Review Request 41884: SAMZA-802: KafkaSystemAdmin needs to handle empty topic offsets
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41884/ --- Review request for samza. Repository: samza Description --- Quick fix to prevent NullPointerException. Diffs - samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemAdmin.scala 9dc436a Diff: https://reviews.apache.org/r/41884/diff/ Testing --- Thanks, Aleksandar Pejakovic
Review Request 40485: SAMZA-767 yarn.queue option is not used anywhere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40485/ --- Review request for samza. Repository: samza Description --- Added missing code from [SAMZA-491](https://issues.apache.org/jira/browse/SAMZA-491) Diffs - samza-yarn/src/main/java/org/apache/samza/config/YarnConfig.java a572aa2 samza-yarn/src/main/scala/org/apache/samza/job/yarn/ClientHelper.scala a2b9279 samza-yarn/src/main/scala/org/apache/samza/job/yarn/YarnJob.scala 02f46a1 Diff: https://reviews.apache.org/r/40485/diff/ Testing --- Thanks, Aleksandar Pejakovic
Review Request 39433: SAMZA-795: Fix getMax() error in Shanpshot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39433/ --- Review request for samza. Repository: samza Description --- Changed: ``` this.size = values.size(); ``` to: ``` this.size = this.values.size(); ``` Diffs - samza-api/src/main/java/org/apache/samza/metrics/Snapshot.java 4c7b525 Diff: https://reviews.apache.org/r/39433/diff/ Testing --- Thanks, Aleksandar Pejakovic
Re: Review Request 38807: SAMZA-338 Support metrics report via STDOUT
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38807/ --- (Updated Oct. 6, 2015, 7:45 a.m.) Review request for samza. Changes --- Tested with hello-samza. Repository: samza Description --- Added support for Console metrics support. This patch is on top of [SAMZA-683](https://issues.apache.org/jira/browse/SAMZA-683). Diffs - build.gradle 682d4f8 docs/learn/documentation/versioned/container/metrics.md 11a62f9 docs/learn/documentation/versioned/jobs/configuration-table.html b42c34c samza-core/src/main/java/org/apache/samza/metrics/reporter/ConsoleReporterFactory.java PRE-CREATION samza-core/src/main/java/org/apache/samza/metrics/reporter/ConsoleReporterWriter.java PRE-CREATION samza-core/src/main/java/org/apache/samza/metrics/reporter/MetricsRegistryReporterMap.java PRE-CREATION samza-core/src/main/java/org/apache/samza/metrics/reporter/ReporterWriter.java PRE-CREATION samza-core/src/main/java/org/apache/samza/metrics/reporter/SamzaConsoleReporter.java PRE-CREATION Diff: https://reviews.apache.org/r/38807/diff/ Testing (updated) --- Tested with hello-samza, works like a charm. Thanks, Aleksandar Pejakovic
Review Request 39045: SAMZA-782: Update all tutorial pages for 0.9.1
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39045/ --- Review request for samza. Repository: samza Description --- Updated tutorial pages for 0.9.1 version. Diffs - docs/learn/tutorials/versioned/deploy-samza-job-from-hdfs.md 77a1e21 docs/learn/tutorials/versioned/deploy-samza-to-CDH.md 8c19150 docs/learn/tutorials/versioned/remote-debugging-samza.md 1af10b9 docs/learn/tutorials/versioned/run-in-multi-node-yarn.md 312efaf Diff: https://reviews.apache.org/r/39045/diff/ Testing --- Thanks, Aleksandar Pejakovic
Review Request 38949: SAMZA-341: Support metrics report via Ganglia
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38949/ --- Review request for samza. Repository: samza-hello-samza Description --- Hello-samza support for Ganglia metric. Diffs - pom.xml 86148ef src/main/assembly/src.xml f57fee2 Diff: https://reviews.apache.org/r/38949/diff/ Testing --- Thanks, Aleksandar Pejakovic
Review Request 38898: SAMZA-781: Upgrade SAMZA to YARN 2.6.1
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38898/ --- Review request for samza. Repository: samza-hello-samza Description --- Upgraded hello-samza to work with yarn 2.6.1. Diffs - bin/grid 8deb76e pom.xml 9804267 Diff: https://reviews.apache.org/r/38898/diff/ Testing --- Thanks, Aleksandar Pejakovic
Review Request 38897: SAMZA-781: Upgrade SAMZA to YARN 2.6.1
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38897/ --- Review request for samza. Repository: samza Description --- Updated yarn to 2.6.1. Tested on hello-samza. Diffs - README.md ce111a2 bin/check-all.sh b1f65e7 docs/learn/tutorials/versioned/run-in-multi-node-yarn.md b286226 gradle/dependency-versions.gradle 9c179e4 samza-test/src/main/python/configs/downloads.json c890e70 samza-test/src/main/python/configs/yarn.json b1492bf Diff: https://reviews.apache.org/r/38897/diff/ Testing --- Thanks, Aleksandar Pejakovic
Re: Review Request 38807: SAMZA-338 Support metrics report via STDOUT
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38807/ --- (Updated Sept. 29, 2015, 2:14 p.m.) Review request for samza. Changes --- Small fix. Updated documentation. Repository: samza Description --- Added support for Console metrics support. This patch is on top of [SAMZA-683](https://issues.apache.org/jira/browse/SAMZA-683). Diffs (updated) - build.gradle 682d4f8 docs/learn/documentation/versioned/container/metrics.md 11a62f9 docs/learn/documentation/versioned/jobs/configuration-table.html b42c34c samza-core/src/main/java/org/apache/samza/metrics/reporter/ConsoleReporterFactory.java PRE-CREATION samza-core/src/main/java/org/apache/samza/metrics/reporter/ConsoleReporterWriter.java PRE-CREATION samza-core/src/main/java/org/apache/samza/metrics/reporter/MetricsRegistryReporterMap.java PRE-CREATION samza-core/src/main/java/org/apache/samza/metrics/reporter/ReporterWriter.java PRE-CREATION samza-core/src/main/java/org/apache/samza/metrics/reporter/SamzaConsoleReporter.java PRE-CREATION Diff: https://reviews.apache.org/r/38807/diff/ Testing --- Thanks, Aleksandar Pejakovic
Review Request 38485: SAMZA-683 add meter and histogram support in the metrics reporter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38485/ --- Review request for samza. Repository: samza Description --- Fixed patch: https://reviews.apache.org/r/35053/ In Meter getMeanRate return numberOfChanges / upTime. We don't have support for oneMinuteRate, fiveMinuteRate nor fifteenMinuteRate - for that we would need to import dropwizards EWMA class. If it's ok to import it will do so. Diffs - samza-api/src/main/java/org/apache/samza/metrics/Histogram.java PRE-CREATION samza-api/src/main/java/org/apache/samza/metrics/Meter.java PRE-CREATION samza-api/src/main/java/org/apache/samza/metrics/MetricsRegistry.java 5a00d01 samza-api/src/main/java/org/apache/samza/metrics/MetricsVisitor.java 75abfe7 samza-api/src/main/java/org/apache/samza/metrics/ReadableMetricsRegistryListener.java 739d68f samza-api/src/main/java/org/apache/samza/util/NoOpMetricsRegistry.java 3df855c samza-core/src/main/scala/org/apache/samza/metrics/MetricsRegistryMap.scala 40ffee2 samza-core/src/main/scala/org/apache/samza/metrics/reporter/JmxReporter.scala e966102 samza-core/src/main/scala/org/apache/samza/metrics/reporter/MetricsSnapshotReporter.scala fb438a4 samza-yarn/src/main/scala/org/apache/samza/webapp/ApplicationMasterRestServlet.scala 09f4dc3 Diff: https://reviews.apache.org/r/38485/diff/ Testing --- Thanks, Aleksandar Pejakovic
Review Request 38296: SAMZA-341: Support metrics report via Ganglia
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38296/ --- Review request for samza. Repository: samza Description --- Added new moduo for Ganglia support. Implemented come is based on [SAMZA-340](https://issues.apache.org/jira/browse/SAMZA-340) Diffs - build.gradle 3a7fabc checkstyle/import-control.xml bc07ae8 docs/learn/documentation/versioned/container/metrics.md 11a62f9 docs/learn/documentation/versioned/jobs/configuration-table.html c23d7d3 gradle/dependency-versions.gradle 36d564b samza-ganglia/src/main/java/org/apache/samza/metrics/reporter/GangliaCounter.java PRE-CREATION samza-ganglia/src/main/java/org/apache/samza/metrics/reporter/GangliaGauge.java PRE-CREATION samza-ganglia/src/main/java/org/apache/samza/metrics/reporter/GangliaReporterFactory.java PRE-CREATION samza-ganglia/src/main/java/org/apache/samza/metrics/reporter/GangliaSnapshot.java PRE-CREATION samza-ganglia/src/main/java/org/apache/samza/metrics/reporter/GangliaTimer.java PRE-CREATION samza-ganglia/src/main/java/org/apache/samza/metrics/reporter/SamzaGangliaReporter.java PRE-CREATION samza-ganglia/src/test/java/org/apache/samza/metrics/reporter/GangliaCounterTest.java PRE-CREATION samza-ganglia/src/test/java/org/apache/samza/metrics/reporter/GangliaGaugeTest.java PRE-CREATION samza-ganglia/src/test/java/org/apache/samza/metrics/reporter/GangliaReporterTest.java PRE-CREATION samza-ganglia/src/test/java/org/apache/samza/metrics/reporter/GangliaSnapshotTest.java PRE-CREATION samza-ganglia/src/test/java/org/apache/samza/metrics/reporter/GangliaTimerTest.java PRE-CREATION settings.gradle 4c1aa10 Diff: https://reviews.apache.org/r/38296/diff/ Testing --- Thanks, Aleksandar Pejakovic
Review Request 37942: SAMZA-766 Fix broken links in samza-container.html
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37942/ --- Review request for samza. Repository: samza Description --- Changed link for SystemStreamPartitionGrouper and removed link for GroupBySystemStreamPartition (it's located in samza-core and we are only showing javadoc for samza-api). Diffs - docs/learn/documentation/versioned/container/samza-container.md f97e8a3 Diff: https://reviews.apache.org/r/37942/diff/ Testing --- Thanks, Aleksandar Pejakovic
Review Request 37843: SAMZA-764 Change java version in hello-samza
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37843/ --- Review request for samza. Repository: samza-hello-samza Description --- Changed version of hello-samza to follow samza. Diffs - pom.xml 0e3bf5f Diff: https://reviews.apache.org/r/37843/diff/ Testing --- Thanks, Aleksandar Pejakovic
Review Request 37796: SAMZA-763 Organise imports in scala packages
samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterMetrics.scala 03acfe1 samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterService.scala 0605386 samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterState.scala f667c83 samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterTaskManager.scala 1743c86 samza-yarn/src/main/scala/org/apache/samza/job/yarn/YarnAppMasterListener.scala 6bf3046 samza-yarn/src/main/scala/org/apache/samza/job/yarn/YarnContainer.scala 7ab866f samza-yarn/src/main/scala/org/apache/samza/job/yarn/YarnJob.scala 8dd70c9 samza-yarn/src/main/scala/org/apache/samza/job/yarn/YarnJobFactory.scala 4e328a5 samza-yarn/src/main/scala/org/apache/samza/util/hadoop/HttpFileSystem.scala 7dff90e samza-yarn/src/main/scala/org/apache/samza/util/hadoop/HttpInputStream.scala a5458fb samza-yarn/src/main/scala/org/apache/samza/webapp/ApplicationMasterRestServlet.scala 09f4dc3 samza-yarn/src/main/scala/org/apache/samza/webapp/ApplicationMasterWebServlet.scala 7fd5122 samza-yarn/src/test/scala/org/apache/samza/job/yarn/TestSamzaAppMaster.scala 7b7d86a samza-yarn/src/test/scala/org/apache/samza/job/yarn/TestSamzaAppMasterLifecycle.scala df5992e samza-yarn/src/test/scala/org/apache/samza/job/yarn/TestSamzaAppMasterService.scala 6f4bfaf samza-yarn/src/test/scala/org/apache/samza/job/yarn/TestSamzaAppMasterTaskManager.scala 2eec65f Diff: https://reviews.apache.org/r/37796/diff/ Testing --- Thanks, Aleksandar Pejakovic
Re: Review Request 36727: SAMZA-563 Upgrade Samza to YARN 2.6.0
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36727/ --- (Updated Aug. 21, 2015, 7:37 a.m.) Review request for samza. Changes --- Changed YARN version to 2.6.0 instead of 2.7.1 Repository: samza Description --- Upgraded version of yarn in samza. Diffs (updated) - README.md c736669 bin/check-all.sh 67bf776 docs/learn/tutorials/versioned/run-in-multi-node-yarn.md 7a9fdf4 gradle/dependency-versions.gradle fb06e8e samza-test/src/main/python/configs/downloads.json a75756f samza-test/src/main/python/configs/yarn.json 9b0143d samza-yarn/src/test/scala/org/apache/samza/job/yarn/TestSamzaAppMasterLifecycle.scala df5992e samza-yarn/src/test/scala/org/apache/samza/job/yarn/TestSamzaAppMasterTaskManager.scala 1e936b4 Diff: https://reviews.apache.org/r/36727/diff/ Testing (updated) --- Changed samza-yarn - TestSamzaAppMaster - testAppMasterShouldReboot, now all tests pass. Thanks, Aleksandar Pejakovic
Re: Review Request 36728: HELLO-SAMZA-563 Upgrade Samza to YARN 2.6.0
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36728/ --- (Updated Aug. 21, 2015, 7:38 a.m.) Review request for samza. Changes --- Changed YARN version to 2.6.0 instead of 2.7.1 Repository: samza-hello-samza Description --- Changed version of hadoop-yarn. Diffs (updated) - bin/grid a639ade pom.xml 0e3bf5f Diff: https://reviews.apache.org/r/36728/diff/ Testing --- Tried all three jobs, they all ran nicely. Thanks, Aleksandar Pejakovic
Re: Review Request 37528: SAMZA-736 BrokerProxy will stuck in infinite loop if consumer.fetch throws OOME
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37528/ --- (Updated Aug. 21, 2015, 7:30 a.m.) Review request for samza. Changes --- Removed trailing white space. Repository: samza Description --- Added new catch blocks to prevent infinite loops Diffs (updated) - samza-core/src/main/scala/org/apache/samza/util/ExponentialSleepStrategy.scala 376b277 samza-kafka/src/main/scala/org/apache/samza/system/kafka/BrokerProxy.scala 614f33f samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestBrokerProxy.scala e285dec Diff: https://reviews.apache.org/r/37528/diff/ Testing --- Thanks, Aleksandar Pejakovic
Re: Review Request 37642: SAMZA-695 Update the StreamAppender doc
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37642/ --- (Updated Aug. 21, 2015, 7:23 a.m.) Review request for samza. Changes --- Fixed patch Repository: samza Description (updated) --- Added requested param to logging.md - fixed Diffs (updated) - docs/learn/documentation/versioned/jobs/logging.md d1b372c Diff: https://reviews.apache.org/r/37642/diff/ Testing --- Thanks, Aleksandar Pejakovic
Re: Review Request 37528: SAMZA-736 BrokerProxy will stuck in infinite loop if consumer.fetch throws OOME
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37528/ --- (Updated Aug. 19, 2015, 9:03 a.m.) Review request for samza. Changes --- Fixed test for OOME and SOE exceptions in broker proxy Repository: samza Description --- Added new catch blocks to prevent infinite loops Diffs (updated) - samza-core/src/main/scala/org/apache/samza/util/ExponentialSleepStrategy.scala 376b277 samza-kafka/src/main/scala/org/apache/samza/system/kafka/BrokerProxy.scala 614f33f samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestBrokerProxy.scala e285dec Diff: https://reviews.apache.org/r/37528/diff/ Testing --- Thanks, Aleksandar Pejakovic
Re: Review Request 37528: SAMZA-736 BrokerProxy will stuck in infinite loop if consumer.fetch throws OOME
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37528/ --- (Updated Aug. 18, 2015, 12:58 p.m.) Review request for samza. Changes --- Added test for OOME and SOE in TestBrokerProxy Repository: samza Description --- Added new catch blocks to prevent infinite loops Diffs (updated) - samza-core/src/main/scala/org/apache/samza/util/ExponentialSleepStrategy.scala 376b277 samza-kafka/src/main/scala/org/apache/samza/system/kafka/BrokerProxy.scala 614f33f samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestBrokerProxy.scala e285dec Diff: https://reviews.apache.org/r/37528/diff/ Testing --- Thanks, Aleksandar Pejakovic
Review Request 37528: SAMZA-736 BrokerProxy will stuck in infinite loop if consumer.fetch throws OOME
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37528/ --- Review request for samza. Repository: samza Description --- Added new catch blocks to prevent infinite loops Diffs - samza-core/src/main/scala/org/apache/samza/util/ExponentialSleepStrategy.scala 376b277 samza-kafka/src/main/scala/org/apache/samza/system/kafka/BrokerProxy.scala 614f33f Diff: https://reviews.apache.org/r/37528/diff/ Testing --- Thanks, Aleksandar Pejakovic
I have a problem with Samza and YARN
Hi all, I have problem with YARN 2.6.0. For this patch: https://issues.apache.org/jira/browse/SAMZA-563 i tried to change samza with hello-samza to work on YARN 2.6.0. All tests in samza pass nicely but when i try to run bin/grid bootstrap from hello-samza there are some problems with starting ResourceManager and Node Manager. I also tried to upgrade samza and hello-samza to 2.7.1 and then it has no problems with RM nor NM. On 2.7.1 ewerything works just nicely. Does anyone know what the possible problem may be?
Re: Review Request 37069: SAMZA-738 Samza Timer based metrics does not have enough precision
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37069/
---
(Updated Aug. 5, 2015, 2:58 p.m.)
Review request for samza.
Changes
---
Fixed test
Repository: samza
Description
---
Changed SystemProducersMetrics and RunLoop so that metrics now show nanoseconds
instead milliseconds.
Diffs (updated)
-
samza-core/src/main/scala/org/apache/samza/container/RunLoop.scala c292ae4
samza-core/src/main/scala/org/apache/samza/container/SamzaContainerMetrics.scala
aa7a9bc
samza-core/src/main/scala/org/apache/samza/util/TimerUtils.scala 1643070
samza-core/src/test/scala/org/apache/samza/container/TestRunLoop.scala
64a5844
samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemProducer.scala
39c54aa
samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemProducerMetrics.scala
8aa73ce
Diff: https://reviews.apache.org/r/37069/diff/
Testing
---
Tested on hello-samza - wikipedia-parser, results:
```
org.apache.samza.container.SamzaContainerMetrics:{
commit-calls:10,
window-ns:3198.62544796632,
process-null-envelopes:56292,
process-envelopes:989,
window-calls:0,
commit-ns:5130.901534393375,
send-calls:0,
process-calls:57283,
choose-ns:10368839.818551894,
process-ns:10390588.194071393,
event-loop-utilization:0.99807554
}
```
Thanks,
Aleksandar Pejakovic
Review Request 37069: SAMZA-738 Samza Timer based metrics does not have enough precision
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37069/
---
Review request for samza.
Repository: samza
Description
---
Changed SystemProducersMetrics and RunLoop so that metrics now show nanoseconds
instead milliseconds.
Diffs
-
samza-core/src/main/scala/org/apache/samza/container/RunLoop.scala c292ae4
samza-core/src/main/scala/org/apache/samza/container/SamzaContainerMetrics.scala
aa7a9bc
Diff: https://reviews.apache.org/r/37069/diff/
Testing
---
Tested on hello-samza - wikipedia-parser, results:
```
org.apache.samza.container.SamzaContainerMetrics:{
commit-calls:10,
window-ns:3198.62544796632,
process-null-envelopes:56292,
process-envelopes:989,
window-calls:0,
commit-ns:5130.901534393375,
send-calls:0,
process-calls:57283,
choose-ns:10368839.818551894,
process-ns:10390588.194071393,
event-loop-utilization:0.99807554
}
```
Thanks,
Aleksandar Pejakovic
Re: Review Request 37069: SAMZA-738 Samza Timer based metrics does not have enough precision
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37069/
---
(Updated Aug. 4, 2015, 9:18 a.m.)
Review request for samza.
Changes
---
Fixed typo.
Repository: samza
Description
---
Changed SystemProducersMetrics and RunLoop so that metrics now show nanoseconds
instead milliseconds.
Diffs (updated)
-
samza-core/src/main/scala/org/apache/samza/container/RunLoop.scala c292ae4
samza-core/src/main/scala/org/apache/samza/container/SamzaContainerMetrics.scala
aa7a9bc
Diff: https://reviews.apache.org/r/37069/diff/
Testing
---
Tested on hello-samza - wikipedia-parser, results:
```
org.apache.samza.container.SamzaContainerMetrics:{
commit-calls:10,
window-ns:3198.62544796632,
process-null-envelopes:56292,
process-envelopes:989,
window-calls:0,
commit-ns:5130.901534393375,
send-calls:0,
process-calls:57283,
choose-ns:10368839.818551894,
process-ns:10390588.194071393,
event-loop-utilization:0.99807554
}
```
Thanks,
Aleksandar Pejakovic
Re: Review Request 36727: SAMZA-563 Upgrade Samza to YARN 2.6.0
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36727/ --- (Updated July 29, 2015, 8:39 a.m.) Review request for samza. Changes --- Fixed test in samza-yarn - TestSamzaAppMaster - testAppMasterShouldReboot - changed allocate method in TestAMRMClientImpl to throw ApplicationAttemptNotFoundException if reboot is set to true Repository: samza Description --- Upgraded version of yarn in samza. Diffs (updated) - bin/check-all.sh 67bf776 docs/contribute/tests.md f485ce2 docs/learn/tutorials/versioned/run-in-multi-node-yarn.md 312efaf gradle/dependency-versions.gradle fb06e8e samza-test/src/main/python/configs/downloads.json a75756f samza-test/src/main/python/configs/yarn.json 9b0143d samza-yarn/src/test/scala/org/apache/samza/job/yarn/TestSamzaAppMaster.scala 7b7d86a samza-yarn/src/test/scala/org/apache/samza/job/yarn/TestSamzaAppMasterLifecycle.scala df5992e samza-yarn/src/test/scala/org/apache/samza/job/yarn/TestSamzaAppMasterTaskManager.scala 1e936b4 Diff: https://reviews.apache.org/r/36727/diff/ Testing --- All test except one in samza-yarn - TestSamzaAppMaster - testAppMasterShouldReboot pass. - because of: [YARN-1365](https://issues.apache.org/jira/browse/YARN-1365), [YARN-1366](https://issues.apache.org/jira/browse/YARN-1366) and [YARN-1367](https://issues.apache.org/jira/browse/YARN-1366) they changed: - AMRMClientAsyncImpl.java - private class HeartbeatThread. It's method run() no longer catches ApplicationMasterNotRegisteredException (replacement for AMCommand.AM_RESYNC) and no longer does resyncing. Without that test everything works just fine. Tried hello-samza, works fine. Thanks, Aleksandar Pejakovic
Review Request 36769: SAMZA-742 Add a Contribution section in README of samza and hello-samza
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36769/ --- Review request for samza. Repository: samza Description --- Added Contribution section to README Diffs - README.md f83fd41 Diff: https://reviews.apache.org/r/36769/diff/ Testing --- Thanks, Aleksandar Pejakovic
Review Request 36770: SAMZA-742 Add a Contribution section in README of samza and hello-samza
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36770/ --- Review request for samza. Repository: samza-hello-samza Description --- Hello Samza: added Contribution section to README Diffs - README.md 14bf45e Diff: https://reviews.apache.org/r/36770/diff/ Testing --- Thanks, Aleksandar Pejakovic
Review Request 36728: HELLO-SAMZA-563 Upgrade Samza to YARN 2.6.0
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36728/ --- Review request for samza. Repository: samza-hello-samza Description --- Changed version of hadoop-yarn. Diffs - bin/grid 3d0e66e pom.xml f9c4fa9 Diff: https://reviews.apache.org/r/36728/diff/ Testing --- Tried all three jobs, they all ran nicely. Thanks, Aleksandar Pejakovic
Review Request 36641: SAMZA-739 Change version of hello-samza in SAMZA tutorials/latest
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36641/ --- Review request for samza. Repository: samza Description --- Changed version of hello-samza in SAMZA/tutorials from 0.8.0 to 0.9.1. Diffs - docs/learn/tutorials/versioned/deploy-samza-job-from-hdfs.md 77a1e21 docs/learn/tutorials/versioned/deploy-samza-to-CDH.md 8c19150 docs/learn/tutorials/versioned/remote-debugging-samza.md 5f4f993 docs/learn/tutorials/versioned/run-in-multi-node-yarn.md 312efaf Diff: https://reviews.apache.org/r/36641/diff/ Testing --- Thanks, Aleksandar Pejakovic
Review Request 36507: SAMZA-734 Remove redundant Dashboard
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36507/ --- Review request for samza. Repository: samza Description --- Removed redundant Dashboard in [Yarn/Application Master](http://samza.apache.org/learn/documentation/latest/yarn/application-master.html) and corrected [Jobs/Configuration Table](http://samza.apache.org/learn/documentation/latest/jobs/configuration-table.html) Diffs - docs/learn/documentation/versioned/jobs/configuration-table.html cd7ea8d docs/learn/documentation/versioned/yarn/application-master.md d20aece Diff: https://reviews.apache.org/r/36507/diff/ Testing --- Thanks, Aleksandar Pejakovic
Re: Review Request 35644: SAMZA-718 Update links in README.md
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35644/ --- (Updated June 20, 2015, 8:18 a.m.) Review request for samza. Changes --- Changed from latest to 0.9 Repository: samza-hello-samza Description (updated) --- Changed links from: http://samza.apache.org/startup/hello-samza/0.8/ to http://samza.apache.org/startup/hello-samza/0.9/ Diffs (updated) - README.md 4463454 Diff: https://reviews.apache.org/r/35644/diff/ Testing --- Thanks, Aleksandar Pejakovic
Review Request 35644: SAMZA-718 Update links in README.md
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35644/ --- Review request for samza. Repository: samza-hello-samza Description --- Changed links from: http://samza.apache.org/startup/hello-samza/0.8/ to http://samza.apache.org/startup/hello-samza/latest/ Diffs - README.md 4463454 Diff: https://reviews.apache.org/r/35644/diff/ Testing --- Thanks, Aleksandar Pejakovic
Review Request 35598: SAMZA-563 Upgrade Hello - Samza to YARN 2.6.0
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35598/ --- Review request for samza. Repository: samza-hello-samza Description --- Changed bin/grid script and pom.xml file in samza-hello-samza to use hadoop 2.6.0 instead of 2.4.0. Diffs - bin/grid a639ade pom.xml 0e3bf5f Diff: https://reviews.apache.org/r/35598/diff/ Testing --- Thanks, Aleksandar Pejakovic
Review Request 35115: SAMZA-474 check-all script should fail more gracefully in the absence of gradlew
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35115/ --- Review request for samza. Repository: samza Description --- Improvement for issue [SAMZA-474](https://issues.apache.org/jira/browse/SAMZA-474) added check search for gradlew, if not present it will use currently installed gradle. Diffs - bin/check-all.sh 0725b82 Diff: https://reviews.apache.org/r/35115/diff/ Testing --- Thanks, Aleksandar Pejakovic
