[GitHub] [incubator-sdap-nexus] tloubrieu-jpl commented on a change in pull request #101: SDAP-249 : add solr time out client argument to webapp, use it in the data acces…

[GitBox]

tloubrieu-jpl commented on a change in pull request #101:
URL: 
https://github.com/apache/incubator-sdap-nexus/pull/101#discussion_r443916050



##
File path: analysis/webservice/webapp.py
##
@@ -156,6 +155,23 @@ def async_callback(self, result):
 if hasattr(result, 'cleanup'):
 result.cleanup()
 
+def inject_args_in_config(args, config):
+"""
+Takes command argparse arguments and push them in the config
+ with syntax args._
+"""
+for _, t_opt in args._options.items():

Review comment:
   Ok, done





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-sdap-nexus] tloubrieu-jpl commented on a change in pull request #101: SDAP-249 : add solr time out client argument to webapp, use it in the data acces…

[GitBox]

tloubrieu-jpl commented on a change in pull request #101:
URL: 
https://github.com/apache/incubator-sdap-nexus/pull/101#discussion_r443915590



##
File path: analysis/webservice/algorithms/doms/DomsInitialization.py
##
@@ -49,6 +49,7 @@ def init(self, config):
 log.info("Cassandra Protocol Version: %s" % (cassVersion))
 
 dc_policy = DCAwareRoundRobinPolicy(cassDatacenter)
+#dc_policy = WhiteListRoundRobinPolicy([cassHost])

Review comment:
   ok, I did that.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-sdap-ingester] eamonford merged pull request #2: Add granule ingester code to this repo

[GitBox]

eamonford merged pull request #2:
URL: https://github.com/apache/incubator-sdap-ingester/pull/2


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-sdap-ingester] eamonford commented on pull request #2: Add granule ingester code to this repo

[GitBox]

eamonford commented on pull request #2:
URL: 
https://github.com/apache/incubator-sdap-ingester/pull/2#issuecomment-647831077


   I will add some documentation to the readme file.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-sdap-ingester] eamonford commented on pull request #2: Add granule ingester code to this repo

[GitBox]

eamonford commented on pull request #2:
URL: 
https://github.com/apache/incubator-sdap-ingester/pull/2#issuecomment-647830877


   @tloubrieu-jpl the reason there is both `conda_requirements.txt` and 
`requirements.txt` is because:
   1) `setup.py` is using conda instead of pip to install most of the 
requirements in this package because some of them (like numpy) have fairly 
large underlying dependencies which are better to install using conda, which 
will make sure all the OS libraries are installed as well. Pip does not install 
OS library components.
   2) Not all the requirements for this package are available in conda, which 
is why there are 3 requirements listed in `requirements.txt`. These will be 
installed using pip by `setup.py`.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-sdap-ingester] eamonford opened a new pull request #4: SDAP-237 Dockerize Collection Manager

[GitBox]

eamonford opened a new pull request #4:
URL: https://github.com/apache/incubator-sdap-ingester/pull/4


   https://issues.apache.org/jira/browse/SDAP-237



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-sdap-ingester] eamonford merged pull request #3: Bug fixes

[GitBox]

eamonford merged pull request #3:
URL: https://github.com/apache/incubator-sdap-ingester/pull/3


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-sdap-nexus] eamonford closed pull request #48: SDAP-158 changes from SDAP-149 + Spark imaging algorithms

[GitBox]

eamonford closed pull request #48:
URL: https://github.com/apache/incubator-sdap-nexus/pull/48


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-sdap-nexus] eamonford closed pull request #8: SDAP-40 Update Spark Time Series algorithm to handle multiple time steps per tile

[GitBox]

eamonford closed pull request #8:
URL: https://github.com/apache/incubator-sdap-nexus/pull/8


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-sdap-nexus] eamonford closed pull request #52: SDAP-149: Generate images directly from data

[GitBox]

eamonford closed pull request #52:
URL: https://github.com/apache/incubator-sdap-nexus/pull/52


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-sdap-nexus] eamonford merged pull request #102: SDAP-253 MaximaMinima Algorithm

[GitBox]

eamonford merged pull request #102:
URL: https://github.com/apache/incubator-sdap-nexus/pull/102


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-sdap-nexus] eamonford merged pull request #98: Performance metrics logging

[GitBox]

eamonford merged pull request #98:
URL: https://github.com/apache/incubator-sdap-nexus/pull/98


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-sdap-ingester] eamonford opened a new pull request #3: Bug fixes

[GitBox]

eamonford opened a new pull request #3:
URL: https://github.com/apache/incubator-sdap-ingester/pull/3


   This PR fixes the following bugs:
   https://issues.apache.org/jira/browse/SDAP-254
   https://issues.apache.org/jira/browse/SDAP-255
   https://issues.apache.org/jira/browse/SDAP-256



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-sdap-nexus] mayadebellis opened a new pull request #102: SDAP-253 MaximaMinima Algorithm

[GitBox]

mayadebellis opened a new pull request #102:
URL: https://github.com/apache/incubator-sdap-nexus/pull/102


   Specified by ECCO scientists
   
   /maxMin will return a map of maxima and minima as well as a map of the 
maxima and minima of the absolute values of the data
   
   Ticket: https://issues.apache.org/jira/browse/SDAP-253



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-sdap-ingester] eamonford commented on a change in pull request #1: SDAP-234: Test suite

[GitBox]

eamonford commented on a change in pull request #1:
URL: 
https://github.com/apache/incubator-sdap-ingester/pull/1#discussion_r442537902



##
File path: collection_manager/tests/services/test_CollectionWatcher.py
##
@@ -0,0 +1,203 @@
+import os
+import tempfile
+import time
+import unittest
+from datetime import datetime
+from unittest.mock import Mock
+
+from collection_manager.entities import Collection
+from collection_manager.entities.exceptions import YamlParsingError, 
CollectionConfigFileNotFoundError, \
+RelativePathCollectionError, ConflictingPathCollectionError
+from collection_manager.services import CollectionWatcher
+
+
+class TestCollectionWatcher(unittest.TestCase):
+
+def test_collections_returns_all_collections(self):
+collection_watcher = CollectionWatcher('/foo', Mock(), Mock())
+collection_watcher._collections_by_dir = {
+"/foo": {
+Collection("id1", "var1", "path1", 1, 2, datetime.now(), 
datetime.now()),
+Collection("id2", "var2", "path2", 3, 4, datetime.now(), 
datetime.now()),
+},
+"/bar": {
+Collection("id3", "var3", "path3", 5, 6, datetime.now(), 
datetime.now()),
+Collection("id4", "var4", "path4", 7, 8, datetime.now(), 
datetime.now()),
+}
+}
+flattened_collections = collection_watcher.collections()
+self.assertEqual(len(flattened_collections), 4)
+
+def test_load_collections_loads_all_collections(self):
+collections_path = os.path.join(os.path.dirname(__file__), 
'../resources/collections.yml')
+collection_watcher = CollectionWatcher(collections_path, Mock(), 
Mock())
+collection_watcher._load_collections()
+
+self.assertEquals(len(collection_watcher._collections_by_dir), 2)
+
self.assertEquals(len(collection_watcher._collections_by_dir['/opt/data/grace']),
 2)
+
self.assertEquals(len(collection_watcher._collections_by_dir['/opt/data/avhrr']),
 1)
+
+def test_load_collections_with_bad_yaml_syntax(self):
+collections_path = os.path.join(os.path.dirname(__file__), 
'../resources/collections_bad.yml')
+collection_watcher = CollectionWatcher(collections_path, Mock(), 
Mock())
+
+self.assertRaises(YamlParsingError, 
collection_watcher._load_collections)
+
+def test_load_collections_with_file_not_found(self):
+collections_path = os.path.join(os.path.dirname(__file__), 
'../resources/does_not_exist.yml')
+collection_watcher = CollectionWatcher(collections_path, Mock(), 
Mock())
+
+self.assertRaises(CollectionConfigFileNotFoundError, 
collection_watcher._load_collections)
+
+def test_get_updated_collections_returns_all_collections(self):
+collections_path = os.path.join(os.path.dirname(__file__), 
'../resources/collections.yml')
+collection_watcher = CollectionWatcher(collections_path, Mock(), 
Mock())
+
+updated_collections = collection_watcher._get_updated_collections()
+self.assertSetEqual(updated_collections, 
collection_watcher.collections())
+
+def test_get_updated_collections_returns_no_collections(self):
+collections_path = os.path.join(os.path.dirname(__file__), 
'../resources/collections.yml')
+collection_watcher = CollectionWatcher(collections_path, Mock(), 
Mock())
+collection_watcher._load_collections()
+updated_collections = collection_watcher._get_updated_collections()
+
+self.assertEquals(len(updated_collections), 0)
+
+def test_get_updated_collections_returns_some_collections(self):
+collections_path = os.path.join(os.path.dirname(__file__), 
'../resources/collections.yml')
+collection_watcher = CollectionWatcher(collections_path, Mock(), 
Mock())
+collection_watcher._load_collections()
+
+new_collections_path = os.path.join(os.path.dirname(__file__), 
'../resources/collections_alternate.yml')
+collection_watcher._collections_path = new_collections_path
+updated_collections = collection_watcher._get_updated_collections()
+
+self.assertEquals(len(updated_collections), 1)
+
+def test_validate_collection(self):
+collections_path = os.path.join(os.path.dirname(__file__), 
'../resources/collections.yml')
+collection_watcher = CollectionWatcher(collections_path, Mock(), 
Mock())
+
+collection = Collection(dataset_id="test_dataset",
+path="/absolute/path",
+variable="test_variable",
+historical_priority=1,
+forward_processing_priority=2,
+date_from=None,
+date_to=None)
+collection_watcher._validate_collection(collection)
+
+def test_validate_collection_with_relative_path(self):
+collections_path = 

[GitHub] [incubator-sdap-ingester] tloubrieu-jpl commented on a change in pull request #1: SDAP-234: Test suite

[GitBox]

tloubrieu-jpl commented on a change in pull request #1:
URL: 
https://github.com/apache/incubator-sdap-ingester/pull/1#discussion_r442537460



##
File path: collection_manager/tests/services/test_CollectionWatcher.py
##
@@ -0,0 +1,203 @@
+import os
+import tempfile
+import time
+import unittest
+from datetime import datetime
+from unittest.mock import Mock
+
+from collection_manager.entities import Collection
+from collection_manager.entities.exceptions import YamlParsingError, 
CollectionConfigFileNotFoundError, \
+RelativePathCollectionError, ConflictingPathCollectionError
+from collection_manager.services import CollectionWatcher
+
+
+class TestCollectionWatcher(unittest.TestCase):
+
+def test_collections_returns_all_collections(self):
+collection_watcher = CollectionWatcher('/foo', Mock(), Mock())
+collection_watcher._collections_by_dir = {
+"/foo": {
+Collection("id1", "var1", "path1", 1, 2, datetime.now(), 
datetime.now()),
+Collection("id2", "var2", "path2", 3, 4, datetime.now(), 
datetime.now()),
+},
+"/bar": {
+Collection("id3", "var3", "path3", 5, 6, datetime.now(), 
datetime.now()),
+Collection("id4", "var4", "path4", 7, 8, datetime.now(), 
datetime.now()),
+}
+}
+flattened_collections = collection_watcher.collections()
+self.assertEqual(len(flattened_collections), 4)
+
+def test_load_collections_loads_all_collections(self):
+collections_path = os.path.join(os.path.dirname(__file__), 
'../resources/collections.yml')
+collection_watcher = CollectionWatcher(collections_path, Mock(), 
Mock())
+collection_watcher._load_collections()
+
+self.assertEquals(len(collection_watcher._collections_by_dir), 2)
+
self.assertEquals(len(collection_watcher._collections_by_dir['/opt/data/grace']),
 2)
+
self.assertEquals(len(collection_watcher._collections_by_dir['/opt/data/avhrr']),
 1)
+
+def test_load_collections_with_bad_yaml_syntax(self):
+collections_path = os.path.join(os.path.dirname(__file__), 
'../resources/collections_bad.yml')
+collection_watcher = CollectionWatcher(collections_path, Mock(), 
Mock())
+
+self.assertRaises(YamlParsingError, 
collection_watcher._load_collections)
+
+def test_load_collections_with_file_not_found(self):
+collections_path = os.path.join(os.path.dirname(__file__), 
'../resources/does_not_exist.yml')
+collection_watcher = CollectionWatcher(collections_path, Mock(), 
Mock())
+
+self.assertRaises(CollectionConfigFileNotFoundError, 
collection_watcher._load_collections)
+
+def test_get_updated_collections_returns_all_collections(self):
+collections_path = os.path.join(os.path.dirname(__file__), 
'../resources/collections.yml')
+collection_watcher = CollectionWatcher(collections_path, Mock(), 
Mock())
+
+updated_collections = collection_watcher._get_updated_collections()
+self.assertSetEqual(updated_collections, 
collection_watcher.collections())
+
+def test_get_updated_collections_returns_no_collections(self):
+collections_path = os.path.join(os.path.dirname(__file__), 
'../resources/collections.yml')
+collection_watcher = CollectionWatcher(collections_path, Mock(), 
Mock())
+collection_watcher._load_collections()
+updated_collections = collection_watcher._get_updated_collections()
+
+self.assertEquals(len(updated_collections), 0)
+
+def test_get_updated_collections_returns_some_collections(self):
+collections_path = os.path.join(os.path.dirname(__file__), 
'../resources/collections.yml')
+collection_watcher = CollectionWatcher(collections_path, Mock(), 
Mock())
+collection_watcher._load_collections()
+
+new_collections_path = os.path.join(os.path.dirname(__file__), 
'../resources/collections_alternate.yml')
+collection_watcher._collections_path = new_collections_path
+updated_collections = collection_watcher._get_updated_collections()
+
+self.assertEquals(len(updated_collections), 1)
+
+def test_validate_collection(self):
+collections_path = os.path.join(os.path.dirname(__file__), 
'../resources/collections.yml')
+collection_watcher = CollectionWatcher(collections_path, Mock(), 
Mock())
+
+collection = Collection(dataset_id="test_dataset",
+path="/absolute/path",
+variable="test_variable",
+historical_priority=1,
+forward_processing_priority=2,
+date_from=None,
+date_to=None)
+collection_watcher._validate_collection(collection)
+
+def test_validate_collection_with_relative_path(self):
+collections_path = 

[GitHub] [incubator-sdap-ingester] eamonford commented on a change in pull request #1: SDAP-234: Test suite

[GitBox]

eamonford commented on a change in pull request #1:
URL: 
https://github.com/apache/incubator-sdap-ingester/pull/1#discussion_r441902633



##
File path: collection_manager/tests/services/test_CollectionWatcher.py
##
@@ -0,0 +1,203 @@
+import os
+import tempfile
+import time
+import unittest
+from datetime import datetime
+from unittest.mock import Mock
+
+from collection_manager.entities import Collection
+from collection_manager.entities.exceptions import YamlParsingError, 
CollectionConfigFileNotFoundError, \
+RelativePathCollectionError, ConflictingPathCollectionError
+from collection_manager.services import CollectionWatcher
+
+
+class TestCollectionWatcher(unittest.TestCase):
+
+def test_collections_returns_all_collections(self):
+collection_watcher = CollectionWatcher('/foo', Mock(), Mock())
+collection_watcher._collections_by_dir = {
+"/foo": {
+Collection("id1", "var1", "path1", 1, 2, datetime.now(), 
datetime.now()),
+Collection("id2", "var2", "path2", 3, 4, datetime.now(), 
datetime.now()),
+},
+"/bar": {
+Collection("id3", "var3", "path3", 5, 6, datetime.now(), 
datetime.now()),
+Collection("id4", "var4", "path4", 7, 8, datetime.now(), 
datetime.now()),
+}
+}
+flattened_collections = collection_watcher.collections()
+self.assertEqual(len(flattened_collections), 4)
+
+def test_load_collections_loads_all_collections(self):
+collections_path = os.path.join(os.path.dirname(__file__), 
'../resources/collections.yml')
+collection_watcher = CollectionWatcher(collections_path, Mock(), 
Mock())
+collection_watcher._load_collections()
+
+self.assertEquals(len(collection_watcher._collections_by_dir), 2)
+
self.assertEquals(len(collection_watcher._collections_by_dir['/opt/data/grace']),
 2)
+
self.assertEquals(len(collection_watcher._collections_by_dir['/opt/data/avhrr']),
 1)
+
+def test_load_collections_with_bad_yaml_syntax(self):
+collections_path = os.path.join(os.path.dirname(__file__), 
'../resources/collections_bad.yml')
+collection_watcher = CollectionWatcher(collections_path, Mock(), 
Mock())
+
+self.assertRaises(YamlParsingError, 
collection_watcher._load_collections)
+
+def test_load_collections_with_file_not_found(self):
+collections_path = os.path.join(os.path.dirname(__file__), 
'../resources/does_not_exist.yml')
+collection_watcher = CollectionWatcher(collections_path, Mock(), 
Mock())
+
+self.assertRaises(CollectionConfigFileNotFoundError, 
collection_watcher._load_collections)
+
+def test_get_updated_collections_returns_all_collections(self):
+collections_path = os.path.join(os.path.dirname(__file__), 
'../resources/collections.yml')
+collection_watcher = CollectionWatcher(collections_path, Mock(), 
Mock())
+
+updated_collections = collection_watcher._get_updated_collections()
+self.assertSetEqual(updated_collections, 
collection_watcher.collections())
+
+def test_get_updated_collections_returns_no_collections(self):
+collections_path = os.path.join(os.path.dirname(__file__), 
'../resources/collections.yml')
+collection_watcher = CollectionWatcher(collections_path, Mock(), 
Mock())
+collection_watcher._load_collections()
+updated_collections = collection_watcher._get_updated_collections()
+
+self.assertEquals(len(updated_collections), 0)
+
+def test_get_updated_collections_returns_some_collections(self):
+collections_path = os.path.join(os.path.dirname(__file__), 
'../resources/collections.yml')
+collection_watcher = CollectionWatcher(collections_path, Mock(), 
Mock())
+collection_watcher._load_collections()
+
+new_collections_path = os.path.join(os.path.dirname(__file__), 
'../resources/collections_alternate.yml')
+collection_watcher._collections_path = new_collections_path
+updated_collections = collection_watcher._get_updated_collections()
+
+self.assertEquals(len(updated_collections), 1)
+
+def test_validate_collection(self):
+collections_path = os.path.join(os.path.dirname(__file__), 
'../resources/collections.yml')
+collection_watcher = CollectionWatcher(collections_path, Mock(), 
Mock())
+
+collection = Collection(dataset_id="test_dataset",
+path="/absolute/path",
+variable="test_variable",
+historical_priority=1,
+forward_processing_priority=2,
+date_from=None,
+date_to=None)
+collection_watcher._validate_collection(collection)
+
+def test_validate_collection_with_relative_path(self):
+collections_path = 

[GitHub] [incubator-sdap-ingester] eamonford opened a new pull request #2: Add granule ingester code to this repo

[GitBox]

eamonford opened a new pull request #2:
URL: https://github.com/apache/incubator-sdap-ingester/pull/2


   https://issues.apache.org/jira/browse/SDAP-245



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-sdap-ingester] tloubrieu-jpl commented on a change in pull request #1: SDAP-234: Test suite

[GitBox]

tloubrieu-jpl commented on a change in pull request #1:
URL: 
https://github.com/apache/incubator-sdap-ingester/pull/1#discussion_r441176767



##
File path: collection_manager/tests/services/test_CollectionWatcher.py
##
@@ -0,0 +1,203 @@
+import os
+import tempfile
+import time
+import unittest
+from datetime import datetime
+from unittest.mock import Mock
+
+from collection_manager.entities import Collection
+from collection_manager.entities.exceptions import YamlParsingError, 
CollectionConfigFileNotFoundError, \
+RelativePathCollectionError, ConflictingPathCollectionError
+from collection_manager.services import CollectionWatcher
+
+
+class TestCollectionWatcher(unittest.TestCase):
+
+def test_collections_returns_all_collections(self):
+collection_watcher = CollectionWatcher('/foo', Mock(), Mock())
+collection_watcher._collections_by_dir = {
+"/foo": {
+Collection("id1", "var1", "path1", 1, 2, datetime.now(), 
datetime.now()),
+Collection("id2", "var2", "path2", 3, 4, datetime.now(), 
datetime.now()),
+},
+"/bar": {
+Collection("id3", "var3", "path3", 5, 6, datetime.now(), 
datetime.now()),
+Collection("id4", "var4", "path4", 7, 8, datetime.now(), 
datetime.now()),
+}
+}
+flattened_collections = collection_watcher.collections()
+self.assertEqual(len(flattened_collections), 4)
+
+def test_load_collections_loads_all_collections(self):
+collections_path = os.path.join(os.path.dirname(__file__), 
'../resources/collections.yml')
+collection_watcher = CollectionWatcher(collections_path, Mock(), 
Mock())
+collection_watcher._load_collections()
+
+self.assertEquals(len(collection_watcher._collections_by_dir), 2)
+
self.assertEquals(len(collection_watcher._collections_by_dir['/opt/data/grace']),
 2)
+
self.assertEquals(len(collection_watcher._collections_by_dir['/opt/data/avhrr']),
 1)
+
+def test_load_collections_with_bad_yaml_syntax(self):
+collections_path = os.path.join(os.path.dirname(__file__), 
'../resources/collections_bad.yml')
+collection_watcher = CollectionWatcher(collections_path, Mock(), 
Mock())
+
+self.assertRaises(YamlParsingError, 
collection_watcher._load_collections)
+
+def test_load_collections_with_file_not_found(self):
+collections_path = os.path.join(os.path.dirname(__file__), 
'../resources/does_not_exist.yml')
+collection_watcher = CollectionWatcher(collections_path, Mock(), 
Mock())
+
+self.assertRaises(CollectionConfigFileNotFoundError, 
collection_watcher._load_collections)
+
+def test_get_updated_collections_returns_all_collections(self):
+collections_path = os.path.join(os.path.dirname(__file__), 
'../resources/collections.yml')
+collection_watcher = CollectionWatcher(collections_path, Mock(), 
Mock())
+
+updated_collections = collection_watcher._get_updated_collections()
+self.assertSetEqual(updated_collections, 
collection_watcher.collections())
+
+def test_get_updated_collections_returns_no_collections(self):
+collections_path = os.path.join(os.path.dirname(__file__), 
'../resources/collections.yml')
+collection_watcher = CollectionWatcher(collections_path, Mock(), 
Mock())
+collection_watcher._load_collections()
+updated_collections = collection_watcher._get_updated_collections()
+
+self.assertEquals(len(updated_collections), 0)
+
+def test_get_updated_collections_returns_some_collections(self):
+collections_path = os.path.join(os.path.dirname(__file__), 
'../resources/collections.yml')
+collection_watcher = CollectionWatcher(collections_path, Mock(), 
Mock())
+collection_watcher._load_collections()
+
+new_collections_path = os.path.join(os.path.dirname(__file__), 
'../resources/collections_alternate.yml')
+collection_watcher._collections_path = new_collections_path
+updated_collections = collection_watcher._get_updated_collections()
+
+self.assertEquals(len(updated_collections), 1)
+
+def test_validate_collection(self):
+collections_path = os.path.join(os.path.dirname(__file__), 
'../resources/collections.yml')
+collection_watcher = CollectionWatcher(collections_path, Mock(), 
Mock())
+
+collection = Collection(dataset_id="test_dataset",
+path="/absolute/path",
+variable="test_variable",
+historical_priority=1,
+forward_processing_priority=2,
+date_from=None,
+date_to=None)
+collection_watcher._validate_collection(collection)
+
+def test_validate_collection_with_relative_path(self):
+collections_path = 

[GitHub] [incubator-sdap-nexus] eamonford commented on a change in pull request #101: SDAP-249 : add solr time out client argument to webapp, use it in the data acces…

[GitBox]

eamonford commented on a change in pull request #101:
URL: 
https://github.com/apache/incubator-sdap-nexus/pull/101#discussion_r441780658



##
File path: analysis/webservice/algorithms/doms/DomsInitialization.py
##
@@ -49,6 +49,7 @@ def init(self, config):
 log.info("Cassandra Protocol Version: %s" % (cassVersion))
 
 dc_policy = DCAwareRoundRobinPolicy(cassDatacenter)
+#dc_policy = WhiteListRoundRobinPolicy([cassHost])

Review comment:
   Could you delete this commented line and the unused import in this file?

##
File path: data-access/nexustiles/dao/SolrProxy.py
##
@@ -36,12 +36,18 @@ class SolrProxy(object):
 def __init__(self, config):
 self.solrUrl = config.get("solr", "host")
 self.solrCore = config.get("solr", "core")
+solr_kargs = {}
+if config.has_option("solr", "time_out"):
+solr_kargs["timeout"] = config.get("solr", "time_out")
 self.logger = logging.getLogger('nexus')
 
 with SOLR_CON_LOCK:
 solrcon = getattr(thread_local, 'solrcon', None)
 if solrcon is None:
-solrcon = pysolr.Solr('http://%s/solr/%s' % (self.solrUrl, 
self.solrCore))
+solr_url = 'http://%s/solr/%s' % (self.solrUrl, self.solrCore)
+self.logger.info("connect to solr, url {}".format(solr_url))
+self.logger.info("with option(s) = {}".format(solr_kargs))

Review comment:
   Could you combine these two log statements into one? The NEXUS logs are 
kind of polluted and these two logs are part of the same sentence anyway

##
File path: analysis/webservice/webapp.py
##
@@ -156,6 +155,23 @@ def async_callback(self, result):
 if hasattr(result, 'cleanup'):
 result.cleanup()
 
+def inject_args_in_config(args, config):
+"""
+Takes command argparse arguments and push them in the config
+ with syntax args._
+"""
+for _, t_opt in args._options.items():

Review comment:
   you can change this line to `for t_opt in args._options.values():`

##
File path: analysis/webservice/webapp.py
##
@@ -156,6 +155,23 @@ def async_callback(self, result):
 if hasattr(result, 'cleanup'):
 result.cleanup()
 
+def inject_args_in_config(args, config):

Review comment:
   Can you write a unit test for this function? There is some parsing logic 
which should be unit tested

##
File path: data-access/nexustiles/dao/CassandraProxy.py
##
@@ -168,6 +168,7 @@ def __init__(self, config):
 def __open(self):
 
 dc_policy = DCAwareRoundRobinPolicy(self.__cass_local_DC)
+#dc_policy = WhiteListRoundRobinPolicy([self.__cass_url ])

Review comment:
   Could you delete this commented line and the unused import in this file?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-sdap-nexus] tloubrieu-jpl opened a new pull request #101: SDAP-249 : add solr time out client argument to webapp, use it in the data acces…

[GitBox]

tloubrieu-jpl opened a new pull request #101:
URL: https://github.com/apache/incubator-sdap-nexus/pull/101


   …s configuration
   
   As described in jira ticket SDAP-249



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-sdap-nexus] tloubrieu-jpl closed pull request #100: #249 (add solr client time out argument for webapp driver)

[GitBox]

tloubrieu-jpl closed pull request #100:
URL: https://github.com/apache/incubator-sdap-nexus/pull/100


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-sdap-nexus] tloubrieu-jpl opened a new pull request #100: #249 (add solr client time out argument for webapp driver)

[GitBox]

tloubrieu-jpl opened a new pull request #100:
URL: https://github.com/apache/incubator-sdap-nexus/pull/100


   This pull request implements https://issues.apache.org/jira/browse/SDAP-249
   
   The helm chart is not updated to use the new parameter
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-sdap-ingester] eamonford opened a new pull request #1: SDAP-234: Test suite

[GitBox]

eamonford opened a new pull request #1:
URL: https://github.com/apache/incubator-sdap-ingester/pull/1


   This adds more test coverage to the collection_manager package.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-sdap-nexus] ntquach merged pull request #99: SDAP-242: Add updates to ESRI/SDAP Integration

[GitBox]

ntquach merged pull request #99:
URL: https://github.com/apache/incubator-sdap-nexus/pull/99


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-sdap-nexus] yepremyana opened a new pull request #99: SDAP-242: Add updates to ESRI/SDAP Integration

[GitBox]

yepremyana opened a new pull request #99:
URL: https://github.com/apache/incubator-sdap-nexus/pull/99


   https://issues.apache.org/jira/browse/SDAP-242



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-sdap-nexus] eamonford opened a new pull request #98: Performance metrics logging

[GitBox]

eamonford opened a new pull request #98:
URL: https://github.com/apache/incubator-sdap-nexus/pull/98


   #SDAP-232



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-sdap-nexus] dependabot[bot] commented on pull request #87: Bump pillow from 5.0.0 to 6.2.0 in /analysis

[GitBox]

dependabot[bot] commented on pull request #87:
URL: 
https://github.com/apache/incubator-sdap-nexus/pull/87#issuecomment-625495378


   Looks like pillow is up-to-date now, so this is no longer needed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-sdap-nexus] dependabot[bot] commented on pull request #86: Bump pyyaml from 3.12 to 5.1 in /analysis

[GitBox]

dependabot[bot] commented on pull request #86:
URL: 
https://github.com/apache/incubator-sdap-nexus/pull/86#issuecomment-625495381


   Looks like pyyaml is no longer a dependency, so this is no longer needed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-sdap-nexus] dependabot[bot] commented on pull request #85: Bump pyyaml from 3.12 to 5.1 in /data-access

[GitBox]

dependabot[bot] commented on pull request #85:
URL: 
https://github.com/apache/incubator-sdap-nexus/pull/85#issuecomment-625495379


   Looks like pyyaml is no longer a dependency, so this is no longer needed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-sdap-nexus] jjacob7734 merged pull request #93: SDAP-220: temporal variance algorithm

[GitBox]

jjacob7734 merged pull request #93: SDAP-220: temporal variance algorithm
URL: https://github.com/apache/incubator-sdap-nexus/pull/93
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-sdap-nexusproto] ntquach merged pull request #5: SDAP-229: Ecco support

[GitBox]

ntquach merged pull request #5: SDAP-229: Ecco support
URL: https://github.com/apache/incubator-sdap-nexusproto/pull/5
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-sdap-nexusproto] eamonford opened a new pull request #5: SDAP-227: Ecco support

[GitBox]

eamonford opened a new pull request #5: SDAP-227: Ecco support
URL: https://github.com/apache/incubator-sdap-nexusproto/pull/5
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-sdap-nexus] ntquach merged pull request #97: SDAP-228 Optional rootwebpage

[GitBox]

ntquach merged pull request #97: SDAP-228 Optional rootwebpage
URL: https://github.com/apache/incubator-sdap-nexus/pull/97
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-sdap-nexus] eamonford opened a new pull request #97: SDAP-228 Optional rootwebpage

[GitBox]

eamonford opened a new pull request #97: SDAP-228 Optional rootwebpage
URL: https://github.com/apache/incubator-sdap-nexus/pull/97
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-sdap-ningester] ntquach merged pull request #14: SDAP-227 Support indexed latlon

[GitBox]

ntquach merged pull request #14: SDAP-227 Support indexed latlon
URL: https://github.com/apache/incubator-sdap-ningester/pull/14
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-sdap-ningester] eamonford opened a new pull request #14: Support indexed latlon

[GitBox]

eamonford opened a new pull request #14: Support indexed latlon
URL: https://github.com/apache/incubator-sdap-ningester/pull/14
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-sdap-ningesterpy] ntquach merged pull request #12: SDAP-227 Support indexed latlon

[GitBox]

ntquach merged pull request #12: SDAP-227 Support indexed latlon
URL: https://github.com/apache/incubator-sdap-ningesterpy/pull/12
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-sdap-nexus] ntquach merged pull request #96: SDAP-226: pass in the configured number of zookeeper replicas to zook…

[GitBox]

ntquach merged pull request #96: SDAP-226: pass in the configured number of 
zookeeper replicas to zook…
URL: https://github.com/apache/incubator-sdap-nexus/pull/96
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-sdap-nexus] eamonford opened a new pull request #96: SDAP-226: pass in the configured number of zookeeper replicas to zook…

[GitBox]

eamonford opened a new pull request #96: SDAP-226: pass in the configured 
number of zookeeper replicas to zook…
URL: https://github.com/apache/incubator-sdap-nexus/pull/96
 
 
   …eeper container args


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-sdap-nexus] jjacob7734 merged pull request #95: SDAP 219

[GitBox]

jjacob7734 merged pull request #95: SDAP 219
URL: https://github.com/apache/incubator-sdap-nexus/pull/95
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-sdap-nexus] yepremyana commented on a change in pull request #94: Sdap 223

[GitBox]

yepremyana commented on a change in pull request #94: Sdap 223
URL: 
https://github.com/apache/incubator-sdap-nexus/pull/94#discussion_r391127612
 
 

 ##
 File path: integrations/esri/README.md
 ##
 @@ -0,0 +1,36 @@
+# SDAP ArcGIS Tools
+
+Toolbox and scripts for utilizing SDAP analytics within ArcGIS
+
+## Contents
+
+`zipped_toolbox`: Contains the python scripts and the toolbox. 
+
+`nexus_toolbox_embedded.tbx`: toolbox which contains the SDAP scripts embedded 
into the toolbox. 
+
+## Usage
+
+###Development
 
 Review comment:
   updated, thanks!


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-sdap-nexus] eamonford commented on a change in pull request #94: Sdap 223

[GitBox]

eamonford commented on a change in pull request #94: Sdap 223
URL: 
https://github.com/apache/incubator-sdap-nexus/pull/94#discussion_r391110901
 
 

 ##
 File path: integrations/esri/README.md
 ##
 @@ -0,0 +1,36 @@
+# SDAP ArcGIS Tools
+
+Toolbox and scripts for utilizing SDAP analytics within ArcGIS
+
+## Contents
+
+`zipped_toolbox`: Contains the python scripts and the toolbox. 
+
+`nexus_toolbox_embedded.tbx`: toolbox which contains the SDAP scripts embedded 
into the toolbox. 
+
+## Usage
+
+###Development
 
 Review comment:
   I think there's supposed to be a space after the ### to make the MD render 
properly


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-sdap-nexus] eamonford opened a new pull request #95: SDAP 219

[GitBox]

eamonford opened a new pull request #95: SDAP 219
URL: https://github.com/apache/incubator-sdap-nexus/pull/95
 
 
   Add helm readme file


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-sdap-nexus] yepremyana opened a new pull request #94: Sdap 223

[GitBox]

yepremyana opened a new pull request #94: Sdap 223
URL: https://github.com/apache/incubator-sdap-nexus/pull/94
 
 
   Refer to Jira ticket 223 for more information


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-sdap-nexus] jjacob7734 merged pull request #92: SDAP-222: Add support for nodeSelectors and tolerations in the Helm chart

[GitBox]

jjacob7734 merged pull request #92: SDAP-222: Add support for nodeSelectors and 
tolerations in the Helm chart
URL: https://github.com/apache/incubator-sdap-nexus/pull/92
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-sdap-nexus] jjacob7734 commented on issue #91: SDAP-221: Add Helm configuration value to enable/disable nginx-ingress subchart installation

[GitBox]

jjacob7734 commented on issue #91: SDAP-221: Add Helm configuration value to 
enable/disable nginx-ingress subchart installation
URL: 
https://github.com/apache/incubator-sdap-nexus/pull/91#issuecomment-593564996
 
 
   SDAP-221: Add Helm configuration value to enable/disable nginx-ingress 
subchart installation


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-sdap-nexus] jjacob7734 closed pull request #91: SDAP-221: Add Helm configuration value to enable/disable nginx-ingress subchart installation

[GitBox]

jjacob7734 closed pull request #91: SDAP-221: Add Helm configuration value to 
enable/disable nginx-ingress subchart installation
URL: https://github.com/apache/incubator-sdap-nexus/pull/91
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-sdap-nexus] jjacob7734 merged pull request #91: SDAP-221: Add Helm configuration value to enable/disable nginx-ingress subchart installation

[GitBox]

jjacob7734 merged pull request #91: SDAP-221: Add Helm configuration value to 
enable/disable nginx-ingress subchart installation
URL: https://github.com/apache/incubator-sdap-nexus/pull/91
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-sdap-nexus] eamonford opened a new pull request #91: SDAP-221: Add Helm configuration value to enable/disable nginx-ingress subchart installation

[GitBox]

eamonford opened a new pull request #91: SDAP-221: Add Helm configuration value 
to enable/disable nginx-ingress subchart installation
URL: https://github.com/apache/incubator-sdap-nexus/pull/91
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-sdap-nexus] fgreg commented on issue #91: SDAP-221: Add Helm configuration value to enable/disable nginx-ingress subchart installation

[GitBox]

fgreg commented on issue #91: SDAP-221: Add Helm configuration value to 
enable/disable nginx-ingress subchart installation
URL: 
https://github.com/apache/incubator-sdap-nexus/pull/91#issuecomment-593561065
 
 
   Sounds good to me. I think there is value in having a `ingress-setup.md`. It 
would just need to list some assumptions and be generic. But yeah, LGTM.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-sdap-nexus] eamonford commented on issue #91: SDAP-221: Add Helm configuration value to enable/disable nginx-ingress subchart installation

[GitBox]

eamonford commented on issue #91: SDAP-221: Add Helm configuration value to 
enable/disable nginx-ingress subchart installation
URL: 
https://github.com/apache/incubator-sdap-nexus/pull/91#issuecomment-593551035
 
 
   After reading your feedback and discussing with @ntquach, I've decided the 
ingress-setup.md file would be better suited for the nexus-deployment repo at 
https://git.earthdata.nasa.gov/projects/NEXUS/repos/nexus-deployment/browse. 
I've removed the file from this repo and a PR will be coming soon in 
nexus-deployment.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-sdap-nexus] mayadebellis opened a new pull request #93: SDAP-220: add data anomaly algorithm

[GitBox]

mayadebellis opened a new pull request #93: SDAP-220: add data anomaly algorithm
URL: https://github.com/apache/incubator-sdap-nexus/pull/93
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-sdap-nexus] eamonford opened a new pull request #92: SDAP-222: Add support for nodeSelectors and tolerations in the Helm chart

[GitBox]

eamonford opened a new pull request #92: SDAP-222: Add support for 
nodeSelectors and tolerations in the Helm chart
URL: https://github.com/apache/incubator-sdap-nexus/pull/92
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-sdap-nexus] eamonford opened a new pull request #91: SDAP-221: Add Helm configuration value to enable/disable nginx-ingress subchart installation

[GitBox]

eamonford opened a new pull request #91: SDAP-221: Add Helm configuration value 
to enable/disable nginx-ingress subchart installation
URL: https://github.com/apache/incubator-sdap-nexus/pull/91
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-sdap-nexus] tloubrieu-jpl commented on issue #90: SDAP 218: bug correction on start/end date from nexcusli.dataset_list()

[GitBox]

tloubrieu-jpl commented on issue #90: SDAP 218: bug correction on start/end 
date from nexcusli.dataset_list() 
URL: 
https://github.com/apache/incubator-sdap-nexus/pull/90#issuecomment-589450172
 
 
   I did the change, apparently you were notified. Thanks. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-sdap-nexus] fgreg merged pull request #90: SDAP 218: bug correction on start/end date from nexcusli.dataset_list()

[GitBox]

fgreg merged pull request #90: SDAP 218: bug correction on start/end date from 
nexcusli.dataset_list() 
URL: https://github.com/apache/incubator-sdap-nexus/pull/90
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-sdap-nexus] fgreg merged pull request #89: SDAP-216: Update the quickstart guide

[GitBox]

fgreg merged pull request #89: SDAP-216: Update the quickstart guide
URL: https://github.com/apache/incubator-sdap-nexus/pull/89
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-sdap-nexus] tloubrieu-jpl opened a new pull request #90: SDAP 218: bug correction on start/end date from nexcusli.dataset_list()

[GitBox]

tloubrieu-jpl opened a new pull request #90: SDAP 218: bug correction on 
start/end date from nexcusli.dataset_list() 
URL: https://github.com/apache/incubator-sdap-nexus/pull/90
 
 
   The function was converting date timestamp to iso format assuming the 
timestamp was in millisecond.
   
   Instead we directly get the iso date string from the nexus service. No 
conversion is required.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-sdap-nexus] jjacob7734 commented on issue #89: Sdap 216

[GitBox]

jjacob7734 commented on issue #89: Sdap 216
URL: 
https://github.com/apache/incubator-sdap-nexus/pull/89#issuecomment-589273413
 
 
   This does address all the places where I noticed the Quickstart guide 
diverged from reality a bit.  Requested a review from Frank who prepared the 
original version, but I think this would be good to get merged to avoid 
confusion for newcomers.  


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-sdap-nexus] tloubrieu-jpl opened a new pull request #89: Sdap 216

[GitBox]

tloubrieu-jpl opened a new pull request #89: Sdap 216
URL: https://github.com/apache/incubator-sdap-nexus/pull/89
 
 
   A few updated in the quickstart guide for a single node installation after I 
have tested the deployment on my laptop.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-sdap-mudrod] JLLeitschuh opened a new pull request #52: [SECURITY] Use HTTPS to resolve dependencies in Maven Build

[GitBox]

JLLeitschuh opened a new pull request #52: [SECURITY] Use HTTPS to resolve 
dependencies in Maven Build
URL: https://github.com/apache/incubator-sdap-mudrod/pull/52
 
 
   
[![mitm_build](https://user-images.githubusercontent.com/1323708/59226671-90645200-8ba1-11e9-8ab3-39292bef99e9.jpeg)](https://medium.com/@jonathan.leitschuh/want-to-take-over-the-java-ecosystem-all-you-need-is-a-mitm-1fc329d898fb?source=friends_link=3c99970c55a899ad9ef41f126efcde0e)
   
   - [Want to take over the Java ecosystem? All you need is a 
MITM!](https://medium.com/@jonathan.leitschuh/want-to-take-over-the-java-ecosystem-all-you-need-is-a-mitm-1fc329d898fb?source=friends_link=3c99970c55a899ad9ef41f126efcde0e)
   - [Update: Want to take over the Java ecosystem? All you need is a 
MITM!](https://medium.com/bugbountywriteup/update-want-to-take-over-the-java-ecosystem-all-you-need-is-a-mitm-d069d253fe23?source=friends_link=8c8e52a7d57b98d0b7e541665688b454)
   
   ---
   
   This is a security fix for a  vulnerability in your [Apache 
Maven](https://maven.apache.org/) `pom.xml` file(s).
   
   The build files indicate that this project is resolving dependencies over 
HTTP instead of HTTPS.
   This leaves your build vulnerable to allowing a [Man in the 
Middle](https://en.wikipedia.org/wiki/Man-in-the-middle_attack) (MITM) 
attackers to execute arbitrary code on your or your computer or CI/CD system.
   
   This vulnerability has a CVSS v3.0 Base Score of 
[8.1/10](https://nvd.nist.gov/vuln-metrics/cvss/v3-calculator?vector=AV:N/AC:H/PR:N/UI:N/S:U/C:H/I:H/A:H).
   
   [POC 
code](https://max.computer/blog/how-to-take-over-the-computer-of-any-java-or-clojure-or-scala-developer/)
 has existed since 2014 to maliciously compromise a JAR file in-flight.
   MITM attacks against HTTP are [increasingly 
common](https://security.stackexchange.com/a/12050), for example [Comcast is 
known to have done it to their own 
users](https://thenextweb.com/insights/2017/12/11/comcast-continues-to-inject-its-own-code-into-websites-you-visit/#).
   
   This contribution is a part of a submission to the [GitHub Security 
Lab](https://securitylab.github.com/) Bug Bounty program.
   
   ## Detecting this and Future Vulnerabilities
   
   This vulnerability was automatically detected by 
[LGTM.com](https://lgtm.com) using this [CodeQL 
Query](https://lgtm.com/rules/155648721/).
   
   As of September 2019 LGTM.com and Semmle are [officially a part of 
GitHub](https://github.blog/2019-09-18-github-welcomes-semmle/).
   
   You can automatically detect future vulnerabilities like this by enabling 
the free (for open-source) [LGTM App](https://github.com/marketplace/lgtm).
   
   I'm not an employee of GitHub nor of Semmle, I'm simply a user of 
[LGTM.com](https://lgtm.com) and an open-source security researcher.
   
   ## Source
   
   Yes, this contribution was automatically generated, however, the code to 
generate this PR was lovingly hand crafted to bring this security fix to your 
repository.
   
   The source code that generated and submitted this PR can be found here:
   
[JLLeitschuh/bulk-security-pr-generator](https://github.com/JLLeitschuh/bulk-security-pr-generator)
   
   ## Opting-Out
   
   If you'd like to opt-out of future automated security vulnerability fixes 
like this, please consider adding a file called
   `.github/GH-ROBOTS.txt` to your repository with the line:
   
   ```
   User-agent: JLLeitschuh/bulk-security-pr-generator
   Disallow: *
   ```
   
   This bot will respect the [ROBOTS.txt](https://moz.com/learn/seo/robotstxt) 
format for future contributions.
   
   Alternatively, if this project is no longer actively maintained, consider 
[archiving](https://help.github.com/en/github/creating-cloning-and-archiving-repositories/about-archiving-repositories)
 the repository.
   
   ## CLA Requirements
   
   _This section is only relevant if your project requires contributors to sign 
a Contributor License Agreement (CLA) for external contributions._
   
   It is unlikely that I'll be able to directly sign CLAs. However, all 
contributed commits are already automatically signed-off.
   
   > The meaning of a signoff depends on the project, but it typically 
certifies that committer has the rights to submit this work under the same 
license and agrees to a Developer Certificate of Origin 
   > (see 
[https://developercertificate.org/](https://developercertificate.org/) for more 
information).
   >
   > \- [Git Commit Signoff documentation](https://developercertificate.org/)
   
   If signing your organization's CLA is a strict-requirement for merging this 
contribution, please feel free to close this PR.
   
   ## Tracking
   
   All PR's generated as part of this fix are tracked here: 
   https://github.com/JLLeitschuh/bulk-security-pr-generator/issues/2


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and 

[GitHub] [incubator-sdap-ningesterpy] fgreg commented on issue #12: Support indexed latlon

[GitBox]

fgreg commented on issue #12: Support indexed latlon
URL: 
https://github.com/apache/incubator-sdap-ningesterpy/pull/12#issuecomment-582685184
 
 
   Do you have a JIRA ticket for it? Can you add it to the PR name


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-sdap-ningesterpy] eamonford commented on issue #12: Support indexed latlon

[GitBox]

eamonford commented on issue #12: Support indexed latlon
URL: 
https://github.com/apache/incubator-sdap-ningesterpy/pull/12#issuecomment-582684410
 
 
   > Awesome. Looks like with this change the name of the dimension does not 
need to match the name of the coordinate variable anymore. Is that right?
   
   Yeah that's correct -- if dimension names aren't specified it'll default to 
using the coordinate variable names, otherwise they don't need to match


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-sdap-ningesterpy] fgreg commented on issue #12: Support indexed latlon

[GitBox]

fgreg commented on issue #12: Support indexed latlon
URL: 
https://github.com/apache/incubator-sdap-ningesterpy/pull/12#issuecomment-582683805
 
 
   Awesome. Looks like with this change the name of the dimension does not need 
to match the name of the coordinate variable anymore. Is that right?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-sdap-ningesterpy] eamonford opened a new pull request #12: Support indexed latlon

[GitBox]

eamonford opened a new pull request #12: Support indexed latlon
URL: https://github.com/apache/incubator-sdap-ningesterpy/pull/12
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-sdap-nexus] eamonford commented on a change in pull request #88: SDAP-215 Use k8s as Spark scheduler and create helm chart

[GitBox]

eamonford commented on a change in pull request #88: SDAP-215 Use k8s as Spark 
scheduler and create helm chart
URL: 
https://github.com/apache/incubator-sdap-nexus/pull/88#discussion_r369875545
 
 

 ##
 File path: analysis/webservice/algorithms/doms/domsconfig.ini
 ##
 @@ -1,5 +1,5 @@
 [cassandra]
-host=127.0.0.1
+host=sdap-cassandra
 
 Review comment:
   I agree, this should be addressed in a separate PR... unfortunately without 
`docker-entrypoint.sh` these values are indeed hardcoded, but I had to remove 
docker-entrypoint because the Spark Operator controller now handles the 
submission of the of the webapp to the spark server. I think addressing this 
should be a top priority after this PR goes in


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-sdap-nexus] eamonford commented on a change in pull request #88: SDAP-215 Use k8s as Spark scheduler and create helm chart

[GitBox]

eamonford commented on a change in pull request #88: SDAP-215 Use k8s as Spark 
scheduler and create helm chart
URL: 
https://github.com/apache/incubator-sdap-nexus/pull/88#discussion_r369874390
 
 

 ##
 File path: helm/templates/ingress.yaml
 ##
 @@ -0,0 +1,26 @@
+apiVersion: extensions/v1beta1
+kind: Ingress
+metadata:
+  name: nexus-webapp
+  annotations:
+kubernetes.io/ingress.class: ingress-nginx
+nginx.ingress.kubernetes.io/rewrite-target: /$1
+nginx.ingress.kubernetes.io/proxy-read-timeout: "180"
+nginx.ingress.kubernetes.io/proxy-send-timeout: "180"
+spec:
+  rules:
+  - host: {{ .Values.host }}
+http:
+  paths:
+  - path: /
 
 Review comment:
   I'm going to leave the root-webpage route in there for now, because /onearth 
is currently proxying to a node outside the EKS cluster so I don't want to move 
the nexus webapp to the root path or nexus might try to pick up requests 
intended for OnEarth. When OnEarth moves to a k8s deployment, we can revisit 
this


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-sdap-edge] lewismc merged pull request #10: SDAP-214 Simplify EDGE directory structure

[GitBox]

lewismc merged pull request #10: SDAP-214 Simplify EDGE directory structure
URL: https://github.com/apache/incubator-sdap-edge/pull/10
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-sdap-nexus] fgreg commented on a change in pull request #88: SDAP-215 Use k8s as Spark scheduler and create helm chart

[GitBox]

fgreg commented on a change in pull request #88: SDAP-215 Use k8s as Spark 
scheduler and create helm chart
URL: 
https://github.com/apache/incubator-sdap-nexus/pull/88#discussion_r352887919
 
 

 ##
 File path: helm/templates/solr.yml
 ##
 @@ -0,0 +1,59 @@
+apiVersion: v1
+kind: Service
+metadata:
+  name: sdap-solr
+spec:
+  type: ClusterIP
+  ports:
+  - port: 8983
+protocol: TCP
+targetPort: http
+  selector:
+app: sdap-solr
+
+---
+apiVersion: apps/v1
+kind: StatefulSet
+metadata:
+  name: solr-set
+spec:
+  selector:
+matchLabels:
+  app: sdap-solr # has to match .spec.template.metadata.labels
+  serviceName: "sdap-solr"
+  replicas: {{ .Values.solr.replicas }}
 
 Review comment:
   I don't think there is a valid use case where you would deploy more than 1 
replica of the `solr-singlenode` image. This would simply result in multiple 
segregated solr nodes that know nothing of each other but would be attached 
behind the solr service proxy meaning any service could respond to any request. 
So a document could end up being indexed into replica-1 but requested from 
replica-2, etc...
   
   You'd have to use the 
https://github.com/apache/incubator-sdap-nexus/tree/master/docker/solr/cloud 
image along with the 
https://github.com/apache/incubator-sdap-nexus/tree/master/docker/solr/cloud-init
 to properly setup a solr cloud cluster.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-sdap-nexus] fgreg commented on a change in pull request #88: SDAP-215 Use k8s as Spark scheduler and create helm chart

[GitBox]

fgreg commented on a change in pull request #88: SDAP-215 Use k8s as Spark 
scheduler and create helm chart
URL: 
https://github.com/apache/incubator-sdap-nexus/pull/88#discussion_r352895731
 
 

 ##
 File path: helm/templates/ingress.yaml
 ##
 @@ -0,0 +1,26 @@
+apiVersion: extensions/v1beta1
+kind: Ingress
+metadata:
+  name: nexus-webapp
+  annotations:
+kubernetes.io/ingress.class: ingress-nginx
+nginx.ingress.kubernetes.io/rewrite-target: /$1
+nginx.ingress.kubernetes.io/proxy-read-timeout: "180"
+nginx.ingress.kubernetes.io/proxy-send-timeout: "180"
+spec:
+  rules:
+  - host: {{ .Values.host }}
+http:
+  paths:
+  - path: /
 
 Review comment:
   I'd actually remove this by default. The way the root-webpage is setup 
currently causes the application to return 200 OK for any path requested (the 
intent was for just /) and it will cause many false-positives for security 
scans.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-sdap-nexus] fgreg commented on a change in pull request #88: SDAP-215 Use k8s as Spark scheduler and create helm chart

[GitBox]

fgreg commented on a change in pull request #88: SDAP-215 Use k8s as Spark 
scheduler and create helm chart
URL: 
https://github.com/apache/incubator-sdap-nexus/pull/88#discussion_r352889616
 
 

 ##
 File path: Dockerfile
 ##
 @@ -0,0 +1,120 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
 
 Review comment:
   I think it would still be nice for this to be in the /docker directory since 
this project does produce a number of docker images.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-sdap-nexus] jjacob7734 commented on issue #88: SDAP-215 Use k8s as Spark scheduler and create helm chart

[GitBox]

jjacob7734 commented on issue #88: SDAP-215 Use k8s as Spark scheduler and 
create helm chart
URL: 
https://github.com/apache/incubator-sdap-nexus/pull/88#issuecomment-560700354
 
 
   You probably didn't mean to refer to your personal repo in your 
Dockerfile... please check on that before we merge.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-sdap-nexus] eamonford commented on issue #88: SDAP-215 Use k8s as Spark scheduler and create helm chart

[GitBox]

eamonford commented on issue #88: SDAP-215 Use k8s as Spark scheduler and 
create helm chart
URL: 
https://github.com/apache/incubator-sdap-nexus/pull/88#issuecomment-560643769
 
 
   > I'm not sure if it is even possible here, but just want to point out, that 
it is usually advisable to break up large PRs into smaller where ever possible. 
(Again, I know things w k8s can get screwy and that might not have been an 
option, I'm mainly saying it so others are aware).
   
   Completely agree -- the only reason I included the Helm chart in this PR 
along with the Spark/Docker changes is because the deployment starts to get 
more complex with the extra roles and configuration values that are needed, and 
Helm streamlines much of this. The files deleted in this PR are from the 
Mesos/Kubernetes deployment, which gets superseded by this new Spark deployment.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-sdap-edge] rawkintrevo commented on issue #10: SDAP-214 Simplify EDGE directory structure

[GitBox]

rawkintrevo commented on issue #10: SDAP-214 Simplify EDGE directory structure
URL: 
https://github.com/apache/incubator-sdap-edge/pull/10#issuecomment-560651171
 
 
   @lewismc  Ahh my bad, I was looking at the lines, not the context (e.g. the 
file that was being edited).
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-sdap-edge] lewismc commented on issue #10: SDAP-214 Simplify EDGE directory structure

[GitBox]

lewismc commented on issue #10: SDAP-214 Simplify EDGE directory structure
URL: 
https://github.com/apache/incubator-sdap-edge/pull/10#issuecomment-560626011
 
 
   @rawkintrevo thanks for reviewinbg
   
   > It appears you also upgraded a couple of things to python3
   
   Negative, that work was done in 
https://github.com/apache/incubator-sdap-edge/pull/9, the only Python3 'stuff' 
on this branch was documentation int he README.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-sdap-nexus] rawkintrevo commented on issue #88: SDAP-215 Use k8s as Spark scheduler and create helm chart

[GitBox]

rawkintrevo commented on issue #88: SDAP-215 Use k8s as Spark scheduler and 
create helm chart
URL: 
https://github.com/apache/incubator-sdap-nexus/pull/88#issuecomment-560617578
 
 
   Also- thanks for the contribution @eamonford !!
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-sdap-edge] fgreg commented on issue #10: SDAP-214 Simplify EDGE directory structure

[GitBox]

fgreg commented on issue #10: SDAP-214 Simplify EDGE directory structure
URL: 
https://github.com/apache/incubator-sdap-edge/pull/10#issuecomment-560612908
 
 
   Seems reasonable to me. @lewismc Were you able to successfully start it 
locally using the instructions from the Readme?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-sdap-edge] rawkintrevo commented on issue #10: SDAP-214 Simplify EDGE directory structure

[GitBox]

rawkintrevo commented on issue #10: SDAP-214 Simplify EDGE directory structure
URL: 
https://github.com/apache/incubator-sdap-edge/pull/10#issuecomment-560609065
 
 
   It appears you also upgraded a couple of things to python3.  
   
   That's OK, but in general its better to make another PR for something like 
`SDAP-XXX Upgrade Edge directory to python3` or whatever. It just makes it 
easier to track changes if someone ever needs to go through it. 
   
   just my .02
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-sdap-edge] lewismc commented on issue #10: SDAP-214 Simplify EDGE directory structure

[GitBox]

lewismc commented on issue #10: SDAP-214 Simplify EDGE directory structure
URL: 
https://github.com/apache/incubator-sdap-edge/pull/10#issuecomment-560599500
 
 
   Any comments?
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-sdap-nexus] eamonford opened a new pull request #88: SDAP-215 Use k8s as Spark scheduler and create helm chart

[GitBox]

eamonford opened a new pull request #88: SDAP-215 Use k8s as Spark scheduler 
and create helm chart
URL: https://github.com/apache/incubator-sdap-nexus/pull/88
 
 
   This branch updates Spark to v2.4.4 to be natively compatible with 
Kubernetes, so Spark now uses Kubernetes as a scheduler. This branch also adds 
a Helm chart so that nexus can be deployed using helm install.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-sdap-edge] lewismc opened a new pull request #10: SDAP-214 Simplify EDGE directory structure

[GitBox]

lewismc opened a new pull request #10: SDAP-214 Simplify EDGE directory 
structure
URL: https://github.com/apache/incubator-sdap-edge/pull/10
 
 
   @ntquach @fgreg this addresses https://issues.apache.org/jira/browse/SDAP-214


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-sdap-edge] lewismc commented on issue #9: SDAP-212 Update EDGE to Python 3.7

[GitBox]

lewismc commented on issue #9: SDAP-212 Update EDGE to Python 3.7
URL: https://github.com/apache/incubator-sdap-edge/pull/9#issuecomment-558797180
 
 
   @ntquach @fgreg thanks for input. The new ticket for the directory structure 
is created as https://issues.apache.org/jira/browse/SDAP-214


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-sdap-edge] lewismc merged pull request #9: SDAP-212 Update EDGE to Python 3.7

[GitBox]

lewismc merged pull request #9: SDAP-212 Update EDGE to Python 3.7
URL: https://github.com/apache/incubator-sdap-edge/pull/9
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-sdap-edge] fgreg commented on issue #9: SDAP-212 Update EDGE to Python 3.7

[GitBox]

fgreg commented on issue #9: SDAP-212 Update EDGE to Python 3.7
URL: https://github.com/apache/incubator-sdap-edge/pull/9#issuecomment-558731966
 
 
   > Also, it occurred to me that the build system for EDGE doesn't make much 
sense...
   > I'm thinking about removing the pom.xml and then just moving everything 
under 
[main](https://github.com/apache/incubator-sdap-edge/tree/master/src/main) to 
the top level.
   > Everything under 
[site](https://github.com/apache/incubator-sdap-edge/tree/master/src/site) can 
be moved to a wiki.
   > Any thoughts?
   
   @lewismc I think you're probably right. I'd move this discussion over to the 
mailing list or open a new JIRA for it as I think input from Nga would be 
appreciated (I'm not sure if anything under site is relevant anymore).


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-sdap-edge] lewismc commented on issue #9: SDAP-212 Update EDGE to Python 3.7

[GitBox]

lewismc commented on issue #9: SDAP-212 Update EDGE to Python 3.7
URL: https://github.com/apache/incubator-sdap-edge/pull/9#issuecomment-558469676
 
 
   Also, it occurred to me that the build system for EDGE doesn't make much 
sense...
   I'm thinking about removing the  pom.xml and then just moving everything 
under 
[main](https://github.com/apache/incubator-sdap-edge/tree/master/src/main) to 
the top level.
   Everything under 
[site](https://github.com/apache/incubator-sdap-edge/tree/master/src/site) can 
be moved to a wiki.
   Any thoughts?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-sdap-edge] lewismc opened a new pull request #9: SDAP-212 Update EDGE to Python 3.7

[GitBox]

lewismc opened a new pull request #9: SDAP-212 Update EDGE to Python 3.7
URL: https://github.com/apache/incubator-sdap-edge/pull/9
 
 
   Bulk result of running Python's 2to3-3.7 tooling on the codebase.
   This issue addresses https://issues.apache.org/jira/browse/SDAP-212


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-sdap-mudrod] dependabot[bot] opened a new pull request #51: Bump spark.version from 2.1.0 to 2.4.4

[GitBox]

dependabot[bot] opened a new pull request #51: Bump spark.version from 2.1.0 to 
2.4.4
URL: https://github.com/apache/incubator-sdap-mudrod/pull/51
 
 
   Bumps `spark.version` from 2.1.0 to 2.4.4.
   
   Updates `spark-core_2.11` from 2.1.0 to 2.4.4
   
   Updates `spark-sql_2.11` from 2.1.0 to 2.4.4
   
   Updates `spark-mllib_2.11` from 2.1.0 to 2.4.4
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot ignore this [patch|minor|major] version` will close this PR 
and stop Dependabot creating any more for this minor/major version (unless you 
reopen the PR or upgrade to it yourself)
   - `@dependabot ignore this dependency` will close this PR and stop 
Dependabot creating any more for this dependency (unless you reopen the PR or 
upgrade to it yourself)
   - `@dependabot use these labels` will set the current labels as the default 
for future PRs for this repo and language
   - `@dependabot use these reviewers` will set the current reviewers as the 
default for future PRs for this repo and language
   - `@dependabot use these assignees` will set the current assignees as the 
default for future PRs for this repo and language
   - `@dependabot use this milestone` will set the current milestone as the 
default for future PRs for this repo and language
   
   You can disable automated security fix PRs for this repo from the [Security 
Alerts page](https://github.com/apache/incubator-sdap-mudrod/network/alerts).
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-sdap-mudrod] asf-ci commented on issue #51: Bump spark.version from 2.1.0 to 2.4.4

[GitBox]

asf-ci commented on issue #51: Bump spark.version from 2.1.0 to 2.4.4
URL: 
https://github.com/apache/incubator-sdap-mudrod/pull/51#issuecomment-548768506
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-sdap-nexus] dependabot[bot] opened a new pull request #87: Bump pillow from 5.0.0 to 6.2.0 in /analysis

[GitBox]

dependabot[bot] opened a new pull request #87: Bump pillow from 5.0.0 to 6.2.0 
in /analysis
URL: https://github.com/apache/incubator-sdap-nexus/pull/87
 
 
   Bumps [pillow](https://github.com/python-pillow/Pillow) from 5.0.0 to 6.2.0.
   
   Release notes
   
   *Sourced from [pillow's 
releases](https://github.com/python-pillow/Pillow/releases).*
   
   > ## 6.2.0
   > https://pillow.readthedocs.io/en/stable/releasenotes/6.2.0.html
   > 
   > ## 6.1.0
   > https://pillow.readthedocs.io/en/stable/releasenotes/6.1.0.html
   > 
   > ## 6.0.0
   > No release notes provided.
   > 
   > ## 5.4.1
   > No release notes provided.
   > 
   > ## 5.4.0
   > No release notes provided.
   > 
   > ## 5.3.0
   > No release notes provided.
   > 
   > ## 5.2.0
   > No release notes provided.
   > 
   > ## 5.1.0
   > No release notes provided.
   
   
   Changelog
   
   *Sourced from [pillow's 
changelog](https://github.com/python-pillow/Pillow/blob/master/CHANGES.rst).*
   
   > 6.2.0 (2019-10-01)
   > --
   > 
   > - Catch buffer overruns 
[#4104](https://github-redirect.dependabot.com/python-pillow/Pillow/issues/4104)
   >   [radarhere]
   > 
   > - Initialize rows_per_strip when RowsPerStrip tag is missing 
[#4034](https://github-redirect.dependabot.com/python-pillow/Pillow/issues/4034)
   >   [cgohlke, radarhere]
   > 
   > - Raise error if TIFF dimension is a string 
[#4103](https://github-redirect.dependabot.com/python-pillow/Pillow/issues/4103)
   >   [radarhere]
   > 
   > - Added decompression bomb checks 
[#4102](https://github-redirect.dependabot.com/python-pillow/Pillow/issues/4102)
   >   [radarhere]
   > 
   > - Fix ImageGrab.grab DPI scaling on Windows 10 version 1607+ 
[#4000](https://github-redirect.dependabot.com/python-pillow/Pillow/issues/4000)
   >   [nulano, radarhere]
   > 
   > - Corrected negative seeks 
[#4101](https://github-redirect.dependabot.com/python-pillow/Pillow/issues/4101)
   >   [radarhere]
   > 
   > - Added argument to capture all screens on Windows 
[#3950](https://github-redirect.dependabot.com/python-pillow/Pillow/issues/3950)
   >   [nulano, radarhere]
   > 
   > - Updated warning to specify when Image.frombuffer defaults will change 
[#4086](https://github-redirect.dependabot.com/python-pillow/Pillow/issues/4086)
   >   [radarhere]
   > 
   > - Changed WindowsViewer format to PNG 
[#4080](https://github-redirect.dependabot.com/python-pillow/Pillow/issues/4080)
   >   [radarhere]
   > 
   > - Use TIFF orientation 
[#4063](https://github-redirect.dependabot.com/python-pillow/Pillow/issues/4063)
   >   [radarhere]
   > 
   > - Raise the same error if a truncated image is loaded a second time 
[#3965](https://github-redirect.dependabot.com/python-pillow/Pillow/issues/3965)
   >   [radarhere]
   > 
   > - Lazily use ImageFileDirectory_v1 values from Exif 
[#4031](https://github-redirect.dependabot.com/python-pillow/Pillow/issues/4031)
   >   [radarhere]
   > 
   > - Improved HSV conversion 
[#4004](https://github-redirect.dependabot.com/python-pillow/Pillow/issues/4004)
   >   [radarhere]
   > 
   > - Added text stroking 
[#3978](https://github-redirect.dependabot.com/python-pillow/Pillow/issues/3978)
   >   [radarhere, hugovk]
   > 
   > - No more deprecated bdist_wininst .exe installers 
[#4029](https://github-redirect.dependabot.com/python-pillow/Pillow/issues/4029)
   >   [hugovk]
   > 
   > - Do not allow floodfill to extend into negative coordinates 
[#4017](https://github-redirect.dependabot.com/python-pillow/Pillow/issues/4017)
   >   [radarhere]
   > ... (truncated)
   
   
   Commits
   
   - 
[`8a30d13`](https://github.com/python-pillow/Pillow/commit/8a30d135378dc6a1c3c08fa4bb9fbc15370feedf)
 Updated CHANGES.rst [ci skip]
   - 
[`75602d1`](https://github.com/python-pillow/Pillow/commit/75602d12e1b6f2152ab5bd1acfb62a9c8a4a0432)
 6.2.0 version bump
   - 
[`4756af9`](https://github.com/python-pillow/Pillow/commit/4756af9c1027ae620eaa9538d6b0dd9b0e844fca)
 Updated CHANGES.rst [ci skip]
   - 
[`cc16025`](https://github.com/python-pillow/Pillow/commit/cc16025e234b7a7a4dd3a86d2fdc0980698db9cc)
 Merge pull request 
[#4104](https://github-redirect.dependabot.com/python-pillow/Pillow/issues/4104)
 from radarhere/overrun
   - 
[`fb84701`](https://github.com/python-pillow/Pillow/commit/fb8470187a45043c33b1c75e7dca48b38d5db7a6)
 Merge pull request 
[#4034](https://github-redirect.dependabot.com/python-pillow/Pillow/issues/4034)
 from cgohlke/patch-1
   - 
[`b9693a5`](https://github.com/python-pillow/Pillow/commit/b9693a51c99c260bd66d1affeeab4a226cf7e5a5)
 Merge pull request 
[#4103](https://github-redirect.dependabot.com/python-pillow/Pillow/issues/4103)
 from radarhere/dimension
   - 
[`f228d0c`](https://github.com/python-pillow/Pillow/commit/f228d0ccbf6bf9392d7fcd51356ef2cfda80c75a)
 Merge pull request 
[#4102](https://github-redirect.dependabot.com/python-pillow/Pillow/issues/4102)
 from radarhere/decompression
   - 

[GitHub] [incubator-sdap-nexus] dependabot[bot] opened a new pull request #86: Bump pyyaml from 3.12 to 5.1 in /analysis

[GitBox]

dependabot[bot] opened a new pull request #86: Bump pyyaml from 3.12 to 5.1 in 
/analysis
URL: https://github.com/apache/incubator-sdap-nexus/pull/86
 
 
   Bumps [pyyaml](https://github.com/yaml/pyyaml) from 3.12 to 5.1.
   
   Changelog
   
   *Sourced from [pyyaml's 
changelog](https://github.com/yaml/pyyaml/blob/master/CHANGES).*
   
   > 5.1 (2019-03-13)
   > 
   > 
   > * 
[yaml/pyyaml#35](https://github-redirect.dependabot.com/yaml/pyyaml/pull/35) -- 
Some modernization of the test running
   > * 
[yaml/pyyaml#42](https://github-redirect.dependabot.com/yaml/pyyaml/pull/42) -- 
Install tox in a virtualenv
   > * 
[yaml/pyyaml#45](https://github-redirect.dependabot.com/yaml/pyyaml/pull/45) -- 
Allow colon in a plain scalar in a flow context
   > * 
[yaml/pyyaml#48](https://github-redirect.dependabot.com/yaml/pyyaml/pull/48) -- 
Fix typos
   > * 
[yaml/pyyaml#55](https://github-redirect.dependabot.com/yaml/pyyaml/pull/55) -- 
Improve RepresenterError creation
   > * 
[yaml/pyyaml#59](https://github-redirect.dependabot.com/yaml/pyyaml/pull/59) -- 
Resolves [#57](https://github-redirect.dependabot.com/yaml/pyyaml/issues/57), 
update readme issues link
   > * 
[yaml/pyyaml#60](https://github-redirect.dependabot.com/yaml/pyyaml/pull/60) -- 
Document and test Python 3.6 support
   > * 
[yaml/pyyaml#61](https://github-redirect.dependabot.com/yaml/pyyaml/pull/61) -- 
Use Travis CI built in pip cache support
   > * 
[yaml/pyyaml#62](https://github-redirect.dependabot.com/yaml/pyyaml/pull/62) -- 
Remove tox workaround for Travis CI
   > * 
[yaml/pyyaml#63](https://github-redirect.dependabot.com/yaml/pyyaml/pull/63) -- 
Adding support to Unicode characters over codepoint 0x
   > * 
[yaml/pyyaml#65](https://github-redirect.dependabot.com/yaml/pyyaml/pull/65) -- 
Support unicode literals over codepoint 0x
   > * 
[yaml/pyyaml#75](https://github-redirect.dependabot.com/yaml/pyyaml/pull/75) -- 
add 3.12 changelog
   > * 
[yaml/pyyaml#76](https://github-redirect.dependabot.com/yaml/pyyaml/pull/76) -- 
Fallback to Pure Python if Compilation fails
   > * 
[yaml/pyyaml#84](https://github-redirect.dependabot.com/yaml/pyyaml/pull/84) -- 
Drop unsupported Python 3.3
   > * 
[yaml/pyyaml#102](https://github-redirect.dependabot.com/yaml/pyyaml/pull/102) 
-- Include license file in the generated wheel package
   > * 
[yaml/pyyaml#105](https://github-redirect.dependabot.com/yaml/pyyaml/pull/105) 
-- Removed Python 2.6 & 3.3 support
   > * 
[yaml/pyyaml#111](https://github-redirect.dependabot.com/yaml/pyyaml/pull/111) 
-- Remove commented out Psyco code
   > * 
[yaml/pyyaml#129](https://github-redirect.dependabot.com/yaml/pyyaml/pull/129) 
-- Remove call to `ord` in lib3 emitter code
   > * 
[yaml/pyyaml#143](https://github-redirect.dependabot.com/yaml/pyyaml/pull/143) 
-- Allow to turn off sorting keys in Dumper
   > * 
[yaml/pyyaml#149](https://github-redirect.dependabot.com/yaml/pyyaml/pull/149) 
-- Test on Python 3.7-dev
   > * 
[yaml/pyyaml#158](https://github-redirect.dependabot.com/yaml/pyyaml/pull/158) 
-- Support escaped slash in double quotes "\/"
   > * 
[yaml/pyyaml#181](https://github-redirect.dependabot.com/yaml/pyyaml/pull/181) 
-- Import Hashable from collections.abc
   > * 
[yaml/pyyaml#256](https://github-redirect.dependabot.com/yaml/pyyaml/pull/256) 
-- Make default_flow_style=False
   > * 
[yaml/pyyaml#257](https://github-redirect.dependabot.com/yaml/pyyaml/pull/257) 
-- Deprecate yaml.load and add FullLoader and UnsafeLoader classes
   > * 
[yaml/pyyaml#263](https://github-redirect.dependabot.com/yaml/pyyaml/pull/263) 
-- Windows Appveyor build
   > 
   > 3.13 (2018-07-05)
   > -
   > 
   > * Resolved issues around PyYAML working in Python 3.7.
   
   
   Commits
   
   - 
[`e471e86`](https://github.com/yaml/pyyaml/commit/e471e86bf6dabdad45a1438c20a4a5c033eb9034)
 Updates for 5.1 release
   - 
[`9141e90`](https://github.com/yaml/pyyaml/commit/9141e900d10d280173335b20207e87d4a15e62c6)
 Windows Appveyor build
   - 
[`d6cbff6`](https://github.com/yaml/pyyaml/commit/d6cbff662084dd94bde5421ece495482d1b14454)
 Skip certain unicode tests when maxunicode not > 0x
   - 
[`69103ba`](https://github.com/yaml/pyyaml/commit/69103ba255dd807ecb576654e84bd5efba3bad6e)
 Update .travis.yml to use libyaml 0.2.2
   - 
[`91c9435`](https://github.com/yaml/pyyaml/commit/91c9435bb667dc318c845f5b3e8af36bb84c66eb)
 Squash/merge pull request 
[#105](https://github-redirect.dependabot.com/yaml/pyyaml/issues/105) from 
nnadeau/patch-1
   - 
[`507a464`](https://github.com/yaml/pyyaml/commit/507a464ce62c933bf667b2296a96ad45f0147873)
 Make default_flow_style=False
   - 
[`07c88c6`](https://github.com/yaml/pyyaml/commit/07c88c6c1bee51439a00bc07827980fbb161a1ad)
 Allow to turn off sorting keys in Dumper
   - 
[`611ba39`](https://github.com/yaml/pyyaml/commit/611ba395079026fda2ea67c4ad23eb6351c5aa18)
 Include license file in the generated wheel package
   - 

[GitHub] [incubator-sdap-nexus] dependabot[bot] opened a new pull request #85: Bump pyyaml from 3.12 to 5.1 in /data-access

[GitBox]

dependabot[bot] opened a new pull request #85: Bump pyyaml from 3.12 to 5.1 in 
/data-access
URL: https://github.com/apache/incubator-sdap-nexus/pull/85
 
 
   Bumps [pyyaml](https://github.com/yaml/pyyaml) from 3.12 to 5.1.
   
   Changelog
   
   *Sourced from [pyyaml's 
changelog](https://github.com/yaml/pyyaml/blob/master/CHANGES).*
   
   > 5.1 (2019-03-13)
   > 
   > 
   > * 
[yaml/pyyaml#35](https://github-redirect.dependabot.com/yaml/pyyaml/pull/35) -- 
Some modernization of the test running
   > * 
[yaml/pyyaml#42](https://github-redirect.dependabot.com/yaml/pyyaml/pull/42) -- 
Install tox in a virtualenv
   > * 
[yaml/pyyaml#45](https://github-redirect.dependabot.com/yaml/pyyaml/pull/45) -- 
Allow colon in a plain scalar in a flow context
   > * 
[yaml/pyyaml#48](https://github-redirect.dependabot.com/yaml/pyyaml/pull/48) -- 
Fix typos
   > * 
[yaml/pyyaml#55](https://github-redirect.dependabot.com/yaml/pyyaml/pull/55) -- 
Improve RepresenterError creation
   > * 
[yaml/pyyaml#59](https://github-redirect.dependabot.com/yaml/pyyaml/pull/59) -- 
Resolves [#57](https://github-redirect.dependabot.com/yaml/pyyaml/issues/57), 
update readme issues link
   > * 
[yaml/pyyaml#60](https://github-redirect.dependabot.com/yaml/pyyaml/pull/60) -- 
Document and test Python 3.6 support
   > * 
[yaml/pyyaml#61](https://github-redirect.dependabot.com/yaml/pyyaml/pull/61) -- 
Use Travis CI built in pip cache support
   > * 
[yaml/pyyaml#62](https://github-redirect.dependabot.com/yaml/pyyaml/pull/62) -- 
Remove tox workaround for Travis CI
   > * 
[yaml/pyyaml#63](https://github-redirect.dependabot.com/yaml/pyyaml/pull/63) -- 
Adding support to Unicode characters over codepoint 0x
   > * 
[yaml/pyyaml#65](https://github-redirect.dependabot.com/yaml/pyyaml/pull/65) -- 
Support unicode literals over codepoint 0x
   > * 
[yaml/pyyaml#75](https://github-redirect.dependabot.com/yaml/pyyaml/pull/75) -- 
add 3.12 changelog
   > * 
[yaml/pyyaml#76](https://github-redirect.dependabot.com/yaml/pyyaml/pull/76) -- 
Fallback to Pure Python if Compilation fails
   > * 
[yaml/pyyaml#84](https://github-redirect.dependabot.com/yaml/pyyaml/pull/84) -- 
Drop unsupported Python 3.3
   > * 
[yaml/pyyaml#102](https://github-redirect.dependabot.com/yaml/pyyaml/pull/102) 
-- Include license file in the generated wheel package
   > * 
[yaml/pyyaml#105](https://github-redirect.dependabot.com/yaml/pyyaml/pull/105) 
-- Removed Python 2.6 & 3.3 support
   > * 
[yaml/pyyaml#111](https://github-redirect.dependabot.com/yaml/pyyaml/pull/111) 
-- Remove commented out Psyco code
   > * 
[yaml/pyyaml#129](https://github-redirect.dependabot.com/yaml/pyyaml/pull/129) 
-- Remove call to `ord` in lib3 emitter code
   > * 
[yaml/pyyaml#143](https://github-redirect.dependabot.com/yaml/pyyaml/pull/143) 
-- Allow to turn off sorting keys in Dumper
   > * 
[yaml/pyyaml#149](https://github-redirect.dependabot.com/yaml/pyyaml/pull/149) 
-- Test on Python 3.7-dev
   > * 
[yaml/pyyaml#158](https://github-redirect.dependabot.com/yaml/pyyaml/pull/158) 
-- Support escaped slash in double quotes "\/"
   > * 
[yaml/pyyaml#181](https://github-redirect.dependabot.com/yaml/pyyaml/pull/181) 
-- Import Hashable from collections.abc
   > * 
[yaml/pyyaml#256](https://github-redirect.dependabot.com/yaml/pyyaml/pull/256) 
-- Make default_flow_style=False
   > * 
[yaml/pyyaml#257](https://github-redirect.dependabot.com/yaml/pyyaml/pull/257) 
-- Deprecate yaml.load and add FullLoader and UnsafeLoader classes
   > * 
[yaml/pyyaml#263](https://github-redirect.dependabot.com/yaml/pyyaml/pull/263) 
-- Windows Appveyor build
   > 
   > 3.13 (2018-07-05)
   > -
   > 
   > * Resolved issues around PyYAML working in Python 3.7.
   
   
   Commits
   
   - 
[`e471e86`](https://github.com/yaml/pyyaml/commit/e471e86bf6dabdad45a1438c20a4a5c033eb9034)
 Updates for 5.1 release
   - 
[`9141e90`](https://github.com/yaml/pyyaml/commit/9141e900d10d280173335b20207e87d4a15e62c6)
 Windows Appveyor build
   - 
[`d6cbff6`](https://github.com/yaml/pyyaml/commit/d6cbff662084dd94bde5421ece495482d1b14454)
 Skip certain unicode tests when maxunicode not > 0x
   - 
[`69103ba`](https://github.com/yaml/pyyaml/commit/69103ba255dd807ecb576654e84bd5efba3bad6e)
 Update .travis.yml to use libyaml 0.2.2
   - 
[`91c9435`](https://github.com/yaml/pyyaml/commit/91c9435bb667dc318c845f5b3e8af36bb84c66eb)
 Squash/merge pull request 
[#105](https://github-redirect.dependabot.com/yaml/pyyaml/issues/105) from 
nnadeau/patch-1
   - 
[`507a464`](https://github.com/yaml/pyyaml/commit/507a464ce62c933bf667b2296a96ad45f0147873)
 Make default_flow_style=False
   - 
[`07c88c6`](https://github.com/yaml/pyyaml/commit/07c88c6c1bee51439a00bc07827980fbb161a1ad)
 Allow to turn off sorting keys in Dumper
   - 
[`611ba39`](https://github.com/yaml/pyyaml/commit/611ba395079026fda2ea67c4ad23eb6351c5aa18)
 Include license file in the generated wheel package
   - 

[GitHub] [incubator-sdap-nexus] fgreg merged pull request #84: Pull master into SNAPSHOT

[GitBox]

fgreg merged pull request #84: Pull master into SNAPSHOT
URL: https://github.com/apache/incubator-sdap-nexus/pull/84
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-sdap-nexus] fgreg opened a new pull request #84: Pull master into SNAPSHOT

[GitBox]

fgreg opened a new pull request #84: Pull master into SNAPSHOT
URL: https://github.com/apache/incubator-sdap-nexus/pull/84
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-sdap-nexus] fgreg merged pull request #83: SDAP-192 Create DOMS netCDF reader tool

[GitBox]

fgreg merged pull request #83: SDAP-192 Create DOMS netCDF reader tool
URL: https://github.com/apache/incubator-sdap-nexus/pull/83
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-sdap-nexus] jelya opened a new pull request #83: Sdap 192

[GitBox]

jelya opened a new pull request #83: Sdap 192
URL: https://github.com/apache/incubator-sdap-nexus/pull/83
 
 
   SDAP-192 Updating the documentation for the DOMS netCDF reader tool, adding 
a README.md file.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-sdap-edge] ntquach merged pull request #8: update QC filtering to be only selected quality flags

[GitBox]

ntquach merged pull request #8: update QC filtering to be only selected quality 
flags
URL: https://github.com/apache/incubator-sdap-edge/pull/8
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-sdap-edge] echyam opened a new pull request #8: update QC filtering to be only selected quality flags

[GitBox]

echyam opened a new pull request #8: update QC filtering to be only selected 
quality flags
URL: https://github.com/apache/incubator-sdap-edge/pull/8
 
 
   • don't include higher quality flags, and default to good if not specified
   • also filter SPURS and SPURS2 data, now that good data would be excluded if 
not selected


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-sdap-edge] fgreg merged pull request #7: SDAP-209 Fix mapping of SAMOS quality flag fields

[GitBox]

fgreg merged pull request #7: SDAP-209 Fix mapping of SAMOS quality flag fields
URL: https://github.com/apache/incubator-sdap-edge/pull/7
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-sdap-edge] ntquach opened a new pull request #7: SDAP-209 Fix mapping of SAMOS quality flag fields

[GitBox]

ntquach opened a new pull request #7: SDAP-209 Fix mapping of SAMOS quality 
flag fields
URL: https://github.com/apache/incubator-sdap-edge/pull/7
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services