fgreg commented on a change in pull request #88: SDAP-215 Use k8s as Spark
scheduler and create helm chart
URL:
https://github.com/apache/incubator-sdap-nexus/pull/88#discussion_r352895731
##########
File path: helm/templates/ingress.yaml
##########
@@ -0,0 +1,26 @@
+apiVersion: extensions/v1beta1
+kind: Ingress
+metadata:
+ name: nexus-webapp
+ annotations:
+ kubernetes.io/ingress.class: ingress-nginx
+ nginx.ingress.kubernetes.io/rewrite-target: /$1
+ nginx.ingress.kubernetes.io/proxy-read-timeout: "180"
+ nginx.ingress.kubernetes.io/proxy-send-timeout: "180"
+spec:
+ rules:
+ - host: {{ .Values.host }}
+ http:
+ paths:
+ - path: /
Review comment:
I'd actually remove this by default. The way the root-webpage is setup
currently causes the application to return 200 OK for any path requested (the
intent was for just /) and it will cause many false-positives for security
scans.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
