Review Request 68661: SENTRY-2394: Fixed typo in sentry-site.xml.service.template

2018-09-06 Thread Morio Ramdenbourg via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68661/
---

Review request for sentry, Arjun Mishra, Steve Moist, and Sergio Pena.


Bugs: https://issues.apache.org/jira/browse/SENTRY-2394

https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/SENTRY-2394


Repository: sentry


Description
---

[SENTRY-2394](https://issues.apache.org/jira/browse/SENTRY-2394): Fixed typo in 
sentry-site.xml.service.template


Diffs
-

  conf/sentry-site.xml.service.template 
e4916600a9a8f182cf50ac57a19099224926f93b 


Diff: https://reviews.apache.org/r/68661/diff/1/


Testing
---


Thanks,

Morio Ramdenbourg

Re: Review Request 68657: SENTRY-2392: Add metrics statistics to list_user_privileges and list_role_privileges API

2018-09-06 Thread Sergio Pena via Review Board 


> On Sept. 6, 2018, 5:56 p.m., Steve Moist wrote:
> > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java
> > Line 1397 (original), 1397 (patched)
> > 
> >
> > Shouldn't there be a finally block here to stop the timer?

It is using try-with-resources which closes the object inside the try() 
sentence.


- Sergio


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68657/#review208414
---


On Sept. 6, 2018, 2:57 p.m., Sergio Pena wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68657/
> ---
> 
> (Updated Sept. 6, 2018, 2:57 p.m.)
> 
> 
> Review request for sentry, Arjun Mishra, kalyan kumar kalvagadda, and Na Li.
> 
> 
> Bugs: sentry-2392
> https://issues.apache.org/jira/browse/sentry-2392
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> Add some metric statistics to the new SentryPolicyStoreProcessor API that 
> returns a list of users and roles privileges. This would be good to collect 
> in order to understand how this API is used.
> 
> 
> Diffs
> -
> 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryMetrics.java
>  35c7d079be3de8d0cf7e8067d4b5ef46c10f8d72 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java
>  008a48efc0b1a2a8703a301c85cf0068dd171f38 
> 
> 
> Diff: https://reviews.apache.org/r/68657/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Sergio Pena
> 
>

Re: Review Request 68657: SENTRY-2392: Add metrics statistics to list_user_privileges and list_role_privileges API

2018-09-06 Thread Steve Moist via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68657/#review208414
---




sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java
Line 1397 (original), 1397 (patched)


Shouldn't there be a finally block here to stop the timer?


- Steve Moist


On Sept. 6, 2018, 2:57 p.m., Sergio Pena wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68657/
> ---
> 
> (Updated Sept. 6, 2018, 2:57 p.m.)
> 
> 
> Review request for sentry, Arjun Mishra, kalyan kumar kalvagadda, and Na Li.
> 
> 
> Bugs: sentry-2392
> https://issues.apache.org/jira/browse/sentry-2392
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> Add some metric statistics to the new SentryPolicyStoreProcessor API that 
> returns a list of users and roles privileges. This would be good to collect 
> in order to understand how this API is used.
> 
> 
> Diffs
> -
> 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryMetrics.java
>  35c7d079be3de8d0cf7e8067d4b5ef46c10f8d72 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java
>  008a48efc0b1a2a8703a301c85cf0068dd171f38 
> 
> 
> Diff: https://reviews.apache.org/r/68657/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Sergio Pena
> 
>

Re: Review Request 68647: SENTRY-2375: Fixed typos in listPrivilegesbyAuthorizable and getAllPrivilegesbyAuthorizable APIs

2018-09-06 Thread Steve Moist via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68647/#review208413
---


Ship it!




Ship It!

- Steve Moist


On Sept. 6, 2018, 5:36 a.m., Morio Ramdenbourg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68647/
> ---
> 
> (Updated Sept. 6, 2018, 5:36 a.m.)
> 
> 
> Review request for sentry, Arjun Mishra, Steve Moist, and Sergio Pena.
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> [SENTRY-2375](https://issues.apache.org/jira/browse/SENTRY-2375): Fixed typos 
> in listPrivilegesbyAuthorizable and getAllPrivilegesbyAuthorizable APIs
> 
> 
> Diffs
> -
> 
>   
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/DefaultSentryAccessController.java
>  5db796dd45fcc026bfbbd17173b4c54d8051611e 
>   
> sentry-service/sentry-service-api/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyServiceClient.java
>  3ef1624e824881489fbf0798d7d1d0fa7688e5f0 
>   
> sentry-service/sentry-service-api/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyServiceClientDefaultImpl.java
>  a2213ae35e62b15f649940ab24ff90cc87f0cd90 
>   
> sentry-service/sentry-service-server/src/test/java/org/apache/sentry/api/service/thrift/TestSentryServiceIntegration.java
>  73fca848ba333aa4d7d7198f82c5bd03c09c0791 
> 
> 
> Diff: https://reviews.apache.org/r/68647/diff/1/
> 
> 
> Testing
> ---
> 
> Ran the test phase (mvn clean install) from the root level successfully.
> 
> 
> Thanks,
> 
> Morio Ramdenbourg
> 
>

Re: Review Request 68657: SENTRY-2392: Add metrics statistics to list_user_privileges and list_role_privileges API

2018-09-06 Thread Na Li via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68657/#review208409
---


Ship it!




Ship It!

- Na Li


On Sept. 6, 2018, 2:57 p.m., Sergio Pena wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68657/
> ---
> 
> (Updated Sept. 6, 2018, 2:57 p.m.)
> 
> 
> Review request for sentry, Arjun Mishra, kalyan kumar kalvagadda, and Na Li.
> 
> 
> Bugs: sentry-2392
> https://issues.apache.org/jira/browse/sentry-2392
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> Add some metric statistics to the new SentryPolicyStoreProcessor API that 
> returns a list of users and roles privileges. This would be good to collect 
> in order to understand how this API is used.
> 
> 
> Diffs
> -
> 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryMetrics.java
>  35c7d079be3de8d0cf7e8067d4b5ef46c10f8d72 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java
>  008a48efc0b1a2a8703a301c85cf0068dd171f38 
> 
> 
> Diff: https://reviews.apache.org/r/68657/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Sergio Pena
> 
>

Review Request 68657: SENTRY-2392: Add metrics statistics to list_user_privileges and list_role_privileges API

2018-09-06 Thread Sergio Pena via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68657/
---

Review request for sentry, Arjun Mishra, kalyan kumar kalvagadda, and Na Li.


Bugs: sentry-2392
https://issues.apache.org/jira/browse/sentry-2392


Repository: sentry


Description
---

Add some metric statistics to the new SentryPolicyStoreProcessor API that 
returns a list of users and roles privileges. This would be good to collect in 
order to understand how this API is used.


Diffs
-

  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryMetrics.java
 35c7d079be3de8d0cf7e8067d4b5ef46c10f8d72 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java
 008a48efc0b1a2a8703a301c85cf0068dd171f38 


Diff: https://reviews.apache.org/r/68657/diff/1/


Testing
---


Thanks,

Sergio Pena

Re: Review Request 68647: SENTRY-2375: Fixed typos in listPrivilegesbyAuthorizable and getAllPrivilegesbyAuthorizable APIs

2018-09-06 Thread Arjun Mishra via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68647/#review208408
---


Ship it!




Ship It!

- Arjun Mishra


On Sept. 6, 2018, 5:36 a.m., Morio Ramdenbourg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68647/
> ---
> 
> (Updated Sept. 6, 2018, 5:36 a.m.)
> 
> 
> Review request for sentry, Arjun Mishra, Steve Moist, and Sergio Pena.
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> [SENTRY-2375](https://issues.apache.org/jira/browse/SENTRY-2375): Fixed typos 
> in listPrivilegesbyAuthorizable and getAllPrivilegesbyAuthorizable APIs
> 
> 
> Diffs
> -
> 
>   
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/DefaultSentryAccessController.java
>  5db796dd45fcc026bfbbd17173b4c54d8051611e 
>   
> sentry-service/sentry-service-api/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyServiceClient.java
>  3ef1624e824881489fbf0798d7d1d0fa7688e5f0 
>   
> sentry-service/sentry-service-api/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyServiceClientDefaultImpl.java
>  a2213ae35e62b15f649940ab24ff90cc87f0cd90 
>   
> sentry-service/sentry-service-server/src/test/java/org/apache/sentry/api/service/thrift/TestSentryServiceIntegration.java
>  73fca848ba333aa4d7d7198f82c5bd03c09c0791 
> 
> 
> Diff: https://reviews.apache.org/r/68647/diff/1/
> 
> 
> Testing
> ---
> 
> Ran the test phase (mvn clean install) from the root level successfully.
> 
> 
> Thanks,
> 
> Morio Ramdenbourg
> 
>