Re: Review Request 63086: SENTRY-1993: StringIndexOutOfBoundsException in HMSPathsDumper.java
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63086/#review188866 --- Ship it! New patch added call to hmsPaths.addPathsToAuthzObject(), which allows passing paths with empty elements. This is a public API, so it should be used for other tests too, but this will be addressed by another JIRA. For the scope of this JIRA, it would cause StringIndexOutOfBoundsException without Misha's fix, so now we directly test the fix. - Vadim Spector On Oct. 20, 2017, 7:14 p.m., Misha Dmitriev wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63086/ > --- > > (Updated Oct. 20, 2017, 7:14 p.m.) > > > Review request for sentry, Alexander Kolbasov and Vadim Spector. > > > Bugs: SENTRY-1993 > https://issues.apache.org/jira/browse/SENTRY-1993 > > > Repository: sentry > > > Description > --- > > SENTRY-1993: StringIndexOutOfBoundsException in HMSPathsDumper.java > > > Diffs > - > > > sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPathsDumper.java > 1267093dbbdeb291ec01ecdc87253a90e8ab98ac > > sentry-hdfs/sentry-hdfs-common/src/test/java/org/apache/sentry/hdfs/TestHMSPathsFullDump.java > 6a4e32f6ad180bc1c2ecb6d0be7cdae6c586505d > > > Diff: https://reviews.apache.org/r/63086/diff/2/ > > > Testing > --- > > > Thanks, > > Misha Dmitriev > >
Re: Review Request 63086: SENTRY-1993: StringIndexOutOfBoundsException in HMSPathsDumper.java
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63086/ --- (Updated Oct. 20, 2017, 7:14 p.m.) Review request for sentry, Alexander Kolbasov and Vadim Spector. Changes --- Updates from Vadim Spector's patch SENTRY-1993.02.patch in SENTRY-1993 jira. Bugs: SENTRY-1993 https://issues.apache.org/jira/browse/SENTRY-1993 Repository: sentry Description --- SENTRY-1993: StringIndexOutOfBoundsException in HMSPathsDumper.java Diffs (updated) - sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPathsDumper.java 1267093dbbdeb291ec01ecdc87253a90e8ab98ac sentry-hdfs/sentry-hdfs-common/src/test/java/org/apache/sentry/hdfs/TestHMSPathsFullDump.java 6a4e32f6ad180bc1c2ecb6d0be7cdae6c586505d Diff: https://reviews.apache.org/r/63086/diff/2/ Changes: https://reviews.apache.org/r/63086/diff/1-2/ Testing --- Thanks, Misha Dmitriev
Re: Review Request 63086: SENTRY-1993: StringIndexOutOfBoundsException in HMSPathsDumper.java
> On Oct. 18, 2017, 2:44 p.m., Vadim Spector wrote: > > Ship It! I'll proceed with commit today - Vadim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63086/#review188492 --- On Oct. 17, 2017, 7:12 p.m., Misha Dmitriev wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63086/ > --- > > (Updated Oct. 17, 2017, 7:12 p.m.) > > > Review request for sentry, Alexander Kolbasov and Vadim Spector. > > > Bugs: SENTRY-1993 > https://issues.apache.org/jira/browse/SENTRY-1993 > > > Repository: sentry > > > Description > --- > > SENTRY-1993: StringIndexOutOfBoundsException in HMSPathsDumper.java > > > Diffs > - > > > sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPathsDumper.java > 1267093dbbdeb291ec01ecdc87253a90e8ab98ac > > sentry-hdfs/sentry-hdfs-common/src/test/java/org/apache/sentry/hdfs/TestHMSPathsFullDump.java > 6a4e32f6ad180bc1c2ecb6d0be7cdae6c586505d > > > Diff: https://reviews.apache.org/r/63086/diff/1/ > > > Testing > --- > > > Thanks, > > Misha Dmitriev > >
Re: Review Request 63086: SENTRY-1993: StringIndexOutOfBoundsException in HMSPathsDumper.java
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63086/#review188492 --- Ship it! Ship It! - Vadim Spector On Oct. 17, 2017, 7:12 p.m., Misha Dmitriev wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63086/ > --- > > (Updated Oct. 17, 2017, 7:12 p.m.) > > > Review request for sentry, Alexander Kolbasov and Vadim Spector. > > > Bugs: SENTRY-1993 > https://issues.apache.org/jira/browse/SENTRY-1993 > > > Repository: sentry > > > Description > --- > > SENTRY-1993: StringIndexOutOfBoundsException in HMSPathsDumper.java > > > Diffs > - > > > sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPathsDumper.java > 1267093dbbdeb291ec01ecdc87253a90e8ab98ac > > sentry-hdfs/sentry-hdfs-common/src/test/java/org/apache/sentry/hdfs/TestHMSPathsFullDump.java > 6a4e32f6ad180bc1c2ecb6d0be7cdae6c586505d > > > Diff: https://reviews.apache.org/r/63086/diff/1/ > > > Testing > --- > > > Thanks, > > Misha Dmitriev > >
Re: Review Request 63086: SENTRY-1993: StringIndexOutOfBoundsException in HMSPathsDumper.java
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63086/#review188491 --- Ship it! Ship It! - Sergio Pena On Oct. 17, 2017, 7:12 p.m., Misha Dmitriev wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63086/ > --- > > (Updated Oct. 17, 2017, 7:12 p.m.) > > > Review request for sentry, Alexander Kolbasov and Vadim Spector. > > > Bugs: SENTRY-1993 > https://issues.apache.org/jira/browse/SENTRY-1993 > > > Repository: sentry > > > Description > --- > > SENTRY-1993: StringIndexOutOfBoundsException in HMSPathsDumper.java > > > Diffs > - > > > sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPathsDumper.java > 1267093dbbdeb291ec01ecdc87253a90e8ab98ac > > sentry-hdfs/sentry-hdfs-common/src/test/java/org/apache/sentry/hdfs/TestHMSPathsFullDump.java > 6a4e32f6ad180bc1c2ecb6d0be7cdae6c586505d > > > Diff: https://reviews.apache.org/r/63086/diff/1/ > > > Testing > --- > > > Thanks, > > Misha Dmitriev > >
Re: Review Request 63086: SENTRY-1993: StringIndexOutOfBoundsException in HMSPathsDumper.java
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63086/#review188432 --- Ship it! Ship It! - Alexander Kolbasov On Oct. 17, 2017, 7:12 p.m., Misha Dmitriev wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63086/ > --- > > (Updated Oct. 17, 2017, 7:12 p.m.) > > > Review request for sentry, Alexander Kolbasov and Vadim Spector. > > > Bugs: SENTRY-1993 > https://issues.apache.org/jira/browse/SENTRY-1993 > > > Repository: sentry > > > Description > --- > > SENTRY-1993: StringIndexOutOfBoundsException in HMSPathsDumper.java > > > Diffs > - > > > sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPathsDumper.java > 1267093dbbdeb291ec01ecdc87253a90e8ab98ac > > sentry-hdfs/sentry-hdfs-common/src/test/java/org/apache/sentry/hdfs/TestHMSPathsFullDump.java > 6a4e32f6ad180bc1c2ecb6d0be7cdae6c586505d > > > Diff: https://reviews.apache.org/r/63086/diff/1/ > > > Testing > --- > > > Thanks, > > Misha Dmitriev > >
