Re: Review Request 64241: SENTRY-2081: Update the LICENSE.txt with the license information of distributed jars

2017-12-01 Thread kalyan kumar kalvagadda via Review Board 


> On Dec. 1, 2017, 10:28 p.m., Alexander Kolbasov wrote:
> > LICENSE.txt
> > Line 214 (original)
> > 
> >
> > Should theLICENSE.txt include copyrights as well or not? Looks like you 
> > are removing some copyrights.

previously we has some licenses embedded here. Now, we are adding pointers to 
the licences. 
"For details, see the associated license in 
sentry-dist/src/main/resources/licenses/BSD_License.txt"


> On Dec. 1, 2017, 10:28 p.m., Alexander Kolbasov wrote:
> > README_license.txt
> > Lines 11 (patched)
> > 
> >
> > Does it run during every build or it should be manually invoked?

It run's on every build in package phase of mvn


> On Dec. 1, 2017, 10:28 p.m., Alexander Kolbasov wrote:
> > README_license.txt
> > Lines 34 (patched)
> > 
> >
> > Is there anything that checks correctness of pointers? What would 
> > happen if release manager forgets to add the file?

I will be adding this in the release process in the Wiki.


- kalyan kumar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64241/#review192558
---


On Dec. 1, 2017, 11:12 p.m., kalyan kumar kalvagadda wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64241/
> ---
> 
> (Updated Dec. 1, 2017, 11:12 p.m.)
> 
> 
> Review request for sentry, Alexander Kolbasov, Brian Towles, Colm O 
> hEigeartaigh, and Sergio Pena.
> 
> 
> Bugs: SENTRY-2081
> https://issues.apache.org/jira/browse/SENTRY-2081
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> As per https://www.apache.org/dev/licensing-howto.html , sentry should update 
> the LICENSE.txt file with license information of all the jars that sentry is 
> distributing along with the pointer to the LICENSE files of the dependencies.
> 
> 
> Diffs
> -
> 
>   LICENSE.txt b794ae6604774186020a1cf3dde922e92da57276 
>   README_license.txt PRE-CREATION 
>   pom.xml eec185bc6409e5cebee12f3a0e4ca17c843cd631 
>   sentry-dist/pom.xml 4c69535660b132943c7cdc2419fff140a0909a48 
>   sentry-dist/src/license/THIRD-PARTY.ftl PRE-CREATION 
>   sentry-dist/src/license/THIRD-PARTY.properties PRE-CREATION 
>   sentry-dist/src/license/override-THIRD-PARTY.properties PRE-CREATION 
>   sentry-dist/src/main/assembly/bin.xml 
> 5727fc964bc139a5bd5490132efad13db6cbcf44 
>   sentry-dist/src/main/resources/licences/BSD_2-clause.txt PRE-CREATION 
>   sentry-dist/src/main/resources/licences/BSD_License.txt PRE-CREATION 
>   sentry-dist/src/main/resources/licences/CDDL_1_0.txt PRE-CREATION 
>   sentry-dist/src/main/resources/licences/CDDL_1_1.txt PRE-CREATION 
>   sentry-dist/src/main/resources/licences/CDDL_2.txt PRE-CREATION 
>   
> sentry-dist/src/main/resources/licences/Eclipse_Public_License_-_Version_1_0.txt
>  PRE-CREATION 
>   sentry-dist/src/main/resources/licences/MIT_License.txt PRE-CREATION 
>   
> sentry-dist/src/main/resources/licences/Mozilla_Public_License_Version_1_1.txt
>  PRE-CREATION 
>   sentry-dist/src/main/resources/licences/The_BSD_3-Clause_License.txt 
> PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/64241/diff/8/
> 
> 
> Testing
> ---
> 
> Made sure that LICENSE.txt file generated in sentry-dist/target directory has 
> the license informaion of all the jars that sentry is distributing.
> 
> 
> Thanks,
> 
> kalyan kumar kalvagadda
> 
>

Re: Review Request 64241: SENTRY-2081: Update the LICENSE.txt with the license information of distributed jars

2017-12-01 Thread Alexander Kolbasov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64241/#review192594
---


Ship it!




Ship It!

- Alexander Kolbasov


On Dec. 1, 2017, 11:12 p.m., kalyan kumar kalvagadda wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64241/
> ---
> 
> (Updated Dec. 1, 2017, 11:12 p.m.)
> 
> 
> Review request for sentry, Alexander Kolbasov, Brian Towles, Colm O 
> hEigeartaigh, and Sergio Pena.
> 
> 
> Bugs: SENTRY-2081
> https://issues.apache.org/jira/browse/SENTRY-2081
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> As per https://www.apache.org/dev/licensing-howto.html , sentry should update 
> the LICENSE.txt file with license information of all the jars that sentry is 
> distributing along with the pointer to the LICENSE files of the dependencies.
> 
> 
> Diffs
> -
> 
>   LICENSE.txt b794ae6604774186020a1cf3dde922e92da57276 
>   README_license.txt PRE-CREATION 
>   pom.xml eec185bc6409e5cebee12f3a0e4ca17c843cd631 
>   sentry-dist/pom.xml 4c69535660b132943c7cdc2419fff140a0909a48 
>   sentry-dist/src/license/THIRD-PARTY.ftl PRE-CREATION 
>   sentry-dist/src/license/THIRD-PARTY.properties PRE-CREATION 
>   sentry-dist/src/license/override-THIRD-PARTY.properties PRE-CREATION 
>   sentry-dist/src/main/assembly/bin.xml 
> 5727fc964bc139a5bd5490132efad13db6cbcf44 
>   sentry-dist/src/main/resources/licences/BSD_2-clause.txt PRE-CREATION 
>   sentry-dist/src/main/resources/licences/BSD_License.txt PRE-CREATION 
>   sentry-dist/src/main/resources/licences/CDDL_1_0.txt PRE-CREATION 
>   sentry-dist/src/main/resources/licences/CDDL_1_1.txt PRE-CREATION 
>   sentry-dist/src/main/resources/licences/CDDL_2.txt PRE-CREATION 
>   
> sentry-dist/src/main/resources/licences/Eclipse_Public_License_-_Version_1_0.txt
>  PRE-CREATION 
>   sentry-dist/src/main/resources/licences/MIT_License.txt PRE-CREATION 
>   
> sentry-dist/src/main/resources/licences/Mozilla_Public_License_Version_1_1.txt
>  PRE-CREATION 
>   sentry-dist/src/main/resources/licences/The_BSD_3-Clause_License.txt 
> PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/64241/diff/8/
> 
> 
> Testing
> ---
> 
> Made sure that LICENSE.txt file generated in sentry-dist/target directory has 
> the license informaion of all the jars that sentry is distributing.
> 
> 
> Thanks,
> 
> kalyan kumar kalvagadda
> 
>

Re: Review Request 64241: SENTRY-2081: Update the LICENSE.txt with the license information of distributed jars

2017-12-01 Thread kalyan kumar kalvagadda via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64241/
---

(Updated Dec. 1, 2017, 11:12 p.m.)


Review request for sentry, Alexander Kolbasov, Brian Towles, Colm O 
hEigeartaigh, and Sergio Pena.


Changes
---

addressed sasha's comments


Bugs: SENTRY-2081
https://issues.apache.org/jira/browse/SENTRY-2081


Repository: sentry


Description
---

As per https://www.apache.org/dev/licensing-howto.html , sentry should update 
the LICENSE.txt file with license information of all the jars that sentry is 
distributing along with the pointer to the LICENSE files of the dependencies.


Diffs (updated)
-

  LICENSE.txt b794ae6604774186020a1cf3dde922e92da57276 
  README_license.txt PRE-CREATION 
  pom.xml eec185bc6409e5cebee12f3a0e4ca17c843cd631 
  sentry-dist/pom.xml 4c69535660b132943c7cdc2419fff140a0909a48 
  sentry-dist/src/license/THIRD-PARTY.ftl PRE-CREATION 
  sentry-dist/src/license/THIRD-PARTY.properties PRE-CREATION 
  sentry-dist/src/license/override-THIRD-PARTY.properties PRE-CREATION 
  sentry-dist/src/main/assembly/bin.xml 
5727fc964bc139a5bd5490132efad13db6cbcf44 
  sentry-dist/src/main/resources/licences/BSD_2-clause.txt PRE-CREATION 
  sentry-dist/src/main/resources/licences/BSD_License.txt PRE-CREATION 
  sentry-dist/src/main/resources/licences/CDDL_1_0.txt PRE-CREATION 
  sentry-dist/src/main/resources/licences/CDDL_1_1.txt PRE-CREATION 
  sentry-dist/src/main/resources/licences/CDDL_2.txt PRE-CREATION 
  
sentry-dist/src/main/resources/licences/Eclipse_Public_License_-_Version_1_0.txt
 PRE-CREATION 
  sentry-dist/src/main/resources/licences/MIT_License.txt PRE-CREATION 
  
sentry-dist/src/main/resources/licences/Mozilla_Public_License_Version_1_1.txt 
PRE-CREATION 
  sentry-dist/src/main/resources/licences/The_BSD_3-Clause_License.txt 
PRE-CREATION 


Diff: https://reviews.apache.org/r/64241/diff/8/

Changes: https://reviews.apache.org/r/64241/diff/7-8/


Testing
---

Made sure that LICENSE.txt file generated in sentry-dist/target directory has 
the license informaion of all the jars that sentry is distributing.


Thanks,

kalyan kumar kalvagadda

Re: Review Request 64241: SENTRY-2081: Update the LICENSE.txt with the license information of distributed jars

2017-12-01 Thread Alexander Kolbasov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64241/#review192558
---




LICENSE.txt
Line 214 (original)


Should theLICENSE.txt include copyrights as well or not? Looks like you are 
removing some copyrights.



README_license.txt
Lines 9 (patched)


s/in places/in place



README_license.txt
Lines 10 (patched)


s/build/built



README_license.txt
Lines 11 (patched)


Does it run during every build or it should be manually invoked?



README_license.txt
Lines 12 (patched)


Before you say 'we' and here it is 'you'. Please be consistent



README_license.txt
Lines 14 (patched)


I think third party is two words. Also this doesn't look like an item from 
enumeration, just the description text, so this should be moved to the top 
level paragraph.



README_license.txt
Lines 16 (patched)


with licenses listed below



README_license.txt
Lines 34 (patched)


Is there anything that checks correctness of pointers? What would happen if 
release manager forgets to add the file?



pom.xml
Lines 734 (patched)


This looks like an unrelated change - can you move this to a different JIRA?


- Alexander Kolbasov


On Dec. 1, 2017, 9:29 p.m., kalyan kumar kalvagadda wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64241/
> ---
> 
> (Updated Dec. 1, 2017, 9:29 p.m.)
> 
> 
> Review request for sentry, Alexander Kolbasov, Brian Towles, Colm O 
> hEigeartaigh, and Sergio Pena.
> 
> 
> Bugs: SENTRY-2081
> https://issues.apache.org/jira/browse/SENTRY-2081
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> As per https://www.apache.org/dev/licensing-howto.html , sentry should update 
> the LICENSE.txt file with license information of all the jars that sentry is 
> distributing along with the pointer to the LICENSE files of the dependencies.
> 
> 
> Diffs
> -
> 
>   LICENSE.txt b794ae6604774186020a1cf3dde922e92da57276 
>   README_license.txt PRE-CREATION 
>   pom.xml eec185bc6409e5cebee12f3a0e4ca17c843cd631 
>   sentry-dist/pom.xml 4c69535660b132943c7cdc2419fff140a0909a48 
>   sentry-dist/src/license/THIRD-PARTY.ftl PRE-CREATION 
>   sentry-dist/src/license/THIRD-PARTY.properties PRE-CREATION 
>   sentry-dist/src/license/override-THIRD-PARTY.properties PRE-CREATION 
>   sentry-dist/src/main/assembly/bin.xml 
> 5727fc964bc139a5bd5490132efad13db6cbcf44 
>   sentry-dist/src/main/resources/licences/BSD_2-clause.txt PRE-CREATION 
>   sentry-dist/src/main/resources/licences/BSD_License.txt PRE-CREATION 
>   sentry-dist/src/main/resources/licences/CDDL_1_0.txt PRE-CREATION 
>   sentry-dist/src/main/resources/licences/CDDL_1_1.txt PRE-CREATION 
>   sentry-dist/src/main/resources/licences/CDDL_2.txt PRE-CREATION 
>   
> sentry-dist/src/main/resources/licences/Eclipse_Public_License_-_Version_1_0.txt
>  PRE-CREATION 
>   sentry-dist/src/main/resources/licences/MIT_License.txt PRE-CREATION 
>   
> sentry-dist/src/main/resources/licences/Mozilla_Public_License_Version_1_1.txt
>  PRE-CREATION 
>   sentry-dist/src/main/resources/licences/The_BSD_3-Clause_License.txt 
> PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/64241/diff/7/
> 
> 
> Testing
> ---
> 
> Made sure that LICENSE.txt file generated in sentry-dist/target directory has 
> the license informaion of all the jars that sentry is distributing.
> 
> 
> Thanks,
> 
> kalyan kumar kalvagadda
> 
>

Re: Review Request 64241: SENTRY-2081: Update the LICENSE.txt with the license information of distributed jars

2017-12-01 Thread Sergio Pena via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64241/#review192575
---


Ship it!




Ship It!

- Sergio Pena


On Dec. 1, 2017, 9:29 p.m., kalyan kumar kalvagadda wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64241/
> ---
> 
> (Updated Dec. 1, 2017, 9:29 p.m.)
> 
> 
> Review request for sentry, Alexander Kolbasov, Brian Towles, Colm O 
> hEigeartaigh, and Sergio Pena.
> 
> 
> Bugs: SENTRY-2081
> https://issues.apache.org/jira/browse/SENTRY-2081
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> As per https://www.apache.org/dev/licensing-howto.html , sentry should update 
> the LICENSE.txt file with license information of all the jars that sentry is 
> distributing along with the pointer to the LICENSE files of the dependencies.
> 
> 
> Diffs
> -
> 
>   LICENSE.txt b794ae6604774186020a1cf3dde922e92da57276 
>   README_license.txt PRE-CREATION 
>   pom.xml eec185bc6409e5cebee12f3a0e4ca17c843cd631 
>   sentry-dist/pom.xml 4c69535660b132943c7cdc2419fff140a0909a48 
>   sentry-dist/src/license/THIRD-PARTY.ftl PRE-CREATION 
>   sentry-dist/src/license/THIRD-PARTY.properties PRE-CREATION 
>   sentry-dist/src/license/override-THIRD-PARTY.properties PRE-CREATION 
>   sentry-dist/src/main/assembly/bin.xml 
> 5727fc964bc139a5bd5490132efad13db6cbcf44 
>   sentry-dist/src/main/resources/licences/BSD_2-clause.txt PRE-CREATION 
>   sentry-dist/src/main/resources/licences/BSD_License.txt PRE-CREATION 
>   sentry-dist/src/main/resources/licences/CDDL_1_0.txt PRE-CREATION 
>   sentry-dist/src/main/resources/licences/CDDL_1_1.txt PRE-CREATION 
>   sentry-dist/src/main/resources/licences/CDDL_2.txt PRE-CREATION 
>   
> sentry-dist/src/main/resources/licences/Eclipse_Public_License_-_Version_1_0.txt
>  PRE-CREATION 
>   sentry-dist/src/main/resources/licences/MIT_License.txt PRE-CREATION 
>   
> sentry-dist/src/main/resources/licences/Mozilla_Public_License_Version_1_1.txt
>  PRE-CREATION 
>   sentry-dist/src/main/resources/licences/The_BSD_3-Clause_License.txt 
> PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/64241/diff/7/
> 
> 
> Testing
> ---
> 
> Made sure that LICENSE.txt file generated in sentry-dist/target directory has 
> the license informaion of all the jars that sentry is distributing.
> 
> 
> Thanks,
> 
> kalyan kumar kalvagadda
> 
>

Re: Review Request 64241: SENTRY-2081: Update the LICENSE.txt with the license information of distributed jars

2017-12-01 Thread kalyan kumar kalvagadda via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64241/
---

(Updated Dec. 1, 2017, 9:29 p.m.)


Review request for sentry, Alexander Kolbasov, Brian Towles, Colm O 
hEigeartaigh, and Sergio Pena.


Changes
---

addressed review comment from sergio.


Bugs: SENTRY-2081
https://issues.apache.org/jira/browse/SENTRY-2081


Repository: sentry


Description
---

As per https://www.apache.org/dev/licensing-howto.html , sentry should update 
the LICENSE.txt file with license information of all the jars that sentry is 
distributing along with the pointer to the LICENSE files of the dependencies.


Diffs (updated)
-

  LICENSE.txt b794ae6604774186020a1cf3dde922e92da57276 
  README_license.txt PRE-CREATION 
  pom.xml eec185bc6409e5cebee12f3a0e4ca17c843cd631 
  sentry-dist/pom.xml 4c69535660b132943c7cdc2419fff140a0909a48 
  sentry-dist/src/license/THIRD-PARTY.ftl PRE-CREATION 
  sentry-dist/src/license/THIRD-PARTY.properties PRE-CREATION 
  sentry-dist/src/license/override-THIRD-PARTY.properties PRE-CREATION 
  sentry-dist/src/main/assembly/bin.xml 
5727fc964bc139a5bd5490132efad13db6cbcf44 
  sentry-dist/src/main/resources/licences/BSD_2-clause.txt PRE-CREATION 
  sentry-dist/src/main/resources/licences/BSD_License.txt PRE-CREATION 
  sentry-dist/src/main/resources/licences/CDDL_1_0.txt PRE-CREATION 
  sentry-dist/src/main/resources/licences/CDDL_1_1.txt PRE-CREATION 
  sentry-dist/src/main/resources/licences/CDDL_2.txt PRE-CREATION 
  
sentry-dist/src/main/resources/licences/Eclipse_Public_License_-_Version_1_0.txt
 PRE-CREATION 
  sentry-dist/src/main/resources/licences/MIT_License.txt PRE-CREATION 
  
sentry-dist/src/main/resources/licences/Mozilla_Public_License_Version_1_1.txt 
PRE-CREATION 
  sentry-dist/src/main/resources/licences/The_BSD_3-Clause_License.txt 
PRE-CREATION 


Diff: https://reviews.apache.org/r/64241/diff/7/

Changes: https://reviews.apache.org/r/64241/diff/6-7/


Testing
---

Made sure that LICENSE.txt file generated in sentry-dist/target directory has 
the license informaion of all the jars that sentry is distributing.


Thanks,

kalyan kumar kalvagadda

Re: Review Request 64241: SENTRY-2081: Update the LICENSE.txt with the license information of distributed jars

2017-12-01 Thread Sergio Pena via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64241/#review192552
---




README_licesence.me
Lines 1 (patched)


You named with an incorrect file extension 'README_licesence.me'

Btw, instead of using .md, let's use .txt. .md uses a rich-text format file 
which can be displayed in Github pretty nice. This file is not using that 
format. There are some guidelines for links, lines, headers. Let's use .txt for 
now unless you want it to display it nice on github?


- Sergio Pena


On Dec. 1, 2017, 8:50 p.m., kalyan kumar kalvagadda wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64241/
> ---
> 
> (Updated Dec. 1, 2017, 8:50 p.m.)
> 
> 
> Review request for sentry, Alexander Kolbasov, Brian Towles, Colm O 
> hEigeartaigh, and Sergio Pena.
> 
> 
> Bugs: SENTRY-2081
> https://issues.apache.org/jira/browse/SENTRY-2081
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> As per https://www.apache.org/dev/licensing-howto.html , sentry should update 
> the LICENSE.txt file with license information of all the jars that sentry is 
> distributing along with the pointer to the LICENSE files of the dependencies.
> 
> 
> Diffs
> -
> 
>   LICENSE.txt b794ae6604774186020a1cf3dde922e92da57276 
>   README_licesence.me PRE-CREATION 
>   pom.xml eec185bc6409e5cebee12f3a0e4ca17c843cd631 
>   sentry-dist/pom.xml 4c69535660b132943c7cdc2419fff140a0909a48 
>   sentry-dist/src/license/THIRD-PARTY.ftl PRE-CREATION 
>   sentry-dist/src/license/THIRD-PARTY.properties PRE-CREATION 
>   sentry-dist/src/license/override-THIRD-PARTY.properties PRE-CREATION 
>   sentry-dist/src/main/assembly/bin.xml 
> 5727fc964bc139a5bd5490132efad13db6cbcf44 
>   sentry-dist/src/main/resources/licences/BSD_2-clause.txt PRE-CREATION 
>   sentry-dist/src/main/resources/licences/BSD_License.txt PRE-CREATION 
>   sentry-dist/src/main/resources/licences/CDDL_1_0.txt PRE-CREATION 
>   sentry-dist/src/main/resources/licences/CDDL_1_1.txt PRE-CREATION 
>   sentry-dist/src/main/resources/licences/CDDL_2.txt PRE-CREATION 
>   
> sentry-dist/src/main/resources/licences/Eclipse_Public_License_-_Version_1_0.txt
>  PRE-CREATION 
>   sentry-dist/src/main/resources/licences/MIT_License.txt PRE-CREATION 
>   
> sentry-dist/src/main/resources/licences/Mozilla_Public_License_Version_1_1.txt
>  PRE-CREATION 
>   sentry-dist/src/main/resources/licences/The_BSD_3-Clause_License.txt 
> PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/64241/diff/6/
> 
> 
> Testing
> ---
> 
> Made sure that LICENSE.txt file generated in sentry-dist/target directory has 
> the license informaion of all the jars that sentry is distributing.
> 
> 
> Thanks,
> 
> kalyan kumar kalvagadda
> 
>

Re: Review Request 64241: SENTRY-2081: Update the LICENSE.txt with the license information of distributed jars

2017-12-01 Thread kalyan kumar kalvagadda via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64241/
---

(Updated Dec. 1, 2017, 8:50 p.m.)


Review request for sentry, Alexander Kolbasov, Brian Towles, Colm O 
hEigeartaigh, and Sergio Pena.


Changes
---

addressed review comments by adding readme file licensing which explains things 
in detail


Bugs: SENTRY-2081
https://issues.apache.org/jira/browse/SENTRY-2081


Repository: sentry


Description
---

As per https://www.apache.org/dev/licensing-howto.html , sentry should update 
the LICENSE.txt file with license information of all the jars that sentry is 
distributing along with the pointer to the LICENSE files of the dependencies.


Diffs (updated)
-

  LICENSE.txt b794ae6604774186020a1cf3dde922e92da57276 
  README_licesence.me PRE-CREATION 
  pom.xml eec185bc6409e5cebee12f3a0e4ca17c843cd631 
  sentry-dist/pom.xml 4c69535660b132943c7cdc2419fff140a0909a48 
  sentry-dist/src/license/THIRD-PARTY.ftl PRE-CREATION 
  sentry-dist/src/license/THIRD-PARTY.properties PRE-CREATION 
  sentry-dist/src/license/override-THIRD-PARTY.properties PRE-CREATION 
  sentry-dist/src/main/assembly/bin.xml 
5727fc964bc139a5bd5490132efad13db6cbcf44 
  sentry-dist/src/main/resources/licences/BSD_2-clause.txt PRE-CREATION 
  sentry-dist/src/main/resources/licences/BSD_License.txt PRE-CREATION 
  sentry-dist/src/main/resources/licences/CDDL_1_0.txt PRE-CREATION 
  sentry-dist/src/main/resources/licences/CDDL_1_1.txt PRE-CREATION 
  sentry-dist/src/main/resources/licences/CDDL_2.txt PRE-CREATION 
  
sentry-dist/src/main/resources/licences/Eclipse_Public_License_-_Version_1_0.txt
 PRE-CREATION 
  sentry-dist/src/main/resources/licences/MIT_License.txt PRE-CREATION 
  
sentry-dist/src/main/resources/licences/Mozilla_Public_License_Version_1_1.txt 
PRE-CREATION 
  sentry-dist/src/main/resources/licences/The_BSD_3-Clause_License.txt 
PRE-CREATION 


Diff: https://reviews.apache.org/r/64241/diff/6/

Changes: https://reviews.apache.org/r/64241/diff/5-6/


Testing
---

Made sure that LICENSE.txt file generated in sentry-dist/target directory has 
the license informaion of all the jars that sentry is distributing.


Thanks,

kalyan kumar kalvagadda

Re: Review Request 64241: SENTRY-2081: Update the LICENSE.txt with the license information of distributed jars

2017-12-01 Thread kalyan kumar kalvagadda via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64241/
---

(Updated Dec. 1, 2017, 6:16 p.m.)


Review request for sentry, Alexander Kolbasov, Brian Towles, Colm O 
hEigeartaigh, and Sergio Pena.


Changes
---

addressed comments.


Bugs: SENTRY-2081
https://issues.apache.org/jira/browse/SENTRY-2081


Repository: sentry


Description
---

As per https://www.apache.org/dev/licensing-howto.html , sentry should update 
the LICENSE.txt file with license information of all the jars that sentry is 
distributing along with the pointer to the LICENSE files of the dependencies.


Diffs (updated)
-

  LICENSE.txt b794ae6604774186020a1cf3dde922e92da57276 
  pom.xml eec185bc6409e5cebee12f3a0e4ca17c843cd631 
  sentry-dist/pom.xml 4c69535660b132943c7cdc2419fff140a0909a48 
  sentry-dist/src/license/THIRD-PARTY.ftl PRE-CREATION 
  sentry-dist/src/license/THIRD-PARTY.properties PRE-CREATION 
  sentry-dist/src/license/override-THIRD-PARTY.properties PRE-CREATION 
  sentry-dist/src/main/assembly/bin.xml 
5727fc964bc139a5bd5490132efad13db6cbcf44 
  sentry-dist/src/main/resources/licences/BSD_2-clause.txt PRE-CREATION 
  sentry-dist/src/main/resources/licences/BSD_License.txt PRE-CREATION 
  sentry-dist/src/main/resources/licences/CDDL_1_0.txt PRE-CREATION 
  sentry-dist/src/main/resources/licences/CDDL_1_1.txt PRE-CREATION 
  sentry-dist/src/main/resources/licences/CDDL_2.txt PRE-CREATION 
  
sentry-dist/src/main/resources/licences/Eclipse_Public_License_-_Version_1_0.txt
 PRE-CREATION 
  sentry-dist/src/main/resources/licences/MIT_License.txt PRE-CREATION 
  
sentry-dist/src/main/resources/licences/Mozilla_Public_License_Version_1_1.txt 
PRE-CREATION 
  sentry-dist/src/main/resources/licences/The_BSD_3-Clause_License.txt 
PRE-CREATION 


Diff: https://reviews.apache.org/r/64241/diff/5/

Changes: https://reviews.apache.org/r/64241/diff/4-5/


Testing
---

Made sure that LICENSE.txt file generated in sentry-dist/target directory has 
the license informaion of all the jars that sentry is distributing.


Thanks,

kalyan kumar kalvagadda

Re: Review Request 64241: SENTRY-2081: Update the LICENSE.txt with the license information of distributed jars

2017-12-01 Thread Sergio Pena via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64241/#review192523
---



Is there any documentation about how to maintain this new licensing method? 
Do contributors need to add new licenses under 
sentry-dist/src/main/resources/license if new ones exist later?
Is the current LICENSE.txt source file need to exist if the automated build 
generates one?


sentry-dist/pom.xml
Line 151 (original)


nit: tab or space



sentry-dist/src/main/assembly/bin.xml
Line 89 (original)


nit: remove tab or space here



sentry-dist/src/main/assembly/bin.xml
Lines 143-149 (patched)


This seems a duplicated , isn't it? Above this there is another 
similar.


- Sergio Pena


On Dec. 1, 2017, 5:27 p.m., kalyan kumar kalvagadda wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64241/
> ---
> 
> (Updated Dec. 1, 2017, 5:27 p.m.)
> 
> 
> Review request for sentry, Alexander Kolbasov, Brian Towles, Colm O 
> hEigeartaigh, and Sergio Pena.
> 
> 
> Bugs: SENTRY-2081
> https://issues.apache.org/jira/browse/SENTRY-2081
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> As per https://www.apache.org/dev/licensing-howto.html , sentry should update 
> the LICENSE.txt file with license information of all the jars that sentry is 
> distributing along with the pointer to the LICENSE files of the dependencies.
> 
> 
> Diffs
> -
> 
>   LICENSE.txt b794ae6604774186020a1cf3dde922e92da57276 
>   pom.xml eec185bc6409e5cebee12f3a0e4ca17c843cd631 
>   sentry-dist/pom.xml 4c69535660b132943c7cdc2419fff140a0909a48 
>   sentry-dist/src/license/THIRD-PARTY.ftl PRE-CREATION 
>   sentry-dist/src/license/THIRD-PARTY.properties PRE-CREATION 
>   sentry-dist/src/license/override-THIRD-PARTY.properties PRE-CREATION 
>   sentry-dist/src/main/assembly/bin.xml 
> 5727fc964bc139a5bd5490132efad13db6cbcf44 
>   sentry-dist/src/main/resources/licences/BSD_2-clause.txt PRE-CREATION 
>   sentry-dist/src/main/resources/licences/BSD_License.txt PRE-CREATION 
>   sentry-dist/src/main/resources/licences/CDDL_1_0.txt PRE-CREATION 
>   sentry-dist/src/main/resources/licences/CDDL_1_1.txt PRE-CREATION 
>   sentry-dist/src/main/resources/licences/CDDL_2.txt PRE-CREATION 
>   
> sentry-dist/src/main/resources/licences/Eclipse_Public_License_-_Version_1_0.txt
>  PRE-CREATION 
>   sentry-dist/src/main/resources/licences/MIT_License.txt PRE-CREATION 
>   
> sentry-dist/src/main/resources/licences/Mozilla_Public_License_Version_1_1.txt
>  PRE-CREATION 
>   sentry-dist/src/main/resources/licences/The_BSD_3-Clause_License.txt 
> PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/64241/diff/4/
> 
> 
> Testing
> ---
> 
> Made sure that LICENSE.txt file generated in sentry-dist/target directory has 
> the license informaion of all the jars that sentry is distributing.
> 
> 
> Thanks,
> 
> kalyan kumar kalvagadda
> 
>

Re: Review Request 64241: SENTRY-2081: Update the LICENSE.txt with the license information of distributed jars

2017-12-01 Thread kalyan kumar kalvagadda via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64241/
---

(Updated Dec. 1, 2017, 5:27 p.m.)


Review request for sentry, Alexander Kolbasov, Brian Towles, Colm O 
hEigeartaigh, and Sergio Pena.


Changes
---

Addressed comments from Colm


Bugs: SENTRY-2081
https://issues.apache.org/jira/browse/SENTRY-2081


Repository: sentry


Description
---

As per https://www.apache.org/dev/licensing-howto.html , sentry should update 
the LICENSE.txt file with license information of all the jars that sentry is 
distributing along with the pointer to the LICENSE files of the dependencies.


Diffs (updated)
-

  LICENSE.txt b794ae6604774186020a1cf3dde922e92da57276 
  pom.xml eec185bc6409e5cebee12f3a0e4ca17c843cd631 
  sentry-dist/pom.xml 4c69535660b132943c7cdc2419fff140a0909a48 
  sentry-dist/src/license/THIRD-PARTY.ftl PRE-CREATION 
  sentry-dist/src/license/THIRD-PARTY.properties PRE-CREATION 
  sentry-dist/src/license/override-THIRD-PARTY.properties PRE-CREATION 
  sentry-dist/src/main/assembly/bin.xml 
5727fc964bc139a5bd5490132efad13db6cbcf44 
  sentry-dist/src/main/resources/licences/BSD_2-clause.txt PRE-CREATION 
  sentry-dist/src/main/resources/licences/BSD_License.txt PRE-CREATION 
  sentry-dist/src/main/resources/licences/CDDL_1_0.txt PRE-CREATION 
  sentry-dist/src/main/resources/licences/CDDL_1_1.txt PRE-CREATION 
  sentry-dist/src/main/resources/licences/CDDL_2.txt PRE-CREATION 
  
sentry-dist/src/main/resources/licences/Eclipse_Public_License_-_Version_1_0.txt
 PRE-CREATION 
  sentry-dist/src/main/resources/licences/MIT_License.txt PRE-CREATION 
  
sentry-dist/src/main/resources/licences/Mozilla_Public_License_Version_1_1.txt 
PRE-CREATION 
  sentry-dist/src/main/resources/licences/The_BSD_3-Clause_License.txt 
PRE-CREATION 
  sentry-provider/sentry-provider-db/dependency-reduced-pom.xml 
f40ec32cf11ab438c591a47b7025a922d0ba5d6a 


Diff: https://reviews.apache.org/r/64241/diff/3/

Changes: https://reviews.apache.org/r/64241/diff/2-3/


Testing
---

Made sure that LICENSE.txt file generated in sentry-dist/target directory has 
the license informaion of all the jars that sentry is distributing.


Thanks,

kalyan kumar kalvagadda

Re: Review Request 64241: SENTRY-2081: Update the LICENSE.txt with the license information of distributed jars

2017-12-01 Thread kalyan kumar kalvagadda via Review Board 


> On Dec. 1, 2017, 3:58 p.m., Colm O hEigeartaigh wrote:
> > Is there a way to exclude the Apache licensed jars from the LICENSE.txt?
> > Is it possible to remove the Stax-API bit for GPL? There are two sections, 
> > one GPL and one CDDL.
> > You could also change the root LICENSE.txt in our source repo. For example 
> > the "cliche" license is MIT and you could just point to the licenses 
> > directly here instead of referencing the license. Same for the licenses 
> > above it.

Yes, I can make those change quickly and submit another patch.


- kalyan kumar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64241/#review192500
---


On Dec. 1, 2017, 2:03 p.m., kalyan kumar kalvagadda wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64241/
> ---
> 
> (Updated Dec. 1, 2017, 2:03 p.m.)
> 
> 
> Review request for sentry, Alexander Kolbasov, Brian Towles, Colm O 
> hEigeartaigh, and Sergio Pena.
> 
> 
> Bugs: SENTRY-2081
> https://issues.apache.org/jira/browse/SENTRY-2081
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> As per https://www.apache.org/dev/licensing-howto.html , sentry should update 
> the LICENSE.txt file with license information of all the jars that sentry is 
> distributing along with the pointer to the LICENSE files of the dependencies.
> 
> 
> Diffs
> -
> 
>   pom.xml eec185bc6409e5cebee12f3a0e4ca17c843cd631 
>   sentry-dist/pom.xml 4c69535660b132943c7cdc2419fff140a0909a48 
>   sentry-dist/src/license/THIRD-PARTY.ftl PRE-CREATION 
>   sentry-dist/src/license/THIRD-PARTY.properties PRE-CREATION 
>   sentry-dist/src/license/override-THIRD-PARTY.properties PRE-CREATION 
>   sentry-dist/src/main/assembly/bin.xml 
> 5727fc964bc139a5bd5490132efad13db6cbcf44 
>   sentry-dist/src/main/resources/licences/BSD_2-clause.txt PRE-CREATION 
>   sentry-dist/src/main/resources/licences/BSD_License.txt PRE-CREATION 
>   sentry-dist/src/main/resources/licences/CDDL_1_0.txt PRE-CREATION 
>   sentry-dist/src/main/resources/licences/CDDL_1_1.txt PRE-CREATION 
>   sentry-dist/src/main/resources/licences/CDDL_2.txt PRE-CREATION 
>   
> sentry-dist/src/main/resources/licences/Eclipse_Public_License_-_Version_1_0.txt
>  PRE-CREATION 
>   sentry-dist/src/main/resources/licences/MIT_License.txt PRE-CREATION 
>   
> sentry-dist/src/main/resources/licences/Mozilla_Public_License_Version_1_1.txt
>  PRE-CREATION 
>   sentry-dist/src/main/resources/licences/The_BSD_3-Clause_License.txt 
> PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/64241/diff/2/
> 
> 
> Testing
> ---
> 
> Made sure that LICENSE.txt file generated in sentry-dist/target directory has 
> the license informaion of all the jars that sentry is distributing.
> 
> 
> Thanks,
> 
> kalyan kumar kalvagadda
> 
>

Re: Review Request 64241: SENTRY-2081: Update the LICENSE.txt with the license information of distributed jars

2017-12-01 Thread Colm O hEigeartaigh 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64241/#review192500
---



Is there a way to exclude the Apache licensed jars from the LICENSE.txt?
Is it possible to remove the Stax-API bit for GPL? There are two sections, one 
GPL and one CDDL.
You could also change the root LICENSE.txt in our source repo. For example the 
"cliche" license is MIT and you could just point to the licenses directly here 
instead of referencing the license. Same for the licenses above it.

- Colm O hEigeartaigh


On Dec. 1, 2017, 2:03 p.m., kalyan kumar kalvagadda wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64241/
> ---
> 
> (Updated Dec. 1, 2017, 2:03 p.m.)
> 
> 
> Review request for sentry, Alexander Kolbasov, Brian Towles, Colm O 
> hEigeartaigh, and Sergio Pena.
> 
> 
> Bugs: SENTRY-2081
> https://issues.apache.org/jira/browse/SENTRY-2081
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> As per https://www.apache.org/dev/licensing-howto.html , sentry should update 
> the LICENSE.txt file with license information of all the jars that sentry is 
> distributing along with the pointer to the LICENSE files of the dependencies.
> 
> 
> Diffs
> -
> 
>   pom.xml eec185bc6409e5cebee12f3a0e4ca17c843cd631 
>   sentry-dist/pom.xml 4c69535660b132943c7cdc2419fff140a0909a48 
>   sentry-dist/src/license/THIRD-PARTY.ftl PRE-CREATION 
>   sentry-dist/src/license/THIRD-PARTY.properties PRE-CREATION 
>   sentry-dist/src/license/override-THIRD-PARTY.properties PRE-CREATION 
>   sentry-dist/src/main/assembly/bin.xml 
> 5727fc964bc139a5bd5490132efad13db6cbcf44 
>   sentry-dist/src/main/resources/licences/BSD_2-clause.txt PRE-CREATION 
>   sentry-dist/src/main/resources/licences/BSD_License.txt PRE-CREATION 
>   sentry-dist/src/main/resources/licences/CDDL_1_0.txt PRE-CREATION 
>   sentry-dist/src/main/resources/licences/CDDL_1_1.txt PRE-CREATION 
>   sentry-dist/src/main/resources/licences/CDDL_2.txt PRE-CREATION 
>   
> sentry-dist/src/main/resources/licences/Eclipse_Public_License_-_Version_1_0.txt
>  PRE-CREATION 
>   sentry-dist/src/main/resources/licences/MIT_License.txt PRE-CREATION 
>   
> sentry-dist/src/main/resources/licences/Mozilla_Public_License_Version_1_1.txt
>  PRE-CREATION 
>   sentry-dist/src/main/resources/licences/The_BSD_3-Clause_License.txt 
> PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/64241/diff/2/
> 
> 
> Testing
> ---
> 
> Made sure that LICENSE.txt file generated in sentry-dist/target directory has 
> the license informaion of all the jars that sentry is distributing.
> 
> 
> Thanks,
> 
> kalyan kumar kalvagadda
> 
>

Re: Review Request 64241: SENTRY-2081: Update the LICENSE.txt with the license information of distributed jars

2017-12-01 Thread kalyan kumar kalvagadda via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64241/
---

(Updated Dec. 1, 2017, 2:03 p.m.)


Review request for sentry, Alexander Kolbasov, Brian Towles, Colm O 
hEigeartaigh, and Sergio Pena.


Changes
---

Rebased the patch anlso addressing comments from Colm. Additionally this patch 
makes sure that sentry doesn't distribute artifact javax.jms:jms as license 
information for this not available.


Bugs: SENTRY-2081
https://issues.apache.org/jira/browse/SENTRY-2081


Repository: sentry


Description
---

As per https://www.apache.org/dev/licensing-howto.html , sentry should update 
the LICENSE.txt file with license information of all the jars that sentry is 
distributing along with the pointer to the LICENSE files of the dependencies.


Diffs (updated)
-

  pom.xml eec185bc6409e5cebee12f3a0e4ca17c843cd631 
  sentry-dist/pom.xml 4c69535660b132943c7cdc2419fff140a0909a48 
  sentry-dist/src/license/THIRD-PARTY.ftl PRE-CREATION 
  sentry-dist/src/license/THIRD-PARTY.properties PRE-CREATION 
  sentry-dist/src/license/override-THIRD-PARTY.properties PRE-CREATION 
  sentry-dist/src/main/assembly/bin.xml 
5727fc964bc139a5bd5490132efad13db6cbcf44 
  sentry-dist/src/main/resources/licences/BSD_2-clause.txt PRE-CREATION 
  sentry-dist/src/main/resources/licences/BSD_License.txt PRE-CREATION 
  sentry-dist/src/main/resources/licences/CDDL_1_0.txt PRE-CREATION 
  sentry-dist/src/main/resources/licences/CDDL_1_1.txt PRE-CREATION 
  sentry-dist/src/main/resources/licences/CDDL_2.txt PRE-CREATION 
  
sentry-dist/src/main/resources/licences/Eclipse_Public_License_-_Version_1_0.txt
 PRE-CREATION 
  sentry-dist/src/main/resources/licences/MIT_License.txt PRE-CREATION 
  
sentry-dist/src/main/resources/licences/Mozilla_Public_License_Version_1_1.txt 
PRE-CREATION 
  sentry-dist/src/main/resources/licences/The_BSD_3-Clause_License.txt 
PRE-CREATION 


Diff: https://reviews.apache.org/r/64241/diff/2/

Changes: https://reviews.apache.org/r/64241/diff/1-2/


Testing
---

Made sure that LICENSE.txt file generated in sentry-dist/target directory has 
the license informaion of all the jars that sentry is distributing.


Thanks,

kalyan kumar kalvagadda