Re: [VOTE] Release Apache ServiceComb Service-Center (incubating) version 1.0.0-m1 - Fourth Attempt
+1 non binding Ran the service-center release binary successfully 2018-03-19 13:05 GMT+08:00 Mahesh Raju Somalaraju : > +1 Non Binding > > - Ran java-chassis demos using service-center release binary. > - Run the rat to verify the License header issue. > > Thanks & Regards > -Mahesh Raju S > > On Sat, Mar 17, 2018 at 12:08 AM, Mohammad Asif Siddiqui < > asifdxtr...@apache.org> wrote: > > > Hi All, > > > > This is a call for Vote to release Apache ServiceComb Service-Center > > (Incubating) version 1.0.0-m1 (fourth release candidate). > > > > Release Notes : https://github.com/apache/incubator-servicecomb-service- > > center/blob/master/docs/release/releaseNotes.md > > > > Release Candidate : https://dist.apache.org/repos/dist/dev/incubator/ > > servicecomb/incubator-servicecomb-service-center/1.0.0-m1/ > > > > Release Tag : https://github.com/apache/incubator-servicecomb-service- > > center/releases/tag/1.0.0-m1 > > > > Release CommitID : 94cea25ba55e763dbe23d0cd4a8da73e37a50539 > > > > Keys to verify the Release Candidate : https://dist.apache.org/repos/ > > dist/dev/incubator/servicecomb/KEYS > > > > Guide to build the release from source : https://github.com/apache/ > > incubator-servicecomb-service-center/tree/master/scripts/release > > > > Voting will start now ( Saturday, 17th March, 2018) and will remain open > > for next 72 hours, Request all PPMC members to give their vote. > > [ ] +1 Release this package as 1.0.0-m1 > > [ ] +0 No Opinion > > [ ] -1 Do not release this package because > > > > Regards > > Asif > > > > > > >
Re: [VOTE] Release Apache ServiceComb Saga (incubating) version 0.1.0 - Second Attempt
+1 Non Binding Checked the demo 2018-03-19 13:06 GMT+08:00 Mahesh Raju Somalaraju : > +1 Non Binding > > - Ran java-chassis demos using service-center release binary. > - Run the rat to verify the License header issue. > > Thanks & Regards > -Mahesh Raju S > > > On Sat, Mar 17, 2018 at 12:31 AM, Mohammad Asif Siddiqui < > asifdxtr...@apache.org> wrote: > > > Hi All, > > > > This is a call for Vote to release Apache ServiceComb Saga (Incubating) > > version 0.1.0 > > > > Release Notes : https://issues.apache.org/jira/secure/ReleaseNote.jspa? > > projectId=12321626&version=12342353 > > > > Release Candidate : https://dist.apache.org/repos/dist/dev/incubator/ > > servicecomb/incubator-servicecomb-saga/0.1.0/ > > > > Staging Repo : https://repository.apache.org/content/repositories/ > > orgapacheservicecomb-1166 > > > > Release Tag : https://github.com/apache/incubator-servicecomb-saga/ > > releases/tag/0.1.0 > > > > Release CommitID : 708eec092988dfd4a5960ca5f232fb7421d5fbdd > > > > Keys to verify the Release Candidate : https://dist.apache.org/repos/ > > dist/dev/incubator/servicecomb/KEYS > > > > Voting will start now ( Saturday, 17th March, 2018) and will remain open > > for next 72 hours, Request all PPMC members to give their vote > > > > [ ] +1 Release this package as 0.1.0 > > [ ] +0 No Opinion > > [ ] -1 Do not release this package because > > > > Regards > > Asif > > > > >
Re: [VOTE] Release Apache ServiceComb Java-Chassis (incubating) version 1.0.0-m1 - Second Attempt
+1 Non Binding Build the source successfully,and unit tests and integration tests are passed 2018-03-19 13:06 GMT+08:00 Mahesh Raju Somalaraju : > +1 Non Binding > > - Ran java-chassis demos using service-center release binary. > - Run the rat to verify the License header issue. > > Thanks & Regards > -Mahesh Raju S > > > On Sat, Mar 17, 2018 at 12:22 AM, Mohammad Asif Siddiqui < > asifdxtr...@apache.org> wrote: > > > Hi All, > > > > This is a call for Vote to release Apache ServiceComb Java-Chassis > > (Incubating) version 1.0.0-m1 > > > > Release Notes : https://github.com/apache/incubator-servicecomb-java- > > chassis/blob/master/etc/releaseNotes.md > > > > Release Candidate : https://dist.apache.org/repos/dist/dev/incubator/ > > servicecomb/incubator-servicecomb-java-chassis/1.0.0-m1/ > > > > Staging Repo : https://repository.apache.org/content/repositories/ > > orgapacheservicecomb-1181/ > > > > Release Tag : https://github.com/apache/incubator-servicecomb-java- > > chassis/releases/tag/1.0.0-m1 > > > > Release CommitID : 3dbfb87eb6249f3ad41ea7514d1a73ec6e193bfe > > > > Keys to verify the Release Candidate : https://dist.apache.org/repos/ > > dist/dev/incubator/servicecomb/KEYS > > > > Voting will start now ( Saturday, 17th March, 2018) and will remain open > > for next 72 hours, Request all PPMC members to give their vote > > > > [ ] +1 Release this package as 1.0.0-m1 > > [ ] +0 No Opinion > > [ ] -1 Do not release this package because > > > > Regards > > Asif > > > > >
Re: discussion: about performance metrics local log output format.
just a logger to output local log periodically, not about filter. this make developers easier to know bottleneck of their system, no need to deploy any other component 2018年3月17日星期六，Willem Jiang 写道： > Hi wjm, > > It's handy feature if we can configure the filter to let the consol print > out the metrics data. > You can take the git log[1] as an example, we can setup the some custom > options for different output format. > > Here I have a question for the user scenario of this feature，it looks like > you want use it for the performance test. How about the normal system > administration work? > > [1]https://git-scm.com/docs/git-log > > > Willem Jiang > > Blog: http://willemjiang.blogspot.com (English) > http://jnn.iteye.com (Chinese) > Twitter: willemjiang > Weibo: 姜宁willem > > On Sat, Mar 17, 2018 at 2:22 AM, wjm wjm wrote: > > > 1.output will be group by transport and statusCode for consumer and > > producer > >operation is empty means this line is summary for this group > > 2.will add cpu/memory/gc output in the furture. > >cpu is only about this process, not about os level > >because jvm did not provide api to get os level cpu usage except > invoke > > command and analysis the output. > > 3.if necessary will add configuration to filter operations, so that will > > not print so many informations. > > > > any suggestions? > > thanks. > > > > > > > > >
Re: [VOTE] Release Apache ServiceComb Java-Chassis (incubating) version 1.0.0-m1 - Second Attempt
+0 Non Binding Built the code from Release Candidate then check all samples using Staging Repo. Run unit tests and integration tests. Problem : 1.Need Update Release notes: https://issues.apache.org/jira/browse/SCB-414 2.Pojo sample will be failed when running "mvn exec:java" : https://issues.apache.org/jira/browse/SCB-413 Suggestion: 1.Change "apollo.config.clusters" setting value in config-apollo-sample from "test-cluster" to "default" : https://issues.apache.org/jira/browse/SCB-415 -- Original -- From: "Mohammad Asif Siddiqui"; Date: Sat, Mar 17, 2018 02:52 AM To: "dev"; Subject: [VOTE] Release Apache ServiceComb Java-Chassis (incubating) version 1.0.0-m1 - Second Attempt Hi All, This is a call for Vote to release Apache ServiceComb Java-Chassis (Incubating) version 1.0.0-m1 Release Notes : https://github.com/apache/incubator-servicecomb-java-chassis/blob/master/etc/releaseNotes.md Release Candidate : https://dist.apache.org/repos/dist/dev/incubator/servicecomb/incubator-servicecomb-java-chassis/1.0.0-m1/ Staging Repo : https://repository.apache.org/content/repositories/orgapacheservicecomb-1181/ Release Tag : https://github.com/apache/incubator-servicecomb-java-chassis/releases/tag/1.0.0-m1 Release CommitID : 3dbfb87eb6249f3ad41ea7514d1a73ec6e193bfe Keys to verify the Release Candidate : https://dist.apache.org/repos/dist/dev/incubator/servicecomb/KEYS Voting will start now ( Saturday, 17th March, 2018) and will remain open for next 72 hours, Request all PPMC members to give their vote [ ] +1 Release this package as 1.0.0-m1 [ ] +0 No Opinion [ ] -1 Do not release this package because Regards Asif
[GitHub] zhengyangyong opened a new pull request #610: [SCB-415] change cluster value from "test-cluster" to "default"
zhengyangyong opened a new pull request #610: [SCB-415] change cluster value from "test-cluster" to "default" URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/610 Signed-off-by: zhengyangyong Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] zhengyangyong opened a new pull request #611: [SCB-414] fix releaseNotes
zhengyangyong opened a new pull request #611: [SCB-414] fix releaseNotes URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/611 Signed-off-by: zhengyangyong Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] zhengyangyong closed pull request #572: [SCB-370] Improve latency and max precision
zhengyangyong closed pull request #572: [SCB-370] Improve latency and max
precision
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/572
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/demo/perf/src/main/java/org/apache/servicecomb/demo/perf/PerfMetricsFilePublisher.java
b/demo/perf/src/main/java/org/apache/servicecomb/demo/perf/PerfMetricsFilePublisher.java
index cbbd1d87c..494e065d3 100644
---
a/demo/perf/src/main/java/org/apache/servicecomb/demo/perf/PerfMetricsFilePublisher.java
+++
b/demo/perf/src/main/java/org/apache/servicecomb/demo/perf/PerfMetricsFilePublisher.java
@@ -24,6 +24,7 @@
import org.apache.servicecomb.foundation.metrics.publish.MetricNode;
import org.apache.servicecomb.foundation.metrics.publish.MetricsLoader;
import org.apache.servicecomb.foundation.vertx.VertxUtils;
+import org.apache.servicecomb.metrics.core.MetricsUtils;
import org.apache.servicecomb.metrics.core.MonitorManager;
import org.apache.servicecomb.swagger.invocation.InvocationType;
import org.slf4j.Logger;
@@ -35,7 +36,9 @@
private static final Logger LOGGER =
LoggerFactory.getLogger(PerfMetricsFilePublisher.class);
public void onCycle() {
-Map metrics = MonitorManager.getInstance().measure();
+//print with TimeUnit.MILLISECONDS
+Map metrics = MetricsUtils
+.convertMeasurements(MonitorManager.getInstance().measure(),
TimeUnit.MILLISECONDS);
MetricsLoader loader = new MetricsLoader(metrics);
StringBuilder sb = new StringBuilder();
@@ -85,7 +88,7 @@ private void collectMetrics(MetricsLoader loader,
StringBuilder sb) {
.getFirstMatchMetricValue(MetricsConst.TAG_STAGE,
MetricsConst.STAGE_TOTAL,
MetricsConst.TAG_STATISTIC, "tps"),
statusNode.getValue()
- .getFirstMatchMetricValue(TimeUnit.MILLISECONDS,
MetricsConst.TAG_STAGE, MetricsConst.STAGE_TOTAL,
+ .getFirstMatchMetricValue(MetricsConst.TAG_STAGE,
MetricsConst.STAGE_TOTAL,
MetricsConst.TAG_STATISTIC, "latency"),
statusNode.getKey(), operationNode.getKey()));
}
@@ -103,13 +106,13 @@ private void collectMetrics(MetricsLoader loader,
StringBuilder sb) {
.getFirstMatchMetricValue(MetricsConst.TAG_STAGE,
MetricsConst.STAGE_TOTAL,
MetricsConst.TAG_STATISTIC, "tps"),
statusNode.getValue()
- .getFirstMatchMetricValue(TimeUnit.MILLISECONDS,
MetricsConst.TAG_STAGE, MetricsConst.STAGE_TOTAL,
+ .getFirstMatchMetricValue(MetricsConst.TAG_STAGE,
MetricsConst.STAGE_TOTAL,
MetricsConst.TAG_STATISTIC, "latency"),
statusNode.getValue()
- .getFirstMatchMetricValue(TimeUnit.MILLISECONDS,
MetricsConst.TAG_STAGE, MetricsConst.STAGE_QUEUE,
+ .getFirstMatchMetricValue(MetricsConst.TAG_STAGE,
MetricsConst.STAGE_QUEUE,
MetricsConst.TAG_STATISTIC, "latency"),
statusNode.getValue()
- .getFirstMatchMetricValue(TimeUnit.MILLISECONDS,
MetricsConst.TAG_STAGE,
+ .getFirstMatchMetricValue(MetricsConst.TAG_STAGE,
MetricsConst.STAGE_EXECUTION,
MetricsConst.TAG_STATISTIC, "latency"),
statusNode.getKey(), operationNode.getKey()));
diff --git
a/foundations/foundation-metrics/src/main/java/org/apache/servicecomb/foundation/metrics/publish/Metric.java
b/foundations/foundation-metrics/src/main/java/org/apache/servicecomb/foundation/metrics/publish/Metric.java
index b894b5810..6a1d708e0 100644
---
a/foundations/foundation-metrics/src/main/java/org/apache/servicecomb/foundation/metrics/publish/Metric.java
+++
b/foundations/foundation-metrics/src/main/java/org/apache/servicecomb/foundation/metrics/publish/Metric.java
@@ -19,10 +19,8 @@
import java.util.HashMap;
import java.util.Map;
-import java.util.concurrent.TimeUnit;
import
org.apache.servicecomb.foundation.common.exceptions.ServiceCombException;
-import org.apache.servicecomb.foundation.metrics.MetricsConst;
public class Metric {
private String name;
@@ -77,15 +75,6 @@ public double getValue() {
return value;
}
- public double getValue(TimeUnit unit) {
-if (tags.containsKey(MetricsConst.TAG_UNIT)) {
- if (!tags.get(MetricsConst.TAG_UNIT).equals(String.valueOf(unit))) {
-return unit.convert((long) value,
TimeUnit.valueOf(tags.get(MetricsConst.TAG_UNIT)));
- }
-}
-return value;
- }
-
public int getTagsCount() {
return tags.size();
}
diff --git
a/fo
[GitHub] zhengyangyong opened a new pull request #612: [SCB-413] fix pojo consumer sample bean xml
zhengyangyong opened a new pull request #612: [SCB-413] fix pojo consumer sample bean xml URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/612 Signed-off-by: zhengyangyong Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
Re: [VOTE] Release Apache ServiceComb Service-Center (incubating) version 1.0.0-m1 - Fourth Attempt
+1 non binding 2018-03-19 15:09 GMT+08:00 Bin Ma : > +1 non binding > > Ran the service-center release binary successfully > > 2018-03-19 13:05 GMT+08:00 Mahesh Raju Somalaraju < > maheshraju.o...@gmail.com > >: > > > +1 Non Binding > > > > - Ran java-chassis demos using service-center release binary. > > - Run the rat to verify the License header issue. > > > > Thanks & Regards > > -Mahesh Raju S > > > > On Sat, Mar 17, 2018 at 12:08 AM, Mohammad Asif Siddiqui < > > asifdxtr...@apache.org> wrote: > > > > > Hi All, > > > > > > This is a call for Vote to release Apache ServiceComb Service-Center > > > (Incubating) version 1.0.0-m1 (fourth release candidate). > > > > > > Release Notes : https://github.com/apache/ > incubator-servicecomb-service- > > > center/blob/master/docs/release/releaseNotes.md > > > > > > Release Candidate : https://dist.apache.org/repos/dist/dev/incubator/ > > > servicecomb/incubator-servicecomb-service-center/1.0.0-m1/ > > > > > > Release Tag : https://github.com/apache/incubator-servicecomb-service- > > > center/releases/tag/1.0.0-m1 > > > > > > Release CommitID : 94cea25ba55e763dbe23d0cd4a8da73e37a50539 > > > > > > Keys to verify the Release Candidate : https://dist.apache.org/repos/ > > > dist/dev/incubator/servicecomb/KEYS > > > > > > Guide to build the release from source : https://github.com/apache/ > > > incubator-servicecomb-service-center/tree/master/scripts/release > > > > > > Voting will start now ( Saturday, 17th March, 2018) and will remain > open > > > for next 72 hours, Request all PPMC members to give their vote. > > > [ ] +1 Release this package as 1.0.0-m1 > > > [ ] +0 No Opinion > > > [ ] -1 Do not release this package because > > > > > > Regards > > > Asif > > > > > > > > > > > >
Re: [VOTE] Release Apache ServiceComb Saga (incubating) version 0.1.0 - Second Attempt
+1 Non Binding 2018-03-19 15:14 GMT+08:00 Bin Ma : > +1 Non Binding Checked the demo > > > 2018-03-19 13:06 GMT+08:00 Mahesh Raju Somalaraju < > maheshraju.o...@gmail.com > >: > > > +1 Non Binding > > > > - Ran java-chassis demos using service-center release binary. > > - Run the rat to verify the License header issue. > > > > Thanks & Regards > > -Mahesh Raju S > > > > > > On Sat, Mar 17, 2018 at 12:31 AM, Mohammad Asif Siddiqui < > > asifdxtr...@apache.org> wrote: > > > > > Hi All, > > > > > > This is a call for Vote to release Apache ServiceComb Saga (Incubating) > > > version 0.1.0 > > > > > > Release Notes : https://issues.apache.org/jira/secure/ReleaseNote.jspa > ? > > > projectId=12321626&version=12342353 > > > > > > Release Candidate : https://dist.apache.org/repos/dist/dev/incubator/ > > > servicecomb/incubator-servicecomb-saga/0.1.0/ > > > > > > Staging Repo : https://repository.apache.org/content/repositories/ > > > orgapacheservicecomb-1166 > > > > > > Release Tag : https://github.com/apache/incubator-servicecomb-saga/ > > > releases/tag/0.1.0 > > > > > > Release CommitID : 708eec092988dfd4a5960ca5f232fb7421d5fbdd > > > > > > Keys to verify the Release Candidate : https://dist.apache.org/repos/ > > > dist/dev/incubator/servicecomb/KEYS > > > > > > Voting will start now ( Saturday, 17th March, 2018) and will remain > open > > > for next 72 hours, Request all PPMC members to give their vote > > > > > > [ ] +1 Release this package as 0.1.0 > > > [ ] +0 No Opinion > > > [ ] -1 Do not release this package because > > > > > > Regards > > > Asif > > > > > > > > >
Re: [VOTE] Release Apache ServiceComb Java-Chassis (incubating) version 1.0.0-m1 - Second Attempt
As the SCB-413 introduced some trouble for the user to run the example, I think we need to fix this issue before release. So I changed my vote to -1, we need to fix this issue before release. Willem Jiang Blog: http://willemjiang.blogspot.com (English) http://jnn.iteye.com (Chinese) Twitter: willemjiang Weibo: 姜宁willem On Mon, Mar 19, 2018 at 3:54 PM, 郑扬勇 wrote: > +0 Non Binding > > Built the code from Release Candidate then check all samples using > Staging Repo. > Run unit tests and integration tests. > > Problem : > 1.Need Update Release notes: https://issues.apache.org/ > jira/browse/SCB-414 > 2.Pojo sample will be failed when running "mvn exec:java" : > https://issues.apache.org/jira/browse/SCB-413 > > Suggestion: > 1.Change "apollo.config.clusters" setting value in config-apollo-sample > from "test-cluster" to "default" : https://issues.apache.org/ > jira/browse/SCB-415 > > -- Original -- > From: "Mohammad Asif Siddiqui"; > Date: Sat, Mar 17, 2018 02:52 AM > To: "dev"; > > Subject: [VOTE] Release Apache ServiceComb Java-Chassis (incubating) > version 1.0.0-m1 - Second Attempt > > > > Hi All, > > This is a call for Vote to release Apache ServiceComb Java-Chassis > (Incubating) version 1.0.0-m1 > > Release Notes : https://github.com/apache/incubator-servicecomb-java- > chassis/blob/master/etc/releaseNotes.md > > Release Candidate : https://dist.apache.org/repos/dist/dev/incubator/ > servicecomb/incubator-servicecomb-java-chassis/1.0.0-m1/ > > Staging Repo : https://repository.apache.org/content/repositories/ > orgapacheservicecomb-1181/ > > Release Tag : https://github.com/apache/incubator-servicecomb-java- > chassis/releases/tag/1.0.0-m1 > > Release CommitID : 3dbfb87eb6249f3ad41ea7514d1a73ec6e193bfe > > Keys to verify the Release Candidate : https://dist.apache.org/repos/ > dist/dev/incubator/servicecomb/KEYS > > Voting will start now ( Saturday, 17th March, 2018) and will remain open > for next 72 hours, Request all PPMC members to give their vote > > [ ] +1 Release this package as 1.0.0-m1 > [ ] +0 No Opinion > [ ] -1 Do not release this package because > > Regards > Asif >
[GitHub] WillemJiang commented on a change in pull request #612: [SCB-413] fix pojo consumer sample bean xml
WillemJiang commented on a change in pull request #612: [SCB-413] fix pojo consumer sample bean xml URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/612#discussion_r175358825 ## File path: samples/pojo-sample/pojo-consumer/src/main/resources/META-INF/spring/pojo.consumer.bean.xml ## @@ -20,8 +20,10 @@ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xmlns:cse="http://www.huawei.com/schema/paas/cse/rpc"; xmlns:context="http://www.springframework.org/schema/context"; - xsi:schemaLocation="http://www.springframework.org/schema/beans classpath:org/springframework/beans/factory/xml/spring-beans-3.0.xsd - http://www.huawei.com/schema/paas/cse/rpc classpath:META-INF/spring/spring-paas-cse-rpc.xsd"> + xsi:schemaLocation=" + http://www.springframework.org/schema/beans classpath:org/springframework/beans/factory/xml/spring-beans-3.0.xsd + http://www.springframework.org/schema/context http://www.springframework.org/schema/context/spring-context-3.0.xsd + http://www.huawei.com/schema/paas/cse/rpc classpath:META-INF/spring/spring-paas-cse-rpc.xsd"> Review comment: It doesn't make scene that we have name space of paas/cse/rpc here. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] WillemJiang closed pull request #611: [SCB-414] fix releaseNotes
WillemJiang closed pull request #611: [SCB-414] fix releaseNotes URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/611 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/etc/releaseNotes.md b/etc/releaseNotes.md index f9db15c7f..27eca0996 100644 --- a/etc/releaseNotes.md +++ b/etc/releaseNotes.md @@ -20,8 +20,7 @@ more details. ### Other Noticeable Changes: - The Java Chassis libraries are now under group "org.apache.servicecomb". -- We provide out of the box metrics support now. Prometheus and Overwatch -is supported. +- We provide out of the box metrics support now. Prometheus is supported. - Configuration center was re-factored and moved out from foundation. Support for Apollo was added. - Users can now use Object type for calling services. @@ -30,6 +29,6 @@ Support for Apollo was added. - Upgraded to zipkin2 internally, Java Chassis can now work with zipkin server v1 and v2. - We are in the process of supporting reactive programming. Pojo consumer -and provider now supports CompletableFutre. +and provider now supports CompletableFuture. ### For more detailed information please checkout [here](https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12321626&version=12342351) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] WillemJiang commented on a change in pull request #610: [SCB-415] change cluster value from "test-cluster" to "default"
WillemJiang commented on a change in pull request #610: [SCB-415] change cluster value from "test-cluster" to "default" URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/610#discussion_r175362174 ## File path: samples/config-apollo-sample/src/main/resources/microservice.yaml ## @@ -26,7 +26,7 @@ apollo: serverUri: http://127.0.0.1:8070 serviceName: apollo-test env: DEV -clusters: test-cluster +clusters: default Review comment: Please add some explanation about this setting. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] zhengyangyong commented on a change in pull request #610: [SCB-415] change cluster value from "test-cluster" to "default"
zhengyangyong commented on a change in pull request #610: [SCB-415] change cluster value from "test-cluster" to "default" URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/610#discussion_r175363834 ## File path: samples/config-apollo-sample/src/main/resources/microservice.yaml ## @@ -26,7 +26,7 @@ apollo: serverUri: http://127.0.0.1:8070 serviceName: apollo-test env: DEV -clusters: test-cluster +clusters: default Review comment: Done This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] zhengyangyong commented on a change in pull request #612: [SCB-413] fix pojo consumer sample bean xml
zhengyangyong commented on a change in pull request #612: [SCB-413] fix pojo consumer sample bean xml URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/612#discussion_r175365511 ## File path: samples/pojo-sample/pojo-consumer/src/main/resources/META-INF/spring/pojo.consumer.bean.xml ## @@ -20,8 +20,10 @@ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xmlns:cse="http://www.huawei.com/schema/paas/cse/rpc"; xmlns:context="http://www.springframework.org/schema/context"; - xsi:schemaLocation="http://www.springframework.org/schema/beans classpath:org/springframework/beans/factory/xml/spring-beans-3.0.xsd - http://www.huawei.com/schema/paas/cse/rpc classpath:META-INF/spring/spring-paas-cse-rpc.xsd"> + xsi:schemaLocation=" + http://www.springframework.org/schema/beans classpath:org/springframework/beans/factory/xml/spring-beans-3.0.xsd + http://www.springframework.org/schema/context http://www.springframework.org/schema/context/spring-context-3.0.xsd + http://www.huawei.com/schema/paas/cse/rpc classpath:META-INF/spring/spring-paas-cse-rpc.xsd"> Review comment: Ok,wait a moment This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] tianxiaoliang closed issue #314: docker hub don't have document and simple description
tianxiaoliang closed issue #314: docker hub don't have document and simple description URL: https://github.com/apache/incubator-servicecomb-service-center/issues/314 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #610: [SCB-415] change cluster value from "test-cluster" to "default"
coveralls commented on issue #610: [SCB-415] change cluster value from "test-cluster" to "default" URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/610#issuecomment-374164496 [](https://coveralls.io/builds/16047946) Coverage increased (+0.02%) to 87.327% when pulling **2cd6b5f7cc49007d271d68fc53c7ca7b4637893f on zhengyangyong:SCB-415** into **8814a2ef936b3be64d319ba3c144adb27cd9e42c on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] WillemJiang closed pull request #610: [SCB-415] change cluster value from "test-cluster" to "default"
WillemJiang closed pull request #610: [SCB-415] change cluster value from "test-cluster" to "default" URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/610 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/samples/config-apollo-sample/src/main/resources/microservice.yaml b/samples/config-apollo-sample/src/main/resources/microservice.yaml index 47ef10974..524b5a576 100644 --- a/samples/config-apollo-sample/src/main/resources/microservice.yaml +++ b/samples/config-apollo-sample/src/main/resources/microservice.yaml @@ -24,9 +24,13 @@ service_description: apollo: config: serverUri: http://127.0.0.1:8070 -serviceName: apollo-test +serviceName: apollo-test #AppId in apollo env: DEV -clusters: test-cluster +#default clusters name in apollo,if user create new clusters please replace this setting value +#more detail can be found at https://github.com/ctripcorp/apollo/wiki +clusters: default +#default namespace name in apollo,if user create new namespace please replace this setting value +#more detail can be found at https://github.com/ctripcorp/apollo/wiki/Apollo%E6%A0%B8%E5%BF%83%E6%A6%82%E5%BF%B5%E4%B9%8B%E2%80%9CNamespace%E2%80%9D namespace: application token: #get token from Apollo web pages cse: This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] liubao68 opened a new pull request #613: [SCB-416]For load balance rule configurations, we need provider service level configuration
liubao68 opened a new pull request #613: [SCB-416]For load balance rule configurations, we need provider service level configuration URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/613 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #310: SCB-411 SC can not check the reduplicate endpoints when register with ID
coveralls commented on issue #310: SCB-411 SC can not check the reduplicate endpoints when register with ID URL: https://github.com/apache/incubator-servicecomb-service-center/pull/310#issuecomment-373902346 [](https://coveralls.io/builds/16049929) Coverage decreased (-0.3%) to 73.654% when pulling **b10ffec3be7e07b2f10abff29a7757f85ff5922f on little-cui:master** into **f8b3e7b95ef63709cfb933a3688a4714271ec518 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #310: SCB-411 SC can not check the reduplicate endpoints when register with ID
codecov-io commented on issue #310: SCB-411 SC can not check the reduplicate endpoints when register with ID URL: https://github.com/apache/incubator-servicecomb-service-center/pull/310#issuecomment-373902301 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/310?src=pr&el=h1) Report > Merging [#310](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/310?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/f8b3e7b95ef63709cfb933a3688a4714271ec518?src=pr&el=desc) will **decrease** coverage by `0.39%`. > The diff coverage is `56.91%`. [](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/310?src=pr&el=tree) ```diff @@Coverage Diff@@ ## master #310 +/- ## = - Coverage 70.33% 69.93% -0.4% = Files 17 17 Lines3452 3443 -9 = - Hits 2428 2408 -20 - Misses853 864 +11 Partials 171 171 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/310?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [server/service/util/instance\_util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/310/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9pbnN0YW5jZV91dGlsLmdv) | `53.45% <41.66%> (+4.36%)` | :arrow_up: | | [server/service/instances.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/310/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvaW5zdGFuY2VzLmdv) | `67.28% <58.55%> (-3.84%)` | :arrow_down: | | [server/service/rule.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/310/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvcnVsZS5nbw==) | `77.25% <0%> (+0.42%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/310?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/310?src=pr&el=footer). Last update [f8b3e7b...b10ffec](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/310?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] zhengyangyong opened a new pull request #614: [SCB-417] delete useless lines in readme
zhengyangyong opened a new pull request #614: [SCB-417] delete useless lines in readme URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/614 Signed-off-by: zhengyangyong Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
Re: [VOTE] Release Apache ServiceComb Java-Chassis (incubating) version 1.0.0-m1 - Second Attempt
Hi All, We are cancelling this vote as there are some issues which needs to be handled before the release. We will re-intiate the vote once we are done fixing it. Thanks All for your support. Regards Asif On 2018/03/16 18:52:25, Mohammad Asif Siddiqui wrote: > Hi All, > > This is a call for Vote to release Apache ServiceComb Java-Chassis > (Incubating) version 1.0.0-m1 > > Release Notes : > https://github.com/apache/incubator-servicecomb-java-chassis/blob/master/etc/releaseNotes.md > > > Release Candidate : > https://dist.apache.org/repos/dist/dev/incubator/servicecomb/incubator-servicecomb-java-chassis/1.0.0-m1/ > > > Staging Repo : > https://repository.apache.org/content/repositories/orgapacheservicecomb-1181/ > > Release Tag : > https://github.com/apache/incubator-servicecomb-java-chassis/releases/tag/1.0.0-m1 > > > Release CommitID : 3dbfb87eb6249f3ad41ea7514d1a73ec6e193bfe > > Keys to verify the Release Candidate : > https://dist.apache.org/repos/dist/dev/incubator/servicecomb/KEYS > > Voting will start now ( Saturday, 17th March, 2018) and will remain open for > next 72 hours, Request all PPMC members to give their vote > > [ ] +1 Release this package as 1.0.0-m1 > [ ] +0 No Opinion > [ ] -1 Do not release this package because > > Regards > Asif > >
[GitHub] asifdxtreme commented on a change in pull request #614: [SCB-417] delete useless lines in readme
asifdxtreme commented on a change in pull request #614: [SCB-417] delete useless lines in readme URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/614#discussion_r175427311 ## File path: samples/README.md ## @@ -7,20 +7,4 @@ It's the samples of Java chassis 4. code first sample 5. customer handler sample 6. extend metrics health checker sample -7. write metrics data into separate text files sample - -## 1. Start the ServiceComb/Service Center Review comment: I think starting Service-Center should be there in Readme, as our samples won't run without a working instance of Service-Center This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] WillemJiang commented on a change in pull request #614: [SCB-417] delete useless lines in readme
WillemJiang commented on a change in pull request #614: [SCB-417] delete useless lines in readme URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/614#discussion_r175428342 ## File path: samples/README.md ## @@ -7,20 +7,4 @@ It's the samples of Java chassis 4. code first sample 5. customer handler sample 6. extend metrics health checker sample -7. write metrics data into separate text files sample - -## 1. Start the ServiceComb/Service Center Review comment: Yeah, we need to keep the Service-Center running instruction here. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] WillemJiang closed pull request #612: [SCB-413] fix pojo consumer sample bean xml
WillemJiang closed pull request #612: [SCB-413] fix pojo consumer sample bean xml URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/612 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/samples/auth-sample/README.md b/samples/auth-sample/README.md index 7f7e4b83f..0784d8fd0 100644 --- a/samples/auth-sample/README.md +++ b/samples/auth-sample/README.md @@ -72,7 +72,7 @@ Auth sample use `RestTemplate` to present RSA communication between provider and cd incubator-servicecomb-java-chassis/ mvn clean install -Psamples -DskipTests #only need to install at first time. cd samples/auth-sample/auth-provider/ - mvn exec:java -Dexec.mainClass="org.apache.servicecomb.samples.springmvc.provider.AuthProviderMain" + mvn exec:java -Dexec.mainClass="org.apache.servicecomb.samples.auth.provider.AuthProviderMain" ``` - Start provider service by IDE @@ -85,7 +85,7 @@ Auth sample use `RestTemplate` to present RSA communication between provider and ```bash cd samples/auth-sample/auth-consumer/ - mvn exec:java -Dexec.mainClass="org.apache.servicecomb.samples.springmvc.consumer.AuthConsumerMain" + mvn exec:java -Dexec.mainClass="org.apache.servicecomb.samples.auth.consumer.AuthConsumerMain" ``` 4. How to verify diff --git a/samples/auth-sample/auth-consumer/src/main/java/org/apache/servicecomb/samples/springmvc/consumer/AuthConsumerMain.java b/samples/auth-sample/auth-consumer/src/main/java/org/apache/servicecomb/samples/auth/consumer/AuthConsumerMain.java similarity index 97% rename from samples/auth-sample/auth-consumer/src/main/java/org/apache/servicecomb/samples/springmvc/consumer/AuthConsumerMain.java rename to samples/auth-sample/auth-consumer/src/main/java/org/apache/servicecomb/samples/auth/consumer/AuthConsumerMain.java index c3993dddf..eeb21cfc5 100644 --- a/samples/auth-sample/auth-consumer/src/main/java/org/apache/servicecomb/samples/springmvc/consumer/AuthConsumerMain.java +++ b/samples/auth-sample/auth-consumer/src/main/java/org/apache/servicecomb/samples/auth/consumer/AuthConsumerMain.java @@ -14,7 +14,7 @@ * See the License for the specific language governing permissions and * limitations under the License. */ -package org.apache.servicecomb.samples.springmvc.consumer; +package org.apache.servicecomb.samples.auth.consumer; import org.apache.servicecomb.foundation.common.utils.BeanUtils; import org.apache.servicecomb.foundation.common.utils.Log4jUtils; diff --git a/samples/auth-sample/auth-provider/src/main/java/org/apache/servicecomb/samples/springmvc/provider/AuthProviderMain.java b/samples/auth-sample/auth-provider/src/main/java/org/apache/servicecomb/samples/auth/provider/AuthProviderMain.java similarity index 94% rename from samples/auth-sample/auth-provider/src/main/java/org/apache/servicecomb/samples/springmvc/provider/AuthProviderMain.java rename to samples/auth-sample/auth-provider/src/main/java/org/apache/servicecomb/samples/auth/provider/AuthProviderMain.java index ba4b666cf..f52388eb5 100644 --- a/samples/auth-sample/auth-provider/src/main/java/org/apache/servicecomb/samples/springmvc/provider/AuthProviderMain.java +++ b/samples/auth-sample/auth-provider/src/main/java/org/apache/servicecomb/samples/auth/provider/AuthProviderMain.java @@ -15,7 +15,7 @@ * limitations under the License. */ -package org.apache.servicecomb.samples.springmvc.provider; +package org.apache.servicecomb.samples.auth.provider; import org.apache.servicecomb.foundation.common.utils.BeanUtils; import org.apache.servicecomb.foundation.common.utils.Log4jUtils; diff --git a/samples/auth-sample/auth-provider/src/main/java/org/apache/servicecomb/samples/springmvc/provider/SpringmvcHelloImpl.java b/samples/auth-sample/auth-provider/src/main/java/org/apache/servicecomb/samples/auth/provider/SpringmvcHelloImpl.java similarity index 96% rename from samples/auth-sample/auth-provider/src/main/java/org/apache/servicecomb/samples/springmvc/provider/SpringmvcHelloImpl.java rename to samples/auth-sample/auth-provider/src/main/java/org/apache/servicecomb/samples/auth/provider/SpringmvcHelloImpl.java index 47113d736..42ef65d88 100644 --- a/samples/auth-sample/auth-provider/src/main/java/org/apache/servicecomb/samples/springmvc/provider/SpringmvcHelloImpl.java +++ b/samples/auth-sample/auth-provider/src/main/java/org/apache/servicecomb/samples/auth/provider/SpringmvcHelloImpl.java @@ -15,7 +15,7 @@ * limitations under the License. */ -package org.apache.servicecomb.samples.springmvc.provider; +package org.apache.servicecomb.samples.auth.provider; import javax.ws.rs.core.MediaType; diff --git a/samples/auth-sample/auth-provider/src/main/resources/META-INF/sprin
[GitHub] weichao666 commented on a change in pull request #613: [SCB-416]For load balance rule configurations, we need provider service level configuration
weichao666 commented on a change in pull request #613: [SCB-416]For load
balance rule configurations, we need provider service level configuration
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/613#discussion_r175434451
##
File path:
handlers/handler-loadbalance/src/main/java/org/apache/servicecomb/loadbalance/Configuration.java
##
@@ -101,10 +101,11 @@ public String getRuleStrategyName(String microservice) {
PROP_ROOT + PROP_RULE_STRATEGY_NAME);
}
- public int getSessionTimeoutInSeconds() {
+ public int getSessionTimeoutInSeconds(String microservice) {
final int defaultValue = 30;
// do not support MicroService level now
Review comment:
this annotation can be deleted.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] WillemJiang commented on a change in pull request #614: [SCB-417] delete useless lines in readme
WillemJiang commented on a change in pull request #614: [SCB-417] delete useless lines in readme URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/614#discussion_r175428342 ## File path: samples/README.md ## @@ -7,20 +7,4 @@ It's the samples of Java chassis 4. code first sample 5. customer handler sample 6. extend metrics health checker sample -7. write metrics data into separate text files sample - -## 1. Start the ServiceComb/Service Center Review comment: Yeah, we need to keep the Service-Center running instruction here. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weichao666 commented on a change in pull request #613: [SCB-416]For load balance rule configurations, we need provider service level configuration
weichao666 commented on a change in pull request #613: [SCB-416]For load
balance rule configurations, we need provider service level configuration
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/613#discussion_r175435231
##
File path:
handlers/handler-loadbalance/src/main/java/org/apache/servicecomb/loadbalance/Configuration.java
##
@@ -113,10 +114,11 @@ public int getSessionTimeoutInSeconds() {
}
}
- public int getSuccessiveFailedTimes() {
+ public int getSuccessiveFailedTimes(String microservice) {
final int defaultValue = 5;
// do not support MicroService level now
Review comment:
this annotation can be deleted too.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] WillemJiang commented on a change in pull request #614: [SCB-417] delete useless lines in readme
WillemJiang commented on a change in pull request #614: [SCB-417] delete useless lines in readme URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/614#discussion_r175435491 ## File path: samples/README.md ## @@ -7,20 +7,4 @@ It's the samples of Java chassis 4. code first sample 5. customer handler sample 6. extend metrics health checker sample -7. write metrics data into separate text files sample - -## 1. Start the ServiceComb/Service Center Review comment: I just checked the README file from other examples, they have the service center start instruction. We should remove these lines. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] WillemJiang closed pull request #614: [SCB-417] delete useless lines in readme
WillemJiang closed pull request #614: [SCB-417] delete useless lines in readme URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/614 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/samples/README.md b/samples/README.md index dc2fa0562..08d84503d 100644 --- a/samples/README.md +++ b/samples/README.md @@ -7,20 +7,4 @@ It's the samples of Java chassis 4. code first sample 5. customer handler sample 6. extend metrics health checker sample -7. write metrics data into separate text files sample - -## 1. Start the ServiceComb/Service Center - -[how to start the service center](http://servicecomb.io/users/setup-environment/#) - -## 2.Start the Microservice server - -```bash -mvn test -Pserver -``` - -## 3.Start the Microservice client - -```bash -mvn test -Pclient -``` +7. write metrics data into separate text files sample \ No newline at end of file This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] asifdxtreme opened a new pull request #315: Add Dockerfile to base directory
asifdxtreme opened a new pull request #315: Add Dockerfile to base directory URL: https://github.com/apache/incubator-servicecomb-service-center/pull/315 Signed-off-by: asifdxtreme Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] asifdxtreme closed pull request #310: SCB-411 SC can not check the reduplicate endpoints when register with ID
asifdxtreme closed pull request #310: SCB-411 SC can not check the reduplicate
endpoints when register with ID
URL: https://github.com/apache/incubator-servicecomb-service-center/pull/310
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/pkg/validate/validate.go b/pkg/validate/validate.go
index 59190e3b..7bbe15e1 100644
--- a/pkg/validate/validate.go
+++ b/pkg/validate/validate.go
@@ -48,10 +48,10 @@ func (v *ValidateRule) String() string {
idx++
}
if v.Regexp != nil {
- arr[idx] = fmt.Sprintf("Length: %s", v.Regexp)
+ arr[idx] = fmt.Sprintf("Regexp: %s", v.Regexp)
idx++
}
- return "rule: {" + util.StringJoin(arr[:idx], ",") + "}"
+ return "{" + util.StringJoin(arr[:idx], ",") + "}"
}
func (v *ValidateRule) Match(s interface{}) bool {
@@ -239,9 +239,9 @@ func (v *Validator) Validate(s interface{}) error {
// TODO null pointer如何校验
if field.Kind() != reflect.Ptr && !validate.Match(fi) {
if filter(fieldName) {
- return fmt.Errorf("invalid field: %s.%s
, %s", st.Type.Name(), fieldName, validate)
+ return fmt.Errorf("The field '%s.%s'
value does not match rule: %s", st.Type.Name(), fieldName, validate)
}
- return fmt.Errorf("invalid field: %s.%s,
invalid value: {%v} , %s", st.Type.Name(), fieldName, fi, validate)
+ return fmt.Errorf("The field '%s.%s' value(%v)
does not match rule: %s", st.Type.Name(), fieldName, fi, validate)
}
}
}
@@ -249,9 +249,9 @@ func (v *Validator) Validate(s interface{}) error {
}
var (
- BLACK_LIST_FOR_PRINT = map[string]interface{} {
- "Properties": nil,
- }
+ BLACK_LIST_FOR_PRINT = map[string]struct{}{
+ "Properties": {},
+ }
)
func filter(fieldName string) bool {
diff --git a/server/core/backend/store/lease.go
b/server/core/backend/store/lease.go
index 04a2ff98..192ae8c6 100644
--- a/server/core/backend/store/lease.go
+++ b/server/core/backend/store/lease.go
@@ -43,27 +43,27 @@ func (lat *LeaseAsyncTask) Do(ctx context.Context) (err
error) {
lat.StartTime = time.Now()
lat.TTL, err = backend.Registry().LeaseRenew(ctx, lat.LeaseID)
lat.EndTime = time.Now()
- if err == nil {
- lat.err = err
- util.LogNilOrWarnf(lat.CreateTime, "renew lease %d(rev: %s,
run: %s), key %s",
+ if err != nil {
+ util.Logger().Errorf(err, "[%s]renew lease %d failed(rev: %s,
run: %s), key %s",
+ time.Now().Sub(lat.CreateTime),
lat.LeaseID,
lat.CreateTime.Format(TIME_FORMAT),
lat.StartTime.Format(TIME_FORMAT),
lat.Key())
- return
+ if _, ok := err.(errorsEx.InternalError); !ok {
+ // it means lease not found if err is not the
InternalError type
+ lat.err = err
+ return
+ }
}
- util.Logger().Errorf(err, "[%s]renew lease %d failed(rev: %s, run: %s),
key %s",
- time.Now().Sub(lat.CreateTime),
+ lat.err, err = nil, nil
+ util.LogNilOrWarnf(lat.CreateTime, "renew lease %d(rev: %s, run: %s),
key %s",
lat.LeaseID,
lat.CreateTime.Format(TIME_FORMAT),
lat.StartTime.Format(TIME_FORMAT),
lat.Key())
- if _, ok := err.(errorsEx.InternalError); !ok {
- lat.err = err
- return
- }
- return nil
+ return
}
func (lat *LeaseAsyncTask) Err() error {
diff --git a/server/core/common.go b/server/core/common.go
index 7b35285b..2ea5de2c 100644
--- a/server/core/common.go
+++ b/server/core/common.go
@@ -67,7 +67,7 @@ func init() {
pathRegex, _ := regexp.Compile(`^[A-Za-z0-9.,?'\\/+&%$#=~_\-@{}]*$`)
// descriptionRegex, _ := regexp.Compile(`^[\p{Han}\w\s。.:*,\-：”“"]*$`)
levelRegex, _ := regexp.Compile(`^(FRONT|MIDDLE|BACK)$`)
- statusRegex, _ := regexp.Compile("^(" + pb.MS_UP + "|" + pb.MS_DOWN +
")*$")
+ statusRegex, _ := regexp.Compile("^(" + pb.MS_UP + "|" + pb.MS_DOWN +
")?$")
serviceIdRegex, _ := regexp.Compile(`^.*$`)
aliasRegex, _ := regexp.Compile(`^[a-zA-Z0-9_\-.:]*$`)
registerByRegex, _ := regexp.Compile("^(" +
util.StringJoin([]string{pb.REGISTERBY_SDK, pb.REGISTERBY_SIDECAR}, "|") +
")*$")
@@ -78,7 +78,7
[GitHub] weichao666 commented on a change in pull request #613: [SCB-416]For load balance rule configurations, we need provider service level configuration
weichao666 commented on a change in pull request #613: [SCB-416]For load
balance rule configurations, we need provider service level configuration
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/613#discussion_r175445652
##
File path:
handlers/handler-loadbalance/src/test/java/org/apache/servicecomb/loadbalance/TestLoadBalancer.java
##
@@ -146,4 +148,32 @@ public void testGetAllServers() {
Mockito.when(filter.getFilteredListOfServers(servers)).thenReturn(servers);
Assert.assertEquals(servers, loadBalancer.getAllServers());
}
+
+ @Test
+ public void testLaodBalanceWithSessionSticknessRule() {
Review comment:
it's testLoad, not testLaod
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] coveralls commented on issue #315: Add Dockerfile to base directory
coveralls commented on issue #315: Add Dockerfile to base directory URL: https://github.com/apache/incubator-servicecomb-service-center/pull/315#issuecomment-374225112 [](https://coveralls.io/builds/16051753) Coverage increased (+0.2%) to 74.087% when pulling **dbfbab0a3c5235cd6b59f4ebcd0b37617d3406b2 on asifdxtreme:master** into **29fbda9e72860b957de02ba71e68f0ae59244dee on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #315: Add Dockerfile to base directory
codecov-io commented on issue #315: Add Dockerfile to base directory URL: https://github.com/apache/incubator-servicecomb-service-center/pull/315#issuecomment-374225263 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/315?src=pr&el=h1) Report > Merging [#315](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/315?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/29fbda9e72860b957de02ba71e68f0ae59244dee?src=pr&el=desc) will **increase** coverage by `0.02%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/315?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master #315 +/- ## == + Coverage 70.33% 70.36% +0.02% == Files 17 17 Lines3452 3452 == + Hits 2428 2429 +1 Misses853 853 + Partials 171 170 -1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/315?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [server/service/tag.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/315/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdGFnLmdv) | `76.02% <0%> (+0.58%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/315?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/315?src=pr&el=footer). Last update [29fbda9...dbfbab0](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/315?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
Re: [VOTE] Release Apache ServiceComb Service-Center (incubating) version 1.0.0-m1 - Fourth Attempt
+1 -- Original -- From: Mohammad Asif Siddiqui Date: Mon,Mar 19,2018 0:16 PM To: dev Subject: Re: [VOTE] Release Apache ServiceComb Service-Center (incubating) version 1.0.0-m1 - Fourth Attempt +1 Binding I Checked - incubating in name - hashes and signatures is good - DISCLAIMER exists - can compile from source - checked for archive matching git tag - Source file have ASF headers - ran Integration test using release binary on windows and linux - ran java-chassis demo(springmvc) using service-center release binary. Regards Asif On 2018/03/16 18:38:32, Mohammad Asif Siddiqui wrote: > Hi All, > > This is a call for Vote to release Apache ServiceComb Service-Center > (Incubating) version 1.0.0-m1 (fourth release candidate). > > Release Notes : > https://github.com/apache/incubator-servicecomb-service-center/blob/master/docs/release/releaseNotes.md > > > Release Candidate : > https://dist.apache.org/repos/dist/dev/incubator/servicecomb/incubator-servicecomb-service-center/1.0.0-m1/ > > > Release Tag : > https://github.com/apache/incubator-servicecomb-service-center/releases/tag/1.0.0-m1 > > > Release CommitID : 94cea25ba55e763dbe23d0cd4a8da73e37a50539 > > Keys to verify the Release Candidate : > https://dist.apache.org/repos/dist/dev/incubator/servicecomb/KEYS > > Guide to build the release from source : > https://github.com/apache/incubator-servicecomb-service-center/tree/master/scripts/release > > > Voting will start now ( Saturday, 17th March, 2018) and will remain open for > next 72 hours, Request all PPMC members to give their vote. > [ ] +1 Release this package as 1.0.0-m1 > [ ] +0 No Opinion > [ ] -1 Do not release this package because > > Regards > Asif > > >
?????? [VOTE] Release Apache ServiceComb Java-Chassis (incubating) version 1.0.0-m1 - Second Attempt
Hi All: I had checked the latest release : Release Candidate : https://dist.apache.org/repos/dist/dev/incubator/servicecomb/incubator-servicecomb-java-chassis/1.0.0-m1/ Staging Repo : https://repository.apache.org/content/repositories/orgapacheservicecomb-1196/ All problem had solved ,No any new problem found ,so +1 non binding -- -- ??: "??"; : 2018??3??19??(??) 3:54 ??: "dev"; : Re: [VOTE] Release Apache ServiceComb Java-Chassis (incubating) version 1.0.0-m1 - Second Attempt +0 Non Binding Built the code from Release Candidate then check all samples using Staging Repo. Run unit tests and integration tests. Problem : 1.Need Update Release notes: https://issues.apache.org/jira/browse/SCB-414 2.Pojo sample will be failed when running "mvn exec:java" : https://issues.apache.org/jira/browse/SCB-413 Suggestion: 1.Change "apollo.config.clusters" setting value in config-apollo-sample from "test-cluster" to "default" : https://issues.apache.org/jira/browse/SCB-415 -- Original -- From: "Mohammad Asif Siddiqui"; Date: Sat, Mar 17, 2018 02:52 AM To: "dev"; Subject: [VOTE] Release Apache ServiceComb Java-Chassis (incubating) version 1.0.0-m1 - Second Attempt Hi All, This is a call for Vote to release Apache ServiceComb Java-Chassis (Incubating) version 1.0.0-m1 Release Notes : https://github.com/apache/incubator-servicecomb-java-chassis/blob/master/etc/releaseNotes.md Release Candidate : https://dist.apache.org/repos/dist/dev/incubator/servicecomb/incubator-servicecomb-java-chassis/1.0.0-m1/ Staging Repo : https://repository.apache.org/content/repositories/orgapacheservicecomb-1181/ Release Tag : https://github.com/apache/incubator-servicecomb-java-chassis/releases/tag/1.0.0-m1 Release CommitID : 3dbfb87eb6249f3ad41ea7514d1a73ec6e193bfe Keys to verify the Release Candidate : https://dist.apache.org/repos/dist/dev/incubator/servicecomb/KEYS Voting will start now ( Saturday, 17th March, 2018) and will remain open for next 72 hours, Request all PPMC members to give their vote [ ] +1 Release this package as 1.0.0-m1 [ ] +0 No Opinion [ ] -1 Do not release this package because Regards Asif
[RESULT] [VOTE] Release Apache ServiceComb Service-Center (incubating) version 1.0.0-m1 - Fourth Attempt
Hi All, I am glad to announce that ServiceComb community has approved the Apache ServiceComb Service-Center(incubating) 1.0.0-m1 release with the following results: +1 binding: 4 (Willem Jiang, Cuiyihua, Liubao, Mohammad Asif Siddiqui) +1 non-binding: 5 (Yang Bo, Eric Lee, Ma BIn, Zen Lin, MaheshRaju) We will be publishing the release binaries shortly.. Thanks All for your participation in this vote. Regards Asif
?????? [VOTE] Release Apache ServiceComb Java-Chassis (incubating) version 1.0.0-m1 - Second Attempt
Hi All: Sorry this is my mistake??The new VOTE has not started yet. I withdrew my +1, thanks. -- -- ??: "??"; : 2018??3??20??(??) 9:54 ??: "dev"; : ?? [VOTE] Release Apache ServiceComb Java-Chassis (incubating) version 1.0.0-m1 - Second Attempt Hi All: I had checked the latest release : Release Candidate : https://dist.apache.org/repos/dist/dev/incubator/servicecomb/incubator-servicecomb-java-chassis/1.0.0-m1/ Staging Repo : https://repository.apache.org/content/repositories/orgapacheservicecomb-1196/ All problem had solved ,No any new problem found ,so +1 non binding -- -- ??: "??"; : 2018??3??19??(??) 3:54 ??: "dev"; : Re: [VOTE] Release Apache ServiceComb Java-Chassis (incubating) version 1.0.0-m1 - Second Attempt +0 Non Binding Built the code from Release Candidate then check all samples using Staging Repo. Run unit tests and integration tests. Problem : 1.Need Update Release notes: https://issues.apache.org/jira/browse/SCB-414 2.Pojo sample will be failed when running "mvn exec:java" : https://issues.apache.org/jira/browse/SCB-413 Suggestion: 1.Change "apollo.config.clusters" setting value in config-apollo-sample from "test-cluster" to "default" : https://issues.apache.org/jira/browse/SCB-415 -- Original -- From: "Mohammad Asif Siddiqui"; Date: Sat, Mar 17, 2018 02:52 AM To: "dev"; Subject: [VOTE] Release Apache ServiceComb Java-Chassis (incubating) version 1.0.0-m1 - Second Attempt Hi All, This is a call for Vote to release Apache ServiceComb Java-Chassis (Incubating) version 1.0.0-m1 Release Notes : https://github.com/apache/incubator-servicecomb-java-chassis/blob/master/etc/releaseNotes.md Release Candidate : https://dist.apache.org/repos/dist/dev/incubator/servicecomb/incubator-servicecomb-java-chassis/1.0.0-m1/ Staging Repo : https://repository.apache.org/content/repositories/orgapacheservicecomb-1181/ Release Tag : https://github.com/apache/incubator-servicecomb-java-chassis/releases/tag/1.0.0-m1 Release CommitID : 3dbfb87eb6249f3ad41ea7514d1a73ec6e193bfe Keys to verify the Release Candidate : https://dist.apache.org/repos/dist/dev/incubator/servicecomb/KEYS Voting will start now ( Saturday, 17th March, 2018) and will remain open for next 72 hours, Request all PPMC members to give their vote [ ] +1 Release this package as 1.0.0-m1 [ ] +0 No Opinion [ ] -1 Do not release this package because Regards Asif
Re: [RESULT] [VOTE] Release Apache ServiceComb Service-Center (incubating) version 1.0.0-m1 - Fourth Attempt
Hi All, We will send this Release Candidate for IPMC approval, Once the vote passes there then we will publish the binaries. Regards Asif On 2018/03/20 02:07:58, Mohammad Asif Siddiqui wrote: > Hi All, > > I am glad to announce that ServiceComb community has approved the Apache > ServiceComb Service-Center(incubating) 1.0.0-m1 release with the following > results: > > +1 binding: 4 (Willem Jiang, Cuiyihua, Liubao, Mohammad Asif Siddiqui) > +1 non-binding: 5 (Yang Bo, Eric Lee, Ma BIn, Zen Lin, MaheshRaju) > > We will be publishing the release binaries shortly.. > > Thanks All for your participation in this vote. > > Regards > Asif > >
[RESULT] [VOTE] Release Apache ServiceComb Saga (incubating) version 0.1.0 - Second Attempt
Hi All, I am glad to announce that ServiceComb community has approved the Apache ServiceComb Saga(incubating) 0.1.0 release with the following results: +1 binding: 3 (Willem Jiang, Cuiyihua, Mohammad Asif Siddiqui) +1 non-binding: 5 (Yang Bo, Eric Lee, Libo, Kirin Wang, Ma BIn, Zen Lin, MaheshRaju) We will send this Release Candidate for IPMC approval, once the vote passes there then we will publish the binaries. Thanks All for your participation in this vote. Regards Asif
Re: 回复： [VOTE] Release Apache ServiceComb Java-Chassis (incubating) version 1.0.0-m1 - Second Attempt
Hi All, Since the new release candidate solves the issues so we will re-initiate the voting mail for this release candidate in a seperate thread. Regards Asif On 2018/03/20 01:54:20, "éæ¬å" wrote: > Hi All: >I had checked the latest release : >Release Candidate : > https://dist.apache.org/repos/dist/dev/incubator/servicecomb/incubator-servicecomb-java-chassis/1.0.0-m1/ > > Staging Repo : > https://repository.apache.org/content/repositories/orgapacheservicecomb-1196/ > >All problem had solved ,No any new problem found ,so > >+1 non binding > > > -- åå§é®ä»¶ -- > å件人: "éæ¬å"; > åéæ¶é´: 2018å¹´3æ19æ¥(ææä¸) ä¸å3:54 > æ¶ä»¶äºº: "dev"; > > 主é¢: Re: [VOTE] Release Apache ServiceComb Java-Chassis (incubating) > version 1.0.0-m1 - Second Attempt > > > > +0 Non Binding > > Built the code from Release Candidate then check all samples using Staging > Repo. > Run unit tests and integration tests. > > Problem : > 1.Need Update Release notes: https://issues.apache.org/jira/browse/SCB-414 > 2.Pojo sample will be failed when running "mvn exec:java" : > https://issues.apache.org/jira/browse/SCB-413 > > Suggestion: > 1.Change "apollo.config.clusters" setting value in config-apollo-sample from > "test-cluster" to "default" : https://issues.apache.org/jira/browse/SCB-415 > > -- Original -- > From: "Mohammad Asif Siddiqui"; > Date: Sat, Mar 17, 2018 02:52 AM > To: "dev"; > > Subject: [VOTE] Release Apache ServiceComb Java-Chassis (incubating) > version 1.0.0-m1 - Second Attempt > > > > Hi All, > > This is a call for Vote to release Apache ServiceComb Java-Chassis > (Incubating) version 1.0.0-m1 > > Release Notes : > https://github.com/apache/incubator-servicecomb-java-chassis/blob/master/etc/releaseNotes.md > > > Release Candidate : > https://dist.apache.org/repos/dist/dev/incubator/servicecomb/incubator-servicecomb-java-chassis/1.0.0-m1/ > > > Staging Repo : > https://repository.apache.org/content/repositories/orgapacheservicecomb-1181/ > > Release Tag : > https://github.com/apache/incubator-servicecomb-java-chassis/releases/tag/1.0.0-m1 > > > Release CommitID : 3dbfb87eb6249f3ad41ea7514d1a73ec6e193bfe > > Keys to verify the Release Candidate : > https://dist.apache.org/repos/dist/dev/incubator/servicecomb/KEYS > > Voting will start now ( Saturday, 17th March, 2018) and will remain open for > next 72 hours, Request all PPMC members to give their vote > > [ ] +1 Release this package as 1.0.0-m1 > [ ] +0 No Opinion > [ ] -1 Do not release this package because > > Regards > Asif
[VOTE] Release Apache ServiceComb Java-Chassis (incubating) version 1.0.0-m1 - Third Attempt
Hi All, This is a call for Vote to release Apache ServiceComb Java-Chassis (Incubating) version 1.0.0-m1 Release Notes : https://github.com/apache/incubator-servicecomb-java-chassis/blob/master/etc/releaseNotes.md Release Candidate : https://dist.apache.org/repos/dist/dev/incubator/servicecomb/incubator-servicecomb-java-chassis/1.0.0-m1/ Staging Repo : https://repository.apache.org/content/repositories/orgapacheservicecomb-1196 Release Tag : https://github.com/apache/incubator-servicecomb-java-chassis/releases/tag/1.0.0-m1 Release CommitID : 901869b987c6f65c92b5b8b8f05eaf0f9f6e69cb Keys to verify the Release Candidate : https://dist.apache.org/repos/dist/dev/incubator/servicecomb/KEYS Voting will start now ( Tuesday, 20th March, 2018) and will remain open for next 72 hours, Request all PPMC members to give their vote. [ ] +1 Release this package as 1.0.0-m1 [ ] +0 No Opinion [ ] -1 Do not release this package because Regards Asif
[GitHub] zhfeng opened a new pull request #156: SCB-390 Update to introduece the byteman to the acceptance tests
zhfeng opened a new pull request #156: SCB-390 Update to introduece the byteman to the acceptance tests URL: https://github.com/apache/incubator-servicecomb-saga/pull/156 Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #156: SCB-390 Update to introduece the byteman to the acceptance tests
coveralls commented on issue #156: SCB-390 Update to introduece the byteman to the acceptance tests URL: https://github.com/apache/incubator-servicecomb-saga/pull/156#issuecomment-374489236 [](https://coveralls.io/builds/16067959) Coverage decreased (-0.4%) to 94.846% when pulling **e0393ed4cef53c194366f06c5af5f74339de811d on zhfeng:SCB-390** into **3c3979596d6da2ec30e316e92e750264f5fde1e0 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[SAGA] introduce the byteman to the acceptance tests
Hi all,
I just send the PR [1] to introduce the byteman[2] to our acceptance tests.
The byteman could be used to inject the fault into the java classes. The PR
includes
1. unpack the byteman.jar into the ${project.output.directory}/saga which
can be assembled into the docker image.
2. set the JAVA_OPTS to
"-javaagent:/maven/saga/byteman.jar=port:9091,address:0.0.0.0,listener:true",
so we can submit the rule scripts to the remote jvm.
3. update the step of the test to accept the rule of submitting the rule
script. such as
Given Install the byteman script ${path_to_the_btm} to ${service_name}
Service
Anyway, now we are able to submit the byteman rule scripts to the demo
services. I will continue to write the rules to tests the scenarios of timeout
and crashing and recovering.
Welcome to any feedback !
Thanks,
[1] https://github.com/apache/incubator-servicecomb-saga/pull/156
[2] http://byteman.jboss.org/
[GitHub] liubao68 commented on a change in pull request #594: [SCB-379] support AsyncRestTemplate
liubao68 commented on a change in pull request #594: [SCB-379] support
AsyncRestTemplate
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/594#discussion_r175666547
##
File path:
providers/provider-springmvc/src/main/java/org/apache/servicecomb/provider/springmvc/reference/async/AcceptableAsyncRestTemplate.java
##
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.provider.springmvc.reference.async;
+
+import java.net.URI;
+
+import org.springframework.web.client.AsyncRestTemplate;
+
+public abstract class AcceptableAsyncRestTemplate extends AsyncRestTemplate {
Review comment:
since wrapper class deleted, this interface can be deleted also.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
