[jira] [Resolved] (SLING-1725) Register internal post operations as services for consumption by servlets other than the SlingPostServlet
[ https://issues.apache.org/jira/browse/SLING-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Felix Meschberger resolved SLING-1725. -- Resolution: Fixed Yes, resolved. Register internal post operations as services for consumption by servlets other than the SlingPostServlet - Key: SLING-1725 URL: https://issues.apache.org/jira/browse/SLING-1725 Project: Sling Issue Type: Improvement Components: Servlets Affects Versions: Servlets Post 2.0.4 Reporter: Felix Meschberger Assignee: Felix Meschberger Fix For: Servlets Post 2.1.2 Attachments: SLING-1725.patch As discussed in [1] it would be useful to have the internal operations of the Sling POST Servlet available as services for other bundles to reuse. [1] http://markmail.org/message/a7vrtyhictf7tv4m -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-1974) Accept header issues in the Sling POST Servlet
[ https://issues.apache.org/jira/browse/SLING-1974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13197708#comment-13197708 ] Felix Meschberger commented on SLING-1974: -- Lets postpone to the next release... Accept header issues in the Sling POST Servlet -- Key: SLING-1974 URL: https://issues.apache.org/jira/browse/SLING-1974 Project: Sling Issue Type: Bug Components: Servlets Affects Versions: Servlets Post 2.1.0 Reporter: Felix Meschberger Fix For: Servlets Post 2.1.2 Attachments: SLING-1974.patch As of SLING-1336 the Sling POST Servlet can interpret the Accept request header to select what response content type to render. Unfortunately that handling seems broken as for an Accept header like (as generated by FireFox with the JSONovich plugin installed) : Accept: text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8,application/json the JSON response might be selected but sometimes also text/html (we can observe both behaviours for different server platforms with our application). The Accept header should probably consider equivalent q values (as for text/html and application/json in the example) to solve the tie by selecting the first type list; thus text/html in this example. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (SLING-2393) Update Post Servlet Documentation for patch operation
Update Post Servlet Documentation for patch operation - Key: SLING-2393 URL: https://issues.apache.org/jira/browse/SLING-2393 Project: Sling Issue Type: Task Components: Servlets Affects Versions: Servlets Post 2.1.0 Reporter: Felix Meschberger Add documentation to http://sling.apache.org/site/manipulating-content-the-slingpostservlet-servletspost.html with information on patch operation (see SLING-1983) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (SLING-2394) Resource type might be null if provided artifact is not copied
Resource type might be null if provided artifact is not copied -- Key: SLING-2394 URL: https://issues.apache.org/jira/browse/SLING-2394 Project: Sling Issue Type: Bug Components: Installer Affects Versions: Installer Core 3.3.2, Installer Core 3.3.4 Reporter: Carsten Ziegeler Assignee: Carsten Ziegeler Fix For: Installer Core 3.3.6 If the provider does not require the artifact to be copied and the provider does no resource type detection, than the type is null which later on causes NPEs The type should always be set -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (SLING-2394) Resource type might be null if provided artifact is not copied
[ https://issues.apache.org/jira/browse/SLING-2394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-2394. - Resolution: Fixed Fixed in revision 1239021 Resource type might be null if provided artifact is not copied -- Key: SLING-2394 URL: https://issues.apache.org/jira/browse/SLING-2394 Project: Sling Issue Type: Bug Components: Installer Affects Versions: Installer Core 3.3.2, Installer Core 3.3.4 Reporter: Carsten Ziegeler Assignee: Carsten Ziegeler Fix For: Installer Core 3.3.6 If the provider does not require the artifact to be copied and the provider does no resource type detection, than the type is null which later on causes NPEs The type should always be set -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (SLING-1983) Post servlet: Patching multi-value properties
[ https://issues.apache.org/jira/browse/SLING-1983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Felix Meschberger resolved SLING-1983. -- Resolution: Fixed Can be resolved, documentation to be done as part of SLING-2393 Post servlet: Patching multi-value properties - Key: SLING-1983 URL: https://issues.apache.org/jira/browse/SLING-1983 Project: Sling Issue Type: New Feature Components: Servlets Affects Versions: Servlets Post 2.1.0 Reporter: Alexander Klimetschek Assignee: Felix Meschberger Fix For: Servlets Post 2.1.2 Attachments: SLING-1983.patch As described on the sling list http://sling.markmail.org/thread/xxaaqowtx7jgfo3p , allow patching of multi-value properties: New @Patch suffix: my:property@TypeHint=String[] my:property@Patch=true my:property=+value1 my:property=-value1 When @Patch is present, each of the property values from the request are expected to start with either + or -, followed by the actual value. These two would represent the operations you want to have executed on the set. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (SLING-1983) Post servlet: Patching multi-value properties
[ https://issues.apache.org/jira/browse/SLING-1983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Felix Meschberger reopened SLING-1983: -- wrong resolution Post servlet: Patching multi-value properties - Key: SLING-1983 URL: https://issues.apache.org/jira/browse/SLING-1983 Project: Sling Issue Type: New Feature Components: Servlets Affects Versions: Servlets Post 2.1.0 Reporter: Alexander Klimetschek Assignee: Felix Meschberger Fix For: Servlets Post 2.1.2 Attachments: SLING-1983.patch As described on the sling list http://sling.markmail.org/thread/xxaaqowtx7jgfo3p , allow patching of multi-value properties: New @Patch suffix: my:property@TypeHint=String[] my:property@Patch=true my:property=+value1 my:property=-value1 When @Patch is present, each of the property values from the request are expected to start with either + or -, followed by the actual value. These two would represent the operations you want to have executed on the set. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
The beast that is JcrResourceResolverFactoryImpl
I am experimenting with using Sling in a non-JCR application, that is, I want to leverage Sling's templating support, OSGi goodies, resource resolution etc, without using JCR, but in this case, a regular relational database. I have created a ResourceProvider which turns DB data into resources, so far so good. But I'd like to avoid any JCR dependency whatsoever. The changes outlined in [1] did a lot to allow custom ResourceResolverFactories. Still, much basic functionality happens in JcrResourceResolverFactoryImpl that makes it hard to avoid, without reimplementing: . - Domain mappings (o.a.s.jcr.resource.internal.helper.MapEntries, MapEntry, Mapping) (JCR independant since SLING-1463 [2]) - Redirect resouces (o.a.s.jcr.resource.internal.helper.RedirectResource) - Resource iterator (o.a.s.jcr.resource.internal.helper.ResourceIterator) - Star Resource (o.a.s.jcr.resource.internal.helper.starresource.StarResource) - Resource provider resolution logic (o.a.s.jcr.resource.internal.helper.ResourceProviderEntry) - (maybe others) In fact, none of the classes listed above imports any packages from javax.jcr. So, if we accept that a non-JCR ResourceResolverFactory would have to implement these features, shouldn't they be available somewhere outside JcrResourceResolverFactoryImpl? I'm not sure what is the best approach - an AbstractResourceResolverFactory, or turning these features into separate components. Any thoughts? [1] https://cwiki.apache.org/SLING/add-resourceresolverfactory-service-interface.html [2] https://issues.apache.org/jira/browse/SLING-1463 -- Vidar S. Ramdal vidar.ram...@webstep.no Webstep AS - http://www.webstep.no Besøksadresse: Lilleakerveien 8, 0283 Oslo Postadresse: Postboks 272 Lilleaker, 0216 Oslo
[jira] [Commented] (SLING-2320) Current DOS-prevention for infinity.json can prevent enumeration of children
[ https://issues.apache.org/jira/browse/SLING-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13197723#comment-13197723 ] Jeff Young commented on SLING-2320: --- My last patch (which contains all the good bug fixes; see a - d above) still needs committing. Current DOS-prevention for infinity.json can prevent enumeration of children Key: SLING-2320 URL: https://issues.apache.org/jira/browse/SLING-2320 Project: Sling Issue Type: Bug Components: Servlets Affects Versions: Servlets Get 2.1.0 Reporter: Jeff Young Assignee: Felix Meschberger Labels: newbie, patch Fix For: Servlets Get 2.1.4 Attachments: jsonRenderer.diff, json_get_servlet_rewrite.patch, servlet_tests.patch Original Estimate: 1h Remaining Estimate: 1h A request of resource.1.json should always succeed, as it's the primary method for JSON introspection of the repository hierarchy. DOS protection should only apply to deep traversals; that is, anything with a depth greater than 1 (and, in particular, resource.infinity.json). For a fuller discussion, see: http://www.mail-archive.com/dev@sling.apache.org/msg13961.html. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
Jenkins build is back to normal : sling-trunk-1.5 #1570
See https://builds.apache.org/job/sling-trunk-1.5/1570/changes
Jenkins build is back to normal : sling-trunk-1.6 #1240
See https://builds.apache.org/job/sling-trunk-1.6/1240/
[jira] [Created] (SLING-2395) Metatype default value for log file size (rotation policy) does not match actual default
Metatype default value for log file size (rotation policy) does not match actual default Key: SLING-2395 URL: https://issues.apache.org/jira/browse/SLING-2395 Project: Sling Issue Type: Bug Components: Commons Affects Versions: Commons Log 2.1.2 Reporter: Felix Meschberger Assignee: Felix Meschberger Fix For: Commons Log 3.0.0 The default value for the log file size (rotation policy) does not match the default value actually used by the LogManager and also does not match the documentation of the property in the metatype.properties file. This should be fixed to match. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (SLING-2395) Metatype default value for log file size (rotation policy) does not match actual default
[ https://issues.apache.org/jira/browse/SLING-2395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Felix Meschberger resolved SLING-2395. -- Resolution: Fixed Fix Version/s: (was: Commons Log 3.0.0) Commons Log 3.0.2 Fixed in Rev. 1239109 Metatype default value for log file size (rotation policy) does not match actual default Key: SLING-2395 URL: https://issues.apache.org/jira/browse/SLING-2395 Project: Sling Issue Type: Bug Components: Commons Affects Versions: Commons Log 2.1.2 Reporter: Felix Meschberger Assignee: Felix Meschberger Fix For: Commons Log 3.0.2 The default value for the log file size (rotation policy) does not match the default value actually used by the LogManager and also does not match the documentation of the property in the metatype.properties file. This should be fixed to match. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
Build failed in Jenkins: sling-contrib-1.5 #818
See https://builds.apache.org/job/sling-contrib-1.5/818/
--
[...truncated 3009 lines...]
[INFO] Copying bundle from
/home/jenkins/.m2/repository/org/apache/sling/org.apache.sling.scripting.xproc/2.0.0-SNAPSHOT/org.apache.sling.scripting.xproc-2.0.0-SNAPSHOT.jar
to
https://builds.apache.org/job/sling-contrib-1.5/ws/contrib-1.5/launchpad/testing/target/launchpad-bundles/resources/bundles/15/org.apache.sling.scripting.xproc-2.0.0-SNAPSHOT.jar
[INFO] snapshot
org.apache.sling:org.apache.sling.extensions.apt.servlet:2.0.3-SNAPSHOT:
checking for updates from apache.snapshots
[INFO] Copying bundle from
/home/jenkins/.m2/repository/org/apache/sling/org.apache.sling.extensions.apt.servlet/2.0.3-SNAPSHOT/org.apache.sling.extensions.apt.servlet-2.0.3-SNAPSHOT.jar
to
https://builds.apache.org/job/sling-contrib-1.5/ws/contrib-1.5/launchpad/testing/target/launchpad-bundles/resources/bundles/15/org.apache.sling.extensions.apt.servlet-2.0.3-SNAPSHOT.jar
[INFO] snapshot
org.apache.sling:org.apache.sling.extensions.apt.parser:2.0.3-SNAPSHOT:
checking for updates from apache.snapshots
[INFO] Copying bundle from
/home/jenkins/.m2/repository/org/apache/sling/org.apache.sling.extensions.apt.parser/2.0.3-SNAPSHOT/org.apache.sling.extensions.apt.parser-2.0.3-SNAPSHOT.jar
to
https://builds.apache.org/job/sling-contrib-1.5/ws/contrib-1.5/launchpad/testing/target/launchpad-bundles/resources/bundles/15/org.apache.sling.extensions.apt.parser-2.0.3-SNAPSHOT.jar
[INFO] snapshot
org.apache.sling.samples:org.apache.sling.samples.path-based.rtp:2.0.5-SNAPSHOT:
checking for updates from apache.snapshots
Downloading:
http://repository.apache.org/snapshots/org/apache/sling/samples/org.apache.sling.samples.path-based.rtp/2.0.5-SNAPSHOT/org.apache.sling.samples.path-based.rtp-2.0.5-SNAPSHOT.jar
[INFO] Copying bundle from
/home/jenkins/.m2/repository/org/apache/sling/samples/org.apache.sling.samples.path-based.rtp/2.0.5-SNAPSHOT/org.apache.sling.samples.path-based.rtp-2.0.5-SNAPSHOT.jar
to
https://builds.apache.org/job/sling-contrib-1.5/ws/contrib-1.5/launchpad/testing/target/launchpad-bundles/resources/bundles/15/org.apache.sling.samples.path-based.rtp-2.0.5-SNAPSHOT.jar
[INFO] [remote-resources:process {execution: default}]
[INFO] [resources:resources {execution: default-resources}]
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 0 resource
[INFO] Copying 3 resources
[INFO] [build-helper:reserve-network-port {execution: reserve-network-port}]
[INFO] Reserved port 38607 for http.port
[WARNING] DEPRECATED [tasks]: Use target instead
[INFO] [antrun:run {execution: default}]
[WARNING] Parameter tasks is deprecated, use target instead
[INFO] Executing tasks
main:
[echo] WARNING (SLING-443/SLING-1782)
**
[echo] On most platforms, you'll get OutOfMemoryErrors when building
unless you set
[echo] on 32bit platforms: MAVEN_OPTS=-Xmx256M -XX:MaxPermSize=256M, see
SLING-443
[echo] on 64bit platforms: MAVEN_OPTS=-Xmx512M -XX:MaxPermSize=512M, see
SLING-1782
[echo]
**
[INFO] Executed tasks
[INFO] [compiler:compile {execution: default-compile}]
[INFO] No sources to compile
[INFO] [resources:testResources {execution: default-testResources}]
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 50 resources
[INFO] Copying 3 resources
[INFO] [compiler:testCompile {execution: default-testCompile}]
[INFO] Compiling 7 source files to
https://builds.apache.org/job/sling-contrib-1.5/ws/contrib-1.5/launchpad/testing/target/test-classes
[WARNING] DEPRECATED [systemProperties]: Use systemPropertyVariables instead.
[INFO] [surefire:test {execution: default-test}]
[INFO] Surefire report directory:
https://builds.apache.org/job/sling-contrib-1.5/ws/contrib-1.5/launchpad/testing/target/surefire-reports
---
T E S T S
---
There are no tests to run.
Results :
Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
[JENKINS] Recording test results[INFO] [animal-sniffer:check {execution:
default}]
[INFO] Checking unresolved references to org.codehaus.mojo.signature:java15:1.0
[INFO] [war:war {execution: default-war}]
[INFO] Packaging webapp
[INFO] Assembling webapp [org.apache.sling.launchpad.contrib-testing] in
[https://builds.apache.org/job/sling-contrib-1.5/ws/contrib-1.5/launchpad/testing/target/org.apache.sling.launchpad.contrib-testing-4-SNAPSHOT]
[INFO] Processing war project
[INFO] Copying webapp webResources
[https://builds.apache.org/job/sling-contrib-1.5/ws/contrib-1.5/launchpad/testing/target/launchpad-bundles]
to
[https://builds.apache.org/job/sling-contrib-1.5/ws/contrib-1.5/launchpad/testing/target/org.apache.sling.launchpad.contrib-testing-4-SNAPSHOT]
[INFO] Copying webapp webResources
Build failed in Jenkins: sling-samples-1.5 #271
See https://builds.apache.org/job/sling-samples-1.5/271/
--
[...truncated 946 lines...]
[INFO] Preparing source:jar
[WARNING] Removing: jar from forked lifecycle, to prevent recursive invocation.
[JENKINS] Archiving
https://builds.apache.org/job/sling-samples-1.5/ws/contrib-1.5/framework-fragment/pom.xml
to
/home/hudson/hudson/jobs/sling-samples-1.5/modules/org.apache.sling$org.apache.sling.samples.frameworkfragment/builds/2012-02-01_13-16-50/archive/org.apache.sling/org.apache.sling.samples.frameworkfragment/0.9.9-SNAPSHOT/org.apache.sling.samples.frameworkfragment-0.9.9-SNAPSHOT.pom
[JENKINS] Archiving
https://builds.apache.org/job/sling-samples-1.5/ws/contrib-1.5/framework-fragment/target/org.apache.sling.samples.frameworkfragment-0.9.9-SNAPSHOT.jar
to
/home/hudson/hudson/jobs/sling-samples-1.5/modules/org.apache.sling$org.apache.sling.samples.frameworkfragment/builds/2012-02-01_13-16-50/archive/org.apache.sling/org.apache.sling.samples.frameworkfragment/0.9.9-SNAPSHOT/org.apache.sling.samples.frameworkfragment-0.9.9-SNAPSHOT.jar
[INFO] [enforcer:enforce {execution: enforce-java}]
[INFO] [source:jar {execution: attach-sources}]
[INFO] META-INF already added, skipping
[INFO] META-INF/LICENSE already added, skipping
[INFO] META-INF/NOTICE already added, skipping
[INFO] META-INF/DEPENDENCIES already added, skipping
[INFO] Building jar:
https://builds.apache.org/job/sling-samples-1.5/ws/contrib-1.5/framework-fragment/target/org.apache.sling.samples.frameworkfragment-0.9.9-SNAPSHOT-sources.jar
[INFO] META-INF already added, skipping
[INFO] META-INF/LICENSE already added, skipping
[INFO] META-INF/NOTICE already added, skipping
[INFO] META-INF/DEPENDENCIES already added, skipping
[INFO] [ianal:verify-legal-files {execution: default}]
[INFO] Checking legal files in:
org.apache.sling.samples.frameworkfragment-0.9.9-SNAPSHOT.jar
[INFO] Checking legal files in:
org.apache.sling.samples.frameworkfragment-0.9.9-SNAPSHOT-sources.jar
[INFO] [install:install {execution: default-install}]
[INFO] Installing
https://builds.apache.org/job/sling-samples-1.5/ws/contrib-1.5/framework-fragment/target/org.apache.sling.samples.frameworkfragment-0.9.9-SNAPSHOT.jar
to
/home/jenkins/.m2/repository/org/apache/sling/org.apache.sling.samples.frameworkfragment/0.9.9-SNAPSHOT/org.apache.sling.samples.frameworkfragment-0.9.9-SNAPSHOT.jar
[INFO] Installing
https://builds.apache.org/job/sling-samples-1.5/ws/contrib-1.5/framework-fragment/target/org.apache.sling.samples.frameworkfragment-0.9.9-SNAPSHOT-sources.jar
to
/home/jenkins/.m2/repository/org/apache/sling/org.apache.sling.samples.frameworkfragment/0.9.9-SNAPSHOT/org.apache.sling.samples.frameworkfragment-0.9.9-SNAPSHOT-sources.jar
[JENKINS] Archiving
https://builds.apache.org/job/sling-samples-1.5/ws/contrib-1.5/framework-fragment/target/org.apache.sling.samples.frameworkfragment-0.9.9-SNAPSHOT-sources.jar
to
/home/hudson/hudson/jobs/sling-samples-1.5/modules/org.apache.sling$org.apache.sling.samples.frameworkfragment/builds/2012-02-01_13-16-50/archive/org.apache.sling/org.apache.sling.samples.frameworkfragment/0.9.9-SNAPSHOT/org.apache.sling.samples.frameworkfragment-0.9.9-SNAPSHOT-sources.jar
[INFO]
[INFO] Building Apache Sling User Manager UI sample
[INFO]task-segment: [clean, install]
[INFO]
[INFO] artifact net.alchim31.maven:yuicompressor-maven-plugin: checking for
updates from oss.sonatype.org
[INFO] [clean:clean {execution: default-clean}]
[INFO] Deleting
https://builds.apache.org/job/sling-samples-1.5/ws/contrib-1.5/usermanager-ui/target
[INFO] [enforcer:enforce {execution: enforce-java}]
[INFO] [remote-resources:process {execution: default}]
[INFO] [resources:resources {execution: default-resources}]
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 28 resources
[INFO] Copying 3 resources
[WARNING] DEPRECATED [tasks]: Use target instead
[INFO] [antrun:run {execution: default}]
[WARNING] Parameter tasks is deprecated, use target instead
[INFO] Executing tasks
main:
[echo] WARNING (SLING-443/SLING-1782)
**
[echo] On most platforms, you'll get OutOfMemoryErrors when building
unless you set
[echo] on 32bit platforms: MAVEN_OPTS=-Xmx256M -XX:MaxPermSize=256M, see
SLING-443
[echo] on 64bit platforms: MAVEN_OPTS=-Xmx512M -XX:MaxPermSize=512M, see
SLING-1782
[echo]
**
[INFO] Executed tasks
[INFO] [yuicompressor:compress {execution: default}]
[INFO] nothing to do,
https://builds.apache.org/job/sling-samples-1.5/ws/contrib-1.5/usermanager-ui/src/main/resources/js/usermanager/usermanager.min.js
is younger than original, use 'force' option or clean your target
[INFO] nothing to do,
Re: The beast that is JcrResourceResolverFactoryImpl
Hi, yes, this is an unfinished area - the ResourceResolverFactory should have no ties to JCR and just use ResourceProvider services. So the basic idea is to create a new module for the implementation of the ResourceResolverFactory which has all the functionality that is not deferred to resource providers. I think some time ago Felix was working on a prototype for this. Not sure what the status is. But that's definitely something we should do in Sling rather sooner than later. Regards Carsten 2012/2/1 Vidar Ramdal vidar.ram...@webstep.no: I am experimenting with using Sling in a non-JCR application, that is, I want to leverage Sling's templating support, OSGi goodies, resource resolution etc, without using JCR, but in this case, a regular relational database. I have created a ResourceProvider which turns DB data into resources, so far so good. But I'd like to avoid any JCR dependency whatsoever. The changes outlined in [1] did a lot to allow custom ResourceResolverFactories. Still, much basic functionality happens in JcrResourceResolverFactoryImpl that makes it hard to avoid, without reimplementing: . - Domain mappings (o.a.s.jcr.resource.internal.helper.MapEntries, MapEntry, Mapping) (JCR independant since SLING-1463 [2]) - Redirect resouces (o.a.s.jcr.resource.internal.helper.RedirectResource) - Resource iterator (o.a.s.jcr.resource.internal.helper.ResourceIterator) - Star Resource (o.a.s.jcr.resource.internal.helper.starresource.StarResource) - Resource provider resolution logic (o.a.s.jcr.resource.internal.helper.ResourceProviderEntry) - (maybe others) In fact, none of the classes listed above imports any packages from javax.jcr. So, if we accept that a non-JCR ResourceResolverFactory would have to implement these features, shouldn't they be available somewhere outside JcrResourceResolverFactoryImpl? I'm not sure what is the best approach - an AbstractResourceResolverFactory, or turning these features into separate components. Any thoughts? [1] https://cwiki.apache.org/SLING/add-resourceresolverfactory-service-interface.html [2] https://issues.apache.org/jira/browse/SLING-1463 -- Vidar S. Ramdal vidar.ram...@webstep.no Webstep AS - http://www.webstep.no Besøksadresse: Lilleakerveien 8, 0283 Oslo Postadresse: Postboks 272 Lilleaker, 0216 Oslo -- Carsten Ziegeler cziege...@apache.org
[jira] [Updated] (SLING-1974) Accept header issues in the Sling POST Servlet
[ https://issues.apache.org/jira/browse/SLING-1974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler updated SLING-1974: Fix Version/s: (was: Servlets Post 2.1.2) Servlets Post 2.1.4 Moved to next version Accept header issues in the Sling POST Servlet -- Key: SLING-1974 URL: https://issues.apache.org/jira/browse/SLING-1974 Project: Sling Issue Type: Bug Components: Servlets Affects Versions: Servlets Post 2.1.0 Reporter: Felix Meschberger Fix For: Servlets Post 2.1.4 Attachments: SLING-1974.patch As of SLING-1336 the Sling POST Servlet can interpret the Accept request header to select what response content type to render. Unfortunately that handling seems broken as for an Accept header like (as generated by FireFox with the JSONovich plugin installed) : Accept: text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8,application/json the JSON response might be selected but sometimes also text/html (we can observe both behaviours for different server platforms with our application). The Accept header should probably consider equivalent q values (as for text/html and application/json in the example) to solve the tie by selecting the first type list; thus text/html in this example. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
Build failed in Jenkins: sling-trunk-1.6 #1241
See https://builds.apache.org/job/sling-trunk-1.6/1241/changes Changes: [cziegeler] SLING-2376 : New Startup Features [cziegeler] SLING-2376 : New Startup Features [fmeschbe] SLING-2395 Fix default value for log file size in metatype descriptor -- [...truncated 631 lines...] There are no tests to run. Results : Tests run: 0, Failures: 0, Errors: 0, Skipped: 0 [JENKINS] Recording test results [INFO] [INFO] --- animal-sniffer-maven-plugin:1.7:check (default) @ org.apache.sling.launchpad.api --- [INFO] Checking unresolved references to org.codehaus.mojo.signature:java15:1.0 [INFO] [INFO] --- maven-bundle-plugin:2.0.1:bundle (default-bundle) @ org.apache.sling.launchpad.api --- [INFO] [INFO] --- maven-enforcer-plugin:1.0:enforce (enforce-java) @ org.apache.sling.launchpad.api --- [JENKINS] Archiving https://builds.apache.org/job/sling-trunk-1.6/ws/trunk/launchpad/api/pom.xml to /home/hudson/hudson/jobs/sling-trunk-1.6/modules/org.apache.sling$org.apache.sling.launchpad.api/builds/2012-02-01_17-13-27/archive/org.apache.sling/org.apache.sling.launchpad.api/1.1.1-SNAPSHOT/org.apache.sling.launchpad.api-1.1.1-SNAPSHOT.pom [JENKINS] Archiving https://builds.apache.org/job/sling-trunk-1.6/ws/trunk/launchpad/api/target/org.apache.sling.launchpad.api-1.1.1-SNAPSHOT.jar to /home/hudson/hudson/jobs/sling-trunk-1.6/modules/org.apache.sling$org.apache.sling.launchpad.api/builds/2012-02-01_17-13-27/archive/org.apache.sling/org.apache.sling.launchpad.api/1.1.1-SNAPSHOT/org.apache.sling.launchpad.api-1.1.1-SNAPSHOT.jar Feb 1, 2012 5:14:59 PM hudson.maven.ExecutedMojo init WARNING: Failed to getClass for org.apache.maven.plugin.source.SourceJarMojo [INFO] [INFO] --- maven-source-plugin:2.1.2:jar (attach-sources) @ org.apache.sling.launchpad.api --- [INFO] META-INF already added, skipping [INFO] META-INF/LICENSE already added, skipping [INFO] META-INF/NOTICE already added, skipping [INFO] META-INF/DEPENDENCIES already added, skipping [INFO] Building jar: https://builds.apache.org/job/sling-trunk-1.6/ws/trunk/launchpad/api/target/org.apache.sling.launchpad.api-1.1.1-SNAPSHOT-sources.jar [INFO] META-INF already added, skipping [INFO] META-INF/LICENSE already added, skipping [INFO] META-INF/NOTICE already added, skipping [INFO] META-INF/DEPENDENCIES already added, skipping [INFO] [INFO] --- ianal-maven-plugin:1.0-alpha-1:verify-legal-files (default) @ org.apache.sling.launchpad.api --- [INFO] Checking legal files in: org.apache.sling.launchpad.api-1.1.1-SNAPSHOT.jar [INFO] Checking legal files in: org.apache.sling.launchpad.api-1.1.1-SNAPSHOT-sources.jar [INFO] [INFO] Installing https://builds.apache.org/job/sling-trunk-1.6/ws/trunk/launchpad/api/target/org.apache.sling.launchpad.api-1.1.1-SNAPSHOT.jar to /home/jenkins/.m2/repository/org/apache/sling/org.apache.sling.launchpad.api/1.1.1-SNAPSHOT/org.apache.sling.launchpad.api-1.1.1-SNAPSHOT.jar [INFO] --- maven-install-plugin:2.3.1:install (default-install) @ org.apache.sling.launchpad.api --- [INFO] Installing https://builds.apache.org/job/sling-trunk-1.6/ws/trunk/launchpad/api/pom.xml to /home/jenkins/.m2/repository/org/apache/sling/org.apache.sling.launchpad.api/1.1.1-SNAPSHOT/org.apache.sling.launchpad.api-1.1.1-SNAPSHOT.pom [INFO] Installing https://builds.apache.org/job/sling-trunk-1.6/ws/trunk/launchpad/api/target/org.apache.sling.launchpad.api-1.1.1-SNAPSHOT-sources.jar to /home/jenkins/.m2/repository/org/apache/sling/org.apache.sling.launchpad.api/1.1.1-SNAPSHOT/org.apache.sling.launchpad.api-1.1.1-SNAPSHOT-sources.jar [INFO] [INFO] Local OBR update disabled (enable with -DobrRepository) [INFO] --- maven-bundle-plugin:2.0.1:install (default-install) @ org.apache.sling.launchpad.api --- [JENKINS] Archiving https://builds.apache.org/job/sling-trunk-1.6/ws/trunk/launchpad/api/target/org.apache.sling.launchpad.api-1.1.1-SNAPSHOT-sources.jar to /home/hudson/hudson/jobs/sling-trunk-1.6/modules/org.apache.sling$org.apache.sling.launchpad.api/builds/2012-02-01_17-13-27/archive/org.apache.sling/org.apache.sling.launchpad.api/1.1.1-SNAPSHOT/org.apache.sling.launchpad.api-1.1.1-SNAPSHOT-sources.jar [INFO] [INFO] [INFO] Building Apache Sling Launchpad Base 2.3.1-SNAPSHOT [INFO] [INFO] [INFO] Deleting https://builds.apache.org/job/sling-trunk-1.6/ws/trunk/launchpad/base/target [INFO] --- maven-clean-plugin:2.4.1:clean (default-clean) @ org.apache.sling.launchpad.base --- [INFO] [INFO] --- maven-enforcer-plugin:1.0:enforce (enforce-java) @ org.apache.sling.launchpad.base --- [INFO] [INFO] --- maven-dependency-plugin:2.2:copy-dependencies (copy-felix-httpservice-bridge) @ org.apache.sling.launchpad.base --- [INFO] Copying org.apache.felix.http.bridge-2.2.0.jar to
Build failed in Jenkins: sling-trunk-1.5 #1572
See https://builds.apache.org/job/sling-trunk-1.5/1572/changes Changes: [cziegeler] SLING-2376 : New Startup Features [cziegeler] SLING-2376 : New Startup Features -- [...truncated 766 lines...] [INFO] META-INF/NOTICE already added, skipping [INFO] META-INF/DEPENDENCIES already added, skipping [INFO] Building jar: https://builds.apache.org/job/sling-trunk-1.5/ws/trunk/launchpad/api/target/org.apache.sling.launchpad.api-1.1.1-SNAPSHOT-sources.jar [INFO] META-INF already added, skipping [INFO] META-INF/LICENSE already added, skipping [INFO] META-INF/NOTICE already added, skipping [INFO] META-INF/DEPENDENCIES already added, skipping [INFO] [INFO] --- ianal-maven-plugin:1.0-alpha-1:verify-legal-files (default) @ org.apache.sling.launchpad.api --- [INFO] Checking legal files in: org.apache.sling.launchpad.api-1.1.1-SNAPSHOT.jar [INFO] Checking legal files in: org.apache.sling.launchpad.api-1.1.1-SNAPSHOT-sources.jar [INFO] [INFO] Installing https://builds.apache.org/job/sling-trunk-1.5/ws/trunk/launchpad/api/target/org.apache.sling.launchpad.api-1.1.1-SNAPSHOT.jar to /home/jenkins/.m2/repository/org/apache/sling/org.apache.sling.launchpad.api/1.1.1-SNAPSHOT/org.apache.sling.launchpad.api-1.1.1-SNAPSHOT.jar [INFO] Installing https://builds.apache.org/job/sling-trunk-1.5/ws/trunk/launchpad/api/pom.xml to /home/jenkins/.m2/repository/org/apache/sling/org.apache.sling.launchpad.api/1.1.1-SNAPSHOT/org.apache.sling.launchpad.api-1.1.1-SNAPSHOT.pom [INFO] Installing https://builds.apache.org/job/sling-trunk-1.5/ws/trunk/launchpad/api/target/org.apache.sling.launchpad.api-1.1.1-SNAPSHOT-sources.jar to /home/jenkins/.m2/repository/org/apache/sling/org.apache.sling.launchpad.api/1.1.1-SNAPSHOT/org.apache.sling.launchpad.api-1.1.1-SNAPSHOT-sources.jar [INFO] --- maven-install-plugin:2.3.1:install (default-install) @ org.apache.sling.launchpad.api --- [INFO] [INFO] Local OBR update disabled (enable with -DobrRepository) [INFO] --- maven-bundle-plugin:2.0.1:install (default-install) @ org.apache.sling.launchpad.api --- [INFO] Downloading: https://repository.apache.org/content/repositories/snapshots/org/apache/sling/org.apache.sling.launchpad.api/1.1.1-SNAPSHOT/maven-metadata.xml [INFO] --- maven-deploy-plugin:2.5:deploy (default-deploy) @ org.apache.sling.launchpad.api --- Downloaded: https://repository.apache.org/content/repositories/snapshots/org/apache/sling/org.apache.sling.launchpad.api/1.1.1-SNAPSHOT/maven-metadata.xml (1010 B at 2.3 KB/sec) Uploading: https://repository.apache.org/content/repositories/snapshots/org/apache/sling/org.apache.sling.launchpad.api/1.1.1-SNAPSHOT/org.apache.sling.launchpad.api-1.1.1-20120201.173041-5.jar Uploaded: https://repository.apache.org/content/repositories/snapshots/org/apache/sling/org.apache.sling.launchpad.api/1.1.1-SNAPSHOT/org.apache.sling.launchpad.api-1.1.1-20120201.173041-5.jar (10 KB at 40.8 KB/sec) Uploading: https://repository.apache.org/content/repositories/snapshots/org/apache/sling/org.apache.sling.launchpad.api/1.1.1-SNAPSHOT/org.apache.sling.launchpad.api-1.1.1-20120201.173041-5.pom Uploaded: https://repository.apache.org/content/repositories/snapshots/org/apache/sling/org.apache.sling.launchpad.api/1.1.1-SNAPSHOT/org.apache.sling.launchpad.api-1.1.1-20120201.173041-5.pom (3 KB at 12.8 KB/sec) Downloading: https://repository.apache.org/content/repositories/snapshots/org/apache/sling/org.apache.sling.launchpad.api/maven-metadata.xml Downloaded: https://repository.apache.org/content/repositories/snapshots/org/apache/sling/org.apache.sling.launchpad.api/maven-metadata.xml (386 B at 2.0 KB/sec) Uploading: https://repository.apache.org/content/repositories/snapshots/org/apache/sling/org.apache.sling.launchpad.api/1.1.1-SNAPSHOT/maven-metadata.xml Uploaded: https://repository.apache.org/content/repositories/snapshots/org/apache/sling/org.apache.sling.launchpad.api/1.1.1-SNAPSHOT/maven-metadata.xml (1010 B at 4.9 KB/sec) Uploading: https://repository.apache.org/content/repositories/snapshots/org/apache/sling/org.apache.sling.launchpad.api/maven-metadata.xml Uploaded: https://repository.apache.org/content/repositories/snapshots/org/apache/sling/org.apache.sling.launchpad.api/maven-metadata.xml (386 B at 1.1 KB/sec) Uploading: https://repository.apache.org/content/repositories/snapshots/org/apache/sling/org.apache.sling.launchpad.api/1.1.1-SNAPSHOT/org.apache.sling.launchpad.api-1.1.1-20120201.173041-5-sources.jar Uploaded: https://repository.apache.org/content/repositories/snapshots/org/apache/sling/org.apache.sling.launchpad.api/1.1.1-SNAPSHOT/org.apache.sling.launchpad.api-1.1.1-20120201.173041-5-sources.jar (9 KB at 40.8 KB/sec) Uploading: https://repository.apache.org/content/repositories/snapshots/org/apache/sling/org.apache.sling.launchpad.api/1.1.1-SNAPSHOT/maven-metadata.xml Uploaded:
Re: The beast that is JcrResourceResolverFactoryImpl
2012/2/1 Vidar Ramdal vidar.ram...@webstep.no: I am experimenting with using Sling in a non-JCR application, that is, I want to leverage Sling's templating support, OSGi goodies, resource resolution etc, without using JCR, but in this case, a regular relational database. I have created a ResourceProvider which turns DB data into resources, so far so good. But I'd like to avoid any JCR dependency whatsoever. The changes outlined in [1] did a lot to allow custom ResourceResolverFactories. Still, much basic functionality happens in JcrResourceResolverFactoryImpl that makes it hard to avoid, without reimplementing: . - Domain mappings (o.a.s.jcr.resource.internal.helper.MapEntries, MapEntry, Mapping) (JCR independant since SLING-1463 [2]) - Redirect resouces (o.a.s.jcr.resource.internal.helper.RedirectResource) - Resource iterator (o.a.s.jcr.resource.internal.helper.ResourceIterator) - Star Resource (o.a.s.jcr.resource.internal.helper.starresource.StarResource) - Resource provider resolution logic (o.a.s.jcr.resource.internal.helper.ResourceProviderEntry) - (maybe others) In fact, none of the classes listed above imports any packages from javax.jcr. So, if we accept that a non-JCR ResourceResolverFactory would have to implement these features, shouldn't they be available somewhere outside JcrResourceResolverFactoryImpl? I'm not sure what is the best approach - an AbstractResourceResolverFactory, or turning these features into separate components. Any thoughts? [1] https://cwiki.apache.org/SLING/add-resourceresolverfactory-service-interface.html [2] https://issues.apache.org/jira/browse/SLING-1463 2012/2/1 Carsten Ziegeler cziege...@apache.org: yes, this is an unfinished area - the ResourceResolverFactory should have no ties to JCR and just use ResourceProvider services. Great, that's what I thought. So the basic idea is to create a new module for the implementation of the ResourceResolverFactory which has all the functionality that is not deferred to resource providers. By all the functionality that is not deferred to resource providers, do you mean for instance those bullets I posted above (domain mappings etc)? I think some time ago Felix was working on a prototype for this. Not sure what the status is. But that's definitely something we should do in Sling rather sooner than later. I'd be interested in seeing this come to Sling, and could start do to some work on it - at least slowly, piece by piece. If we could find any references to Felix' prototype, I could start from there. -- Vidar S. Ramdal vidar.ram...@webstep.no Webstep AS - http://www.webstep.no Besøksadresse: Lilleakerveien 8, 0283 Oslo Postadresse: Postboks 272 Lilleaker, 0216 Oslo
