Build failed in Jenkins: sling-trunk-1.6 #1408

[Apache Jenkins Server]

See 

Changes:

[justin] SLING-2559 - avoiding the setValue() call by queueing updates to the 
handler map and then using putAll()

--
[...truncated 1498 lines...]
mojoSucceeded 
org.apache.maven.plugins:maven-remote-resources-plugin:1.1(default)
mojoStarted 
org.apache.maven.plugins:maven-resources-plugin:2.4.3(default-resources)
[INFO] 
[INFO] --- maven-resources-plugin:2.4.3:resources (default-resources) @ 
sling-bundle-archetype ---
mojoSucceeded 
org.apache.maven.plugins:maven-resources-plugin:2.4.3(default-resources)
mojoStarted org.apache.maven.plugins:maven-antrun-plugin:1.6(default)
[INFO] 
[INFO] --- maven-antrun-plugin:1.6:run (default) @ sling-bundle-archetype ---
mojoSucceeded org.apache.maven.plugins:maven-antrun-plugin:1.6(default)
mojoStarted 
org.apache.maven.plugins:maven-resources-plugin:2.4.3(default-testResources)
[INFO] 
[INFO] --- maven-resources-plugin:2.4.3:testResources (default-testResources) @ 
sling-bundle-archetype ---
mojoSucceeded 
org.apache.maven.plugins:maven-resources-plugin:2.4.3(default-testResources)
mojoStarted org.codehaus.mojo:animal-sniffer-maven-plugin:1.7(default)
[INFO] 
[INFO] --- animal-sniffer-maven-plugin:1.7:check (default) @ 
sling-bundle-archetype ---
mojoSucceeded org.codehaus.mojo:animal-sniffer-maven-plugin:1.7(default)
[INFO] Deleting 

mojoStarted 
org.apache.maven.plugins:maven-archetype-plugin:2.0-alpha-4(default-jar)
[INFO] 
[INFO] --- maven-archetype-plugin:2.0-alpha-4:jar (default-jar) @ 
sling-bundle-archetype ---
mojoSucceeded 
org.apache.maven.plugins:maven-archetype-plugin:2.0-alpha-4(default-jar)
mojoStarted 
org.apache.maven.plugins:maven-archetype-plugin:2.0-alpha-4(default-add-archetype-metadata)
[INFO] 
[INFO] --- maven-archetype-plugin:2.0-alpha-4:add-archetype-metadata 
(default-add-archetype-metadata) @ sling-bundle-archetype ---
mojoSucceeded 
org.apache.maven.plugins:maven-archetype-plugin:2.0-alpha-4(default-add-archetype-metadata)
forkedProjectStarted org.apache.sling:sling-bundle-archetype:1.0.1-SNAPSHOT
mojoStarted org.apache.maven.plugins:maven-enforcer-plugin:1.0(enforce-java)
[INFO] 
[INFO] --- maven-enforcer-plugin:1.0:enforce (enforce-java) @ 
sling-bundle-archetype ---
mojoSucceeded org.apache.maven.plugins:maven-enforcer-plugin:1.0(enforce-java)
forkedProjectSucceeded org.apache.sling:sling-bundle-archetype:1.0.1-SNAPSHOT
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 4 resources
[INFO] Copying 3 resources
mojoStarted org.apache.maven.plugins:maven-source-plugin:2.1.2(attach-sources)
[INFO] 
[INFO] --- maven-source-plugin:2.1.2:jar (attach-sources) @ 
sling-bundle-archetype ---
mojoSucceeded org.apache.maven.plugins:maven-source-plugin:2.1.2(attach-sources)
[INFO] Executing tasks

main:
 [echo]  WARNING (SLING-443/SLING-1782) 
**
 [echo] On most platforms, you'll get OutOfMemoryErrors when building 
unless you set
 [echo] on 32bit platforms: MAVEN_OPTS="-Xmx256M -XX:MaxPermSize=256M", see 
SLING-443
 [echo] on 64bit platforms: MAVEN_OPTS="-Xmx512M -XX:MaxPermSize=512M", see 
SLING-1782
 [echo] 
**
[INFO] Executed tasks
mojoStarted 
org.apache.maven.plugins:maven-archetype-plugin:2.0-alpha-4(default-integration-test)
[INFO] 
[INFO] --- maven-archetype-plugin:2.0-alpha-4:integration-test 
(default-integration-test) @ sling-bundle-archetype ---
mojoSucceeded 
org.apache.maven.plugins:maven-archetype-plugin:2.0-alpha-4(default-integration-test)
mojoStarted org.codehaus.mojo:ianal-maven-plugin:1.0-alpha-1(default)
[INFO] 
[INFO] --- ianal-maven-plugin:1.0-alpha-1:verify-legal-files (default) @ 
sling-bundle-archetype ---
mojoSucceeded org.codehaus.mojo:ianal-maven-plugin:1.0-alpha-1(default)
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
mojoStarted org.apache.maven.plugins:maven-install-plugin:2.3.1(default-install)
[INFO] 
[INFO] --- maven-install-plugin:2.3.1:install (default-install) @ 
sling-bundle-archetype ---
mojoSucceeded 
org.apache.maven.plugins:maven-install-plugin:2.3.1(default-install)
[INFO] Checking unresolved references to org.codehaus.mojo.signature:java15:1.0
mojoStarted 
org.apache.maven.plugins:maven-archetype-plugin:2.0-alpha-4(default-update-local-catalog)
[INFO] 
[INFO] --- maven-archetype-plugin:2.0-alpha-4:update-local-catalog 
(default-update-local-catalog) @ sling-bundle-archetype ---
mojoSucceeded 
org.apache.maven.plugins:maven-archetype-plugin:2.0-alpha-4(default-update-local-catalog)
projectSucceeded org.apache.sling:sling-bundle-archetype:1.0.1-SNAPSHOT
Aug 13, 2012 9

Build failed in Jenkins: sling-trunk-1.5 #1746

[Apache Jenkins Server]

See 

Changes:

[justin] SLING-2559 - avoiding the setValue() call by queueing updates to the 
handler map and then using putAll()

--
[...truncated 3650 lines...]
[INFO] 
[INFO] --- maven-enforcer-plugin:1.0:enforce (enforce-java) @ 
org.apache.sling.commons.log ---
mojoSucceeded org.apache.maven.plugins:maven-enforcer-plugin:1.0(enforce-java)
mojoStarted org.apache.maven.plugins:maven-remote-resources-plugin:1.1(default)
[INFO] 
[INFO] --- maven-remote-resources-plugin:1.1:process (default) @ 
org.apache.sling.commons.log ---
[INFO] Setting property: classpath.resource.loader.class => 
'org.codehaus.plexus.velocity.ContextClassLoaderResourceLoader'.
[INFO] Setting property: velocimacro.messages.on => 'false'.
[INFO] Setting property: resource.loader => 'classpath'.
[INFO] Setting property: resource.manager.logwhenfound => 'false'.
mojoSucceeded 
org.apache.maven.plugins:maven-remote-resources-plugin:1.1(default)
mojoStarted 
org.apache.maven.plugins:maven-resources-plugin:2.4.3(default-resources)
[INFO] 
[INFO] --- maven-resources-plugin:2.4.3:resources (default-resources) @ 
org.apache.sling.commons.log ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 2 resources
[INFO] Copying 3 resources
mojoSucceeded 
org.apache.maven.plugins:maven-resources-plugin:2.4.3(default-resources)
mojoStarted org.apache.maven.plugins:maven-antrun-plugin:1.6(default)
[INFO] 
[INFO] --- maven-antrun-plugin:1.6:run (default) @ org.apache.sling.commons.log 
---
[INFO] Executing tasks

main:
 [echo]  WARNING (SLING-443/SLING-1782) 
**
 [echo] On most platforms, you'll get OutOfMemoryErrors when building 
unless you set
 [echo] on 32bit platforms: MAVEN_OPTS="-Xmx256M -XX:MaxPermSize=256M", see 
SLING-443
 [echo] on 64bit platforms: MAVEN_OPTS="-Xmx512M -XX:MaxPermSize=512M", see 
SLING-1782
mojoSucceeded org.apache.maven.plugins:maven-antrun-plugin:1.6(default) 
[echo] 
**
[INFO] Executed tasks

mojoStarted 
org.apache.maven.plugins:maven-compiler-plugin:2.5.1(default-compile)
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:compile (default-compile) @ 
org.apache.sling.commons.log ---
[INFO] Compiling 21 source files to 

mojoSucceeded 
org.apache.maven.plugins:maven-compiler-plugin:2.5.1(default-compile)
mojoStarted 
org.apache.maven.plugins:maven-resources-plugin:2.4.3(default-testResources)[INFO]
 Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources

[INFO] 
[INFO] --- maven-resources-plugin:2.4.3:testResources (default-testResources) @ 
org.apache.sling.commons.log ---
mojoSucceeded 
org.apache.maven.plugins:maven-resources-plugin:2.4.3(default-testResources)
mojoStarted 
org.apache.maven.plugins:maven-compiler-plugin:2.5.1(default-testCompile)
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile) @ 
org.apache.sling.commons.log ---
[INFO] Compiling 4 source files to 

mojoSucceeded 
org.apache.maven.plugins:maven-compiler-plugin:2.5.1(default-testCompile)
mojoStarted org.apache.maven.plugins:maven-surefire-plugin:2.7.2(default-test)
[INFO] 
[INFO] --- maven-surefire-plugin:2.7.2:test (default-test) @ 
org.apache.sling.commons.log ---
[INFO] Surefire report directory: 


---
 T E S T S
---
Running org.apache.sling.commons.log.internal.slf4j.SizeLimitedFileRotatorTest
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.032 sec
Running org.apache.sling.commons.log.internal.slf4j.SlingLoggerTest
Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.013 sec
Running org.apache.sling.commons.log.internal.slf4j.SlingLogWriterTest
Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.027 sec

Results :

Tests run: 17, Failures: 0, Errors: 0, Skipped: 0

mojoSucceeded org.apache.maven.plugins:maven-surefire-plugin:2.7.2(default-test)
[JENKINS] Recording test results
mojoStarted org.codehaus.mojo:animal-sniffer-maven-plugin:1.7(default)
[INFO] 
[INFO] --- animal-sniffer-maven-plugin:1.7:check (default) @ 
org.apache.sling.commons.log ---
[INFO] Checking unresolved references to org.codehaus.mojo.signature:java15:1.0
mojoSucceeded org.codehaus.mojo:animal-sniffer-maven-plugin:1.7(default)
mojoStarted org.apache.felix:maven-bundle-plugin:2.3.6(default-bundle)
[INFO] 

Build failed in Jenkins: sling-trunk-1.6 #1407

[Apache Jenkins Server]

See 

Changes:

[cziegeler] SLING-2484 : Sling parent should map various plugin executions to 
ignore. Apply patch from Robert Munteanu

[cziegeler] Use latest snapshot version

[cziegeler] SLING-2558 : Potential Deadlocks may be caused by AdapterManager

[cziegeler] Use latest release

[cziegeler] [maven-release-plugin] prepare for next development iteration

[cziegeler] [maven-release-plugin] prepare release 
org.apache.sling.scripting.jst-2.0.6

[cziegeler] SLING-2545 : Scripting jst is using wrong import package directives

[cziegeler] SLING-2545 : Scripting jst is using wrong import package directives

[cziegeler] SLING-2545 : Scripting jst is using wrong import package directives

--
[...truncated 1085 lines...]
[INFO] META-INF/DEPENDENCIES already added, skipping
[INFO] Building jar: 

[INFO] META-INF already added, skipping
[INFO] META-INF already added, skipping
[INFO] META-INF/LICENSE already added, skipping
[INFO] META-INF/NOTICE already added, skipping
[INFO] META-INF/DEPENDENCIES already added, skipping
[INFO] Checking legal files in: 
sling-launchpad-standalone-archetype-1.0.1-SNAPSHOT.jar
[INFO] Checking legal files in: 
sling-launchpad-standalone-archetype-1.0.1-SNAPSHOT-sources.jar
[INFO] Installing 

 to 
/home/jenkins/jenkins-slave/maven-repositories/1/org/apache/sling/sling-launchpad-standalone-archetype/1.0.1-SNAPSHOT/sling-launchpad-standalone-archetype-1.0.1-SNAPSHOT.jar
[INFO] Installing 

 to 
/home/jenkins/jenkins-slave/maven-repositories/1/org/apache/sling/sling-launchpad-standalone-archetype/1.0.1-SNAPSHOT/sling-launchpad-standalone-archetype-1.0.1-SNAPSHOT.pom
[INFO] Installing 

 to 
/home/jenkins/jenkins-slave/maven-repositories/1/org/apache/sling/sling-launchpad-standalone-archetype/1.0.1-SNAPSHOT/sling-launchpad-standalone-archetype-1.0.1-SNAPSHOT-sources.jar
projectStarted org.apache.sling:sling-launchpad-webapp-archetype:1.0.1-SNAPSHOT
[INFO] 
[INFO] 
[INFO] Building Sling Launchpad Webapp Archetype 1.0.1-SNAPSHOT
[INFO] 
mojoStarted org.apache.maven.plugins:maven-clean-plugin:2.4.1(default-clean)
[INFO] 
[INFO] --- maven-clean-plugin:2.4.1:clean (default-clean) @ 
sling-launchpad-webapp-archetype ---
mojoSucceeded org.apache.maven.plugins:maven-clean-plugin:2.4.1(default-clean)
mojoStarted org.apache.maven.plugins:maven-enforcer-plugin:1.0(enforce-java)
[INFO] 
[INFO] --- maven-enforcer-plugin:1.0:enforce (enforce-java) @ 
sling-launchpad-webapp-archetype ---
mojoSucceeded org.apache.maven.plugins:maven-enforcer-plugin:1.0(enforce-java)
mojoStarted org.apache.maven.plugins:maven-remote-resources-plugin:1.1(default)
[INFO] 
[INFO] --- maven-remote-resources-plugin:1.1:process (default) @ 
sling-launchpad-webapp-archetype ---
mojoSucceeded 
org.apache.maven.plugins:maven-remote-resources-plugin:1.1(default)
mojoStarted 
org.apache.maven.plugins:maven-resources-plugin:2.4.3(default-resources)
[INFO] 
[INFO] --- maven-resources-plugin:2.4.3:resources (default-resources) @ 
sling-launchpad-webapp-archetype ---
mojoSucceeded 
org.apache.maven.plugins:maven-resources-plugin:2.4.3(default-resources)
mojoStarted org.apache.maven.plugins:maven-antrun-plugin:1.6(default)
[INFO] 
[INFO] --- maven-antrun-plugin:1.6:run (default) @ 
sling-launchpad-webapp-archetype ---
mojoSucceeded org.apache.maven.plugins:maven-antrun-plugin:1.6(default)
mojoStarted 
org.apache.maven.plugins:maven-resources-plugin:2.4.3(default-testResources)
[INFO] 
[INFO] --- maven-resources-plugin:2.4.3:testResources (default-testResources) @ 
sling-launchpad-webapp-archetype ---
mojoSucceeded 
org.apache.maven.plugins:maven-resources-plugin:2.4.3(default-testResources)
mojoStarted org.codehaus.mojo:animal-sniffer-maven-plugin:1.7(default)
[INFO] 
[INFO] --- animal-sniffer-maven-plugin:1.7:check (default) @ 
sling-launchpad-webapp-archetype ---
mojoSucceeded org.codehaus.mojo:animal-sniffer-maven-plugin:1.7(default)
[INFO] Deleting 

mojoStarted 
org.apache.maven.plugins:maven-archetype-plugin:2.0-alpha-4(default-jar)
[INFO] 
[INF

[jira] [Resolved] (SLING-2559) SlingHandlerManager uses setValue() on entries retrieved from a java.util.TreeMap

[Justin Edelson (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-2559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Justin Edelson resolved SLING-2559.
---

   Resolution: Fixed
Fix Version/s: JCR Webdav 2.1.2

fixed in r1372539

> SlingHandlerManager uses setValue() on entries retrieved from a 
> java.util.TreeMap
> -
>
> Key: SLING-2559
> URL: https://issues.apache.org/jira/browse/SLING-2559
> Project: Sling
>  Issue Type: Bug
>  Components: JCR
>Affects Versions: JCR Webdav 2.1.0
>Reporter: Justin Edelson
>Assignee: Justin Edelson
> Fix For: JCR Webdav 2.1.2
>
>
> Line 67 of org.apache.sling.jcr.webdav.impl.handler.SlingHandlerManager calls 
> setValue() on a java.util.Map.Entry object retrieved from a TreeMap 
> (indirectly through the entries collection). This is not allowed per the 
> JavaDoc:
> http://docs.oracle.com/javase/6/docs/api/java/util/TreeMap.html
> "All Map.Entry pairs returned by methods in this class and its views 
> represent snapshots of mappings at the time they were produced. They do not 
> support the Entry.setValue method. (Note however that it is possible to 
> change mappings in the associated map using put.)"

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Assigned] (SLING-2559) SlingHandlerManager uses setValue() on entries retrieved from a java.util.TreeMap

[Justin Edelson (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-2559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Justin Edelson reassigned SLING-2559:
-

Assignee: Justin Edelson

> SlingHandlerManager uses setValue() on entries retrieved from a 
> java.util.TreeMap
> -
>
> Key: SLING-2559
> URL: https://issues.apache.org/jira/browse/SLING-2559
> Project: Sling
>  Issue Type: Bug
>  Components: JCR
>Affects Versions: JCR Webdav 2.1.0
>Reporter: Justin Edelson
>Assignee: Justin Edelson
>
> Line 67 of org.apache.sling.jcr.webdav.impl.handler.SlingHandlerManager calls 
> setValue() on a java.util.Map.Entry object retrieved from a TreeMap 
> (indirectly through the entries collection). This is not allowed per the 
> JavaDoc:
> http://docs.oracle.com/javase/6/docs/api/java/util/TreeMap.html
> "All Map.Entry pairs returned by methods in this class and its views 
> represent snapshots of mappings at the time they were produced. They do not 
> support the Entry.setValue method. (Note however that it is possible to 
> change mappings in the associated map using put.)"

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

Jenkins build is still unstable: sling-trunk-1.5 #1745

[Apache Jenkins Server]

See 

Jenkins build is still unstable: sling-trunk-1.5 » Apache Sling Launchpad Testing #1745

[Apache Jenkins Server]

See 

Jenkins build is still unstable: sling-trunk-1.5 » Apache Sling Launchpad Testing WAR version #1745

[Apache Jenkins Server]

See 

Jenkins build is unstable: sling-trunk-1.5 #1744

[Apache Jenkins Server]

See 

[jira] [Resolved] (SLING-2484) Sling parent should map various plugin executions to ignore

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-2484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-2484.
-

   Resolution: Fixed
Fix Version/s: Parent 14

Thanks for your patch, Robert - it's applied

> Sling parent should map various plugin executions to ignore
> ---
>
> Key: SLING-2484
> URL: https://issues.apache.org/jira/browse/SLING-2484
> Project: Sling
>  Issue Type: Task
>  Components: General
>Affects Versions: Parent 13
>Reporter: Robert Munteanu
>Assignee: Carsten Ziegeler
>Priority: Minor
> Fix For: Parent 14
>
> Attachments: m2eclipse-ignore-executions.diff, 
> m2e-ignore-executions-3.diff
>
>
> Following the discussion on sling-dev [0] I suggest that the following plugin 
> executions should be mapped to ignore in Eclipse, rather than execute:
> * maven-dependency-plugin:unpack/copy-dependencies
> * maven-antrun-plugin:run
> * maven-scr-plugin:scr
> [0]: http://mail-archives.apache.org/mod_mbox/sling-dev/201205.mbox/browser

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Created] (SLING-2559) SlingHandlerManager uses setValue() on entries retrieved from a java.util.TreeMap

[Justin Edelson (JIRA)]

Justin Edelson created SLING-2559:
-

 Summary: SlingHandlerManager uses setValue() on entries retrieved 
from a java.util.TreeMap
 Key: SLING-2559
 URL: https://issues.apache.org/jira/browse/SLING-2559
 Project: Sling
  Issue Type: Bug
  Components: JCR
Affects Versions: JCR Webdav 2.1.0
Reporter: Justin Edelson


Line 67 of org.apache.sling.jcr.webdav.impl.handler.SlingHandlerManager calls 
setValue() on a java.util.Map.Entry object retrieved from a TreeMap (indirectly 
through the entries collection). This is not allowed per the JavaDoc:

http://docs.oracle.com/javase/6/docs/api/java/util/TreeMap.html

"All Map.Entry pairs returned by methods in this class and its views represent 
snapshots of mappings at the time they were produced. They do not support the 
Entry.setValue method. (Note however that it is possible to change mappings in 
the associated map using put.)"

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

Build failed in Jenkins: sling-trunk-1.5 #1743

[Apache Jenkins Server]

See 

Changes:

[cziegeler] SLING-2558 : Potential Deadlocks may be caused by AdapterManager

--
[...truncated 434 lines...]
[INFO] --- maven-remote-resources-plugin:1.1:process (default) @ 
maven-jcrocm-plugin ---
mojoSucceeded 
org.apache.maven.plugins:maven-remote-resources-plugin:1.1(default)
mojoStarted 
org.apache.maven.plugins:maven-resources-plugin:2.4.3(default-resources)[INFO] 
Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 0 resource
[INFO] Copying 3 resources

[INFO] 
[INFO] --- maven-resources-plugin:2.4.3:resources (default-resources) @ 
maven-jcrocm-plugin ---
mojoSucceeded 
org.apache.maven.plugins:maven-resources-plugin:2.4.3(default-resources)
mojoStarted org.apache.maven.plugins:maven-antrun-plugin:1.6(default)
[INFO] 
[INFO] --- maven-antrun-plugin:1.6:run (default) @ maven-jcrocm-plugin ---
[INFO] Executing tasks

main:
 [echo]  WARNING (SLING-443/SLING-1782) 
**
 [echo] On most platforms, you'll get OutOfMemoryErrors when building 
unless you set
 [echo] on 32bit platforms: MAVEN_OPTS="-Xmx256M -XX:MaxPermSize=256M", see 
SLING-443
 [echo] on 64bit platforms: MAVEN_OPTS="-Xmx512M -XX:MaxPermSize=512M", see 
SLING-1782
 [echo] 
**
[INFO] Executed tasks
mojoSucceeded org.apache.maven.plugins:maven-antrun-plugin:1.6(default)
mojoStarted 
org.apache.maven.plugins:maven-compiler-plugin:2.5.1(default-compile)[INFO] 
Compiling 9 source files to 


[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:compile (default-compile) @ 
maven-jcrocm-plugin ---
mojoSucceeded 
org.apache.maven.plugins:maven-compiler-plugin:2.5.1(default-compile)
mojoStarted 
org.apache.maven.plugins:maven-resources-plugin:2.4.3(default-testResources)[INFO]
 Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources

[INFO] 
[INFO] --- maven-resources-plugin:2.4.3:testResources (default-testResources) @ 
maven-jcrocm-plugin ---
mojoSucceeded 
org.apache.maven.plugins:maven-resources-plugin:2.4.3(default-testResources)
mojoStarted 
org.apache.maven.plugins:maven-compiler-plugin:2.5.1(default-testCompile)[INFO] 
No sources to compile

[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile) @ 
maven-jcrocm-plugin ---
mojoSucceeded 
org.apache.maven.plugins:maven-compiler-plugin:2.5.1(default-testCompile)
mojoStarted 
org.apache.maven.plugins:maven-surefire-plugin:2.7.2(default-test)[INFO] 
Surefire report directory: 


[INFO] 
[INFO] --- maven-surefire-plugin:2.7.2:test (default-test) @ 
maven-jcrocm-plugin ---

---
 T E S T S
---
There are no tests to run.

Results :

Tests run: 0, Failures: 0, Errors: 0, Skipped: 0

mojoSucceeded org.apache.maven.plugins:maven-surefire-plugin:2.7.2(default-test)
[JENKINS] Recording test results[INFO] Checking unresolved references to 
org.codehaus.mojo.signature:java15:1.0

mojoStarted org.codehaus.mojo:animal-sniffer-maven-plugin:1.7(default)
[INFO] 
[INFO] --- animal-sniffer-maven-plugin:1.7:check (default) @ 
maven-jcrocm-plugin ---
mojoSucceeded org.codehaus.mojo:animal-sniffer-maven-plugin:1.7(default)
mojoStarted org.apache.maven.plugins:maven-jar-plugin:2.3.1(default-jar)
[INFO] 
[INFO] --- maven-jar-plugin:2.3.1:jar (default-jar) @ maven-jcrocm-plugin ---
[INFO] Building jar: 

mojoSucceeded org.apache.maven.plugins:maven-jar-plugin:2.3.1(default-jar)
mojoStarted 
org.apache.maven.plugins:maven-plugin-plugin:2.7(default-addPluginArtifactMetadata)
[INFO] 
[INFO] --- maven-plugin-plugin:2.7:addPluginArtifactMetadata 
(default-addPluginArtifactMetadata) @ maven-jcrocm-plugin ---
mojoSucceeded 
org.apache.maven.plugins:maven-plugin-plugin:2.7(default-addPluginArtifactMetadata)
forkedProjectStarted org.apache.sling:maven-jcrocm-plugin:2.0.5-SNAPSHOT
mojoStarted org.apache.maven.plugins:maven-enforcer-plugin:1.0(enforce-java)
[INFO] 
[INFO] --- maven-enforcer-plugin:1.0:enforce (enforce-java) @ 
maven-jcrocm-plugin ---
mojoSucceeded org.apache.maven.plugins:maven-enforcer-plugin:1.0(enforce-java)
forkedProjectSucceeded org.apache.sling:maven-jcrocm-plugin:2.0.5-SNAPSHOTAug 
13, 2012 2:05:19 PM hudson.maven.ExecutedMojo 
WARNING: Failed to getClass for org.apache.maven.plugin.source.SourceJarMojo

mojoStarted org.apache.maven

[jira] [Commented] (SLING-2558) Potential Deadlocks may be caused by AdapterManager

[Carsten Ziegeler (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-2558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13433130#comment-13433130
 ] 

Carsten Ziegeler commented on SLING-2558:
-

Committed first version which uses a concurrent hash map for the cache, I've 
reduced the syncs on the factories (which I renamed to descriptions) to the 
bare minimum
Removed the sync in the AdapterFactoryDescriptor

In addition, factories are now really fetched lazy when they are first used

> Potential Deadlocks may be caused by AdapterManager
> ---
>
> Key: SLING-2558
> URL: https://issues.apache.org/jira/browse/SLING-2558
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: Adapter 2.0.16
>Reporter: Felix Meschberger
>Assignee: Carsten Ziegeler
> Fix For: Adapter 2.0.18
>
>
> The AdapterManager uses a cascade of three synchronized blocks when the 
> AdapterFactoryDescriptor.getFactory() method is called:
>   * synchronized(cache)
>   * synchronized(factories)
>   * synchronized(this)
> A potential deadlock may happen because the 
> AdapterFactoryDescriptor.getFactory() method asks the Declarative Services 
> runtime for a service, which may cause a ServiceFactory service to be 
> instantiated (with a whole cascade of potential secondary actions depending 
> on what happens on this instantiation).
> The last block can probably simply be removed while the others definitely 
> have to be refactored to not be the cause or participants in deadlock 
> situations. The reason for this is, that (a) synchronized blocks must not be 
> too large and (b) no Java locks should be held when calling into the OSGi 
> Framework, which happens in the AdapterFactoryDescriptor.getFactory method.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

Build failed in Jenkins: sling-trunk-1.5 #1742

[Apache Jenkins Server]

See 

Changes:

[cziegeler] Use latest release

--
[...truncated 5326 lines...]
[INFO] 
mojoStarted 
org.apache.maven.plugins:maven-clean-plugin:2.4.1(default-clean)[INFO] Deleting 


[INFO] 
[INFO] --- maven-clean-plugin:2.4.1:clean (default-clean) @ 
org.apache.sling.auth.openid ---
mojoSucceeded org.apache.maven.plugins:maven-clean-plugin:2.4.1(default-clean)
mojoStarted org.apache.maven.plugins:maven-enforcer-plugin:1.0(enforce-java)
[INFO] 
[INFO] --- maven-enforcer-plugin:1.0:enforce (enforce-java) @ 
org.apache.sling.auth.openid ---
mojoSucceeded org.apache.maven.plugins:maven-enforcer-plugin:1.0(enforce-java)
mojoStarted org.apache.maven.plugins:maven-remote-resources-plugin:1.1(default)
[INFO] 
[INFO] --- maven-remote-resources-plugin:1.1:process (default) @ 
org.apache.sling.auth.openid ---
mojoSucceeded 
org.apache.maven.plugins:maven-remote-resources-plugin:1.1(default)
mojoStarted 
org.apache.maven.plugins:maven-resources-plugin:2.4.3(default-resources)[INFO] 
Using 'UTF-8' encoding to copy filtered resources.

[INFO] 
[INFO] --- maven-resources-plugin:2.4.3:resources (default-resources) @ 
org.apache.sling.auth.openid ---
[INFO] Copying 2 resources
[INFO] Copying 3 resources
mojoSucceeded 
org.apache.maven.plugins:maven-resources-plugin:2.4.3(default-resources)
mojoStarted org.apache.maven.plugins:maven-antrun-plugin:1.6(default)[INFO] 
Executing tasks

main:
 [echo]  WARNING (SLING-443/SLING-1782) 
**
 [echo] On most platforms, you'll get OutOfMemoryErrors when building 
unless you set
 [echo] on 32bit platforms: MAVEN_OPTS="-Xmx256M -XX:MaxPermSize=256M", see 
SLING-443
 [echo] on 64bit platforms: MAVEN_OPTS="-Xmx512M -XX:MaxPermSize=512M", see 
SLING-1782
 [echo] 
**
[INFO] Executed tasks

[INFO] 
[INFO] --- maven-antrun-plugin:1.6:run (default) @ org.apache.sling.auth.openid 
---
mojoSucceeded org.apache.maven.plugins:maven-antrun-plugin:1.6(default)
mojoStarted 
org.apache.maven.plugins:maven-compiler-plugin:2.5.1(default-compile)
[INFO] Compiling 5 source files to 

[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:compile (default-compile) @ 
org.apache.sling.auth.openid ---
mojoSucceeded 
org.apache.maven.plugins:maven-compiler-plugin:2.5.1(default-compile)
mojoStarted org.apache.felix:maven-scr-plugin:1.7.4(generate-scr-scrdescriptor)
[INFO] 
[INFO] --- maven-scr-plugin:1.7.4:scr (generate-scr-scrdescriptor) @ 
org.apache.sling.auth.openid ---
[INFO] Generating 2 MetaType Descriptors to 

[INFO] Writing abstract service descriptor 

 with 2 entries.
[INFO] Generating 2 Service Component Descriptors to 

mojoSucceeded 
org.apache.felix:maven-scr-plugin:1.7.4(generate-scr-scrdescriptor)
mojoStarted 
org.apache.maven.plugins:maven-resources-plugin:2.4.3(default-testResources)[INFO]
 Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources

[INFO] 
[INFO] --- maven-resources-plugin:2.4.3:testResources (default-testResources) @ 
org.apache.sling.auth.openid ---
mojoSucceeded 
org.apache.maven.plugins:maven-resources-plugin:2.4.3(default-testResources)
mojoStarted 
org.apache.maven.plugins:maven-compiler-plugin:2.5.1(default-testCompile)
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile) @ 
org.apache.sling.auth.openid ---
[INFO] Compiling 1 source file to 

mojoSucceeded 
org.apache.maven.plugins:maven-compiler-plugin:2.5.1(default-testCompile)
mojoStarted 
org.apache.maven.plugins:maven-surefire-plugin:2.7.2(default-test)[INFO] 
Surefire report directory: 


[INFO] 
[INFO] --- maven-surefire-plugin:2.7.2:test (default-test) @ 
org.apache.sling.auth.openid ---

---
 T E S T S
---
Running org.apache.sling.auth.openid.impl.OpenIDAuthenti

[jira] [Assigned] (SLING-2558) Potential Deadlocks may be caused by AdapterManager

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-2558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler reassigned SLING-2558:
---

Assignee: Carsten Ziegeler

> Potential Deadlocks may be caused by AdapterManager
> ---
>
> Key: SLING-2558
> URL: https://issues.apache.org/jira/browse/SLING-2558
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: Adapter 2.0.16
>Reporter: Felix Meschberger
>Assignee: Carsten Ziegeler
> Fix For: Adapter 2.0.18
>
>
> The AdapterManager uses a cascade of three synchronized blocks when the 
> AdapterFactoryDescriptor.getFactory() method is called:
>   * synchronized(cache)
>   * synchronized(factories)
>   * synchronized(this)
> A potential deadlock may happen because the 
> AdapterFactoryDescriptor.getFactory() method asks the Declarative Services 
> runtime for a service, which may cause a ServiceFactory service to be 
> instantiated (with a whole cascade of potential secondary actions depending 
> on what happens on this instantiation).
> The last block can probably simply be removed while the others definitely 
> have to be refactored to not be the cause or participants in deadlock 
> situations. The reason for this is, that (a) synchronized blocks must not be 
> too large and (b) no Java locks should be held when calling into the OSGi 
> Framework, which happens in the AdapterFactoryDescriptor.getFactory method.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

Re: Empty string property values

[Carsten Ziegeler]

2012/8/13 Bertrand Delacretaz :
> On Mon, Aug 13, 2012 at 2:14 PM, Carsten Ziegeler  
> wrote:
>> 2012/8/13 Bertrand Delacretaz :
>
>>> ...The first SLING-1412 commit is svn revision 916419, and the
>>> SlingDefaultValuesTest#testDefaultBehaviour test hasn't changed since
>>> rev 656302, so I think the "remove property on empty value" behavior
>>> has been there from rev 656302 or even earlier.
>>
>> Yes, I have the same feeling, but then why has SLING-1412 filed? :)
>
> IIUC the use case for that is a request with the following parameters
>
> /stringProperty@TypeHint=String[]
> ./stringProperty@IgnoreBlanks=true
> ./stringProperty=foo
> ./stringProperty=bar
> ./stringProperty=
>
> which should set only two values in the stringProperty multi-value
> field, instead of three without @IgnoreBlanks.
>
> If I'm right we could probably restrict IgnoreBlanks to multi-value
> properties, if that helps clarifying things.
>
>> ...the current code only implements some strange behaviour for
>> @IgnoreBlanks which in one way or the other has to be fixed
>
> Ok, but IMO the "remove property if no value is provided for it"
> behavior needs to stay.
>
Yes, interestingly a lot of the integration tests fail otherwise -
which really surprises me. But that's a different story.

I think we should deprecate @IgnoreBlanks, properly document how blank
values are really handled, and then implement SLING-2534 which is the
opposite of @IgnoreBlanks

Carsten



-- 
Carsten Ziegeler
cziege...@apache.org

Re: Empty string property values

[Justin Edelson]

On Mon, Aug 13, 2012 at 8:24 AM, Bertrand Delacretaz  wrote:

> On Mon, Aug 13, 2012 at 2:14 PM, Carsten Ziegeler 
> wrote:
> > 2012/8/13 Bertrand Delacretaz :
>
> >> ...The first SLING-1412 commit is svn revision 916419, and the
> >> SlingDefaultValuesTest#testDefaultBehaviour test hasn't changed since
> >> rev 656302, so I think the "remove property on empty value" behavior
> >> has been there from rev 656302 or even earlier.
> >
> > Yes, I have the same feeling, but then why has SLING-1412 filed? :)
>
> IIUC the use case for that is a request with the following parameters
>
> /stringProperty@TypeHint=String[]
> ./stringProperty@IgnoreBlanks=true
> ./stringProperty=foo
> ./stringProperty=bar
> ./stringProperty=
>
> which should set only two values in the stringProperty multi-value
> field, instead of three without @IgnoreBlanks.
>

Yes - this was the intended use case.


>
> If I'm right we could probably restrict IgnoreBlanks to multi-value
> properties, if that helps clarifying things.
>
> > ...the current code only implements some strange behaviour for
> > @IgnoreBlanks which in one way or the other has to be fixed
>
> Ok, but IMO the "remove property if no value is provided for it"
> behavior needs to stay.
>

+1

Justin


>
> -Bertrand
>

Re: Empty string property values

[Bertrand Delacretaz]

On Mon, Aug 13, 2012 at 2:14 PM, Carsten Ziegeler  wrote:
> 2012/8/13 Bertrand Delacretaz :

>> ...The first SLING-1412 commit is svn revision 916419, and the
>> SlingDefaultValuesTest#testDefaultBehaviour test hasn't changed since
>> rev 656302, so I think the "remove property on empty value" behavior
>> has been there from rev 656302 or even earlier.
>
> Yes, I have the same feeling, but then why has SLING-1412 filed? :)

IIUC the use case for that is a request with the following parameters

/stringProperty@TypeHint=String[]
./stringProperty@IgnoreBlanks=true
./stringProperty=foo
./stringProperty=bar
./stringProperty=

which should set only two values in the stringProperty multi-value
field, instead of three without @IgnoreBlanks.

If I'm right we could probably restrict IgnoreBlanks to multi-value
properties, if that helps clarifying things.

> ...the current code only implements some strange behaviour for
> @IgnoreBlanks which in one way or the other has to be fixed

Ok, but IMO the "remove property if no value is provided for it"
behavior needs to stay.

-Bertrand

Re: Empty string property values

[Carsten Ziegeler]

2012/8/13 Bertrand Delacretaz :
> On Mon, Aug 13, 2012 at 1:15 PM, Carsten Ziegeler  
> wrote:
>> 2012/8/13 Bertrand Delacretaz :
>>> On Mon, Aug 13, 2012 at 11:47 AM, Carsten Ziegeler  
>>> wrote:
 ...after fixing these I run into failing integration tests, e.g.
 SlingDefaultValuesTest#testDefaultBehaviour posts a new property with
 an empty value and checks if the property does not exists afterwards
>>>
>>> IIRC (but that was a long time ago) that's by design. Would we have
>>> another way of removing a property via a POST than setting it empty
>>> anyways?
>>>
>> See 
>> http://sling.apache.org/site/manipulating-content-the-slingpostservlet-servletspost.html
>>
>> which mentions that @IgnoreBlanks should be used instead
>
> I don't think IgnoreBlanks can be used to remove properties, IIUC it
> just causes request parameters with empty values to be ignored. So IMO
> there would be no way to remove a property if we changed the current
> behavior.

No, I think it's the other way round! At least looking at the docs and
the implementation (though buggy) I get the feeling that without
@IgnoreBlanks a blank field is not removing the property but setting
it to empty.

>
>>
>> Reading https://issues.apache.org/jira/browse/SLING-1412 where this
>> was introduced, it suggests that the current behaviour was not how
>> these things have been handled before the fix.
>
> The first SLING-1412 commit is svn revision 916419, and the
> SlingDefaultValuesTest#testDefaultBehaviour test hasn't changed since
> rev 656302, so I think the "remove property on empty value" behavior
> has been there from rev 656302 or even earlier.

Yes, I have the same feeling, but then why has SLING-1412 filed? :)

>
> IMO the current code is fine, we might just need to update the
> @IgnoreBlanks doc (or better: add integration tests for that, and yes
> I volunteer ;-)

No, the current code only implements some strange behaviour for
@IgnoreBlanks which in one way or the other has to be fixed.

Regards
Carsten
>
> -Bertrand



-- 
Carsten Ziegeler
cziege...@apache.org

Re: Empty string property values

[Felix Meschberger]

Hi,

ANd it must not be forgotten that the Sling POST Servlet was designed with 
first class support for HTML Forms in mind. If you consider such a form, you 
could pre-fill it with the current values and the user could clear the fields 
assuming to remove/clear the properties. So the Sling POST Servlet just removes 
the property.

And even though the doc may contradict the implementation, the implementation 
has been around for more than two years. We cannot just change the 
implementation without risking breaking existing applications. In this special 
case we should therefore fix the doc and referring to the problem.

Regards
Felix

Am 13.08.2012 um 13:15 schrieb Carsten Ziegeler:

> 2012/8/13 Bertrand Delacretaz :
>> On Mon, Aug 13, 2012 at 11:47 AM, Carsten Ziegeler  
>> wrote:
>>> ...after fixing these I run into failing integration tests, e.g.
>>> SlingDefaultValuesTest#testDefaultBehaviour posts a new property with
>>> an empty value and checks if the property does not exists afterwards
>> 
>> IIRC (but that was a long time ago) that's by design. Would we have
>> another way of removing a property via a POST than setting it empty
>> anyways?
>> 
> See 
> http://sling.apache.org/site/manipulating-content-the-slingpostservlet-servletspost.html
> 
> which mentions that @IgnoreBlanks should be used instead
> 
> Reading https://issues.apache.org/jira/browse/SLING-1412 where this
> was introduced, it suggests that the current behaviour was not how
> these things have been handled before the fix.
> 
> Carsten
> 
> 
> -- 
> Carsten Ziegeler
> cziege...@apache.org

Re: Empty string property values

[Bertrand Delacretaz]

On Mon, Aug 13, 2012 at 1:15 PM, Carsten Ziegeler  wrote:
> 2012/8/13 Bertrand Delacretaz :
>> On Mon, Aug 13, 2012 at 11:47 AM, Carsten Ziegeler  
>> wrote:
>>> ...after fixing these I run into failing integration tests, e.g.
>>> SlingDefaultValuesTest#testDefaultBehaviour posts a new property with
>>> an empty value and checks if the property does not exists afterwards
>>
>> IIRC (but that was a long time ago) that's by design. Would we have
>> another way of removing a property via a POST than setting it empty
>> anyways?
>>
> See 
> http://sling.apache.org/site/manipulating-content-the-slingpostservlet-servletspost.html
>
> which mentions that @IgnoreBlanks should be used instead

I don't think IgnoreBlanks can be used to remove properties, IIUC it
just causes request parameters with empty values to be ignored. So IMO
there would be no way to remove a property if we changed the current
behavior.

>
> Reading https://issues.apache.org/jira/browse/SLING-1412 where this
> was introduced, it suggests that the current behaviour was not how
> these things have been handled before the fix.

The first SLING-1412 commit is svn revision 916419, and the
SlingDefaultValuesTest#testDefaultBehaviour test hasn't changed since
rev 656302, so I think the "remove property on empty value" behavior
has been there from rev 656302 or even earlier.

IMO the current code is fine, we might just need to update the
@IgnoreBlanks doc (or better: add integration tests for that, and yes
I volunteer ;-)

-Bertrand

Re: Empty string property values

[Carsten Ziegeler]

2012/8/13 Bertrand Delacretaz :
> On Mon, Aug 13, 2012 at 11:47 AM, Carsten Ziegeler  
> wrote:
>> ...after fixing these I run into failing integration tests, e.g.
>> SlingDefaultValuesTest#testDefaultBehaviour posts a new property with
>> an empty value and checks if the property does not exists afterwards
>
> IIRC (but that was a long time ago) that's by design. Would we have
> another way of removing a property via a POST than setting it empty
> anyways?
>
See 
http://sling.apache.org/site/manipulating-content-the-slingpostservlet-servletspost.html

which mentions that @IgnoreBlanks should be used instead

Reading https://issues.apache.org/jira/browse/SLING-1412 where this
was introduced, it suggests that the current behaviour was not how
these things have been handled before the fix.

Carsten


-- 
Carsten Ziegeler
cziege...@apache.org

Re: Empty string property values

[Bertrand Delacretaz]

On Mon, Aug 13, 2012 at 11:47 AM, Carsten Ziegeler  wrote:
> ...after fixing these I run into failing integration tests, e.g.
> SlingDefaultValuesTest#testDefaultBehaviour posts a new property with
> an empty value and checks if the property does not exists afterwards

IIRC (but that was a long time ago) that's by design. Would we have
another way of removing a property via a POST than setting it empty
anyways?

-Bertrand

RE: Empty string property values

[Jeff Young]

Hi Carsten,

While I don't have any advice on how to proceed, I can tell you that I'd be 
getting cold feet at about this point too. ;)

Jeff.


> -Original Message-
> From: Carsten Ziegeler [mailto:cziege...@apache.org]
> Sent: 13 August 2012 10:48
> To: dev@sling.apache.org
> Subject: Re: Empty string property values
> 
> While looking into SLING-2534, it seems that (as Alex noted) our docs
> say something different than the implementation.
> So I tried to fix the implementation (whic is fairly easy), but then I
> ran into failing junit tests - I think these tests have wrong
> assumptions.
> So after fixing these I run into failing integration tests, e.g.
> SlingDefaultValuesTest#testDefaultBehaviour posts a new property with
> an empty value and checks if the property does not exists afterwards.
> Now, these tests can be fixed as well, but I'm wondering if that's a
> good thing - it would be correct, but existing applications might rely
> on the wrong behaviour?
> On the other hand for rendering a missing value and an empty value
> usually doesn't make a difference...while it might make a difference
> for other apps
> 
> Carsten
> 
> 
> 2012/7/19 Alexander Klimetschek :
> > On 16.07.2012, at 17:07, Jeremy Booth wrote:
> >> For our app we do need to
> >> differentiate between provided empty and not provided.
> >
> > I can imagine that this makes sense sometimes (albeit I haven't come across
> this yet).
> >
> >> On 16 July 2012 15:42, Carsten Ziegeler  wrote:
> >>> the handling of the empty value happens in the Sling Post servlet -
> >>> afaik this was a decision in the early days of the post servlet to
> >>> treat an empty value like no value.
> >
> > Yes, that was always in the code (I remember refactoring that once for the
> @Patch feature). It's clearly commented, albeit the initial reasoning seems
> lost:
> >
> > // if no value is present or a single empty string is given,
> > // just remove the existing property (if any)
> > removeProperty(parent, prop);
> >
> >  However, the sling post servlet docs say something different:
> >
> > http://sling.apache.org/site/manipulating-content-the-slingpostservlet-
> servletspost.html#ManipulatingContent-TheSlingPostServlet%28servlets.post%29-
> %7B%7B@IgnoreBlanks%7D%7D
> >
> > The 2nd example in that section:
> >
> > 
> > 
> > 
> > 
> >
> > This will _not_ result in an empty property, but in no property at all (just
> tested it).
> >
> > Without knowing the original reasoning for "" == null, I would say the sling
> post servlet documentation is king and this is a bug :-)
> >
> > But one needs to be careful here, as there are so many options involved:
> single- vs. multi-value properties, @IgnoreBlanks, @DefaultValue = :null,
> @DefaultValue = :ignore ... (see also RequestPropertyTest).
> >
> > Cheers,
> > Alex
> >
> 
> 
> 
> --
> Carsten Ziegeler
> cziege...@apache.org

Re: Empty string property values

[Carsten Ziegeler]

While looking into SLING-2534, it seems that (as Alex noted) our docs
say something different than the implementation.
So I tried to fix the implementation (whic is fairly easy), but then I
ran into failing junit tests - I think these tests have wrong
assumptions.
So after fixing these I run into failing integration tests, e.g.
SlingDefaultValuesTest#testDefaultBehaviour posts a new property with
an empty value and checks if the property does not exists afterwards.
Now, these tests can be fixed as well, but I'm wondering if that's a
good thing - it would be correct, but existing applications might rely
on the wrong behaviour?
On the other hand for rendering a missing value and an empty value
usually doesn't make a difference...while it might make a difference
for other apps

Carsten


2012/7/19 Alexander Klimetschek :
> On 16.07.2012, at 17:07, Jeremy Booth wrote:
>> For our app we do need to
>> differentiate between provided empty and not provided.
>
> I can imagine that this makes sense sometimes (albeit I haven't come across 
> this yet).
>
>> On 16 July 2012 15:42, Carsten Ziegeler  wrote:
>>> the handling of the empty value happens in the Sling Post servlet -
>>> afaik this was a decision in the early days of the post servlet to
>>> treat an empty value like no value.
>
> Yes, that was always in the code (I remember refactoring that once for the 
> @Patch feature). It's clearly commented, albeit the initial reasoning seems 
> lost:
>
> // if no value is present or a single empty string is given,
> // just remove the existing property (if any)
> removeProperty(parent, prop);
>
>  However, the sling post servlet docs say something different:
>
> http://sling.apache.org/site/manipulating-content-the-slingpostservlet-servletspost.html#ManipulatingContent-TheSlingPostServlet%28servlets.post%29-%7B%7B@IgnoreBlanks%7D%7D
>
> The 2nd example in that section:
>
>  enctype="multipart/form-data">
> 
> 
> 
>
> This will _not_ result in an empty property, but in no property at all (just 
> tested it).
>
> Without knowing the original reasoning for "" == null, I would say the sling 
> post servlet documentation is king and this is a bug :-)
>
> But one needs to be careful here, as there are so many options involved: 
> single- vs. multi-value properties, @IgnoreBlanks, @DefaultValue = :null, 
> @DefaultValue = :ignore ... (see also RequestPropertyTest).
>
> Cheers,
> Alex
>



-- 
Carsten Ziegeler
cziege...@apache.org

Jenkins build is back to normal : sling-contrib-1.6 #923

[Apache Jenkins Server]

See 

Jenkins build is unstable: sling-trunk-1.5 #1741

[Apache Jenkins Server]

See 

Jenkins build is back to stable : sling-trunk-1.5 » Apache Sling JCR Resource Resolver #1741

[Apache Jenkins Server]

See 

Re: [VOTE] Release Scripting JST 2.0.6

[Bertrand Delacretaz]

On Mon, Aug 13, 2012 at 9:45 AM, Carsten Ziegeler  wrote:
> ...Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-133/

+1, checked signatures, build and that the following archive matches
the corresponding svn tag.

MD5 (org.apache.sling.scripting.jst-2.0.6-source-release.zip) =
4cd3be6e72dfc3329826d04518663466

-Bertrand

Re: [VOTE] Release Scripting JST 2.0.6

[Felix Meschberger]

+1

Regards
Felix

Am 13.08.2012 um 09:45 schrieb Carsten Ziegeler:

> Hi,
> 
> This vote is the release of Apache Sling Scripting JST 2.0.6 which
> fixes SLING-2545.
> 
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-133/
> 
> 
> You can use this UNIX script to download the release and verify the 
> signatures:
> http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh
> 
> Usage:
> sh check_staged_release.sh 133 /tmp/sling-staging
> 
> 
> Please vote to approve this release:
> 
> [ ] +1 Approve the release
> [ ]  0 Don't care
> [ ] -1 Don't release, because ...
> 
> This vote will be open for 72 hours.
> 
> Regards
> Carsten
> -- 
> Carsten Ziegeler
> cziege...@apache.org

Re: [VOTE] Release Scripting JST 2.0.6

[Ian Boston]

All good.
+1
Ian


On 13 August 2012 17:45, Carsten Ziegeler  wrote:
> +1
>
> Carsten
>
> 2012/8/13 Carsten Ziegeler :
>> Hi,
>>
>> This vote is the release of Apache Sling Scripting JST 2.0.6 which
>> fixes SLING-2545.
>>
>> Staging repository:
>> https://repository.apache.org/content/repositories/orgapachesling-133/
>>
>>
>> You can use this UNIX script to download the release and verify the 
>> signatures:
>> http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh
>>
>> Usage:
>> sh check_staged_release.sh 133 /tmp/sling-staging
>>
>>
>> Please vote to approve this release:
>>
>>  [ ] +1 Approve the release
>>  [ ]  0 Don't care
>>  [ ] -1 Don't release, because ...
>>
>> This vote will be open for 72 hours.
>>
>> Regards
>> Carsten
>> --
>> Carsten Ziegeler
>> cziege...@apache.org
>
>
>
> --
> Carsten Ziegeler
> cziege...@apache.org

Jenkins build is back to normal : sling-contrib-1.6 » Apache Sling Request Processing Analyzer #922

[Apache Jenkins Server]

See 

[jira] [Resolved] (SLING-2491) How can I change the self.registration.enabled property in java?

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-2491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-2491.
-

Resolution: Invalid

> How can I change the self.registration.enabled property in java?
> 
>
> Key: SLING-2491
> URL: https://issues.apache.org/jira/browse/SLING-2491
> Project: Sling
>  Issue Type: Task
>  Components: JCR
>Affects Versions: JCR Jackrabbit User Manager 2.1.0
> Environment: Xubuntu
>Reporter: Chris Papagrigoriou
>
> Hey I kinda can't find out how to change the the self.registration.enabled 
> property of the CreateUserServlet.
> I tried it via the ConfigurationAdmin but it doesn't seem to work.
> Can anyone tell me how to change it?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (SLING-2534) Strings of zero length on update in post servlet delete the property

[Carsten Ziegeler (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-2534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13432982#comment-13432982
 ] 

Carsten Ziegeler commented on SLING-2534:
-

Actually, it seems this is a bug in the Sling POST servlet, according to

http://sling.apache.org/site/manipulating-content-the-slingpostservlet-servletspost.html

an empty value should be set, unless @IgnoreBlanks is specified.

> Strings of zero length on update in post servlet delete the property
> 
>
> Key: SLING-2534
> URL: https://issues.apache.org/jira/browse/SLING-2534
> Project: Sling
>  Issue Type: Bug
>  Components: Servlets
>Affects Versions: Servlets Post 2.1.2
>Reporter: Endolf
> Fix For: Servlets Post 2.1.4
>
> Attachments: blankstrings.patch
>
>
> According to JCR specs, for string type properties, a blank string should be 
> a valid value. Currently the post servlet delets any property where 1 or less 
> values are specifed and the 1 value has a 0 length. I think string properties 
> with a zero length should be blanked instead of deleted.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (SLING-2534) Strings of zero length on update in post servlet delete the property

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-2534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler updated SLING-2534:


Fix Version/s: Servlets Post 2.1.4

> Strings of zero length on update in post servlet delete the property
> 
>
> Key: SLING-2534
> URL: https://issues.apache.org/jira/browse/SLING-2534
> Project: Sling
>  Issue Type: Bug
>  Components: Servlets
>Affects Versions: Servlets Post 2.1.2
>Reporter: Endolf
> Fix For: Servlets Post 2.1.4
>
> Attachments: blankstrings.patch
>
>
> According to JCR specs, for string type properties, a blank string should be 
> a valid value. Currently the post servlet delets any property where 1 or less 
> values are specifed and the 1 value has a 0 length. I think string properties 
> with a zero length should be blanked instead of deleted.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Closed] (SLING-2491) How can I change the self.registration.enabled property in java?

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-2491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler closed SLING-2491.
---


> How can I change the self.registration.enabled property in java?
> 
>
> Key: SLING-2491
> URL: https://issues.apache.org/jira/browse/SLING-2491
> Project: Sling
>  Issue Type: Task
>  Components: JCR
>Affects Versions: JCR Jackrabbit User Manager 2.1.0
> Environment: Xubuntu
>Reporter: Chris Papagrigoriou
>
> Hey I kinda can't find out how to change the the self.registration.enabled 
> property of the CreateUserServlet.
> I tried it via the ConfigurationAdmin but it doesn't seem to work.
> Can anyone tell me how to change it?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

Re: [VOTE] Release Scripting JST 2.0.6

[Carsten Ziegeler]

+1

Carsten

2012/8/13 Carsten Ziegeler :
> Hi,
>
> This vote is the release of Apache Sling Scripting JST 2.0.6 which
> fixes SLING-2545.
>
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-133/
>
>
> You can use this UNIX script to download the release and verify the 
> signatures:
> http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh
>
> Usage:
> sh check_staged_release.sh 133 /tmp/sling-staging
>
>
> Please vote to approve this release:
>
>  [ ] +1 Approve the release
>  [ ]  0 Don't care
>  [ ] -1 Don't release, because ...
>
> This vote will be open for 72 hours.
>
> Regards
> Carsten
> --
> Carsten Ziegeler
> cziege...@apache.org



-- 
Carsten Ziegeler
cziege...@apache.org

[VOTE] Release Scripting JST 2.0.6

[Carsten Ziegeler]

Hi,

This vote is the release of Apache Sling Scripting JST 2.0.6 which
fixes SLING-2545.

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-133/


You can use this UNIX script to download the release and verify the signatures:
http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh

Usage:
sh check_staged_release.sh 133 /tmp/sling-staging


Please vote to approve this release:

 [ ] +1 Approve the release
 [ ]  0 Don't care
 [ ] -1 Don't release, because ...

This vote will be open for 72 hours.

Regards
Carsten
-- 
Carsten Ziegeler
cziege...@apache.org

[jira] [Resolved] (SLING-2545) Scripting jst is using wrong import package directives

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-2545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-2545.
-

   Resolution: Fixed
Fix Version/s: Scripting JST 2.0.6

Fixed the imports, also corrected the exports and fixed a minor problem with 
the breadcrumb

As this generates scrips for the client, we don't need the dynamic classloader

> Scripting jst is using wrong import package directives
> --
>
> Key: SLING-2545
> URL: https://issues.apache.org/jira/browse/SLING-2545
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Affects Versions: Scripting JST 2.0.4
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: Scripting JST 2.0.6
>
>
> Scripting jst is not imorting all packages it requires through import-package 
> in the manifest. Many of them are done with the dynamic import package * 
> directive.
> This should be correct and proper imports should be specified
> In addition dynamic import * should be replaced by using the dynamic class 
> loader

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira