[jira] [Commented] (SLING-3290) Long startup time with many vanityPath
[ https://issues.apache.org/jira/browse/SLING-3290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14085847#comment-14085847 ] Carsten Ziegeler commented on SLING-3290: - I'm note sure if we should mix the two issues for now. As Felix points out, the long term goal is to just use /etc/map as the source of truth (some time ago I created SLING-3206 for a first step). Startup might still be slow if we have to traverse a large tree in /etc/map, so I think Antonio's idea of the bloom filter still makes sense. Re guava: let's please not introduce this - if we require something from that lib, just embedd the single class you need, but I definitely don't want this lib as an OSGi bundle Long startup time with many vanityPath -- Key: SLING-3290 URL: https://issues.apache.org/jira/browse/SLING-3290 Project: Sling Issue Type: Improvement Components: ResourceResolver Reporter: Antonio Sanso Assignee: Antonio Sanso Labels: vanity Attachments: SLING-3290-patch.txt, StartupWithManyVanityPath.jpg When many vanityPath or alias are present the system take long time to startup , Same when a vanityPath/alias is removed or updated . The reason behind is the usage of a query that updates the global mapentry. I have added a new Test to the performance test suite and this is the outcome {code} 0 vanityPath 16ms 1 vanityPath 19ms 10 vanityPath 70ms 100 vanityPath111ms 1000 vanityPath 200ms 1 vanityPath 1173ms 3 vanityPath 3358ms {code} -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SLING-3290) Long startup time with many vanityPath
[ https://issues.apache.org/jira/browse/SLING-3290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14085852#comment-14085852 ] Bertrand Delacretaz commented on SLING-3290: FWIW I'm fine about embedding the relevant Guava (or other) code instead of having to install its bundle. What I object to is creating our own (or copy/pasted) bloom filter implementation, especially if there are no automated tests for it ;-) Long startup time with many vanityPath -- Key: SLING-3290 URL: https://issues.apache.org/jira/browse/SLING-3290 Project: Sling Issue Type: Improvement Components: ResourceResolver Reporter: Antonio Sanso Assignee: Antonio Sanso Labels: vanity Attachments: SLING-3290-patch.txt, StartupWithManyVanityPath.jpg When many vanityPath or alias are present the system take long time to startup , Same when a vanityPath/alias is removed or updated . The reason behind is the usage of a query that updates the global mapentry. I have added a new Test to the performance test suite and this is the outcome {code} 0 vanityPath 16ms 1 vanityPath 19ms 10 vanityPath 70ms 100 vanityPath111ms 1000 vanityPath 200ms 1 vanityPath 1173ms 3 vanityPath 3358ms {code} -- This message was sent by Atlassian JIRA (v6.2#6252)
Re: Launchpad 7 Release?
On Wednesday 23 July 2014 08:24:35 Bertrand Delacretaz wrote: On Tue, Jul 22, 2014 at 10:33 PM, Oliver Lietz apa...@oliverlietz.de wrote: On Tuesday 22 July 2014 13:30:59 Bertrand Delacretaz wrote: ...Are you planning to setup integration tests for that Karaf-based launcher? Sure. There are already basic bootstrap tests which check if the required bundles are available and active in org.apache.sling.launchpad.karaf- integration-tests and also some extended tests which check for services and nodes in the repository... Sorry my question was unclear - are you planning to run the launchpad/integration-tests on the Karaf-based launcher? So that the same test suite is used for that and for the launchpad. SLING-3821 - some tests fail simply because required bundles are not present. I will add more bundles/features in the next days to fix them and come to you for some other failing tests as I'm not that familiar with the Sling test stuff. And there is sling-tests on GitHub. Where exactly? Not sure what that is. https://github.com/oliverlietz/sling-tests Was an easier and faster way for me to create tests with Pax Exam and Karaf instead of learning the Sling test stuff spread in different bundles in the repo. Should be easy for me to recreate them in launchpad/integration-tests when I'm done with SLING-3821. O. -Bertrand
[jira] [Updated] (SLING-3502) Main job queue is not properly outdated
[ https://issues.apache.org/jira/browse/SLING-3502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler updated SLING-3502: Fix Version/s: Event 3.3.10 Main job queue is not properly outdated Key: SLING-3502 URL: https://issues.apache.org/jira/browse/SLING-3502 Project: Sling Issue Type: Bug Components: Extensions Affects Versions: Event 3.3.10 Reporter: Marc Pfaff Assignee: Stefan Egli Fix For: Event 3.3.10 Attachments: SLING-3502-2.patch, SLING-3502-IT.patch, SLING-3502.patch, SLING-3502.patch The default job queue called main queue appears not to be properly outdated. The JobManager keeps an internal map of currently running job queues, indexed by job name. The code to outdate a queue (JobManagerImpl.outdateQueue()) uses a filtered queue name to look up the queue to outdate in this map. But the part that uses, creates and puts the queue on the map (JobManagerImpl.process()), does not filter the queue name. After outdating the main queue like this, there are two or more main queue entries in the map, depending on the number of topology changes happening, pointing to the same outdated queue instance. As one of the queues is still indexed with main queue, new jobs that use the main queue are always assigned an outdated queue. That's a dead end, as outdated queues do not appear to have a queue thread running no more. To reproduce: * Start one instance * Start a job that uses the main queue, so one instance of the main queue is created. This job passes fine. * Trigger a topology change, e.g. by adding a second instance to the same topology * Check the job manager in sling console, you should see two outdated main queues, properly labeled as outdated, but one of them is internally still indexed by main queue * Start another job that uses the main queue. This job and all following jobs using main queue never get executed -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Resolved] (SLING-3652) Sling Job Consumer Manager : Distribute config should be disabled by default
[ https://issues.apache.org/jira/browse/SLING-3652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-3652. - Resolution: Won't Fix Closing as won't fix as this can be changed by applying an OSGi configuration Sling Job Consumer Manager : Distribute config should be disabled by default Key: SLING-3652 URL: https://issues.apache.org/jira/browse/SLING-3652 Project: Sling Issue Type: Bug Components: Extensions Affects Versions: Event 3.3.10 Reporter: Ashutosh Shroti Assignee: Amit Gupta Sling Job Consumer Manager service have an following flag: Distribute config - disabled This should be disabled by default. Use Case: While configuring author instances in the cluster, config changes like disable the listener on topic com/adobe/granite/workflow/offloading should be local to an instance. Hence above mentioned flag should be disabled by default to prevent config changes to local instance. -- This message was sent by Atlassian JIRA (v6.2#6252)
Re: Launchpad 7 Release?
Hi Oliver, On Tue, Aug 5, 2014 at 8:57 AM, Oliver Lietz apa...@oliverlietz.de wrote: ...https://github.com/oliverlietz/sling-tests Was an easier and faster way for me to create tests with Pax Exam and Karaf instead of learning the Sling test stuff spread in different bundles in the repo. Should be easy for me to recreate them in launchpad/integration-tests when I'm done with SLING-3821 Ok, fair enough - what's important IMO is to run the exact same integration tests suite in all environments, that is launchpad/integration-tests. Note that those require the launchpad/test-services bundle. -Bertrand
[jira] [Reopened] (SLING-3652) Sling Job Consumer Manager : Distribute config should be disabled by default
[ https://issues.apache.org/jira/browse/SLING-3652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashutosh Shroti reopened SLING-3652: Seems I had to elaborate the issue in detail: Sling job consumer manager service has an configuration distribute config = disabled, which doesn't work as expected on start up. This config value needs to be reset (mark it enable then disable) explicitly through OSGI config to get it reflected. Above issue should be fixed as it depicts confusing un-expected behavior for an end user. Sling Job Consumer Manager : Distribute config should be disabled by default Key: SLING-3652 URL: https://issues.apache.org/jira/browse/SLING-3652 Project: Sling Issue Type: Bug Components: Extensions Affects Versions: Event 3.3.10 Reporter: Ashutosh Shroti Assignee: Amit Gupta Sling Job Consumer Manager service have an following flag: Distribute config - disabled This should be disabled by default. Use Case: While configuring author instances in the cluster, config changes like disable the listener on topic com/adobe/granite/workflow/offloading should be local to an instance. Hence above mentioned flag should be disabled by default to prevent config changes to local instance. -- This message was sent by Atlassian JIRA (v6.2#6252)
Build failed in Jenkins: sling-contrib-1.6 » Apache Sling Launchpad Karaf - Integration Tests #1196
See https://builds.apache.org/job/sling-contrib-1.6/org.apache.sling$org.apache.sling.launchpad.karaf-integration-tests/1196/ -- [INFO] [INFO] [INFO] Building Apache Sling Launchpad Karaf - Integration Tests 0.1.1-SNAPSHOT [INFO] Downloading: http://repo.maven.apache.org/maven2/org/apache/sling/org.apache.sling.engine/2.3.4/org.apache.sling.engine-2.3.4.pom Downloaded: http://repo.maven.apache.org/maven2/org/apache/sling/org.apache.sling.engine/2.3.4/org.apache.sling.engine-2.3.4.pom (14 KB at 51.7 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/apache/sling/org.apache.sling.engine/2.3.4/org.apache.sling.engine-2.3.4.jar Downloaded: http://repo.maven.apache.org/maven2/org/apache/sling/org.apache.sling.engine/2.3.4/org.apache.sling.engine-2.3.4.jar (180 KB at 563.5 KB/sec) [INFO] [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ org.apache.sling.launchpad.karaf-integration-tests --- [INFO] [INFO] --- maven-enforcer-plugin:1.3.1:enforce (enforce-java) @ org.apache.sling.launchpad.karaf-integration-tests --- [INFO] [INFO] --- maven-antrun-plugin:1.7:run (set-bundle-required-execution-environment) @ org.apache.sling.launchpad.karaf-integration-tests --- [INFO] Executing tasks main: [INFO] Executed tasks [INFO] [INFO] --- maven-remote-resources-plugin:1.5:process (default) @ org.apache.sling.launchpad.karaf-integration-tests --- [INFO] [INFO] --- maven-resources-plugin:2.6:resources (default-resources) @ org.apache.sling.launchpad.karaf-integration-tests --- [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] skip non existing resourceDirectory https://builds.apache.org/job/sling-contrib-1.6/org.apache.sling$org.apache.sling.launchpad.karaf-integration-tests/ws/src/main/resources [INFO] Copying 3 resources [INFO] [INFO] --- maven-antrun-plugin:1.7:run (check-memory-task) @ org.apache.sling.launchpad.karaf-integration-tests --- [INFO] Executing tasks main: [echo] WARNING (SLING-443/SLING-1782) ** [echo] On most platforms, you'll get OutOfMemoryErrors when building unless you set [echo] on 32bit platforms: MAVEN_OPTS=-Xmx256M -XX:MaxPermSize=256M, see SLING-443 [echo] on 64bit platforms: MAVEN_OPTS=-Xmx512M -XX:MaxPermSize=512M, see SLING-1782 [echo] ** [INFO] Executed tasks [INFO] [INFO] --- maven-compiler-plugin:3.1:compile (default-compile) @ org.apache.sling.launchpad.karaf-integration-tests --- [INFO] Changes detected - recompiling the module! [INFO] Compiling 1 source file to https://builds.apache.org/job/sling-contrib-1.6/org.apache.sling$org.apache.sling.launchpad.karaf-integration-tests/ws/target/classes [INFO] [INFO] --- maven-resources-plugin:2.6:testResources (default-testResources) @ org.apache.sling.launchpad.karaf-integration-tests --- [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] skip non existing resourceDirectory https://builds.apache.org/job/sling-contrib-1.6/org.apache.sling$org.apache.sling.launchpad.karaf-integration-tests/ws/src/test/resources [INFO] Copying 3 resources [INFO] [INFO] --- maven-compiler-plugin:3.1:testCompile (default-testCompile) @ org.apache.sling.launchpad.karaf-integration-tests --- [INFO] Changes detected - recompiling the module! [INFO] Compiling 34 source files to https://builds.apache.org/job/sling-contrib-1.6/org.apache.sling$org.apache.sling.launchpad.karaf-integration-tests/ws/target/test-classes [WARNING] Note: https://builds.apache.org/job/sling-contrib-1.6/org.apache.sling$org.apache.sling.launchpad.karaf-integration-tests/ws/src/test/java/org/apache/sling/launchpad/karaf/tests/bootstrap/SlingLaunchpadJackrabbitIT.java uses or overrides a deprecated API. [WARNING] Note: Recompile with -Xlint:deprecation for details. [INFO] [INFO] --- maven-surefire-plugin:2.16:test (default-test) @ org.apache.sling.launchpad.karaf-integration-tests --- [INFO] [INFO] --- animal-sniffer-maven-plugin:1.11:check (default) @ org.apache.sling.launchpad.karaf-integration-tests --- [INFO] Checking unresolved references to org.codehaus.mojo.signature:java15:1.0 [JENKINS] Recording test results [INFO] [INFO] --- maven-bundle-plugin:2.4.0:bundle (default-bundle) @ org.apache.sling.launchpad.karaf-integration-tests --- [INFO] [INFO] --- maven-enforcer-plugin:1.3.1:enforce (enforce-java) @ org.apache.sling.launchpad.karaf-integration-tests --- [INFO] [INFO] --- maven-antrun-plugin:1.7:run (set-bundle-required-execution-environment) @ org.apache.sling.launchpad.karaf-integration-tests --- [INFO] Executing tasks main: [INFO] Executed tasks [WARNING] Failed to getClass for
Build failed in Jenkins: sling-contrib-1.6 #1196
See https://builds.apache.org/job/sling-contrib-1.6/1196/changes Changes: [chetanm] SLING-3814 - Groovy fragment bundle for Commons Log to support scriptable event evaluation Updated readme with details related to ILoggingEvent variable accessible to script -- [...truncated 6389 lines...] [INFO] No primary artifact to install, installing attached artifacts instead. [INFO] Installing https://builds.apache.org/job/sling-contrib-1.6/ws/contrib-1.6/launchpad/karaf/org.apache.sling.launchpad.karaf-features/pom.xml to /home/jenkins/jenkins-slave/maven-repositories/1/org/apache/sling/org.apache.sling.launchpad.karaf-features/0.1.1-SNAPSHOT/org.apache.sling.launchpad.karaf-features-0.1.1-SNAPSHOT.pom [INFO] Installing https://builds.apache.org/job/sling-contrib-1.6/ws/contrib-1.6/launchpad/karaf/org.apache.sling.launchpad.karaf-features/target/feature/feature.xml to /home/jenkins/jenkins-slave/maven-repositories/1/org/apache/sling/org.apache.sling.launchpad.karaf-features/0.1.1-SNAPSHOT/org.apache.sling.launchpad.karaf-features-0.1.1-SNAPSHOT-features.xml [INFO] Installing https://builds.apache.org/job/sling-contrib-1.6/ws/contrib-1.6/launchpad/karaf/org.apache.sling.launchpad.karaf-features/target/org.apache.sling.launchpad.karaf-features-0.1.1-SNAPSHOT-sources.jar to /home/jenkins/jenkins-slave/maven-repositories/1/org/apache/sling/org.apache.sling.launchpad.karaf-features/0.1.1-SNAPSHOT/org.apache.sling.launchpad.karaf-features-0.1.1-SNAPSHOT-sources.jar [JENKINS] Archiving disabled [INFO] [INFO] [INFO] Building Apache Sling Launchpad Karaf - Integration Tests 0.1.1-SNAPSHOT [INFO] Downloading: http://repo.maven.apache.org/maven2/org/apache/sling/org.apache.sling.engine/2.3.4/org.apache.sling.engine-2.3.4.pom Downloaded: http://repo.maven.apache.org/maven2/org/apache/sling/org.apache.sling.engine/2.3.4/org.apache.sling.engine-2.3.4.pom (14 KB at 51.7 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/apache/sling/org.apache.sling.engine/2.3.4/org.apache.sling.engine-2.3.4.jar Downloaded: http://repo.maven.apache.org/maven2/org/apache/sling/org.apache.sling.engine/2.3.4/org.apache.sling.engine-2.3.4.jar (180 KB at 563.5 KB/sec) [INFO] [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ org.apache.sling.launchpad.karaf-integration-tests --- [INFO] [INFO] --- maven-enforcer-plugin:1.3.1:enforce (enforce-java) @ org.apache.sling.launchpad.karaf-integration-tests --- [INFO] [INFO] --- maven-antrun-plugin:1.7:run (set-bundle-required-execution-environment) @ org.apache.sling.launchpad.karaf-integration-tests --- [INFO] Executing tasks main: [INFO] Executed tasks [INFO] [INFO] --- maven-remote-resources-plugin:1.5:process (default) @ org.apache.sling.launchpad.karaf-integration-tests --- [INFO] [INFO] --- maven-resources-plugin:2.6:resources (default-resources) @ org.apache.sling.launchpad.karaf-integration-tests --- [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] skip non existing resourceDirectory https://builds.apache.org/job/sling-contrib-1.6/ws/contrib-1.6/launchpad/karaf/org.apache.sling.launchpad.karaf-integration-tests/src/main/resources [INFO] Copying 3 resources [INFO] [INFO] --- maven-antrun-plugin:1.7:run (check-memory-task) @ org.apache.sling.launchpad.karaf-integration-tests --- [INFO] Executing tasks main: [echo] WARNING (SLING-443/SLING-1782) ** [echo] On most platforms, you'll get OutOfMemoryErrors when building unless you set [echo] on 32bit platforms: MAVEN_OPTS=-Xmx256M -XX:MaxPermSize=256M, see SLING-443 [echo] on 64bit platforms: MAVEN_OPTS=-Xmx512M -XX:MaxPermSize=512M, see SLING-1782 [echo] ** [INFO] Executed tasks [INFO] [INFO] --- maven-compiler-plugin:3.1:compile (default-compile) @ org.apache.sling.launchpad.karaf-integration-tests --- [INFO] Changes detected - recompiling the module! [INFO] Compiling 1 source file to https://builds.apache.org/job/sling-contrib-1.6/ws/contrib-1.6/launchpad/karaf/org.apache.sling.launchpad.karaf-integration-tests/target/classes [INFO] [INFO] --- maven-resources-plugin:2.6:testResources (default-testResources) @ org.apache.sling.launchpad.karaf-integration-tests --- [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] skip non existing resourceDirectory https://builds.apache.org/job/sling-contrib-1.6/ws/contrib-1.6/launchpad/karaf/org.apache.sling.launchpad.karaf-integration-tests/src/test/resources [INFO] Copying 3 resources [INFO] [INFO] --- maven-compiler-plugin:3.1:testCompile (default-testCompile) @ org.apache.sling.launchpad.karaf-integration-tests --- [INFO]
[jira] [Commented] (SLING-3815) Add support for X-Content-Type-Options: nosniff
[ https://issues.apache.org/jira/browse/SLING-3815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14085951#comment-14085951 ] Antonio Sanso commented on SLING-3815: -- [~olli] thanks for the pointer. Is this going to be part of the launchpad? Given the importance of the nosniff (as also suggested in a private conversation with [~fmeschbe]) would be good to have it set in the Sling Main Servlet... (at least the nosniff, and we can use the urlrewriter for the other fields) WDYT? Add support for X-Content-Type-Options: nosniff Key: SLING-3815 URL: https://issues.apache.org/jira/browse/SLING-3815 Project: Sling Issue Type: Improvement Components: Engine Reporter: Antonio Sanso Priority: Minor It would be nice if Sling will have customizable support for X-Content-Type-Options: nosniff . This is really useful to defend against some common attack e.g. XSS, Rosetta Flash etc. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SLING-3815) Add support for X-Content-Type-Options: nosniff
[ https://issues.apache.org/jira/browse/SLING-3815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14085965#comment-14085965 ] Bertrand Delacretaz commented on SLING-3815: Ok with having that in the sling main servlet if we want it turned on most of the time. Still, it's not hard to allow for configuring multiple such static headers there, so I'd make that configuration generic instead of just nosniff, with nosniff included in the defaults. Add support for X-Content-Type-Options: nosniff Key: SLING-3815 URL: https://issues.apache.org/jira/browse/SLING-3815 Project: Sling Issue Type: Improvement Components: Engine Reporter: Antonio Sanso Priority: Minor It would be nice if Sling will have customizable support for X-Content-Type-Options: nosniff . This is really useful to defend against some common attack e.g. XSS, Rosetta Flash etc. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SLING-3290) Long startup time with many vanityPath
[ https://issues.apache.org/jira/browse/SLING-3290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14085969#comment-14085969 ] Antonio Sanso commented on SLING-3290: -- [~cziegeler] I am afraid is not as easy as embedding one single Guava file for the BloomFilter. At the sight [0] contains many other dependencies. [~bdelacretaz] apologies if I did not include unit test for the BloomFilter in my patch (they do exists though). I will include in my next, more precise patch. [0] http://docs.guava-libraries.googlecode.com/git/javadoc/com/google/common/hash/BloomFilter.html Long startup time with many vanityPath -- Key: SLING-3290 URL: https://issues.apache.org/jira/browse/SLING-3290 Project: Sling Issue Type: Improvement Components: ResourceResolver Reporter: Antonio Sanso Assignee: Antonio Sanso Labels: vanity Attachments: SLING-3290-patch.txt, StartupWithManyVanityPath.jpg When many vanityPath or alias are present the system take long time to startup , Same when a vanityPath/alias is removed or updated . The reason behind is the usage of a query that updates the global mapentry. I have added a new Test to the performance test suite and this is the outcome {code} 0 vanityPath 16ms 1 vanityPath 19ms 10 vanityPath 70ms 100 vanityPath111ms 1000 vanityPath 200ms 1 vanityPath 1173ms 3 vanityPath 3358ms {code} -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SLING-3290) Long startup time with many vanityPath
[ https://issues.apache.org/jira/browse/SLING-3290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14085974#comment-14085974 ] Bertrand Delacretaz commented on SLING-3290: @asanso, ok, if there's an automated test I'm ok with integrating that code, thanks! Long startup time with many vanityPath -- Key: SLING-3290 URL: https://issues.apache.org/jira/browse/SLING-3290 Project: Sling Issue Type: Improvement Components: ResourceResolver Reporter: Antonio Sanso Assignee: Antonio Sanso Labels: vanity Attachments: SLING-3290-patch.txt, StartupWithManyVanityPath.jpg When many vanityPath or alias are present the system take long time to startup , Same when a vanityPath/alias is removed or updated . The reason behind is the usage of a query that updates the global mapentry. I have added a new Test to the performance test suite and this is the outcome {code} 0 vanityPath 16ms 1 vanityPath 19ms 10 vanityPath 70ms 100 vanityPath111ms 1000 vanityPath 200ms 1 vanityPath 1173ms 3 vanityPath 3358ms {code} -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SLING-3815) Add support for X-Content-Type-Options: nosniff
[ https://issues.apache.org/jira/browse/SLING-3815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14085970#comment-14085970 ] Antonio Sanso commented on SLING-3815: -- bq. Still, it's not hard to allow for configuring multiple such static headers there, so I'd make that configuration generic instead of just nosniff, with nosniff included in the defaults. +1 Add support for X-Content-Type-Options: nosniff Key: SLING-3815 URL: https://issues.apache.org/jira/browse/SLING-3815 Project: Sling Issue Type: Improvement Components: Engine Reporter: Antonio Sanso Priority: Minor It would be nice if Sling will have customizable support for X-Content-Type-Options: nosniff . This is really useful to defend against some common attack e.g. XSS, Rosetta Flash etc. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (SLING-3290) Long startup time with many vanityPath
[ https://issues.apache.org/jira/browse/SLING-3290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Antonio Sanso updated SLING-3290: - Attachment: BloomFilterUtilsTest attaching test class. again credit goes to [~tmueller] Long startup time with many vanityPath -- Key: SLING-3290 URL: https://issues.apache.org/jira/browse/SLING-3290 Project: Sling Issue Type: Improvement Components: ResourceResolver Reporter: Antonio Sanso Assignee: Antonio Sanso Labels: vanity Attachments: BloomFilterUtilsTest.txt, SLING-3290-patch.txt, StartupWithManyVanityPath.jpg When many vanityPath or alias are present the system take long time to startup , Same when a vanityPath/alias is removed or updated . The reason behind is the usage of a query that updates the global mapentry. I have added a new Test to the performance test suite and this is the outcome {code} 0 vanityPath 16ms 1 vanityPath 19ms 10 vanityPath 70ms 100 vanityPath111ms 1000 vanityPath 200ms 1 vanityPath 1173ms 3 vanityPath 3358ms {code} -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (SLING-3290) Long startup time with many vanityPath
[ https://issues.apache.org/jira/browse/SLING-3290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Antonio Sanso updated SLING-3290: - Attachment: BloomFilterUtilsTest.txt Long startup time with many vanityPath -- Key: SLING-3290 URL: https://issues.apache.org/jira/browse/SLING-3290 Project: Sling Issue Type: Improvement Components: ResourceResolver Reporter: Antonio Sanso Assignee: Antonio Sanso Labels: vanity Attachments: BloomFilterUtilsTest.txt, SLING-3290-patch.txt, StartupWithManyVanityPath.jpg When many vanityPath or alias are present the system take long time to startup , Same when a vanityPath/alias is removed or updated . The reason behind is the usage of a query that updates the global mapentry. I have added a new Test to the performance test suite and this is the outcome {code} 0 vanityPath 16ms 1 vanityPath 19ms 10 vanityPath 70ms 100 vanityPath111ms 1000 vanityPath 200ms 1 vanityPath 1173ms 3 vanityPath 3358ms {code} -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (SLING-3290) Long startup time with many vanityPath
[ https://issues.apache.org/jira/browse/SLING-3290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Antonio Sanso updated SLING-3290: - Attachment: (was: BloomFilterUtilsTest) Long startup time with many vanityPath -- Key: SLING-3290 URL: https://issues.apache.org/jira/browse/SLING-3290 Project: Sling Issue Type: Improvement Components: ResourceResolver Reporter: Antonio Sanso Assignee: Antonio Sanso Labels: vanity Attachments: BloomFilterUtilsTest.txt, SLING-3290-patch.txt, StartupWithManyVanityPath.jpg When many vanityPath or alias are present the system take long time to startup , Same when a vanityPath/alias is removed or updated . The reason behind is the usage of a query that updates the global mapentry. I have added a new Test to the performance test suite and this is the outcome {code} 0 vanityPath 16ms 1 vanityPath 19ms 10 vanityPath 70ms 100 vanityPath111ms 1000 vanityPath 200ms 1 vanityPath 1173ms 3 vanityPath 3358ms {code} -- This message was sent by Atlassian JIRA (v6.2#6252)
Jenkins build is back to stable : sling-trunk-1.7 » Apache Sling Launchpad Testing #733
See https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.launchpad.testing/733/
Jenkins build became unstable: sling-trunk-1.7 » Apache Sling Resource-Based Discovery Service #733
See https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.discovery.impl/733/
Jenkins build is still unstable: sling-trunk-1.7 #733
See https://builds.apache.org/job/sling-trunk-1.7/changes
Jenkins build is still unstable: sling-trunk-1.8 » Apache Sling Resource Resolver #18
See https://builds.apache.org/job/sling-trunk-1.8/org.apache.sling$org.apache.sling.resourceresolver/18/
Jenkins build is still unstable: sling-trunk-1.8 » Apache Sling Launchpad Testing #18
See https://builds.apache.org/job/sling-trunk-1.8/org.apache.sling$org.apache.sling.launchpad.testing/18/
[jira] [Commented] (SLING-3820) Fix replication integration tests after importer/exporter refactoring
[ https://issues.apache.org/jira/browse/SLING-3820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14086042#comment-14086042 ] Tommaso Teofili commented on SLING-3820: patch applied in r1615901, plus a minor fix on wrong local importer name (it was default, it is local), however forward and reverse replication ITs still fail. Fix replication integration tests after importer/exporter refactoring - Key: SLING-3820 URL: https://issues.apache.org/jira/browse/SLING-3820 Project: Sling Issue Type: Bug Components: Extensions Reporter: Marius Petria Labels: replication-testing Attachments: SLING-3820.patch The refactoring in SLING-3816 introduced changes that break replication integration tests. These should be fixed. -- This message was sent by Atlassian JIRA (v6.2#6252)
Jenkins build is still unstable: sling-trunk-1.8 #18
See https://builds.apache.org/job/sling-trunk-1.8/changes
Jenkins build became unstable: sling-trunk-1.6 » Apache Sling Resource-Based Discovery Service #2356
See https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.discovery.impl/2356/
Jenkins build became unstable: sling-trunk-1.6 » Apache Sling Pax Exam Utilities #2356
See https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.paxexam.util/2356/
Jenkins build became unstable: sling-trunk-1.6 » Apache Sling Event Support #2356
See https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.event/2356/changes
[VOTE] Release Apache Sling Eventing 3.3.12
Hi, we fixed 3 issues for this release: https://issues.apache.org/jira/browse/SLING/fixforversion/12326798 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-1087 You can use this UNIX script to download the release and verify the signatures: http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh Usage: sh check_staged_release.sh 1087 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards Regards -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org
Re: [VOTE] Release Apache Sling Eventing 3.3.12
+1 Robert On Tue, Aug 5, 2014 at 3:12 PM, Carsten Ziegeler cziege...@apache.org wrote: Hi, we fixed 3 issues for this release: https://issues.apache.org/jira/browse/SLING/fixforversion/12326798 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-1087 You can use this UNIX script to download the release and verify the signatures: http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh Usage: sh check_staged_release.sh 1087 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards Regards -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org
[jira] [Commented] (SLING-3820) Fix replication integration tests after importer/exporter refactoring
[ https://issues.apache.org/jira/browse/SLING-3820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14086188#comment-14086188 ] Tommaso Teofili commented on SLING-3820: follow up fix in r1615918 Fix replication integration tests after importer/exporter refactoring - Key: SLING-3820 URL: https://issues.apache.org/jira/browse/SLING-3820 Project: Sling Issue Type: Bug Components: Extensions Reporter: Marius Petria Labels: replication-testing Attachments: SLING-3820.patch The refactoring in SLING-3816 introduced changes that break replication integration tests. These should be fixed. -- This message was sent by Atlassian JIRA (v6.2#6252)
Jenkins build is back to stable : sling-trunk-1.7 » Apache Sling Resource-Based Discovery Service #734
See https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.discovery.impl/734/
Jenkins build is back to stable : sling-trunk-1.7 #734
See https://builds.apache.org/job/sling-trunk-1.7/734/changes
Re: [VOTE] Release Apache Sling Eventing 3.3.12
+1 2014-08-05 14:18 GMT+02:00 Robert Munteanu romb...@apache.org: +1 Robert On Tue, Aug 5, 2014 at 3:12 PM, Carsten Ziegeler cziege...@apache.org wrote: Hi, we fixed 3 issues for this release: https://issues.apache.org/jira/browse/SLING/fixforversion/12326798 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-1087 You can use this UNIX script to download the release and verify the signatures: http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh Usage: sh check_staged_release.sh 1087 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards Regards -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org
[jira] [Updated] (SLING-3820) Fix replication integration tests after importer/exporter refactoring
[ https://issues.apache.org/jira/browse/SLING-3820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marius Petria updated SLING-3820: - Attachment: SLING-3820.1.patch Adding a couple more fixes, in particular the vlt package builder should rely on package id primarily. Fix replication integration tests after importer/exporter refactoring - Key: SLING-3820 URL: https://issues.apache.org/jira/browse/SLING-3820 Project: Sling Issue Type: Bug Components: Extensions Reporter: Marius Petria Labels: replication-testing Attachments: SLING-3820.1.patch, SLING-3820.patch The refactoring in SLING-3816 introduced changes that break replication integration tests. These should be fixed. -- This message was sent by Atlassian JIRA (v6.2#6252)
Re: [VOTE] Release Apache Sling Eventing 3.3.12
On Tue, Aug 5, 2014 at 2:12 PM, Carsten Ziegeler cziege...@apache.org wrote: ...Staging repository: https://repository.apache.org/content/repositories/orgapachesling-1087 ... +1, signatures and digests match, build works and contents of the following archive match the corresponding svn tag: MD5 (org.apache.sling.event-3.3.12-source-release.zip) = 1e0a46a92db46d024cfe08ab16a880e2 -Bertrand
[jira] [Commented] (SLING-3820) Fix replication integration tests after importer/exporter refactoring
[ https://issues.apache.org/jira/browse/SLING-3820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14086292#comment-14086292 ] Tommaso Teofili commented on SLING-3820: thanks Marius, patch applied in r1615933 Fix replication integration tests after importer/exporter refactoring - Key: SLING-3820 URL: https://issues.apache.org/jira/browse/SLING-3820 Project: Sling Issue Type: Bug Components: Extensions Reporter: Marius Petria Labels: replication-testing Attachments: SLING-3820.1.patch, SLING-3820.patch The refactoring in SLING-3816 introduced changes that break replication integration tests. These should be fixed. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (SLING-3822) Sling Models Documentation: Please document the separator for Sling-Model-Packages
Konrad Windszus created SLING-3822: -- Summary: Sling Models Documentation: Please document the separator for Sling-Model-Packages Key: SLING-3822 URL: https://issues.apache.org/jira/browse/SLING-3822 Project: Sling Issue Type: New Feature Components: Extensions Affects Versions: Sling Models API 1.0.2 Reporter: Konrad Windszus Currently in http://sling.apache.org/documentation/bundles/models.html there is only an example on how to use the Sling-Model-Packages header. Please add the information, that one may list multiple packages within that header separated by ,. Also please explicitly state that only one such header is allowed per Bundle manifest. -- This message was sent by Atlassian JIRA (v6.2#6252)
Jenkins build is back to stable : sling-trunk-1.6 » Apache Sling Resource-Based Discovery Service #2357
See https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.discovery.impl/2357/
Jenkins build is back to stable : sling-trunk-1.6 » Apache Sling Event Support #2357
See https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.event/2357/
Jenkins build is back to stable : sling-trunk-1.6 » Apache Sling Pax Exam Utilities #2357
See https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.paxexam.util/2357/
[jira] [Commented] (SLING-3709) Sling Models: Allow caller to deal with exceptions
[ https://issues.apache.org/jira/browse/SLING-3709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14086356#comment-14086356 ] Konrad Windszus commented on SLING-3709: Since the discussion at http://www.mail-archive.com/dev@sling.apache.org/msg31261.html did not really come to a conclusion, I am a bit clueless how to proceed here. We urgently need a way to deal with validation errors but obviously I could not convince everyone that adaptTo needs to be extended/modified. I don't think that introducing another mechanism in addition to the adaptTo method only for Sling Models is the right way here because a) adaptTo is already used within Sling Models (e.g. for model composition) b) adaptTo is widely supported by custom tags/extensions in JSP and Sightly Your proposal with wrapping an exception within the adapter does not really work well, because we don't really want to unwrap the exception to see it (that would be very hard to do in Sightly anyways). The approach in http://www.mail-archive.com/dev@sling.apache.org/msg32612.html seems technically feasible but would require a double adaptTo. (not really good because of reasons a) and b) from above) I tend to agree with [~fmeschbe]: ... technically a RuntimeException may always be thrown. (from http://www.mail-archive.com/dev@sling.apache.org/msg31261.html). The problem is backwards-compatibility with that approach. I would still prefer to use adaptTo (for the reasons listed above), but make it configurable whether Sightly throws RuntimeExceptions or not within an OSGi configuration (by default not) and then let the developers decide, whether to use globally either the new behaviour or the old one! If that is not acceptable, then we would need to invent a completely different method of instanciating a Sling Model which right from the beginning allows to throw RuntimeExceptions. The only questions then is how to deal with composed models (injecting one into the other). [~justinedelson] WDYT? Sling Models: Allow caller to deal with exceptions -- Key: SLING-3709 URL: https://issues.apache.org/jira/browse/SLING-3709 Project: Sling Issue Type: Improvement Affects Versions: Sling Models Implementation 1.0.4, Sling Models Implementation 1.0.6 Reporter: Konrad Windszus Currently due to the specification of the adaptTo-method to return null if adaptation is not possible, the caller is not notified about any exceptions (because they are caught within the ModelAdapterFactory). This is e.g. necessary to deal with validation exceptions properly (i.e. required field injection not possible). The problem was also discussed briefly in http://apache-sling.73963.n3.nabble.com/Silng-Models-Validation-Framework-td4033411.html. All exceptions either being thrown by the @PostConstruct method or caused by the field/method injection are not propagated but basically swallowed by Sling Models. It would be great to be able to catch those exceptions either in the view or in a servlet filter. I think it should be possible to throw unchecked exceptions in the ModelAdapterFactory.getFactory() method if it is requested (i.e. through a global OSGi configuration flag for Sling Models). WDYT? Would you accept such a patch or do you think this breaks the API (also compare with https://issues.apache.org/jira/browse/SLING-2712?focusedCommentId=13561516page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13561516). If it does not work through the adaptTo, SlingModels should provide an alternative way of instanciating models (and propagating exceptions), although this is kind of tricky, because it internally relies on adaptTo as well (e.g. in https://github.com/apache/sling/blob/trunk/bundles/extensions/models/impl/src/main/java/org/apache/sling/models/impl/ModelAdapterFactory.java#L647) -- This message was sent by Atlassian JIRA (v6.2#6252)
Jenkins build is still unstable: sling-trunk-1.8 » Apache Sling Launchpad Testing #20
See https://builds.apache.org/job/sling-trunk-1.8/org.apache.sling$org.apache.sling.launchpad.testing/20/
Jenkins build is back to stable : sling-trunk-1.8 » Apache Sling Pax Exam Utilities #20
See https://builds.apache.org/job/sling-trunk-1.8/org.apache.sling$org.apache.sling.paxexam.util/20/
Jenkins build is still unstable: sling-trunk-1.8 » Apache Sling Resource Resolver #20
See https://builds.apache.org/job/sling-trunk-1.8/org.apache.sling$org.apache.sling.resourceresolver/changes
Jenkins build became unstable: sling-trunk-1.8 » Apache Sling Installer Integration Tests #20
See https://builds.apache.org/job/sling-trunk-1.8/org.apache.sling$org.apache.sling.installer.it/20/
Jenkins build is still unstable: sling-trunk-1.8 #20
See https://builds.apache.org/job/sling-trunk-1.8/changes
Build failed in Jenkins: sling-contrib-1.6 » Apache Sling Launchpad Karaf - Integration Tests #1198
See https://builds.apache.org/job/sling-contrib-1.6/org.apache.sling$org.apache.sling.launchpad.karaf-integration-tests/1198/ -- [INFO] [INFO] [INFO] Building Apache Sling Launchpad Karaf - Integration Tests 0.1.1-SNAPSHOT [INFO] [INFO] [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ org.apache.sling.launchpad.karaf-integration-tests --- [INFO] Deleting https://builds.apache.org/job/sling-contrib-1.6/org.apache.sling$org.apache.sling.launchpad.karaf-integration-tests/ws/target [INFO] [INFO] --- maven-enforcer-plugin:1.3.1:enforce (enforce-java) @ org.apache.sling.launchpad.karaf-integration-tests --- [INFO] [INFO] --- maven-antrun-plugin:1.7:run (set-bundle-required-execution-environment) @ org.apache.sling.launchpad.karaf-integration-tests --- [INFO] Executing tasks main: [INFO] Executed tasks [INFO] [INFO] --- maven-remote-resources-plugin:1.5:process (default) @ org.apache.sling.launchpad.karaf-integration-tests --- [INFO] [INFO] --- maven-resources-plugin:2.6:resources (default-resources) @ org.apache.sling.launchpad.karaf-integration-tests --- [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] skip non existing resourceDirectory https://builds.apache.org/job/sling-contrib-1.6/org.apache.sling$org.apache.sling.launchpad.karaf-integration-tests/ws/src/main/resources [INFO] Copying 3 resources [INFO] [INFO] --- maven-antrun-plugin:1.7:run (check-memory-task) @ org.apache.sling.launchpad.karaf-integration-tests --- [INFO] Executing tasks main: [echo] WARNING (SLING-443/SLING-1782) ** [echo] On most platforms, you'll get OutOfMemoryErrors when building unless you set [echo] on 32bit platforms: MAVEN_OPTS=-Xmx256M -XX:MaxPermSize=256M, see SLING-443 [echo] on 64bit platforms: MAVEN_OPTS=-Xmx512M -XX:MaxPermSize=512M, see SLING-1782 [echo] ** [INFO] Executed tasks [INFO] [INFO] --- maven-compiler-plugin:3.1:compile (default-compile) @ org.apache.sling.launchpad.karaf-integration-tests --- [INFO] Changes detected - recompiling the module! [INFO] Compiling 1 source file to https://builds.apache.org/job/sling-contrib-1.6/org.apache.sling$org.apache.sling.launchpad.karaf-integration-tests/ws/target/classes [INFO] [INFO] --- maven-resources-plugin:2.6:testResources (default-testResources) @ org.apache.sling.launchpad.karaf-integration-tests --- [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] skip non existing resourceDirectory https://builds.apache.org/job/sling-contrib-1.6/org.apache.sling$org.apache.sling.launchpad.karaf-integration-tests/ws/src/test/resources [INFO] Copying 3 resources [INFO] [INFO] --- maven-compiler-plugin:3.1:testCompile (default-testCompile) @ org.apache.sling.launchpad.karaf-integration-tests --- [INFO] Changes detected - recompiling the module! [INFO] Compiling 34 source files to https://builds.apache.org/job/sling-contrib-1.6/org.apache.sling$org.apache.sling.launchpad.karaf-integration-tests/ws/target/test-classes [WARNING] Note: https://builds.apache.org/job/sling-contrib-1.6/org.apache.sling$org.apache.sling.launchpad.karaf-integration-tests/ws/src/test/java/org/apache/sling/launchpad/karaf/tests/bootstrap/SlingLaunchpadJackrabbitIT.java uses or overrides a deprecated API. [WARNING] Note: Recompile with -Xlint:deprecation for details. [INFO] [INFO] --- maven-surefire-plugin:2.16:test (default-test) @ org.apache.sling.launchpad.karaf-integration-tests --- [JENKINS] Recording test results[INFO] [INFO] --- animal-sniffer-maven-plugin:1.11:check (default) @ org.apache.sling.launchpad.karaf-integration-tests --- [INFO] Checking unresolved references to org.codehaus.mojo.signature:java15:1.0 [INFO] [INFO] --- maven-bundle-plugin:2.4.0:bundle (default-bundle) @ org.apache.sling.launchpad.karaf-integration-tests --- [INFO] [INFO] --- maven-enforcer-plugin:1.3.1:enforce (enforce-java) @ org.apache.sling.launchpad.karaf-integration-tests --- [INFO] [INFO] --- maven-antrun-plugin:1.7:run (set-bundle-required-execution-environment) @ org.apache.sling.launchpad.karaf-integration-tests --- [INFO] Executing tasks main: [INFO] Executed tasks [WARNING] Failed to getClass for org.apache.maven.plugin.source.SourceJarMojo [INFO] [INFO] --- maven-source-plugin:2.2.1:jar (attach-sources) @ org.apache.sling.launchpad.karaf-integration-tests --- [INFO] Building jar: https://builds.apache.org/job/sling-contrib-1.6/org.apache.sling$org.apache.sling.launchpad.karaf-integration-tests/ws/target/org.apache.sling.launchpad.karaf-integration-tests-0.1.1-SNAPSHOT-sources.jar [INFO] [INFO] ---
Jenkins build is back to stable : sling-contrib-1.6 » Apache Sling Replication Integration Tests #1198
See https://builds.apache.org/job/sling-contrib-1.6/org.apache.sling$org.apache.sling.replication.it/1198/changes
Build failed in Jenkins: sling-contrib-1.6 #1198
See https://builds.apache.org/job/sling-contrib-1.6/1198/changes Changes: [tommaso] SLING-3820 - fixed ITs for forward and reverse replication [tommaso] SLING-3820 - applying Marius Petria's patch for fixing ITs [tommaso] SLING-3820 - minor fixes, temporarily removing jcr package creation from vlt package builder until it's fully working -- [...truncated 3962 lines...] [INFO] [INFO] --- maven-install-plugin:2.5.1:install (default-install) @ org.apache.sling.launchpad.karaf-features --- [INFO] No primary artifact to install, installing attached artifacts instead. [INFO] Installing https://builds.apache.org/job/sling-contrib-1.6/ws/contrib-1.6/launchpad/karaf/org.apache.sling.launchpad.karaf-features/pom.xml to /home/jenkins/jenkins-slave/maven-repositories/1/org/apache/sling/org.apache.sling.launchpad.karaf-features/0.1.1-SNAPSHOT/org.apache.sling.launchpad.karaf-features-0.1.1-SNAPSHOT.pom [INFO] Installing https://builds.apache.org/job/sling-contrib-1.6/ws/contrib-1.6/launchpad/karaf/org.apache.sling.launchpad.karaf-features/target/feature/feature.xml to /home/jenkins/jenkins-slave/maven-repositories/1/org/apache/sling/org.apache.sling.launchpad.karaf-features/0.1.1-SNAPSHOT/org.apache.sling.launchpad.karaf-features-0.1.1-SNAPSHOT-features.xml [INFO] Installing https://builds.apache.org/job/sling-contrib-1.6/ws/contrib-1.6/launchpad/karaf/org.apache.sling.launchpad.karaf-features/target/org.apache.sling.launchpad.karaf-features-0.1.1-SNAPSHOT-sources.jar to /home/jenkins/jenkins-slave/maven-repositories/1/org/apache/sling/org.apache.sling.launchpad.karaf-features/0.1.1-SNAPSHOT/org.apache.sling.launchpad.karaf-features-0.1.1-SNAPSHOT-sources.jar [JENKINS] Archiving disabled [INFO] [INFO] [INFO] Building Apache Sling Launchpad Karaf - Integration Tests 0.1.1-SNAPSHOT [INFO] [INFO] [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ org.apache.sling.launchpad.karaf-integration-tests --- [INFO] Deleting https://builds.apache.org/job/sling-contrib-1.6/ws/contrib-1.6/launchpad/karaf/org.apache.sling.launchpad.karaf-integration-tests/target [INFO] [INFO] --- maven-enforcer-plugin:1.3.1:enforce (enforce-java) @ org.apache.sling.launchpad.karaf-integration-tests --- [INFO] [INFO] --- maven-antrun-plugin:1.7:run (set-bundle-required-execution-environment) @ org.apache.sling.launchpad.karaf-integration-tests --- [INFO] Executing tasks main: [INFO] Executed tasks [INFO] [INFO] --- maven-remote-resources-plugin:1.5:process (default) @ org.apache.sling.launchpad.karaf-integration-tests --- [INFO] [INFO] --- maven-resources-plugin:2.6:resources (default-resources) @ org.apache.sling.launchpad.karaf-integration-tests --- [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] skip non existing resourceDirectory https://builds.apache.org/job/sling-contrib-1.6/ws/contrib-1.6/launchpad/karaf/org.apache.sling.launchpad.karaf-integration-tests/src/main/resources [INFO] Copying 3 resources [INFO] [INFO] --- maven-antrun-plugin:1.7:run (check-memory-task) @ org.apache.sling.launchpad.karaf-integration-tests --- [INFO] Executing tasks main: [echo] WARNING (SLING-443/SLING-1782) ** [echo] On most platforms, you'll get OutOfMemoryErrors when building unless you set [echo] on 32bit platforms: MAVEN_OPTS=-Xmx256M -XX:MaxPermSize=256M, see SLING-443 [echo] on 64bit platforms: MAVEN_OPTS=-Xmx512M -XX:MaxPermSize=512M, see SLING-1782 [echo] ** [INFO] Executed tasks [INFO] [INFO] --- maven-compiler-plugin:3.1:compile (default-compile) @ org.apache.sling.launchpad.karaf-integration-tests --- [INFO] Changes detected - recompiling the module! [INFO] Compiling 1 source file to https://builds.apache.org/job/sling-contrib-1.6/ws/contrib-1.6/launchpad/karaf/org.apache.sling.launchpad.karaf-integration-tests/target/classes [INFO] [INFO] --- maven-resources-plugin:2.6:testResources (default-testResources) @ org.apache.sling.launchpad.karaf-integration-tests --- [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] skip non existing resourceDirectory https://builds.apache.org/job/sling-contrib-1.6/ws/contrib-1.6/launchpad/karaf/org.apache.sling.launchpad.karaf-integration-tests/src/test/resources [INFO] Copying 3 resources [INFO] [INFO] --- maven-compiler-plugin:3.1:testCompile (default-testCompile) @ org.apache.sling.launchpad.karaf-integration-tests --- [INFO] Changes detected - recompiling the module! [INFO] Compiling 34 source files to
Jenkins build is still unstable: sling-oak-it-1.6 » Apache Sling Launchpad Testing #57
See https://builds.apache.org/job/sling-oak-it-1.6/org.apache.sling$org.apache.sling.launchpad.testing/57/
Jenkins build is still unstable: sling-oak-it-1.6 #57
See https://builds.apache.org/job/sling-oak-it-1.6/57/
Jenkins build is still unstable: sling-oak-it-1.6 » Apache Sling Launchpad Testing #58
See https://builds.apache.org/job/sling-oak-it-1.6/org.apache.sling$org.apache.sling.launchpad.testing/58/
Jenkins build is still unstable: sling-oak-it-1.6 #58
See https://builds.apache.org/job/sling-oak-it-1.6/58/
[jira] [Commented] (SLING-3709) Sling Models: Allow caller to deal with exceptions
[ https://issues.apache.org/jira/browse/SLING-3709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14086993#comment-14086993 ] Justin Edelson commented on SLING-3709: --- [~kwin] I'm not sure I understand what you are proposing - how would an AdapterFactory (ModelAdapterFactory in this case) know that it was being invoked from Sightly vs. Java vs. a JSP? By inspecting the call stack? I would be more inclined to introduce a direct method of accessing the ModelAdapterFactory, i.e. a new service interface. This would, to your point, require that the ModelAdapterFactory vary behavior for composed models based on whether or not the child model is adapter by ModelAdapterFactory vs. some other AdapterFactory, but this doesn't strike me as too challenging to implement. Or perhaps this can be skipped and only throw an exception for a single model class (and not children). Sling Models: Allow caller to deal with exceptions -- Key: SLING-3709 URL: https://issues.apache.org/jira/browse/SLING-3709 Project: Sling Issue Type: Improvement Affects Versions: Sling Models Implementation 1.0.4, Sling Models Implementation 1.0.6 Reporter: Konrad Windszus Currently due to the specification of the adaptTo-method to return null if adaptation is not possible, the caller is not notified about any exceptions (because they are caught within the ModelAdapterFactory). This is e.g. necessary to deal with validation exceptions properly (i.e. required field injection not possible). The problem was also discussed briefly in http://apache-sling.73963.n3.nabble.com/Silng-Models-Validation-Framework-td4033411.html. All exceptions either being thrown by the @PostConstruct method or caused by the field/method injection are not propagated but basically swallowed by Sling Models. It would be great to be able to catch those exceptions either in the view or in a servlet filter. I think it should be possible to throw unchecked exceptions in the ModelAdapterFactory.getFactory() method if it is requested (i.e. through a global OSGi configuration flag for Sling Models). WDYT? Would you accept such a patch or do you think this breaks the API (also compare with https://issues.apache.org/jira/browse/SLING-2712?focusedCommentId=13561516page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13561516). If it does not work through the adaptTo, SlingModels should provide an alternative way of instanciating models (and propagating exceptions), although this is kind of tricky, because it internally relies on adaptTo as well (e.g. in https://github.com/apache/sling/blob/trunk/bundles/extensions/models/impl/src/main/java/org/apache/sling/models/impl/ModelAdapterFactory.java#L647) -- This message was sent by Atlassian JIRA (v6.2#6252)