[jira] [Updated] (SLING-4840) Provide an option to disable a set of logger via config
[ https://issues.apache.org/jira/browse/SLING-4840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chetan Mehrotra updated SLING-4840: --- Description: Logsupport Web Console plugin simplifies configuring the loggers with content assist. At times for debugging purpose users routes logs from set of loggers to a specific file. Post debugging these loggers have to be deleted. It would helpful if UI provides an option to turn off the loggers i.e. have the config be there but not applied was: Logsupport Web Console plugin simplifies configuring the loggers with content assist. At times for debugging purpose users routes logs from set of loggers to a specific file. Post debugging these loggers have to be deleted. It would helpful if UI provides an option to turn off the loggers > Provide an option to disable a set of logger via config > --- > > Key: SLING-4840 > URL: https://issues.apache.org/jira/browse/SLING-4840 > Project: Sling > Issue Type: Improvement > Components: Commons >Reporter: Chetan Mehrotra >Assignee: Chetan Mehrotra > Fix For: Commons Log 4.0.4 > > > Logsupport Web Console plugin simplifies configuring the loggers with content > assist. At times for debugging purpose users routes logs from set of loggers > to a specific file. > Post debugging these loggers have to be deleted. It would helpful if UI > provides an option to turn off the loggers i.e. have the config be there but > not applied -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (SLING-4840) Provide an option to disable a set of logger via config
Chetan Mehrotra created SLING-4840: -- Summary: Provide an option to disable a set of logger via config Key: SLING-4840 URL: https://issues.apache.org/jira/browse/SLING-4840 Project: Sling Issue Type: Improvement Components: Commons Reporter: Chetan Mehrotra Assignee: Chetan Mehrotra Fix For: Commons Log 4.0.4 Logsupport Web Console plugin simplifies configuring the loggers with content assist. At times for debugging purpose users routes logs from set of loggers to a specific file. Post debugging these loggers have to be deleted. It would helpful if UI provides an option to turn off the loggers -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (SLING-4839) Allow to configure logger additivity via OSGi Config UI
Chetan Mehrotra created SLING-4839: -- Summary: Allow to configure logger additivity via OSGi Config UI Key: SLING-4839 URL: https://issues.apache.org/jira/browse/SLING-4839 Project: Sling Issue Type: Improvement Components: Commons Affects Versions: Commons Log 4.0.2 Reporter: Chetan Mehrotra Assignee: Chetan Mehrotra Priority: Minor Fix For: Commons Log 4.0.4 While configuring the loggers via OSGi Commons Log sets the additivity to false by default. Due to this logs from those categories are not routed to main error log. This at times causes important exceptions from getting noticed and hence might get missed out. Commons Log does support controlling the additivity via OSGi config but that setting is not exposed in UI. This setting should be exposed via UI -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (SLING-4838) Tests failing if "test.server.url" is not null but blank
[
https://issues.apache.org/jira/browse/SLING-4838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Sedding resolved SLING-4838.
---
Resolution: Fixed
fixed in https://svn.apache.org/r1687810
> Tests failing if "test.server.url" is not null but blank
>
>
> Key: SLING-4838
> URL: https://issues.apache.org/jira/browse/SLING-4838
> Project: Sling
> Issue Type: Bug
> Components: Testing
>Affects Versions: org.apache.sling.testing.tools 1.0.10
>Reporter: Julian Sedding
>Assignee: Julian Sedding
>Priority: Minor
> Fix For: org.apache.sling.testing.tools 1.0.12
>
>
> In SlingTestBase there is a check for whether the system property
> {{test.server.url}} is set or not. It only checks for null but does not take
> into account that it could be blank.
> This leads to integration test failures on Jenkins.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (SLING-4838) Tests failing if "test.server.url" is not null but blank
Julian Sedding created SLING-4838:
-
Summary: Tests failing if "test.server.url" is not null but blank
Key: SLING-4838
URL: https://issues.apache.org/jira/browse/SLING-4838
Project: Sling
Issue Type: Bug
Components: Testing
Affects Versions: org.apache.sling.testing.tools 1.0.10
Reporter: Julian Sedding
Assignee: Julian Sedding
Priority: Minor
Fix For: org.apache.sling.testing.tools 1.0.12
In SlingTestBase there is a check for whether the system property
{{test.server.url}} is set or not. It only checks for null but does not take
into account that it could be blank.
This leads to integration test failures on Jenkins.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Re: [VOTE] Release Apache Sling JCR Resource Resolver 2.5.2
Hi, On Mon, Jun 22, 2015 at 3:26 PM, Bertrand Delacretaz wrote: > ...Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-1279/ ... The vote passes with +1s from Robert, Carsten and myself, and no other votes. I'll take care of promoting the release. -Bertrand
[jira] [Created] (SLING-4837) Resource Editor :: properties page :: add support for property arrays ("multiple" properties)
Sandro Boehme created SLING-4837:
Summary: Resource Editor :: properties page :: add support for
property arrays ("multiple" properties)
Key: SLING-4837
URL: https://issues.apache.org/jira/browse/SLING-4837
Project: Sling
Issue Type: New Feature
Affects Versions: Resource Editor 1.0.2
Reporter: Sandro Boehme
Assignee: Sandro Boehme
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (SLING-4736) Resource Editor :: properties page :: add CRUD for String and prepare for other types
[ https://issues.apache.org/jira/browse/SLING-4736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sandro Boehme resolved SLING-4736. -- Resolution: Fixed o Added crud for String and Path properties o Added path-editor, path-viewer and string-editor tag files o Added e2e tests for the new crud and improved other e2e tests o Added shortcuts and a cheat sheet for properties to explain them o Added bootstrap-notify to notify after saving and deleting properties o Added Glyphicons-halflings icon font for property icons o Manually tested on IE9 o Styles adapted for IE9 o Added toolbar with dropdown for the properties page o Replaced some css colors by variables in less files o Added vertical scrolling to the properties page > Resource Editor :: properties page :: add CRUD for String and prepare for > other types > - > > Key: SLING-4736 > URL: https://issues.apache.org/jira/browse/SLING-4736 > Project: Sling > Issue Type: New Feature >Affects Versions: Resource Editor 1.0.2 >Reporter: Sandro Boehme > > Yay, I can finally start with the editing functionality for the properties > page! -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Build failed in Jenkins: sling-trunk-1.7 #1975
I to have fixed most (all?) of the failures related to rat checks in the main build. There seems to be an error related to the model ITs now, can someone look into it? Thanks, Robert On Fri, 2015-06-26 at 10:23 +, Apache Jenkins Server wrote: > [ERROR] Failed to execute goal org.apache.maven.plugins:maven> > -failsafe-plugin:2.18.1:integration-test (integration-test) on > project > org.apache.sling.models.integration-tests: Execution > integration-test of > goal org.apache.maven.plugins:maven-failsafe> -plugin:2.18.1:integration-test > failed: There was an error in the > forked process > [ERROR] java.lang.AssertionError: Server not ready after 60 seconds, > giving up > [ERROR] at org.junit.Assert.fail(Assert.java:88) > [ERROR] at > org.apache.sling.testing.tools.sling.SlingTestBase.waitForServerReady > (SlingTestBase.java:308) > [ERROR] at > org.apache.sling.testing.tools.sling.SlingTestBase.startServerIfNeede > d(SlingTestBase.java:152) > [ERROR] at > org.apache.sling.testing.tools.sling.SlingTestBase.getServerBaseUrl(S > lingTestBase.java:213) > [ERROR] at > org.apache.sling.models.it.RemoteIT.getJunitServletUrl(RemoteIT.java: > 28) > [ERROR] at > org.apache.sling.junit.remote.testrunner.SlingRemoteTestRunner.maybeE > xecuteTests(SlingRemoteTestRunner.java:95) > [ERROR] at > org.apache.sling.junit.remote.testrunner.SlingRemoteTestRunner.getChi > ldren(SlingRemoteTestRunner.java:138) > [ERROR] at > org.junit.runners.ParentRunner.getFilteredChildren(ParentRunner.java: > 363) > [ERROR] at > org.junit.runners.ParentRunner.getDescription(ParentRunner.java:297) > [ERROR] at org.junit.runners.Suite.describeChild(Suite.java:122) > [ERROR] at org.junit.runners.Suite.describeChild(Suite.java:26) > [ERROR] at > org.junit.runners.ParentRunner.getDescription(ParentRunner.java:298) > [ERROR] at > org.apache.maven.surefire.common.junit4.JUnit4ProviderUtil.createSuit > eDescription(JUnit4ProviderUtil.java:113) > [ERROR] at > org.apache.maven.surefire.junit4.JUnit4Provider.createTestsDescriptio > n(JUnit4Provider.java:257) > [ERROR] at > org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider > .java:124) > [ERROR] at > org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameCla > ssLoader(ForkedBooter.java:203) > [ERROR] at > org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(Fork > edBooter.java:155) > [ERROR] at > org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java: > 103) > [ERROR] -> [Help 1] > [ERROR] > [ERROR] To see the full stack trace of the errors, re-run Maven with > the -e switch. > [ERROR] Re-run Maven using the -X switch to enable full debug > logging. > [ERROR] > [ERROR] For more information about the errors and possible solutions, > please read the following articles: > [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/Plu > ginExecutionException > [ERROR] > [ERROR] After correcting the problems, you can resume the build with > the command > [ERROR] mvn -rf :org.apache.sling.models.integration-tests > channel stopped
[jira] [Comment Edited] (SLING-4835) jacoco-it report missing if maven-failsafe-plugin:argLine is used
[
https://issues.apache.org/jira/browse/SLING-4835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14602681#comment-14602681
]
Bertrand Delacretaz edited comment on SLING-4835 at 6/26/15 10:38 AM:
--
As per http://www.eclemma.org/jacoco/trunk/doc/prepare-agent-mojo.html ("if
your project already uses the argLine") the trick is to set argLine in the pom
properties, so that the jacoco plugin appends to it.
I have fixed this in the contentdetection and contentloader modules, building
with -P jacoco-report now correctly produces 3 reports as per SLING-4760
The downside is that options added to that argLine is now used by both the
surefire and failsafe plugins - if surefire needs a different argLine it will
need to be declared in that plugin's config.
was (Author: bdelacretaz):
As per the trick is to set argLine in the pom properties, so that the jacoco
plugin appends to it.
I have fixed this in the contentdetection and contentloader modules, building
with -P jacoco-report now correctly produces 3 reports as per SLING-4760
The downside is that options added to that argLine is now used by both the
surefire and failsafe plugins - if surefire needs a different argLine it will
need to be declared in that plugin's config.
> jacoco-it report missing if maven-failsafe-plugin:argLine is used
> --
>
> Key: SLING-4835
> URL: https://issues.apache.org/jira/browse/SLING-4835
> Project: Sling
> Issue Type: Bug
> Components: Testing
>Reporter: Bertrand Delacretaz
>Assignee: Bertrand Delacretaz
>Priority: Minor
>
> In {{bundles/commons/contentdetection}} for example, using our parent pom 23,
> the {{target/site/jacoco-it}} report is not generated.
> That's probably because the pom uses the maven-failsafe-plugin {{argLine}}
> setting to set the jvm memory. The jacoco plugin also sets that to activate
> its agent, but I suppose that's ignored as {{argLine}} is already set by the
> pom, so the agent is not activated for the integration tests.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (SLING-4835) jacoco-it report missing if maven-failsafe-plugin:argLine is used
[
https://issues.apache.org/jira/browse/SLING-4835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bertrand Delacretaz resolved SLING-4835.
Resolution: Fixed
As per the trick is to set argLine in the pom properties, so that the jacoco
plugin appends to it.
I have fixed this in the contentdetection and contentloader modules, building
with -P jacoco-report now correctly produces 3 reports as per SLING-4760
The downside is that options added to that argLine is now used by both the
surefire and failsafe plugins - if surefire needs a different argLine it will
need to be declared in that plugin's config.
> jacoco-it report missing if maven-failsafe-plugin:argLine is used
> --
>
> Key: SLING-4835
> URL: https://issues.apache.org/jira/browse/SLING-4835
> Project: Sling
> Issue Type: Bug
> Components: Testing
>Reporter: Bertrand Delacretaz
>Assignee: Bertrand Delacretaz
>Priority: Minor
>
> In {{bundles/commons/contentdetection}} for example, using our parent pom 23,
> the {{target/site/jacoco-it}} report is not generated.
> That's probably because the pom uses the maven-failsafe-plugin {{argLine}}
> setting to set the jvm memory. The jacoco plugin also sets that to activate
> its agent, but I suppose that's ignored as {{argLine}} is already set by the
> pom, so the agent is not activated for the integration tests.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
RE: File extension for sling provisioning files?
>Well, it is just a text file, so txt sounds right. It also means that >a text editor is always associated with it in desktop environments + >IDEs, which is a plus. it required some very special escaping rules esp. in the [configurations] sections (felix config file format conventions, e.g. you have to escape blanks and "=" characters inside string values, although they are already quoted. so every tooling has to exactly know if it is a text file or not. other files like *.json, *.yaml, *.config etc. have special extensions as well, and it's easy to configure your editor to treat them as text. >Would adding a some metadata to the file in the form of comments work? not really, i wanted to avoid to have to parse the file. and i have one scenario i want to set up a template engine with a specific set of escaping rules matching the file type, and i have only the file extension because the content is not generated yet. ok, it's always possible to solve this on this way or the other in the tooling itself. if no one other sees a need we can drop the proposal - but it may become problematic if the format gains more popularity and wider use e.g. in devops tools. stefan
[jira] [Issue Comment Deleted] (SLING-4757) Improve test coverage and add integration tests to the contentdetection module
[ https://issues.apache.org/jira/browse/SLING-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Satya Deep Maheshwari updated SLING-4757: - Comment: was deleted (was: Thanks. That works perfectly!) > Improve test coverage and add integration tests to the contentdetection module > -- > > Key: SLING-4757 > URL: https://issues.apache.org/jira/browse/SLING-4757 > Project: Sling > Issue Type: Improvement > Components: Commons >Reporter: Bertrand Delacretaz >Assignee: Petr Shypila > Attachments: > FileNameExtractorImpl_Injection_failed__ClassNotFoundException.patch, > content-tampering-test.patch, week2-part1-unit-tests.patch, > week2-part2-integration-tests.patch > > > The new SLING-4694 contentdetection module has reasonable test coverage but > there are some gaps, and it's also missing some integration tests to verify > that the services provided by the bundle are correctly made available in an > OSGI environment. > I'll take this opportunity to ask our GSoC student [~petr.shypila] to expand > these tests, as that's a good example of what we're trying to do with his > tests improvement project. > So [~petr.shypila] here's your "mission" ;-) > Buliding bundles/commons/contentdetection with with -Pjacoco-report and > looking at target/site/jacoco/index.html shows that a few things are not > tested. The first step is to add the missing unit tests to improve that, > maybe provide a first patch with just that. > Then, we'd like to add integration tests that start this bundle in an OSGi > environment and verify that the ContentAwareMimeTypeService and > FileNameExtractor services are available and work. No need to duplicate the > unit tests, just verify that the services are here and work in a simple case. > The best way to do this is probably with Pax Exam, the > ResourceBundleProviderIT. is a good example of that and there are other > examples in our codebase if you search for *IT.java files that contain > "pax.exam". > As usual, try to minimize changes to the pom (except for what's directly > related to testing) and to non-test code. > Feel free to ask if you have any questions of course, either here for minor > ones or on the dev list for larger discussions. > [1] > https://svn.apache.org/repos/asf/sling/trunk/bundles/extensions/i18n/src/test/java/org/apache/sling/i18n/it/ResourceBundleProviderIT.java -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-4757) Improve test coverage and add integration tests to the contentdetection module
[ https://issues.apache.org/jira/browse/SLING-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14602582#comment-14602582 ] Satya Deep Maheshwari commented on SLING-4757: -- Thanks. That works perfectly! > Improve test coverage and add integration tests to the contentdetection module > -- > > Key: SLING-4757 > URL: https://issues.apache.org/jira/browse/SLING-4757 > Project: Sling > Issue Type: Improvement > Components: Commons >Reporter: Bertrand Delacretaz >Assignee: Petr Shypila > Attachments: > FileNameExtractorImpl_Injection_failed__ClassNotFoundException.patch, > content-tampering-test.patch, week2-part1-unit-tests.patch, > week2-part2-integration-tests.patch > > > The new SLING-4694 contentdetection module has reasonable test coverage but > there are some gaps, and it's also missing some integration tests to verify > that the services provided by the bundle are correctly made available in an > OSGI environment. > I'll take this opportunity to ask our GSoC student [~petr.shypila] to expand > these tests, as that's a good example of what we're trying to do with his > tests improvement project. > So [~petr.shypila] here's your "mission" ;-) > Buliding bundles/commons/contentdetection with with -Pjacoco-report and > looking at target/site/jacoco/index.html shows that a few things are not > tested. The first step is to add the missing unit tests to improve that, > maybe provide a first patch with just that. > Then, we'd like to add integration tests that start this bundle in an OSGi > environment and verify that the ContentAwareMimeTypeService and > FileNameExtractor services are available and work. No need to duplicate the > unit tests, just verify that the services are here and work in a simple case. > The best way to do this is probably with Pax Exam, the > ResourceBundleProviderIT. is a good example of that and there are other > examples in our codebase if you search for *IT.java files that contain > "pax.exam". > As usual, try to minimize changes to the pom (except for what's directly > related to testing) and to non-test code. > Feel free to ask if you have any questions of course, either here for minor > ones or on the dev list for larger discussions. > [1] > https://svn.apache.org/repos/asf/sling/trunk/bundles/extensions/i18n/src/test/java/org/apache/sling/i18n/it/ResourceBundleProviderIT.java -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-4757) Improve test coverage and add integration tests to the contentdetection module
[ https://issues.apache.org/jira/browse/SLING-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14602581#comment-14602581 ] Satya Deep Maheshwari commented on SLING-4757: -- Thanks. That works perfectly! > Improve test coverage and add integration tests to the contentdetection module > -- > > Key: SLING-4757 > URL: https://issues.apache.org/jira/browse/SLING-4757 > Project: Sling > Issue Type: Improvement > Components: Commons >Reporter: Bertrand Delacretaz >Assignee: Petr Shypila > Attachments: > FileNameExtractorImpl_Injection_failed__ClassNotFoundException.patch, > content-tampering-test.patch, week2-part1-unit-tests.patch, > week2-part2-integration-tests.patch > > > The new SLING-4694 contentdetection module has reasonable test coverage but > there are some gaps, and it's also missing some integration tests to verify > that the services provided by the bundle are correctly made available in an > OSGI environment. > I'll take this opportunity to ask our GSoC student [~petr.shypila] to expand > these tests, as that's a good example of what we're trying to do with his > tests improvement project. > So [~petr.shypila] here's your "mission" ;-) > Buliding bundles/commons/contentdetection with with -Pjacoco-report and > looking at target/site/jacoco/index.html shows that a few things are not > tested. The first step is to add the missing unit tests to improve that, > maybe provide a first patch with just that. > Then, we'd like to add integration tests that start this bundle in an OSGi > environment and verify that the ContentAwareMimeTypeService and > FileNameExtractor services are available and work. No need to duplicate the > unit tests, just verify that the services are here and work in a simple case. > The best way to do this is probably with Pax Exam, the > ResourceBundleProviderIT. is a good example of that and there are other > examples in our codebase if you search for *IT.java files that contain > "pax.exam". > As usual, try to minimize changes to the pom (except for what's directly > related to testing) and to non-test code. > Feel free to ask if you have any questions of course, either here for minor > ones or on the dev list for larger discussions. > [1] > https://svn.apache.org/repos/asf/sling/trunk/bundles/extensions/i18n/src/test/java/org/apache/sling/i18n/it/ResourceBundleProviderIT.java -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (SLING-4757) Improve test coverage and add integration tests to the contentdetection module
[ https://issues.apache.org/jira/browse/SLING-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14602564#comment-14602564 ] Petr Shypila edited comment on SLING-4757 at 6/26/15 8:40 AM: -- Satya, I'm had very same problem. That's how I run build to connect for debug remotely: For IT: mvn verify failsafe:integration-test -Dmaven.failsafe.debug For Unit: mvn test surefire:test -Dmaven.surefire.debug UPD: But as I remember if you debug through Intellij it doesn't see your module sources and tries to decompile source code instead of using existing. In this case you should create an artifact with these sources and show to IDE where they are. Hope it will help you. was (Author: petr.shypila): Satya, I'm had very same problem. That's how I run build to connect for debug remotely: For IT: mvn verify failsafe:integration-test -Dmaven.failsafe.debug For Unit: mvn test surefire:test -Dmaven.surefire.debug > Improve test coverage and add integration tests to the contentdetection module > -- > > Key: SLING-4757 > URL: https://issues.apache.org/jira/browse/SLING-4757 > Project: Sling > Issue Type: Improvement > Components: Commons >Reporter: Bertrand Delacretaz >Assignee: Petr Shypila > Attachments: > FileNameExtractorImpl_Injection_failed__ClassNotFoundException.patch, > content-tampering-test.patch, week2-part1-unit-tests.patch, > week2-part2-integration-tests.patch > > > The new SLING-4694 contentdetection module has reasonable test coverage but > there are some gaps, and it's also missing some integration tests to verify > that the services provided by the bundle are correctly made available in an > OSGI environment. > I'll take this opportunity to ask our GSoC student [~petr.shypila] to expand > these tests, as that's a good example of what we're trying to do with his > tests improvement project. > So [~petr.shypila] here's your "mission" ;-) > Buliding bundles/commons/contentdetection with with -Pjacoco-report and > looking at target/site/jacoco/index.html shows that a few things are not > tested. The first step is to add the missing unit tests to improve that, > maybe provide a first patch with just that. > Then, we'd like to add integration tests that start this bundle in an OSGi > environment and verify that the ContentAwareMimeTypeService and > FileNameExtractor services are available and work. No need to duplicate the > unit tests, just verify that the services are here and work in a simple case. > The best way to do this is probably with Pax Exam, the > ResourceBundleProviderIT. is a good example of that and there are other > examples in our codebase if you search for *IT.java files that contain > "pax.exam". > As usual, try to minimize changes to the pom (except for what's directly > related to testing) and to non-test code. > Feel free to ask if you have any questions of course, either here for minor > ones or on the dev list for larger discussions. > [1] > https://svn.apache.org/repos/asf/sling/trunk/bundles/extensions/i18n/src/test/java/org/apache/sling/i18n/it/ResourceBundleProviderIT.java -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (SLING-4757) Improve test coverage and add integration tests to the contentdetection module
[ https://issues.apache.org/jira/browse/SLING-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14602564#comment-14602564 ] Petr Shypila edited comment on SLING-4757 at 6/26/15 8:35 AM: -- Satya, I'm had very same problem. That's how I run build to connect for debug remotely: For IT: mvn verify failsafe:integration-test -Dmaven.failsafe.debug For Unit: mvn test surefire:test -Dmaven.surefire.debug was (Author: petr.shypila): Satya, I'm had very same problem. That's how I run build to connect to remotely: For IT: mvn verify failsafe:integration-test -Dmaven.failsafe.debug For Unit: mvn test surefire:test -Dmaven.surefire.debug > Improve test coverage and add integration tests to the contentdetection module > -- > > Key: SLING-4757 > URL: https://issues.apache.org/jira/browse/SLING-4757 > Project: Sling > Issue Type: Improvement > Components: Commons >Reporter: Bertrand Delacretaz >Assignee: Petr Shypila > Attachments: > FileNameExtractorImpl_Injection_failed__ClassNotFoundException.patch, > content-tampering-test.patch, week2-part1-unit-tests.patch, > week2-part2-integration-tests.patch > > > The new SLING-4694 contentdetection module has reasonable test coverage but > there are some gaps, and it's also missing some integration tests to verify > that the services provided by the bundle are correctly made available in an > OSGI environment. > I'll take this opportunity to ask our GSoC student [~petr.shypila] to expand > these tests, as that's a good example of what we're trying to do with his > tests improvement project. > So [~petr.shypila] here's your "mission" ;-) > Buliding bundles/commons/contentdetection with with -Pjacoco-report and > looking at target/site/jacoco/index.html shows that a few things are not > tested. The first step is to add the missing unit tests to improve that, > maybe provide a first patch with just that. > Then, we'd like to add integration tests that start this bundle in an OSGi > environment and verify that the ContentAwareMimeTypeService and > FileNameExtractor services are available and work. No need to duplicate the > unit tests, just verify that the services are here and work in a simple case. > The best way to do this is probably with Pax Exam, the > ResourceBundleProviderIT. is a good example of that and there are other > examples in our codebase if you search for *IT.java files that contain > "pax.exam". > As usual, try to minimize changes to the pom (except for what's directly > related to testing) and to non-test code. > Feel free to ask if you have any questions of course, either here for minor > ones or on the dev list for larger discussions. > [1] > https://svn.apache.org/repos/asf/sling/trunk/bundles/extensions/i18n/src/test/java/org/apache/sling/i18n/it/ResourceBundleProviderIT.java -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-4757) Improve test coverage and add integration tests to the contentdetection module
[ https://issues.apache.org/jira/browse/SLING-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14602564#comment-14602564 ] Petr Shypila commented on SLING-4757: - Satya, I'm had very same problem. That's how I run build to connect to remotely: For IT: mvn verify failsafe:integration-test -Dmaven.failsafe.debug For Unit: mvn test surefire:test -Dmaven.surefire.debug > Improve test coverage and add integration tests to the contentdetection module > -- > > Key: SLING-4757 > URL: https://issues.apache.org/jira/browse/SLING-4757 > Project: Sling > Issue Type: Improvement > Components: Commons >Reporter: Bertrand Delacretaz >Assignee: Petr Shypila > Attachments: > FileNameExtractorImpl_Injection_failed__ClassNotFoundException.patch, > content-tampering-test.patch, week2-part1-unit-tests.patch, > week2-part2-integration-tests.patch > > > The new SLING-4694 contentdetection module has reasonable test coverage but > there are some gaps, and it's also missing some integration tests to verify > that the services provided by the bundle are correctly made available in an > OSGI environment. > I'll take this opportunity to ask our GSoC student [~petr.shypila] to expand > these tests, as that's a good example of what we're trying to do with his > tests improvement project. > So [~petr.shypila] here's your "mission" ;-) > Buliding bundles/commons/contentdetection with with -Pjacoco-report and > looking at target/site/jacoco/index.html shows that a few things are not > tested. The first step is to add the missing unit tests to improve that, > maybe provide a first patch with just that. > Then, we'd like to add integration tests that start this bundle in an OSGi > environment and verify that the ContentAwareMimeTypeService and > FileNameExtractor services are available and work. No need to duplicate the > unit tests, just verify that the services are here and work in a simple case. > The best way to do this is probably with Pax Exam, the > ResourceBundleProviderIT. is a good example of that and there are other > examples in our codebase if you search for *IT.java files that contain > "pax.exam". > As usual, try to minimize changes to the pom (except for what's directly > related to testing) and to non-test code. > Feel free to ask if you have any questions of course, either here for minor > ones or on the dev list for larger discussions. > [1] > https://svn.apache.org/repos/asf/sling/trunk/bundles/extensions/i18n/src/test/java/org/apache/sling/i18n/it/ResourceBundleProviderIT.java -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-4757) Improve test coverage and add integration tests to the contentdetection module
[ https://issues.apache.org/jira/browse/SLING-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14602562#comment-14602562 ] Satya Deep Maheshwari commented on SLING-4757: -- And I am unable to execute the test from within the IDE (Intellij) as well as it fails with the same error. > Improve test coverage and add integration tests to the contentdetection module > -- > > Key: SLING-4757 > URL: https://issues.apache.org/jira/browse/SLING-4757 > Project: Sling > Issue Type: Improvement > Components: Commons >Reporter: Bertrand Delacretaz >Assignee: Petr Shypila > Attachments: > FileNameExtractorImpl_Injection_failed__ClassNotFoundException.patch, > content-tampering-test.patch, week2-part1-unit-tests.patch, > week2-part2-integration-tests.patch > > > The new SLING-4694 contentdetection module has reasonable test coverage but > there are some gaps, and it's also missing some integration tests to verify > that the services provided by the bundle are correctly made available in an > OSGI environment. > I'll take this opportunity to ask our GSoC student [~petr.shypila] to expand > these tests, as that's a good example of what we're trying to do with his > tests improvement project. > So [~petr.shypila] here's your "mission" ;-) > Buliding bundles/commons/contentdetection with with -Pjacoco-report and > looking at target/site/jacoco/index.html shows that a few things are not > tested. The first step is to add the missing unit tests to improve that, > maybe provide a first patch with just that. > Then, we'd like to add integration tests that start this bundle in an OSGi > environment and verify that the ContentAwareMimeTypeService and > FileNameExtractor services are available and work. No need to duplicate the > unit tests, just verify that the services are here and work in a simple case. > The best way to do this is probably with Pax Exam, the > ResourceBundleProviderIT. is a good example of that and there are other > examples in our codebase if you search for *IT.java files that contain > "pax.exam". > As usual, try to minimize changes to the pom (except for what's directly > related to testing) and to non-test code. > Feel free to ask if you have any questions of course, either here for minor > ones or on the dev list for larger discussions. > [1] > https://svn.apache.org/repos/asf/sling/trunk/bundles/extensions/i18n/src/test/java/org/apache/sling/i18n/it/ResourceBundleProviderIT.java -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-4757) Improve test coverage and add integration tests to the contentdetection module
[
https://issues.apache.org/jira/browse/SLING-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14602559#comment-14602559
]
Satya Deep Maheshwari commented on SLING-4757:
--
I need to remotely connect to the maven build while its executing the ITs to
debug something I was trying out. By default, surefire forks a different thread
for ITs. In order to be able to connect, I need it to run on the same thread as
the maven build. Please see [1]
The mvn based url (i.e. mvn://...) seems to be related to
{{org.ops4j.pax.url}}
[1] -
http://maven.apache.org/surefire/maven-surefire-plugin/examples/debugging.html
> Improve test coverage and add integration tests to the contentdetection module
> --
>
> Key: SLING-4757
> URL: https://issues.apache.org/jira/browse/SLING-4757
> Project: Sling
> Issue Type: Improvement
> Components: Commons
>Reporter: Bertrand Delacretaz
>Assignee: Petr Shypila
> Attachments:
> FileNameExtractorImpl_Injection_failed__ClassNotFoundException.patch,
> content-tampering-test.patch, week2-part1-unit-tests.patch,
> week2-part2-integration-tests.patch
>
>
> The new SLING-4694 contentdetection module has reasonable test coverage but
> there are some gaps, and it's also missing some integration tests to verify
> that the services provided by the bundle are correctly made available in an
> OSGI environment.
> I'll take this opportunity to ask our GSoC student [~petr.shypila] to expand
> these tests, as that's a good example of what we're trying to do with his
> tests improvement project.
> So [~petr.shypila] here's your "mission" ;-)
> Buliding bundles/commons/contentdetection with with -Pjacoco-report and
> looking at target/site/jacoco/index.html shows that a few things are not
> tested. The first step is to add the missing unit tests to improve that,
> maybe provide a first patch with just that.
> Then, we'd like to add integration tests that start this bundle in an OSGi
> environment and verify that the ContentAwareMimeTypeService and
> FileNameExtractor services are available and work. No need to duplicate the
> unit tests, just verify that the services are here and work in a simple case.
> The best way to do this is probably with Pax Exam, the
> ResourceBundleProviderIT. is a good example of that and there are other
> examples in our codebase if you search for *IT.java files that contain
> "pax.exam".
> As usual, try to minimize changes to the pom (except for what's directly
> related to testing) and to non-test code.
> Feel free to ask if you have any questions of course, either here for minor
> ones or on the dev list for larger discussions.
> [1]
> https://svn.apache.org/repos/asf/sling/trunk/bundles/extensions/i18n/src/test/java/org/apache/sling/i18n/it/ResourceBundleProviderIT.java
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Re: [VOTE] Release Apache Sling Feature Flags 1.0.2
On Fri, 2015-06-26 at 07:43 +, Antonio Sanso wrote: > Please vote to approve this release: +1 Robert
Re: Moving to servlet 3 as the base?
On Fri, Jun 26, 2015 at 9:48 AM, Robert Munteanu wrote: > ...I imagine there might he people running on older versions of these > application servers but 2011-2012 looks recent enough for me to > require it in Sling Definitely, thanks for researching this and +1 to the move. -Bertrand
Re: Moving to servlet 3 as the base?
On Fri, Jun 26, 2015 at 10:16 AM, Bertrand Delacretaz wrote: > On Thu, Jun 25, 2015 at 6:17 PM, Carsten Ziegeler > wrote: >> ...I think 3.0 is now out long enough that we could "upgrade" and require >> 3.0 as the base and get rid of all the special handling... > > Would that work for people running Sling on enterprise application > servers, as opposed to using the embedded Jetty server? > > I'm (luckily) not familiar with those environments but I suppose they > might be slower to provide the latest stuff that more lightweight > environments. For the record, here are the oldest versions of some application servers that support Servlet 3.0: - WebSphere Application Server 8.0 ( Jun 2011 ) - WebLogic Server 12c ( Dec 2011 ) - Tomcat 7 ( Jan 2011 ) - Jetty 8 ( September 2011 ) - JBoss EAP 6 ( June 2012 ) I imagine there might he people running on older versions of these application servers but 2011-2012 looks recent enough for me to require it in Sling. +1 for moving to Servlet 3.0 Robert
Re: [VOTE] Release Apache Sling Feature Flags 1.0.2
+1 regards antonio On Jun 26, 2015, at 9:43 AM, Antonio Sanso wrote: > Hi, > > We solved 1 issue in this release: > https://issues.apache.org/jira/browse/SLING/fixforversion/12326703 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-1283/ > > You can use this UNIX script to download the release and verify the > signatures: > http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh > > Usage: > sh check_staged_release.sh 1283 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours.
[VOTE] Release Apache Sling Feature Flags 1.0.2
Hi, We solved 1 issue in this release: https://issues.apache.org/jira/browse/SLING/fixforversion/12326703 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-1283/ You can use this UNIX script to download the release and verify the signatures: http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh Usage: sh check_staged_release.sh 1283 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours.
[jira] [Resolved] (SLING-4836) Escape output in Apache Sling Feature Flags webconsole plugin
[ https://issues.apache.org/jira/browse/SLING-4836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Antonio Sanso resolved SLING-4836. -- Resolution: Fixed Fix Version/s: Feature Flags 1.0.2 fixed in rev. r1687690 > Escape output in Apache Sling Feature Flags webconsole plugin > - > > Key: SLING-4836 > URL: https://issues.apache.org/jira/browse/SLING-4836 > Project: Sling > Issue Type: Bug > Components: Feature Flags >Reporter: Antonio Sanso >Assignee: Antonio Sanso > Fix For: Feature Flags 1.0.2 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (SLING-4836) Escape output in Apache Sling Feature Flags webconsole plugin
Antonio Sanso created SLING-4836: Summary: Escape output in Apache Sling Feature Flags webconsole plugin Key: SLING-4836 URL: https://issues.apache.org/jira/browse/SLING-4836 Project: Sling Issue Type: Bug Components: Feature Flags Reporter: Antonio Sanso Assignee: Antonio Sanso -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: contentloader module testing
Hi Petr, On Fri, Jun 26, 2015 at 9:16 AM, Petr Shypila wrote: > ...The only problem I have now is JaCoCo report The parent pom 23 is now released, here's what I get for the bundles/commons/contentdetection module for example: $ mvn clean install -P jacoco-report ... $ ls target/site/jacoco-*/index.html target/site/jacoco-merged/index.htmltarget/site/jacoco-unit/index.html The jacoco-it report is missing, I have created SLING-4835 for this, will have a look today. Feel free to comment there if you have ideas or if you can confirm my hypothesis. -Bertrand
[jira] [Created] (SLING-4835) jacoco-it report missing if maven-failsafe-plugin:argLine is used
Bertrand Delacretaz created SLING-4835:
--
Summary: jacoco-it report missing if maven-failsafe-plugin:argLine
is used
Key: SLING-4835
URL: https://issues.apache.org/jira/browse/SLING-4835
Project: Sling
Issue Type: Bug
Components: Testing
Reporter: Bertrand Delacretaz
Assignee: Bertrand Delacretaz
Priority: Minor
In {{bundles/commons/contentdetection}} for example, using our parent pom 23,
the {{target/site/jacoco-it}} report is not generated.
That's probably because the pom uses the maven-failsafe-plugin {{argLine}}
setting to set the jvm memory. The jacoco plugin also sets that to activate its
agent, but I suppose that's ignored as {{argLine}} is already set by the pom,
so the agent is not activated for the integration tests.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Re: Moving to servlet 3 as the base?
On Thu, Jun 25, 2015 at 6:17 PM, Carsten Ziegeler wrote: > ...I think 3.0 is now out long enough that we could "upgrade" and require > 3.0 as the base and get rid of all the special handling... Would that work for people running Sling on enterprise application servers, as opposed to using the embedded Jetty server? I'm (luckily) not familiar with those environments but I suppose they might be slower to provide the latest stuff that more lightweight environments. -Bertrand
Re: contentloader module testing
Hi Bertrand, I finally solved all problems which I had with this integration tests and for now everything is clear for me. Yesterday I was stuck for a while(because of my poor OSGi knowledge), but as I wrote, now everything is fine. So integration tests for this module will be presented. The only problem I have now is JaCoCo report. It looks like it doesn't creates reports for integration tests(Few weeks ago everything was fine). I updated contentloader's parent to 24-SNAPSHOT(I tried 23-SNAPSHOT as well) but it didn't help me. org.apache.sling sling 24-SNAPSHOT org.apache.sling.jcr.contentloader 2.1.11-SNAPSHOT bundle I build module with this command: mvn clean install -Pjacoco-report. 2015-06-25 12:04 GMT+03:00 Bertrand Delacretaz : > Hi Petr, > > On Thu, Jun 25, 2015 at 9:40 AM, Petr Shypila wrote: > > ...I also got a look on other modules under ./bundles and it looks like > engine > > is a very good one, because it's coverage is only 20%(e.g. > resourceresolver > > coverage is 70%) > > Both engine and resourceresolver are good candidates, as they are > critical core bundles. > > I suspect that our launchpad integration tests also cover quite a bit > of those modules, it might be nice to have a look at the aggregate > coverage of (for example) the bundles/engine module based on both its > own tests and on the launchpad/testing tests. > > I did experiment with generating that aggregate launchpad + local > coverage in SLING-1803 (the integration-deploys-jacoco-exec.patch) in > addition to SLING-4760. Once you're mostly done with the contentloader > tests it might be good to look at this - if we can easily get that > aggregate coverage that might help focus your efforts better. That > patch is probably stale but we could reuse the general idea - having > launchpad/testing deploy its coverage data to Maven so that other > modules can merge it with their own coverage. > > > ...I see that most tests are written with > > JMock. Could be there some other useful information for me how to test > this > > module in better way?... > > I've been moving to Mockito lately, the code is more readable than > JMock IMO. If a module has few tests so far you might switch it to > Mockito for consistency. Maybe JMock has also improved in the > meantime. > > -Bertrand >
[jira] [Commented] (SLING-4757) Improve test coverage and add integration tests to the contentdetection module
[ https://issues.apache.org/jira/browse/SLING-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14602494#comment-14602494 ] Petr Shypila commented on SLING-4757: - Same for me. But this error appears on other modules as well(e.g. contentloader). > Improve test coverage and add integration tests to the contentdetection module > -- > > Key: SLING-4757 > URL: https://issues.apache.org/jira/browse/SLING-4757 > Project: Sling > Issue Type: Improvement > Components: Commons >Reporter: Bertrand Delacretaz >Assignee: Petr Shypila > Attachments: > FileNameExtractorImpl_Injection_failed__ClassNotFoundException.patch, > content-tampering-test.patch, week2-part1-unit-tests.patch, > week2-part2-integration-tests.patch > > > The new SLING-4694 contentdetection module has reasonable test coverage but > there are some gaps, and it's also missing some integration tests to verify > that the services provided by the bundle are correctly made available in an > OSGI environment. > I'll take this opportunity to ask our GSoC student [~petr.shypila] to expand > these tests, as that's a good example of what we're trying to do with his > tests improvement project. > So [~petr.shypila] here's your "mission" ;-) > Buliding bundles/commons/contentdetection with with -Pjacoco-report and > looking at target/site/jacoco/index.html shows that a few things are not > tested. The first step is to add the missing unit tests to improve that, > maybe provide a first patch with just that. > Then, we'd like to add integration tests that start this bundle in an OSGi > environment and verify that the ContentAwareMimeTypeService and > FileNameExtractor services are available and work. No need to duplicate the > unit tests, just verify that the services are here and work in a simple case. > The best way to do this is probably with Pax Exam, the > ResourceBundleProviderIT. is a good example of that and there are other > examples in our codebase if you search for *IT.java files that contain > "pax.exam". > As usual, try to minimize changes to the pom (except for what's directly > related to testing) and to non-test code. > Feel free to ask if you have any questions of course, either here for minor > ones or on the dev list for larger discussions. > [1] > https://svn.apache.org/repos/asf/sling/trunk/bundles/extensions/i18n/src/test/java/org/apache/sling/i18n/it/ResourceBundleProviderIT.java -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-4757) Improve test coverage and add integration tests to the contentdetection module
[
https://issues.apache.org/jira/browse/SLING-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14602491#comment-14602491
]
Bertrand Delacretaz commented on SLING-4757:
Yes I get the same error with {{-DforkCount=0}}, probably because the mvn: URL
protocol is not registered correctly in this case.
Why would you need {{-DforkCount=0}} ?
> Improve test coverage and add integration tests to the contentdetection module
> --
>
> Key: SLING-4757
> URL: https://issues.apache.org/jira/browse/SLING-4757
> Project: Sling
> Issue Type: Improvement
> Components: Commons
>Reporter: Bertrand Delacretaz
>Assignee: Petr Shypila
> Attachments:
> FileNameExtractorImpl_Injection_failed__ClassNotFoundException.patch,
> content-tampering-test.patch, week2-part1-unit-tests.patch,
> week2-part2-integration-tests.patch
>
>
> The new SLING-4694 contentdetection module has reasonable test coverage but
> there are some gaps, and it's also missing some integration tests to verify
> that the services provided by the bundle are correctly made available in an
> OSGI environment.
> I'll take this opportunity to ask our GSoC student [~petr.shypila] to expand
> these tests, as that's a good example of what we're trying to do with his
> tests improvement project.
> So [~petr.shypila] here's your "mission" ;-)
> Buliding bundles/commons/contentdetection with with -Pjacoco-report and
> looking at target/site/jacoco/index.html shows that a few things are not
> tested. The first step is to add the missing unit tests to improve that,
> maybe provide a first patch with just that.
> Then, we'd like to add integration tests that start this bundle in an OSGi
> environment and verify that the ContentAwareMimeTypeService and
> FileNameExtractor services are available and work. No need to duplicate the
> unit tests, just verify that the services are here and work in a simple case.
> The best way to do this is probably with Pax Exam, the
> ResourceBundleProviderIT. is a good example of that and there are other
> examples in our codebase if you search for *IT.java files that contain
> "pax.exam".
> As usual, try to minimize changes to the pom (except for what's directly
> related to testing) and to non-test code.
> Feel free to ask if you have any questions of course, either here for minor
> ones or on the dev list for larger discussions.
> [1]
> https://svn.apache.org/repos/asf/sling/trunk/bundles/extensions/i18n/src/test/java/org/apache/sling/i18n/it/ResourceBundleProviderIT.java
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
