[jira] [Commented] (SLING-7575) Define common instructions for bnd-maven-plugin

[Konrad Windszus (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476882#comment-16476882
 ] 

Konrad Windszus commented on SLING-7575:


Obviously bnd developers think differently. I would suggest starting a 
discussion about the automatically added Private-Packages header on their 
mailing list.

> Define common instructions for bnd-maven-plugin
> ---
>
> Key: SLING-7575
> URL: https://issues.apache.org/jira/browse/SLING-7575
> Project: Sling
>  Issue Type: Improvement
>  Components: General
>Affects Versions: Parent 33
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Parent 34
>
>
> Once [https://github.com/bndtools/bnd/issues/2265] is fixed and released in 
> {{bnd-maven-plugin}} 4.0 we should upgrade to that version and make sure to 
> define all the instructions common to all Sling bundles in the parameter 
> {{bnd}} of the parent. Those instructions should include
>  # Bundle-Category: sling
>  # Bundle-Description: ${project.description}
>  # Bundle-DocURL: https://sling.apache.org|https://sling.apache.org/
>  # Bundle-License: Apache License, Version 2.0
>  # Bundle-Vendor: The Apache Software Foundation
>  # -exportcontents: 
> ${removeall;${packages;VERSIONED};${packages;CONDITIONAL}}, this is to by 
> default export all versioned packages, except for the ones which are 
> conditionally included, compare with 
> [https://github.com/bndtools/bnd/issues/2131]
>  # -snapshot: ${tstamp;MMddHHmmssSSS} (compare with 
> [https://www.mail-archive.com/dev@sling.apache.org/msg76177.html])



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Comment Edited] (SLING-7575) Define common instructions for bnd-maven-plugin

[Carsten Ziegeler (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476857#comment-16476857
 ] 

Carsten Ziegeler edited comment on SLING-7575 at 5/16/18 5:28 AM:
--

Why do we add (or not remove) entries to the manifest which have zero meaning?
Private-Package is not an official header, adding it to the manifest make it 
look like it is. I see no point in having it there. Similar with the other 
headers


was (Author: cziegeler):
Why do we add (or not remove) entries to the manifest which have zero meaning?

> Define common instructions for bnd-maven-plugin
> ---
>
> Key: SLING-7575
> URL: https://issues.apache.org/jira/browse/SLING-7575
> Project: Sling
>  Issue Type: Improvement
>  Components: General
>Affects Versions: Parent 33
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Parent 34
>
>
> Once [https://github.com/bndtools/bnd/issues/2265] is fixed and released in 
> {{bnd-maven-plugin}} 4.0 we should upgrade to that version and make sure to 
> define all the instructions common to all Sling bundles in the parameter 
> {{bnd}} of the parent. Those instructions should include
>  # Bundle-Category: sling
>  # Bundle-Description: ${project.description}
>  # Bundle-DocURL: https://sling.apache.org|https://sling.apache.org/
>  # Bundle-License: Apache License, Version 2.0
>  # Bundle-Vendor: The Apache Software Foundation
>  # -exportcontents: 
> ${removeall;${packages;VERSIONED};${packages;CONDITIONAL}}, this is to by 
> default export all versioned packages, except for the ones which are 
> conditionally included, compare with 
> [https://github.com/bndtools/bnd/issues/2131]
>  # -snapshot: ${tstamp;MMddHHmmssSSS} (compare with 
> [https://www.mail-archive.com/dev@sling.apache.org/msg76177.html])



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7575) Define common instructions for bnd-maven-plugin

[Carsten Ziegeler (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476857#comment-16476857
 ] 

Carsten Ziegeler commented on SLING-7575:
-

Why do we add (or not remove) entries to the manifest which have zero meaning?

> Define common instructions for bnd-maven-plugin
> ---
>
> Key: SLING-7575
> URL: https://issues.apache.org/jira/browse/SLING-7575
> Project: Sling
>  Issue Type: Improvement
>  Components: General
>Affects Versions: Parent 33
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Parent 34
>
>
> Once [https://github.com/bndtools/bnd/issues/2265] is fixed and released in 
> {{bnd-maven-plugin}} 4.0 we should upgrade to that version and make sure to 
> define all the instructions common to all Sling bundles in the parameter 
> {{bnd}} of the parent. Those instructions should include
>  # Bundle-Category: sling
>  # Bundle-Description: ${project.description}
>  # Bundle-DocURL: https://sling.apache.org|https://sling.apache.org/
>  # Bundle-License: Apache License, Version 2.0
>  # Bundle-Vendor: The Apache Software Foundation
>  # -exportcontents: 
> ${removeall;${packages;VERSIONED};${packages;CONDITIONAL}}, this is to by 
> default export all versioned packages, except for the ones which are 
> conditionally included, compare with 
> [https://github.com/bndtools/bnd/issues/2131]
>  # -snapshot: ${tstamp;MMddHHmmssSSS} (compare with 
> [https://www.mail-archive.com/dev@sling.apache.org/msg76177.html])



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: [VOTE] Release Apache Sling Servlets Get 2.1.32

[Daniel Klco]

+1

On Tue, May 15, 2018 at 4:25 PM, Jason E Bailey  wrote:

> Hi,
>
> We solved 5 issues in this release:
> https://issues.apache.org/jira/projects/SLING/versions/12343102
>
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-1904/
>
> You can use this UNIX script to download the release and verify the
> signatures:
> https://gitbox.apache.org/repos/asf?p=sling-tooling-
> release.git;a=blob;f=check_staged_release.sh;hb=HEAD
>
> Usage:
> sh check_staged_release.sh 1904 /tmp/sling-staging
>
> Please vote to approve this release:
>
>   [ ] +1 Approve the release
>   [ ]  0 Don't care
>   [ ] -1 Don't release, because ...
>
> This majority vote is open for at least 72 hours.
>
> - Jason
>
>

[jira] [Commented] (SLING-7157) metatype.properties file must not be in OSGI-INF/metatype

[Dan Klco (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476813#comment-16476813
 ] 

Dan Klco commented on SLING-7157:
-

Fixed Form Based Authentication with SLING-7671

> metatype.properties file must not be in OSGI-INF/metatype
> -
>
> Key: SLING-7157
> URL: https://issues.apache.org/jira/browse/SLING-7157
> Project: Sling
>  Issue Type: Bug
>Affects Versions: JCR Web Console 1.0.2, JCR Registration 1.0.2, JCR 
> ClassLoader 3.2.2, Form Based Authentication 1.0.8, Settings 1.3.8, Commons 
> Threads 3.2.6, Auth Core 1.4.0, SLF4J MDC Filter 1.0.0, Authentication XING 
> OAuth 0.0.2, Authentication XING Login 0.0.2, URL Rewriter 0.0.2, DataSource 
> Provider 1.0.4, NoSQL MongoDB Resource Provider 1.1.0, Commons Log 5.0.2, 
> Discovery Impl 1.2.12, Discovery Oak 1.2.18, JCR Davex 1.3.8, JCR Webdav 
> 2.3.8, JCR Installer 3.1.26
>Reporter: Carsten Ziegeler
>Priority: Blocker
> Fix For: JCR Web Console 1.0.4, JCR ClassLoader 3.2.4, Settings 
> 1.3.10, Auth Core 1.4.4, Mongo Resource Provider 1.0.0, Authentication XING 
> OAuth 0.0.4, Authentication XING Login 0.0.4, DataSource Provider 1.0.4, URL 
> Rewriter 0.0.4, Commons Log 5.1.0, Commons Threads 3.2.10, SLF4J MDC Filter 
> 1.0.2, JCR Webdav 2.3.10, JCR Installer 3.1.28, Discovery Impl 1.2.14, 
> Discovery Oak 1.2.24, JCR Davex 1.3.12
>
>
> According to the spec the metatype.properties file must not be inside the 
> OSGI-INF/metatype directory. This is against the spec, so we should move it 
> to OSGI-INF/l10n
> We probably should also upgrade the maven-scr-plugin for this 1.25.0
> I found the following files:
> ./bundles/auth/core/src/main/resources/OSGI-INF/metatype/metatype.properties
> ./bundles/auth/form/src/main/resources/OSGI-INF/metatype/metatype.properties
> ./bundles/commons/log/src/main/resources/OSGI-INF/metatype/metatype.properties
> ./bundles/commons/threads/src/main/resources/OSGI-INF/metatype/metatype.properties
> ./bundles/extensions/discovery/impl/src/main/resources/OSGI-INF/metatype/metatype.properties
> ./bundles/extensions/discovery/oak/src/main/resources/OSGI-INF/metatype/metatype.properties
> ./bundles/extensions/settings/src/main/resources/OSGI-INF/metatype/metatype.properties
> ./bundles/jcr/classloader/src/main/resources/OSGI-INF/metatype/metatype.properties
> ./bundles/jcr/davex/src/main/resources/OSGI-INF/metatype/metatype.properties
> ./bundles/jcr/registration/src/main/resources/OSGI-INF/metatype/metatype.properties
> ./bundles/jcr/webconsole/src/main/resources/OSGI-INF/metatype/metatype.properties
> ./bundles/jcr/webdav/src/main/resources/OSGI-INF/metatype/metatype.properties
> ./contrib/auth/org.apache.sling.auth.xing.login/src/main/resources/OSGI-INF/metatype/metatype.properties
> ./contrib/auth/org.apache.sling.auth.xing.oauth/src/main/resources/OSGI-INF/metatype/metatype.properties
> ./contrib/extensions/datasource/src/main/resources/OSGI-INF/metatype/metatype.properties
> ./contrib/extensions/mongodb/src/main/resources/OSGI-INF/metatype/metatype.properties
> ./contrib/extensions/slf4j-mdc/src/main/resources/OSGI-INF/metatype/metatype.properties
> ./contrib/extensions/startup-filter/src/main/resources/OSGI-INF/metatype/metatype.properties
> ./contrib/extensions/urlrewriter/src/main/resources/OSGI-INF/metatype/metatype.properties
> ./installer/providers/jcr/src/main/resources/OSGI-INF/metatype/metatype.properties
> ./samples/path-based-rtp/src/main/resources/OSGI-INF/metatype/metatype.properties
> ./samples/workspacepicker/src/main/resources/OSGI-INF/metatype/metatype.properties
> ./testing/junit/core/src/main/resources/OSGI-INF/metatype/metatype.properties
> ./testing/junit/healthcheck/src/main/resources/OSGI-INF/metatype/metatype.properties



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (SLING-7671) Switch Form Based Authentication to OSGi annotation

[Dan Klco (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Klco resolved SLING-7671.
-
Resolution: Fixed

Resolved in 
https://github.com/apache/sling-org-apache-sling-auth-form/commit/11555fe32802733b9b9c554f4e3153f5964b80e3

> Switch Form Based Authentication to OSGi annotation 
> 
>
> Key: SLING-7671
> URL: https://issues.apache.org/jira/browse/SLING-7671
> Project: Sling
>  Issue Type: Task
>  Components: Authentication
>Affects Versions: Form Based Authentication 1.0.8
>Reporter: Dan Klco
>Assignee: Dan Klco
>Priority: Minor
> Fix For: Form Based Authentication 1.0.10
>
>
> Switch to official OSGi annotations and resolve SLING-7157



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SLING-7157) metatype.properties file must not be in OSGI-INF/metatype

[Dan Klco (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Klco updated SLING-7157:

Fix Version/s: (was: Form Based Authentication 1.0.10)

> metatype.properties file must not be in OSGI-INF/metatype
> -
>
> Key: SLING-7157
> URL: https://issues.apache.org/jira/browse/SLING-7157
> Project: Sling
>  Issue Type: Bug
>Affects Versions: JCR Web Console 1.0.2, JCR Registration 1.0.2, JCR 
> ClassLoader 3.2.2, Form Based Authentication 1.0.8, Settings 1.3.8, Commons 
> Threads 3.2.6, Auth Core 1.4.0, SLF4J MDC Filter 1.0.0, Authentication XING 
> OAuth 0.0.2, Authentication XING Login 0.0.2, URL Rewriter 0.0.2, DataSource 
> Provider 1.0.4, NoSQL MongoDB Resource Provider 1.1.0, Commons Log 5.0.2, 
> Discovery Impl 1.2.12, Discovery Oak 1.2.18, JCR Davex 1.3.8, JCR Webdav 
> 2.3.8, JCR Installer 3.1.26
>Reporter: Carsten Ziegeler
>Priority: Blocker
> Fix For: JCR Web Console 1.0.4, JCR ClassLoader 3.2.4, Settings 
> 1.3.10, Auth Core 1.4.4, Mongo Resource Provider 1.0.0, Authentication XING 
> OAuth 0.0.4, Authentication XING Login 0.0.4, DataSource Provider 1.0.4, URL 
> Rewriter 0.0.4, Commons Log 5.1.0, Commons Threads 3.2.10, SLF4J MDC Filter 
> 1.0.2, JCR Webdav 2.3.10, JCR Installer 3.1.28, Discovery Impl 1.2.14, 
> Discovery Oak 1.2.24, JCR Davex 1.3.12
>
>
> According to the spec the metatype.properties file must not be inside the 
> OSGI-INF/metatype directory. This is against the spec, so we should move it 
> to OSGI-INF/l10n
> We probably should also upgrade the maven-scr-plugin for this 1.25.0
> I found the following files:
> ./bundles/auth/core/src/main/resources/OSGI-INF/metatype/metatype.properties
> ./bundles/auth/form/src/main/resources/OSGI-INF/metatype/metatype.properties
> ./bundles/commons/log/src/main/resources/OSGI-INF/metatype/metatype.properties
> ./bundles/commons/threads/src/main/resources/OSGI-INF/metatype/metatype.properties
> ./bundles/extensions/discovery/impl/src/main/resources/OSGI-INF/metatype/metatype.properties
> ./bundles/extensions/discovery/oak/src/main/resources/OSGI-INF/metatype/metatype.properties
> ./bundles/extensions/settings/src/main/resources/OSGI-INF/metatype/metatype.properties
> ./bundles/jcr/classloader/src/main/resources/OSGI-INF/metatype/metatype.properties
> ./bundles/jcr/davex/src/main/resources/OSGI-INF/metatype/metatype.properties
> ./bundles/jcr/registration/src/main/resources/OSGI-INF/metatype/metatype.properties
> ./bundles/jcr/webconsole/src/main/resources/OSGI-INF/metatype/metatype.properties
> ./bundles/jcr/webdav/src/main/resources/OSGI-INF/metatype/metatype.properties
> ./contrib/auth/org.apache.sling.auth.xing.login/src/main/resources/OSGI-INF/metatype/metatype.properties
> ./contrib/auth/org.apache.sling.auth.xing.oauth/src/main/resources/OSGI-INF/metatype/metatype.properties
> ./contrib/extensions/datasource/src/main/resources/OSGI-INF/metatype/metatype.properties
> ./contrib/extensions/mongodb/src/main/resources/OSGI-INF/metatype/metatype.properties
> ./contrib/extensions/slf4j-mdc/src/main/resources/OSGI-INF/metatype/metatype.properties
> ./contrib/extensions/startup-filter/src/main/resources/OSGI-INF/metatype/metatype.properties
> ./contrib/extensions/urlrewriter/src/main/resources/OSGI-INF/metatype/metatype.properties
> ./installer/providers/jcr/src/main/resources/OSGI-INF/metatype/metatype.properties
> ./samples/path-based-rtp/src/main/resources/OSGI-INF/metatype/metatype.properties
> ./samples/workspacepicker/src/main/resources/OSGI-INF/metatype/metatype.properties
> ./testing/junit/core/src/main/resources/OSGI-INF/metatype/metatype.properties
> ./testing/junit/healthcheck/src/main/resources/OSGI-INF/metatype/metatype.properties



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (SLING-7671) Switch Form Based Authentication to OSGi annotation

[Dan Klco (JIRA)]

Dan Klco created SLING-7671:
---

 Summary: Switch Form Based Authentication to OSGi annotation 
 Key: SLING-7671
 URL: https://issues.apache.org/jira/browse/SLING-7671
 Project: Sling
  Issue Type: Task
  Components: Authentication
Affects Versions: Form Based Authentication 1.0.8
Reporter: Dan Klco
Assignee: Dan Klco
 Fix For: Form Based Authentication 1.0.10


Switch to official OSGi annotations and resolve SLING-7157



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[VOTE] Release Apache Sling Servlets Get 2.1.32

[Jason E Bailey]

Hi,

We solved 5 issues in this release:
https://issues.apache.org/jira/projects/SLING/versions/12343102

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-1904/

You can use this UNIX script to download the release and verify the signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 1904 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

- Jason

[jira] [Resolved] (SLING-7670) Default JSON Get Servlet provide ISO-8601 formatted date

[Jason E Bailey (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason E Bailey resolved SLING-7670.
---
Resolution: Fixed

> Default JSON Get Servlet provide ISO-8601 formatted date
> 
>
> Key: SLING-7670
> URL: https://issues.apache.org/jira/browse/SLING-7670
> Project: Sling
>  Issue Type: Improvement
>Reporter: Jason E Bailey
>Assignee: Jason E Bailey
>Priority: Major
> Fix For: Servlets Get 2.1.32
>
>
> Default JSON Get Servlet was providing an ECMA formatted date string by 
> default. Changed to ISO-8601 formatted date and added configurations to 
> enable the older format if desired.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SLING-7670) Default JSON Get Servlet provide ISO-8601 formatted date

[Jason E Bailey (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason E Bailey updated SLING-7670:
--
Description: Default JSON Get Servlet was providing an ECMA formatted date 
string by default. Changed to ISO-8601 formatted date and added configurations 
to enable the older format if desired.

> Default JSON Get Servlet provide ISO-8601 formatted date
> 
>
> Key: SLING-7670
> URL: https://issues.apache.org/jira/browse/SLING-7670
> Project: Sling
>  Issue Type: Improvement
>Reporter: Jason E Bailey
>Assignee: Jason E Bailey
>Priority: Major
> Fix For: Servlets Get 2.1.32
>
>
> Default JSON Get Servlet was providing an ECMA formatted date string by 
> default. Changed to ISO-8601 formatted date and added configurations to 
> enable the older format if desired.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (SLING-7670) Default JSON Get Servlet provide ISO-8601 formatted date

[Jason E Bailey (JIRA)]

Jason E Bailey created SLING-7670:
-

 Summary: Default JSON Get Servlet provide ISO-8601 formatted date
 Key: SLING-7670
 URL: https://issues.apache.org/jira/browse/SLING-7670
 Project: Sling
  Issue Type: Improvement
Reporter: Jason E Bailey
Assignee: Jason E Bailey






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SLING-7670) Default JSON Get Servlet provide ISO-8601 formatted date

[Jason E Bailey (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason E Bailey updated SLING-7670:
--
Fix Version/s: Servlets Get 2.1.32

> Default JSON Get Servlet provide ISO-8601 formatted date
> 
>
> Key: SLING-7670
> URL: https://issues.apache.org/jira/browse/SLING-7670
> Project: Sling
>  Issue Type: Improvement
>Reporter: Jason E Bailey
>Assignee: Jason E Bailey
>Priority: Major
> Fix For: Servlets Get 2.1.32
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (SLING-7656) Unit test improvements for Sling Default GET Servlet

[Jason E Bailey (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason E Bailey resolved SLING-7656.
---
Resolution: Fixed

> Unit test improvements for Sling Default GET Servlet
> 
>
> Key: SLING-7656
> URL: https://issues.apache.org/jira/browse/SLING-7656
> Project: Sling
>  Issue Type: Improvement
>  Components: Servlets
>Affects Versions: Servlets Get 2.1.30
>Reporter: Jason E Bailey
>Assignee: Jason E Bailey
>Priority: Major
> Fix For: Servlets Get 2.1.32
>
>
> Unit test cases need to be improved to cover content as well, since the 
> content is being generated with the default GET servlet renderers



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SLING-7656) Unit test improvements for Sling Default GET Servlet

[Jason E Bailey (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason E Bailey updated SLING-7656:
--
Fix Version/s: Servlets Get 2.1.32

> Unit test improvements for Sling Default GET Servlet
> 
>
> Key: SLING-7656
> URL: https://issues.apache.org/jira/browse/SLING-7656
> Project: Sling
>  Issue Type: Improvement
>  Components: Servlets
>Affects Versions: Servlets Get 2.1.30
>Reporter: Jason E Bailey
>Assignee: Jason E Bailey
>Priority: Major
> Fix For: Servlets Get 2.1.32
>
>
> Unit test cases need to be improved to cover content as well, since the 
> content is being generated with the default GET servlet renderers



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (SLING-7625) Refactor Default Get Servlets

[Jason E Bailey (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason E Bailey resolved SLING-7625.
---
Resolution: Fixed

> Refactor Default Get Servlets 
> --
>
> Key: SLING-7625
> URL: https://issues.apache.org/jira/browse/SLING-7625
> Project: Sling
>  Issue Type: Improvement
>  Components: Servlets
>Reporter: Jason E Bailey
>Assignee: Jason E Bailey
>Priority: Major
> Fix For: Servlets Get 2.1.32
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> This started off with an attempt to update the Date rendering and got 
> sidetracked. The majority of changes here are clean up and with all the 
> classes being under an .impl folder there should be no external impact.
> Remove all uses of deprecated API's
> Remove all methods that aren't being used
> Re-organize GET servlets to be in one location
> Rename objects to better represent their purpose
> Reduce memory consumption by removing unnecessary Object creation
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (SLING-7619) Redirect Servlet - consolidate configuration

[Jason E Bailey (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason E Bailey resolved SLING-7619.
---
Resolution: Fixed

> Redirect Servlet - consolidate configuration
> 
>
> Key: SLING-7619
> URL: https://issues.apache.org/jira/browse/SLING-7619
> Project: Sling
>  Issue Type: Improvement
>  Components: Servlets
>Reporter: Jason E Bailey
>Assignee: Jason E Bailey
>Priority: Major
> Fix For: Servlets Get 2.1.32
>
>
> Currently the Redirect Servlet handles a GET for a node with a 
> sling:resourceType of sling:redirect and a .json extension like generic GET 
> request however it does it separately from the the DefaultGetServlets 
> implementation. This then requires a separate configuration for the 
> JSONRendererServlet.
> This modifies the RedirectServlet so that a request it receives with the 
> .json extension is handed off to the DefaultGetServlet for completion. This 
> centralizes the configuration for the json renderer.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Comment Edited] (SLING-7575) Define common instructions for bnd-maven-plugin

[Konrad Windszus (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476448#comment-16476448
 ] 

Konrad Windszus edited comment on SLING-7575 at 5/15/18 8:52 PM:
-

I  think that bnd will always add packages within the bundle to either 
{{Export-Package}} or {{Private-Package}}, so that all packages within the 
bundle are listed in either of those two headers. Although not that useful for 
other bundles, I think the {{Private-Package}} does not do any harm. Why do you 
want to remove non-exported packages from the manifest?


was (Author: kwin):
I  think that bnd will always add packages within the bundle to either 
{{Export-Package}} or {{Private-Package}}, so that all packages within the 
bundle are listed in either of those two instructions. Although not that useful 
for other bundles, I think the Private-Package does not do any harm. Why do you 
want to remove non-exported packages from the manifest?

> Define common instructions for bnd-maven-plugin
> ---
>
> Key: SLING-7575
> URL: https://issues.apache.org/jira/browse/SLING-7575
> Project: Sling
>  Issue Type: Improvement
>  Components: General
>Affects Versions: Parent 33
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Parent 34
>
>
> Once [https://github.com/bndtools/bnd/issues/2265] is fixed and released in 
> {{bnd-maven-plugin}} 4.0 we should upgrade to that version and make sure to 
> define all the instructions common to all Sling bundles in the parameter 
> {{bnd}} of the parent. Those instructions should include
>  # Bundle-Category: sling
>  # Bundle-Description: ${project.description}
>  # Bundle-DocURL: https://sling.apache.org|https://sling.apache.org/
>  # Bundle-License: Apache License, Version 2.0
>  # Bundle-Vendor: The Apache Software Foundation
>  # -exportcontents: 
> ${removeall;${packages;VERSIONED};${packages;CONDITIONAL}}, this is to by 
> default export all versioned packages, except for the ones which are 
> conditionally included, compare with 
> [https://github.com/bndtools/bnd/issues/2131]
>  # -snapshot: ${tstamp;MMddHHmmssSSS} (compare with 
> [https://www.mail-archive.com/dev@sling.apache.org/msg76177.html])



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7575) Define common instructions for bnd-maven-plugin

[Konrad Windszus (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476448#comment-16476448
 ] 

Konrad Windszus commented on SLING-7575:


I  think that bnd will always add packages within the bundle to either 
{{Export-Package}} or {{Private-Package}}, so that all packages within the 
bundle are listed in either of those two instructions. Although not that useful 
for other bundles, I think the Private-Package does not do any harm. Why do you 
want to remove non-exported packages from the manifest?

> Define common instructions for bnd-maven-plugin
> ---
>
> Key: SLING-7575
> URL: https://issues.apache.org/jira/browse/SLING-7575
> Project: Sling
>  Issue Type: Improvement
>  Components: General
>Affects Versions: Parent 33
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Parent 34
>
>
> Once [https://github.com/bndtools/bnd/issues/2265] is fixed and released in 
> {{bnd-maven-plugin}} 4.0 we should upgrade to that version and make sure to 
> define all the instructions common to all Sling bundles in the parameter 
> {{bnd}} of the parent. Those instructions should include
>  # Bundle-Category: sling
>  # Bundle-Description: ${project.description}
>  # Bundle-DocURL: https://sling.apache.org|https://sling.apache.org/
>  # Bundle-License: Apache License, Version 2.0
>  # Bundle-Vendor: The Apache Software Foundation
>  # -exportcontents: 
> ${removeall;${packages;VERSIONED};${packages;CONDITIONAL}}, this is to by 
> default export all versioned packages, except for the ones which are 
> conditionally included, compare with 
> [https://github.com/bndtools/bnd/issues/2131]
>  # -snapshot: ${tstamp;MMddHHmmssSSS} (compare with 
> [https://www.mail-archive.com/dev@sling.apache.org/msg76177.html])



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7575) Define common instructions for bnd-maven-plugin

[Oliver Lietz (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476400#comment-16476400
 ] 

Oliver Lietz commented on SLING-7575:
-

[~kwin], I have to investigate but I guess it's because of {{internal}} in the 
package name and {{-includeresource}} instruction for {{LuceneIndexHelper}}.

> Define common instructions for bnd-maven-plugin
> ---
>
> Key: SLING-7575
> URL: https://issues.apache.org/jira/browse/SLING-7575
> Project: Sling
>  Issue Type: Improvement
>  Components: General
>Affects Versions: Parent 33
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Parent 34
>
>
> Once [https://github.com/bndtools/bnd/issues/2265] is fixed and released in 
> {{bnd-maven-plugin}} 4.0 we should upgrade to that version and make sure to 
> define all the instructions common to all Sling bundles in the parameter 
> {{bnd}} of the parent. Those instructions should include
>  # Bundle-Category: sling
>  # Bundle-Description: ${project.description}
>  # Bundle-DocURL: https://sling.apache.org|https://sling.apache.org/
>  # Bundle-License: Apache License, Version 2.0
>  # Bundle-Vendor: The Apache Software Foundation
>  # -exportcontents: 
> ${removeall;${packages;VERSIONED};${packages;CONDITIONAL}}, this is to by 
> default export all versioned packages, except for the ones which are 
> conditionally included, compare with 
> [https://github.com/bndtools/bnd/issues/2131]
>  # -snapshot: ${tstamp;MMddHHmmssSSS} (compare with 
> [https://www.mail-archive.com/dev@sling.apache.org/msg76177.html])



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7575) Define common instructions for bnd-maven-plugin

[Konrad Windszus (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476397#comment-16476397
 ] 

Konrad Windszus commented on SLING-7575:


[~olli] Do you have some reference by which instructions those headers are 
being generated. At least {{Embed-Dependency}} and {{Embed-Transitive}} are not 
at all within bnd (only maven-bundle-plugin). Both  {{Include-Resource}} and 
{{Private-Package}} are documented in 
https://bnd.bndtools.org/chapters/800-headers.html but I am not sure who adds 
those in the first place for JCR Oak Server 
(https://github.com/apache/sling-org-apache-sling-jcr-oak-server/blob/master/bnd.bnd).

> Define common instructions for bnd-maven-plugin
> ---
>
> Key: SLING-7575
> URL: https://issues.apache.org/jira/browse/SLING-7575
> Project: Sling
>  Issue Type: Improvement
>  Components: General
>Affects Versions: Parent 33
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Parent 34
>
>
> Once [https://github.com/bndtools/bnd/issues/2265] is fixed and released in 
> {{bnd-maven-plugin}} 4.0 we should upgrade to that version and make sure to 
> define all the instructions common to all Sling bundles in the parameter 
> {{bnd}} of the parent. Those instructions should include
>  # Bundle-Category: sling
>  # Bundle-Description: ${project.description}
>  # Bundle-DocURL: https://sling.apache.org|https://sling.apache.org/
>  # Bundle-License: Apache License, Version 2.0
>  # Bundle-Vendor: The Apache Software Foundation
>  # -exportcontents: 
> ${removeall;${packages;VERSIONED};${packages;CONDITIONAL}}, this is to by 
> default export all versioned packages, except for the ones which are 
> conditionally included, compare with 
> [https://github.com/bndtools/bnd/issues/2131]
>  # -snapshot: ${tstamp;MMddHHmmssSSS} (compare with 
> [https://www.mail-archive.com/dev@sling.apache.org/msg76177.html])



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7575) Define common instructions for bnd-maven-plugin

[Oliver Lietz (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476395#comment-16476395
 ] 

Oliver Lietz commented on SLING-7575:
-

bq. AFAIK all those headers are only used in the context of the 
maven-bundle-plugin. They were never interpreted by bnd in any way, and should 
therefore not be used with the bnd-maven-plugin.

First two are from {{maven-bundle-plugin}}, last two are from bnd: 
https://bnd.bndtools.org/chapters/800-headers.html Right?

So this should be fine:
{noformat}
-removeheaders:\
  Include-Resource,\
  Private-Package
{noformat}

> Define common instructions for bnd-maven-plugin
> ---
>
> Key: SLING-7575
> URL: https://issues.apache.org/jira/browse/SLING-7575
> Project: Sling
>  Issue Type: Improvement
>  Components: General
>Affects Versions: Parent 33
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Parent 34
>
>
> Once [https://github.com/bndtools/bnd/issues/2265] is fixed and released in 
> {{bnd-maven-plugin}} 4.0 we should upgrade to that version and make sure to 
> define all the instructions common to all Sling bundles in the parameter 
> {{bnd}} of the parent. Those instructions should include
>  # Bundle-Category: sling
>  # Bundle-Description: ${project.description}
>  # Bundle-DocURL: https://sling.apache.org|https://sling.apache.org/
>  # Bundle-License: Apache License, Version 2.0
>  # Bundle-Vendor: The Apache Software Foundation
>  # -exportcontents: 
> ${removeall;${packages;VERSIONED};${packages;CONDITIONAL}}, this is to by 
> default export all versioned packages, except for the ones which are 
> conditionally included, compare with 
> [https://github.com/bndtools/bnd/issues/2131]
>  # -snapshot: ${tstamp;MMddHHmmssSSS} (compare with 
> [https://www.mail-archive.com/dev@sling.apache.org/msg76177.html])



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7575) Define common instructions for bnd-maven-plugin

[Oliver Lietz (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476389#comment-16476389
 ] 

Oliver Lietz commented on SLING-7575:
-

[~kwin], this instruction removes (in my opinion) unnecessary data from 
{{MANIFEST.MF}} which is added by bnd, e.g. JCR Oak Server bundle without 
{{-removeheaders}} contains:

{noformat}
Private-Package: org.apache.jackrabbit.oak.plugins.index.lucene.util,o
 rg.apache.sling.jcr.oak.server.internal
{noformat}

> Define common instructions for bnd-maven-plugin
> ---
>
> Key: SLING-7575
> URL: https://issues.apache.org/jira/browse/SLING-7575
> Project: Sling
>  Issue Type: Improvement
>  Components: General
>Affects Versions: Parent 33
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Parent 34
>
>
> Once [https://github.com/bndtools/bnd/issues/2265] is fixed and released in 
> {{bnd-maven-plugin}} 4.0 we should upgrade to that version and make sure to 
> define all the instructions common to all Sling bundles in the parameter 
> {{bnd}} of the parent. Those instructions should include
>  # Bundle-Category: sling
>  # Bundle-Description: ${project.description}
>  # Bundle-DocURL: https://sling.apache.org|https://sling.apache.org/
>  # Bundle-License: Apache License, Version 2.0
>  # Bundle-Vendor: The Apache Software Foundation
>  # -exportcontents: 
> ${removeall;${packages;VERSIONED};${packages;CONDITIONAL}}, this is to by 
> default export all versioned packages, except for the ones which are 
> conditionally included, compare with 
> [https://github.com/bndtools/bnd/issues/2131]
>  # -snapshot: ${tstamp;MMddHHmmssSSS} (compare with 
> [https://www.mail-archive.com/dev@sling.apache.org/msg76177.html])



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Comment Edited] (SLING-7575) Define common instructions for bnd-maven-plugin

[Konrad Windszus (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476381#comment-16476381
 ] 

Konrad Windszus edited comment on SLING-7575 at 5/15/18 7:41 PM:
-

[~olli] Why is that instruction necessary? Who adds those headers in the first 
place? AFAIK all those headers are only used in the context of the 
maven-bundle-plugin. They were never interpreted by bnd in any way, and should 
therefore not be used with the bnd-maven-plugin.


was (Author: kwin):
[~olli] Why is that instruction necessary? Who adds those headers in the first 
place?

> Define common instructions for bnd-maven-plugin
> ---
>
> Key: SLING-7575
> URL: https://issues.apache.org/jira/browse/SLING-7575
> Project: Sling
>  Issue Type: Improvement
>  Components: General
>Affects Versions: Parent 33
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Parent 34
>
>
> Once [https://github.com/bndtools/bnd/issues/2265] is fixed and released in 
> {{bnd-maven-plugin}} 4.0 we should upgrade to that version and make sure to 
> define all the instructions common to all Sling bundles in the parameter 
> {{bnd}} of the parent. Those instructions should include
>  # Bundle-Category: sling
>  # Bundle-Description: ${project.description}
>  # Bundle-DocURL: https://sling.apache.org|https://sling.apache.org/
>  # Bundle-License: Apache License, Version 2.0
>  # Bundle-Vendor: The Apache Software Foundation
>  # -exportcontents: 
> ${removeall;${packages;VERSIONED};${packages;CONDITIONAL}}, this is to by 
> default export all versioned packages, except for the ones which are 
> conditionally included, compare with 
> [https://github.com/bndtools/bnd/issues/2131]
>  # -snapshot: ${tstamp;MMddHHmmssSSS} (compare with 
> [https://www.mail-archive.com/dev@sling.apache.org/msg76177.html])



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7575) Define common instructions for bnd-maven-plugin

[Konrad Windszus (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476381#comment-16476381
 ] 

Konrad Windszus commented on SLING-7575:


[~olli] Why is that instruction necessary? Who adds those headers in the first 
place?

> Define common instructions for bnd-maven-plugin
> ---
>
> Key: SLING-7575
> URL: https://issues.apache.org/jira/browse/SLING-7575
> Project: Sling
>  Issue Type: Improvement
>  Components: General
>Affects Versions: Parent 33
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Parent 34
>
>
> Once [https://github.com/bndtools/bnd/issues/2265] is fixed and released in 
> {{bnd-maven-plugin}} 4.0 we should upgrade to that version and make sure to 
> define all the instructions common to all Sling bundles in the parameter 
> {{bnd}} of the parent. Those instructions should include
>  # Bundle-Category: sling
>  # Bundle-Description: ${project.description}
>  # Bundle-DocURL: https://sling.apache.org|https://sling.apache.org/
>  # Bundle-License: Apache License, Version 2.0
>  # Bundle-Vendor: The Apache Software Foundation
>  # -exportcontents: 
> ${removeall;${packages;VERSIONED};${packages;CONDITIONAL}}, this is to by 
> default export all versioned packages, except for the ones which are 
> conditionally included, compare with 
> [https://github.com/bndtools/bnd/issues/2131]
>  # -snapshot: ${tstamp;MMddHHmmssSSS} (compare with 
> [https://www.mail-archive.com/dev@sling.apache.org/msg76177.html])



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7575) Define common instructions for bnd-maven-plugin

[Oliver Lietz (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476378#comment-16476378
 ] 

Oliver Lietz commented on SLING-7575:
-

[~kwin], did you leave out {{-removeheaders}} on purpose?

{noformat}
-removeheaders:\
  Embed-Dependency,\
  Embed-Transitive,\
  Include-Resource,\
  Private-Package
{noformat}

> Define common instructions for bnd-maven-plugin
> ---
>
> Key: SLING-7575
> URL: https://issues.apache.org/jira/browse/SLING-7575
> Project: Sling
>  Issue Type: Improvement
>  Components: General
>Affects Versions: Parent 33
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Parent 34
>
>
> Once [https://github.com/bndtools/bnd/issues/2265] is fixed and released in 
> {{bnd-maven-plugin}} 4.0 we should upgrade to that version and make sure to 
> define all the instructions common to all Sling bundles in the parameter 
> {{bnd}} of the parent. Those instructions should include
>  # Bundle-Category: sling
>  # Bundle-Description: ${project.description}
>  # Bundle-DocURL: https://sling.apache.org|https://sling.apache.org/
>  # Bundle-License: Apache License, Version 2.0
>  # Bundle-Vendor: The Apache Software Foundation
>  # -exportcontents: 
> ${removeall;${packages;VERSIONED};${packages;CONDITIONAL}}, this is to by 
> default export all versioned packages, except for the ones which are 
> conditionally included, compare with 
> [https://github.com/bndtools/bnd/issues/2131]
>  # -snapshot: ${tstamp;MMddHHmmssSSS} (compare with 
> [https://www.mail-archive.com/dev@sling.apache.org/msg76177.html])



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (SLING-7632) Pipe Execution Result should show an error list

[Nicolas Peltier (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier reassigned SLING-7632:
--

Assignee: Nicolas Peltier

> Pipe Execution Result should show an error list
> ---
>
> Key: SLING-7632
> URL: https://issues.apache.org/jira/browse/SLING-7632
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: pipes 2.0.2
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Major
>
> While not breaking the pipe execution at the first issue encountered is 
> important in a production world when a content exception should/could be 
> handled separately. Errors happening are "only" happening on logs. 
> They should be tracked in the execution result as well, with path excerpt, 
> and total #, with same limit as for results. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: [VOTE] Release Apache Sling Dynamic Include 3.1.0

[Daniel Klco]

+1

On Tue, May 15, 2018 at 6:35 AM, Robert Munteanu  wrote:

> On Tue, 2018-05-15 at 11:45 +0200, Bertrand Delacretaz wrote:
> > Please vote to approve this release:
>
> +1
>
> Robert

Re: JSR 305 annotations (nullability)

[Julian Reschke]

On 2018-05-15 17:16, Konrad Windszus wrote:

IMHO migration from JSR-305 to 
https://github.com/spotbugs/spotbugs/tree/release-3.1/spotbugs-annotations/src/main/java/edu/umd/cs/findbugs/annotations
 

 is very painless, because the former evolved from the latter. You only need to 
adjust the package name but the semantics of the annotations are the same. Also it 
has most probably the best tooling/IDE support because those are by far the oldest 
nullability annotations (invented by FindBugs before JSR-305 has even been started). 
Now they are actively maintained by the spotbugs community. I currently fail to see a 
better alternative, but I am open to other suggestions.
Konrad


...the Guava developers seem to have a preference on the ones used by 
the Checker framework. I personally don't care much, as long as we don't 
have to re-do this exercise too soon :-).

Re: JSR 305 annotations (nullability)

[Konrad Windszus]

IMHO migration from JSR-305 to 
https://github.com/spotbugs/spotbugs/tree/release-3.1/spotbugs-annotations/src/main/java/edu/umd/cs/findbugs/annotations
 

 is very painless, because the former evolved from the latter. You only need to 
adjust the package name but the semantics of the annotations are the same. Also 
it has most probably the best tooling/IDE support because those are by far the 
oldest nullability annotations (invented by FindBugs before JSR-305 has even 
been started). Now they are actively maintained by the spotbugs community. I 
currently fail to see a better alternative, but I am open to other suggestions.
Konrad

> On 15. May 2018, at 17:12, Julian Reschke  wrote:
> 
> On 2018-05-15 16:39, Konrad Windszus wrote:
>> There are some ideas in https://issues.apache.org/jira/browse/SLING-7312 
>>  but not yet a solution, 
>> as even the proposed alternative spotbugs-annotations is not yet JSR-305 
>> free (which might be problematic from a licensing point of view). But IMHO 
>> the spotbugs annotations are the best alternative: 
>> https://github.com/spotbugs/spotbugs/tree/release-3.1/spotbugs-annotations/src/main/java/edu/umd/cs/findbugs/annotations
>>  
>> ,
>>  because they are not bound to a specific IDE and are still supported by 
>> spotbugs/findbugs. The only thing I am not sure about is whether SonarQube 
>> natively supports spotbugs-annotations.
>> Konrad
> 
> It seems everybody agrees on the goal to move away, however it's not clear 
> what to move to (see for instance, 
> ).
> 
> Best regards, Julian
> 

Re: JSR 305 annotations (nullability)

[Julian Reschke]

On 2018-05-15 16:39, Konrad Windszus wrote:

There are some ideas in https://issues.apache.org/jira/browse/SLING-7312 
 but not yet a solution, as even 
the proposed alternative spotbugs-annotations is not yet JSR-305 free (which might be 
problematic from a licensing point of view). But IMHO the spotbugs annotations are the best 
alternative: 
https://github.com/spotbugs/spotbugs/tree/release-3.1/spotbugs-annotations/src/main/java/edu/umd/cs/findbugs/annotations
 
,
 because they are not bound to a specific IDE and are still supported by spotbugs/findbugs. 
The only thing I am not sure about is whether SonarQube natively supports 
spotbugs-annotations.
Konrad


It seems everybody agrees on the goal to move away, however it's not 
clear what to move to (see for instance, 
).


Best regards, Julian

[jira] [Comment Edited] (SLING-7312) Java 9 requires javax.annotation to be added to the classpath

[Konrad Windszus (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16457540#comment-16457540
 ] 

Konrad Windszus edited comment on SLING-7312 at 5/15/18 2:54 PM:
-

There are some hints about this in 
https://blog.codefx.org/java/jsr-305-java-9/. Google is considering moving from 
JSR-305 to Spotbugs annotations for that reason 
(https://github.com/google/guava/issues/2960). Oak/Jackrabbit wants to move 
away as well (JCR-4301).


was (Author: kwin):
There are some hints about this in 
https://blog.codefx.org/java/jsr-305-java-9/. Google is considering moving from 
JSR-305 to Spotbugs annotations for that reason 
(https://github.com/google/guava/issues/2960).

> Java 9 requires javax.annotation to be added to the classpath
> -
>
> Key: SLING-7312
> URL: https://issues.apache.org/jira/browse/SLING-7312
> Project: Sling
>  Issue Type: Bug
>  Components: Launchpad
>Reporter: Robert Munteanu
>Priority: Major
> Fix For: Starter 11
>
>
> When running on Java 9 post SLING-7186 startup fails due to the 
> {{javax.annotation}} package no longer being exported by default, e.g.
> {noformat}org.osgi.framework.BundleException: Unable to resolve 
> org.apache.sling.installer.core [2](R 2.0): missing requirement 
> [org.apache.sling.installer.core [2](R 2.0)] osgi.wiring.package; 
> (osgi.wiring.package=javax.annotation) Unresolved requirements: 
> [[org.apache.sling.installer.core [2](R 2.0)] osgi.wiring.package; 
> (osgi.wiring.package=javax.annotation)]
>   at 
> org.apache.felix.framework.Felix.resolveBundleRevision(Felix.java:4149)
>   at org.apache.felix.framework.Felix.startBundle(Felix.java:2119)
>   at org.apache.felix.framework.Felix.setActiveStartLevel(Felix.java:1373)
>   at 
> org.apache.felix.framework.FrameworkStartLevelImpl.run(FrameworkStartLevelImpl.java:308)
>   at java.base/java.lang.Thread.run(Thread.java:844){noformat}
> The interesting part here is that the {{javax.annotation}} classes that are 
> required - for instance {{javax.annotation.CheckForNull}} are _not_ part of 
> the JDK-provided {{javax.annotation}} package, they must come from another 
> jar. In fact, we don't have that Jar deployed in the starter, but instead the 
> JDK provides:
> {noformat}
> Generated.class
> PostConstruct.class
> PreDestroy.class
> Resource.class
> Resources.class
> {noformat}
> In a sense, this is very close to the root cause of SLING-7135 - solving one 
> might solve both but the symptoms are very different so raising it separately.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: JSR 305 annotations (nullability)

[Konrad Windszus]

There are some ideas in https://issues.apache.org/jira/browse/SLING-7312 
 but not yet a solution, as 
even the proposed alternative spotbugs-annotations is not yet JSR-305 free 
(which might be problematic from a licensing point of view). But IMHO the 
spotbugs annotations are the best alternative: 
https://github.com/spotbugs/spotbugs/tree/release-3.1/spotbugs-annotations/src/main/java/edu/umd/cs/findbugs/annotations
 
,
 because they are not bound to a specific IDE and are still supported by 
spotbugs/findbugs. The only thing I am not sure about is whether SonarQube 
natively supports spotbugs-annotations.
Konrad

> On 15. May 2018, at 15:26, Julian Reschke  wrote:
> 
> Hi there,
> 
> does the Sling team have a plan how to move away from the JSR 305 annotations?
> 
> See
> 
> 
> 
> and
> 
> 
> 
> 
> It would probably good to coordinate with Jackrabbit Oak; see 
> ...
> 
> Best regards, Julian

Launchpad minor change PR

[Andrei Dulvac]

Hi everyone,

I think I could merge this PR myself, but I'd appreciate another set of
eyes, considering it's not my area of expertise (even though it's a small
change).
The PR is
https://github.com/apache/sling-org-apache-sling-launchpad-base/pull/3 and
it adds a new SharedConstant to keep the target startlevel + a small change
in the StartupManager.

WDYT?
- Andrei

[GitHub] dulvac opened a new pull request #3: SLING-7669 StartupManager overwrites the frameworkstartlevel property…

[GitBox]

dulvac opened a new pull request #3: SLING-7669 StartupManager overwrites the 
frameworkstartlevel property…
URL: https://github.com/apache/sling-org-apache-sling-launchpad-base/pull/3
 
 
   … and there is no way to retrieve the intended target start level
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Created] (SLING-7669) StartupManager overwrites the frameworkstartlevel property and there is no way to retrieve the intended target start level

[Andrei Dulvac (JIRA)]

Andrei Dulvac created SLING-7669:


 Summary: StartupManager overwrites the frameworkstartlevel 
property and there is no way to retrieve the intended target start level
 Key: SLING-7669
 URL: https://issues.apache.org/jira/browse/SLING-7669
 Project: Sling
  Issue Type: Bug
  Components: Launchpad
Reporter: Andrei Dulvac
Assignee: Andrei Dulvac


In incremental mode, the {{StartupManager}} keeps the target startlevel in a 
private field, but overwrites "org.osgi.framework.startlevel.beginning" (for a 
reason), but leaves no other way to retrieve the "target start level" of the 
application.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (SLING-7668) Add adapterFactory to obtain Authorizable or User from ResourceResolver

[Robert Munteanu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-7668.

Resolution: Fixed

Follow-up fix applied in [commit 
7b3e0a|https://github.com/apache/sling-org-apache-sling-jcr-jackrabbit-usermanager/pull/2/commits/7b3e0a1d997421ab39e315f36d646160ee47897b]

> Add adapterFactory to obtain Authorizable or User from ResourceResolver
> ---
>
> Key: SLING-7668
> URL: https://issues.apache.org/jira/browse/SLING-7668
> Project: Sling
>  Issue Type: Improvement
>  Components: JCR
>Reporter: Dominik Süß
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: JCR Jackrabbit User Manager 2.2.8
>
>  Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> The process to extract the current user from a resourceResolver is currently 
> not obvious in a plain Sling setup (AEM as commercial product has a 
> propietary usermanager providing corresponding functionality) so this ticket 
> is about adding a corresponding adapterFactory to the sling jackrabbit 
> usermanager to hide away the necessary boilerplate code.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: [VOTE] Release Apache Sling Dynamic Include 3.1.0

[Robert Munteanu]

On Tue, 2018-05-15 at 11:45 +0200, Bertrand Delacretaz wrote:
> Please vote to approve this release:

+1

Robert

signature.asc
Description: This is a digitally signed message part

JSR 305 annotations (nullability)

[Julian Reschke]

Hi there,

does the Sling team have a plan how to move away from the JSR 305 
annotations?


See



and




It would probably good to coordinate with Jackrabbit Oak; see 
...


Best regards, Julian

[jira] [Reopened] (SLING-7668) Add adapterFactory to obtain Authorizable or User from ResourceResolver

[Robert Munteanu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu reopened SLING-7668:


Reopening to address the fact that adaption to Authorizable does not work.

> Add adapterFactory to obtain Authorizable or User from ResourceResolver
> ---
>
> Key: SLING-7668
> URL: https://issues.apache.org/jira/browse/SLING-7668
> Project: Sling
>  Issue Type: Improvement
>  Components: JCR
>Reporter: Dominik Süß
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: JCR Jackrabbit User Manager 2.2.8
>
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> The process to extract the current user from a resourceResolver is currently 
> not obvious in a plain Sling setup (AEM as commercial product has a 
> propietary usermanager providing corresponding functionality) so this ticket 
> is about adding a corresponding adapterFactory to the sling jackrabbit 
> usermanager to hide away the necessary boilerplate code.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (SLING-7668) Add adapterFactory to obtain Authorizable or User from ResourceResolver

[Robert Munteanu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-7668.

   Resolution: Fixed
Fix Version/s: JCR Jackrabbit User Manager 2.2.8

Thanks [~dsuess] for your contribution, I've applied it in [commit 
4f7e9929|https://github.com/apache/sling-org-apache-sling-jcr-jackrabbit-usermanager/commit/4f7e992940bb64033d12183eb0da387eaa67a534].

> Add adapterFactory to obtain Authorizable or User from ResourceResolver
> ---
>
> Key: SLING-7668
> URL: https://issues.apache.org/jira/browse/SLING-7668
> Project: Sling
>  Issue Type: Improvement
>  Components: JCR
>Reporter: Dominik Süß
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: JCR Jackrabbit User Manager 2.2.8
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> The process to extract the current user from a resourceResolver is currently 
> not obvious in a plain Sling setup (AEM as commercial product has a 
> propietary usermanager providing corresponding functionality) so this ticket 
> is about adding a corresponding adapterFactory to the sling jackrabbit 
> usermanager to hide away the necessary boilerplate code.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (SLING-7668) Add adapterFactory to obtain Authorizable or User from ResourceResolver

[Robert Munteanu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu reassigned SLING-7668:
--

Assignee: Robert Munteanu

> Add adapterFactory to obtain Authorizable or User from ResourceResolver
> ---
>
> Key: SLING-7668
> URL: https://issues.apache.org/jira/browse/SLING-7668
> Project: Sling
>  Issue Type: Improvement
>  Components: JCR
>Reporter: Dominik Süß
>Assignee: Robert Munteanu
>Priority: Major
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> The process to extract the current user from a resourceResolver is currently 
> not obvious in a plain Sling setup (AEM as commercial product has a 
> propietary usermanager providing corresponding functionality) so this ticket 
> is about adding a corresponding adapterFactory to the sling jackrabbit 
> usermanager to hide away the necessary boilerplate code.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (SLING-7668) Add adapterFactory to obtain Authorizable or User from ResourceResolver

[JIRA]

Dominik Süß created SLING-7668:
--

 Summary: Add adapterFactory to obtain Authorizable or User from 
ResourceResolver
 Key: SLING-7668
 URL: https://issues.apache.org/jira/browse/SLING-7668
 Project: Sling
  Issue Type: Improvement
  Components: JCR
Reporter: Dominik Süß


The process to extract the current user from a resourceResolver is currently 
not obvious in a plain Sling setup (AEM as commercial product has a propietary 
usermanager providing corresponding functionality) so this ticket is about 
adding a corresponding adapterFactory to the sling jackrabbit usermanager to 
hide away the necessary boilerplate code.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: [RESULT] [VOTE] Release Apache Sling Servlet Helpers 1.1.6

[Radu Cotescu]

Done in r26920.

> On 12 May 2018, at 14:13, Jason E Bailey  wrote:
> 
> Can a PMC member please copy this release to the Sling dist directory.

[jira] [Commented] (SLING-7621) Regex path matching in Sling Dynamic Include

[Bertrand Delacretaz (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16475565#comment-16475565
 ] 

Bertrand Delacretaz commented on SLING-7621:


I found some time and started the release vote, for release 3.1.0 as you 
suggested, makes sense as this is new functionality.

I'll close the vote this Friday, it's at

https://lists.apache.org/thread.html/50490391b05988374767caee28d02327e450d9e95b3f0394d13042d5@%3Cdev.sling.apache.org%3E

> Regex path matching in Sling Dynamic Include
> 
>
> Key: SLING-7621
> URL: https://issues.apache.org/jira/browse/SLING-7621
> Project: Sling
>  Issue Type: New Feature
>Affects Versions: Dynamic Include 3.0.0
>Reporter: Marek Krokosinski
>Assignee: Bertrand Delacretaz
>Priority: Major
> Fix For: Dynamic Include 3.1.0
>
>
> In some cases one might want to include external content to a page. Example 
> of such external content are AEM Experience Fragments or Content Fragments, 
> or Zen Garden Snippets.
>  Sometimes such 3rd party content can be categorized into two categories:
>  * not included by SDI - content which should not be included separately (for 
> example when content requires page context)
>  * included by SDI - content which is static, so it can be cached because it 
> does not change often (header, footer), or because it changes once per week 
> and we don't want to invalidate whole cache.
> Example content structure:
>  * /content/my-site/my-micro-site/en_gl/content/fragments/
>  * /content/my-site/my-micro-site/en_gl/content/fragments/cacheable-fragments
> When content is specific to market (by market I mean for example British 
> market, German market etc.), and we would want to include that 3rd party 
> content using SDI, we would have to provide one Sling Dynamic Include 
> configuration per market.
>  As you may know, one site can have 100 or more markets, it means at least 
> 100 configuration for such simple case (and usually, it's not the only one!).
> Solution for this problem is to change the way, how SDI performs check on the 
> path.
>  Currently SDI checks if requested resource path starts from the configured 
> path. 
>  Instead of simple check with startsWith, SDI should support regular 
> expressions, which are much more flexible.
> In the given scenario we would have one simple configuration with path 
> configured to:
> ^/content/my-site/([a-zA-Z-_]+)/([a-z]{2}_[a-z]{2})/content/fragments/cacheable-fragments$
> I have created pull requests which also provides some unit tests for 
> Configuration and ConfigurationWhiteboard classes.
>  
> Pull request: 
> https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/3



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7666) Update sling site documentation for bundle - sling-eventing-and-job-handling

[indra kumar gurjar (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16475545#comment-16475545
 ] 

indra kumar gurjar commented on SLING-7666:
---

[~rombert] Here is the PR - 
[https://github.com/apache/sling-site/pull/14|https://github.com/apache/sling-site/pull/14.]
 . 

> Update sling site documentation for bundle - sling-eventing-and-job-handling
> 
>
> Key: SLING-7666
> URL: https://issues.apache.org/jira/browse/SLING-7666
> Project: Sling
>  Issue Type: Improvement
>  Components: Documentation
>Reporter: indra kumar gurjar
>Priority: Minor
> Attachments: site.patch
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> The sling sling-eventing-and-job-handling bundle documentation doesn't 
> include information of  "JobExecutor" , it describes only "JobConsumer".
> If consumer needs more features like providing progress information or adding 
> more information of the processing, JobExecutor should be implemented. 
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7621) Regex path matching in Sling Dynamic Include

[Bertrand Delacretaz (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16475508#comment-16475508
 ] 

Bertrand Delacretaz commented on SLING-7621:


Sorry, I meant to start this release last week but this fell through the 
cracks...it's on back my list for this week.

> Regex path matching in Sling Dynamic Include
> 
>
> Key: SLING-7621
> URL: https://issues.apache.org/jira/browse/SLING-7621
> Project: Sling
>  Issue Type: New Feature
>Affects Versions: Dynamic Include 3.0.0
>Reporter: Marek Krokosinski
>Assignee: Bertrand Delacretaz
>Priority: Major
> Fix For: Dynamic Include 3.0.2
>
>
> In some cases one might want to include external content to a page. Example 
> of such external content are AEM Experience Fragments or Content Fragments, 
> or Zen Garden Snippets.
>  Sometimes such 3rd party content can be categorized into two categories:
>  * not included by SDI - content which should not be included separately (for 
> example when content requires page context)
>  * included by SDI - content which is static, so it can be cached because it 
> does not change often (header, footer), or because it changes once per week 
> and we don't want to invalidate whole cache.
> Example content structure:
>  * /content/my-site/my-micro-site/en_gl/content/fragments/
>  * /content/my-site/my-micro-site/en_gl/content/fragments/cacheable-fragments
> When content is specific to market (by market I mean for example British 
> market, German market etc.), and we would want to include that 3rd party 
> content using SDI, we would have to provide one Sling Dynamic Include 
> configuration per market.
>  As you may know, one site can have 100 or more markets, it means at least 
> 100 configuration for such simple case (and usually, it's not the only one!).
> Solution for this problem is to change the way, how SDI performs check on the 
> path.
>  Currently SDI checks if requested resource path starts from the configured 
> path. 
>  Instead of simple check with startsWith, SDI should support regular 
> expressions, which are much more flexible.
> In the given scenario we would have one simple configuration with path 
> configured to:
> ^/content/my-site/([a-zA-Z-_]+)/([a-z]{2}_[a-z]{2})/content/fragments/cacheable-fragments$
> I have created pull requests which also provides some unit tests for 
> Configuration and ConfigurationWhiteboard classes.
>  
> Pull request: 
> https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/3



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7621) Regex path matching in Sling Dynamic Include

[Marek Krokosinski (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16475498#comment-16475498
 ] 

Marek Krokosinski commented on SLING-7621:
--

Hi [~bdelacretaz] 

Do you have any information about the status of the release of this ticket? 
Information saying that it won't happen soon would be useful too. Thanks.

 

> Regex path matching in Sling Dynamic Include
> 
>
> Key: SLING-7621
> URL: https://issues.apache.org/jira/browse/SLING-7621
> Project: Sling
>  Issue Type: New Feature
>Affects Versions: Dynamic Include 3.0.0
>Reporter: Marek Krokosinski
>Assignee: Bertrand Delacretaz
>Priority: Major
> Fix For: Dynamic Include 3.0.2
>
>
> In some cases one might want to include external content to a page. Example 
> of such external content are AEM Experience Fragments or Content Fragments, 
> or Zen Garden Snippets.
>  Sometimes such 3rd party content can be categorized into two categories:
>  * not included by SDI - content which should not be included separately (for 
> example when content requires page context)
>  * included by SDI - content which is static, so it can be cached because it 
> does not change often (header, footer), or because it changes once per week 
> and we don't want to invalidate whole cache.
> Example content structure:
>  * /content/my-site/my-micro-site/en_gl/content/fragments/
>  * /content/my-site/my-micro-site/en_gl/content/fragments/cacheable-fragments
> When content is specific to market (by market I mean for example British 
> market, German market etc.), and we would want to include that 3rd party 
> content using SDI, we would have to provide one Sling Dynamic Include 
> configuration per market.
>  As you may know, one site can have 100 or more markets, it means at least 
> 100 configuration for such simple case (and usually, it's not the only one!).
> Solution for this problem is to change the way, how SDI performs check on the 
> path.
>  Currently SDI checks if requested resource path starts from the configured 
> path. 
>  Instead of simple check with startsWith, SDI should support regular 
> expressions, which are much more flexible.
> In the given scenario we would have one simple configuration with path 
> configured to:
> ^/content/my-site/([a-zA-Z-_]+)/([a-z]{2}_[a-z]{2})/content/fragments/cacheable-fragments$
> I have created pull requests which also provides some unit tests for 
> Configuration and ConfigurationWhiteboard classes.
>  
> Pull request: 
> https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/3



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (SLING-7667) Place distribution packages in buckets to support smoothly tens of thousands of packages

[Marius Petria (JIRA)]

Marius Petria created SLING-7667:


 Summary: Place distribution packages in buckets to support 
smoothly tens of thousands of packages
 Key: SLING-7667
 URL: https://issues.apache.org/jira/browse/SLING-7667
 Project: Sling
  Issue Type: Improvement
  Components: Content Distribution
Affects Versions: Content Distribution Core 0.2.10
Reporter: Marius Petria


All distribution packages created 
{{/var/sling/distribution/vlt/packages/data}}. There is a remarkable slowdown 
when there are more than 20k packages in the folder.

We would need to create the packages in buckets to have a more manageable size 
of items in a folder.
Proposal of bucketing:
- one level
- 100 fixed buckets (to avoid bucket deletion and management)
- created on demand

{{.../packages/data/03/packageid}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SLING-7667) Place distribution packages in buckets to support smoothly tens of thousands of packages

[Marius Petria (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marius Petria updated SLING-7667:
-
Description: 
All distribution packages created 
{{/var/sling/distribution/vlt/packages/data}}. There is a remarkable slowdown 
when there are more than 20k packages in the folder.

We would need to create the packages in buckets to have a more manageable size 
of items in a folder.
Proposal of bucketing:
- one level
- 100 fixed buckets (to avoid bucket deletion and management)
- created on demand

{{.../packages/data/03/packageid}}
{{.../packages/data/99/packageid}}

  was:
All distribution packages created 
{{/var/sling/distribution/vlt/packages/data}}. There is a remarkable slowdown 
when there are more than 20k packages in the folder.

We would need to create the packages in buckets to have a more manageable size 
of items in a folder.
Proposal of bucketing:
- one level
- 100 fixed buckets (to avoid bucket deletion and management)
- created on demand

{{.../packages/data/03/packageid}}


> Place distribution packages in buckets to support smoothly tens of thousands 
> of packages
> 
>
> Key: SLING-7667
> URL: https://issues.apache.org/jira/browse/SLING-7667
> Project: Sling
>  Issue Type: Improvement
>  Components: Content Distribution
>Affects Versions: Content Distribution Core 0.2.10
>Reporter: Marius Petria
>Priority: Major
>
> All distribution packages created 
> {{/var/sling/distribution/vlt/packages/data}}. There is a remarkable slowdown 
> when there are more than 20k packages in the folder.
> We would need to create the packages in buckets to have a more manageable 
> size of items in a folder.
> Proposal of bucketing:
> - one level
> - 100 fixed buckets (to avoid bucket deletion and management)
> - created on demand
> {{.../packages/data/03/packageid}}
> {{.../packages/data/99/packageid}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)