[jira] [Commented] (SLING-7980) Minimise Sling HCs to a simple bridge for backwards-compatibility
[ https://issues.apache.org/jira/browse/SLING-7980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16805557#comment-16805557 ] Georg Henzler commented on SLING-7980: -- Added migration guide [44d8cffb3f68|https://gitbox.apache.org/repos/asf?p=sling-site.git;a=commitdiff;h=44d8cffb3f6843d2f79d751a14c00b1b37350022] - see https://sling.apache.org/documentation/bundles/sling-health-check-tool.html and https://sling.apache.org/documentation/bundles/sling-health-check-tool-deprecated.html > Minimise Sling HCs to a simple bridge for backwards-compatibility > - > > Key: SLING-7980 > URL: https://issues.apache.org/jira/browse/SLING-7980 > Project: Sling > Issue Type: Task > Components: Health Check >Reporter: Georg Henzler >Assignee: Georg Henzler >Priority: Major > > Once FELIX-5952 is completed, the Sling HC modules have to be updated to only > bridge to Felix Health Checks. > Steps: > # Release the current API bundle with a fully deprecated API (so everyone > upgrading to the latest version is pointed to a required change) > # Write a migration guide (at top of page page [4] leaving the existing > documentation at the bottom of the page) > # The bundles HC core HC web console are not needed anymore. I would just > empty the repositories for now and link to the migration guide in a README > file [4] > # The bundle HC support is used for Sling specific HC features that don't fit > elsewhere, e.g. the ScriptableHealthCheck that is using the Sling > ScriptEngineManager which is not available in Felix (but normally HCs go into > the module they check, see 5.) > # Adjust all Sling modules that come with HCs to use the new Felix API > # Adjust the sling starter with a setup that will both support the deprecated > Sling API and the new Felix API (using Sling HC API and Felix HC API side by > side with the Felix HC Core achieves exactly that) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-7980) Minimise Sling HCs to a simple bridge for backwards-compatibility
[ https://issues.apache.org/jira/browse/SLING-7980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16805510#comment-16805510 ] Georg Henzler commented on SLING-7980: -- Deprecated all api classes in [fdec4a8999284d8|https://gitbox.apache.org/repos/asf?p=sling-org-apache-sling-hc-api.git;a=commitdiff;h=fdec4a8999284d860a35acf11631f454d54e147e] > Minimise Sling HCs to a simple bridge for backwards-compatibility > - > > Key: SLING-7980 > URL: https://issues.apache.org/jira/browse/SLING-7980 > Project: Sling > Issue Type: Task > Components: Health Check >Reporter: Georg Henzler >Assignee: Georg Henzler >Priority: Major > > Once FELIX-5952 is completed, the Sling HC modules have to be updated to only > bridge to Felix Health Checks. > Steps: > # Release the current API bundle with a fully deprecated API (so everyone > upgrading to the latest version is pointed to a required change) > # Write a migration guide (at top of page page [4] leaving the existing > documentation at the bottom of the page) > # The bundles HC core HC web console are not needed anymore. I would just > empty the repositories for now and link to the migration guide in a README > file [4] > # The bundle HC support is used for Sling specific HC features that don't fit > elsewhere, e.g. the ScriptableHealthCheck that is using the Sling > ScriptEngineManager which is not available in Felix (but normally HCs go into > the module they check, see 5.) > # Adjust all Sling modules that come with HCs to use the new Felix API > # Adjust the sling starter with a setup that will both support the deprecated > Sling API and the new Felix API (using Sling HC API and Felix HC API side by > side with the Felix HC Core achieves exactly that) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SLING-7980) Minimise Sling HCs to a simple bridge for backwards-compatibility
[ https://issues.apache.org/jira/browse/SLING-7980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Georg Henzler updated SLING-7980: - Description: Once FELIX-5952 is completed, the Sling HC modules have to be updated to only bridge to Felix Health Checks. Steps: # Release the current API bundle with a fully deprecated API (so everyone upgrading to the latest version is pointed to a required change) # Write a migration guide (at top of page page [4] leaving the existing documentation at the bottom of the page) # The bundles HC core HC web console are not needed anymore. I would just empty the repositories for now and link to the migration guide in a README file [4] # The bundle HC support is used for Sling specific HC features that don't fit elsewhere, e.g. the ScriptableHealthCheck that is using the Sling ScriptEngineManager which is not available in Felix (but normally HCs go into the module they check, see 5.) # Adjust all Sling modules that come with HCs to use the new Felix API # Adjust the sling starter with a setup that will both support the deprecated Sling API and the new Felix API (using Sling HC API and Felix HC API side by side with the Felix HC Core achieves exactly that) was: Once FELIX-5952 is completed, the Sling HC modules have to be updated to only bridge to Felix Health Checks. Steps: # Release the current API bundle with a fully deprecated API (so everyone upgrading to the latest version is pointed to a required change) # Write a migration guide (replacing most information on page [4]) # The bundles HC core HC web console are not needed anymore. I would just empty the repositories for now and link to the migration guide in a README file [4] # The bundle HC support is used for Sling specific HC features that don't fit elsewhere, e.g. the ScriptableHealthCheck that is using the Sling ScriptEngineManager which is not available in Felix (but normally HCs go into the module they check, see 5.) # Adjust all Sling modules that come with HCs to use the new Felix API # Adjust the sling starter with a setup that will both support the deprecated Sling API and the new Felix API (using Sling HC API and Felix HC API side by side with the Felix HC Core achieves exactly that) > Minimise Sling HCs to a simple bridge for backwards-compatibility > - > > Key: SLING-7980 > URL: https://issues.apache.org/jira/browse/SLING-7980 > Project: Sling > Issue Type: Task > Components: Health Check >Reporter: Georg Henzler >Assignee: Georg Henzler >Priority: Major > > Once FELIX-5952 is completed, the Sling HC modules have to be updated to only > bridge to Felix Health Checks. > Steps: > # Release the current API bundle with a fully deprecated API (so everyone > upgrading to the latest version is pointed to a required change) > # Write a migration guide (at top of page page [4] leaving the existing > documentation at the bottom of the page) > # The bundles HC core HC web console are not needed anymore. I would just > empty the repositories for now and link to the migration guide in a README > file [4] > # The bundle HC support is used for Sling specific HC features that don't fit > elsewhere, e.g. the ScriptableHealthCheck that is using the Sling > ScriptEngineManager which is not available in Felix (but normally HCs go into > the module they check, see 5.) > # Adjust all Sling modules that come with HCs to use the new Felix API > # Adjust the sling starter with a setup that will both support the deprecated > Sling API and the new Felix API (using Sling HC API and Felix HC API side by > side with the Felix HC Core achieves exactly that) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Re: [DISCUSS] Scaling Sling development
Sorry for the late feedback, in general I really like the idea to improve the release process! The wiki states: Many of these must be run by the release manager, since by definition releases are individual acts in the Apache Software Foundation. Isn't pushing a button in Jenkins when you are logged in an individual act? IMHO it would be best to just have one pipeline that you start in Jenkins on master, builds (it's easy with git to have Jenkins commit as a certain user) and stages the release (the private GPG key might be problem, but I'm sure that can be solved somehow) and then sends the [VOTE] email to the mailing list. The votes can be done by simple input elements (that send an email to the mailing list if +1 is voted, -1 can be another button that would also sent that email and abort the pipeline). Having it all in Jenkins would be simpler than a CLI tool (that again needs documentation). Also Jenkins can automatically acknowledge user rights (release start only for committers), it can also count the votes (binding/non-binding) after timeout and promote (or not promote) the release automatically. Just imagine a workflow where - one committer starts the release by just a click in Jenkins on Thursday night - three PMC members vote +1 within an hour (because things had been discussed already) - all these people move on to other tasks - on Sunday, the release pipeline automatically acknowledges the sufficient votes and does everything (including updating the site etc.) that is needed to finish the release I think this would greatly improve productivity :) There are probably reasons why this is not allowed (e.g. the release has to be built on a computer of an individual), but personally (if it is a problem) I think it could even be worthwhile to question these requirements with the ASF board. -Georg On 2019-03-06 14:28, Robert Munteanu wrote: Hi, I have been thinking lately about how we can improve our development process for contributors/developers/release managers. I have listed some issues that I perceived as important with proposed solutions at https://cwiki.apache.org/confluence/display/SLING/Scaling+Sling+Development All comments are welcome: - there are probably pain points I have missed - maybe there are solutions I have overlooked - maybe some pain points are my own and others have solved them :-) Thanks! Robert
Re: [DISCUSS] How to move on with Health Checks in Sling
Hi Robert, On Mon, 2019-03-04 at 17:50 +0100, Georg Henzler wrote: 2. Write a migration guide (replacing most information on page [4]) Maybe the information here should stay and a visible not be added to the page which would point users to the new home. There may be value in maintaining the documentation for users that user the old, Sling, API. This makes sense, so I'd put the migration guide to the top of the page and leave the existing documentation below. -Georg
Re: [DISCUSS] Create new sling repo for org.apache.sling.cli
Hi, I am thinking that this CLI may the the basis for other commands. One which I would benefit personally from would be a code grep ... pull-request list to list all open pull requests, which could be the basis of solving PRB-CONTRIB from [1]. Anyway, org-apache-sling-release-cli sounds OK to me, at least initially, and we can rename it later. so if it is planned to introduce more goals that are non-release-related, I'd prefer to start directly with org-apache-sling-cli. -Georg
[GitHub] [sling-org-apache-sling-jcr-contentloader] rombert commented on issue #1: Sling 8243 - support merge options
rombert commented on issue #1: Sling 8243 - support merge options URL: https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/1#issuecomment-478138626 A SonarQube report for the changes added _only by this pull request_ was generated. Please review it at https://builds.apache.org/job/Sling/job/sling-org-apache-sling-jcr-contentloader/job/PR-1/2/artifact/target/sonar/issues-report/issues-report-light.html This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
RE: [VOTE] Release Apache Testing Sling Mock 2.3.6
+1
[VOTE] Release Apache Testing Sling Mock 2.3.6
Hi, We solved 3 issues in this release: https://issues.apache.org/jira/browse/SLING/fixforversion/12343989 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2060/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2060 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. stefan
Re: [DISCUSS] Create new sling repo for org.apache.sling.cli
Robert, On 3/29/2019 8:59 AM, Robert Munteanu wrote: Hi Ruben, On Fri, 2019-03-29 at 08:13 -0700, Ruben Reusser wrote: Robert, I think as long as the 'maybe help with other stuff' part of your email is true I'd suggest not to use sling.cli Suggestions welcome, I'm not terribly good at naming :-) maybe sling.dc (sling developer companion) for things that are relevant to the work a sling developer does? On a separate note, for the sling based peregrine-cms we chose to use nodejs for the cli [1] to lower the entry barrier a bit That's interesting. I briefly considered using something like go which seems better suited for CLI tools ... but ended up deciding for something familiar. How did you find node for writing CLI tools? writing cli tools with node is in fact very simple and straight forward as most nodejs based frameworks provide a cli tool. There is also a cli tool for front end developers working on AEM (aemfed) at [1] it relies on aemsync [2] [1] https://www.npmjs.com/package/aemfed [2] https://www.npmjs.com/package/aemsync Robert Ruben [1] https://github.com/headwirecom/percli On 3/29/2019 2:13 AM, Robert Munteanu wrote: Hi, Radu and I have been working on a little tool to automate some of the release work [1] (and maybe help with other stuff). See [2] for background information. As it's starting to take shape and become usable we'd like to move it out of the whiteboard. I suggest we use 'org.apache.sling.cli' as the artifactId and 'sling- org-apache-sling-cli' as the repository. Thoughts? Thanks, Robert [1]: https://github.com/apache/sling-whiteboard/tree/master/cli [2]: https://lists.apache.org/thread.html/b3001deea28c800f81830701c9293e66634f5512d70bed0043fb2302@%3Cdev.sling.apache.org%3E
adaptTo() 2019 - Call for Papers extended / Early Bird Tickets
Dear adaptTo() Community, We are extending our Call for Papers by another two weeks. The new deadline is April 15. So, if you would like to be a speaker, please visit https://adapt.to/cfp - and/or if you know any other potential speakers, please send them our way! I would also like to use this opportunity to remind you that Early Bird tickets are still available. Go to https://adapt.to/tickets before May 31 to take advantage of this offer. As the event usually sells out quickly, we advise you to buy your tickets as soon as possible. Kind regards on behalf of the adaptTo() Team, Stefan
[jira] [Created] (SLING-8337) Create sub-command to manage the Jira update when promoting a release
Robert Munteanu created SLING-8337:
--
Summary: Create sub-command to manage the Jira update when
promoting a release
Key: SLING-8337
URL: https://issues.apache.org/jira/browse/SLING-8337
Project: Sling
Issue Type: Improvement
Components: Tooling
Reporter: Robert Munteanu
Assignee: Robert Munteanu
Fix For: CLI 1.0.0
We should add a new command {{release update-jira}} which takes care of the
jira tasks for a new release:
- marks all issues for the released version as 'Closed'
- marks the released version as 'Released'
- creates, if needed, a successor version with the same name and an incremented
micor version component ( e.g. X.Y.Z+2 )
- orders the versions so that the successor version is placed right above the
released version
The incremented version should only be created if no newer version exists, e.g.
for released version 1.0.0 and already existing version 1.1.0 no 1.0.2 version
should be created.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-8335) StringIndexOutOfBoundsException from resolver.map with non absolute path
[
https://issues.apache.org/jira/browse/SLING-8335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16805167#comment-16805167
]
Robert Munteanu commented on SLING-8335:
Thanks for the patch [~ashokpanghal] . Can you please open a PR with this so we
can get Jenkins checks running and maybe involve more people in the review?
> StringIndexOutOfBoundsException from resolver.map with non absolute path
>
>
> Key: SLING-8335
> URL: https://issues.apache.org/jira/browse/SLING-8335
> Project: Sling
> Issue Type: Bug
> Components: ResourceResolver
>Affects Versions: Resource Resolver 1.6.8
>Reporter: Ashok Kumar
>Priority: Major
> Attachments: StringIndexOutofBounds.patch
>
>
> ResourceResolver.map("content/we-retail/us/en”) - Forward Mapping
> Steps to Reproduce :
> 1. go to /system/console/jcrresolver console
> 2. input "content/we-retail/us/en" in Test
> 3. click map
> Output
> it give out the error message -: java.lang.StringIndexOutOfBoundsException:
> String index out of range: -1
>
> [https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/master/src/main/java/org/apache/sling/resourceresolver/impl/ResourceResolverImpl.java#L770]
> {quote}final String pathInfo = absPath.substring(path.length());
> {quote}
> path = "/content/we-retail/us/en" whereas absPath = "content/we-retail/us/en"
> substring fails
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (SLING-8311) Investigate creating a Sling CLI tool for development task automation
[
https://issues.apache.org/jira/browse/SLING-8311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu resolved SLING-8311.
Resolution: Fixed
[~radu.cotescu] - FYI I'm resolving this one as the investigation part is
complete. I suggest we create specific tasks for other steps and set fixVersion
to 'CLI 1.0.0'
> Investigate creating a Sling CLI tool for development task automation
> -
>
> Key: SLING-8311
> URL: https://issues.apache.org/jira/browse/SLING-8311
> Project: Sling
> Issue Type: New Feature
> Components: Build and Source Control, Tooling
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: CLI 1.0.0
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> As part of
> https://cwiki.apache.org/confluence/display/SLING/Scaling+Sling+Development I
> would like to investigate if we can produce a CLI tool which automates some
> of the 'boring' tasks related to Sling development, especially those listed
> under {{PRB-RELEASE}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (SLING-8311) Investigate creating a Sling CLI tool for development task automation
[
https://issues.apache.org/jira/browse/SLING-8311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu updated SLING-8311:
---
Fix Version/s: CLI 1.0.0
> Investigate creating a Sling CLI tool for development task automation
> -
>
> Key: SLING-8311
> URL: https://issues.apache.org/jira/browse/SLING-8311
> Project: Sling
> Issue Type: New Feature
> Components: Build and Source Control, Tooling
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: CLI 1.0.0
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> As part of
> https://cwiki.apache.org/confluence/display/SLING/Scaling+Sling+Development I
> would like to investigate if we can produce a CLI tool which automates some
> of the 'boring' tasks related to Sling development, especially those listed
> under {{PRB-RELEASE}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [sling-org-apache-sling-feature] rombert commented on issue #10: Update readme.md
rombert commented on issue #10: Update readme.md URL: https://github.com/apache/sling-org-apache-sling-feature/pull/10#issuecomment-478057881 Well spotted! Thanks @jmarrero This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [sling-org-apache-sling-feature] rombert merged pull request #10: Update readme.md
rombert merged pull request #10: Update readme.md URL: https://github.com/apache/sling-org-apache-sling-feature/pull/10 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
Re: [DISCUSS] Create new sling repo for org.apache.sling.cli
On Fri, 2019-03-29 at 10:31 +0100, Bertrand Delacretaz wrote: > On Fri, Mar 29, 2019 at 10:13 AM Robert Munteanu > wrote: > > ...I suggest we use 'org.apache.sling.cli' as the artifactId and > > 'sling- > > org-apache-sling-cli' as the repository... > > IIUC this tool is specifically about automating release, so how about > a more specific name? > > org-apache-sling-release-cli ? Hi Bertrand, I'm a bit undecided about this. Currently this is about releases, supporting the 'release' command and some other subcommands, e.g. release list release prepare-email release tally-votes release update-local-site I am thinking that this CLI may the the basis for other commands. One which I would benefit personally from would be a code grep one, which searches the Sling repos. Additionally some github integration would be useful such as pull-request list to list all open pull requests, which could be the basis of solving PRB-CONTRIB from [1]. Anyway, org-apache-sling-release-cli sounds OK to me, at least initially, and we can rename it later. Thanks, Robert [1]: https://cwiki.apache.org/confluence/display/SLING/Scaling+Sling+Development
[jira] [Resolved] (SLING-8336) [cp2fm] filter.xml files not properly merged
[
https://issues.apache.org/jira/browse/SLING-8336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Simone Tripodi resolved SLING-8336.
---
Resolution: Fixed
Fix Version/s: Feature Model 1.0.0
Fixed in
[e5c3880|https://github.com/apache/sling-org-apache-sling-feature-cpconverter/commit/e5c3880a879b701aad7513a99b9153645748fe00]
> [cp2fm] filter.xml files not properly merged
>
>
> Key: SLING-8336
> URL: https://issues.apache.org/jira/browse/SLING-8336
> Project: Sling
> Issue Type: Bug
> Components: Feature Model
>Reporter: Simone Tripodi
>Assignee: Simone Tripodi
>Priority: Major
> Fix For: Feature Model 1.0.0
>
>
> Currently, {{filters.xml}} files are not properly merged/outputted in the
> main generated content-package, it needs to be addressed
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (SLING-8336) [cp2fm] filter.xml files not properly merged
Simone Tripodi created SLING-8336:
-
Summary: [cp2fm] filter.xml files not properly merged
Key: SLING-8336
URL: https://issues.apache.org/jira/browse/SLING-8336
Project: Sling
Issue Type: Bug
Components: Feature Model
Reporter: Simone Tripodi
Assignee: Simone Tripodi
Currently, {{filters.xml}} files are not properly merged/outputted in the main
generated content-package, it needs to be addressed
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (SLING-8311) Investigate creating a Sling CLI tool for development task automation
[
https://issues.apache.org/jira/browse/SLING-8311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Radu Cotescu updated SLING-8311:
Component/s: Tooling
> Investigate creating a Sling CLI tool for development task automation
> -
>
> Key: SLING-8311
> URL: https://issues.apache.org/jira/browse/SLING-8311
> Project: Sling
> Issue Type: New Feature
> Components: Build and Source Control, Tooling
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> As part of
> https://cwiki.apache.org/confluence/display/SLING/Scaling+Sling+Development I
> would like to investigate if we can produce a CLI tool which automates some
> of the 'boring' tasks related to Sling development, especially those listed
> under {{PRB-RELEASE}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (SLING-8334) Get Launcher Extension API ready for 1.0 release
[ https://issues.apache.org/jira/browse/SLING-8334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Bosschaert resolved SLING-8334. - Resolution: Fixed Fixed with: https://github.com/apache/sling-org-apache-sling-feature-launcher/commit/4103794287784f51997866715d17466effe9e291 > Get Launcher Extension API ready for 1.0 release > > > Key: SLING-8334 > URL: https://issues.apache.org/jira/browse/SLING-8334 > Project: Sling > Issue Type: Improvement > Components: Feature Model >Affects Versions: Feature Model Launcher 0.8.0 >Reporter: David Bosschaert >Assignee: David Bosschaert >Priority: Major > Fix For: Feature Model Launcher 1.0.0 > > Time Spent: 40m > Remaining Estimate: 0h > > In preparation for the Feature Launcher 1.0 release, we should revisit its > extension plugin API to see if it can be improved. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [sling-org-apache-sling-feature-launcher] bosschaert merged pull request #8: SLING-8334 Get Launcher Extension API ready for 1.0 release
bosschaert merged pull request #8: SLING-8334 Get Launcher Extension API ready for 1.0 release URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/8 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (SLING-8335) StringIndexOutOfBoundsException from resolver.map with non absolute path
[
https://issues.apache.org/jira/browse/SLING-8335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16804815#comment-16804815
]
Ashok Kumar commented on SLING-8335:
Attached patch has a localised fix as I am not sure if it should be a check
right at the top of the method resolveInternal which expects absPath as
parameter.
> StringIndexOutOfBoundsException from resolver.map with non absolute path
>
>
> Key: SLING-8335
> URL: https://issues.apache.org/jira/browse/SLING-8335
> Project: Sling
> Issue Type: Bug
> Components: ResourceResolver
>Affects Versions: Resource Resolver 1.6.8
>Reporter: Ashok Kumar
>Priority: Major
> Attachments: StringIndexOutofBounds.patch
>
>
> ResourceResolver.map("content/we-retail/us/en”) - Forward Mapping
> Steps to Reproduce :
> 1. go to /system/console/jcrresolver console
> 2. input "content/we-retail/us/en" in Test
> 3. click map
> Output
> it give out the error message -: java.lang.StringIndexOutOfBoundsException:
> String index out of range: -1
>
> [https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/master/src/main/java/org/apache/sling/resourceresolver/impl/ResourceResolverImpl.java#L770]
> {quote}final String pathInfo = absPath.substring(path.length());
> {quote}
> path = "/content/we-retail/us/en" whereas absPath = "content/we-retail/us/en"
> substring fails
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (SLING-8335) StringIndexOutOfBoundsException from resolver.map with non absolute path
[
https://issues.apache.org/jira/browse/SLING-8335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ashok Kumar updated SLING-8335:
---
Attachment: StringIndexOutofBounds.patch
> StringIndexOutOfBoundsException from resolver.map with non absolute path
>
>
> Key: SLING-8335
> URL: https://issues.apache.org/jira/browse/SLING-8335
> Project: Sling
> Issue Type: Bug
> Components: ResourceResolver
>Affects Versions: Resource Resolver 1.6.8
>Reporter: Ashok Kumar
>Priority: Major
> Attachments: StringIndexOutofBounds.patch
>
>
> ResourceResolver.map("content/we-retail/us/en”) - Forward Mapping
> Steps to Reproduce :
> 1. go to /system/console/jcrresolver console
> 2. input "content/we-retail/us/en" in Test
> 3. click map
> Output
> it give out the error message -: java.lang.StringIndexOutOfBoundsException:
> String index out of range: -1
>
> [https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/master/src/main/java/org/apache/sling/resourceresolver/impl/ResourceResolverImpl.java#L770]
> {quote}final String pathInfo = absPath.substring(path.length());
> {quote}
> path = "/content/we-retail/us/en" whereas absPath = "content/we-retail/us/en"
> substring fails
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (SLING-8335) StringIndexOutOfBoundsException from resolver.map with non absolute path
Ashok Kumar created SLING-8335:
--
Summary: StringIndexOutOfBoundsException from resolver.map with
non absolute path
Key: SLING-8335
URL: https://issues.apache.org/jira/browse/SLING-8335
Project: Sling
Issue Type: Bug
Components: ResourceResolver
Affects Versions: Resource Resolver 1.6.8
Reporter: Ashok Kumar
ResourceResolver.map("content/we-retail/us/en”) - Forward Mapping
Steps to Reproduce :
1. go to /system/console/jcrresolver console
2. input "content/we-retail/us/en" in Test
3. click map
Output
it give out the error message -: java.lang.StringIndexOutOfBoundsException:
String index out of range: -1
[https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/master/src/main/java/org/apache/sling/resourceresolver/impl/ResourceResolverImpl.java#L770]
{quote}final String pathInfo = absPath.substring(path.length());
{quote}
path = "/content/we-retail/us/en" whereas absPath = "content/we-retail/us/en"
substring fails
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Re: [DISCUSS] Create new sling repo for org.apache.sling.cli
On Fri, Mar 29, 2019 at 10:13 AM Robert Munteanu wrote: > ...I suggest we use 'org.apache.sling.cli' as the artifactId and 'sling- > org-apache-sling-cli' as the repository... IIUC this tool is specifically about automating release, so how about a more specific name? org-apache-sling-release-cli ? -Bertrand
[DISCUSS] Create new sling repo for org.apache.sling.cli
Hi, Radu and I have been working on a little tool to automate some of the release work [1] (and maybe help with other stuff). See [2] for background information. As it's starting to take shape and become usable we'd like to move it out of the whiteboard. I suggest we use 'org.apache.sling.cli' as the artifactId and 'sling- org-apache-sling-cli' as the repository. Thoughts? Thanks, Robert [1]: https://github.com/apache/sling-whiteboard/tree/master/cli [2]: https://lists.apache.org/thread.html/b3001deea28c800f81830701c9293e66634f5512d70bed0043fb2302@%3Cdev.sling.apache.org%3E
