[jira] [Resolved] (SLING-8583) [r2f] Lookup bundles ArtifactId in idbsnver.properties and skip the bundle 0

[Simone Tripodi (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-8583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Simone Tripodi resolved SLING-8583.
---
Resolution: Fixed

> [r2f] Lookup bundles ArtifactId in idbsnver.properties and skip the bundle 0 
> -
>
> Key: SLING-8583
> URL: https://issues.apache.org/jira/browse/SLING-8583
> Project: Sling
>  Issue Type: Bug
>Affects Versions: Feature Runtime2Feature 0.0.2
>Reporter: Simone Tripodi
>Assignee: Simone Tripodi
>Priority: Major
> Fix For: Feature Runtime2Feature 0.0.4
>
>
> As per subject, once the instance is up and running, the 
> {{idbsnver.properties}} contains the {{(BundleSymbolicName,Version) -> 
> ArtifactId}} mapping, which is faster to query rather than computing bundles 
> GAV by reading the nested {{pom.properties}}, which can be used if not 
> previously found.
> Moreover, the bundle 0 must be skipped.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Re: nodejs based sling packager

[Ruben Reusser]

Dan, thanks for reporting the issue - what version of sling, java, node 
are you using?


On 7/15/2019 6:26 AM, Daniel Klco wrote:

Ruben,

Nice idea! The package CLI tool is a nice tool beyond just being a Node
example.

I did have some trouble installing the simple-sling-vue-example into a
local Sling instance. It's possible that my node definitions are somehow
messed up, but I got the following error message:

Collecting import information... Installing node types... Installing
privileges... Importing content... - / - /content E
/content/vuecontentbrowser ! javax.jcr.nodetype.NoSuchNodeTypeException:
Node type sling0:OrderedFolder does not exist E
/content/vuecontentbrowser/css ! java.lang.IllegalStateException: Parent
node not found. E /content/vuecontentbrowser/css/app.d4b2f170.css !
java.lang.IllegalStateException: Parent node not found. E
/content/vuecontentbrowser/js ! java.lang.IllegalStateException: Parent
node not found. E /content/vuecontentbrowser/js/app.ea81798f.js !
java.lang.IllegalStateException: Parent node not found. E
/content/vuecontentbrowser/js/app.ea81798f.js.map !
java.lang.IllegalStateException: Parent node not found. E
/content/vuecontentbrowser/js/chunk-vendors.c9e50ecf.js !
java.lang.IllegalStateException: Parent node not found. E
/content/vuecontentbrowser/js/chunk-vendors.c9e50ecf.js.map !
java.lang.IllegalStateException: Parent node not found. E
/content/vuecontentbrowser/favicon.ico ! java.lang.IllegalStateException:
Parent node not found. E /content/vuecontentbrowser/index.html !
java.lang.IllegalStateException: Parent node not found. saving approx 10
nodes... Package imported (with errors, check logs!)

On Sun, Jul 14, 2019 at 11:44 AM Ruben Reusser  wrote:


Dear Sling Developers,

in an effort to help 'front end developers' embrace Apache Sling and in
order to make simple front-end Sling projects maven independent we
created a node only slingpackager [1] and a sample VueJs based Slnig
Content Browser [2] as a showcase project.

We'd like to see the slingpackager (and potentially the showcase
example) be part of Apache Sling and maybe live on npmjs in an Apache
Sling organization (@apachesling for example).

We'd love to hear what you think about this!

Ruben Reusser

[1] https://github.com/peregrine-cms/slingpackager
[2] https://github.com/peregrine-cms/simple-sling-vue-example

[jira] [Commented] (SLING-7245) Validate pull requests using Jenkins

[Bertrand Delacretaz (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885254#comment-16885254
 ] 

Bertrand Delacretaz commented on SLING-7245:


My understanding of INFRA-18748 is that builds from non-committers should not 
happen to avoid denial of service attacks.

IIRC for [https://cwiki.apache.org/] people have to ask the PMC to get write 
access - a similar mechanism would sound reasonable for PR builds: authorize 
them if the GitHub username is included in a list that the PMC manages.

I have mentioned this suggestion in the infra thread mentioned above.

> Validate pull requests using Jenkins
> 
>
> Key: SLING-7245
> URL: https://issues.apache.org/jira/browse/SLING-7245
> Project: Sling
>  Issue Type: Improvement
>  Components: Build and Source Control
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Attachments: image-2019-01-30-12-52-54-106.png, 
> image-2019-01-30-12-52-56-248.png
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> We should refine the work done in SLING-7163 and validate PRs using Jenkins.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Comment Edited] (SLING-7245) Validate pull requests using Jenkins

[Konrad Windszus (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885137#comment-16885137
 ] 

Konrad Windszus edited comment on SLING-7245 at 7/15/19 1:48 PM:
-

Not sure, I also don't know where this policy is documented... There is now a 
discussion around that at 
https://lists.apache.org/thread.html/7ba9424ae1cadd61363a5c6e7d12dec9f5b424b1f68e27915032fbab@%3Cprivate.infra.apache.org%3E.


was (Author: kwin):
Not sure, I also don't know where this policy is documented...

> Validate pull requests using Jenkins
> 
>
> Key: SLING-7245
> URL: https://issues.apache.org/jira/browse/SLING-7245
> Project: Sling
>  Issue Type: Improvement
>  Components: Build and Source Control
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Attachments: image-2019-01-30-12-52-54-106.png, 
> image-2019-01-30-12-52-56-248.png
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> We should refine the work done in SLING-7163 and validate PRs using Jenkins.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Re: nodejs based sling packager

[Daniel Klco]

Ruben,

Nice idea! The package CLI tool is a nice tool beyond just being a Node
example.

I did have some trouble installing the simple-sling-vue-example into a
local Sling instance. It's possible that my node definitions are somehow
messed up, but I got the following error message:

Collecting import information... Installing node types... Installing
privileges... Importing content... - / - /content E
/content/vuecontentbrowser ! javax.jcr.nodetype.NoSuchNodeTypeException:
Node type sling0:OrderedFolder does not exist E
/content/vuecontentbrowser/css ! java.lang.IllegalStateException: Parent
node not found. E /content/vuecontentbrowser/css/app.d4b2f170.css !
java.lang.IllegalStateException: Parent node not found. E
/content/vuecontentbrowser/js ! java.lang.IllegalStateException: Parent
node not found. E /content/vuecontentbrowser/js/app.ea81798f.js !
java.lang.IllegalStateException: Parent node not found. E
/content/vuecontentbrowser/js/app.ea81798f.js.map !
java.lang.IllegalStateException: Parent node not found. E
/content/vuecontentbrowser/js/chunk-vendors.c9e50ecf.js !
java.lang.IllegalStateException: Parent node not found. E
/content/vuecontentbrowser/js/chunk-vendors.c9e50ecf.js.map !
java.lang.IllegalStateException: Parent node not found. E
/content/vuecontentbrowser/favicon.ico ! java.lang.IllegalStateException:
Parent node not found. E /content/vuecontentbrowser/index.html !
java.lang.IllegalStateException: Parent node not found. saving approx 10
nodes... Package imported (with errors, check logs!)

On Sun, Jul 14, 2019 at 11:44 AM Ruben Reusser  wrote:

> Dear Sling Developers,
>
> in an effort to help 'front end developers' embrace Apache Sling and in
> order to make simple front-end Sling projects maven independent we
> created a node only slingpackager [1] and a sample VueJs based Slnig
> Content Browser [2] as a showcase project.
>
> We'd like to see the slingpackager (and potentially the showcase
> example) be part of Apache Sling and maybe live on npmjs in an Apache
> Sling organization (@apachesling for example).
>
> We'd love to hear what you think about this!
>
> Ruben Reusser
>
> [1] https://github.com/peregrine-cms/slingpackager
> [2] https://github.com/peregrine-cms/simple-sling-vue-example
>
>

[RESULT][VOTE] Sling API Regions Runtime component 1.0.2

[davidb]

With 3+1s this vote succeeds.
I've promoted the artifacts.

Best regards,

David

On Wed, 10 Jul 2019 at 10:17,  wrote:

> Hi all,
>
> I would like to call the 1.0.2 release for
> the org.apache.sling.feature.apiregions bundle.
> The following issues have been fixed:
> https://issues.apache.org/jira/projects/SLING/versions/12345377
>
> Staging repository for this release:
> https://repository.apache.org/content/repositories/orgapachesling-2106/
> 
>
> You can use this UNIX script to download the release and verify the
> signatures:
> http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh
>
> Usage:
> sh check_staged_release.sh 2106 /tmp/sling-staging
>
> Please vote to approve this release:
>
>   [ ] +1 Approve the release
>   [ ] -1 Don't release, because ...
>
> This majority vote is open for at least 72 hours.
>
> Best regards,
>
> David Bosschaert
>

Re: [VOTE] Sling API Regions Runtime component 1.0.2

[Bertrand Delacretaz]

On Wed, Jul 10, 2019 at 11:18 AM  wrote:
> ...I would like to call the 1.0.2 release for
> the org.apache.sling.feature.apiregions bundle...

LGTM, +1 for the release of
SHA1(org.apache.sling.feature.apiregions-1.0.2-source-release.zip)=
bfb4d1bb39bbb00b2f55d15d609ab5168d7b4914

-Bertrand

[jira] [Updated] (SLING-8570) Extract a generic Content Parser API from org.apache.sling.jcr.contentparser with pluggable implementations

[Radu Cotescu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-8570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radu Cotescu updated SLING-8570:

Fix Version/s: Content Parser XML JCR 1.0.0
   Content Parser XML 1.0.0
   Content Parser JSON 1.0.0

> Extract a generic Content Parser API from org.apache.sling.jcr.contentparser 
> with pluggable implementations
> ---
>
> Key: SLING-8570
> URL: https://issues.apache.org/jira/browse/SLING-8570
> Project: Sling
>  Issue Type: New Feature
>Reporter: Radu Cotescu
>Assignee: Radu Cotescu
>Priority: Major
> Fix For: Content Parser API 1.0.0, Content Parser JSON 1.0.0, 
> Content Parser XML 1.0.0, Content Parser XML JCR 1.0.0
>
>
> The {{org.apache.sling.jcr.contentparser}} bundle provides the API and three 
> parser implementations supporting JSON, XML and Vault XML structures for 
> generating Sling resource trees. The goal of this issue is to modularise 
> {{org.apache.sling.jcr.contentparser}}, by extracting 4 bundles:
> # org.apache.sling.contentparser.api - API only, no JCR / Jackrabbit 
> dependencies
> # org.apache.sling.contentparser.json - JSON parser implementation
> # org.apache.sling.contentparser.xml - XML parser implementation
> # org.apache.sling.contentparser.xml.jcr - JackRabbit FileVault parser 
> implementation



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (SLING-7245) Validate pull requests using Jenkins

[Konrad Windszus (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885137#comment-16885137
 ] 

Konrad Windszus commented on SLING-7245:


Not sure, I also don't know where this policy is documented...

> Validate pull requests using Jenkins
> 
>
> Key: SLING-7245
> URL: https://issues.apache.org/jira/browse/SLING-7245
> Project: Sling
>  Issue Type: Improvement
>  Components: Build and Source Control
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Attachments: image-2019-01-30-12-52-54-106.png, 
> image-2019-01-30-12-52-56-248.png
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> We should refine the work done in SLING-7163 and validate PRs using Jenkins.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Comment Edited] (SLING-7245) Validate pull requests using Jenkins

[Robert Munteanu (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885135#comment-16885135
 ] 

Robert Munteanu edited comment on SLING-7245 at 7/15/19 12:01 PM:
--

[~kwin] - is it not allowed to _automatically_ trigger such builds or is it not 
allowed to build contributions from non-committers at all on ASF hardware?


was (Author: rombert):
[~kwin] - is it not allowed to _automatically_ trigger such builds or is it not 
allowed to build contributions at all on ASF hardware?

> Validate pull requests using Jenkins
> 
>
> Key: SLING-7245
> URL: https://issues.apache.org/jira/browse/SLING-7245
> Project: Sling
>  Issue Type: Improvement
>  Components: Build and Source Control
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Attachments: image-2019-01-30-12-52-54-106.png, 
> image-2019-01-30-12-52-56-248.png
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> We should refine the work done in SLING-7163 and validate PRs using Jenkins.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (SLING-7245) Validate pull requests using Jenkins

[Robert Munteanu (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885135#comment-16885135
 ] 

Robert Munteanu commented on SLING-7245:


[~kwin] - is it not allowed to _automatically_ trigger such builds or is it not 
allowed to build contributions at all on ASF hardware?

> Validate pull requests using Jenkins
> 
>
> Key: SLING-7245
> URL: https://issues.apache.org/jira/browse/SLING-7245
> Project: Sling
>  Issue Type: Improvement
>  Components: Build and Source Control
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Attachments: image-2019-01-30-12-52-54-106.png, 
> image-2019-01-30-12-52-56-248.png
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> We should refine the work done in SLING-7163 and validate PRs using Jenkins.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Re: [org.apache.sling.jcr.contentparser] can we decouple it from JCR?

[Radu Cotescu]

Hi,

> On 8 Jul 2019, at 22:20, Radu Cotescu  wrote:
> 
> Thanks for the +1s. I’ll start working in the whiteboard and hope to have 
> everything ready for review by the end of the week.

The code is now available at [0]. Let me know if you have any objections or 
feedback that I should incorporate before moving the modules to their own git 
repositories.

Thanks,
Radu

[0] - https://github.com/apache/sling-whiteboard/tree/master/contentparser/

[jira] [Commented] (SLING-7245) Validate pull requests using Jenkins

[Konrad Windszus (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885112#comment-16885112
 ] 

Konrad Windszus commented on SLING-7245:


[~rombert] According to [~gstein] it is not allowed to trigger builds from PRs 
created by non-committers 
(https://issues.apache.org/jira/browse/INFRA-18748?focusedCommentId=16885091=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16885091).
 We should discuss how to handle those.

> Validate pull requests using Jenkins
> 
>
> Key: SLING-7245
> URL: https://issues.apache.org/jira/browse/SLING-7245
> Project: Sling
>  Issue Type: Improvement
>  Components: Build and Source Control
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Attachments: image-2019-01-30-12-52-54-106.png, 
> image-2019-01-30-12-52-56-248.png
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> We should refine the work done in SLING-7163 and validate PRs using Jenkins.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (SLING-8582) Improve test coverage

[Konrad Windszus (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-8582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885099#comment-16885099
 ] 

Konrad Windszus commented on SLING-8582:


I triggered the build once manually but for the second commit it hasn't been 
triggered again. I have opened https://jira.apache.org/jira/browse/INFRA-18750 
to track this.

> Improve test coverage 
> --
>
> Key: SLING-8582
> URL: https://issues.apache.org/jira/browse/SLING-8582
> Project: Sling
>  Issue Type: Improvement
>  Components: Event
>Affects Versions: Event 4.2.12
>Reporter: Jörg Hoh
>Priority: Major
>
> Right now the unittest coverage of sling eventing has room for improvement, 
> also there are some sonar reportings for it.
> Please merge [https://github.com/apache/sling-org-apache-sling-event/pull/6] 
> as a first step to towards adressing those issues.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (SLING-8583) [r2f] Lookup bundles ArtifactId in idbsnver.properties and skip the bundle 0

[Simone Tripodi (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-8583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885081#comment-16885081
 ] 

Simone Tripodi commented on SLING-8583:
---

initial fix implemented in 
[3e7efcb|https://github.com/apache/sling-org-apache-sling-feature-r2f/commit/3e7efcb001d31b843d45e11628152961c479666f]

> [r2f] Lookup bundles ArtifactId in idbsnver.properties and skip the bundle 0 
> -
>
> Key: SLING-8583
> URL: https://issues.apache.org/jira/browse/SLING-8583
> Project: Sling
>  Issue Type: Bug
>Affects Versions: Feature Runtime2Feature 0.0.2
>Reporter: Simone Tripodi
>Assignee: Simone Tripodi
>Priority: Major
> Fix For: Feature Runtime2Feature 0.0.4
>
>
> As per subject, once the instance is up and running, the 
> {{idbsnver.properties}} contains the {{(BundleSymbolicName,Version) -> 
> ArtifactId}} mapping, which is faster to query rather than computing bundles 
> GAV by reading the nested {{pom.properties}}, which can be used if not 
> previously found.
> Moreover, the bundle 0 must be skipped.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Created] (SLING-8583) [r2f] Lookup bundles ArtifactId in idbsnver.properties and skip the bundle 0

[Simone Tripodi (JIRA)]

Simone Tripodi created SLING-8583:
-

 Summary: [r2f] Lookup bundles ArtifactId in idbsnver.properties 
and skip the bundle 0 
 Key: SLING-8583
 URL: https://issues.apache.org/jira/browse/SLING-8583
 Project: Sling
  Issue Type: Bug
Affects Versions: Feature Runtime2Feature 0.0.2
Reporter: Simone Tripodi
Assignee: Simone Tripodi
 Fix For: Feature Runtime2Feature 0.0.4


As per subject, once the instance is up and running, the 
{{idbsnver.properties}} contains the {{(BundleSymbolicName,Version) -> 
ArtifactId}} mapping, which is faster to query rather than computing bundles 
GAV by reading the nested {{pom.properties}}, which can be used if not 
previously found.

Moreover, the bundle 0 must be skipped.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (SLING-8582) Improve test coverage

[JIRA]

[ 
https://issues.apache.org/jira/browse/SLING-8582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885062#comment-16885062
 ] 

Jörg Hoh commented on SLING-8582:
-

I did a second push to address some sonar findings, but I don't see that a new 
sonar scan has been triggered :(

> Improve test coverage 
> --
>
> Key: SLING-8582
> URL: https://issues.apache.org/jira/browse/SLING-8582
> Project: Sling
>  Issue Type: Improvement
>  Components: Event
>Affects Versions: Event 4.2.12
>Reporter: Jörg Hoh
>Priority: Major
>
> Right now the unittest coverage of sling eventing has room for improvement, 
> also there are some sonar reportings for it.
> Please merge [https://github.com/apache/sling-org-apache-sling-event/pull/6] 
> as a first step to towards adressing those issues.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (SLING-8582) Improve test coverage

[JIRA]

[ 
https://issues.apache.org/jira/browse/SLING-8582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885042#comment-16885042
 ] 

Jörg Hoh commented on SLING-8582:
-

The Sonar check passed: 
https://github.com/apache/sling-org-apache-sling-event/pull/6/checks?check_run_id=168894067

> Improve test coverage 
> --
>
> Key: SLING-8582
> URL: https://issues.apache.org/jira/browse/SLING-8582
> Project: Sling
>  Issue Type: Improvement
>  Components: Event
>Affects Versions: Event 4.2.12
>Reporter: Jörg Hoh
>Priority: Major
>
> Right now the unittest coverage of sling eventing has room for improvement, 
> also there are some sonar reportings for it.
> Please merge [https://github.com/apache/sling-org-apache-sling-event/pull/6] 
> as a first step to towards adressing those issues.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (SLING-8511) Make testing compliant with Java 9 and higher

[Bertrand Delacretaz (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-8511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885023#comment-16885023
 ] 

Bertrand Delacretaz commented on SLING-8511:


I have fixed the wrong jira version numbers, thank you for mentioning this - at 
https://issues.apache.org/jira/plugins/servlet/project-config/SLING/administer-versions?=released-unreleased=capabilities

> Make testing compliant with Java 9 and higher
> -
>
> Key: SLING-8511
> URL: https://issues.apache.org/jira/browse/SLING-8511
> Project: Sling
>  Issue Type: Task
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: Apache Sling Capabilities JCR 0.2.0
>
>
> * Set sling.java.version to 8
> * Use Sling Bundle Parent 35
> * Update Pax Exam to 4.13.1
> * Update Testing PaxExam to 3.0.0
> * Update Felix Framework to 6.0.3
> * Use scr Option
> * Remove duplicated JUnit dependency



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Updated] (SLING-8452) Sling Models: Migrate from Felix SCR annotations to OSGi R6 annotations

[Konrad Windszus (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-8452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus updated SLING-8452:
---
Affects Version/s: (was: Sling Models Validation Impl 1.0.0)
Fix Version/s: Sling Models API 1.3.10
   Sling Models Jackson Exporter 1.0.10

> Sling Models: Migrate from Felix SCR annotations to OSGi R6 annotations
> ---
>
> Key: SLING-8452
> URL: https://issues.apache.org/jira/browse/SLING-8452
> Project: Sling
>  Issue Type: Improvement
>  Components: Sling Models
>Affects Versions: Sling Models API 1.3.8, Sling Models Jackson Exporter 
> 1.0.8, Sling Models Impl 1.4.10
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Sling Models Jackson Exporter 1.0.10, Sling Models Impl 
> 1.4.12, Sling Models API 1.3.10
>
>  Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> Even the R6 metatype annotations should work in this case as currently we 
> don't have any attributes with hyphens in the name (which are only supported 
> since R7).



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Comment Edited] (SLING-8582) Improve test coverage

[Robert Munteanu (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-8582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884969#comment-16884969
 ] 

Robert Munteanu edited comment on SLING-8582 at 7/15/19 9:38 AM:
-

Not sure [~kwin]. Looking at 
https://builds.apache.org/job/Sling/job/sling-org-apache-sling-event/indexing/console
 the build was not triggered. I also don't see a matching event at 
https://builds.apache.org/job/Sling/computation/console , but that might've 
just been too far back to still see it.

Note that you can always manually trigger a scan from 
https://builds.apache.org/job/Sling/job/sling-org-apache-sling-event/ ( _Scan 
Repository Now_ ) in case you detect an inconsistency.

If we start seeing systemic issues we should raise a Jira with the ASF Infra 
team.


was (Author: rombert):
Not sure [~kwin]. Looking at 
https://builds.apache.org/job/Sling/job/sling-org-apache-sling-event/indexing/console
 the build was not triggered. I also don't see a matching event at 
https://builds.apache.org/job/Sling/computation/console , but that might've 
just been too far back to still see it.

> Improve test coverage 
> --
>
> Key: SLING-8582
> URL: https://issues.apache.org/jira/browse/SLING-8582
> Project: Sling
>  Issue Type: Improvement
>  Components: Event
>Affects Versions: Event 4.2.12
>Reporter: Jörg Hoh
>Priority: Major
>
> Right now the unittest coverage of sling eventing has room for improvement, 
> also there are some sonar reportings for it.
> Please merge [https://github.com/apache/sling-org-apache-sling-event/pull/6] 
> as a first step to towards adressing those issues.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (SLING-8582) Improve test coverage

[Robert Munteanu (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-8582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884969#comment-16884969
 ] 

Robert Munteanu commented on SLING-8582:


Not sure [~kwin]. Looking at 
https://builds.apache.org/job/Sling/job/sling-org-apache-sling-event/indexing/console
 the build was not triggered. I also don't see a matching event at 
https://builds.apache.org/job/Sling/computation/console , but that might've 
just been too far back to still see it.

> Improve test coverage 
> --
>
> Key: SLING-8582
> URL: https://issues.apache.org/jira/browse/SLING-8582
> Project: Sling
>  Issue Type: Improvement
>  Components: Event
>Affects Versions: Event 4.2.12
>Reporter: Jörg Hoh
>Priority: Major
>
> Right now the unittest coverage of sling eventing has room for improvement, 
> also there are some sonar reportings for it.
> Please merge [https://github.com/apache/sling-org-apache-sling-event/pull/6] 
> as a first step to towards adressing those issues.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (SLING-8582) Improve test coverage

[Konrad Windszus (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-8582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884967#comment-16884967
 ] 

Konrad Windszus commented on SLING-8582:


[~rombert] Do you know why there was no Jenkins Build triggered for the PR from 
Jörg?

> Improve test coverage 
> --
>
> Key: SLING-8582
> URL: https://issues.apache.org/jira/browse/SLING-8582
> Project: Sling
>  Issue Type: Improvement
>  Components: Event
>Affects Versions: Event 4.2.12
>Reporter: Jörg Hoh
>Priority: Major
>
> Right now the unittest coverage of sling eventing has room for improvement, 
> also there are some sonar reportings for it.
> Please merge [https://github.com/apache/sling-org-apache-sling-event/pull/6] 
> as a first step to towards adressing those issues.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Resolved] (SLING-8271) Improve AbstractResourceVisitor to allow to stop visiting child resources

[Konrad Windszus (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-8271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus resolved SLING-8271.

Resolution: Won't Fix

> Improve AbstractResourceVisitor to allow to stop visiting child resources
> -
>
> Key: SLING-8271
> URL: https://issues.apache.org/jira/browse/SLING-8271
> Project: Sling
>  Issue Type: Improvement
>  Components: API
>Affects Versions: API 2.20.0
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> Currently the AbstractResourceVisitor 
> (https://github.com/apache/sling-org-apache-sling-api/blob/master/src/main/java/org/apache/sling/api/resource/AbstractResourceVisitor.java)
>  completely decouples the {{visit}} method from the actual resource 
> traversal. That means it is currently rather hard to programmatically add a 
> break condition which should lead to no further descending into child 
> resources.
> I propose to extend {{AbstractResourceVisitor}} by an additional visit method 
> which is supposed to return a boolean value. Only if {{true}} is returned it 
> will further descend into the children of the current resource. The default 
> implementation should just return {{true}} to make this change backwards 
> compatible.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (SLING-8271) Improve AbstractResourceVisitor to allow to stop visiting child resources

[Konrad Windszus (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-8271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884961#comment-16884961
 ] 

Konrad Windszus commented on SLING-8271:


I updated the javadoc accordingly in 
https://github.com/apache/sling-org-apache-sling-api/commit/9e31b3074e6ee6a7ca665e8c34f4909a9e2a26b4
 and added links to the ResourceStream/ResourceFilterStream classes.

> Improve AbstractResourceVisitor to allow to stop visiting child resources
> -
>
> Key: SLING-8271
> URL: https://issues.apache.org/jira/browse/SLING-8271
> Project: Sling
>  Issue Type: Improvement
>  Components: API
>Affects Versions: API 2.20.0
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: API 2.20.2
>
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> Currently the AbstractResourceVisitor 
> (https://github.com/apache/sling-org-apache-sling-api/blob/master/src/main/java/org/apache/sling/api/resource/AbstractResourceVisitor.java)
>  completely decouples the {{visit}} method from the actual resource 
> traversal. That means it is currently rather hard to programmatically add a 
> break condition which should lead to no further descending into child 
> resources.
> I propose to extend {{AbstractResourceVisitor}} by an additional visit method 
> which is supposed to return a boolean value. Only if {{true}} is returned it 
> will further descend into the children of the current resource. The default 
> implementation should just return {{true}} to make this change backwards 
> compatible.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Updated] (SLING-8271) Improve AbstractResourceVisitor to allow to stop visiting child resources

[Konrad Windszus (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-8271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus updated SLING-8271:
---
Fix Version/s: (was: API 2.20.2)

> Improve AbstractResourceVisitor to allow to stop visiting child resources
> -
>
> Key: SLING-8271
> URL: https://issues.apache.org/jira/browse/SLING-8271
> Project: Sling
>  Issue Type: Improvement
>  Components: API
>Affects Versions: API 2.20.0
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> Currently the AbstractResourceVisitor 
> (https://github.com/apache/sling-org-apache-sling-api/blob/master/src/main/java/org/apache/sling/api/resource/AbstractResourceVisitor.java)
>  completely decouples the {{visit}} method from the actual resource 
> traversal. That means it is currently rather hard to programmatically add a 
> break condition which should lead to no further descending into child 
> resources.
> I propose to extend {{AbstractResourceVisitor}} by an additional visit method 
> which is supposed to return a boolean value. Only if {{true}} is returned it 
> will further descend into the children of the current resource. The default 
> implementation should just return {{true}} to make this change backwards 
> compatible.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Created] (SLING-8582) Improve test coverage

[JIRA]

Jörg Hoh created SLING-8582:
---

 Summary: Improve test coverage 
 Key: SLING-8582
 URL: https://issues.apache.org/jira/browse/SLING-8582
 Project: Sling
  Issue Type: Improvement
  Components: Event
Affects Versions: Event 4.2.12
Reporter: Jörg Hoh


Right now the unittest coverage of sling eventing has room for improvement, 
also there are some sonar reportings for it.

Please merge [https://github.com/apache/sling-org-apache-sling-event/pull/6] as 
a first step to towards adressing those issues.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[GitHub] [sling-org-apache-sling-feature-cpconverter] simonetripodi commented on issue #11: SLING-8578 - Nodes which contain : are not correctly processed

[GitBox]

simonetripodi commented on issue #11: SLING-8578 - Nodes which contain : are 
not correctly processed
URL: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/11#issuecomment-511306787
 
 
   Thanks again @andreituicu for keep contributing!


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: [VOTE] Sling API Regions Runtime component 1.0.2

[davidb]

We need one more binding +1 vote.
Would anyone be interested in voting?

Best regards,

David

On Wed, 10 Jul 2019 at 10:17,  wrote:

> Hi all,
>
> I would like to call the 1.0.2 release for
> the org.apache.sling.feature.apiregions bundle.
> The following issues have been fixed:
> https://issues.apache.org/jira/projects/SLING/versions/12345377
>
> Staging repository for this release:
> https://repository.apache.org/content/repositories/orgapachesling-2106/
> 
>
> You can use this UNIX script to download the release and verify the
> signatures:
> http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh
>
> Usage:
> sh check_staged_release.sh 2106 /tmp/sling-staging
>
> Please vote to approve this release:
>
>   [ ] +1 Approve the release
>   [ ] -1 Don't release, because ...
>
> This majority vote is open for at least 72 hours.
>
> Best regards,
>
> David Bosschaert
>

[jira] [Resolved] (SLING-8581) Include Resource Filter in Sling Starter

[Konrad Windszus (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-8581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus resolved SLING-8581.

Resolution: Fixed

Fixed with 
https://github.com/apache/sling-org-apache-sling-starter/commit/54a327572adc32985ea743eb7be75757fbeb4922.

> Include Resource Filter in Sling Starter
> 
>
> Key: SLING-8581
> URL: https://issues.apache.org/jira/browse/SLING-8581
> Project: Sling
>  Issue Type: Improvement
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>  Labels: Sling-12-ReleaseNotes
> Fix For: Starter 12
>
>
> As discussed in 
> https://www.mail-archive.com/dev@sling.apache.org/msg86704.html the new 
> Resource Filter bundle should be added to Sling Starter.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[GitHub] [sling-org-apache-sling-feature-cpconverter] andreituicu opened a new pull request #11: SLING-8578 - Nodes which contain : are not correctly processed

[GitBox]

andreituicu opened a new pull request #11: SLING-8578 - Nodes which contain : 
are not correctly processed
URL: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/11
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Updated] (SLING-8581) Include Resource Filter in Sling Starter

[Konrad Windszus (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-8581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus updated SLING-8581:
---
Description: As discussed in 
https://www.mail-archive.com/dev@sling.apache.org/msg86704.html the new 
Resource Filter bundle should be added to Sling Starter.

> Include Resource Filter in Sling Starter
> 
>
> Key: SLING-8581
> URL: https://issues.apache.org/jira/browse/SLING-8581
> Project: Sling
>  Issue Type: Improvement
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>  Labels: Sling-12-ReleaseNotes
> Fix For: Starter 12
>
>
> As discussed in 
> https://www.mail-archive.com/dev@sling.apache.org/msg86704.html the new 
> Resource Filter bundle should be added to Sling Starter.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Created] (SLING-8581) Include Resource Filter in Sling Starter

[Konrad Windszus (JIRA)]

Konrad Windszus created SLING-8581:
--

 Summary: Include Resource Filter in Sling Starter
 Key: SLING-8581
 URL: https://issues.apache.org/jira/browse/SLING-8581
 Project: Sling
  Issue Type: Improvement
Reporter: Konrad Windszus
Assignee: Konrad Windszus
 Fix For: Starter 12






--
This message was sent by Atlassian JIRA
(v7.6.14#76016)