[jira] [Commented] (SLING-8655) Add an Annotation to Sling Model to mark a property to be Externalized

[Andreas Schaefer (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-8655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16916179#comment-16916179
 ] 

Andreas Schaefer commented on SLING-8655:
-

Adjusted the PRs to reflect the changes requested by the reviewer

> Add an Annotation to Sling Model to mark a property to be Externalized
> --
>
> Key: SLING-8655
> URL: https://issues.apache.org/jira/browse/SLING-8655
> Project: Sling
>  Issue Type: New Feature
>  Components: Sling Models
>Affects Versions: Sling Models API 1.3.8
>Reporter: Andreas Schaefer
>Assignee: Andreas Schaefer
>Priority: Major
> Fix For: Sling Models API 1.3.10
>
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> For Peregrine CMS we use Sling Models to obtain data in JSon format to be 
> rendered on the client side. This means that the returned content is not 
> externalized aka paths are not mapped to the external view.
> Sling Model should have an Annotation (@ExternalizedPath) that marks a 
> property to be externalized when loaded.
> In order to be flexible the Externalized Path Injector should be pluggable so 
> that customers can add their custom Externalized Path Providers if they 
> choose to do so. By default there is a provider that uses the Resource 
> Resolver's map() function.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

[GitHub] [sling-org-apache-sling-models-impl] schaefa commented on a change in pull request #14: SLING-8655 - Updated dependency on API, provided Externalized Path In…

[GitBox]

schaefa commented on a change in pull request #14: SLING-8655 - Updated 
dependency on API, provided Externalized Path In…
URL: 
https://github.com/apache/sling-org-apache-sling-models-impl/pull/14#discussion_r317825063
 
 

 ##
 File path: 
src/test/java/org/apache/sling/models/impl/injectors/ExternalizedPathInjectorTest.java
 ##
 @@ -0,0 +1,128 @@
+package org.apache.sling.models.impl.injectors;
+
+import org.apache.sling.api.resource.Resource;
+import org.apache.sling.api.resource.ResourceResolver;
+import org.apache.sling.api.resource.ValueMap;
+import org.apache.sling.models.annotations.ExternalizePath;
+import 
org.apache.sling.models.annotations.injectorspecific.ExternalizedPathProvider;
+import org.apache.sling.models.spi.DisposalCallbackRegistry;
+import org.jetbrains.annotations.NotNull;
+import org.junit.Test;
+
+import java.lang.reflect.AnnotatedElement;
+import java.lang.reflect.Type;
+
+import static org.junit.Assert.assertEquals;
+import static org.mockito.Matchers.eq;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+
+public class ExternalizedPathInjectorTest {
+
+@Test
+public void testNoResolveInjection() {
+String imagePath = "/content/test/image/test-image.jpg";
+
+ExternalizedPathInjector injector = new ExternalizedPathInjector();
+Resource adaptable = mock(Resource.class);
+ValueMap valueMap = mock(ValueMap.class);
+when(adaptable.adaptTo(eq(ValueMap.class))).thenReturn(valueMap);
+String name = "imagePath";
+when(valueMap.get(eq(name), eq(String.class))).thenReturn(imagePath);
+Type type = String.class;
+AnnotatedElement element = mock(AnnotatedElement.class);
+
when(element.isAnnotationPresent(eq(ExternalizePath.class))).thenReturn(true);
+DisposalCallbackRegistry callbackRegistry = 
mock(DisposalCallbackRegistry.class);
+ResourceResolver resourceResolver = mock(ResourceResolver.class);
+when(adaptable.getResourceResolver()).thenReturn(resourceResolver);
+when(resourceResolver.map(imagePath)).thenReturn(imagePath);
+
+Object value = injector.getValue(adaptable, name, type, element, 
callbackRegistry);
+assertEquals("No Mapping was expected", imagePath, value);
+}
+
+@Test
+public void testResolveInjection() {
+String imagePath = "/content/test/image/test-image.jpg";
+String mappedImagePath = "/image/test-image.jpg";
+
+ExternalizedPathInjector injector = new ExternalizedPathInjector();
+Resource adaptable = mock(Resource.class);
+ValueMap valueMap = mock(ValueMap.class);
+when(adaptable.adaptTo(eq(ValueMap.class))).thenReturn(valueMap);
+String name = "imagePath";
+when(valueMap.get(eq(name), eq(String.class))).thenReturn(imagePath);
+Type type = String.class;
+AnnotatedElement element = mock(AnnotatedElement.class);
+
when(element.isAnnotationPresent(eq(ExternalizePath.class))).thenReturn(true);
+DisposalCallbackRegistry callbackRegistry = 
mock(DisposalCallbackRegistry.class);
+ResourceResolver resourceResolver = mock(ResourceResolver.class);
+when(adaptable.getResourceResolver()).thenReturn(resourceResolver);
+when(resourceResolver.map(imagePath)).thenReturn(mappedImagePath);
+
+Object value = injector.getValue(adaptable, name, type, element, 
callbackRegistry);
+assertEquals("Mapping was expected", mappedImagePath, value);
+}
+
+@Test
+public void testCustomProviderInjection() {
+String imagePath = "/content/test/image/test-image.jpg";
+String from = "/content/test/image/";
+String to1 = "/image1/";
+String to2 = "/image2/";
+String to3 = "/image3/";
+String mappedImagePath = "/image/test-image.jpg";
+String mappedImagePath1 = "/image1/test-image.jpg";
+String mappedImagePath2 = "/image2/test-image.jpg";
+String mappedImagePath3 = "/image3/test-image.jpg";
+
+ExternalizedPathInjector injector = new ExternalizedPathInjector();
+Resource adaptable = mock(Resource.class);
+ValueMap valueMap = mock(ValueMap.class);
+when(adaptable.adaptTo(eq(ValueMap.class))).thenReturn(valueMap);
+String name = "imagePath";
+when(valueMap.get(eq(name), eq(String.class))).thenReturn(imagePath);
+Type type = String.class;
+AnnotatedElement element = mock(AnnotatedElement.class);
+
when(element.isAnnotationPresent(eq(ExternalizePath.class))).thenReturn(true);
+DisposalCallbackRegistry callbackRegistry = 
mock(DisposalCallbackRegistry.class);
+ResourceResolver resourceResolver = mock(ResourceResolver.class);
+when(adaptable.getResourceResolver()).thenReturn(resourceResolver);
+when(resourceResolver.map(imagePath)).thenReturn(mappedImagePath);
+
+TestExternalizedPathProvider provider

[GitHub] [sling-org-apache-sling-models-impl] schaefa commented on a change in pull request #14: SLING-8655 - Updated dependency on API, provided Externalized Path In…

[GitBox]

schaefa commented on a change in pull request #14: SLING-8655 - Updated 
dependency on API, provided Externalized Path In…
URL: 
https://github.com/apache/sling-org-apache-sling-models-impl/pull/14#discussion_r317823600
 
 

 ##
 File path: 
src/main/java/org/apache/sling/models/impl/injectors/ExternalizedPathInjector.java
 ##
 @@ -0,0 +1,113 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.sling.models.impl.injectors;
+
+import org.apache.commons.lang3.ObjectUtils;
+import org.apache.sling.api.resource.ResourceResolver;
+import org.apache.sling.api.resource.ValueMap;
+import org.apache.sling.models.annotations.ExternalizePath;
+import 
org.apache.sling.models.annotations.injectorspecific.ExternalizedPathProvider;
+import org.apache.sling.models.spi.DisposalCallbackRegistry;
+import org.apache.sling.models.spi.Injector;
+import org.jetbrains.annotations.NotNull;
+import org.osgi.framework.Constants;
+import org.osgi.service.component.annotations.Component;
+import org.osgi.service.component.annotations.Reference;
+import org.osgi.service.component.annotations.ReferenceCardinality;
+import org.osgi.service.component.annotations.ReferencePolicy;
+
+import java.lang.reflect.AnnotatedElement;
+import java.lang.reflect.Type;
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.Comparator;
+import java.util.List;
+
+@Component(
+property=Constants.SERVICE_RANKING+":Integer=1000",
+service={
+Injector.class
+}
+)
+public class ExternalizedPathInjector
+extends AbstractInjector
+implements Injector
+{
+List providerList = new ArrayList<>();
+
+@Reference(policy = ReferencePolicy.DYNAMIC, cardinality = 
ReferenceCardinality.OPTIONAL)
+void bindExternalizedPathProvider(ExternalizedPathProvider provider) {
+providerList.add(provider);
+// The providers are sorted so that the one with the highest priority 
is the first entry
+Collections.sort(
+providerList,
+
Comparator.comparingInt(ExternalizedPathProvider::getPriority).reversed()
+);
+}
+
+void unbindExternalizedPathProvider(ExternalizedPathProvider provider) {
+providerList.remove(provider);
+}
+
+public ExternalizedPathInjector() {
+bindExternalizedPathProvider(new DefaultExternalizedPathProvider());
+}
+
+@Override
+public @NotNull String getName() {
+return "externalize-path";
+}
+
+@Override
+public Object getValue(@NotNull Object adaptable, String name, @NotNull 
Type type, @NotNull AnnotatedElement element,
+@NotNull DisposalCallbackRegistry callbackRegistry) {
+if (adaptable == ObjectUtils.NULL) {
+return null;
+}
+if (element.isAnnotationPresent(ExternalizePath.class)) {
+ValueMap properties = getValueMap(adaptable);
+if(properties != ObjectUtils.NULL) {
 
 Review comment:
   Fixed that


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [sling-org-apache-sling-models-impl] schaefa commented on a change in pull request #14: SLING-8655 - Updated dependency on API, provided Externalized Path In…

[GitBox]

schaefa commented on a change in pull request #14: SLING-8655 - Updated 
dependency on API, provided Externalized Path In…
URL: 
https://github.com/apache/sling-org-apache-sling-models-impl/pull/14#discussion_r317823448
 
 

 ##
 File path: 
src/main/java/org/apache/sling/models/impl/injectors/ExternalizedPathInjector.java
 ##
 @@ -0,0 +1,113 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.sling.models.impl.injectors;
+
+import org.apache.commons.lang3.ObjectUtils;
+import org.apache.sling.api.resource.ResourceResolver;
+import org.apache.sling.api.resource.ValueMap;
+import org.apache.sling.models.annotations.ExternalizePath;
+import 
org.apache.sling.models.annotations.injectorspecific.ExternalizedPathProvider;
+import org.apache.sling.models.spi.DisposalCallbackRegistry;
+import org.apache.sling.models.spi.Injector;
+import org.jetbrains.annotations.NotNull;
+import org.osgi.framework.Constants;
+import org.osgi.service.component.annotations.Component;
+import org.osgi.service.component.annotations.Reference;
+import org.osgi.service.component.annotations.ReferenceCardinality;
+import org.osgi.service.component.annotations.ReferencePolicy;
+
+import java.lang.reflect.AnnotatedElement;
+import java.lang.reflect.Type;
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.Comparator;
+import java.util.List;
+
+@Component(
+property=Constants.SERVICE_RANKING+":Integer=1000",
+service={
+Injector.class
+}
+)
+public class ExternalizedPathInjector
+extends AbstractInjector
+implements Injector
+{
+List providerList = new ArrayList<>();
+
+@Reference(policy = ReferencePolicy.DYNAMIC, cardinality = 
ReferenceCardinality.OPTIONAL)
+void bindExternalizedPathProvider(ExternalizedPathProvider provider) {
+providerList.add(provider);
+// The providers are sorted so that the one with the highest priority 
is the first entry
+Collections.sort(
+providerList,
+
Comparator.comparingInt(ExternalizedPathProvider::getPriority).reversed()
+);
+}
+
+void unbindExternalizedPathProvider(ExternalizedPathProvider provider) {
+providerList.remove(provider);
+}
+
+public ExternalizedPathInjector() {
+bindExternalizedPathProvider(new DefaultExternalizedPathProvider());
+}
+
+@Override
+public @NotNull String getName() {
+return "externalize-path";
+}
+
+@Override
+public Object getValue(@NotNull Object adaptable, String name, @NotNull 
Type type, @NotNull AnnotatedElement element,
+@NotNull DisposalCallbackRegistry callbackRegistry) {
+if (adaptable == ObjectUtils.NULL) {
+return null;
+}
+if (element.isAnnotationPresent(ExternalizePath.class)) {
+ValueMap properties = getValueMap(adaptable);
+if(properties != ObjectUtils.NULL) {
+String imagePath = properties.get(name, String.class);
+if(imagePath != null) {
+ExternalizedPathProvider provider = providerList.get(0);
+return provider.externalize(adaptable, imagePath);
+}
+}
+}
+return null;
+}
+
+/** Fallback Implementation of the Externalized Path Provider that uses 
the Resource Resolver's map function **/
+private class DefaultExternalizedPathProvider
 
 Review comment:
   Moved this to be an regular OSGi Component


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [sling-org-apache-sling-models-impl] schaefa commented on a change in pull request #14: SLING-8655 - Updated dependency on API, provided Externalized Path In…

[GitBox]

schaefa commented on a change in pull request #14: SLING-8655 - Updated 
dependency on API, provided Externalized Path In…
URL: 
https://github.com/apache/sling-org-apache-sling-models-impl/pull/14#discussion_r317823534
 
 

 ##
 File path: 
src/main/java/org/apache/sling/models/impl/injectors/ExternalizedPathInjector.java
 ##
 @@ -0,0 +1,113 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.sling.models.impl.injectors;
+
+import org.apache.commons.lang3.ObjectUtils;
+import org.apache.sling.api.resource.ResourceResolver;
+import org.apache.sling.api.resource.ValueMap;
+import org.apache.sling.models.annotations.ExternalizePath;
+import 
org.apache.sling.models.annotations.injectorspecific.ExternalizedPathProvider;
+import org.apache.sling.models.spi.DisposalCallbackRegistry;
+import org.apache.sling.models.spi.Injector;
+import org.jetbrains.annotations.NotNull;
+import org.osgi.framework.Constants;
+import org.osgi.service.component.annotations.Component;
+import org.osgi.service.component.annotations.Reference;
+import org.osgi.service.component.annotations.ReferenceCardinality;
+import org.osgi.service.component.annotations.ReferencePolicy;
+
+import java.lang.reflect.AnnotatedElement;
+import java.lang.reflect.Type;
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.Comparator;
+import java.util.List;
+
+@Component(
+property=Constants.SERVICE_RANKING+":Integer=1000",
+service={
+Injector.class
+}
+)
+public class ExternalizedPathInjector
+extends AbstractInjector
+implements Injector
+{
+List providerList = new ArrayList<>();
+
+@Reference(policy = ReferencePolicy.DYNAMIC, cardinality = 
ReferenceCardinality.OPTIONAL)
+void bindExternalizedPathProvider(ExternalizedPathProvider provider) {
+providerList.add(provider);
+// The providers are sorted so that the one with the highest priority 
is the first entry
+Collections.sort(
+providerList,
+
Comparator.comparingInt(ExternalizedPathProvider::getPriority).reversed()
 
 Review comment:
   Used RankedServices as suggested


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: [VOTE] Release Apache Sling Starter Content 1.0.6, Apache Sling Dynamic Include 3.1.6, Apache Sling Form Based Authentication 1.0.16

[Daniel Klco]

+1

On Mon, Aug 26, 2019 at 12:35 PM Robert Munteanu  wrote:

> On Mon, 2019-08-26 at 17:52 +0200, Georg Henzler wrote:
> > P.S. There are two issues that are not resolved and should
> > be moved to the next version in JIRA (not a problem for this
> > release though IMHO):
> >
> > Version Dynamic Include 3.1.6
> > https://issues.apache.org/jira/projects/SLING/versions/12345726
>
> Thanks, Georg - I've moved them to the next version.
>
> Robert
>
>

[jira] [Resolved] (SLING-8661) Moving Jira issues to next version fails with 405 status code

[Robert Munteanu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-8661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-8661.

  Assignee: Robert Munteanu
Resolution: Fixed

Fixed with [sling-org-apache-sling-committer-cli commit 
4bc0019|https://github.com/apache/sling-org-apache-sling-committer-cli/commit/4bc0019]


> Moving Jira issues to next version fails with 405 status code
> -
>
> Key: SLING-8661
> URL: https://issues.apache.org/jira/browse/SLING-8661
> Project: Sling
>  Issue Type: Bug
>  Components: Build and Source Control
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Committer CLI 1.0.0
>
>
> {noformat}Found Version: Dynamic Include 3.1.6 (id=12345726, fixed issues=3).
> Should version Dynamic Include 3.1.8 be created?
> Yes (y)/No (n)? [Yes (y)]: y
> Created version Dynamic Include 3.1.8
> Should the 2 unresolved issue(s) from version Dynamic Include 3.1.6 be moved 
> to version Dynamic Include 3.1.8?
> Yes (y)/No (n)? [Yes (y)]: y
> Moving the following issues from Dynamic Include 3.1.6 to Dynamic Include 
> 3.1.8.
> - SLING-8427 : Sling Dynamic Include - TTL not being set on synthetic 
> resources
> - SLING-8255 : Use of mappings in SDI
> java.lang.RuntimeException: java.io.IOException: Status line : HTTP/1.1 405 
> 405
>   at 
> org.apache.sling.cli.impl.jira.VersionClient.moveIssueToNewVersion(VersionClient.java:351)
>   at 
> org.apache.sling.cli.impl.jira.VersionClient.lambda$moveIssuesToNewVersion$5(VersionClient.java:324)
>   at 
> java.base/java.util.ArrayList$ArrayListSpliterator.forEachRemaining(Unknown 
> Source)
>   at java.base/java.util.stream.ReferencePipeline$Head.forEach(Unknown 
> Source)
>   at 
> org.apache.sling.cli.impl.jira.VersionClient.moveIssuesToNewVersion(VersionClient.java:324)
>   at 
> org.apache.sling.cli.impl.release.CreateJiraVersionCommand.run(CreateJiraVersionCommand.java:117)
>   at picocli.CommandLine.executeUserObject(CommandLine.java:1687)
>   at picocli.CommandLine.access$900(CommandLine.java:146)
>   at picocli.CommandLine$RunLast.handle(CommandLine.java:2059)
>   at picocli.CommandLine$RunLast.handle(CommandLine.java:2026)
>   at 
> picocli.CommandLine$AbstractParseResultHandler.execute(CommandLine.java:1893)
>   at picocli.CommandLine.execute(CommandLine.java:1822)
>   at 
> org.apache.sling.cli.impl.CommandProcessor.runCommand(CommandProcessor.java:110)
>   at 
> org.apache.sling.cli.impl.ExecutionTrigger.lambda$activate$0(ExecutionTrigger.java:33)
>   at java.base/java.lang.Thread.run(Unknown Source)
> Caused by: java.io.IOException: Status line : HTTP/1.1 405 405
>   at 
> org.apache.sling.cli.impl.jira.VersionClient.newException(VersionClient.java:245)
>   at 
> org.apache.sling.cli.impl.jira.VersionClient.moveIssueToNewVersion(VersionClient.java:345)
>   ... 14 more{noformat}



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

Re: [VOTE] Release Apache Sling Starter Content 1.0.6, Apache Sling Dynamic Include 3.1.6, Apache Sling Form Based Authentication 1.0.16

[Robert Munteanu]

On Mon, 2019-08-26 at 17:52 +0200, Georg Henzler wrote:
> P.S. There are two issues that are not resolved and should
> be moved to the next version in JIRA (not a problem for this
> release though IMHO):
> 
> Version Dynamic Include 3.1.6
> https://issues.apache.org/jira/projects/SLING/versions/12345726

Thanks, Georg - I've moved them to the next version.

Robert

[jira] [Updated] (SLING-8255) Use of mappings in SDI

[Robert Munteanu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-8255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-8255:
---
Fix Version/s: (was: Dynamic Include 3.1.6)
   Dynamic Include 3.1.8

> Use of mappings in SDI
> --
>
> Key: SLING-8255
> URL: https://issues.apache.org/jira/browse/SLING-8255
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: Dynamic Include 3.1.2
>Reporter: Michał Tobiasz
>Priority: Minor
> Fix For: Dynamic Include 3.1.8
>
>
> Hello,
> It would be great to consider using mappings for SDI. In our case, we would 
> like to configure mappings for snippets to use a different format (short 
> names).
>  
> [~rombert]  what do you think of using ResourceResolver#map when building URL.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

Re: [VOTE] Accept the donation of the Sling Packager tool, SLING-8584

[Daniel Klco]

+1

On Mon, Aug 26, 2019, 12:08 PM Carsten Ziegeler 
wrote:

> +1
>
> Carsten
>
> Am 26.08.2019 um 16:42 schrieb Robert Munteanu:
> > Hi,
> >
> > Please vote to accept the donation of the Sling Packager module
> > described in SLING-8584 [1].
> >
> > This majority vote is open for at least 72 hours.
> >
> > Thanks,
> >
> > Robert
> >
> > [1]: https://issues.apache.org/jira/browse/SLING-8584
> >
>
> --
> --
> Carsten Ziegeler
> Adobe Research Switzerland
> cziege...@apache.org
>

[jira] [Updated] (SLING-8427) Sling Dynamic Include - TTL not being set on synthetic resources

[Robert Munteanu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-8427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-8427:
---
Fix Version/s: (was: Dynamic Include 3.1.6)
   Dynamic Include 3.1.8

> Sling Dynamic Include - TTL not being set on synthetic resources
> 
>
> Key: SLING-8427
> URL: https://issues.apache.org/jira/browse/SLING-8427
> Project: Sling
>  Issue Type: Bug
>Affects Versions: Dynamic Include 3.1.2
> Environment: AEM 6.3 - AEM 6.5
>Reporter: Eric Van Geem
>Priority: Major
> Fix For: Dynamic Include 3.1.8
>
>
> When a TTL value is configured, the Cache-Control header does not get set in 
> the response headers of the resource when the resource is synthetic. 
> *Expected behavior:*
> The existing SyntheticResourceFilter is responsible for identifying if the 
> requested resource is synthetic, and if so, force the resourceType into the 
> request by taking the resourceType from the request URL suffix. Then, the 
> CacheControlFilter is to be invoked after this which reads the resource from 
> the request (now the forced resourceType from the prior step) and sets the 
> appropriate Cache-Control header if this resourceType is configured for SDI.
> *Actual behavior:*
> The CacheControlFilter is never executed after the SyntheticResourceFilter 
> sets the forced resourceType in the request for the synthetic resource, thus 
> the Cache-Control response header never gets set. 
>  
> More details:
> I believe the cause of this issue is due to the way the CacheControlFilter's 
> filter scope is defined; it is missing the *forward* filter scope. The 
> SyntheticResourceFilter forces the resourceType by passing a new object of 
> options to the request dispatcher 
> {code:java}
> dispatcher = slingRequest.getRequestDispatcher(resource, options);{code}
> This is then followed by a call to 
> {code:java}
> dispatcher.forward(request, response);{code}
> to forward the request in the filter chain.
> This is where the CacheControlFilter should receive the request, but does not 
> happen because the CacheControlFilter's filter scope has not been declared to 
> receive forwarded requests. Simply adding the *forward* scope to the 
> CacheControlFilter's list of scopes seems to resolve the issue.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

[jira] [Updated] (SLING-6779) The HTL compiler and Maven Plugin should warn when using potentially invalid options

[Radu Cotescu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-6779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radu Cotescu updated SLING-6779:

Issue Type: New Feature  (was: Bug)

> The HTL compiler and Maven Plugin should warn when using potentially invalid 
> options
> 
>
> Key: SLING-6779
> URL: https://issues.apache.org/jira/browse/SLING-6779
> Project: Sling
>  Issue Type: New Feature
>  Components: Scripting
>Affects Versions: Scripting HTL Compiler 1.0.0, HTL Maven Plugin 1.0.6
>Reporter: Feike Visser
>Assignee: Radu Cotescu
>Priority: Major
> Fix For: Scripting HTL Compiler 1.2.0-1.4.0, HTL Maven Plugin 
> 1.3.0-1.4.0, Scripting HTL Engine 1.2.0-1.4.0, Scripting HTL Testing 
> 1.0.18-1.4.0
>
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> I have the following code 
> {code}
> ${currentPage.title @ contex = 'scriptString'}
> {code}
> No warning or error is given for the wrong option @ contex



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

[jira] [Updated] (SLING-8471) Update the HTL modules to the Sling bundle parent pom 35

[Radu Cotescu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-8471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radu Cotescu updated SLING-8471:

Issue Type: Task  (was: Improvement)

> Update the HTL modules to the Sling bundle parent pom 35
> 
>
> Key: SLING-8471
> URL: https://issues.apache.org/jira/browse/SLING-8471
> Project: Sling
>  Issue Type: Task
>  Components: Scripting
>Reporter: Radu Cotescu
>Assignee: Radu Cotescu
>Priority: Major
> Fix For: Scripting HTL Compiler 1.2.0-1.4.0, HTL Maven Plugin 
> 1.3.0-1.4.0, Scripting HTL Engine 1.2.0-1.4.0, Scripting HTL Testing 
> 1.0.18-1.4.0, Scripting HTL Java Compiler 1.1.4-1.4.0, Scripting HTL JS Use 
> Provider 1.0.30, Scripting HTL Runtime 1.1.2-1.4.0, Scripting HTL Models Use 
> Provider 1.0.10, Scripting HTL Testing Content 1.0.16-1.4.0
>
>
> This update would bring support for building these modules with Java 11.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

[jira] [Resolved] (SLING-8660) Add optional support for precompiled scripts in the HTL engine

[Radu Cotescu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-8660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radu Cotescu resolved SLING-8660.
-
Resolution: Fixed

Implemented in [commit 
d709c52|[https://github.com/apache/sling-org-apache-sling-scripting-sightly/commit/d709c52].|https://github.com/apache/sling-org-apache-sling-scripting-sightly/commit/d709c52],]

> Add optional support for precompiled scripts in the HTL engine
> --
>
> Key: SLING-8660
> URL: https://issues.apache.org/jira/browse/SLING-8660
> Project: Sling
>  Issue Type: New Feature
>  Components: Scripting
>Reporter: Radu Cotescu
>Assignee: Radu Cotescu
>Priority: Major
> Fix For: Scripting HTL Engine 1.2.0-1.4.0
>
>
> With the help of the 
> {{[org.apache.sling.scripting.bundle.tracker|https://github.com/apache/sling-org-apache-sling-scripting-bundle-tracker]}}
>  module developers can deploy precompiled scripts on a Sling instance. The 
> HTL engine should be extended to provide support for executing these 
> precompiled scripts if the mentioned bundle tracker is also present.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

[jira] [Updated] (SLING-8661) Moving Jira issues to next version fails with 405 status code

[Robert Munteanu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-8661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-8661:
---
Summary: Moving Jira issues to next version fails with 405 status code  
(was: Moving Jira issues not next version fails with 405 status code)

> Moving Jira issues to next version fails with 405 status code
> -
>
> Key: SLING-8661
> URL: https://issues.apache.org/jira/browse/SLING-8661
> Project: Sling
>  Issue Type: Bug
>  Components: Build and Source Control
>Reporter: Robert Munteanu
>Priority: Major
> Fix For: Committer CLI 1.0.0
>
>
> {noformat}Found Version: Dynamic Include 3.1.6 (id=12345726, fixed issues=3).
> Should version Dynamic Include 3.1.8 be created?
> Yes (y)/No (n)? [Yes (y)]: y
> Created version Dynamic Include 3.1.8
> Should the 2 unresolved issue(s) from version Dynamic Include 3.1.6 be moved 
> to version Dynamic Include 3.1.8?
> Yes (y)/No (n)? [Yes (y)]: y
> Moving the following issues from Dynamic Include 3.1.6 to Dynamic Include 
> 3.1.8.
> - SLING-8427 : Sling Dynamic Include - TTL not being set on synthetic 
> resources
> - SLING-8255 : Use of mappings in SDI
> java.lang.RuntimeException: java.io.IOException: Status line : HTTP/1.1 405 
> 405
>   at 
> org.apache.sling.cli.impl.jira.VersionClient.moveIssueToNewVersion(VersionClient.java:351)
>   at 
> org.apache.sling.cli.impl.jira.VersionClient.lambda$moveIssuesToNewVersion$5(VersionClient.java:324)
>   at 
> java.base/java.util.ArrayList$ArrayListSpliterator.forEachRemaining(Unknown 
> Source)
>   at java.base/java.util.stream.ReferencePipeline$Head.forEach(Unknown 
> Source)
>   at 
> org.apache.sling.cli.impl.jira.VersionClient.moveIssuesToNewVersion(VersionClient.java:324)
>   at 
> org.apache.sling.cli.impl.release.CreateJiraVersionCommand.run(CreateJiraVersionCommand.java:117)
>   at picocli.CommandLine.executeUserObject(CommandLine.java:1687)
>   at picocli.CommandLine.access$900(CommandLine.java:146)
>   at picocli.CommandLine$RunLast.handle(CommandLine.java:2059)
>   at picocli.CommandLine$RunLast.handle(CommandLine.java:2026)
>   at 
> picocli.CommandLine$AbstractParseResultHandler.execute(CommandLine.java:1893)
>   at picocli.CommandLine.execute(CommandLine.java:1822)
>   at 
> org.apache.sling.cli.impl.CommandProcessor.runCommand(CommandProcessor.java:110)
>   at 
> org.apache.sling.cli.impl.ExecutionTrigger.lambda$activate$0(ExecutionTrigger.java:33)
>   at java.base/java.lang.Thread.run(Unknown Source)
> Caused by: java.io.IOException: Status line : HTTP/1.1 405 405
>   at 
> org.apache.sling.cli.impl.jira.VersionClient.newException(VersionClient.java:245)
>   at 
> org.apache.sling.cli.impl.jira.VersionClient.moveIssueToNewVersion(VersionClient.java:345)
>   ... 14 more{noformat}



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

[jira] [Updated] (SLING-8661) Moving Jira issues not next version fails with 405 status code

[Robert Munteanu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-8661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-8661:
---
Summary: Moving Jira issues not next version fails with 405 status code  
(was: Migrating Jira issues not next version fails with 405 status code)

> Moving Jira issues not next version fails with 405 status code
> --
>
> Key: SLING-8661
> URL: https://issues.apache.org/jira/browse/SLING-8661
> Project: Sling
>  Issue Type: Bug
>  Components: Build and Source Control
>Reporter: Robert Munteanu
>Priority: Major
> Fix For: Committer CLI 1.0.0
>
>
> {noformat}Found Version: Dynamic Include 3.1.6 (id=12345726, fixed issues=3).
> Should version Dynamic Include 3.1.8 be created?
> Yes (y)/No (n)? [Yes (y)]: y
> Created version Dynamic Include 3.1.8
> Should the 2 unresolved issue(s) from version Dynamic Include 3.1.6 be moved 
> to version Dynamic Include 3.1.8?
> Yes (y)/No (n)? [Yes (y)]: y
> Moving the following issues from Dynamic Include 3.1.6 to Dynamic Include 
> 3.1.8.
> - SLING-8427 : Sling Dynamic Include - TTL not being set on synthetic 
> resources
> - SLING-8255 : Use of mappings in SDI
> java.lang.RuntimeException: java.io.IOException: Status line : HTTP/1.1 405 
> 405
>   at 
> org.apache.sling.cli.impl.jira.VersionClient.moveIssueToNewVersion(VersionClient.java:351)
>   at 
> org.apache.sling.cli.impl.jira.VersionClient.lambda$moveIssuesToNewVersion$5(VersionClient.java:324)
>   at 
> java.base/java.util.ArrayList$ArrayListSpliterator.forEachRemaining(Unknown 
> Source)
>   at java.base/java.util.stream.ReferencePipeline$Head.forEach(Unknown 
> Source)
>   at 
> org.apache.sling.cli.impl.jira.VersionClient.moveIssuesToNewVersion(VersionClient.java:324)
>   at 
> org.apache.sling.cli.impl.release.CreateJiraVersionCommand.run(CreateJiraVersionCommand.java:117)
>   at picocli.CommandLine.executeUserObject(CommandLine.java:1687)
>   at picocli.CommandLine.access$900(CommandLine.java:146)
>   at picocli.CommandLine$RunLast.handle(CommandLine.java:2059)
>   at picocli.CommandLine$RunLast.handle(CommandLine.java:2026)
>   at 
> picocli.CommandLine$AbstractParseResultHandler.execute(CommandLine.java:1893)
>   at picocli.CommandLine.execute(CommandLine.java:1822)
>   at 
> org.apache.sling.cli.impl.CommandProcessor.runCommand(CommandProcessor.java:110)
>   at 
> org.apache.sling.cli.impl.ExecutionTrigger.lambda$activate$0(ExecutionTrigger.java:33)
>   at java.base/java.lang.Thread.run(Unknown Source)
> Caused by: java.io.IOException: Status line : HTTP/1.1 405 405
>   at 
> org.apache.sling.cli.impl.jira.VersionClient.newException(VersionClient.java:245)
>   at 
> org.apache.sling.cli.impl.jira.VersionClient.moveIssueToNewVersion(VersionClient.java:345)
>   ... 14 more{noformat}



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

[jira] [Created] (SLING-8661) Migrating Jira issues not next version fails with 405 status code

[Robert Munteanu (Jira)]

Robert Munteanu created SLING-8661:
--

 Summary: Migrating Jira issues not next version fails with 405 
status code
 Key: SLING-8661
 URL: https://issues.apache.org/jira/browse/SLING-8661
 Project: Sling
  Issue Type: Bug
  Components: Build and Source Control
Reporter: Robert Munteanu
 Fix For: Committer CLI 1.0.0


{noformat}Found Version: Dynamic Include 3.1.6 (id=12345726, fixed issues=3).
Should version Dynamic Include 3.1.8 be created?
Yes (y)/No (n)? [Yes (y)]: y
Created version Dynamic Include 3.1.8
Should the 2 unresolved issue(s) from version Dynamic Include 3.1.6 be moved to 
version Dynamic Include 3.1.8?
Yes (y)/No (n)? [Yes (y)]: y
Moving the following issues from Dynamic Include 3.1.6 to Dynamic Include 3.1.8.
- SLING-8427 : Sling Dynamic Include - TTL not being set on synthetic resources
- SLING-8255 : Use of mappings in SDI
java.lang.RuntimeException: java.io.IOException: Status line : HTTP/1.1 405 405
at 
org.apache.sling.cli.impl.jira.VersionClient.moveIssueToNewVersion(VersionClient.java:351)
at 
org.apache.sling.cli.impl.jira.VersionClient.lambda$moveIssuesToNewVersion$5(VersionClient.java:324)
at 
java.base/java.util.ArrayList$ArrayListSpliterator.forEachRemaining(Unknown 
Source)
at java.base/java.util.stream.ReferencePipeline$Head.forEach(Unknown 
Source)
at 
org.apache.sling.cli.impl.jira.VersionClient.moveIssuesToNewVersion(VersionClient.java:324)
at 
org.apache.sling.cli.impl.release.CreateJiraVersionCommand.run(CreateJiraVersionCommand.java:117)
at picocli.CommandLine.executeUserObject(CommandLine.java:1687)
at picocli.CommandLine.access$900(CommandLine.java:146)
at picocli.CommandLine$RunLast.handle(CommandLine.java:2059)
at picocli.CommandLine$RunLast.handle(CommandLine.java:2026)
at 
picocli.CommandLine$AbstractParseResultHandler.execute(CommandLine.java:1893)
at picocli.CommandLine.execute(CommandLine.java:1822)
at 
org.apache.sling.cli.impl.CommandProcessor.runCommand(CommandProcessor.java:110)
at 
org.apache.sling.cli.impl.ExecutionTrigger.lambda$activate$0(ExecutionTrigger.java:33)
at java.base/java.lang.Thread.run(Unknown Source)
Caused by: java.io.IOException: Status line : HTTP/1.1 405 405
at 
org.apache.sling.cli.impl.jira.VersionClient.newException(VersionClient.java:245)
at 
org.apache.sling.cli.impl.jira.VersionClient.moveIssueToNewVersion(VersionClient.java:345)
... 14 more{noformat}



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

Re: [VOTE] Release Apache Sling Health Check Core 2.0.0, Sling Health Check Web Console 2.0.0

[Georg Henzler]

Interesting thought - I didn't think about using [1].

I think it is fine though, since those two bundles should
never be referenced via maven directly - rather they are
part of a runtime (as e.g. compiled by the provisioning
model [2] or the feature model). For those non-pom
references, I don't think the metadata from [1] would
be picked up.

I included a different mechanism though: By explicitly
referencing the new Felix HC API [3] the new bundles only
start if the Felix API bundle is installed - so anybody
blindly upgrading to apache-sling-hc-core|webconsole
2.0.0 will get unstarted bundles showing the missing
Felix HC API package - that should be pointer enough to
find the migration guide [4].

-Georg


[1] https://maven.apache.org/guides/mini/guide-relocation.html

[2] 
https://github.com/apache/sling-org-apache-sling-starter/blob/master/src/main/provisioning/healthcheck.txt


[3] 
https://github.com/apache/sling-org-apache-sling-hc-core/blob/b0cfe3c8f7fdc1790f8c16bc075967f12ce33686/src/main/java/org/apache/sling/hc/core/impl/NoopHcCore.java#L33


[4] 
https://sling.apache.org/documentation/bundles/sling-health-check-tool.html


On 2019-08-26 10:04, Konrad Windszus wrote:

Yes, Felix HC. This is a drop in replacement at least for these two
bundles IMHO (although the API package has changed).
Konrad

On 26. Aug 2019, at 10:01, Stefan Seifert  
wrote:


relocate to what - felix HC?
relocate makes only sense if the new target is a drop-in replacement - 
which is not the case with sling HC -> felix HC?


stefan


-Original Message-
From: Konrad Windszus [mailto:konra...@gmx.de]
Sent: Monday, August 26, 2019 9:51 AM
To: dev@sling.apache.org
Subject: Re: [VOTE] Release Apache Sling Health Check Core 2.0.0, 
Sling

Health Check Web Console 2.0.0

Hi Georg,
wouldn't it make sense to add a relocation section to this last 
release

(https://maven.apache.org/guides/mini/guide-relocation.html
)?
That way it would be even more obvious on how to migrate...
Konrad


On 22. Aug 2019, at 19:34, Georg Henzler  
wrote:


Hi,

We solved 1 issues in this release:
https://issues.apache.org/jira/browse/SLING-8653

There are no outstanding issues.

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2117/

You can use this UNIX script to download the release and verify the

signatures:

https://gitbox.apache.org/repos/asf?p=sling-tooling-

release.git;a=blob;f=check_staged_release.sh;hb=HEAD


Usage:
sh check_staged_release.sh 2117 /tmp/sling-staging

Please vote to approve this release:

[ ] +1 Approve the release
[ ]  0 Don't care
[ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

-Georg

Re: [VOTE] Release Apache Sling Starter Content 1.0.6, Apache Sling Dynamic Include 3.1.6, Apache Sling Form Based Authentication 1.0.16

[Carsten Ziegeler]

+1

Carsten

Am 26.08.2019 um 17:24 schrieb Robert Munteanu:

Hi,

We solved 5 issues in these releases:
https://issues.apache.org/jira/browse/SLING/fixforversion/12345545
https://issues.apache.org/jira/browse/SLING/fixforversion/12345726
https://issues.apache.org/jira/browse/SLING/fixforversion/12345544

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2119/

You can use this UNIX script to download the release and verify the signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2119 /tmp/sling-staging

Please vote to approve this release:

   [ ] +1 Approve the release
   [ ]  0 Don't care
   [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards,
Robert Munteanu



--
--
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

Re: [VOTE] Release Apache Sling Starter Content 1.0.6, Apache Sling Dynamic Include 3.1.6, Apache Sling Form Based Authentication 1.0.16

[Andreas Schaefer]

+1 (non-binding)

- Andy

> On Aug 26, 2019, at 8:24 AM, Robert Munteanu  wrote:
> 
> Hi,
> 
> We solved 5 issues in these releases:
> https://issues.apache.org/jira/browse/SLING/fixforversion/12345545
> https://issues.apache.org/jira/browse/SLING/fixforversion/12345726
> https://issues.apache.org/jira/browse/SLING/fixforversion/12345544
> 
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-2119/
> 
> You can use this UNIX script to download the release and verify the 
> signatures:
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
> 
> Usage:
> sh check_staged_release.sh 2119 /tmp/sling-staging
> 
> Please vote to approve this release:
> 
>  [ ] +1 Approve the release
>  [ ]  0 Don't care
>  [ ] -1 Don't release, because ...
> 
> This majority vote is open for at least 72 hours.
> 
> Regards,
> Robert Munteanu

Re: [VOTE] Accept the donation of the Sling Packager tool, SLING-8584

[Carsten Ziegeler]

+1

Carsten

Am 26.08.2019 um 16:42 schrieb Robert Munteanu:

Hi,

Please vote to accept the donation of the Sling Packager module
described in SLING-8584 [1].

This majority vote is open for at least 72 hours.

Thanks,

Robert

[1]: https://issues.apache.org/jira/browse/SLING-8584



--
--
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

Re: [VOTE] Release Apache Sling Starter Content 1.0.6, Apache Sling Dynamic Include 3.1.6, Apache Sling Form Based Authentication 1.0.16

[Georg Henzler]

+1 (checked signatures and build)

-Georg

P.S. There are two issues that are not resolved and should
be moved to the next version in JIRA (not a problem for this
release though IMHO):

Version Dynamic Include 3.1.6
https://issues.apache.org/jira/projects/SLING/versions/12345726


On 2019-08-26 17:24, Robert Munteanu wrote:

Hi,

We solved 5 issues in these releases:
https://issues.apache.org/jira/browse/SLING/fixforversion/12345545
https://issues.apache.org/jira/browse/SLING/fixforversion/12345726
https://issues.apache.org/jira/browse/SLING/fixforversion/12345544

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2119/

You can use this UNIX script to download the release and verify the 
signatures:

https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2119 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards,
Robert Munteanu

[jira] [Updated] (SLING-8660) Add optional support for precompiled scripts in the HTL engine

[Radu Cotescu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-8660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radu Cotescu updated SLING-8660:

Description: With the help of the 
{{[org.apache.sling.scripting.bundle.tracker|[https://github.com/apache/sling-org-apache-sling-scripting-bundle-tracker]]}}
 module developers can deploy precompiled scripts on a Sling instance. The HTL 
engine should be extended to provide support for executing these precompiled 
scripts if the mentioned bundle tracker is also present.  (was: With the help 
of the {{org.apache.sling.scripting.bundle.tracker}} component developers can 
deploy precompiled scripts on a Sling instance. The HTL engine should be 
extended to provide support for executing these precompiled scripts if the 
mentioned bundle tracker is also present.)

> Add optional support for precompiled scripts in the HTL engine
> --
>
> Key: SLING-8660
> URL: https://issues.apache.org/jira/browse/SLING-8660
> Project: Sling
>  Issue Type: New Feature
>  Components: Scripting
>Reporter: Radu Cotescu
>Priority: Major
> Fix For: Scripting HTL Engine 1.2.0-1.4.0
>
>
> With the help of the 
> {{[org.apache.sling.scripting.bundle.tracker|[https://github.com/apache/sling-org-apache-sling-scripting-bundle-tracker]]}}
>  module developers can deploy precompiled scripts on a Sling instance. The 
> HTL engine should be extended to provide support for executing these 
> precompiled scripts if the mentioned bundle tracker is also present.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

[jira] [Assigned] (SLING-8660) Add optional support for precompiled scripts in the HTL engine

[Radu Cotescu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-8660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radu Cotescu reassigned SLING-8660:
---

Assignee: Radu Cotescu

> Add optional support for precompiled scripts in the HTL engine
> --
>
> Key: SLING-8660
> URL: https://issues.apache.org/jira/browse/SLING-8660
> Project: Sling
>  Issue Type: New Feature
>  Components: Scripting
>Reporter: Radu Cotescu
>Assignee: Radu Cotescu
>Priority: Major
> Fix For: Scripting HTL Engine 1.2.0-1.4.0
>
>
> With the help of the 
> {{[org.apache.sling.scripting.bundle.tracker|https://github.com/apache/sling-org-apache-sling-scripting-bundle-tracker]}}
>  module developers can deploy precompiled scripts on a Sling instance. The 
> HTL engine should be extended to provide support for executing these 
> precompiled scripts if the mentioned bundle tracker is also present.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

[jira] [Updated] (SLING-8660) Add optional support for precompiled scripts in the HTL engine

[Radu Cotescu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-8660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radu Cotescu updated SLING-8660:

Description: With the help of the 
{{[org.apache.sling.scripting.bundle.tracker|https://github.com/apache/sling-org-apache-sling-scripting-bundle-tracker]}}
 module developers can deploy precompiled scripts on a Sling instance. The HTL 
engine should be extended to provide support for executing these precompiled 
scripts if the mentioned bundle tracker is also present.  (was: With the help 
of the 
{{[org.apache.sling.scripting.bundle.tracker|[https://github.com/apache/sling-org-apache-sling-scripting-bundle-tracker]]}}
 module developers can deploy precompiled scripts on a Sling instance. The HTL 
engine should be extended to provide support for executing these precompiled 
scripts if the mentioned bundle tracker is also present.)

> Add optional support for precompiled scripts in the HTL engine
> --
>
> Key: SLING-8660
> URL: https://issues.apache.org/jira/browse/SLING-8660
> Project: Sling
>  Issue Type: New Feature
>  Components: Scripting
>Reporter: Radu Cotescu
>Priority: Major
> Fix For: Scripting HTL Engine 1.2.0-1.4.0
>
>
> With the help of the 
> {{[org.apache.sling.scripting.bundle.tracker|https://github.com/apache/sling-org-apache-sling-scripting-bundle-tracker]}}
>  module developers can deploy precompiled scripts on a Sling instance. The 
> HTL engine should be extended to provide support for executing these 
> precompiled scripts if the mentioned bundle tracker is also present.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

[jira] [Created] (SLING-8660) Add optional support for precompiled scripts in the HTL engine

[Radu Cotescu (Jira)]

Radu Cotescu created SLING-8660:
---

 Summary: Add optional support for precompiled scripts in the HTL 
engine
 Key: SLING-8660
 URL: https://issues.apache.org/jira/browse/SLING-8660
 Project: Sling
  Issue Type: New Feature
  Components: Scripting
Reporter: Radu Cotescu
 Fix For: Scripting HTL Engine 1.2.0-1.4.0


With the help of the {{org.apache.sling.scripting.bundle.tracker}} component 
developers can deploy precompiled scripts on a Sling instance. The HTL engine 
should be extended to provide support for executing these precompiled scripts 
if the mentioned bundle tracker is also present.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

[jira] [Resolved] (SLING-8657) Remove the biz.aQute.bndlib dependency

[Radu Cotescu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-8657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radu Cotescu resolved SLING-8657.
-
Resolution: Fixed

Fixed in [commit 
76d9a40|https://github.com/apache/sling-org-apache-sling-scripting-bundle-tracker/commit/76d9a40].

> Remove the biz.aQute.bndlib dependency
> --
>
> Key: SLING-8657
> URL: https://issues.apache.org/jira/browse/SLING-8657
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Reporter: Radu Cotescu
>Assignee: Radu Cotescu
>Priority: Major
> Fix For: Scripting Bundle Tracker 0.1.0
>
>
> The Scripting Bundle Tracker makes use of the {{biz.aQute.bndlib}} library in 
> order to programatically generate a {{Provide-Capability}} header. However, 
> that library shadows some core OSGi annotations which should be consumed from 
> their respective libraries. Given that the 
> {{aQute.bnd.annotation.headers.ProvideCapability}} annotation can be replaced 
> with {{org.osgi.annotation.bundle.Capability}}, there's no reason to keep 
> {{biz.aQute.bndlib as a dependency.}}



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

[VOTE] Release Apache Sling Starter Content 1.0.6, Apache Sling Dynamic Include 3.1.6, Apache Sling Form Based Authentication 1.0.16

[Robert Munteanu]

Hi,

We solved 5 issues in these releases:
https://issues.apache.org/jira/browse/SLING/fixforversion/12345545
https://issues.apache.org/jira/browse/SLING/fixforversion/12345726
https://issues.apache.org/jira/browse/SLING/fixforversion/12345544

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2119/

You can use this UNIX script to download the release and verify the signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2119 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards,
Robert Munteanu

Re: [VOTE] Accept the donation of the Sling Packager tool, SLING-8584

[Andreas Schaefer]

+1

- Andy

> On Aug 26, 2019, at 7:42 AM, Robert Munteanu  wrote:
> 
> Hi,
> 
> Please vote to accept the donation of the Sling Packager module
> described in SLING-8584 [1].
> 
> This majority vote is open for at least 72 hours.
> 
> Thanks,
> 
> Robert
> 
> [1]: https://issues.apache.org/jira/browse/SLING-8584
> 

[jira] [Resolved] (SLING-8658) Update logo src location after changes for SLING-8615

[Robert Munteanu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-8658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-8658.

Resolution: Fixed

Fixed with [sling-org-apache-sling-auth-form commit 
a784767|https://github.com/apache/sling-org-apache-sling-auth-form/commit/a784767]


> Update logo src location after changes for SLING-8615
> -
>
> Key: SLING-8658
> URL: https://issues.apache.org/jira/browse/SLING-8658
> Project: Sling
>  Issue Type: Task
>  Components: Authentication
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Form Based Authentication 1.0.16
>
>
> With the changes to SLING-8615 the location of the Sling logo has changed and 
> the login link is broken.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

[jira] [Resolved] (SLING-8659) Use only https for links on login page

[Robert Munteanu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-8659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-8659.

Resolution: Fixed

Fixed with [sling-org-apache-sling-auth-form commit 
b2c5bdf|https://github.com/apache/sling-org-apache-sling-auth-form/commit/b2c5bdf]


> Use only https for links on login page
> --
>
> Key: SLING-8659
> URL: https://issues.apache.org/jira/browse/SLING-8659
> Project: Sling
>  Issue Type: Task
>  Components: Authentication
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Form Based Authentication 1.0.16
>
>
> The links to the Apache and Apache Sling websites are using http, and they 
> should be using https.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

[jira] [Updated] (SLING-8659) Use only https for links on login page

[Robert Munteanu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-8659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-8659:
---
Description: The links to the Apache and Apache Sling websites are using 
http, and they should be using https.

> Use only https for links on login page
> --
>
> Key: SLING-8659
> URL: https://issues.apache.org/jira/browse/SLING-8659
> Project: Sling
>  Issue Type: Task
>  Components: Authentication
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Form Based Authentication 1.0.16
>
>
> The links to the Apache and Apache Sling websites are using http, and they 
> should be using https.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

[jira] [Created] (SLING-8659) Use only https for links on login page

[Robert Munteanu (Jira)]

Robert Munteanu created SLING-8659:
--

 Summary: Use only https for links on login page
 Key: SLING-8659
 URL: https://issues.apache.org/jira/browse/SLING-8659
 Project: Sling
  Issue Type: Task
  Components: Authentication
Reporter: Robert Munteanu
Assignee: Robert Munteanu
 Fix For: Form Based Authentication 1.0.16






--
This message was sent by Atlassian Jira
(v8.3.2#803003)

[Jenkins] Sling » sling-org-apache-sling-launchpad-testing » master #288 is BROKEN

[Apache Jenkins Server]

[INFO] Results:
[INFO] 
[ERROR] Failures: 
[ERROR]   CreateUserTest.testAnonymousSelfRegistrationDisabled:271 
expected:<500> but was:<401>
[INFO] 
[ERROR] Tests run: 660, Failures: 1, Errors: 0, Skipped: 1
[INFO] 
[INFO] 
[INFO] --- slingstart-maven-plugin:1.7.16:stop (stop-container) @ 
org.apache.sling.launchpad.testing ---
[INFO] Stopping 1 Launchpad instances
[INFO] Stopping Launchpad '_-41000'
26.08.2019 14:53:12.944 *INFO * [Apache Sling Terminator] Java VM is shutting 
down
26.08.2019 14:53:12.944 *INFO * [Apache Sling Terminator] Stopping Apache Sling
Warning: Nashorn engine is planned to be removed from a future JDK release
26.08.2019 14:53:19.377 *INFO * [Sling Notifier] Apache Sling has been stopped
[INFO] 
[INFO] --- ianal-maven-plugin:1.0-alpha-1:verify-legal-files (default) @ 
org.apache.sling.launchpad.testing ---
WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by 
org.codehaus.groovy.reflection.CachedConstructor 
(file:/home/jenkins/.m2/repository/org/codehaus/groovy/groovy-all-minimal/1.5.6/groovy-all-minimal-1.5.6.jar)
 to constructor java.io.File(java.lang.String,java.io.File)
WARNING: Please consider reporting this to the maintainers of 
org.codehaus.groovy.reflection.CachedConstructor
WARNING: Use --illegal-access=warn to enable warnings of further illegal 
reflective access operations
WARNING: All illegal access operations will be denied in a future release
[INFO] Checking legal files in: 
org.apache.sling.launchpad.testing-12-SNAPSHOT.jar
[INFO] Checking legal files in: 
org.apache.sling.launchpad.testing-12-SNAPSHOT-sources.jar
[INFO] 
[INFO] --- apache-rat-plugin:0.11:check (default) @ 
org.apache.sling.launchpad.testing ---
[INFO] 51 implicit excludes (use -debug for more details).
[INFO] Exclude: DEPENDENCIES
[INFO] Exclude: src/main/appended-resources/META-INF/*
[INFO] Exclude: velocity.log
[INFO] Exclude: target/*
[INFO] Exclude: README.md
[INFO] Exclude: maven-eclipse.xml
[INFO] Exclude: .*
[INFO] Exclude: .*/**
[INFO] Exclude: **/*.json
[INFO] Exclude: DEPENDENCIES
[INFO] Exclude: **/*.rej
[INFO] Exclude: hs_err_*.log
[INFO] Exclude: **/repository/index/*/index-details.txt
[INFO] Exclude: bnd.bnd
[INFO] 7 resources included (use -debug for more details)
[INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 
approved: 6 licence.
[INFO] 
[INFO] --- maven-failsafe-plugin:2.21.0:verify (default) @ 
org.apache.sling.launchpad.testing ---
[INFO] 
[INFO] BUILD FAILURE
[INFO] 
[INFO] Total time:  03:22 min
[INFO] Finished at: 2019-08-26T14:53:21Z
[INFO] 
[INFO] [jenkins-event-spy] Generated 
/home/jenkins/jenkins-slave/workspace/e-sling-launchpad-testing_master@tmp/withMaven8530cce6/maven-spy-20190826-144958-7972672062266539314059.log
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-failsafe-plugin:2.21.0:verify (default) on 
project org.apache.sling.launchpad.testing: There are test failures.
[ERROR] 
[ERROR] Please refer to 
/home/jenkins/jenkins-slave/workspace/e-sling-launchpad-testing_master/target/failsafe-reports
 for the individual test results.
[ERROR] Please refer to dump files (if any exist) [date]-jvmRun[N].dump, 
[date].dumpstream and [date]-jvmRun[N].dumpstream.
[ERROR] -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please 
read the following articles:
[ERROR] [Help 1] 
http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[Pipeline] }
[withMaven] Publishers: Pipeline Graph Publisher: 7 ms, JGiven Publisher: 1 ms
[Pipeline] // withMaven
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
[Pipeline] // timeout
[Pipeline] stage
[Pipeline] { (Notifications)
[Pipeline] echo
Status change is BROKEN, notifications will be sent.
[Pipeline] emailext

[jira] [Created] (SLING-8658) Update logo src location after changes for SLING-8615

[Robert Munteanu (Jira)]

Robert Munteanu created SLING-8658:
--

 Summary: Update logo src location after changes for SLING-8615
 Key: SLING-8658
 URL: https://issues.apache.org/jira/browse/SLING-8658
 Project: Sling
  Issue Type: Task
  Components: Authentication
Reporter: Robert Munteanu
Assignee: Robert Munteanu
 Fix For: Form Based Authentication 1.0.16


With the changes to SLING-8615 the location of the Sling logo has changed and 
the login link is broken.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

IP clearance (was: nodejs based sling packager)

[Robert Munteanu]

Hi,

I have started the contribution vote for the Sling Packager
contribution. Thanks for contributing this and sorry for the delay.

I am not sure whether this module should go through IP clearance, e.g.
it is a "substantial contribution" in the terms of [3].

I would be interested in knowing what others that accepted
contributions have to say on the topic.

Thanks!

Robert

On Sun, 2019-07-14 at 08:44 -0700, Ruben Reusser wrote:
> Dear Sling Developers,
> 
> in an effort to help 'front end developers' embrace Apache Sling and
> in 
> order to make simple front-end Sling projects maven independent we 
> created a node only slingpackager [1] and a sample VueJs based Slnig 
> Content Browser [2] as a showcase project.
> 
> We'd like to see the slingpackager (and potentially the showcase 
> example) be part of Apache Sling and maybe live on npmjs in an
> Apache 
> Sling organization (@apachesling for example).
> 
> We'd love to hear what you think about this!
> 
> Ruben Reusser
> 
> [1] https://github.com/peregrine-cms/slingpackager
> [2] https://github.com/peregrine-cms/simple-sling-vue-example
> 

[3]: http://incubator.apache.org/ip-clearance/

[VOTE] Accept the donation of the Sling Packager tool, SLING-8584

[Robert Munteanu]

Hi,

Please vote to accept the donation of the Sling Packager module
described in SLING-8584 [1].

This majority vote is open for at least 72 hours.

Thanks,

Robert

[1]: https://issues.apache.org/jira/browse/SLING-8584

[jira] [Assigned] (SLING-8584) Donation proposal of nodejs slingpackager

[Robert Munteanu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-8584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu reassigned SLING-8584:
--

Assignee: Robert Munteanu

> Donation proposal of nodejs slingpackager
> -
>
> Key: SLING-8584
> URL: https://issues.apache.org/jira/browse/SLING-8584
> Project: Sling
>  Issue Type: New Feature
>Reporter: Henry Saginor
>Assignee: Robert Munteanu
>Priority: Minor
> Attachments: slingpackager.tar.gz
>
>
> h1. Modules
> This donation proposal covers one module.
> ||Module||Source||Description||
> |slingpackager|on 
> [GitHub|https://github.com/peregrine-cms/slingpackager/tree/apacheContrib]
>  or [^slingpackager.tar.gz] 
> (shasum ee91c707070f81d9516c8fedbab0aec30605c225)|A nodejs based command line 
> tool alternative to the maven plugin.
>  This tool covers the following use cases.
>  * build a content package form a local folder
>  * upload a content package onto a server
>  * install a content package on a server
>  * list all installed packages on the server
>  * uninstall a content package from the server
>  * delete a content package on the server|



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

[jira] [Updated] (SLING-8657) Remove the biz.aQute.bndlib dependency

[Radu Cotescu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-8657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radu Cotescu updated SLING-8657:

Summary: Remove the biz.aQute.bndlib dependency  (was: Remove the 
biz.aQute.bndlib dependency, since it shadows OSGi core annotations)

> Remove the biz.aQute.bndlib dependency
> --
>
> Key: SLING-8657
> URL: https://issues.apache.org/jira/browse/SLING-8657
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Reporter: Radu Cotescu
>Assignee: Radu Cotescu
>Priority: Major
> Fix For: Scripting Bundle Tracker 0.1.0
>
>
> The Scripting Bundle Tracker makes use of the {{biz.aQute.bndlib}} library in 
> order to programatically generate a {{Provide-Capability}} header. However, 
> that library shadows some core OSGi annotations which should be consumed from 
> their respective libraries. Given that the 
> {{aQute.bnd.annotation.headers.ProvideCapability}} annotation can be replaced 
> with {{org.osgi.annotation.bundle.Capability}}, there's no reason to keep 
> {{biz.aQute.bndlib as a dependency.}}



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

[jira] [Created] (SLING-8657) Remove the biz.aQute.bndlib dependency, since it shadows OSGi core annotations

[Radu Cotescu (Jira)]

Radu Cotescu created SLING-8657:
---

 Summary: Remove the biz.aQute.bndlib dependency, since it shadows 
OSGi core annotations
 Key: SLING-8657
 URL: https://issues.apache.org/jira/browse/SLING-8657
 Project: Sling
  Issue Type: Bug
  Components: Scripting
Reporter: Radu Cotescu
 Fix For: Scripting Bundle Tracker 0.1.0


The Scripting Bundle Tracker makes use of the {{biz.aQute.bndlib}} library in 
order to programatically generate a {{Provide-Capability}} header. However, 
that library shadows some core OSGi annotations which should be consumed from 
their respective libraries. Given that the 
{{aQute.bnd.annotation.headers.ProvideCapability}} annotation can be replaced 
with {{org.osgi.annotation.bundle.Capability}}, there's no reason to keep 
{{biz.aQute.bndlib as a dependency.}}



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

[jira] [Assigned] (SLING-8657) Remove the biz.aQute.bndlib dependency, since it shadows OSGi core annotations

[Radu Cotescu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-8657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radu Cotescu reassigned SLING-8657:
---

Assignee: Radu Cotescu

> Remove the biz.aQute.bndlib dependency, since it shadows OSGi core annotations
> --
>
> Key: SLING-8657
> URL: https://issues.apache.org/jira/browse/SLING-8657
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Reporter: Radu Cotescu
>Assignee: Radu Cotescu
>Priority: Major
> Fix For: Scripting Bundle Tracker 0.1.0
>
>
> The Scripting Bundle Tracker makes use of the {{biz.aQute.bndlib}} library in 
> order to programatically generate a {{Provide-Capability}} header. However, 
> that library shadows some core OSGi annotations which should be consumed from 
> their respective libraries. Given that the 
> {{aQute.bnd.annotation.headers.ProvideCapability}} annotation can be replaced 
> with {{org.osgi.annotation.bundle.Capability}}, there's no reason to keep 
> {{biz.aQute.bndlib as a dependency.}}



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

Re: Release Validator Docker Image

[Bertrand Delacretaz]

On Fri, Aug 23, 2019 at 3:00 PM Daniel Klco  wrote:
> ...I'm just not convinced of the
> value re-implementing in Java brings vs a few simple bash commands...

+1, IMO what's important is for the tools used to be traceable, for
example by including digests of scripts (or Docker images?) in their
output and having people validate those digests before running the
tools.

The OpenWhisk release checking script [1] does that:

  echo "$(basename $0) (script SHA1: $(gpg --print-md SHA1 $0 | cut
-d' ' -f2-))"

So that when someone pastes the script output in their vote message,
it points to the exact version of the tool that was used, assuming
people check the script's digest when running it.

-Bertrand

[1] https://github.com/apache/openwhisk-release/blob/master/tools/rcverify.sh

Re: [VOTE] Release Apache Sling Commons LogService 1.1.0

[Andreas Schaefer]

+1 (non-binding)

> On Aug 26, 2019, at 12:22 AM, Carsten Ziegeler  wrote:
> 
> sh check_staged_release.sh 2118/tmp/sling-staging

[RESULT][VOTE] Apache Sling Feature Model 1.1.0 Feature Model IO 1.1.0 Feature Model Analyser 1.1.0 Feature Model Launcher 1.1.0 slingfeature-maven-plugin 1.1.0 slingstart-maven-plugin 1.9.0

[davidb]

With +1 votes from Karl Pauls, Andreas Schaefer, Stefan Seifert, David
Bosschaert and no other votes this release succeeds. I've promoted the
artifacts.

Best regards,

David

On Thu, 22 Aug 2019 at 09:35,  wrote:

> Hi all,
>
> I would like to call the release of the following components:
>
> org.apache.sling.feature 1.1.0
> Issues fixed:
> https://issues.apache.org/jira/projects/SLING/versions/12345973
>
> org.apache.sling.feature.io 1.1.0
> Issues fixed:
> https://issues.apache.org/jira/projects/SLING/versions/12345974
>
> org.apache.sling.feature.analyser 1.1.0
> Issues fixed:
> https://issues.apache.org/jira/projects/SLING/versions/12345969
>
> org.apache.sling.feature.launcher 1.1.0
> Issues fixed:
> https://issues.apache.org/jira/browse/SLING/fixforversion/12345972
>
> slingfeature-maven-plugin 1.1.0
> Issues fixed:
> https://issues.apache.org/jira/browse/SLING/fixforversion/12345971
>
> slingstart-maven-plugin 1.9.0
> Issues fixed:
> https://issues.apache.org/jira/projects/SLING/versions/12345976
>
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-2116/
>
> You can use this UNIX script to download the release and verify the
> signatures:
>
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
>
> Usage:
> sh check_staged_release.sh 2116 /tmp/sling-staging
>
> Please vote to approve this release:
>
>   [ ] +1 Approve the release
>   [ ] -1 Don't release, because ...
>
> This majority vote is open for at least 72 hours.
>
> Best regards,
>
> David Bosschaert
>

[jira] [Resolved] (SLING-8649) Missing dependencies when installing computed content-packages

[Simone Tripodi (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-8649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Simone Tripodi resolved SLING-8649.
---
Resolution: Fixed

Fix + testcase merged on _master_

> Missing dependencies when installing computed content-packages
> --
>
> Key: SLING-8649
> URL: https://issues.apache.org/jira/browse/SLING-8649
> Project: Sling
>  Issue Type: Improvement
>  Components: Content-Package to Feature Model Converter
>Reporter: Simone Tripodi
>Assignee: Simone Tripodi
>Priority: Major
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> filtering out mutable content-packages being installed via Feature Model, it 
> may causes a missing dependency issue when installing related transitive 
> dependencies content-packages.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

RE: [VOTE] Release Apache Sling Commons LogService 1.1.0

[Stefan Seifert]

+1

[jira] [Closed] (SLING-8493) Move embedded jackrabbit classes to Sling package space

[Karl Pauls (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-8493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls closed SLING-8493.
-

> Move embedded jackrabbit classes to Sling package space
> ---
>
> Key: SLING-8493
> URL: https://issues.apache.org/jira/browse/SLING-8493
> Project: Sling
>  Issue Type: Improvement
>  Components: API, Servlets
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Servlets Get 2.1.42, API 2.20.2, Servlets Post 2.3.32
>
>
> Classes from jackrabbit util are embedded as is; it's better to move them to 
> a package owned by Sling to avoid collisions



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

[jira] [Closed] (SLING-8560) Servlets Post jcrEnabled doesn't catch all cases.

[Karl Pauls (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-8560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls closed SLING-8560.
-

> Servlets Post jcrEnabled doesn't catch all cases.
> -
>
> Key: SLING-8560
> URL: https://issues.apache.org/jira/browse/SLING-8560
> Project: Sling
>  Issue Type: Bug
>  Components: Servlets
>Affects Versions: Servlets Post 2.3.30
>Reporter: Karl Pauls
>Assignee: Karl Pauls
>Priority: Major
> Fix For: Servlets Post 2.3.32
>
>
> When running without full JCR support the jcrEnabled() check of servlets post 
> doesn't catch all cases.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

Re: [RESULT][VOTE] Release Apache Sling Servlets Post 2.3.32 and Sling Commons Scheduler 2.7.4

[Karl Pauls]

Time to call the vote on the Apache Sling Servlets Post 2.3.32 and
Sling Commons Scheduler 2.7.4 releases.

* +1 votes from Stefan Seifert, Radu Cotescu, Robert Munteanu, David Bosschaert,
Andreas Schaefer, and Karl Pauls.

* No other votes.

The vote is successful. I will make the artifacts available as soon as possible.

Re: [VOTE] Release Apache Sling Servlets Post 2.3.32 and Sling Commons Scheduler 2.7.4

[Karl Pauls]

+1

regards,

Karl

On Thu, Aug 22, 2019 at 3:44 PM Andreas Schaefer
 wrote:
>
> +1 (non-binding)
>
> - Andy
>
> > On Aug 22, 2019, at 12:39 AM, Karl Pauls  wrote:
> >
> > I would like to call a vote on the following releases:
> >
> > Apache Sling Servlets Post 2.3.32
> >
> > We solved 2 issue in this release:
> >
> > https://issues.apache.org/jira/projects/SLING/versions/12345523
> >
> > Apache Sling Commons Scheduler 2.7.4
> >
> > We solved 4 issue in this release:
> >
> > https://issues.apache.org/jira/projects/SLING/versions/12344302
> >
> > Staging repository:
> > https://repository.apache.org/content/repositories/orgapachesling-2115/
> >
> > You can use this UNIX script to download the release and verify the 
> > signatures:
> > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
> >
> > Usage:
> > sh check_staged_release.sh 2115 /tmp/sling-staging
> >
> > Please vote to approve these release:
> >
> >  [ ] +1 Approve the releases
> >  [ ]  0 Don't care
> >  [ ] -1 Don't release, because ...
>


-- 
Karl Pauls
karlpa...@gmail.com

[jira] [Comment Edited] (SLING-8652) Prototypes are not supported in multi-module builds

[Carsten Ziegeler (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-8652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16915571#comment-16915571
 ] 

Carsten Ziegeler edited comment on SLING-8652 at 8/26/19 8:04 AM:
--

This was a classic copy/paste/refactoring bug. Fixed in rev 447e95b

Please note, that it is not possible to use aggregates as prototypes across 
projects in a multi project setup. 


was (Author: cziegeler):
This was a classic copy/paste/refactoring bug. Fixed in rev 447e95b

Please note, that it is not possible to use aggregates across projects in a 
multi project setup

> Prototypes are not supported in multi-module builds
> ---
>
> Key: SLING-8652
> URL: https://issues.apache.org/jira/browse/SLING-8652
> Project: Sling
>  Issue Type: Bug
>  Components: Feature Model
>Affects Versions: slingfeature-maven-plugin 1.0.6, 
> slingfeature-maven-plugin 1.1.0
>Reporter: Radu Cotescu
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: slingfeature-maven-plugin 1.1.2
>
>
> In a multi-module build, if a module A represents the prototype for a second 
> module B, the reactor build will fail with an error similar to:
> {noformat}
> [INFO] Scanning for projects...
> [ERROR] Unable to get feature A:slingosgifeature:0.0.1-SNAPSHOT : Recursive 
> feature dependency list including project MavenProject: B:0.0.1-SNAPSHOT @ 
> ~/workspace/reactor/B/pom.xml
> [ERROR] Internal error: java.lang.IllegalStateException: Unable to find 
> prototype feature A:slingosgifeature:0.0.1-SNAPSHOT -> [Help 1]
> org.apache.maven.InternalErrorException: Internal error: 
> java.lang.IllegalStateException: Unable to find prototype feature 
> A:slingosgifeature:0.0.1-SNAPSHOT
>at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:120)
>at org.apache.maven.cli.MavenCli.execute (MavenCli.java:956)
>at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288)
>at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
>at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
>at jdk.internal.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:62)
>at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
>at java.lang.reflect.Method.invoke (Method.java:566)
>at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
> (Launcher.java:282)
>at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
> (Launcher.java:225)
>at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
> (Launcher.java:406)
>at org.codehaus.plexus.classworlds.launcher.Launcher.main 
> (Launcher.java:347)
> Caused by: java.lang.IllegalStateException: Unable to find prototype feature 
> A:slingosgifeature:0.0.1-SNAPSHOT
>at org.apache.sling.feature.builder.FeatureBuilder.internalAssemble 
> (FeatureBuilder.java:314)
>at org.apache.sling.feature.builder.FeatureBuilder.assemble 
> (FeatureBuilder.java:59)
>at org.apache.sling.feature.maven.Preprocessor.process 
> (Preprocessor.java:216)
>at org.apache.sling.feature.maven.Preprocessor.process 
> (Preprocessor.java:118)
>at 
> org.apache.sling.feature.maven.mojos.DependencyLifecycleParticipant.afterProjectsRead
>  (DependencyLifecycleParticipant.java:79)
>at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:264)
>at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
>at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
>at org.apache.maven.cli.MavenCli.execute (MavenCli.java:956)
>at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288)
>at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
>at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
>at jdk.internal.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:62)
>at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
>at java.lang.reflect.Method.invoke (Method.java:566)
>at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
> (Launcher.java:282)
>at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
> (Launcher.java:225)
>at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
> (Launcher.java:406)
>at org.codehaus.plexus.classworlds.launcher.Launcher.main 
> (Launcher.java:347)
> {noformat}
> The workaround, when one wants to work with a multi-module setup, is to use 
> aggregates to compose feature B, instead of relying on A as a prototype.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

Re: [VOTE] Release Apache Sling Health Check Core 2.0.0, Sling Health Check Web Console 2.0.0

[Konrad Windszus]

Yes, Felix HC. This is a drop in replacement at least for these two bundles 
IMHO (although the API package has changed).
Konrad

> On 26. Aug 2019, at 10:01, Stefan Seifert  wrote:
> 
> relocate to what - felix HC?
> relocate makes only sense if the new target is a drop-in replacement - which 
> is not the case with sling HC -> felix HC?
> 
> stefan
> 
>> -Original Message-
>> From: Konrad Windszus [mailto:konra...@gmx.de]
>> Sent: Monday, August 26, 2019 9:51 AM
>> To: dev@sling.apache.org
>> Subject: Re: [VOTE] Release Apache Sling Health Check Core 2.0.0, Sling
>> Health Check Web Console 2.0.0
>> 
>> Hi Georg,
>> wouldn't it make sense to add a relocation section to this last release
>> (https://maven.apache.org/guides/mini/guide-relocation.html
>> )?
>> That way it would be even more obvious on how to migrate...
>> Konrad
>> 
>> 
>>> On 22. Aug 2019, at 19:34, Georg Henzler  wrote:
>>> 
>>> Hi,
>>> 
>>> We solved 1 issues in this release:
>>> https://issues.apache.org/jira/browse/SLING-8653
>>> 
>>> There are no outstanding issues.
>>> 
>>> Staging repository:
>>> https://repository.apache.org/content/repositories/orgapachesling-2117/
>>> 
>>> You can use this UNIX script to download the release and verify the
>> signatures:
>>> https://gitbox.apache.org/repos/asf?p=sling-tooling-
>> release.git;a=blob;f=check_staged_release.sh;hb=HEAD
>>> 
>>> Usage:
>>> sh check_staged_release.sh 2117 /tmp/sling-staging
>>> 
>>> Please vote to approve this release:
>>> 
>>> [ ] +1 Approve the release
>>> [ ]  0 Don't care
>>> [ ] -1 Don't release, because ...
>>> 
>>> This majority vote is open for at least 72 hours.
>>> 
>>> -Georg
> 
> 

[jira] [Resolved] (SLING-8652) Prototypes are not supported in multi-module builds

[Carsten Ziegeler (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-8652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-8652.
-
  Assignee: Carsten Ziegeler
Resolution: Fixed

This was a classic copy/paste/refactoring bug. Fixed in rev 447e95b

Please note, that it is not possible to use aggregates across projects in a 
multi project setup

> Prototypes are not supported in multi-module builds
> ---
>
> Key: SLING-8652
> URL: https://issues.apache.org/jira/browse/SLING-8652
> Project: Sling
>  Issue Type: Bug
>  Components: Feature Model
>Affects Versions: slingfeature-maven-plugin 1.0.6, 
> slingfeature-maven-plugin 1.1.0
>Reporter: Radu Cotescu
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: slingfeature-maven-plugin 1.1.2
>
>
> In a multi-module build, if a module A represents the prototype for a second 
> module B, the reactor build will fail with an error similar to:
> {noformat}
> [INFO] Scanning for projects...
> [ERROR] Unable to get feature A:slingosgifeature:0.0.1-SNAPSHOT : Recursive 
> feature dependency list including project MavenProject: B:0.0.1-SNAPSHOT @ 
> ~/workspace/reactor/B/pom.xml
> [ERROR] Internal error: java.lang.IllegalStateException: Unable to find 
> prototype feature A:slingosgifeature:0.0.1-SNAPSHOT -> [Help 1]
> org.apache.maven.InternalErrorException: Internal error: 
> java.lang.IllegalStateException: Unable to find prototype feature 
> A:slingosgifeature:0.0.1-SNAPSHOT
>at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:120)
>at org.apache.maven.cli.MavenCli.execute (MavenCli.java:956)
>at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288)
>at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
>at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
>at jdk.internal.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:62)
>at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
>at java.lang.reflect.Method.invoke (Method.java:566)
>at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
> (Launcher.java:282)
>at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
> (Launcher.java:225)
>at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
> (Launcher.java:406)
>at org.codehaus.plexus.classworlds.launcher.Launcher.main 
> (Launcher.java:347)
> Caused by: java.lang.IllegalStateException: Unable to find prototype feature 
> A:slingosgifeature:0.0.1-SNAPSHOT
>at org.apache.sling.feature.builder.FeatureBuilder.internalAssemble 
> (FeatureBuilder.java:314)
>at org.apache.sling.feature.builder.FeatureBuilder.assemble 
> (FeatureBuilder.java:59)
>at org.apache.sling.feature.maven.Preprocessor.process 
> (Preprocessor.java:216)
>at org.apache.sling.feature.maven.Preprocessor.process 
> (Preprocessor.java:118)
>at 
> org.apache.sling.feature.maven.mojos.DependencyLifecycleParticipant.afterProjectsRead
>  (DependencyLifecycleParticipant.java:79)
>at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:264)
>at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
>at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
>at org.apache.maven.cli.MavenCli.execute (MavenCli.java:956)
>at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288)
>at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
>at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
>at jdk.internal.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:62)
>at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
>at java.lang.reflect.Method.invoke (Method.java:566)
>at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
> (Launcher.java:282)
>at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
> (Launcher.java:225)
>at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
> (Launcher.java:406)
>at org.codehaus.plexus.classworlds.launcher.Launcher.main 
> (Launcher.java:347)
> {noformat}
> The workaround, when one wants to work with a multi-module setup, is to use 
> aggregates to compose feature B, instead of relying on A as a prototype.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

RE: [VOTE] Release Apache Sling Health Check Core 2.0.0, Sling Health Check Web Console 2.0.0

[Stefan Seifert]

relocate to what - felix HC?
relocate makes only sense if the new target is a drop-in replacement - which is 
not the case with sling HC -> felix HC?

stefan

>-Original Message-
>From: Konrad Windszus [mailto:konra...@gmx.de]
>Sent: Monday, August 26, 2019 9:51 AM
>To: dev@sling.apache.org
>Subject: Re: [VOTE] Release Apache Sling Health Check Core 2.0.0, Sling
>Health Check Web Console 2.0.0
>
>Hi Georg,
>wouldn't it make sense to add a relocation section to this last release
>(https://maven.apache.org/guides/mini/guide-relocation.html
>)?
>That way it would be even more obvious on how to migrate...
>Konrad
>
>
>> On 22. Aug 2019, at 19:34, Georg Henzler  wrote:
>>
>> Hi,
>>
>> We solved 1 issues in this release:
>> https://issues.apache.org/jira/browse/SLING-8653
>>
>> There are no outstanding issues.
>>
>> Staging repository:
>> https://repository.apache.org/content/repositories/orgapachesling-2117/
>>
>> You can use this UNIX script to download the release and verify the
>signatures:
>> https://gitbox.apache.org/repos/asf?p=sling-tooling-
>release.git;a=blob;f=check_staged_release.sh;hb=HEAD
>>
>> Usage:
>> sh check_staged_release.sh 2117 /tmp/sling-staging
>>
>> Please vote to approve this release:
>>
>>  [ ] +1 Approve the release
>>  [ ]  0 Don't care
>>  [ ] -1 Don't release, because ...
>>
>> This majority vote is open for at least 72 hours.
>>
>> -Georg

[jira] [Updated] (SLING-8652) Prototypes are not supported in multi-module builds

[Carsten Ziegeler (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-8652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler updated SLING-8652:

Fix Version/s: slingfeature-maven-plugin 1.1.2

> Prototypes are not supported in multi-module builds
> ---
>
> Key: SLING-8652
> URL: https://issues.apache.org/jira/browse/SLING-8652
> Project: Sling
>  Issue Type: Bug
>  Components: Feature Model
>Affects Versions: slingfeature-maven-plugin 1.0.6, 
> slingfeature-maven-plugin 1.1.0
>Reporter: Radu Cotescu
>Priority: Major
> Fix For: slingfeature-maven-plugin 1.1.2
>
>
> In a multi-module build, if a module A represents the prototype for a second 
> module B, the reactor build will fail with an error similar to:
> {noformat}
> [INFO] Scanning for projects...
> [ERROR] Unable to get feature A:slingosgifeature:0.0.1-SNAPSHOT : Recursive 
> feature dependency list including project MavenProject: B:0.0.1-SNAPSHOT @ 
> ~/workspace/reactor/B/pom.xml
> [ERROR] Internal error: java.lang.IllegalStateException: Unable to find 
> prototype feature A:slingosgifeature:0.0.1-SNAPSHOT -> [Help 1]
> org.apache.maven.InternalErrorException: Internal error: 
> java.lang.IllegalStateException: Unable to find prototype feature 
> A:slingosgifeature:0.0.1-SNAPSHOT
>at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:120)
>at org.apache.maven.cli.MavenCli.execute (MavenCli.java:956)
>at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288)
>at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
>at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
>at jdk.internal.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:62)
>at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
>at java.lang.reflect.Method.invoke (Method.java:566)
>at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
> (Launcher.java:282)
>at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
> (Launcher.java:225)
>at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
> (Launcher.java:406)
>at org.codehaus.plexus.classworlds.launcher.Launcher.main 
> (Launcher.java:347)
> Caused by: java.lang.IllegalStateException: Unable to find prototype feature 
> A:slingosgifeature:0.0.1-SNAPSHOT
>at org.apache.sling.feature.builder.FeatureBuilder.internalAssemble 
> (FeatureBuilder.java:314)
>at org.apache.sling.feature.builder.FeatureBuilder.assemble 
> (FeatureBuilder.java:59)
>at org.apache.sling.feature.maven.Preprocessor.process 
> (Preprocessor.java:216)
>at org.apache.sling.feature.maven.Preprocessor.process 
> (Preprocessor.java:118)
>at 
> org.apache.sling.feature.maven.mojos.DependencyLifecycleParticipant.afterProjectsRead
>  (DependencyLifecycleParticipant.java:79)
>at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:264)
>at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
>at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
>at org.apache.maven.cli.MavenCli.execute (MavenCli.java:956)
>at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288)
>at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
>at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
>at jdk.internal.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:62)
>at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
>at java.lang.reflect.Method.invoke (Method.java:566)
>at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
> (Launcher.java:282)
>at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
> (Launcher.java:225)
>at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
> (Launcher.java:406)
>at org.codehaus.plexus.classworlds.launcher.Launcher.main 
> (Launcher.java:347)
> {noformat}
> The workaround, when one wants to work with a multi-module setup, is to use 
> aggregates to compose feature B, instead of relying on A as a prototype.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

Re: [VOTE] Release Apache Sling Health Check Core 2.0.0, Sling Health Check Web Console 2.0.0

[Konrad Windszus]

Hi Georg,
wouldn't it make sense to add a relocation section to this last release 
(https://maven.apache.org/guides/mini/guide-relocation.html 
)?
That way it would be even more obvious on how to migrate...
Konrad


> On 22. Aug 2019, at 19:34, Georg Henzler  wrote:
> 
> Hi,
> 
> We solved 1 issues in this release:
> https://issues.apache.org/jira/browse/SLING-8653
> 
> There are no outstanding issues.
> 
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-2117/
> 
> You can use this UNIX script to download the release and verify the 
> signatures:
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
> 
> Usage:
> sh check_staged_release.sh 2117 /tmp/sling-staging
> 
> Please vote to approve this release:
> 
>  [ ] +1 Approve the release
>  [ ]  0 Don't care
>  [ ] -1 Don't release, because ...
> 
> This majority vote is open for at least 72 hours.
> 
> -Georg

Re: [VOTE] Release Apache Sling Commons LogService 1.1.0

[Radu Cotescu]

+1

> On 26 Aug 2019, at 09:22, Carsten Ziegeler  wrote:
> 
> Please vote to approve this release:
> 
>  [ ] +1 Approve the release
>  [ ]  0 Don't care
>  [ ] -1 Don't release, because ...
> 
> This majority vote is open for at least 72 hours.

Re: [VOTE] Release Apache Sling Commons LogService 1.1.0

[Carsten Ziegeler]

+1

Carsten

Am 26.08.2019 um 09:22 schrieb Carsten Ziegeler:

Hi,

We solved 2 issues in this release:

https://issues.apache.org/jira/projects/SLING/versions/12333856

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2118

You can use this UNIX script to download the release and verify the
signatures:
http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh

Usage:
sh check_staged_release.sh 2118/tmp/sling-staging

Please vote to approve this release:

   [ ] +1 Approve the release
   [ ]  0 Don't care
   [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards
Carsten
--
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org


--
--
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

[VOTE] Release Apache Sling Commons LogService 1.1.0

[Carsten Ziegeler]

Hi,

We solved 2 issues in this release:

https://issues.apache.org/jira/projects/SLING/versions/12333856

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2118

You can use this UNIX script to download the release and verify the
signatures:
http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh

Usage:
sh check_staged_release.sh 2118/tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards
Carsten
--
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org