[jira] [Resolved] (SLING-8831) Provide more than one source for the api for an artifact

[Carsten Ziegeler (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-8831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-8831.
-
Resolution: Fixed

The metadata sourceId can now contain either a single artifact id or a comma 
separated list of ids (in a single string value)

> Provide more than one source for the api for an artifact
> 
>
> Key: SLING-8831
> URL: https://issues.apache.org/jira/browse/SLING-8831
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model, Maven Plugins and Archetypes
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: slingfeature-maven-plugin 1.1.10
>
>
> Right now its only possible to define one alternative source artifact for the 
> api generation. In some cases it is required to specify more than one source 
> artifact, for example if a bundle is containing more than one api



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Resolved] (SLING-8830) Provide a configuration to define the classifier for api jars

[Carsten Ziegeler (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-8830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-8830.
-
Resolution: Fixed

Added a new configuration option:
{noformat}
 
global

{noformat}
which allows to map the classifier to something different (main to global in 
that example)

> Provide a configuration to define the classifier for api jars
> -
>
> Key: SLING-8830
> URL: https://issues.apache.org/jira/browse/SLING-8830
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model, Maven Plugins and Archetypes
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: slingfeature-maven-plugin 1.1.10
>
>
> The classifier of the feature model is used to define the name of the api jar 
> classifier. It would be nice to have a configuration to change this



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Resolved] (SLING-8829) Provide a configuration to provide an alternative api region name for the api jar

[Carsten Ziegeler (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-8829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-8829.
-
Resolution: Fixed

Added a new configuration option:
{noformat}
 
foo

{noformat}
which allows to map the region name to something different (global to foo in 
that example)

> Provide a configuration to provide an alternative api region name for the api 
> jar
> -
>
> Key: SLING-8829
> URL: https://issues.apache.org/jira/browse/SLING-8829
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model, Maven Plugins and Archetypes
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: slingfeature-maven-plugin 1.1.10
>
>
> The generated api jars take the name of the api region as part of the 
> qualifier. It would be nice to have a way to change the api region name.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Resolved] (SLING-8828) Provide a configuration to disable automatic attaching of api jars

[Carsten Ziegeler (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-8828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-8828.
-
Resolution: Fixed

Added new parameter attachApiJars in rev 0907a01

> Provide a configuration to disable automatic attaching of api jars
> --
>
> Key: SLING-8828
> URL: https://issues.apache.org/jira/browse/SLING-8828
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model, Maven Plugins and Archetypes
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: slingfeature-maven-plugin 1.1.10
>
>
> api jars are automatically added to the project, it would be good to have a 
> configuration to disable this



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (SLING-8831) Provide more than one source for the api for an artifact

[Carsten Ziegeler (Jira)]

Carsten Ziegeler created SLING-8831:
---

 Summary: Provide more than one source for the api for an artifact
 Key: SLING-8831
 URL: https://issues.apache.org/jira/browse/SLING-8831
 Project: Sling
  Issue Type: Improvement
  Components: Feature Model, Maven Plugins and Archetypes
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: slingfeature-maven-plugin 1.1.10


Right now its only possible to define one alternative source artifact for the 
api generation. In some cases it is required to specify more than one source 
artifact, for example if a bundle is containing more than one api



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (SLING-8830) Provide a configuration to define the classifier for api jars

[Carsten Ziegeler (Jira)]

Carsten Ziegeler created SLING-8830:
---

 Summary: Provide a configuration to define the classifier for api 
jars
 Key: SLING-8830
 URL: https://issues.apache.org/jira/browse/SLING-8830
 Project: Sling
  Issue Type: Improvement
  Components: Feature Model, Maven Plugins and Archetypes
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: slingfeature-maven-plugin 1.1.10


The classifier of the feature model is used to define the name of the api jar 
classifier. It would be nice to have a configuration to change this



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (SLING-8829) Provide a configuration to provide an alternative api region name for the api jar

[Carsten Ziegeler (Jira)]

Carsten Ziegeler created SLING-8829:
---

 Summary: Provide a configuration to provide an alternative api 
region name for the api jar
 Key: SLING-8829
 URL: https://issues.apache.org/jira/browse/SLING-8829
 Project: Sling
  Issue Type: Improvement
  Components: Feature Model, Maven Plugins and Archetypes
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: slingfeature-maven-plugin 1.1.10


The generated api jars take the name of the api region as part of the 
qualifier. It would be nice to have a way to change the api region name.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (SLING-8828) Provide a configuration to disable automatic attaching of api jars

[Carsten Ziegeler (Jira)]

Carsten Ziegeler created SLING-8828:
---

 Summary: Provide a configuration to disable automatic attaching of 
api jars
 Key: SLING-8828
 URL: https://issues.apache.org/jira/browse/SLING-8828
 Project: Sling
  Issue Type: Improvement
  Components: Feature Model, Maven Plugins and Archetypes
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: slingfeature-maven-plugin 1.1.10


api jars are automatically added to the project, it would be good to have a 
configuration to disable this



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Publishing packages on npmjs.com

[Ruben Reusser]

Robert, I do not have an opinion on 1 or 2. Do what's best for the sling 
PMC team


Ruben

On 11/6/2019 9:11 AM, Robert Munteanu wrote:

Thanks, Ruben.

I will then create the @apache-sling org on NPM. There is only one
question left - how to manage credentials. I see two options:

1. Create a shared account that is registered using the
'priv...@sling.apache.org' email. This makes sure credentials are not
tied to a single account, but then again makes it harder to revoke and
there is less tracing.

2. Create it using my account and then grant access to other PMC
members on-demand, using the '@apache.org' accounts.

I slightly prefer 2, I think the credentials are better handled without
reset links being accessible in (privately) archived mailing lists.

I plan to create the org on Monday, so if you have other ideas, please
let me know.

Thanks,
Robert


On Thu, 2019-10-24 at 05:37 -0700, Ruben Reusser wrote:

Robert, thank you for looking into this

there is also a sling-packager user package preventing us from using
sling-packager or slingpackager.

I honestly would prefer the org and as an org only 1 is an option.

thank you

Ruben

On 10/24/2019 3:04 AM, Robert Munteanu wrote:

Hi,

In https://issues.apache.org/jira/browse/SLING-8747 we are
discussing
how to publish Sling packages on npmjs.com .

First thing to settle would be the naming convention. I guess we
have
four options here:

1. @apache-sling/$PACKAGE-NAME
2. @sling/$PACKAGE-NAME
3. apache-sling-$PACKAGE-NAME
4. sling-$PACKAGE-NAME

I think an org is preferrable since we would be able to add
multiple
accounts to it.

There already is a user package https://www.npmjs.com/package/sling
  ,
so I'm not sure if we can create a @sling organisation.

Which option to you prefer? New ones are welcome, of course.

Thanks,
Robert

Re: Publishing packages on npmjs.com

[Robert Munteanu]

Thanks, Ruben.

I will then create the @apache-sling org on NPM. There is only one
question left - how to manage credentials. I see two options:

1. Create a shared account that is registered using the 
'priv...@sling.apache.org' email. This makes sure credentials are not
tied to a single account, but then again makes it harder to revoke and
there is less tracing.

2. Create it using my account and then grant access to other PMC
members on-demand, using the '@apache.org' accounts.

I slightly prefer 2, I think the credentials are better handled without
reset links being accessible in (privately) archived mailing lists.

I plan to create the org on Monday, so if you have other ideas, please
let me know.

Thanks,
Robert


On Thu, 2019-10-24 at 05:37 -0700, Ruben Reusser wrote:
> Robert, thank you for looking into this
> 
> there is also a sling-packager user package preventing us from using 
> sling-packager or slingpackager.
> 
> I honestly would prefer the org and as an org only 1 is an option.
> 
> thank you
> 
> Ruben
> 
> On 10/24/2019 3:04 AM, Robert Munteanu wrote:
> > Hi,
> > 
> > In https://issues.apache.org/jira/browse/SLING-8747 we are
> > discussing
> > how to publish Sling packages on npmjs.com .
> > 
> > First thing to settle would be the naming convention. I guess we
> > have
> > four options here:
> > 
> > 1. @apache-sling/$PACKAGE-NAME
> > 2. @sling/$PACKAGE-NAME
> > 3. apache-sling-$PACKAGE-NAME
> > 4. sling-$PACKAGE-NAME
> > 
> > I think an org is preferrable since we would be able to add
> > multiple
> > accounts to it.
> > 
> > There already is a user package https://www.npmjs.com/package/sling
> >  ,
> > so I'm not sure if we can create a @sling organisation.
> > 
> > Which option to you prefer? New ones are welcome, of course.
> > 
> > Thanks,
> > Robert
> > 

[jira] [Updated] (SLING-8752) Release CP Converter

[Andreas Schaefer (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-8752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andreas Schaefer updated SLING-8752:

Reporter: Andreas Schaefer  (was: andysch#1)

> Release CP Converter
> 
>
> Key: SLING-8752
> URL: https://issues.apache.org/jira/browse/SLING-8752
> Project: Sling
>  Issue Type: Task
>  Components: Content-Package to Feature Model Converter, Feature Model
>Affects Versions: Content-Package to Feature Model Converter 1.0.0
>Reporter: Andreas Schaefer
>Assignee: Simone Tripodi
>Priority: Blocker
> Fix For: Content-Package to Feature Model Converter 1.0.0
>
>
> For the Feature Model Converter Maven Plugin I need to have this module 
> released.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-8641) Onboard sling-feature-converter-maven-plugin to SonarCloud

[Andreas Schaefer (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-8641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16968472#comment-16968472
 ] 

Andreas Schaefer commented on SLING-8641:
-

[~bellingard] Sorry for the late reply but I overlooked your comment. Yes, that 
is the module in question.

> Onboard sling-feature-converter-maven-plugin to SonarCloud
> --
>
> Key: SLING-8641
> URL: https://issues.apache.org/jira/browse/SLING-8641
> Project: Sling
>  Issue Type: Task
>  Components: Feature Model
>Reporter: Andreas Schaefer
>Priority: Major
>
> [~bellingard] Can you onboard the new module 
> sling-maven-converter-maven-plugin?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [sling-org-apache-sling-feature] HarisAdzemovic opened a new pull request #15: Strings and Boxed types should be compared using "equals()"

[GitBox]

HarisAdzemovic opened a new pull request #15: Strings and Boxed types should be 
compared using "equals()"
URL: https://github.com/apache/sling-org-apache-sling-feature/pull/15
 
 
   This fixes 1 Sonarqube violation of rule S4973:
   https://rules.sonarsource.com/java/RSPEC-4973
   
   Sonarcloud violation URL:
   
https://sonarcloud.io/organizations/apache/issues?languages=java=AWolvFAZ7getyiJUvV3-=false=squid%3AS4973=BUG
   
   Jira Ticket:
   https://issues.apache.org/jira/browse/SLING-8825


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [sling-org-apache-sling-feature-apiregions] simonetripodi commented on issue #1: SLING-8815 - [API Regions] Prevent from resolving to customer-provided bundles

[GitBox]

simonetripodi commented on issue #1: SLING-8815 - [API Regions] Prevent from 
resolving to customer-provided bundles
URL: 
https://github.com/apache/sling-org-apache-sling-feature-apiregions/pull/1#issuecomment-550329795
 
 
   @bosschaert @cziegeler I just applied all the suggestions to the PR, in case 
you'll have some spare time to give another review, it will be very appreciated!


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Resolved] (SLING-8827) api: Upgrade to parent pom 35

[Radu Cotescu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-8827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radu Cotescu resolved SLING-8827.
-
Resolution: Fixed

Implemented in [commit 
49f86bb|https://github.com/apache/sling-org-apache-sling-api/commit/49f86bb].

> api: Upgrade to parent pom 35
> -
>
> Key: SLING-8827
> URL: https://issues.apache.org/jira/browse/SLING-8827
> Project: Sling
>  Issue Type: Sub-task
>  Components: API
>Reporter: Radu Cotescu
>Assignee: Radu Cotescu
>Priority: Major
> Fix For: API 2.21.0
>
>
> The {{org.apache.sling.api}} bundle should be updated to version 35 of the 
> {{sling-bundle-parent}} pom, in order to allow builds with Java 11 and above.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: issues switching to bnd baseline maven plugin

[Radu Cotescu]

Hi Stefan,

> On 1 Nov 2019, at 11:48, Stefan Seifert  wrote:
> 
> i've started migrating my first non-trivial projects to parent 35 including 
> bnd-maven-plugin and ran in some issues:
> 
> 1. bnd-baseline-maven-plugin demands for package version increases where it's 
> not appropriate
> - in [1] i switched to bnd maven plugins (1st commit in this branch)
> - if I compile the project the baseline plugin wants to raise the last digit 
> in the package, it complains that null annotations where added to several 
> methods
> - but: these annotations where already present in the previous release 
> baseline was comparing to
> - the problem can be solved by just incrementing the package versions (2nd 
> commit), but this does not seem to like a proper solution
> - and will it do the same for future releases?
> 
> 
> [1] 
> https://github.com/apache/sling-org-apache-sling-caconfig-api/tree/feature/SLING-8824-parent25

I experienced the same issue regarding the JSR-305 annotations in [4], but Karl 
and I think we found the explanation: parent 35 defines sling.java.version as 8 
by default. Most of the projects which were not yet migrated to parent 35 were 
built with Java 7. In [5] there’s a mention that the baseline check also 
applies to the resulted bytecode, therefore implying that it could trigger 
warnings when you’re baselining against the same codebase, but with the 
artifact built with a different JDK.

I guess we’ll just have to bump those micro versions once and see if the 
history repeats itself for subsequent releases with the same JDK, or if [5] is 
indeed the correct explanation.

Regards,
Radu

[4] - https://issues.apache.org/jira/browse/SLING-8827 

[5] - https://github.com/bndtools/bnd/issues/2177 

[RESULT] [VOTE] Release Apache Sling Models Implementation 1.4.12

[Nicolas Peltier]

Hi,

the vote has passed with the following result:
+1: Stefan Seifer, Radu Cotescu, David Bosschaert, myself
+1 (non binding) : Eric Norman

I will copy this release to the sling dist directory, and promote the
artifacts to the central maven repository.

Cheers,
Nicolas
Le lun. 4 nov. 2019 à 16:05, Nicolas Peltier  a écrit :

> +1
>
> Le ven. 1 nov. 2019 à 21:16, Eric Norman  a écrit :
>
>> +1 (non-binding)
>>
>> On Fri, Nov 1, 2019 at 4:14 AM Nicolas Peltier 
>> wrote:
>>
>> > Hi,
>> >
>> > We solved 6 issues in this release
>> >
>> >
>> https://issues.apache.org/jira/browse/SLING-8781?jql=project%20%3D%20SLING%20AND%20fixVersion%20%3D%20%22Sling%20Models%20Impl%201.4.12%22
>> >
>> > Staging repository:
>> > https://repository.apache.org/content/repositories/orgapachesling-[YOUR
>> > REPOSITORY ID]/
>> >
>> > You can use this UNIX script to download the release and verify the
>> > signatures:
>> >
>> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
>> >
>> > Usage:
>> > sh check_staged_release.sh 2150 /tmp/sling-staging
>> >
>> > Please vote to approve this release:
>> >
>> >   [ ] +1 Approve the release
>> >   [ ]  0 Don't care
>> >   [ ] -1 Don't release, because ...
>> >
>> > This majority vote is open for at least 72 hours.
>> >
>>
>

[GitHub] [sling-org-apache-sling-auth-core] HarisAdzemovic opened a new pull request #1: Strings and Boxed types should be compared using "equals()"

[GitBox]

HarisAdzemovic opened a new pull request #1: Strings and Boxed types should be 
compared using "equals()"
URL: https://github.com/apache/sling-org-apache-sling-auth-core/pull/1
 
 
   This fixes 1 Sonarqube violation of rule S4973:
   https://rules.sonarsource.com/java/RSPEC-4973
   
   Sonarcloud violation URL:
   
https://sonarcloud.io/organizations/apache/issues?languages=java=AWogePnQ9zLXaOU8uV59=false=squid%3AS4973=BUG
   
   Jira Ticket:
   https://issues.apache.org/jira/browse/SLING-8825


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Resolved] (SLING-8825) Strings and Boxed types should be compared using "equals()"

[Robert Munteanu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-8825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-8825.

Fix Version/s: Discovery Impl 1.2.14
 Assignee: Robert Munteanu
   Resolution: Fixed

PR applied, thanks [~HarisAdzemovic] for your contribution!

> Strings and Boxed types should be compared using "equals()"
> ---
>
> Key: SLING-8825
> URL: https://issues.apache.org/jira/browse/SLING-8825
> Project: Sling
>  Issue Type: Bug
>Reporter: Haris Adzemovic
>Assignee: Robert Munteanu
>Priority: Minor
> Fix For: Discovery Impl 1.2.14
>
>
> There are a number of Sonarqube violations relating to comparisons of Boxed 
> types and Strings using the "==" operator rather than ".equals()".
> Sonarcloud analysis: 
> [https://sonarcloud.io/organizations/apache/issues?resolved=false=squid%3AS4973]
> Violated rule: [https://rules.sonarsource.com/java/RSPEC-4973]
> Are pull requests for fixing these welcome?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (SLING-8827) api: Upgrade to parent pom 35

[Radu Cotescu (Jira)]

Radu Cotescu created SLING-8827:
---

 Summary: api: Upgrade to parent pom 35
 Key: SLING-8827
 URL: https://issues.apache.org/jira/browse/SLING-8827
 Project: Sling
  Issue Type: Sub-task
  Components: API
Reporter: Radu Cotescu
Assignee: Radu Cotescu
 Fix For: API 2.22.0


The {{org.apache.sling.api}} bundle should be updated to version 35 of the 
{{sling-bundle-parent}} pom, in order to allow builds with Java 11 and above.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)