[jira] [Comment Edited] (SLING-9332) Error logged for NonRecoverableDistributionException in SimpleDistributionAgentQueueProcessor does not log queuename

[Mohit Arora (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-9332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17076283#comment-17076283
 ] 

Mohit Arora edited comment on SLING-9332 at 4/7/20, 4:13 AM:
-

I have updated the log statements in all the classes in the project to use 
correct syntax for 1.7.x version of slf4j - 
https://github.com/apache/sling-org-apache-sling-distribution-core/pull/38

I have also verified that after this change the logger of 
SimpleDistributionAgentQueueProcessor is logging the correct message in case of 
error.

[~cschneider], [~marett] can you please review and merge the PR?


was (Author: mohiaror):
There was also [overriden 
version|https://github.com/apache/sling-org-apache-sling-distribution-core/commit/cc8ea64cc836280335eb66a587d5da330a2f9ac4]
 of slf4j in distribution-core's pom which was removed after bumping the parent 
version.

I have updated the log statements in all the classes in the project to use 
correct syntax for 1.7.x version of slf4j - 
https://github.com/apache/sling-org-apache-sling-distribution-core/pull/38

I have also verified that after this change the logger of 
SimpleDistributionAgentQueueProcessor is logging the correct message in case of 
error.

[~cschneider], [~marett] can you please review and merge the PR?

> Error logged for NonRecoverableDistributionException in 
> SimpleDistributionAgentQueueProcessor does not log queuename
> 
>
> Key: SLING-9332
> URL: https://issues.apache.org/jira/browse/SLING-9332
> Project: Sling
>  Issue Type: Bug
>  Components: Content Distribution
>Reporter: Mohit Arora
>Priority: Minor
> Fix For: Content Distribution Core 0.4.4
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> The [error message logged 
> in|https://github.com/apache/sling-org-apache-sling-distribution-core/blob/master/src/main/java/org/apache/sling/distribution/agent/impl/SimpleDistributionAgentQueueProcessor.java#L157]
>   SimpleDistributionAgentQueueProcessor uses an _Object_ to log 
> distributionpackage ID and queuename. However, from version 1.7 onward, log4j 
> seems to have stopped processing the object arrays for log statements. 
> Because of this the error logged in case of unsuccessful distribution looks 
> like - 
> {noformat}06.04.2020 07:48:30.411 *ERROR* 
> [sling-default-1-resource-queueProcessor-bpdistributionagent0-queue-bpdistributionagent0]
>  
> org.apache.sling.distribution.agent.impl.SimpleDistributionAgentQueueProcessor
>  could not deliver package 
> [dstrpck-1586159284848-e4c369fc-5bbf-4cfc-9ea3-2819af650784, 
> queue-bpdistributionagent0] from queue {}
> org.apache.sling.distribution.common.DistributionException: 
> org.apache.http.client.HttpResponseException: Bad Gateway
>   at 
> org.apache.sling.distribution.transport.impl.SimpleHttpDistributionTransport.deliverPackage(SimpleHttpDistributionTransport.java:162)
>  [org.apache.sling.distribution.core:0.4.2]
>   at 
> org.apache.sling.distribution.packaging.impl.importer.RemoteDistributionPackageImporter.importPackage(RemoteDistributionPackageImporter.java:66)
>  [org.apache.sling.distribution.core:0.4.2]
>   at 
> org.apache.sling.distribution.agent.impl.SimpleDistributionAgentQueueProcessor.processQueueItem(SimpleDistributionAgentQueueProcessor.java:134)
>  [org.apache.sling.distribution.core:0.4.2]
>   at 
> org.apache.sling.distribution.agent.impl.SimpleDistributionAgentQueueProcessor.process(SimpleDistributionAgentQueueProcessor.java:91)
>  [org.apache.sling.distribution.core:0.4.2]
>   at 
> org.apache.sling.distribution.queue.impl.simple.SimpleDistributionQueueProcessor.run(SimpleDistributionQueueProcessor.java:53)
>  [org.apache.sling.distribution.core:0.4.2]
>   at 
> org.apache.sling.commons.scheduler.impl.QuartzJobExecutor.execute(QuartzJobExecutor.java:347)
>  [org.apache.sling.commons.scheduler:2.7.6]
>   at org.quartz.core.JobRunShell.run(JobRunShell.java:202) 
> [org.apache.sling.commons.scheduler:2.7.6]
>   at 
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
>   at 
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
>   at java.base/java.lang.Thread.run(Thread.java:834)
> Caused by: org.apache.http.client.HttpResponseException: Bad Gateway
>   at 
> org.apache.http.impl.client.AbstractResponseHandler.handleResponse(AbstractResponseHandler.java:70)
>  [org.apache.httpcomponents.httpclient:4.5.4]
>   at 
> org.apache.http.client.fluent.Response.handleResponse(Response.java:90) 
> [org.apache.httpcomponents.httpclient:4.5.4]
>   at 
> org.apache.http.client.fluent.Response.returnContent(Response.java:97) 
> 

[jira] [Comment Edited] (SLING-9332) Error logged for NonRecoverableDistributionException in SimpleDistributionAgentQueueProcessor does not log queuename

[Mohit Arora (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-9332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17076256#comment-17076256
 ] 

Mohit Arora edited comment on SLING-9332 at 4/7/20, 4:12 AM:
-

The main problem is sling-distribution-core bundle using very old version of 
[sling 
parent|https://github.com/apache/sling-org-apache-sling-distribution-core/blob/master/pom.xml#L28].
 This version was changed from 26 to 28 [quite 
recently|https://github.com/apache/sling-org-apache-sling-distribution-core/commit/a1850193d63ddedced4ad982df18a62345cdf41b#diff-600376dffeb79835ede4a0b285078036]
 by [~cschneider]. Probably because of some compatibility concerns, it was not 
changed to a higher version. Sling parent has moved to 1.7.x version of slf4j a 
[long time 
back|https://github.com/apache/sling-parent/commit/4b673afd477272f84449bdede7e4f0596dcd0513]
 and I think we should at least be using that version of parent pom with latest 
slf4j version. If, however, that's not possible without trivial changes, the 
version of slf4j bundles should be overridden in distribution-core pom as it 
has always been the case.

EDIT - I just checked that version of 28 of sling-parent contains the update to 
slf4j bundle version. In that case we only need to adapt the log statement.


was (Author: mohiaror):
The main problem is sling-distribution-core bundle using very old version of 
[sling 
parent|https://github.com/apache/sling-org-apache-sling-distribution-core/blob/master/pom.xml#L28].
 This version was changed from 26 to 28 [quite 
recently|https://github.com/apache/sling-org-apache-sling-distribution-core/commit/a1850193d63ddedced4ad982df18a62345cdf41b#diff-600376dffeb79835ede4a0b285078036]
 by [~cschneider]. Probably because of some compatibility concerns, it was not 
changed to a higher version. Sling parent has moved to 1.7.x version of slf4j a 
[long time 
back|https://github.com/apache/sling-parent/commit/4b673afd477272f84449bdede7e4f0596dcd0513]
 and I think we should at least be using that version of parent pom with latest 
slf4j version. If, however, that's not possible without non-trivial changes, 
the version of log4j bundles should be overridden in distribution-core pom as 
it has always been the case.

EDIT - I just checked that version of 28 of sling-parent contains the update to 
slf4j bundle version. In that case we only need to adapt the log statement.

> Error logged for NonRecoverableDistributionException in 
> SimpleDistributionAgentQueueProcessor does not log queuename
> 
>
> Key: SLING-9332
> URL: https://issues.apache.org/jira/browse/SLING-9332
> Project: Sling
>  Issue Type: Bug
>  Components: Content Distribution
>Reporter: Mohit Arora
>Priority: Minor
> Fix For: Content Distribution Core 0.4.4
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> The [error message logged 
> in|https://github.com/apache/sling-org-apache-sling-distribution-core/blob/master/src/main/java/org/apache/sling/distribution/agent/impl/SimpleDistributionAgentQueueProcessor.java#L157]
>   SimpleDistributionAgentQueueProcessor uses an _Object_ to log 
> distributionpackage ID and queuename. However, from version 1.7 onward, log4j 
> seems to have stopped processing the object arrays for log statements. 
> Because of this the error logged in case of unsuccessful distribution looks 
> like - 
> {noformat}06.04.2020 07:48:30.411 *ERROR* 
> [sling-default-1-resource-queueProcessor-bpdistributionagent0-queue-bpdistributionagent0]
>  
> org.apache.sling.distribution.agent.impl.SimpleDistributionAgentQueueProcessor
>  could not deliver package 
> [dstrpck-1586159284848-e4c369fc-5bbf-4cfc-9ea3-2819af650784, 
> queue-bpdistributionagent0] from queue {}
> org.apache.sling.distribution.common.DistributionException: 
> org.apache.http.client.HttpResponseException: Bad Gateway
>   at 
> org.apache.sling.distribution.transport.impl.SimpleHttpDistributionTransport.deliverPackage(SimpleHttpDistributionTransport.java:162)
>  [org.apache.sling.distribution.core:0.4.2]
>   at 
> org.apache.sling.distribution.packaging.impl.importer.RemoteDistributionPackageImporter.importPackage(RemoteDistributionPackageImporter.java:66)
>  [org.apache.sling.distribution.core:0.4.2]
>   at 
> org.apache.sling.distribution.agent.impl.SimpleDistributionAgentQueueProcessor.processQueueItem(SimpleDistributionAgentQueueProcessor.java:134)
>  [org.apache.sling.distribution.core:0.4.2]
>   at 
> org.apache.sling.distribution.agent.impl.SimpleDistributionAgentQueueProcessor.process(SimpleDistributionAgentQueueProcessor.java:91)
>  [org.apache.sling.distribution.core:0.4.2]
>   at 
> 

[jira] [Updated] (SLING-9337) sling:alias not working when alias caching enabled

[Ben Fortuna (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ben Fortuna updated SLING-9337:
---
 Attachment: image-2020-04-07-09-17-32-399.png
Description: 
I'd like to use Sling aliases to reference the current content as follows (node 
is /content/wnews/articles/2020):
{code:java}
{
  "jcr:primaryType": "nt:unstructured",
  "title": "Articles (2020)",
  "sling:alias": "current",
  "pageSize": 7,
  "sling:resourceType": "wnews/page/article-list"
} {code}
So for example, the following URLs should both work:
 * [http://example.com/content/wnews/articles/2020.html]
 * [http://example.com/content/wnews/articles/current.html]

I've discovered that the "current" url doesn't resolved unless I disable alias 
caching in the Resource Resolver Factory:

  !image-2020-04-07-09-17-32-399.png!

 

I'm pretty sure this isn't a good workaround, especially as it causes other 
issues with redirects of URLs with no extension.

Any other possible reasons why this isn't working?

Other refs:
 * 
[https://experienceleaguecommunities.adobe.com/t5/adobe-experience-manager/apache-sling-resource-alias-caching/qaq-p/169480]

 

  was:
I'd like to use Sling aliases to reference the current content as follows (node 
is /content/wnews/articles/2020):
{code:java}
{
  "jcr:primaryType": "nt:unstructured",
  "title": "Articles (2020)",
  "sling:alias": "current",
  "pageSize": 7,
  "sling:resourceType": "wnews/page/article-list"
} {code}
So for example, the following URLs should both work:
 * [http://example.com/content/wnews/articles/2020.html]
 * [http://example.com/content/wnews/articles/current.html]

I've discovered that the "current" url doesn't resolved unless I disable alias 
caching in the Resource Resolver Factory:

 

 

I'm pretty sure this isn't a good workaround, especially as it causes other 
issues with redirects of URLs with no extension.

Any other possible reasons why this isn't working?

Other refs:
 * 
[https://experienceleaguecommunities.adobe.com/t5/adobe-experience-manager/apache-sling-resource-alias-caching/qaq-p/169480]

 


> sling:alias not working when alias caching enabled
> --
>
> Key: SLING-9337
> URL: https://issues.apache.org/jira/browse/SLING-9337
> Project: Sling
>  Issue Type: Bug
>  Components: ResourceResolver
>Reporter: Ben Fortuna
>Priority: Major
> Attachments: image-2020-04-07-09-17-32-399.png
>
>
> I'd like to use Sling aliases to reference the current content as follows 
> (node is /content/wnews/articles/2020):
> {code:java}
> {
>   "jcr:primaryType": "nt:unstructured",
>   "title": "Articles (2020)",
>   "sling:alias": "current",
>   "pageSize": 7,
>   "sling:resourceType": "wnews/page/article-list"
> } {code}
> So for example, the following URLs should both work:
>  * [http://example.com/content/wnews/articles/2020.html]
>  * [http://example.com/content/wnews/articles/current.html]
> I've discovered that the "current" url doesn't resolved unless I disable 
> alias caching in the Resource Resolver Factory:
>   !image-2020-04-07-09-17-32-399.png!
>  
> I'm pretty sure this isn't a good workaround, especially as it causes other 
> issues with redirects of URLs with no extension.
> Any other possible reasons why this isn't working?
> Other refs:
>  * 
> [https://experienceleaguecommunities.adobe.com/t5/adobe-experience-manager/apache-sling-resource-alias-caching/qaq-p/169480]
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (SLING-9337) sling:alias not working when alias caching enabled

[Ben Fortuna (Jira)]

Ben Fortuna created SLING-9337:
--

 Summary: sling:alias not working when alias caching enabled
 Key: SLING-9337
 URL: https://issues.apache.org/jira/browse/SLING-9337
 Project: Sling
  Issue Type: Bug
  Components: ResourceResolver
Reporter: Ben Fortuna
 Attachments: image-2020-04-07-09-17-32-399.png

I'd like to use Sling aliases to reference the current content as follows (node 
is /content/wnews/articles/2020):
{code:java}
{
  "jcr:primaryType": "nt:unstructured",
  "title": "Articles (2020)",
  "sling:alias": "current",
  "pageSize": 7,
  "sling:resourceType": "wnews/page/article-list"
} {code}
So for example, the following URLs should both work:
 * [http://example.com/content/wnews/articles/2020.html]
 * [http://example.com/content/wnews/articles/current.html]

I've discovered that the "current" url doesn't resolved unless I disable alias 
caching in the Resource Resolver Factory:

 

 

I'm pretty sure this isn't a good workaround, especially as it causes other 
issues with redirects of URLs with no extension.

Any other possible reasons why this isn't working?

Other refs:
 * 
[https://experienceleaguecommunities.adobe.com/t5/adobe-experience-manager/apache-sling-resource-alias-caching/qaq-p/169480]

 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [sling-whiteboard] cmrockwell commented on a change in pull request #51: SAML2 Service Provider Pull Request

[GitBox]

cmrockwell commented on a change in pull request #51: SAML2 Service Provider 
Pull Request
URL: https://github.com/apache/sling-whiteboard/pull/51#discussion_r404400439
 
 

 ##
 File path: saml-handler/pom.xml
 ##
 @@ -0,0 +1,366 @@
+
+
+http://maven.apache.org/POM/4.0.0;
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+  
+org.apache.sling
+sling
+37
+
+  
+
+  4.0.0
+  org.apache.sling.auth
+  saml2
+  0.1.0-SNAPSHOT
+  SAML2 Service Provider
+
+  
+3.4.3
+localhost
+8080
+admin
+admin
+  
+
+  bundle
+
+  
+
+  
+org.apache.felix
+maven-bundle-plugin
+3.5.0
+true
+
+  
+
org.apache.sling.auth.saml2.Activator
+*;scope=compile|runtime;
 
 Review comment:
   I tried timing it down a bit, but still 16.6MB. Seems the first priority is 
to go with bnd plugin, and I would really appreciate any help help with that I 
could get. BND seems to have a lot of features that could help reduce the size.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [sling-whiteboard] cmrockwell commented on a change in pull request #51: SAML2 Service Provider Pull Request

[GitBox]

cmrockwell commented on a change in pull request #51: SAML2 Service Provider 
Pull Request
URL: https://github.com/apache/sling-whiteboard/pull/51#discussion_r404399296
 
 

 ##
 File path: 
saml-handler/src/main/java/org/apache/sling/auth/saml2/AuthenticationHandlerSAML2.java
 ##
 @@ -0,0 +1,661 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.sling.auth.saml2;
+
+import 
net.shibboleth.utilities.java.support.component.ComponentInitializationException;
+import net.shibboleth.utilities.java.support.xml.ParserPool;
+import org.apache.jackrabbit.api.security.user.User;
+import org.apache.sling.auth.core.AuthUtil;
+import org.apache.sling.auth.saml2.idp.IDPCredentials;
+import org.apache.sling.auth.saml2.impl.SAML2ConfigServiceImpl;
+import org.apache.sling.auth.saml2.impl.Saml2Credentials;
+import org.apache.sling.auth.saml2.sp.SPCredentials;
+import org.apache.sling.auth.saml2.sync.Saml2User;
+import org.joda.time.DateTime;
+import org.opensaml.core.xml.XMLObject;
+import org.opensaml.core.xml.config.XMLObjectProviderRegistrySupport;
+import org.opensaml.core.xml.schema.XSString;
+import org.opensaml.messaging.context.MessageContext;
+import org.opensaml.messaging.decoder.MessageDecodingException;
+import org.opensaml.messaging.encoder.MessageEncodingException;
+import org.opensaml.saml.common.messaging.context.SAMLBindingContext;
+import org.opensaml.saml.common.messaging.context.SAMLEndpointContext;
+import org.opensaml.saml.common.messaging.context.SAMLPeerEntityContext;
+import org.opensaml.saml.saml2.binding.decoding.impl.HTTPPostDecoder;
+import 
org.opensaml.saml.saml2.binding.encoding.impl.HTTPRedirectDeflateEncoder;
+import org.opensaml.saml.saml2.core.*;
+import org.opensaml.saml.common.xml.SAMLConstants;
+import org.opensaml.saml.saml2.encryption.Decrypter;
+import org.opensaml.saml.saml2.metadata.Endpoint;
+import org.opensaml.saml.saml2.metadata.SingleSignOnService;
+import org.opensaml.saml.security.impl.SAMLSignatureProfileValidator;
+import org.opensaml.xmlsec.SignatureSigningParameters;
+import org.opensaml.xmlsec.context.SecurityParametersContext;
+import org.opensaml.xmlsec.encryption.support.DecryptionException;
+import org.opensaml.xmlsec.encryption.support.InlineEncryptedKeyResolver;
+import org.opensaml.xmlsec.keyinfo.impl.StaticKeyInfoCredentialResolver;
+import org.opensaml.xmlsec.signature.support.SignatureConstants;
+import org.opensaml.xmlsec.signature.support.SignatureException;
+import org.opensaml.xmlsec.signature.support.SignatureValidator;
+import org.osgi.framework.BundleContext;
+import org.osgi.framework.FrameworkUtil;
+import org.osgi.framework.wiring.BundleWiring;
+import org.apache.sling.auth.core.spi.AuthenticationHandler;
+import org.apache.sling.auth.core.spi.AuthenticationInfo;
+import org.apache.sling.auth.core.spi.DefaultAuthenticationFeedbackHandler;
+import org.apache.sling.auth.saml2.sp.SessionStorage;
+import org.osgi.service.component.ComponentContext;
+import org.osgi.service.component.annotations.*;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import javax.jcr.RepositoryException;
+import javax.servlet.http.HttpServletRequest;
+import javax.servlet.http.HttpServletResponse;
+import java.io.File;
+import java.io.IOException;
+import java.io.UnsupportedEncodingException;
+import java.math.BigInteger;
+import java.security.InvalidKeyException;
+import java.security.NoSuchAlgorithmException;
+import java.security.SecureRandom;
+import static 
org.apache.sling.auth.saml2.idp.Saml2IDPServlet.TEST_IDP_ENDPOINT;
+
+
+@Component(
+service = AuthenticationHandler.class ,
+name = AuthenticationHandlerSAML2.SERVICE_NAME,
+configurationPid = 
"org.apache.sling.auth.saml2.impl.SAML2ConfigServiceImpl",
+configurationPolicy = ConfigurationPolicy.REQUIRE,
+property = {"sling.servlet.methods={GET, POST}",
+AuthenticationHandler.PATH_PROPERTY+"={}",
+AuthenticationHandler.TYPE_PROPERTY + "=" + 
AuthenticationHandlerSAML2.AUTH_TYPE,
+"service.description=SAML2 Authentication Handler",
+"service.ranking=42",
+},
+immediate = true)
 
 Review comment:
   If 

[GitHub] [sling-whiteboard] cmrockwell commented on a change in pull request #51: SAML2 Service Provider Pull Request

[GitBox]

cmrockwell commented on a change in pull request #51: SAML2 Service Provider 
Pull Request
URL: https://github.com/apache/sling-whiteboard/pull/51#discussion_r404396230
 
 

 ##
 File path: saml-handler/pom.xml
 ##
 @@ -0,0 +1,378 @@
+
+
+http://maven.apache.org/POM/4.0.0;
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+  
+org.apache.sling
+sling
+37
+
+  
+
+  4.0.0
+  org.apache.sling.auth
+  saml2
+  0.1.0-SNAPSHOT
+  SAML2 Service Provider
+
+  
+3.4.3
+localhost
+8080
+admin
+admin
+  
+
+  bundle
+
+  
+
+  
+org.apache.felix
+maven-bundle-plugin
+3.5.0
+true
+
+  
+
org.apache.sling.auth.saml2.Activator
+*;scope=compile|runtime;
+true
+target/dependency
+true
+
+  !sun.misc;resolution:=optional,
+  !com.sun.msv.*;resolution:=optional,
+  !com.sun.jdmk.comm;resolution:=optional,
+  sun.io.*;resolution:=optional,
+  com.beust.jcommander*;resolution:=optional,
+  com.google.appengine.api.*;resolution:=optional,
+  com.google.apphosting.api.*;resolution:=optional,
+  com.google.appengine.repackaged.*;resolution:=optional,
+  org.apache.log.*;resolution:=optional,
+  org.apache.oro.text.perl.*;resolution:=optional,
+  antlr.*;resolution:=optional,
+  org.apache.tools.ant.*;resolution:=optional,
+  junit.framework.*;resolution:=optional,
+  org.dom4j.*;resolution:=optional,
+  org.jdom.*;resolution:=optional,
+  org.bouncycastle.*;resolution:=optional,
+  com.sun.org.apache.xerces.internal.*;resolution:=optional,
+  *
+<_noee>true
+  
+
+  
+
+  
+org.apache.sling
+maven-sling-plugin
+  
+
+  
+org.apache.maven.plugins
+maven-compiler-plugin
+
+  8
+  8
+
+  
+
+  
+org.apache.maven.plugins
+maven-jar-plugin
+2.6
+
+  
+
${project.build.outputDirectory}/META-INF/MANIFEST.MF
+
+  
org.apache.sling.auth.saml2.sync.Saml2LoginModule
+
+  
+
+  
+
+  
+org.apache.sling
+maven-sling-plugin
+2.4.2
 
 Review comment:
   I removed the version


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [sling-whiteboard] cmrockwell commented on a change in pull request #51: SAML2 Service Provider Pull Request

[GitBox]

cmrockwell commented on a change in pull request #51: SAML2 Service Provider 
Pull Request
URL: https://github.com/apache/sling-whiteboard/pull/51#discussion_r404350338
 
 

 ##
 File path: saml-handler/pom.xml
 ##
 @@ -0,0 +1,366 @@
+
+
+http://maven.apache.org/POM/4.0.0;
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+  
+org.apache.sling
+sling
+37
+
+  
+
+  4.0.0
+  org.apache.sling.auth
+  saml2
+  0.1.0-SNAPSHOT
+  SAML2 Service Provider
+
+  
+3.4.3
+localhost
+8080
+admin
+admin
+  
+
+  bundle
+
+  
+
+  
+org.apache.felix
+maven-bundle-plugin
+3.5.0
+true
+
+  
+
org.apache.sling.auth.saml2.Activator
+*;scope=compile|runtime;
+true
+target/dependency
+true
+
+  !sun.misc;resolution:=optional,
+  !com.sun.msv.*;resolution:=optional,
+  !com.sun.jdmk.comm;resolution:=optional,
+  sun.io.*;resolution:=optional,
+  com.beust.jcommander*;resolution:=optional,
+  com.google.appengine.api.*;resolution:=optional,
+  com.google.apphosting.api.*;resolution:=optional,
+  com.google.appengine.repackaged.*;resolution:=optional,
+  org.apache.log.*;resolution:=optional,
+  org.apache.oro.text.perl.*;resolution:=optional,
+  antlr.*;resolution:=optional,
+  org.apache.tools.ant.*;resolution:=optional,
+  junit.framework.*;resolution:=optional,
+  org.dom4j.*;resolution:=optional,
+  org.jdom.*;resolution:=optional,
+  org.bouncycastle.*;resolution:=optional,
+  com.sun.org.apache.xerces.internal.*;resolution:=optional,
+  *
+<_noee>true
 
 Review comment:
   If I remove the `_noee` directive, I get the error below and the bundle 
doesn't activate. I'll take a look at your plugin related questions and circle 
back to this.
   
   06.04.2020 15:51:23.218 *ERROR* [Background Update 
org.apache.sling.auth.saml2 (179)] org.apache.felix.http.jetty Cannot install 
or update bundle from 
/var/folders/ww/vd006cgx4zgdvvxcfk02b5xrgp/T/install2386711195585220288.tmp 
(org.osgi.framework.BundleException: Unable to resolve 
org.apache.sling.auth.saml2 [179](R 179.190): missing requirement 
[org.apache.sling.auth.saml2 [179](R 179.190)] osgi.ee; 
(&(osgi.ee=JavaSE)(version=9.0)) Unresolved requirements: 
[[org.apache.sling.auth.saml2 [179](R 179.190)] osgi.ee; 
(&(osgi.ee=JavaSE)(version=9.0))])
   org.osgi.framework.BundleException: Unable to resolve 
org.apache.sling.auth.saml2 [179](R 179.190): missing requirement 
[org.apache.sling.auth.saml2 [179](R 179.190)] osgi.ee; 
(&(osgi.ee=JavaSE)(version=9.0)) Unresolved requirements: 
[[org.apache.sling.auth.saml2 [179](R 179.190)] osgi.ee; 
(&(osgi.ee=JavaSE)(version=9.0))]
at 
org.apache.felix.framework.Felix.resolveBundleRevision(Felix.java:4133)
at org.apache.felix.framework.Felix.startBundle(Felix.java:2118)
at org.apache.felix.framework.BundleImpl.start(BundleImpl.java:998)
at 
org.apache.felix.webconsole.internal.core.BaseUpdateInstallHelper.run(BaseUpdateInstallHelper.java:192)
at java.lang.Thread.run(Thread.java:748)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [sling-whiteboard] cmrockwell commented on a change in pull request #51: SAML2 Service Provider Pull Request

[GitBox]

cmrockwell commented on a change in pull request #51: SAML2 Service Provider 
Pull Request
URL: https://github.com/apache/sling-whiteboard/pull/51#discussion_r404305355
 
 

 ##
 File path: 
saml-handler/src/main/java/org/apache/sling/auth/saml2/AuthenticationHandlerSAML2.java
 ##
 @@ -0,0 +1,661 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.sling.auth.saml2;
+
+import 
net.shibboleth.utilities.java.support.component.ComponentInitializationException;
+import net.shibboleth.utilities.java.support.xml.ParserPool;
+import org.apache.jackrabbit.api.security.user.User;
+import org.apache.sling.auth.core.AuthUtil;
+import org.apache.sling.auth.saml2.idp.IDPCredentials;
+import org.apache.sling.auth.saml2.impl.SAML2ConfigServiceImpl;
+import org.apache.sling.auth.saml2.impl.Saml2Credentials;
+import org.apache.sling.auth.saml2.sp.SPCredentials;
+import org.apache.sling.auth.saml2.sync.Saml2User;
+import org.joda.time.DateTime;
+import org.opensaml.core.xml.XMLObject;
+import org.opensaml.core.xml.config.XMLObjectProviderRegistrySupport;
+import org.opensaml.core.xml.schema.XSString;
+import org.opensaml.messaging.context.MessageContext;
+import org.opensaml.messaging.decoder.MessageDecodingException;
+import org.opensaml.messaging.encoder.MessageEncodingException;
+import org.opensaml.saml.common.messaging.context.SAMLBindingContext;
+import org.opensaml.saml.common.messaging.context.SAMLEndpointContext;
+import org.opensaml.saml.common.messaging.context.SAMLPeerEntityContext;
+import org.opensaml.saml.saml2.binding.decoding.impl.HTTPPostDecoder;
+import 
org.opensaml.saml.saml2.binding.encoding.impl.HTTPRedirectDeflateEncoder;
+import org.opensaml.saml.saml2.core.*;
+import org.opensaml.saml.common.xml.SAMLConstants;
+import org.opensaml.saml.saml2.encryption.Decrypter;
+import org.opensaml.saml.saml2.metadata.Endpoint;
+import org.opensaml.saml.saml2.metadata.SingleSignOnService;
+import org.opensaml.saml.security.impl.SAMLSignatureProfileValidator;
+import org.opensaml.xmlsec.SignatureSigningParameters;
+import org.opensaml.xmlsec.context.SecurityParametersContext;
+import org.opensaml.xmlsec.encryption.support.DecryptionException;
+import org.opensaml.xmlsec.encryption.support.InlineEncryptedKeyResolver;
+import org.opensaml.xmlsec.keyinfo.impl.StaticKeyInfoCredentialResolver;
+import org.opensaml.xmlsec.signature.support.SignatureConstants;
+import org.opensaml.xmlsec.signature.support.SignatureException;
+import org.opensaml.xmlsec.signature.support.SignatureValidator;
+import org.osgi.framework.BundleContext;
+import org.osgi.framework.FrameworkUtil;
+import org.osgi.framework.wiring.BundleWiring;
+import org.apache.sling.auth.core.spi.AuthenticationHandler;
+import org.apache.sling.auth.core.spi.AuthenticationInfo;
+import org.apache.sling.auth.core.spi.DefaultAuthenticationFeedbackHandler;
+import org.apache.sling.auth.saml2.sp.SessionStorage;
+import org.osgi.service.component.ComponentContext;
+import org.osgi.service.component.annotations.*;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import javax.jcr.RepositoryException;
+import javax.servlet.http.HttpServletRequest;
+import javax.servlet.http.HttpServletResponse;
+import java.io.File;
+import java.io.IOException;
+import java.io.UnsupportedEncodingException;
+import java.math.BigInteger;
+import java.security.InvalidKeyException;
+import java.security.NoSuchAlgorithmException;
+import java.security.SecureRandom;
+import static 
org.apache.sling.auth.saml2.idp.Saml2IDPServlet.TEST_IDP_ENDPOINT;
+
+
+@Component(
+service = AuthenticationHandler.class ,
+name = AuthenticationHandlerSAML2.SERVICE_NAME,
+configurationPid = 
"org.apache.sling.auth.saml2.impl.SAML2ConfigServiceImpl",
+configurationPolicy = ConfigurationPolicy.REQUIRE,
+property = {"sling.servlet.methods={GET, POST}",
+AuthenticationHandler.PATH_PROPERTY+"={}",
+AuthenticationHandler.TYPE_PROPERTY + "=" + 
AuthenticationHandlerSAML2.AUTH_TYPE,
+"service.description=SAML2 Authentication Handler",
+"service.ranking=42",
 
 Review comment:
   Awesome! thanks for the feedback. That 

Re: Doing a Feathercast interview on Sling next Monday, your input is welcome

[Bertrand Delacretaz]

Hi,

On Mon, Apr 6, 2020 at 10:37 AM Robert Munteanu  wrote:
>... I can't see any improvements to what you have posted, have fun :-)..

thank you, I did!

The audio is at Feathercast: https://wp.me/p8gHED-1bn

Video is on YouTube: https://youtu.be/tNE4xAPt910

-Bertrand

[jira] [Resolved] (SLING-9335) Capabilities based on the extends file should be merged with capabilities based on resource label scripts

[Radu Cotescu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radu Cotescu resolved SLING-9335.
-
Resolution: Fixed

Fixed in:
* commit [commit 
d4663fb|https://github.com/apache/sling-scriptingbundle-maven-plugin/commit/d4663fb]
* [commit 
a194e58|https://github.com/apache/sling-org-apache-sling-scripting-bundle-tracker-it/commit/a194e58]

> Capabilities based on the extends file should be merged with capabilities 
> based on resource label scripts
> -
>
> Key: SLING-9335
> URL: https://issues.apache.org/jira/browse/SLING-9335
> Project: Sling
>  Issue Type: Bug
>  Components: Maven Plugins and Archetypes
>Reporter: Radu Cotescu
>Assignee: Radu Cotescu
>Priority: Major
> Fix For: Scripting Bundle Maven Plugin 0.2.0
>
>
> Currently a capability generated from an {{extends}} file will co-exist with 
> a capability generated from a resource label script, leading to issues at 
> runtime when it comes to finding the correct executable which has to handle a 
> certain resource type. As such, these capabilities should be merged 
> automatically by the plugin, before generating the values for the bundle's 
> manifest.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-9118) Sling fails to start when database exists but 'sling' directory is missing

[Carlos Munoz (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-9118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17076428#comment-17076428
 ] 

Carlos Munoz commented on SLING-9118:
-

Ahh... here it is: [^error.log]

> Sling fails to start when database exists but 'sling' directory is missing
> --
>
> Key: SLING-9118
> URL: https://issues.apache.org/jira/browse/SLING-9118
> Project: Sling
>  Issue Type: Bug
>Reporter: Ben Radey
>Assignee: Robert Munteanu
>Priority: Major
> Attachments: drop-mongo.sh, error.log, recreateSlingReplicaSet.sh, 
> run-mongo.sh, run-sling-initial.sh, run-sling-second.sh, 
> sling-startup-error.log.txt
>
>
> # Create a persistent mongodb to use with Sling.
>  # Start sling using the mongodb.
>  # Stop sling.
>  # Remove 'sling' directory.
>  # Attempt to restart sling. Ultimately, sling fails to start.
> 
> Steps to reproduce with attached scripts:
> # Run [^run-mongo.sh] . This creates a MongoDB 3.6 container named 
> _mongo-sling_
> # Run [^run-sling-initial.sh]. This starts up Sling in the oak_mongo runmode, 
> shuts it down after it's (probably) started up
> # Run [^run-sling-second.sh]. This moves away the sling directory and starts 
> up a new instance. This always fails
> For cleanup, the [^drop-mongo.sh] script stops and removes the _mongo-sling_ 
> container.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-9118) Sling fails to start when database exists but 'sling' directory is missing

[Carlos Munoz (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carlos Munoz updated SLING-9118:

Attachment: error.log

> Sling fails to start when database exists but 'sling' directory is missing
> --
>
> Key: SLING-9118
> URL: https://issues.apache.org/jira/browse/SLING-9118
> Project: Sling
>  Issue Type: Bug
>Reporter: Ben Radey
>Assignee: Robert Munteanu
>Priority: Major
> Attachments: drop-mongo.sh, error.log, recreateSlingReplicaSet.sh, 
> run-mongo.sh, run-sling-initial.sh, run-sling-second.sh, 
> sling-startup-error.log.txt
>
>
> # Create a persistent mongodb to use with Sling.
>  # Start sling using the mongodb.
>  # Stop sling.
>  # Remove 'sling' directory.
>  # Attempt to restart sling. Ultimately, sling fails to start.
> 
> Steps to reproduce with attached scripts:
> # Run [^run-mongo.sh] . This creates a MongoDB 3.6 container named 
> _mongo-sling_
> # Run [^run-sling-initial.sh]. This starts up Sling in the oak_mongo runmode, 
> shuts it down after it's (probably) started up
> # Run [^run-sling-second.sh]. This moves away the sling directory and starts 
> up a new instance. This always fails
> For cleanup, the [^drop-mongo.sh] script stops and removes the _mongo-sling_ 
> container.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [sling-whiteboard] rombert commented on a change in pull request #51: SAML2 Service Provider Pull Request

[GitBox]

rombert commented on a change in pull request #51: SAML2 Service Provider Pull 
Request
URL: https://github.com/apache/sling-whiteboard/pull/51#discussion_r404162549
 
 

 ##
 File path: saml-handler/pom.xml
 ##
 @@ -0,0 +1,366 @@
+
+
+http://maven.apache.org/POM/4.0.0;
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+  
+org.apache.sling
+sling
+37
+
+  
+
+  4.0.0
+  org.apache.sling.auth
+  saml2
+  0.1.0-SNAPSHOT
+  SAML2 Service Provider
+
+  
+3.4.3
+localhost
+8080
+admin
+admin
+  
+
+  bundle
+
+  
+
+  
+org.apache.felix
+maven-bundle-plugin
+3.5.0
+true
+
+  
+
org.apache.sling.auth.saml2.Activator
+*;scope=compile|runtime;
+true
+target/dependency
+true
+
+  !sun.misc;resolution:=optional,
+  !com.sun.msv.*;resolution:=optional,
+  !com.sun.jdmk.comm;resolution:=optional,
+  sun.io.*;resolution:=optional,
+  com.beust.jcommander*;resolution:=optional,
+  com.google.appengine.api.*;resolution:=optional,
+  com.google.apphosting.api.*;resolution:=optional,
+  com.google.appengine.repackaged.*;resolution:=optional,
+  org.apache.log.*;resolution:=optional,
+  org.apache.oro.text.perl.*;resolution:=optional,
+  antlr.*;resolution:=optional,
+  org.apache.tools.ant.*;resolution:=optional,
+  junit.framework.*;resolution:=optional,
+  org.dom4j.*;resolution:=optional,
+  org.jdom.*;resolution:=optional,
+  org.bouncycastle.*;resolution:=optional,
+  com.sun.org.apache.xerces.internal.*;resolution:=optional,
+  *
+<_noee>true
 
 Review comment:
   Why is this needed?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [sling-whiteboard] rombert commented on a change in pull request #51: SAML2 Service Provider Pull Request

[GitBox]

rombert commented on a change in pull request #51: SAML2 Service Provider Pull 
Request
URL: https://github.com/apache/sling-whiteboard/pull/51#discussion_r404161328
 
 

 ##
 File path: saml-handler/pom.xml
 ##
 @@ -0,0 +1,366 @@
+
+
+http://maven.apache.org/POM/4.0.0;
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+  
+org.apache.sling
+sling
+37
+
+  
+
+  4.0.0
+  org.apache.sling.auth
+  saml2
+  0.1.0-SNAPSHOT
+  SAML2 Service Provider
+
+  
+3.4.3
+localhost
+8080
+admin
+admin
+  
+
+  bundle
+
+  
+
+  
+org.apache.felix
+maven-bundle-plugin
+3.5.0
+true
+
+  
+
org.apache.sling.auth.saml2.Activator
+*;scope=compile|runtime;
 
 Review comment:
   You don't need to do this _now_, but the bundle is very heavy right now. 
It's at 18MB in size and embeds 40 jars, including some that should be 
available as OSGi bundles, e.g. XML parsers, commons-*, guava, metrics. That 
should be reviewed at some point.
   
   Are the opensaml jars OSGi-aware or is there the potential to make them 
OSGi-aware?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [sling-org-apache-sling-scripting-bundle-tracker] sonarcloud[bot] commented on issue #1: SLING-9336: filter servlet services with a hook.

[GitBox]

sonarcloud[bot] commented on issue #1: SLING-9336: filter servlet services with 
a hook.
URL: 
https://github.com/apache/sling-org-apache-sling-scripting-bundle-tracker/pull/1#issuecomment-609845619
 
 
   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-bundle-tracker=1=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-bundle-tracker=1=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-bundle-tracker=1=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-bundle-tracker=1=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-bundle-tracker=1=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-bundle-tracker=1=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-bundle-tracker=1=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-bundle-tracker=1=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-bundle-tracker=1=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-bundle-tracker=1=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-bundle-tracker=1=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-bundle-tracker=1=new_coverage=list)
 [84.0% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-bundle-tracker=1=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-bundle-tracker=1=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-bundle-tracker=1=new_duplicated_lines_density=list)
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: [VOTE] Release Apache Sling Testing Clients version 2.0.0 and Apache Sling Testing Rules version 2.0.0

[Daniel Klco]

+1

On Mon, Apr 6, 2020 at 9:20 AM Andrei Dulvac  wrote:

> Hi,
> We solved 5 issues across those two releases
>
>
> https://issues.apache.org/jira/projects/SLING/versions/12347772
>
> https://issues.apache.org/jira/projects/SLING/versions/12344767
>
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-2236
>
>
> You can use this UNIX script to download the release and verify the
> signatures:
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
>
> Usage:
> sh check_staged_release.sh 2236 /tmp/sling-staging
>
>
>
> Please vote to approve this release:
>
>   [ ] +1 Approve the release
>   [ ]  0 Don't care
>   [ ] -1 Don't release, because ...
>
> This majority vote is open for at least 72 hours.
>
>
> -Andrei
>

[GitHub] [sling-org-apache-sling-scripting-bundle-tracker] karlpauls opened a new pull request #1: SLING-9336: filter servlet services with a hook.

[GitBox]

karlpauls opened a new pull request #1: SLING-9336: filter servlet services 
with a hook.
URL: 
https://github.com/apache/sling-org-apache-sling-scripting-bundle-tracker/pull/1
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Created] (SLING-9336) Hide servlet services from the outside

[Karl Pauls (Jira)]

Karl Pauls created SLING-9336:
-

 Summary: Hide servlet services from the outside
 Key: SLING-9336
 URL: https://issues.apache.org/jira/browse/SLING-9336
 Project: Sling
  Issue Type: Improvement
  Components: Scripting
Reporter: Karl Pauls
Assignee: Karl Pauls
 Fix For: Scripting Bundle Tracker 0.2.0


As the bundle script tracker might register a lot of services we should hide 
them using hooks form everything except the servletresolver. Otherwise, we 
cause problems in other parts of the system that might not be able to work with 
a high number of services and as the services really are represented as 
resources we don't need to expose them.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Consistently failing ITs

[Konrad Windszus]

That is because testing war 
(https://github.com/apache/sling-org-apache-sling-launchpad-testing-war/blob/master/src/main/provisioning/model.txt
 
)
 does not deploy anything apart from the starter and some test-bundles.
It IMHO must deploy 
https://github.com/apache/sling-org-apache-sling-launchpad-test-services-war 
 
in addition.
Konrad

> On 6. Apr 2020, at 16:04, Robert Munteanu  wrote:
> 
> FWIW, the same tests fail in launchpad-testing-war as well [1].
> 
> So that is probably not the right fix to do.
> 
> [1]: 
> https://builds.apache.org/job/Sling/job/sling-org-apache-sling-launchpad-testing-war/job/master/68/console
> 
> 
> 
> On Wed, 2020-04-01 at 16:06 +0200, Robert Munteanu wrote:
>> Sounds like a reasonable explanation to me.
>> 
>> Thanks,
>> Robert
>> 
>> On Wed, 2020-04-01 at 16:03 +0200, Konrad Windszus wrote:
>>> What I assume happened was the following:
>>> 
>>> The WAR was incorrectly treated as bundle and therefore installed
>>> by
>>> the OSGi Installer for bundles.
>>> As consequence the according servlets were registered.
>>> 
>>> 
 On 1. Apr 2020, at 16:00, Robert Munteanu 
 wrote:
 
 I agree in principle. But why did these not fail until now?
 
 Thanks,
 Robert
 
 On Wed, 2020-04-01 at 15:39 +0200, Konrad Windszus wrote:
> IMHO there are some test which should only be executed from 
> https://github.com/apache/sling-org-apache-sling-launchpad-testing-war
> , namely 
> https://github.com/apache/sling-org-apache-sling-launchpad-integration-tests/blob/bd0c0c270b73e582dc5dfa3ed25231c951d0c98d/src/main/java/org/apache/sling/launchpad/webapp/integrationtest/servlets/resolution/WarSelectorServletTest.java
> .
> 
> That should IMHO be moved to 
> https://github.com/apache/sling-org-apache-sling-launchpad-testing-war
> to make sure it is not executed with 
> https://github.com/apache/sling-org-apache-sling-launchpad-testing.
> WDYT?
> 
> Konrad
> 
>> On 1. Apr 2020, at 15:29, Konrad Windszus 
>> wrote:
>> 
>> Done with 
>> https://github.com/apache/sling-org-apache-sling-launchpad-test-bundles/commit/43956dd07234ddc3263ce29c5b7c3f7198ad4caf
>> <
>> https://github.com/apache/sling-org-apache-sling-launchpad-test-bundles/commit/43956dd07234ddc3263ce29c5b7c3f7198ad4caf>
>> ;.
>> 
>> That leaves us with 2 remaining issues:
>> 
>> [ERROR] Failures: 
>> [ERROR]   WarSelectorServletTest.testSelectorOne:23-
>>> ResolutionTestBase.assertServlet:75 Content contains
>> servlet.class.name property (** Resource dumped by
>> PlainTextRenderer**
>> Resource path:/servlet-resolution-
>> tests/1585747495298/this_is_a_test_node_
>> Resource metadata: {sling.modificationTime=-1,
>> sling.characterEncoding=null, sling.parameterMap={},
>> sling.contentType=null, sling.creationTime=-1,
>> sling.contentLength=-1, sling.resolutionPath=/servlet-
>> resolution-
>> tests/1585747495298/this_is_a_test_node_,
>> sling.resolutionPathInfo=.WAR_TEST_SEL_1.txt}
>> Resource type: nt:unstructured
>> Resource super type: -
>> 
>> ** Resource properties **
>> jcr:primaryType: nt:unstructured
>> text: This is a test node 1585747503024
>> )
>> [ERROR]   WarSelectorServletTest.testSelectorTwo:29-
>>> ResolutionTestBase.assertServlet:75 Content contains
>> servlet.class.name property (** Resource dumped by
>> PlainTextRenderer**
>> Resource path:/servlet-resolution-
>> tests/1585747495298/this_is_a_test_node_
>> Resource metadata: {sling.modificationTime=-1,
>> sling.characterEncoding=null, sling.parameterMap={},
>> sling.contentType=null, sling.creationTime=-1,
>> sling.contentLength=-1, sling.resolutionPath=/servlet-
>> resolution-
>> tests/1585747495298/this_is_a_test_node_,
>> sling.resolutionPathInfo=.WAR_TEST_SEL_2.txt}
>> Resource type: nt:unstructured
>> Resource super type: -
>> 
>> ** Resource properties **
>> jcr:primaryType: nt:unstructured
>> text: This is a test node 1585747503113
>> )
>> 
>> 
>> Konrad
>> 
>>> On 1. Apr 2020, at 15:21, Robert Munteanu <
>>> romb...@apache.org
>>> wrote:
>>> 
>>> On Wed, 2020-04-01 at 15:16 +0200, Konrad Windszus wrote:
 The test fails with the following output
 
 [ERROR] Tests run: 3, Failures: 1, Errors: 0, Skipped: 0,
 Time
 elapsed: 0.292 s <<< FAILURE! - in
 org.apache.sling.launchpad.webapp.integrationtest.install
 er
 .Ser
 verSid
 eInstallerTest
 [ERROR]
 noUntransformedResources(org.apache.sling.launchpad.webap
 p.
 inte
 gratio

Re: Consistently failing ITs

[Robert Munteanu]

FWIW, the same tests fail in launchpad-testing-war as well [1].

So that is probably not the right fix to do.

[1]: 
https://builds.apache.org/job/Sling/job/sling-org-apache-sling-launchpad-testing-war/job/master/68/console



On Wed, 2020-04-01 at 16:06 +0200, Robert Munteanu wrote:
> Sounds like a reasonable explanation to me.
> 
> Thanks,
> Robert
> 
> On Wed, 2020-04-01 at 16:03 +0200, Konrad Windszus wrote:
> > What I assume happened was the following:
> > 
> > The WAR was incorrectly treated as bundle and therefore installed
> > by
> > the OSGi Installer for bundles.
> > As consequence the according servlets were registered.
> >  
> > 
> > > On 1. Apr 2020, at 16:00, Robert Munteanu 
> > > wrote:
> > > 
> > > I agree in principle. But why did these not fail until now?
> > > 
> > > Thanks,
> > > Robert
> > > 
> > > On Wed, 2020-04-01 at 15:39 +0200, Konrad Windszus wrote:
> > > > IMHO there are some test which should only be executed from 
> > > > https://github.com/apache/sling-org-apache-sling-launchpad-testing-war
> > > > , namely 
> > > > https://github.com/apache/sling-org-apache-sling-launchpad-integration-tests/blob/bd0c0c270b73e582dc5dfa3ed25231c951d0c98d/src/main/java/org/apache/sling/launchpad/webapp/integrationtest/servlets/resolution/WarSelectorServletTest.java
> > > > .
> > > > 
> > > > That should IMHO be moved to 
> > > > https://github.com/apache/sling-org-apache-sling-launchpad-testing-war
> > > > to make sure it is not executed with 
> > > > https://github.com/apache/sling-org-apache-sling-launchpad-testing.
> > > > WDYT?
> > > > 
> > > > Konrad
> > > > 
> > > > > On 1. Apr 2020, at 15:29, Konrad Windszus 
> > > > > wrote:
> > > > > 
> > > > > Done with 
> > > > > https://github.com/apache/sling-org-apache-sling-launchpad-test-bundles/commit/43956dd07234ddc3263ce29c5b7c3f7198ad4caf
> > > > > <
> > > > > https://github.com/apache/sling-org-apache-sling-launchpad-test-bundles/commit/43956dd07234ddc3263ce29c5b7c3f7198ad4caf>
> > > > > ;.
> > > > > 
> > > > > That leaves us with 2 remaining issues:
> > > > > 
> > > > > [ERROR] Failures: 
> > > > > [ERROR]   WarSelectorServletTest.testSelectorOne:23-
> > > > > > ResolutionTestBase.assertServlet:75 Content contains
> > > > > servlet.class.name property (** Resource dumped by
> > > > > PlainTextRenderer**
> > > > > Resource path:/servlet-resolution-
> > > > > tests/1585747495298/this_is_a_test_node_
> > > > > Resource metadata: {sling.modificationTime=-1,
> > > > > sling.characterEncoding=null, sling.parameterMap={},
> > > > > sling.contentType=null, sling.creationTime=-1,
> > > > > sling.contentLength=-1, sling.resolutionPath=/servlet-
> > > > > resolution-
> > > > > tests/1585747495298/this_is_a_test_node_,
> > > > > sling.resolutionPathInfo=.WAR_TEST_SEL_1.txt}
> > > > > Resource type: nt:unstructured
> > > > > Resource super type: -
> > > > > 
> > > > > ** Resource properties **
> > > > > jcr:primaryType: nt:unstructured
> > > > > text: This is a test node 1585747503024
> > > > > )
> > > > > [ERROR]   WarSelectorServletTest.testSelectorTwo:29-
> > > > > > ResolutionTestBase.assertServlet:75 Content contains
> > > > > servlet.class.name property (** Resource dumped by
> > > > > PlainTextRenderer**
> > > > > Resource path:/servlet-resolution-
> > > > > tests/1585747495298/this_is_a_test_node_
> > > > > Resource metadata: {sling.modificationTime=-1,
> > > > > sling.characterEncoding=null, sling.parameterMap={},
> > > > > sling.contentType=null, sling.creationTime=-1,
> > > > > sling.contentLength=-1, sling.resolutionPath=/servlet-
> > > > > resolution-
> > > > > tests/1585747495298/this_is_a_test_node_,
> > > > > sling.resolutionPathInfo=.WAR_TEST_SEL_2.txt}
> > > > > Resource type: nt:unstructured
> > > > > Resource super type: -
> > > > > 
> > > > > ** Resource properties **
> > > > > jcr:primaryType: nt:unstructured
> > > > > text: This is a test node 1585747503113
> > > > > )
> > > > > 
> > > > > 
> > > > > Konrad
> > > > > 
> > > > > > On 1. Apr 2020, at 15:21, Robert Munteanu <
> > > > > > romb...@apache.org
> > > > > > wrote:
> > > > > > 
> > > > > > On Wed, 2020-04-01 at 15:16 +0200, Konrad Windszus wrote:
> > > > > > > The test fails with the following output
> > > > > > > 
> > > > > > > [ERROR] Tests run: 3, Failures: 1, Errors: 0, Skipped: 0,
> > > > > > > Time
> > > > > > > elapsed: 0.292 s <<< FAILURE! - in
> > > > > > > org.apache.sling.launchpad.webapp.integrationtest.install
> > > > > > > er
> > > > > > > .Ser
> > > > > > > verSid
> > > > > > > eInstallerTest
> > > > > > > [ERROR]
> > > > > > > noUntransformedResources(org.apache.sling.launchpad.webap
> > > > > > > p.
> > > > > > > inte
> > > > > > > gratio
> > > > > > > ntest.installer.ServerSideInstallerTest)  Time elapsed:
> > > > > > > 0.105
> > > > > > > s  <<<
> > > > > > > FAILURE!
> > > > > > > java.lang.AssertionError: Untransformed resources found:
> > > > > > > [RegisteredResource(url=launchpad:resources/install/5/org
> > > > > > > .a
> > > > > > > pach
> > > > 

[jira] [Created] (SLING-9335) Capabilities based on the extends file should be merged with capabilities based on resource label scripts

[Radu Cotescu (Jira)]

Radu Cotescu created SLING-9335:
---

 Summary: Capabilities based on the extends file should be merged 
with capabilities based on resource label scripts
 Key: SLING-9335
 URL: https://issues.apache.org/jira/browse/SLING-9335
 Project: Sling
  Issue Type: Bug
  Components: Maven Plugins and Archetypes
Reporter: Radu Cotescu
Assignee: Radu Cotescu
 Fix For: Scripting Bundle Maven Plugin 0.2.0


Currently a capability generated from an {{extends}} file will co-exist with a 
capability generated from a resource label script, leading to issues at runtime 
when it comes to finding the correct executable which has to handle a certain 
resource type. As such, these capabilities should be merged automatically by 
the plugin, before generating the values for the bundle's manifest.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[VOTE] Release Apache Sling Testing Clients version 2.0.0 and Apache Sling Testing Rules version 2.0.0

[Andrei Dulvac]

Hi,
We solved 5 issues across those two releases


https://issues.apache.org/jira/projects/SLING/versions/12347772

https://issues.apache.org/jira/projects/SLING/versions/12344767

Staging 
repository:https://repository.apache.org/content/repositories/orgapachesling-2236


You can use this UNIX script to download the release and verify the
signatures:https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2236 /tmp/sling-staging



Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.


-Andrei

Re: [VOTE] Release Apache Sling Provisioning Model 1.8.6, Feature Model Converter 1.0.14, Slinstart Maven Plugin 1.9.10

[Daniel Klco]

+1

On Mon, Apr 6, 2020 at 8:37 AM David Bosschaert 
wrote:

> +1
>
> David
>
> On Mon, 6 Apr 2020 at 13:24, Carsten Ziegeler 
> wrote:
>
> > Hi,
> >
> > we solved 1 issue in Provisioning Model 1.8.6:
> > https://issues.apache.org/jira/projects/SLING/versions/12341384
> >
> > we solved 2 issues in Feature Model Converter 1.0.14:
> > https://issues.apache.org/jira/projects/SLING/versions/12346851
> >
> > we solved 5 issues in Slinstart Maven Plugin 1.9.10:
> > https://issues.apache.org/jira/projects/SLING/versions/12346859
> >
> >
> > Staging repository:
> > https://repository.apache.org/content/repositories/orgapachesling-2235
> >
> > You can use this UNIX script to download the release and verify the
> > signatures:
> >
> >
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
> >
> > Usage:
> > sh check_staged_release.sh 2235 /tmp/sling-staging
> >
> > Please vote to approve this release:
> >
> > [ ] +1 Approve the release
> > [ ]  0 Don't care
> > [ ] -1 Don't release, because ...
> >
> > This majority vote is open for at least 72 hours.
> >
> > Regards
> > Carsten
> > --
> > Carsten Ziegeler
> > Adobe Research Switzerland
> > cziege...@apache.org
> >
>

[jira] [Resolved] (SLING-9334) Refactor configurable retries mechanism to make them consistent

[Andrei Dulvac (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrei Dulvac resolved SLING-9334.
--
Resolution: Fixed

> Refactor configurable retries mechanism to make them consistent
> ---
>
> Key: SLING-9334
> URL: https://issues.apache.org/jira/browse/SLING-9334
> Project: Sling
>  Issue Type: Improvement
>  Components: Apache Sling Testing Clients
>Affects Versions: Apache Sling Testing Clients 1.2.4
>Reporter: Andrei Dulvac
>Assignee: Andrei Dulvac
>Priority: Critical
> Fix For: Apache Sling Testing Clients 2.0.0
>
>
> The {{o.a.s.testing.util.Constants}} class has some static fields that are 
> not constants at all. Those values should be moved into methods.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-9334) Refactor configurable retries mechanism to make them consistent

[Andrei Dulvac (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-9334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17076306#comment-17076306
 ] 

Andrei Dulvac commented on SLING-9334:
--

This took care of 
https://builds.apache.org/blue/organizations/jenkins/Sling%2Fsling-org-apache-sling-testing-clients/detail/master/92/pipeline
 


> Refactor configurable retries mechanism to make them consistent
> ---
>
> Key: SLING-9334
> URL: https://issues.apache.org/jira/browse/SLING-9334
> Project: Sling
>  Issue Type: Improvement
>  Components: Apache Sling Testing Clients
>Affects Versions: Apache Sling Testing Clients 1.2.4
>Reporter: Andrei Dulvac
>Assignee: Andrei Dulvac
>Priority: Critical
> Fix For: Apache Sling Testing Clients 2.0.0
>
>
> The {{o.a.s.testing.util.Constants}} class has some static fields that are 
> not constants at all. Those values should be moved into methods.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: [VOTE] Release Apache Sling Provisioning Model 1.8.6, Feature Model Converter 1.0.14, Slinstart Maven Plugin 1.9.10

[David Bosschaert]

+1

David

On Mon, 6 Apr 2020 at 13:24, Carsten Ziegeler  wrote:

> Hi,
>
> we solved 1 issue in Provisioning Model 1.8.6:
> https://issues.apache.org/jira/projects/SLING/versions/12341384
>
> we solved 2 issues in Feature Model Converter 1.0.14:
> https://issues.apache.org/jira/projects/SLING/versions/12346851
>
> we solved 5 issues in Slinstart Maven Plugin 1.9.10:
> https://issues.apache.org/jira/projects/SLING/versions/12346859
>
>
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-2235
>
> You can use this UNIX script to download the release and verify the
> signatures:
>
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
>
> Usage:
> sh check_staged_release.sh 2235 /tmp/sling-staging
>
> Please vote to approve this release:
>
> [ ] +1 Approve the release
> [ ]  0 Don't care
> [ ] -1 Don't release, because ...
>
> This majority vote is open for at least 72 hours.
>
> Regards
> Carsten
> --
> Carsten Ziegeler
> Adobe Research Switzerland
> cziege...@apache.org
>

[jira] [Updated] (SLING-9334) Refactor configurable retries mechanism to make them consistent

[Andrei Dulvac (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrei Dulvac updated SLING-9334:
-
Description: The {{o.a.s.testing.util.Constants}} class has some static 
fields that are not constants at all. Those values should be moved into 
methods.  (was: Make http retry mechanism configurable.
More specifically, configure the error codes for which to retry the test http 
calls.)

> Refactor configurable retries mechanism to make them consistent
> ---
>
> Key: SLING-9334
> URL: https://issues.apache.org/jira/browse/SLING-9334
> Project: Sling
>  Issue Type: Improvement
>  Components: Apache Sling Testing Clients
>Affects Versions: Apache Sling Testing Clients 1.2.4
>Reporter: Andrei Dulvac
>Assignee: Andrei Dulvac
>Priority: Critical
> Fix For: Apache Sling Testing Clients 2.0.0
>
>
> The {{o.a.s.testing.util.Constants}} class has some static fields that are 
> not constants at all. Those values should be moved into methods.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: [VOTE] Release Apache Sling Provisioning Model 1.8.6, Feature Model Converter 1.0.14, Slinstart Maven Plugin 1.9.10

[Carsten Ziegeler]

+1

Carsten

On 06.04.2020 14:24, Carsten Ziegeler wrote:

Hi,

we solved 1 issue in Provisioning Model 1.8.6:
https://issues.apache.org/jira/projects/SLING/versions/12341384

we solved 2 issues in Feature Model Converter 1.0.14:
https://issues.apache.org/jira/projects/SLING/versions/12346851

we solved 5 issues in Slinstart Maven Plugin 1.9.10:
https://issues.apache.org/jira/projects/SLING/versions/12346859


Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2235

You can use this UNIX script to download the release and verify the 
signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD 



Usage:
sh check_staged_release.sh 2235 /tmp/sling-staging

Please vote to approve this release:

    [ ] +1 Approve the release
    [ ]  0 Don't care
    [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards
Carsten


--
--
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

[jira] [Created] (SLING-9334) Refactor configurable retries mechanism to make them consistent

[Andrei Dulvac (Jira)]

Andrei Dulvac created SLING-9334:


 Summary: Refactor configurable retries mechanism to make them 
consistent
 Key: SLING-9334
 URL: https://issues.apache.org/jira/browse/SLING-9334
 Project: Sling
  Issue Type: Improvement
  Components: Apache Sling Testing Clients
Affects Versions: Apache Sling Testing Clients 1.2.4
Reporter: Andrei Dulvac
Assignee: Andrei Dulvac
 Fix For: Apache Sling Testing Clients 2.0.0


Make http retry mechanism configurable.
More specifically, configure the error codes for which to retry the test http 
calls.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: [VOTE] Release Apache Sling Provisioning Model 1.8.6, Feature Model Converter 1.0.14, Slinstart Maven Plugin 1.9.10

[Karl Pauls]

+1

regards,

Karl

On Mon, Apr 6, 2020 at 2:24 PM Carsten Ziegeler  wrote:
>
> Hi,
>
> we solved 1 issue in Provisioning Model 1.8.6:
> https://issues.apache.org/jira/projects/SLING/versions/12341384
>
> we solved 2 issues in Feature Model Converter 1.0.14:
> https://issues.apache.org/jira/projects/SLING/versions/12346851
>
> we solved 5 issues in Slinstart Maven Plugin 1.9.10:
> https://issues.apache.org/jira/projects/SLING/versions/12346859
>
>
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-2235
>
> You can use this UNIX script to download the release and verify the
> signatures:
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
>
> Usage:
> sh check_staged_release.sh 2235 /tmp/sling-staging
>
> Please vote to approve this release:
>
> [ ] +1 Approve the release
> [ ]  0 Don't care
> [ ] -1 Don't release, because ...
>
> This majority vote is open for at least 72 hours.
>
> Regards
> Carsten
> --
> Carsten Ziegeler
> Adobe Research Switzerland
> cziege...@apache.org



-- 
Karl Pauls
karlpa...@gmail.com

[Jenkins] Sling » sling-org-apache-sling-starter » master #127 is FIXED

[Apache Jenkins Server]

Please see 
https://builds.apache.org/job/Sling/job/sling-org-apache-sling-starter/job/master/127/
 for details.

No further emails will be sent until the status of the build is changed.

[VOTE] Release Apache Sling Provisioning Model 1.8.6, Feature Model Converter 1.0.14, Slinstart Maven Plugin 1.9.10

[Carsten Ziegeler]

Hi,

we solved 1 issue in Provisioning Model 1.8.6:
https://issues.apache.org/jira/projects/SLING/versions/12341384

we solved 2 issues in Feature Model Converter 1.0.14:
https://issues.apache.org/jira/projects/SLING/versions/12346851

we solved 5 issues in Slinstart Maven Plugin 1.9.10:
https://issues.apache.org/jira/projects/SLING/versions/12346859


Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2235

You can use this UNIX script to download the release and verify the 
signatures:

https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2235 /tmp/sling-staging

Please vote to approve this release:

   [ ] +1 Approve the release
   [ ]  0 Don't care
   [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards
Carsten
--
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

[jira] [Comment Edited] (SLING-9332) Error logged for NonRecoverableDistributionException in SimpleDistributionAgentQueueProcessor does not log queuename

[Mohit Arora (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-9332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17076283#comment-17076283
 ] 

Mohit Arora edited comment on SLING-9332 at 4/6/20, 12:14 PM:
--

There was also [overriden 
version|https://github.com/apache/sling-org-apache-sling-distribution-core/commit/cc8ea64cc836280335eb66a587d5da330a2f9ac4]
 of slf4j in distribution-core's pom which was removed after bumping the parent 
version.

I have updated the log statements in all the classes in the project to use 
correct syntax for 1.7.x version of slf4j - 
https://github.com/apache/sling-org-apache-sling-distribution-core/pull/38

I have also verified that after this change the logger of 
SimpleDistributionAgentQueueProcessor is logging the correct message in case of 
error.

[~cschneider], [~marett] can you please review and merge the PR?


was (Author: mohiaror):
There was also [override 
version|https://github.com/apache/sling-org-apache-sling-distribution-core/commit/cc8ea64cc836280335eb66a587d5da330a2f9ac4]
 of slf4j in distribution-core's pom which was removed after bumping the parent 
version.

I have updated the log statements in all the classes in the project to use 
correct syntax for 1.7.x version of slf4j - 
https://github.com/apache/sling-org-apache-sling-distribution-core/pull/38

I have also verified that after this change the logger of 
SimpleDistributionAgentQueueProcessor is logging the correct message in case of 
error.

[~cschneider], [~marett] can you please review and merge the PR?

> Error logged for NonRecoverableDistributionException in 
> SimpleDistributionAgentQueueProcessor does not log queuename
> 
>
> Key: SLING-9332
> URL: https://issues.apache.org/jira/browse/SLING-9332
> Project: Sling
>  Issue Type: Bug
>  Components: Content Distribution
>Reporter: Mohit Arora
>Priority: Minor
> Fix For: Content Distribution Core 0.4.4
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> The [error message logged 
> in|https://github.com/apache/sling-org-apache-sling-distribution-core/blob/master/src/main/java/org/apache/sling/distribution/agent/impl/SimpleDistributionAgentQueueProcessor.java#L157]
>   SimpleDistributionAgentQueueProcessor uses an _Object_ to log 
> distributionpackage ID and queuename. However, from version 1.7 onward, log4j 
> seems to have stopped processing the object arrays for log statements. 
> Because of this the error logged in case of unsuccessful distribution looks 
> like - 
> {noformat}06.04.2020 07:48:30.411 *ERROR* 
> [sling-default-1-resource-queueProcessor-bpdistributionagent0-queue-bpdistributionagent0]
>  
> org.apache.sling.distribution.agent.impl.SimpleDistributionAgentQueueProcessor
>  could not deliver package 
> [dstrpck-1586159284848-e4c369fc-5bbf-4cfc-9ea3-2819af650784, 
> queue-bpdistributionagent0] from queue {}
> org.apache.sling.distribution.common.DistributionException: 
> org.apache.http.client.HttpResponseException: Bad Gateway
>   at 
> org.apache.sling.distribution.transport.impl.SimpleHttpDistributionTransport.deliverPackage(SimpleHttpDistributionTransport.java:162)
>  [org.apache.sling.distribution.core:0.4.2]
>   at 
> org.apache.sling.distribution.packaging.impl.importer.RemoteDistributionPackageImporter.importPackage(RemoteDistributionPackageImporter.java:66)
>  [org.apache.sling.distribution.core:0.4.2]
>   at 
> org.apache.sling.distribution.agent.impl.SimpleDistributionAgentQueueProcessor.processQueueItem(SimpleDistributionAgentQueueProcessor.java:134)
>  [org.apache.sling.distribution.core:0.4.2]
>   at 
> org.apache.sling.distribution.agent.impl.SimpleDistributionAgentQueueProcessor.process(SimpleDistributionAgentQueueProcessor.java:91)
>  [org.apache.sling.distribution.core:0.4.2]
>   at 
> org.apache.sling.distribution.queue.impl.simple.SimpleDistributionQueueProcessor.run(SimpleDistributionQueueProcessor.java:53)
>  [org.apache.sling.distribution.core:0.4.2]
>   at 
> org.apache.sling.commons.scheduler.impl.QuartzJobExecutor.execute(QuartzJobExecutor.java:347)
>  [org.apache.sling.commons.scheduler:2.7.6]
>   at org.quartz.core.JobRunShell.run(JobRunShell.java:202) 
> [org.apache.sling.commons.scheduler:2.7.6]
>   at 
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
>   at 
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
>   at java.base/java.lang.Thread.run(Thread.java:834)
> Caused by: org.apache.http.client.HttpResponseException: Bad Gateway
>   at 
> org.apache.http.impl.client.AbstractResponseHandler.handleResponse(AbstractResponseHandler.java:70)
>  

[jira] [Commented] (SLING-9332) Error logged for NonRecoverableDistributionException in SimpleDistributionAgentQueueProcessor does not log queuename

[Mohit Arora (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-9332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17076283#comment-17076283
 ] 

Mohit Arora commented on SLING-9332:


There was also [override 
version|https://github.com/apache/sling-org-apache-sling-distribution-core/commit/cc8ea64cc836280335eb66a587d5da330a2f9ac4]
 of slf4j in distribution-core's pom which was removed after bumping the parent 
version.

I have updated the log statements in all the classes in the project to use 
correct syntax for 1.7.x version of slf4j - 
https://github.com/apache/sling-org-apache-sling-distribution-core/pull/38

I have also verified that after this change the logger of 
SimpleDistributionAgentQueueProcessor is logging the correct message in case of 
error.

[~cschneider], [~marett] can you please review and merge the PR?

> Error logged for NonRecoverableDistributionException in 
> SimpleDistributionAgentQueueProcessor does not log queuename
> 
>
> Key: SLING-9332
> URL: https://issues.apache.org/jira/browse/SLING-9332
> Project: Sling
>  Issue Type: Bug
>  Components: Content Distribution
>Reporter: Mohit Arora
>Priority: Minor
> Fix For: Content Distribution Core 0.4.4
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> The [error message logged 
> in|https://github.com/apache/sling-org-apache-sling-distribution-core/blob/master/src/main/java/org/apache/sling/distribution/agent/impl/SimpleDistributionAgentQueueProcessor.java#L157]
>   SimpleDistributionAgentQueueProcessor uses an _Object_ to log 
> distributionpackage ID and queuename. However, from version 1.7 onward, log4j 
> seems to have stopped processing the object arrays for log statements. 
> Because of this the error logged in case of unsuccessful distribution looks 
> like - 
> {noformat}06.04.2020 07:48:30.411 *ERROR* 
> [sling-default-1-resource-queueProcessor-bpdistributionagent0-queue-bpdistributionagent0]
>  
> org.apache.sling.distribution.agent.impl.SimpleDistributionAgentQueueProcessor
>  could not deliver package 
> [dstrpck-1586159284848-e4c369fc-5bbf-4cfc-9ea3-2819af650784, 
> queue-bpdistributionagent0] from queue {}
> org.apache.sling.distribution.common.DistributionException: 
> org.apache.http.client.HttpResponseException: Bad Gateway
>   at 
> org.apache.sling.distribution.transport.impl.SimpleHttpDistributionTransport.deliverPackage(SimpleHttpDistributionTransport.java:162)
>  [org.apache.sling.distribution.core:0.4.2]
>   at 
> org.apache.sling.distribution.packaging.impl.importer.RemoteDistributionPackageImporter.importPackage(RemoteDistributionPackageImporter.java:66)
>  [org.apache.sling.distribution.core:0.4.2]
>   at 
> org.apache.sling.distribution.agent.impl.SimpleDistributionAgentQueueProcessor.processQueueItem(SimpleDistributionAgentQueueProcessor.java:134)
>  [org.apache.sling.distribution.core:0.4.2]
>   at 
> org.apache.sling.distribution.agent.impl.SimpleDistributionAgentQueueProcessor.process(SimpleDistributionAgentQueueProcessor.java:91)
>  [org.apache.sling.distribution.core:0.4.2]
>   at 
> org.apache.sling.distribution.queue.impl.simple.SimpleDistributionQueueProcessor.run(SimpleDistributionQueueProcessor.java:53)
>  [org.apache.sling.distribution.core:0.4.2]
>   at 
> org.apache.sling.commons.scheduler.impl.QuartzJobExecutor.execute(QuartzJobExecutor.java:347)
>  [org.apache.sling.commons.scheduler:2.7.6]
>   at org.quartz.core.JobRunShell.run(JobRunShell.java:202) 
> [org.apache.sling.commons.scheduler:2.7.6]
>   at 
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
>   at 
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
>   at java.base/java.lang.Thread.run(Thread.java:834)
> Caused by: org.apache.http.client.HttpResponseException: Bad Gateway
>   at 
> org.apache.http.impl.client.AbstractResponseHandler.handleResponse(AbstractResponseHandler.java:70)
>  [org.apache.httpcomponents.httpclient:4.5.4]
>   at 
> org.apache.http.client.fluent.Response.handleResponse(Response.java:90) 
> [org.apache.httpcomponents.httpclient:4.5.4]
>   at 
> org.apache.http.client.fluent.Response.returnContent(Response.java:97) 
> [org.apache.httpcomponents.httpclient:4.5.4]
>   at 
> org.apache.sling.distribution.transport.impl.SimpleHttpDistributionTransport.deliverPackage(SimpleHttpDistributionTransport.java:148)
>  [org.apache.sling.distribution.core:0.4.2]
>   ... 9 common frames omitted{noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [sling-org-apache-sling-distribution-core] mohiaror opened a new pull request #38: SLING-9332 Error logged for NonRecoverableDistributionException in SimpleDistributionAgentQueueProcessor doe

[GitBox]

mohiaror opened a new pull request #38: SLING-9332 Error logged for 
NonRecoverableDistributionException in SimpleDistributionAgentQueueProcessor 
does not log queuename
URL: https://github.com/apache/sling-org-apache-sling-distribution-core/pull/38
 
 
   Updating the syntax of log statements to comply with 1.7.x version of slf4j.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Resolved] (SLING-9333) Artifact metadata is incorrectly writing a comma to separate the parameters

[Carsten Ziegeler (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-9333.
-
Resolution: Fixed

Fixed in rev 
https://github.com/apache/sling-org-apache-sling-provisioning-model/commit/6330b54a142bd3fc5c1e3a8541cd551cb711ef8c

> Artifact metadata is incorrectly writing a comma to separate the parameters
> ---
>
> Key: SLING-9333
> URL: https://issues.apache.org/jira/browse/SLING-9333
> Project: Sling
>  Issue Type: Bug
>  Components: Tooling
>Affects Versions: Sling Provisioning Model 1.8.4, Feature Model Converter 
> 1.0.12, Slingstart Maven Plugin 1.9.8
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Blocker
> Fix For: Sling Provisioning Model 1.8.6, Feature Model Converter 
> 1.0.14, Slingstart Maven Plugin 1.9.10
>
>
> Artifact metadata is separated by space only, however the writer writes out a 
> comma and a space. Which then results in wrong values when the parameters are 
> read again



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-9333) Artifact metadata is incorrectly writing a comma to separate the parameters

[Carsten Ziegeler (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler updated SLING-9333:

Fix Version/s: Slingstart Maven Plugin 1.9.10
   Feature Model Converter 1.0.14

> Artifact metadata is incorrectly writing a comma to separate the parameters
> ---
>
> Key: SLING-9333
> URL: https://issues.apache.org/jira/browse/SLING-9333
> Project: Sling
>  Issue Type: Bug
>  Components: Tooling
>Affects Versions: Sling Provisioning Model 1.8.4, Feature Model Converter 
> 1.0.12, Slingstart Maven Plugin 1.9.8
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Blocker
> Fix For: Sling Provisioning Model 1.8.6, Feature Model Converter 
> 1.0.14, Slingstart Maven Plugin 1.9.10
>
>
> Artifact metadata is separated by space only, however the writer writes out a 
> comma and a space. Which then results in wrong values when the parameters are 
> read again



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Resolved] (SLING-5914) Provisioning model does not correctly handle floating-point configuration values

[Carsten Ziegeler (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-5914.
-
Fix Version/s: (was: Sling Provisioning Model 1.8.6)
   Resolution: Won't Fix

The OSGi configuration resource format is the way to go, therefore resolving 
this as won't fix

> Provisioning model does not correctly handle floating-point configuration 
> values
> 
>
> Key: SLING-5914
> URL: https://issues.apache.org/jira/browse/SLING-5914
> Project: Sling
>  Issue Type: Bug
>  Components: Tooling
>Reporter: Robert Munteanu
>Priority: Major
>
> The provisioning model specifies that floating-point values are encoded in 
> the following format:
> - {{D"1.0"}} for doubles
> - {{F"1.0"}} for floats
> However, the ConfigAdmin has a different idea about how these values should 
> be stored:
> {code:java}
> case TOKEN_SIMPLE_FLOAT:
> case TOKEN_PRIMITIVE_FLOAT:
> int fBits = Integer.parseInt( readQuoted( pr ) );
> return new Float( Float.intBitsToFloat( fBits ) );
> case TOKEN_SIMPLE_DOUBLE:
> case TOKEN_PRIMITIVE_DOUBLE:
> long dBits = Long.parseLong( readQuoted( pr ) );
> return new Double( Double.longBitsToDouble( dBits ) );
> {code}
> I assume that this is done to preserve precision when reading/writing values.
> The provisioning model should be updated to mediate between the user-supplied 
> values and the configuration admin format.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-9333) Artifact metadata is incorrectly writing a comma to separate the parameters

[Carsten Ziegeler (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler updated SLING-9333:

Affects Version/s: Feature Model Converter 1.0.12
   Slingstart Maven Plugin 1.9.8

> Artifact metadata is incorrectly writing a comma to separate the parameters
> ---
>
> Key: SLING-9333
> URL: https://issues.apache.org/jira/browse/SLING-9333
> Project: Sling
>  Issue Type: Bug
>  Components: Tooling
>Affects Versions: Sling Provisioning Model 1.8.4, Feature Model Converter 
> 1.0.12, Slingstart Maven Plugin 1.9.8
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Blocker
> Fix For: Sling Provisioning Model 1.8.6
>
>
> Artifact metadata is separated by space only, however the writer writes out a 
> comma and a space. Which then results in wrong values when the parameters are 
> read again



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-9333) Artifact metadata is incorrectly writing a comma to separate the parameters

[Carsten Ziegeler (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler updated SLING-9333:

Component/s: (was: General)
 Tooling

> Artifact metadata is incorrectly writing a comma to separate the parameters
> ---
>
> Key: SLING-9333
> URL: https://issues.apache.org/jira/browse/SLING-9333
> Project: Sling
>  Issue Type: Bug
>  Components: Tooling
>Affects Versions: Sling Provisioning Model 1.8.4
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Blocker
> Fix For: Sling Provisioning Model 1.8.6
>
>
> Artifact metadata is separated by space only, however the writer writes out a 
> comma and a space. Which then results in wrong values when the parameters are 
> read again



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-6332) Configurations with same PID but different features/run modes in provisioning model are ignored

[Carsten Ziegeler (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-6332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler updated SLING-6332:

Fix Version/s: (was: Sling Provisioning Model 1.8.6)
   Sling Provisioning Model 1.8.8

> Configurations with same PID but different features/run modes in provisioning 
> model are ignored 
> 
>
> Key: SLING-6332
> URL: https://issues.apache.org/jira/browse/SLING-6332
> Project: Sling
>  Issue Type: Bug
>  Components: Tooling
>Reporter: Robert Munteanu
>Priority: Major
> Fix For: Sling Provisioning Model 1.8.8
>
>
> I have the following scenario:
> # {{launchpad/builder}} defines an OSGi config for 
> {{org.apache.sling.jcr.base.internal.LoginAdminWhitelist}}, setting the 
> {{whitelist.bundles.additional}} property
> # {{launchpad/testing}} depends on {{launchpad/builder}} and defines an the 
> same config with {{[mode=merge]}} and sets the {{whitelist.bundles.regexp}} 
> property
> When building {{launchpad/testing}}, the configuration from this project is 
> ignored completely and the one from {{launchpad/builder}} is picked up.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (SLING-9333) Artifact metadata is incorrectly writing a comma to separate the parameters

[Carsten Ziegeler (Jira)]

Carsten Ziegeler created SLING-9333:
---

 Summary: Artifact metadata is incorrectly writing a comma to 
separate the parameters
 Key: SLING-9333
 URL: https://issues.apache.org/jira/browse/SLING-9333
 Project: Sling
  Issue Type: Bug
  Components: General
Affects Versions: Sling Provisioning Model 1.8.4
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: Sling Provisioning Model 1.8.6


Artifact metadata is separated by space only, however the writer writes out a 
comma and a space. Which then results in wrong values when the parameters are 
read again



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-9333) Artifact metadata is incorrectly writing a comma to separate the parameters

[Carsten Ziegeler (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler updated SLING-9333:

Priority: Blocker  (was: Major)

> Artifact metadata is incorrectly writing a comma to separate the parameters
> ---
>
> Key: SLING-9333
> URL: https://issues.apache.org/jira/browse/SLING-9333
> Project: Sling
>  Issue Type: Bug
>  Components: General
>Affects Versions: Sling Provisioning Model 1.8.4
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Blocker
> Fix For: Sling Provisioning Model 1.8.6
>
>
> Artifact metadata is separated by space only, however the writer writes out a 
> comma and a space. Which then results in wrong values when the parameters are 
> read again



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[Jenkins] Sling » sling-org-apache-sling-starter » master #126 is BROKEN

[Apache Jenkins Server]

java/jdk1.8.0_241/jre
Default locale: en_US, platform encoding: ISO-8859-1
OS name: "linux", version: "4.15.0-76-generic", arch: "amd64", family: "unix"
[INFO] [jenkins-event-spy] Generate 
/home/jenkins/jenkins-slave/workspace/-org-apache-sling-starter_master@tmp/withMavencbab5c24/maven-spy-20200406-113512-7442795840198552186488.log.tmp
 ...
[INFO] Scanning for projects...
[INFO] Extended Maven classpath (scope 'provided') by the dependencies 
extracted from the Sling model.
[INFO] 
[INFO] -< org.apache.sling:org.apache.sling.starter >--
[INFO] Building Apache Sling Starter Application 12-SNAPSHOT
[INFO] -[ slingstart ]-
[INFO] Downloading from central: 
https://repo.maven.apache.org/maven2/org/apache/sling/org.apache.sling.installer.provider.file/1.2.2/org.apache.sling.installer.provider.file-1.2.2.pom
[WARNING] The POM for 
org.apache.sling:org.apache.sling.installer.provider.file:jar:1.2.2 is missing, 
no dependency information available
[INFO] Downloading from central: 
https://repo.maven.apache.org/maven2/org/apache/jackrabbit/oak-api/1.26.0/oak-api-1.26.0.pom
[INFO] Downloaded from central: 
https://repo.maven.apache.org/maven2/org/apache/jackrabbit/oak-api/1.26.0/oak-api-1.26.0.pom
 (3.3 kB at 74 kB/s)
[INFO] Downloading from central: 
https://repo.maven.apache.org/maven2/org/apache/jackrabbit/oak-parent/1.26.0/oak-parent-1.26.0.pom
[INFO] Downloaded from central: 
https://repo.maven.apache.org/maven2/org/apache/jackrabbit/oak-parent/1.26.0/oak-parent-1.26.0.pom
 (48 kB at 1.4 MB/s)
[INFO] Downloading from central: 
https://repo.maven.apache.org/maven2/org/apache/jackrabbit/oak-blob-plugins/1.26.0/oak-blob-plugins-1.26.0.pom
[INFO] Downloaded from central: 
https://repo.maven.apache.org/maven2/org/apache/jackrabbit/oak-blob-plugins/1.26.0/oak-blob-plugins-1.26.0.pom
 (7.0 kB at 412 kB/s)
[INFO] Downloading from central: 
https://repo.maven.apache.org/maven2/org/apache/jackrabbit/oak-jackrabbit-api/1.26.0/oak-jackrabbit-api-1.26.0.pom
[INFO] Downloaded from central: 
https://repo.maven.apache.org/maven2/org/apache/jackrabbit/oak-jackrabbit-api/1.26.0/oak-jackrabbit-api-1.26.0.pom
 (2.1 kB at 138 kB/s)
[INFO] Downloading from central: 
https://repo.maven.apache.org/maven2/org/apache/jackrabbit/oak-commons/1.26.0/oak-commons-1.26.0.pom
[INFO] Downloaded from central: 
https://repo.maven.apache.org/maven2/org/apache/jackrabbit/oak-commons/1.26.0/oak-commons-1.26.0.pom
 (4.6 kB at 306 kB/s)
[INFO] Downloading from central: 
https://repo.maven.apache.org/maven2/org/apache/jackrabbit/oak-core-spi/1.26.0/oak-core-spi-1.26.0.pom
[INFO] Downloaded from central: 
https://repo.maven.apache.org/maven2/org/apache/jackrabbit/oak-core-spi/1.26.0/oak-core-spi-1.26.0.pom
 (6.2 kB at 364 kB/s)
[INFO] Downloading from central: 
https://repo.maven.apache.org/maven2/org/apache/jackrabbit/oak-blob/1.26.0/oak-blob-1.26.0.pom
[INFO] Downloaded from central: 
https://repo.maven.apache.org/maven2/org/apache/jackrabbit/oak-blob/1.26.0/oak-blob-1.26.0.pom
 (5.0 kB at 279 kB/s)
[INFO] Downloading from central: 
https://repo.maven.apache.org/maven2/org/apache/jackrabbit/oak-store-spi/1.26.0/oak-store-spi-1.26.0.pom
[INFO] Downloaded from central: 
https://repo.maven.apache.org/maven2/org/apache/jackrabbit/oak-store-spi/1.26.0/oak-store-spi-1.26.0.pom
 (5.1 kB at 319 kB/s)
[INFO] Downloading from central: 
https://repo.maven.apache.org/maven2/org/apache/jackrabbit/oak-core/1.26.0/oak-core-1.26.0.pom
[INFO] Downloaded from central: 
https://repo.maven.apache.org/maven2/org/apache/jackrabbit/oak-core/1.26.0/oak-core-1.26.0.pom
 (16 kB at 938 kB/s)
[INFO] Downloading from central: 
https://repo.maven.apache.org/maven2/org/apache/jackrabbit/oak-query-spi/1.26.0/oak-query-spi-1.26.0.pom
[INFO] Downloaded from central: 
https://repo.maven.apache.org/maven2/org/apache/jackrabbit/oak-query-spi/1.26.0/oak-query-spi-1.26.0.pom
 (4.0 kB at 249 kB/s)
[INFO] Downloading from central: 
https://repo.maven.apache.org/maven2/org/apache/jackrabbit/oak-security-spi/1.26.0/oak-security-spi-1.26.0.pom
[INFO] Downloaded from central: 
https://repo.maven.apache.org/maven2/org/apache/jackrabbit/oak-security-spi/1.26.0/oak-security-spi-1.26.0.pom
 (6.9 kB at 457 kB/s)
[INFO] Downloading from central: 
https://repo.maven.apache.org/maven2/org/apache/jackrabbit/oak-jcr/1.26.0/oak-jcr-1.26.0.pom
[INFO] Downloaded from central: 
https://repo.maven.apache.org/maven2/org/apache/jackrabbit/oak-jcr/1.26.0/oak-jcr-1.26.0.pom
 (23 kB at 1.2 MB/s)
[INFO] Downloading from central: 
https://repo.maven.apache.org/maven2/org/apache/jackrabbit/oak-lucene/1.26.0/oak-lucene-1.26.0.pom
[INFO] Downloaded from central: 
https://repo.maven.apache.org/maven2/org/apache/jackrabbit/oak-lucene/1.26.0/oak-lucene-1.26.0.pom
 (20 kB at 1.1 MB/s)
[INFO] Downloading from central: 
https://repo.maven.apache.org/maven2/org/apache/jackrabbit/oak-store-document/1

[jira] [Comment Edited] (SLING-9332) Error logged for NonRecoverableDistributionException in SimpleDistributionAgentQueueProcessor does not log queuename

[Mohit Arora (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-9332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17076256#comment-17076256
 ] 

Mohit Arora edited comment on SLING-9332 at 4/6/20, 11:31 AM:
--

The main problem is sling-distribution-core bundle using very old version of 
[sling 
parent|https://github.com/apache/sling-org-apache-sling-distribution-core/blob/master/pom.xml#L28].
 This version was changed from 26 to 28 [quite 
recently|https://github.com/apache/sling-org-apache-sling-distribution-core/commit/a1850193d63ddedced4ad982df18a62345cdf41b#diff-600376dffeb79835ede4a0b285078036]
 by [~cschneider]. Probably because of some compatibility concerns, it was not 
changed to a higher version. Sling parent has moved to 1.7.x version of slf4j a 
[long time 
back|https://github.com/apache/sling-parent/commit/4b673afd477272f84449bdede7e4f0596dcd0513]
 and I think we should at least be using that version of parent pom with latest 
slf4j version. If, however, that's not possible without non-trivial changes, 
the version of log4j bundles should be overridden in distribution-core pom as 
it has always been the case.

EDIT - I just checked that version of 28 of sling-parent contains the update to 
slf4j bundle version. In that case we only need to adapt the log statement.


was (Author: mohiaror):
The main problem is sling-distribution-core bundle using very old version of 
[sling 
parent|https://github.com/apache/sling-org-apache-sling-distribution-core/blob/master/pom.xml#L28].
 This version was changed from 26 to 28 [quite 
recently|https://github.com/apache/sling-org-apache-sling-distribution-core/commit/a1850193d63ddedced4ad982df18a62345cdf41b#diff-600376dffeb79835ede4a0b285078036]
 by [~cschneider]. Probably because of some compatibility concerns, it was not 
changed to a higher version. Sling parent has moved to 1.7.x version of slf4j a 
[long time 
back|https://github.com/apache/sling-parent/commit/4b673afd477272f84449bdede7e4f0596dcd0513]
 and I think we should at least be using that version of parent pom with latest 
slf4j version. If, however, that's not possible without non-trivial changes, 
the version of log4j bundles should be overridden in distribution-core pom as 
it has always been the case.

> Error logged for NonRecoverableDistributionException in 
> SimpleDistributionAgentQueueProcessor does not log queuename
> 
>
> Key: SLING-9332
> URL: https://issues.apache.org/jira/browse/SLING-9332
> Project: Sling
>  Issue Type: Bug
>  Components: Content Distribution
>Reporter: Mohit Arora
>Priority: Minor
> Fix For: Content Distribution Core 0.4.4
>
>
> The [error message logged 
> in|https://github.com/apache/sling-org-apache-sling-distribution-core/blob/master/src/main/java/org/apache/sling/distribution/agent/impl/SimpleDistributionAgentQueueProcessor.java#L157]
>   SimpleDistributionAgentQueueProcessor uses an _Object_ to log 
> distributionpackage ID and queuename. However, from version 1.7 onward, log4j 
> seems to have stopped processing the object arrays for log statements. 
> Because of this the error logged in case of unsuccessful distribution looks 
> like - 
> {noformat}06.04.2020 07:48:30.411 *ERROR* 
> [sling-default-1-resource-queueProcessor-bpdistributionagent0-queue-bpdistributionagent0]
>  
> org.apache.sling.distribution.agent.impl.SimpleDistributionAgentQueueProcessor
>  could not deliver package 
> [dstrpck-1586159284848-e4c369fc-5bbf-4cfc-9ea3-2819af650784, 
> queue-bpdistributionagent0] from queue {}
> org.apache.sling.distribution.common.DistributionException: 
> org.apache.http.client.HttpResponseException: Bad Gateway
>   at 
> org.apache.sling.distribution.transport.impl.SimpleHttpDistributionTransport.deliverPackage(SimpleHttpDistributionTransport.java:162)
>  [org.apache.sling.distribution.core:0.4.2]
>   at 
> org.apache.sling.distribution.packaging.impl.importer.RemoteDistributionPackageImporter.importPackage(RemoteDistributionPackageImporter.java:66)
>  [org.apache.sling.distribution.core:0.4.2]
>   at 
> org.apache.sling.distribution.agent.impl.SimpleDistributionAgentQueueProcessor.processQueueItem(SimpleDistributionAgentQueueProcessor.java:134)
>  [org.apache.sling.distribution.core:0.4.2]
>   at 
> org.apache.sling.distribution.agent.impl.SimpleDistributionAgentQueueProcessor.process(SimpleDistributionAgentQueueProcessor.java:91)
>  [org.apache.sling.distribution.core:0.4.2]
>   at 
> org.apache.sling.distribution.queue.impl.simple.SimpleDistributionQueueProcessor.run(SimpleDistributionQueueProcessor.java:53)
>  [org.apache.sling.distribution.core:0.4.2]
>   at 
> 

[jira] [Commented] (SLING-9332) Error logged for NonRecoverableDistributionException in SimpleDistributionAgentQueueProcessor does not log queuename

[Mohit Arora (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-9332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17076256#comment-17076256
 ] 

Mohit Arora commented on SLING-9332:


The main problem is sling-distribution-core bundle using very old version of 
[sling 
parent|https://github.com/apache/sling-org-apache-sling-distribution-core/blob/master/pom.xml#L28].
 This version was changed from 26 to 28 [quite 
recently|https://github.com/apache/sling-org-apache-sling-distribution-core/commit/a1850193d63ddedced4ad982df18a62345cdf41b#diff-600376dffeb79835ede4a0b285078036]
 by [~cschneider]. Probably because of some compatibility concerns, it was not 
changed to a higher version. Sling parent has moved to 1.7.x version of slf4j a 
[long time 
back|https://github.com/apache/sling-parent/commit/4b673afd477272f84449bdede7e4f0596dcd0513]
 and I think we should at least be using that version of parent pom with latest 
slf4j version. If, however, that's not possible without non-trivial changes, 
the version of log4j bundles should be overridden in distribution-core pom as 
it has always been the case.

> Error logged for NonRecoverableDistributionException in 
> SimpleDistributionAgentQueueProcessor does not log queuename
> 
>
> Key: SLING-9332
> URL: https://issues.apache.org/jira/browse/SLING-9332
> Project: Sling
>  Issue Type: Bug
>  Components: Content Distribution
>Reporter: Mohit Arora
>Priority: Minor
> Fix For: Content Distribution Core 0.4.4
>
>
> The [error message logged 
> in|https://github.com/apache/sling-org-apache-sling-distribution-core/blob/master/src/main/java/org/apache/sling/distribution/agent/impl/SimpleDistributionAgentQueueProcessor.java#L157]
>   SimpleDistributionAgentQueueProcessor uses an _Object_ to log 
> distributionpackage ID and queuename. However, from version 1.7 onward, log4j 
> seems to have stopped processing the object arrays for log statements. 
> Because of this the error logged in case of unsuccessful distribution looks 
> like - 
> {noformat}06.04.2020 07:48:30.411 *ERROR* 
> [sling-default-1-resource-queueProcessor-bpdistributionagent0-queue-bpdistributionagent0]
>  
> org.apache.sling.distribution.agent.impl.SimpleDistributionAgentQueueProcessor
>  could not deliver package 
> [dstrpck-1586159284848-e4c369fc-5bbf-4cfc-9ea3-2819af650784, 
> queue-bpdistributionagent0] from queue {}
> org.apache.sling.distribution.common.DistributionException: 
> org.apache.http.client.HttpResponseException: Bad Gateway
>   at 
> org.apache.sling.distribution.transport.impl.SimpleHttpDistributionTransport.deliverPackage(SimpleHttpDistributionTransport.java:162)
>  [org.apache.sling.distribution.core:0.4.2]
>   at 
> org.apache.sling.distribution.packaging.impl.importer.RemoteDistributionPackageImporter.importPackage(RemoteDistributionPackageImporter.java:66)
>  [org.apache.sling.distribution.core:0.4.2]
>   at 
> org.apache.sling.distribution.agent.impl.SimpleDistributionAgentQueueProcessor.processQueueItem(SimpleDistributionAgentQueueProcessor.java:134)
>  [org.apache.sling.distribution.core:0.4.2]
>   at 
> org.apache.sling.distribution.agent.impl.SimpleDistributionAgentQueueProcessor.process(SimpleDistributionAgentQueueProcessor.java:91)
>  [org.apache.sling.distribution.core:0.4.2]
>   at 
> org.apache.sling.distribution.queue.impl.simple.SimpleDistributionQueueProcessor.run(SimpleDistributionQueueProcessor.java:53)
>  [org.apache.sling.distribution.core:0.4.2]
>   at 
> org.apache.sling.commons.scheduler.impl.QuartzJobExecutor.execute(QuartzJobExecutor.java:347)
>  [org.apache.sling.commons.scheduler:2.7.6]
>   at org.quartz.core.JobRunShell.run(JobRunShell.java:202) 
> [org.apache.sling.commons.scheduler:2.7.6]
>   at 
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
>   at 
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
>   at java.base/java.lang.Thread.run(Thread.java:834)
> Caused by: org.apache.http.client.HttpResponseException: Bad Gateway
>   at 
> org.apache.http.impl.client.AbstractResponseHandler.handleResponse(AbstractResponseHandler.java:70)
>  [org.apache.httpcomponents.httpclient:4.5.4]
>   at 
> org.apache.http.client.fluent.Response.handleResponse(Response.java:90) 
> [org.apache.httpcomponents.httpclient:4.5.4]
>   at 
> org.apache.http.client.fluent.Response.returnContent(Response.java:97) 
> [org.apache.httpcomponents.httpclient:4.5.4]
>   at 
> org.apache.sling.distribution.transport.impl.SimpleHttpDistributionTransport.deliverPackage(SimpleHttpDistributionTransport.java:148)
>  [org.apache.sling.distribution.core:0.4.2]
>   ... 9 common frames 

[jira] [Closed] (SLING-9219) Invalid Comments in JSON Configuration

[Konrad Windszus (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus closed SLING-9219.
--

> Invalid Comments in JSON Configuration
> --
>
> Key: SLING-9219
> URL: https://issues.apache.org/jira/browse/SLING-9219
> Project: Sling
>  Issue Type: Bug
>  Components: Installer
>Affects Versions: File Installer 1.2.0, JCR Installer 3.2.0
>Reporter: Dan Klco
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: JCR Installer 3.2.2, File Installer 1.2.2
>
>
> With the latest version of JCR Installer, I'm seeing an exception when saving 
> OSGi Configurations from the console:
>  
> {{18.03.2020 19:57:44.565 *WARN* [JcrInstaller.2] 
> org.apache.sling.installer.core.impl.OsgiInstallerImpl Cannot create 
> InternalResource (resource will be ignored):InstallableResource, 
> priority=200, 
> id=/apps/sling/install/org.apache.sling.cms.core.internal.repository.RevisionCleanupScheduler.cfg.json}}{{javax.json.stream.JsonParsingException:
>  Unexpected character '#' (Codepoint: 35) on [lineNumber=2, columnNumber=77, 
> streamOffset=76]. Reason is [[Expected structural character or digit or 't' 
> or 'n' or 'f' or '-']]}}{{at 
> org.apache.johnzon.core.JsonStreamParserImpl.uexc(JsonStreamParserImpl.java:966)}}{{at
>  
> org.apache.johnzon.core.JsonStreamParserImpl.uexc(JsonStreamParserImpl.java:972)}}{{at
>  
> org.apache.johnzon.core.JsonStreamParserImpl.defaultHandling(JsonStreamParserImpl.java:422)}}{{at
>  
> org.apache.johnzon.core.JsonStreamParserImpl.next(JsonStreamParserImpl.java:414)}}{{at
>  
> org.apache.johnzon.core.JsonStreamParserImpl.next(JsonStreamParserImpl.java:353)}}{{at
>  
> org.apache.johnzon.core.JsonReaderImpl.parseObject(JsonReaderImpl.java:131)}}{{at
>  
> org.apache.johnzon.core.JsonReaderImpl.readValue(JsonReaderImpl.java:56)}}{{at
>  org.apache.johnzon.core.JsonReaderImpl.read(JsonReaderImpl.java:42)}}{{at 
> org.apache.felix.configurator.impl.json.JSONUtil.parseJSON(JSONUtil.java:331) 
> [org.apache.sling.installer.core:3.10.2]}}{{at 
> org.apache.felix.configurator.impl.json.JSONUtil.readJSON(JSONUtil.java:161) 
> [org.apache.sling.installer.core:3.10.2]}}{{at 
> org.apache.sling.installer.core.impl.InternalResource.readDictionary(InternalResource.java:274)
>  [org.apache.sling.installer.core:3.10.2]}}{{at 
> org.apache.sling.installer.core.impl.InternalResource.create(InternalResource.java:106)
>  [org.apache.sling.installer.core:3.10.2]}}{{at 
> org.apache.sling.installer.core.impl.OsgiInstallerImpl.createResources(OsgiInstallerImpl.java:385)
>  [org.apache.sling.installer.core:3.10.2]}}{{at 
> org.apache.sling.installer.core.impl.OsgiInstallerImpl.updateResources(OsgiInstallerImpl.java:425)
>  [org.apache.sling.installer.core:3.10.2]}}{{at 
> org.apache.sling.installer.provider.jcr.impl.JcrInstaller.runOneCycle(JcrInstaller.java:465)
>  [org.apache.sling.installer.provider.jcr:3.2.0]}}{{at 
> org.apache.sling.installer.provider.jcr.impl.JcrInstaller$StoppableThread.run(JcrInstaller.java:287)
>  [org.apache.sling.installer.provider.jcr:3.2.0]}}
> The problem appears to be that the files are in JSON format, but contain a 
> prefix comment: " # Configuration created by Apache Sling JCR Installer"
> This is due to the JCR Installer changing to write the configuration files in 
> JSON format, but still including the comment from when the configurations 
> were persisted as text files:
> [https://github.com/apache/sling-org-apache-sling-installer-provider-jcr/blame/master/src/main/java/org/apache/sling/installer/provider/jcr/impl/JcrInstaller.java#L695]
> The question [~kwin] it looks like there was a revert commit, so should the 
> config files revert to TXT format or remove the comment and have the 
> configurations in JSON format?
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (SLING-9319) sling:OsgiConfig nodetype is not registered anymore

[Konrad Windszus (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus closed SLING-9319.
--

> sling:OsgiConfig nodetype is not registered anymore
> ---
>
> Key: SLING-9319
> URL: https://issues.apache.org/jira/browse/SLING-9319
> Project: Sling
>  Issue Type: Bug
>  Components: Installer
>Affects Versions: JCR Installer 3.2.0
>Reporter: Bertrand Delacretaz
>Assignee: Bertrand Delacretaz
>Priority: Major
> Fix For: JCR Installer 3.2.2
>
>
> The {{bnd.bnd}} file has {{Sling-Nodetypes: 
> SLING-INF/nodetypes/osgiconfig.cn}} with a "cn" instead of "cnd" extension, 
> as a result the {{sling:OsgiConfig}} nodetype is not registered.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (SLING-9313) Content Package Installer: do not return an InstallTask if the TaskResource is of an unsupported type

[Konrad Windszus (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus closed SLING-9313.
--

> Content Package Installer: do not return an InstallTask if the TaskResource 
> is of an unsupported type
> -
>
> Key: SLING-9313
> URL: https://issues.apache.org/jira/browse/SLING-9313
> Project: Sling
>  Issue Type: Bug
>  Components: Installer
>Affects Versions: Installer Packages Factory 1.0.0
>Reporter: Radu Cotescu
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Installer Packages Factory 1.0.2
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> The 
> {{org.apache.sling.installer.factory.packages.impl.PackageTransformer#createTask}}
>  currently returns a {{ChangeStateTask}} for resources that it cannot handle 
> [0]. According to the documentation of the 
> {{org.apache.sling.installer.api.tasks.InstallTaskFactory}}, a factory should 
> return {{null}} "if the factory does not support the resource".
> The following error is encountered in the HTL integration tests setup from 
> https://github.com/apache/sling-org-apache-sling-scripting-sightly-testing:
> {noformat}
> 31.03.2020 16:15:14.833 *ERROR* [OsgiInstallerImpl] 
> org.apache.sling.installer.factory.packages.impl.PackageTransformer 
> Unupported type of 
> TaskResource(url=jcrinstall:/apps/sightly/install/org.apache.sling.scripting.sightly.testing-content-crlf.jar,
>  entity=bundle:org.apache.sling.scripting.sightly.testing-content-crlf, 
> state=INSTALL, 
> attributes=[org.apache.sling.installer.api.tasks.ResourceTransformer=:448:611:9:,
>  Bundle-SymbolicName=org.apache.sling.scripting.sightly.testing-content-crlf, 
> Bundle-Version=1.0.0], digest=1585265891708): bundle.
> {noformat}
> Several tests are failing, since the above bundle doesn't get installed. The 
> error cannot be reproduced all the time, suggesting that the order in which 
> the {{org.apache.sling.installer.api.tasks.InstallTaskFactory}} services are 
> started plays a role.
> [0] - 
> https://github.com/apache/sling-org-apache-sling-installer-factory-packages/blob/org.apache.sling.installer.factory.packages-1.0.0/src/main/java/org/apache/sling/installer/factory/packages/impl/PackageTransformer.java#L241



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[RESULT] [VOTE] JCR Installer 3.2.2, File Installer 1.2.2, Installer Packages Factory 1.0.2

[Konrad Windszus]

Hi,

The vote has passed with the following result :

+1 (binding): Carsten, Radu, Robert

I will copy this release to the Sling dist directory and
promote the artifacts to the central Maven repository.

Thanks,
Konrad

[jira] [Updated] (SLING-9332) Error logged for NonRecoverableDistributionException in SimpleDistributionAgentQueueProcessor does not log queuename

[Mohit Arora (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mohit Arora updated SLING-9332:
---
Description: 
The [error message logged 
in|https://github.com/apache/sling-org-apache-sling-distribution-core/blob/master/src/main/java/org/apache/sling/distribution/agent/impl/SimpleDistributionAgentQueueProcessor.java#L157]
  SimpleDistributionAgentQueueProcessor uses an _Object_ to log 
distributionpackage ID and queuename. However, from version 1.7 onward, log4j 
seems to have stopped processing the object arrays for log statements. Because 
of this the error logged in case of unsuccessful distribution looks like - 

{noformat}06.04.2020 07:48:30.411 *ERROR* 
[sling-default-1-resource-queueProcessor-bpdistributionagent0-queue-bpdistributionagent0]
 org.apache.sling.distribution.agent.impl.SimpleDistributionAgentQueueProcessor 
could not deliver package 
[dstrpck-1586159284848-e4c369fc-5bbf-4cfc-9ea3-2819af650784, 
queue-bpdistributionagent0] from queue {}
org.apache.sling.distribution.common.DistributionException: 
org.apache.http.client.HttpResponseException: Bad Gateway
at 
org.apache.sling.distribution.transport.impl.SimpleHttpDistributionTransport.deliverPackage(SimpleHttpDistributionTransport.java:162)
 [org.apache.sling.distribution.core:0.4.2]
at 
org.apache.sling.distribution.packaging.impl.importer.RemoteDistributionPackageImporter.importPackage(RemoteDistributionPackageImporter.java:66)
 [org.apache.sling.distribution.core:0.4.2]
at 
org.apache.sling.distribution.agent.impl.SimpleDistributionAgentQueueProcessor.processQueueItem(SimpleDistributionAgentQueueProcessor.java:134)
 [org.apache.sling.distribution.core:0.4.2]
at 
org.apache.sling.distribution.agent.impl.SimpleDistributionAgentQueueProcessor.process(SimpleDistributionAgentQueueProcessor.java:91)
 [org.apache.sling.distribution.core:0.4.2]
at 
org.apache.sling.distribution.queue.impl.simple.SimpleDistributionQueueProcessor.run(SimpleDistributionQueueProcessor.java:53)
 [org.apache.sling.distribution.core:0.4.2]
at 
org.apache.sling.commons.scheduler.impl.QuartzJobExecutor.execute(QuartzJobExecutor.java:347)
 [org.apache.sling.commons.scheduler:2.7.6]
at org.quartz.core.JobRunShell.run(JobRunShell.java:202) 
[org.apache.sling.commons.scheduler:2.7.6]
at 
java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
at 
java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
at java.base/java.lang.Thread.run(Thread.java:834)
Caused by: org.apache.http.client.HttpResponseException: Bad Gateway
at 
org.apache.http.impl.client.AbstractResponseHandler.handleResponse(AbstractResponseHandler.java:70)
 [org.apache.httpcomponents.httpclient:4.5.4]
at 
org.apache.http.client.fluent.Response.handleResponse(Response.java:90) 
[org.apache.httpcomponents.httpclient:4.5.4]
at 
org.apache.http.client.fluent.Response.returnContent(Response.java:97) 
[org.apache.httpcomponents.httpclient:4.5.4]
at 
org.apache.sling.distribution.transport.impl.SimpleHttpDistributionTransport.deliverPackage(SimpleHttpDistributionTransport.java:148)
 [org.apache.sling.distribution.core:0.4.2]
... 9 common frames omitted{noformat}

  was:
The[ error message logged 
in|https://github.com/apache/sling-org-apache-sling-distribution-core/blob/master/src/main/java/org/apache/sling/distribution/agent/impl/SimpleDistributionAgentQueueProcessor.java#L157]
  SimpleDistributionAgentQueueProcessor uses an _Object_ to log 
distributionpackage ID and queuename. However, from version 1.7 onward, log4j 
seems to have stopped processing the object arrays for log statements. Because 
of this the error logged in case of unsuccessful distribution looks like - 

{noformat}06.04.2020 07:48:30.411 *ERROR* 
[sling-default-1-resource-queueProcessor-bpdistributionagent0-queue-bpdistributionagent0]
 org.apache.sling.distribution.agent.impl.SimpleDistributionAgentQueueProcessor 
could not deliver package 
[dstrpck-1586159284848-e4c369fc-5bbf-4cfc-9ea3-2819af650784, 
queue-bpdistributionagent0] from queue {}
org.apache.sling.distribution.common.DistributionException: 
org.apache.http.client.HttpResponseException: Bad Gateway
at 
org.apache.sling.distribution.transport.impl.SimpleHttpDistributionTransport.deliverPackage(SimpleHttpDistributionTransport.java:162)
 [org.apache.sling.distribution.core:0.4.2]
at 
org.apache.sling.distribution.packaging.impl.importer.RemoteDistributionPackageImporter.importPackage(RemoteDistributionPackageImporter.java:66)
 [org.apache.sling.distribution.core:0.4.2]
at 
org.apache.sling.distribution.agent.impl.SimpleDistributionAgentQueueProcessor.processQueueItem(SimpleDistributionAgentQueueProcessor.java:134)
 [org.apache.sling.distribution.core:0.4.2]
at 

[jira] [Created] (SLING-9332) Error logged for NonRecoverableDistributionException in SimpleDistributionAgentQueueProcessor does not log queuename

[Mohit Arora (Jira)]

Mohit Arora created SLING-9332:
--

 Summary: Error logged for NonRecoverableDistributionException in 
SimpleDistributionAgentQueueProcessor does not log queuename
 Key: SLING-9332
 URL: https://issues.apache.org/jira/browse/SLING-9332
 Project: Sling
  Issue Type: Bug
  Components: Content Distribution
Reporter: Mohit Arora
 Fix For: Content Distribution Core 0.4.4


The[ error message logged 
in|https://github.com/apache/sling-org-apache-sling-distribution-core/blob/master/src/main/java/org/apache/sling/distribution/agent/impl/SimpleDistributionAgentQueueProcessor.java#L157]
  SimpleDistributionAgentQueueProcessor uses an _Object_ to log 
distributionpackage ID and queuename. However, from version 1.7 onward, log4j 
seems to have stopped processing the object arrays for log statements. Because 
of this the error logged in case of unsuccessful distribution looks like - 

{noformat}06.04.2020 07:48:30.411 *ERROR* 
[sling-default-1-resource-queueProcessor-bpdistributionagent0-queue-bpdistributionagent0]
 org.apache.sling.distribution.agent.impl.SimpleDistributionAgentQueueProcessor 
could not deliver package 
[dstrpck-1586159284848-e4c369fc-5bbf-4cfc-9ea3-2819af650784, 
queue-bpdistributionagent0] from queue {}
org.apache.sling.distribution.common.DistributionException: 
org.apache.http.client.HttpResponseException: Bad Gateway
at 
org.apache.sling.distribution.transport.impl.SimpleHttpDistributionTransport.deliverPackage(SimpleHttpDistributionTransport.java:162)
 [org.apache.sling.distribution.core:0.4.2]
at 
org.apache.sling.distribution.packaging.impl.importer.RemoteDistributionPackageImporter.importPackage(RemoteDistributionPackageImporter.java:66)
 [org.apache.sling.distribution.core:0.4.2]
at 
org.apache.sling.distribution.agent.impl.SimpleDistributionAgentQueueProcessor.processQueueItem(SimpleDistributionAgentQueueProcessor.java:134)
 [org.apache.sling.distribution.core:0.4.2]
at 
org.apache.sling.distribution.agent.impl.SimpleDistributionAgentQueueProcessor.process(SimpleDistributionAgentQueueProcessor.java:91)
 [org.apache.sling.distribution.core:0.4.2]
at 
org.apache.sling.distribution.queue.impl.simple.SimpleDistributionQueueProcessor.run(SimpleDistributionQueueProcessor.java:53)
 [org.apache.sling.distribution.core:0.4.2]
at 
org.apache.sling.commons.scheduler.impl.QuartzJobExecutor.execute(QuartzJobExecutor.java:347)
 [org.apache.sling.commons.scheduler:2.7.6]
at org.quartz.core.JobRunShell.run(JobRunShell.java:202) 
[org.apache.sling.commons.scheduler:2.7.6]
at 
java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
at 
java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
at java.base/java.lang.Thread.run(Thread.java:834)
Caused by: org.apache.http.client.HttpResponseException: Bad Gateway
at 
org.apache.http.impl.client.AbstractResponseHandler.handleResponse(AbstractResponseHandler.java:70)
 [org.apache.httpcomponents.httpclient:4.5.4]
at 
org.apache.http.client.fluent.Response.handleResponse(Response.java:90) 
[org.apache.httpcomponents.httpclient:4.5.4]
at 
org.apache.http.client.fluent.Response.returnContent(Response.java:97) 
[org.apache.httpcomponents.httpclient:4.5.4]
at 
org.apache.sling.distribution.transport.impl.SimpleHttpDistributionTransport.deliverPackage(SimpleHttpDistributionTransport.java:148)
 [org.apache.sling.distribution.core:0.4.2]
... 9 common frames omitted{noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Resolved] (SLING-9330) Path registrations override the servlet resources for parent resource types

[Radu Cotescu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radu Cotescu resolved SLING-9330.
-
  Assignee: Radu Cotescu
Resolution: Fixed

Fixed in [commit 
26fdcfb|https://github.com/apache/sling-org-apache-sling-scripting-bundle-tracker/commit/26fdcfb],
 tests added in [commit 
02f3ecf|https://github.com/apache/sling-org-apache-sling-scripting-bundle-tracker-it/commit/02f3ecf].

> Path registrations override the servlet resources for parent resource types
> ---
>
> Key: SLING-9330
> URL: https://issues.apache.org/jira/browse/SLING-9330
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Reporter: Radu Cotescu
>Assignee: Radu Cotescu
>Priority: Major
> Fix For: Scripting Bundle Tracker 0.2.0
>
>
> The implementation for SLING-9255 can override the initial servlet resources 
> due to the fact that path registrations for inheriting resource types are 
> generated with the scripts of the parents. This will add a 
> {{sling:resourceSuperType}} to the parent resources pointing to themselves, 
> which can break the servlet resolution process.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-9118) Sling fails to start when database exists but 'sling' directory is missing

[Robert Munteanu (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-9118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17076148#comment-17076148
 ] 

Robert Munteanu commented on SLING-9118:


[~carlosmunoz] - I think you only attached the console output, right? I would 
need the file from {{sling/logs/error.log}} as well.

> Sling fails to start when database exists but 'sling' directory is missing
> --
>
> Key: SLING-9118
> URL: https://issues.apache.org/jira/browse/SLING-9118
> Project: Sling
>  Issue Type: Bug
>Reporter: Ben Radey
>Assignee: Robert Munteanu
>Priority: Major
> Attachments: drop-mongo.sh, recreateSlingReplicaSet.sh, run-mongo.sh, 
> run-sling-initial.sh, run-sling-second.sh, sling-startup-error.log.txt
>
>
> # Create a persistent mongodb to use with Sling.
>  # Start sling using the mongodb.
>  # Stop sling.
>  # Remove 'sling' directory.
>  # Attempt to restart sling. Ultimately, sling fails to start.
> 
> Steps to reproduce with attached scripts:
> # Run [^run-mongo.sh] . This creates a MongoDB 3.6 container named 
> _mongo-sling_
> # Run [^run-sling-initial.sh]. This starts up Sling in the oak_mongo runmode, 
> shuts it down after it's (probably) started up
> # Run [^run-sling-second.sh]. This moves away the sling directory and starts 
> up a new instance. This always fails
> For cleanup, the [^drop-mongo.sh] script stops and removes the _mongo-sling_ 
> container.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Doing a Feathercast interview on Sling next Monday, your input is welcome

[Robert Munteanu]

Hi Bertrand,

I can't see any improvements to what you have posted, have fun :-)

Robert

On Fri, 2020-04-03 at 16:09 +0200, Bertrand Delacretaz wrote:
> Hi,
> 
> I'll be doing an interview about Sling next Monday for
> https://feathercast.apache.org/ , with Rich Bowen from the ASF.
> 
> I enclose the planned questions along with my tentative answers.
> 
> If someone has comments or complements they are welcome!
> 
> -Bertrand
> 
> ** feathercast questions ***
> 
> Q: I read the description of your project from the website, but what
> does that actually mean? What does your project do? Who would use it?
> 
> Sling is an extremely modular Java Web Framework, which dynamically
> selects scripts in various languages and Java Servlets to process
> HTTP
> requests. Its strong points are its flexibility, as it runs any
> scripting language that the Java Virtual Machine supports, its
> extreme
> modularity, based on the OSGi module system, and its code quality and
> stability. It's a very mature project, more than ten years old but
> still going strong with new modules and performance and functionality
> improvements being worked on all the time by roughly twenty active
> committers.
> 
> Our more than 300 Git repositories were a bit scary for Apache Infra
> initially, but some of our community members helped create a few
> tools
> to manage them and that works very well. Big thanks to Apache Infra!
> 
> Q:  Tell us some user stories: Give us an example of people who are
> using $Project in the real world, and what kinds of problems they are
> solving with it.
> 
> Sling powers some major content management products which run some of
> the largest websites on the planet. At my employer we are using it in
> many different contexts, from smaller on-premises systems to large
> cloud-based services. Seeing your code used in such contexts and
> service millions
> of requests is very gratifying. And helps explain to your family what
> it is that you actually do in these long hours in front of your
> computer  ;-)
> 
> Q: Name origin story? (If weird/interesting name.)
> 
> From the Sling website:
> 
> The name "Sling" was proposed by Roy Fielding who explained it like
> this:
> 
> [The name is] Biblical in nature. The story of David: the weapon he
> uses to slay the giant Goliath is a sling.
> Hence, it's our David's favorite weapon.
> [that's David Nuescheler, CTO of Day Software when that company
> donated the Sling codebase to Apache]
> It is also the simplest device for delivering content very fast ;-)
> 
> Q: Recent releases/development/activity?
> 
> Tons of them!
> 
> A good portion of our more than 300 modules are evolving all the time
> with very frequent releases.
> 
> reporter.apache.org outputs more than 1'300 lines for Sling since
> 2008, each line listing one or a few releases.
> 128 lines in 2019 and already 36 in 2020. We most often have a few
> module releases every week.
> 
> Q: Where do you hang out? Where should I come to connect with you?
> 
> Our main channel is the dev@sling.apache.org mailing list
> 
> Q: Where do I get more info? (This is where you advertise your
> website, mailing lists, and other online resources. Also promote
> upcoming events, if any.)
> 
> sling.apache.org is the entry point for everything around SLing.
> 
> The yearly adaptTo() conference is where many of us we gather for
> in-person technical exchange, the next one is in Berlin at the end of
> September, its website is at adapt.to

[jira] [Commented] (SLING-9212) Distribution code checks for jcr:removeNode permissions on importer side for DELETE request

[Mohit Arora (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-9212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17076138#comment-17076138
 ] 

Mohit Arora commented on SLING-9212:


[~marett] Can you please check this issue and provide your feedback here?

cc - [~shgu...@adobe.com]

> Distribution code checks for jcr:removeNode permissions on importer side for 
> DELETE request
> ---
>
> Key: SLING-9212
> URL: https://issues.apache.org/jira/browse/SLING-9212
> Project: Sling
>  Issue Type: Bug
>  Components: Content Distribution
>Reporter: Mohit Arora
>Priority: Major
> Fix For: Content Distribution Core 0.4.4
>
>
> When a resource is distributed from one endpoint to other with RequestType 
> set to DELETE, the execute method of SimpleDistributionAgent [checks the 
> permissions for the passed resolver on given 
> path(s)|https://github.com/apache/sling-org-apache-sling-distribution-core/blob/master/src/main/java/org/apache/sling/distribution/agent/impl/SimpleDistributionAgent.java#L175].
>  In case of DELETE request, apart from the [configured 
> permissions|https://github.com/apache/sling-org-apache-sling-distribution-core/blob/master/src/main/java/org/apache/sling/distribution/agent/impl/PrivilegeDistributionRequestAuthorizationStrategy.java#L85],
>  it also checks for {{jcr:removeNode}} permissions for the user on the path. 
> This check happens on the exporter side but AFAIU, the actual deletion 
> happens on the importer endpoint. The content does not get deleted on 
> exporter side. In that case, this permission check should happen on importer 
> side.
> cc - [~marett], [~ashishc]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Sling 12 with Composite Node Store

[Robert Munteanu]

Sounds good!

Robert

On Fri, 2020-04-03 at 12:11 -0700, Andreas Schaefer wrote:
> The Sling Kickstart project has now a branch feature/composite-node-
> store that works the same way as Robert’s Sling Starter.
> 
> Because there was an adjustment in the Sling FM you need to build it
> first (mvn clean install).
> The run create_seed_fm.sh and then run_composite_fm.sh.
> 
> Will add a readme later.
> 
> - Andy
> 
> > On Apr 2, 2020, at 10:46 PM, Ruben Reusser  wrote:
> > 
> > hey
> > 
> > bei deinem email:
> > 
> > 
> > AEM: "/jcr:system/rep:permissionStore/oak:mount-libs-crx.default”
> > Sling: "/jcr:system/rep:permissionStore/oak:mount-libs-default”
> > 
> > Not sure what the difference means but if I use the AEM line in
> > Sling Composum (or any JSP for that matter) will not work.
> > 
> > meinst Du da dass wenn Du AEM:
> > "/jcr:system/rep:permissionStore/oak:mount-libs-crx.default”
> > brauchst funktioniert composum nicht aber wenn Du Sling:
> > "/jcr:system/rep:permissionStore/oak:mount-libs-default” brauchst
> > funktioniert es? 
> > 
> > und zwischen sling und composum muesste wohl noch ein komma stehen
> > damit man das nicht falsch liest
> > 
> > Ruben
> > 
> > 
> > 
> >  Forwarded Message 
> > Subject:Re: Sling 12 with Composite Node Store
> > Date:   Thu, 2 Apr 2020 18:43:12 -0700
> > From:   Andreas Schaefer   > schaef...@me.com.INVALID>
> > Reply-To:   dev@sling.apache.org 
> > To: dev  
> > 
> > Hi Robert
> > 
> > I got your example up and running and then I was able to migrate
> > the entire thing to a Feature Model based version using the
> > Kickstarter project.
> > I will create a branch (like yours) on the kickstarter and add the
> > configuration files there.
> > 
> > Later I will write a little bit more about it to fill in some
> > blanks and background info.
> > With the launcher I was able to just have the Segment Node Store in
> > the /sling folder which would also to avoid the prepare call but I
> > need to do some more testing to see if we can avoid that step with
> > the Kickstarter.
> > 
> > When comparing Sling with AEM Quickstart I noticed that the
> > MountInfoProviderService has a different mount path:
> > 
> > AEM: "/jcr:system/rep:permissionStore/oak:mount-libs-crx.default”
> > Sling: "/jcr:system/rep:permissionStore/oak:mount-libs-default”
> > 
> > Not sure what the difference means but if I use the AEM line in
> > Sling Composum (or any JSP for that matter) will not work.
> > 
> > - Andy
> > 
> > > On Apr 1, 2020, at 7:00 AM, Robert Munteanu 
> > >  wrote:
> > > 
> > > On Wed, 2020-04-01 at 10:21 +0200, Robert Munteanu wrote:
> > > > Hi Andy,
> > > > 
> > > > I'm trying to set this up myself based on some internal notes
> > > > from
> > > > Thomas Mueller.
> > > 
> > > (snip)
> > > 
> > > > I'll post back if I make more progress.
> > > 
> > > I have what seems to be a working setup at [1]. See the README at
> > > [2]
> > > for (somewhat) detailed instructions on how to get this running.
> > > 
> > > Comments, PRs, etc welcome for anything that can be improved.
> > > 
> > > Thanks!
> > > Robert
> > > 
> > > [1]: 
> > > https://github.com/apache/sling-org-apache-sling-starter/tree/feature/composite-node-store
> > > <
> > > https://github.com/apache/sling-org-apache-sling-starter/tree/feature/composite-node-store
> > > >
> > > [2]: 
> > > https://github.com/apache/sling-org-apache-sling-starter/blob/feature/composite-node-store/README-composite.md
> > > <
> > > https://github.com/apache/sling-org-apache-sling-starter/blob/feature/composite-node-store/README-composite.md
> > > >
> > > 
> > > 

Re: Released POMs are missing licenses and organisation information

[Carsten Ziegeler]

Probably answering my own question: normal inheritance is used for these 
tags as well, so if you want to find the license or organisation of a 
pom you need to walk up the parent pom chain until you find it :(


Regards
Carsten

On 06.04.2020 09:31, Carsten Ziegeler wrote:

Hi

I just realised that our released poms do not contain the  or 
 section inherited from the parent pom.


For example [1] does not have it, but I couldn't find it in any other 
pom I looked at either.


If you do a "mvn help:effective-pom" in such a project, the tags appear.

Does anyone have an idea what is going wrong?

Regards
Carsten


[1] 
https://repo1.maven.org/maven2/org/apache/sling/org.apache.sling.feature/1.1.8/org.apache.sling.feature-1.1.8.pom 



--
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org


--
--
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

[jira] [Commented] (SLING-8803) Update to Oak 1.26.0

[Robert Munteanu (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-8803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17076102#comment-17076102
 ] 

Robert Munteanu commented on SLING-8803:


Fixed with [sling-org-apache-sling-starter commit 
1b49e0b|https://github.com/apache/sling-org-apache-sling-starter/commit/1b49e0b]


> Update to Oak 1.26.0
> 
>
> Key: SLING-8803
> URL: https://issues.apache.org/jira/browse/SLING-8803
> Project: Sling
>  Issue Type: Improvement
>  Components: Starter
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
>  Labels: Sling-12-ReleaseNotes
> Fix For: Starter 12
>
>
> Oak 1.20.0 will be out, potentially with breaking changes (see OAK-8717)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Released POMs are missing licenses and organisation information

[Carsten Ziegeler]

Hi

I just realised that our released poms do not contain the  or 
 section inherited from the parent pom.


For example [1] does not have it, but I couldn't find it in any other 
pom I looked at either.


If you do a "mvn help:effective-pom" in such a project, the tags appear.

Does anyone have an idea what is going wrong?

Regards
Carsten


[1] 
https://repo1.maven.org/maven2/org/apache/sling/org.apache.sling.feature/1.1.8/org.apache.sling.feature-1.1.8.pom


--
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org