[jira] [Commented] (SLING-9594) Move Sling builds to ci-builds.apache.org

2020-08-10 Thread Robert Munteanu (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-9594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17175076#comment-17175076
 ] 

Robert Munteanu commented on SLING-9594:


I've enabled all module builds and things _seem_ fine. However, due to 
INFRA-20607  (unable to recreate monitor view) I'm unable to check how many of 
the module failures are master builds and how many are outdated branches.

> Move Sling builds to ci-builds.apache.org
> -
>
> Key: SLING-9594
> URL: https://issues.apache.org/jira/browse/SLING-9594
> Project: Sling
>  Issue Type: Task
>  Components: Build and Source Control
>Reporter: Robert Munteanu
>Priority: Critical
>
> The ASF Jenkins infrastructure is moving to to a new
> Cloudbees based Client Master called https://ci-builds.apache.org, see 
> https://lists.apache.org/thread.html/re974eed417a1bc294694701d5c91b4bf92689fcf32a4c91f169be87d%40%3Cbuilds.apache.org%3E
>  .  The migrations of all jobs needs to be done before the switch off date of 
> 15th August 2020, so we have a maximum about three weeks from now to make the 
> move.
> There is no automatic way of migrating the jobs, but thankfully our current 
> set up is very much automated and reasonably well documented at 
> https://cwiki.apache.org/confluence/display/SLING/Sling+Jenkins+Setup .
> It very well may be that we can simply set up another GitHub org on the new 
> Jenkins master, provide the secrets and be done with it. But it needs 
> investigation though.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [sling-org-apache-sling-feature-launcher] sonarcloud[bot] commented on pull request #13: Issues/sling 8483 Add a Priority to the Extension Handler to sort them

2020-08-10 Thread GitBox


sonarcloud[bot] commented on pull request #13:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/13#issuecomment-671576873


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=13=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=13=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=13=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=13=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=13=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=13=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=13
 lved=false=SECURITY_HOTSPOT) [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=13=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=13=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=13=false=CODE_SMELL)
 [1 Code 
Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=13=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-launcher=13=new_coverage=list)
 [90.0% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-launcher=13=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-launcher=13=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-launcher=13=new_duplicated_lines_density=list)
   
The version of Java (1.8.0_252) you 
have used to run this analysis is deprecated and we will stop accepting it from 
October 2020. Please update to at least Java 11.
   Read more [here](https://sonarcloud.io/documentation/upcoming/)
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [sling-whiteboard] sonarcloud[bot] commented on pull request #62: Saml2 auth handler/upgrade sling12 open samlv4 java11

2020-08-10 Thread GitBox


sonarcloud[bot] commented on pull request #62:
URL: https://github.com/apache/sling-whiteboard/pull/62#issuecomment-671575111


   SonarCloud Quality Gate failed.
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=62=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=62=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=62=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=62=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=62=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=62=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=62=false=SECURITY_HOTSPOT)
 [0 Security Hotspots](https://sonarcloud.io/project/issue
 
s?id=apache_sling-whiteboard=62=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=62=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=62=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=62=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-whiteboard=62=new_coverage=list)
 [0.0% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-whiteboard=62=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-whiteboard=62=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-whiteboard=62=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [sling-whiteboard] sonarcloud[bot] commented on pull request #14: First commit for oidc handler.

2020-08-10 Thread GitBox


sonarcloud[bot] commented on pull request #14:
URL: https://github.com/apache/sling-whiteboard/pull/14#issuecomment-671574671


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=14=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=14=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=14=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=14=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=14=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=14=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=14=false=SECURITY_HOTSPOT)
 [0 Security Hotspots](https://sonarcloud.io/project/issue
 
s?id=apache_sling-whiteboard=14=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=14=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=14=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=14=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-whiteboard=14=coverage=list)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_sling-whiteboard=14=duplicated_lines_density=list)
 No Duplication information
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [sling-whiteboard] sonarcloud[bot] commented on pull request #50: Bump eslint-utils from 1.3.1 to 1.4.3 in /serverless-microsling

2020-08-10 Thread GitBox


sonarcloud[bot] commented on pull request #50:
URL: https://github.com/apache/sling-whiteboard/pull/50#issuecomment-671574697


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=50=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=50=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=50=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=50=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=50=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=50=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=50=false=SECURITY_HOTSPOT)
 [0 Security Hotspots](https://sonarcloud.io/project/issue
 
s?id=apache_sling-whiteboard=50=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=50=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=50=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=50=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-whiteboard=50=coverage=list)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_sling-whiteboard=50=duplicated_lines_density=list)
 No Duplication information
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [sling-whiteboard] sonarcloud[bot] commented on pull request #44: SLING-8525 - adding Launcher extension to be able to launch analyser …

2020-08-10 Thread GitBox


sonarcloud[bot] commented on pull request #44:
URL: https://github.com/apache/sling-whiteboard/pull/44#issuecomment-671574612


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=44=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=44=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=44=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=44=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=44=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=44=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=44=false=SECURITY_HOTSPOT)
 [0 Security Hotspots](https://sonarcloud.io/project/issue
 
s?id=apache_sling-whiteboard=44=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=44=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=44=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=44=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-whiteboard=44=coverage=list)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_sling-whiteboard=44=duplicated_lines_density=list)
 No Duplication information
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [sling-org-apache-sling-launchpad-base] sonarcloud[bot] commented on pull request #6: Strings and Boxed types should be compared using "equals()"

2020-08-10 Thread GitBox


sonarcloud[bot] commented on pull request #6:
URL: 
https://github.com/apache/sling-org-apache-sling-launchpad-base/pull/6#issuecomment-671573024


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-base=6=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-base=6=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-base=6=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-base=6=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-base=6=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-base=6=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-base=6=false
 ypes=SECURITY_HOTSPOT) [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-base=6=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-base=6=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-base=6=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-base=6=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-launchpad-base=6=new_coverage=list)
 [59.5% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-launchpad-base=6=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-launchpad-base=6=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-launchpad-base=6=new_duplicated_lines_density=list)
   
The version of Java (1.8.0_252) you 
have used to run this analysis is deprecated and we will stop accepting it from 
October 2020. Please update to at least Java 11.
   Read more [here](https://sonarcloud.io/documentation/upcoming/)
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[Jenkins] Sling » Modules » sling-org-apache-sling-launchpad-testing » master #4 is BROKEN

2020-08-10 Thread Apache Jenkins Server
s/workspace/e-sling-launchpad-testing_master/target/jacoco-merged.exec
[INFO] Analyzed bundle 'Apache Sling Launchpad Testing' with 0 classes
[INFO] 
[INFO] --- maven-failsafe-plugin:2.21.0:verify (default) @ 
org.apache.sling.launchpad.testing ---
[INFO] 
[INFO] 
[INFO] Skipping Apache Sling Launchpad Testing
[INFO] This project has been banned from the build due to previous failures.
[INFO] 
[INFO] ----
[INFO] BUILD FAILURE
[INFO] 
[INFO] Total time:  03:46 min
[INFO] Finished at: 2020-08-10T20:27:01Z
[INFO] 
[INFO] [jenkins-event-spy] Generated 
/home/jenkins/workspace/e-sling-launchpad-testing_master@tmp/withMaven4d407388/maven-spy-20200810-202315-5908717683411172421057.log
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-failsafe-plugin:2.21.0:verify (default) on 
project org.apache.sling.launchpad.testing: There are test failures.
[ERROR] 
[ERROR] Please refer to 
/home/jenkins/workspace/e-sling-launchpad-testing_master/target/failsafe-reports
 for the individual test results.
[ERROR] Please refer to dump files (if any exist) [date]-jvmRun[N].dump, 
[date].dumpstream and [date]-jvmRun[N].dumpstream.
[ERROR] -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please 
read the following articles:
[ERROR] [Help 1] 
http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[Pipeline] echo
Marking build unstable due to mvn sonar:sonar failing. See 
https://cwiki.apache.org/confluence/display/SLING/SonarCloud+analysis for more 
info.
[Pipeline] }
[withMaven] Publishers: 
[Pipeline] // withMaven
[Pipeline] }
[Pipeline] // withCredentials
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
[Pipeline] // timeout
[Pipeline] stage
[Pipeline] { (Notifications)
[Pipeline] echo
Status change is BROKEN, notifications will be sent.
[Pipeline] emailext

[Jenkins] Sling » Modules » sling-org-apache-sling-launchpad-testing » master #2 is FIXED

2020-08-10 Thread Apache Jenkins Server
Please see 
https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-launchpad-testing/job/master/2/
 for details.

No further emails will be sent until the status of the build is changed.

[GitHub] [sling-org-apache-sling-testing-sling-mock] sonarcloud[bot] commented on pull request #2: [SLING-8060] declare OSGi dependencies with scope "compile"

2020-08-10 Thread GitBox


sonarcloud[bot] commented on pull request #2:
URL: 
https://github.com/apache/sling-org-apache-sling-testing-sling-mock/pull/2#issuecomment-671569526


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-sling-mock=2=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-sling-mock=2=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-sling-mock=2=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-sling-mock=2=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-sling-mock=2=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-sling-mock=2=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-sling-mock=2;
 resolved=false=SECURITY_HOTSPOT) [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-sling-mock=2=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-sling-mock=2=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-sling-mock=2=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-sling-mock=2=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-sling-mock=2=coverage=list)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-sling-mock=2=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-sling-mock=2=new_duplicated_lines_density=list)
   
The version of Java (1.8.0_252) you 
have used to run this analysis is deprecated and we will stop accepting it from 
October 2020. Please update to at least Java 11.
   Read more [here](https://sonarcloud.io/documentation/upcoming/)
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[Jenkins] Sling » Modules » sling-org-apache-sling-launchpad-testing » master #1 is BROKEN

2020-08-10 Thread Apache Jenkins Server
Please see 
https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-launchpad-testing/job/master/1/
 for details.

No further emails will be sent until the status of the build is changed.
Build log follows below:

[...truncated 3720 lines...]


ApacheSling/2.7 (jetty/9.4.28.v20200408, OpenJDK 64-Bit Server VM 
1.8.0_252, Linux 4.15.0-76-generic amd64)


) expected:<200> but was:<403>
at 
org.apache.sling.launchpad.webapp.integrationtest.BundleContentTest.testBundleContentRetrieval(BundleContentTest.java:30)

[INFO] Running 
org.apache.sling.launchpad.webapp.integrationtest.WebdavDeleteTest
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.122 s 
- in org.apache.sling.launchpad.webapp.integrationtest.WebdavDeleteTest
[INFO] Running 
org.apache.sling.launchpad.webapp.integrationtest.repository.RepositoryNameTest
ERROR: JarContent: Unable to read bytes for file 
org/apache/felix/utils/json/JSONWriter.class in ZIP file 
/home/jenkins/.m2/repository/org/apache/sling/org.apache.sling.launchpad.test-services/12-SNAPSHOT/org.apache.sling.launchpad.test-services-12-SNAPSHOT.jar
[ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.02 s 
<<< FAILURE! - in 
org.apache.sling.launchpad.webapp.integrationtest.repository.RepositoryNameTest
[ERROR] 
checkOakName(org.apache.sling.launchpad.webapp.integrationtest.repository.RepositoryNameTest)
  Time elapsed: 0.019 s  <<< FAILURE!
junit.framework.AssertionFailedError: 
Expected status 200 for 
http://localhost:41000/testing/RepositoryDescriptors.json (content=


500 org/apache/felix/utils/json/JSONWriter


org/apache/felix/utils/json/JSONWriter (500)
The requested URL /testing/RepositoryDescriptors.json resulted in an error 
in 
org.apache.sling.launchpad.testservices.servlets.RepositoryDescriptorsServlet.
Exception:

java.lang.NoClassDefFoundError: org/apache/felix/utils/json/JSONWriter
at 
org.apache.sling.launchpad.testservices.servlets.RepositoryDescriptorsServlet.doGet(RepositoryDescriptorsServlet.java:54)
at 
org.apache.sling.api.servlets.SlingSafeMethodsServlet.mayService(SlingSafeMethodsServlet.java:266)
at 
org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:342)
at 
org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:374)
at 
org.apache.sling.engine.impl.request.RequestData.service(RequestData.java:552)
at 
org.apache.sling.engine.impl.filter.SlingComponentFilterChain.render(SlingComponentFilterChain.java:44)
at 
org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:82)
at 
org.apache.sling.engine.impl.SlingRequestProcessorImpl.processComponent(SlingRequestProcessorImpl.java:283)
at 
org.apache.sling.engine.impl.filter.RequestSlingFilterChain.render(RequestSlingFilterChain.java:49)
at 
org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:82)
at 
org.apache.sling.engine.impl.debug.RequestProgressTrackerLogFilter.doFilter(RequestProgressTrackerLogFilter.java:110)
at 
org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
at 
org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:78)
at 
org.apache.sling.launchpad.testservices.filters.TestFilter.doFilter(TestFilter.java:47)
at 
org.apache.sling.launchpad.testservices.filters.NoPropertyFilter.doFilter(NoPropertyFilter.java:25)
at 
org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
at 
org.apache.sling.launchpad.testservices.filters.TestFilter.doFilter(TestFilter.java:47)
at 
org.apache.sling.launchpad.testservices.filters.SlingFilter.doFilter(SlingFilter.java:25)
at 
org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
at org.apache.sling.i18n.impl.I18NFilter.doFilter(I18NFilter.java:131)
at 
org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
at 
org.apache.sling.engine.impl.SlingRequestProcessorImpl.doProcessRequest(SlingRequestProcessorImpl.java:151)
at 
org.apache.sling.engine.impl.SlingMainServlet.service(SlingMainServlet.java:250)
at 
org.apache.felix.http.base.internal.handler.ServletHandler.handle(ServletHandler.java:123)
at 
org.apache.felix.http.base.internal.dispatch.InvocationChain.doFilter(InvocationChain.java:86)
at 
org.apache.sling.junit.impl.servlet.TestLogServlet$TestNameLoggingFilter.doFilter(TestLogServlet.java:257)
at 
org.apache.felix.http.base.internal.handler.FilterHandler.handle(FilterHandler.java:142)
at 

[GitHub] [sling-org-apache-sling-launchpad-integration-tests] sonarcloud[bot] commented on pull request #1: [SLING-9417] Added test for an nt:file child of a versioned node

2020-08-10 Thread GitBox


sonarcloud[bot] commented on pull request #1:
URL: 
https://github.com/apache/sling-org-apache-sling-launchpad-integration-tests/pull/1#issuecomment-671564439


   SonarCloud Quality Gate failed.
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-integration-tests=1=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-integration-tests=1=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-integration-tests=1=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-integration-tests=1=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-integration-tests=1=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-integration-tests=1=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launch
 pad-integration-tests=1=false=SECURITY_HOTSPOT) [0 
Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-integration-tests=1=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-integration-tests=1=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-integration-tests=1=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-integration-tests=1=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-launchpad-integration-tests=1=new_coverage=list)
 [0.0% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-launchpad-integration-tests=1=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-launchpad-integration-tests=1=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-launchpad-integration-tests=1=new_duplicated_lines_density=list)
   
The version of Java (1.8.0_252) you 
have used to run this analysis is deprecated and we will stop accepting it from 
October 2020. Please update to at least Java 11.
   Read more [here](https://sonarcloud.io/documentation/upcoming/)
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [sling-org-apache-sling-launchpad-integration-tests] sonarcloud[bot] removed a comment on pull request #1: [SLING-9417] Added test for an nt:file child of a versioned node

2020-08-10 Thread GitBox


sonarcloud[bot] removed a comment on pull request #1:
URL: 
https://github.com/apache/sling-org-apache-sling-launchpad-integration-tests/pull/1#issuecomment-671555879


   SonarCloud Quality Gate failed.
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-integration-tests=1=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-integration-tests=1=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-integration-tests=1=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-integration-tests=1=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-integration-tests=1=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-integration-tests=1=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launch
 pad-integration-tests=1=false=SECURITY_HOTSPOT) [0 
Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-integration-tests=1=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-integration-tests=1=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-integration-tests=1=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-integration-tests=1=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-launchpad-integration-tests=1=new_coverage=list)
 [0.0% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-launchpad-integration-tests=1=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-launchpad-integration-tests=1=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-launchpad-integration-tests=1=new_duplicated_lines_density=list)
   
The version of Java (1.8.0_252) you 
have used to run this analysis is deprecated and we will stop accepting it from 
October 2020. Please update to at least Java 11.
   Read more [here](https://sonarcloud.io/documentation/upcoming/)
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[Jenkins] Sling » Modules » sling-org-apache-sling-launchpad-testing-war » master #1 is BROKEN

2020-08-10 Thread Apache Jenkins Server
Argument host 
parameter is null
[INFO] 
[INFO] 
[ERROR] Tests run: 582, Failures: 567, Errors: 10, Skipped: 1
[INFO] 
[INFO] 
[INFO] --- jetty-maven-plugin:9.3.12.v20160915:stop (stop-jetty) @ 
org.apache.sling.launchpad.testing-war ---
[INFO] 
[INFO] --- ianal-maven-plugin:1.0-alpha-1:verify-legal-files (default) @ 
org.apache.sling.launchpad.testing-war ---
[INFO] Stopped ServerConnector@39dafaca{HTTP/1.1,[http/1.1]}{0.0.0.0:8080}
[DEBUG] [ServiceReference 633 from bundle 93 : 
org.apache.sling.jcr.davex:1.3.10 ref=[javax.servlet.Servlet] 
properties={objectClass=[javax.servlet.Servlet], 
osgi.http.whiteboard.context.select=(osgi.http.whiteboard.context.name=DavExAuthHttpContext),
 osgi.http.whiteboard.servlet.pattern=/server/*, service.bundleid=93, 
service.description=Sling JcrRemoting Servlet, service.id=633, 
service.scope=singleton, service.vendor=The Apache Software Foundation, 
servlet.init.createAbsoluteURI=true, servlet.init.csrf-protection=disabled, 
servlet.init.protectedhandlers-config=org.apache.jackrabbit.server.remoting.davex.AclRemoveHandler,
 servlet.init.resource-path-prefix=/server, sling.auth.requirements=-/server}] 
Ignoring unmatching Servlet service
[DEBUG] [ServiceReference 424 from bundle 143 : org.apache.sling.engine:2.7.2 
ref=[javax.servlet.Servlet] properties={objectClass=[javax.servlet.Servlet], 
osgi.http.whiteboard.context.select=(osgi.http.whiteboard.context.name=org.apache.sling),
 osgi.http.whiteboard.servlet.name=ApacheSling/2.7, 
osgi.http.whiteboard.servlet.pattern=/, service.bundleid=143, 
service.description=Apache Sling Engine Main Servlet, service.id=424, 
service.scope=singleton, service.vendor=The Apache Software Foundation}] 
Ignoring unmatching Servlet service
[DEBUG] [ServiceReference 153 from bundle 59 : 
org.apache.sling.launchpad.test-services:12.0.0.SNAPSHOT 
ref=[javax.servlet.Servlet] properties={component.id=60, 
component.name=org.apache.sling.launchpad.testservices.servlets.R6WhiteboardServlet,
 objectClass=[javax.servlet.Servlet], 
osgi.http.whiteboard.context.select=(osgi.http.whiteboard.context.name=org.apache.sling),
 osgi.http.whiteboard.servlet.pattern=/whiteboard_r6, service.bundleid=59, 
service.id=153, 
service.pid=org.apache.sling.launchpad.testservices.servlets.R6WhiteboardServlet,
 service.scope=bundle, service.vendor=The Apache Software Foundation}] Ignoring 
unmatching Servlet service
[INFO] Checking legal files in: 
org.apache.sling.launchpad.testing-war-12-SNAPSHOT.jar
[INFO] Checking legal files in: 
org.apache.sling.launchpad.testing-war-12-SNAPSHOT.war
[INFO] Checking legal files in: 
org.apache.sling.launchpad.testing-war-12-SNAPSHOT-sources.jar
[INFO] 
[INFO] --- maven-failsafe-plugin:2.21.0:verify (default) @ 
org.apache.sling.launchpad.testing-war ---
[INFO] 
[INFO] BUILD FAILURE
[INFO] 
[INFO] Total time:  04:21 min
[INFO] Finished at: 2020-08-10T19:57:05Z
[INFO] 
[INFO] [jenkins-event-spy] Generated 
/home/jenkins/workspace/ing-launchpad-testing-war_master@tmp/withMaven87cd3050/maven-spy-20200810-195244-2038079249552242102794.log
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-failsafe-plugin:2.21.0:verify (default) on 
project org.apache.sling.launchpad.testing-war: There are test failures.
[ERROR] 
[ERROR] Please refer to 
/home/jenkins/workspace/ing-launchpad-testing-war_master/target/failsafe-reports
 for the individual test results.
[ERROR] Please refer to dump files (if any exist) [date]-jvmRun[N].dump, 
[date].dumpstream and [date]-jvmRun[N].dumpstream.
[ERROR] -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please 
read the following articles:
[ERROR] [Help 1] 
http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[Pipeline] }
[Fast Archiver] No prior successful build to compare, so performing full copy 
of artifacts
[withMaven] junitPublisher - Archive test results for Maven artifact 
org.apache.sling:org.apache.sling.launchpad.testing-war:slingstart:12-SNAPSHOT 
generated by maven-surefire-plugin:test (default-test): 
target/surefire-reports/*.xml
Recording test results
None of the test reports contained any result
[withMaven] junitPublisher - Archive test results for Maven artifact 
org.apache.sling:org.apache.sling.launchpad.testing-war:slingstart:12-SNAPSHOT 
generated by maven-failsafe-plugin:integration-test (default): 
target/failsafe-reports/*.xml
Recording test results
[DevOpticsMavenPublisher] dependencies consumed: 431, artifacts produced: 0
[withMaven] Publishers: Pipeline Graph Publisher: 2 ms, Generated Artifacts 
Publisher: 175 ms, Junit Publisher: 78139 ms, Dependencies Fingerprint 
Publisher: 1737 ms, Open Task Scanner Publisher: 173 ms, CloudBees DevOptics 
Gate Artifact Publisher: 153246 ms
[Pipeline] // withMaven
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
[Pipeline] // timeout
[Pipeline] stage
[Pipeline] { (Notifications)
[Pipeline] echo
Status change is BROKEN, notifications will be sent.
[Pipeline] emailext

[GitHub] [sling-parent] sonarcloud[bot] commented on pull request #10: SLING-7534 generate sha-512 hashes by default and also attach to build

2020-08-10 Thread GitBox


sonarcloud[bot] commented on pull request #10:
URL: https://github.com/apache/sling-parent/pull/10#issuecomment-671556060


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-parent=10=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-parent=10=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-parent=10=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-parent=10=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-parent=10=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-parent=10=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_sling-parent=10=false=SECURITY_HOTSPOT)
 [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_slin
 g-parent=10=false=SECURITY_HOTSPOT) to review)  
   [](https://sonarcloud.io/project/issues?id=apache_sling-parent=10=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-parent=10=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-parent=10=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-parent=10)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_sling-parent=10=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-parent=10=new_duplicated_lines_density=list)
   
The version of Java (1.8.0_252) you 
have used to run this analysis is deprecated and we will stop accepting it from 
October 2020. Please update to at least Java 11.
   Read more [here](https://sonarcloud.io/documentation/upcoming/)
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [sling-org-apache-sling-launchpad-integration-tests] sonarcloud[bot] commented on pull request #1: [SLING-9417] Added test for an nt:file child of a versioned node

2020-08-10 Thread GitBox


sonarcloud[bot] commented on pull request #1:
URL: 
https://github.com/apache/sling-org-apache-sling-launchpad-integration-tests/pull/1#issuecomment-671555879


   SonarCloud Quality Gate failed.
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-integration-tests=1=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-integration-tests=1=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-integration-tests=1=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-integration-tests=1=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-integration-tests=1=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-integration-tests=1=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launch
 pad-integration-tests=1=false=SECURITY_HOTSPOT) [0 
Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-integration-tests=1=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-integration-tests=1=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-integration-tests=1=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-integration-tests=1=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-launchpad-integration-tests=1=new_coverage=list)
 [0.0% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-launchpad-integration-tests=1=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-launchpad-integration-tests=1=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-launchpad-integration-tests=1=new_duplicated_lines_density=list)
   
The version of Java (1.8.0_252) you 
have used to run this analysis is deprecated and we will stop accepting it from 
October 2020. Please update to at least Java 11.
   Read more [here](https://sonarcloud.io/documentation/upcoming/)
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [sling-org-apache-sling-launchpad-integration-tests] sonarcloud[bot] removed a comment on pull request #1: [SLING-9417] Added test for an nt:file child of a versioned node

2020-08-10 Thread GitBox


sonarcloud[bot] removed a comment on pull request #1:
URL: 
https://github.com/apache/sling-org-apache-sling-launchpad-integration-tests/pull/1#issuecomment-670997838


   SonarCloud Quality Gate failed.
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-integration-tests=1=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-integration-tests=1=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-integration-tests=1=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-integration-tests=1=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-integration-tests=1=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-integration-tests=1=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launch
 pad-integration-tests=1=false=SECURITY_HOTSPOT) [0 
Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-integration-tests=1=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-integration-tests=1=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-integration-tests=1=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-integration-tests=1=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-launchpad-integration-tests=1=new_coverage=list)
 [0.0% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-launchpad-integration-tests=1=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-launchpad-integration-tests=1=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-launchpad-integration-tests=1=new_duplicated_lines_density=list)
   
The version of Java (1.8.0_252) you 
have used to run this analysis is deprecated and we will stop accepting it from 
October 2020. Please update to at least Java 11.
   Read more [here](https://sonarcloud.io/documentation/upcoming/)
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [sling-org-apache-sling-distribution-core] sonarcloud[bot] commented on pull request #32: SLING-8994 Optimize session saves for Single Queue Dispatching Strategy

2020-08-10 Thread GitBox


sonarcloud[bot] commented on pull request #32:
URL: 
https://github.com/apache/sling-org-apache-sling-distribution-core/pull/32#issuecomment-671551952


   SonarCloud Quality Gate failed.
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-core=32=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-core=32=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-core=32=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-core=32=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-core=32=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-core=32=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-core=32;
 resolved=false=SECURITY_HOTSPOT) [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-core=32=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-core=32=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-core=32=false=CODE_SMELL)
 [3 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-core=32=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-distribution-core=32=new_coverage=list)
 [71.1% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-distribution-core=32=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-distribution-core=32=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-distribution-core=32=new_duplicated_lines_density=list)
   
The version of Java (1.8.0_252) you 
have used to run this analysis is deprecated and we will stop accepting it from 
October 2020. Please update to at least Java 11.
   Read more [here](https://sonarcloud.io/documentation/upcoming/)
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [sling-org-apache-sling-distribution-core] sonarcloud[bot] commented on pull request #33: SLING-9017 ErrorQueueDispatchingStrategy ends up using an incorrect …

2020-08-10 Thread GitBox


sonarcloud[bot] commented on pull request #33:
URL: 
https://github.com/apache/sling-org-apache-sling-distribution-core/pull/33#issuecomment-671551447


   SonarCloud Quality Gate failed.
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-core=33=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-core=33=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-core=33=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-core=33=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-core=33=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-core=33=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-core=33;
 resolved=false=SECURITY_HOTSPOT) [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-core=33=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-core=33=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-core=33=false=CODE_SMELL)
 [3 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-core=33=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-distribution-core=33=new_coverage=list)
 [41.2% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-distribution-core=33=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-distribution-core=33=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-distribution-core=33=new_duplicated_lines_density=list)
   
The version of Java (1.8.0_252) you 
have used to run this analysis is deprecated and we will stop accepting it from 
October 2020. Please update to at least Java 11.
   Read more [here](https://sonarcloud.io/documentation/upcoming/)
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [sling-org-apache-sling-superimposing] sonarcloud[bot] commented on pull request #1: API Upgrade

2020-08-10 Thread GitBox


sonarcloud[bot] commented on pull request #1:
URL: 
https://github.com/apache/sling-org-apache-sling-superimposing/pull/1#issuecomment-671551528


   SonarCloud Quality Gate failed.
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-superimposing=1=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-superimposing=1=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-superimposing=1=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-superimposing=1=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-superimposing=1=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-superimposing=1=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-superimposing=1=false
 =SECURITY_HOTSPOT) [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-superimposing=1=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-superimposing=1=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-superimposing=1=false=CODE_SMELL)
 [10 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-superimposing=1=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-superimposing=1=new_coverage=list)
 [45.7% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-superimposing=1=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-superimposing=1=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-superimposing=1=new_duplicated_lines_density=list)
   
The version of Java (1.8.0_252) you 
have used to run this analysis is deprecated and we will stop accepting it from 
October 2020. Please update to at least Java 11.
   Read more [here](https://sonarcloud.io/documentation/upcoming/)
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [sling-org-apache-sling-distribution-core] sonarcloud[bot] commented on pull request #11: Adding Proxy Configuration if available

2020-08-10 Thread GitBox


sonarcloud[bot] commented on pull request #11:
URL: 
https://github.com/apache/sling-org-apache-sling-distribution-core/pull/11#issuecomment-671551542


   SonarCloud Quality Gate failed.
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-core=11=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-core=11=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-core=11=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-core=11=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-core=11=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-core=11=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-core=11;
 resolved=false=SECURITY_HOTSPOT) [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-core=11=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-core=11=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-core=11=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-core=11=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-distribution-core=11=new_coverage=list)
 [16.7% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-distribution-core=11=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-distribution-core=11=new_duplicated_lines_density=list)
 [8.7% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-distribution-core=11=new_duplicated_lines_density=list)
   
The version of Java (1.8.0_252) you 
have used to run this analysis is deprecated and we will stop accepting it from 
October 2020. Please update to at least Java 11.
   Read more [here](https://sonarcloud.io/documentation/upcoming/)
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [sling-org-apache-sling-query] sonarcloud[bot] commented on pull request #3: SLING-9600 Updated commons-lang to commons-lang3

2020-08-10 Thread GitBox


sonarcloud[bot] commented on pull request #3:
URL: 
https://github.com/apache/sling-org-apache-sling-query/pull/3#issuecomment-671551230


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-query=3=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-query=3=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-query=3=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-query=3=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-query=3=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-query=3=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-query=3=false=SECURITY_HOTSPOT)
 [0 Security H
 
otspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-query=3=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-query=3=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-query=3=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-query=3=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-query=3=coverage=list)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-query=3=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-query=3=new_duplicated_lines_density=list)
   
The version of Java (1.8.0_252) you 
have used to run this analysis is deprecated and we will stop accepting it from 
October 2020. Please update to at least Java 11.
   Read more [here](https://sonarcloud.io/documentation/upcoming/)
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [sling-org-apache-sling-rewriter] sonarcloud[bot] commented on pull request #2: ProcessorManagerImpl - consistent code format + remove obvious (and private) comments

2020-08-10 Thread GitBox


sonarcloud[bot] commented on pull request #2:
URL: 
https://github.com/apache/sling-org-apache-sling-rewriter/pull/2#issuecomment-671551118


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-rewriter=2=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-rewriter=2=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-rewriter=2=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-rewriter=2=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-rewriter=2=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-rewriter=2=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-rewriter=2=false=SECURITY_HOTSPOT)
 [
 0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-rewriter=2=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-rewriter=2=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-rewriter=2=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-rewriter=2=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-rewriter=2=coverage=list)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-rewriter=2=duplicated_lines_density=list)
 No Duplication information
   
The version of Java (1.8.0_252) you 
have used to run this analysis is deprecated and we will stop accepting it from 
October 2020. Please update to at least Java 11.
   Read more [here](https://sonarcloud.io/documentation/upcoming/)
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [sling-org-apache-sling-query] sonarcloud[bot] removed a comment on pull request #3: SLING-9600 Updated commons-lang to commons-lang3

2020-08-10 Thread GitBox


sonarcloud[bot] removed a comment on pull request #3:
URL: 
https://github.com/apache/sling-org-apache-sling-query/pull/3#issuecomment-663150640


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-query=3=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-query=3=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-query=3=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-query=3=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-query=3=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-query=3=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-query=3=false=SECURITY_HOTSPOT)
 [0 Security H
 
otspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-query=3=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-query=3=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-query=3=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-query=3=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-query=3=coverage=list)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-query=3=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-query=3=new_duplicated_lines_density=list)
   
The version of Java (1.8.0_252) you 
have used to run this analysis is deprecated and we will stop accepting it from 
October 2020. Please update to at least Java 11.
   Read more [here](https://sonarcloud.io/documentation/upcoming/)
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [sling-org-apache-sling-dynamic-include] sonarcloud[bot] commented on pull request #14: SLING-9174: Added the code for enhancement

2020-08-10 Thread GitBox


sonarcloud[bot] commented on pull request #14:
URL: 
https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/14#issuecomment-671550933


   SonarCloud Quality Gate failed.
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include=14=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include=14=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include=14=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include=14=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include=14=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include=14=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include=14
 =false=SECURITY_HOTSPOT) [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include=14=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include=14=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include=14=false=CODE_SMELL)
 [3 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include=14=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-dynamic-include=14=new_coverage=list)
 [45.2% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-dynamic-include=14=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-dynamic-include=14=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-dynamic-include=14=new_duplicated_lines_density=list)
   
The version of Java (1.8.0_252) you 
have used to run this analysis is deprecated and we will stop accepting it from 
October 2020. Please update to at least Java 11.
   Read more [here](https://sonarcloud.io/documentation/upcoming/)
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [sling-org-apache-sling-dynamic-include] sonarcloud[bot] commented on pull request #9: Fix documentation for httpd config

2020-08-10 Thread GitBox


sonarcloud[bot] commented on pull request #9:
URL: 
https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/9#issuecomment-671550769


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include=9=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include=9=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include=9=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include=9=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include=9=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include=9=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include=9=fal
 se=SECURITY_HOTSPOT) [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include=9=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include=9=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include=9=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include=9=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-dynamic-include=9=coverage=list)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-dynamic-include=9=duplicated_lines_density=list)
 No Duplication information
   
The version of Java (1.8.0_252) you 
have used to run this analysis is deprecated and we will stop accepting it from 
October 2020. Please update to at least Java 11.
   Read more [here](https://sonarcloud.io/documentation/upcoming/)
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [sling-org-apache-sling-event] sonarcloud[bot] commented on pull request #4: SLING-8295 - injecting coverage command via Abstract IT vmOptions

2020-08-10 Thread GitBox


sonarcloud[bot] commented on pull request #4:
URL: 
https://github.com/apache/sling-org-apache-sling-event/pull/4#issuecomment-671549978


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event=4=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event=4=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event=4=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event=4=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event=4=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event=4=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event=4=false=SECURITY_HOTSPOT)
 [0 Security H
 
otspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event=4=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event=4=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event=4=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event=4=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-event=4=coverage=list)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-event=4=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-event=4=new_duplicated_lines_density=list)
   
The version of Java (1.8.0_252) you 
have used to run this analysis is deprecated and we will stop accepting it from 
October 2020. Please update to at least Java 11.
   Read more [here](https://sonarcloud.io/documentation/upcoming/)
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [sling-org-apache-sling-servlets-resolver] sonarcloud[bot] commented on pull request #7: [SLING-9230] - Servlet should not be allowed to register with invalid…

2020-08-10 Thread GitBox


sonarcloud[bot] commented on pull request #7:
URL: 
https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/7#issuecomment-671549234


   SonarCloud Quality Gate failed.
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=7=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=7=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=7=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=7=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=7=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=7=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=7
 lved=false=SECURITY_HOTSPOT) [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=7=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=7=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=7=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=7=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver=7=new_coverage=list)
 [70.0% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver=7=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver=7=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver=7=new_duplicated_lines_density=list)
   
The version of Java (1.8.0_252) you 
have used to run this analysis is deprecated and we will stop accepting it from 
October 2020. Please update to at least Java 11.
   Read more [here](https://sonarcloud.io/documentation/upcoming/)
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [sling-org-apache-sling-distribution-api] sonarcloud[bot] commented on pull request #7: SLING-9389: Distribution Event Properties enhanced for holding queue item creation time stamp

2020-08-10 Thread GitBox


sonarcloud[bot] commented on pull request #7:
URL: 
https://github.com/apache/sling-org-apache-sling-distribution-api/pull/7#issuecomment-671548752


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-api=7=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-api=7=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-api=7=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-api=7=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-api=7=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-api=7=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-api=7
 =false=SECURITY_HOTSPOT) [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-api=7=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-api=7=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-api=7=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-api=7=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-distribution-api=7=coverage=list)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-distribution-api=7=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-distribution-api=7=new_duplicated_lines_density=list)
   
The version of Java (1.8.0_252) you 
have used to run this analysis is deprecated and we will stop accepting it from 
October 2020. Please update to at least Java 11.
   Read more [here](https://sonarcloud.io/documentation/upcoming/)
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [sling-org-apache-sling-scripting-sightly-models-provider] sonarcloud[bot] commented on pull request #1: Allow an adaptable argument

2020-08-10 Thread GitBox


sonarcloud[bot] commented on pull request #1:
URL: 
https://github.com/apache/sling-org-apache-sling-scripting-sightly-models-provider/pull/1#issuecomment-671546217


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-models-provider=1=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-models-provider=1=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-models-provider=1=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-models-provider=1=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-models-provider=1=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-models-provider=1=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_sling-org-a
 
pache-sling-scripting-sightly-models-provider=1=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-models-provider=1=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-models-provider=1=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-models-provider=1=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-models-provider=1=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly-models-provider=1=new_coverage=list)
 [0.0% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly-models-provider=1=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly-models-provider=1=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly-models-provider=1=new_duplicated_lines_density=list)
   
The version of Java (1.8.0_252) you 
have used to run this analysis is deprecated and we will stop accepting it from 
October 2020. Please update to at least Java 11.
   Read more [here](https://sonarcloud.io/documentation/upcoming/)
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [sling-org-apache-sling-resourceresolver] sonarcloud[bot] commented on pull request #18: SLING-9620 ResourceMapperImpl.getAllMappings does not respect multi-valued sling:alias

2020-08-10 Thread GitBox


sonarcloud[bot] commented on pull request #18:
URL: 
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/18#issuecomment-671545274


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=18=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=18=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=18=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=18=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=18=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=18=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=18
 lved=false=SECURITY_HOTSPOT) [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=18=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=18=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=18=false=CODE_SMELL)
 [5 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=18=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=18=new_coverage=list)
 [85.7% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=18=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=18=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=18=new_duplicated_lines_density=list)
   
The version of Java (1.8.0_252) you 
have used to run this analysis is deprecated and we will stop accepting it from 
October 2020. Please update to at least Java 11.
   Read more [here](https://sonarcloud.io/documentation/upcoming/)
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [sling-org-apache-sling-resourceresolver] sonarcloud[bot] removed a comment on pull request #18: SLING-9620 ResourceMapperImpl.getAllMappings does not respect multi-valued sling:alias

2020-08-10 Thread GitBox


sonarcloud[bot] removed a comment on pull request #18:
URL: 
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/18#issuecomment-670579047


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=18=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=18=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=18=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=18=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=18=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=18=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=18
 lved=false=SECURITY_HOTSPOT) [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=18=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=18=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=18=false=CODE_SMELL)
 [5 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=18=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=18=new_coverage=list)
 [85.7% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=18=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=18=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=18=new_duplicated_lines_density=list)
   
The version of Java (1.8.0_252) you 
have used to run this analysis is deprecated and we will stop accepting it from 
October 2020. Please update to at least Java 11.
   Read more [here](https://sonarcloud.io/documentation/upcoming/)
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [sling-org-apache-sling-jcr-oak-server] sonarcloud[bot] commented on pull request #2: SLING-8309: Allow adding CommitHooks and EditorProviders dynamically from bundles

2020-08-10 Thread GitBox


sonarcloud[bot] commented on pull request #2:
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-oak-server/pull/2#issuecomment-671544376


   SonarCloud Quality Gate failed.
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-oak-server=2=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-oak-server=2=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-oak-server=2=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-oak-server=2=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-oak-server=2=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-oak-server=2=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-oak-server=2=false
 ypes=SECURITY_HOTSPOT) [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-oak-server=2=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-oak-server=2=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-oak-server=2=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-oak-server=2=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-oak-server=2=new_coverage=list)
 [0.0% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-oak-server=2=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-oak-server=2=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-oak-server=2=new_duplicated_lines_density=list)
   
The version of Java (1.8.0_252) you 
have used to run this analysis is deprecated and we will stop accepting it from 
October 2020. Please update to at least Java 11.
   Read more [here](https://sonarcloud.io/documentation/upcoming/)
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [sling-org-apache-sling-models-impl] sonarcloud[bot] commented on pull request #17: SLING-8706 - Injections for java.util.Optional<> should be automatically optional

2020-08-10 Thread GitBox


sonarcloud[bot] commented on pull request #17:
URL: 
https://github.com/apache/sling-org-apache-sling-models-impl/pull/17#issuecomment-671542559


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl=17=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl=17=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl=17=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl=17=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl=17=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl=17=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl=17=false=SEC
 URITY_HOTSPOT) [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl=17=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl=17=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl=17=false=CODE_SMELL)
 [2 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl=17=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-impl=17=new_coverage=list)
 [89.7% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-impl=17=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-impl=17=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-impl=17=new_duplicated_lines_density=list)
   
The version of Java (1.8.0_252) you 
have used to run this analysis is deprecated and we will stop accepting it from 
October 2020. Please update to at least Java 11.
   Read more [here](https://sonarcloud.io/documentation/upcoming/)
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [sling-org-apache-sling-discovery-base] sonarcloud[bot] commented on pull request #2: Update TopologyRequestValidator.java

2020-08-10 Thread GitBox


sonarcloud[bot] commented on pull request #2:
URL: 
https://github.com/apache/sling-org-apache-sling-discovery-base/pull/2#issuecomment-671542198


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-base=2=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-base=2=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-base=2=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-base=2=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-base=2=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-base=2=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-base=2=false
 ypes=SECURITY_HOTSPOT) [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-base=2=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-base=2=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-base=2=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-base=2=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-discovery-base=2=coverage=list)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-discovery-base=2=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-discovery-base=2=new_duplicated_lines_density=list)
   
The version of Java (1.8.0_252) you 
have used to run this analysis is deprecated and we will stop accepting it from 
October 2020. Please update to at least Java 11.
   Read more [here](https://sonarcloud.io/documentation/upcoming/)
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [sling-org-apache-sling-i18n] sonarcloud[bot] commented on pull request #2: SLING-8802 JcrResourceBundle should not consider dictionaries with a …

2020-08-10 Thread GitBox


sonarcloud[bot] commented on pull request #2:
URL: 
https://github.com/apache/sling-org-apache-sling-i18n/pull/2#issuecomment-671541292


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-i18n=2=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-i18n=2=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-i18n=2=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-i18n=2=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-i18n=2=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-i18n=2=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-i18n=2=false=SECURITY_HOTSPOT)
 [0 Security Hotsp
 
ots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-i18n=2=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-i18n=2=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-i18n=2=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-i18n=2=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-i18n=2=new_coverage=list)
 [90.0% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-i18n=2=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-i18n=2=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-i18n=2=new_duplicated_lines_density=list)
   
The version of Java (1.8.0_252) you 
have used to run this analysis is deprecated and we will stop accepting it from 
October 2020. Please update to at least Java 11.
   Read more [here](https://sonarcloud.io/documentation/upcoming/)
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [sling-org-apache-sling-models-jacksonexporter] sonarcloud[bot] commented on pull request #1: SLING-8452 migrate to OSGi R6 annotations

2020-08-10 Thread GitBox


sonarcloud[bot] commented on pull request #1:
URL: 
https://github.com/apache/sling-org-apache-sling-models-jacksonexporter/pull/1#issuecomment-671539763


   SonarCloud Quality Gate failed.
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-jacksonexporter=1=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-jacksonexporter=1=false=BUG)
 [1 
Bug](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-jacksonexporter=1=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-jacksonexporter=1=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-jacksonexporter=1=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-jacksonexporter=1=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-jacksonexporte
 r=1=false=SECURITY_HOTSPOT) [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-jacksonexporter=1=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-jacksonexporter=1=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-jacksonexporter=1=false=CODE_SMELL)
 [1 Code 
Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-jacksonexporter=1=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-jacksonexporter=1=new_coverage=list)
 [0.0% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-jacksonexporter=1=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-jacksonexporter=1=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-jacksonexporter=1=new_duplicated_lines_density=list)
   
The version of Java (1.8.0_252) you 
have used to run this analysis is deprecated and we will stop accepting it from 
October 2020. Please update to at least Java 11.
   Read more [here](https://sonarcloud.io/documentation/upcoming/)
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [sling-org-apache-sling-models-api] sonarcloud[bot] commented on pull request #2: SLING-8655 - Added the Externalized Path Annotation and Provider inte…

2020-08-10 Thread GitBox


sonarcloud[bot] commented on pull request #2:
URL: 
https://github.com/apache/sling-org-apache-sling-models-api/pull/2#issuecomment-671539025


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-api=2=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-api=2=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-api=2=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-api=2=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-api=2=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-api=2=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-api=2=false=SECURITY_HO
 TSPOT) [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-api=2=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-api=2=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-api=2=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-api=2=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-api=2=coverage=list)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-api=2=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-api=2=new_duplicated_lines_density=list)
   
The version of Java (1.8.0_252) you 
have used to run this analysis is deprecated and we will stop accepting it from 
October 2020. Please update to at least Java 11.
   Read more [here](https://sonarcloud.io/documentation/upcoming/)
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [sling-org-apache-sling-event-api] sonarcloud[bot] commented on pull request #1: SLING-5884 : deprecate job queries, introduce query-free JobManager2,…

2020-08-10 Thread GitBox


sonarcloud[bot] commented on pull request #1:
URL: 
https://github.com/apache/sling-org-apache-sling-event-api/pull/1#issuecomment-671537083


   SonarCloud Quality Gate failed.
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event-api=1=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event-api=1=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event-api=1=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event-api=1=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event-api=1=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event-api=1=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event-api=1=false=SECURITY_HOTSPO
 T) [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event-api=1=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event-api=1=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event-api=1=false=CODE_SMELL)
 [6 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event-api=1=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-event-api=1=coverage=list)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-event-api=1=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-event-api=1=new_duplicated_lines_density=list)
   
The version of Java (1.8.0_252) you 
have used to run this analysis is deprecated and we will stop accepting it from 
October 2020. Please update to at least Java 11.
   Read more [here](https://sonarcloud.io/documentation/upcoming/)
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [sling-org-apache-sling-caconfig-spi] sonarcloud[bot] commented on pull request #1: SLING-8849 Added a ConfigurationBindingsResourceDetectionStrategy that can be used to detect a Resource bas

2020-08-10 Thread GitBox


sonarcloud[bot] commented on pull request #1:
URL: 
https://github.com/apache/sling-org-apache-sling-caconfig-spi/pull/1#issuecomment-671536636


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-spi=1=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-spi=1=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-spi=1=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-spi=1=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-spi=1=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-spi=1=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-spi=1=false=SEC
 URITY_HOTSPOT) [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-spi=1=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-spi=1=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-spi=1=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-spi=1=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-caconfig-spi=1=coverage=list)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-caconfig-spi=1=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-caconfig-spi=1=new_duplicated_lines_density=list)
   
The version of Java (1.8.0_252) you 
have used to run this analysis is deprecated and we will stop accepting it from 
October 2020. Please update to at least Java 11.
   Read more [here](https://sonarcloud.io/documentation/upcoming/)
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [sling-org-apache-sling-discovery-support] sonarcloud[bot] removed a comment on pull request #1: SLING-9589 : expose discovery metrics

2020-08-10 Thread GitBox


sonarcloud[bot] removed a comment on pull request #1:
URL: 
https://github.com/apache/sling-org-apache-sling-discovery-support/pull/1#issuecomment-658877784


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-support=1=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-support=1=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-support=1=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-support=1=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-support=1=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-support=1=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-support=1
 lved=false=SECURITY_HOTSPOT) [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-support=1=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-support=1=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-support=1=false=CODE_SMELL)
 [19 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-support=1=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-discovery-support=1=new_coverage=list)
 [94.6% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-discovery-support=1=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-discovery-support=1=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-discovery-support=1=new_duplicated_lines_density=list)
   
The version of Java (1.8.0_252) you 
have used to run this analysis is deprecated and we will stop accepting it from 
October 2020. Please update to at least Java 11.
   Read more [here](https://sonarcloud.io/documentation/upcoming/)
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [sling-org-apache-sling-discovery-support] sonarcloud[bot] commented on pull request #1: SLING-9589 : expose discovery metrics

2020-08-10 Thread GitBox


sonarcloud[bot] commented on pull request #1:
URL: 
https://github.com/apache/sling-org-apache-sling-discovery-support/pull/1#issuecomment-671536663


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-support=1=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-support=1=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-support=1=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-support=1=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-support=1=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-support=1=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-support=1
 lved=false=SECURITY_HOTSPOT) [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-support=1=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-support=1=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-support=1=false=CODE_SMELL)
 [19 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-support=1=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-discovery-support=1=new_coverage=list)
 [94.6% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-discovery-support=1=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-discovery-support=1=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-discovery-support=1=new_duplicated_lines_density=list)
   
The version of Java (1.8.0_252) you 
have used to run this analysis is deprecated and we will stop accepting it from 
October 2020. Please update to at least Java 11.
   Read more [here](https://sonarcloud.io/documentation/upcoming/)
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




Re: Sling GraphQL

2020-08-10 Thread Radu Cotescu
Hi Bertrand,

> On 10 Aug 2020, at 11:14, Bertrand Delacretaz  wrote:
> 
> So a complete scenario could be like
> 
> 1. Client wants to run a query with digest cf81d4 (computed according
> to a definition that we publish)
> 2. Client GETs /prepared/cf81d4.json and receives a 404 as the query
> store is empty
> 3. Client POSTs the query to /prepared and receives a 201 created
> /prepared/cf81d4.json
> 4. Client GETs /prepared/cf81d4.json and receives the results along
> with ETag and Cache-Control headers which allow a front-end HTTP cache
> to store it
> 5. Later, the same or another client GETs /prepared/cf81d4.json
> through the HTTP cache, which based on headers received at 4. serves
> results from cache and does not touch Sling
> 6. Later, the same or another client GETs /prepared/cf81d4.json, the
> results caching period expired but Sling still has that query stored,
> so it runs the query again and returns a new ETag
> 7. If a request comes later with an expired cache and the cf81d4 query
> has been purged, Sling returns a 404 and the client has to start over
> a 2.

Ok. I thought you had proposed that we’d purge the query once we consider the 
results to be stale, but now I see what you mean. The prepared query can very 
well outlive the results.

I think it’s a good design to rely on existing caching layers and leave the 
path open for application-level caching, if we’d ever need that.

Thanks,
Radu

[VOTE] Release Apache Sling testing Clients version 2.0.2

2020-08-10 Thread Andrei Dulvac
Hi,

We solved 2 issues in this release:
https://issues.apache.org/jira/projects/SLING/versions/12348058


Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2316

You can use this UNIX script to download the release and verify the
signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD


Usage:
sh check_staged_release.sh 2316 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.\

- Andrei


[jira] [Resolved] (SLING-9647) [Testing Clients] Store request and response on a ClientException

2020-08-10 Thread Andrei Dulvac (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-9647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrei Dulvac resolved SLING-9647.
--
Resolution: Fixed

> [Testing Clients] Store request and response on  a ClientException 
> ---
>
> Key: SLING-9647
> URL: https://issues.apache.org/jira/browse/SLING-9647
> Project: Sling
>  Issue Type: Improvement
>  Components: Apache Sling Testing Clients
>Affects Versions: Apache Sling Testing Clients 2.0.0
>Reporter: Andrei Dulvac
>Assignee: Andrei Dulvac
>Priority: Minor
> Fix For: Apache Sling Testing Clients 2.0.2
>
>
> Allow for ClientException to optionally store the request and response. This 
> would be useful for logging them as part of exception handling



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Re: Sling GraphQL

2020-08-10 Thread Bertrand Delacretaz
Hi Andreea,

On Mon, Aug 10, 2020 at 3:06 PM Andreea Miruna Moise
 wrote:
> ...The queries run in authenticated environment and if the CDN does not 
> support private caching
> then I guess it has to be supported by sling right?...

I would just mark such responses with "Cache-Control:private" to allow
clients to cache them privately according to other cache headers.
Considering the they are responses to plain GET requests, browsers
should treat them in the same as non-GraphQL web content.

-Bertrand

[1] https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Cache-Control


[jira] [Commented] (SLING-9648) SlingPropertiesPrinter fails to activate: No bundle context property 'sling.properties.url' provided

2020-08-10 Thread Konrad Windszus (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-9648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174341#comment-17174341
 ] 

Konrad Windszus commented on SLING-9648:


bq. there is no sling.properties file by default
I know but still if there would be one below conf/sling.properties all those 
entries would be used as framework properties. So there is  IMHO still support 
for sling.properties in the launcher.

> SlingPropertiesPrinter fails to activate: No bundle context property 
> 'sling.properties.url' provided
> 
>
> Key: SLING-9648
> URL: https://issues.apache.org/jira/browse/SLING-9648
> Project: Sling
>  Issue Type: Bug
>Reporter: Robert Munteanu
>Priority: Major
> Fix For: Settings 1.4.2
>
>
> When starting up the Sling Starter I see the following error printed on the 
> console:
> {noformat}ERROR: bundle org.apache.sling.settings:1.4.0 
> (22)[org.apache.sling.settings.impl.SlingPropertiesPrinter(1)] :  Error 
> during instantiation of the implementation object
> java.lang.reflect.InvocationTargetException
>   at 
> java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native
>  Method)
>   at 
> java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
>   at 
> java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
>   at 
> java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:490)
>   at 
> org.apache.felix.scr.impl.inject.internal.ComponentConstructorImpl.newInstance(ComponentConstructorImpl.java:312)
>   at 
> org.apache.felix.scr.impl.manager.SingleComponentManager.createImplementationObject(SingleComponentManager.java:279)
>   at 
> org.apache.felix.scr.impl.manager.SingleComponentManager.createComponent(SingleComponentManager.java:115)
>   at 
> org.apache.felix.scr.impl.manager.SingleComponentManager.getService(SingleComponentManager.java:984)
>   at 
> org.apache.felix.scr.impl.manager.SingleComponentManager.getServiceInternal(SingleComponentManager.java:957)
>   at 
> org.apache.felix.scr.impl.manager.SingleComponentManager.getService(SingleComponentManager.java:902)
>   at 
> org.apache.felix.framework.ServiceRegistrationImpl.getFactoryUnchecked(ServiceRegistrationImpl.java:348)
>   at 
> org.apache.felix.framework.ServiceRegistrationImpl.getService(ServiceRegistrationImpl.java:248)
>   at 
> org.apache.felix.framework.ServiceRegistry.getService(ServiceRegistry.java:350)
>   at org.apache.felix.framework.Felix.getService(Felix.java:3954)
>   at 
> org.apache.felix.framework.BundleContextImpl.getService(BundleContextImpl.java:450)
>   at 
> org.apache.felix.inventory.impl.webconsole.WebConsoleAdapter.addingService(WebConsoleAdapter.java:152)
>   at 
> org.osgi.util.tracker.ServiceTracker$Tracked.customizerAdding(ServiceTracker.java:943)
>   at 
> org.osgi.util.tracker.ServiceTracker$Tracked.customizerAdding(ServiceTracker.java:871)
>   at 
> org.osgi.util.tracker.AbstractTracked.trackAdding(AbstractTracked.java:256)
>   at 
> org.osgi.util.tracker.AbstractTracked.trackInitial(AbstractTracked.java:183)
>   at org.osgi.util.tracker.ServiceTracker.open(ServiceTracker.java:321)
>   at org.osgi.util.tracker.ServiceTracker.open(ServiceTracker.java:264)
>   at 
> org.apache.felix.inventory.impl.webconsole.WebConsoleAdapter.(WebConsoleAdapter.java:68)
>   at org.apache.felix.inventory.impl.Activator.start(Activator.java:63)
>   at 
> org.apache.felix.framework.util.SecureAction.startActivator(SecureAction.java:698)
>   at org.apache.felix.framework.Felix.activateBundle(Felix.java:2402)
>   at org.apache.felix.framework.Felix.startBundle(Felix.java:2308)
>   at org.apache.felix.framework.Felix.setActiveStartLevel(Felix.java:1539)
>   at 
> org.apache.felix.framework.FrameworkStartLevelImpl.run(FrameworkStartLevelImpl.java:308)
>   at java.base/java.lang.Thread.run(Thread.java:834)
> Caused by: java.lang.IllegalStateException: No bundle context property 
> 'sling.properties.url' provided
>   at 
> org.apache.sling.settings.impl.SlingPropertiesPrinter.(SlingPropertiesPrinter.java:64)
>   ... 30 more
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (SLING-9648) SlingPropertiesPrinter fails to activate: No bundle context property 'sling.properties.url' provided

2020-08-10 Thread Robert Munteanu (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-9648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174340#comment-17174340
 ] 

Robert Munteanu commented on SLING-9648:


[~kwin] - FWIW, there is no sling.properties file by default, I just launched 
the Starter to check.

Maybe [~kpauls]/[~davidb] would be able to comment.

> SlingPropertiesPrinter fails to activate: No bundle context property 
> 'sling.properties.url' provided
> 
>
> Key: SLING-9648
> URL: https://issues.apache.org/jira/browse/SLING-9648
> Project: Sling
>  Issue Type: Bug
>Reporter: Robert Munteanu
>Priority: Major
> Fix For: Settings 1.4.2
>
>
> When starting up the Sling Starter I see the following error printed on the 
> console:
> {noformat}ERROR: bundle org.apache.sling.settings:1.4.0 
> (22)[org.apache.sling.settings.impl.SlingPropertiesPrinter(1)] :  Error 
> during instantiation of the implementation object
> java.lang.reflect.InvocationTargetException
>   at 
> java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native
>  Method)
>   at 
> java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
>   at 
> java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
>   at 
> java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:490)
>   at 
> org.apache.felix.scr.impl.inject.internal.ComponentConstructorImpl.newInstance(ComponentConstructorImpl.java:312)
>   at 
> org.apache.felix.scr.impl.manager.SingleComponentManager.createImplementationObject(SingleComponentManager.java:279)
>   at 
> org.apache.felix.scr.impl.manager.SingleComponentManager.createComponent(SingleComponentManager.java:115)
>   at 
> org.apache.felix.scr.impl.manager.SingleComponentManager.getService(SingleComponentManager.java:984)
>   at 
> org.apache.felix.scr.impl.manager.SingleComponentManager.getServiceInternal(SingleComponentManager.java:957)
>   at 
> org.apache.felix.scr.impl.manager.SingleComponentManager.getService(SingleComponentManager.java:902)
>   at 
> org.apache.felix.framework.ServiceRegistrationImpl.getFactoryUnchecked(ServiceRegistrationImpl.java:348)
>   at 
> org.apache.felix.framework.ServiceRegistrationImpl.getService(ServiceRegistrationImpl.java:248)
>   at 
> org.apache.felix.framework.ServiceRegistry.getService(ServiceRegistry.java:350)
>   at org.apache.felix.framework.Felix.getService(Felix.java:3954)
>   at 
> org.apache.felix.framework.BundleContextImpl.getService(BundleContextImpl.java:450)
>   at 
> org.apache.felix.inventory.impl.webconsole.WebConsoleAdapter.addingService(WebConsoleAdapter.java:152)
>   at 
> org.osgi.util.tracker.ServiceTracker$Tracked.customizerAdding(ServiceTracker.java:943)
>   at 
> org.osgi.util.tracker.ServiceTracker$Tracked.customizerAdding(ServiceTracker.java:871)
>   at 
> org.osgi.util.tracker.AbstractTracked.trackAdding(AbstractTracked.java:256)
>   at 
> org.osgi.util.tracker.AbstractTracked.trackInitial(AbstractTracked.java:183)
>   at org.osgi.util.tracker.ServiceTracker.open(ServiceTracker.java:321)
>   at org.osgi.util.tracker.ServiceTracker.open(ServiceTracker.java:264)
>   at 
> org.apache.felix.inventory.impl.webconsole.WebConsoleAdapter.(WebConsoleAdapter.java:68)
>   at org.apache.felix.inventory.impl.Activator.start(Activator.java:63)
>   at 
> org.apache.felix.framework.util.SecureAction.startActivator(SecureAction.java:698)
>   at org.apache.felix.framework.Felix.activateBundle(Felix.java:2402)
>   at org.apache.felix.framework.Felix.startBundle(Felix.java:2308)
>   at org.apache.felix.framework.Felix.setActiveStartLevel(Felix.java:1539)
>   at 
> org.apache.felix.framework.FrameworkStartLevelImpl.run(FrameworkStartLevelImpl.java:308)
>   at java.base/java.lang.Thread.run(Thread.java:834)
> Caused by: java.lang.IllegalStateException: No bundle context property 
> 'sling.properties.url' provided
>   at 
> org.apache.sling.settings.impl.SlingPropertiesPrinter.(SlingPropertiesPrinter.java:64)
>   ... 30 more
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (SLING-9118) Sling fails to start when database exists but 'sling' directory is missing

2020-08-10 Thread Robert Munteanu (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-9118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-9118.

Fix Version/s: Starter 12
   Resolution: Fixed

[~carlosmunoz], [~benradey] - I'm going to consider this fixed since the fixes 
in org.apache.sling.jcr.base 3.1.4 are now included in the Sling Starter.

Please reopen if you still see the problem.

> Sling fails to start when database exists but 'sling' directory is missing
> --
>
> Key: SLING-9118
> URL: https://issues.apache.org/jira/browse/SLING-9118
> Project: Sling
>  Issue Type: Bug
>Reporter: Ben Radey
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Starter 12
>
> Attachments: drop-mongo.sh, error.log, fm-launch.zip, karaf.log, 
> recreateSlingReplicaSet.sh, run-mongo.sh, run-sling-initial.sh, 
> run-sling-second.sh, sling-startup-error.log.txt
>
>
> # Create a persistent mongodb to use with Sling.
>  # Start sling using the mongodb.
>  # Stop sling.
>  # Remove 'sling' directory.
>  # Attempt to restart sling. Ultimately, sling fails to start.
> 
> Steps to reproduce with attached scripts:
> # Run [^run-mongo.sh] . This creates a MongoDB 3.6 container named 
> _mongo-sling_
> # Run [^run-sling-initial.sh]. This starts up Sling in the oak_mongo runmode, 
> shuts it down after it's (probably) started up
> # Run [^run-sling-second.sh]. This moves away the sling directory and starts 
> up a new instance. This always fails
> For cleanup, the [^drop-mongo.sh] script stops and removes the _mongo-sling_ 
> container.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [sling-org-apache-sling-resourceresolver] rombert commented on a change in pull request #18: SLING-9620 ResourceMapperImpl.getAllMappings does not respect multi-valued sling:alias

2020-08-10 Thread GitBox


rombert commented on a change in pull request #18:
URL: 
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/18#discussion_r467898196



##
File path: 
src/test/java/org/apache/sling/resourceresolver/impl/mapping/PathGeneratorTest.java
##
@@ -0,0 +1,120 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.sling.resourceresolver.impl.mapping;
+
+import static java.util.Arrays.asList;
+import static java.util.Collections.emptyList;
+import static java.util.Collections.singletonList;
+import static org.junit.Assert.*;
+
+import java.util.List;
+
+import org.hamcrest.Matchers;
+import org.junit.Test;
+
+public class PathGeneratorTest {
+
+@Test
+public void rootPath() {
+
+List paths = new PathGenerator().generatePaths();
+
+assertThat(paths, Matchers.hasSize(1));
+assertThat(paths, Matchers.hasItem("/"));
+}
+
+@Test
+public void subPathWithMissingAliases() {
+
+PathGenerator builder = new PathGenerator();
+builder.insertSegment(singletonList(null), "bar");
+builder.insertSegment(singletonList(""), "foo");
+List paths = builder.generatePaths();
+
+assertThat(paths, Matchers.hasSize(1));
+assertThat(paths, Matchers.hasItem("/foo/bar"));
+}
+
+@Test
+public void subPathWithMixedAliases() {
+
+PathGenerator builder = new PathGenerator();
+builder.insertSegment(emptyList(), "bar");
+builder.insertSegment(singletonList("super"), "foo");
+List paths = builder.generatePaths();
+
+assertThat(paths, Matchers.hasSize(1));
+assertThat(paths, Matchers.hasItem("/super/bar"));
+}
+
+@Test
+public void subPathWithResolutionInfo() {
+
+PathGenerator builder = new PathGenerator();
+builder.insertSegment(emptyList(), "bar");
+builder.insertSegment(emptyList(), "foo");
+builder.setResolutionPathInfo("/baz");
+
+List paths = builder.generatePaths();
+
+assertThat(paths, Matchers.hasSize(1));
+assertThat(paths, Matchers.hasItem("/foo/bar/baz"));
+}
+
+@Test
+public void subPathWithMultipleAliases() {
+
+PathGenerator builder = new PathGenerator();
+builder.insertSegment(emptyList(), "bar");
+builder.insertSegment(asList("alias1", "alias2"), "foo");
+
+List paths = builder.generatePaths();
+
+assertThat(paths, Matchers.hasSize(2));
+assertThat(paths, Matchers.hasItems("/alias1/bar", "/alias2/bar"));

Review comment:
   The `PathGenerator` is a bit special-cased as it generates the 
path-based variant only if no other aliases exist. Would it be clearer it it 
only generated the alias-based combinations, as the node name only variant is 
already handled differently in the `ResourceMapperImpl`?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [sling-org-apache-sling-resourceresolver] jsedding commented on a change in pull request #18: SLING-9620 ResourceMapperImpl.getAllMappings does not respect multi-valued sling:alias

2020-08-10 Thread GitBox


jsedding commented on a change in pull request #18:
URL: 
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/18#discussion_r467896090



##
File path: 
src/test/java/org/apache/sling/resourceresolver/impl/mapping/PathGeneratorTest.java
##
@@ -0,0 +1,120 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.sling.resourceresolver.impl.mapping;
+
+import static java.util.Arrays.asList;
+import static java.util.Collections.emptyList;
+import static java.util.Collections.singletonList;
+import static org.junit.Assert.*;
+
+import java.util.List;
+
+import org.hamcrest.Matchers;
+import org.junit.Test;
+
+public class PathGeneratorTest {
+
+@Test
+public void rootPath() {
+
+List paths = new PathGenerator().generatePaths();
+
+assertThat(paths, Matchers.hasSize(1));
+assertThat(paths, Matchers.hasItem("/"));
+}
+
+@Test
+public void subPathWithMissingAliases() {
+
+PathGenerator builder = new PathGenerator();
+builder.insertSegment(singletonList(null), "bar");
+builder.insertSegment(singletonList(""), "foo");
+List paths = builder.generatePaths();
+
+assertThat(paths, Matchers.hasSize(1));
+assertThat(paths, Matchers.hasItem("/foo/bar"));
+}
+
+@Test
+public void subPathWithMixedAliases() {
+
+PathGenerator builder = new PathGenerator();
+builder.insertSegment(emptyList(), "bar");
+builder.insertSegment(singletonList("super"), "foo");
+List paths = builder.generatePaths();
+
+assertThat(paths, Matchers.hasSize(1));
+assertThat(paths, Matchers.hasItem("/super/bar"));
+}
+
+@Test
+public void subPathWithResolutionInfo() {
+
+PathGenerator builder = new PathGenerator();
+builder.insertSegment(emptyList(), "bar");
+builder.insertSegment(emptyList(), "foo");
+builder.setResolutionPathInfo("/baz");
+
+List paths = builder.generatePaths();
+
+assertThat(paths, Matchers.hasSize(1));
+assertThat(paths, Matchers.hasItem("/foo/bar/baz"));
+}
+
+@Test
+public void subPathWithMultipleAliases() {
+
+PathGenerator builder = new PathGenerator();
+builder.insertSegment(emptyList(), "bar");
+builder.insertSegment(asList("alias1", "alias2"), "foo");
+
+List paths = builder.generatePaths();
+
+assertThat(paths, Matchers.hasSize(2));
+assertThat(paths, Matchers.hasItems("/alias1/bar", "/alias2/bar"));

Review comment:
   @rombert What is the reason that `PathGenerator` does not generate 
permutations of the path including the node-name? I.e. I'd expect 
`Matchers.hasItems("/alias1/bar", "/alias2/bar", "/foo/bar")` (probably in this 
order, if the first entry is what should happen when mapping a resource path to 
a URL path).
   
   AFAIR the resource could be accessed by all three paths.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [sling-org-apache-sling-resourceresolver] jsedding commented on a change in pull request #18: SLING-9620 ResourceMapperImpl.getAllMappings does not respect multi-valued sling:alias

2020-08-10 Thread GitBox


jsedding commented on a change in pull request #18:
URL: 
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/18#discussion_r467896090



##
File path: 
src/test/java/org/apache/sling/resourceresolver/impl/mapping/PathGeneratorTest.java
##
@@ -0,0 +1,120 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.sling.resourceresolver.impl.mapping;
+
+import static java.util.Arrays.asList;
+import static java.util.Collections.emptyList;
+import static java.util.Collections.singletonList;
+import static org.junit.Assert.*;
+
+import java.util.List;
+
+import org.hamcrest.Matchers;
+import org.junit.Test;
+
+public class PathGeneratorTest {
+
+@Test
+public void rootPath() {
+
+List paths = new PathGenerator().generatePaths();
+
+assertThat(paths, Matchers.hasSize(1));
+assertThat(paths, Matchers.hasItem("/"));
+}
+
+@Test
+public void subPathWithMissingAliases() {
+
+PathGenerator builder = new PathGenerator();
+builder.insertSegment(singletonList(null), "bar");
+builder.insertSegment(singletonList(""), "foo");
+List paths = builder.generatePaths();
+
+assertThat(paths, Matchers.hasSize(1));
+assertThat(paths, Matchers.hasItem("/foo/bar"));
+}
+
+@Test
+public void subPathWithMixedAliases() {
+
+PathGenerator builder = new PathGenerator();
+builder.insertSegment(emptyList(), "bar");
+builder.insertSegment(singletonList("super"), "foo");
+List paths = builder.generatePaths();
+
+assertThat(paths, Matchers.hasSize(1));
+assertThat(paths, Matchers.hasItem("/super/bar"));
+}
+
+@Test
+public void subPathWithResolutionInfo() {
+
+PathGenerator builder = new PathGenerator();
+builder.insertSegment(emptyList(), "bar");
+builder.insertSegment(emptyList(), "foo");
+builder.setResolutionPathInfo("/baz");
+
+List paths = builder.generatePaths();
+
+assertThat(paths, Matchers.hasSize(1));
+assertThat(paths, Matchers.hasItem("/foo/bar/baz"));
+}
+
+@Test
+public void subPathWithMultipleAliases() {
+
+PathGenerator builder = new PathGenerator();
+builder.insertSegment(emptyList(), "bar");
+builder.insertSegment(asList("alias1", "alias2"), "foo");
+
+List paths = builder.generatePaths();
+
+assertThat(paths, Matchers.hasSize(2));
+assertThat(paths, Matchers.hasItems("/alias1/bar", "/alias2/bar"));

Review comment:
   @rombert What is the reason that `PathGenerator` does not generate 
permutations of the path including the node-name? I.e. I'd expect 
`Matchers.hasItems("/alias1/bar", "/alias2/bar", "/foo/bar")` (probably in this 
order, if the first entry is what should happen when mapping a resource path to 
a URL path).





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




Re: Sling GraphQL

2020-08-10 Thread Andreea Miruna Moise
Hi Radu and Bertrand,

The only thing left here is the private caching. The queries run in 
authenticated environment and if the CDN does not support private caching then 
I guess it has to be supported by sling right?

Regards,
Andreea

On 10/08/2020, 12:15, "Bertrand Delacretaz"  wrote:

Hi Radu,

On Mon, Aug 10, 2020 at 10:54 AM Radu Cotescu  wrote:
> > On 7 Aug 2020, at 16:18, Bertrand Delacretaz  
wrote:
...
> > 5) There's no guarantee on how long the prepared queries are stored, a
> > client that gets a 404 on a prepared query request must be prepared to
> > use the default POST request method or store the prepared query again
>
> Instead of replying with a 404 and asking the client to do another POST + 
GET, couldn’t we just return the
> updated results with updated cache headers?
> Judging by how you describe the algorithm, the Sling server would still 
have to maintain a cache internally...

I wasn't planning to store the query results on the Sling side, just
the query itself and enough information to be able to process
conditional HTTP requests.

So a complete scenario could be like

1. Client wants to run a query with digest cf81d4 (computed according
to a definition that we publish)
2. Client GETs /prepared/cf81d4.json and receives a 404 as the query
store is empty
3. Client POSTs the query to /prepared and receives a 201 created
/prepared/cf81d4.json
4. Client GETs /prepared/cf81d4.json and receives the results along
with ETag and Cache-Control headers which allow a front-end HTTP cache
to store it
5. Later, the same or another client GETs /prepared/cf81d4.json
through the HTTP cache, which based on headers received at 4. serves
results from cache and does not touch Sling
6. Later, the same or another client GETs /prepared/cf81d4.json, the
results caching period expired but Sling still has that query stored,
so it runs the query again and returns a new ETag
7. If a request comes later with an expired cache and the cf81d4 query
has been purged, Sling returns a 404 and the client has to start over
a 2.

With this scenario (assuming it works, your sanity check of that is
welcome) Sling just needs to store the queries, ETag and cache
expiration time, which I suppose is much less than query results?

-Bertrand




[jira] [Commented] (SLING-9648) SlingPropertiesPrinter fails to activate: No bundle context property 'sling.properties.url' provided

2020-08-10 Thread Konrad Windszus (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-9648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174311#comment-17174311
 ] 

Konrad Windszus commented on SLING-9648:


bq. The feature launcher does not have a sling.properties file, so what should 
this console display?

Hmm, what is this then: 
https://github.com/apache/sling-org-apache-sling-feature-launcher/blob/5c3c18a20e51b0773807da59262f9bf306427c41/src/main/java/org/apache/sling/feature/launcher/impl/Bootstrap.java#L92?
Is that for backwards compatibility? Why not exposing such file in the 
SlingPropertiesPrinter if it is supported and exist?  But currently 
{{sling.properties}} is not sufficient for the web console but 
{{sling.properties.url}} is needed.

I would suggest to proceed with two different improvements here:
# Make {{SlingPropertiesPrinter}} also capable of working just on top of 
{{sling.properties}} in case {{sling.properties.url}} is not set
# Instead of  managing the lifecycle of the service with DS revert to a 
BundleActivator again which takes care of registering the web console if the 
necessary properties are set.

[~cziegeler][[~rombert] WDYT?



> SlingPropertiesPrinter fails to activate: No bundle context property 
> 'sling.properties.url' provided
> 
>
> Key: SLING-9648
> URL: https://issues.apache.org/jira/browse/SLING-9648
> Project: Sling
>  Issue Type: Bug
>Reporter: Robert Munteanu
>Priority: Major
> Fix For: Settings 1.4.2
>
>
> When starting up the Sling Starter I see the following error printed on the 
> console:
> {noformat}ERROR: bundle org.apache.sling.settings:1.4.0 
> (22)[org.apache.sling.settings.impl.SlingPropertiesPrinter(1)] :  Error 
> during instantiation of the implementation object
> java.lang.reflect.InvocationTargetException
>   at 
> java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native
>  Method)
>   at 
> java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
>   at 
> java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
>   at 
> java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:490)
>   at 
> org.apache.felix.scr.impl.inject.internal.ComponentConstructorImpl.newInstance(ComponentConstructorImpl.java:312)
>   at 
> org.apache.felix.scr.impl.manager.SingleComponentManager.createImplementationObject(SingleComponentManager.java:279)
>   at 
> org.apache.felix.scr.impl.manager.SingleComponentManager.createComponent(SingleComponentManager.java:115)
>   at 
> org.apache.felix.scr.impl.manager.SingleComponentManager.getService(SingleComponentManager.java:984)
>   at 
> org.apache.felix.scr.impl.manager.SingleComponentManager.getServiceInternal(SingleComponentManager.java:957)
>   at 
> org.apache.felix.scr.impl.manager.SingleComponentManager.getService(SingleComponentManager.java:902)
>   at 
> org.apache.felix.framework.ServiceRegistrationImpl.getFactoryUnchecked(ServiceRegistrationImpl.java:348)
>   at 
> org.apache.felix.framework.ServiceRegistrationImpl.getService(ServiceRegistrationImpl.java:248)
>   at 
> org.apache.felix.framework.ServiceRegistry.getService(ServiceRegistry.java:350)
>   at org.apache.felix.framework.Felix.getService(Felix.java:3954)
>   at 
> org.apache.felix.framework.BundleContextImpl.getService(BundleContextImpl.java:450)
>   at 
> org.apache.felix.inventory.impl.webconsole.WebConsoleAdapter.addingService(WebConsoleAdapter.java:152)
>   at 
> org.osgi.util.tracker.ServiceTracker$Tracked.customizerAdding(ServiceTracker.java:943)
>   at 
> org.osgi.util.tracker.ServiceTracker$Tracked.customizerAdding(ServiceTracker.java:871)
>   at 
> org.osgi.util.tracker.AbstractTracked.trackAdding(AbstractTracked.java:256)
>   at 
> org.osgi.util.tracker.AbstractTracked.trackInitial(AbstractTracked.java:183)
>   at org.osgi.util.tracker.ServiceTracker.open(ServiceTracker.java:321)
>   at org.osgi.util.tracker.ServiceTracker.open(ServiceTracker.java:264)
>   at 
> org.apache.felix.inventory.impl.webconsole.WebConsoleAdapter.(WebConsoleAdapter.java:68)
>   at org.apache.felix.inventory.impl.Activator.start(Activator.java:63)
>   at 
> org.apache.felix.framework.util.SecureAction.startActivator(SecureAction.java:698)
>   at org.apache.felix.framework.Felix.activateBundle(Felix.java:2402)
>   at org.apache.felix.framework.Felix.startBundle(Felix.java:2308)
>   at org.apache.felix.framework.Felix.setActiveStartLevel(Felix.java:1539)
>   at 
> org.apache.felix.framework.FrameworkStartLevelImpl.run(FrameworkStartLevelImpl.java:308)
>   at 

[jira] [Resolved] (SLING-9649) TEST requests should be accepted

2020-08-10 Thread Christian Schneider (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-9649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schneider resolved SLING-9649.

Resolution: Fixed

> TEST requests should be accepted
> 
>
> Key: SLING-9649
> URL: https://issues.apache.org/jira/browse/SLING-9649
> Project: Sling
>  Issue Type: Bug
>  Components: Content Distribution
>Affects Versions: Content Distribution Journal Core 0.1.16
>Reporter: Christian Schneider
>Assignee: Christian Schneider
>Priority: Major
> Fix For: Content Distribution Journal Core 0.1.20
>
>
> Distribution agent test connect failing with message : 
> POST /libs/sling/distribution/services/agents/publish HTTP/1.1] 
> org.apache.sling.distribution.journal.impl.publisher.DistributionPublisher 
> [null] Request type TEST is not supported by this agent, expected one of 
> [ADD, DELETE, TEST]"
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (SLING-9594) Move Sling builds to ci-builds.apache.org

2020-08-10 Thread Bertrand Delacretaz (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-9594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174290#comment-17174290
 ] 

Bertrand Delacretaz commented on SLING-9594:


+1 on moving soon to avoid the rush

> Move Sling builds to ci-builds.apache.org
> -
>
> Key: SLING-9594
> URL: https://issues.apache.org/jira/browse/SLING-9594
> Project: Sling
>  Issue Type: Task
>  Components: Build and Source Control
>Reporter: Robert Munteanu
>Priority: Critical
>
> The ASF Jenkins infrastructure is moving to to a new
> Cloudbees based Client Master called https://ci-builds.apache.org, see 
> https://lists.apache.org/thread.html/re974eed417a1bc294694701d5c91b4bf92689fcf32a4c91f169be87d%40%3Cbuilds.apache.org%3E
>  .  The migrations of all jobs needs to be done before the switch off date of 
> 15th August 2020, so we have a maximum about three weeks from now to make the 
> move.
> There is no automatic way of migrating the jobs, but thankfully our current 
> set up is very much automated and reasonably well documented at 
> https://cwiki.apache.org/confluence/display/SLING/Sling+Jenkins+Setup .
> It very well may be that we can simply set up another GitHub org on the new 
> Jenkins master, provide the secrets and be done with it. But it needs 
> investigation though.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (SLING-9594) Move Sling builds to ci-builds.apache.org

2020-08-10 Thread Robert Munteanu (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-9594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174262#comment-17174262
 ] 

Robert Munteanu commented on SLING-9594:


All in all, should we move ASAP? Aug 15 is the cut-off date and I think many 
projects will be rushing to migrate this week. This gives us a better chance to 
see any other issues that may come up and get INFRA assistance if needed.

> Move Sling builds to ci-builds.apache.org
> -
>
> Key: SLING-9594
> URL: https://issues.apache.org/jira/browse/SLING-9594
> Project: Sling
>  Issue Type: Task
>  Components: Build and Source Control
>Reporter: Robert Munteanu
>Priority: Critical
>
> The ASF Jenkins infrastructure is moving to to a new
> Cloudbees based Client Master called https://ci-builds.apache.org, see 
> https://lists.apache.org/thread.html/re974eed417a1bc294694701d5c91b4bf92689fcf32a4c91f169be87d%40%3Cbuilds.apache.org%3E
>  .  The migrations of all jobs needs to be done before the switch off date of 
> 15th August 2020, so we have a maximum about three weeks from now to make the 
> move.
> There is no automatic way of migrating the jobs, but thankfully our current 
> set up is very much automated and reasonably well documented at 
> https://cwiki.apache.org/confluence/display/SLING/Sling+Jenkins+Setup .
> It very well may be that we can simply set up another GitHub org on the new 
> Jenkins master, provide the secrets and be done with it. But it needs 
> investigation though.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (SLING-9627) jcr.base: update to parent pom 39 or newer

2020-08-10 Thread Robert Munteanu (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-9627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu closed SLING-9627.
--

> jcr.base: update to parent pom 39 or newer
> --
>
> Key: SLING-9627
> URL: https://issues.apache.org/jira/browse/SLING-9627
> Project: Sling
>  Issue Type: Sub-task
>  Components: JCR
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: JCR Base 3.1.4
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (SLING-7811) NPE when repository is starting up due to repository manager shutdown

2020-08-10 Thread Robert Munteanu (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-7811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu closed SLING-7811.
--

> NPE when repository is starting up due to repository manager shutdown
> -
>
> Key: SLING-7811
> URL: https://issues.apache.org/jira/browse/SLING-7811
> Project: Sling
>  Issue Type: Bug
>  Components: JCR
>Affects Versions: JCR Oak Server 1.1.4, JCR Base 3.0.4
>Reporter: Carsten Ziegeler
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: JCR Base 3.1.4
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> With the latest Sling Starter, the following NPE occurs in the logs. It seems 
> to be harmless, nevertheless we should fix it:
> For now I assigned it to both, JCR Base and Oak Server, as it's unclear which 
> one it is. Interestingly we've released Oak Server 1.2.0 but are not using it 
> in the starter.
> {noformat}
> 06.08.2018 15:45:18.396 *ERROR* [Apache Sling Repository Startup Thread] 
> org.apache.sling.jcr.oak.server.internal.OakSlingRepositoryManager start: 
> Uncaught Throwable trying to access Repository, calling stopRepository()
> java.lang.NullPointerException: null
> at 
> com.google.common.base.Preconditions.checkNotNull(Preconditions.java:192) 
> [com.google.guava:15.0.0]
> at org.apache.jackrabbit.oak.jcr.Jcr.with(Jcr.java:296) 
> [org.apache.jackrabbit.oak-jcr:1.6.8]
> at 
> org.apache.sling.jcr.oak.server.internal.OakSlingRepositoryManager.acquireRepository(OakSlingRepositoryManager.java:161)
>  [org.apache.sling.jcr.oak.server:1.1.4]
> at 
> org.apache.sling.jcr.base.AbstractSlingRepositoryManager.initializeAndRegisterRepositoryService(AbstractSlingRepositoryManager.java:471)
>  [org.apache.sling.jcr.base:3.0.4]
> at 
> org.apache.sling.jcr.base.AbstractSlingRepositoryManager.access$300(AbstractSlingRepositoryManager.java:85)
>  [org.apache.sling.jcr.base:3.0.4]
> at 
> org.apache.sling.jcr.base.AbstractSlingRepositoryManager$4.run(AbstractSlingRepositoryManager.java:455)
>  [org.apache.sling.jcr.base:3.0.4]
> {noformat}
> The stack trace points to a null workspace name ( see 
> https://github.com/apache/jackrabbit-oak/blob/jackrabbit-oak-1.6.8/oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/Jcr.java#L296
>  ).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (SLING-9629) Jackrabbit RMI imports no longer marked as optional

2020-08-10 Thread Robert Munteanu (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-9629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu closed SLING-9629.
--

> Jackrabbit RMI imports no longer marked as optional
> ---
>
> Key: SLING-9629
> URL: https://issues.apache.org/jira/browse/SLING-9629
> Project: Sling
>  Issue Type: Bug
>  Components: JCR
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Critical
> Fix For: JCR Base 3.1.4
>
>
> After the fix for SLING-9627 the org.apache.jackrabbit.rmi.client, 
> org.apache.jackrabbit.rmi.remote imports are no longer marked as optional. 
> This means the bundle does not resolve on deployments where the RMI bundles 
> are not present, which is unexpected and undesired.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[RESULT] [VOTE] Release Apache Sling JCR Base 3.1.4

2020-08-10 Thread Robert Munteanu
Hi,

The vote has passed with the following result:

+1 (binding): Robert Munteanu, Dan Klco, Stefan Seifert, Nicolas
Peltier
+1 (non-binding): Andreas Schaefer

I will copy this release to the Sling dist directory and
promote the artifacts to the central Maven repository.

Regards,
Robert Munteanu



[jira] [Commented] (SLING-9649) TEST requests should be accepted

2020-08-10 Thread Christian Schneider (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-9649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174218#comment-17174218
 ] 

Christian Schneider commented on SLING-9649:


It turns out we are using a variable this.sender before it is initialized. 

> TEST requests should be accepted
> 
>
> Key: SLING-9649
> URL: https://issues.apache.org/jira/browse/SLING-9649
> Project: Sling
>  Issue Type: Bug
>  Components: Content Distribution
>Affects Versions: Content Distribution Journal Core 0.1.16
>Reporter: Christian Schneider
>Assignee: Christian Schneider
>Priority: Major
> Fix For: Content Distribution Journal Core 0.1.20
>
>
> Distribution agent test connect failing with message : 
> POST /libs/sling/distribution/services/agents/publish HTTP/1.1] 
> org.apache.sling.distribution.journal.impl.publisher.DistributionPublisher 
> [null] Request type TEST is not supported by this agent, expected one of 
> [ADD, DELETE, TEST]"
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (SLING-9649) TEST requests should be accepted

2020-08-10 Thread Christian Schneider (Jira)
Christian Schneider created SLING-9649:
--

 Summary: TEST requests should be accepted
 Key: SLING-9649
 URL: https://issues.apache.org/jira/browse/SLING-9649
 Project: Sling
  Issue Type: Bug
  Components: Content Distribution
Affects Versions: Content Distribution Journal Core 0.1.16
Reporter: Christian Schneider
Assignee: Christian Schneider
 Fix For: Content Distribution Journal Core 0.1.20


Distribution agent test connect failing with message : 

POST /libs/sling/distribution/services/agents/publish HTTP/1.1] 
org.apache.sling.distribution.journal.impl.publisher.DistributionPublisher 
[null] Request type TEST is not supported by this agent, expected one of [ADD, 
DELETE, TEST]"

 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (SLING-9599) Incomplete non-existing resource check

2020-08-10 Thread Radu Cotescu (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-9599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radu Cotescu closed SLING-9599.
---

> Incomplete non-existing resource check
> --
>
> Key: SLING-9599
> URL: https://issues.apache.org/jira/browse/SLING-9599
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Affects Versions: Scripting HTL JS Use Provider 1.2.2
>Reporter: Radu Cotescu
>Assignee: Radu Cotescu
>Priority: Major
> Fix For: Scripting HTL JS Use Provider 1.2.4
>
>
> Checking for non-existing resources is not completely implemented in 
> SLING-9580 - a correct check would look at the Resource's class and the type. 
> However, the previous solution only checks the former.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (SLING-9619) The JavaScript Use Provider does not allow loading scripts relative to search paths any more

2020-08-10 Thread Radu Cotescu (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-9619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radu Cotescu closed SLING-9619.
---

> The JavaScript Use Provider does not allow loading scripts relative to search 
> paths any more
> 
>
> Key: SLING-9619
> URL: https://issues.apache.org/jira/browse/SLING-9619
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Affects Versions: Scripting HTL JS Use Provider 1.2.2
>Reporter: Radu Cotescu
>Assignee: Radu Cotescu
>Priority: Major
> Fix For: Scripting HTL JS Use Provider 1.2.4
>
>
> Starting with SLING-9580 the JavaScript Use Provider does not allow loading 
> scripts relative to search paths any more. This use-case should still be 
> supported.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Re: Sling GraphQL

2020-08-10 Thread Bertrand Delacretaz
Hi Radu,

On Mon, Aug 10, 2020 at 10:54 AM Radu Cotescu  wrote:
> > On 7 Aug 2020, at 16:18, Bertrand Delacretaz  wrote:
...
> > 5) There's no guarantee on how long the prepared queries are stored, a
> > client that gets a 404 on a prepared query request must be prepared to
> > use the default POST request method or store the prepared query again
>
> Instead of replying with a 404 and asking the client to do another POST + 
> GET, couldn’t we just return the
> updated results with updated cache headers?
> Judging by how you describe the algorithm, the Sling server would still have 
> to maintain a cache internally...

I wasn't planning to store the query results on the Sling side, just
the query itself and enough information to be able to process
conditional HTTP requests.

So a complete scenario could be like

1. Client wants to run a query with digest cf81d4 (computed according
to a definition that we publish)
2. Client GETs /prepared/cf81d4.json and receives a 404 as the query
store is empty
3. Client POSTs the query to /prepared and receives a 201 created
/prepared/cf81d4.json
4. Client GETs /prepared/cf81d4.json and receives the results along
with ETag and Cache-Control headers which allow a front-end HTTP cache
to store it
5. Later, the same or another client GETs /prepared/cf81d4.json
through the HTTP cache, which based on headers received at 4. serves
results from cache and does not touch Sling
6. Later, the same or another client GETs /prepared/cf81d4.json, the
results caching period expired but Sling still has that query stored,
so it runs the query again and returns a new ETag
7. If a request comes later with an expired cache and the cf81d4 query
has been purged, Sling returns a 404 and the client has to start over
a 2.

With this scenario (assuming it works, your sanity check of that is
welcome) Sling just needs to store the queries, ETag and cache
expiration time, which I suppose is much less than query results?

-Bertrand


[RESULT] [VOTE] Release Apache Sling Scripting HTL JS Use Provider 1.2.4

2020-08-10 Thread Radu Cotescu
Hi,

The vote has passed with the following result:

+1 (binding): Radu Cotescu, Robert Munteanu, Stefan Seifert, Daniel Klco, 
Nicolas Peltier
+1 (non-binding): none

I will copy this release to the Sling dist directory and
promote the artifacts to the central Maven repository.

Regards,
Radu Cotescu

Re: Sling GraphQL

2020-08-10 Thread Radu Cotescu
Hi Bertrand,

> On 7 Aug 2020, at 16:18, Bertrand Delacretaz  wrote:
> 
> Here's what I suggest:
> 
> 1) GraphQL queries executed via POST are not cached bySling
> 
> 2) Queries can be prepared in advance by POSTing the query text to
> Sling, which returns a "201 created" status with a URL that contains
> the query's digest, like cf81d4
> 
> 3) Clients run such prepared queries by making GET requests to URLs
> like /graphqlservlet/prepared/cf81d4.json
> 
> 4) The responses to such prepared queries requests contain useful HTTP
> Cache headers, which might be set from hints supplied by data fetchers
> with configurable defaults.
> 
> 5) There's no guarantee on how long the prepared queries are stored, a
> client that gets a 404 on a prepared query request must be prepared to
> use the default POST request method or store the prepared query again

Instead of replying with a 404 and asking the client to do another POST + GET, 
couldn’t we just return the updated results with updated cache headers? Judging 
by how you describe the algorithm, the Sling server would still have to 
maintain a cache internally. And we can return a 404 only when we purge the 
query from Sling’s internal cache, which doesn’t have to coincide with the 
moment the query’s results have to be updated. In my view the query’s endpoint 
is the resource, whereas what we return would be the resource’s version. This 
way we can reply with ETag and Cache-Control headers.

Thanks,
Radu

Re: Sling GraphQL

2020-08-10 Thread Bertrand Delacretaz
Hi,

On Fri, Aug 7, 2020 at 4:48 PM Andreea Miruna Moise
 wrote:
> >3) Clients run such prepared queries by making GET requests to URLs
> like /graphqlservlet/prepared/cf81d4.json
> To be able to do this a different endpoint would be needed instead of
> org.apache.sling.graphql.core.servlet. GraphQLServlet right?...

We might extend that servlet to support this behavior, I think that's
an implementation detail.

> >4) The responses to such prepared queries requests contain useful HTTP
> Cache headers, which might be set from hints supplied by data fetchers
> with configurable defaults.
> This means that sling would have to compute the headers based on the cache 
> hints...

Yes, and I think a module or utility class that does this can be
useful in other parts of Sling.

>
> On the other hand I was thinking that the KeyValueCache service can be 
> implemented at
> the sling-graphql-adapter level and sling-graphql-core would only provide the 
> interface. ..

We could also provide extension points to do that, without providing
an actual cache implementation, see below.

> It just seemed a simpler solution...

Apart from small internal things like caching servlet resolution I
don't think we've been doing that kind of caching in Sling so far so I
prefer avoiding it if possible. Delegating caching to the HTTP layer
is much more consistent with what we're doing already.

-Bertrand


Re: Sling Starter switched to the Feature Model

2020-08-10 Thread Robert Munteanu
Hi Eric,

On Fri, 2020-08-07 at 10:10 -0700, Eric Norman wrote:
> Hi Robert,
> 
> I think I stumbled upon a regression with the changes done to the
> build of
> the org-apache-sling-launchpad-testing project.  Specifically, if I
> combine
> the "eclipse:eclipse" goal with the "install" or "verify" goal in the
> same
> mvn command line, it results in an error about a duplicate feature
> file.
> This command worked in the past, so maybe you might know what the
> problem
> is?  It appears that the "aggregate-features" goal is getting called
> twice
> during this build scenario and not handling it well.
> 
> For example:
> 
> *org-apache-sling-launchpad-testing $ **mvn clean eclipse:eclipse
> verify*

I think I know why this happens:

- the eclipse:eclipse invocation invokes the lifecycle phase generate-
resources [5]
- the AggregateFeaturesMojo is bound to the generate-resources phase as
well [6]
- when running `mvn clean eclipse:eclipse install` the generate-
resources phase is invoked twice, and it seems that the features are
aggregated twice

I think the most reasonable solution would be for the slingfeature-
maven-plugin to handle this gracefully, as it fails also when executing

  $ mvn generate-resources generate-resources

Can you please file a bug against the slingfeature-maven-plugin?

Thanks,
Robert

> 
> 
> Results in this error:
> 
> [ERROR] Failed to execute goal
> org.apache.sling:slingfeature-maven-plugin:1.3.6:aggregate-features
> (aggregate-features) on project org.apache.sling.launchpad.testing:
> Execution aggregate-features of goal
> org.apache.sling:slingfeature-maven-plugin:1.3.6:aggregate-features
> failed:
> More than one feature file for classifier testing-oak_tar in project
> org.apache.sling:org.apache.sling.launchpad.testing:jar:12-SNAPSHOT :
> [aggregate testing-oak_tar, aggregate testing-oak_tar] -> [Help 1]
> 
> 
> 
> A workaround is to run the "eclipse:eclipse" goal and the "install"
> or
> "verify goal in separate runs.
> 
> Regards,
> -Eric

[5]: https://maven.apache.org/plugins/maven-eclipse-plugin/eclipse-mojo.html
[6]: 
https://github.com/apache/sling-slingfeature-maven-plugin/blob/6d2918f1c0e8b3162a826149e9ba4bfd475c9216/src/main/java/org/apache/sling/feature/maven/mojos/AggregateFeaturesMojo.java#L47-L51