Re: SlingPostServlet should not throw 500 on any exception

[Andrei Dulvac]

Hi.

Strongly agree this should not be a 5xx response. A 4xx makes sense.

- Andrei

On Wed, 11 Nov 2020 at 14:25, Carsten Ziegeler  wrote:

> Hi,
>
> agreed - in many cases we're return a 500 where a 4xx would be more
> appropriate. As you mention, the post servlet can't decide which case it
> is, so we have to map all exceptions either to 500 (like today) or to
> 4xx. In both cases, we have a false positives.
> But I agree, that it's more likely that its a 4xx case if the exception
> is thrown. When there is a real server problem, I would assume you get
> exceptions all over the place anyway.
> So, I think the change makes sense - we should also not log the
> stacktrace as part of the warning anymore. I'm not even sure if a 4xx
> should log a warning at all.
>
> Regards
> Carsten
>
> Am 11.11.2020 um 13:10 schrieb Jörg Hoh:
> > Hi all,
> >
> > while trying to assess a number of internal server errors, I came across
> > the behavior that the SlingPostServlet is always returning a 500 if it
> has
> > been invoked and wasn't able to write to the repository because of
> missing
> > write permissions [2]. See
> https://issues.apache.org/jira/browse/SLING-9896
> > for a sample of such a stacktrace.
> >
> > I don't think that this type of error qualifies for a HTTP statuscode
> 500,
> > but it's rather an expected behavior, and therefor it should return with
> a
> > 4xx statuscode.
> >
> > In the example mentioned above, the PersistenceException is thrown by the
> > JcrResourceProvider [1], but this PersistenceException is generated on
> > every RepositoryException. So technically, on the one hand side it could
> be
> > caused by a defunct repository (and imo that would qualify for an
> internal
> > server error) on the other hand side it might be caused just by missing
> > permissions.
> >
> > Having that in mind, I would nevertheless argue to switch the behavior of
> > the SlingPostServlet to return a 405 "Method not allowed" in the case of
> a
> > PersistenceError [2]. It isn't 100% accurate either but still better than
> > the internal server error. Making it more accurate would require major
> > changes to the Sling-JCR implementation, and I am not sure if this
> > improvement in semantics justifies it.
> > All other exceptions are thandled the same way as before and continue to
> > return an internal server error.
> >
> > WDYT?
> >
> > Jörg
> >
> >
> > [1]
> >
> https://github.com/apache/sling-org-apache-sling-jcr-resource/blob/org.apache.sling.jcr.resource-3.0.22/src/main/java/org/apache/sling/jcr/resource/internal/helper/jcr/JcrResourceProvider.java#L476
> >
> > [2]
> >
> https://github.com/apache/sling-org-apache-sling-servlets-post/blob/master/src/main/java/org/apache/sling/servlets/post/impl/SlingPostServlet.java#L237
> >
>
> --
> --
> Carsten Ziegeler
> Adobe Research Switzerland
> cziege...@apache.org
>

[jira] [Commented] (SLING-9898) Support interpolation in Context-Aware Configuration

[Konrad Windszus (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-9898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17230169#comment-17230169
 ] 

Konrad Windszus commented on SLING-9898:


The extension could be hooked into 
https://github.com/apache/sling-org-apache-sling-caconfig-impl/blob/acc61e506c22a22e2d7d31fdff9340b702b40d86/src/main/java/org/apache/sling/caconfig/impl/ConfigurationResourceWrapper.java#L39.

> Support interpolation in Context-Aware Configuration
> 
>
> Key: SLING-9898
> URL: https://issues.apache.org/jira/browse/SLING-9898
> Project: Sling
>  Issue Type: New Feature
>Affects Versions: Context-Aware Configuration Impl 1.5.0
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: Context-Aware Configuration Impl 1.5.2
>
>
> Similar to https://issues.apache.org/jira/browse/SLING-7768 and 
> https://github.com/apache/felix-dev/blob/master/configadmin-plugins/interpolation/README.md
>  Context-Aware configurations should support interpolating values from at 
> least environment variables.
> Although a similar behaviour could probably be achieved with a new Override 
> Provider 
> (https://sling.apache.org/documentation/bundles/context-aware-configuration/context-aware-configuration-override.html#built-in-override-providers),
>  it would require a level of indirection. 
> This feature is about directly referencing external values inside the 
> Context-Aware Configuration.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-9898) Support interpolation in Context-Aware Configuration

[Konrad Windszus (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus updated SLING-9898:
---
Description: 
Similar to https://issues.apache.org/jira/browse/SLING-7768 and 
https://github.com/apache/felix-dev/blob/master/configadmin-plugins/interpolation/README.md
 Context-Aware configurations should support interpolating values from at least 
environment variables.
Although a similar behaviour could probably be achieved with a new Override 
Provider 
(https://sling.apache.org/documentation/bundles/context-aware-configuration/context-aware-configuration-override.html#built-in-override-providers),
 it would require a level of indirection. 
This feature is about directly referencing external values inside the 
Context-Aware Configuration.

  was:Similar to https://issues.apache.org/jira/browse/SLING-7768 and 
https://github.com/apache/felix-dev/blob/master/configadmin-plugins/interpolation/README.md
 Context-Aware configurations should support interpolating values from at least 
environment variables.


> Support interpolation in Context-Aware Configuration
> 
>
> Key: SLING-9898
> URL: https://issues.apache.org/jira/browse/SLING-9898
> Project: Sling
>  Issue Type: New Feature
>Affects Versions: Context-Aware Configuration Impl 1.5.0
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: Context-Aware Configuration Impl 1.5.2
>
>
> Similar to https://issues.apache.org/jira/browse/SLING-7768 and 
> https://github.com/apache/felix-dev/blob/master/configadmin-plugins/interpolation/README.md
>  Context-Aware configurations should support interpolating values from at 
> least environment variables.
> Although a similar behaviour could probably be achieved with a new Override 
> Provider 
> (https://sling.apache.org/documentation/bundles/context-aware-configuration/context-aware-configuration-override.html#built-in-override-providers),
>  it would require a level of indirection. 
> This feature is about directly referencing external values inside the 
> Context-Aware Configuration.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-9898) Support interpolation in Context-Aware Configuration

[Konrad Windszus (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus updated SLING-9898:
---
Description: Similar to https://issues.apache.org/jira/browse/SLING-7768 
and 
https://github.com/apache/felix-dev/blob/master/configadmin-plugins/interpolation/README.md
 Context-Aware configurations should support interpolating values from at least 
environment variables.  (was: Similar to 
https://issues.apache.org/jira/browse/SLING-7768 and 
https://github.com/apache/felix-dev/blob/master/configadmin-plugins/interpolation/README.md
 Context-Aware configuration should support interpolating values from at least 
environment variables.)

> Support interpolation in Context-Aware Configuration
> 
>
> Key: SLING-9898
> URL: https://issues.apache.org/jira/browse/SLING-9898
> Project: Sling
>  Issue Type: New Feature
>Affects Versions: Context-Aware Configuration Impl 1.5.0
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: Context-Aware Configuration Impl 1.5.2
>
>
> Similar to https://issues.apache.org/jira/browse/SLING-7768 and 
> https://github.com/apache/felix-dev/blob/master/configadmin-plugins/interpolation/README.md
>  Context-Aware configurations should support interpolating values from at 
> least environment variables.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (SLING-9898) Support interpolation in Context-Aware Configuration

[Konrad Windszus (Jira)]

Konrad Windszus created SLING-9898:
--

 Summary: Support interpolation in Context-Aware Configuration
 Key: SLING-9898
 URL: https://issues.apache.org/jira/browse/SLING-9898
 Project: Sling
  Issue Type: New Feature
Affects Versions: Context-Aware Configuration Impl 1.5.0
Reporter: Konrad Windszus
 Fix For: Context-Aware Configuration Impl 1.5.2


Similar to https://issues.apache.org/jira/browse/SLING-7768 and 
https://github.com/apache/felix-dev/blob/master/configadmin-plugins/interpolation/README.md
 Context-Aware configuration should support interpolating values from at least 
environment variables.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: [VOTE] Release Apache Sling Content Package Archetype 1.0.0

[Radu Cotescu]

Hi,

> On 6 Nov 2020, at 16:24, Ruben Reusser  wrote:
> 
> I totally understand the idea behind why to put a simple html component into 
> the content package. I however struggle with the fact that Java Use Objects 
> are probably not a best practice for sling projects or other upstream 
> projects. Maybe I am wrong here.

Ruben is right - Java Use Objects in the resource tree are not the best idea. 
With HTL it’s better to use Sling Models for the Use API, albeit these are not 
content structures. However, I’d really avoid encouraging people to still use 
Java Use Objects, even though they’re still supported.

Thanks,
Radu

[CANCELLED] [VOTE] Release Apache Sling Content Package Archetype 1.0.0

[Robert Munteanu]

Hi,

I'm cancelling this vote to address the feedback raised by Ruben and
Konrad.

Thanks,
Robert

Re: [VOTE] Release Apache Sling Content Package Archetype 1.0.0

[Robert Munteanu]

Hi Konrad,

On Fri, 2020-11-06 at 16:47 +0100, Konrad Windszus wrote:
> Sorry I haven't checked the code up till now.
> Some questions/remarks:
> 
> 1. Why filevault-package-maven-plugin 1.1.2 and not the latest
> version 1.1.4?

It was the latest version available at the time. I just pushed an
update

  https://github.com/apache/sling-content-package-archetype/commit/6286389

> 2. It is using a mixed package (mutable/potentially immutable
> content), why do we propose that instead of a clear separation with
> three different modules (apps. content, container)

I wanted to go with something very simple. But on the other hand I
don't want to go with something that is against current best practices.
Would you mind filing an issue for points 2-5? I will cancel the
current vote and get back to dev@ once I think it's ready.

Thanks!
Robert

> 3. I would recommend setting a dedicated package type in the
> configuration (
> https://github.com/apache/sling-content-package-archetype/blob/30380a1d75abfaafa1aa67d487f01b3123575777/src/main/resources/archetype-resources/pom.xml#L49
> <
> https://github.com/apache/sling-content-package-archetype/blob/30380a1d75abfaafa1aa67d487f01b3123575777/src/main/resources/archetype-resources/pom.xml#L49>
> ;)
> 4. Would it make sense to embed a bundle here as well?
> 5. As archetypes don't allow speaking description for properties
> these either need a documentation and/or a very speaking name. IMHO
> shortName (
> https://github.com/apache/sling-content-package-archetype/blob/30380a1d75abfaafa1aa67d487f01b3123575777/src/main/resources/META-INF/maven/archetype-metadata.xml#L39
> <
> https://github.com/apache/sling-content-package-archetype/blob/30380a1d75abfaafa1aa67d487f01b3123575777/src/main/resources/META-INF/maven/archetype-metadata.xml#L39>
> ;) is not good enough, given that there is not a readme
> 
> Thanks and sorry for the late feedback,
> Konrad
> 
> > On 6. Nov 2020, at 13:18, Robert Munteanu 
> > wrote:
> > 
> > Hi,
> > 
> > This is a first release of the tooling, so no issues fixed (but a
> > version was created):
> > https://issues.apache.org/jira/browse/SLING/fixforversion/12349357
> > 
> > Staging repository:
> > https://repository.apache.org/content/repositories/orgapachesling-2369/
> > 
> > You can use this UNIX script to download the release and verify the
> > signatures:
> > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
> > 
> > Usage:
> > sh check_staged_release.sh 2369 /tmp/sling-staging
> > 
> > Please vote to approve this release:
> > 
> >  [ ] +1 Approve the release
> >  [ ]  0 Don't care
> >  [ ] -1 Don't release, because ...
> > 
> > This majority vote is open for at least 72 hours.
> > 
> > Regards,
> > Robert Munteanu
> > 

[GitHub] [sling-org-apache-sling-feature-extension-apiregions] sonarcloud[bot] commented on pull request #11: SLING-9897 Update API Regions Analysers to use artifact-aware error reporting

[GitBox]

sonarcloud[bot] commented on pull request #11:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-extension-apiregions/pull/11#issuecomment-725511527


   SonarCloud Quality Gate failed.
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-extension-apiregions=11=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-extension-apiregions=11=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-extension-apiregions=11=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-extension-apiregions=11=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-extension-apiregions=11=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-extension-apiregions=11=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-
 
feature-extension-apiregions=11=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-extension-apiregions=11=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-extension-apiregions=11=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-extension-apiregions=11=false=CODE_SMELL)
 [1 Code 
Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-extension-apiregions=11=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-extension-apiregions=11=new_coverage=list)
 [58.3% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-extension-apiregions=11=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-extension-apiregions=11=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-extension-apiregions=11=new_duplicated_lines_density=list)
   
The version of Java (1.8.0_252) you 
have used to run this analysis is deprecated and we will stop accepting it 
accepting it soon.Please update to at least Java 11.
   Read more [here](https://sonarcloud.io/documentation/upcoming/)
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-feature-extension-apiregions] bosschaert opened a new pull request #11: SLING-9897 Update API Regions Analysers to use artifact-aware error reporting

[GitBox]

bosschaert opened a new pull request #11:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-extension-apiregions/pull/11


   Also updated some error messages to be a little easier to understand.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Updated] (SLING-9896) change statuscode in SlingPostServlet for PersistenceException

[Jira]

 [ 
https://issues.apache.org/jira/browse/SLING-9896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jörg Hoh updated SLING-9896:

Description: 
When the SlingPostServlet receives a PersistenceExceptions while trying to 
persist the changes, it should not throw an internal server error, but a 
statuscode of 405, because this behavior is expected.

Example stacktrace:


{noformat}
11.11.2020 11:18:38.418 *ERROR* [172.16.123.101 [1605093518414] POST 
/foo/bar.html HTTP/1.1] 
org.apache.sling.servlets.post.impl.operations.ModifyOperation
Exception during response processing.
org.apache.sling.api.resource.PersistenceException: Unable to create node at 
/foo/bar.html
at 
org.apache.sling.jcr.resource.internal.helper.jcr.JcrResourceProvider.create(JcrResourceProvider.java:477)
 [org.apache.sling.jcr.resource:3.0.22]
at 
org.apache.sling.resourceresolver.impl.providers.stateful.AuthenticatedResourceProvider.create(AuthenticatedResourceProvider.java:182)
 [org.apache.sling.resourceresolver:1.7.0]
at 
org.apache.sling.resourceresolver.impl.helper.ResourceResolverControl.create(ResourceResolverControl.java:381)
 [org.apache.sling.resourceresolver:1.7.0]
at 
org.apache.sling.resourceresolver.impl.ResourceResolverImpl.create(ResourceResolverImpl.java:979)
 [org.apache.sling.resourceresolver:1.7.0]
at 
org.apache.sling.servlets.post.impl.operations.AbstractCreateOperation.deepGetOrCreateResource(AbstractCreateOperation.java:598)
 [org.apache.sling.servlets.post:2.3.36]
at 
org.apache.sling.servlets.post.impl.operations.AbstractCreateOperation.processCreate(AbstractCreateOperation.java:146)
 [org.apache.sling.servlets.post:2.3.36]
at 
org.apache.sling.servlets.post.impl.operations.ModifyOperation.doRun(ModifyOperation.java:83)
 [org.apache.sling.servlets.post:2.3.36]
at 
org.apache.sling.servlets.post.impl.operations.AbstractPostOperation.run(AbstractPostOperation.java:99)
 [org.apache.sling.servlets.post:2.3.36]
at 
org.apache.sling.servlets.post.impl.SlingPostServlet.doPost(SlingPostServlet.java:233)
 [org.apache.sling.servlets.post:2.3.36]
at 
org.apache.sling.api.servlets.SlingAllMethodsServlet.mayService(SlingAllMethodsServlet.java:146)
 [org.apache.sling.api:2.22.0]
at 
org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:342)
 [org.apache.sling.api:2.22.0]
[...]
Caused by: javax.jcr.nodetype.ConstraintViolationException: No default node 
type available for /foo/bar.html
at 
org.apache.jackrabbit.oak.plugins.tree.TreeUtil.addChild(TreeUtil.java:234) 
[org.apache.jackrabbit.oak-security-spi:1.35.0]
at 
org.apache.jackrabbit.oak.jcr.delegate.NodeDelegate.addChild(NodeDelegate.java:690)
 [org.apache.jackrabbit.oak-jcr:1.35.0]
at 
org.apache.jackrabbit.oak.jcr.session.NodeImpl$5.perform(NodeImpl.java:314) 
[org.apache.jackrabbit.oak-jcr:1.35.0]
at 
org.apache.jackrabbit.oak.jcr.session.NodeImpl$5.perform(NodeImpl.java:280) 
[org.apache.jackrabbit.oak-jcr:1.35.0]
at 
org.apache.jackrabbit.oak.jcr.delegate.SessionDelegate.perform(SessionDelegate.java:209)
 [org.apache.jackrabbit.oak-jcr:1.35.0]
at 
org.apache.jackrabbit.oak.jcr.session.ItemImpl.perform(ItemImpl.java:112) 
[org.apache.jackrabbit.oak-jcr:1.35.0]
at 
org.apache.jackrabbit.oak.jcr.session.NodeImpl.addNode(NodeImpl.java:280) 
[org.apache.jackrabbit.oak-jcr:1.35.0]
at 
org.apache.jackrabbit.oak.jcr.session.NodeImpl.addNode(NodeImpl.java:265) 
[org.apache.jackrabbit.oak-jcr:1.35.0]
at 
org.apache.sling.jcr.resource.internal.helper.jcr.JcrResourceProvider.create(JcrResourceProvider.java:448)
 [org.apache.sling.jcr.resource:3.0.22]
... 154 common frames omitted
{noformat}

Discussion at https://www.mail-archive.com/dev@sling.apache.org/msg100122.html 
(dev@sling)


  was:
When the SlingPostServlet receives a PersistenceExceptions while trying to 
persist the changes, it should not throw an internal server error, but a 
statuscode of 405, because this behavior is expected.

Example stacktrace:


{noformat}
11.11.2020 11:18:38.418 *ERROR* [172.16.123.101 [1605093518414] POST 
/foo/bar.html HTTP/1.1] 
org.apache.sling.servlets.post.impl.operations.ModifyOperation
Exception during response processing.
org.apache.sling.api.resource.PersistenceException: Unable to create node at 
/foo/bar.html
at 
org.apache.sling.jcr.resource.internal.helper.jcr.JcrResourceProvider.create(JcrResourceProvider.java:477)
 [org.apache.sling.jcr.resource:3.0.22]
at 
org.apache.sling.resourceresolver.impl.providers.stateful.AuthenticatedResourceProvider.create(AuthenticatedResourceProvider.java:182)
 [org.apache.sling.resourceresolver:1.7.0]
at 
org.apache.sling.resourceresolver.impl.helper.ResourceResolverControl.create(ResourceResolverControl.java:381)
 

Re: [VOTE] Release Apache Sling Content-Package to Feature Model Converter 1.0.18

[Daniel Klco]

+1

On Wed, Nov 11, 2020 at 7:01 AM Julian Sedding  wrote:
>
> +1
>
> Regards
> Julian
>
>
> On Wed, Nov 11, 2020 at 10:38 AM  wrote:
> >
> > Hi all,
> >
> > I would like to call the release on the Content-Package to Feature Model
> > Converter 1.0.18
> > https://issues.apache.org/jira/projects/SLING/versions/12349329
> >
> > Staging repository:
> > https://repository.apache.org/content/repositories/orgapachesling-2375
> >
> > You can use this UNIX script to download the release and verify the
> > signatures:
> > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
> >
> > Usage:
> > sh check_staged_release.sh 2375 /tmp/sling-staging
> >
> > Please vote to approve this release:
> >
> >[ ] +1 Approve the release
> >[ ] -1 Don't release, because ...
> >
> > This majority vote is open for at least 72 hours.
> >
> > Best regards,
> >
> > David

Re: [VOTE] Release Sling Adapter Annotations 2.0.0

[Daniel Klco]

+1

On Wed, Nov 11, 2020 at 6:53 AM Julian Sedding  wrote:
>
> +1
>
> Regards
> Julian
>
>
> On Tue, Nov 10, 2020 at 7:11 PM Bertrand Delacretaz
>  wrote:
> >
> > Hi,
> >
> > This is a new module, at
> > https://github.com/apache/sling-org-apache-sling-adapter-annotations
> >
> > ...not to be confused with the older
> > https://github.com/apache/sling-adapter-annotations module, which I
> > have renamed with a (JSON) suffix for clarity.
> >
> > There are still some outstanding issues:
> > https://issues.apache.org/jira/projects/SLING/versions/12349370
> >
> > Staging repository:
> > https://repository.apache.org/content/repositories/orgapachesling-2374/
> >
> > You can use this UNIX script to download the release and verify the 
> > signatures:
> > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
> >
> > Usage:
> > sh check_staged_release.sh 2374 /tmp/sling-staging
> >
> > Please vote to approve this release:
> >
> >   [ ] +1 Approve the release
> >   [ ]  0 Don't care
> >   [ ] -1 Don't release, because ...
> >
> > This majority vote is open for at least 72 hours.
> >
> > Here's my +1.
> >
> > -Bertrand

[jira] [Updated] (SLING-9897) Update API Regions Analysers to use artifact-aware error reporting

[A. J. David Bosschaert (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

A. J. David Bosschaert updated SLING-9897:
--
Summary: Update API Regions Analysers to use artifact-aware error reporting 
 (was: Update API Regions Analysers to use artifac-aware error reporting)

> Update API Regions Analysers to use artifact-aware error reporting
> --
>
> Key: SLING-9897
> URL: https://issues.apache.org/jira/browse/SLING-9897
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model Analyser
>Affects Versions: Feature Model API Regions Extension 1.1.10
>Reporter: A. J. David Bosschaert
>Assignee: A. J. David Bosschaert
>Priority: Major
> Fix For: Feature Model API Regions Extension 1.1.12
>
>
> A new improved error reporting is available in the Analysers API which allows 
> the association with an artifact for the error reporting.
> The API Regions analysers should be updated to use this where applicable.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (SLING-9897) Update API Regions Analysers to use artifac-aware error reporting

[A. J. David Bosschaert (Jira)]

A. J. David Bosschaert created SLING-9897:
-

 Summary: Update API Regions Analysers to use artifac-aware error 
reporting
 Key: SLING-9897
 URL: https://issues.apache.org/jira/browse/SLING-9897
 Project: Sling
  Issue Type: Improvement
  Components: Feature Model Analyser
Affects Versions: Feature Model API Regions Extension 1.1.10
Reporter: A. J. David Bosschaert
Assignee: A. J. David Bosschaert
 Fix For: Feature Model API Regions Extension 1.1.12


A new improved error reporting is available in the Analysers API which allows 
the association with an artifact for the error reporting.

The API Regions analysers should be updated to use this where applicable.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: SlingPostServlet should not throw 500 on any exception

[Carsten Ziegeler]

Hi,

agreed - in many cases we're return a 500 where a 4xx would be more 
appropriate. As you mention, the post servlet can't decide which case it 
is, so we have to map all exceptions either to 500 (like today) or to 
4xx. In both cases, we have a false positives.
But I agree, that it's more likely that its a 4xx case if the exception 
is thrown. When there is a real server problem, I would assume you get 
exceptions all over the place anyway.
So, I think the change makes sense - we should also not log the 
stacktrace as part of the warning anymore. I'm not even sure if a 4xx 
should log a warning at all.


Regards
Carsten

Am 11.11.2020 um 13:10 schrieb Jörg Hoh:

Hi all,

while trying to assess a number of internal server errors, I came across
the behavior that the SlingPostServlet is always returning a 500 if it has
been invoked and wasn't able to write to the repository because of missing
write permissions [2]. See https://issues.apache.org/jira/browse/SLING-9896
for a sample of such a stacktrace.

I don't think that this type of error qualifies for a HTTP statuscode 500,
but it's rather an expected behavior, and therefor it should return with a
4xx statuscode.

In the example mentioned above, the PersistenceException is thrown by the
JcrResourceProvider [1], but this PersistenceException is generated on
every RepositoryException. So technically, on the one hand side it could be
caused by a defunct repository (and imo that would qualify for an internal
server error) on the other hand side it might be caused just by missing
permissions.

Having that in mind, I would nevertheless argue to switch the behavior of
the SlingPostServlet to return a 405 "Method not allowed" in the case of a
PersistenceError [2]. It isn't 100% accurate either but still better than
the internal server error. Making it more accurate would require major
changes to the Sling-JCR implementation, and I am not sure if this
improvement in semantics justifies it.
All other exceptions are thandled the same way as before and continue to
return an internal server error.

WDYT?

Jörg


[1]
https://github.com/apache/sling-org-apache-sling-jcr-resource/blob/org.apache.sling.jcr.resource-3.0.22/src/main/java/org/apache/sling/jcr/resource/internal/helper/jcr/JcrResourceProvider.java#L476

[2]
https://github.com/apache/sling-org-apache-sling-servlets-post/blob/master/src/main/java/org/apache/sling/servlets/post/impl/SlingPostServlet.java#L237



--
--
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

Re: [Jenkins] Sling » Modules » sling-org-apache-sling-starter » master #52 is BROKEN

[Konrad Windszus]

This is again the issue described in 
https://github.com/bndtools/bnd/issues/4125#issuecomment-691707488 
.
The metadata of staxex is again corrupt on Maven Central. I opened 
https://issues.sonatype.org/browse/MVNCENTRAL-6303 
 for that.
Konrad

> On 11. Nov 2020, at 12:20, Apache Jenkins Server  
> wrote:
> 
> Please see 
> https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-starter/job/master/52/
>  for details.
> 
> No further emails will be sent until the status of the build is changed.
> Build log follows below:
> 
> [...truncated 190 lines...]
> [WARNING] Bundle org.apache.sling.jcr.davex:1.3.10 is importing package(s) 
> org.osgi.service.event without specifying a version range.
> [WARNING] Bundle org.apache.servicemix.bundles.thymeleaf:3.0.11.RELEASE_1 is 
> importing package(s) [ognl, com.fasterxml.jackson.core, 
> com.fasterxml.jackson.core.io, com.fasterxml.jackson.databind, ognl.enhance] 
> without specifying a version range.
> [WARNING] Bundle oak-query-spi:1.32.0 is importing package(s) 
> org.apache.jackrabbit.oak.spi.state without specifying a version range.
> [WARNING] Bundle tika-parsers:1.24 is importing package(s) 
> [org.openxmlformats.schemas.wordprocessingml.x2006.main, com.pff, 
> org.apache.tika.parser.ner, org.apache.uima.analysis_engine, 
> org.apache.poi.hssf.extractor, org.apache.tika.parser.odf, 
> org.apache.poi.poifs.crypt, org.apache.tika.parser.geo.topic, ucar.ma2, 
> com.epam.parso.impl, com.coremedia.iso.boxes.apple, 
> org.apache.tika.parser.mail, 
> org.apache.tika.parser.html.charsetdetector.charsets, com.drew.metadata, 
> com.uwyn.jhighlight.renderer, org.apache.poi.common.usermodel.fonts, 
> org.apache.poi.hslf.usermodel, org.apache.tika.parser.chm.core, 
> org.apache.poi.openxml4j.opc.internal, org.apache.http, 
> org.apache.sis.metadata.iso, opennlp.tools.sentiment, org.apache.uima.jcas, 
> org.openxmlformats.schemas.drawingml.x2006.main, 
> org.openxmlformats.schemas.officeDocument.x2006.extendedProperties, 
> org.apache.sis.metadata.iso.identification, 
> org.apache.ctakes.typesystem.type.refsem, org.apache.poi.xdgf.usermodel, 
> org.apache.tika.parser.chm.assertion, com.github.junrar.exception, ucar.nc2, 
> org.apache.poi.util, org.apache.poi.hmef, org.apache.sis.metadata.iso.extent, 
> de.l3s.boilerpipe.document, org.apache.tika.parser.microsoft.ooxml.xps, 
> org.apache.poi.ooxml, org.apache.poi.openxml4j.exceptions, 
> org.apache.tika.parser.pkg, org.apache.poi.poifs.macros, 
> org.apache.tika.parser.utils, org.apache.poi.ss.usermodel, 
> org.apache.sis.metadata.iso.constraint, org.apache.tika.parser.csv, 
> org.apache.sis.storage, com.github.junrar, org.apache.http.entity, 
> org.apache.ctakes.typesystem.type.textsem, org.apache.poi.ooxml.extractor, 
> com.drew.lang, com.googlecode.mp4parser, com.github.junrar.impl, 
> ucar.nc2.dataset, org.mozilla.universalchardet, org.apache.xmlbeans, 
> org.apache.tika.parser.executable, com.googlecode.mp4parser.util, 
> org.apache.poi.ss.util, com.coremedia.iso.boxes, 
> org.apache.poi.hssf.usermodel, org.apache.poi.xssf.eventusermodel, 
> com.epam.parso, org.apache.uima.cas.impl, org.apache.poi.hssf.model, 
> org.apache.poi.hwpf, org.apache.tika.parser.rtf, com.github.junrar.rarfile, 
> org.apache.tika.parser.ocr, org.apache.tika.parser.html, 
> org.apache.uima.util, org.apache.poi.hssf.eventusermodel, 
> org.apache.poi.openxml4j.opc, com.drew.imaging.jpeg, 
> org.apache.poi.ooxml.util, org.apache.sis.util.collection, 
> org.apache.poi.hwpf.model, org.ccil.cowan.tagsoup, 
> org.apache.poi.hwpf.converter, org.apache.poi.hssf.record.common, 
> org.apache.poi.poifs.filesystem, org.apache.poi.xssf.extractor, 
> org.apache.poi.xssf.binary, com.healthmarketscience.jackcess.impl, 
> com.drew.imaging.webp, org.apache.poi.xwpf.extractor, 
> org.apache.tika.parser.chm.accessor, org.apache.poi.xssf.usermodel.helpers, 
> org.apache.poi, org.apache.poi.common.usermodel, 
> org.apache.pdfbox.tools.imageio, com.drew.imaging.riff, 
> org.apache.poi.hpbf.extractor, org.apache.poi.hdgf.extractor, 
> org.apache.poi.hslf.exceptions, org.apache.poi.hslf.model, 
> org.apache.poi.xslf.usermodel, com.coremedia.iso.boxes.sampleentry, 
> org.apache.tika.parser.chm.exception, org.apache.tika.parser.xml, 
> org.apache.http.client, org.apache.http.client.methods, 
> org.apache.tika.parser.txt, org.apache.http.impl.client, com.jmatio.io, 
> org.apache.poi.hwpf.usermodel, org.apache.poi.hpsf, org.apache.uima.cas, 
> org.apache.tika.parser.iwork, org.apache.tika.parser.recognition, 
> org.apache.poi.ddf, org.apache.tika.parser.image, org.apache.uima, 
> org.apache.poi.hssf.record.crypto, org.apache.uima.fit.util, 
> org.apache.tika.parser.mbox, org.apache.poi.hssf.record, 
> org.apache.poi.xslf.extractor, org.apache.sis.internal.util, 
> org.apache.uima.jcas.cas, ucar.nc2.util, 

[jira] [Updated] (SLING-9896) change statuscode in SlingPostServlet for PersistenceException

[Jira]

 [ 
https://issues.apache.org/jira/browse/SLING-9896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jörg Hoh updated SLING-9896:

Description: 
When the SlingPostServlet receives a PersistenceExceptions while trying to 
persist the changes, it should not throw an internal server error, but a 
statuscode of 405, because this behavior is expected.

Example stacktrace:


{noformat}
11.11.2020 11:18:38.418 *ERROR* [172.16.123.101 [1605093518414] POST 
/foo/bar.html HTTP/1.1] 
org.apache.sling.servlets.post.impl.operations.ModifyOperation
Exception during response processing.
org.apache.sling.api.resource.PersistenceException: Unable to create node at 
/foo/bar.html
at 
org.apache.sling.jcr.resource.internal.helper.jcr.JcrResourceProvider.create(JcrResourceProvider.java:477)
 [org.apache.sling.jcr.resource:3.0.22]
at 
org.apache.sling.resourceresolver.impl.providers.stateful.AuthenticatedResourceProvider.create(AuthenticatedResourceProvider.java:182)
 [org.apache.sling.resourceresolver:1.7.0]
at 
org.apache.sling.resourceresolver.impl.helper.ResourceResolverControl.create(ResourceResolverControl.java:381)
 [org.apache.sling.resourceresolver:1.7.0]
at 
org.apache.sling.resourceresolver.impl.ResourceResolverImpl.create(ResourceResolverImpl.java:979)
 [org.apache.sling.resourceresolver:1.7.0]
at 
org.apache.sling.servlets.post.impl.operations.AbstractCreateOperation.deepGetOrCreateResource(AbstractCreateOperation.java:598)
 [org.apache.sling.servlets.post:2.3.36]
at 
org.apache.sling.servlets.post.impl.operations.AbstractCreateOperation.processCreate(AbstractCreateOperation.java:146)
 [org.apache.sling.servlets.post:2.3.36]
at 
org.apache.sling.servlets.post.impl.operations.ModifyOperation.doRun(ModifyOperation.java:83)
 [org.apache.sling.servlets.post:2.3.36]
at 
org.apache.sling.servlets.post.impl.operations.AbstractPostOperation.run(AbstractPostOperation.java:99)
 [org.apache.sling.servlets.post:2.3.36]
at 
org.apache.sling.servlets.post.impl.SlingPostServlet.doPost(SlingPostServlet.java:233)
 [org.apache.sling.servlets.post:2.3.36]
at 
org.apache.sling.api.servlets.SlingAllMethodsServlet.mayService(SlingAllMethodsServlet.java:146)
 [org.apache.sling.api:2.22.0]
at 
org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:342)
 [org.apache.sling.api:2.22.0]
[...]
Caused by: javax.jcr.nodetype.ConstraintViolationException: No default node 
type available for /foo/bar.html
at 
org.apache.jackrabbit.oak.plugins.tree.TreeUtil.addChild(TreeUtil.java:234) 
[org.apache.jackrabbit.oak-security-spi:1.35.0]
at 
org.apache.jackrabbit.oak.jcr.delegate.NodeDelegate.addChild(NodeDelegate.java:690)
 [org.apache.jackrabbit.oak-jcr:1.35.0]
at 
org.apache.jackrabbit.oak.jcr.session.NodeImpl$5.perform(NodeImpl.java:314) 
[org.apache.jackrabbit.oak-jcr:1.35.0]
at 
org.apache.jackrabbit.oak.jcr.session.NodeImpl$5.perform(NodeImpl.java:280) 
[org.apache.jackrabbit.oak-jcr:1.35.0]
at 
org.apache.jackrabbit.oak.jcr.delegate.SessionDelegate.perform(SessionDelegate.java:209)
 [org.apache.jackrabbit.oak-jcr:1.35.0]
at 
org.apache.jackrabbit.oak.jcr.session.ItemImpl.perform(ItemImpl.java:112) 
[org.apache.jackrabbit.oak-jcr:1.35.0]
at 
org.apache.jackrabbit.oak.jcr.session.NodeImpl.addNode(NodeImpl.java:280) 
[org.apache.jackrabbit.oak-jcr:1.35.0]
at 
org.apache.jackrabbit.oak.jcr.session.NodeImpl.addNode(NodeImpl.java:265) 
[org.apache.jackrabbit.oak-jcr:1.35.0]
at 
org.apache.sling.jcr.resource.internal.helper.jcr.JcrResourceProvider.create(JcrResourceProvider.java:448)
 [org.apache.sling.jcr.resource:3.0.22]
... 154 common frames omitted
{noformat}


  was:
When the SlingPostServlet receives a PersistenceExceptions while trying to 
persist the changes, it should not throw an internal server error, but a 
statuscode of 4xx, because this behavior is expected.

Example stacktrace:


{noformat}
11.11.2020 11:18:38.418 *ERROR* [172.16.123.101 [1605093518414] POST 
/foo/bar.html HTTP/1.1] 
org.apache.sling.servlets.post.impl.operations.ModifyOperation
Exception during response processing.
org.apache.sling.api.resource.PersistenceException: Unable to create node at 
/foo/bar.html
at 
org.apache.sling.jcr.resource.internal.helper.jcr.JcrResourceProvider.create(JcrResourceProvider.java:477)
 [org.apache.sling.jcr.resource:3.0.22]
at 
org.apache.sling.resourceresolver.impl.providers.stateful.AuthenticatedResourceProvider.create(AuthenticatedResourceProvider.java:182)
 [org.apache.sling.resourceresolver:1.7.0]
at 
org.apache.sling.resourceresolver.impl.helper.ResourceResolverControl.create(ResourceResolverControl.java:381)
 [org.apache.sling.resourceresolver:1.7.0]
at 

SlingPostServlet should not throw 500 on any exception

[Jörg Hoh]

Hi all,

while trying to assess a number of internal server errors, I came across
the behavior that the SlingPostServlet is always returning a 500 if it has
been invoked and wasn't able to write to the repository because of missing
write permissions [2]. See https://issues.apache.org/jira/browse/SLING-9896
for a sample of such a stacktrace.

I don't think that this type of error qualifies for a HTTP statuscode 500,
but it's rather an expected behavior, and therefor it should return with a
4xx statuscode.

In the example mentioned above, the PersistenceException is thrown by the
JcrResourceProvider [1], but this PersistenceException is generated on
every RepositoryException. So technically, on the one hand side it could be
caused by a defunct repository (and imo that would qualify for an internal
server error) on the other hand side it might be caused just by missing
permissions.

Having that in mind, I would nevertheless argue to switch the behavior of
the SlingPostServlet to return a 405 "Method not allowed" in the case of a
PersistenceError [2]. It isn't 100% accurate either but still better than
the internal server error. Making it more accurate would require major
changes to the Sling-JCR implementation, and I am not sure if this
improvement in semantics justifies it.
All other exceptions are thandled the same way as before and continue to
return an internal server error.

WDYT?

Jörg


[1]
https://github.com/apache/sling-org-apache-sling-jcr-resource/blob/org.apache.sling.jcr.resource-3.0.22/src/main/java/org/apache/sling/jcr/resource/internal/helper/jcr/JcrResourceProvider.java#L476

[2]
https://github.com/apache/sling-org-apache-sling-servlets-post/blob/master/src/main/java/org/apache/sling/servlets/post/impl/SlingPostServlet.java#L237

-- 
Cheers,
Jörg Hoh,

http://cqdump.wordpress.com
Twitter: @joerghoh

[jira] [Commented] (SLING-9874) Allow adapting SlingHttpServletRequest and ResourceResolver to XSSAPI

[Julian Sedding (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-9874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17229933#comment-17229933
 ] 

Julian Sedding commented on SLING-9874:
---

I started a [discussion on the dev mailing 
list|https://lists.apache.org/thread.html/r7d5f78b5974eebab00d60933e65e92fce681648fc685ffad012d676e%40%3Cdev.sling.apache.org%3E].

> Allow adapting SlingHttpServletRequest and ResourceResolver to XSSAPI
> -
>
> Key: SLING-9874
> URL: https://issues.apache.org/jira/browse/SLING-9874
> Project: Sling
>  Issue Type: New Feature
>  Components: XSS Protection API
>Affects Versions: XSS Protection API 2.2.6
>Reporter: Julian Sedding
>Assignee: Julian Sedding
>Priority: Minor
> Fix For: XSS Protection API 2.2.8
>
>
> Most commonly an {{XSSAPI}} instance is needed when rendering a response 
> body. In such circumstances, it can be cumbersome to retrieve the {{XSSAPI}} 
> service. To add some convenience, it would be nice to be able to adapt a 
> {{SlingHttpServletRequest}} or a {{ResourceResolver}} to an {{XSSAPI}} 
> instance.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: [VOTE] Release Apache Sling Content-Package to Feature Model Converter 1.0.18

[Julian Sedding]

+1

Regards
Julian


On Wed, Nov 11, 2020 at 10:38 AM  wrote:
>
> Hi all,
>
> I would like to call the release on the Content-Package to Feature Model
> Converter 1.0.18
> https://issues.apache.org/jira/projects/SLING/versions/12349329
>
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-2375
>
> You can use this UNIX script to download the release and verify the
> signatures:
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
>
> Usage:
> sh check_staged_release.sh 2375 /tmp/sling-staging
>
> Please vote to approve this release:
>
>[ ] +1 Approve the release
>[ ] -1 Don't release, because ...
>
> This majority vote is open for at least 72 hours.
>
> Best regards,
>
> David

[jira] [Created] (SLING-9896) change statuscode in SlingPostServlet for PersistenceException

[Jira]

Jörg Hoh created SLING-9896:
---

 Summary: change statuscode in SlingPostServlet for 
PersistenceException
 Key: SLING-9896
 URL: https://issues.apache.org/jira/browse/SLING-9896
 Project: Sling
  Issue Type: Improvement
  Components: Servlets
Affects Versions: Servlets Post 2.3.36
Reporter: Jörg Hoh


When the SlingPostServlet receives a PersistenceExceptions while trying to 
persist the changes, it should not throw an internal server error, but a 
statuscode of 4xx, because this behavior is expected.

Example stacktrace:


{noformat}
11.11.2020 11:18:38.418 *ERROR* [172.16.123.101 [1605093518414] POST 
/foo/bar.html HTTP/1.1] 
org.apache.sling.servlets.post.impl.operations.ModifyOperation
Exception during response processing.
org.apache.sling.api.resource.PersistenceException: Unable to create node at 
/foo/bar.html
at 
org.apache.sling.jcr.resource.internal.helper.jcr.JcrResourceProvider.create(JcrResourceProvider.java:477)
 [org.apache.sling.jcr.resource:3.0.22]
at 
org.apache.sling.resourceresolver.impl.providers.stateful.AuthenticatedResourceProvider.create(AuthenticatedResourceProvider.java:182)
 [org.apache.sling.resourceresolver:1.7.0]
at 
org.apache.sling.resourceresolver.impl.helper.ResourceResolverControl.create(ResourceResolverControl.java:381)
 [org.apache.sling.resourceresolver:1.7.0]
at 
org.apache.sling.resourceresolver.impl.ResourceResolverImpl.create(ResourceResolverImpl.java:979)
 [org.apache.sling.resourceresolver:1.7.0]
at 
org.apache.sling.servlets.post.impl.operations.AbstractCreateOperation.deepGetOrCreateResource(AbstractCreateOperation.java:598)
 [org.apache.sling.servlets.post:2.3.36]
at 
org.apache.sling.servlets.post.impl.operations.AbstractCreateOperation.processCreate(AbstractCreateOperation.java:146)
 [org.apache.sling.servlets.post:2.3.36]
at 
org.apache.sling.servlets.post.impl.operations.ModifyOperation.doRun(ModifyOperation.java:83)
 [org.apache.sling.servlets.post:2.3.36]
at 
org.apache.sling.servlets.post.impl.operations.AbstractPostOperation.run(AbstractPostOperation.java:99)
 [org.apache.sling.servlets.post:2.3.36]
at 
org.apache.sling.servlets.post.impl.SlingPostServlet.doPost(SlingPostServlet.java:233)
 [org.apache.sling.servlets.post:2.3.36]
at 
org.apache.sling.api.servlets.SlingAllMethodsServlet.mayService(SlingAllMethodsServlet.java:146)
 [org.apache.sling.api:2.22.0]
at 
org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:342)
 [org.apache.sling.api:2.22.0]
[...]
Caused by: javax.jcr.nodetype.ConstraintViolationException: No default node 
type available for /foo/bar.html
at 
org.apache.jackrabbit.oak.plugins.tree.TreeUtil.addChild(TreeUtil.java:234) 
[org.apache.jackrabbit.oak-security-spi:1.35.0]
at 
org.apache.jackrabbit.oak.jcr.delegate.NodeDelegate.addChild(NodeDelegate.java:690)
 [org.apache.jackrabbit.oak-jcr:1.35.0]
at 
org.apache.jackrabbit.oak.jcr.session.NodeImpl$5.perform(NodeImpl.java:314) 
[org.apache.jackrabbit.oak-jcr:1.35.0]
at 
org.apache.jackrabbit.oak.jcr.session.NodeImpl$5.perform(NodeImpl.java:280) 
[org.apache.jackrabbit.oak-jcr:1.35.0]
at 
org.apache.jackrabbit.oak.jcr.delegate.SessionDelegate.perform(SessionDelegate.java:209)
 [org.apache.jackrabbit.oak-jcr:1.35.0]
at 
org.apache.jackrabbit.oak.jcr.session.ItemImpl.perform(ItemImpl.java:112) 
[org.apache.jackrabbit.oak-jcr:1.35.0]
at 
org.apache.jackrabbit.oak.jcr.session.NodeImpl.addNode(NodeImpl.java:280) 
[org.apache.jackrabbit.oak-jcr:1.35.0]
at 
org.apache.jackrabbit.oak.jcr.session.NodeImpl.addNode(NodeImpl.java:265) 
[org.apache.jackrabbit.oak-jcr:1.35.0]
at 
org.apache.sling.jcr.resource.internal.helper.jcr.JcrResourceProvider.create(JcrResourceProvider.java:448)
 [org.apache.sling.jcr.resource:3.0.22]
... 154 common frames omitted
{noformat}




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: [VOTE] Release Sling Adapter Annotations 2.0.0

[Julian Sedding]

+1

Regards
Julian


On Tue, Nov 10, 2020 at 7:11 PM Bertrand Delacretaz
 wrote:
>
> Hi,
>
> This is a new module, at
> https://github.com/apache/sling-org-apache-sling-adapter-annotations
>
> ...not to be confused with the older
> https://github.com/apache/sling-adapter-annotations module, which I
> have renamed with a (JSON) suffix for clarity.
>
> There are still some outstanding issues:
> https://issues.apache.org/jira/projects/SLING/versions/12349370
>
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-2374/
>
> You can use this UNIX script to download the release and verify the 
> signatures:
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
>
> Usage:
> sh check_staged_release.sh 2374 /tmp/sling-staging
>
> Please vote to approve this release:
>
>   [ ] +1 Approve the release
>   [ ]  0 Don't care
>   [ ] -1 Don't release, because ...
>
> This majority vote is open for at least 72 hours.
>
> Here's my +1.
>
> -Bertrand

Re: [VOTE] Release Apache Sling Testing Clients version 2.0.8

[Julian Sedding]

+1

Regards
Julian

On Wed, Nov 11, 2020 at 9:16 AM Stefan Seifert  wrote:
>
> +1

[Jenkins] Sling » Modules » sling-org-apache-sling-starter » master #52 is BROKEN

[Apache Jenkins Server]

Please see 
https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-starter/job/master/52/
 for details.

No further emails will be sent until the status of the build is changed.
Build log follows below:

[...truncated 190 lines...]
[WARNING] Bundle org.apache.sling.jcr.davex:1.3.10 is importing package(s) 
org.osgi.service.event without specifying a version range.
[WARNING] Bundle org.apache.servicemix.bundles.thymeleaf:3.0.11.RELEASE_1 is 
importing package(s) [ognl, com.fasterxml.jackson.core, 
com.fasterxml.jackson.core.io, com.fasterxml.jackson.databind, ognl.enhance] 
without specifying a version range.
[WARNING] Bundle oak-query-spi:1.32.0 is importing package(s) 
org.apache.jackrabbit.oak.spi.state without specifying a version range.
[WARNING] Bundle tika-parsers:1.24 is importing package(s) 
[org.openxmlformats.schemas.wordprocessingml.x2006.main, com.pff, 
org.apache.tika.parser.ner, org.apache.uima.analysis_engine, 
org.apache.poi.hssf.extractor, org.apache.tika.parser.odf, 
org.apache.poi.poifs.crypt, org.apache.tika.parser.geo.topic, ucar.ma2, 
com.epam.parso.impl, com.coremedia.iso.boxes.apple, 
org.apache.tika.parser.mail, 
org.apache.tika.parser.html.charsetdetector.charsets, com.drew.metadata, 
com.uwyn.jhighlight.renderer, org.apache.poi.common.usermodel.fonts, 
org.apache.poi.hslf.usermodel, org.apache.tika.parser.chm.core, 
org.apache.poi.openxml4j.opc.internal, org.apache.http, 
org.apache.sis.metadata.iso, opennlp.tools.sentiment, org.apache.uima.jcas, 
org.openxmlformats.schemas.drawingml.x2006.main, 
org.openxmlformats.schemas.officeDocument.x2006.extendedProperties, 
org.apache.sis.metadata.iso.identification, 
org.apache.ctakes.typesystem.type.refsem, org.apache.poi.xdgf.usermodel, 
org.apache.tika.parser.chm.assertion, com.github.junrar.exception, ucar.nc2, 
org.apache.poi.util, org.apache.poi.hmef, org.apache.sis.metadata.iso.extent, 
de.l3s.boilerpipe.document, org.apache.tika.parser.microsoft.ooxml.xps, 
org.apache.poi.ooxml, org.apache.poi.openxml4j.exceptions, 
org.apache.tika.parser.pkg, org.apache.poi.poifs.macros, 
org.apache.tika.parser.utils, org.apache.poi.ss.usermodel, 
org.apache.sis.metadata.iso.constraint, org.apache.tika.parser.csv, 
org.apache.sis.storage, com.github.junrar, org.apache.http.entity, 
org.apache.ctakes.typesystem.type.textsem, org.apache.poi.ooxml.extractor, 
com.drew.lang, com.googlecode.mp4parser, com.github.junrar.impl, 
ucar.nc2.dataset, org.mozilla.universalchardet, org.apache.xmlbeans, 
org.apache.tika.parser.executable, com.googlecode.mp4parser.util, 
org.apache.poi.ss.util, com.coremedia.iso.boxes, org.apache.poi.hssf.usermodel, 
org.apache.poi.xssf.eventusermodel, com.epam.parso, org.apache.uima.cas.impl, 
org.apache.poi.hssf.model, org.apache.poi.hwpf, org.apache.tika.parser.rtf, 
com.github.junrar.rarfile, org.apache.tika.parser.ocr, 
org.apache.tika.parser.html, org.apache.uima.util, 
org.apache.poi.hssf.eventusermodel, org.apache.poi.openxml4j.opc, 
com.drew.imaging.jpeg, org.apache.poi.ooxml.util, 
org.apache.sis.util.collection, org.apache.poi.hwpf.model, 
org.ccil.cowan.tagsoup, org.apache.poi.hwpf.converter, 
org.apache.poi.hssf.record.common, org.apache.poi.poifs.filesystem, 
org.apache.poi.xssf.extractor, org.apache.poi.xssf.binary, 
com.healthmarketscience.jackcess.impl, com.drew.imaging.webp, 
org.apache.poi.xwpf.extractor, org.apache.tika.parser.chm.accessor, 
org.apache.poi.xssf.usermodel.helpers, org.apache.poi, 
org.apache.poi.common.usermodel, org.apache.pdfbox.tools.imageio, 
com.drew.imaging.riff, org.apache.poi.hpbf.extractor, 
org.apache.poi.hdgf.extractor, org.apache.poi.hslf.exceptions, 
org.apache.poi.hslf.model, org.apache.poi.xslf.usermodel, 
com.coremedia.iso.boxes.sampleentry, org.apache.tika.parser.chm.exception, 
org.apache.tika.parser.xml, org.apache.http.client, 
org.apache.http.client.methods, org.apache.tika.parser.txt, 
org.apache.http.impl.client, com.jmatio.io, org.apache.poi.hwpf.usermodel, 
org.apache.poi.hpsf, org.apache.uima.cas, org.apache.tika.parser.iwork, 
org.apache.tika.parser.recognition, org.apache.poi.ddf, 
org.apache.tika.parser.image, org.apache.uima, 
org.apache.poi.hssf.record.crypto, org.apache.uima.fit.util, 
org.apache.tika.parser.mbox, org.apache.poi.hssf.record, 
org.apache.poi.xslf.extractor, org.apache.sis.internal.util, 
org.apache.uima.jcas.cas, ucar.nc2.util, org.apache.http.client.utils, 
org.openxmlformats.schemas.presentationml.x2006.main, org.apache.poi.extractor, 
org.apache.xmlbeans.impl.values, org.apache.poi.hssf.record.chart, 
org.apache.poi.hwmf.usermodel, org.apache.poi.xwpf.model, 
org.apache.tika.parser.captioning, org.apache.tika.parser.microsoft.ooxml.xslf, 
com.drew.metadata.jpeg, de.l3s.boilerpipe, org.apache.poi.hsmf, 
org.openxmlformats.schemas.drawingml.x2006.spreadsheetDrawing, 
org.apache.tika.parser.jpeg, org.apache.poi.hemf.record.emf, 
org.apache.poi.hemf.usermodel, org.apache.poi.wp.usermodel, 
org.apache.poi.xssf.model, 

Re: [VOTE] Release Apache Sling Content-Package to Feature Model Converter 1.0.18

[Karl Pauls]

+1

regards,

Karl

On Wed, Nov 11, 2020 at 11:36 AM  wrote:
>
> +1
>
> David
>
> On Wed, 11 Nov 2020 at 09:38,  wrote:
>
> > Hi all,
> >
> > I would like to call the release on the Content-Package to Feature Model
> > Converter 1.0.18
> > https://issues.apache.org/jira/projects/SLING/versions/12349329
> >
> > Staging repository:
> > https://repository.apache.org/content/repositories/orgapachesling-2375
> >
> > You can use this UNIX script to download the release and verify the
> > signatures:
> >
> > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
> >
> > Usage:
> > sh check_staged_release.sh 2375 /tmp/sling-staging
> >
> > Please vote to approve this release:
> >
> >[ ] +1 Approve the release
> >[ ] -1 Don't release, because ...
> >
> > This majority vote is open for at least 72 hours.
> >
> > Best regards,
> >
> > David
> >



-- 
Karl Pauls
karlpa...@gmail.com

Re: [VOTE] Release Apache Sling Content-Package to Feature Model Converter 1.0.18

[davidb]

+1

David

On Wed, 11 Nov 2020 at 09:38,  wrote:

> Hi all,
>
> I would like to call the release on the Content-Package to Feature Model
> Converter 1.0.18
> https://issues.apache.org/jira/projects/SLING/versions/12349329
>
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-2375
>
> You can use this UNIX script to download the release and verify the
> signatures:
>
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
>
> Usage:
> sh check_staged_release.sh 2375 /tmp/sling-staging
>
> Please vote to approve this release:
>
>[ ] +1 Approve the release
>[ ] -1 Don't release, because ...
>
> This majority vote is open for at least 72 hours.
>
> Best regards,
>
> David
>

Re: [VOTE] Release Apache Sling Content-Package to Feature Model Converter 1.0.18

[Carsten Ziegeler]

+1

Carsten

Am 11.11.2020 um 10:38 schrieb dav...@apache.org:

Hi all,

I would like to call the release on the Content-Package to Feature Model
Converter 1.0.18
https://issues.apache.org/jira/projects/SLING/versions/12349329

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2375

You can use this UNIX script to download the release and verify the
signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2375 /tmp/sling-staging

Please vote to approve this release:

[ ] +1 Approve the release
[ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Best regards,

David



--
--
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

[VOTE] Release Apache Sling Content-Package to Feature Model Converter 1.0.18

[davidb]

Hi all,

I would like to call the release on the Content-Package to Feature Model
Converter 1.0.18
https://issues.apache.org/jira/projects/SLING/versions/12349329

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2375

You can use this UNIX script to download the release and verify the
signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2375 /tmp/sling-staging

Please vote to approve this release:

   [ ] +1 Approve the release
   [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Best regards,

David

[jira] [Resolved] (SLING-9881) CPConverter dropping type information on sling:OsgiConfig nodes

[A. J. David Bosschaert (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

A. J. David Bosschaert resolved SLING-9881.
---
Resolution: Fixed

> CPConverter dropping type information on sling:OsgiConfig nodes
> ---
>
> Key: SLING-9881
> URL: https://issues.apache.org/jira/browse/SLING-9881
> Project: Sling
>  Issue Type: Bug
>  Components: Content-Package to Feature Model Converter
>Affects Versions: Content-Package to Feature Model Converter 1.0.16
>Reporter: Dominik Süß
>Priority: Critical
> Fix For: Content-Package to Feature Model Converter 1.1.0
>
>
> The implementation of the converter for sling:OsgiConfig nodes 
> (XmlConfigurationEntryHandler) currently ignores the type of the properties 
> and transforms everything into Strings (as DocViewProperty returns values as 
> String representations with separate type property).
> This leads to broken configurations in case of the use of those config nodes 
> with typed properties.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Resolved] (SLING-9894) CP Converter not defining explicit dependency of embedded package on parent

[A. J. David Bosschaert (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

A. J. David Bosschaert resolved SLING-9894.
---
Resolution: Fixed

> CP Converter not defining explicit dependency of embedded package on parent
> ---
>
> Key: SLING-9894
> URL: https://issues.apache.org/jira/browse/SLING-9894
> Project: Sling
>  Issue Type: Bug
>  Components: Content-Package to Feature Model Converter
>Affects Versions: Content-Package to Feature Model Converter 1.0.16
>Reporter: Dominik Süß
>Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.1.0
>
>
> An embedded package of a non-container package (/libs/xy/install) when 
> installed via OSGI installer will always be installed after the parent 
> package even when there is no explicit dependency. The converter misses to 
> convert this implicit dependency into an explict dependency which can cause 
> the order to differ and therefore cause oversights of ordering issues. To 
> align this packages need to set up an explicit dependency to a parent package 
> unless this is a container package which would be treated as non-existing and 
> therefore removed.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [sling-org-apache-sling-feature-cpconverter] bosschaert merged pull request #32: Issue/sling 9881

[GitBox]

bosschaert merged pull request #32:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/32


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #32: Issue/sling 9881

[GitBox]

sonarcloud[bot] commented on pull request #32:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/32#issuecomment-725306690


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=32=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=32=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=32=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=32=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=32=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=32=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter
 uest=32=false=SECURITY_HOTSPOT) [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=32=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=32=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=32=false=CODE_SMELL)
 [5 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=32=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=32=new_coverage=list)
 [91.2% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=32=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=32=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=32=new_duplicated_lines_density=list)
   
The version of Java (1.8.0_252) you 
have used to run this analysis is deprecated and we will stop accepting it 
accepting it soon.Please update to at least Java 11.
   Read more [here](https://sonarcloud.io/documentation/upcoming/)
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] removed a comment on pull request #32: Issue/sling 9881

[GitBox]

sonarcloud[bot] removed a comment on pull request #32:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/32#issuecomment-724571619


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=32=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=32=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=32=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=32=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=32=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=32=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter
 uest=32=false=SECURITY_HOTSPOT) [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=32=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=32=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=32=false=CODE_SMELL)
 [5 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=32=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=32=new_coverage=list)
 [90.9% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=32=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=32=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=32=new_duplicated_lines_density=list)
   
The version of Java (1.8.0_252) you 
have used to run this analysis is deprecated and we will stop accepting it 
accepting it soon.Please update to at least Java 11.
   Read more [here](https://sonarcloud.io/documentation/upcoming/)
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Resolved] (SLING-9895) Provide more information to extension handlers

[Carsten Ziegeler (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-9895.
-
Resolution: Fixed

Added two new boolean methods to the HandlerContext
https://github.com/apache/sling-org-apache-sling-feature/commit/5c446a04d85dfc2407665749e5f0bf900dc02efe

> Provide more information to extension handlers
> --
>
> Key: SLING-9895
> URL: https://issues.apache.org/jira/browse/SLING-9895
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Feature Model 1.2.14
>
>
> Extension handlers get a source and a target and are invoked to merge the 
> source into the target. For example if two features are aggregated, a handler 
> is invoked twice, the target is always the resulting feature and the source 
> is the first feature and then the second feature.
> If an extension handler wants to act on data of the aggregated features 
> (first and second feature in this case), the handler does not have a clue 
> when it is invoked about the state.
> In addition, the same handlers are also used to process a prototype feature - 
> in some cases processing of prototypes might be different from aggregation



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [sling-org-apache-sling-feature-cpconverter] bosschaert merged pull request #34: SLING-9894 - setting explicit dependency from embedded to non-contain…

[GitBox]

bosschaert merged pull request #34:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/34


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Created] (SLING-9895) Provide more information to extension handlers

[Carsten Ziegeler (Jira)]

Carsten Ziegeler created SLING-9895:
---

 Summary: Provide more information to extension handlers
 Key: SLING-9895
 URL: https://issues.apache.org/jira/browse/SLING-9895
 Project: Sling
  Issue Type: Improvement
  Components: Feature Model
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: Feature Model 1.2.14


Extension handlers get a source and a target and are invoked to merge the 
source into the target. For example if two features are aggregated, a handler 
is invoked twice, the target is always the resulting feature and the source is 
the first feature and then the second feature.
If an extension handler wants to act on data of the aggregated features (first 
and second feature in this case), the handler does not have a clue when it is 
invoked about the state.
In addition, the same handlers are also used to process a prototype feature - 
in some cases processing of prototypes might be different from aggregation



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [sling-org-apache-sling-feature-cpconverter] bosschaert commented on pull request #34: SLING-9894 - setting explicit dependency from embedded to non-contain…

[GitBox]

bosschaert commented on pull request #34:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/34#issuecomment-725300280


   LGTM



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Updated] (SLING-9894) CP Converter not defining explicit dependency of embedded package on parent

[A. J. David Bosschaert (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

A. J. David Bosschaert updated SLING-9894:
--
Fix Version/s: Content-Package to Feature Model Converter 1.1.0

> CP Converter not defining explicit dependency of embedded package on parent
> ---
>
> Key: SLING-9894
> URL: https://issues.apache.org/jira/browse/SLING-9894
> Project: Sling
>  Issue Type: Bug
>  Components: Content-Package to Feature Model Converter
>Affects Versions: Content-Package to Feature Model Converter 1.0.16
>Reporter: Dominik Süß
>Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.1.0
>
>
> An embedded package of a non-container package (/libs/xy/install) when 
> installed via OSGI installer will always be installed after the parent 
> package even when there is no explicit dependency. The converter misses to 
> convert this implicit dependency into an explict dependency which can cause 
> the order to differ and therefore cause oversights of ordering issues. To 
> align this packages need to set up an explicit dependency to a parent package 
> unless this is a container package which would be treated as non-existing and 
> therefore removed.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: [VOTE] Release Sling Adapter Annotations 2.0.0

[Konrad Windszus]

+1
Konrad

> On 10. Nov 2020, at 19:11, Bertrand Delacretaz  wrote:
> 
> Hi,
> 
> This is a new module, at
> https://github.com/apache/sling-org-apache-sling-adapter-annotations
> 
> ...not to be confused with the older
> https://github.com/apache/sling-adapter-annotations module, which I
> have renamed with a (JSON) suffix for clarity.
> 
> There are still some outstanding issues:
> https://issues.apache.org/jira/projects/SLING/versions/12349370
> 
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-2374/
> 
> You can use this UNIX script to download the release and verify the 
> signatures:
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
> 
> Usage:
> sh check_staged_release.sh 2374 /tmp/sling-staging
> 
> Please vote to approve this release:
> 
>  [ ] +1 Approve the release
>  [ ]  0 Don't care
>  [ ] -1 Don't release, because ...
> 
> This majority vote is open for at least 72 hours.
> 
> Here's my +1.
> 
> -Bertrand

RE: [VOTE] Release Apache Sling Testing Clients version 2.0.8

[Stefan Seifert]

+1

RE: [VOTE] Release Sling Adapter Annotations 2.0.0

[Stefan Seifert]

+1