Hi Konrad, On Fri, 2020-11-06 at 16:47 +0100, Konrad Windszus wrote: > Sorry I haven't checked the code up till now. > Some questions/remarks: > > 1. Why filevault-package-maven-plugin 1.1.2 and not the latest > version 1.1.4?
It was the latest version available at the time. I just pushed an update https://github.com/apache/sling-content-package-archetype/commit/6286389 > 2. It is using a mixed package (mutable/potentially immutable > content), why do we propose that instead of a clear separation with > three different modules (apps. content, container) I wanted to go with something very simple. But on the other hand I don't want to go with something that is against current best practices. Would you mind filing an issue for points 2-5? I will cancel the current vote and get back to dev@ once I think it's ready. Thanks! Robert > 3. I would recommend setting a dedicated package type in the > configuration ( > https://github.com/apache/sling-content-package-archetype/blob/30380a1d75abfaafa1aa67d487f01b3123575777/src/main/resources/archetype-resources/pom.xml#L49 > < > https://github.com/apache/sling-content-package-archetype/blob/30380a1d75abfaafa1aa67d487f01b3123575777/src/main/resources/archetype-resources/pom.xml#L49> > ;) > 4. Would it make sense to embed a bundle here as well? > 5. As archetypes don't allow speaking description for properties > these either need a documentation and/or a very speaking name. IMHO > shortName ( > https://github.com/apache/sling-content-package-archetype/blob/30380a1d75abfaafa1aa67d487f01b3123575777/src/main/resources/META-INF/maven/archetype-metadata.xml#L39 > < > https://github.com/apache/sling-content-package-archetype/blob/30380a1d75abfaafa1aa67d487f01b3123575777/src/main/resources/META-INF/maven/archetype-metadata.xml#L39> > ;) is not good enough, given that there is not a readme.... > > Thanks and sorry for the late feedback, > Konrad > > > On 6. Nov 2020, at 13:18, Robert Munteanu <romb...@apache.org> > > wrote: > > > > Hi, > > > > This is a first release of the tooling, so no issues fixed (but a > > version was created): > > https://issues.apache.org/jira/browse/SLING/fixforversion/12349357 > > > > Staging repository: > > https://repository.apache.org/content/repositories/orgapachesling-2369/ > > > > You can use this UNIX script to download the release and verify the > > signatures: > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > > > Usage: > > sh check_staged_release.sh 2369 /tmp/sling-staging > > > > Please vote to approve this release: > > > > [ ] +1 Approve the release > > [ ] 0 Don't care > > [ ] -1 Don't release, because ... > > > > This majority vote is open for at least 72 hours. > > > > Regards, > > Robert Munteanu > >
