Re: state of sling-org-apache-sling-starter

[Ruben Reusser]

here's the current list of mismatches:

org.apache.sling.commons.fsclassloader starter: 1.0.14 downloads: 1.0.8
org.apache.sling.commons.scheduler starter: 2.7.6 downloads: 2.7.2
org.apache.sling.models.impl starter: 1.4.12 downloads: 1.4.16
org.apache.sling.serviceusermapper starter: 1.4.4 downloads: 1.4.2
org.apache.sling.servlets.resolver starter: 2.7.10 downloads: 2.7.8
org.apache.sling.commons.johnzon starter: 1.2.4 downloads: 1.2.6
org.apache.sling.commons.osgi starter: 2.4.0 downloads: 2.4.2
org.apache.sling.installer.core starter: 3.11.2 downloads: 3.11.4
org.apache.sling.settings starter: 1.4.0 downloads: 1.4.2
org.apache.sling.discovery.oak starter: 1.2.28 downloads: 1.2.30
org.apache.sling.discovery.support starter: 1.0.4 downloads: 1.0.6
org.apache.sling.jcr.contentloader starter: 2.3.0 downloads: 2.4.0
org.apache.sling.extensions.webconsolesecurityprovider starter: 1.2.4 
downloads: 1.2.2



On Tue, Nov 24, 2020 at 5:13 pm, Bertrand Delacretaz 
 wrote:

Hi Ruben,

On Tue, Nov 24, 2020 at 4:29 PM Ruben Reusser > wrote:
 ...is there a process to update the starter and the downloads page 
when a

 new version of a bundle is released?...


Updating it is part of our release instructions at


But I suspect we miss that sometimes - patches welcome of course!

-Bertrand

[GitHub] [sling-org-apache-sling-junit-core] cmrockwell commented on pull request #5: Sling 9915 support for sling annotations test runner

[GitBox]

cmrockwell commented on pull request #5:
URL: 
https://github.com/apache/sling-org-apache-sling-junit-core/pull/5#issuecomment-733281786


   > I think a similar setup would work for your tests, creating a distinct 
test bundle in the same junit-core repository and testing it via the invoker 
plugin? Happy to help with the "details" if needed.
   
   I tried setting the integration-testing approach using PAX. I pushed a 
[commit](https://github.com/apache/sling-org-apache-sling-junit-core/commit/b6de942fccb17f99fd44077c693afe55a2bcdfab)
 to a separate branch,  SLING-9915-junit-annotation-int-tests for review. 
   
   I've switched for the time being to Java 8, because the example project 
(sling-org-apache-sling-servlets-annotations) has builds errors with Java 11. 
Even with Java 8, my version fails. The system properties are null. Any 
pointers would be much appreciated. 
   
   > [INFO] [INFO] Running org.apache.sling.junit.annotations.TestReferenceIT
   [INFO] <<<
   [INFO] Bundle File
   [INFO] null
   [INFO] jacoco
   [INFO] null
   [INFO] pax.vm.options
   [INFO] null
   [INFO] <<<
   [INFO] [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time 
elapsed: 0.456 s <<< FAILURE! - in 
org.apache.sling.junit.annotations.TestReferenceIT
   [INFO] [ERROR] org.apache.sling.junit.annotations.TestReferenceIT  Time 
elapsed: 0.449 s  <<< ERROR!
   [INFO] java.lang.reflect.InvocationTargetException
   [INFO]   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
   [INFO]   at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
   [INFO]   at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
   [INFO]   at java.lang.reflect.Method.invoke(Method.java:498)
   [INFO]   at 
org.ops4j.pax.exam.junit.PaxExamServer.getConfigurationOptions(PaxExamServer.java:98)
   [INFO]   at 
org.ops4j.pax.exam.junit.PaxExamServer.before(PaxExamServer.java:84)
   [INFO]   at 
org.apache.sling.junit.annotations.TestReferenceIT$1.before(TestReferenceIT.java:56)
   [INFO]   at 
org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:50)
   [INFO]   at org.junit.rules.RunRules.evaluate(RunRules.java:20)
   [INFO]   at 
org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
   [INFO]   at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
   [INFO]   at 
org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:365)
   [INFO]   at 
org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:273)
   [INFO]   at 
org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238)
   [INFO]   at 
org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:159)
   [INFO]   at 
org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:377)
   [INFO]   at 
org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:138)
   [INFO]   at 
org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:465)
   [INFO]   at 
org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:451)
   [INFO] Caused by: java.lang.NullPointerException
   [INFO]   at java.io.File.(File.java:277)
   [INFO]   at 
org.apache.sling.testing.paxexam.TestSupport.testBundle(TestSupport.java:103)
   [INFO]   at 
org.apache.sling.junit.annotations.TestReferenceIT.configuration(TestReferenceIT.java:98)
   [INFO]   ... 19 more
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-servlets-post] enapps-enorman edited a comment on pull request #6: SLING-9896 handle PersistenceExceptions explicitly and throw a 405

[GitBox]

enapps-enorman edited a comment on pull request #6:
URL: 
https://github.com/apache/sling-org-apache-sling-servlets-post/pull/6#issuecomment-733247057


   > Hi @enapps-enorman
   > 
   > Regarding extensibility: I don't see any request to make the existing 
implementation more extensible regarding the handling of the return code, so I 
am bit hesitant to add a bunch of code, which we don't need (yet). Are you 
aware of features or feature requests which require this?
   > 
   
   Well, yes.  The problem you are attempting to fix is the feature request 
that the proposed solution would solve.
   
   > And regarding backwards compatibility of the change: Yes, we could easily 
add a flag (via OSGI propertieis), which reverts to the old behavior and return 
a 500. But I would definitely change the default to a 405.
   
   I have no problem with changing to a better default as long as it is well 
documented and the end users are given fair warning.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-servlets-post] enapps-enorman commented on pull request #6: SLING-9896 handle PersistenceExceptions explicitly and throw a 405

[GitBox]

enapps-enorman commented on pull request #6:
URL: 
https://github.com/apache/sling-org-apache-sling-servlets-post/pull/6#issuecomment-733247057


   > Hi @enapps-enorman
   > 
   > Regarding extensibility: I don't see any request to make the existing 
implementation more extensible regarding the handling of the return code, so I 
am bit hesitant to add a bunch of code, which we don't need (yet). Are you 
aware of features or feature requests which require this?
   > 
   
   Well, yes.  The problem you are attempting to fix is the feature request 
that the proposed solution would solve.
   
   > And regarding backwards compatibility of the change: Yes, we could easily 
add a flag (via OSGI propertieis), which reverts to the old behavior and return 
a 500. But I would definitely change the default to a 405.
   
   I have no problem with changing to a better defaults as long as it is well 
documented and the end users are given fair warning.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (SLING-9929) Use PaxExamServer for HTTP-based integration testing

[Oliver Lietz (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-9929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17238354#comment-17238354
 ] 

Oliver Lietz commented on SLING-9929:
-

[~bdelacretaz], This could be a major change which would fit into the upcoming 
4.0.0 release (WIP).

> Use PaxExamServer for HTTP-based integration testing
> 
>
> Key: SLING-9929
> URL: https://issues.apache.org/jira/browse/SLING-9929
> Project: Sling
>  Issue Type: Improvement
>  Components: Testing
>Affects Versions: Testing PaxExam 3.1.0
>Reporter: Bertrand Delacretaz
>Assignee: Bertrand Delacretaz
>Priority: Minor
>
> We've discussed this in SLING-7993 and I have created a minimal example (with 
> Karate, but other HTTP clients work similarly) at 
> [https://github.com/bdelacretaz/karate-pax-exam]
> This ticket is meant to coordinate efforts around how to use the 
> {{PaxExamServer}} utility to run "out-of-process" tests via HTTP against a 
> minimal Sling instance setup using the 
> https://github.com/apache/sling-org-apache-sling-testing-paxexam/ tools.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-9929) Use PaxExamServer for HTTP-based integration testing

[Oliver Lietz (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz updated SLING-9929:

Fix Version/s: Testing PaxExam 4.0.0

> Use PaxExamServer for HTTP-based integration testing
> 
>
> Key: SLING-9929
> URL: https://issues.apache.org/jira/browse/SLING-9929
> Project: Sling
>  Issue Type: Improvement
>  Components: Testing
>Affects Versions: Testing PaxExam 3.1.0
>Reporter: Bertrand Delacretaz
>Assignee: Bertrand Delacretaz
>Priority: Minor
> Fix For: Testing PaxExam 4.0.0
>
>
> We've discussed this in SLING-7993 and I have created a minimal example (with 
> Karate, but other HTTP clients work similarly) at 
> [https://github.com/bdelacretaz/karate-pax-exam]
> This ticket is meant to coordinate efforts around how to use the 
> {{PaxExamServer}} utility to run "out-of-process" tests via HTTP against a 
> minimal Sling instance setup using the 
> https://github.com/apache/sling-org-apache-sling-testing-paxexam/ tools.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-9934) Fix typo in option spifly

[Oliver Lietz (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz updated SLING-9934:

Fix Version/s: (was: Testing PaxExam 4.0.2)
   Testing PaxExam 4.0.0

> Fix typo in option spifly
> -
>
> Key: SLING-9934
> URL: https://issues.apache.org/jira/browse/SLING-9934
> Project: Sling
>  Issue Type: Task
>  Components: Testing
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: Testing PaxExam 4.0.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (SLING-9935) NoClassDefFoundError org/junit/platform/engine/TestEngine

[Cris Rockwell (Jira)]

Cris Rockwell created SLING-9935:


 Summary: NoClassDefFoundError org/junit/platform/engine/TestEngine
 Key: SLING-9935
 URL: https://issues.apache.org/jira/browse/SLING-9935
 Project: Sling
  Issue Type: Bug
  Components: JUnit Core
Affects Versions: JUnit Core 1.1.2
Reporter: Cris Rockwell


When starting Sling with org.apache.sling.junit.core v 1.1.1-SNAPSHOT, standard 
output shows many exceptions related to an optional import upon startup. 

 

ERROR: Bundle org.apache.sling.junit.core [189] EventDispatcher: Error during 
dispatch. (java.lang.NoClassDefFoundError: org/junit/platform/engine/TestEngine)

ERROR: Bundle org.apache.sling.junit.core [189] EventDispatcher: Error during 
dispatch. (java.lang.NoClassDefFoundError: 
org/junit/platform/engine/TestEngine)java.lang.NoClassDefFoundError: 
org/junit/platform/engine/TestEngine at 
org.apache.sling.junit.impl.servlet.junit5.TestEngineTracker$Customizer.getTestEnginesForBundle(TestEngineTracker.java:83)
 at 
org.apache.sling.junit.impl.servlet.junit5.TestEngineTracker$Customizer.addingBundle(TestEngineTracker.java:67)
 at 
org.apache.sling.junit.impl.servlet.junit5.TestEngineTracker$Customizer.addingBundle(TestEngineTracker.java:63)
 at 
org.osgi.util.tracker.BundleTracker$Tracked.customizerAdding(BundleTracker.java:475)
 at 
org.osgi.util.tracker.BundleTracker$Tracked.customizerAdding(BundleTracker.java:420)
 at org.osgi.util.tracker.AbstractTracked.trackAdding(AbstractTracked.java:256) 
at org.osgi.util.tracker.AbstractTracked.track(AbstractTracked.java:229) at 
org.osgi.util.tracker.BundleTracker$Tracked.bundleChanged(BundleTracker.java:450)
 at 
org.apache.felix.framework.EventDispatcher.invokeBundleListenerCallback(EventDispatcher.java:915)
 at 
org.apache.felix.framework.EventDispatcher.fireEventImmediately(EventDispatcher.java:834)
 at 
org.apache.felix.framework.EventDispatcher.fireBundleEvent(EventDispatcher.java:516)
 at org.apache.felix.framework.Felix.fireBundleEvent(Felix.java:4817) at 
org.apache.felix.framework.Felix.startBundle(Felix.java:2336) at 
org.apache.felix.framework.Felix.setActiveStartLevel(Felix.java:1539) at 
org.apache.felix.framework.FrameworkStartLevelImpl.run(FrameworkStartLevelImpl.java:308)
 at java.base/java.lang.Thread.run(Thread.java:834)

ERROR: Bundle org.apache.sling.junit.core [189] EventDispatcher: Error during 
dispatch. (java.lang.NoClassDefFoundError: 
org/junit/platform/engine/TestEngine)java.lang.NoClassDefFoundError: 
org/junit/platform/engine/TestEngine at 
org.apache.sling.junit.impl.servlet.junit5.TestEngineTracker$Customizer.getTestEnginesForBundle(TestEngineTracker.java:83)
 at 
org.apache.sling.junit.impl.servlet.junit5.TestEngineTracker$Customizer.addingBundle(TestEngineTracker.java:67)
 at 
org.apache.sling.junit.impl.servlet.junit5.TestEngineTracker$Customizer.addingBundle(TestEngineTracker.java:63)
 at 
org.osgi.util.tracker.BundleTracker$Tracked.customizerAdding(BundleTracker.java:475)
 at 
org.osgi.util.tracker.BundleTracker$Tracked.customizerAdding(BundleTracker.java:420)
 at org.osgi.util.tracker.AbstractTracked.trackAdding(AbstractTracked.java:256) 
at org.osgi.util.tracker.AbstractTracked.track(AbstractTracked.java:229) at 
org.osgi.util.tracker.BundleTracker$Tracked.bundleChanged(BundleTracker.java:450)
 at 
org.apache.felix.framework.EventDispatcher.invokeBundleListenerCallback(EventDispatcher.java:915)
 at 
org.apache.felix.framework.EventDispatcher.fireEventImmediately(EventDispatcher.java:834)
 at 
org.apache.felix.framework.EventDispatcher.fireBundleEvent(EventDispatcher.java:516)
 at org.apache.felix.framework.Felix.fireBundleEvent(Felix.java:4817) at 
org.apache.felix.framework.Felix.startBundle(Felix.java:2336) at 
org.apache.felix.framework.Felix.setActiveStartLevel(Felix.java:1539) at 
org.apache.felix.framework.FrameworkStartLevelImpl.run(FrameworkStartLevelImpl.java:308)
 at java.base/java.lang.Thread.run(Thread.java:834)

ERROR: Bundle org.apache.sling.junit.core [189] EventDispatcher: Error during 
dispatch. (java.lang.NoClassDefFoundError: 
org/junit/platform/engine/TestEngine)java.lang.NoClassDefFoundError: 
org/junit/platform/engine/TestEngine at 
org.apache.sling.junit.impl.servlet.junit5.TestEngineTracker$Customizer.getTestEnginesForBundle(TestEngineTracker.java:83)
 at 
org.apache.sling.junit.impl.servlet.junit5.TestEngineTracker$Customizer.addingBundle(TestEngineTracker.java:67)
 at 
org.apache.sling.junit.impl.servlet.junit5.TestEngineTracker$Customizer.addingBundle(TestEngineTracker.java:63)
 at 
org.osgi.util.tracker.BundleTracker$Tracked.customizerAdding(BundleTracker.java:475)
 at 
org.osgi.util.tracker.BundleTracker$Tracked.customizerAdding(BundleTracker.java:420)
 at org.osgi.util.tracker.AbstractTracked.trackAdding(AbstractTracked.java:256) 
at org.osgi.util.tracker.AbstractTracked.track(AbstractTracked.java:229) at 

Re: state of sling-org-apache-sling-starter

[Bertrand Delacretaz]

Hi Ruben,

On Tue, Nov 24, 2020 at 4:29 PM Ruben Reusser  wrote:
> ...is there a process to update the starter and the downloads page when a
> new version of a bundle is released?...

Updating it is part of our release instructions at
https://sling.apache.org/documentation/development/release-management.html#update-the-sling-starter-module-1

But I suspect we miss that sometimes - patches welcome of course!

-Bertrand

[jira] [Created] (SLING-9934) Fix typo in option spifly

[Oliver Lietz (Jira)]

Oliver Lietz created SLING-9934:
---

 Summary: Fix typo in option spifly
 Key: SLING-9934
 URL: https://issues.apache.org/jira/browse/SLING-9934
 Project: Sling
  Issue Type: Task
  Components: Testing
Reporter: Oliver Lietz
Assignee: Oliver Lietz
 Fix For: Testing PaxExam 4.0.0






--
This message was sent by Atlassian Jira
(v8.3.4#803005)

state of sling-org-apache-sling-starter

[Ruben Reusser]

dear sling devs

I was looking at the feature files in sling starter as bit today and 
noticed some discrepancies between the sling starter and the latest 
released modules list on the sling website


just some examples:

org.apache.sling:org.apache.sling.commons.osgi starter: 2.4.0, downloads 
page : 2.4.2
org.apache.sling:org.apache.sling.commons.fsclassloader, starter: 
1.0.14, downloads page: 1.0.8


is there a process to update the starter and the downloads page when a 
new version of a bundle is released?


Ruben

[1] https://github.com/apache/sling-org-apache-sling-starter/
[2] https://sling.apache.org/downloads.cgi

[GitHub] [sling-org-apache-sling-servlets-post] joerghoh commented on pull request #6: SLING-9896 handle PersistenceExceptions explicitly and throw a 405

[GitBox]

joerghoh commented on pull request #6:
URL: 
https://github.com/apache/sling-org-apache-sling-servlets-post/pull/6#issuecomment-733045651


   Hi @enapps-enorman 
   
   Regarding extensibility: I don't see any request to make the existing 
implementation more extensible regarding the handling of the return code, so I 
am bit hesitant to add a bunch of code, which we don't need (yet).  Are you 
aware of features or feature requests which require this?
   
   And regarding backwards compatibility of the change: Yes, we could easily 
add a flag (via OSGI propertieis), which reverts to the old behavior and return 
a 500. But I would definitely change the default to a 405.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-junit-core] jsedding commented on pull request #5: Sling 9915 support for sling annotations test runner

[GitBox]

jsedding commented on pull request #5:
URL: 
https://github.com/apache/sling-org-apache-sling-junit-core/pull/5#issuecomment-733041714


   > 
   > `Import-Package: org.junit.platform.*;resolution:=optional, \`
   > 
   > Is this something to be addressed here or later?
   
   @cmrockwell could you please open a separate issue for the exception please? 
If you're interested you can read [documentation about the JUnit5 
support](https://sling.apache.org/documentation/bundles/org-apache-sling-junit-bundles.html#junit-5-support-since-version-110-1)
 for some background on why the imports are optional and how things should work.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [VOTE][LAZY] deprecate the sling-org-apache-sling-servlets-annotations-it module

[Julian Sedding]

+1

Regards
Julian

On Tue, Nov 24, 2020 at 12:14 PM Bertrand Delacretaz
 wrote:
>
> Hi,
>
> In SLING-9930 I have merged the integration tests that were in the
> sling-org-apache-sling-servlets-annotations-it module in the main
> sling-org-apache-sling-servlets-annotations module.
>
> As the former is not needed anymore I suggest deprecating it,
> https://github.com/apache/sling-org-apache-sling-servlets-annotations-it
> , according to the instructions at
> https://sling.apache.org/documentation/development/deprecating-sling-modules.html
>
> I'll wait at least 24 hours before proceeding, in case someone has an 
> objection.
>
> -Bertrand

[GitHub] [sling-org-apache-sling-junit-core] jsedding commented on a change in pull request #5: Sling 9915 support for sling annotations test runner

[GitBox]

jsedding commented on a change in pull request #5:
URL: 
https://github.com/apache/sling-org-apache-sling-junit-core/pull/5#discussion_r529609030



##
File path: 
src/main/java/org/apache/sling/junit/annotations/SlingAnnotationsTestRunner.java
##
@@ -56,4 +57,16 @@ protected Object createTest() throws Exception {
 return top.process(super.createTest());
 }
 }
+
+@Override
+public void run(RunNotifier notifier){
+try {
+super.run(notifier);
+} catch (Exception e) {
+log.error("Test 'run' method", e);
+} finally {
+AnnotationsProcessor ap = (AnnotationsProcessor) top;
+ap.closeAllServices();

Review comment:
   I think this is not what you want to do here. If I understand the code 
correctly, `AnnotationsProcessor` implements `TestObjectProcessor` and is a 
service, which in turn implies it is a singleton. On the other hand, there is 
probably an instance of `SlingAnnotationsTestRunner` per test class. The 
current code, if I read it correctly, closes all services of all tests. This 
may not be a practical issue as long as tests are not executed concurrently, 
but it is still not correct.
   
   The `ServiceGetter` instances are created for a specific test, namely the 
one created by the call `top.process(super.createTest());` above. I would add a 
method to `TestObjectProcessor` that allows cleaning up after a test. I'll 
provisionally call it `TestObjectProcessor#cleanupTest(Object test)`. Then 
instead of keeping an instance of `TestObjectProcessor` in a field, I would 
keep an instance of the `Object` returned by `super.createTest()` in a field. 
In the finally block, this object can then be passed to the cleanup method.
   
   In `AnnotationsProcessor` you keep an `IdentityHashMap>`, which you initialize in the `#process(Object)` method. 
Finally, in the `#cleanup(Object)` method, you close all `ServiceGetter`s 
pertaining to the `object` and remove it from the map. Don't forget to clear 
the map on `@Deactivate` of `AnnotationsProcessor`.
   
   You may want to provide a no-op default implementation of `#cleanup(Object)` 
in the interface `TestObjectProcessor`. This might (I'm not sure it does) 
reduce the required version increase, and it would certainly keep any 
implementations out in the wild running without code changes (if they indeed 
exist... who knows).
   
   ALTERNATIVE: If you're feeling adventurous and have some time, there would 
be an alternative to adding a new method to the API. You could use 
`WeakReference` and `ReferenceQueue` with a cleanup thread inside 
`AnnotationsProcessor` in order to close the `ServiceGetter`s. The approach is 
[nicely summed up on stack 
overflow](https://stackoverflow.com/questions/14450538/using-javas-referencequeue/14450693#14450693),
 where `Foo` would be the test `Object` and `Bar` the `List`.

##
File path: src/main/java/org/apache/sling/junit/impl/AnnotationsProcessor.java
##
@@ -35,9 +34,11 @@
 public class AnnotationsProcessor implements TestObjectProcessor {
 private Logger log = LoggerFactory.getLogger(getClass());
 private BundleContext bundleContext;
-
+private ArrayList> serviceGetters;

Review comment:
   I prefer using interface types for all fields rather than 
implementations. That makes refactoring to a different type easier and the diff 
less noisy.

##
File path: 
src/main/java/org/apache/sling/junit/annotations/SlingAnnotationsTestRunner.java
##
@@ -56,4 +57,16 @@ protected Object createTest() throws Exception {
 return top.process(super.createTest());
 }
 }
+
+@Override
+public void run(RunNotifier notifier){
+try {
+super.run(notifier);
+} catch (Exception e) {
+log.error("Test 'run' method", e);

Review comment:
   Don't catch the exception here. You are decorating, so ideally the 
calling code gets the same result as without the decoration (except for desired 
changes/side-effects). In case my previous comments prompted you to add the 
catch block, I'm sorry for causing confusion. The finally block is sufficient, 
because it gets called in any case, exception or not.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (SLING-9929) Use PaxExamServer for HTTP-based integration testing

[Bertrand Delacretaz (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-9929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17238191#comment-17238191
 ] 

Bertrand Delacretaz commented on SLING-9929:


I'll try to have a look but I don't know when that will happen, I have to 
switch to something else now. Let's use this ticket to coordinate!

> Use PaxExamServer for HTTP-based integration testing
> 
>
> Key: SLING-9929
> URL: https://issues.apache.org/jira/browse/SLING-9929
> Project: Sling
>  Issue Type: Improvement
>  Components: Testing
>Affects Versions: Testing PaxExam 3.1.0
>Reporter: Bertrand Delacretaz
>Assignee: Bertrand Delacretaz
>Priority: Minor
>
> We've discussed this in SLING-7993 and I have created a minimal example (with 
> Karate, but other HTTP clients work similarly) at 
> [https://github.com/bdelacretaz/karate-pax-exam]
> This ticket is meant to coordinate efforts around how to use the 
> {{PaxExamServer}} utility to run "out-of-process" tests via HTTP against a 
> minimal Sling instance setup using the 
> https://github.com/apache/sling-org-apache-sling-testing-paxexam/ tools.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [sling-org-apache-sling-junit-core] cmrockwell commented on pull request #5: Sling 9915 support for sling annotations test runner

[GitBox]

cmrockwell commented on pull request #5:
URL: 
https://github.com/apache/sling-org-apache-sling-junit-core/pull/5#issuecomment-733019791


   Thanks! @bdelacretaz I'll try using the example you gave.
   
   @jsedding  I have another other question for you. I'm getting many many 
errors in the console like the one below
   
   > ERROR: Bundle org.apache.sling.junit.core [189] EventDispatcher: Error 
during dispatch. (java.lang.NoClassDefFoundError: 
org/junit/platform/engine/TestEngine)
   java.lang.NoClassDefFoundError: org/junit/platform/engine/TestEngine
at 
org.apache.sling.junit.impl.servlet.junit5.TestEngineTracker$Customizer.getTestEnginesForBundle(TestEngineTracker.java:83)
at 
org.apache.sling.junit.impl.servlet.junit5.TestEngineTracker$Customizer.addingBundle(TestEngineTracker.java:67)
at 
org.apache.sling.junit.impl.servlet.junit5.TestEngineTracker$Customizer.addingBundle(TestEngineTracker.java:63)
at 
org.osgi.util.tracker.BundleTracker$Tracked.customizerAdding(BundleTracker.java:475)
at 
org.osgi.util.tracker.BundleTracker$Tracked.customizerAdding(BundleTracker.java:420)
at 
org.osgi.util.tracker.AbstractTracked.trackAdding(AbstractTracked.java:256)
at org.osgi.util.tracker.AbstractTracked.track(AbstractTracked.java:229)
at 
org.osgi.util.tracker.BundleTracker$Tracked.bundleChanged(BundleTracker.java:450)
at 
org.apache.felix.framework.EventDispatcher.invokeBundleListenerCallback(EventDispatcher.java:915)
at 
org.apache.felix.framework.EventDispatcher.fireEventImmediately(EventDispatcher.java:834)
at 
org.apache.felix.framework.EventDispatcher.fireBundleEvent(EventDispatcher.java:516)
at org.apache.felix.framework.Felix.fireBundleEvent(Felix.java:4817)
at org.apache.felix.framework.Felix.start(Felix.java:1116)
at 
org.apache.sling.feature.launcher.impl.launchers.AbstractRunner$4.call(AbstractRunner.java:232)
at 
org.apache.sling.feature.launcher.impl.launchers.AbstractRunner$4.call(AbstractRunner.java:228)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at 
java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
at 
java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
at java.base/java.lang.Thread.run(Thread.java:834)
   [INFO] Framework started
   
   Seems this version of org.apache.sling.junit.core had this optional 
Import-Package added from 
[SLING-9795](https://github.com/apache/sling-org-apache-sling-junit-core/commit/8a30309ddebaa86a9edf399d410fe891c15dbf7d#diff-6d1033f3cc4642b36cd395cf203fdc2d963f51e46cb1949508765a9756743c45)
   
   `Import-Package: org.junit.platform.*;resolution:=optional, \`
   
   Is this something to be addressed here or later?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (SLING-9929) Use PaxExamServer for HTTP-based integration testing

[Oliver Lietz (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-9929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17238140#comment-17238140
 ] 

Oliver Lietz commented on SLING-9929:
-

[~bdelacretaz], Will you look into the {{baseConfiguration()}} topic? Which 
dependencies are not wanted?

> Use PaxExamServer for HTTP-based integration testing
> 
>
> Key: SLING-9929
> URL: https://issues.apache.org/jira/browse/SLING-9929
> Project: Sling
>  Issue Type: Improvement
>  Components: Testing
>Affects Versions: Testing PaxExam 3.1.0
>Reporter: Bertrand Delacretaz
>Assignee: Bertrand Delacretaz
>Priority: Minor
>
> We've discussed this in SLING-7993 and I have created a minimal example (with 
> Karate, but other HTTP clients work similarly) at 
> [https://github.com/bdelacretaz/karate-pax-exam]
> This ticket is meant to coordinate efforts around how to use the 
> {{PaxExamServer}} utility to run "out-of-process" tests via HTTP against a 
> minimal Sling instance setup using the 
> https://github.com/apache/sling-org-apache-sling-testing-paxexam/ tools.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Resolved] (SLING-9932) Sling Installer Configuration: Calling the configuration dumper web console might bind a configuration to the wrong bundle

[Konrad Windszus (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus resolved SLING-9932.

Resolution: Fixed

Fixed in 
https://github.com/apache/sling-org-apache-sling-installer-console/commit/7780d9b22da491b3932a9fbc36c425a61b9a5aa9.

> Sling Installer Configuration: Calling the configuration dumper web console 
> might bind a configuration to the wrong bundle
> --
>
> Key: SLING-9932
> URL: https://issues.apache.org/jira/browse/SLING-9932
> Project: Sling
>  Issue Type: Bug
>  Components: Installer
>Affects Versions: Installer Console 1.1.0
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Installer Console 1.1.2
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> In certain conditions (i.e. when a configuration has been changed, but is not 
> yet bound to any other bundle), the code at 
> https://github.com/apache/sling-org-apache-sling-installer-console/blob/a087b18fc681e3d62c597bd4a1ef3166399d899b/src/main/java/org/apache/sling/installer/core/impl/console/ConfigurationSerializerWebConsolePlugin.java#L151
>  might lead to the configuration getting bound to the wrong bundle.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [sling-org-apache-sling-installer-console] kwin merged pull request #2: SLING-9932 prevent binding configurations to the Installer Console

[GitBox]

kwin merged pull request #2:
URL: https://github.com/apache/sling-org-apache-sling-installer-console/pull/2


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Resolved] (SLING-9933) Make it possible to plug into the ArtifactProvider used in the AnalyserMojo

[A. J. David Bosschaert (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

A. J. David Bosschaert resolved SLING-9933.
---
Resolution: Fixed

> Make it possible to plug into the ArtifactProvider used in the AnalyserMojo
> ---
>
> Key: SLING-9933
> URL: https://issues.apache.org/jira/browse/SLING-9933
> Project: Sling
>  Issue Type: Improvement
>  Components: Maven Plugins and Archetypes
>Affects Versions: slingfeature-maven-plugin 1.4.16
>Reporter: A. J. David Bosschaert
>Assignee: A. J. David Bosschaert
>Priority: Major
> Fix For: slingfeature-maven-plugin 1.4.18
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [sling-slingfeature-maven-plugin] bosschaert merged pull request #62: SLING-9933 Make it possible to plug into the ArtifactProvider used in the AnalyserMojo

[GitBox]

bosschaert merged pull request #62:
URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/62


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-slingfeature-maven-plugin] sonarcloud[bot] commented on pull request #62: SLING-9933 Make it possible to plug into the ArtifactProvider used in the AnalyserMojo

[GitBox]

sonarcloud[bot] commented on pull request #62:
URL: 
https://github.com/apache/sling-slingfeature-maven-plugin/pull/62#issuecomment-732937708


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=62=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=62=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=62=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=62=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=62=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=62=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=62=false=SECURITY_HOTSPO
 T) [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=62=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=62=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=62=false=CODE_SMELL)
 [1 Code 
Smell](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=62=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-slingfeature-maven-plugin=62=new_coverage=list)
 [0.0% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-slingfeature-maven-plugin=62=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-slingfeature-maven-plugin=62=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-slingfeature-maven-plugin=62=new_duplicated_lines_density=list)
   
The version of Java (1.8.0_252) you 
have used to run this analysis is deprecated and we will stop accepting it 
soon. Please update to at least Java 11.
   Read more [here](https://sonarcloud.io/documentation/upcoming/)
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-installer-console] rombert commented on pull request #2: SLING-9932 prevent binding configurations to the Installer Console

[GitBox]

rombert commented on pull request #2:
URL: 
https://github.com/apache/sling-org-apache-sling-installer-console/pull/2#issuecomment-732926141


   Looks like this triggered a bug somewhere in the Jenkins setup:
   
   ```
   
/home/jenkins/jenkins-agent/workspace/che-sling-installer-console_PR-2@tmp/durable-293407dd/script.sh:
 1: 
/home/jenkins/jenkins-agent/workspace/che-sling-installer-console_PR-2@tmp/durable-293407dd/script.sh:
 Syntax error: Unterminated quoted string
   ```
   
   Maybe the apostrophe in the branch name?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [VOTE] Release org.apache.sling.scripting.el-api 1.0.4

[davidb]

+1

David

On Tue, 24 Nov 2020 at 11:59, Stefan Seifert  wrote:

> +1
>
>

RE: [VOTE] Release org.apache.sling.scripting.el-api 1.0.4

[Stefan Seifert]

+1 

[GitHub] [sling-slingfeature-maven-plugin] bosschaert opened a new pull request #62: SLING-9933 Make it possible to plug into the ArtifactProvider used in the AnalyserMojo

[GitBox]

bosschaert opened a new pull request #62:
URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/62


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Created] (SLING-9933) Make it possible to plug into the ArtifactProvider used in the AnalyserMojo

[A. J. David Bosschaert (Jira)]

A. J. David Bosschaert created SLING-9933:
-

 Summary: Make it possible to plug into the ArtifactProvider used 
in the AnalyserMojo
 Key: SLING-9933
 URL: https://issues.apache.org/jira/browse/SLING-9933
 Project: Sling
  Issue Type: Improvement
  Components: Maven Plugins and Archetypes
Affects Versions: slingfeature-maven-plugin 1.4.16
Reporter: A. J. David Bosschaert
Assignee: A. J. David Bosschaert
 Fix For: slingfeature-maven-plugin 1.4.18






--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-9932) Sling Installer Configuration: Calling the configuration dumper web console might bind a configuration to the wrong bundle

[Konrad Windszus (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus updated SLING-9932:
---
Fix Version/s: Installer Console 1.1.2

> Sling Installer Configuration: Calling the configuration dumper web console 
> might bind a configuration to the wrong bundle
> --
>
> Key: SLING-9932
> URL: https://issues.apache.org/jira/browse/SLING-9932
> Project: Sling
>  Issue Type: Bug
>  Components: Installer
>Affects Versions: Installer Console 1.1.0
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Installer Console 1.1.2
>
>
> In certain conditions (i.e. when a configuration has been changed, but is not 
> yet bound to any other bundle), the code at 
> https://github.com/apache/sling-org-apache-sling-installer-console/blob/a087b18fc681e3d62c597bd4a1ef3166399d899b/src/main/java/org/apache/sling/installer/core/impl/console/ConfigurationSerializerWebConsolePlugin.java#L151
>  might lead to the configuration getting bound to the wrong bundle.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [sling-org-apache-sling-installer-console] kwin opened a new pull request #2: SLING-9932 prevent binding configurations to the Installer Console

[GitBox]

kwin opened a new pull request #2:
URL: https://github.com/apache/sling-org-apache-sling-installer-console/pull/2


   Bundle



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Created] (SLING-9932) Sling Installer Configuration: Calling the configuration dumper web console might bind a configuration to the wrong bundle

[Konrad Windszus (Jira)]

Konrad Windszus created SLING-9932:
--

 Summary: Sling Installer Configuration: Calling the configuration 
dumper web console might bind a configuration to the wrong bundle
 Key: SLING-9932
 URL: https://issues.apache.org/jira/browse/SLING-9932
 Project: Sling
  Issue Type: Bug
  Components: Installer
Affects Versions: Installer Console 1.1.0
Reporter: Konrad Windszus
Assignee: Konrad Windszus


In certain conditions (i.e. when a configuration has been changed, but is not 
yet bound to any other bundle), the code at 
https://github.com/apache/sling-org-apache-sling-installer-console/blob/a087b18fc681e3d62c597bd4a1ef3166399d899b/src/main/java/org/apache/sling/installer/core/impl/console/ConfigurationSerializerWebConsolePlugin.java#L151
 might lead to the configuration getting bound to the wrong bundle.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[VOTE][LAZY] deprecate the sling-org-apache-sling-servlets-annotations-it module

[Bertrand Delacretaz]

Hi,

In SLING-9930 I have merged the integration tests that were in the
sling-org-apache-sling-servlets-annotations-it module in the main
sling-org-apache-sling-servlets-annotations module.

As the former is not needed anymore I suggest deprecating it,
https://github.com/apache/sling-org-apache-sling-servlets-annotations-it
, according to the instructions at
https://sling.apache.org/documentation/development/deprecating-sling-modules.html

I'll wait at least 24 hours before proceeding, in case someone has an objection.

-Bertrand

[GitHub] [sling-org-apache-sling-junit-core] bdelacretaz commented on pull request #5: Sling 9915 support for sling annotations test runner

[GitBox]

bdelacretaz commented on pull request #5:
URL: 
https://github.com/apache/sling-org-apache-sling-junit-core/pull/5#issuecomment-732835451


   > One option can delete the tests I made which were useful for my 
development efforts...
   
   That wouldn't be good! But modifying the tests so that they run 
automatically and are kept out of the final bundle is good, and that would 
address Julian's concern as well.
   
   I just added tests to the servlets-annotations module that run in a distinct 
build using `maven-invoker-plugin`and talk to the Sling instance under test via 
HTTP, in [commit 
8c5fb2b](https://github.com/apache/sling-org-apache-sling-servlets-annotations/commit/8c5fb2becdb6cd79ff1798a041400829af3e5229).
   
   I think a similar setup would work for your tests, creating a distinct test 
bundle in the same junit-core repository and testing it via the invoker plugin? 
Happy to help with the "details" if needed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [VOTE] Release org.apache.sling.scripting.el-api 1.0.4

[Carsten Ziegeler]

+1

Carsten

Am 24.11.2020 um 09:13 schrieb Carsten Ziegeler:

Hi,

we solved one issue in this release:
https://issues.apache.org/jira/browse/SLING-9928

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2381

You can use this UNIX script to download the release and verify the
signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD 



Usage:
sh check_staged_release.sh 2381 /tmp/sling-staging

Please vote to approve this release:

    [ ] +1 Approve the release
    [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards
Carsten
--
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org


--
--
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

[jira] [Commented] (SLING-9930) Move sling-servlets-annotations-it tests to sling-servlets-annotations module

[Bertrand Delacretaz (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-9930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17238057#comment-17238057
 ] 

Bertrand Delacretaz commented on SLING-9930:


Implemented in commit 
[8c5fb2b|https://github.com/apache/sling-org-apache-sling-servlets-annotations/commit/8c5fb2becdb6cd79ff1798a041400829af3e5229]

The 
[sling-org-apache-sling-servlets-annotations-it|https://github.com/apache/sling-org-apache-sling-servlets-annotations-it]
 module can now be deprecated, I'll confirm that on our dev list.

> Move sling-servlets-annotations-it tests to sling-servlets-annotations module
> -
>
> Key: SLING-9930
> URL: https://issues.apache.org/jira/browse/SLING-9930
> Project: Sling
>  Issue Type: Improvement
>  Components: Servlets
>Affects Versions: Sling Servlet Annotations 1.2.4
>Reporter: Bertrand Delacretaz
>Assignee: Bertrand Delacretaz
>Priority: Minor
> Fix For: Sling Servlet Annotations 1.2.6
>
>
> Having the ITs in a different Git repository creates a slower feedback loop 
> and makes the tests less visible.
> As recently done for 
> [https://github.com/apache/sling-org-apache-sling-adapter-annotations], I'll 
> move the integration tests to the sling-servlets-annotations module using 
> maven-invoker-plugin.
> I'll use the [{{PaxExamServer}}-based 
> tests|https://github.com/apache/sling-org-apache-sling-servlets-annotations-it/tree/SLING-9929]
>  for that as they are stabler than the ones from the current {{master}} 
> branch (where the Sling startup sometimes fail in testing).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-9930) Move sling-servlets-annotations-it tests to sling-servlets-annotations module

[Bertrand Delacretaz (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bertrand Delacretaz updated SLING-9930:
---
Description: 
Having the ITs in a different Git repository creates a slower feedback loop and 
makes the tests less visible.

As recently done for 
[https://github.com/apache/sling-org-apache-sling-adapter-annotations], I'll 
move the integration tests to the sling-servlets-annotations module using 
maven-invoker-plugin.

I'll use the [{{PaxExamServer}}-based 
tests|https://github.com/apache/sling-org-apache-sling-servlets-annotations-it/tree/SLING-9929]
 for that as they are stabler than the ones from the current {{master}} branch 
(where the Sling startup sometimes fail in testing).

  was:
Having the ITs in a different Git repository creates a slower feedback loop and 
makes the tests less visible.

As recently done for 
https://github.com/apache/sling-org-apache-sling-adapter-annotations, I'll move 
the integration tests to the sling-servlets-annotations module using 
maven-invoker-plugin.

I'll use the [{{PaxExamServer}}-based 
tests|https://github.com/apache/sling-org-apache-sling-servlets-annotations-it/tree/SLING-9929]
 for that as they are stabler than the ones from the current {{master}} branch.


> Move sling-servlets-annotations-it tests to sling-servlets-annotations module
> -
>
> Key: SLING-9930
> URL: https://issues.apache.org/jira/browse/SLING-9930
> Project: Sling
>  Issue Type: Improvement
>  Components: Servlets
>Affects Versions: Sling Servlet Annotations 1.2.4
>Reporter: Bertrand Delacretaz
>Assignee: Bertrand Delacretaz
>Priority: Minor
> Fix For: Sling Servlet Annotations 1.2.6
>
>
> Having the ITs in a different Git repository creates a slower feedback loop 
> and makes the tests less visible.
> As recently done for 
> [https://github.com/apache/sling-org-apache-sling-adapter-annotations], I'll 
> move the integration tests to the sling-servlets-annotations module using 
> maven-invoker-plugin.
> I'll use the [{{PaxExamServer}}-based 
> tests|https://github.com/apache/sling-org-apache-sling-servlets-annotations-it/tree/SLING-9929]
>  for that as they are stabler than the ones from the current {{master}} 
> branch (where the Sling startup sometimes fail in testing).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Resolved] (SLING-9931) Upgrade to Composum 2.1.1

[Robert Munteanu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-9931.

Resolution: Fixed

Fixed with [sling-org-apache-sling-starter commit 
d182d7b|https://github.com/apache/sling-org-apache-sling-starter/commit/d182d7b].

> Upgrade to Composum 2.1.1
> -
>
> Key: SLING-9931
> URL: https://issues.apache.org/jira/browse/SLING-9931
> Project: Sling
>  Issue Type: Task
>  Components: Starter
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Minor
> Fix For: Starter 12
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (SLING-9931) Upgrade to Composum 2.1.1

[Robert Munteanu (Jira)]

Robert Munteanu created SLING-9931:
--

 Summary: Upgrade to Composum 2.1.1
 Key: SLING-9931
 URL: https://issues.apache.org/jira/browse/SLING-9931
 Project: Sling
  Issue Type: Task
  Components: Starter
Reporter: Robert Munteanu
Assignee: Robert Munteanu
 Fix For: Starter 12






--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (SLING-9930) Move sling-servlets-annotations-it tests to sling-servlets-annotations module

[Bertrand Delacretaz (Jira)]

Bertrand Delacretaz created SLING-9930:
--

 Summary: Move sling-servlets-annotations-it tests to 
sling-servlets-annotations module
 Key: SLING-9930
 URL: https://issues.apache.org/jira/browse/SLING-9930
 Project: Sling
  Issue Type: Improvement
  Components: Servlets
Affects Versions: Sling Servlet Annotations 1.2.4
Reporter: Bertrand Delacretaz
Assignee: Bertrand Delacretaz
 Fix For: Sling Servlet Annotations 1.2.6


Having the ITs in a different Git repository creates a slower feedback loop and 
makes the tests less visible.

As recently done for 
https://github.com/apache/sling-org-apache-sling-adapter-annotations, I'll move 
the integration tests to the sling-servlets-annotations module using 
maven-invoker-plugin.

I'll use the [{{PaxExamServer}}-based 
tests|https://github.com/apache/sling-org-apache-sling-servlets-annotations-it/tree/SLING-9929]
 for that as they are stabler than the ones from the current {{master}} branch.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-7993) create some karate tests for pipes http api integration tests

[Bertrand Delacretaz (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-7993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17237994#comment-17237994
 ] 

Bertrand Delacretaz commented on SLING-7993:


I have created SLING-9929 to more generally explore using {{PaxExamServer}}

> create some karate tests for pipes http api integration tests
> -
>
> Key: SLING-7993
> URL: https://issues.apache.org/jira/browse/SLING-7993
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions, pipes
>Affects Versions: Pipes 3.0.2
>Reporter: Nicolas Peltier
>Priority: Major
>
> would be nice to have clear and "documenting" karate tests of pipes http API



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-9929) Use PaxExamServer for HTTP-based integration testing

[Bertrand Delacretaz (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-9929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17237991#comment-17237991
 ] 

Bertrand Delacretaz commented on SLING-9929:


I have a working example at 
[https://github.com/apache/sling-org-apache-sling-servlets-annotations-it/tree/SLING-9929]

I had to add some extra bundles in the configuration method, below.

I haven't analyzed why those are needed, once we clarify we might add options 
to {{org.apache.sling.testing.paxexam.TestSupport}} to select "normal" or 
{{PaxExamServer}} mode.

{code}
return composite(
  // not using this as it seems to pull in some unwanted pax exam dependencies
  //super.baseConfiguration(),

  slingQuickstartOakTar(workingDirectory, httpPort),
  testBundle("bundle.filename"),

  logback(),
  
mavenBundle().groupId("org.apache.felix").artifactId("org.apache.felix.log").version("1.2.4"),
  mavenBundle().groupId("log4j").artifactId("log4j").version("1.2.17"),
  
mavenBundle().groupId("org.apache.aries.spifly").artifactId("org.apache.aries.spifly.dynamic.framework.extension").version("1.3.2"),
  
mavenBundle().groupId("org.apache.felix").artifactId("org.apache.felix.webconsole.plugins.ds").version("2.1.0")
).getOptions();
 {code}

> Use PaxExamServer for HTTP-based integration testing
> 
>
> Key: SLING-9929
> URL: https://issues.apache.org/jira/browse/SLING-9929
> Project: Sling
>  Issue Type: Improvement
>  Components: Testing
>Affects Versions: Testing PaxExam 3.1.0
>Reporter: Bertrand Delacretaz
>Assignee: Bertrand Delacretaz
>Priority: Minor
>
> We've discussed this in SLING-7993 and I have created a minimal example (with 
> Karate, but other HTTP clients work similarly) at 
> [https://github.com/bdelacretaz/karate-pax-exam]
> This ticket is meant to coordinate efforts around how to use the 
> {{PaxExamServer}} utility to run "out-of-process" tests via HTTP against a 
> minimal Sling instance setup using the 
> https://github.com/apache/sling-org-apache-sling-testing-paxexam/ tools.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (SLING-9929) Use PaxExamServer for HTTP-based integration testing

[Bertrand Delacretaz (Jira)]

Bertrand Delacretaz created SLING-9929:
--

 Summary: Use PaxExamServer for HTTP-based integration testing
 Key: SLING-9929
 URL: https://issues.apache.org/jira/browse/SLING-9929
 Project: Sling
  Issue Type: Improvement
  Components: Testing
Affects Versions: Testing PaxExam 3.1.0
Reporter: Bertrand Delacretaz
Assignee: Bertrand Delacretaz


We've discussed this in SLING-7993 and I have created a minimal example (with 
Karate, but other HTTP clients work similarly) at 
[https://github.com/bdelacretaz/karate-pax-exam]

This ticket is meant to coordinate efforts around how to use the 
{{PaxExamServer}} utility to run "out-of-process" tests via HTTP against a 
minimal Sling instance setup using the 
https://github.com/apache/sling-org-apache-sling-testing-paxexam/ tools.




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-9927) Allow java.* imports to be defined, in line with OSGi R7

[A. J. David Bosschaert (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-9927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17237986#comment-17237986
 ] 

A. J. David Bosschaert commented on SLING-9927:
---

The feature model analyser needs to be updated to pick up Felix Utils 1.11.6 
once its release is out.

> Allow java.* imports to be defined, in line with OSGi R7
> 
>
> Key: SLING-9927
> URL: https://issues.apache.org/jira/browse/SLING-9927
> Project: Sling
>  Issue Type: Bug
>  Components: Feature Model Analyser
>Affects Versions: Feature Model Analyser 1.3.12
>Reporter: Radu Cotescu
>Assignee: A. J. David Bosschaert
>Priority: Major
> Fix For: Feature Model Analyser 1.3.14
>
>
> The default Sling analysers seem to not allow {{java.*}} imports:
> {noformat}
> [ERROR] Failed to execute goal 
> org.apache.sling:slingfeature-maven-plugin:1.4.16:analyse-features (analyze) 
> on project : Exception during analysing feature  : 
> org.osgi.framework.BundleException: Unable to build resource for null: 
> Importing java.* packages not allowed: java.awt -> [Help 1] {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-9927) Allow java.* imports to be defined, in line with OSGi R7

[A. J. David Bosschaert (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

A. J. David Bosschaert updated SLING-9927:
--
Fix Version/s: Feature Model Analyser 1.3.14

> Allow java.* imports to be defined, in line with OSGi R7
> 
>
> Key: SLING-9927
> URL: https://issues.apache.org/jira/browse/SLING-9927
> Project: Sling
>  Issue Type: Bug
>  Components: Feature Model Analyser
>Affects Versions: Feature Model Analyser 1.3.12
>Reporter: Radu Cotescu
>Assignee: A. J. David Bosschaert
>Priority: Major
> Fix For: Feature Model Analyser 1.3.14
>
>
> The default Sling analysers seem to not allow {{java.*}} imports:
> {noformat}
> [ERROR] Failed to execute goal 
> org.apache.sling:slingfeature-maven-plugin:1.4.16:analyse-features (analyze) 
> on project : Exception during analysing feature  : 
> org.osgi.framework.BundleException: Unable to build resource for null: 
> Importing java.* packages not allowed: java.awt -> [Help 1] {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (SLING-9889) Slingfeature-Maven-Plugin: Fix failing ITs

[A. J. David Bosschaert (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

A. J. David Bosschaert closed SLING-9889.
-

> Slingfeature-Maven-Plugin: Fix failing ITs
> --
>
> Key: SLING-9889
> URL: https://issues.apache.org/jira/browse/SLING-9889
> Project: Sling
>  Issue Type: Bug
>  Components: Feature Model
>Reporter: Konrad Windszus
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: slingfeature-maven-plugin 1.4.12
>
>
> After the merge of https://issues.apache.org/jira/browse/SLING-9886 some ITs 
> are failing:
> {code}
> [ERROR] The following builds failed:
> [ERROR] *  apis-jar-wrapped-flattened-classes/pom.xml
> [ERROR] *  apis-jar-wrapper-bundle/pom.xml
> [ERROR] *  apis-jar/pom.xml
> {code}
> (https://ci-builds.apache.org/job/Sling/job/modules/job/sling-slingfeature-maven-plugin/job/master/48/console)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (SLING-9913) ArtifactProvider should not log stack trace if artifact is not found

[A. J. David Bosschaert (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

A. J. David Bosschaert closed SLING-9913.
-

> ArtifactProvider should not log stack trace if artifact is not found
> 
>
> Key: SLING-9913
> URL: https://issues.apache.org/jira/browse/SLING-9913
> Project: Sling
>  Issue Type: Improvement
>  Components: Maven Plugins and Archetypes
>Affects Versions: slingfeature-maven-plugin 1.4.14
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: slingfeature-maven-plugin 1.4.16
>
>
> BaseArtifactProvider is currently logging an exception, but ignoring them 
> (returning null)
> As the exception is considered a valid case and is handled, it should not be 
> logged as an error with the full stack trace



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (SLING-9914) If no tag is specified, HEAD is used as default branch

[A. J. David Bosschaert (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

A. J. David Bosschaert closed SLING-9914.
-

> If no tag is specified, HEAD is used as default branch
> --
>
> Key: SLING-9914
> URL: https://issues.apache.org/jira/browse/SLING-9914
> Project: Sling
>  Issue Type: Bug
>  Components: Maven Plugins and Archetypes
>Affects Versions: slingfeature-maven-plugin 1.4.14
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: slingfeature-maven-plugin 1.4.16
>
>
> With the fix in SLING-9912, a new problem might occur: if the pom has no 
> "tag" set in the scm info, Maven by default uses "HEAD"  refering to the main 
> branch - that tag is then used to checkout the source code which fails as 
> HEAD does not exist as a branch



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (SLING-9911) Update Feature Model Launcher to latest feature model

[A. J. David Bosschaert (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

A. J. David Bosschaert closed SLING-9911.
-

> Update Feature Model Launcher to latest feature model
> -
>
> Key: SLING-9911
> URL: https://issues.apache.org/jira/browse/SLING-9911
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model
>Affects Versions: Feature Model Launcher 1.1.10
>Reporter: A. J. David Bosschaert
>Assignee: A. J. David Bosschaert
>Priority: Major
> Fix For: Feature Model Launcher 1.1.12
>
>
> The feature model launcher should use feature model 1.2.14. Because it embeds 
> it, a new release of the launcher must be made.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (SLING-9885) Prevent potential NPE in ConvertCPMojo

[A. J. David Bosschaert (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

A. J. David Bosschaert closed SLING-9885.
-

> Prevent potential NPE in ConvertCPMojo
> --
>
> Key: SLING-9885
> URL: https://issues.apache.org/jira/browse/SLING-9885
> Project: Sling
>  Issue Type: Bug
>  Components: Content-Package to Feature Model Converter
>Affects Versions: Feature Model Converter Plugin 1.0.6
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: Feature Model Converter Plugin 1.0.8
>
>
> As {{Artifact.getFile()}} 
> (https://maven.apache.org/ref/3.6.0/maven-artifact/apidocs/org/apache/maven/artifact/Artifact.html#getFile())
>  might return {{null}} a null check should be added in  
> https://github.com/apache/sling-feature-converter-maven-plugin/blob/f626fda29e879f32026092e3f7cf80ec918455f4/src/main/java/org/apache/sling/cpconverter/maven/mojos/ConvertCPMojo.java#L271



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (SLING-9907) Programmatic setting of Analyser Task Configuration

[A. J. David Bosschaert (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

A. J. David Bosschaert closed SLING-9907.
-

> Programmatic setting of Analyser Task Configuration
> ---
>
> Key: SLING-9907
> URL: https://issues.apache.org/jira/browse/SLING-9907
> Project: Sling
>  Issue Type: Improvement
>  Components: Maven Plugins and Archetypes
>Affects Versions: slingfeature-maven-plugin 1.4.6
>Reporter: A. J. David Bosschaert
>Assignee: A. J. David Bosschaert
>Priority: Major
> Fix For: slingfeature-maven-plugin 1.4.12
>
>
> The Scan class contains Analyser Task configurations. This configuration is 
> normally reflectively set by Maven based on information in the pom. Therefore 
> there is only a getter available for it.
> However, when other plugins drive the analyser mojo, it would be good if this 
> configuration can be set programmatically in the Scan class.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (SLING-9908) Remove ContentOrderMergeProcessor

[A. J. David Bosschaert (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

A. J. David Bosschaert closed SLING-9908.
-

> Remove ContentOrderMergeProcessor
> -
>
> Key: SLING-9908
> URL: https://issues.apache.org/jira/browse/SLING-9908
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model
>Affects Versions: Feature Model Content Extension 1.0.6
>Reporter: Karl Pauls
>Assignee: Karl Pauls
>Priority: Major
> Fix For: Feature Model Content Extension 1.0.8
>
>
> We should remove the ContentOrderMergeProcessor as we can handle that with 
> the slingfeature-maven-plugin and it is problematic in its current form as it 
> doesn't take the merge policies into account.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (SLING-9897) Update API Regions Analysers to use artifact-aware error reporting

[A. J. David Bosschaert (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

A. J. David Bosschaert closed SLING-9897.
-

> Update API Regions Analysers to use artifact-aware error reporting
> --
>
> Key: SLING-9897
> URL: https://issues.apache.org/jira/browse/SLING-9897
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model Analyser
>Affects Versions: Feature Model API Regions Extension 1.1.10
>Reporter: A. J. David Bosschaert
>Assignee: A. J. David Bosschaert
>Priority: Major
> Fix For: Feature Model API Regions Extension 1.1.12
>
>
> A new improved error reporting is available in the Analysers API which allows 
> the association with an artifact for the error reporting.
> The API Regions analysers should be updated to use this where applicable.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (SLING-9886) Slingfeature-maven-plugin: ITs always succeed

[A. J. David Bosschaert (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

A. J. David Bosschaert closed SLING-9886.
-

> Slingfeature-maven-plugin: ITs always succeed
> -
>
> Key: SLING-9886
> URL: https://issues.apache.org/jira/browse/SLING-9886
> Project: Sling
>  Issue Type: Bug
>  Components: Feature Model
>Affects Versions: slingfeature-maven-plugin 1.4.6
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: slingfeature-maven-plugin 1.4.12
>
>
> Due to the way how the {{verify.bsh}} are written with a return statement 
> after try and catch the following bug is triggered in BSH: 
> https://github.com/beanshell/beanshell/issues/367.
> You can reproduce by just inverting a condition, e.g. in 
> https://github.com/apache/sling-slingfeature-maven-plugin/blob/56caf46d529f7f09e86e0a644357e17d00028263/src/it/apis-jar-wrapper-bundle/verify.bsh#L30
>  and you see that the build will still not fail.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (SLING-9904) Provide an option to globally set metadata to bundles and artifacts

[A. J. David Bosschaert (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

A. J. David Bosschaert closed SLING-9904.
-

> Provide an option to globally set metadata to bundles and artifacts
> ---
>
> Key: SLING-9904
> URL: https://issues.apache.org/jira/browse/SLING-9904
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model, Maven Plugins and Archetypes
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: slingfeature-maven-plugin 1.4.12
>
>
> Verify often all bundles and all content packages (artifacts) need to be 
> configured with exactly the same value of some metadata property, for example 
> the start order (for a bundle or content package)
> While this can be done in a feature model, it is very tidous to do - we could 
> provide an option for the maven plugin which applies then to all 
> bundles/artifacts metadata, unless that metadata is already set in the 
> feature. This makes authoring features in a maven project easier



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (SLING-9900) Wrong Warning and Error count reported by Feature Model Analyser

[A. J. David Bosschaert (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

A. J. David Bosschaert closed SLING-9900.
-

> Wrong Warning and Error count reported by Feature Model Analyser
> 
>
> Key: SLING-9900
> URL: https://issues.apache.org/jira/browse/SLING-9900
> Project: Sling
>  Issue Type: Bug
>  Components: Feature Model Analyser
>Affects Versions: Feature Model Analyser 1.3.10
>Reporter: A. J. David Bosschaert
>Assignee: A. J. David Bosschaert
>Priority: Major
> Fix For: Feature Model Analyser 1.3.12
>
>
> The total number of errors and warnings reported by the feature model 
> analyser is wrong:
> {code:java}
> [INFO] - Executing Bundle Resources Check [bundle-resources]...
> [INFO] Analyzing feature 
> 'com.mysite:test4.analyse:slingosgifeature:aggregated:1.0.0-SNAPSHOT' 
> finished : 010 warnings, 000 errors.
> [WARNING] com.mysite:test4.core:1.0.0-SNAPSHOT: Found bundle resources : 
> [/libs/sling/explorer!/resources/explorer]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
>  
> {code}
> In this case there is clearly just 1 warning, not 10.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (SLING-9887) Record feature origins for configurations

[A. J. David Bosschaert (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

A. J. David Bosschaert closed SLING-9887.
-

> Record feature origins for configurations
> -
>
> Key: SLING-9887
> URL: https://issues.apache.org/jira/browse/SLING-9887
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Feature Model 1.2.14
>
>
> For tracking purposes we should record the feature origins of a configuration 
> (we do the same for artifacts).
> We can add a new property of type String[] to the configuration:
> If the property is not set, the origin is the current feature
> The property is set if two features are merged - the array contains the ids 
> of the feature where the configuration is defined. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (SLING-9899) Support strategy FIRST for artifact merging

[A. J. David Bosschaert (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

A. J. David Bosschaert closed SLING-9899.
-

> Support strategy FIRST for artifact merging
> ---
>
> Key: SLING-9899
> URL: https://issues.apache.org/jira/browse/SLING-9899
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Feature Model 1.2.14
>
>
> While we support first, and last for configurations, we only support last 
> (and highest) with artifacts/bundles. We should also support first



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (SLING-9884) Feature Analyser Requirement/Capabilities check should log warnings on artifact level

[A. J. David Bosschaert (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

A. J. David Bosschaert closed SLING-9884.
-

> Feature Analyser Requirement/Capabilities check should log warnings on 
> artifact level
> -
>
> Key: SLING-9884
> URL: https://issues.apache.org/jira/browse/SLING-9884
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model Analyser
>Affects Versions: Feature Model Analyser 1.3.10
>Reporter: Karl Pauls
>Assignee: Karl Pauls
>Priority: Major
> Fix For: Feature Model Analyser 1.3.12
>
>
> The introduction of artifact level errors/warnings missed to convert the 
> requirements/capabilities check to use the artifact level for warnings.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (SLING-9895) Provide more information to extension handlers

[A. J. David Bosschaert (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

A. J. David Bosschaert closed SLING-9895.
-

> Provide more information to extension handlers
> --
>
> Key: SLING-9895
> URL: https://issues.apache.org/jira/browse/SLING-9895
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Feature Model 1.2.14
>
>
> Extension handlers get a source and a target and are invoked to merge the 
> source into the target. For example if two features are aggregated, a handler 
> is invoked twice, the target is always the resulting feature and the source 
> is the first feature and then the second feature.
> If an extension handler wants to act on data of the aggregated features 
> (first and second feature in this case), the handler does not have a clue 
> when it is invoked about the state.
> In addition, the same handlers are also used to process a prototype feature - 
> in some cases processing of prototypes might be different from aggregation



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (SLING-9902) Merging with policy HIGHEST should take alias version into account.

[A. J. David Bosschaert (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

A. J. David Bosschaert closed SLING-9902.
-

> Merging with policy HIGHEST should take alias version into account.
> ---
>
> Key: SLING-9902
> URL: https://issues.apache.org/jira/browse/SLING-9902
> Project: Sling
>  Issue Type: Bug
>  Components: Feature Model
>Affects Versions: Feature Model 1.2.12
>Reporter: Karl Pauls
>Assignee: Karl Pauls
>Priority: Major
> Fix For: Feature Model 1.2.14
>
>
> When an artifact has an alias and that alias is clashing with a different 
> artifact the merge policy should take the version of the alias for the 
> selection of the highest version.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (SLING-9881) CPConverter dropping type information on sling:OsgiConfig nodes

[A. J. David Bosschaert (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

A. J. David Bosschaert closed SLING-9881.
-

> CPConverter dropping type information on sling:OsgiConfig nodes
> ---
>
> Key: SLING-9881
> URL: https://issues.apache.org/jira/browse/SLING-9881
> Project: Sling
>  Issue Type: Bug
>  Components: Content-Package to Feature Model Converter
>Affects Versions: Content-Package to Feature Model Converter 1.0.16
>Reporter: Dominik Süß
>Priority: Critical
> Fix For: Content-Package to Feature Model Converter 1.0.18
>
>
> The implementation of the converter for sling:OsgiConfig nodes 
> (XmlConfigurationEntryHandler) currently ignores the type of the properties 
> and transforms everything into Strings (as DocViewProperty returns values as 
> String representations with separate type property).
> This leads to broken configurations in case of the use of those config nodes 
> with typed properties.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (SLING-9894) CP Converter not defining explicit dependency of embedded package on parent

[A. J. David Bosschaert (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

A. J. David Bosschaert closed SLING-9894.
-

> CP Converter not defining explicit dependency of embedded package on parent
> ---
>
> Key: SLING-9894
> URL: https://issues.apache.org/jira/browse/SLING-9894
> Project: Sling
>  Issue Type: Bug
>  Components: Content-Package to Feature Model Converter
>Affects Versions: Content-Package to Feature Model Converter 1.0.16
>Reporter: Dominik Süß
>Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.0.18
>
>
> An embedded package of a non-container package (/libs/xy/install) when 
> installed via OSGI installer will always be installed after the parent 
> package even when there is no explicit dependency. The converter misses to 
> convert this implicit dependency into an explict dependency which can cause 
> the order to differ and therefore cause oversights of ordering issues. To 
> align this packages need to set up an explicit dependency to a parent package 
> unless this is a container package which would be treated as non-existing and 
> therefore removed.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (SLING-9891) Content Package to Feature Model converter does not work on Windows

[A. J. David Bosschaert (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

A. J. David Bosschaert closed SLING-9891.
-

> Content Package to Feature Model converter does not work on Windows
> ---
>
> Key: SLING-9891
> URL: https://issues.apache.org/jira/browse/SLING-9891
> Project: Sling
>  Issue Type: Bug
>  Components: Content-Package to Feature Model Converter
>Affects Versions: Content-Package to Feature Model Converter 1.0.16
>Reporter: A. J. David Bosschaert
>Assignee: A. J. David Bosschaert
>Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.0.18
>
>
> Run `mvn install` in the project on Windows and you'll see.
> There are 2 main problems:
>  * The {{java.nio.Path}} implementation chosen to represent Repository paths, 
> does not accept all valid repository paths when run with the Windows 
> implementation.
>  * The test cases use Unix line separators in string comparisons which on 
> Windows don't match



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (SLING-9794) Content package artifacts found by maven plugin don't always have their 'file' attribute set

[A. J. David Bosschaert (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

A. J. David Bosschaert closed SLING-9794.
-

> Content package artifacts found by maven plugin don't always have their 
> 'file' attribute set
> 
>
> Key: SLING-9794
> URL: https://issues.apache.org/jira/browse/SLING-9794
> Project: Sling
>  Issue Type: Bug
>  Components: Content-Package to Feature Model Converter
>Affects Versions: Feature Model Converter Plugin 1.0.4
>Reporter: A. J. David Bosschaert
>Assignee: A. J. David Bosschaert
>Priority: Major
> Fix For: Feature Model Converter Plugin 1.0.6
>
>
> The Content Package to Feature Model plugin looks up content packages from 
> the maven dependencies in {{ContentPackage.getMatchingArtifacts()}}. 
> However this mechanism doesn't always work fully, leaving the {{file}} 
> attribute of the returned Artifacts {{null}}. 
> This later causes a NPE when the result is processed: 
> {code:java}
> Caused by: java.lang.NullPointerException
> at org.apache.sling.cpconverter.maven.mojos.ConvertCPMojo.execute 
> (ConvertCPMojo.java:238)
> at com.adobe.aem.analyser.mojos.ConvertToFeatureModelMojo.execute 
> (ConvertToFeatureModelMojo.java:46)
> at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo 
> (DefaultBuildPluginManager.java:137)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:210)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:156)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:148)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:117)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:81)
> at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
>  (SingleThreadedBuilder.java:56)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
> (LifecycleStarter.java:128)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:957)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:289)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:193)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:62)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:566)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
> (Launcher.java:282)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
> (Launcher.java:225)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
> (Launcher.java:406)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main 
> (Launcher.java:347) {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (SLING-9864) Update to latest feature model

[A. J. David Bosschaert (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

A. J. David Bosschaert closed SLING-9864.
-

> Update to latest feature model
> --
>
> Key: SLING-9864
> URL: https://issues.apache.org/jira/browse/SLING-9864
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model
>Affects Versions: Feature Model Launcher 1.1.8
>Reporter: A. J. David Bosschaert
>Assignee: A. J. David Bosschaert
>Priority: Major
> Fix For: Feature Model Launcher 1.1.10
>
>
> An important fix has been made to the feature model regarding with the ALL 
> policy. This should be picked up by the launcher, which embeds the feature 
> model in its binary.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (SLING-9827) Specify the API Region to export packages into

[A. J. David Bosschaert (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

A. J. David Bosschaert closed SLING-9827.
-

> Specify the API Region to export packages into
> --
>
> Key: SLING-9827
> URL: https://issues.apache.org/jira/browse/SLING-9827
> Project: Sling
>  Issue Type: Improvement
>  Components: Content-Package to Feature Model Converter
>Affects Versions: Feature Model Converter Plugin 1.0.4, Content-Package to 
> Feature Model Converter 1.0.14
>Reporter: A. J. David Bosschaert
>Assignee: A. J. David Bosschaert
>Priority: Major
> Fix For: Feature Model Converter Plugin 1.0.6, Content-Package to 
> Feature Model Converter 1.0.16
>
>
> Make it possible to specify that all packages exported by bundles in a 
> content package will be exported in a given region.
> By default the packages are not listed, which is ok if the generated feature 
> doesn't opt in to the API Regions mechanism. In that case the packages are 
> implicitly visible in the {{global}} region.
> However, if the generated feature does opt into the API Regions (for example 
> by specifying the {{-r}} / {{--api-region}} option), then it will be 
> necessary to also explicitly list the exported packages in the API Regions 
> exports, as otherwise they will not be visible across the features if 
> multiple features are generated from a single content package (e.g. to handle 
> run modes).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (SLING-9823) Make analyzers report more context about issues and make it possible to filter reports.

[A. J. David Bosschaert (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

A. J. David Bosschaert closed SLING-9823.
-

> Make analyzers report more context about issues and make it possible to 
> filter reports.
> ---
>
> Key: SLING-9823
> URL: https://issues.apache.org/jira/browse/SLING-9823
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model Analyser
>Affects Versions: Feature Model Analyser 1.3.8
>Reporter: Karl Pauls
>Assignee: Karl Pauls
>Priority: Major
> Fix For: Feature Model Analyser 1.3.10
>
>
> Currently, an analyser task just reports a string (either as error or 
> warning) - we should add new methods to AnalyserTaskContext for reporting 
> error/warning. 
> These methods should take an ArtifactId and a string or an extension name and 
> a string (something like reportArtifactError(ArtifactId, 
> String)...reportExtensionError(String, String) ) 
> This way the analysers can provide more context about a warning/error and we 
> can display them later per artifact instead of a long list. With that we have 
> three types of errors: global (just the string), per artifact id, per 
> extension name - the analyser tasks could be updated to use the new methods 
> where appropriate. Similar, we add new methods to AnalyserResult getting 
> those three types of errors/warnings - and deprecate the two existing ones. 
> They would be changed to return all errors/warnings - so everything would be 
> compatible.
> The final piece is ignoring errors/warnings for certain artifacts. If we do 
> the changes as mentioned above - the scanner/analyser does not need to know 
> anything about whether something is ignored. We can handle this in the maven 
> plugin. 
> We have two options here: either we make this a configuration of the plugin - 
> or we allow that metadata property is added to an artifact in the feature 
> model telling the plugin to not report errors/warnings for this artifact.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (SLING-9805) Add a method to create the metadata cache extension

[A. J. David Bosschaert (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

A. J. David Bosschaert closed SLING-9805.
-

> Add a method to create the metadata cache extension
> ---
>
> Key: SLING-9805
> URL: https://issues.apache.org/jira/browse/SLING-9805
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model Analyser
>Reporter: Carsten Ziegeler
>Assignee: Karl Pauls
>Priority: Major
> Fix For: Feature Model Analyser 1.3.10
>
>
> With SLING-8481 and SLING-9804 implemented, an utility method could be added 
> to the scanner api package, creating an extension with the cached artifact 
> metadata (taking a feature descriptor and framework descriptor as input)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (SLING-9815) Add analyser to check for "unused" bundles

[A. J. David Bosschaert (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

A. J. David Bosschaert closed SLING-9815.
-

> Add analyser to check for "unused" bundles
> --
>
> Key: SLING-9815
> URL: https://issues.apache.org/jira/browse/SLING-9815
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model Analyser, Maven Plugins and Archetypes
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Feature Model Analyser 1.3.10, slingfeature-maven-plugin 
> 1.4.6
>
>
> A new analyser could check if exports from a bundle are imported by any other 
> bundle.
> This analyser should issue warnings (not errors) as the bundle might still be 
> needed; the warning is just an indication 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (SLING-9804) Make descriptors available via AnalyseResult

[A. J. David Bosschaert (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

A. J. David Bosschaert closed SLING-9804.
-

> Make descriptors available via AnalyseResult
> 
>
> Key: SLING-9804
> URL: https://issues.apache.org/jira/browse/SLING-9804
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Feature Model Analyser 1.3.10
>
>
> The analyser returns an analyser result which currently only provides errors 
> and warnings. It could be extended to also make the feature descriptor and 
> optional framework descriptor available.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (SLING-9822) Make artifact retrieval lazy for cached artifacts

[A. J. David Bosschaert (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

A. J. David Bosschaert closed SLING-9822.
-

> Make artifact retrieval lazy for cached artifacts
> -
>
> Key: SLING-9822
> URL: https://issues.apache.org/jira/browse/SLING-9822
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model Analyser
>Affects Versions: Feature Model Analyser 1.3.8
>Reporter: Karl Pauls
>Assignee: Karl Pauls
>Priority: Major
> Fix For: Feature Model Analyser 1.3.10
>
>
> With SLING-9805, we made it possible to have artifacts from the cache 
> extension that don't need to be present via maven - however, we are currently 
> requesting them AOT. It would be better to make that JIT and have the 
> analyzers be able to deal with artifacts not present in a better way.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (SLING-9860) Merging artifacts with the ALL strategy should keep the origins for clashing bundles and their origins only

[A. J. David Bosschaert (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

A. J. David Bosschaert closed SLING-9860.
-

> Merging artifacts with the ALL strategy should keep the origins for clashing 
> bundles and their origins only 
> 
>
> Key: SLING-9860
> URL: https://issues.apache.org/jira/browse/SLING-9860
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model
>Affects Versions: Feature Model 1.2.10
>Reporter: A. J. David Bosschaert
>Assignee: A. J. David Bosschaert
>Priority: Major
> Fix For: Feature Model 1.2.12
>
>
> When merging 2 features that both contain the same artifact, but in different 
> versions, both artifacts are preserved, however, the feature-origins of one 
> of the artifact contains both features instead of just its own feature.
> For example Feature A contains:
>  * bundle org.foo:bar:1.2
> And Feature B contains
>  * bundle org.foo:bar:1.3
> Then once merged with the ALL strategy the resulting feature contains the 
> artifact with  (origins A,B).
> While this allows for package substitution to work between the bundles it can 
> be problematic in cases where that is not desired for isolation purposes. As 
> the interpretation of the origins is up to extensions, it seems better to not 
> make the union decision in this place but leave it up to merge extensions and 
> handlers later. 
> In other words, we should change this so that the origins for version 1.2 
> should be just A, not both A and B.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[VOTE] Release org.apache.sling.scripting.el-api 1.0.4

[Carsten Ziegeler]

Hi,

we solved one issue in this release:
https://issues.apache.org/jira/browse/SLING-9928

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2381

You can use this UNIX script to download the release and verify the
signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2381 /tmp/sling-staging

Please vote to approve this release:

   [ ] +1 Approve the release
   [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards
Carsten
--
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

[jira] [Comment Edited] (SLING-9928) Sling el-api embeds vulnerable version of el-api

[Akanksha Jain (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-9928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17237942#comment-17237942
 ] 

Akanksha Jain edited comment on SLING-9928 at 11/24/20, 8:05 AM:
-

[~cziegeler]  Thank you for merging the PR.

Can you please release this updated 'org.apache.sling.scripting.el-api'.


was (Author: akanksha88):
[~cziegeler] Can you please release this updated 
'org.apache.sling.scripting.el-api'.

> Sling el-api embeds vulnerable version of el-api
> 
>
> Key: SLING-9928
> URL: https://issues.apache.org/jira/browse/SLING-9928
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Reporter: Akanksha Jain
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Scripting EL API Wrapper 1.0.4
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> *Issue summary :* Security issues reported under org.apache.tomcat
> *Vulnerabilities*
> CVE-2014-7810 5.0 org.apache.tomcat : el-api : 6.0.14
> [https://nvd.nist.gov/vuln/detail/CVE-2014-7810]
> el-api-6.0.14 is embedded by org.apache.sling.scripting.el-api.
> Expected: Need to update el-api version in org.apache.sling.scripting.el-api.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-9928) Sling el-api embeds vulnerable version of el-api

[Akanksha Jain (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-9928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17237942#comment-17237942
 ] 

Akanksha Jain commented on SLING-9928:
--

[~cziegeler] Can you please release this updated 
'org.apache.sling.scripting.el-api'.

> Sling el-api embeds vulnerable version of el-api
> 
>
> Key: SLING-9928
> URL: https://issues.apache.org/jira/browse/SLING-9928
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Reporter: Akanksha Jain
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Scripting EL API Wrapper 1.0.4
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> *Issue summary :* Security issues reported under org.apache.tomcat
> *Vulnerabilities*
> CVE-2014-7810 5.0 org.apache.tomcat : el-api : 6.0.14
> [https://nvd.nist.gov/vuln/detail/CVE-2014-7810]
> el-api-6.0.14 is embedded by org.apache.sling.scripting.el-api.
> Expected: Need to update el-api version in org.apache.sling.scripting.el-api.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)