[jira] [Assigned] (SLING-10093) Add Mock Node Definition in jcr-mock
[ https://issues.apache.org/jira/browse/SLING-10093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert reassigned SLING-10093: -- Assignee: Stefan Seifert thanks, i'll have a look at it > Add Mock Node Definition in jcr-mock > > > Key: SLING-10093 > URL: https://issues.apache.org/jira/browse/SLING-10093 > Project: Sling > Issue Type: Improvement > Components: Testing >Reporter: Roy Teeuwen >Assignee: Stefan Seifert >Priority: Major > > There is no mock node definition for the jcr mocks. It would be handy if > there is one because the JcrUtil.copy uses the node's definition when doing a > deep copy of a source node to a target -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-10110) Sling Dynamic Include: ignoreUrlParams with Wildcards do not work
Andreas Bannasch created SLING-10110:
Summary: Sling Dynamic Include: ignoreUrlParams with Wildcards do
not work
Key: SLING-10110
URL: https://issues.apache.org/jira/browse/SLING-10110
Project: Sling
Issue Type: Bug
Affects Versions: Dynamic Include 3.2.0
Environment: AEM 6.3 - AEM 6.5
Reporter: Andreas Bannasch
Fix For: Dynamic Include 3.2.2
Hello
i have the following problem in my AEM instance but i think it might be a
general problem.
The issue i am facing is that in my dispatcher configuration there are several
parameters defined with a * as wildcard.
This is configured for our tracking engine where users might get a link to a
page with one of these parameters.
For example:
{code:html}
https//www.mypage.com/latest-news?testengine-usergroup=10
{code}
In this case my dispatcher is configured to ignore the paramers that match the
following:
{code:html}
testengine-*
{code}
When i configured this in my SlingDynamicInclude config on the server under the
ignoreUrlParams it does not see the above parameter from the url as matching
for ignoreUrlParams.
{code:config}
include-filter.config.extension=""
include-filter.config.enabled=B"true"
include-filter.config.path="/content"
include-filter.config.required_header="Server-Agent\=Communique-Dispatcher"
include-filter.config.include-type="SSI"
include-filter.config.selector="nocache"
include-filter.config.add_comment=B"true"
include-filter.config.appendSuffix=B"true"
include-filter.config.rewrite=B"false"
include-filter.config.ttl=""
# These are the urlParams from the dispatcher that are ignored by as such and
will load from cache (for tracking etc.)
# If you do not ignore them then a page with rendered SDI will be cached if the
call contains these parameters
include-filter.config.ignoreUrlParams=[
"gclid",
"testengine-*"
]
include-filter.config.resource-types=[
"mypage/components/slingdynamic/dynamicbanner"
]
{code}
Instead the SDI component will completely render and since my dispatcher was
configured to ignore this parameter, the response will be cached with an
already rendered SDI-Component instead of the SDI-Tag.
I hope this information is enough to understand what my problem is.
If there are some more informations that you need or if something is not clear
enough please tell me and i will try to update everything that is needed
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (SLING-10111) data-sly-test: redundant constant value comparison
Marvin Flock created SLING-10111:
Summary: data-sly-test: redundant constant value comparison
Key: SLING-10111
URL: https://issues.apache.org/jira/browse/SLING-10111
Project: Sling
Issue Type: Bug
Components: Maven Plugins and Archetypes
Affects Versions: HTL Maven Plugin 2.0.2-1.4.0
Reporter: Marvin Flock
The HTL-Maven-Plugin (when set with _failOnWarnings = true_) is failing with
warnings like these:
_data-sly-test: redundant constant value comparison_
Problem is, this message is not giving a lot of insight, why it is failing.
e.g.:
I have a snippet like this:
_data-sly-test=${object.property}_
It fails with the mentioned warning and I am fishing in the dark.
It is a valid test, it checks _object.property_ for _null_, right?
Is it maybe a false positive?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[Jenkins] Sling » Modules » sling-org-apache-sling-launchpad-testing » master #330 is BROKEN
.testing-12-SNAPSHOT.jar
[INFO] Checking legal files in:
org.apache.sling.launchpad.testing-12-SNAPSHOT-sources.jar
[INFO]
[INFO] --- apache-rat-plugin:0.11:check (default) @
org.apache.sling.launchpad.testing ---
[INFO] 51 implicit excludes (use -debug for more details).
[INFO] Exclude: DEPENDENCIES
[INFO] Exclude: src/main/appended-resources/META-INF/*
[INFO] Exclude: velocity.log
[INFO] Exclude: target/*
[INFO] Exclude: README.md
[INFO] Exclude: maven-eclipse.xml
[INFO] Exclude: .*
[INFO] Exclude: .*/**
[INFO] Exclude: **/*.json
[INFO] Exclude: DEPENDENCIES
[INFO] Exclude: **/*.rej
[INFO] Exclude: hs_err_*.log
[INFO] Exclude: **/repository/index/*/index-details.txt
[INFO] Exclude: bnd.bnd
[INFO] 6 resources included (use -debug for more details)
[INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0
approved: 5 licence.
[INFO]
[INFO] --- maven-failsafe-plugin:2.21.0:verify (default) @
org.apache.sling.launchpad.testing ---
[INFO]
[INFO] BUILD FAILURE
[INFO]
[INFO] Total time: 03:20 min
[INFO] Finished at: 2021-02-01T11:20:47Z
[INFO]
[WARNING] The requested profile "ci" could not be activated because it does not
exist.
[INFO] [jenkins-event-spy] Generated
/home/jenkins/jenkins-agent/workspace/e-sling-launchpad-testing_master@tmp/withMaven8c1458d4/maven-spy-20210201-111726-9587794413320407440540.log
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-failsafe-plugin:2.21.0:verify (default) on
project org.apache.sling.launchpad.testing: There are test failures.
[ERROR]
[ERROR] Please refer to
/home/jenkins/jenkins-agent/workspace/e-sling-launchpad-testing_master/target/failsafe-reports
for the individual test results.
[ERROR] Please refer to dump files (if any exist) [date]-jvmRun[N].dump,
[date].dumpstream and [date]-jvmRun[N].dumpstream.
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please
read the following articles:
[ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[Pipeline] }
[withMaven] junitPublisher - Archive test results for Maven artifact
org.apache.sling:org.apache.sling.launchpad.testing:jar:12-SNAPSHOT generated
by maven-surefire-plugin:test (default-test): target/surefire-reports/*.xml
Recording test results
None of the test reports contained any result
[withMaven] junitPublisher - Archive test results for Maven artifact
org.apache.sling:org.apache.sling.launchpad.testing:jar:12-SNAPSHOT generated
by maven-failsafe-plugin:integration-test (default):
target/failsafe-reports/*.xml
Recording test results
[DevOpticsMavenPublisher] dependencies consumed: 93, artifacts produced: 0
[withMaven] Publishers: Pipeline Graph Publisher: 9 ms, Generated Artifacts
Publisher: 507 ms, Junit Publisher: 129027 ms, Dependencies Fingerprint
Publisher: 1183 ms, Open Task Scanner Publisher: 169 ms, CloudBees DevOptics
Gate Artifact Publisher: 55122 ms
[Pipeline] // withMaven
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
[Pipeline] // timeout
[Pipeline] stage
[Pipeline] { (Notifications)
[Pipeline] echo
Status change is BROKEN, notifications will be sent.
[Pipeline] emailext
Questions surfaced by SLING-9999
Hi, we have a discussion going on at SLING- that needs some resolving. As far as I can see, there are the following proposals in the issue: #1 move the o.a.s.servlets.resolver.bundle.tracker package to another artifact #2 rename the package to something else #3 split up the package to move the ResourceType class to sling api As far as the positioning goes, I guess my summary would be: On the one hand, to not have the scripting bundles depend on the servlets.resolver (#1 above) and on the other hand (#2), would it be better to have the package name include "scripting" (I’m not sure we have to discuss #3 right now as that seems to be orthogonal)? Please correct me if I'm missing something (we could work with optional imports as well but that isn't the nicest way to handle dependencies). One option to achieve #1 is to introduce a servlets.api bundle. I guess the idea behind that one is that this way, the servlets.resolver doesn’t require the scripting.api and the scripting doesn’t require the servlets.resolver (just this new api bundle). Another way to do it is to move the package to scripting.api. Which solves it as well with the downside of having the servlets.resolver require the scripting.api. Granted, if #2 is taken into account (renaming the package to be the in scripting namespace) it makes sense. Ultimately, I guess the question for this list to get consensus on is: Do we want the servlets.resolver to have a dependency on scripting.api or do we rather introduce a new servlets.resolver.api bundle - with a possible tie-breaking subquestion of do we think the bundle.tracker api package should stay in the namespace it is in right now or should it move to the scripting namespace? Personally, I think the package namespace is a slightly better fit for the servlets resolver rather than the scripting and consequently, would go with the servlets.resolver.api bundle as a reasonable compromise. regards, Karl -- Karl Pauls karlpa...@gmail.com
[jira] [Created] (SLING-10112) Distribution Queue can not be reliably cleared due to race condition processing delete messages
Christian Schneider created SLING-10112: --- Summary: Distribution Queue can not be reliably cleared due to race condition processing delete messages Key: SLING-10112 URL: https://issues.apache.org/jira/browse/SLING-10112 Project: Sling Issue Type: Improvement Components: Content Distribution Reporter: Christian Schneider Assignee: Christian Schneider Replication queue can not be reliable cleared due to race condition with processing the 'delete' messages. If the first message is stuck during processing, the 'clear queue' signal might never have effect on the subscriber. A restart of the process does not help as the same situation might occur. -- This message was sent by Atlassian Jira (v8.3.4#803005)
SPI for Pre/Postprocessing Content Distribution Packages
Hi everyone, when looking at https://sling.apache.org/documentation/bundles/content-distribution.html and https://github.com/apache/sling-org-apache-sling-distribution-core I couldn't find hooks for preprocessing/postprocessing distribution packages. Is the only option to to apply some operations before and after the actual installation to implement a custom distribution package or is there maybe a more lightweight approach? Thanks, Konrad P.S. I know of FileVault Install Hooks (http://jackrabbit.apache.org/filevault/installhooks.html) but since those can only be executed by admin users, they cannot be used in this particular use case (https://issues.apache.org/jira/browse/JCRVLT-427).
[jira] [Commented] (SLING-9906) Avoid retrying to load jobs if classes are missing
[ https://issues.apache.org/jira/browse/SLING-9906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17276443#comment-17276443 ] Stefan Egli commented on SLING-9906: [~cziegeler], thx for the review! I was actually intending to handle the BundleEvent and then thought hooking into configurationChanged would be enough (as that is invoked on PROPERTIES_CHANGED TopologyEvent - which is triggered if a bundle is activated that exposes a job consumer/executor). But that indeed might not be enough as the class might be in another bundle for example. So I've now added handling of BundleEvent explicitly [here|https://github.com/apache/sling-org-apache-sling-event/pull/8/commits/f24618bf7080f8b66c4cc0779b9f1e27c8a18964] > Avoid retrying to load jobs if classes are missing > -- > > Key: SLING-9906 > URL: https://issues.apache.org/jira/browse/SLING-9906 > Project: Sling > Issue Type: Improvement > Components: Event >Reporter: Carsten Ziegeler >Assignee: Stefan Egli >Priority: Major > Fix For: Event 4.2.14 > > Time Spent: 20m > Remaining Estimate: 0h > > When a Sling job is tried to be loaded, it might reference public api classes > provided by bundles - although that is a bad pattern that should be avoid, > sometimes this is used. > While the job engine does not try to reload those jobs for execution - unless > such a new job is created (which is unlikely as the class is missing), the > re-assigning of jobs from a removed instance to a new one suffers from the > same problem. And that is retried over and over again. > So there are probably several possible improvements: > - make sure that jobs are not reloaded when public classes are missing during > job execution (unless bundles have changed) > - reduce log output to a log statement (except of stack trace) if > classloading for jobs fails > - change re-assigning of jobs to not require classes to be available. This > can probably be solved by using ResourceResolver.move -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-10113) data-sly-resource RecursionTooDeepException
Marvin Flock created SLING-10113: Summary: data-sly-resource RecursionTooDeepException Key: SLING-10113 URL: https://issues.apache.org/jira/browse/SLING-10113 Project: Sling Issue Type: Bug Components: Scripting Reporter: Marvin Flock Attachments: image-2021-02-01-17-40-19-873.png AEM Version 6.5.7 While using data-sly-resource with a path, I get a RecursionTooDeepException. See -SLING-7685- for Reference I currently cant make hold of the behavior, using __ will include the current page infinite times (at least it tries) instead of the target page while using something like this: __ will render the curentPage with the RecursionTooDeepException. The HTL Engine I am using is of the following version: !image-2021-02-01-17-40-19-873.png! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-10113) data-sly-resource throwing RecursionTooDeepException
[ https://issues.apache.org/jira/browse/SLING-10113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marvin Flock updated SLING-10113: - Summary: data-sly-resource throwing RecursionTooDeepException (was: data-sly-resource RecursionTooDeepException) > data-sly-resource throwing RecursionTooDeepException > > > Key: SLING-10113 > URL: https://issues.apache.org/jira/browse/SLING-10113 > Project: Sling > Issue Type: Bug > Components: Scripting >Reporter: Marvin Flock >Priority: Major > Attachments: image-2021-02-01-17-40-19-873.png > > > AEM Version 6.5.7 > While using data-sly-resource with a path, I get a RecursionTooDeepException. > See -SLING-7685- for Reference > I currently cant make hold of the behavior, using > __ > will include the current page infinite times (at least it tries) instead of > the target page > while using something like this: > __ > will render the curentPage with the RecursionTooDeepException. > The HTL Engine I am using is of the following version: > !image-2021-02-01-17-40-19-873.png! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-10113) data-sly-resource throwing RecursionTooDeepException
[ https://issues.apache.org/jira/browse/SLING-10113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marvin Flock updated SLING-10113: - Description: AEM Version 6.5.7 While using data-sly-resource with a path, I get a RecursionTooDeepException. See -SLING-7685- for Similarity I currently cant make hold of the behavior, using __ will include the current page infinite times (at least it tries) instead of the target page while using something like this: __ will render the curentPage with the RecursionTooDeepException. The HTL Engine I am using is of the following version: !image-2021-02-01-17-40-19-873.png! was: AEM Version 6.5.7 While using data-sly-resource with a path, I get a RecursionTooDeepException. See -SLING-7685- for Reference I currently cant make hold of the behavior, using __ will include the current page infinite times (at least it tries) instead of the target page while using something like this: __ will render the curentPage with the RecursionTooDeepException. The HTL Engine I am using is of the following version: !image-2021-02-01-17-40-19-873.png! > data-sly-resource throwing RecursionTooDeepException > > > Key: SLING-10113 > URL: https://issues.apache.org/jira/browse/SLING-10113 > Project: Sling > Issue Type: Bug > Components: Scripting >Reporter: Marvin Flock >Priority: Major > Attachments: image-2021-02-01-17-40-19-873.png > > > AEM Version 6.5.7 > While using data-sly-resource with a path, I get a RecursionTooDeepException. > See -SLING-7685- for Similarity > I currently cant make hold of the behavior, using > __ > will include the current page infinite times (at least it tries) instead of > the target page > while using something like this: > __ > will render the curentPage with the RecursionTooDeepException. > The HTL Engine I am using is of the following version: > !image-2021-02-01-17-40-19-873.png! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [sling-org-apache-sling-event] stefan-egli commented on pull request #8: SLING-9906 : Avoid retrying to load jobs if classes are missing
stefan-egli commented on pull request #8: URL: https://github.com/apache/sling-org-apache-sling-event/pull/8#issuecomment-771027417 /retest please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-event] stefan-egli commented on pull request #8: SLING-9906 : Avoid retrying to load jobs if classes are missing
stefan-egli commented on pull request #8: URL: https://github.com/apache/sling-org-apache-sling-event/pull/8#issuecomment-771061224 Following output from jenkins (sort of looks unrelated to my changes ... ) : ``` + mvn -U clean verify sonar:sonar -Dsonar.host.url=https://sonarcloud.io -Dsonar.organization=apache -Dsonar.projectKey=apache_sling-org-apache-sling-event -Pjacoco-report -Dsonar.coverage.jacoco.xmlReportPaths=target/site/jacoco-merged/jacoco.xml -Dsonar.pullrequest.branch=SLING-9906 -Dsonar.pullrequest.base=master -Dsonar.pullrequest.key=8 -Pci - withMaven Wrapper script - Picked up JAVA_TOOL_OPTIONS: -Dmaven.ext.class.path="/home/jenkins/workspace/ling-org-apache-sling-event_PR-8@tmp/withMaven319b0e24/pipeline-maven-spy.jar" -Dorg.jenkinsci.plugins.pipeline.maven.reportsFolder="/home/jenkins/workspace/ling-org-apache-sling-event_PR-8@tmp/withMaven319b0e24" Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f) Maven home: /home/jenkins/tools/maven/latest3 Java version: 11.0.9, vendor: Oracle Corporation, runtime: /usr/local/asfpackages/java/oraclejdk-11.0.9 Default locale: en_US, platform encoding: ISO-8859-1 OS name: "linux", version: "4.15.0-76-generic", arch: "amd64", family: "unix" [INFO] [jenkins-event-spy] Generate /home/jenkins/workspace/ling-org-apache-sling-event_PR-8@tmp/withMaven319b0e24/maven-spy-20210201-180903-12312722978851857616059.log.tmp ... [INFO] Scanning for projects... [WARNING] [WARNING] Some problems were encountered while building the effective model for org.apache.sling:org.apache.sling.event:bundle:4.2.13-SNAPSHOT [WARNING] 'dependencies.dependency.(groupId:artifactId:type:classifier)' must be unique: org.mockito:mockito-all:jar -> version 1.10.19 vs 1.9.5 @ line 382, column 21 [WARNING] [WARNING] It is highly recommended to fix these problems because they threaten the stability of your build. [WARNING] [WARNING] For this reason, future Maven versions might no longer support building such malformed projects. [WARNING] [INFO] Downloading from central: https://repo.maven.apache.org/maven2/org/codehaus/mojo/maven-metadata.xml [INFO] Downloading from Nexus: http://repository.apache.org/snapshots/org/apache/maven/plugins/maven-metadata.xml [INFO] Downloading from central: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-metadata.xml [INFO] Downloading from Nexus: http://repository.apache.org/snapshots/org/codehaus/mojo/maven-metadata.xml [INFO] Downloaded from central: https://repo.maven.apache.org/maven2/org/codehaus/mojo/maven-metadata.xml (20 kB at 34 kB/s) [INFO] Downloaded from central: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-metadata.xml (14 kB at 23 kB/s) [INFO] Downloaded from Nexus: http://repository.apache.org/snapshots/org/apache/maven/plugins/maven-metadata.xml (8.5 kB at 12 kB/s) [INFO] Downloading from Nexus: http://repository.apache.org/snapshots/org/codehaus/mojo/sonar-maven-plugin/maven-metadata.xml [INFO] Downloading from central: https://repo.maven.apache.org/maven2/org/codehaus/mojo/sonar-maven-plugin/maven-metadata.xml [INFO] Downloaded from central: https://repo.maven.apache.org/maven2/org/codehaus/mojo/sonar-maven-plugin/maven-metadata.xml (1.2 kB at 43 kB/s) [INFO] [INFO] --< org.apache.sling:org.apache.sling.event >--- [INFO] Building Apache Sling Event Support 4.2.13-SNAPSHOT [INFO] ---[ bundle ]--- [INFO] [INFO] --- maven-clean-plugin:3.0.0:clean (default-clean) @ org.apache.sling.event --- [INFO] Deleting /home/jenkins/workspace/ling-org-apache-sling-event_PR-8/target [INFO] Deleting /home/jenkins/workspace/ling-org-apache-sling-event_PR-8 (includes = [derby.log], excludes = []) [INFO] [INFO] --- maven-enforcer-plugin:3.0.0-M1:enforce (enforce-property-values) @ org.apache.sling.event --- [INFO] [INFO] --- maven-enforcer-plugin:3.0.0-M1:enforce (enforce-java) @ org.apache.sling.event --- [INFO] [INFO] --- maven-enforcer-plugin:3.0.0-M1:enforce (ban-maven-scr-plugin) @ org.apache.sling.event --- [INFO] [INFO] --- jacoco-maven-plugin:0.7.9:prepare-agent (prepare-agent) @ org.apache.sling.event --- [INFO] argLine set to -javaagent:/home/jenkins/.m2/repository/org/jacoco/org.jacoco.agent/0.7.9/org.jacoco.agent-0.7.9-runtime.jar=destfile=/home/jenkins/workspace/ling-org-apache-sling-event_PR-8/target/jacoco-unit.exec [INFO] [INFO] --- maven-remote-resources-plugin:1.5:process (process-resource-bundles) @ org.apache.sling.event --- [INFO] [INFO] --- maven-remote-resources-plugin:1.5:process (default) @ org.apache.sling.event --- [INFO] [INFO] --- maven-resources-plugin:2.7:resources (default-resources) @ org.apa
[GitHub] [sling-org-apache-sling-event] stefan-egli opened a new pull request #9: just a test - wont merge this
stefan-egli opened a new pull request #9: URL: https://github.com/apache/sling-org-apache-sling-event/pull/9 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-event] stefan-egli commented on pull request #8: SLING-9906 : Avoid retrying to load jobs if classes are missing
stefan-egli commented on pull request #8: URL: https://github.com/apache/sling-org-apache-sling-event/pull/8#issuecomment-771068514 I'm assuming the jenkins errors are unrelated to this PR - https://github.com/apache/sling-org-apache-sling-event/pull/8/commits/752055ed7d0641bc44e9ba60c78481dc7a778f01 helped indeed - so will merge anyway. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-event] stefan-egli merged pull request #8: SLING-9906 : Avoid retrying to load jobs if classes are missing
stefan-egli merged pull request #8: URL: https://github.com/apache/sling-org-apache-sling-event/pull/8 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Sling Repository Initializer is failing on Setting a Property with Curly Brackets in them
Hi
If I try to create a property with a curly brackets in it then the parsing
fails:
set properties on /var/dxml/folderprofiles
set globalDefaultConfigs{String} to \"{\"type\":\"one\"}\"
end
I tried to escape the curly brackets with \{ and \} but to no avail.
Is there a way to use unicode or ascii codes or any other way to fix it?
Should this be considered a bug as curly brackets in a string properly is a
valid value? If so I will create a ticket for it.
- Andy
[jira] [Created] (SLING-10114) Document content distribution events
Timothee Maret created SLING-10114: -- Summary: Document content distribution events Key: SLING-10114 URL: https://issues.apache.org/jira/browse/SLING-10114 Project: Sling Issue Type: Improvement Components: Content Distribution Affects Versions: Content Distribution Core 0.4.2 Reporter: Timothee Maret The existing documentation https://sling.apache.org/documentation/bundles/content-distribution.html#events is not complete. We should add the properties contained in the events and an example showing how to use events to distribute content and be notified about the status. -- This message was sent by Atlassian Jira (v8.3.4#803005)
Re: SPI for Pre/Postprocessing Content Distribution Packages
Hi Konrad, Are those processor required to operate in the same thread and same session as the import ? If not, how about leveraging distribution events https://sling.apache.org/documentation/bundles/content-distribution.html#events ? We could raise an extra event before importing content. Regards, Timothee Le lun. 1 févr. 2021 à 17:11, Konrad Windszus a écrit : > Hi everyone, > when looking at > https://sling.apache.org/documentation/bundles/content-distribution.html > and https://github.com/apache/sling-org-apache-sling-distribution-core I > couldn't find hooks for preprocessing/postprocessing distribution packages. > Is the only option to to apply some operations before and after the actual > installation to implement a custom distribution package or is there maybe a > more lightweight approach? > > Thanks, > Konrad > > P.S. I know of FileVault Install Hooks ( > http://jackrabbit.apache.org/filevault/installhooks.html) but since those > can only be executed by admin users, they cannot be used in this particular > use case (https://issues.apache.org/jira/browse/JCRVLT-427). > >
Re: Sling Repository Initializer is failing on Setting a Property with Curly Brackets in them
Hi
As it turns out the problem is NOT the curly brackets but rather the internal
double quotes.
- Andy
> On Feb 1, 2021, at 12:05 PM, Andreas Schaefer
> wrote:
>
> Hi
>
> If I try to create a property with a curly brackets in it then the parsing
> fails:
>
>set properties on /var/dxml/folderprofiles
>set globalDefaultConfigs{String} to \"{\"type\":\"one\"}\"
>end
>
> I tried to escape the curly brackets with \{ and \} but to no avail.
>
> Is there a way to use unicode or ascii codes or any other way to fix it?
>
> Should this be considered a bug as curly brackets in a string properly is a
> valid value? If so I will create a ticket for it.
>
> - Andy
[jira] [Commented] (SLING-10113) data-sly-resource throwing RecursionTooDeepException
[
https://issues.apache.org/jira/browse/SLING-10113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17276645#comment-17276645
]
Paul Bjorkstrand commented on SLING-10113:
--
Does {{targetPagePath}} start with a slash ({{/}})? Per the code [1], the path
is appended to the current resource, if it does not
[1]:
https://github.com/apache/sling-org-apache-sling-scripting-sightly/blob/org.apache.sling.scripting.sightly-1.1.2-1.4.0/src/main/java/org/apache/sling/scripting/sightly/impl/engine/extension/ResourceRuntimeExtension.java#L212
> data-sly-resource throwing RecursionTooDeepException
>
>
> Key: SLING-10113
> URL: https://issues.apache.org/jira/browse/SLING-10113
> Project: Sling
> Issue Type: Bug
> Components: Scripting
>Reporter: Marvin Flock
>Priority: Major
> Attachments: image-2021-02-01-17-40-19-873.png
>
>
> AEM Version 6.5.7
> While using data-sly-resource with a path, I get a RecursionTooDeepException.
> See -SLING-7685- for Similarity
> I currently cant make hold of the behavior, using
> __
> will include the current page infinite times (at least it tries) instead of
> the target page
> while using something like this:
> __
> will render the curentPage with the RecursionTooDeepException.
> The HTL Engine I am using is of the following version:
> !image-2021-02-01-17-40-19-873.png!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
Re: Questions surfaced by SLING-9999
On Monday, February 1, 2021 1:17:23 PM CET Karl Pauls wrote: > Hi, Hi, > we have a discussion going on at SLING- that needs some resolving. > > As far as I can see, there are the following proposals in the issue: > > #1 move the o.a.s.servlets.resolver.bundle.tracker package to another > artifact #2 rename the package to something else > #3 split up the package to move the ResourceType class to sling api > > As far as the positioning goes, I guess my summary would be: > > On the one hand, to not have the scripting bundles depend on the > servlets.resolver (#1 above) and on the other hand (#2), would it be > better to have the package name include "scripting" (I’m not sure we > have to discuss #3 right now as that seems to be orthogonal)? Please > correct me if I'm missing something (we could work with optional > imports as well but that isn't the nicest way to handle dependencies). > > One option to achieve #1 is to introduce a servlets.api bundle. I guess the > idea behind that one is that this way, the servlets.resolver doesn’t > require the scripting.api and the scripting doesn’t require the > servlets.resolver (just this new api bundle). > > Another way to do it is to move the package to scripting.api. Which > solves it as well with the downside of having the servlets.resolver > require the scripting.api. Granted, if #2 is taken into account > (renaming the package to be the in scripting namespace) it makes > sense. > > Ultimately, I guess the question for this list to get consensus on is: > > Do we want the servlets.resolver to have a dependency on scripting.api > or do we rather introduce a new servlets.resolver.api bundle - with a > possible tie-breaking subquestion of do we think the bundle.tracker > api package should stay in the namespace it is in right now or should > it move to the scripting namespace? > > Personally, I think the package namespace is a slightly better fit for > the servlets resolver rather than the scripting and consequently, > would go with the servlets.resolver.api bundle as a reasonable > compromise. #1 move the o.a.s.servlets.resolver.bundle.tracker package to another artifact Package o.a.s.servlets.resolver.bundle.tracker contains the new Bundle API for _Scripts_. The API is a new dependency for Scripting Core, Scripting HTL, Scripting JSP and Servlets Resolver. To provide its full functionality Servlets Resolver requires the optional dependency Scripting Core. Therefore it makes sense to move the package out of Servlets Resolver to not have a cyclic dependency. As Karl said optional imports are not a nice way to handle dependencies. #2 rename the package to something else See dependents (mostly scripting) above. The classes in the package reference or deal with Script(ing) and not Servlets Resolver, see [1]. I see the API/SPI therefore in a "scripting" package (without tracker as it is an implementation detail) and matching bundle: a) o.a.s.scripting.api.bundle (bundle o.a.s.scripting.api) b) o.a.s.scripting.spi.bundle (new bundle o.a.s.scripting.spi) c) o.a.s.api.scripting.bundle (bundle o.a.s.api) d) o.a.s.spi.scripting.bundle (bundle o.a.s.api) #3 split up the package to move the ResourceType class to sling api ResourceType is generic and can be used in different contexts not related to Scripting or Servlets Resolver. Therefore it makes sense to move it into package o.a.s.api.resource.type in Sling API bundle. [1] https://issues.apache.org/jira/browse/SLING-? focusedCommentId=17275984&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment- tabpanel#comment-17275984 Regards, O. > regards, > > Karl
Re: Sling Repository Initializer is failing on Setting a Property with Curly Brackets in them
I got around this issue by extracting the setting of the properties into a
reference file (repoinit.txt) and there is works as there the quotes can be
escaped with a \.
- Andy
> On Feb 1, 2021, at 12:52 PM, Andreas Schaefer
> wrote:
>
> Hi
>
> As it turns out the problem is NOT the curly brackets but rather the internal
> double quotes.
>
> - Andy
>
>> On Feb 1, 2021, at 12:05 PM, Andreas Schaefer
>> wrote:
>>
>> Hi
>>
>> If I try to create a property with a curly brackets in it then the parsing
>> fails:
>>
>> set properties on /var/dxml/folderprofiles
>> set globalDefaultConfigs{String} to \"{\"type\":\"one\"}\"
>> end
>>
>> I tried to escape the curly brackets with \{ and \} but to no avail.
>>
>> Is there a way to use unicode or ascii codes or any other way to fix it?
>>
>> Should this be considered a bug as curly brackets in a string properly is a
>> valid value? If so I will create a ticket for it.
>>
>> - Andy
>
Re: Sling Repository Initializer is failing on Setting a Property with Curly Brackets in them
I ran into another issue:
How can I define a multi-value string with No or just ONE entry?
When I try:
- set test to “one”,// It is a String[] multi-value but with two
values where the 2nd is empty
- set test to , // The parsing fails
In addition using a keyword like ‘end’ fails to parse:
- set end to “TEST” // Fails to parse
- set end{String} to “TEST” // Fails to parse
- set ‘end’ to “TEST” // Fails to parse
- set “end” to “TEST” // Fails to parse
Cheers - Andy
> On Feb 1, 2021, at 1:58 PM, Andreas Schaefer wrote:
>
> I got around this issue by extracting the setting of the properties into a
> reference file (repoinit.txt) and there is works as there the quotes can be
> escaped with a \.
>
> - Andy
>
>> On Feb 1, 2021, at 12:52 PM, Andreas Schaefer
>> wrote:
>>
>> Hi
>>
>> As it turns out the problem is NOT the curly brackets but rather the
>> internal double quotes.
>>
>> - Andy
>>
>>> On Feb 1, 2021, at 12:05 PM, Andreas Schaefer
>>> wrote:
>>>
>>> Hi
>>>
>>> If I try to create a property with a curly brackets in it then the parsing
>>> fails:
>>>
>>> set properties on /var/dxml/folderprofiles
>>> set globalDefaultConfigs{String} to \"{\"type\":\"one\"}\"
>>> end
>>>
>>> I tried to escape the curly brackets with \{ and \} but to no avail.
>>>
>>> Is there a way to use unicode or ascii codes or any other way to fix it?
>>>
>>> Should this be considered a bug as curly brackets in a string properly is a
>>> valid value? If so I will create a ticket for it.
>>>
>>> - Andy
>>
>
[jira] [Created] (SLING-10115) CMS - Reference - Select Does Not Validate Required
Dan Klco created SLING-10115: Summary: CMS - Reference - Select Does Not Validate Required Key: SLING-10115 URL: https://issues.apache.org/jira/browse/SLING-10115 Project: Sling Issue Type: Bug Components: App CMS Reference Affects Versions: App CMS 0.16.2 Reporter: Dan Klco Assignee: Dan Klco Fix For: App CMS 1.0.2 When using a select field the required attribute is not set and the default value is not set to blank so the form will submit the default text if the user does not select a value. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-10080) Onboard org.apache.sling.jcr.maintenance to SonarCloud
[ https://issues.apache.org/jira/browse/SLING-10080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco resolved SLING-10080. -- Resolution: Fixed Thanks [~bellingard] > Onboard org.apache.sling.jcr.maintenance to SonarCloud > -- > > Key: SLING-10080 > URL: https://issues.apache.org/jira/browse/SLING-10080 > Project: Sling > Issue Type: Task >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Major > Attachments: screenshot-1.png > > > [~bellingard] - can you please onboard > https://github.com/apache/sling-org-apache-sling-jcr-maintenance to > SonarCloud? > Thanks! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-9985) Add Repository Maintenance Job
[ https://issues.apache.org/jira/browse/SLING-9985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17276845#comment-17276845 ] Dan Klco commented on SLING-9985: - Note -- should also resolve SLING-7495 > Add Repository Maintenance Job > -- > > Key: SLING-9985 > URL: https://issues.apache.org/jira/browse/SLING-9985 > Project: Sling > Issue Type: Improvement > Components: App CMS, Starter >Affects Versions: Starter 11, App CMS 0.16.2 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Major > Labels: Sling-12-ReleaseNotes > Fix For: Starter 12, App CMS 1.0.2, JCR Maintenance 1.0.0 > > > Currently, versions created in Sling CMS don't get automatically purged which > can cause excessive repository growth if not cleaned up. The job should > support deleting older versions based on a limit on the number of versions > and removing versions on deleted resources after a specified time period. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-10115) CMS - Reference - Select Does Not Validate Required
[ https://issues.apache.org/jira/browse/SLING-10115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17276847#comment-17276847 ] Dan Klco commented on SLING-10115: -- Fixed in https://github.com/apache/sling-org-apache-sling-app-cms/commit/7f8b3b41056c1026742351af4618bc1c0782496a > CMS - Reference - Select Does Not Validate Required > --- > > Key: SLING-10115 > URL: https://issues.apache.org/jira/browse/SLING-10115 > Project: Sling > Issue Type: Bug > Components: App CMS Reference >Affects Versions: App CMS 0.16.2 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Major > Fix For: App CMS 1.0.2 > > > When using a select field the required attribute is not set and the default > value is not set to blank so the form will submit the default text if the > user does not select a value. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-10115) CMS - Reference - Select Does Not Validate Required
[ https://issues.apache.org/jira/browse/SLING-10115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco resolved SLING-10115. -- Resolution: Fixed > CMS - Reference - Select Does Not Validate Required > --- > > Key: SLING-10115 > URL: https://issues.apache.org/jira/browse/SLING-10115 > Project: Sling > Issue Type: Bug > Components: App CMS Reference >Affects Versions: App CMS 0.16.2 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Major > Fix For: App CMS 1.0.2 > > > When using a select field the required attribute is not set and the default > value is not set to blank so the form will submit the default text if the > user does not select a value. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-7495) Start of online compaction of the repository
[ https://issues.apache.org/jira/browse/SLING-7495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco updated SLING-7495: Fix Version/s: JCR Maintenance 1.0.0 > Start of online compaction of the repository > > > Key: SLING-7495 > URL: https://issues.apache.org/jira/browse/SLING-7495 > Project: Sling > Issue Type: Improvement >Reporter: Guido Dunker >Priority: Critical > Fix For: JCR Maintenance 1.0.0 > > > There is no information about when the online compaction will be startet. > I cannot see any cron pattern or time i could configure. The only way to start > the compaction at a given time, is to call the mbean from outside. Please > find a way > to configure start times like we see in the according AEM software. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-7495) Start of online compaction of the repository
[ https://issues.apache.org/jira/browse/SLING-7495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco resolved SLING-7495. - Resolution: Fixed > Start of online compaction of the repository > > > Key: SLING-7495 > URL: https://issues.apache.org/jira/browse/SLING-7495 > Project: Sling > Issue Type: Improvement >Reporter: Guido Dunker >Priority: Critical > Fix For: JCR Maintenance 1.0.0 > > > There is no information about when the online compaction will be startet. > I cannot see any cron pattern or time i could configure. The only way to start > the compaction at a given time, is to call the mbean from outside. Please > find a way > to configure start times like we see in the according AEM software. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-9985) Add Repository Maintenance Job
[ https://issues.apache.org/jira/browse/SLING-9985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco resolved SLING-9985. - Resolution: Fixed > Add Repository Maintenance Job > -- > > Key: SLING-9985 > URL: https://issues.apache.org/jira/browse/SLING-9985 > Project: Sling > Issue Type: Improvement > Components: App CMS, Starter >Affects Versions: Starter 11, App CMS 0.16.2 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Major > Labels: Sling-12-ReleaseNotes > Fix For: Starter 12, App CMS 1.0.2, JCR Maintenance 1.0.0 > > > Currently, versions created in Sling CMS don't get automatically purged which > can cause excessive repository growth if not cleaned up. The job should > support deleting older versions based on a limit on the number of versions > and removing versions on deleted resources after a specified time period. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-9985) Add Repository Maintenance Job
[ https://issues.apache.org/jira/browse/SLING-9985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco updated SLING-9985: Fix Version/s: (was: App CMS 1.0.2) (was: Starter 12) > Add Repository Maintenance Job > -- > > Key: SLING-9985 > URL: https://issues.apache.org/jira/browse/SLING-9985 > Project: Sling > Issue Type: Improvement > Components: App CMS, Starter >Affects Versions: Starter 11, App CMS 0.16.2 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Major > Labels: Sling-12-ReleaseNotes > Fix For: JCR Maintenance 1.0.0 > > > Currently, versions created in Sling CMS don't get automatically purged which > can cause excessive repository growth if not cleaned up. The job should > support deleting older versions based on a limit on the number of versions > and removing versions on deleted resources after a specified time period. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-10116) Add Maintenance Job to Starter and CMS
Dan Klco created SLING-10116: Summary: Add Maintenance Job to Starter and CMS Key: SLING-10116 URL: https://issues.apache.org/jira/browse/SLING-10116 Project: Sling Issue Type: Sub-task Reporter: Dan Klco Assignee: Dan Klco Add the Maintenance Job bundle to the starter and CMS without the run configuration (by default). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-10116) Add Maintenance Job to Starter and CMS
[ https://issues.apache.org/jira/browse/SLING-10116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco updated SLING-10116: - Fix Version/s: App CMS 1.0.2 Starter 12 > Add Maintenance Job to Starter and CMS > -- > > Key: SLING-10116 > URL: https://issues.apache.org/jira/browse/SLING-10116 > Project: Sling > Issue Type: Sub-task >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Major > Fix For: Starter 12, App CMS 1.0.2 > > > Add the Maintenance Job bundle to the starter and CMS without the run > configuration (by default). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[VOTE] Release Apache Sling JCR Maintenance version 1.0.0
Hi, We solved 2 issues in this release: https://issues.apache.org/jira/projects/SLING/versions/12349606 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2403/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2403 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours.
