Re: [VOTE] Release Apache Sling Content Distribution Journal Messages version 0.2.0
+1 Le jeu. 4 févr. 2021 à 08:40, Robert Munteanu a écrit : > On Wed, 2021-02-03 at 15:09 +0100, Christian Schneider wrote: > > Please vote to approve this release: > > +1 > Robert >
Re: [VOTE] Release Apache Sling Content Distribution Journal Messages version 0.2.0
On Wed, 2021-02-03 at 15:09 +0100, Christian Schneider wrote: > Please vote to approve this release: +1 Robert signature.asc Description: This is a digitally signed message part
[GitHub] [sling-org-apache-sling-engine] akankshajain18 closed pull request #12: Sling 9741 dummy
akankshajain18 closed pull request #12: URL: https://github.com/apache/sling-org-apache-sling-engine/pull/12 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [VOTE] Release Apache Sling Content Distribution Journal Messages version 0.2.0
+1 Carsten Am 03.02.2021 um 15:09 schrieb Christian Schneider: Hi, We solved 3 issues in this release: https://issues.apache.org/jira/projects/SLING/versions/12348397 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2406/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2406 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. -- Here is my +1 -- -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org
Re: [VOTE] Release Apache Sling JCR Maintenance version 1.0.0
Stefan, Thanks for the note. At one point my thought was that there should be a SPI exposed for extending the logic for Version Purging, but until required, YAGNI. I missed consolidating the packages during refactoring, but as stated since they're not exposed it could be done at any point. On Tue, Feb 2, 2021 at 4:57 PM Stefan Seifert wrote: > +1 > > one cosmetic note: the name of the package > org.apache.sling.jcr.maintenance vs. > org.apache.sling.jcr.maintenance.internal seems to imply the first package > is exported via OSGi, the second not. but both are not exported (which is > probably by intention). the package names are a bit confusing - but they > can be changed later as they are not exported. > > stefan > > > >-Original Message- > >From: Daniel Klco > >Sent: Tuesday, February 2, 2021 5:35 AM > >To: dev@sling.apache.org > >Subject: [VOTE] Release Apache Sling JCR Maintenance version 1.0.0 > > > >Hi, > > > >We solved 2 issues in this release: > >https://issues.apache.org/jira/projects/SLING/versions/12349606 > > > >Staging repository: > >https://repository.apache.org/content/repositories/orgapachesling-2403/ > > > >You can use this UNIX script to download the release and verify the > >signatures: > >https://gitbox.apache.org/repos/asf?p=sling-tooling- > >release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > > >Usage: > >sh check_staged_release.sh 2403 /tmp/sling-staging > > > >Please vote to approve this release: > > > > [ ] +1 Approve the release > > [ ] 0 Don't care > > [ ] -1 Don't release, because ... > > > >This majority vote is open for at least 72 hours. >
Re: [VOTE] Release Apache Sling Content Distribution Journal Messages version 0.2.0
+1 On Wed, Feb 3, 2021 at 9:09 AM Christian Schneider wrote: > Hi, > > We solved 3 issues in this release: > https://issues.apache.org/jira/projects/SLING/versions/12348397 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2406/ > > You can use this UNIX script to download the release and verify the > signatures: > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh 2406 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > -- > > Here is my > +1 > > -- > -- > Christian Schneider > http://www.liquid-reality.de > > Computer Scientist > http://www.adobe.com >
[jira] [Commented] (SLING-10122) A Equal Sign (=) in a set properties instruction makes the Converter fail
[ https://issues.apache.org/jira/browse/SLING-10122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17278339#comment-17278339 ] Andreas Schaefer commented on SLING-10122: -- Enhanced the Repository Initializer test to showcase this issue. If the '\=\ is replaced by '=' it will fail the test: set properties on /test set testprop to \"one\=two\" end"\ > A Equal Sign (=) in a set properties instruction makes the Converter fail > - > > Key: SLING-10122 > URL: https://issues.apache.org/jira/browse/SLING-10122 > Project: Sling > Issue Type: Bug > Components: Feature Model >Affects Versions: Content-Package to Feature Model Converter 1.0.22 >Reporter: Andreas Schaefer >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.0.28 > > > An entry in a Repository Initializer like this: > "create path /test > set properties on /test > set testprop to \"one=two\" > end"\ > will make the ConfigurationEntryHandler fail with: > Tests run: 48, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.036 s <<< > FAILURE! - in > org.apache.sling.feature.cpconverter.handlers.ConfigurationEntryHandlerTest > org.apache.sling.feature.cpconverter.handlers.ConfigurationEntryHandlerTest.parseConfiguration[13] > Time elapsed: 0.005 s <<< ERROR! > java.io.IOException: Unexpected token 34; expected: 61 (line=24, pos=9) > at > org.apache.felix.cm.file.ConfigurationHandler.readFailure(ConfigurationHandler.java:700) > at > org.apache.felix.cm.file.ConfigurationHandler.readInternal(ConfigurationHandler.java:304) > at > org.apache.felix.cm.file.ConfigurationHandler.read(ConfigurationHandler.java:267) > at > org.apache.sling.feature.cpconverter.handlers.ConfigurationEntryHandler.parseConfiguration(ConfigurationEntryHandler.java:33) > at > org.apache.sling.feature.cpconverter.handlers.AbstractConfigurationEntryHandler.handle(AbstractConfigurationEntryHandler.java:66) > at > org.apache.sling.feature.cpconverter.handlers.ConfigurationEntryHandlerTest.parseConfiguration(ConfigurationEntryHandlerTest.java:132) > > I can fix that by escaping with a backslash but that is not a valid > Repository Initializer content. -- This message was sent by Atlassian Jira (v8.3.4#803005)
Re: How to create an admin user
Thank you for the suggestion! I'll give it a try! On Wed, Feb 3, 2021 at 11:36 AM Daniel Klco wrote: > Unless I'm missing something, this sounds like you'd to assign the user > into an administrative group and give that administrative group the JCR > repository permissions as well as adding the administrative group into the > groups list for the WebConsole Security Provider: > > https://sling.apache.org/documentation/bundles/web-console-extensions.html#security-provider-orgapacheslingextensionswebconsolesecurityprovider > > Ideally, you could do this with a callback after the keycloak > authentication using a service user. > > On Wed, Feb 3, 2021 at 11:15 AM Lisa Davidson wrote: > > > Eric, > > > > I'm integrating with keycloak. After the user is authenticated, if user > > does not exist, I create a new user via UserManager. > > > > I currently have a need to be able to grant a particular user admin > rights > > so that it can access > > Browse Content > > System Console > > System Configuration > > > > > > > > > > > > On Tue, Feb 2, 2021 at 5:21 PM Eric Norman wrote: > > > > > Hi Lisa, > > > > > > Can you provide some additional clarification on what you mean by "to > be > > > admin"? Are you saying you want to replace the autocreated "admin" user > > > with another existing user who then becomes the superuser for the > > > repository? Or maybe you meant something else? > > > > > > Regards, > > > Eric > > > > > > On Tue, Feb 2, 2021 at 12:56 PM Lisa Davidson wrote: > > > > > > > I have a need to update an existing user to be admin. For some > reason, > > I > > > > can't find a way to do that in either /bin/users.html/ web console on > > the > > > > UI or via the REST interface here > > > > > > > > > > > > > > https://sling.apache.org/documentation/bundles/managing-users-and-groups-jackrabbit-usermanager.html > > > > > > > > > > > > Any suggestions? > > > > -- > > > > Lisa Davidson, RHCE > > > > Sr. Software Engineer > > > > Red Hat, Inc. > > > > > > > > > > > > > -- > > Lisa Davidson, RHCE > > Sr. Software Engineer > > Red Hat, Inc. > > > -- Lisa Davidson, RHCE Sr. Software Engineer Red Hat, Inc.
[jira] [Updated] (SLING-10124) OSGi Mock - Service reference order is not correct
[ https://issues.apache.org/jira/browse/SLING-10124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roy Teeuwen updated SLING-10124: Component/s: Testing > OSGi Mock - Service reference order is not correct > -- > > Key: SLING-10124 > URL: https://issues.apache.org/jira/browse/SLING-10124 > Project: Sling > Issue Type: Bug > Components: Testing >Reporter: Roy Teeuwen >Priority: Major > > If I look at the osgi mocks implementation to get back a list of service > references, I have the feeling that the order is wrong: > https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/blob/ef6535bab69562ad3c2276dc84893fa2fab48438/core/src/main/java/org/apache/sling/testing/mock/osgi/MockBundleContext.java#L295 > It states here that the order is the reverse order, but if I check in the > framework itself, the following comment would state the other order (which is > what I also experience when debugging in a live instance) : > https://github.com/apache/felix-dev/blob/c562829a9ffd40af2f165a8b4763b4d6759f3c0f/framework/src/main/java/org/apache/felix/framework/ServiceRegistrationImpl.java#L688 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-10124) OSGi Mock - Service reference order is not correct
[ https://issues.apache.org/jira/browse/SLING-10124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17278216#comment-17278216 ] Roy Teeuwen commented on SLING-10124: - [~sseifert] I see you committed the code for the ordering, any idea's about this? I don't mind opening a PR to put the order back in the natural state but I want confirmation first that I'm not overlooking something > OSGi Mock - Service reference order is not correct > -- > > Key: SLING-10124 > URL: https://issues.apache.org/jira/browse/SLING-10124 > Project: Sling > Issue Type: Bug >Reporter: Roy Teeuwen >Priority: Major > > If I look at the osgi mocks implementation to get back a list of service > references, I have the feeling that the order is wrong: > https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/blob/ef6535bab69562ad3c2276dc84893fa2fab48438/core/src/main/java/org/apache/sling/testing/mock/osgi/MockBundleContext.java#L295 > It states here that the order is the reverse order, but if I check in the > framework itself, the following comment would state the other order (which is > what I also experience when debugging in a live instance) : > https://github.com/apache/felix-dev/blob/c562829a9ffd40af2f165a8b4763b4d6759f3c0f/framework/src/main/java/org/apache/felix/framework/ServiceRegistrationImpl.java#L688 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-10124) OSGi Mock - Service reference order is not correct
Roy Teeuwen created SLING-10124: --- Summary: OSGi Mock - Service reference order is not correct Key: SLING-10124 URL: https://issues.apache.org/jira/browse/SLING-10124 Project: Sling Issue Type: Bug Reporter: Roy Teeuwen If I look at the osgi mocks implementation to get back a list of service references, I have the feeling that the order is wrong: https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/blob/ef6535bab69562ad3c2276dc84893fa2fab48438/core/src/main/java/org/apache/sling/testing/mock/osgi/MockBundleContext.java#L295 It states here that the order is the reverse order, but if I check in the framework itself, the following comment would state the other order (which is what I also experience when debugging in a live instance) : https://github.com/apache/felix-dev/blob/c562829a9ffd40af2f165a8b4763b4d6759f3c0f/framework/src/main/java/org/apache/felix/framework/ServiceRegistrationImpl.java#L688 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [sling-org-apache-sling-engine] sonarcloud[bot] commented on pull request #12: Sling 9741 dummy
sonarcloud[bot] commented on pull request #12: URL: https://github.com/apache/sling-org-apache-sling-engine/pull/12#issuecomment-772663657 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine&pullRequest=12&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine&pullRequest=12&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine&pullRequest=12&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine&pullRequest=12&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine&pullRequest=12&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine&pullRequest=12&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-engine&pullRequest=12&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-engine&pullRequest=12&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-engine&pullRequest=12&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine&pullRequest=12&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine&pullRequest=12&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine&pullRequest=12&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-engine&pullRequest=12&metric=new_coverage&view=list) [76.9% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-engine&pullRequest=12&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-engine&pullRequest=12&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-engine&pullRequest=12&metric=new_duplicated_lines_density&view=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-engine] akankshajain18 opened a new pull request #12: Sling 9741 dummy
akankshajain18 opened a new pull request #12: URL: https://github.com/apache/sling-org-apache-sling-engine/pull/12 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: How to create an admin user
Unless I'm missing something, this sounds like you'd to assign the user into an administrative group and give that administrative group the JCR repository permissions as well as adding the administrative group into the groups list for the WebConsole Security Provider: https://sling.apache.org/documentation/bundles/web-console-extensions.html#security-provider-orgapacheslingextensionswebconsolesecurityprovider Ideally, you could do this with a callback after the keycloak authentication using a service user. On Wed, Feb 3, 2021 at 11:15 AM Lisa Davidson wrote: > Eric, > > I'm integrating with keycloak. After the user is authenticated, if user > does not exist, I create a new user via UserManager. > > I currently have a need to be able to grant a particular user admin rights > so that it can access > Browse Content > System Console > System Configuration > > > > > > On Tue, Feb 2, 2021 at 5:21 PM Eric Norman wrote: > > > Hi Lisa, > > > > Can you provide some additional clarification on what you mean by "to be > > admin"? Are you saying you want to replace the autocreated "admin" user > > with another existing user who then becomes the superuser for the > > repository? Or maybe you meant something else? > > > > Regards, > > Eric > > > > On Tue, Feb 2, 2021 at 12:56 PM Lisa Davidson wrote: > > > > > I have a need to update an existing user to be admin. For some reason, > I > > > can't find a way to do that in either /bin/users.html/ web console on > the > > > UI or via the REST interface here > > > > > > > > > https://sling.apache.org/documentation/bundles/managing-users-and-groups-jackrabbit-usermanager.html > > > > > > > > > Any suggestions? > > > -- > > > Lisa Davidson, RHCE > > > Sr. Software Engineer > > > Red Hat, Inc. > > > > > > > > -- > Lisa Davidson, RHCE > Sr. Software Engineer > Red Hat, Inc. >
Re: How to create an admin user
Eric, I'm integrating with keycloak. After the user is authenticated, if user does not exist, I create a new user via UserManager. I currently have a need to be able to grant a particular user admin rights so that it can access Browse Content System Console System Configuration On Tue, Feb 2, 2021 at 5:21 PM Eric Norman wrote: > Hi Lisa, > > Can you provide some additional clarification on what you mean by "to be > admin"? Are you saying you want to replace the autocreated "admin" user > with another existing user who then becomes the superuser for the > repository? Or maybe you meant something else? > > Regards, > Eric > > On Tue, Feb 2, 2021 at 12:56 PM Lisa Davidson wrote: > > > I have a need to update an existing user to be admin. For some reason, I > > can't find a way to do that in either /bin/users.html/ web console on the > > UI or via the REST interface here > > > > > https://sling.apache.org/documentation/bundles/managing-users-and-groups-jackrabbit-usermanager.html > > > > > > Any suggestions? > > -- > > Lisa Davidson, RHCE > > Sr. Software Engineer > > Red Hat, Inc. > > > -- Lisa Davidson, RHCE Sr. Software Engineer Red Hat, Inc.
[jira] [Resolved] (SLING-10106) Update to Apache Felix cm.json 1.0.6
[ https://issues.apache.org/jira/browse/SLING-10106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-10106. -- Resolution: Fixed Updated all to cm.json 1.0.6 > Update to Apache Felix cm.json 1.0.6 > > > Key: SLING-10106 > URL: https://issues.apache.org/jira/browse/SLING-10106 > Project: Sling > Issue Type: Improvement > Components: Feature Model >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Slingstart Maven Plugin 1.9.14, Installer Core 3.11.6, > Installer Factory Feature Model 0.6.0, Feature Model Launcher 1.1.16, > Content-Package to Feature Model Converter 1.0.26, Feature Model 1.2.20, > Feature Model Analyser 1.3.20, Feature Model API Regions Extension 1.1.20, > slingfeature-maven-plugin 1.4.24 > > > cm.json 1.0.4 provides propper handling of case-insensitive configuration > property keys -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [sling-org-apache-sling-engine] sonarcloud[bot] commented on pull request #11: SLING-9741|Invalid path decomposition in case of multiple dots
sonarcloud[bot] commented on pull request #11: URL: https://github.com/apache/sling-org-apache-sling-engine/pull/11#issuecomment-772588324 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine&pullRequest=11&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine&pullRequest=11&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine&pullRequest=11&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine&pullRequest=11&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine&pullRequest=11&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine&pullRequest=11&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-engine&pullRequest=11&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-engine&pullRequest=11&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-engine&pullRequest=11&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine&pullRequest=11&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine&pullRequest=11&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine&pullRequest=11&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-engine&pullRequest=11&metric=new_coverage&view=list) [75.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-engine&pullRequest=11&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-engine&pullRequest=11&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-engine&pullRequest=11&metric=new_duplicated_lines_density&view=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-engine] akankshajain18 opened a new pull request #11: SLING-9741|Invalid path decomposition in case of multiple dots
akankshajain18 opened a new pull request #11: URL: https://github.com/apache/sling-org-apache-sling-engine/pull/11 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [RT] Make bundles with Sling-Initial-Content first-class citizens in feature model tooling
Hi Stefan, I think we have more than two worlds - it's a multi-verse For example, for our projects we don't want to have initial content at all - thats why we need to have an analyser checking for this. If I think about other projects I can envision that some are fine with initial content for an immutable repository - but not for a mutable repository. And others might be fine with whatever they get. I think thats a choice every project should be able to make - it's like some projects like to code OSGi services with Declarative Services, some want to do via framework api, others want to use CDI etc. There is no right or wrong here. So for the analyser we need to have this configurable. We can discuss what we think is the best default for Sling based projects of course. For the cpconverter, I think it depends on where or who is using this. So you might want to enable converting initial content to a content package or you might be fine with ignoring it or you use the "normal" way of the contentloader bundle at runtime. It's again the users choice. Regards Carsten Am 03.02.2021 um 15:12 schrieb Stefan Seifert: hello carsten. can you give some more details about the "setups and requirements" that differ? i fear if we introduce a switch to distinguish on those things we create different "worlds" of scenarios which all have to be maintained and tested separately in the already quite complex toolchain around feature models. and why is it exactly the Sling-Initial-Content support which will be the pivot that separates one world from the other? stefan -Original Message- From: Carsten Ziegeler Sent: Wednesday, February 3, 2021 6:51 AM To: dev@sling.apache.org Subject: Re: [RT] Make bundles with Sling-Initial-Content first-class citizens in feature model tooling Hi, in general, I think those changes make sense. However, project setups and requirements differ - so I think it makes sense to have an analyser that forbids initial content in bundles. So we either make the existing analyser configurable or have two analysers. I think the same applies to the cpconverter: having a switch which either allows initial content and creates the content packages as you suggest or fails. Regards Carsten Am 02.02.2021 um 23:38 schrieb Stefan Seifert: currently, bundles with Sling-Initial-Content have not special support in the feature model tooling and when used with composite nodestore. however, they work just fine e.g. in AEMaaCS because during the image build phase the contained content gets extracted and baked into the docker image. at runtime, the Sling JCR content loader produces a warning about the locked down /apps folder which can be ignored, because the content is already there and does not need to be extracted again. however, it's probably currently working only due to "lucky circumstances" in the current process of cloud build pipeline. the sling-feature-analyzer [1] is currently looking out for bundles with Sling-Initial-Content and produce a warning if it founds any. Sling-Initial-Content is around for years and i would like to make bundles with it "first-class citizens" in the world of feature models and composite node stores. Without having looked into details of the current feature model toolchain a "full support" might look like this: 1. the sling-feature-analyzer should be changed to accept bundles with Sling-Initial-Content in general, but check the configured path to make sure they point only to immutable areas in the repository. 2. in the feature-cpconverter [2] could be extended to detect bundles with Sling-Initial-Content and probably convert the contained content to a content package and include it in the feature model for further processing. WDYT? stefan [1] https://github.com/apache/sling-org-apache-sling-feature-analyser/ [2] https://github.com/apache/sling-org-apache-sling-feature-cpconverter -- -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org -- -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org
[jira] [Updated] (SLING-10095) Add a tracker to log content package extractor operations
[
https://issues.apache.org/jira/browse/SLING-10095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christian Schneider updated SLING-10095:
Fix Version/s: (was: Content Distribution Journal Core 0.1.18)
Content Distribution Journal Core 0.1.20
> Add a tracker to log content package extractor operations
> --
>
> Key: SLING-10095
> URL: https://issues.apache.org/jira/browse/SLING-10095
> Project: Sling
> Issue Type: Improvement
> Components: Content Distribution
>Affects Versions: Content Distribution Journal Core 0.1.6
>Reporter: Timothee Maret
>Priority: Major
> Fix For: Content Distribution Journal Core 0.1.20
>
>
> The
> [ContentPackageExtractor|https://github.com/apache/sling-org-apache-sling-distribution-journal/blob/02846937fa0e07d183f50484bc68e028337c3fe5/src/main/java/org/apache/sling/distribution/journal/bookkeeper/ContentPackageExtractor.java]
> should report its progress in the logs. This will allow to pin point exactly
> which path is the root cause of import problems.
> FileVault allows to plug a ProgressTrackerListener for that purpose.
> We'd need to add set a progress tracker listener instance on the ImportOption
> [here|https://github.com/apache/sling-org-apache-sling-distribution-journal/blob/02846937fa0e07d183f50484bc68e028337c3fe5/src/main/java/org/apache/sling/distribution/journal/bookkeeper/ContentPackageExtractor.java#L99]
> and have that tracker log progress.
> To avoid flooding the logs, we may keep standard messages at debug level but
> keep error messages at ERROR levels.
> {code}
> ImportOptions opts = new ImportOptions();
> opts.setListener(new ProgressTrackerListener() {
> @Override
> public void onMessage(Mode mode, String s, String s1) {
> log.debug(...);
> }
> @Override
> public void onError(Mode mode, String s, Exception e) {
> log.error(...);
> }
> });
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (SLING-9649) TEST requests should be accepted
[ https://issues.apache.org/jira/browse/SLING-9649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Schneider updated SLING-9649: --- Fix Version/s: (was: Content Distribution Journal Core 0.1.20) Content Distribution Journal Core 0.1.18 > TEST requests should be accepted > > > Key: SLING-9649 > URL: https://issues.apache.org/jira/browse/SLING-9649 > Project: Sling > Issue Type: Bug > Components: Content Distribution >Affects Versions: Content Distribution Journal Core 0.1.16 >Reporter: Christian Schneider >Assignee: Christian Schneider >Priority: Major > Fix For: Content Distribution Journal Core 0.1.18 > > > Distribution agent test connect failing with message : > POST /libs/sling/distribution/services/agents/publish HTTP/1.1] > org.apache.sling.distribution.journal.impl.publisher.DistributionPublisher > [null] Request type TEST is not supported by this agent, expected one of > [ADD, DELETE, TEST]" > -- This message was sent by Atlassian Jira (v8.3.4#803005)
RE: [RT] Make bundles with Sling-Initial-Content first-class citizens in feature model tooling
hello carsten. can you give some more details about the "setups and requirements" that differ? i fear if we introduce a switch to distinguish on those things we create different "worlds" of scenarios which all have to be maintained and tested separately in the already quite complex toolchain around feature models. and why is it exactly the Sling-Initial-Content support which will be the pivot that separates one world from the other? stefan >-Original Message- >From: Carsten Ziegeler >Sent: Wednesday, February 3, 2021 6:51 AM >To: dev@sling.apache.org >Subject: Re: [RT] Make bundles with Sling-Initial-Content first-class >citizens in feature model tooling > >Hi, > >in general, I think those changes make sense. However, project setups >and requirements differ - so I think it makes sense to have an analyser >that forbids initial content in bundles. So we either make the existing >analyser configurable or have two analysers. > >I think the same applies to the cpconverter: having a switch which >either allows initial content and creates the content packages as you >suggest or fails. > >Regards >Carsten > >Am 02.02.2021 um 23:38 schrieb Stefan Seifert: >> currently, bundles with Sling-Initial-Content have not special support in >the feature model tooling and when used with composite nodestore. however, >they work just fine e.g. in AEMaaCS because during the image build phase >the contained content gets extracted and baked into the docker image. at >runtime, the Sling JCR content loader produces a warning about the locked >down /apps folder which can be ignored, because the content is already >there and does not need to be extracted again. however, it's probably >currently working only due to "lucky circumstances" in the current process >of cloud build pipeline. >> >> the sling-feature-analyzer [1] is currently looking out for bundles with >Sling-Initial-Content and produce a warning if it founds any. >> >> Sling-Initial-Content is around for years and i would like to make >bundles with it "first-class citizens" in the world of feature models and >composite node stores. Without having looked into details of the current >feature model toolchain a "full support" might look like this: >> >> 1. the sling-feature-analyzer should be changed to accept bundles with >Sling-Initial-Content in general, but check the configured path to make >sure they point only to immutable areas in the repository. >> >> 2. in the feature-cpconverter [2] could be extended to detect bundles >with Sling-Initial-Content and probably convert the contained content to a >content package and include it in the feature model for further processing. >> >> WDYT? >> >> stefan >> >> [1] https://github.com/apache/sling-org-apache-sling-feature-analyser/ >> [2] https://github.com/apache/sling-org-apache-sling-feature-cpconverter >> > >-- >-- >Carsten Ziegeler >Adobe Research Switzerland >cziege...@apache.org
[VOTE] Release Apache Sling Content Distribution Journal Messages version 0.2.0
Hi, We solved 3 issues in this release: https://issues.apache.org/jira/projects/SLING/versions/12348397 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2406/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2406 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. -- Here is my +1 -- -- Christian Schneider http://www.liquid-reality.de Computer Scientist http://www.adobe.com
[jira] [Commented] (SLING-10105) Onboard the Apache Sling Servlets Resolver API bundle to SonarCloud
[ https://issues.apache.org/jira/browse/SLING-10105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17277989#comment-17277989 ] Fabrice Bellingard commented on SLING-10105: Done [~radu]! => https://sonarcloud.io/project/configuration?id=apache_sling-org-apache-sling-servlets-resolver-api > Onboard the Apache Sling Servlets Resolver API bundle to SonarCloud > --- > > Key: SLING-10105 > URL: https://issues.apache.org/jira/browse/SLING-10105 > Project: Sling > Issue Type: Improvement > Components: Servlets >Reporter: Radu Cotescu >Assignee: Fabrice Bellingard >Priority: Major > Fix For: Servlets Resolver API 1.0.0 > > > The Apache Sling Servlets Resolver API bundle is a new Sling module that > should be onboarded to SonarCloud. See > https://github.com/apache/sling-org-apache-sling-servlets-resolver-api. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-10096) Allow the SlingHttpServletRequest in the IncludeGenerator or Sling dynamic includes
[ https://issues.apache.org/jira/browse/SLING-10096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17277988#comment-17277988 ] Robert Munteanu commented on SLING-10096: - Thanks for raising the issue and submitting the PR [~santiagozky]. I don't understand why this is relevant, since SDI does not export any packages. How is the service meant to be implemented? > Allow the SlingHttpServletRequest in the IncludeGenerator or Sling dynamic > includes > --- > > Key: SLING-10096 > URL: https://issues.apache.org/jira/browse/SLING-10096 > Project: Sling > Issue Type: Improvement >Reporter: Santiago García Pimentel >Priority: Major > > The current interface of the IncludeGenerator of Sling Dynamic Includes only > pass the String with the original URL. > It would be great to allow to pass it also the Request to allow clients to > implement more robust/complex implementations. > For example, allow to create SDI that use the information of the user making > the request -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [sling-org-apache-sling-servlets-resolver] sonarcloud[bot] commented on pull request #7: [SLING-9230] - Servlet should not be allowed to register with invalid…
sonarcloud[bot] commented on pull request #7: URL: https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/7#issuecomment-772494666 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=7&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=7&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=7&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=7&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=7&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=7&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=7&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=7&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=7&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=7&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=7&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=7&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=7&metric=new_coverage&view=list) [70.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=7&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=7&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=7&metric=new_duplicated_lines_density&view=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-servlets-resolver] sonarcloud[bot] removed a comment on pull request #7: [SLING-9230] - Servlet should not be allowed to register with invalid…
sonarcloud[bot] removed a comment on pull request #7: URL: https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/7#issuecomment-769719133 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=7&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=7&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=7&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=7&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=7&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=7&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=7&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=7&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=7&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=7&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=7&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=7&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=7&metric=new_coverage&view=list) [70.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=7&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=7&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=7&metric=new_duplicated_lines_density&view=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-servlets-post] sonarcloud[bot] removed a comment on pull request #11: SLING-10087 convert more persistenceexceptions
sonarcloud[bot] removed a comment on pull request #11: URL: https://github.com/apache/sling-org-apache-sling-servlets-post/pull/11#issuecomment-769914538 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=11&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=11&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=11&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=11&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=11&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=11&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-post&pullRequest=11&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-post&pullRequest=11&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-post&pullRequest=11&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=11&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=11&resolved=false&types=CODE_SMELL) [5 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=11&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post&pullRequest=11&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post&pullRequest=11&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post&pullRequest=11&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post&pullRequest=11&metric=new_duplicated_lines_density&view=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-servlets-post] sonarcloud[bot] commented on pull request #11: SLING-10087 convert more persistenceexceptions
sonarcloud[bot] commented on pull request #11: URL: https://github.com/apache/sling-org-apache-sling-servlets-post/pull/11#issuecomment-772491020 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=11&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=11&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=11&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=11&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=11&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=11&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-post&pullRequest=11&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-post&pullRequest=11&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-post&pullRequest=11&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=11&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=11&resolved=false&types=CODE_SMELL) [5 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=11&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post&pullRequest=11&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post&pullRequest=11&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post&pullRequest=11&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post&pullRequest=11&metric=new_duplicated_lines_density&view=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[Jenkins] Sling » Modules » sling-org-apache-sling-launchpad-testing » master #333 is BROKEN
Please see
https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-launchpad-testing/job/master/333/
for details.
No further emails will be sent until the status of the build is changed.
Build log follows below:
[...truncated 32 lines...]
[Pipeline] {
[Pipeline] stage
[Pipeline] { (Init)
[Pipeline] checkout
using credential sling-github-token
Cloning the remote Git repository
Cloning with configured refspecs honoured and without tags
Fetching without tags
Cloning repository
https://github.com/apache/sling-org-apache-sling-launchpad-testing.git
> git init
> /home/jenkins/jenkins-agent/workspace/e-sling-launchpad-testing_master #
> timeout=10
Fetching upstream changes from
https://github.com/apache/sling-org-apache-sling-launchpad-testing.git
> git --version # timeout=10
using GIT_ASKPASS to set credentials Personal access token for Github
repository access. Use with Apache Sling jobs only.
> git fetch --no-tags --progress --
> https://github.com/apache/sling-org-apache-sling-launchpad-testing.git
> +refs/heads/master:refs/remotes/origin/master # timeout=10
> git config remote.origin.url
> https://github.com/apache/sling-org-apache-sling-launchpad-testing.git #
> timeout=10
> git config --add remote.origin.fetch
> +refs/heads/master:refs/remotes/origin/master # timeout=10
> git config remote.origin.url
> https://github.com/apache/sling-org-apache-sling-launchpad-testing.git #
> timeout=10
Checking out Revision e68051d95a23f4112e2c6c81c4175a018394c10b (master)
Commit message: "mvn clean launcher folder"
Fetching upstream changes from
https://github.com/apache/sling-org-apache-sling-launchpad-testing.git
using GIT_ASKPASS to set credentials Personal access token for Github
repository access. Use with Apache Sling jobs only.
> git fetch --no-tags --progress --
> https://github.com/apache/sling-org-apache-sling-launchpad-testing.git
> +refs/heads/master:refs/remotes/origin/master # timeout=10
> git config core.sparsecheckout # timeout=10
> git checkout -f e68051d95a23f4112e2c6c81c4175a018394c10b # timeout=10
> git rev-list --no-walk e68051d95a23f4112e2c6c81c4175a018394c10b # timeout=10
[Pipeline] sh
+ git clean -fdx
[Pipeline] sh
+ git config remote.origin.url
[Pipeline] fileExists
[Pipeline] readJSON
[Pipeline] echo
Jenkins overrides: [rebuildFrequency:@daily, sonarQubeEnabled:false, jdks:[8,
11, 15], archivePatterns:[**/logs/*.log],
emailRecipients:[dev@sling.apache.org],
upstreamProjects:[../sling-org-apache-sling-starter/master]]
[Pipeline] echo
Final job config: [jdks:[8, 11, 15],
upstreamProjects:[../sling-org-apache-sling-starter/master],
archivePatterns:[**/logs/*.log], mavenGoal:, additionalMavenParams:,
rebuildFrequency:@daily, enabled:true, emailRecipients:[dev@sling.apache.org],
sonarQubeEnabled:false, sonarQubeUseAdditionalMavenParams:true,
sonarQubeAdditionalParams:, repoName:sling-org-apache-sling-launchpad-testing]
[Pipeline] }
[Pipeline] // stage
[Pipeline] stage
[Pipeline] { (Configure Job)
[Pipeline] properties
[Pipeline] }
[Pipeline] // stage
[Pipeline] readMavenPom
[Pipeline] stage
[Pipeline] { (Build (Java 8, deploy))
[Pipeline] withMaven
[withMaven] Options:
[org.jenkinsci.plugins.pipeline.maven.publishers.GeneratedArtifactsPublisher[disabled=false],
JunitTestsPublisher[disabled=false,healthScaleFactor=,keepLongStdio=false,ignoreAttachments=false],
org.jenkinsci.plugins.pipeline.maven.publishers.TasksScannerPublisher[disabled='false',
healthy='', unHealthy='', thresholdLimit='low'],
org.jenkinsci.plugins.pipeline.maven.publishers.DependenciesFingerprintPublisher[disabled=false,
scopes=[compile, provided, runtime], versions={snapshot:true, release:false}]]
[withMaven] Available options:
[withMaven] using JDK installation jdk_1.8_latest
[withMaven] using Maven installation 'maven_3_latest'
[Pipeline] {
[Pipeline] sh
+ mvn -U clean deploy -Pci
- withMaven Wrapper script -
Picked up JAVA_TOOL_OPTIONS:
-Dmaven.ext.class.path="/home/jenkins/jenkins-agent/workspace/e-sling-launchpad-testing_master@tmp/withMaven92604317/pipeline-maven-spy.jar"
-Dorg.jenkinsci.plugins.pipeline.maven.reportsFolder="/home/jenkins/jenkins-agent/workspace/e-sling-launchpad-testing_master@tmp/withMaven92604317"
Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
Maven home: /home/jenkins/tools/maven/latest3
Java version: 1.8.0_281, vendor: Oracle Corporation, runtime:
/usr/local/asfpackages/java/oraclejdk-1.8.0-281/jre
Default locale: en_US, platform encoding: ISO-8859-1
OS name: "linux", version: "4.15.0-58-generic", arch: "amd64", family: "unix"
[INFO] [jenkins-event-spy] Generate
/home/jenkins/jenkins-agent/workspace/e-sling-launchpad-testing_master@tmp/withMaven92604317/maven-spy-20210203-121323-423290490539990858530.log.tmp
...
[Jenkins] Sling » Modules » sling-org-apache-sling-launchpad-testing » master #332 is FIXED
Please see https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-launchpad-testing/job/master/332/ for details. No further emails will be sent until the status of the build is changed.
[jira] [Updated] (SLING-10123) Distribution agent queue processor should implement a backoff in case of retries for processing an item
[ https://issues.apache.org/jira/browse/SLING-10123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mohit Arora updated SLING-10123: Description: In case of recoverable exceptions, distribution agent queue processor does not evict the queue item from the processing queue [0]. Rather, the item is retried infinitely until either the distribution of the item is successful or a non-recoverable exception is thrown for the item. However, since there is "something wrong" because of which an exception is thrown in the first place, we should add a cool off period before trying to reattempt to distribute the same item. This can be achieved through a linear or exponential backoff. cc - [~ashishc] [0] https://github.com/apache/sling-org-apache-sling-distribution-core/blob/master/src/main/java/org/apache/sling/distribution/agent/impl/SimpleDistributionAgentQueueProcessor.java#L147-L150 was: In case of recoverable exceptions, distribution agent queue processor does not evict the queue item from the processing queue [0]. Rather, the item is retried infinitely until either the distribution of the item is successful or a non-recoverable exception is thrown for the item. However, since there is "something wrong" because of which an exception is thrown in the first place, we should add a cool off period before trying to reattempt to distribute the same item. This can be achieved through a linear of exponential backoff. cc - [~ashishc] [0] https://github.com/apache/sling-org-apache-sling-distribution-core/blob/master/src/main/java/org/apache/sling/distribution/agent/impl/SimpleDistributionAgentQueueProcessor.java#L147-L150 > Distribution agent queue processor should implement a backoff in case of > retries for processing an item > --- > > Key: SLING-10123 > URL: https://issues.apache.org/jira/browse/SLING-10123 > Project: Sling > Issue Type: Bug > Components: Content Distribution >Affects Versions: Content Distribution Core 0.4.2 >Reporter: Mohit Arora >Priority: Major > Fix For: Content Distribution Core 0.4.4 > > > In case of recoverable exceptions, distribution agent queue processor does > not evict the queue item from the processing queue [0]. Rather, the item is > retried infinitely until either the distribution of the item is successful or > a non-recoverable exception is thrown for the item. However, since there is > "something wrong" because of which an exception is thrown in the first place, > we should add a cool off period before trying to reattempt to distribute the > same item. This can be achieved through a linear or exponential backoff. > cc - [~ashishc] > [0] > https://github.com/apache/sling-org-apache-sling-distribution-core/blob/master/src/main/java/org/apache/sling/distribution/agent/impl/SimpleDistributionAgentQueueProcessor.java#L147-L150 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-10123) Distribution agent queue processor should implement a backoff in case of retries for processing an item
[ https://issues.apache.org/jira/browse/SLING-10123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mohit Arora updated SLING-10123: Description: In case of recoverable exceptions, distribution agent queue processor does not evict the queue item from the processing queue [0]. Rather, the item is retried infinitely until either the distribution of the item is successful or a non-recoverable exception is thrown for the item. However, since there is "something wrong" because of which an exception is thrown in the first place, we should add a cool off period before trying to reattempt to distribute the same item. This can be achieved through a linear of exponential backoff. cc - [~ashishc] [0] https://github.com/apache/sling-org-apache-sling-distribution-core/blob/master/src/main/java/org/apache/sling/distribution/agent/impl/SimpleDistributionAgentQueueProcessor.java#L147-L150 was: In case of recoverable exceptions, distribution agent queue processor does not evict the queue item from the processing queue. Rather, the item is retried infinitely until either the distribution of the item is successful or a non-recoverable exception is thrown for the item. However, since there is "something wrong" because of which an exception is thrown in the first place, we should add a cool off period before trying to reattempt to distribute the same item. This can be achieved through a linear of exponential backoff. cc - [~ashishc] > Distribution agent queue processor should implement a backoff in case of > retries for processing an item > --- > > Key: SLING-10123 > URL: https://issues.apache.org/jira/browse/SLING-10123 > Project: Sling > Issue Type: Bug > Components: Content Distribution >Affects Versions: Content Distribution Core 0.4.2 >Reporter: Mohit Arora >Priority: Major > Fix For: Content Distribution Core 0.4.4 > > > In case of recoverable exceptions, distribution agent queue processor does > not evict the queue item from the processing queue [0]. Rather, the item is > retried infinitely until either the distribution of the item is successful or > a non-recoverable exception is thrown for the item. However, since there is > "something wrong" because of which an exception is thrown in the first place, > we should add a cool off period before trying to reattempt to distribute the > same item. This can be achieved through a linear of exponential backoff. > cc - [~ashishc] > [0] > https://github.com/apache/sling-org-apache-sling-distribution-core/blob/master/src/main/java/org/apache/sling/distribution/agent/impl/SimpleDistributionAgentQueueProcessor.java#L147-L150 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-10123) Distribution agent queue processor should implement a backoff in case of retries for processing an item
Mohit Arora created SLING-10123: --- Summary: Distribution agent queue processor should implement a backoff in case of retries for processing an item Key: SLING-10123 URL: https://issues.apache.org/jira/browse/SLING-10123 Project: Sling Issue Type: Bug Components: Content Distribution Affects Versions: Content Distribution Core 0.4.2 Reporter: Mohit Arora Fix For: Content Distribution Core 0.4.4 In case of recoverable exceptions, distribution agent queue processor does not evict the queue item from the processing queue. Rather, the item is retried infinitely until either the distribution of the item is successful or a non-recoverable exception is thrown for the item. However, since there is "something wrong" because of which an exception is thrown in the first place, we should add a cool off period before trying to reattempt to distribute the same item. This can be achieved through a linear of exponential backoff. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-10123) Distribution agent queue processor should implement a backoff in case of retries for processing an item
[ https://issues.apache.org/jira/browse/SLING-10123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mohit Arora updated SLING-10123: Description: In case of recoverable exceptions, distribution agent queue processor does not evict the queue item from the processing queue. Rather, the item is retried infinitely until either the distribution of the item is successful or a non-recoverable exception is thrown for the item. However, since there is "something wrong" because of which an exception is thrown in the first place, we should add a cool off period before trying to reattempt to distribute the same item. This can be achieved through a linear of exponential backoff. cc - [~ashishc] was:In case of recoverable exceptions, distribution agent queue processor does not evict the queue item from the processing queue. Rather, the item is retried infinitely until either the distribution of the item is successful or a non-recoverable exception is thrown for the item. However, since there is "something wrong" because of which an exception is thrown in the first place, we should add a cool off period before trying to reattempt to distribute the same item. This can be achieved through a linear of exponential backoff. > Distribution agent queue processor should implement a backoff in case of > retries for processing an item > --- > > Key: SLING-10123 > URL: https://issues.apache.org/jira/browse/SLING-10123 > Project: Sling > Issue Type: Bug > Components: Content Distribution >Affects Versions: Content Distribution Core 0.4.2 >Reporter: Mohit Arora >Priority: Major > Fix For: Content Distribution Core 0.4.4 > > > In case of recoverable exceptions, distribution agent queue processor does > not evict the queue item from the processing queue. Rather, the item is > retried infinitely until either the distribution of the item is successful or > a non-recoverable exception is thrown for the item. However, since there is > "something wrong" because of which an exception is thrown in the first place, > we should add a cool off period before trying to reattempt to distribute the > same item. This can be achieved through a linear of exponential backoff. > cc - [~ashishc] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-9504) Switch from protobuf to json
[ https://issues.apache.org/jira/browse/SLING-9504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Schneider resolved SLING-9504. Resolution: Fixed > Switch from protobuf to json > > > Key: SLING-9504 > URL: https://issues.apache.org/jira/browse/SLING-9504 > Project: Sling > Issue Type: Improvement > Components: Content Distribution >Affects Versions: Content Distribution Journal Messages 0.1.2 >Reporter: Christian Schneider >Assignee: Christian Schneider >Priority: Major > Fix For: Content Distribution Journal Messages 0.1.10 > > > Protobuf has the problem that it is difficult to diagnose. We would like to > switch all messages to json payload. > This is an incompatible change. So data of running instances will have to be > migrated to the new format or old messages will be lost. > A good way for migration is to wait until the queues are empty. This way only > history in kafka is lost but there is no risk of inconsistencies. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[VOTE][CANCEL] Release Apache Sling Event Support 4.2.14
Cancelling the vote due to the issues found, follow-up SLING-10120 Cheers, Stefan On 02.02.21 09:53, Stefan Egli wrote: Hi, We solved 2 issues in this release: https://issues.apache.org/jira/projects/SLING/versions/12344827 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2404/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2404 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Cheers, Stefan
[jira] [Assigned] (SLING-10120) Upgrade event to parent 40
[ https://issues.apache.org/jira/browse/SLING-10120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli reassigned SLING-10120: --- Assignee: Stefan Egli > Upgrade event to parent 40 > -- > > Key: SLING-10120 > URL: https://issues.apache.org/jira/browse/SLING-10120 > Project: Sling > Issue Type: Sub-task > Components: Event >Reporter: Robert Munteanu >Assignee: Stefan Egli >Priority: Major > Fix For: Event 4.2.16 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
Re: [VOTE] Release Apache Sling Event Support 4.2.14
Thx for the findings, I'll revert the vote and look into SLING-10120 Cheers, Stefan On 03.02.21 11:29, Robert Munteanu wrote: All of these are due to using an old parent pom. The improvement to move to a recent parent pom is tracked at https://issues.apache.org/jira/browse/SLING-10120 Thanks, Robert On Tue, 2021-02-02 at 19:23 -0500, Daniel Klco wrote: I'm also seeing a failure on the latest build: https://ci-builds.apache.org/blue/organizations/jenkins/Sling%2Fmodules%2Fsling-org-apache-sling-event/detail/master/31/pipeline/33 and it appears that the project hasn't updated SonarCloud since Nov 25, 2020: https://sonarcloud.io/project/activity?id=apache_sling-org-apache-sling-event On Tue, Feb 2, 2021 at 5:02 PM Stefan Seifert wrote: the test dependency org.mockito:mockito-all is defined twice (with different versions). and using "mockito-all" is discouraged, "mockito-core" should be used instead. if try to build the project on a windows 10 machine (java 11.0.9) i get a NPE in the unit tests (details see below). the sling parent 33 is quite outdated, probably the error is fixed with the latest parent & surefire plugin version. stefan [INFO] --- maven-surefire-plugin:2.20.1:test (default-test) @ org.apache.sling.event --- [INFO] Surefire report directory: D:\Develop\OpenSource\sling-git\sling-org-apache-sling- event\target\surefire-reports [INFO] --- - [INFO] BUILD FAILURE [INFO] --- - [INFO] Total time: 9.441 s [INFO] Finished at: 2021-02-02T22:59:43+01:00 [INFO] --- - [ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.20.1:test (default-test) on project org.apache.sling.event: Execution default-test of goal org.apache.maven.plugins:maven-surefire-plugin:2.20.1:test failed.: NullPointerException -> [Help 1] org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.20.1:test (default-test) on project org.apache.sling.event: Execution default-test of goal org.apache.maven.plugins:maven-surefire-plugin:2.20.1:test failed. at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:215) at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:156) at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:148) at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildPro ject (LifecycleModuleBuilder.java:117) at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildPro ject (LifecycleModuleBuilder.java:81) at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleTh readedBuilder.build (SingleThreadedBuilder.java:56) at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:128) at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305) at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192) at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105) at org.apache.maven.cli.MavenCli.execute (MavenCli.java:957) at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:289) at org.apache.maven.cli.MavenCli.main (MavenCli.java:193) at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method) at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62) at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke (Method.java:566) at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:282) at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:225) at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:406) at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347) Caused by: org.apache.maven.plugin.PluginExecutionException: Execution default-test of goal org.apache.maven.plugins:maven-surefire-plugin:2.20.1:test failed. at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:148) at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:210) at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:156) at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:148) at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildPro ject (LifecycleModuleBuilder.java:117) at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildPro ject (LifecycleModuleBuilder.java:81) at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleTh readedBuilder.build (SingleThreadedBuilder.java:56) at org.
Re: [VOTE] Release Apache Sling Event Support 4.2.14
All of these are due to using an old parent pom. The improvement to move to a recent parent pom is tracked at https://issues.apache.org/jira/browse/SLING-10120 Thanks, Robert On Tue, 2021-02-02 at 19:23 -0500, Daniel Klco wrote: > I'm also seeing a failure on the latest build: > https://ci-builds.apache.org/blue/organizations/jenkins/Sling%2Fmodules%2Fsling-org-apache-sling-event/detail/master/31/pipeline/33 > and it appears that the project hasn't updated SonarCloud since Nov > 25, > 2020: > https://sonarcloud.io/project/activity?id=apache_sling-org-apache-sling-event > > On Tue, Feb 2, 2021 at 5:02 PM Stefan Seifert > wrote: > > > the test dependency org.mockito:mockito-all is defined twice (with > > different versions). > > and using "mockito-all" is discouraged, "mockito-core" should be > > used > > instead. > > > > if try to build the project on a windows 10 machine (java 11.0.9) i > > get a > > NPE in the unit tests (details see below). > > > > the sling parent 33 is quite outdated, probably the error is fixed > > with > > the latest parent & surefire plugin version. > > > > stefan > > > > > > [INFO] --- maven-surefire-plugin:2.20.1:test (default-test) @ > > org.apache.sling.event --- > > [INFO] Surefire report directory: > > D:\Develop\OpenSource\sling-git\sling-org-apache-sling- > > event\target\surefire-reports > > [INFO] > > --- > > - > > [INFO] BUILD FAILURE > > [INFO] > > --- > > - > > [INFO] Total time: 9.441 s > > [INFO] Finished at: 2021-02-02T22:59:43+01:00 > > [INFO] > > --- > > - > > [ERROR] Failed to execute goal > > org.apache.maven.plugins:maven-surefire-plugin:2.20.1:test > > (default-test) > > on project org.apache.sling.event: Execution default-test of goal > > org.apache.maven.plugins:maven-surefire-plugin:2.20.1:test failed.: > > NullPointerException -> [Help 1] > > org.apache.maven.lifecycle.LifecycleExecutionException: Failed to > > execute > > goal org.apache.maven.plugins:maven-surefire-plugin:2.20.1:test > > (default-test) on project org.apache.sling.event: Execution > > default-test of > > goal org.apache.maven.plugins:maven-surefire-plugin:2.20.1:test > > failed. > > at org.apache.maven.lifecycle.internal.MojoExecutor.execute > > (MojoExecutor.java:215) > > at org.apache.maven.lifecycle.internal.MojoExecutor.execute > > (MojoExecutor.java:156) > > at org.apache.maven.lifecycle.internal.MojoExecutor.execute > > (MojoExecutor.java:148) > > at > > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildPro > > ject > > (LifecycleModuleBuilder.java:117) > > at > > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildPro > > ject > > (LifecycleModuleBuilder.java:81) > > at > > org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleTh > > readedBuilder.build > > (SingleThreadedBuilder.java:56) > > at org.apache.maven.lifecycle.internal.LifecycleStarter.execute > > (LifecycleStarter.java:128) > > at org.apache.maven.DefaultMaven.doExecute > > (DefaultMaven.java:305) > > at org.apache.maven.DefaultMaven.doExecute > > (DefaultMaven.java:192) > > at org.apache.maven.DefaultMaven.execute > > (DefaultMaven.java:105) > > at org.apache.maven.cli.MavenCli.execute (MavenCli.java:957) > > at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:289) > > at org.apache.maven.cli.MavenCli.main (MavenCli.java:193) > > at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 > > (Native > > Method) > > at jdk.internal.reflect.NativeMethodAccessorImpl.invoke > > (NativeMethodAccessorImpl.java:62) > > at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke > > (DelegatingMethodAccessorImpl.java:43) > > at java.lang.reflect.Method.invoke (Method.java:566) > > at > > org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced > > (Launcher.java:282) > > at org.codehaus.plexus.classworlds.launcher.Launcher.launch > > (Launcher.java:225) > > at > > org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode > > (Launcher.java:406) > > at org.codehaus.plexus.classworlds.launcher.Launcher.main > > (Launcher.java:347) > > Caused by: org.apache.maven.plugin.PluginExecutionException: > > Execution > > default-test of goal > > org.apache.maven.plugins:maven-surefire-plugin:2.20.1:test failed. > > at > > org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo > > (DefaultBuildPluginManager.java:148) > > at org.apache.maven.lifecycle.internal.MojoExecutor.execute > > (MojoExecutor.java:210) > > at org.apache.maven.lifecycle.internal.MojoExecutor.execute > > (MojoExecutor.java:156) > > at org.apache.maven.lifecycle.internal.MojoExecutor.execute > > (MojoExecutor.java:148) > > at > > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.build
[jira] [Updated] (SLING-8595) Update of sling parent pom
[ https://issues.apache.org/jira/browse/SLING-8595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-8595: --- Parent: SLING-8734 Issue Type: Sub-task (was: Improvement) > Update of sling parent pom > -- > > Key: SLING-8595 > URL: https://issues.apache.org/jira/browse/SLING-8595 > Project: Sling > Issue Type: Sub-task > Components: Content Distribution >Reporter: Christian Schneider >Assignee: Christian Schneider >Priority: Major > Fix For: Content Distribution Core 0.4.8 > > Time Spent: 1h > Remaining Estimate: 0h > > When running upstream modules together with sling distribution core in > eclipse I got issues as the outdated osgi core jar slipped into the build > dependencies of the upstream module. > I found that updating the parent pom fixed the issue. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-8595) Update of sling parent pom
[ https://issues.apache.org/jira/browse/SLING-8595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Schneider updated SLING-8595: --- Fix Version/s: (was: Content Distribution Core 0.4.6) Content Distribution Core 0.4.8 > Update of sling parent pom > -- > > Key: SLING-8595 > URL: https://issues.apache.org/jira/browse/SLING-8595 > Project: Sling > Issue Type: Improvement > Components: Content Distribution >Reporter: Christian Schneider >Assignee: Christian Schneider >Priority: Major > Fix For: Content Distribution Core 0.4.8 > > Time Spent: 1h > Remaining Estimate: 0h > > When running upstream modules together with sling distribution core in > eclipse I got issues as the outdated osgi core jar slipped into the build > dependencies of the upstream module. > I found that updating the parent pom fixed the issue. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-8994) Optimize session saves for Single Queue Dispatching Strategy
[
https://issues.apache.org/jira/browse/SLING-8994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christian Schneider updated SLING-8994:
---
Fix Version/s: (was: Content Distribution Core 0.4.6)
Content Distribution Core 0.4.8
> Optimize session saves for Single Queue Dispatching Strategy
>
>
> Key: SLING-8994
> URL: https://issues.apache.org/jira/browse/SLING-8994
> Project: Sling
> Issue Type: Bug
> Components: Content Distribution
>Reporter: Ashish Chopra
>Assignee: Timothee Maret
>Priority: Major
> Fix For: Content Distribution Core 0.4.8
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Separation of concerns dictate that there's a loose coupling between
> Distribution Packages and Queue entries, and thus the distribution-packages
> and queue-items are persisted in different sessions (indeed, depending on
> queue-impl/distribution-packaging-impl chosen there may not be a need to
> persist either, or any of them at all).
> To enable collection of unreferenced Distribution packages, currently, queue
> items are be acquired [0] and released [1] on a per-queue basis in
> {{MultipleQueueDispatchingStrategy}}. Only the distribution-packages that
> don't have any live references are claimed.
> For a 1:1 distribution (as {{SingleQueueDispatchingStrategy}} [2] aims to
> achieve), acquring and releasing packages is superfluous (since there's only
> one queue) and as such it should just be sufficient to mark the package
> 'released' [3] once the queue is done with it.
> However, the ref-updates still happen given way it is implemented currently
> (as a subclass of {{MultipleQueueDispatchingStrategy}} that doesn't override
> anything [2]).
> Opening this issue propose improving {{SingleQueueDispatchingStrategy}} impl.
> This should slightly optimize the book-keeping and marginally reduce the
> write-overhead for 1:1 distribution.
> [0]
> https://github.com/apache/sling-org-apache-sling-distribution-core/blob/537bb57af821f21537cf4a24ad7d2347c6a5dae1/src/main/java/org/apache/sling/distribution/queue/impl/MultipleQueueDispatchingStrategy.java#L61
> [1]
> https://github.com/apache/sling-org-apache-sling-distribution-core/blob/537bb57af821f21537cf4a24ad7d2347c6a5dae1/src/main/java/org/apache/sling/distribution/agent/impl/SimpleDistributionAgentQueueProcessor.java#L169
> [2]
> https://github.com/apache/sling-org-apache-sling-distribution-core/blob/537bb57af821f21537cf4a24ad7d2347c6a5dae1/src/main/java/org/apache/sling/distribution/queue/impl/SingleQueueDispatchingStrategy.java
> [3]
> https://github.com/apache/sling-org-apache-sling-distribution-core/blob/537bb57af821f21537cf4a24ad7d2347c6a5dae1/src/main/java/org/apache/sling/distribution/packaging/impl/DistributionPackageUtils.java#L107-L111
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (SLING-9017) ErrorQueueDispatchingStrategy ends up using an incorrect QueueProvider
[
https://issues.apache.org/jira/browse/SLING-9017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christian Schneider updated SLING-9017:
---
Fix Version/s: (was: Content Distribution Core 0.4.6)
Content Distribution Core 0.4.8
> ErrorQueueDispatchingStrategy ends up using an incorrect QueueProvider
> --
>
> Key: SLING-9017
> URL: https://issues.apache.org/jira/browse/SLING-9017
> Project: Sling
> Issue Type: Bug
> Components: Content Distribution
>Reporter: Ashish Chopra
>Assignee: Timothee Maret
>Priority: Major
> Fix For: Content Distribution Core 0.4.8
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Currently, {{ErrorQueueDispatchingStrategy}} [0] interface dictates that the
> {{.add}} [1] method supplies the {{DistributionQueueProvider}} [1] to it.
> For {{ForwardDistributionAgentFactory}} (and perhaps other Agent-factories as
> well), this {{DistributionQueueProvider}} is further used to {{.getQueue}} by
> a name [2].
> As the discussion in SLING-8854 concluded, it was found acceptable [3] for
> {{DistributionQueue}} impls and {{DistributionQueueProvider}} impls to share
> state - concordantly, there needs to be a way for Agent-Factories to dictate
> which _specific_ queue-providers they want {{ErrorQueueDispatchingStrategy}}
> to use.
> One approach to make that happen would be to enhance
> {{ErrorQueueDispatchingStrategy}} with another CTOR to accept a
> {{DistributionQueueProvider}} argument. The impl of {{.add}} can then treat
> the supplied {{DistributionQueueProvider}} at the time of API invocation as a
> 'hint' and ignore it if the {{ErrorQueueDispatchingStrategy}} already has one
> of its own.
> [0]
> https://github.com/apache/sling-org-apache-sling-distribution-core/blob/master/src/main/java/org/apache/sling/distribution/queue/impl/ErrorQueueDispatchingStrategy.java
> [1]
> https://github.com/apache/sling-org-apache-sling-distribution-core/blob/537bb57af821f21537cf4a24ad7d2347c6a5dae1/src/main/java/org/apache/sling/distribution/queue/impl/ErrorQueueDispatchingStrategy.java#L56
> [2]
> https://github.com/apache/sling-org-apache-sling-distribution-core/blob/537bb57af821f21537cf4a24ad7d2347c6a5dae1/src/main/java/org/apache/sling/distribution/agent/impl/SimpleDistributionAgentQueueProcessor.java#L187
> [3]
> https://issues.apache.org/jira/browse/SLING-8854?focusedCommentId=16982396&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16982396
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (SLING-10097) Add a tracker to log FileVault content serializer operations
[
https://issues.apache.org/jira/browse/SLING-10097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christian Schneider updated SLING-10097:
Fix Version/s: (was: Content Distribution Core 0.4.6)
Content Distribution Core 0.4.8
> Add a tracker to log FileVault content serializer operations
> -
>
> Key: SLING-10097
> URL: https://issues.apache.org/jira/browse/SLING-10097
> Project: Sling
> Issue Type: Improvement
> Components: Content Distribution
>Reporter: Timothee Maret
>Priority: Major
> Fix For: Content Distribution Core 0.4.8
>
>
> The
> [FileVaultContentSerializer|https://github.com/apache/sling-org-apache-sling-distribution-core/blob/b80cd8f3bae6b7875387ee7caaea271b7e9baec6/src/main/java/org/apache/sling/distribution/serialization/impl/vlt/FileVaultContentSerializer.java]
> should report its progress in the logs. This will allow to pin point exactly
> which path is the root cause of import problems.
> FileVault allows to plug a ProgressTrackerListener for that purpose.
> We'd need to add set a progress tracker listener instance on the ImportOption
> [here|https://github.com/apache/sling-org-apache-sling-distribution-core/blob/b80cd8f3bae6b7875387ee7caaea271b7e9baec6/src/main/java/org/apache/sling/distribution/serialization/impl/vlt/FileVaultContentSerializer.java#L135]
> and have that tracker log progress.
> To avoid flooding the logs, we may keep standard messages at debug level but
> keep error messages at ERROR levels.
> {code}
> ImportOptions opts = new ImportOptions();
> opts.setListener(new ProgressTrackerListener() {
> @Override
> public void onMessage(Mode mode, String s, String s1) {
> log.debug(...);
> }
> @Override
> public void onError(Mode mode, String s, Exception e) {
> log.error(...);
> }
> });
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
Re: How to create an admin user
Hi, On Tue, Feb 2, 2021 at 9:56 PM Lisa Davidson wrote: > ...I have a need to update an existing user to be admin... In general I think the recommendation is to create a group that has the necessary access rights, with that user as a member. Using the JCR admin user more than strictly needed is not recommended. -Bertrand
[jira] [Resolved] (SLING-10088) PatternSyntaxException: Unclosed group near index x
[
https://issues.apache.org/jira/browse/SLING-10088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christian Schneider resolved SLING-10088.
-
Fix Version/s: (was: Content Distribution Core 0.4.4)
Content Distribution Core 0.4.6
Resolution: Fixed
> PatternSyntaxException: Unclosed group near index x
> ---
>
> Key: SLING-10088
> URL: https://issues.apache.org/jira/browse/SLING-10088
> Project: Sling
> Issue Type: Bug
> Components: Content Distribution
>Affects Versions: Content Distribution Core 0.4.2
>Reporter: Christian Schneider
>Assignee: Christian Schneider
>Priority: Critical
> Fix For: Content Distribution Core 0.4.6
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> if a path contains a "(" the following exception will occur when we try to
> distribute it.
> As far as I can tell the problem is a missing escaping of the path in
> org.apache.sling.distribution.serialization.impl.vlt.VltUtils.createFilter.
> {code:java}
> [org.apache.sling.distribution.core:0.4.3.T20200720-c96d3fb] at
> org.apache.sling.distribution.journal.impl.publisher.PackageMessageFactory.createAdd(PackageMessageFactory.java:95)
> [org.apache.sling.distribution.journal:0.2.0.T202009251421-0284693]
> at
> org.apache.sling.distribution.journal.impl.publisher.PackageMessageFactory.create(PackageMessageFactory.java:86)
> [org.apache.sling.distribution.journal:0.2.0.T202009251421-0284693]
> at
> org.apache.sling.distribution.journal.impl.publisher.DistributionPublisher.lambda$execute$1(DistributionPublisher.java:271)
> [org.apache.sling.distribution.journal:0.2.0.T202009251421-0284693]
> at
> org.apache.sling.distribution.journal.shared.DistributionMetricsService.timed(DistributionMetricsService.java:147)
> [org.apache.sling.distribution.journal:0.2.0.T202009251421-0284693]
> at
> org.apache.sling.distribution.journal.impl.publisher.DistributionPublisher.execute(DistributionPublisher.java:270)
> [org.apache.sling.distribution.journal:0.2.0.T202009251421-0284693]
> at
> org.apache.sling.distribution.journal.impl.publisher.DistributionPublisher.execute(DistributionPublisher.java:259)
> [org.apache.sling.distribution.journal:0.2.0.T202009251421-0284693]
> at
> org.apache.sling.distribution.impl.DefaultDistributor.distribute(DefaultDistributor.java:60)
> [org.apache.sling.distribution.core:0.4.3.T20200720-c96d3fb] at
> org.apache.sling.distribution.chunked.ChunkedDistribution.distributeChunk(ChunkedDistribution.java:124)
> [org.apache.sling.distribution.chunked:0.1.0.20210121164255060] at
> org.apache.sling.distribution.chunked.ChunkedDistribution.distribute(ChunkedDistribution.java:102)
> [org.apache.sling.distribution.chunked:0.1.0.20210121164255060] at
> org.apache.sling.distribution.chunked.ChunkedDistribution.process(ChunkedDistribution.java:72)
> [org.apache.sling.distribution.chunked:0.1.0.20210121164255060] at
> org.apache.sling.event.impl.jobs.queues.JobQueueImpl.startJob(JobQueueImpl.java:293)
> [org.apache.sling.event:4.2.12] at
> org.apache.sling.event.impl.jobs.queues.JobQueueImpl.access$100(JobQueueImpl.java:60)
> [org.apache.sling.event:4.2.12] at
> org.apache.sling.event.impl.jobs.queues.JobQueueImpl$1.run(JobQueueImpl.java:229)
> [org.apache.sling.event:4.2.12] at
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
> at java.base/java.lang.Thread.run(Thread.java:834)Caused by:
> java.util.regex.PatternSyntaxException: Unclosed group near index
> 20/nodewith(shouldwork at
> java.base/java.util.regex.Pattern.error(Pattern.java:2027) at
> java.base/java.util.regex.Pattern.accept(Pattern.java:1877) at
> java.base/java.util.regex.Pattern.group0(Pattern.java:3060) at
> java.base/java.util.regex.Pattern.sequence(Pattern.java:2123) at
> java.base/java.util.regex.Pattern.expr(Pattern.java:2068) at
> java.base/java.util.regex.Pattern.compile(Pattern.java:1782) at
> java.base/java.util.regex.Pattern.(Pattern.java:1428) at
> java.base/java.util.regex.Pattern.compile(Pattern.java:1068) at
> org.apache.jackrabbit.vault.fs.filter.DefaultPathFilter.setPattern(DefaultPathFilter.java:68)
> [org.apache.jackrabbit.vault:3.4.0] at
> org.apache.jackrabbit.vault.fs.filter.DefaultPathFilter.(DefaultPathFilter.java:48)
> [org.apache.jackrabbit.vault:3.4.0] at
> org.apache.sling.distribution.serialization.impl.vlt.VltUtils.createFilter(VltUtils.java:92)
> [org.apache.sling.distribution.core:0.4.3.T2020072
