Re: [VOTE] Release Apache Sling Parent and Bundle Parent version 60
On Tue, 2024-01-30 at 14:27 +0100, Konrad Windszus wrote: > Please vote to approve this release: +1 Robert signature.asc Description: This is a digitally signed message part
[PR] CQ-4355073 - Anonymous testing client throws NPE [sling-org-apache-sling-testing-clients]
etugarev opened a new pull request, #47: URL: https://github.com/apache/sling-org-apache-sling-testing-clients/pull/47 When using the AEM testing Clients: anonymous client to access content on a publish instance ( AEMCS) the client throws an NPE to reproduce: ``` anonymousPublish = cqBaseClassRule.publishRule.getClient(CQClient.class, null, null); anonymousPublish.doGet("/graphql/execute.json", 204); ``` What is in this PR: - NPE fix - Added Unit test - Removed usage of deprecated methods - Fixed few warnings -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CQ-4355073 - Anonymous testing client throws NPE [sling-org-apache-sling-testing-clients]
sonarcloud[bot] commented on PR #47: URL: https://github.com/apache/sling-org-apache-sling-testing-clients/pull/47#issuecomment-1921449455 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-testing-clients&pullRequest=47) **Quality Gate failed** Failed conditions [41.2% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-clients&pullRequest=47&metric=new_coverage&view=list) (required ≥ 80%) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-testing-clients&pullRequest=47) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Anonymous testing client throws NPE [sling-org-apache-sling-testing-clients]
etugarev closed pull request #47: Anonymous testing client throws NPE URL: https://github.com/apache/sling-org-apache-sling-testing-clients/pull/47 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12205: ResourceResolver: switch sling:alias query to JCR-SQL2 [sling-org-apache-sling-resourceresolver]
enapps-enorman commented on PR #109: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/109#issuecomment-1922007973 > it's not specific to _this_ PR @reschke I'm not sure that is true. You specifically changed the code to use a new query language. For me, using the best practices for that new query language is the appropriate thing to do. If you do it correctly the the first time then you don't have to waste time re-doing it later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [VOTE] Release Apache Resource Resolver 1.11.6
Julian, FWIW: disagreeing is not the same thing as "ignoring". Well, you did more than just disagree. There was no followup to any of the 3 replies to explain your position. I'm not a mind reader. On Mon, Jan 22, 2024 at 1:15 AM Julian Reschke wrote: > On 20.01.2024 02:09, Eric Norman wrote: > > +0 for me. > > > > Though, I am still a little annoyed that you just ignored my review > > comments from > > > https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/109#pullrequestreview-1791514750 > > Eric, > > FWIW: disagreeing is not the same thing as "ignoring". This change was > urgent because it addresses a customer-visible defect (aliases broken > when more than >100K). What you raised is a stylistic issue which is not > specific to this PR, so it really ought to be addressed/discussed as > separate issue. > > Best regards, Julian >
Re: [VOTE] Release Apache Sling Commons Log 5.5.0
+1 On Mon, Jan 29, 2024 at 4:38 AM Robert Munteanu wrote: > Hi, > > We solved 2 issues in this release: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710&version=12354154&styleName=Text > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2835/ > > You can use this UNIX script to download the release and verify the > signatures: > > https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh > > Usage: > sh check_staged_release.sh 2835 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards, > Robert Munteanu >
[PR] chore(deps): update dependency org.apache.sling:org.apache.sling.servlets.resolver to v2.11.0 [sling-org-apache-sling-starter]
renovate-bot opened a new pull request, #303: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/303 [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.apache.sling:org.apache.sling.servlets.resolver](https://sling.apache.org) ([source](https://togithub.com/apache/sling-org-apache-sling-servlets-resolver)) | `2.10.0` -> `2.11.0` | [![age](https://developer.mend.io/api/mc/badges/age/maven/org.apache.sling:org.apache.sling.servlets.resolver/2.11.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/org.apache.sling:org.apache.sling.servlets.resolver/2.11.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/org.apache.sling:org.apache.sling.servlets.resolver/2.10.0/2.11.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/org.apache.sling:org.apache.sling.servlets.resolver/2.10.0/2.11.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/apache/sling-org-apache-sling-starter). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] chore(deps): update dependency org.apache.felix:org.apache.felix.http.jetty to v5.1.8 [sling-org-apache-sling-starter]
renovate-bot opened a new pull request, #302: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/302 [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.apache.felix:org.apache.felix.http.jetty](https://felix.apache.org/) ([source](https://gitbox.apache.org/repos/asf?p=felix-dev.git)) | `5.1.6` -> `5.1.8` | [![age](https://developer.mend.io/api/mc/badges/age/maven/org.apache.felix:org.apache.felix.http.jetty/5.1.8?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/org.apache.felix:org.apache.felix.http.jetty/5.1.8?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/org.apache.felix:org.apache.felix.http.jetty/5.1.6/5.1.8?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/org.apache.felix:org.apache.felix.http.jetty/5.1.6/5.1.8?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/apache/sling-org-apache-sling-starter). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org