[jira] [Closed] (SLING-12255) Fix formatting
[ https://issues.apache.org/jira/browse/SLING-12255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh closed SLING-12255. - > Fix formatting > --- > > Key: SLING-12255 > URL: https://issues.apache.org/jira/browse/SLING-12255 > Project: Sling > Issue Type: Task >Affects Versions: Servlets Resolver 2.9.14 >Reporter: Joerg Hoh >Assignee: Joerg Hoh >Priority: Trivial > Fix For: Servlets Resolver 2.11.2 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-12257) update spotbugs to support java21
[ https://issues.apache.org/jira/browse/SLING-12257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh closed SLING-12257. - > update spotbugs to support java21 > - > > Key: SLING-12257 > URL: https://issues.apache.org/jira/browse/SLING-12257 > Project: Sling > Issue Type: Task > Components: Servlets >Affects Versions: Servlets Resolver 2.9.14 >Reporter: Joerg Hoh >Assignee: Joerg Hoh >Priority: Major > Fix For: Servlets Resolver 2.11.2 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-12253) ConcurrentModificationException in AbstractResourceCollector
[
https://issues.apache.org/jira/browse/SLING-12253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joerg Hoh closed SLING-12253.
-
> ConcurrentModificationException in AbstractResourceCollector
>
>
> Key: SLING-12253
> URL: https://issues.apache.org/jira/browse/SLING-12253
> Project: Sling
> Issue Type: Task
>Affects Versions: Servlets Resolver 2.9.14, Servlets Resolver 2.10.0,
> Servlets Resolver 2.11.0
>Reporter: Joerg Hoh
>Assignee: Joerg Hoh
>Priority: Major
> Fix For: Servlets Resolver 2.11.2
>
>
> {noformat}
> [[::1] [1705550745690] GET /content/foobar.html HTTP/1.1]
> org.apache.sling.engine.impl.SlingRequestProcessorImpl service: Uncaught
> Throwable
> java.util.ConcurrentModificationException: null
> at
> java.base/java.util.ArrayList$Itr.checkForComodification(ArrayList.java:1043)
> at java.base/java.util.ArrayList$Itr.next(ArrayList.java:997)
> at
> org.apache.sling.servlets.resolver.internal.helper.ResourceCollector.getWeightedResources(ResourceCollector.java:232)
> [org.apache.sling.servlets.resolver:2.9.14]
> at
> org.apache.sling.servlets.resolver.internal.helper.AbstractResourceCollector.lambda$getServlets$1(AbstractResourceCollector.java:117)
> [org.apache.sling.servlets.resolver:2.9.14]
> at java.base/java.util.ArrayList.forEach(ArrayList.java:1541)
> at
> org.apache.sling.servlets.resolver.internal.helper.AbstractResourceCollector.getServlets(AbstractResourceCollector.java:117)
> [org.apache.sling.servlets.resolver:2.9.14]
> at
> org.apache.sling.servlets.resolver.internal.SlingServletResolver.getServletInternal(SlingServletResolver.java:528)
> [org.apache.sling.servlets.resolver:2.9.14]
> at
> org.apache.sling.servlets.resolver.internal.SlingServletResolver.resolveServletInternal(SlingServletResolver.java:489)
> [org.apache.sling.servlets.resolver:2.9.14]
> ...
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (SLING-12256) update test dependencies
[ https://issues.apache.org/jira/browse/SLING-12256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh closed SLING-12256. - > update test dependencies > > > Key: SLING-12256 > URL: https://issues.apache.org/jira/browse/SLING-12256 > Project: Sling > Issue Type: Task > Components: Servlets >Affects Versions: Servlets Resolver 2.11.0 >Reporter: Joerg Hoh >Assignee: Joerg Hoh >Priority: Major > Fix For: Servlets Resolver 2.11.2 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [git] New git repository for retired module - sling-org-apache-sling-commons-json
On Wed, 2024-02-28 at 11:22 +0100, Carsten Ziegeler wrote: > Can we do this without creating a new git repo? Creating a separate > new > repo gives a different message than what we intend it to be. > > It would be great if we could do this directly in SVN :) I think that would be pretty complex; the SVN repo is read-only and we haven't done a release from SVN for years - not sure if the plug-in / SVN versions we used back then still work with the current Maven versions. I also am not very concerned about people misintepreting Sling git repo number 347 :-) But if we want to be extra careful, we could create it a and immediately deprecate it [1]. Any potential contributions would land in the 'maintenance' branch and any potential releases would be created from the same place. Robert [1]: https://sling.apache.org/documentation/development/deprecating-sling-modules.html > > Regards > Carsten > > On 28.02.2024 10:52, Robert Munteanu wrote: > > Hi Jörg > > > > On Tue, 2024-02-27 at 11:06 +0100, Jörg Hoh wrote: > > > Hi Robert, > > > > > > makes sense. > > > > > > To clarify: We just provide this final version of commons.json as > > > a > > > convenience for all users who are still depending on > > > commons.json; > > > but > > > there is no intention to continue development of commons.json or > > > to > > > re-introducing this dependency again into other areas of Sling. > > > > > > There is no intention to use this again in any other modules, add > > it to > > the Starter, etc. We will keep the code deprecated. At the same > > time, > > we may choose to apply fixes for the reported CVEs, if those are > > already available upstream, and cut a new release. > > > > Thanks, > > Robert > > > > > > > > Correct? > > > > > > Jörg > > > > > > > > > Am Mo., 26. Feb. 2024 um 16:30 Uhr schrieb Robert Munteanu < > > > romb...@apache.org>: > > > > > > > Hi, > > > > > > > > A long time ago we retired the commons.json module for legal > > > > reasons > > > > [1], leaving it only in the SVN attic [2]. > > > > > > > > After some time a CVE was reported against this module [3] > > > > which we > > > > could not fix as we could not release new versions. > > > > > > > > In the meantime, the JSON library we have been using has > > > > changed > > > > its > > > > license to 'Public domain', which makes it acceptable for use > > > > at > > > > the > > > > ASF. [4] > > > > > > > > I would like to create a GitHub repository for this module and > > > > include > > > > the current state from the attic. This opens up the way for > > > > creating a > > > > final service release, allowing consumers of this bundle that > > > > have > > > > not > > > > cleaned up their usages to use non-vulnerable versions. > > > > > > > > I will leave this thread open for comments for 72 hours. > > > > > > > > Thanks, > > > > Robert > > > > > > > > > > > > [1]: > > > > https://lists.apache.org/thread/p9rmd9dvgk04h36dtm6vn0bj6dkx0hkk > > > > [2]: https://svn.apache.org/repos/asf/sling/attic/commons.json/ > > > > [3]: https://www.cve.org/CVERecord?id=CVE-2022-47937 > > > > [4]: https://issues.apache.org/jira/browse/LEGAL-666 > > > > > > > > > > > > >
Re: [PR] Update dependency org.apache.sling:org.apache.sling.graphql.core to v0.0.30 [sling-site]
rombert merged PR #155: URL: https://github.com/apache/sling-site/pull/155 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[VOTE] Release Apache Sling Content-Package to Feature Model Converter 1.3.6
Hi, We solved 2 issues in this release: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710&version=12353651&styleName=Text Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2840/ You can use this UNIX script to download the release and verify the signatures: https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh Usage: sh check_staged_release.sh 2840 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards, Robert Munteanu
[jira] [Updated] (SLING-11778) Test that the feature models generated by the CPConverter are deployable
[ https://issues.apache.org/jira/browse/SLING-11778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-11778: Fix Version/s: Content-Package to Feature Model Converter 1.3.8 (was: Content-Package to Feature Model Converter 1.3.6) > Test that the feature models generated by the CPConverter are deployable > > > Key: SLING-11778 > URL: https://issues.apache.org/jira/browse/SLING-11778 > Project: Sling > Issue Type: Improvement > Components: Content-Package to Feature Model Converter >Reporter: Robert Munteanu >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.3.8 > > > We have a set of tests in the CPConverter that validate what the output looks > like. I have a feeling that we would be better off if we would validate that > the feature models and associated artifacts can actually be installed. > We can do this by setting up a Sling application that contains the > prerequisites ( Oak/FileVault mostly ) and starting that application with the > feature models generated. The application can be parameterised to use > different FileVault versions, so we are certain that we don't run into > problems like SLING-11777 . > We can then validate that > - all bundles are started > - all content packages are installed > I think this would cover a gap that we have regarding validating the > correctness of the artifacts that we generate with the CPConverter. > We don't have to start with a lot of tests, but having 1-3 content packages > with good coverages validated as "installable" would IMO be a great step > forward. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12197) cpconverter: Sling-Initial-Content directories created as nt:folder instead of sling:Folder
[
https://issues.apache.org/jira/browse/SLING-12197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu updated SLING-12197:
Fix Version/s: Content-Package to Feature Model Converter 1.3.8
(was: Content-Package to Feature Model Converter 1.3.6)
> cpconverter: Sling-Initial-Content directories created as nt:folder instead
> of sling:Folder
> ---
>
> Key: SLING-12197
> URL: https://issues.apache.org/jira/browse/SLING-12197
> Project: Sling
> Issue Type: Bug
> Components: Content-Package to Feature Model Converter
>Affects Versions: Content-Package to Feature Model Converter 1.3.4
>Reporter: Stefan Seifert
>Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.3.8
>
> Attachments: io.wcm.handler.link-apps-1.10.2-cp2fm-converted.zip
>
>
> the cpconverter extracts Sling-Initial-Content from OSGi bundles and creates
> FileVault packages with the transformed content.
> this works well, but there is one difference when the resulting content
> package is installed compared when uploading the OSGi bundle with the
> Sling-Initial-Content directly:
> * the JCR Content Loader by defaults creates a {{sling:Folder}} node type for
> each directory found in the Sling-Initial-Content (see also
> [docs|https://sling.apache.org/documentation/bundles/content-loading-jcr-contentloader.html#initial-content-loading-1])
> * the cpconverter process creates no {{.content.xml}} file for the folders,
> but only for the actual JSON files found in the process. as a result, the
> folders are created as {{nt:folder}} when uploading the transformed package
> * this difference becomes relevant, when a JSON file in Sling-Initial-Content
> defines a primary type of {{nt:unstructured}} - it is not allowed to created
> such a node directly below a {{nt:folder}} node - but it is allowed to do so
> below a {{sling:Folder}} node
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[PR] chore(deps): update dependency com.fasterxml.woodstox:woodstox-core to v6.6.1 [sling-org-apache-sling-starter]
renovate-bot opened a new pull request, #309: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/309 [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.fasterxml.woodstox:woodstox-core](https://togithub.com/FasterXML/woodstox) | `6.6.0` -> `6.6.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/apache/sling-org-apache-sling-starter). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] chore(deps): update dependency org.apache.sling:org.apache.sling.servlets.resolver to v2.11.2 [sling-org-apache-sling-starter]
renovate-bot opened a new pull request, #310: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/310 [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.apache.sling:org.apache.sling.servlets.resolver](https://sling.apache.org) ([source](https://togithub.com/apache/sling-org-apache-sling-servlets-resolver)) | `2.11.0` -> `2.11.2` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/apache/sling-org-apache-sling-starter). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
March 2023 board report draft
Hi, I plan to submit the following report on Monday. Feedback welcome, Thanks, Robert --- ## Description: Apache Sling™ is a framework for RESTful web-applications based on an extensible content tree. ## Project Status: Current project status: Ongoing, with moderate activity. Issues for the board: none. ## Membership Data: Apache Sling was founded 2009-06-17 (15 years ago) There are currently 51 committers and 29 PMC members in this project. The Committer-to-PMC ratio is roughly 7:4. Community changes, past quarter: - No new PMC members. Last addition was Joerg Hoh on 2022-06-13. - No new committers. Last addition was Henry Kuijpers on 2023-10-19. ## Project Activity: We released version 12 of our sample application, the Sling Starter, on March 18th, 2022. We have not yet made plans for version 13, but individual modules are being developed and released, with 27 releases for this reporting period. Work is ongoing for migrating individual modules to the Jakarta JSON specification. ## Community Health: Community health is good and contributions from various individuals continue.
Re: [VOTE] Release Apache Sling Content-Package to Feature Model Converter 1.3.6
+1 Am Do., 29. Feb. 2024 um 15:29 Uhr schrieb Robert Munteanu < romb...@apache.org>: > Hi, > > We solved 2 issues in this release: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710&version=12353651&styleName=Text > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2840/ > > You can use this UNIX script to download the release and verify the > signatures: > > https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh > > Usage: > sh check_staged_release.sh 2840 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards, > Robert Munteanu > -- https://cqdump.joerghoh.de
[PR] Add tests for multiple applicable configs [sling-org-apache-sling-event]
kwin opened a new pull request, #35: URL: https://github.com/apache/sling-org-apache-sling-event/pull/35 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (SLING-12259) ModelFactory adatpercache does not cleanup keys when weakreference are collectd
Sumanta Pakira created SLING-12259:
--
Summary: ModelFactory adatpercache does not cleanup keys when
weakreference are collectd
Key: SLING-12259
URL: https://issues.apache.org/jira/browse/SLING-12259
Project: Sling
Issue Type: Bug
Reporter: Sumanta Pakira
When the model cache is enabled, then the adapter cache map keeps on growing
which caused memory leaks.
For example, In an application when adapting to a resource of type dam:Asset
then in this [line of
code|https://github.com/apache/sling-org-apache-sling-models-impl/blob/master/src/main/java/org/apache/sling/models/impl/ModelAdapterFactory.java#L351]
the Map keeps on growing. Because WeakHashMap value gets Garbage collected
faster, so the values are removed but the keys remain.
One way to solve this would be, some housekeeping to remove key-value pairs
that have had their {{SoftReferences}} cleared.
The approach I think could be one map that maps between the cache key and weak
referenced values and one in the opposite direction mapping between the weak
referenced values and the keys and reference queue and a cleanup thread.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SLING-12259) ModelFactory adatpercache does not cleanup keys when weakreference are collectd
[
https://issues.apache.org/jira/browse/SLING-12259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sumanta Pakira updated SLING-12259:
---
Description:
When the model cache is enabled, then the adapter cache map keeps on growing
which caused memory leaks.
For example, In an application when adapting to a resource of type dam:Asset
then in this [line of
code|https://github.com/apache/sling-org-apache-sling-models-impl/blob/master/src/main/java/org/apache/sling/models/impl/ModelAdapterFactory.java#L351]
the Map keeps on growing. Because WeakHashMap value gets Garbage collected
faster, so the values are removed but the keys remain.
One way to solve this would be, some housekeeping to remove key-value pairs
that have had their {{SoftReferences}} cleared.
The approach I think could be one map that maps between the cache key and weak
referenced values and one in the opposite direction mapping between the weak
referenced values and the keys and reference queue and a cleanup thread.
If this sounds ok then I can create PR.
was:
When the model cache is enabled, then the adapter cache map keeps on growing
which caused memory leaks.
For example, In an application when adapting to a resource of type dam:Asset
then in this [line of
code|https://github.com/apache/sling-org-apache-sling-models-impl/blob/master/src/main/java/org/apache/sling/models/impl/ModelAdapterFactory.java#L351]
the Map keeps on growing. Because WeakHashMap value gets Garbage collected
faster, so the values are removed but the keys remain.
One way to solve this would be, some housekeeping to remove key-value pairs
that have had their {{SoftReferences}} cleared.
The approach I think could be one map that maps between the cache key and weak
referenced values and one in the opposite direction mapping between the weak
referenced values and the keys and reference queue and a cleanup thread.
> ModelFactory adatpercache does not cleanup keys when weakreference are
> collectd
> ---
>
> Key: SLING-12259
> URL: https://issues.apache.org/jira/browse/SLING-12259
> Project: Sling
> Issue Type: Bug
>Reporter: Sumanta Pakira
>Priority: Minor
>
> When the model cache is enabled, then the adapter cache map keeps on growing
> which caused memory leaks.
> For example, In an application when adapting to a resource of type dam:Asset
> then in this [line of
> code|https://github.com/apache/sling-org-apache-sling-models-impl/blob/master/src/main/java/org/apache/sling/models/impl/ModelAdapterFactory.java#L351]
> the Map keeps on growing. Because WeakHashMap value gets Garbage collected
> faster, so the values are removed but the keys remain.
>
> One way to solve this would be, some housekeeping to remove key-value pairs
> that have had their {{SoftReferences}} cleared.
> The approach I think could be one map that maps between the cache key and
> weak referenced values and one in the opposite direction mapping between the
> weak referenced values and the keys and reference queue and a cleanup thread.
> If this sounds ok then I can create PR.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SLING-12259) ModelFactory adatpercache does not cleanup keys when weakreference are collectd
[
https://issues.apache.org/jira/browse/SLING-12259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sumanta Pakira updated SLING-12259:
---
Component/s: Sling Models
Priority: Major (was: Minor)
> ModelFactory adatpercache does not cleanup keys when weakreference are
> collectd
> ---
>
> Key: SLING-12259
> URL: https://issues.apache.org/jira/browse/SLING-12259
> Project: Sling
> Issue Type: Bug
> Components: Sling Models
>Reporter: Sumanta Pakira
>Priority: Major
>
> When the model cache is enabled, then the adapter cache map keeps on growing
> which caused memory leaks.
> For example, In an application when adapting to a resource of type dam:Asset
> then in this [line of
> code|https://github.com/apache/sling-org-apache-sling-models-impl/blob/master/src/main/java/org/apache/sling/models/impl/ModelAdapterFactory.java#L351]
> the Map keeps on growing. Because WeakHashMap value gets Garbage collected
> faster, so the values are removed but the keys remain.
>
> One way to solve this would be, some housekeeping to remove key-value pairs
> that have had their {{SoftReferences}} cleared.
> The approach I think could be one map that maps between the cache key and
> weak referenced values and one in the opposite direction mapping between the
> weak referenced values and the keys and reference queue and a cleanup thread.
> If this sounds ok then I can create PR.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SLING-12259) ModelFactory adatpercache does not cleanup keys when weakreference are collectd
[
https://issues.apache.org/jira/browse/SLING-12259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sumanta Pakira updated SLING-12259:
---
Description:
When the model cache is enabled, then the adapter cache map keeps on growing
which caused memory leaks.
For example, In an application when adapting to a resource of type dam:Asset
then in this [line of
code|https://github.com/apache/sling-org-apache-sling-models-impl/blob/master/src/main/java/org/apache/sling/models/impl/ModelAdapterFactory.java#L351]
the Map keeps on growing. Because WeakHashMap gets Garbage collected faster,
so the values are removed but the keys remain.
One way to solve this would be, some housekeeping to remove key-value pairs
that have had their {{SoftReferences}} cleared.
The approach I think could be one map that maps between the cache key and weak
referenced values and one in the opposite direction mapping between the weak
referenced values and the keys and reference queue and a cleanup thread.
If this sounds ok then I can create PR.
was:
When the model cache is enabled, then the adapter cache map keeps on growing
which caused memory leaks.
For example, In an application when adapting to a resource of type dam:Asset
then in this [line of
code|https://github.com/apache/sling-org-apache-sling-models-impl/blob/master/src/main/java/org/apache/sling/models/impl/ModelAdapterFactory.java#L351]
the Map keeps on growing. Because WeakHashMap value gets Garbage collected
faster, so the values are removed but the keys remain.
One way to solve this would be, some housekeeping to remove key-value pairs
that have had their {{SoftReferences}} cleared.
The approach I think could be one map that maps between the cache key and weak
referenced values and one in the opposite direction mapping between the weak
referenced values and the keys and reference queue and a cleanup thread.
If this sounds ok then I can create PR.
> ModelFactory adatpercache does not cleanup keys when weakreference are
> collectd
> ---
>
> Key: SLING-12259
> URL: https://issues.apache.org/jira/browse/SLING-12259
> Project: Sling
> Issue Type: Bug
> Components: Sling Models
>Reporter: Sumanta Pakira
>Priority: Major
>
> When the model cache is enabled, then the adapter cache map keeps on growing
> which caused memory leaks.
> For example, In an application when adapting to a resource of type dam:Asset
> then in this [line of
> code|https://github.com/apache/sling-org-apache-sling-models-impl/blob/master/src/main/java/org/apache/sling/models/impl/ModelAdapterFactory.java#L351]
> the Map keeps on growing. Because WeakHashMap gets Garbage collected faster,
> so the values are removed but the keys remain.
>
> One way to solve this would be, some housekeeping to remove key-value pairs
> that have had their {{SoftReferences}} cleared.
> The approach I think could be one map that maps between the cache key and
> weak referenced values and one in the opposite direction mapping between the
> weak referenced values and the keys and reference queue and a cleanup thread.
> If this sounds ok then I can create PR.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] Bump gson from 2.8.6 to 2.8.9 [sling-org-apache-sling-feature-cpconverter]
sonarcloud[bot] commented on PR #137: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/137#issuecomment-1971668345 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=137) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=137&resolved=false&inNewCodePeriod=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=137&metric=new_accepted_issues&view=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=137&resolved=false&inNewCodePeriod=true)  No data about Coverage  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=137&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=137) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] issue/binary indexing [sling-org-apache-sling-feature-cpconverter]
sonarcloud[bot] commented on PR #174: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/174#issuecomment-1971666495 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=174) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=174&resolved=false&inNewCodePeriod=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=174&metric=new_accepted_issues&view=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=174&resolved=false&inNewCodePeriod=true)  No data about Coverage  No data about Duplication [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=174) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (SLING-12259) ModelFactory adatpercache does not cleanup entries
[
https://issues.apache.org/jira/browse/SLING-12259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sumanta Pakira updated SLING-12259:
---
Summary: ModelFactory adatpercache does not cleanup entries (was:
ModelFactory adatpercache does not cleanup keys when weakreference are collectd)
> ModelFactory adatpercache does not cleanup entries
> --
>
> Key: SLING-12259
> URL: https://issues.apache.org/jira/browse/SLING-12259
> Project: Sling
> Issue Type: Bug
> Components: Sling Models
>Reporter: Sumanta Pakira
>Priority: Major
>
> When the model cache is enabled, then the adapter cache map keeps on growing
> which caused memory leaks.
> For example, In an application when adapting to a resource of type dam:Asset
> then in this [line of
> code|https://github.com/apache/sling-org-apache-sling-models-impl/blob/master/src/main/java/org/apache/sling/models/impl/ModelAdapterFactory.java#L351]
> the Map keeps on growing. Because WeakHashMap gets Garbage collected faster,
> so the values are removed but the keys remain.
>
> One way to solve this would be, some housekeeping to remove key-value pairs
> that have had their {{SoftReferences}} cleared.
> The approach I think could be one map that maps between the cache key and
> weak referenced values and one in the opposite direction mapping between the
> weak referenced values and the keys and reference queue and a cleanup thread.
> If this sounds ok then I can create PR.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SLING-12259) ModelFactory adatpercache does not cleanup entries
[
https://issues.apache.org/jira/browse/SLING-12259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sumanta Pakira updated SLING-12259:
---
Description:
When the model cache is enabled, then the adapter cache map keeps on growing
which caused memory leaks.
For example, In an application when adapting to a resource of type dam:Asset
then in this [line of
code|https://github.com/apache/sling-org-apache-sling-models-impl/blob/master/src/main/java/org/apache/sling/models/impl/ModelAdapterFactory.java#L351]
the Map keeps on growing.
was:
When the model cache is enabled, then the adapter cache map keeps on growing
which caused memory leaks.
For example, In an application when adapting to a resource of type dam:Asset
then in this [line of
code|https://github.com/apache/sling-org-apache-sling-models-impl/blob/master/src/main/java/org/apache/sling/models/impl/ModelAdapterFactory.java#L351]
the Map keeps on growing. Because WeakHashMap gets Garbage collected faster,
so the values are removed but the keys remain.
One way to solve this would be, some housekeeping to remove key-value pairs
that have had their {{SoftReferences}} cleared.
The approach I think could be one map that maps between the cache key and weak
referenced values and one in the opposite direction mapping between the weak
referenced values and the keys and reference queue and a cleanup thread.
If this sounds ok then I can create PR.
> ModelFactory adatpercache does not cleanup entries
> --
>
> Key: SLING-12259
> URL: https://issues.apache.org/jira/browse/SLING-12259
> Project: Sling
> Issue Type: Bug
> Components: Sling Models
>Reporter: Sumanta Pakira
>Priority: Major
>
> When the model cache is enabled, then the adapter cache map keeps on growing
> which caused memory leaks.
> For example, In an application when adapting to a resource of type dam:Asset
> then in this [line of
> code|https://github.com/apache/sling-org-apache-sling-models-impl/blob/master/src/main/java/org/apache/sling/models/impl/ModelAdapterFactory.java#L351]
> the Map keeps on growing.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SLING-12259) ModelFactory adatpercache does not cleanup entries
[ https://issues.apache.org/jira/browse/SLING-12259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sumanta Pakira updated SLING-12259: --- Description: When the model cache is enabled, then the adapter cache map keeps on growing which causes high memory consumtion For example, In an application when adapting to a resource of type dam:Asset then in this [line of code|https://github.com/apache/sling-org-apache-sling-models-impl/blob/master/src/main/java/org/apache/sling/models/impl/ModelAdapterFactory.java#L351] the Map keeps on growing. One way to solve this problem would be to implement LRU based cache was: When the model cache is enabled, then the adapter cache map keeps on growing which caused memory leaks. For example, In an application when adapting to a resource of type dam:Asset then in this [line of code|https://github.com/apache/sling-org-apache-sling-models-impl/blob/master/src/main/java/org/apache/sling/models/impl/ModelAdapterFactory.java#L351] the Map keeps on growing. > ModelFactory adatpercache does not cleanup entries > -- > > Key: SLING-12259 > URL: https://issues.apache.org/jira/browse/SLING-12259 > Project: Sling > Issue Type: Bug > Components: Sling Models >Reporter: Sumanta Pakira >Priority: Major > > When the model cache is enabled, then the adapter cache map keeps on growing > which causes high memory consumtion > For example, In an application when adapting to a resource of type dam:Asset > then in this [line of > code|https://github.com/apache/sling-org-apache-sling-models-impl/blob/master/src/main/java/org/apache/sling/models/impl/ModelAdapterFactory.java#L351] > the Map keeps on growing. > One way to solve this problem would be to implement LRU based cache > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12259) ModelFactory adatpercache does not cleanup entries
[ https://issues.apache.org/jira/browse/SLING-12259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sumanta Pakira updated SLING-12259: --- Description: When the model cache is enabled, then the adapter cache map keeps on growing which causes high memory consumption For example, In an application when adapting to a resource of type dam:Asset then in this [line of code|https://github.com/apache/sling-org-apache-sling-models-impl/blob/master/src/main/java/org/apache/sling/models/impl/ModelAdapterFactory.java#L351] the Map keeps on growing. One way to solve this problem would be to implement LRU based cache. Please let me know what do you think, I can create PR accordingly. was: When the model cache is enabled, then the adapter cache map keeps on growing which causes high memory consumtion For example, In an application when adapting to a resource of type dam:Asset then in this [line of code|https://github.com/apache/sling-org-apache-sling-models-impl/blob/master/src/main/java/org/apache/sling/models/impl/ModelAdapterFactory.java#L351] the Map keeps on growing. One way to solve this problem would be to implement LRU based cache. Please let me know what do you think, I can create PR accordingly. > ModelFactory adatpercache does not cleanup entries > -- > > Key: SLING-12259 > URL: https://issues.apache.org/jira/browse/SLING-12259 > Project: Sling > Issue Type: Bug > Components: Sling Models >Reporter: Sumanta Pakira >Priority: Major > > When the model cache is enabled, then the adapter cache map keeps on growing > which causes high memory consumption > For example, In an application when adapting to a resource of type dam:Asset > then in this [line of > code|https://github.com/apache/sling-org-apache-sling-models-impl/blob/master/src/main/java/org/apache/sling/models/impl/ModelAdapterFactory.java#L351] > the Map keeps on growing. > One way to solve this problem would be to implement LRU based cache. Please > let me know what do you think, I can create PR accordingly. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12259) ModelFactory adatpercache does not cleanup entries
[ https://issues.apache.org/jira/browse/SLING-12259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sumanta Pakira updated SLING-12259: --- Description: When the model cache is enabled, then the adapter cache map keeps on growing which causes high memory consumtion For example, In an application when adapting to a resource of type dam:Asset then in this [line of code|https://github.com/apache/sling-org-apache-sling-models-impl/blob/master/src/main/java/org/apache/sling/models/impl/ModelAdapterFactory.java#L351] the Map keeps on growing. One way to solve this problem would be to implement LRU based cache. Please let me know what do you think, I can create PR accordingly. was: When the model cache is enabled, then the adapter cache map keeps on growing which causes high memory consumtion For example, In an application when adapting to a resource of type dam:Asset then in this [line of code|https://github.com/apache/sling-org-apache-sling-models-impl/blob/master/src/main/java/org/apache/sling/models/impl/ModelAdapterFactory.java#L351] the Map keeps on growing. One way to solve this problem would be to implement LRU based cache > ModelFactory adatpercache does not cleanup entries > -- > > Key: SLING-12259 > URL: https://issues.apache.org/jira/browse/SLING-12259 > Project: Sling > Issue Type: Bug > Components: Sling Models >Reporter: Sumanta Pakira >Priority: Major > > When the model cache is enabled, then the adapter cache map keeps on growing > which causes high memory consumtion > For example, In an application when adapting to a resource of type dam:Asset > then in this [line of > code|https://github.com/apache/sling-org-apache-sling-models-impl/blob/master/src/main/java/org/apache/sling/models/impl/ModelAdapterFactory.java#L351] > the Map keeps on growing. > One way to solve this problem would be to implement LRU based cache. Please > let me know what do you think, I can create PR accordingly. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
