Sling API exporting @ConsumerType class
Eric pointed out correctly, that there was tight connection between SLING API and Scripting core, as the package import range on scripting core (bundle version 2.4.8) is quite narrow for the package org.apache.sling.api.scripting: org.apache.sling.api.scripting; version="[2.5, 2.6)" This is caused by the class LazyBindings being a ConsumerType ( https://github.com/apache/sling-org-apache-sling-api/blob/bdbd1768969917d0e2436d5b008fff80aaa729dc/src/main/java/org/apache/sling/api/scripting/LazyBindings.java#L56) and the scripting core inheriting from it (in ProtectedBindings). My latest extension to it (SLING-12062) then caused a bump of the exported version, thus breaking the existing imports. Of course I could do a release of the Scripting Core as well and make sure that it works with the package version as well, but I wonder if this is the right thing to do. Should the Sling API export ConsumerType interfaces and classes at all, which can cause this type of problems, or should we try to avoid them? This is a more general question; and in case that we want to avoid those, the question is still how we want to move forward with this specific instance of it. My personal opinion is * to avoid @ConsumerType exports in the Sling API in general and * move the ProtectedBindings class, which inherits from the LazyBindings over to the API that would allow us to have a wider import range on the scripting.core side. WDYT? Jörg -- https://cqdump.joerghoh.de
Re: [VOTE] Release Apache Sling API 2.27.4
Hi Eric, good point; I already thought about it, but wasn't aware of that narrow dependency range between scripting.core and Sling API. Will cancel this release and try to come up with a proper solution. Thanks! Am Do., 6. Juni 2024 um 23:18 Uhr schrieb Eric Norman : > 0 for me. It is probably ok, but I wasn't able to try it in the starter > (or my own projects) due to the errors below from the feature analyzer, > Maybe you can update and release those other impacted bundles at the same > time as this one? > > [ERROR] [bundle-packages] > org.apache.sling:org.apache.sling.scripting.core:2.4.8: Bundle is importing > package org.apache.sling.api.scripting;version=[2.5,2.6) with start order > 20 but no bundle is exporting these for that start order in the required > version range. > [ERROR] [bundle-packages] > org.apache.sling:org.apache.sling.servlets.resolver:2.11.2: Bundle is > importing package org.apache.sling.api.scripting;version=[2.5,2.6) with > start order 20 but no bundle is exporting these for that start order in the > required version range. > > Regards, > Eric > > On Tue, Jun 4, 2024 at 6:25 AM Jörg Hoh > wrote: > > > We solved 9 issues in this > > release: > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12353245=Text=12310710 > > Staging repository: > > https://repository.apache.org/content/repositories/orgapachesling-2865/ > > > > You can use this UNIX script to download the release and verify the > > signatures: > > > https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh > > Usage: > > sh check_staged_release.sh 2865 /tmp/sling-staging > > > > Please vote to approve this release: > > > > [ ] +1 Approve the release > > [ ] 0 Don't care > > [ ] -1 Don't release, because ... > > > > This majority vote is open for at least 72 hours. > > > > > > > > -- > > https://cqdump.joerghoh.de > > > -- https://cqdump.joerghoh.de
[jira] [Updated] (SLING-12351) Create a default implementation for generating the analyser-metadata extension
[
https://issues.apache.org/jira/browse/SLING-12351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu updated SLING-12351:
Fix Version/s: Feature Model Analyser 2.0.6
> Create a default implementation for generating the analyser-metadata extension
> --
>
> Key: SLING-12351
> URL: https://issues.apache.org/jira/browse/SLING-12351
> Project: Sling
> Issue Type: Improvement
> Components: Feature Model Analyser
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Feature Model Analyser 2.0.6
>
>
> The feature model analysers contains and use the
> {{AnalyserMetaDataExtension}} -
> https://github.com/apache/sling-org-apache-sling-feature-analyser/blob/c8518ebd7c8fa245781ad8062f2c2d6b52174345/src/main/java/org/apache/sling/feature/analyser/extensions/AnalyserMetaDataExtension.java
> .
> This class is read and used (error reporting, cached manifests) but there is
> currently no automated way of generating the metadata.
> We should provide a default implementation that simplifies the metadata
> generation. The same implementation should also support generating the
> framework capabilities metadata as discussed in SLING-10288 .
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (SLING-12351) Create a default implementation for generating the analyser-metadata extension
[
https://issues.apache.org/jira/browse/SLING-12351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu resolved SLING-12351.
-
Resolution: Fixed
> Create a default implementation for generating the analyser-metadata extension
> --
>
> Key: SLING-12351
> URL: https://issues.apache.org/jira/browse/SLING-12351
> Project: Sling
> Issue Type: Improvement
> Components: Feature Model Analyser
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Feature Model Analyser 2.0.6
>
>
> The feature model analysers contains and use the
> {{AnalyserMetaDataExtension}} -
> https://github.com/apache/sling-org-apache-sling-feature-analyser/blob/c8518ebd7c8fa245781ad8062f2c2d6b52174345/src/main/java/org/apache/sling/feature/analyser/extensions/AnalyserMetaDataExtension.java
> .
> This class is read and used (error reporting, cached manifests) but there is
> currently no automated way of generating the metadata.
> We should provide a default implementation that simplifies the metadata
> generation. The same implementation should also support generating the
> framework capabilities metadata as discussed in SLING-10288 .
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SLING-10288) FelixFrameworkScanner sets framework properties always for current Java version
[
https://issues.apache.org/jira/browse/SLING-10288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu updated SLING-10288:
Fix Version/s: Feature Model Analyser 2.0.4
> FelixFrameworkScanner sets framework properties always for current Java
> version
> ---
>
> Key: SLING-10288
> URL: https://issues.apache.org/jira/browse/SLING-10288
> Project: Sling
> Issue Type: Bug
> Components: Feature Model Analyser
>Reporter: Konrad Windszus
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Feature Model Analyser 2.0.4
>
>
> Sometimes the analyser is executed with a different java version than the one
> executing the actual OSGi container. There should be a possibility to
> explicitly set a Java version.
> Currently the framework properties are gathered in a dedicated java process
> executing
> https://github.com/apache/sling-org-apache-sling-feature-analyser/blob/730b7d3297ab9f17f484e7b557e4ec47c3d9b3e9/src/main/java/org/apache/sling/feature/scanner/impl/fwk/FrameworkPropertiesGatherer.java#L41.
> That new process always takes the current {{java.home}} which therefore
> returns the wrong properties (i.e. the ones for the current java version
> instead of the one used to execute the framework).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SLING-10288) FelixFrameworkScanner sets framework properties always for current Java version
[
https://issues.apache.org/jira/browse/SLING-10288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu updated SLING-10288:
Fix Version/s: Feature Model Analyser 2.0.6
(was: Feature Model Analyser 2.0.4)
> FelixFrameworkScanner sets framework properties always for current Java
> version
> ---
>
> Key: SLING-10288
> URL: https://issues.apache.org/jira/browse/SLING-10288
> Project: Sling
> Issue Type: Bug
> Components: Feature Model Analyser
>Reporter: Konrad Windszus
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Feature Model Analyser 2.0.6
>
>
> Sometimes the analyser is executed with a different java version than the one
> executing the actual OSGi container. There should be a possibility to
> explicitly set a Java version.
> Currently the framework properties are gathered in a dedicated java process
> executing
> https://github.com/apache/sling-org-apache-sling-feature-analyser/blob/730b7d3297ab9f17f484e7b557e4ec47c3d9b3e9/src/main/java/org/apache/sling/feature/scanner/impl/fwk/FrameworkPropertiesGatherer.java#L41.
> That new process always takes the current {{java.home}} which therefore
> returns the wrong properties (i.e. the ones for the current java version
> instead of the one used to execute the framework).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SLING-12351) Create a default implementation for generating the analyser-metadata extension
[
https://issues.apache.org/jira/browse/SLING-12351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu updated SLING-12351:
Fix Version/s: (was: Feature Model Analyser 2.0.4)
> Create a default implementation for generating the analyser-metadata extension
> --
>
> Key: SLING-12351
> URL: https://issues.apache.org/jira/browse/SLING-12351
> Project: Sling
> Issue Type: Improvement
> Components: Feature Model Analyser
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
>
> The feature model analysers contains and use the
> {{AnalyserMetaDataExtension}} -
> https://github.com/apache/sling-org-apache-sling-feature-analyser/blob/c8518ebd7c8fa245781ad8062f2c2d6b52174345/src/main/java/org/apache/sling/feature/analyser/extensions/AnalyserMetaDataExtension.java
> .
> This class is read and used (error reporting, cached manifests) but there is
> currently no automated way of generating the metadata.
> We should provide a default implementation that simplifies the metadata
> generation. The same implementation should also support generating the
> framework capabilities metadata as discussed in SLING-10288 .
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] SLING-12351 - Create a default implementation for generating the analyser-metadata extension [sling-org-apache-sling-feature-analyser]
rombert merged PR #46: URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/46 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: VOTE] Release Apache Sling Feature Model Analyser 2.0.4
+1 Regards Julian On Fri, Jun 7, 2024 at 5:40 PM Jörg Hoh wrote: > > +1 > > (You might need to update your gpg keys before) > > Am Fr., 7. Juni 2024 um 14:00 Uhr schrieb ang...@apache.org < > ang...@apache.org>: > > > Hi everyone, > > > > We solved 4 issues in this release: > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12353831=Text > > > > Staging repository: > > https://repository.apache.org/content/repositories/orgapachesling-2866/ > > > > You can use this UNIX script to download the release and verify the > > signatures: > > > > > > https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh > > > > Usage: > > sh check_staged_release.sh 2866 /tmp/sling-staging > > > > Please vote to approve this release: > > > >[ ] +1 Approve the release > >[ ] 0 Don't care > >[ ] -1 Don't release, because ... > > > > This majority vote is open for at least 72 hours. > > > > Thanks for voting and kind regards > > Angela > > > > > -- > https://cqdump.joerghoh.de
