Re: [VOTE] Release Apache Sling Repoinit JCR 1.1.50

[Andrei Dulvac]

+1

- Andrei

On Fri, Jun 7, 2024 at 12:20 AM Eric Norman  wrote:

> +1
>
> Regards,
> Eric
>
> On Tue, Jun 4, 2024 at 6:27 AM Julian Sedding  wrote:
>
> > Hi,
> >
> > We solved 1 issue in this release:
> >
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12354758=Text
> >
> > Staging repository:
> > https://repository.apache.org/content/repositories/orgapachesling-2864/
> >
> > You can use this UNIX script to download the release and verify the
> > signatures:
> >
> >
> https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh
> >
> > Usage:
> > sh check_staged_release.sh 2864 /tmp/sling-staging
> >
> > Please vote to approve this release:
> >
> >   [ ] +1 Approve the release
> >   [ ]  0 Don't care
> >   [ ] -1 Don't release, because ...
> >
> > This majority vote is open for at least 72 hours.
> >
> > Regards
> > Julian
> >
>

Re: [VOTE] Release Apache Sling Hypermedia API client-side tools 1.0.2

[Andrei Dulvac]

Hi.

The vote passed with 3 +1 binding votes.
I'll finalize the release.

- Andrei



On Thu, May 2, 2024 at 9:43 AM Stefan Seifert
 wrote:

> +1
>
> stefan
>

[VOTE] Release Apache Sling Hypermedia API client-side tools 1.0.2

[Andrei Dulvac]

We solved 1 issues in this release:
https://issues.apache.org/jira/issues/?jql=project%20%3D%20SLING%20AND%20fixVersion%20%3D%20%22HApi%20Client%201.0.2%22


Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2858/

You can use this UNIX script to download the release and verify the
signatures:
https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh

Usage:
sh check_staged_release.sh 2858 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

- Andrei

Re: [VOTE] Release Apache Sling Rewriter 1.4.4

[Andrei Dulvac]

+1


On Tue, Apr 30, 2024 at 12:26 PM Robert Munteanu  wrote:

> On Tue, 2024-04-30 at 11:27 +0200, Carsten Ziegeler wrote:
> > Please vote to approve this release:
>
> +1
> Robert
>

[jira] [Created] (SLING-12309) Upgrade dependencies (remove security vulnerabilities)

[Andrei Dulvac (Jira)]

Andrei Dulvac created SLING-12309:
-

 Summary: Upgrade dependencies (remove security vulnerabilities)
 Key: SLING-12309
 URL: https://issues.apache.org/jira/browse/SLING-12309
 Project: Sling
  Issue Type: Improvement
  Components: HApi Client
Affects Versions: HApi Client 1.0.0
Reporter: Andrei Dulvac
Assignee: Andrei Dulvac
 Fix For: HApi Client 1.0.2


Update all maven deps with known vulnerabilities



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[RESULT] [VOTE] Release Apache Sling Testing Clients 3.0.24

[Andrei Dulvac]

Hi, With my +1, the vote has passed with the following result : +1
(binding): Robert, Jörg, Andrei +1 (non binding): none I will copy this
release to the Sling dist directory and promote the artifacts to the
central Maven repository.
- Andrei

On Tue, Feb 6, 2024 at 9:04 PM Jörg Hoh 
wrote:

> +1
>
> Am Di., 6. Feb. 2024 um 13:33 Uhr schrieb Andrei Dulvac  >:
>
> > Hi,
> >
> > We solved 1 issue in this release:
> > https://issues.apache.org/jira/projects/SLING/versions/12354205
> >
> > Staging repository:
> > https://repository.apache.org/content/repositories/orgapachesling-2837
> >
> > You can use this UNIX script to download the release and verify the
> > signatures:
> >
> >
> https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh
> >
> > Usage:
> > sh check_staged_release.sh 2837 /tmp/sling-staging
> >
> > Please vote to approve this release:
> >
> >   [ ] +1 Approve the release
> >   [ ]  0 Don't care
> >   [ ] -1 Don't release, because ...
> >
> > This majority vote is open for at least 72 hours.
> >
> > - Andrei
> >
>
>
> --
> https://cqdump.joerghoh.de
>

[VOTE] Release Apache Sling Testing Clients 3.0.24

[Andrei Dulvac]

Hi,

We solved 1 issue in this release:
https://issues.apache.org/jira/projects/SLING/versions/12354205

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2837

You can use this UNIX script to download the release and verify the
signatures:
https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh

Usage:
sh check_staged_release.sh 2837 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

- Andrei

[jira] [Resolved] (SLING-12241) Anonymous sling testing client throws NPE

[Andrei Dulvac (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrei Dulvac resolved SLING-12241.
---
Resolution: Fixed

> Anonymous sling testing client throws NPE
> -
>
> Key: SLING-12241
> URL: https://issues.apache.org/jira/browse/SLING-12241
> Project: Sling
>  Issue Type: Bug
>  Components: Apache Sling Testing Clients
>Affects Versions: Apache Sling Testing Clients 3.0.22
>Reporter: Evgeny Tugarev
>    Assignee: Andrei Dulvac
>Priority: Major
> Fix For: Apache Sling Testing Clients 3.0.24
>
>
> When _null_ is passed as a user name to sling testing client, to mimic the 
> anonymous user, an NPE is thrown in FormBasedAuthInterceptor.
> to reproduce:
> {code:java}
> FormBasedAuthInterceptor interceptor = new 
> FormBasedAuthInterceptor(LOGIN_COOKIE_NAME); 
> SlingClient anonymousClient = SlingClient.Builder.create(httpServer.getURI(), 
> null, "pass")
> .addInterceptorLast(interceptor).build();
> annonnymousClient.doGet(LOGIN_OK_PATH, 200); // NPE
> {code}
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (SLING-12241) Anonymous sling testing client throws NPE

[Andrei Dulvac (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrei Dulvac updated SLING-12241:
--
Fix Version/s: Apache Sling Testing Clients 3.0.24

> Anonymous sling testing client throws NPE
> -
>
> Key: SLING-12241
> URL: https://issues.apache.org/jira/browse/SLING-12241
> Project: Sling
>  Issue Type: Bug
>  Components: Apache Sling Testing Clients
>Affects Versions: Apache Sling Testing Clients 3.0.22
>Reporter: Evgeny Tugarev
>    Assignee: Andrei Dulvac
>Priority: Major
> Fix For: Apache Sling Testing Clients 3.0.24
>
>
> When _null_ is passed as a user name to sling testing client, to mimic the 
> anonymous user, an NPE is thrown in FormBasedAuthInterceptor.
> to reproduce:
> {code:java}
> FormBasedAuthInterceptor interceptor = new 
> FormBasedAuthInterceptor(LOGIN_COOKIE_NAME); 
> SlingClient anonymousClient = SlingClient.Builder.create(httpServer.getURI(), 
> null, "pass")
> .addInterceptorLast(interceptor).build();
> annonnymousClient.doGet(LOGIN_OK_PATH, 200); // NPE
> {code}
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (SLING-12241) Anonymous sling testing client throws NPE

[Andrei Dulvac (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrei Dulvac updated SLING-12241:
--
Affects Version/s: Apache Sling Testing Clients 3.0.24
   (was: Apache Sling Testing Clients 3.0.22)

> Anonymous sling testing client throws NPE
> -
>
> Key: SLING-12241
> URL: https://issues.apache.org/jira/browse/SLING-12241
> Project: Sling
>  Issue Type: Bug
>  Components: Apache Sling Testing Clients
>Affects Versions: Apache Sling Testing Clients 3.0.24
>Reporter: Evgeny Tugarev
>    Assignee: Andrei Dulvac
>Priority: Major
>
> When _null_ is passed as a user name to sling testing client, to mimic the 
> anonymous user, an NPE is thrown in FormBasedAuthInterceptor.
> to reproduce:
> {code:java}
> FormBasedAuthInterceptor interceptor = new 
> FormBasedAuthInterceptor(LOGIN_COOKIE_NAME); 
> SlingClient anonymousClient = SlingClient.Builder.create(httpServer.getURI(), 
> null, "pass")
> .addInterceptorLast(interceptor).build();
> annonnymousClient.doGet(LOGIN_OK_PATH, 200); // NPE
> {code}
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (SLING-12241) Anonymous sling testing client throws NPE

[Andrei Dulvac (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrei Dulvac updated SLING-12241:
--
Affects Version/s: Apache Sling Testing Clients 3.0.22
   (was: Apache Sling Testing Clients 3.0.24)

> Anonymous sling testing client throws NPE
> -
>
> Key: SLING-12241
> URL: https://issues.apache.org/jira/browse/SLING-12241
> Project: Sling
>  Issue Type: Bug
>  Components: Apache Sling Testing Clients
>Affects Versions: Apache Sling Testing Clients 3.0.22
>Reporter: Evgeny Tugarev
>    Assignee: Andrei Dulvac
>Priority: Major
>
> When _null_ is passed as a user name to sling testing client, to mimic the 
> anonymous user, an NPE is thrown in FormBasedAuthInterceptor.
> to reproduce:
> {code:java}
> FormBasedAuthInterceptor interceptor = new 
> FormBasedAuthInterceptor(LOGIN_COOKIE_NAME); 
> SlingClient anonymousClient = SlingClient.Builder.create(httpServer.getURI(), 
> null, "pass")
> .addInterceptorLast(interceptor).build();
> annonnymousClient.doGet(LOGIN_OK_PATH, 200); // NPE
> {code}
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Assigned] (SLING-12241) Anonymous testing client throws NPE

[Andrei Dulvac (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrei Dulvac reassigned SLING-12241:
-

Assignee: Andrei Dulvac

> Anonymous testing client throws NPE
> ---
>
> Key: SLING-12241
> URL: https://issues.apache.org/jira/browse/SLING-12241
> Project: Sling
>  Issue Type: Bug
>  Components: Apache Sling Testing Clients
>Affects Versions: Apache Sling Testing Clients 3.0.22
>Reporter: Evgeny Tugarev
>    Assignee: Andrei Dulvac
>Priority: Major
>
> When using the AEM testing Clients: anonymous client to access content on a 
> publish instance ( AEMCS)  the client throws an NPE
> to reproduce:
> {code:java}
>  anonymousPublish = cqBaseClassRule.publishRule.getClient(CQClient.class, 
> null, null);
>  anonymousPublish.doGet("/graphql/execute.json", 204);
> {code}
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[RESULT] [VOTE] Release Apache Sling Testing Clients 3.0.22

[Andrei Dulvac]

Hi,

The vote has passed with the following result :

+1 (binding): Carsten, Stefan, Jörg, Eric
+1 (non binding): none

I will copy this release to the Sling dist directory and
promote the artifacts to the central Maven repository.

- Andrei

On Wed, Jan 17, 2024 at 10:00 PM Eric Norman  wrote:

> +1
>
> On Mon, Jan 15, 2024 at 2:09 AM Andrei Dulvac  wrote:
>
> > Hi,
> >
> > We solved 5 issues in this release:
> > https://issues.apache.org/jira/projects/SLING/versions/12353709
> >
> > Staging repository:
> > https://repository.apache.org/content/repositories/orgapachesling-2829/
> >
> > You can use this UNIX script to download the release and verify the
> > signatures:
> >
> >
> https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh
> >
> > Usage:
> > sh check_staged_release.sh 2829 /tmp/sling-staging
> >
> > Please vote to approve this release:
> >
> >   [ ] +1 Approve the release
> >   [ ]  0 Don't care
> >   [ ] -1 Don't release, because ...
> >
> > This majority vote is open for at least 72 hours.
> >
> > - Andrei
> >
>

Re: [VOTE] Release Apache Sling Rewriter 1.3.8

[Andrei Dulvac]

+1

On Mon, Jan 15, 2024 at 10:58 AM Carsten Ziegeler 
wrote:

> Hi,
>
> We solved 3 issues in this release:
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12354083
>
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-2828/
>
> You can use this UNIX script to download the release and verify the
> signatures:
>
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
>
> Usage:
> sh check_staged_release.sh 2828 /tmp/sling-staging
>
> Please vote to approve this release:
>
>[ ] +1 Approve the release
>[ ]  0 Don't care
>[ ] -1 Don't release, because ...
>
> This majority vote is open for at least 72 hours.
>
> Regards
> Carsten
> --
> Carsten Ziegeler
> Adobe
> cziege...@apache.org
>

[VOTE] Release Apache Sling Testing Clients 3.0.22

[Andrei Dulvac]

Hi,

We solved 5 issues in this release:
https://issues.apache.org/jira/projects/SLING/versions/12353709

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2829/

You can use this UNIX script to download the release and verify the
signatures:
https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh

Usage:
sh check_staged_release.sh 2829 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

- Andrei

[jira] [Resolved] (SLING-12229) Update jackson and jsoup dependencies

[Andrei Dulvac (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrei Dulvac resolved SLING-12229.
---
Resolution: Fixed

> Update jackson and jsoup dependencies
> -
>
> Key: SLING-12229
> URL: https://issues.apache.org/jira/browse/SLING-12229
> Project: Sling
>  Issue Type: Bug
>  Components: Apache Sling Testing Clients
>Affects Versions: Apache Sling Testing Clients 3.0.20
>    Reporter: Andrei Dulvac
>    Assignee: Andrei Dulvac
>Priority: Major
> Fix For: Apache Sling Testing Clients 3.0.22
>
>
> jackson-core - 2.13.0, jackson-databind-2.13.2.1, jsoup-1.14.3 need to be 
> updated because they cause:
> CVE-2022-42003
> CVE-2022-42004
> CVE-2022-36033



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Assigned] (SLING-10868) Search pattern in getSlingLocation method only works if id is the last attribute

[Andrei Dulvac (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrei Dulvac reassigned SLING-10868:
-

Assignee: Andrei Dulvac

> Search pattern in getSlingLocation method only works if id is the last 
> attribute
> 
>
> Key: SLING-10868
> URL: https://issues.apache.org/jira/browse/SLING-10868
> Project: Sling
>  Issue Type: Bug
>  Components: Apache Sling Testing Clients
>Reporter: Michael Kitanovski
>    Assignee: Andrei Dulvac
>Priority: Major
>  Labels: sling-IT
> Attachments: response_content.txt
>
>
> The method getSlingLocation in class SlingHttpResponse uses a search pattern 
> which only works if the "id" attribute is the last one. We have implemented a 
> link rewriter transformer in our project which adds a class="internal" to 
> each internal link. In our case now the class attribute is the last one and 
> the method  extractFromHTMLResponse(String searchPattern) will return null 
> because it won't find the the searched string in the content (see attached 
> response_content.txt).
>  
> [https://github.com/apache/sling-org-apache-sling-testing-clients/blob/c8a6d4bd9c3e92a2c00920d86f3d27d58478050e/src/main/java/org/apache/sling/testing/clients/SlingHttpResponse.java#L201]
>  
> The same issue exists for other methods like 
> - getSlingParentLocation()
> - getSlingReferer()
>  
> It seems AEMaaCs uses the aem-test-samples 
> ([https://github.com/adobe/aem-test-samples)] for integration tests during 
> the production pipeline run. One of the tests is using the getSlingLocation 
> method which causes termination of the deployment process.
>  
> [https://github.com/adobe/aem-test-samples/blob/4f7653db344c3f31f4a1a6440bf0f01db75ea382/smoke/src/main/java/com/adobe/cq/cloud/testing/it/smoke/CreatePageAsAuthorUserIT.java#L78]
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Resolved] (SLING-6072) The testing rules do not call CloseableHttpClient.close()

[Andrei Dulvac (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-6072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrei Dulvac resolved SLING-6072.
--
Resolution: Fixed

> The testing rules do not call CloseableHttpClient.close()
> -
>
> Key: SLING-6072
> URL: https://issues.apache.org/jira/browse/SLING-6072
> Project: Sling
>  Issue Type: Bug
>  Components: Apache Sling Testing Clients
>Affects Versions: Apache Sling Testing Clients 1.0.0, Apache Sling Testing 
> Rules 1.0.0
>Reporter: Konrad Windszus
>Assignee: Andrei Dulvac
>Priority: Major
> Fix For: Apache Sling Testing Rules 1.0.1, Apache Sling Testing 
> Clients 1.0.1
>
>
> The rules being provided by the sling testing rules do not automatically call 
> close on the underlying {{ClosableHttpClient}} which is necessary to close 
> the dangling http connections being managed by the underlying connection 
> manager (see 
> https://hc.apache.org/httpcomponents-client-ga/tutorial/html/fundamentals.html#d5e217).
>  Even custom code cannot call close, because the underlying 
> {{ClosableHttpClient}} is not really exposed.
> I guess there is also a change necessary in testing/http/client to expose 
> such a close method as well, and also clarify under which circumstances a new 
> HttpClient is created or when an existing one is reused.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (SLING-6072) The testing rules do not call CloseableHttpClient.close()

[Andrei Dulvac (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-6072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrei Dulvac updated SLING-6072:
-
Fix Version/s: Apache Sling Testing Rules 1.0.1
   Apache Sling Testing Clients 1.0.1

> The testing rules do not call CloseableHttpClient.close()
> -
>
> Key: SLING-6072
> URL: https://issues.apache.org/jira/browse/SLING-6072
> Project: Sling
>  Issue Type: Bug
>  Components: Apache Sling Testing Clients
>Affects Versions: Apache Sling Testing Clients 1.0.0, Apache Sling Testing 
> Rules 1.0.0
>Reporter: Konrad Windszus
>Assignee: Andrei Dulvac
>Priority: Major
> Fix For: Apache Sling Testing Clients 1.0.1, Apache Sling Testing 
> Rules 1.0.1
>
>
> The rules being provided by the sling testing rules do not automatically call 
> close on the underlying {{ClosableHttpClient}} which is necessary to close 
> the dangling http connections being managed by the underlying connection 
> manager (see 
> https://hc.apache.org/httpcomponents-client-ga/tutorial/html/fundamentals.html#d5e217).
>  Even custom code cannot call close, because the underlying 
> {{ClosableHttpClient}} is not really exposed.
> I guess there is also a change necessary in testing/http/client to expose 
> such a close method as well, and also clarify under which circumstances a new 
> HttpClient is created or when an existing one is reused.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Resolved] (SLING-7035) [http.testing.clients] OsgiConsoleClient#editConfigurationWithWait does not wait for bundle to be restarted

[Andrei Dulvac (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-7035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrei Dulvac resolved SLING-7035.
--
Resolution: Cannot Reproduce

> [http.testing.clients] OsgiConsoleClient#editConfigurationWithWait does not 
> wait for bundle to be restarted
> ---
>
> Key: SLING-7035
> URL: https://issues.apache.org/jira/browse/SLING-7035
> Project: Sling
>  Issue Type: Bug
>  Components: Apache Sling Testing Clients
>Affects Versions: Apache Sling Testing Clients 1.1.4
>    Reporter: Andrei Dulvac
>Assignee: Andrei Dulvac
>Priority: Major
>
> https://github.com/apache/sling/blob/trunk/testing/http/clients/src/main/java/org/apache/sling/testing/clients/osgi/OsgiConsoleClient.java#L342
>   doesn't wait for the affected bundle to be restarted. 
> We need a mechanism to wait for the bundle that's restarted after the config 
> change.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Resolved] (SLING-8114) Allow to do polling of code failing on asserts

[Andrei Dulvac (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-8114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrei Dulvac resolved SLING-8114.
--
Resolution: Won't Do

> Allow to do polling of code failing on asserts
> --
>
> Key: SLING-8114
> URL: https://issues.apache.org/jira/browse/SLING-8114
> Project: Sling
>  Issue Type: Improvement
>  Components: Apache Sling Testing Clients
>Affects Versions: Apache Sling Testing Clients 1.2.0
>Reporter: Thierry Ygé
>Priority: Major
>
> Currently if you polling check uses assertions , it will not be retried, this 
> is due to this line
> [https://github.com/apache/sling-org-apache-sling-testing-clients/blob/master/src/main/java/org/apache/sling/testing/clients/util/poller/Polling.java#L118]
> Which is only catching Exceptions while failing Assertions are an error kind 
> (AssertionError).
> It would be nice to handle it so that code wouldn't have to "transform" it to 
> exception.
> To reproduce simply use assertion in your polling check and let it fail if a 
> counter is lower than a value. make the polling retries so that at the next 
> retry counter it should pass.
>  
> {quote}int count = 0;
> new Polling(() -> {  count++;   Assert.assertTrue(count == 2);  return true;  
>        }
> ).poll(2000, 500);
> {quote}
> Observation: it exist the poll directly as the assert fail already.
> Expected: It should have polled until the check pass here.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Resolved] (SLING-9188) Sling Testing Clients does not work on GET with parameters

[Andrei Dulvac (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrei Dulvac resolved SLING-9188.
--
Resolution: Cannot Reproduce

> Sling Testing Clients does not work on GET with parameters
> --
>
> Key: SLING-9188
> URL: https://issues.apache.org/jira/browse/SLING-9188
> Project: Sling
>  Issue Type: Bug
>  Components: Apache Sling Testing Clients
>Affects Versions: Apache Sling Testing Clients 2.0.0
> Environment: Sling 12
>Reporter: Andreas Schaefer
>Priority: Major
>
> There is an issue with Sling Client's doGet() as parameters (?a=b) will cause 
> an error. The question mark is encoded %3F which makes the call fail.
>  
> I created a test project: [https://github.com/schaefa/sling-testing-client-it]
>  
> Run it with: mvn clean install -P it



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Resolved] (SLING-11611) Provide method to retrieve Pid for OSGI Configurations in Sling Testing Clients

[Andrei Dulvac (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-11611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrei Dulvac resolved SLING-11611.
---
Fix Version/s: Apache Sling Testing Clients 3.0.22
   Resolution: Fixed

> Provide method to retrieve Pid for OSGI Configurations in Sling Testing 
> Clients
> ---
>
> Key: SLING-11611
> URL: https://issues.apache.org/jira/browse/SLING-11611
> Project: Sling
>  Issue Type: Improvement
>  Components: Apache Sling Testing Clients
>Affects Versions: Apache Sling Testing Clients 3.0.16
>Reporter: Nicola Scendoni
>Assignee: Andrei Dulvac
>Priority: Minor
> Fix For: Apache Sling Testing Clients 3.0.22
>
>
> During development of IT Tests it may be needed to search the pid for some 
> OSGI Configuration not created by the test itself.
> I will provide an implementation to search the pid of configurations from 
> serviceType and the value of a property.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Resolved] (SLING-11125) SlingClient.exists(...) should use expected status in order to support http retries parameters

[Andrei Dulvac (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-11125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrei Dulvac resolved SLING-11125.
---
Resolution: Not A Bug

> SlingClient.exists(...) should use expected status in order to support http 
> retries parameters
> --
>
> Key: SLING-11125
> URL: https://issues.apache.org/jira/browse/SLING-11125
> Project: Sling
>  Issue Type: Bug
>  Components: Apache Sling Testing Clients
>Affects Versions: Apache Sling Testing Clients 3.0.10
>Reporter: Thierry Ygé
>Priority: Major
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> Currently if tests need to retries on some errors which are likely to happen 
> in clustered setup (AEM in Cloud for example).
> usually the use of 
> "-Dsling.it.http.retriesErrorCodes=401,404,405,429,500,501,503" would include 
> 404 cases.
> The issue is then SlingClient.exists(...) would always fail in case we try to 
> check for "not existing path" as the test would expect also 404 to be 
> returned.
> The current implementation of ServerErrorRetryStrategy support that if the 
> expected values are passed , this would bypass the retriesErrorCodes.
> Thus it would make sense to pass the possible returned code for the request 
> done by SlingClient.exists(...) call.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Created] (SLING-12229) Update jackson-core dependencies

[Andrei Dulvac (Jira)]

Andrei Dulvac created SLING-12229:
-

 Summary: Update jackson-core dependencies
 Key: SLING-12229
 URL: https://issues.apache.org/jira/browse/SLING-12229
 Project: Sling
  Issue Type: Bug
  Components: Apache Sling Testing Clients
Affects Versions: Apache Sling Testing Clients 3.0.20
Reporter: Andrei Dulvac
Assignee: Andrei Dulvac
 Fix For: Apache Sling Testing Clients 3.0.22


jackson-core - 2.13.0, jackson-databind-2.13.2.1, jsoup-1.14.3 need to be 
updated because they cause:
CVE-2022-42003
CVE-2022-42004
CVE-2022-36033



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (SLING-12229) Update jackson and jsoup dependencies

[Andrei Dulvac (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrei Dulvac updated SLING-12229:
--
Summary: Update jackson and jsoup dependencies  (was: Update jackson-core 
dependencies)

> Update jackson and jsoup dependencies
> -
>
> Key: SLING-12229
> URL: https://issues.apache.org/jira/browse/SLING-12229
> Project: Sling
>  Issue Type: Bug
>  Components: Apache Sling Testing Clients
>Affects Versions: Apache Sling Testing Clients 3.0.20
>    Reporter: Andrei Dulvac
>    Assignee: Andrei Dulvac
>Priority: Major
> Fix For: Apache Sling Testing Clients 3.0.22
>
>
> jackson-core - 2.13.0, jackson-databind-2.13.2.1, jsoup-1.14.3 need to be 
> updated because they cause:
> CVE-2022-42003
> CVE-2022-42004
> CVE-2022-36033



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Resolved] (SLING-12096) Testing clients - don't log request headers

[Andrei Dulvac (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrei Dulvac resolved SLING-12096.
---
Fix Version/s: Apache Sling Testing Clients 3.0.22
   Resolution: Fixed

> Testing clients - don't log request headers
> ---
>
> Key: SLING-12096
> URL: https://issues.apache.org/jira/browse/SLING-12096
> Project: Sling
>  Issue Type: Improvement
>  Components: Apache Sling Testing Clients
>Affects Versions: Apache Sling Testing Clients 3.0.16
>Reporter: Marc Pfaff
>    Assignee: Andrei Dulvac
>Priority: Minor
> Fix For: Apache Sling Testing Clients 3.0.22
>
>
> The ServerErrorRetryStrategy used in the testing clients logs when a retry 
> condition is met. 
> I propose to improve this output with more request/response details and retry 
> condition details, in order to help troubleshooting test failures. 
> Current output (example from the unit test):
> {code:java}
> Request retry needed due to service unavailable response
> Response headers contained:
> Header Date:Wed, 11 Jan 2023 08:36:43 GMT
> Header Server:TEST/1.1
> Header Content-Length:8
> Header Content-Type:text/plain; charset=ISO-8859-1
> Header Connection:Keep-Alive
> Response content: TEST_NOK
> {code}
> Proposed improvement (example from the unit test):
> {code:java}
> Request retry condition met: [count=1/4], [expected-codes=[200]], 
> [retry-codes=[500, 503]]
> Request: GET /test/internalerror/resource HTTP/1.1 [Host: 127.0.0.1:32953, 
> Connection: Keep-Alive, User-Agent: Java, Accept-Encoding: gzip,deflate, 
> Authorization: Basic dXNlcjpwYXNz]
> Response: HTTP/1.1 500 Internal Server Error [Date: Wed, 11 Jan 2023 08:39:59 
> GMT, Server: TEST/1.1, Content-Length: 8, Content-Type: text/plain; 
> charset=ISO-8859-1, Connection: Keep-Alive, ]
> {code}
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Resolved] (SLING-11279) Make SlingClient.exists() more resilient with http retries codes

[Andrei Dulvac (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-11279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrei Dulvac resolved SLING-11279.
---
Fix Version/s: Apache Sling Testing Clients 3.0.22
   Resolution: Fixed

> Make SlingClient.exists() more resilient with http retries  codes
> -
>
> Key: SLING-11279
> URL: https://issues.apache.org/jira/browse/SLING-11279
> Project: Sling
>  Issue Type: Improvement
>  Components: Apache Sling Testing Clients
>Affects Versions: Apache Sling Testing Clients 3.0.12
>Reporter: Thierry Ygé
>    Assignee: Andrei Dulvac
>Priority: Major
> Fix For: Apache Sling Testing Clients 3.0.22
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Currently if we are in cluster with affinity cookie and use httpRetries code 
> to retries on 404 to avoid sync problems, the exists() method can be confused 
> for 404 responses. 
> In order to fix it, it need to explicitely list generally expected code that 
> might not need retries in that context.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Resolved] (SLING-11609) Provide doGetWithRetry methods in Sling Testing Clients

[Andrei Dulvac (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-11609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrei Dulvac resolved SLING-11609.
---
Fix Version/s: Apache Sling Testing Clients 3.0.22
 Assignee: Andrei Dulvac  (was: Nicola Scendoni)
   Resolution: Fixed

> Provide doGetWithRetry methods in Sling Testing Clients
> ---
>
> Key: SLING-11609
> URL: https://issues.apache.org/jira/browse/SLING-11609
> Project: Sling
>  Issue Type: Improvement
>  Components: Apache Sling Testing Clients
>Affects Versions: Apache Sling Testing Clients 3.0.16
>Reporter: Nicola Scendoni
>    Assignee: Andrei Dulvac
>Priority: Minor
> Fix For: Apache Sling Testing Clients 3.0.22
>
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> In several situations during IT Tests development we need to retry doGet 
> method until some assertion are verified.
> I propose in the attached pull request an implementation and test for new 
> methods doGetWithRetry



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Assigned] (SLING-11279) Make SlingClient.exists() more resilient with http retries codes

[Andrei Dulvac (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-11279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrei Dulvac reassigned SLING-11279:
-

Assignee: Andrei Dulvac

> Make SlingClient.exists() more resilient with http retries  codes
> -
>
> Key: SLING-11279
> URL: https://issues.apache.org/jira/browse/SLING-11279
> Project: Sling
>  Issue Type: Improvement
>  Components: Apache Sling Testing Clients
>Affects Versions: Apache Sling Testing Clients 3.0.12
>Reporter: Thierry Ygé
>    Assignee: Andrei Dulvac
>Priority: Major
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Currently if we are in cluster with affinity cookie and use httpRetries code 
> to retries on 404 to avoid sync problems, the exists() method can be confused 
> for 404 responses. 
> In order to fix it, it need to explicitely list generally expected code that 
> might not need retries in that context.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Assigned] (SLING-11611) Provide method to retrieve Pid for OSGI Configurations in Sling Testing Clients

[Andrei Dulvac (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-11611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrei Dulvac reassigned SLING-11611:
-

Assignee: Andrei Dulvac  (was: Nicola Scendoni)

> Provide method to retrieve Pid for OSGI Configurations in Sling Testing 
> Clients
> ---
>
> Key: SLING-11611
> URL: https://issues.apache.org/jira/browse/SLING-11611
> Project: Sling
>  Issue Type: Improvement
>  Components: Apache Sling Testing Clients
>Affects Versions: Apache Sling Testing Clients 3.0.16
>Reporter: Nicola Scendoni
>Assignee: Andrei Dulvac
>Priority: Minor
>
> During development of IT Tests it may be needed to search the pid for some 
> OSGI Configuration not created by the test itself.
> I will provide an implementation to search the pid of configurations from 
> serviceType and the value of a property.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[RESULT] [VOTE] Release Apache Sling Testing Clients version 3.0.20

[Andrei Dulvac]

Hi,

The vote has passed with the following result :

+1 (binding): Robert, Daniel, Stefan, Andrei
+1 (non binding): none

I will copy this release to the Sling dist directory and
promote the artifacts to the central Maven repository.

Cheers,
- Andrei

On Fri, Oct 13, 2023 at 11:40 AM Andrei Dulvac  wrote:

> Hi Stefan.
>
> Thanks for pointing it out. I resolved SLING-11748 and should now be in
> the list.
> I probably should've cleaned up that ticket and dealt with the other PR
> before cutting this release. But we can do it with the next one.
>
> With that being said, here's my +1 for this release.
>
> - Andrei
>
> On Wed, Oct 11, 2023 at 12:44 PM Stefan Seifert
>  wrote:
>
>> +1
>>
>> please note that the ticket SLING-11748 is missing from the changelog.
>>
>> for SLING-11748 also a new PR is proposed [1], which completely changes
>> the approach and removes the logging of headers completely (for security
>> reasons). i assume that's not a blocker for this release, but a new ticket
>> should be created for this new PR.
>>
>> stefan
>>
>> [1]
>> https://github.com/apache/sling-org-apache-sling-testing-clients/pull/43
>>
>>
>> > -Original Message-
>> > From: Andrei Dulvac 
>> > Sent: Monday, October 9, 2023 5:44 PM
>> > To: dev@sling.apache.org
>> > Subject: [VOTE] Release Apache Sling Testing Clients version 3.0.20
>> >
>> > Hi,
>> >
>> > We solved 1 issue in this release:
>> > https://issues.apache.org/jira/projects/SLING/versions/12353697
>> >
>> > Staging repository:
>> > https://repository.apache.org/content/repositories/orgapachesling-2794/
>> >
>> > You can use this UNIX script to download the release and verify the
>> > signatures:
>> > https://raw.githubusercontent.com/apache/sling-tooling-
>> > release/master/check_staged_release.sh
>> >
>> > Usage:
>> > sh check_staged_release.sh 2794 /tmp/sling-staging
>> >
>> > Please vote to approve this release:
>> >
>> >   [ ] +1 Approve the release
>> >   [ ]  0 Don't care
>> >   [ ] -1 Don't release, because ...
>> >
>> > This majority vote is open for at least 72 hours.
>> >
>> > Cheers,
>>
>

[jira] [Updated] (SLING-12096) Testing clients - don't log request headers

[Andrei Dulvac (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrei Dulvac updated SLING-12096:
--
Fix Version/s: (was: Apache Sling Testing Clients 3.0.20)

> Testing clients - don't log request headers
> ---
>
> Key: SLING-12096
> URL: https://issues.apache.org/jira/browse/SLING-12096
> Project: Sling
>  Issue Type: Improvement
>  Components: Apache Sling Testing Clients
>Affects Versions: Apache Sling Testing Clients 3.0.16
>Reporter: Marc Pfaff
>    Assignee: Andrei Dulvac
>Priority: Minor
>
> The ServerErrorRetryStrategy used in the testing clients logs when a retry 
> condition is met. 
> I propose to improve this output with more request/response details and retry 
> condition details, in order to help troubleshooting test failures. 
> Current output (example from the unit test):
> {code:java}
> Request retry needed due to service unavailable response
> Response headers contained:
> Header Date:Wed, 11 Jan 2023 08:36:43 GMT
> Header Server:TEST/1.1
> Header Content-Length:8
> Header Content-Type:text/plain; charset=ISO-8859-1
> Header Connection:Keep-Alive
> Response content: TEST_NOK
> {code}
> Proposed improvement (example from the unit test):
> {code:java}
> Request retry condition met: [count=1/4], [expected-codes=[200]], 
> [retry-codes=[500, 503]]
> Request: GET /test/internalerror/resource HTTP/1.1 [Host: 127.0.0.1:32953, 
> Connection: Keep-Alive, User-Agent: Java, Accept-Encoding: gzip,deflate, 
> Authorization: Basic dXNlcjpwYXNz]
> Response: HTTP/1.1 500 Internal Server Error [Date: Wed, 11 Jan 2023 08:39:59 
> GMT, Server: TEST/1.1, Content-Length: 8, Content-Type: text/plain; 
> charset=ISO-8859-1, Connection: Keep-Alive, ]
> {code}
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (SLING-12096) Testing clients - don't log request headers

[Andrei Dulvac (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrei Dulvac updated SLING-12096:
--
Affects Version/s: Apache Sling Testing Clients 3.0.16
   (was: Apache Sling Testing Clients 3.0.20)

> Testing clients - don't log request headers
> ---
>
> Key: SLING-12096
> URL: https://issues.apache.org/jira/browse/SLING-12096
> Project: Sling
>  Issue Type: Improvement
>  Components: Apache Sling Testing Clients
>Affects Versions: Apache Sling Testing Clients 3.0.16
>Reporter: Marc Pfaff
>    Assignee: Andrei Dulvac
>Priority: Minor
> Fix For: Apache Sling Testing Clients 3.0.20
>
>
> The ServerErrorRetryStrategy used in the testing clients logs when a retry 
> condition is met. 
> I propose to improve this output with more request/response details and retry 
> condition details, in order to help troubleshooting test failures. 
> Current output (example from the unit test):
> {code:java}
> Request retry needed due to service unavailable response
> Response headers contained:
> Header Date:Wed, 11 Jan 2023 08:36:43 GMT
> Header Server:TEST/1.1
> Header Content-Length:8
> Header Content-Type:text/plain; charset=ISO-8859-1
> Header Connection:Keep-Alive
> Response content: TEST_NOK
> {code}
> Proposed improvement (example from the unit test):
> {code:java}
> Request retry condition met: [count=1/4], [expected-codes=[200]], 
> [retry-codes=[500, 503]]
> Request: GET /test/internalerror/resource HTTP/1.1 [Host: 127.0.0.1:32953, 
> Connection: Keep-Alive, User-Agent: Java, Accept-Encoding: gzip,deflate, 
> Authorization: Basic dXNlcjpwYXNz]
> Response: HTTP/1.1 500 Internal Server Error [Date: Wed, 11 Jan 2023 08:39:59 
> GMT, Server: TEST/1.1, Content-Length: 8, Content-Type: text/plain; 
> charset=ISO-8859-1, Connection: Keep-Alive, ]
> {code}
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (SLING-12096) Testing clients - don't log request headers

[Andrei Dulvac (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrei Dulvac updated SLING-12096:
--
Affects Version/s: Apache Sling Testing Clients 3.0.20
   (was: Apache Sling Testing Clients 3.0.16)

> Testing clients - don't log request headers
> ---
>
> Key: SLING-12096
> URL: https://issues.apache.org/jira/browse/SLING-12096
> Project: Sling
>  Issue Type: Improvement
>  Components: Apache Sling Testing Clients
>Affects Versions: Apache Sling Testing Clients 3.0.20
>Reporter: Marc Pfaff
>    Assignee: Andrei Dulvac
>Priority: Minor
> Fix For: Apache Sling Testing Clients 3.0.20
>
>
> The ServerErrorRetryStrategy used in the testing clients logs when a retry 
> condition is met. 
> I propose to improve this output with more request/response details and retry 
> condition details, in order to help troubleshooting test failures. 
> Current output (example from the unit test):
> {code:java}
> Request retry needed due to service unavailable response
> Response headers contained:
> Header Date:Wed, 11 Jan 2023 08:36:43 GMT
> Header Server:TEST/1.1
> Header Content-Length:8
> Header Content-Type:text/plain; charset=ISO-8859-1
> Header Connection:Keep-Alive
> Response content: TEST_NOK
> {code}
> Proposed improvement (example from the unit test):
> {code:java}
> Request retry condition met: [count=1/4], [expected-codes=[200]], 
> [retry-codes=[500, 503]]
> Request: GET /test/internalerror/resource HTTP/1.1 [Host: 127.0.0.1:32953, 
> Connection: Keep-Alive, User-Agent: Java, Accept-Encoding: gzip,deflate, 
> Authorization: Basic dXNlcjpwYXNz]
> Response: HTTP/1.1 500 Internal Server Error [Date: Wed, 11 Jan 2023 08:39:59 
> GMT, Server: TEST/1.1, Content-Length: 8, Content-Type: text/plain; 
> charset=ISO-8859-1, Connection: Keep-Alive, ]
> {code}
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Created] (SLING-12096) Testing clients - don't log request headers

[Andrei Dulvac (Jira)]

Andrei Dulvac created SLING-12096:
-

 Summary: Testing clients - don't log request headers
 Key: SLING-12096
 URL: https://issues.apache.org/jira/browse/SLING-12096
 Project: Sling
  Issue Type: Improvement
  Components: Apache Sling Testing Clients
Affects Versions: Apache Sling Testing Clients 3.0.16
Reporter: Marc Pfaff
Assignee: Andrei Dulvac
 Fix For: Apache Sling Testing Clients 3.0.20


The ServerErrorRetryStrategy used in the testing clients logs when a retry 
condition is met. 

I propose to improve this output with more request/response details and retry 
condition details, in order to help troubleshooting test failures. 

Current output (example from the unit test):
{code:java}
Request retry needed due to service unavailable response
Response headers contained:
Header Date:Wed, 11 Jan 2023 08:36:43 GMT
Header Server:TEST/1.1
Header Content-Length:8
Header Content-Type:text/plain; charset=ISO-8859-1
Header Connection:Keep-Alive
Response content: TEST_NOK
{code}
Proposed improvement (example from the unit test):
{code:java}
Request retry condition met: [count=1/4], [expected-codes=[200]], 
[retry-codes=[500, 503]]
Request: GET /test/internalerror/resource HTTP/1.1 [Host: 127.0.0.1:32953, 
Connection: Keep-Alive, User-Agent: Java, Accept-Encoding: gzip,deflate, 
Authorization: Basic dXNlcjpwYXNz]
Response: HTTP/1.1 500 Internal Server Error [Date: Wed, 11 Jan 2023 08:39:59 
GMT, Server: TEST/1.1, Content-Length: 8, Content-Type: text/plain; 
charset=ISO-8859-1, Connection: Keep-Alive, ]
{code}
 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [VOTE] Release Apache Sling Testing Clients version 3.0.20

[Andrei Dulvac]

Hi Stefan.

Thanks for pointing it out. I resolved SLING-11748 and should now be in the
list.
I probably should've cleaned up that ticket and dealt with the other PR
before cutting this release. But we can do it with the next one.

With that being said, here's my +1 for this release.

- Andrei

On Wed, Oct 11, 2023 at 12:44 PM Stefan Seifert
 wrote:

> +1
>
> please note that the ticket SLING-11748 is missing from the changelog.
>
> for SLING-11748 also a new PR is proposed [1], which completely changes
> the approach and removes the logging of headers completely (for security
> reasons). i assume that's not a blocker for this release, but a new ticket
> should be created for this new PR.
>
> stefan
>
> [1]
> https://github.com/apache/sling-org-apache-sling-testing-clients/pull/43
>
>
> > -Original Message-
> > From: Andrei Dulvac 
> > Sent: Monday, October 9, 2023 5:44 PM
> > To: dev@sling.apache.org
> > Subject: [VOTE] Release Apache Sling Testing Clients version 3.0.20
> >
> > Hi,
> >
> > We solved 1 issue in this release:
> > https://issues.apache.org/jira/projects/SLING/versions/12353697
> >
> > Staging repository:
> > https://repository.apache.org/content/repositories/orgapachesling-2794/
> >
> > You can use this UNIX script to download the release and verify the
> > signatures:
> > https://raw.githubusercontent.com/apache/sling-tooling-
> > release/master/check_staged_release.sh
> >
> > Usage:
> > sh check_staged_release.sh 2794 /tmp/sling-staging
> >
> > Please vote to approve this release:
> >
> >   [ ] +1 Approve the release
> >   [ ]  0 Don't care
> >   [ ] -1 Don't release, because ...
> >
> > This majority vote is open for at least 72 hours.
> >
> > Cheers,
>

[jira] [Resolved] (SLING-11748) Improve logging output of HTTP retries in testing clients

[Andrei Dulvac (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-11748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrei Dulvac resolved SLING-11748.
---
Fix Version/s: Apache Sling Testing Clients 3.0.20
 Assignee: Andrei Dulvac
   Resolution: Fixed

> Improve logging output of HTTP retries in testing clients
> -
>
> Key: SLING-11748
> URL: https://issues.apache.org/jira/browse/SLING-11748
> Project: Sling
>  Issue Type: Improvement
>  Components: Apache Sling Testing Clients
>Affects Versions: Apache Sling Testing Clients 3.0.16
>Reporter: Marc Pfaff
>    Assignee: Andrei Dulvac
>Priority: Minor
> Fix For: Apache Sling Testing Clients 3.0.20
>
>  Time Spent: 2.5h
>  Remaining Estimate: 0h
>
> The ServerErrorRetryStrategy used in the testing clients logs when a retry 
> condition is met. 
> I propose to improve this output with more request/response details and retry 
> condition details, in order to help troubleshooting test failures. 
> Current output (example from the unit test):
> {code:java}
> Request retry needed due to service unavailable response
> Response headers contained:
> Header Date:Wed, 11 Jan 2023 08:36:43 GMT
> Header Server:TEST/1.1
> Header Content-Length:8
> Header Content-Type:text/plain; charset=ISO-8859-1
> Header Connection:Keep-Alive
> Response content: TEST_NOK
> {code}
> Proposed improvement (example from the unit test):
> {code:java}
> Request retry condition met: [count=1/4], [expected-codes=[200]], 
> [retry-codes=[500, 503]]
> Request: GET /test/internalerror/resource HTTP/1.1 [Host: 127.0.0.1:32953, 
> Connection: Keep-Alive, User-Agent: Java, Accept-Encoding: gzip,deflate, 
> Authorization: Basic dXNlcjpwYXNz]
> Response: HTTP/1.1 500 Internal Server Error [Date: Wed, 11 Jan 2023 08:39:59 
> GMT, Server: TEST/1.1, Content-Length: 8, Content-Type: text/plain; 
> charset=ISO-8859-1, Connection: Keep-Alive, ]
> {code}
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[VOTE] Release Apache Sling Testing Clients version 3.0.20

[Andrei Dulvac]

Hi,

We solved 1 issue in this release:
https://issues.apache.org/jira/projects/SLING/versions/12353697

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2794/

You can use this UNIX script to download the release and verify the
signatures:
https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh

Usage:
sh check_staged_release.sh 2794 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Cheers,

Re: [Vote] Release Apache Sling Event 4.3.14

[Andrei Dulvac]

+1

Andrei

On Mon, Oct 9, 2023 at 5:15 PM Stefan Egli  wrote:

> Thx for the heads-up Daniel!
>
> Could be another case of SLING-12078 - added a 2sec temporary startup
> delay there as well, let's see
> if that fixes things (to be removed once we fix SLING-12078)
>
> Cheers,
> Stefan
>
> On 09.10.23 16:32, Daniel Klco wrote:
> > Thanks for checking Robert!
> >
> > +1
> >
> > On Mon, Oct 9, 2023 at 10:28 AM Robert Munteanu 
> wrote:
> >>
> >> On Mon, 2023-10-09 at 10:16 -0400, Daniel Klco wrote:
> >>> Is there a concern that an IT on the Windows Java 17 build timed out?
> >>>
> https://ci-builds.apache.org/blue/organizations/jenkins/Sling%2Fmodules%2Fsling-org-apache-sling-event/detail/master/230/pipeline/61
> >>>
> >>
> >> I see that the latest build passed
> >>
> >>
> https://ci-builds.apache.org/blue/organizations/jenkins/Sling%2Fmodules%2Fsling-org-apache-sling-event/detail/master/232/pipeline
> >>
> >> It also passed for me locally (Java 17, Linux) so I would classify this
> >> as a flaky test.
> >>
> >> Robert
>

[jira] [Resolved] (SLING-12086) apache sling testing clients: HttpClientBuilder does not honor useSystemProperties

[Andrei Dulvac (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrei Dulvac resolved SLING-12086.
---
Resolution: Fixed

> apache sling testing clients: HttpClientBuilder does not honor 
> useSystemProperties
> --
>
> Key: SLING-12086
> URL: https://issues.apache.org/jira/browse/SLING-12086
> Project: Sling
>  Issue Type: Bug
>  Components: Apache Sling Testing Clients
>Affects Versions: Apache Sling Testing Clients 3.0.18
>Reporter: Andres Bott
>Assignee: Andrei Dulvac
>Priority: Minor
> Fix For: Apache Sling Testing Clients 3.0.20
>
>
> When trying to use system properties to configure a proxy, the Apache sling 
> testing clients httpclient do not always honor the system properties read 
> proxy configuration.
> e.g. 
> https://github.com/apache/sling-org-apache-sling-testing-clients/blob/master/src/main/java/org/apache/sling/testing/clients/interceptors/FormBasedAuthInterceptor.java#L135



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Assigned] (SLING-12086) apache sling testing clients: HttpClientBuilder does not honor useSystemProperties

[Andrei Dulvac (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrei Dulvac reassigned SLING-12086:
-

Assignee: Andrei Dulvac

> apache sling testing clients: HttpClientBuilder does not honor 
> useSystemProperties
> --
>
> Key: SLING-12086
> URL: https://issues.apache.org/jira/browse/SLING-12086
> Project: Sling
>  Issue Type: Bug
>  Components: Apache Sling Testing Clients
>Affects Versions: Apache Sling Testing Clients 3.0.18
>Reporter: Andres Bott
>Assignee: Andrei Dulvac
>Priority: Minor
> Fix For: Apache Sling Testing Clients 3.0.20
>
>
> When trying to use system properties to configure a proxy, the Apache sling 
> testing clients httpclient do not always honor the system properties read 
> proxy configuration.
> e.g. 
> https://github.com/apache/sling-org-apache-sling-testing-clients/blob/master/src/main/java/org/apache/sling/testing/clients/interceptors/FormBasedAuthInterceptor.java#L135



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (SLING-12086) apache sling testing clients: HttpClientBuilder does not honor useSystemProperties

[Andrei Dulvac (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrei Dulvac updated SLING-12086:
--
Fix Version/s: Apache Sling Testing Clients 3.0.20

> apache sling testing clients: HttpClientBuilder does not honor 
> useSystemProperties
> --
>
> Key: SLING-12086
> URL: https://issues.apache.org/jira/browse/SLING-12086
> Project: Sling
>  Issue Type: Bug
>  Components: Apache Sling Testing Clients
>Affects Versions: Apache Sling Testing Clients 3.0.18
>Reporter: Andres Bott
>Priority: Minor
> Fix For: Apache Sling Testing Clients 3.0.20
>
>
> When trying to use system properties to configure a proxy, the Apache sling 
> testing clients httpclient do not always honor the system properties read 
> proxy configuration.
> e.g. 
> https://github.com/apache/sling-org-apache-sling-testing-clients/blob/master/src/main/java/org/apache/sling/testing/clients/interceptors/FormBasedAuthInterceptor.java#L135



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [Vote] Release Sling Testing Clients 3.0.18

[Andrei Dulvac]

+1

Andrei

On Wed, 30 Nov 2022 at 10:58, Jörg Hoh 
wrote:

> +1
>
>
> Am Mi., 30. Nov. 2022 um 10:57 Uhr schrieb Jörg Hoh <
> jhoh...@googlemail.com
> >:
>
> > We solved 1 issue in this release:
> https://issues.apache.org/jira/projects/SLING/versions/12352343
> >
> >
> > Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-2700/
> >
> > You can use this UNIX script to download the release and verify the
> signatures:
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
> >
> > Usage:
> > sh check_staged_release.sh 2700 /tmp/sling-staging
> >
> > Please vote to approve this release:
> >
> >   [ ] +1 Approve the release
> >   [ ]  0 Don't care
> >   [ ] -1 Don't release, because ...
> >
> > This majority vote is open for at least 72 hours.
> >
> >
> >
> > --
> > Cheers,
> > Jörg Hoh,
> >
> > https://cqdump.joerghoh.de
> > Twitter: @joerghoh
> >
>
>
> --
> Cheers,
> Jörg Hoh,
>
> https://cqdump.joerghoh.de
> Twitter: @joerghoh
>

[jira] [Resolved] (SLING-11679) Set more descriptive User-Agent for SlingClients

[Andrei Dulvac (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-11679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrei Dulvac resolved SLING-11679.
---
Resolution: Fixed

> Set more descriptive User-Agent for SlingClients
> 
>
> Key: SLING-11679
> URL: https://issues.apache.org/jira/browse/SLING-11679
> Project: Sling
>  Issue Type: Improvement
>  Components: Apache Sling Testing Clients
>Affects Versions: Apache Sling Testing Clients 3.0.16
>    Reporter: Andrei Dulvac
>    Assignee: Andrei Dulvac
>Priority: Major
> Fix For: Apache Sling Testing Clients 3.0.18
>
>  Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> Customize and change the User-Agent header used by the http clients. The 
> default User-Agent may be changed or it may be replaced or appended per test.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Created] (SLING-11679) Set more descriptive User-Agent for SlingClients

[Andrei Dulvac (Jira)]

Andrei Dulvac created SLING-11679:
-

 Summary: Set more descriptive User-Agent for SlingClients
 Key: SLING-11679
 URL: https://issues.apache.org/jira/browse/SLING-11679
 Project: Sling
  Issue Type: Improvement
  Components: Apache Sling Testing Clients
Affects Versions: Apache Sling Testing Clients 3.0.16
Reporter: Andrei Dulvac
Assignee: Andrei Dulvac
 Fix For: Apache Sling Testing Clients 3.0.18


Customize and change the User-Agent header used by the http clients. The 
default User-Agent may be changed or it may be replaced or appended per test.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[RESULT] [VOTE] Release Apache Sling Testing Clients version 3.0.12

[Andrei Dulvac]

Hi, The vote has passed with the following result : +1 (binding): Carsten,
Radu, Daniel, Stefan +1 (non binding): none
-1: none I will copy this release to the Sling dist directory and promote
the artifacts to the central Maven repository.

- Andrei

[VOTE] Release Apache Sling Testing Clients version 3.0.12

[Andrei Dulvac]

Hi,

It's me again... We resolved another ticket and we have to make another
release.

We solved 1 issues in this release:
https://issues.apache.org/jira/projects/SLING/versions/12351325

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2597

You can use this UNIX script to download the release and verify the
signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2597 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

[jira] [Resolved] (SLING-11131) Update Apache HTTP Client Dependency for CVE-2020-13956

[Andrei Dulvac (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-11131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrei Dulvac resolved SLING-11131.
---
Resolution: Fixed

Fixed by 
https://github.com/apache/sling-org-apache-sling-testing-clients/commit/3e677d306d0ee7e807bcb3dc4c4b8634681f28ac
 

> Update Apache HTTP Client Dependency for CVE-2020-13956
> ---
>
> Key: SLING-11131
> URL: https://issues.apache.org/jira/browse/SLING-11131
> Project: Sling
>  Issue Type: Task
>  Components: Apache Sling Testing Clients
>Affects Versions: Apache Sling Testing Clients 3.0.10
>Reporter: Andrei Tuicu
>    Assignee: Andrei Dulvac
>Priority: Major
> Fix For: Apache Sling Testing Clients 3.0.12
>
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> org.apache.httpcomponents.httpclient 4.4.1 is vulnerable to 
> CVE-2020-13956(MEDIUM)[0].
> We need to update to the latest version of the Apache HTP Client 4.5.13. 
> [0] https://www.cvedetails.com/cve/CVE-2020-13956/



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Updated] (SLING-11131) Update Apache HTTP Client Dependency for CVE-2020-13956

[Andrei Dulvac (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-11131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrei Dulvac updated SLING-11131:
--
Fix Version/s: Apache Sling Testing Clients 3.0.12

> Update Apache HTTP Client Dependency for CVE-2020-13956
> ---
>
> Key: SLING-11131
> URL: https://issues.apache.org/jira/browse/SLING-11131
> Project: Sling
>  Issue Type: Task
>  Components: Apache Sling Testing Clients
>Affects Versions: Apache Sling Testing Clients 3.0.10
>Reporter: Andrei Tuicu
>    Assignee: Andrei Dulvac
>Priority: Major
> Fix For: Apache Sling Testing Clients 3.0.12
>
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> org.apache.httpcomponents.httpclient 4.4.1 is vulnerable to 
> CVE-2020-13956(MEDIUM)[0].
> We need to update to the latest version of the Apache HTP Client 4.5.13. 
> [0] https://www.cvedetails.com/cve/CVE-2020-13956/



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[RESULT] [VOTE] Release Apache Sling Testing Clients version 3.0.10

[Andrei Dulvac]

Hi, The vote has passed with the following result : +1 (binding): Carsten,
Robert, Radu, Daniel, Stefan +1 (non binding): none
-1: none
I will copy this release to the Sling dist directory and promote the
artifacts to the central Maven repository.

- Andrei

[jira] [Assigned] (SLING-11131) Update Apache HTTP Client Dependency for CVE-2020-13956

[Andrei Dulvac (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-11131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrei Dulvac reassigned SLING-11131:
-

Assignee: Andrei Dulvac

> Update Apache HTTP Client Dependency for CVE-2020-13956
> ---
>
> Key: SLING-11131
> URL: https://issues.apache.org/jira/browse/SLING-11131
> Project: Sling
>  Issue Type: Task
>  Components: Apache Sling Testing Clients
>Affects Versions: Apache Sling Testing Clients 3.0.10
>Reporter: Andrei Tuicu
>    Assignee: Andrei Dulvac
>Priority: Major
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> org.apache.httpcomponents.httpclient 4.4.1 is vulnerable to 
> CVE-2020-13956(MEDIUM)[0].
> We need to update to the latest version of the Apache HTP Client 4.5.13. 
> [0] https://www.cvedetails.com/cve/CVE-2020-13956/



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[VOTE] Release Apache Sling Testing Clients version 3.0.10

[Andrei Dulvac]

We solved 1 issues in this release:
https://issues.apache.org/jira/projects/SLING/versions/12351312

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2594

You can use this UNIX script to download the release and verify the
signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2594 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

[CANCELLED][VOTE] Release Apache Sling Testing Clients version 3.0.8

[Andrei Dulvac]

Hi all.

Following the discussion in the comments on
https://issues.apache.org/jira/browse/SLING-11124 I decided to cancel this
release and will soon start a vote again with a new version.

- Andrei

On Mon, Feb 7, 2022 at 10:44 AM Andrei Dulvac  wrote:

> Here's my +1
> - Andrei
>
> On Fri, Feb 4, 2022 at 5:42 PM Andrei Dulvac  wrote:
>
>>
>> We solved 1 issues in this release:
>> https://issues.apache.org/jira/projects/SLING/versions/12351312
>> <https://issues.apache.org/jira/projects/SLING/versions/12351312>
>> Staging repository:
>> https://repository.apache.org/content/repositories/orgapachesling-2593
>> <https://repository.apache.org/content/repositories/orgapachesling-2593>
>> You can use this UNIX script to download the release and verify the
>> signatures:
>>
>> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
>>
>> Usage:
>> sh check_staged_release.sh 2593 /tmp/sling-staging
>>
>> Please vote to approve this release:
>>
>>   [ ] +1 Approve the release
>>   [ ]  0 Don't care
>>   [ ] -1 Don't release, because ...
>>
>> This majority vote is open for at least 72 hours.
>>
>

[jira] [Commented] (SLING-11124) Update Guava Dependency for CVE CVE-2018-10237 and CVE-2020-8908

[Andrei Dulvac (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-11124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17488087#comment-17488087
 ] 

Andrei Dulvac commented on SLING-11124:
---

bq. I prefer to rather remove that guava dependency alltogether

That actually makes sense in this particular case, I agree

> Update Guava Dependency for CVE CVE-2018-10237 and CVE-2020-8908
> 
>
> Key: SLING-11124
> URL: https://issues.apache.org/jira/browse/SLING-11124
> Project: Sling
>  Issue Type: Task
>  Components: Apache Sling Testing Clients
>Affects Versions: Apache Sling Testing Clients 3.0.8
>Reporter: Andrei Tuicu
>    Assignee: Andrei Dulvac
>Priority: Major
> Fix For: Apache Sling Testing Clients 3.0.8
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> Sling testing clients are using com.google.guava guava 14.0.1 which is 
> vulnerable to CVE-2018-10237(MEDIUM) [1] and CVE-2020-8908(LOW) [2].
> Mitigation: update to latest guava 31.0.1-android
> [1] https://www.cvedetails.com/cve/CVE-2018-10237/
> [2] https://www.cvedetails.com/cve/CVE-2020-8908/



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Re: [VOTE] Release Apache Sling Testing Clients version 3.0.8

[Andrei Dulvac]

Here's my +1
- Andrei

On Fri, Feb 4, 2022 at 5:42 PM Andrei Dulvac  wrote:

>
> We solved 1 issues in this release:
> https://issues.apache.org/jira/projects/SLING/versions/12351312
> <https://issues.apache.org/jira/projects/SLING/versions/12351312>
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-2593
> <https://repository.apache.org/content/repositories/orgapachesling-2593>
> You can use this UNIX script to download the release and verify the
> signatures:
>
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
>
> Usage:
> sh check_staged_release.sh 2593 /tmp/sling-staging
>
> Please vote to approve this release:
>
>   [ ] +1 Approve the release
>   [ ]  0 Don't care
>   [ ] -1 Don't release, because ...
>
> This majority vote is open for at least 72 hours.
>

[jira] [Commented] (SLING-11124) Update Guava Dependency for CVE CVE-2018-10237 and CVE-2020-8908

[Andrei Dulvac (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-11124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17487995#comment-17487995
 ] 

Andrei Dulvac commented on SLING-11124:
---

[~enorman], Thanks for pointing that out. I haven't tested it either with oak, 
but the reality is this is almost exclusively (I don't know of a use-case where 
it isn't) used as a client-side library in automated tests, even though we 
package it as an osgi bundle. Also, I think that shouldn't matter anyway, as 
dependencies in the testing clients bundle are embedded.



> Update Guava Dependency for CVE CVE-2018-10237 and CVE-2020-8908
> 
>
> Key: SLING-11124
> URL: https://issues.apache.org/jira/browse/SLING-11124
> Project: Sling
>  Issue Type: Task
>  Components: Apache Sling Testing Clients
>Affects Versions: Apache Sling Testing Clients 3.0.8
>Reporter: Andrei Tuicu
>    Assignee: Andrei Dulvac
>Priority: Major
> Fix For: Apache Sling Testing Clients 3.0.8
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> Sling testing clients are using com.google.guava guava 14.0.1 which is 
> vulnerable to CVE-2018-10237(MEDIUM) [1] and CVE-2020-8908(LOW) [2].
> Mitigation: update to latest guava 31.0.1-android
> [1] https://www.cvedetails.com/cve/CVE-2018-10237/
> [2] https://www.cvedetails.com/cve/CVE-2020-8908/



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[VOTE] Release Apache Sling Testing Clients version 3.0.8

[Andrei Dulvac]

We solved 1 issues in this release:
https://issues.apache.org/jira/projects/SLING/versions/12351312

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2593

You can use this UNIX script to download the release and verify the
signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2593 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

[jira] [Updated] (SLING-11124) Update Guava Dependency for CVE CVE-2018-10237 and CVE-2020-8908

[Andrei Dulvac (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-11124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrei Dulvac updated SLING-11124:
--
Affects Version/s: Apache Sling Testing Clients 3.0.8
   (was: Apache Sling Testing Clients 3.0.6)

> Update Guava Dependency for CVE CVE-2018-10237 and CVE-2020-8908
> 
>
> Key: SLING-11124
> URL: https://issues.apache.org/jira/browse/SLING-11124
> Project: Sling
>  Issue Type: Task
>  Components: Apache Sling Testing Clients
>Affects Versions: Apache Sling Testing Clients 3.0.8
>Reporter: Andrei Tuicu
>    Assignee: Andrei Dulvac
>Priority: Major
> Fix For: Apache Sling Testing Clients 3.0.6
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> Sling testing clients are using com.google.guava guava 14.0.1 which is 
> vulnerable to CVE-2018-10237(MEDIUM) [1] and CVE-2020-8908(LOW) [2].
> Mitigation: update to latest guava 31.0.1-android
> [1] https://www.cvedetails.com/cve/CVE-2018-10237/
> [2] https://www.cvedetails.com/cve/CVE-2020-8908/



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Updated] (SLING-11124) Update Guava Dependency for CVE CVE-2018-10237 and CVE-2020-8908

[Andrei Dulvac (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-11124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrei Dulvac updated SLING-11124:
--
Fix Version/s: Apache Sling Testing Clients 3.0.8
   (was: Apache Sling Testing Clients 3.0.6)

> Update Guava Dependency for CVE CVE-2018-10237 and CVE-2020-8908
> 
>
> Key: SLING-11124
> URL: https://issues.apache.org/jira/browse/SLING-11124
> Project: Sling
>  Issue Type: Task
>  Components: Apache Sling Testing Clients
>Affects Versions: Apache Sling Testing Clients 3.0.8
>Reporter: Andrei Tuicu
>    Assignee: Andrei Dulvac
>Priority: Major
> Fix For: Apache Sling Testing Clients 3.0.8
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> Sling testing clients are using com.google.guava guava 14.0.1 which is 
> vulnerable to CVE-2018-10237(MEDIUM) [1] and CVE-2020-8908(LOW) [2].
> Mitigation: update to latest guava 31.0.1-android
> [1] https://www.cvedetails.com/cve/CVE-2018-10237/
> [2] https://www.cvedetails.com/cve/CVE-2020-8908/



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Resolved] (SLING-11124) Update Guava Dependency for CVE CVE-2018-10237 and CVE-2020-8908

[Andrei Dulvac (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-11124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrei Dulvac resolved SLING-11124.
---
Fix Version/s: Apache Sling Testing Clients 3.0.6
   Resolution: Fixed

> Update Guava Dependency for CVE CVE-2018-10237 and CVE-2020-8908
> 
>
> Key: SLING-11124
> URL: https://issues.apache.org/jira/browse/SLING-11124
> Project: Sling
>  Issue Type: Task
>  Components: Apache Sling Testing Clients
>Affects Versions: Apache Sling Testing Clients 3.0.6
>Reporter: Andrei Tuicu
>    Assignee: Andrei Dulvac
>Priority: Major
> Fix For: Apache Sling Testing Clients 3.0.6
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> Sling testing clients are using com.google.guava guava 14.0.1 which is 
> vulnerable to CVE-2018-10237(MEDIUM) [1] and CVE-2020-8908(LOW) [2].
> Mitigation: update to latest guava 31.0.1-android
> [1] https://www.cvedetails.com/cve/CVE-2018-10237/
> [2] https://www.cvedetails.com/cve/CVE-2020-8908/



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Commented] (SLING-11124) Update Guava Dependency for CVE CVE-2018-10237 and CVE-2020-8908

[Andrei Dulvac (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-11124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17487166#comment-17487166
 ] 

Andrei Dulvac commented on SLING-11124:
---

Merged in 
https://github.com/apache/sling-org-apache-sling-testing-clients/pull/25

> Update Guava Dependency for CVE CVE-2018-10237 and CVE-2020-8908
> 
>
> Key: SLING-11124
> URL: https://issues.apache.org/jira/browse/SLING-11124
> Project: Sling
>  Issue Type: Task
>  Components: Apache Sling Testing Clients
>Affects Versions: Apache Sling Testing Clients 3.0.6
>Reporter: Andrei Tuicu
>    Assignee: Andrei Dulvac
>Priority: Major
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> Sling testing clients are using com.google.guava guava 14.0.1 which is 
> vulnerable to CVE-2018-10237(MEDIUM) [1] and CVE-2020-8908(LOW) [2].
> Mitigation: update to latest guava 31.0.1-android
> [1] https://www.cvedetails.com/cve/CVE-2018-10237/
> [2] https://www.cvedetails.com/cve/CVE-2020-8908/



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Assigned] (SLING-11124) Update Guava Dependency for CVE CVE-2018-10237 and CVE-2020-8908

[Andrei Dulvac (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-11124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrei Dulvac reassigned SLING-11124:
-

Assignee: Andrei Dulvac

> Update Guava Dependency for CVE CVE-2018-10237 and CVE-2020-8908
> 
>
> Key: SLING-11124
> URL: https://issues.apache.org/jira/browse/SLING-11124
> Project: Sling
>  Issue Type: Task
>  Components: Apache Sling Testing Clients
>Affects Versions: Apache Sling Testing Clients 3.0.6
>Reporter: Andrei Tuicu
>    Assignee: Andrei Dulvac
>Priority: Major
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> Sling testing clients are using com.google.guava guava 14.0.1 which is 
> vulnerable to CVE-2018-10237(MEDIUM) [1] and CVE-2020-8908(LOW) [2].
> Mitigation: update to latest guava 31.0.1-android
> [1] https://www.cvedetails.com/cve/CVE-2018-10237/
> [2] https://www.cvedetails.com/cve/CVE-2020-8908/



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[RESULT] [VOTE] Release Apache Sling Testing Clients version 3.0.4

[Andrei Dulvac]

Hi, The vote has passed with the following result : +1 (binding): Stefan,
Olli, Andrei +1 (non binding): none I will copy this release to the Sling
dist directory and promote the artifacts to the central Maven repository.

- Andrei

On Mon, Dec 13, 2021 at 11:20 AM Andrei Dulvac  wrote:

> Here's my +1
> - Andrei
>
> On Thu, Dec 9, 2021 at 10:43 PM Oliver Lietz 
> wrote:
>
>> On Thursday, 9 December 2021 11:41:48 CET Andrei Dulvac wrote:
>> > Hi,
>> >
>> > We solved 1 issue in this release:
>> > https://issues.apache.org/jira/projects/SLING/versions/12350884
>> >
>> >
>> > Staging repository:
>> > https://repository.apache.org/content/repositories/orgapachesling-2563
>>
>> +1 (we could drop several versions from POM as they are managed in parent)
>>
>> O.
>>
>>
>>
>>
>>

Re: [VOTE] Release Apache Sling Testing Clients version 3.0.4

[Andrei Dulvac]

Here's my +1
- Andrei

On Thu, Dec 9, 2021 at 10:43 PM Oliver Lietz  wrote:

> On Thursday, 9 December 2021 11:41:48 CET Andrei Dulvac wrote:
> > Hi,
> >
> > We solved 1 issue in this release:
> > https://issues.apache.org/jira/projects/SLING/versions/12350884
> >
> >
> > Staging repository:
> > https://repository.apache.org/content/repositories/orgapachesling-2563
>
> +1 (we could drop several versions from POM as they are managed in parent)
>
> O.
>
>
>
>
>

[VOTE] Release Apache Sling Testing Clients version 3.0.4

[Andrei Dulvac]

Hi,

We solved 1 issue in this release:
https://issues.apache.org/jira/projects/SLING/versions/12350884


Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2563

You can use this UNIX script to download the release and verify the
signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2563 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Cheers,
- Andrei

Re: [CANCELLED][VOTE] Release Apache Sling Testing Clients version 3.0.0

[Andrei Dulvac]

Sorry for the delayed response Konrad. Yeah, that's why the major version
change.
In any case, because of findings discussed at
https://github.com/apache/sling-org-apache-sling-testing-clients/commit/0835cf2e83c89873ccee6b1ef0af82acde99e832#commitcomment-61613415
, I'm canceling the release and creating a new one.

*I* am sorry for the noise.
- Andrei

On Thu, Dec 9, 2021 at 8:21 AM Konrad Windszus  wrote:

> Sorry for the noise, I was assuming that SLING-10974 is only a change of
> the Maven coordinates, but in fact also the API changed (due to the java
> package name changes).
> So everything fine with the major version change.
> Konrad
>
> > On 8. Dec 2021, at 19:01, Konrad Windszus  wrote:
> >
> > Hi Andrei,
> > I am confused by this major version bump. IMHO
> https://issues.apache.org/jira/browse/SLING-10974 <
> https://issues.apache.org/jira/browse/SLING-10974> does not affect the
> users, therefore a minor or even qualifier increase would be sufficient
> from my PoV.
> > Do we really anticipate compatibility issues due to this change?
> > Konrad
> >
> >> On 8. Dec 2021, at 18:47, Andrei Dulvac  wrote:
> >>
> >> Hi,
> >>
> >> We solved 1 issue in this release:
> >> https://issues.apache.org/jira/projects/SLING/versions/12350884
> >>
> >>
> >> Staging repository:
> >> https://repository.apache.org/content/repositories/orgapachesling-2561
> >>
> >> You can use this UNIX script to download the release and verify the
> >> signatures:
> >>
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
> >>
> >> Usage:
> >> sh check_staged_release.sh 2561 /tmp/sling-staging
> >>
> >> Please vote to approve this release:
> >>
> >> [ ] +1 Approve the release
> >> [ ]  0 Don't care
> >> [ ] -1 Don't release, because ...
> >>
> >> This majority vote is open for at least 72 hours.
> >>
> >> Cheers,
> >> - Andrei
> >
>
>

[jira] [Commented] (SLING-10974) testing clients - replace org.codehaus.jackson with com.fasterxml.jackson.core

[Andrei Dulvac (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-10974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17456265#comment-17456265
 ] 

Andrei Dulvac commented on SLING-10974:
---

[~kwin], hence the major version bump. These jackson packages have a long 
history of security vulnerabilities. Plus, we've been putting this change out 
long enough. See 
https://github.com/apache/sling-org-apache-sling-testing-clients/commit/2988bbe2456c2cfd6beb62cdb94faa984ac4b8c8#diff-9c5fb3d1b7e3b0f54bc5c4182965c4fe1f9023d449017cece3005d3f90e8e4d8R186-R192
 

> testing clients - replace org.codehaus.jackson with com.fasterxml.jackson.core
> --
>
> Key: SLING-10974
> URL: https://issues.apache.org/jira/browse/SLING-10974
> Project: Sling
>  Issue Type: Improvement
>  Components: Apache Sling Testing Clients
>Affects Versions: Apache Sling Testing Clients 2.0.12
>    Reporter: Andrei Dulvac
>    Assignee: Andrei Dulvac
>Priority: Major
> Fix For: Apache Sling Testing Clients 3.0.0
>
>
> Replace {{org.codehaus.jackson}} with the latest 
> {{com.fasterxml.jackson.core}} in the sling testing clients.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[VOTE] Release Apache Sling Testing Clients version 3.0.0

[Andrei Dulvac]

Hi,

We solved 1 issue in this release:
https://issues.apache.org/jira/projects/SLING/versions/12350884


Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2561

You can use this UNIX script to download the release and verify the
signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2561 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Cheers,
- Andrei

[jira] [Resolved] (SLING-10974) testing clients - replace org.codehaus.jackson with com.fasterxml.jackson.core

[Andrei Dulvac (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrei Dulvac resolved SLING-10974.
---
Resolution: Fixed

> testing clients - replace org.codehaus.jackson with com.fasterxml.jackson.core
> --
>
> Key: SLING-10974
> URL: https://issues.apache.org/jira/browse/SLING-10974
> Project: Sling
>  Issue Type: Improvement
>  Components: Apache Sling Testing Clients
>Affects Versions: Apache Sling Testing Clients 2.0.12
>    Reporter: Andrei Dulvac
>    Assignee: Andrei Dulvac
>Priority: Major
> Fix For: Apache Sling Testing Clients 2.0.14
>
>
> Replace {{org.codehaus.jackson}} with the latest 
> {{com.fasterxml.jackson.core}} in the sling testing clients.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Created] (SLING-10974) testing clients - replace org.codehaus.jackson with com.fasterxml.jackson.core

[Andrei Dulvac (Jira)]

Andrei Dulvac created SLING-10974:
-

 Summary: testing clients - replace org.codehaus.jackson with 
com.fasterxml.jackson.core
 Key: SLING-10974
 URL: https://issues.apache.org/jira/browse/SLING-10974
 Project: Sling
  Issue Type: Improvement
  Components: Apache Sling Testing Clients
Affects Versions: Apache Sling Testing Clients 2.0.12
Reporter: Andrei Dulvac
Assignee: Andrei Dulvac
 Fix For: Apache Sling Testing Clients 2.0.14


Replace {{org.codehaus.jackson}} with the latest {{com.fasterxml.jackson.core}} 
in the sling testing clients.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[RESULT] [VOTE] Release Apache Sling Testing Clients version 2.0.12

[Andrei Dulvac]

Hi, The vote has passed with the following result : +1 (binding): Robert,
Stefan, Nicolas +1 (non binding): none I will copy this release to the
Sling dist directory and promote the artifacts to the central Maven
repository.

Cheers,
- Andrei

[VOTE] Release Apache Sling Testing Clients version 2.0.12

[Andrei Dulvac]

Hi,

We solved 1 issue in this release:
https://issues.apache.org/jira/projects/SLING/versions/12350642

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2551/

You can use this UNIX script to download the release and verify the
signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2551 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Cheers,
- Andrei

[RESULT] [VOTE] Release Apache Sling Testing Clients version 2.0.8

[Andrei Dulvac]

Hi, The vote has passed with the following result : +1 (binding): Daniel,
Eric, Stefan +1 (non binding): Julian

There were no objections to the release. I will copy this release to the
Sling dist directory and promote the artifacts to the central Maven
repository.

- Andrei

On Wed, Nov 11, 2020 at 12:52 PM Julian Sedding  wrote:

> +1
>
> Regards
> Julian
>
> On Wed, Nov 11, 2020 at 9:16 AM Stefan Seifert 
> wrote:
> >
> > +1
>

Re: SlingPostServlet should not throw 500 on any exception

[Andrei Dulvac]

Hi.

Strongly agree this should not be a 5xx response. A 4xx makes sense.

- Andrei

On Wed, 11 Nov 2020 at 14:25, Carsten Ziegeler  wrote:

> Hi,
>
> agreed - in many cases we're return a 500 where a 4xx would be more
> appropriate. As you mention, the post servlet can't decide which case it
> is, so we have to map all exceptions either to 500 (like today) or to
> 4xx. In both cases, we have a false positives.
> But I agree, that it's more likely that its a 4xx case if the exception
> is thrown. When there is a real server problem, I would assume you get
> exceptions all over the place anyway.
> So, I think the change makes sense - we should also not log the
> stacktrace as part of the warning anymore. I'm not even sure if a 4xx
> should log a warning at all.
>
> Regards
> Carsten
>
> Am 11.11.2020 um 13:10 schrieb Jörg Hoh:
> > Hi all,
> >
> > while trying to assess a number of internal server errors, I came across
> > the behavior that the SlingPostServlet is always returning a 500 if it
> has
> > been invoked and wasn't able to write to the repository because of
> missing
> > write permissions [2]. See
> https://issues.apache.org/jira/browse/SLING-9896
> > for a sample of such a stacktrace.
> >
> > I don't think that this type of error qualifies for a HTTP statuscode
> 500,
> > but it's rather an expected behavior, and therefor it should return with
> a
> > 4xx statuscode.
> >
> > In the example mentioned above, the PersistenceException is thrown by the
> > JcrResourceProvider [1], but this PersistenceException is generated on
> > every RepositoryException. So technically, on the one hand side it could
> be
> > caused by a defunct repository (and imo that would qualify for an
> internal
> > server error) on the other hand side it might be caused just by missing
> > permissions.
> >
> > Having that in mind, I would nevertheless argue to switch the behavior of
> > the SlingPostServlet to return a 405 "Method not allowed" in the case of
> a
> > PersistenceError [2]. It isn't 100% accurate either but still better than
> > the internal server error. Making it more accurate would require major
> > changes to the Sling-JCR implementation, and I am not sure if this
> > improvement in semantics justifies it.
> > All other exceptions are thandled the same way as before and continue to
> > return an internal server error.
> >
> > WDYT?
> >
> > Jörg
> >
> >
> > [1]
> >
> https://github.com/apache/sling-org-apache-sling-jcr-resource/blob/org.apache.sling.jcr.resource-3.0.22/src/main/java/org/apache/sling/jcr/resource/internal/helper/jcr/JcrResourceProvider.java#L476
> >
> > [2]
> >
> https://github.com/apache/sling-org-apache-sling-servlets-post/blob/master/src/main/java/org/apache/sling/servlets/post/impl/SlingPostServlet.java#L237
> >
>
> --
> --
> Carsten Ziegeler
> Adobe Research Switzerland
> cziege...@apache.org
>

[VOTE] Release Apache Sling Testing Clients version 2.0.8

[Andrei Dulvac]

Hi, We solved 1 issue in this release:
https://issues.apache.org/jira/projects/SLING/versions/12349274  Staging
repository:
https://repository.apache.org/content/repositories/orgapachesling-2372/
You can use this UNIX script to download the release and verify the
signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
Usage: sh check_staged_release.sh 2372 /tmp/sling-staging Please vote to
approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1
Don't release, because ... This majority vote is open for at least 72 hours.

[jira] [Resolved] (SLING-9855) Invalidate login token when receiving 401

[Andrei Dulvac (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrei Dulvac resolved SLING-9855.
--
Resolution: Fixed

> Invalidate login token when receiving 401
> -
>
> Key: SLING-9855
> URL: https://issues.apache.org/jira/browse/SLING-9855
> Project: Sling
>  Issue Type: Improvement
>  Components: Apache Sling Testing Clients
>Affects Versions: Apache Sling Testing Clients 2.0.6
>Reporter: Andrei Tuicu
>    Assignee: Andrei Dulvac
>Priority: Major
> Fix For: Apache Sling Testing Clients 2.0.8
>
>
> h3. Story
> The Sling testing clients should invalidate login token when receiving 401, 
> so that subsequent requests get a fresh token. Retrying requests with a token 
> for which we already got a 401 response are very likely to continue to fail.
> h3. Acceptance Criteria
> * The login token is invalidated in the client when Sling responds with 401
> cc [~andrei.dulvac]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Assigned] (SLING-9855) Invalidate login token when receiving 401

[Andrei Dulvac (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrei Dulvac reassigned SLING-9855:


Assignee: Andrei Dulvac

> Invalidate login token when receiving 401
> -
>
> Key: SLING-9855
> URL: https://issues.apache.org/jira/browse/SLING-9855
> Project: Sling
>  Issue Type: Improvement
>  Components: Apache Sling Testing Clients
>Affects Versions: Apache Sling Testing Clients 2.0.6
>Reporter: Andrei Tuicu
>    Assignee: Andrei Dulvac
>Priority: Major
>
> h3. Story
> The Sling testing clients should invalidate login token when receiving 401, 
> so that subsequent requests get a fresh token. Retrying requests with a token 
> for which we already got a 401 response are very likely to continue to fail.
> h3. Acceptance Criteria
> * The login token is invalidated in the client when Sling responds with 401
> cc [~andrei.dulvac]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-9855) Invalidate login token when receiving 401

[Andrei Dulvac (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrei Dulvac updated SLING-9855:
-
Fix Version/s: Apache Sling Testing Clients 2.0.8

> Invalidate login token when receiving 401
> -
>
> Key: SLING-9855
> URL: https://issues.apache.org/jira/browse/SLING-9855
> Project: Sling
>  Issue Type: Improvement
>  Components: Apache Sling Testing Clients
>Affects Versions: Apache Sling Testing Clients 2.0.6
>Reporter: Andrei Tuicu
>    Assignee: Andrei Dulvac
>Priority: Major
> Fix For: Apache Sling Testing Clients 2.0.8
>
>
> h3. Story
> The Sling testing clients should invalidate login token when receiving 401, 
> so that subsequent requests get a fresh token. Retrying requests with a token 
> for which we already got a 401 response are very likely to continue to fail.
> h3. Acceptance Criteria
> * The login token is invalidated in the client when Sling responds with 401
> cc [~andrei.dulvac]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: [VOTE] Release Apache Sling Scripting HTL Testing Content 1.0.20-1.4.0, Apache Sling Scripting HTL JS Use Provider 1.2.6, Apache Sling Scripting HTL Engine 1.4.2-1.4.0, Apache Sling Scripting HTL

[Andrei Dulvac]

+1

- Andrei

On Fri, 21 Aug 2020 at 14:22, Robert Munteanu  wrote:

> On Fri, 2020-08-21 at 11:17 +, Radu Cotescu wrote:
>
> > sh check_staged_release.sh 2321 /tmp/sling-staging
>
>
>
> +1
>
> Robert
>
>

[RESULT] [VOTE] Release Apache Sling testing Clients version 2.0.2

[Andrei Dulvac]

Hi, The vote has passed with the following result : +1 (binding): Robert,
Stefan, Radu, Nicolas, Andrei +1 (non binding): none I will copy this
release to the Sling dist directory and promote the artifacts to the
central Maven repository.

Cheers,
- Andrei

On Mon, Aug 17, 2020 at 9:58 AM Andrei Dulvac  wrote:

> +1
>
> On Wed, Aug 12, 2020 at 12:09 PM Nicolas Peltier 
> wrote:
>
>> +1
>>
>> Le mar. 11 août 2020 à 14:03, Radu Cotescu  a écrit :
>>
>> > +1
>> >
>> > > On 10 Aug 2020, at 17:34, Andrei Dulvac  wrote:
>> > >
>> > > Please vote to approve this release:
>> > >
>> > >  [ ] +1 Approve the release
>> > >  [ ]  0 Don't care
>> > >  [ ] -1 Don't release, because ...
>> >
>> >
>>
>

Re: [VOTE] Release Apache Sling testing Clients version 2.0.2

[Andrei Dulvac]

+1

On Wed, Aug 12, 2020 at 12:09 PM Nicolas Peltier 
wrote:

> +1
>
> Le mar. 11 août 2020 à 14:03, Radu Cotescu  a écrit :
>
> > +1
> >
> > > On 10 Aug 2020, at 17:34, Andrei Dulvac  wrote:
> > >
> > > Please vote to approve this release:
> > >
> > >  [ ] +1 Approve the release
> > >  [ ]  0 Don't care
> > >  [ ] -1 Don't release, because ...
> >
> >
>

[VOTE] Release Apache Sling testing Clients version 2.0.2

[Andrei Dulvac]

Hi,

We solved 2 issues in this release:
https://issues.apache.org/jira/projects/SLING/versions/12348058


Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2316

You can use this UNIX script to download the release and verify the
signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD


Usage:
sh check_staged_release.sh 2316 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.\

- Andrei

[jira] [Resolved] (SLING-9647) [Testing Clients] Store request and response on a ClientException

[Andrei Dulvac (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrei Dulvac resolved SLING-9647.
--
Resolution: Fixed

> [Testing Clients] Store request and response on  a ClientException 
> ---
>
> Key: SLING-9647
> URL: https://issues.apache.org/jira/browse/SLING-9647
> Project: Sling
>  Issue Type: Improvement
>  Components: Apache Sling Testing Clients
>Affects Versions: Apache Sling Testing Clients 2.0.0
>    Reporter: Andrei Dulvac
>    Assignee: Andrei Dulvac
>Priority: Minor
> Fix For: Apache Sling Testing Clients 2.0.2
>
>
> Allow for ClientException to optionally store the request and response. This 
> would be useful for logging them as part of exception handling



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (SLING-9647) [Testing Clients] Store request and response on a ClientException

[Andrei Dulvac (Jira)]

Andrei Dulvac created SLING-9647:


 Summary: [Testing Clients] Store request and response on  a 
ClientException 
 Key: SLING-9647
 URL: https://issues.apache.org/jira/browse/SLING-9647
 Project: Sling
  Issue Type: Improvement
  Components: Apache Sling Testing Clients
Affects Versions: Apache Sling Testing Clients 2.0.0
Reporter: Andrei Dulvac
Assignee: Andrei Dulvac
 Fix For: Apache Sling Testing Clients 2.0.2


Allow for ClientException to optionally store the request and response. This 
would be useful for logging them as part of exception handling



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Resolved] (SLING-9633) Testing Clients Polling does not return all exceptions encountered while polling

[Andrei Dulvac (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrei Dulvac resolved SLING-9633.
--
Resolution: Fixed

> Testing Clients Polling does not return all exceptions encountered while 
> polling
> 
>
> Key: SLING-9633
> URL: https://issues.apache.org/jira/browse/SLING-9633
> Project: Sling
>  Issue Type: Bug
>Affects Versions: Apache Sling Testing Clients 2.0.0
>    Reporter: Andrei Dulvac
>    Assignee: Andrei Dulvac
>Priority: Minor
> Fix For: Apache Sling Testing Clients 2.0.2
>
>
> It can happen with {{Polling}} that the last exception thrown is not the same 
> as the subsequent ones, for example in case of an operation with side effects 
> that might have thrown a particular exception, after which it throws some 
> sort of "conflict" exception. That first exception is thus lost.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (SLING-9633) Testing Clients Polling does not return all exceptions encountered while polling

[Andrei Dulvac (Jira)]

Andrei Dulvac created SLING-9633:


 Summary: Testing Clients Polling does not return all exceptions 
encountered while polling
 Key: SLING-9633
 URL: https://issues.apache.org/jira/browse/SLING-9633
 Project: Sling
  Issue Type: Bug
Affects Versions: Apache Sling Testing Clients 2.0.0
Reporter: Andrei Dulvac
Assignee: Andrei Dulvac
 Fix For: Apache Sling Testing Clients 2.0.2


It can happen with {{Polling}} that the last exception thrown is not the same 
as the subsequent ones, for example in case of an operation with side effects 
that might have thrown a particular exception, after which it throws some sort 
of "conflict" exception. That first exception is thus lost.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: [VOTE] Release Apache Sling GraphQL Core 0.0.4

[Andrei Dulvac]

+1

- Andrei

On Fri, Jul 10, 2020 at 1:32 PM  wrote:

> +1
>
> David
>
> On Tue, 7 Jul 2020 at 10:53, Radu Cotescu  wrote:
>
> > Hi,
> >
> > We solved 1 issue in this release:
> > https://issues.apache.org/jira/browse/SLING/fixforversion/12348412
> >
> > Staging repository:
> > https://repository.apache.org/content/repositories/orgapachesling-2293/
> >
> > You can use this UNIX script to download the release and verify the
> > signatures:
> >
> >
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
> >
> > Usage:
> > sh check_staged_release.sh 2293 /tmp/sling-staging
> >
> > Please vote to approve this release:
> >
> >   [ ] +1 Approve the release
> >   [ ]  0 Don't care
> >   [ ] -1 Don't release, because ...
> >
> > This majority vote is open for at least 72 hours.
> >
> > Regards,
> > Radu Cotescu
> >
>

[jira] [Resolved] (SLING-9449) Repoinit AclUtil#setPrincipalAcl throws exception if no path-based entry exists for principal

[Andrei Dulvac (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrei Dulvac resolved SLING-9449.
--
Fix Version/s: Repoinit JCR 1.1.28
   Resolution: Fixed

> Repoinit AclUtil#setPrincipalAcl throws exception if no path-based entry 
> exists for principal
> -
>
> Key: SLING-9449
> URL: https://issues.apache.org/jira/browse/SLING-9449
> Project: Sling
>  Issue Type: Bug
>  Components: Repoinit
>Affects Versions: Repoinit JCR 1.1.26
>    Reporter: Andrei Dulvac
>Assignee: Andrei Dulvac
>Priority: Critical
> Fix For: Repoinit JCR 1.1.28
>
>
> The check at 
> https://github.com/apache/sling-org-apache-sling-jcr-repoinit/blob/master/src/main/java/org/apache/sling/jcr/repoinit/impl/AclUtil.java#L191
>  is very aggressive and results in an error getting thrown, which potentially 
> causes the repository service to not start up.
> It should be replaced with a log message.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-9449) Repoinit AclUtil#setPrincipalAcl throws exception if no path-based entry exists for principal

[Andrei Dulvac (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-9449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17106383#comment-17106383
 ] 

Andrei Dulvac commented on SLING-9449:
--

resolved in 
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/commit/55aa500da6805482d6972330e37125eacedaca8f
 

> Repoinit AclUtil#setPrincipalAcl throws exception if no path-based entry 
> exists for principal
> -
>
> Key: SLING-9449
> URL: https://issues.apache.org/jira/browse/SLING-9449
> Project: Sling
>  Issue Type: Bug
>  Components: Repoinit
>Affects Versions: Repoinit JCR 1.1.26
>    Reporter: Andrei Dulvac
>Assignee: Andrei Dulvac
>Priority: Critical
>
> The check at 
> https://github.com/apache/sling-org-apache-sling-jcr-repoinit/blob/master/src/main/java/org/apache/sling/jcr/repoinit/impl/AclUtil.java#L191
>  is very aggressive and results in an error getting thrown, which potentially 
> causes the repository service to not start up.
> It should be replaced with a log message.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (SLING-9449) Repoinit AclUtil#setPrincipalAcl throws exception if no path-based entry exists for principal

[Andrei Dulvac (Jira)]

Andrei Dulvac created SLING-9449:


 Summary: Repoinit AclUtil#setPrincipalAcl throws exception if no 
path-based entry exists for principal
 Key: SLING-9449
 URL: https://issues.apache.org/jira/browse/SLING-9449
 Project: Sling
  Issue Type: Bug
  Components: Repoinit
Affects Versions: Repoinit JCR 1.1.26
Reporter: Andrei Dulvac
Assignee: Andrei Dulvac


The check at 
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/blob/master/src/main/java/org/apache/sling/jcr/repoinit/impl/AclUtil.java#L191
 is very aggressive and results in an error getting thrown, which potentially 
causes the repository service to not start up.

It should be replaced with a log message.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: [VOTE][CANCELLED]Release Apache Sling Testing Clients version 1.2.8 and Apache Sling Testing Rules version 1.0.10

[Andrei Dulvac]

Hi Robert.

Yeah, sorry about that. I must've forgotten. I'll drop them in a bit.

-Andrei

On Tue, 12 May 2020 at 11:16, Robert Munteanu  wrote:

> Hi Andrei,
>
> Should the staging repositories in Nexus also be dropped? I just
> noticed them.
>
> Thanks,
> Robert
>
>

Re: [VOTE] Move o.a.s.graphql.core to its own repo

[Andrei Dulvac]

+1

On Fri, 8 May 2020 at 23:13, Daniel Klco  wrote:

> +1
>
> On Fri, May 8, 2020 at 8:06 AM Radu Cotescu  wrote:
>
> > On 8 May 2020, at 14:03, Bertrand Delacretaz 
> > wrote:
> > >
> > > I'd like to move the org.apache.sling.graphql.core [1] code to its own
> > > module, see the README there for more info on what it does.
> >
> > +1
>

Re: Subject: [VOTE] Release Apache Sling Repoinit JCR 1.1.26

[Andrei Dulvac]

+1

On Thu, Apr 30, 2020 at 6:13 PM Stefan Seifert 
wrote:

> +1
>
>
> please note that the unit tests fail on windows (they are running fine on
> linux)
>
>
> ---
> Test set: org.apache.sling.jcr.repoinit.RepositoryInitializerTest
>
> ---
> Tests run: 10, Failures: 9, Errors: 0, Skipped: 0, Time elapsed: 17.193 s
> <<< FAILURE! - in org.apache.sling.jcr.repoinit.RepositoryInitializerTest
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.testLogin[Using
> provisioning model]  Time elapsed: 15.843 s  <<< FAILURE!
> java.lang.AssertionError: Got unexpected java.net.UnknownHostException in
> activation
> at
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.setup(RepositoryInitializerTest.java:139)
>
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.testLogin[Default
> value of model section config]  Time elapsed: 0.152 s  <<< FAILURE!
> java.lang.AssertionError: Got unexpected java.net.UnknownHostException in
> activation
> at
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.setup(RepositoryInitializerTest.java:139)
>
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.testLogin[Raw
> repoinit/empty section]  Time elapsed: 0.157 s  <<< FAILURE!
> java.lang.AssertionError: Got unexpected java.net.UnknownHostException in
> activation
> at
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.setup(RepositoryInitializerTest.java:139)
>
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.testLogin[Raw
> repoinit/ignored section name]  Time elapsed: 0.142 s  <<< FAILURE!
> java.lang.AssertionError: Got unexpected java.net.UnknownHostException in
> activation
> at
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.setup(RepositoryInitializerTest.java:139)
>
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.testLogin[All
> empty, just setup + parsing]  Time elapsed: 0.167 s  <<< FAILURE!
> java.lang.AssertionError: Got unexpected java.net.UnknownHostException in
> activation
> at
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.setup(RepositoryInitializerTest.java:139)
>
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.testLogin[Raw
> repoinit/null format]  Time elapsed: 0.145 s  <<< FAILURE!
> java.lang.AssertionError: expected: org.apache.sling.repoinit.parser.RepoInitParsingException> but was: java.net.UnknownHostException>
> at
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.setup(RepositoryInitializerTest.java:137)
>
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.testLogin[With
> model/null format]  Time elapsed: 0.133 s  <<< FAILURE!
> java.lang.AssertionError: expected: but
> was:
> at
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.setup(RepositoryInitializerTest.java:137)
>
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.testLogin[Invalid
> format]  Time elapsed: 0.162 s  <<< FAILURE!
> java.lang.AssertionError: expected: but
> was:
> at
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.setup(RepositoryInitializerTest.java:137)
>
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.testLogin[Null
> model section]  Time elapsed: 0.137 s  <<< FAILURE!
> java.lang.AssertionError: expected: but
> was:
> at
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.setup(RepositoryInitializerTest.java:137)
>
>
>
> stefan
>


-- 
 - Andrei

[RESULT][VOTE] Release Apache Sling Testing Clients version 2.0.0 and Apache Sling Testing Rules version 2.0.0

[Andrei Dulvac]

Hi,

The vote has passed with the following result :

+1 (binding): Daniel, Robert, Andrei

No -1 votes

I will copy this release to the Sling dist directory and
promote the artifacts to the central Maven repository.

Thanks,
- Andrei

On Tue, Apr 7, 2020 at 12:51 PM Andrei Dulvac  wrote:

> Hi Robert.
>
> The reasoning is that for the testing clients, which is packaged as a
> bundle, I still like to use semver  for the maven version, even though not
> strictly required.
>
> For the testing rules, it's a bit trickier, but the reasoning is the
> testing clients are supposed to be used as a transient dependency by the
> end user.
>
> I'll have a think about the overall strategy. I don't think a major
> version bump is a problem, but it's a valid point, for sure.
>
> Here's my +1 as well.
>
> Thanks
> Andrei
>
> On Tue, 7 Apr 2020 at 10:43, Robert Munteanu  wrote:
>
>> On Mon, 2020-04-06 at 15:20 +0200, Andrei Dulvac wrote:
>> > Please vote to approve this release:
>>
>> +1
>>
>> As a side note, do you really want a 2.0 version? From a "marketing"
>> point of view these don't add much - the testing rules just has two
>> bugfixes.
>>
>> It does not hurt anything, but then again consumers might be suprised.
>>
>> Robert
>>
>

Re: [VOTE] Release Apache Sling Testing Clients version 2.0.0 and Apache Sling Testing Rules version 2.0.0

[Andrei Dulvac]

Hi Robert.

The reasoning is that for the testing clients, which is packaged as a
bundle, I still like to use semver  for the maven version, even though not
strictly required.

For the testing rules, it's a bit trickier, but the reasoning is the
testing clients are supposed to be used as a transient dependency by the
end user.

I'll have a think about the overall strategy. I don't think a major version
bump is a problem, but it's a valid point, for sure.

Here's my +1 as well.

Thanks
Andrei

On Tue, 7 Apr 2020 at 10:43, Robert Munteanu  wrote:

> On Mon, 2020-04-06 at 15:20 +0200, Andrei Dulvac wrote:
> > Please vote to approve this release:
>
> +1
>
> As a side note, do you really want a 2.0 version? From a "marketing"
> point of view these don't add much - the testing rules just has two
> bugfixes.
>
> It does not hurt anything, but then again consumers might be suprised.
>
> Robert
>

[VOTE] Release Apache Sling Testing Clients version 2.0.0 and Apache Sling Testing Rules version 2.0.0

[Andrei Dulvac]

Hi,
We solved 5 issues across those two releases


https://issues.apache.org/jira/projects/SLING/versions/12347772

https://issues.apache.org/jira/projects/SLING/versions/12344767

Staging 
repository:https://repository.apache.org/content/repositories/orgapachesling-2236


You can use this UNIX script to download the release and verify the
signatures:https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2236 /tmp/sling-staging



Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.


-Andrei

[jira] [Resolved] (SLING-9334) Refactor configurable retries mechanism to make them consistent

[Andrei Dulvac (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrei Dulvac resolved SLING-9334.
--
Resolution: Fixed

> Refactor configurable retries mechanism to make them consistent
> ---
>
> Key: SLING-9334
> URL: https://issues.apache.org/jira/browse/SLING-9334
> Project: Sling
>  Issue Type: Improvement
>  Components: Apache Sling Testing Clients
>Affects Versions: Apache Sling Testing Clients 1.2.4
>    Reporter: Andrei Dulvac
>    Assignee: Andrei Dulvac
>Priority: Critical
> Fix For: Apache Sling Testing Clients 2.0.0
>
>
> The {{o.a.s.testing.util.Constants}} class has some static fields that are 
> not constants at all. Those values should be moved into methods.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-9334) Refactor configurable retries mechanism to make them consistent

[Andrei Dulvac (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-9334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17076306#comment-17076306
 ] 

Andrei Dulvac commented on SLING-9334:
--

This took care of 
https://builds.apache.org/blue/organizations/jenkins/Sling%2Fsling-org-apache-sling-testing-clients/detail/master/92/pipeline
 


> Refactor configurable retries mechanism to make them consistent
> ---
>
> Key: SLING-9334
> URL: https://issues.apache.org/jira/browse/SLING-9334
> Project: Sling
>  Issue Type: Improvement
>  Components: Apache Sling Testing Clients
>Affects Versions: Apache Sling Testing Clients 1.2.4
>    Reporter: Andrei Dulvac
>    Assignee: Andrei Dulvac
>Priority: Critical
> Fix For: Apache Sling Testing Clients 2.0.0
>
>
> The {{o.a.s.testing.util.Constants}} class has some static fields that are 
> not constants at all. Those values should be moved into methods.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-9334) Refactor configurable retries mechanism to make them consistent

[Andrei Dulvac (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrei Dulvac updated SLING-9334:
-
Description: The {{o.a.s.testing.util.Constants}} class has some static 
fields that are not constants at all. Those values should be moved into 
methods.  (was: Make http retry mechanism configurable.
More specifically, configure the error codes for which to retry the test http 
calls.)

> Refactor configurable retries mechanism to make them consistent
> ---
>
> Key: SLING-9334
> URL: https://issues.apache.org/jira/browse/SLING-9334
> Project: Sling
>  Issue Type: Improvement
>  Components: Apache Sling Testing Clients
>Affects Versions: Apache Sling Testing Clients 1.2.4
>    Reporter: Andrei Dulvac
>    Assignee: Andrei Dulvac
>Priority: Critical
> Fix For: Apache Sling Testing Clients 2.0.0
>
>
> The {{o.a.s.testing.util.Constants}} class has some static fields that are 
> not constants at all. Those values should be moved into methods.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)