[jira] [Commented] (SLING-12349) Unable to set a maximum amount of Sling Jobs in parallel
[ https://issues.apache.org/jira/browse/SLING-12349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853054#comment-17853054 ] Carsten Ziegeler commented on SLING-12349: -- as far as I remember, that configuration was intended to do what you want > Unable to set a maximum amount of Sling Jobs in parallel > - > > Key: SLING-12349 > URL: https://issues.apache.org/jira/browse/SLING-12349 > Project: Sling > Issue Type: Bug > Components: Event >Reporter: Roy Teeuwen >Priority: Major > > It is possible to set a maximum parallel of sling jobs on a queue > configuration, but in systems where the platform itself already makes 20 > queue's and the customer's code also add's their own queue's, this > configuration makes no sense because it is set per queue and not overall. The > sum of the parallel could be way more than the amount of cores available, > making the system unworkable if the separate queue's all have jobs at the > same time > It would be logical that you can also set a maximum parallel overall for all > queue's combined. Is there a reason that this is not already the case? Would > there be anything against building this in? -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-12308) Potential ArrayIndexOutOfBoundsException with global transformers
[ https://issues.apache.org/jira/browse/SLING-12308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-12308. > Potential ArrayIndexOutOfBoundsException with global transformers > - > > Key: SLING-12308 > URL: https://issues.apache.org/jira/browse/SLING-12308 > Project: Sling > Issue Type: Bug > Components: General >Affects Versions: Rewriter 1.4.2 >Reporter: Carsten Ziegeler > Assignee: Carsten Ziegeler >Priority: Major > Fix For: Rewriter 1.4.4 > > > When several global transformers are configured but one of them does not > match the current request, an ArrayIndexOutOfBoundsException might be thrown > as the code assumes all transformers match. > This only happens if there is a matching transformer *after* one that does > not match. If it is the other way round, the code works. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[VOTE RESULT] Release Apache Sling Rewriter 1.4.4
The vote passes with three binding +1 votes Thanks Carsten -- Carsten Ziegeler Adobe cziege...@apache.org
Re: [VOTE] Release Apache Sling Rewriter 1.4.4
+1 Carsten On 30.04.2024 11:27, Carsten Ziegeler wrote: Hi, We solved 1 issues in this release https://issues.apache.org/jira/browse/SLING-12308 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2857/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2857 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards Carsten -- Carsten Ziegeler Adobe cziege...@apache.org
Re: [VOTE] Release Apache Sling Hypermedia API client-side tools 1.0.2
+1 Carsten On 30.04.2024 16:20, Andrei Dulvac wrote: We solved 1 issues in this release: https://issues.apache.org/jira/issues/?jql=project%20%3D%20SLING%20AND%20fixVersion%20%3D%20%22HApi%20Client%201.0.2%22 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2858/ You can use this UNIX script to download the release and verify the signatures: https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh Usage: sh check_staged_release.sh 2858 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. - Andrei -- Carsten Ziegeler Adobe cziege...@apache.org
[VOTE] Release Apache Sling Rewriter 1.4.4
Hi, We solved 1 issues in this release https://issues.apache.org/jira/browse/SLING-12308 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2857/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2857 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards Carsten -- Carsten Ziegeler Adobe cziege...@apache.org
[jira] [Resolved] (SLING-12308) Potential ArrayIndexOutOfBoundsException with global transformers
[ https://issues.apache.org/jira/browse/SLING-12308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-12308. -- Resolution: Fixed Fixed in https://github.com/apache/sling-org-apache-sling-rewriter/commit/26976e1b370ef2734428dc80ba3ae2fec3f0351b Added test case > Potential ArrayIndexOutOfBoundsException with global transformers > - > > Key: SLING-12308 > URL: https://issues.apache.org/jira/browse/SLING-12308 > Project: Sling > Issue Type: Bug > Components: General >Affects Versions: Rewriter 1.4.2 >Reporter: Carsten Ziegeler > Assignee: Carsten Ziegeler >Priority: Major > Fix For: Rewriter 1.4.4 > > > When several global transformers are configured but one of them does not > match the current request, an ArrayIndexOutOfBoundsException might be thrown > as the code assumes all transformers match. > This only happens if there is a matching transformer *after* one that does > not match. If it is the other way round, the code works. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12211) Update Parent to 52 and make build compatible with Java 17 and above
[ https://issues.apache.org/jira/browse/SLING-12211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler updated SLING-12211: - Fix Version/s: Rewriter 1.4.6 (was: Rewriter 1.4.4) > Update Parent to 52 and make build compatible with Java 17 and above > > > Key: SLING-12211 > URL: https://issues.apache.org/jira/browse/SLING-12211 > Project: Sling > Issue Type: Improvement >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: Rewriter 1.4.6 > > > Updating to Parent 52 allows reproducible builds > (https://issues.apache.org/jira/browse/SLING-11907). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12308) Potential ArrayIndexOutOfBoundsException with global transformers
Carsten Ziegeler created SLING-12308: Summary: Potential ArrayIndexOutOfBoundsException with global transformers Key: SLING-12308 URL: https://issues.apache.org/jira/browse/SLING-12308 Project: Sling Issue Type: Bug Components: General Affects Versions: Rewriter 1.4.2 Reporter: Carsten Ziegeler Assignee: Carsten Ziegeler Fix For: Rewriter 1.4.4 When several global transformers are configured but one of them does not match the current request, an ArrayIndexOutOfBoundsException might be thrown as the code assumes all transformers match. This only happens if there is a matching transformer *after* one that does not match. If it is the other way round, the code works. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-12303) Global transformers are not sorted by service ranking
[ https://issues.apache.org/jira/browse/SLING-12303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-12303. > Global transformers are not sorted by service ranking > - > > Key: SLING-12303 > URL: https://issues.apache.org/jira/browse/SLING-12303 > Project: Sling > Issue Type: Bug > Components: General >Affects Versions: Rewriter 1.4.0 >Reporter: Carsten Ziegeler > Assignee: Carsten Ziegeler >Priority: Major > Fix For: Rewriter 1.4.2 > > > The service ranking of a transformer (factory) is used to determine its > position in the rewriter pipeline. However, the transformers are not ordered > according to their ranking which makes the order unpredictable. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[VOTE RESULT] Release Apache Sling Rewriter 1.4.2
The vote passed with three binding +1 votes Thanks Carsten-- Carsten Ziegeler Adobe cziege...@apache.org
Re: [VOTE] Release Apache Sling OSGi Feature Maven Plugin 1.8.2
+1 Carsten On 25.04.2024 10:42, Robert Munteanu wrote: Hi, We solved 4 issues in this release: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12353863=Text Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2855/ You can use this UNIX script to download the release and verify the signatures: https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh Usage: sh check_staged_release.sh 2855 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards, Robert Munteanu -- Carsten Ziegeler Adobe cziege...@apache.org
Re: [VOTE] Release Apache Sling Commons JSON 2.0.28
+1 Carsten On 25.04.2024 13:20, Robert Munteanu wrote: Hi, We solved 1 issue in this release: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12354549=Text Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2856/ You can use this UNIX script to download the release and verify the signatures: https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh Usage: sh check_staged_release.sh 2856 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards, Robert Munteanu -- Carsten Ziegeler Adobe cziege...@apache.org
[jira] [Commented] (SLING-12173) Configuration errors in Eclipse for projects using the slingfeature-maven-plugin
[ https://issues.apache.org/jira/browse/SLING-12173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840686#comment-17840686 ] Carsten Ziegeler commented on SLING-12173: -- [~rombert] To be honest I prefer our wrapper over the other solutions; its much simpler to use - it also is faster due to the hard coded factory. > Configuration errors in Eclipse for projects using the > slingfeature-maven-plugin > > > Key: SLING-12173 > URL: https://issues.apache.org/jira/browse/SLING-12173 > Project: Sling > Issue Type: Bug > Components: Maven Plugins and Archetypes >Reporter: Robert Munteanu >Assignee: Robert Munteanu >Priority: Major > Fix For: OSGi Feature Maven Plugin 1.8.2 > > > The slingfeature-maven-plugin currently uses the Jakarta JSON implementation > of the Apache Johnzon parser. > I have noticed problems in the Eclipse IDE, where projects fail to update > with hard to isolate errors (see below). > {noformat}java.util.ServiceConfigurationError: jakarta.json.spi.JsonProvider: > org.apache.johnzon.core.JsonProviderImpl not a subtype > at java.base/java.util.ServiceLoader.fail(ServiceLoader.java:593) > at > java.base/java.util.ServiceLoader$LazyClassPathLookupIterator.hasNextService(ServiceLoader.java:1244) > at > java.base/java.util.ServiceLoader$LazyClassPathLookupIterator.hasNext(ServiceLoader.java:1273) > at java.base/java.util.ServiceLoader$2.hasNext(ServiceLoader.java:1309) > at java.base/java.util.ServiceLoader$3.hasNext(ServiceLoader.java:1393) > at jakarta.json.spi.JsonProvider.provider(JsonProvider.java:69) > at jakarta.json.Json.createReader(Json.java:189) > at > org.apache.sling.feature.maven.JSONFeatures.read(JSONFeatures.java:64) > at > org.apache.sling.feature.maven.ProjectHelper.readFeatureFile(ProjectHelper.java:622) > at > org.apache.sling.feature.maven.Preprocessor.readProjectFeatures(Preprocessor.java:304) > at > org.apache.sling.feature.maven.Preprocessor.process(Preprocessor.java:145) > at > org.apache.sling.feature.maven.Preprocessor.process(Preprocessor.java:110) > at > org.apache.sling.feature.maven.extensions.DependencyLifecycleParticipant.afterProjectsRead(DependencyLifecycleParticipant.java:87) > at > org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.executeParticipants(ProjectRegistryManager.java:824) > at > org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.lambda$15(ProjectRegistryManager.java:791) > at > org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.executeBare(MavenExecutionContext.java:394) > at > org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:275) > at > org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:214) > at > org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.lambda$14(ProjectRegistryManager.java:790) > at java.base/java.util.HashMap$Values.forEach(HashMap.java:1065) > at > org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.lambda$11(ProjectRegistryManager.java:788) > at > org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.executeBare(MavenExecutionContext.java:394) > at > org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:275) > at > org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:214) > at > org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.readMavenProjectFacades(ProjectRegistryManager.java:760) > at > org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.refresh(ProjectRegistryManager.java:392) > at > org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.refresh(ProjectRegistryManager.java:366) > at > org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.refresh(ProjectRegistryManager.java:318) > at > org.eclipse.m2e.core.internal.builder.MavenBuilder$BuildMethod.getProjectFacade(MavenBuilder.java:146) > at > org.eclipse.m2e.core.internal.builder.MavenBuilder$BuildMethod.lambda$0(MavenBuilder.java:84) > at > org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.executeBare(MavenExecutionContext.java:394) > at > org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecuti
Re: [VOTE] Release Apache Sling Rewriter 1.4.2
+1 Carsten On 24.04.2024 14:35, Carsten Ziegeler wrote: Hi, We solved 1 issues in this release https://issues.apache.org/jira/browse/SLING-12303 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2854/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2854 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards Carsten -- Carsten Ziegeler Adobe cziege...@apache.org
[jira] [Resolved] (SLING-12303) Global transformers are not sorted by service ranking
[ https://issues.apache.org/jira/browse/SLING-12303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-12303. -- Resolution: Fixed Added sorting and improved logging in https://github.com/apache/sling-org-apache-sling-rewriter/commit/c98017bc16ee3355dcd00fe080b9c93e387f18dd > Global transformers are not sorted by service ranking > - > > Key: SLING-12303 > URL: https://issues.apache.org/jira/browse/SLING-12303 > Project: Sling > Issue Type: Bug > Components: General >Affects Versions: Rewriter 1.4.0 >Reporter: Carsten Ziegeler > Assignee: Carsten Ziegeler >Priority: Major > Fix For: Rewriter 1.4.2 > > > The service ranking of a transformer (factory) is used to determine its > position in the rewriter pipeline. However, the transformers are not ordered > according to their ranking which makes the order unpredictable. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12211) Update Parent to 52 and make build compatible with Java 17 and above
[ https://issues.apache.org/jira/browse/SLING-12211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler updated SLING-12211: - Fix Version/s: Rewriter 1.4.4 (was: Rewriter 1.4.2) > Update Parent to 52 and make build compatible with Java 17 and above > > > Key: SLING-12211 > URL: https://issues.apache.org/jira/browse/SLING-12211 > Project: Sling > Issue Type: Improvement >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: Rewriter 1.4.4 > > > Updating to Parent 52 allows reproducible builds > (https://issues.apache.org/jira/browse/SLING-11907). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12303) Global transformers are not sorted by service ranking
Carsten Ziegeler created SLING-12303: Summary: Global transformers are not sorted by service ranking Key: SLING-12303 URL: https://issues.apache.org/jira/browse/SLING-12303 Project: Sling Issue Type: Bug Components: General Affects Versions: Rewriter 1.4.0 Reporter: Carsten Ziegeler Assignee: Carsten Ziegeler Fix For: Rewriter 1.4.2 The service ranking of a transformer (factory) is used to determine its position in the rewriter pipeline. However, the transformers are not ordered according to their ranking which makes the order unpredictable. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-12299) Support global transformers in error pipelines
[ https://issues.apache.org/jira/browse/SLING-12299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-12299. > Support global transformers in error pipelines > -- > > Key: SLING-12299 > URL: https://issues.apache.org/jira/browse/SLING-12299 > Project: Sling > Issue Type: Improvement > Components: Extensions > Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Rewriter 1.4.0 > > > Global transformers can currently only be added to the normal content > pipeline but not to an error pipeline. > We should support this as well via a new opt-in property. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[VOTE RESULT] Release Apache Sling Rewriter 1.4.0
The vote passed with four binding +1 votes. Thanks everyone Regards Carsten -- Carsten Ziegeler Adobe cziege...@apache.org
[jira] [Commented] (SLING-12300) Provide a way to retrieve a JCR backed resource by its node identifier
[ https://issues.apache.org/jira/browse/SLING-12300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839473#comment-17839473 ] Carsten Ziegeler commented on SLING-12300: -- [~paul.bjorkstrand] Thanks for the detailed response. I think we have a slightly misleading discussion here, the current implementation is a *resource provider* - granted, that provider is not explicitly mounted at "/jcr:id", but there is no huge difference, except maybe that it would be possible to reconfigure the path to something else or disable the provider. I understand the ask for making an identifier a first class citizen in the Sling API, but I'm not sure that this would really change the picture that much. I rather think, the underlying question is whether we want to make resources addressable through their identifier via the http API or not. An identifier based resource API would allow that, the path based approach taken here does not allow it. > Provide a way to retrieve a JCR backed resource by its node identifier > -- > > Key: SLING-12300 > URL: https://issues.apache.org/jira/browse/SLING-12300 > Project: Sling > Issue Type: New Feature > Components: JCR >Reporter: Radu Cotescu >Assignee: Radu Cotescu >Priority: Major > Fix For: JCR Resource 3.3.0 > > > Since all {{javax.jcr.Nodes}} have an identifier [0], a useful feature would > be {{Resource}} retrieval by node id, which could be its {{jcr:uuid}} > property for referenceable nodes or the path. In systems that would like to > use UUID addressing, this would reduce the need for executing JCR queries for > resource retrieval and would avoid double-reads via the JCR and then Sling > API to obtain the resource. > In order to provide a unified behaviour, paths starting with the {{/jcr:id/}} > prefix should use the resource retrieval by node identifier. > [0] - > https://javadoc.io/static/javax.jcr/jcr/2.0/javax/jcr/Node.html#getIdentifier() -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [VOTE] Release Apache Sling Rewriter 1.4.0
+1 Carsten On 18.04.2024 18:36, Carsten Ziegeler wrote: Hi, We solved 1 issue in this release https://issues.apache.org/jira/browse/SLING-12299 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2851/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2851 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards Carsten -- Carsten Ziegeler Adobe cziege...@apache.org
Re: [VOTE] Sling Engine 2.15.14
+1 Carsten On 22.04.2024 05:19, Jörg Hoh wrote: Hi, We solved 1 issue in this release:https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12354595=Text Staging repository:https://repository.apache.org/content/repositories/orgapachesling-2852/ You can use this UNIX script to download the release and verify the signatures:https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh Usage: sh check_staged_release.sh 2852 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. -- Carsten Ziegeler Adobe cziege...@apache.org
[jira] [Commented] (SLING-12300) Provide a way to retrieve a JCR backed resource by its node identifier
[ https://issues.apache.org/jira/browse/SLING-12300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839392#comment-17839392 ] Carsten Ziegeler commented on SLING-12300: -- I think we have two questions here: - do we want to have a mechanism that allows to get resources (JCR resources in this case) by identifier? - if the answer to the first question is yes, then how does it look like? I'm not sure if we agree to answer the first question with a yes based on the comments here, so lets get that one out of the way first. > Provide a way to retrieve a JCR backed resource by its node identifier > -- > > Key: SLING-12300 > URL: https://issues.apache.org/jira/browse/SLING-12300 > Project: Sling > Issue Type: New Feature > Components: JCR >Reporter: Radu Cotescu >Assignee: Radu Cotescu >Priority: Major > Fix For: JCR Resource 3.3.0 > > > Since all {{javax.jcr.Nodes}} have an identifier [0], a useful feature would > be {{Resource}} retrieval by node id, which could be its {{jcr:uuid}} > property for referenceable nodes or the path. In systems that would like to > use UUID addressing, this would reduce the need for executing JCR queries for > resource retrieval and would avoid double-reads via the JCR and then Sling > API to obtain the resource. > In order to provide a unified behaviour, paths starting with the {{/jcr:id/}} > prefix should use the resource retrieval by node identifier. > [0] - > https://javadoc.io/static/javax.jcr/jcr/2.0/javax/jcr/Node.html#getIdentifier() -- This message was sent by Atlassian Jira (v8.20.10#820010)
[VOTE] Release Apache Sling Rewriter 1.4.0
Hi, We solved 1 issue in this release https://issues.apache.org/jira/browse/SLING-12299 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2851/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2851 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards Carsten -- Carsten Ziegeler Adobe cziege...@apache.org
[jira] [Updated] (SLING-12211) Update Parent to 52 and make build compatible with Java 17 and above
[ https://issues.apache.org/jira/browse/SLING-12211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler updated SLING-12211: - Fix Version/s: Rewriter 1.4.2 (was: Rewriter 1.4.0) > Update Parent to 52 and make build compatible with Java 17 and above > > > Key: SLING-12211 > URL: https://issues.apache.org/jira/browse/SLING-12211 > Project: Sling > Issue Type: Improvement >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: Rewriter 1.4.2 > > > Updating to Parent 52 allows reproducible builds > (https://issues.apache.org/jira/browse/SLING-11907). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-12299) Support global transformers in error pipelines
[ https://issues.apache.org/jira/browse/SLING-12299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-12299. -- Resolution: Fixed Implemented in https://github.com/apache/sling-org-apache-sling-rewriter/commit/24ee302deaee25fe87b27db5549e627b56535b3d > Support global transformers in error pipelines > -- > > Key: SLING-12299 > URL: https://issues.apache.org/jira/browse/SLING-12299 > Project: Sling > Issue Type: Improvement > Components: Extensions > Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Rewriter 1.3.12 > > > Global transformers can currently only be added to the normal content > pipeline but not to an error pipeline. > We should support this as well via a new opt-in property. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12299) Support global transformers in error pipelines
Carsten Ziegeler created SLING-12299: Summary: Support global transformers in error pipelines Key: SLING-12299 URL: https://issues.apache.org/jira/browse/SLING-12299 Project: Sling Issue Type: Improvement Components: Extensions Reporter: Carsten Ziegeler Assignee: Carsten Ziegeler Fix For: Rewriter 1.3.12 Global transformers can currently only be added to the normal content pipeline but not to an error pipeline. We should support this as well via a new opt-in property. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [VOTE] Release Apache Sling Commons JSON 2.0.26
+1 Carsten On 12.04.2024 09:49, Robert Munteanu wrote: Hi, We solved 1 issue in this release: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12354548=Text Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2846/ You can use this UNIX script to download the release and verify the signatures: https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh Usage: sh check_staged_release.sh 2846 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards, Robert Munteanu -- Carsten Ziegeler Adobe cziege...@apache.org
[jira] [Commented] (SLING-12264) check save() operations
[ https://issues.apache.org/jira/browse/SLING-12264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17825158#comment-17825158 ] Carsten Ziegeler commented on SLING-12264: -- This sounds like a fix at the wrong place; I would expect that session.save() is actually doing exactly the same internally - in which case this extra check introduces a penality as it is then called twice. > check save() operations > --- > > Key: SLING-12264 > URL: https://issues.apache.org/jira/browse/SLING-12264 > Project: Sling > Issue Type: Task > Components: Repoinit >Affects Versions: Repoinit JCR 1.1.46 >Reporter: Joerg Hoh >Priority: Major > > Before doing a session.save() operation, it should always be checked if there > is something to save at all. > This can speed up the execution of individual repoinit statements if the > repoinit statement does not need to be applied. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [git] New git repository for retired module - sling-org-apache-sling-commons-json
Can we do this without creating a new git repo? Creating a separate new repo gives a different message than what we intend it to be. It would be great if we could do this directly in SVN :) Regards Carsten On 28.02.2024 10:52, Robert Munteanu wrote: Hi Jörg On Tue, 2024-02-27 at 11:06 +0100, Jörg Hoh wrote: Hi Robert, makes sense. To clarify: We just provide this final version of commons.json as a convenience for all users who are still depending on commons.json; but there is no intention to continue development of commons.json or to re-introducing this dependency again into other areas of Sling. There is no intention to use this again in any other modules, add it to the Starter, etc. We will keep the code deprecated. At the same time, we may choose to apply fixes for the reported CVEs, if those are already available upstream, and cut a new release. Thanks, Robert Correct? Jörg Am Mo., 26. Feb. 2024 um 16:30 Uhr schrieb Robert Munteanu < romb...@apache.org>: Hi, A long time ago we retired the commons.json module for legal reasons [1], leaving it only in the SVN attic [2]. After some time a CVE was reported against this module [3] which we could not fix as we could not release new versions. In the meantime, the JSON library we have been using has changed its license to 'Public domain', which makes it acceptable for use at the ASF. [4] I would like to create a GitHub repository for this module and include the current state from the attic. This opens up the way for creating a final service release, allowing consumers of this bundle that have not cleaned up their usages to use non-vulnerable versions. I will leave this thread open for comments for 72 hours. Thanks, Robert [1]: https://lists.apache.org/thread/p9rmd9dvgk04h36dtm6vn0bj6dkx0hkk [2]: https://svn.apache.org/repos/asf/sling/attic/commons.json/ [3]: https://www.cve.org/CVERecord?id=CVE-2022-47937 [4]: https://issues.apache.org/jira/browse/LEGAL-666 -- Carsten Ziegeler Adobe cziege...@apache.org
[jira] [Commented] (SLING-12253) ConcurrentModificationException in AbstractResourceCollector
[ https://issues.apache.org/jira/browse/SLING-12253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818747#comment-17818747 ] Carsten Ziegeler commented on SLING-12253: -- It seems AbstractResourceCollector#getChildrenList is modifying the list *after* it got put into the cache which then allows another thread to pick up the cached result before the list is completely assembled. A workaround is to disable caching. > ConcurrentModificationException in AbstractResourceCollector > > > Key: SLING-12253 > URL: https://issues.apache.org/jira/browse/SLING-12253 > Project: Sling > Issue Type: Task >Affects Versions: Servlets Resolver 2.9.14, Servlets Resolver 2.10.0, > Servlets Resolver 2.11.0 >Reporter: Joerg Hoh >Priority: Major > > {noformat} > [[::1] [1705550745690] GET /content/foobar.html HTTP/1.1] > org.apache.sling.engine.impl.SlingRequestProcessorImpl service: Uncaught > Throwable > java.util.ConcurrentModificationException: null > at > java.base/java.util.ArrayList$Itr.checkForComodification(ArrayList.java:1043) > at java.base/java.util.ArrayList$Itr.next(ArrayList.java:997) > at > org.apache.sling.servlets.resolver.internal.helper.ResourceCollector.getWeightedResources(ResourceCollector.java:232) > [org.apache.sling.servlets.resolver:2.9.14] > at > org.apache.sling.servlets.resolver.internal.helper.AbstractResourceCollector.lambda$getServlets$1(AbstractResourceCollector.java:117) > [org.apache.sling.servlets.resolver:2.9.14] > at java.base/java.util.ArrayList.forEach(ArrayList.java:1541) > at > org.apache.sling.servlets.resolver.internal.helper.AbstractResourceCollector.getServlets(AbstractResourceCollector.java:117) > [org.apache.sling.servlets.resolver:2.9.14] > at > org.apache.sling.servlets.resolver.internal.SlingServletResolver.getServletInternal(SlingServletResolver.java:528) > [org.apache.sling.servlets.resolver:2.9.14] > at > org.apache.sling.servlets.resolver.internal.SlingServletResolver.resolveServletInternal(SlingServletResolver.java:489) > [org.apache.sling.servlets.resolver:2.9.14] > ... > {noformat} -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12253) ConcurrentModificationException in AbstractResourceCollector
[ https://issues.apache.org/jira/browse/SLING-12253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler updated SLING-12253: - Affects Version/s: Servlets Resolver 2.11.0 Servlets Resolver 2.10.0 > ConcurrentModificationException in AbstractResourceCollector > > > Key: SLING-12253 > URL: https://issues.apache.org/jira/browse/SLING-12253 > Project: Sling > Issue Type: Task >Affects Versions: Servlets Resolver 2.9.14, Servlets Resolver 2.10.0, > Servlets Resolver 2.11.0 >Reporter: Joerg Hoh >Priority: Major > > {noformat} > [[::1] [1705550745690] GET /content/foobar.html HTTP/1.1] > org.apache.sling.engine.impl.SlingRequestProcessorImpl service: Uncaught > Throwable > java.util.ConcurrentModificationException: null > at > java.base/java.util.ArrayList$Itr.checkForComodification(ArrayList.java:1043) > at java.base/java.util.ArrayList$Itr.next(ArrayList.java:997) > at > org.apache.sling.servlets.resolver.internal.helper.ResourceCollector.getWeightedResources(ResourceCollector.java:232) > [org.apache.sling.servlets.resolver:2.9.14] > at > org.apache.sling.servlets.resolver.internal.helper.AbstractResourceCollector.lambda$getServlets$1(AbstractResourceCollector.java:117) > [org.apache.sling.servlets.resolver:2.9.14] > at java.base/java.util.ArrayList.forEach(ArrayList.java:1541) > at > org.apache.sling.servlets.resolver.internal.helper.AbstractResourceCollector.getServlets(AbstractResourceCollector.java:117) > [org.apache.sling.servlets.resolver:2.9.14] > at > org.apache.sling.servlets.resolver.internal.SlingServletResolver.getServletInternal(SlingServletResolver.java:528) > [org.apache.sling.servlets.resolver:2.9.14] > at > org.apache.sling.servlets.resolver.internal.SlingServletResolver.resolveServletInternal(SlingServletResolver.java:489) > [org.apache.sling.servlets.resolver:2.9.14] > ... > {noformat} -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [VOTE] Release Apache Sling GraphQL Core 0.0.30
+1 Carsten On 08.02.2024 16:21, Radu Cotescu wrote: Hi, We solved 1 issue in this release: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12354075=Text Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2838/ You can use this UNIX script to download the release and verify the signatures: https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh Usage: sh check_staged_release.sh 2838 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards, Radu Cotescu -- Carsten Ziegeler Adobe cziege...@apache.org
[jira] [Commented] (SLING-12249) Clarify "ADDED" resource changes for ancestor nodes of path
[ https://issues.apache.org/jira/browse/SLING-12249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816076#comment-17816076 ] Carsten Ziegeler commented on SLING-12249: -- sounds ok to me > Clarify "ADDED" resource changes for ancestor nodes of path > --- > > Key: SLING-12249 > URL: https://issues.apache.org/jira/browse/SLING-12249 > Project: Sling > Issue Type: Improvement > Components: API >Affects Versions: API 2.15.0 >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > > Similar to what was clarified in SLING-6066, events for ancestors of the > registered path may not only be received for "REMOVED" resource changes but > also for "ADDED" resource changes. > This happens e.g. for moving resources with the JCR Resource Provider which > uses internally the semantics from > https://issues.apache.org/jira/browse/OAK-1459?focusedCommentId=13911484=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-13911484 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12245) Sling Rewriter does not detect configuration changes coming in via move
[ https://issues.apache.org/jira/browse/SLING-12245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17815613#comment-17815613 ] Carsten Ziegeler commented on SLING-12245: -- Sure, I see the general problem - for the rewriter the approach sounds fine to me > Sling Rewriter does not detect configuration changes coming in via move > --- > > Key: SLING-12245 > URL: https://issues.apache.org/jira/browse/SLING-12245 > Project: Sling > Issue Type: Improvement >Affects Versions: Rewriter 1.3.10 >Reporter: Konrad Windszus >Priority: Major > > If one renames/moves a JCR node from {{/apps/my/config/invalid-rewriter}} to > {{/apps/my/config/rewriter}} the new rewriter configuration is not being > detected by the {{ProcessorManagerImpl}} due to the > {{ResourceChangeListener}} only being configured to listen for changes below > the {{rewriter}} resource > (https://github.com/apache/sling-org-apache-sling-rewriter/blob/4d1952648e35e7001236f282040a78479f7726d4/src/main/java/org/apache/sling/rewriter/impl/ProcessorManagerImpl.java#L69). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12245) Sling Rewriter does not detect configuration changes coming in via move
[ https://issues.apache.org/jira/browse/SLING-12245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17815610#comment-17815610 ] Carsten Ziegeler commented on SLING-12245: -- I think that's what the listener has to do. And in this case it's not super hard > Sling Rewriter does not detect configuration changes coming in via move > --- > > Key: SLING-12245 > URL: https://issues.apache.org/jira/browse/SLING-12245 > Project: Sling > Issue Type: Improvement >Affects Versions: Rewriter 1.3.10 >Reporter: Konrad Windszus >Priority: Major > > If one renames/moves a JCR node from {{/apps/my/config/invalid-rewriter}} to > {{/apps/my/config/rewriter}} the new rewriter configuration is not being > detected by the {{ProcessorManagerImpl}} due to the > {{ResourceChangeListener}} only being configured to listen for changes below > the {{rewriter}} resource > (https://github.com/apache/sling-org-apache-sling-rewriter/blob/4d1952648e35e7001236f282040a78479f7726d4/src/main/java/org/apache/sling/rewriter/impl/ProcessorManagerImpl.java#L69). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12245) Sling Rewriter does not detect configuration changes coming in via move
[ https://issues.apache.org/jira/browse/SLING-12245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17815605#comment-17815605 ] Carsten Ziegeler commented on SLING-12245: -- [~kwin] I'm not sure I fully understand the problem. You mention "When renaming a working rewriter pipeline config from /apps/system/config/rewriter2 to /apps/system/config/rewriter the following ResourceChange is received:..." which is ignored in ProcessorManagerImpl.onChange(...) So isn't the fix to not ignore the event? > Sling Rewriter does not detect configuration changes coming in via move > --- > > Key: SLING-12245 > URL: https://issues.apache.org/jira/browse/SLING-12245 > Project: Sling > Issue Type: Improvement >Affects Versions: Rewriter 1.3.10 >Reporter: Konrad Windszus >Priority: Major > > If one renames/moves a JCR node from {{/apps/my/config/invalid-rewriter}} to > {{/apps/my/config/rewriter}} the new rewriter configuration is not being > detected by the {{ProcessorManagerImpl}} due to the > {{ResourceChangeListener}} only being configured to listen for changes below > the {{rewriter}} resource > (https://github.com/apache/sling-org-apache-sling-rewriter/blob/4d1952648e35e7001236f282040a78479f7726d4/src/main/java/org/apache/sling/rewriter/impl/ProcessorManagerImpl.java#L69). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12247) Provide component property type for (External)ResourceChangeListener
[ https://issues.apache.org/jira/browse/SLING-12247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814809#comment-17814809 ] Carsten Ziegeler commented on SLING-12247: -- Looks ok to me > Provide component property type for (External)ResourceChangeListener > > > Key: SLING-12247 > URL: https://issues.apache.org/jira/browse/SLING-12247 > Project: Sling > Issue Type: Improvement >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > > In order to ease registration of Sling ResourceChangeListeners a [component > property type > |https://docs.osgi.org/specification/osgi.cmpn/7.0.0/service.component.html#service.component-component.property.types] > should be provided with elements for all supported properties. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12246) Support Event.NODE_MOVED in JcrResourceListener
[ https://issues.apache.org/jira/browse/SLING-12246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814722#comment-17814722 ] Carsten Ziegeler commented on SLING-12246: -- Sure. In theory there should be no need to handle a move event. But if there are cases where no added/removed combo is sent, then this should probably be fixed (best in Oak). > Support Event.NODE_MOVED in JcrResourceListener > --- > > Key: SLING-12246 > URL: https://issues.apache.org/jira/browse/SLING-12246 > Project: Sling > Issue Type: Improvement > Components: JCR >Affects Versions: JCR Resource 3.2.4 >Reporter: Konrad Windszus >Priority: Major > > Currently the event type NODE_MOVED > (https://developer.adobe.com/experience-manager/reference-materials/spec/jcr/2.0/12_Observation.html#12.3.3%20Event%20Information%20on%20Move%20and%20Order) > is not supported in {{JcrResourceListener}} > (https://github.com/apache/sling-org-apache-sling-jcr-resource/blob/8fb5a3d44de01f05964028debcf24531f2f65747/src/main/java/org/apache/sling/jcr/resource/internal/JcrResourceListener.java#L117). > Although the support in Oak is limited > (https://jackrabbit.apache.org/oak/docs/differences.html#observation) the > even type is still used. > IMHO it should be translated into two {{ResourceChange}} events: > # one change on the source path > # one change on the destination path > The path handling for > https://sling.apache.org/apidocs/sling12/org/apache/sling/api/resource/observation/ResourceChangeListener.html#PATHS > must be the same as for remove events (i.e. changed parent paths will also > trigger it) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12246) Support Event.NODE_MOVED in JcrResourceListener
[ https://issues.apache.org/jira/browse/SLING-12246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814717#comment-17814717 ] Carsten Ziegeler commented on SLING-12246: -- I read there "NODE_MOVED event, NODE_ADDED event for the root of the sub-tree only, NODE_REMOVED event for the root of the sub-tree only" > Support Event.NODE_MOVED in JcrResourceListener > --- > > Key: SLING-12246 > URL: https://issues.apache.org/jira/browse/SLING-12246 > Project: Sling > Issue Type: Improvement > Components: JCR >Affects Versions: JCR Resource 3.2.4 >Reporter: Konrad Windszus >Priority: Major > > Currently the event type NODE_MOVED > (https://developer.adobe.com/experience-manager/reference-materials/spec/jcr/2.0/12_Observation.html#12.3.3%20Event%20Information%20on%20Move%20and%20Order) > is not supported in {{JcrResourceListener}} > (https://github.com/apache/sling-org-apache-sling-jcr-resource/blob/8fb5a3d44de01f05964028debcf24531f2f65747/src/main/java/org/apache/sling/jcr/resource/internal/JcrResourceListener.java#L117). > Although the support in Oak is limited > (https://jackrabbit.apache.org/oak/docs/differences.html#observation) the > even type is still used. > IMHO it should be translated into two {{ResourceChange}} events: > # one change on the source path > # one change on the destination path > The path handling for > https://sling.apache.org/apidocs/sling12/org/apache/sling/api/resource/observation/ResourceChangeListener.html#PATHS > must be the same as for remove events (i.e. changed parent paths will also > trigger it) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12246) Support Event.NODE_MOVED in JcrResourceListener
[ https://issues.apache.org/jira/browse/SLING-12246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814714#comment-17814714 ] Carsten Ziegeler commented on SLING-12246: -- If I remember correctly, we skipped implementing explicit support for the "moved" event as a add/remove events were sent in addition anyway. > Support Event.NODE_MOVED in JcrResourceListener > --- > > Key: SLING-12246 > URL: https://issues.apache.org/jira/browse/SLING-12246 > Project: Sling > Issue Type: Improvement > Components: JCR >Affects Versions: JCR Resource 3.2.4 >Reporter: Konrad Windszus >Priority: Major > > Currently the event type NODE_MOVED > (https://developer.adobe.com/experience-manager/reference-materials/spec/jcr/2.0/12_Observation.html#12.3.3%20Event%20Information%20on%20Move%20and%20Order) > is not supported in {{JcrResourceListener}} > (https://github.com/apache/sling-org-apache-sling-jcr-resource/blob/8fb5a3d44de01f05964028debcf24531f2f65747/src/main/java/org/apache/sling/jcr/resource/internal/JcrResourceListener.java#L117). > Although the support in Oak is limited > (https://jackrabbit.apache.org/oak/docs/differences.html#observation) the > even type is still used. > IMHO it should be translated into two {{ResourceChange}} events: > # one change on the source path > # one change on the destination path > The path handling for > https://sling.apache.org/apidocs/sling12/org/apache/sling/api/resource/observation/ResourceChangeListener.html#PATHS > must be the same as for remove events (i.e. changed parent paths will also > trigger it) -- This message was sent by Atlassian Jira (v8.20.10#820010)
CVE-2024-23673: Apache Sling Servlets Resolver: Malicious code execution via path traversal
Affected versions: - Apache Sling Servlets Resolver before 2.11.0 Description: Malicious code execution via path traversal in Apache Software Foundation Apache Sling Servlets Resolver.This issue affects all version of Apache Sling Servlets Resolver before 2.11.0. However, whether a system is vulnerable to this attack depends on the exact configuration of the system. If the system is vulnerable, a user with write access to the repository might be able to trick the Sling Servlet Resolver to load a previously uploaded script. Users are recommended to upgrade to version 2.11.0, which fixes this issue. It is recommended to upgrade, regardless of whether your system configuration currently allows this attack or not. This issue is being tracked as SLING-12233 References: https://sling.apache.org/ https://www.cve.org/CVERecord?id=CVE-2024-23673 https://issues.apache.org/jira/browse/SLING-12233
Re: Sling Model Caching & GC problems
Sure, no problem with using a WeakHashMap. Regards Carsten On 30.01.2024 10:28, Jörg Hoh wrote: Paul, thanks for your mail. I agree to your observation what's going on. I also think that cache at the ResourceResolver level makes more sense, and it's easier to control and remove cached models, which cannot be used any more. @Carsten: Regarding the size, we can still use a WeakHashMap as a container for these Sling Models (and store the WeakHashMap in the PropertyMap of the ResourceResolver), and that should prevent the worst, even in case of a long-running ResourceResolver or many adaptions. Jörg Am Di., 30. Jan. 2024 um 07:16 Uhr schrieb Carsten Ziegeler < cziege...@apache.org>: I don't know much about sling models caching, but it seems storing the cache into the resource resolver and therefore binding it to that lifecycle sounds very reasonable to me. And due to the mentioned support for Closeable, the cache gets discarded automatically with the resolver being closed. No extra handling required, no soft references etc. needed. Obviously, that sounds problematic with long or forever running resource resolvers as the cache would never be released. However, I guess thats not worse than what we have today. And long running resource resolvers are an anti-pattern anyway. Regards Carsten On 23.01.2024 17:23, Paul Bjorkstrand wrote: Hi Jörg, My guess is that you are running up against the problem where the Model is referencing its adaptable, directly or indirectly. In that situation, the model would not be collectable because it is referenced more strongly than by weak reference. The reference path of these might look like this: Model Cache Holder (the Model Adapter Factory (strong reference) Model Cache (soft reference) Model (strong reference) Resource Resolver (strong reference, maybe indirectly) Resource [the adaptable] The resource is strongly or softly referenced, possibly indirectly, making it ineligible for collection on normal GC cycles. The resource & resolver, will not be collected until after the model is collected. Since the model is not collected until there is memory pressure, that would explain why you are seeing this (expensive) GC behavior. When memory pressure occurs, first the models (soft references) are collected prior to the OOM, which releases both resolver (no longer referenced via field in the model) and resource. The quickest fix is to release the resource resolver at the end of the model’s constructor or @PostConstruct [2]. Alternatively, you can eliminate the cache=true, provided it does not negatively impact your application performance. Another option, though more involved, is that the entire caching impl could be changed to better handle these kinds of reference loops, by putting the cache in the adaptable itself (Resolver, Resource, Request, etc). Possible good candidates of these are [4] or request attributes. [4] seems to be the overall best candidate, especially since you can hook into it using Closeable ([5]) improving the cache eviction even more. As long as the object holding the cache is not referenced strongly outside that reference loop (cache holder > cache > model > ... > cache holder), then the loop's objects would be eligible for GC as soon as the cache holder is eligible. [1]: https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/lang/ref/SoftReference.html [2]: https://sling.apache.org/documentation/bundles/models.html#a-note-about-cache-true-and-using-the-self-injector [3]: https://github.com/apache/sling-org-apache-sling-models-impl/pull/18 [4]: https://github.com/apache/sling-org-apache-sling-api/blob/master/src/main/java/org/apache/sling/api/resource/ResourceResolver.java#L888 [5]: https://github.com/apache/sling-org-apache-sling-api/blob/master/src/main/java/org/apache/sling/api/resource/ResourceResolver.java#L610 // Paul On Tue, Jan 23, 2024 at 6:48 AM Jörg Hoh .invalid> wrote: Hi Sling community, I want to share a recent experience I had with Sling Models, Sling Model caching and Garbage Collection problems. I had a case, where an AEM instance had massive garbage collection problems, but no memory problems. We saw the regular sawtooth pattern in the heap consumption, but heavy GC activity (in a stop-the-world manner) almost constantly. But no OutOfMemory situation, there it's not a memory leak. I manually captured a heapdump and found a lot of Sling models being referenced by the Sling ModelAdapterFactory cache, and rechecking these model classes in detail I found them to specify "cache=true" in their @Model annotation.When these statements were removed, the situation looks completely different, and the garbage collection was normal again. I don't have a full explanation for this behavior yet. The Sling Models had a reference to a ResourceResolver (which was properly closed), but I assume that this reference somehow "disabled&q
Re: Sling Model Caching & GC problems
I don't know much about sling models caching, but it seems storing the cache into the resource resolver and therefore binding it to that lifecycle sounds very reasonable to me. And due to the mentioned support for Closeable, the cache gets discarded automatically with the resolver being closed. No extra handling required, no soft references etc. needed. Obviously, that sounds problematic with long or forever running resource resolvers as the cache would never be released. However, I guess thats not worse than what we have today. And long running resource resolvers are an anti-pattern anyway. Regards Carsten On 23.01.2024 17:23, Paul Bjorkstrand wrote: Hi Jörg, My guess is that you are running up against the problem where the Model is referencing its adaptable, directly or indirectly. In that situation, the model would not be collectable because it is referenced more strongly than by weak reference. The reference path of these might look like this: Model Cache Holder (the Model Adapter Factory (strong reference) Model Cache (soft reference) Model (strong reference) Resource Resolver (strong reference, maybe indirectly) Resource [the adaptable] The resource is strongly or softly referenced, possibly indirectly, making it ineligible for collection on normal GC cycles. The resource & resolver, will not be collected until after the model is collected. Since the model is not collected until there is memory pressure, that would explain why you are seeing this (expensive) GC behavior. When memory pressure occurs, first the models (soft references) are collected prior to the OOM, which releases both resolver (no longer referenced via field in the model) and resource. The quickest fix is to release the resource resolver at the end of the model’s constructor or @PostConstruct [2]. Alternatively, you can eliminate the cache=true, provided it does not negatively impact your application performance. Another option, though more involved, is that the entire caching impl could be changed to better handle these kinds of reference loops, by putting the cache in the adaptable itself (Resolver, Resource, Request, etc). Possible good candidates of these are [4] or request attributes. [4] seems to be the overall best candidate, especially since you can hook into it using Closeable ([5]) improving the cache eviction even more. As long as the object holding the cache is not referenced strongly outside that reference loop (cache holder > cache > model > ... > cache holder), then the loop's objects would be eligible for GC as soon as the cache holder is eligible. [1]: https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/lang/ref/SoftReference.html [2]: https://sling.apache.org/documentation/bundles/models.html#a-note-about-cache-true-and-using-the-self-injector [3]: https://github.com/apache/sling-org-apache-sling-models-impl/pull/18 [4]: https://github.com/apache/sling-org-apache-sling-api/blob/master/src/main/java/org/apache/sling/api/resource/ResourceResolver.java#L888 [5]: https://github.com/apache/sling-org-apache-sling-api/blob/master/src/main/java/org/apache/sling/api/resource/ResourceResolver.java#L610 // Paul On Tue, Jan 23, 2024 at 6:48 AM Jörg Hoh wrote: Hi Sling community, I want to share a recent experience I had with Sling Models, Sling Model caching and Garbage Collection problems. I had a case, where an AEM instance had massive garbage collection problems, but no memory problems. We saw the regular sawtooth pattern in the heap consumption, but heavy GC activity (in a stop-the-world manner) almost constantly. But no OutOfMemory situation, there it's not a memory leak. I manually captured a heapdump and found a lot of Sling models being referenced by the Sling ModelAdapterFactory cache, and rechecking these model classes in detail I found them to specify "cache=true" in their @Model annotation.When these statements were removed, the situation looks completely different, and the garbage collection was normal again. I don't have a full explanation for this behavior yet. The Sling Models had a reference to a ResourceResolver (which was properly closed), but I assume that this reference somehow "disabled" the cleaning of the cache on major GCs (as its a WeakHashMap), but tied the collection of these models to the collection of the ResourceResolver objects, which have finalizers registered. And finalizers are only executed under memory pressure. Having this connetion might have led to the situation that the SlingModel objects were not disposed eagerly, but only alongside the finalizers in situation of high memory pressure in a "stop-the-world" situation. I try to get some more examples for that behavior; but I am not sure of the caching of Sling Models as-is is something we should continue to use. This case was quite hard to crack, and I don't know if/how we can avoid such a situation by design. Jörg -- https://cqdump.joe
Re: [VOTE] Release Apache Sling Commons Log 5.5.0
+1 Carsten On 29.01.2024 13:37, Robert Munteanu wrote: Hi, We solved 2 issues in this release: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12354154=Text Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2835/ You can use this UNIX script to download the release and verify the signatures: https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh Usage: sh check_staged_release.sh 2835 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards, Robert Munteanu -- Carsten Ziegeler Adobe cziege...@apache.org
[jira] [Closed] (SLING-12238) Prevent NullPointerException if global transformer returns null
[ https://issues.apache.org/jira/browse/SLING-12238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-12238. > Prevent NullPointerException if global transformer returns null > --- > > Key: SLING-12238 > URL: https://issues.apache.org/jira/browse/SLING-12238 > Project: Sling > Issue Type: Improvement > Components: General >Affects Versions: Rewriter 1.3.8 >Reporter: Carsten Ziegeler > Assignee: Carsten Ziegeler >Priority: Major > Fix For: Rewriter 1.3.10 > > > A TransformerFactory for a global transformer might return null for the > Transformer, similar the factory might already be gone. Both result in a null > value inserted into the array of global transformers. > Later on, when that array is processed, there is no null check anymore. > Potentially resulting in a NullPointerException > This should be guarded with a null check, as this might happen in a dynamic > system -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-12239) Create string representation of processing component configuration only once
[ https://issues.apache.org/jira/browse/SLING-12239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-12239. > Create string representation of processing component configuration only once > > > Key: SLING-12239 > URL: https://issues.apache.org/jira/browse/SLING-12239 > Project: Sling > Issue Type: Improvement > Components: General >Affects Versions: Rewriter 1.3.8 >Reporter: Carsten Ziegeler > Assignee: Carsten Ziegeler >Priority: Major > Fix For: Rewriter 1.3.10 > > > With SLING-12227 the "caching" of the processing component configuration got > accidentally removed. As this one is printed out with each and every html > request, we should only create it once. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-12233) Ignore resource type with invalid paths
[ https://issues.apache.org/jira/browse/SLING-12233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-12233. > Ignore resource type with invalid paths > --- > > Key: SLING-12233 > URL: https://issues.apache.org/jira/browse/SLING-12233 > Project: Sling > Issue Type: Improvement > Components: Servlets >Affects Versions: Servlets Resolver 2.10.0 >Reporter: Carsten Ziegeler > Assignee: Carsten Ziegeler >Priority: Major > Fix For: servlets resolver 2.11.0 > > > Most invalid resource types are already ignored as it relies on > ResourceUtil.normalize. However, path segments with more than two consecutive > dots are currently not ignored, leading to unexpected results. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[VOTE RESULT] Release Apache Sling Rewriter 1.3.10
The vote passed with four binding +1 votes Thanks Carsten -- Carsten Ziegeler Adobe cziege...@apache.org
[VOTE RESULT] Release Apache Sling Servlets Resolver 2.11.0
The vote passed with four binding +1 votes Thanks Carsten -- Carsten Ziegeler Adobe cziege...@apache.org
Re: [VOTE] Release Apache Sling Servlets Resolver 2.11.0
+1 Carsten On 24.01.2024 14:56, Carsten Ziegeler wrote: Hi, We solved 1 issues in this release https://issues.apache.org/jira/browse/SLING-12233 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2834/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2834 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards Carsten -- Carsten Ziegeler Adobe cziege...@apache.org
Re: [VOTE] Release Apache Sling Rewriter 1.3.10
+1 Carsten On 24.01.2024 07:07, Carsten Ziegeler wrote: Hi, We solved 2 issues in this release https://issues.apache.org/jira/projects/SLING/versions/12354138 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2833/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2833 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards Carsten -- Carsten Ziegeler Adobe cziege...@apache.org
[VOTE] Release Apache Sling Servlets Resolver 2.11.0
Hi, We solved 1 issues in this release https://issues.apache.org/jira/browse/SLING-12233 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2834/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2834 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards Carsten -- Carsten Ziegeler Adobe cziege...@apache.org
[VOTE] Release Apache Sling Rewriter 1.3.10
Hi, We solved 2 issues in this release https://issues.apache.org/jira/projects/SLING/versions/12354138 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2833/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2833 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards Carsten -- Carsten Ziegeler Adobe cziege...@apache.org
[jira] [Resolved] (SLING-12239) Create string representation of processing component configuration only once
[ https://issues.apache.org/jira/browse/SLING-12239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-12239. -- Resolution: Fixed https://github.com/apache/sling-org-apache-sling-rewriter/commit/7bbf8a52db191f2d59bc6c00fc86bf0a8235bf20 > Create string representation of processing component configuration only once > > > Key: SLING-12239 > URL: https://issues.apache.org/jira/browse/SLING-12239 > Project: Sling > Issue Type: Improvement > Components: General >Affects Versions: Rewriter 1.3.8 >Reporter: Carsten Ziegeler > Assignee: Carsten Ziegeler >Priority: Major > Fix For: Rewriter 1.3.10 > > > With SLING-12227 the "caching" of the processing component configuration got > accidentally removed. As this one is printed out with each and every html > request, we should only create it once. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12239) Create string representation of processing component configuration only once
Carsten Ziegeler created SLING-12239: Summary: Create string representation of processing component configuration only once Key: SLING-12239 URL: https://issues.apache.org/jira/browse/SLING-12239 Project: Sling Issue Type: Improvement Components: General Affects Versions: Rewriter 1.3.8 Reporter: Carsten Ziegeler Assignee: Carsten Ziegeler Fix For: Rewriter 1.3.10 With SLING-12227 the "caching" of the processing component configuration got accidentally removed. As this one is printed out with each and every html request, we should only create it once. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12211) Update Parent to 52 and make build compatible with Java 17 and above
[ https://issues.apache.org/jira/browse/SLING-12211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler updated SLING-12211: - Fix Version/s: Rewriter 1.3.12 (was: Rewriter 1.3.10) > Update Parent to 52 and make build compatible with Java 17 and above > > > Key: SLING-12211 > URL: https://issues.apache.org/jira/browse/SLING-12211 > Project: Sling > Issue Type: Improvement >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: Rewriter 1.3.12 > > > Updating to Parent 52 allows reproducible builds > (https://issues.apache.org/jira/browse/SLING-11907). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-12238) Prevent NullPointerException if global transformer returns null
[ https://issues.apache.org/jira/browse/SLING-12238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-12238. -- Resolution: Fixed https://github.com/apache/sling-org-apache-sling-rewriter/commit/bd45e2145a438899c487184ce388a579270495f0 > Prevent NullPointerException if global transformer returns null > --- > > Key: SLING-12238 > URL: https://issues.apache.org/jira/browse/SLING-12238 > Project: Sling > Issue Type: Improvement > Components: General >Affects Versions: Rewriter 1.3.8 >Reporter: Carsten Ziegeler > Assignee: Carsten Ziegeler >Priority: Major > Fix For: Rewriter 1.3.10 > > > A TransformerFactory for a global transformer might return null for the > Transformer, similar the factory might already be gone. Both result in a null > value inserted into the array of global transformers. > Later on, when that array is processed, there is no null check anymore. > Potentially resulting in a NullPointerException > This should be guarded with a null check, as this might happen in a dynamic > system -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12238) Prevent NullPointerException if global transformer returns null
Carsten Ziegeler created SLING-12238: Summary: Prevent NullPointerException if global transformer returns null Key: SLING-12238 URL: https://issues.apache.org/jira/browse/SLING-12238 Project: Sling Issue Type: Improvement Components: General Affects Versions: Rewriter 1.3.8 Reporter: Carsten Ziegeler Assignee: Carsten Ziegeler Fix For: Rewriter 1.3.10 A TransformerFactory for a global transformer might return null for the Transformer, similar the factory might already be gone. Both result in a null value inserted into the array of global transformers. Later on, when that array is processed, there is no null check anymore. Potentially resulting in a NullPointerException This should be guarded with a null check, as this might happen in a dynamic system -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-12232) Remove usage of httpclient 5
[ https://issues.apache.org/jira/browse/SLING-12232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-12232. > Remove usage of httpclient 5 > > > Key: SLING-12232 > URL: https://issues.apache.org/jira/browse/SLING-12232 > Project: Sling > Issue Type: Improvement > Components: Feature Model, Installer >Affects Versions: Feature Model Unpack Extension 0.3.0 >Reporter: Carsten Ziegeler > Assignee: Carsten Ziegeler >Priority: Major > Fix For: Feature Model Unpack Extension 0.4.0 > > > Version 0.3.0 introduced a dependency on httpclient5 which is not available > as an OSGi bundle. Therefore we should remove this dependency. > It seems, httpclient is only used in order to implement a retry loop, this > can be done without using that dependency. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12232) Remove usage of httpclient 5
[ https://issues.apache.org/jira/browse/SLING-12232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17809472#comment-17809472 ] Carsten Ziegeler commented on SLING-12232: -- Applied PR which removes dependency to httpclient completely > Remove usage of httpclient 5 > > > Key: SLING-12232 > URL: https://issues.apache.org/jira/browse/SLING-12232 > Project: Sling > Issue Type: Improvement > Components: Feature Model, Installer >Affects Versions: Feature Model Unpack Extension 0.3.0 >Reporter: Carsten Ziegeler > Assignee: Carsten Ziegeler >Priority: Major > Fix For: Feature Model Unpack Extension 0.4.0 > > > Version 0.3.0 introduced a dependency on httpclient5 which is not available > as an OSGi bundle. Therefore we should remove this dependency. > It seems, httpclient is only used in order to implement a retry loop, this > can be done without using that dependency. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-12232) Remove usage of httpclient 5
[ https://issues.apache.org/jira/browse/SLING-12232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-12232. -- Resolution: Fixed > Remove usage of httpclient 5 > > > Key: SLING-12232 > URL: https://issues.apache.org/jira/browse/SLING-12232 > Project: Sling > Issue Type: Improvement > Components: Feature Model, Installer >Affects Versions: Feature Model Unpack Extension 0.3.0 >Reporter: Carsten Ziegeler > Assignee: Carsten Ziegeler >Priority: Major > Fix For: Feature Model Unpack Extension 0.4.0 > > > Version 0.3.0 introduced a dependency on httpclient5 which is not available > as an OSGi bundle. Therefore we should remove this dependency. > It seems, httpclient is only used in order to implement a retry loop, this > can be done without using that dependency. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-12231) Replace javax.json with jakarta.json
[ https://issues.apache.org/jira/browse/SLING-12231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-12231. > Replace javax.json with jakarta.json > > > Key: SLING-12231 > URL: https://issues.apache.org/jira/browse/SLING-12231 > Project: Sling > Issue Type: Improvement > Components: Installer >Affects Versions: Installer Core 3.12.0 >Reporter: Carsten Ziegeler > Assignee: Carsten Ziegeler >Priority: Major > Fix For: Installer Core 3.14.0 > > > We should replace the usage of javax.json with jakarta.json -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-12097) Installer Core build fails with Java 17
[ https://issues.apache.org/jira/browse/SLING-12097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-12097. > Installer Core build fails with Java 17 > --- > > Key: SLING-12097 > URL: https://issues.apache.org/jira/browse/SLING-12097 > Project: Sling > Issue Type: Bug > Components: Installer >Reporter: Robert Munteanu >Assignee: Robert Munteanu >Priority: Major > Fix For: Installer Core 3.14.0 > > > [ERROR] Failed to execute goal > biz.aQute.bnd:bnd-maven-plugin:5.0.0:bnd-process (bnd-process) on project > org.apache.sling.installer.core: bnd error: null: > ConcurrentModificationException -> [Help 1] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[VOTE RESULT] Release Apache Sling Installer Core 3.14.0, Installer Factory Feature 0.8.0, Feature Extension Unpack 0.4.0
The vote passed with three binding +1 votes Thanks Carsten -- Carsten Ziegeler Adobe cziege...@apache.org
Re: [VOTE] Release Apache Sling Installer Core 3.14.0, Installer Factory Feature 0.8.0, Feature Extension Unpack 0.4.0
+1 Carsten On 19.01.2024 16:08, Carsten Ziegeler wrote: Hi, We solved 2 issues in installer core 3.14.0 https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12353713 We solved 1 issue for installer factory feature 0.8.0 https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12353494 We solved 2 issues for feature extension unpack 0.4.0 https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12351328 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2831/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2831 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards Carsten -- Carsten Ziegeler Adobe cziege...@apache.org
[VOTE] Release Apache Sling Installer Core 3.14.0, Installer Factory Feature 0.8.0, Feature Extension Unpack 0.4.0
Hi, We solved 2 issues in installer core 3.14.0 https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12353713 We solved 1 issue for installer factory feature 0.8.0 https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12353494 We solved 2 issues for feature extension unpack 0.4.0 https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12351328 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2831/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2831 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards Carsten -- Carsten Ziegeler Adobe cziege...@apache.org
[jira] [Closed] (SLING-11393) Escape characters in log entries
[ https://issues.apache.org/jira/browse/SLING-11393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-11393. > Escape characters in log entries > > > Key: SLING-11393 > URL: https://issues.apache.org/jira/browse/SLING-11393 > Project: Sling > Issue Type: Improvement > Components: Commons >Affects Versions: Commons Log 5.4.0 >Reporter: Carsten Ziegeler > Assignee: Carsten Ziegeler >Priority: Major > Fix For: Commons Log 5.4.2 > > > We should escape some characters in log messages and exception messages for a > better output. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12232) Remove usage of httpclient 5
[ https://issues.apache.org/jira/browse/SLING-12232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler updated SLING-12232: - Description: Version 0.3.0 introduced a dependency on httpclient5 which is not available as an OSGi bundle. Therefore we should remove this dependency. It seems, httpclient is only used in order to implement a retry loop, this can be done without using that dependency. was:Version 0.3.0 introduced a dependency on httpclient5 which is not available as an OSGi bundle. Therefore we should switch to httpclient4. > Remove usage of httpclient 5 > > > Key: SLING-12232 > URL: https://issues.apache.org/jira/browse/SLING-12232 > Project: Sling > Issue Type: Improvement > Components: Feature Model, Installer >Affects Versions: Feature Model Unpack Extension 0.3.0 >Reporter: Carsten Ziegeler > Assignee: Carsten Ziegeler >Priority: Major > Fix For: Feature Model Unpack Extension 0.4.0 > > > Version 0.3.0 introduced a dependency on httpclient5 which is not available > as an OSGi bundle. Therefore we should remove this dependency. > It seems, httpclient is only used in order to implement a retry loop, this > can be done without using that dependency. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12232) Remove usage of httpclient 5
[ https://issues.apache.org/jira/browse/SLING-12232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler updated SLING-12232: - Summary: Remove usage of httpclient 5 (was: Switch to Apache HttpClient 4) > Remove usage of httpclient 5 > > > Key: SLING-12232 > URL: https://issues.apache.org/jira/browse/SLING-12232 > Project: Sling > Issue Type: Improvement > Components: Feature Model, Installer >Affects Versions: Feature Model Unpack Extension 0.3.0 >Reporter: Carsten Ziegeler > Assignee: Carsten Ziegeler >Priority: Major > Fix For: Feature Model Unpack Extension 0.4.0 > > > Version 0.3.0 introduced a dependency on httpclient5 which is not available > as an OSGi bundle. Therefore we should switch to httpclient4. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-12233) Ignore resource type with invalid paths
[ https://issues.apache.org/jira/browse/SLING-12233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-12233. -- Resolution: Fixed https://github.com/apache/sling-org-apache-sling-servlets-resolver/commit/b54d4e6693e0bcd63a97a0328f4f065b8a81b75e > Ignore resource type with invalid paths > --- > > Key: SLING-12233 > URL: https://issues.apache.org/jira/browse/SLING-12233 > Project: Sling > Issue Type: Improvement > Components: Servlets >Affects Versions: Servlets Resolver 2.10.0 >Reporter: Carsten Ziegeler > Assignee: Carsten Ziegeler >Priority: Major > Fix For: servlets resolver 2.11.0 > > > Most invalid resource types are already ignored as it relies on > ResourceUtil.normalize. However, path segments with more than two consecutive > dots are currently not ignored, leading to unexpected results. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12233) Ignore resource type with invalid paths
Carsten Ziegeler created SLING-12233: Summary: Ignore resource type with invalid paths Key: SLING-12233 URL: https://issues.apache.org/jira/browse/SLING-12233 Project: Sling Issue Type: Improvement Components: Servlets Affects Versions: Servlets Resolver 2.10.0 Reporter: Carsten Ziegeler Assignee: Carsten Ziegeler Fix For: servlets resolver 2.11.0 Most invalid resource types are already ignored as it relies on ResourceUtil.normalize. However, path segments with more than two consecutive dots are currently not ignored, leading to unexpected results. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12232) Switch to Apache HttpClient 4
Carsten Ziegeler created SLING-12232: Summary: Switch to Apache HttpClient 4 Key: SLING-12232 URL: https://issues.apache.org/jira/browse/SLING-12232 Project: Sling Issue Type: Improvement Components: Feature Model, Installer Affects Versions: Feature Model Unpack Extension 0.3.0 Reporter: Carsten Ziegeler Assignee: Carsten Ziegeler Fix For: Feature Model Unpack Extension 0.3.2 Version 0.3.0 introduced a dependency on httpclient5 which is not available as an OSGi bundle. Therefore we should switch to httpclient4. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12231) Replace javax.json with jakarta.json
[ https://issues.apache.org/jira/browse/SLING-12231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler updated SLING-12231: - Affects Version/s: (was: Installer Factory Feature Model 0.7.0) > Replace javax.json with jakarta.json > > > Key: SLING-12231 > URL: https://issues.apache.org/jira/browse/SLING-12231 > Project: Sling > Issue Type: Improvement > Components: Installer >Affects Versions: Installer Core 3.12.0 >Reporter: Carsten Ziegeler > Assignee: Carsten Ziegeler >Priority: Major > Fix For: Installer Factory Feature Model 0.8.0, Installer Core > 3.14.0 > > > We should replace the usage of javax.json with jakarta.json -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-12231) Replace javax.json with jakarta.json
[ https://issues.apache.org/jira/browse/SLING-12231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-12231. -- Resolution: Fixed > Replace javax.json with jakarta.json > > > Key: SLING-12231 > URL: https://issues.apache.org/jira/browse/SLING-12231 > Project: Sling > Issue Type: Improvement > Components: Installer >Affects Versions: Installer Core 3.12.0 >Reporter: Carsten Ziegeler > Assignee: Carsten Ziegeler >Priority: Major > Fix For: Installer Core 3.14.0 > > > We should replace the usage of javax.json with jakarta.json -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12231) Replace javax.json with jakarta.json
[ https://issues.apache.org/jira/browse/SLING-12231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler updated SLING-12231: - Fix Version/s: (was: Installer Factory Feature Model 0.8.0) > Replace javax.json with jakarta.json > > > Key: SLING-12231 > URL: https://issues.apache.org/jira/browse/SLING-12231 > Project: Sling > Issue Type: Improvement > Components: Installer >Affects Versions: Installer Core 3.12.0 >Reporter: Carsten Ziegeler > Assignee: Carsten Ziegeler >Priority: Major > Fix For: Installer Core 3.14.0 > > > We should replace the usage of javax.json with jakarta.json -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12231) Replace javax.json with jakarta.json
[ https://issues.apache.org/jira/browse/SLING-12231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler updated SLING-12231: - Fix Version/s: Installer Factory Feature Model 0.8.0 > Replace javax.json with jakarta.json > > > Key: SLING-12231 > URL: https://issues.apache.org/jira/browse/SLING-12231 > Project: Sling > Issue Type: Improvement > Components: Installer >Affects Versions: Installer Core 3.12.0, Installer Factory Feature Model > 0.7.0 > Reporter: Carsten Ziegeler > Assignee: Carsten Ziegeler >Priority: Major > Fix For: Installer Factory Feature Model 0.8.0, Installer Core > 3.14.0 > > > We should replace the usage of javax.json with jakarta.json -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12231) Replace javax.json with jakarta.json
[ https://issues.apache.org/jira/browse/SLING-12231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler updated SLING-12231: - Affects Version/s: Installer Factory Feature Model 0.7.0 > Replace javax.json with jakarta.json > > > Key: SLING-12231 > URL: https://issues.apache.org/jira/browse/SLING-12231 > Project: Sling > Issue Type: Improvement > Components: Installer >Affects Versions: Installer Core 3.12.0, Installer Factory Feature Model > 0.7.0 > Reporter: Carsten Ziegeler > Assignee: Carsten Ziegeler >Priority: Major > Fix For: Installer Core 3.14.0 > > > We should replace the usage of javax.json with jakarta.json -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12231) Replace javax.json with jakarta.json
[ https://issues.apache.org/jira/browse/SLING-12231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808283#comment-17808283 ] Carsten Ziegeler commented on SLING-12231: -- Installer Core: https://github.com/apache/sling-org-apache-sling-installer-core/commit/ab56c53b4d0a5e9cb0fb5cfb6a1af465f5d80fef > Replace javax.json with jakarta.json > > > Key: SLING-12231 > URL: https://issues.apache.org/jira/browse/SLING-12231 > Project: Sling > Issue Type: Improvement > Components: Installer >Affects Versions: Installer Core 3.12.0 >Reporter: Carsten Ziegeler > Assignee: Carsten Ziegeler >Priority: Major > Fix For: Installer Core 3.12.2 > > > We should replace the usage of javax.json with jakarta.json -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12231) Replace javax.json with jakarta.json
Carsten Ziegeler created SLING-12231: Summary: Replace javax.json with jakarta.json Key: SLING-12231 URL: https://issues.apache.org/jira/browse/SLING-12231 Project: Sling Issue Type: Improvement Components: Installer Affects Versions: Installer Core 3.12.0 Reporter: Carsten Ziegeler Assignee: Carsten Ziegeler Fix For: Installer Core 3.12.2 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12231) Replace javax.json with jakarta.json
[ https://issues.apache.org/jira/browse/SLING-12231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler updated SLING-12231: - Description: We should replace the usage of javax.json with jakarta.json > Replace javax.json with jakarta.json > > > Key: SLING-12231 > URL: https://issues.apache.org/jira/browse/SLING-12231 > Project: Sling > Issue Type: Improvement > Components: Installer >Affects Versions: Installer Core 3.12.0 >Reporter: Carsten Ziegeler > Assignee: Carsten Ziegeler >Priority: Major > Fix For: Installer Core 3.12.2 > > > We should replace the usage of javax.json with jakarta.json -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-12228) Status printer does not display global transformers
[ https://issues.apache.org/jira/browse/SLING-12228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-12228. > Status printer does not display global transformers > --- > > Key: SLING-12228 > URL: https://issues.apache.org/jira/browse/SLING-12228 > Project: Sling > Issue Type: Improvement > Components: General >Affects Versions: Rewriter 1.3.6 >Reporter: Carsten Ziegeler > Assignee: Carsten Ziegeler >Priority: Major > Fix For: Rewriter 1.3.8 > > > Global transformers are currently not displayed at all on the status report -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-12227) Status printer does not properly display array values
[ https://issues.apache.org/jira/browse/SLING-12227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-12227. > Status printer does not properly display array values > - > > Key: SLING-12227 > URL: https://issues.apache.org/jira/browse/SLING-12227 > Project: Sling > Issue Type: Improvement > Components: General >Affects Versions: Rewriter 1.3.6 >Reporter: Carsten Ziegeler > Assignee: Carsten Ziegeler >Priority: Major > Fix For: Rewriter 1.3.8 > > > The status printer for the pipeline components does not properly display > array values, for example the current output looks like this: > {noformat} > Pipeline : > Generator : > htmlparser : {includeTags=[Ljava.lang.String;@19a2db46} > {noformat} -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-12230) Replace usage of Sling Commons OSGi with OSGi converter
[ https://issues.apache.org/jira/browse/SLING-12230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-12230. > Replace usage of Sling Commons OSGi with OSGi converter > --- > > Key: SLING-12230 > URL: https://issues.apache.org/jira/browse/SLING-12230 > Project: Sling > Issue Type: Improvement > Components: General > Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Rewriter 1.3.8 > > > We should replace the usage of Sling Commons OSGi with the OSGi converter to > remove all usage of commons osgi. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [VOTE] Release Apache Sling Rewriter 1.3.8
+1 Carsten On 15.01.2024 10:58, Carsten Ziegeler wrote: Hi, We solved 3 issues in this release: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12354083 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2828/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2828 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards Carsten -- Carsten Ziegeler Adobe cziege...@apache.org
[VOTE RESULT] Release Apache Sling Rewriter 1.3.8
The vote passed with four binding +1 votes Thanks Carsten -- Carsten Ziegeler Adobe cziege...@apache.org
Re: Order of steps in https://sling.apache.org/documentation/development/release-management.html
I think there is no perfect solution. We are operating this way for many years :) which of course doesn't mean there is no room for improvement. I think the scenario you describe happened at least once. but it was detected when the version was released, the jira issue corrected and all was good. This requires a little care of the release manager. but it really is more a theoretical issue. We have all the notifications flying around and usually if you are working on something you know that there is a vote for it going on. The Oak way shows a version as released although it is not, and might never be - which at least in theory can create confusion to users. So I prefer potentially confused release managers over potentially confused users :) Regards Carsten On 17.01.2024 11:02, Julian Reschke wrote: Hi there, the "Release Management" document suggests adding a new (next) release should happen after the release vote, and that the release being voted on remains "unreleased" in the meantime. Doesn't that leave us with a time windos of 72h+ hours in which issue tracking in Jira will be extremely ... awkward? What happens if somebody resolves an issue and enters the release currently under vote as "fixVersion"? (In Oak land, we do it the other way around; we create the "next" release first, and make the release being voted on as "released" when the vote starts). Best regards, Julian -- Carsten Ziegeler Adobe cziege...@apache.org
Re: [VOTE] Release Apache Sling Testing Clients 3.0.22
+1 Carsten On 15.01.2024 11:08, Andrei Dulvac wrote: Hi, We solved 5 issues in this release: https://issues.apache.org/jira/projects/SLING/versions/12353709 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2829/ You can use this UNIX script to download the release and verify the signatures: https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh Usage: sh check_staged_release.sh 2829 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. - Andrei -- Carsten Ziegeler Adobe cziege...@apache.org
[VOTE] Release Apache Sling Rewriter 1.3.8
Hi, We solved 3 issues in this release: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12354083 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2828/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2828 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards Carsten -- Carsten Ziegeler Adobe cziege...@apache.org
[jira] [Updated] (SLING-12211) Update Parent to 52 and make build compatible with Java 17 and above
[ https://issues.apache.org/jira/browse/SLING-12211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler updated SLING-12211: - Fix Version/s: Rewriter 1.3.10 (was: Rewriter 1.3.8) > Update Parent to 52 and make build compatible with Java 17 and above > > > Key: SLING-12211 > URL: https://issues.apache.org/jira/browse/SLING-12211 > Project: Sling > Issue Type: Improvement >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: Rewriter 1.3.10 > > > Updating to Parent 52 allows reproducible builds > (https://issues.apache.org/jira/browse/SLING-11907). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-12230) Replace usage of Sling Commons OSGi with OSGi converter
[ https://issues.apache.org/jira/browse/SLING-12230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-12230. -- Resolution: Fixed Changed in https://github.com/apache/sling-org-apache-sling-rewriter/commit/2960e0b480f53308a7184dc63dc45b958b46e6e6 > Replace usage of Sling Commons OSGi with OSGi converter > --- > > Key: SLING-12230 > URL: https://issues.apache.org/jira/browse/SLING-12230 > Project: Sling > Issue Type: Improvement > Components: General > Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Rewriter 1.3.8 > > > We should replace the usage of Sling Commons OSGi with the OSGi converter to > remove all usage of commons osgi. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12230) Replace usage of Sling Commons OSGi with OSGi converter
Carsten Ziegeler created SLING-12230: Summary: Replace usage of Sling Commons OSGi with OSGi converter Key: SLING-12230 URL: https://issues.apache.org/jira/browse/SLING-12230 Project: Sling Issue Type: Improvement Components: General Reporter: Carsten Ziegeler Assignee: Carsten Ziegeler Fix For: Rewriter 1.3.8 We should replace the usage of Sling Commons OSGi with the OSGi converter to remove all usage of commons osgi. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-12228) Status printer does not display global transformers
[ https://issues.apache.org/jira/browse/SLING-12228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-12228. -- Assignee: Carsten Ziegeler Resolution: Fixed Fixed in https://github.com/apache/sling-org-apache-sling-rewriter/commit/5ef0f8e0fe857fe03a5e1770838359fb654ecb1f > Status printer does not display global transformers > --- > > Key: SLING-12228 > URL: https://issues.apache.org/jira/browse/SLING-12228 > Project: Sling > Issue Type: Improvement > Components: General >Affects Versions: Rewriter 1.3.6 >Reporter: Carsten Ziegeler > Assignee: Carsten Ziegeler >Priority: Major > Fix For: Rewriter 1.3.8 > > > Global transformers are currently not displayed at all on the status report -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-12227) Status printer does not properly display array values
[ https://issues.apache.org/jira/browse/SLING-12227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-12227. -- Assignee: Carsten Ziegeler Resolution: Fixed https://github.com/apache/sling-org-apache-sling-rewriter/commit/a557549c07324aa0ec5797aba8181ade51731888 Also fixed the toString() method which suffered from the same problem > Status printer does not properly display array values > - > > Key: SLING-12227 > URL: https://issues.apache.org/jira/browse/SLING-12227 > Project: Sling > Issue Type: Improvement > Components: General >Affects Versions: Rewriter 1.3.6 >Reporter: Carsten Ziegeler > Assignee: Carsten Ziegeler >Priority: Major > Fix For: Rewriter 1.3.8 > > > The status printer for the pipeline components does not properly display > array values, for example the current output looks like this: > {noformat} > Pipeline : > Generator : > htmlparser : {includeTags=[Ljava.lang.String;@19a2db46} > {noformat} -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12228) Status printer does not display global transformers
Carsten Ziegeler created SLING-12228: Summary: Status printer does not display global transformers Key: SLING-12228 URL: https://issues.apache.org/jira/browse/SLING-12228 Project: Sling Issue Type: Improvement Components: General Affects Versions: Rewriter 1.3.6 Reporter: Carsten Ziegeler Fix For: Rewriter 1.3.8 Global transformers are currently not displayed at all on the status report -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12227) Status printer does not properly display array values
Carsten Ziegeler created SLING-12227: Summary: Status printer does not properly display array values Key: SLING-12227 URL: https://issues.apache.org/jira/browse/SLING-12227 Project: Sling Issue Type: Improvement Components: General Affects Versions: Rewriter 1.3.6 Reporter: Carsten Ziegeler Fix For: Rewriter 1.3.8 The status printer for the pipeline components does not properly display array values, for example the current output looks like this: {noformat} Pipeline : Generator : htmlparser : {includeTags=[Ljava.lang.String;@19a2db46} {noformat} -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (SLING-12225) resource resolver: revise documentation and naming of system properties for query paging
[ https://issues.apache.org/jira/browse/SLING-12225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804679#comment-17804679 ] Carsten Ziegeler edited comment on SLING-12225 at 1/9/24 10:39 AM: --- Given that this is a helper for implementation, I think there are three options: * no configurability at all * make it configurable in a special branch via whatever mechanism is appropriate * make it configurable in the main branch, but ensure to remove it before a release I would prefer one of the first two. And I agree we should use the same approach for both. was (Author: cziegeler): Given that this is a helper for implementation, I think there are three options: * no configurability at all * make it configurable in a special branch via whatever mechanism is appropriate * make it configurable in the main branch, but ensure to remove it before a release I would prefer one of the first two. And I agree we should use the same approach for both. > resource resolver: revise documentation and naming of system properties for > query paging > > > Key: SLING-12225 > URL: https://issues.apache.org/jira/browse/SLING-12225 > Project: Sling > Issue Type: Task >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > > See > https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/111#pullrequestreview-1792876455 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12225) resource resolver: revise documentation and naming of system properties for query paging
[ https://issues.apache.org/jira/browse/SLING-12225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804679#comment-17804679 ] Carsten Ziegeler commented on SLING-12225: -- Given that this is a helper for implementation, I think there are three options: * no configurability at all * make it configurable in a special branch via whatever mechanism is appropriate * make it configurable in the main branch, but ensure to remove it before a release I would prefer one of the first two. And I agree we should use the same approach for both. > resource resolver: revise documentation and naming of system properties for > query paging > > > Key: SLING-12225 > URL: https://issues.apache.org/jira/browse/SLING-12225 > Project: Sling > Issue Type: Task >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > > See > https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/111#pullrequestreview-1792876455 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12225) resource resolver: revise document and naming of system properties for paging
[ https://issues.apache.org/jira/browse/SLING-12225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804642#comment-17804642 ] Carsten Ziegeler commented on SLING-12225: -- Reading that thread, I'm wondering why this is configurable to begin with? It seems that there is no intention to make this configurable for users. The only reason seems to be for "debugging" - but then who is debugging this? Apparently not users. Making this configurable for the implementor to find the right value doesn't sound right to me, at least not in the main branch. > resource resolver: revise document and naming of system properties for paging > - > > Key: SLING-12225 > URL: https://issues.apache.org/jira/browse/SLING-12225 > Project: Sling > Issue Type: Task >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > > See > https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/111#pullrequestreview-1792876455 -- This message was sent by Atlassian Jira (v8.20.10#820010)