[GitHub] rombert commented on issue #6: Allow caching of virtual resources

2018-08-08 Thread GitBox 
rombert commented on issue #6: Allow caching of virtual resources
URL: 
https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/6#issuecomment-411333845
 
 
   All good now, thanks for seeing this through @AndreasWurm !


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rombert commented on issue #6: Allow caching of virtual resources

2018-08-06 Thread GitBox 
rombert commented on issue #6: Allow caching of virtual resources
URL: 
https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/6#issuecomment-410682232
 
 
   @AndreasWurm , yes, it makes sense since public methods were added to the 
exported/API class Configuration.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rombert commented on issue #6: Allow caching of virtual resources

2018-08-03 Thread GitBox 
rombert commented on issue #6: Allow caching of virtual resources
URL: 
https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/6#issuecomment-410269715
 
 
   @AndreasWurm the build now fails due to baseline checks
   
   ```
   [INFO] Comparing bundle org.apache.sling.dynamic-include version 
3.1.1-SNAPSHOT to version 3.1.0
   [INFO] 
   [INFO]   PACKAGE_NAME   DELTA  
CUR_VERBASE_VER   REC_VERWARNINGS  
   [INFO] = == == 
== == == ==
   [INFO] * org.apache.sling.dynamicincludeminor  4.0.0 
 4.0.0  4.1.0  Version increase required
   [INFO]  < class org.apache.sling.dynamicinclude.Configuration
   [INFO]  + method getExtension()
   [INFO]  + return java.lang.String
   [INFO]  + method 
hasExtension(org.apache.sling.api.SlingHttpServletRequest)
   [INFO]  + return boolean
   [INFO]  + method hasExtensionSet()
   [INFO]  + return boolean
   [INFO] 
---
   [INFO]   org.apache.sling.dynamicinclude.generator  unchanged  3.0.0 
 3.0.0  3.0.0  - 
   [INFO] 
---
   [INFO]   org.apache.sling.dynamicinclude.generator.typesunchanged  3.0.0 
 3.0.0  3.0.0  - 
   [INFO] 
---
   [INFO]   org.apache.sling.dynamicinclude.pathmatcherunchanged  3.0.0 
 3.0.0  3.0.0  - 
   [INFO] 
---
   [ERROR] org.apache.sling.dynamicinclude: Version increase required; detected 
4.0.0, suggested 4.1.0
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rombert commented on issue #6: Allow caching of virtual resources

2018-08-01 Thread GitBox 
rombert commented on issue #6: Allow caching of virtual resources
URL: 
https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/6#issuecomment-409552732
 
 
   I get compilation errors when building this module with your patch on top.
   
   ```
   [ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-compiler-plugin:3.2:testCompile 
(default-testCompile) on project org.apache.sling.dynamic-include: Compilation 
failure: Compilation failure: 
   [ERROR] 
/home/robert/Documents/sources/apache/sling/org-apache-sling-dynamic-include/src/test/java/org/apache/sling/dynamicinclude/impl/UrlBuilderTest.java:[45,41]
 method buildUrl in class org.apache.sling.dynamicinclude.impl.UrlBuilder 
cannot be applied to given types;
   [ERROR]   required: 
java.lang.String,java.lang.String,boolean,org.apache.sling.dynamicinclude.Configuration,org.apache.sling.api.request.RequestPathInfo
   [ERROR]   found: 
java.lang.String,java.lang.String,boolean,org.apache.sling.api.request.RequestPathInfo
   [ERROR]   reason: actual and formal argument lists differ in length
   [ERROR] 
/home/robert/Documents/sources/apache/sling/org-apache-sling-dynamic-include/src/test/java/org/apache/sling/dynamicinclude/impl/UrlBuilderTest.java:[56,41]
 method buildUrl in class org.apache.sling.dynamicinclude.impl.UrlBuilder 
cannot be applied to given types;
   [ERROR]   required: 
java.lang.String,java.lang.String,boolean,org.apache.sling.dynamicinclude.Configuration,org.apache.sling.api.request.RequestPathInfo
   [ERROR]   found: 
java.lang.String,java.lang.String,boolean,org.apache.sling.api.request.RequestPathInfo
   [ERROR]   reason: actual and formal argument lists differ in length
   [ERROR] 
/home/robert/Documents/sources/apache/sling/org-apache-sling-dynamic-include/src/test/java/org/apache/sling/dynamicinclude/impl/UrlBuilderTest.java:[67,41]
 method buildUrl in class org.apache.sling.dynamicinclude.impl.UrlBuilder 
cannot be applied to given types;
   [ERROR]   required: 
java.lang.String,java.lang.String,boolean,org.apache.sling.dynamicinclude.Configuration,org.apache.sling.api.request.RequestPathInfo
   [ERROR]   found: 
java.lang.String,java.lang.String,boolean,org.apache.sling.api.request.RequestPathInfo
   [ERROR]   reason: actual and formal argument lists differ in length
   [ERROR] 
/home/robert/Documents/sources/apache/sling/org-apache-sling-dynamic-include/src/test/java/org/apache/sling/dynamicinclude/impl/UrlBuilderTest.java:[78,41]
 method buildUrl in class org.apache.sling.dynamicinclude.impl.UrlBuilder 
cannot be applied to given types;
   [ERROR]   required: 
java.lang.String,java.lang.String,boolean,org.apache.sling.dynamicinclude.Configuration,org.apache.sling.api.request.RequestPathInfo
   [ERROR]   found: 
java.lang.String,java.lang.String,boolean,org.apache.sling.api.request.RequestPathInfo
   [ERROR]   reason: actual and formal argument lists differ in length
   [ERROR] 
/home/robert/Documents/sources/apache/sling/org-apache-sling-dynamic-include/src/test/java/org/apache/sling/dynamicinclude/impl/UrlBuilderTest.java:[89,41]
 method buildUrl in class org.apache.sling.dynamicinclude.impl.UrlBuilder 
cannot be applied to given types;
   [ERROR]   required: 
java.lang.String,java.lang.String,boolean,org.apache.sling.dynamicinclude.Configuration,org.apache.sling.api.request.RequestPathInfo
   [ERROR]   found: 
java.lang.String,java.lang.String,boolean,org.apache.sling.api.request.RequestPathInfo
   [ERROR]   reason: actual and formal argument lists differ in length
   [ERROR] 
/home/robert/Documents/sources/apache/sling/org-apache-sling-dynamic-include/src/test/java/org/apache/sling/dynamicinclude/impl/UrlBuilderTest.java:[100,41]
 method buildUrl in class org.apache.sling.dynamicinclude.impl.UrlBuilder 
cannot be applied to given types;
   [ERROR]   required: 
java.lang.String,java.lang.String,boolean,org.apache.sling.dynamicinclude.Configuration,org.apache.sling.api.request.RequestPathInfo
   [ERROR]   found: 
java.lang.String,java.lang.String,boolean,org.apache.sling.api.request.RequestPathInfo
   [ERROR]   reason: actual and formal argument lists differ in length
   [ERROR] -> [Help 1]
   [ERROR] 
   [ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
switch.
   [ERROR] Re-run Maven using the -X switch to enable full debug logging.
   [ERROR] 
   [ERROR] For more information about the errors and possible solutions, please 
read the following articles:
   [ERROR] [Help 1] 
http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
   ```
   
   I'm using 
   
   ```
   $ mvn -v
   Maven home: /usr/share/java/maven
   Java version: 1.8.0_171, vendor: Oracle Corporation, runtime: 
/usr/lib64/jvm/java-1.8.0-openjdk-1.8.0/jre
   Default locale: en_US, platform encoding: UTF-8
   OS name: "linux", version: "4.17.9-1-default", arch: "amd64", family: "unix"
   ```
   
   Does this happen at your end as well?

[GitHub] rombert commented on issue #6: Allow caching of virtual resources

2018-07-31 Thread GitBox 
rombert commented on issue #6: Allow caching of virtual resources
URL: 
https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/6#issuecomment-409280544
 
 
   Looks good to me, thanks for the updates @AndreasWurm . One final request - 
I applied #5 as i finished its review first. Can you please rebase your commit?
   
   After that there should be no issue in applying your PR and starting a 
release since the other open PRs are kind of stale.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rombert commented on issue #6: Allow caching of virtual resources

2018-07-25 Thread GitBox 
rombert commented on issue #6: Allow caching of virtual resources
URL: 
https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/6#issuecomment-407727401
 
 
   @AndreasWurm - can you please open a SLING Jira issue so be can better track 
this? The issue should be referenced in the commit title.
   
Also, we prefer single commits for fixes, so please squash your commits


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services