[RESULT][VOTE] Release Apache Sling Testing Clients version 2.0.0 and Apache Sling Testing Rules version 2.0.0

2020-04-09 Thread Andrei Dulvac
Hi,

The vote has passed with the following result :

+1 (binding): Daniel, Robert, Andrei

No -1 votes

I will copy this release to the Sling dist directory and
promote the artifacts to the central Maven repository.

Thanks,
- Andrei

On Tue, Apr 7, 2020 at 12:51 PM Andrei Dulvac  wrote:

> Hi Robert.
>
> The reasoning is that for the testing clients, which is packaged as a
> bundle, I still like to use semver  for the maven version, even though not
> strictly required.
>
> For the testing rules, it's a bit trickier, but the reasoning is the
> testing clients are supposed to be used as a transient dependency by the
> end user.
>
> I'll have a think about the overall strategy. I don't think a major
> version bump is a problem, but it's a valid point, for sure.
>
> Here's my +1 as well.
>
> Thanks
> Andrei
>
> On Tue, 7 Apr 2020 at 10:43, Robert Munteanu  wrote:
>
>> On Mon, 2020-04-06 at 15:20 +0200, Andrei Dulvac wrote:
>> > Please vote to approve this release:
>>
>> +1
>>
>> As a side note, do you really want a 2.0 version? From a "marketing"
>> point of view these don't add much - the testing rules just has two
>> bugfixes.
>>
>> It does not hurt anything, but then again consumers might be suprised.
>>
>> Robert
>>
>


Re: [VOTE] Release Apache Sling Testing Clients version 2.0.0 and Apache Sling Testing Rules version 2.0.0

2020-04-07 Thread Andrei Dulvac
Hi Robert.

The reasoning is that for the testing clients, which is packaged as a
bundle, I still like to use semver  for the maven version, even though not
strictly required.

For the testing rules, it's a bit trickier, but the reasoning is the
testing clients are supposed to be used as a transient dependency by the
end user.

I'll have a think about the overall strategy. I don't think a major version
bump is a problem, but it's a valid point, for sure.

Here's my +1 as well.

Thanks
Andrei

On Tue, 7 Apr 2020 at 10:43, Robert Munteanu  wrote:

> On Mon, 2020-04-06 at 15:20 +0200, Andrei Dulvac wrote:
> > Please vote to approve this release:
>
> +1
>
> As a side note, do you really want a 2.0 version? From a "marketing"
> point of view these don't add much - the testing rules just has two
> bugfixes.
>
> It does not hurt anything, but then again consumers might be suprised.
>
> Robert
>


Re: [VOTE] Release Apache Sling Testing Clients version 2.0.0 and Apache Sling Testing Rules version 2.0.0

2020-04-07 Thread Robert Munteanu
On Mon, 2020-04-06 at 15:20 +0200, Andrei Dulvac wrote:
> Please vote to approve this release:

+1

As a side note, do you really want a 2.0 version? From a "marketing"
point of view these don't add much - the testing rules just has two
bugfixes.

It does not hurt anything, but then again consumers might be suprised.

Robert


signature.asc
Description: This is a digitally signed message part


Re: [VOTE] Release Apache Sling Testing Clients version 2.0.0 and Apache Sling Testing Rules version 2.0.0

2020-04-06 Thread Daniel Klco
+1

On Mon, Apr 6, 2020 at 9:20 AM Andrei Dulvac  wrote:

> Hi,
> We solved 5 issues across those two releases
>
>
> https://issues.apache.org/jira/projects/SLING/versions/12347772
>
> https://issues.apache.org/jira/projects/SLING/versions/12344767
>
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-2236
>
>
> You can use this UNIX script to download the release and verify the
> signatures:
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
>
> Usage:
> sh check_staged_release.sh 2236 /tmp/sling-staging
>
>
>
> Please vote to approve this release:
>
>   [ ] +1 Approve the release
>   [ ]  0 Don't care
>   [ ] -1 Don't release, because ...
>
> This majority vote is open for at least 72 hours.
>
>
> -Andrei
>


[VOTE] Release Apache Sling Testing Clients version 2.0.0 and Apache Sling Testing Rules version 2.0.0

2020-04-06 Thread Andrei Dulvac
Hi,
We solved 5 issues across those two releases


https://issues.apache.org/jira/projects/SLING/versions/12347772

https://issues.apache.org/jira/projects/SLING/versions/12344767

Staging 
repository:https://repository.apache.org/content/repositories/orgapachesling-2236


You can use this UNIX script to download the release and verify the
signatures:https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2236 /tmp/sling-staging



Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.


-Andrei