[jira] [Commented] (SLING-4001) Apache Sling Resource Editor contribution
[ https://issues.apache.org/jira/browse/SLING-4001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14188514#comment-14188514 ] Sandro Boehme commented on SLING-4001: -- ++ Building without OSGi OBR deployment ++ The JSTL libraries are already part of the launchpad in the mean time. This makes the JSNodeTypes dependency the only one right now that one needs to put into the running Sling instance before being able to install it to the server. This dependency would have to be embedded into the final Maven artifact in order for the Maven-Sling-Plugin to be able to upload it to the server on install. But if it would be already part of a running Sling instance then that would add an unnecessary copy of this or other potential library that might be added later on. Instead I would like to keep the inconvenient requirement that one needs to deploy the Resource-Editor via the OBR before in order to be able to install it to the server. But only as long as the Resource-Editor is located in contrib. If it is later moved to the launchpad I would like to add the JSNodeTypes library there as well. Then the installation will be simple and convenient again. This way the Resource-Editor can easily be installed to a Sling instance using an OBR when no build is needed while no libraries are embedded. ++ Is it needed to specify the Import-Packages manually? ++ Yes, it is needed. This is because the Bnd tool does not detect import statements and taglib statements from the JSPs and thus would not create the Import-Package statements for the JSTL taglibs [1]. The next patch for the Resource-Editor will contain the Import-Package statements that resolve to the libraries that are currently part of the Launchpad and don't add new dependencies for the Taglibs as it is the case in the initial contribution. The duplicated imports will also be removed. ++ getting rid of the Require-Bundle ++ As David Bosschaert pointed [2] out there are two ways. Using the capabilities/requirements model and using a fake package. Sadly the capabilities/requirements model doesn't work with the OBR as it doesn't support the require-capability header [3]. This is why I will use the fake "package" in the upcoming patch for the Resource-Editor. [1] - http://apache-felix.18485.x6.nabble.com/maven-bundle-plugin-add-JSTL-libraries-to-the-OSGi-imports-tp5010333p5010335.html [2] - http://mail-archives.apache.org/mod_mbox/sling-dev/201410.mbox/%3ccamit8sohpjua0orjdbb3w2imftjwmbng7d60qmo6temslgr...@mail.gmail.com%3E [3] - http://mail-archives.apache.org/mod_mbox/felix-users/201410.mbox/%3CetPan.544e6915.643c9869.30b7%40Endofunctor.local%3E > Apache Sling Resource Editor contribution > - > > Key: SLING-4001 > URL: https://issues.apache.org/jira/browse/SLING-4001 > Project: Sling > Issue Type: New Feature >Reporter: Sandro Boehme >Assignee: Bertrand Delacretaz > Attachments: apache _sling_resource_editor.zip > > > Based on the discussion at the dev list [1, 2] I would like to contribute the > Apache Sling Resource Editor (previously named JCRBrowser and Apache Sling > Content Editor). > ++ Features ++ > Currently it can be used to rename and delete nodes. Rename works by double > clicking the node and you can multi select nodes for the deletion with the > 'del' key. The node names are HTML and URL escaped and it provides stateless > deep links to the nodes. > ++ Further development ++ > In the months to come I can work more intensely on the Sling Resource Editor > and I might add commercial add-ons separately. This is why I would like to be > able to point users to such an add-on from Sling. But judging from other > Apache projects [6] I assume this is probably not a problem. > I will continue the development at GitHub[7] and send patch files to Sling > when new features are implemented. > ++ Implementation ++ > It uses the Sling API. > For the tree on the left the JSTree library is used. It expects a URL to a > JSON that contains the data for the child nodes. This URL points to a > Sling resource with a 'reseditor.nodes' selector and a 'json' extension. This > way the JSPs [3] render the JSON for the resource that is consumed by the > JSTree library. > For the deletion and renaming of nodes I use jQuery Ajax calls to the Sling > POST servlet. > The properties list on the right is rendered [4] using JSTL and the > currentNode variable of Sling. > The html.jsp is registered for the 'reseditor' selector relatively to the > default servlet. And for not getting overruled by servlets registered by > paths and by other resources that are using the 'reseditor' selector I use a > ResourceDecorator [5]. > After a hint from Dominik Süß I work on using a ResourceProvider instead. > I'm looking forward to your feedback
[jira] [Commented] (SLING-4001) Apache Sling Resource Editor contribution
[ https://issues.apache.org/jira/browse/SLING-4001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14182627#comment-14182627 ] Sandro Boehme commented on SLING-4001: -- I was just weighing between embedding the library vs. requiring the library as I have to get the dependency in any way. As I said I think "The Require-Bundle _isn't_ good practice". Which means I fully agree and you preach to the converted ;-). I will ask on the dev list as Bertrand said. Maybe there is a better alternative. > Apache Sling Resource Editor contribution > - > > Key: SLING-4001 > URL: https://issues.apache.org/jira/browse/SLING-4001 > Project: Sling > Issue Type: New Feature >Reporter: Sandro Boehme >Assignee: Bertrand Delacretaz > Attachments: apache _sling_resource_editor.zip > > > Based on the discussion at the dev list [1, 2] I would like to contribute the > Apache Sling Resource Editor (previously named JCRBrowser and Apache Sling > Content Editor). > ++ Features ++ > Currently it can be used to rename and delete nodes. Rename works by double > clicking the node and you can multi select nodes for the deletion with the > 'del' key. The node names are HTML and URL escaped and it provides stateless > deep links to the nodes. > ++ Further development ++ > In the months to come I can work more intensely on the Sling Resource Editor > and I might add commercial add-ons separately. This is why I would like to be > able to point users to such an add-on from Sling. But judging from other > Apache projects [6] I assume this is probably not a problem. > I will continue the development at GitHub[7] and send patch files to Sling > when new features are implemented. > ++ Implementation ++ > It uses the Sling API. > For the tree on the left the JSTree library is used. It expects a URL to a > JSON that contains the data for the child nodes. This URL points to a > Sling resource with a 'reseditor.nodes' selector and a 'json' extension. This > way the JSPs [3] render the JSON for the resource that is consumed by the > JSTree library. > For the deletion and renaming of nodes I use jQuery Ajax calls to the Sling > POST servlet. > The properties list on the right is rendered [4] using JSTL and the > currentNode variable of Sling. > The html.jsp is registered for the 'reseditor' selector relatively to the > default servlet. And for not getting overruled by servlets registered by > paths and by other resources that are using the 'reseditor' selector I use a > ResourceDecorator [5]. > After a hint from Dominik Süß I work on using a ResourceProvider instead. > I'm looking forward to your feedback! > [1] - http://comments.gmane.org/gmane.comp.apache.sling.devel/47292 > [2] - http://comments.gmane.org/gmane.comp.apache.sling.devel/47517 > [3] - > https://github.com/sandroboehme/resourceeditor/tree/master/src/main/resources/SLING-INF/libs/sling/servlet/default/reseditor > [4] - > https://github.com/sandroboehme/resourceeditor/blob/master/src/main/resources/SLING-INF/libs/sling/servlet/default/reseditor/html.jsp > line 174 > [5] - > https://github.com/sandroboehme/resourceeditor/blob/master/src/main/java/org/apache/sling/reseditor/SelectorBasedResourceDecorator.java > [6] - https://www.google.de/search?q=site%3Aapache.org+commercial > [7] - https://github.com/sandroboehme/resourceeditor -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-4001) Apache Sling Resource Editor contribution
[ https://issues.apache.org/jira/browse/SLING-4001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14182602#comment-14182602 ] Felix Meschberger commented on SLING-4001: -- bq. The Require-Bundle isn't good practice but clean from an OSGi point of view Require-Bundle is actually bad practice and not clean at all from an OSGi point of view. In my (and other's) opinion Require-Bundle is actually an anti-pattern and a specification mistake. For backgrounds: AFAICT it was introduced into the spec under pressure from Eclipse to help Eclipse migrate over to OSGi. Not sure whether the Eclipse community would still push for it if they knew then what they know now. The problem with Require-Bundle is that (a) it creates tricky class loading situations, (b) it actually creates strong coupling, and (c) it "wires" to a deployment container rather than to its contents. I think the latter point is the most problematic: Require-Bundle binds to a named container of anything. And by anything I mean anything: It may be the expected classes today but may not be tomorrow. Bundles and Jar files being containers don't define a contract, they just happen to be collections of something. Contrast this to Java Packages which have been defined as a way to "namespace" the Java class space. Classes access other classes through fully qualified class names which are made up of package names and (simple) class names. Such class loading cares for packages and not for the containers of those packages. Hence declaring the dependency on the actual namespace through Import-Package is much closer to the truth and reality than declaring the dependency on the semi-random container. About strong coupling: If your bundle depends on the the XYZ container and the provider of XYZ decides to split the functionality into XYA and XYB, your bundle needs to at least be rebuilt to cope with the new containers -- even if functionally nothing has changed. So, please, don't use Require-Bundle and if I would be stating one rule in Sling it would be "say no to Require-Bundle". Thank you very much. > Apache Sling Resource Editor contribution > - > > Key: SLING-4001 > URL: https://issues.apache.org/jira/browse/SLING-4001 > Project: Sling > Issue Type: New Feature >Reporter: Sandro Boehme >Assignee: Bertrand Delacretaz > Attachments: apache _sling_resource_editor.zip > > > Based on the discussion at the dev list [1, 2] I would like to contribute the > Apache Sling Resource Editor (previously named JCRBrowser and Apache Sling > Content Editor). > ++ Features ++ > Currently it can be used to rename and delete nodes. Rename works by double > clicking the node and you can multi select nodes for the deletion with the > 'del' key. The node names are HTML and URL escaped and it provides stateless > deep links to the nodes. > ++ Further development ++ > In the months to come I can work more intensely on the Sling Resource Editor > and I might add commercial add-ons separately. This is why I would like to be > able to point users to such an add-on from Sling. But judging from other > Apache projects [6] I assume this is probably not a problem. > I will continue the development at GitHub[7] and send patch files to Sling > when new features are implemented. > ++ Implementation ++ > It uses the Sling API. > For the tree on the left the JSTree library is used. It expects a URL to a > JSON that contains the data for the child nodes. This URL points to a > Sling resource with a 'reseditor.nodes' selector and a 'json' extension. This > way the JSPs [3] render the JSON for the resource that is consumed by the > JSTree library. > For the deletion and renaming of nodes I use jQuery Ajax calls to the Sling > POST servlet. > The properties list on the right is rendered [4] using JSTL and the > currentNode variable of Sling. > The html.jsp is registered for the 'reseditor' selector relatively to the > default servlet. And for not getting overruled by servlets registered by > paths and by other resources that are using the 'reseditor' selector I use a > ResourceDecorator [5]. > After a hint from Dominik Süß I work on using a ResourceProvider instead. > I'm looking forward to your feedback! > [1] - http://comments.gmane.org/gmane.comp.apache.sling.devel/47292 > [2] - http://comments.gmane.org/gmane.comp.apache.sling.devel/47517 > [3] - > https://github.com/sandroboehme/resourceeditor/tree/master/src/main/resources/SLING-INF/libs/sling/servlet/default/reseditor > [4] - > https://github.com/sandroboehme/resourceeditor/blob/master/src/main/resources/SLING-INF/libs/sling/servlet/default/reseditor/html.jsp > line 174 > [5] - > https://github.com/sandroboehme/resourceeditor/blob/master/src/main/java/org/apache/sling/reseditor/Sele
[jira] [Commented] (SLING-4001) Apache Sling Resource Editor contribution
[ https://issues.apache.org/jira/browse/SLING-4001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14182590#comment-14182590 ] Bertrand Delacretaz commented on SLING-4001: I don't think we are using require-bundle so far in Sling, so if we can avoid it that's much better. It might be better to discuss such things on the dev list so that others can chime in, it's more of a general best practices discussion that specific to just this issue. > Apache Sling Resource Editor contribution > - > > Key: SLING-4001 > URL: https://issues.apache.org/jira/browse/SLING-4001 > Project: Sling > Issue Type: New Feature >Reporter: Sandro Boehme >Assignee: Bertrand Delacretaz > Attachments: apache _sling_resource_editor.zip > > > Based on the discussion at the dev list [1, 2] I would like to contribute the > Apache Sling Resource Editor (previously named JCRBrowser and Apache Sling > Content Editor). > ++ Features ++ > Currently it can be used to rename and delete nodes. Rename works by double > clicking the node and you can multi select nodes for the deletion with the > 'del' key. The node names are HTML and URL escaped and it provides stateless > deep links to the nodes. > ++ Further development ++ > In the months to come I can work more intensely on the Sling Resource Editor > and I might add commercial add-ons separately. This is why I would like to be > able to point users to such an add-on from Sling. But judging from other > Apache projects [6] I assume this is probably not a problem. > I will continue the development at GitHub[7] and send patch files to Sling > when new features are implemented. > ++ Implementation ++ > It uses the Sling API. > For the tree on the left the JSTree library is used. It expects a URL to a > JSON that contains the data for the child nodes. This URL points to a > Sling resource with a 'reseditor.nodes' selector and a 'json' extension. This > way the JSPs [3] render the JSON for the resource that is consumed by the > JSTree library. > For the deletion and renaming of nodes I use jQuery Ajax calls to the Sling > POST servlet. > The properties list on the right is rendered [4] using JSTL and the > currentNode variable of Sling. > The html.jsp is registered for the 'reseditor' selector relatively to the > default servlet. And for not getting overruled by servlets registered by > paths and by other resources that are using the 'reseditor' selector I use a > ResourceDecorator [5]. > After a hint from Dominik Süß I work on using a ResourceProvider instead. > I'm looking forward to your feedback! > [1] - http://comments.gmane.org/gmane.comp.apache.sling.devel/47292 > [2] - http://comments.gmane.org/gmane.comp.apache.sling.devel/47517 > [3] - > https://github.com/sandroboehme/resourceeditor/tree/master/src/main/resources/SLING-INF/libs/sling/servlet/default/reseditor > [4] - > https://github.com/sandroboehme/resourceeditor/blob/master/src/main/resources/SLING-INF/libs/sling/servlet/default/reseditor/html.jsp > line 174 > [5] - > https://github.com/sandroboehme/resourceeditor/blob/master/src/main/java/org/apache/sling/reseditor/SelectorBasedResourceDecorator.java > [6] - https://www.google.de/search?q=site%3Aapache.org+commercial > [7] - https://github.com/sandroboehme/resourceeditor -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-4001) Apache Sling Resource Editor contribution
[ https://issues.apache.org/jira/browse/SLING-4001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14182066#comment-14182066 ] Sandro Boehme commented on SLING-4001: -- ++ Building without OSGi OBR deployment ++ I use the JSTL core and the JSTL functions TagLib with the Servlet 2.5 spec. I removed the Import-Package statement to test if I can install the Resource Editor but I don't get an error and it is not yet successful. It looks like JSTL and Servlet 2.5 are already part of the Sling Launchpad v7. Then the build should generally work without an OSGi deployment by just using Maven. What command did you use to build the project and to get the error? ++ Is it needed to specify the Import-Packages manually? ++ I also think that the JSP scripting engine has access to the exported packages. There are people out there that use a modified version of the Launchpad right? By resolving the dependencies via OSGi they would still get all the dependencies that the Resource-Editor needs because they are specified in the pom right? If they wouldn't be specified I think these people would have a hard time getting the dependencies right. ++ Require-Bundle vs. embedding the JSNodeTypes library ++ What would be better then? The Require-Bundle isn't good practice but clean from an OSGi point of view and if there isn't a way to do that using import-package based dependencies then this might be one of the rare cases where the Require-Bundle makes sense. > Apache Sling Resource Editor contribution > - > > Key: SLING-4001 > URL: https://issues.apache.org/jira/browse/SLING-4001 > Project: Sling > Issue Type: New Feature >Reporter: Sandro Boehme >Assignee: Bertrand Delacretaz > Attachments: apache _sling_resource_editor.zip > > > Based on the discussion at the dev list [1, 2] I would like to contribute the > Apache Sling Resource Editor (previously named JCRBrowser and Apache Sling > Content Editor). > ++ Features ++ > Currently it can be used to rename and delete nodes. Rename works by double > clicking the node and you can multi select nodes for the deletion with the > 'del' key. The node names are HTML and URL escaped and it provides stateless > deep links to the nodes. > ++ Further development ++ > In the months to come I can work more intensely on the Sling Resource Editor > and I might add commercial add-ons separately. This is why I would like to be > able to point users to such an add-on from Sling. But judging from other > Apache projects [6] I assume this is probably not a problem. > I will continue the development at GitHub[7] and send patch files to Sling > when new features are implemented. > ++ Implementation ++ > It uses the Sling API. > For the tree on the left the JSTree library is used. It expects a URL to a > JSON that contains the data for the child nodes. This URL points to a > Sling resource with a 'reseditor.nodes' selector and a 'json' extension. This > way the JSPs [3] render the JSON for the resource that is consumed by the > JSTree library. > For the deletion and renaming of nodes I use jQuery Ajax calls to the Sling > POST servlet. > The properties list on the right is rendered [4] using JSTL and the > currentNode variable of Sling. > The html.jsp is registered for the 'reseditor' selector relatively to the > default servlet. And for not getting overruled by servlets registered by > paths and by other resources that are using the 'reseditor' selector I use a > ResourceDecorator [5]. > After a hint from Dominik Süß I work on using a ResourceProvider instead. > I'm looking forward to your feedback! > [1] - http://comments.gmane.org/gmane.comp.apache.sling.devel/47292 > [2] - http://comments.gmane.org/gmane.comp.apache.sling.devel/47517 > [3] - > https://github.com/sandroboehme/resourceeditor/tree/master/src/main/resources/SLING-INF/libs/sling/servlet/default/reseditor > [4] - > https://github.com/sandroboehme/resourceeditor/blob/master/src/main/resources/SLING-INF/libs/sling/servlet/default/reseditor/html.jsp > line 174 > [5] - > https://github.com/sandroboehme/resourceeditor/blob/master/src/main/java/org/apache/sling/reseditor/SelectorBasedResourceDecorator.java > [6] - https://www.google.de/search?q=site%3Aapache.org+commercial > [7] - https://github.com/sandroboehme/resourceeditor -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-4001) Apache Sling Resource Editor contribution
[
https://issues.apache.org/jira/browse/SLING-4001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14181878#comment-14181878
]
Robert Munteanu commented on SLING-4001:
{quote}Hey Robert Munteanu, thanks for your feedback! What did you do to get
the installation error? To build the Resource Editor with Maven one has to
first deploy it using the OSGi bundle repository. This makes the dependencies
available to the Sling instance. You find more details in the README.md. I
don't know of a way to tell Maven to load the dependencies from an OBR. Of
course I'm open to better ideas.{quote}
Hm, that's a bit inconvenient. What exact dependencies do you need that are not
part of the Sling Launchpad v7?
{quote}I used the manual Import-Package as the Bnd tool does not find the JSTL
libraries and it's dependencies as these are not used in Java import
statements.{quote}
Does it need them? AFAIR the JSP scripting engine has access to all exported
packages, and your JSPs should not be loaded/executed through the bundle
classloader, but through the JSP classloader.
{quote}This is why I use a Require-Bundle there. I would be happy if someone
knows a better way to handle that.{quote}
Can't you embed the contents of that JSNodeTypes library in this one?
> Apache Sling Resource Editor contribution
> -
>
> Key: SLING-4001
> URL: https://issues.apache.org/jira/browse/SLING-4001
> Project: Sling
> Issue Type: New Feature
>Reporter: Sandro Boehme
>Assignee: Bertrand Delacretaz
> Attachments: apache _sling_resource_editor.zip
>
>
> Based on the discussion at the dev list [1, 2] I would like to contribute the
> Apache Sling Resource Editor (previously named JCRBrowser and Apache Sling
> Content Editor).
> ++ Features ++
> Currently it can be used to rename and delete nodes. Rename works by double
> clicking the node and you can multi select nodes for the deletion with the
> 'del' key. The node names are HTML and URL escaped and it provides stateless
> deep links to the nodes.
> ++ Further development ++
> In the months to come I can work more intensely on the Sling Resource Editor
> and I might add commercial add-ons separately. This is why I would like to be
> able to point users to such an add-on from Sling. But judging from other
> Apache projects [6] I assume this is probably not a problem.
> I will continue the development at GitHub[7] and send patch files to Sling
> when new features are implemented.
> ++ Implementation ++
> It uses the Sling API.
> For the tree on the left the JSTree library is used. It expects a URL to a
> JSON that contains the data for the child nodes. This URL points to a
> Sling resource with a 'reseditor.nodes' selector and a 'json' extension. This
> way the JSPs [3] render the JSON for the resource that is consumed by the
> JSTree library.
> For the deletion and renaming of nodes I use jQuery Ajax calls to the Sling
> POST servlet.
> The properties list on the right is rendered [4] using JSTL and the
> currentNode variable of Sling.
> The html.jsp is registered for the 'reseditor' selector relatively to the
> default servlet. And for not getting overruled by servlets registered by
> paths and by other resources that are using the 'reseditor' selector I use a
> ResourceDecorator [5].
> After a hint from Dominik Süß I work on using a ResourceProvider instead.
> I'm looking forward to your feedback!
> [1] - http://comments.gmane.org/gmane.comp.apache.sling.devel/47292
> [2] - http://comments.gmane.org/gmane.comp.apache.sling.devel/47517
> [3] -
> https://github.com/sandroboehme/resourceeditor/tree/master/src/main/resources/SLING-INF/libs/sling/servlet/default/reseditor
> [4] -
> https://github.com/sandroboehme/resourceeditor/blob/master/src/main/resources/SLING-INF/libs/sling/servlet/default/reseditor/html.jsp
> line 174
> [5] -
> https://github.com/sandroboehme/resourceeditor/blob/master/src/main/java/org/apache/sling/reseditor/SelectorBasedResourceDecorator.java
> [6] - https://www.google.de/search?q=site%3Aapache.org+commercial
> [7] - https://github.com/sandroboehme/resourceeditor
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SLING-4001) Apache Sling Resource Editor contribution
[ https://issues.apache.org/jira/browse/SLING-4001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14181821#comment-14181821 ] Sandro Boehme commented on SLING-4001: -- Hey [~rombert], thanks for your feedback! What did you do to get the installation error? To build the Resource Editor with Maven one has to first deploy it using the OSGi bundle repository [1]. This makes the dependencies available to the Sling instance. You find more details in the README.md. I don't know of a way to tell Maven to load the dependencies from an OBR. Of course I'm open to better ideas. I used the manual Import-Package as the Bnd tool does not find the JSTL libraries and it's dependencies as these are not used in Java import statements. It's the same with the JSNodeTypes library. Except that it doesn't export an official Java package as an API at all which I can use for the Import-Package. This is why I use a Require-Bundle there. I would be happy if someone knows a better way to handle that. The de.sandroboehme.jsnodetypes should be resolved from my OBR [1] which in turn loads it from Maven Central. [1] - http://www.jcrbrowser.org/sling/obr/repository.xml > Apache Sling Resource Editor contribution > - > > Key: SLING-4001 > URL: https://issues.apache.org/jira/browse/SLING-4001 > Project: Sling > Issue Type: New Feature >Reporter: Sandro Boehme >Assignee: Bertrand Delacretaz > Attachments: apache _sling_resource_editor.zip > > > Based on the discussion at the dev list [1, 2] I would like to contribute the > Apache Sling Resource Editor (previously named JCRBrowser and Apache Sling > Content Editor). > ++ Features ++ > Currently it can be used to rename and delete nodes. Rename works by double > clicking the node and you can multi select nodes for the deletion with the > 'del' key. The node names are HTML and URL escaped and it provides stateless > deep links to the nodes. > ++ Further development ++ > In the months to come I can work more intensely on the Sling Resource Editor > and I might add commercial add-ons separately. This is why I would like to be > able to point users to such an add-on from Sling. But judging from other > Apache projects [6] I assume this is probably not a problem. > I will continue the development at GitHub[7] and send patch files to Sling > when new features are implemented. > ++ Implementation ++ > It uses the Sling API. > For the tree on the left the JSTree library is used. It expects a URL to a > JSON that contains the data for the child nodes. This URL points to a > Sling resource with a 'reseditor.nodes' selector and a 'json' extension. This > way the JSPs [3] render the JSON for the resource that is consumed by the > JSTree library. > For the deletion and renaming of nodes I use jQuery Ajax calls to the Sling > POST servlet. > The properties list on the right is rendered [4] using JSTL and the > currentNode variable of Sling. > The html.jsp is registered for the 'reseditor' selector relatively to the > default servlet. And for not getting overruled by servlets registered by > paths and by other resources that are using the 'reseditor' selector I use a > ResourceDecorator [5]. > After a hint from Dominik Süß I work on using a ResourceProvider instead. > I'm looking forward to your feedback! > [1] - http://comments.gmane.org/gmane.comp.apache.sling.devel/47292 > [2] - http://comments.gmane.org/gmane.comp.apache.sling.devel/47517 > [3] - > https://github.com/sandroboehme/resourceeditor/tree/master/src/main/resources/SLING-INF/libs/sling/servlet/default/reseditor > [4] - > https://github.com/sandroboehme/resourceeditor/blob/master/src/main/resources/SLING-INF/libs/sling/servlet/default/reseditor/html.jsp > line 174 > [5] - > https://github.com/sandroboehme/resourceeditor/blob/master/src/main/java/org/apache/sling/reseditor/SelectorBasedResourceDecorator.java > [6] - https://www.google.de/search?q=site%3Aapache.org+commercial > [7] - https://github.com/sandroboehme/resourceeditor -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-4001) Apache Sling Resource Editor contribution
[ https://issues.apache.org/jira/browse/SLING-4001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14181640#comment-14181640 ] Robert Munteanu commented on SLING-4001: [~sandro] - The trouble stems from the manual Import-Package instructions, I got an installation error that there was a duplicate import for javax.servlet.http. I simply removed the Import-Package instructions and trusted the maven-bundle-plugin to do its thing. Unfortunately it then failed since there is Require-Bundle instructions for de.sandroboehme.jsnodetypes . Where should that come from? > Apache Sling Resource Editor contribution > - > > Key: SLING-4001 > URL: https://issues.apache.org/jira/browse/SLING-4001 > Project: Sling > Issue Type: New Feature >Reporter: Sandro Boehme >Assignee: Bertrand Delacretaz > Attachments: apache _sling_resource_editor.zip > > > Based on the discussion at the dev list [1, 2] I would like to contribute the > Apache Sling Resource Editor (previously named JCRBrowser and Apache Sling > Content Editor). > ++ Features ++ > Currently it can be used to rename and delete nodes. Rename works by double > clicking the node and you can multi select nodes for the deletion with the > 'del' key. The node names are HTML and URL escaped and it provides stateless > deep links to the nodes. > ++ Further development ++ > In the months to come I can work more intensely on the Sling Resource Editor > and I might add commercial add-ons separately. This is why I would like to be > able to point users to such an add-on from Sling. But judging from other > Apache projects [6] I assume this is probably not a problem. > I will continue the development at GitHub[7] and send patch files to Sling > when new features are implemented. > ++ Implementation ++ > It uses the Sling API. > For the tree on the left the JSTree library is used. It expects a URL to a > JSON that contains the data for the child nodes. This URL points to a > Sling resource with a 'reseditor.nodes' selector and a 'json' extension. This > way the JSPs [3] render the JSON for the resource that is consumed by the > JSTree library. > For the deletion and renaming of nodes I use jQuery Ajax calls to the Sling > POST servlet. > The properties list on the right is rendered [4] using JSTL and the > currentNode variable of Sling. > The html.jsp is registered for the 'reseditor' selector relatively to the > default servlet. And for not getting overruled by servlets registered by > paths and by other resources that are using the 'reseditor' selector I use a > ResourceDecorator [5]. > After a hint from Dominik Süß I work on using a ResourceProvider instead. > I'm looking forward to your feedback! > [1] - http://comments.gmane.org/gmane.comp.apache.sling.devel/47292 > [2] - http://comments.gmane.org/gmane.comp.apache.sling.devel/47517 > [3] - > https://github.com/sandroboehme/resourceeditor/tree/master/src/main/resources/SLING-INF/libs/sling/servlet/default/reseditor > [4] - > https://github.com/sandroboehme/resourceeditor/blob/master/src/main/resources/SLING-INF/libs/sling/servlet/default/reseditor/html.jsp > line 174 > [5] - > https://github.com/sandroboehme/resourceeditor/blob/master/src/main/java/org/apache/sling/reseditor/SelectorBasedResourceDecorator.java > [6] - https://www.google.de/search?q=site%3Aapache.org+commercial > [7] - https://github.com/sandroboehme/resourceeditor -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-4001) Apache Sling Resource Editor contribution
[ https://issues.apache.org/jira/browse/SLING-4001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14181525#comment-14181525 ] Sandro Boehme commented on SLING-4001: -- I have a new version of the Resource Editor available but I think it makes sense to post a patch after it is possible to install the resource editor. > Apache Sling Resource Editor contribution > - > > Key: SLING-4001 > URL: https://issues.apache.org/jira/browse/SLING-4001 > Project: Sling > Issue Type: New Feature >Reporter: Sandro Boehme >Assignee: Bertrand Delacretaz > Attachments: apache _sling_resource_editor.zip > > > Based on the discussion at the dev list [1, 2] I would like to contribute the > Apache Sling Resource Editor (previously named JCRBrowser and Apache Sling > Content Editor). > ++ Features ++ > Currently it can be used to rename and delete nodes. Rename works by double > clicking the node and you can multi select nodes for the deletion with the > 'del' key. The node names are HTML and URL escaped and it provides stateless > deep links to the nodes. > ++ Further development ++ > In the months to come I can work more intensely on the Sling Resource Editor > and I might add commercial add-ons separately. This is why I would like to be > able to point users to such an add-on from Sling. But judging from other > Apache projects [6] I assume this is probably not a problem. > I will continue the development at GitHub[7] and send patch files to Sling > when new features are implemented. > ++ Implementation ++ > It uses the Sling API. > For the tree on the left the JSTree library is used. It expects a URL to a > JSON that contains the data for the child nodes. This URL points to a > Sling resource with a 'reseditor.nodes' selector and a 'json' extension. This > way the JSPs [3] render the JSON for the resource that is consumed by the > JSTree library. > For the deletion and renaming of nodes I use jQuery Ajax calls to the Sling > POST servlet. > The properties list on the right is rendered [4] using JSTL and the > currentNode variable of Sling. > The html.jsp is registered for the 'reseditor' selector relatively to the > default servlet. And for not getting overruled by servlets registered by > paths and by other resources that are using the 'reseditor' selector I use a > ResourceDecorator [5]. > After a hint from Dominik Süß I work on using a ResourceProvider instead. > I'm looking forward to your feedback! > [1] - http://comments.gmane.org/gmane.comp.apache.sling.devel/47292 > [2] - http://comments.gmane.org/gmane.comp.apache.sling.devel/47517 > [3] - > https://github.com/sandroboehme/resourceeditor/tree/master/src/main/resources/SLING-INF/libs/sling/servlet/default/reseditor > [4] - > https://github.com/sandroboehme/resourceeditor/blob/master/src/main/resources/SLING-INF/libs/sling/servlet/default/reseditor/html.jsp > line 174 > [5] - > https://github.com/sandroboehme/resourceeditor/blob/master/src/main/java/org/apache/sling/reseditor/SelectorBasedResourceDecorator.java > [6] - https://www.google.de/search?q=site%3Aapache.org+commercial > [7] - https://github.com/sandroboehme/resourceeditor -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-4001) Apache Sling Resource Editor contribution
[ https://issues.apache.org/jira/browse/SLING-4001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14181522#comment-14181522 ] Sandro Boehme commented on SLING-4001: -- There is one bigger problem [~bdelacretaz], it's not possible to install the project to the server. Except that everything is fine. With 'mvn install' or 'mvn install -P autoInstallBundle' Maven ends with "success" and the jar is posted to '/system/console' but the changes are not available. It works as long as I use the 2.3.7 version of Felix' maven-bundle-plugin but not with the 2.5.3 version of that plugin that comes from the parent pom. It took me a while to figure that out. If someone knows something about that please tell me. In the other case I will go into more detail. > Apache Sling Resource Editor contribution > - > > Key: SLING-4001 > URL: https://issues.apache.org/jira/browse/SLING-4001 > Project: Sling > Issue Type: New Feature >Reporter: Sandro Boehme >Assignee: Bertrand Delacretaz > Attachments: apache _sling_resource_editor.zip > > > Based on the discussion at the dev list [1, 2] I would like to contribute the > Apache Sling Resource Editor (previously named JCRBrowser and Apache Sling > Content Editor). > ++ Features ++ > Currently it can be used to rename and delete nodes. Rename works by double > clicking the node and you can multi select nodes for the deletion with the > 'del' key. The node names are HTML and URL escaped and it provides stateless > deep links to the nodes. > ++ Further development ++ > In the months to come I can work more intensely on the Sling Resource Editor > and I might add commercial add-ons separately. This is why I would like to be > able to point users to such an add-on from Sling. But judging from other > Apache projects [6] I assume this is probably not a problem. > I will continue the development at GitHub[7] and send patch files to Sling > when new features are implemented. > ++ Implementation ++ > It uses the Sling API. > For the tree on the left the JSTree library is used. It expects a URL to a > JSON that contains the data for the child nodes. This URL points to a > Sling resource with a 'reseditor.nodes' selector and a 'json' extension. This > way the JSPs [3] render the JSON for the resource that is consumed by the > JSTree library. > For the deletion and renaming of nodes I use jQuery Ajax calls to the Sling > POST servlet. > The properties list on the right is rendered [4] using JSTL and the > currentNode variable of Sling. > The html.jsp is registered for the 'reseditor' selector relatively to the > default servlet. And for not getting overruled by servlets registered by > paths and by other resources that are using the 'reseditor' selector I use a > ResourceDecorator [5]. > After a hint from Dominik Süß I work on using a ResourceProvider instead. > I'm looking forward to your feedback! > [1] - http://comments.gmane.org/gmane.comp.apache.sling.devel/47292 > [2] - http://comments.gmane.org/gmane.comp.apache.sling.devel/47517 > [3] - > https://github.com/sandroboehme/resourceeditor/tree/master/src/main/resources/SLING-INF/libs/sling/servlet/default/reseditor > [4] - > https://github.com/sandroboehme/resourceeditor/blob/master/src/main/resources/SLING-INF/libs/sling/servlet/default/reseditor/html.jsp > line 174 > [5] - > https://github.com/sandroboehme/resourceeditor/blob/master/src/main/java/org/apache/sling/reseditor/SelectorBasedResourceDecorator.java > [6] - https://www.google.de/search?q=site%3Aapache.org+commercial > [7] - https://github.com/sandroboehme/resourceeditor -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-4001) Apache Sling Resource Editor contribution
[ https://issues.apache.org/jira/browse/SLING-4001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14175113#comment-14175113 ] Sandro Boehme commented on SLING-4001: -- Thanks a lot for leading my contribution to the final commits [~bdelacretaz]! I will cross check and expect to be able to send a first patch next week. > Apache Sling Resource Editor contribution > - > > Key: SLING-4001 > URL: https://issues.apache.org/jira/browse/SLING-4001 > Project: Sling > Issue Type: New Feature >Reporter: Sandro Boehme >Assignee: Bertrand Delacretaz > Attachments: apache _sling_resource_editor.zip > > > Based on the discussion at the dev list [1, 2] I would like to contribute the > Apache Sling Resource Editor (previously named JCRBrowser and Apache Sling > Content Editor). > ++ Features ++ > Currently it can be used to rename and delete nodes. Rename works by double > clicking the node and you can multi select nodes for the deletion with the > 'del' key. The node names are HTML and URL escaped and it provides stateless > deep links to the nodes. > ++ Further development ++ > In the months to come I can work more intensely on the Sling Resource Editor > and I might add commercial add-ons separately. This is why I would like to be > able to point users to such an add-on from Sling. But judging from other > Apache projects [6] I assume this is probably not a problem. > I will continue the development at GitHub[7] and send patch files to Sling > when new features are implemented. > ++ Implementation ++ > It uses the Sling API. > For the tree on the left the JSTree library is used. It expects a URL to a > JSON that contains the data for the child nodes. This URL points to a > Sling resource with a 'reseditor.nodes' selector and a 'json' extension. This > way the JSPs [3] render the JSON for the resource that is consumed by the > JSTree library. > For the deletion and renaming of nodes I use jQuery Ajax calls to the Sling > POST servlet. > The properties list on the right is rendered [4] using JSTL and the > currentNode variable of Sling. > The html.jsp is registered for the 'reseditor' selector relatively to the > default servlet. And for not getting overruled by servlets registered by > paths and by other resources that are using the 'reseditor' selector I use a > ResourceDecorator [5]. > After a hint from Dominik Süß I work on using a ResourceProvider instead. > I'm looking forward to your feedback! > [1] - http://comments.gmane.org/gmane.comp.apache.sling.devel/47292 > [2] - http://comments.gmane.org/gmane.comp.apache.sling.devel/47517 > [3] - > https://github.com/sandroboehme/resourceeditor/tree/master/src/main/resources/SLING-INF/libs/sling/servlet/default/reseditor > [4] - > https://github.com/sandroboehme/resourceeditor/blob/master/src/main/resources/SLING-INF/libs/sling/servlet/default/reseditor/html.jsp > line 174 > [5] - > https://github.com/sandroboehme/resourceeditor/blob/master/src/main/java/org/apache/sling/reseditor/SelectorBasedResourceDecorator.java > [6] - https://www.google.de/search?q=site%3Aapache.org+commercial > [7] - https://github.com/sandroboehme/resourceeditor -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-4001) Apache Sling Resource Editor contribution
[ https://issues.apache.org/jira/browse/SLING-4001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14165137#comment-14165137 ] Bertrand Delacretaz commented on SLING-4001: Ok, let's keep the attached contribution zip unchanged for now, as we'll be referring to it based on its sha1 digest in various places. It's fine to send patches once the contribution is committed. > Apache Sling Resource Editor contribution > - > > Key: SLING-4001 > URL: https://issues.apache.org/jira/browse/SLING-4001 > Project: Sling > Issue Type: New Feature >Reporter: Sandro Boehme > Attachments: apache _sling_resource_editor.zip > > > Based on the discussion at the dev list [1, 2] I would like to contribute the > Apache Sling Resource Editor (previously named JCRBrowser and Apache Sling > Content Editor). > ++ Features ++ > Currently it can be used to rename and delete nodes. Rename works by double > clicking the node and you can multi select nodes for the deletion with the > 'del' key. The node names are HTML and URL escaped and it provides stateless > deep links to the nodes. > ++ Further development ++ > In the months to come I can work more intensely on the Sling Resource Editor > and I might add commercial add-ons separately. This is why I would like to be > able to point users to such an add-on from Sling. But judging from other > Apache projects [6] I assume this is probably not a problem. > I will continue the development at GitHub[7] and send patch files to Sling > when new features are implemented. > ++ Implementation ++ > It uses the Sling API. > For the tree on the left the JSTree library is used. It expects a URL to a > JSON that contains the data for the child nodes. This URL points to a > Sling resource with a 'reseditor.nodes' selector and a 'json' extension. This > way the JSPs [3] render the JSON for the resource that is consumed by the > JSTree library. > For the deletion and renaming of nodes I use jQuery Ajax calls to the Sling > POST servlet. > The properties list on the right is rendered [4] using JSTL and the > currentNode variable of Sling. > The html.jsp is registered for the 'reseditor' selector relatively to the > default servlet. And for not getting overruled by servlets registered by > paths and by other resources that are using the 'reseditor' selector I use a > ResourceDecorator [5]. > After a hint from Dominik Süß I work on using a ResourceProvider instead. > I'm looking forward to your feedback! > [1] - http://comments.gmane.org/gmane.comp.apache.sling.devel/47292 > [2] - http://comments.gmane.org/gmane.comp.apache.sling.devel/47517 > [3] - > https://github.com/sandroboehme/resourceeditor/tree/master/src/main/resources/SLING-INF/libs/sling/servlet/default/reseditor > [4] - > https://github.com/sandroboehme/resourceeditor/blob/master/src/main/resources/SLING-INF/libs/sling/servlet/default/reseditor/html.jsp > line 174 > [5] - > https://github.com/sandroboehme/resourceeditor/blob/master/src/main/java/org/apache/sling/reseditor/SelectorBasedResourceDecorator.java > [6] - https://www.google.de/search?q=site%3Aapache.org+commercial > [7] - https://github.com/sandroboehme/resourceeditor -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-4001) Apache Sling Resource Editor contribution
[ https://issues.apache.org/jira/browse/SLING-4001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14165128#comment-14165128 ] Sandro Boehme commented on SLING-4001: -- I will move the mentions to the LICENSE file and remove the NOTICE file after the contribution is accepted and upload a new zip. > Apache Sling Resource Editor contribution > - > > Key: SLING-4001 > URL: https://issues.apache.org/jira/browse/SLING-4001 > Project: Sling > Issue Type: New Feature >Reporter: Sandro Boehme > Attachments: apache _sling_resource_editor.zip > > > Based on the discussion at the dev list [1, 2] I would like to contribute the > Apache Sling Resource Editor (previously named JCRBrowser and Apache Sling > Content Editor). > ++ Features ++ > Currently it can be used to rename and delete nodes. Rename works by double > clicking the node and you can multi select nodes for the deletion with the > 'del' key. The node names are HTML and URL escaped and it provides stateless > deep links to the nodes. > ++ Further development ++ > In the months to come I can work more intensely on the Sling Resource Editor > and I might add commercial add-ons separately. This is why I would like to be > able to point users to such an add-on from Sling. But judging from other > Apache projects [6] I assume this is probably not a problem. > I will continue the development at GitHub[7] and send patch files to Sling > when new features are implemented. > ++ Implementation ++ > It uses the Sling API. > For the tree on the left the JSTree library is used. It expects a URL to a > JSON that contains the data for the child nodes. This URL points to a > Sling resource with a 'reseditor.nodes' selector and a 'json' extension. This > way the JSPs [3] render the JSON for the resource that is consumed by the > JSTree library. > For the deletion and renaming of nodes I use jQuery Ajax calls to the Sling > POST servlet. > The properties list on the right is rendered [4] using JSTL and the > currentNode variable of Sling. > The html.jsp is registered for the 'reseditor' selector relatively to the > default servlet. And for not getting overruled by servlets registered by > paths and by other resources that are using the 'reseditor' selector I use a > ResourceDecorator [5]. > After a hint from Dominik Süß I work on using a ResourceProvider instead. > I'm looking forward to your feedback! > [1] - http://comments.gmane.org/gmane.comp.apache.sling.devel/47292 > [2] - http://comments.gmane.org/gmane.comp.apache.sling.devel/47517 > [3] - > https://github.com/sandroboehme/resourceeditor/tree/master/src/main/resources/SLING-INF/libs/sling/servlet/default/reseditor > [4] - > https://github.com/sandroboehme/resourceeditor/blob/master/src/main/resources/SLING-INF/libs/sling/servlet/default/reseditor/html.jsp > line 174 > [5] - > https://github.com/sandroboehme/resourceeditor/blob/master/src/main/java/org/apache/sling/reseditor/SelectorBasedResourceDecorator.java > [6] - https://www.google.de/search?q=site%3Aapache.org+commercial > [7] - https://github.com/sandroboehme/resourceeditor -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-4001) Apache Sling Resource Editor contribution
[ https://issues.apache.org/jira/browse/SLING-4001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14165010#comment-14165010 ] Bertrand Delacretaz commented on SLING-4001: It looks like the NOTICE file contains many mentions that are not required, we'll need to remove them (or move them to the LICENSE file) before releasing this module, if we accept the contribution. For now, I'll start a vote on our dev list about accepting this contribution - thanks for preparing it! > Apache Sling Resource Editor contribution > - > > Key: SLING-4001 > URL: https://issues.apache.org/jira/browse/SLING-4001 > Project: Sling > Issue Type: New Feature >Reporter: Sandro Boehme > Attachments: apache _sling_resource_editor.zip > > > Based on the discussion at the dev list [1, 2] I would like to contribute the > Apache Sling Resource Editor (previously named JCRBrowser and Apache Sling > Content Editor). > ++ Features ++ > Currently it can be used to rename and delete nodes. Rename works by double > clicking the node and you can multi select nodes for the deletion with the > 'del' key. The node names are HTML and URL escaped and it provides stateless > deep links to the nodes. > ++ Further development ++ > In the months to come I can work more intensely on the Sling Resource Editor > and I might add commercial add-ons separately. This is why I would like to be > able to point users to such an add-on from Sling. But judging from other > Apache projects [6] I assume this is probably not a problem. > I will continue the development at GitHub[7] and send patch files to Sling > when new features are implemented. > ++ Implementation ++ > It uses the Sling API. > For the tree on the left the JSTree library is used. It expects a URL to a > JSON that contains the data for the child nodes. This URL points to a > Sling resource with a 'reseditor.nodes' selector and a 'json' extension. This > way the JSPs [3] render the JSON for the resource that is consumed by the > JSTree library. > For the deletion and renaming of nodes I use jQuery Ajax calls to the Sling > POST servlet. > The properties list on the right is rendered [4] using JSTL and the > currentNode variable of Sling. > The html.jsp is registered for the 'reseditor' selector relatively to the > default servlet. And for not getting overruled by servlets registered by > paths and by other resources that are using the 'reseditor' selector I use a > ResourceDecorator [5]. > After a hint from Dominik Süß I work on using a ResourceProvider instead. > I'm looking forward to your feedback! > [1] - http://comments.gmane.org/gmane.comp.apache.sling.devel/47292 > [2] - http://comments.gmane.org/gmane.comp.apache.sling.devel/47517 > [3] - > https://github.com/sandroboehme/resourceeditor/tree/master/src/main/resources/SLING-INF/libs/sling/servlet/default/reseditor > [4] - > https://github.com/sandroboehme/resourceeditor/blob/master/src/main/resources/SLING-INF/libs/sling/servlet/default/reseditor/html.jsp > line 174 > [5] - > https://github.com/sandroboehme/resourceeditor/blob/master/src/main/java/org/apache/sling/reseditor/SelectorBasedResourceDecorator.java > [6] - https://www.google.de/search?q=site%3Aapache.org+commercial > [7] - https://github.com/sandroboehme/resourceeditor -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-4001) Apache Sling Resource Editor contribution
[ https://issues.apache.org/jira/browse/SLING-4001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14161907#comment-14161907 ] Sandro Boehme commented on SLING-4001: -- Three bugs [1] are now fixed at GitHub and will be available as a patch after the contribution. [1] - https://github.com/sandroboehme/resourceeditor/issues/5 https://github.com/sandroboehme/resourceeditor/issues/6 https://github.com/sandroboehme/resourceeditor/issues/7 > Apache Sling Resource Editor contribution > - > > Key: SLING-4001 > URL: https://issues.apache.org/jira/browse/SLING-4001 > Project: Sling > Issue Type: New Feature >Reporter: Sandro Boehme > Attachments: apache _sling_resource_editor.zip > > > Based on the discussion at the dev list [1, 2] I would like to contribute the > Apache Sling Resource Editor (previously named JCRBrowser and Apache Sling > Content Editor). > ++ Features ++ > Currently it can be used to rename and delete nodes. Rename works by double > clicking the node and you can multi select nodes for the deletion with the > 'del' key. The node names are HTML and URL escaped and it provides stateless > deep links to the nodes. > ++ Further development ++ > In the months to come I can work more intensely on the Sling Resource Editor > and I might add commercial add-ons separately. This is why I would like to be > able to point users to such an add-on from Sling. But judging from other > Apache projects [6] I assume this is probably not a problem. > I will continue the development at GitHub[7] and send patch files to Sling > when new features are implemented. > ++ Implementation ++ > It uses the Sling API. > For the tree on the left the JSTree library is used. It expects a URL to a > JSON that contains the data for the child nodes. This URL points to a > Sling resource with a 'reseditor.nodes' selector and a 'json' extension. This > way the JSPs [3] render the JSON for the resource that is consumed by the > JSTree library. > For the deletion and renaming of nodes I use jQuery Ajax calls to the Sling > POST servlet. > The properties list on the right is rendered [4] using JSTL and the > currentNode variable of Sling. > The html.jsp is registered for the 'reseditor' selector relatively to the > default servlet. And for not getting overruled by servlets registered by > paths and by other resources that are using the 'reseditor' selector I use a > ResourceDecorator [5]. > After a hint from Dominik Süß I work on using a ResourceProvider instead. > I'm looking forward to your feedback! > [1] - http://comments.gmane.org/gmane.comp.apache.sling.devel/47292 > [2] - http://comments.gmane.org/gmane.comp.apache.sling.devel/47517 > [3] - > https://github.com/sandroboehme/resourceeditor/tree/master/src/main/resources/SLING-INF/libs/sling/servlet/default/reseditor > [4] - > https://github.com/sandroboehme/resourceeditor/blob/master/src/main/resources/SLING-INF/libs/sling/servlet/default/reseditor/html.jsp > line 174 > [5] - > https://github.com/sandroboehme/resourceeditor/blob/master/src/main/java/org/apache/sling/reseditor/SelectorBasedResourceDecorator.java > [6] - https://www.google.de/search?q=site%3Aapache.org+commercial > [7] - https://github.com/sandroboehme/resourceeditor -- This message was sent by Atlassian JIRA (v6.3.4#6332)
