Re: Null checking annotatins for IDE tooling (was: Build failed in Jenkins: sling-ide #88)

[Robert Munteanu]

On Fri, 2017-01-13 at 12:05 -0800, Andreas Schaefer Sr. wrote:
> This is not limited to API.
> 
> There is the issue with impl-vlt that uses the Activator to obtain
> the Plugin Logger.
> IntelliJ for example is not OSGi based and this caused me some
> headaches (and still does).
> 
> But there is also code that would be common to IDEs but it is
> embedded into Eclipse
> source because it has references to Eclipse objects like the
> ResourceChangeCommandFactory.
> 
> A while ago I proposed a set of interfaces that would remove the
> Eclipse dependencies from the
> RCCF and hide the IDE specific logic inside the implementations of
> these interfaces.
> 
> So far this went nowhere as I don’t know where to find the Eclipse
> code necessary and how to
> build and test it properly.
> 
> Later I went a step further creating a Deployment Manager that even
> extracts IDE specific
> code / classes from methods like
> SlingLaunchpadBehaviour.publishModule() etc.
> The goal was to create a common behavior of the code deployment to
> AEM in all
> IDEs.


I fully agree that although the general design was to isolate some
parts of the IDE tooling from Eclipse it does not always hold.

I've been thinking about how to best approach it and I think the best
way to start off is to have a single build which includes both the
Eclipse and IntelliJ plug-ins. Then we can start sharing code and
seeing what breaks.

I can't reserve the time right now to look into this, but hopefully in
the future that will change :-)

Robert

> 
> Cheers - Andy
> 
> > On Jan 13, 2017, at 9:39 AM, Konrad Windszus 
> > wrote:
> > 
> > For the API part I will make sure to not introduce any Eclipse
> > specific dependencies.
> > For the null-check annotations we should probably then rely on JSR-
> > 305 annotations (https://sling.apache.org/documentation/development
> > /jsr-305.html).
> > Konrad
> > 
> > > On 13 Jan 2017, at 17:10, Andreas Schaefer Sr. 
> > > wrote:
> > > 
> > > If tooling is every going to support other IDEs than Eclipse then
> > > you should not add more Eclipse dependencies
> > > to non Eclipse modules. 
> > > 
> > > Cheers - Andy Schaefer
> > > 
> > > > On Jan 10, 2017, at 3:24 AM, Robert Munteanu  > > > g> wrote:
> > > > 
> > > > On Mon, 2017-01-09 at 09:24 -0500, Konrad Windszus wrote:
> > > > > > On 9 Jan 2017, at 06:00, Robert Munteanu  > > > > > g>
> > > > > > wrote:
> > > > > > 
> > > > > > Hi Konrad,
> > > > > > 
> > > > > > On Thu, 2016-12-29 at 19:23 +0100, Konrad Windszus wrote:
> > > > > > > This is due to https://bugs.eclipse.org/bugs/show_bug.cgi
> > > > > > > ?id=4340
> > > > > > > 33.
> > > > > > > Any suggestions which annotation types to use in the
> > > > > > > Eclipse IDE
> > > > > > > for
> > > > > > > null checks?
> > > > > > > Or would it be fine to build the Sling IDE with target
> > > > > > > 1.8?
> > > > > > 
> > > > > > I am not opposed to building the IDE tooling with target
> > > > > > 1.8 .
> > > > > > First
> > > > > > though, there is a workaround noted in the Eclipse bug:
> > > > > > 
> > > > > > please make sure that an in projects below 1.8 you
> > > > > > reference
> > > > > > version
> > > > > > [1.1.0,2.0.0) of the annotation bundle (exluding 2.0.0!)
> > > > > > 
> > > > > > Would that work for our scenario?
> > > > > 
> > > > > I have not tested that, but I just checked that indeed at
> > > > > least
> > > > > Eclipse Neon ships with two different versions of that bundle
> > > > > 1.1.100
> > > > > and 2.1.0 but I am not sure about older and newer versions of
> > > > > Eclipse. I would rather instead upgrade to Java 8, since with
> > > > > Neon
> > > > > Java 8 is anyhow required (see https://wiki.eclipse.org/Eclip
> > > > > se/Insta
> > > > > llation).
> > > > > WDYT?
> > > > 
> > > > I for one would switch to Java 8 only if really needed, as I
> > > > think we
> > > > need to make it as easy as possible to run the IDE tools.
> > > > 
> > > > Are there any developers out there using the IDE Tooling on
> > > > Java 7? No
> > > > idea. If there's a way to get null checking with Java 7, let's
> > > > do that.
> > > > Otherwise, feel free to raise a new SLING issue about moving to
> > > > Java 8
> > > > to track the reasons behind the move and change the requirement
> > > > to Java
> > > > 8.
> > > > 
> > > > Robert
> > > > 
> > > > > 
> > > > > > 
> > > > > > Robert
> > > > > > 
> > > > > > > Konrad
> > > > > > > 
> > > > > > > > On 29 Dec 2016, at 18:01, Apache Jenkins Server  > > > > > > > s@builds
> > > > > > > > .apa
> > > > > > > > che.org> wrote:
> > > > > > > > 
> > > > > > > > See  > > > > > > > >
> > > > > > > > 
> > > > > > > > Changes:
> > > > > > > > 
> > > > > > > > [kwin] SLING-6344 disable syncing if no filter.xml can
> > > > > > > > be found
> > > > > > > > 
> > > > > > > > simplify FilterLocator service
> > > > > > > > 
> > > > > > > > 

Re: Null checking annotatins for IDE tooling (was: Build failed in Jenkins: sling-ide #88)

[Andreas Schaefer Sr.]

This is not limited to API.

There is the issue with impl-vlt that uses the Activator to obtain the Plugin 
Logger.
IntelliJ for example is not OSGi based and this caused me some headaches (and 
still does).

But there is also code that would be common to IDEs but it is embedded into 
Eclipse
source because it has references to Eclipse objects like the 
ResourceChangeCommandFactory.

A while ago I proposed a set of interfaces that would remove the Eclipse 
dependencies from the
RCCF and hide the IDE specific logic inside the implementations of these 
interfaces.

So far this went nowhere as I don’t know where to find the Eclipse code 
necessary and how to
build and test it properly.

Later I went a step further creating a Deployment Manager that even extracts 
IDE specific
code / classes from methods like SlingLaunchpadBehaviour.publishModule() etc.
The goal was to create a common behavior of the code deployment to AEM in all
IDEs.

Cheers - Andy

> On Jan 13, 2017, at 9:39 AM, Konrad Windszus  wrote:
> 
> For the API part I will make sure to not introduce any Eclipse specific 
> dependencies.
> For the null-check annotations we should probably then rely on JSR-305 
> annotations (https://sling.apache.org/documentation/development/jsr-305.html).
> Konrad
> 
>> On 13 Jan 2017, at 17:10, Andreas Schaefer Sr.  wrote:
>> 
>> If tooling is every going to support other IDEs than Eclipse then you should 
>> not add more Eclipse dependencies
>> to non Eclipse modules. 
>> 
>> Cheers - Andy Schaefer
>> 
>>> On Jan 10, 2017, at 3:24 AM, Robert Munteanu  wrote:
>>> 
>>> On Mon, 2017-01-09 at 09:24 -0500, Konrad Windszus wrote:
> On 9 Jan 2017, at 06:00, Robert Munteanu 
> wrote:
> 
> Hi Konrad,
> 
> On Thu, 2016-12-29 at 19:23 +0100, Konrad Windszus wrote:
>> This is due to https://bugs.eclipse.org/bugs/show_bug.cgi?id=4340
>> 33.
>> Any suggestions which annotation types to use in the Eclipse IDE
>> for
>> null checks?
>> Or would it be fine to build the Sling IDE with target 1.8?
> 
> I am not opposed to building the IDE tooling with target 1.8 .
> First
> though, there is a workaround noted in the Eclipse bug:
> 
> please make sure that an in projects below 1.8 you reference
> version
> [1.1.0,2.0.0) of the annotation bundle (exluding 2.0.0!)
> 
> Would that work for our scenario?
 
 I have not tested that, but I just checked that indeed at least
 Eclipse Neon ships with two different versions of that bundle 1.1.100
 and 2.1.0 but I am not sure about older and newer versions of
 Eclipse. I would rather instead upgrade to Java 8, since with Neon
 Java 8 is anyhow required (see https://wiki.eclipse.org/Eclipse/Insta
 llation).
 WDYT?
>>> 
>>> I for one would switch to Java 8 only if really needed, as I think we
>>> need to make it as easy as possible to run the IDE tools.
>>> 
>>> Are there any developers out there using the IDE Tooling on Java 7? No
>>> idea. If there's a way to get null checking with Java 7, let's do that.
>>> Otherwise, feel free to raise a new SLING issue about moving to Java 8
>>> to track the reasons behind the move and change the requirement to Java
>>> 8.
>>> 
>>> Robert
>>> 
 
> 
> Robert
> 
>> Konrad
>> 
>>> On 29 Dec 2016, at 18:01, Apache Jenkins Server >> .apa
>>> che.org> wrote:
>>> 
>>> See 
>>> 
>>> Changes:
>>> 
>>> [kwin] SLING-6344 disable syncing if no filter.xml can be found
>>> 
>>> simplify FilterLocator service
>>> 
>>> --
>>> [...truncated 899 lines...]
>>> [INFO] --- maven-remote-resources-plugin:1.5:process (default)
>>> @
>>> reactor ---
>>> [INFO] 
>>> [INFO] --- maven-site-plugin:3.3:attach-descriptor (attach-
>>> descriptor) @ reactor ---
>>> [INFO] 
>>> [INFO] --- ianal-maven-plugin:1.0-alpha-1:verify-legal-files
>>> (default) @ reactor ---
>>> [INFO] 
>>> [INFO] --- apache-rat-plugin:0.10:check (default) @ reactor ---
>>> [INFO] 72 implicit excludes (use -debug for more details).
>>> [INFO] Exclude: derby.log
>>> [INFO] Exclude: .gitignore
>>> [INFO] Exclude: README.md
>>> [INFO] Exclude: *.launch
>>> [INFO] Exclude: build.properties
>>> [INFO] Exclude: .options
>>> [INFO] Exclude: META-INF/MANIFEST.MF
>>> [INFO] Exclude: **/*.binary
>>> [INFO] Exclude: eclipse-test/**
>>> [INFO] Exclude: source-bundle/target/**
>>> [INFO] Exclude: .Xauthority-*
>>> [INFO] 6 resources included (use -debug for more details)
>>> Warning:  org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser:
>>> Property 'http://www.oracle.com/xml/jaxp/properties/entityExpan
>>> sion
>>> Limit' is not recognized.

Re: Null checking annotatins for IDE tooling (was: Build failed in Jenkins: sling-ide #88)

[Konrad Windszus]

For the API part I will make sure to not introduce any Eclipse specific 
dependencies.
For the null-check annotations we should probably then rely on JSR-305 
annotations (https://sling.apache.org/documentation/development/jsr-305.html).
Konrad

> On 13 Jan 2017, at 17:10, Andreas Schaefer Sr.  wrote:
> 
> If tooling is every going to support other IDEs than Eclipse then you should 
> not add more Eclipse dependencies
> to non Eclipse modules. 
> 
> Cheers - Andy Schaefer
> 
>> On Jan 10, 2017, at 3:24 AM, Robert Munteanu  wrote:
>> 
>> On Mon, 2017-01-09 at 09:24 -0500, Konrad Windszus wrote:
 On 9 Jan 2017, at 06:00, Robert Munteanu 
 wrote:
 
 Hi Konrad,
 
 On Thu, 2016-12-29 at 19:23 +0100, Konrad Windszus wrote:
> This is due to https://bugs.eclipse.org/bugs/show_bug.cgi?id=4340
> 33.
> Any suggestions which annotation types to use in the Eclipse IDE
> for
> null checks?
> Or would it be fine to build the Sling IDE with target 1.8?
 
 I am not opposed to building the IDE tooling with target 1.8 .
 First
 though, there is a workaround noted in the Eclipse bug:
 
 please make sure that an in projects below 1.8 you reference
 version
 [1.1.0,2.0.0) of the annotation bundle (exluding 2.0.0!)
 
 Would that work for our scenario?
>>> 
>>> I have not tested that, but I just checked that indeed at least
>>> Eclipse Neon ships with two different versions of that bundle 1.1.100
>>> and 2.1.0 but I am not sure about older and newer versions of
>>> Eclipse. I would rather instead upgrade to Java 8, since with Neon
>>> Java 8 is anyhow required (see https://wiki.eclipse.org/Eclipse/Insta
>>> llation).
>>> WDYT?
>> 
>> I for one would switch to Java 8 only if really needed, as I think we
>> need to make it as easy as possible to run the IDE tools.
>> 
>> Are there any developers out there using the IDE Tooling on Java 7? No
>> idea. If there's a way to get null checking with Java 7, let's do that.
>> Otherwise, feel free to raise a new SLING issue about moving to Java 8
>> to track the reasons behind the move and change the requirement to Java
>> 8.
>> 
>> Robert
>> 
>>> 
 
 Robert
 
> Konrad
> 
>> On 29 Dec 2016, at 18:01, Apache Jenkins Server > .apa
>> che.org> wrote:
>> 
>> See 
>> 
>> Changes:
>> 
>> [kwin] SLING-6344 disable syncing if no filter.xml can be found
>> 
>> simplify FilterLocator service
>> 
>> --
>> [...truncated 899 lines...]
>> [INFO] --- maven-remote-resources-plugin:1.5:process (default)
>> @
>> reactor ---
>> [INFO] 
>> [INFO] --- maven-site-plugin:3.3:attach-descriptor (attach-
>> descriptor) @ reactor ---
>> [INFO] 
>> [INFO] --- ianal-maven-plugin:1.0-alpha-1:verify-legal-files
>> (default) @ reactor ---
>> [INFO] 
>> [INFO] --- apache-rat-plugin:0.10:check (default) @ reactor ---
>> [INFO] 72 implicit excludes (use -debug for more details).
>> [INFO] Exclude: derby.log
>> [INFO] Exclude: .gitignore
>> [INFO] Exclude: README.md
>> [INFO] Exclude: *.launch
>> [INFO] Exclude: build.properties
>> [INFO] Exclude: .options
>> [INFO] Exclude: META-INF/MANIFEST.MF
>> [INFO] Exclude: **/*.binary
>> [INFO] Exclude: eclipse-test/**
>> [INFO] Exclude: source-bundle/target/**
>> [INFO] Exclude: .Xauthority-*
>> [INFO] 6 resources included (use -debug for more details)
>> Warning:  org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser:
>> Property 'http://www.oracle.com/xml/jaxp/properties/entityExpan
>> sion
>> Limit' is not recognized.
>> Compiler warnings:
>> WARNING:  'org.apache.xerces.jaxp.SAXParserImpl: Property
>> 'http://
>> javax.xml.XMLConstants/property/accessExternalDTD' is not
>> recognized.'
>> Warning:  org.apache.xerces.parsers.SAXParser: Feature 'http://
>> java
>> x.xml.XMLConstants/feature/secure-processing' is not
>> recognized.
>> Warning:  org.apache.xerces.parsers.SAXParser: Property 'http:/
>> /jav
>> ax.xml.XMLConstants/property/accessExternalDTD' is not
>> recognized.
>> Warning:  org.apache.xerces.parsers.SAXParser: Property 'http:/
>> /www
>> .oracle.com/xml/jaxp/properties/entityExpansionLimit' is not
>> recognized.
>> [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0
>> generated: 0 approved: 5 licence.
>> [JENKINS] Archiving disabled
>> [INFO] 
>> 
>> 
>> [INFO] 
>> 
>> 
>> [INFO] Building Sling IDE Tools: Target definition 1.1.1-
>> SNAPSHOT
>> [INFO] 

Re: Null checking annotatins for IDE tooling (was: Build failed in Jenkins: sling-ide #88)

[Andreas Schaefer Sr.]

If tooling is every going to support other IDEs than Eclipse then you should 
not add more Eclipse dependencies
to non Eclipse modules. 

Cheers - Andy Schaefer

> On Jan 10, 2017, at 3:24 AM, Robert Munteanu  wrote:
> 
> On Mon, 2017-01-09 at 09:24 -0500, Konrad Windszus wrote:
>>> On 9 Jan 2017, at 06:00, Robert Munteanu 
>>> wrote:
>>> 
>>> Hi Konrad,
>>> 
>>> On Thu, 2016-12-29 at 19:23 +0100, Konrad Windszus wrote:
 This is due to https://bugs.eclipse.org/bugs/show_bug.cgi?id=4340
 33.
 Any suggestions which annotation types to use in the Eclipse IDE
 for
 null checks?
 Or would it be fine to build the Sling IDE with target 1.8?
>>> 
>>> I am not opposed to building the IDE tooling with target 1.8 .
>>> First
>>> though, there is a workaround noted in the Eclipse bug:
>>> 
>>>  please make sure that an in projects below 1.8 you reference
>>> version
>>> [1.1.0,2.0.0) of the annotation bundle (exluding 2.0.0!)
>>> 
>>> Would that work for our scenario?
>> 
>> I have not tested that, but I just checked that indeed at least
>> Eclipse Neon ships with two different versions of that bundle 1.1.100
>> and 2.1.0 but I am not sure about older and newer versions of
>> Eclipse. I would rather instead upgrade to Java 8, since with Neon
>> Java 8 is anyhow required (see https://wiki.eclipse.org/Eclipse/Insta
>> llation).
>> WDYT?
> 
> I for one would switch to Java 8 only if really needed, as I think we
> need to make it as easy as possible to run the IDE tools.
> 
> Are there any developers out there using the IDE Tooling on Java 7? No
> idea. If there's a way to get null checking with Java 7, let's do that.
> Otherwise, feel free to raise a new SLING issue about moving to Java 8
> to track the reasons behind the move and change the requirement to Java
> 8.
> 
> Robert
> 
>> 
>>> 
>>> Robert
>>> 
 Konrad
 
> On 29 Dec 2016, at 18:01, Apache Jenkins Server  .apa
> che.org> wrote:
> 
> See 
> 
> Changes:
> 
> [kwin] SLING-6344 disable syncing if no filter.xml can be found
> 
> simplify FilterLocator service
> 
> --
> [...truncated 899 lines...]
> [INFO] --- maven-remote-resources-plugin:1.5:process (default)
> @
> reactor ---
> [INFO] 
> [INFO] --- maven-site-plugin:3.3:attach-descriptor (attach-
> descriptor) @ reactor ---
> [INFO] 
> [INFO] --- ianal-maven-plugin:1.0-alpha-1:verify-legal-files
> (default) @ reactor ---
> [INFO] 
> [INFO] --- apache-rat-plugin:0.10:check (default) @ reactor ---
> [INFO] 72 implicit excludes (use -debug for more details).
> [INFO] Exclude: derby.log
> [INFO] Exclude: .gitignore
> [INFO] Exclude: README.md
> [INFO] Exclude: *.launch
> [INFO] Exclude: build.properties
> [INFO] Exclude: .options
> [INFO] Exclude: META-INF/MANIFEST.MF
> [INFO] Exclude: **/*.binary
> [INFO] Exclude: eclipse-test/**
> [INFO] Exclude: source-bundle/target/**
> [INFO] Exclude: .Xauthority-*
> [INFO] 6 resources included (use -debug for more details)
> Warning:  org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser:
> Property 'http://www.oracle.com/xml/jaxp/properties/entityExpan
> sion
> Limit' is not recognized.
> Compiler warnings:
>  WARNING:  'org.apache.xerces.jaxp.SAXParserImpl: Property
> 'http://
> javax.xml.XMLConstants/property/accessExternalDTD' is not
> recognized.'
> Warning:  org.apache.xerces.parsers.SAXParser: Feature 'http://
> java
> x.xml.XMLConstants/feature/secure-processing' is not
> recognized.
> Warning:  org.apache.xerces.parsers.SAXParser: Property 'http:/
> /jav
> ax.xml.XMLConstants/property/accessExternalDTD' is not
> recognized.
> Warning:  org.apache.xerces.parsers.SAXParser: Property 'http:/
> /www
> .oracle.com/xml/jaxp/properties/entityExpansionLimit' is not
> recognized.
> [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0
> generated: 0 approved: 5 licence.
> [JENKINS] Archiving disabled
> [INFO] 
> 
> 
> [INFO] 
> 
> 
> [INFO] Building Sling IDE Tools: Target definition 1.1.1-
> SNAPSHOT
> [INFO] 
> 
> 
> [INFO] 
> [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @
> org.apache.sling.ide.target-definition ---
> [INFO] 
> [INFO] --- maven-remote-resources-plugin:1.5:process (default)
> @
> org.apache.sling.ide.target-definition ---
> [INFO] 
> [INFO] --- tycho-packaging-plugin:0.22.0:package-target-
> definition
> 

Re: Null checking annotatins for IDE tooling (was: Build failed in Jenkins: sling-ide #88)

[Robert Munteanu]

On Mon, 2017-01-09 at 09:24 -0500, Konrad Windszus wrote:
> > On 9 Jan 2017, at 06:00, Robert Munteanu 
> > wrote:
> > 
> > Hi Konrad,
> > 
> > On Thu, 2016-12-29 at 19:23 +0100, Konrad Windszus wrote:
> > > This is due to https://bugs.eclipse.org/bugs/show_bug.cgi?id=4340
> > > 33.
> > > Any suggestions which annotation types to use in the Eclipse IDE
> > > for
> > > null checks?
> > > Or would it be fine to build the Sling IDE with target 1.8?
> > 
> > I am not opposed to building the IDE tooling with target 1.8 .
> > First
> > though, there is a workaround noted in the Eclipse bug:
> > 
> >  please make sure that an in projects below 1.8 you reference
> > version
> > [1.1.0,2.0.0) of the annotation bundle (exluding 2.0.0!)
> > 
> > Would that work for our scenario?
> 
> I have not tested that, but I just checked that indeed at least
> Eclipse Neon ships with two different versions of that bundle 1.1.100
> and 2.1.0 but I am not sure about older and newer versions of
> Eclipse. I would rather instead upgrade to Java 8, since with Neon
> Java 8 is anyhow required (see https://wiki.eclipse.org/Eclipse/Insta
> llation).
> WDYT?

I for one would switch to Java 8 only if really needed, as I think we
need to make it as easy as possible to run the IDE tools.

Are there any developers out there using the IDE Tooling on Java 7? No
idea. If there's a way to get null checking with Java 7, let's do that.
Otherwise, feel free to raise a new SLING issue about moving to Java 8
to track the reasons behind the move and change the requirement to Java
8.

Robert

> 
> > 
> > Robert
> > 
> > > Konrad
> > > 
> > > > On 29 Dec 2016, at 18:01, Apache Jenkins Server  > > > .apa
> > > > che.org> wrote:
> > > > 
> > > > See 
> > > > 
> > > > Changes:
> > > > 
> > > > [kwin] SLING-6344 disable syncing if no filter.xml can be found
> > > > 
> > > > simplify FilterLocator service
> > > > 
> > > > --
> > > > [...truncated 899 lines...]
> > > > [INFO] --- maven-remote-resources-plugin:1.5:process (default)
> > > > @
> > > > reactor ---
> > > > [INFO] 
> > > > [INFO] --- maven-site-plugin:3.3:attach-descriptor (attach-
> > > > descriptor) @ reactor ---
> > > > [INFO] 
> > > > [INFO] --- ianal-maven-plugin:1.0-alpha-1:verify-legal-files
> > > > (default) @ reactor ---
> > > > [INFO] 
> > > > [INFO] --- apache-rat-plugin:0.10:check (default) @ reactor ---
> > > > [INFO] 72 implicit excludes (use -debug for more details).
> > > > [INFO] Exclude: derby.log
> > > > [INFO] Exclude: .gitignore
> > > > [INFO] Exclude: README.md
> > > > [INFO] Exclude: *.launch
> > > > [INFO] Exclude: build.properties
> > > > [INFO] Exclude: .options
> > > > [INFO] Exclude: META-INF/MANIFEST.MF
> > > > [INFO] Exclude: **/*.binary
> > > > [INFO] Exclude: eclipse-test/**
> > > > [INFO] Exclude: source-bundle/target/**
> > > > [INFO] Exclude: .Xauthority-*
> > > > [INFO] 6 resources included (use -debug for more details)
> > > > Warning:  org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser:
> > > > Property 'http://www.oracle.com/xml/jaxp/properties/entityExpan
> > > > sion
> > > > Limit' is not recognized.
> > > > Compiler warnings:
> > > >  WARNING:  'org.apache.xerces.jaxp.SAXParserImpl: Property
> > > > 'http://
> > > > javax.xml.XMLConstants/property/accessExternalDTD' is not
> > > > recognized.'
> > > > Warning:  org.apache.xerces.parsers.SAXParser: Feature 'http://
> > > > java
> > > > x.xml.XMLConstants/feature/secure-processing' is not
> > > > recognized.
> > > > Warning:  org.apache.xerces.parsers.SAXParser: Property 'http:/
> > > > /jav
> > > > ax.xml.XMLConstants/property/accessExternalDTD' is not
> > > > recognized.
> > > > Warning:  org.apache.xerces.parsers.SAXParser: Property 'http:/
> > > > /www
> > > > .oracle.com/xml/jaxp/properties/entityExpansionLimit' is not
> > > > recognized.
> > > > [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0
> > > > generated: 0 approved: 5 licence.
> > > > [JENKINS] Archiving disabled
> > > > [INFO] 
> > > > 
> > > > 
> > > > [INFO] 
> > > > 
> > > > 
> > > > [INFO] Building Sling IDE Tools: Target definition 1.1.1-
> > > > SNAPSHOT
> > > > [INFO] 
> > > > 
> > > > 
> > > > [INFO] 
> > > > [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @
> > > > org.apache.sling.ide.target-definition ---
> > > > [INFO] 
> > > > [INFO] --- maven-remote-resources-plugin:1.5:process (default)
> > > > @
> > > > org.apache.sling.ide.target-definition ---
> > > > [INFO] 
> > > > [INFO] --- tycho-packaging-plugin:0.22.0:package-target-
> > > > definition
> > > > (default-package-target-definition) @
> > > > org.apache.sling.ide.target-
> > > > definition ---
> > > > [INFO] 
> > > 

Re: Null checking annotatins for IDE tooling (was: Build failed in Jenkins: sling-ide #88)

[Konrad Windszus]

> On 9 Jan 2017, at 06:00, Robert Munteanu  wrote:
> 
> Hi Konrad,
> 
> On Thu, 2016-12-29 at 19:23 +0100, Konrad Windszus wrote:
>> This is due to https://bugs.eclipse.org/bugs/show_bug.cgi?id=434033.
>> Any suggestions which annotation types to use in the Eclipse IDE for
>> null checks?
>> Or would it be fine to build the Sling IDE with target 1.8?
> 
> I am not opposed to building the IDE tooling with target 1.8 . First
> though, there is a workaround noted in the Eclipse bug:
> 
>  please make sure that an in projects below 1.8 you reference version
> [1.1.0,2.0.0) of the annotation bundle (exluding 2.0.0!)
> 
> Would that work for our scenario?

I have not tested that, but I just checked that indeed at least Eclipse Neon 
ships with two different versions of that bundle 1.1.100 and 2.1.0 but I am not 
sure about older and newer versions of Eclipse. I would rather instead upgrade 
to Java 8, since with Neon Java 8 is anyhow required (see 
https://wiki.eclipse.org/Eclipse/Installation).
WDYT?

> 
> Robert
> 
>> Konrad
>> 
>>> On 29 Dec 2016, at 18:01, Apache Jenkins Server >> che.org> wrote:
>>> 
>>> See 
>>> 
>>> Changes:
>>> 
>>> [kwin] SLING-6344 disable syncing if no filter.xml can be found
>>> 
>>> simplify FilterLocator service
>>> 
>>> --
>>> [...truncated 899 lines...]
>>> [INFO] --- maven-remote-resources-plugin:1.5:process (default) @
>>> reactor ---
>>> [INFO] 
>>> [INFO] --- maven-site-plugin:3.3:attach-descriptor (attach-
>>> descriptor) @ reactor ---
>>> [INFO] 
>>> [INFO] --- ianal-maven-plugin:1.0-alpha-1:verify-legal-files
>>> (default) @ reactor ---
>>> [INFO] 
>>> [INFO] --- apache-rat-plugin:0.10:check (default) @ reactor ---
>>> [INFO] 72 implicit excludes (use -debug for more details).
>>> [INFO] Exclude: derby.log
>>> [INFO] Exclude: .gitignore
>>> [INFO] Exclude: README.md
>>> [INFO] Exclude: *.launch
>>> [INFO] Exclude: build.properties
>>> [INFO] Exclude: .options
>>> [INFO] Exclude: META-INF/MANIFEST.MF
>>> [INFO] Exclude: **/*.binary
>>> [INFO] Exclude: eclipse-test/**
>>> [INFO] Exclude: source-bundle/target/**
>>> [INFO] Exclude: .Xauthority-*
>>> [INFO] 6 resources included (use -debug for more details)
>>> Warning:  org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser:
>>> Property 'http://www.oracle.com/xml/jaxp/properties/entityExpansion
>>> Limit' is not recognized.
>>> Compiler warnings:
>>>  WARNING:  'org.apache.xerces.jaxp.SAXParserImpl: Property 'http://
>>> javax.xml.XMLConstants/property/accessExternalDTD' is not
>>> recognized.'
>>> Warning:  org.apache.xerces.parsers.SAXParser: Feature 'http://java
>>> x.xml.XMLConstants/feature/secure-processing' is not recognized.
>>> Warning:  org.apache.xerces.parsers.SAXParser: Property 'http://jav
>>> ax.xml.XMLConstants/property/accessExternalDTD' is not recognized.
>>> Warning:  org.apache.xerces.parsers.SAXParser: Property 'http://www
>>> .oracle.com/xml/jaxp/properties/entityExpansionLimit' is not
>>> recognized.
>>> [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0
>>> generated: 0 approved: 5 licence.
>>> [JENKINS] Archiving disabled
>>> [INFO] 
>>> 
>>> [INFO] 
>>> 
>>> [INFO] Building Sling IDE Tools: Target definition 1.1.1-SNAPSHOT
>>> [INFO] 
>>> 
>>> [INFO] 
>>> [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @
>>> org.apache.sling.ide.target-definition ---
>>> [INFO] 
>>> [INFO] --- maven-remote-resources-plugin:1.5:process (default) @
>>> org.apache.sling.ide.target-definition ---
>>> [INFO] 
>>> [INFO] --- tycho-packaging-plugin:0.22.0:package-target-definition
>>> (default-package-target-definition) @ org.apache.sling.ide.target-
>>> definition ---
>>> [INFO] 
>>> [INFO] --- maven-site-plugin:3.3:attach-descriptor (attach-
>>> descriptor) @ org.apache.sling.ide.target-definition ---
>>> [INFO] 
>>> [INFO] --- ianal-maven-plugin:1.0-alpha-1:verify-legal-files
>>> (default) @ org.apache.sling.ide.target-definition ---
>>> [INFO] 
>>> [INFO] --- apache-rat-plugin:0.10:check (default) @
>>> org.apache.sling.ide.target-definition ---
>>> [INFO] 51 implicit excludes (use -debug for more details).
>>> [INFO] Exclude: derby.log
>>> [INFO] Exclude: .gitignore
>>> [INFO] Exclude: README.md
>>> [INFO] Exclude: *.launch
>>> [INFO] Exclude: build.properties
>>> [INFO] Exclude: .options
>>> [INFO] Exclude: META-INF/MANIFEST.MF
>>> [INFO] Exclude: **/*.binary
>>> [INFO] Exclude: eclipse-test/**
>>> [INFO] Exclude: source-bundle/target/**
>>> [INFO] Exclude: .Xauthority-*
>>> [INFO] 3 resources included (use -debug for more details)
>>> Warning:  org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser:
>>> Property 

Null checking annotatins for IDE tooling (was: Build failed in Jenkins: sling-ide #88)

[Robert Munteanu]

Hi Konrad,

On Thu, 2016-12-29 at 19:23 +0100, Konrad Windszus wrote:
> This is due to https://bugs.eclipse.org/bugs/show_bug.cgi?id=434033.
> Any suggestions which annotation types to use in the Eclipse IDE for
> null checks?
> Or would it be fine to build the Sling IDE with target 1.8?

I am not opposed to building the IDE tooling with target 1.8 . First
though, there is a workaround noted in the Eclipse bug:

  please make sure that an in projects below 1.8 you reference version
[1.1.0,2.0.0) of the annotation bundle (exluding 2.0.0!)

Would that work for our scenario?

Robert

> Konrad
> 
> > On 29 Dec 2016, at 18:01, Apache Jenkins Server  > che.org> wrote:
> > 
> > See 
> > 
> > Changes:
> > 
> > [kwin] SLING-6344 disable syncing if no filter.xml can be found
> > 
> > simplify FilterLocator service
> > 
> > --
> > [...truncated 899 lines...]
> > [INFO] --- maven-remote-resources-plugin:1.5:process (default) @
> > reactor ---
> > [INFO] 
> > [INFO] --- maven-site-plugin:3.3:attach-descriptor (attach-
> > descriptor) @ reactor ---
> > [INFO] 
> > [INFO] --- ianal-maven-plugin:1.0-alpha-1:verify-legal-files
> > (default) @ reactor ---
> > [INFO] 
> > [INFO] --- apache-rat-plugin:0.10:check (default) @ reactor ---
> > [INFO] 72 implicit excludes (use -debug for more details).
> > [INFO] Exclude: derby.log
> > [INFO] Exclude: .gitignore
> > [INFO] Exclude: README.md
> > [INFO] Exclude: *.launch
> > [INFO] Exclude: build.properties
> > [INFO] Exclude: .options
> > [INFO] Exclude: META-INF/MANIFEST.MF
> > [INFO] Exclude: **/*.binary
> > [INFO] Exclude: eclipse-test/**
> > [INFO] Exclude: source-bundle/target/**
> > [INFO] Exclude: .Xauthority-*
> > [INFO] 6 resources included (use -debug for more details)
> > Warning:  org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser:
> > Property 'http://www.oracle.com/xml/jaxp/properties/entityExpansion
> > Limit' is not recognized.
> > Compiler warnings:
> >  WARNING:  'org.apache.xerces.jaxp.SAXParserImpl: Property 'http://
> > javax.xml.XMLConstants/property/accessExternalDTD' is not
> > recognized.'
> > Warning:  org.apache.xerces.parsers.SAXParser: Feature 'http://java
> > x.xml.XMLConstants/feature/secure-processing' is not recognized.
> > Warning:  org.apache.xerces.parsers.SAXParser: Property 'http://jav
> > ax.xml.XMLConstants/property/accessExternalDTD' is not recognized.
> > Warning:  org.apache.xerces.parsers.SAXParser: Property 'http://www
> > .oracle.com/xml/jaxp/properties/entityExpansionLimit' is not
> > recognized.
> > [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0
> > generated: 0 approved: 5 licence.
> > [JENKINS] Archiving disabled
> > [INFO] 
> > 
> > [INFO] 
> > 
> > [INFO] Building Sling IDE Tools: Target definition 1.1.1-SNAPSHOT
> > [INFO] 
> > 
> > [INFO] 
> > [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @
> > org.apache.sling.ide.target-definition ---
> > [INFO] 
> > [INFO] --- maven-remote-resources-plugin:1.5:process (default) @
> > org.apache.sling.ide.target-definition ---
> > [INFO] 
> > [INFO] --- tycho-packaging-plugin:0.22.0:package-target-definition
> > (default-package-target-definition) @ org.apache.sling.ide.target-
> > definition ---
> > [INFO] 
> > [INFO] --- maven-site-plugin:3.3:attach-descriptor (attach-
> > descriptor) @ org.apache.sling.ide.target-definition ---
> > [INFO] 
> > [INFO] --- ianal-maven-plugin:1.0-alpha-1:verify-legal-files
> > (default) @ org.apache.sling.ide.target-definition ---
> > [INFO] 
> > [INFO] --- apache-rat-plugin:0.10:check (default) @
> > org.apache.sling.ide.target-definition ---
> > [INFO] 51 implicit excludes (use -debug for more details).
> > [INFO] Exclude: derby.log
> > [INFO] Exclude: .gitignore
> > [INFO] Exclude: README.md
> > [INFO] Exclude: *.launch
> > [INFO] Exclude: build.properties
> > [INFO] Exclude: .options
> > [INFO] Exclude: META-INF/MANIFEST.MF
> > [INFO] Exclude: **/*.binary
> > [INFO] Exclude: eclipse-test/**
> > [INFO] Exclude: source-bundle/target/**
> > [INFO] Exclude: .Xauthority-*
> > [INFO] 3 resources included (use -debug for more details)
> > Warning:  org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser:
> > Property 'http://www.oracle.com/xml/jaxp/properties/entityExpansion
> > Limit' is not recognized.
> > Compiler warnings:
> >  WARNING:  'org.apache.xerces.jaxp.SAXParserImpl: Property 'http://
> > javax.xml.XMLConstants/property/accessExternalDTD' is not
> > recognized.'
> > Warning:  org.apache.xerces.parsers.SAXParser: Feature 'http://java
> > x.xml.XMLConstants/feature/secure-processing' is not recognized.
> > Warning:  org.apache.xerces.parsers.SAXParser: Property 'http://jav
> >