[GitHub] spark pull request: [WIP] SPARK-1192: The document for most of the...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/85#issuecomment-37211617 Build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [WIP] SPARK-1192: The document for most of the...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/85#issuecomment-37211618 Build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [WIP] SPARK-1192: The document for most of the...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/85#issuecomment-37217442 One or more automated tests failed Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13099/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [WIP] SPARK-1192: The document for most of the...
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/85#discussion_r10355654
--- Diff: core/src/main/scala/org/apache/spark/util/AkkaUtils.scala ---
@@ -108,6 +108,6 @@ private[spark] object AkkaUtils {
/** Returns the default Spark timeout to use for Akka remote actor
lookup. */
def lookupTimeout(conf: SparkConf): FiniteDuration = {
-Duration.create(conf.get(spark.akka.lookupTimeout, 30).toLong,
seconds)
+Duration.create(conf.getLong(spark.akka.lookupTimeout, 30),
seconds)
--- End diff --
This looks unrelated to your patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [WIP] SPARK-1192: The document for most of the...
Github user CodingCat commented on a diff in the pull request:
https://github.com/apache/spark/pull/85#discussion_r10355799
--- Diff: core/src/main/scala/org/apache/spark/util/AkkaUtils.scala ---
@@ -108,6 +108,6 @@ private[spark] object AkkaUtils {
/** Returns the default Spark timeout to use for Akka remote actor
lookup. */
def lookupTimeout(conf: SparkConf): FiniteDuration = {
-Duration.create(conf.get(spark.akka.lookupTimeout, 30).toLong,
seconds)
+Duration.create(conf.getLong(spark.akka.lookupTimeout, 30),
seconds)
--- End diff --
Oh, when I looked at this parameter I found that it is inconsistent with
L106, I thought it is better to make them consistent, especially when they are
so similar in the functionality
https://github.com/CodingCat/spark/blob/config_fix/core/src/main/scala/org/apache/spark/util/AkkaUtils.scala#L106
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [WIP] SPARK-1192: The document for most of the...
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/85#discussion_r10369848
--- Diff: core/src/main/scala/org/apache/spark/util/AkkaUtils.scala ---
@@ -108,6 +108,6 @@ private[spark] object AkkaUtils {
/** Returns the default Spark timeout to use for Akka remote actor
lookup. */
def lookupTimeout(conf: SparkConf): FiniteDuration = {
-Duration.create(conf.get(spark.akka.lookupTimeout, 30).toLong,
seconds)
+Duration.create(conf.getLong(spark.akka.lookupTimeout, 30),
seconds)
--- End diff --
Oh cool that makes sense -- thanks for fixing this!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [WIP] SPARK-1192: The document for most of the...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/85#issuecomment-36958934 Build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [WIP] SPARK-1192: The document for most of the...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/85#issuecomment-36958936 Build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [WIP] SPARK-1192: The document for most of the...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/85#issuecomment-36962140 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13031/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [WIP] SPARK-1192: The document for most of the...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/85#issuecomment-36967432 Build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [WIP] SPARK-1192: The document for most of the...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/85#issuecomment-36967527 Build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [WIP] SPARK-1192: The document for most of the...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/85#issuecomment-36967526 Build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [WIP] SPARK-1192: The document for most of the...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/85#issuecomment-36969147 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13037/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [WIP] SPARK-1192: The document for most of the...
Github user CodingCat commented on the pull request: https://github.com/apache/spark/pull/85#issuecomment-36812678 I said it is WIP, because of 2 things 1. The document is surely need to be revised, I'm not sure if I understand all details correctly, though I spent not so short time to figure out what the parameters specify 2. Adding these parameters to configuration page will make that page a bit too long, do we need to re-structure the docs? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [WIP] SPARK-1192: The document for most of the...
Github user CodingCat commented on the pull request: https://github.com/apache/spark/pull/85#issuecomment-36813427 @pwendell , yep, I asked in the mail list, but didn't get response, so I decided to put the things here first and revise it (e.g. remove those unnecessary) based on the feedbacks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [WIP] SPARK-1192: The document for most of the...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/85#issuecomment-36815476 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13009/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [WIP] SPARK-1192: The document for most of the...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/85#issuecomment-36815474 Merged build finished. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [WIP] SPARK-1192: The document for most of the...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/85#issuecomment-36815535 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [WIP] SPARK-1192: The document for most of the...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/85#issuecomment-36815759 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [WIP] SPARK-1192: The document for most of the...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/85#issuecomment-36824087 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [WIP] SPARK-1192: The document for most of the...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/85#issuecomment-36824086 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [WIP] SPARK-1192: The document for most of the...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/85#issuecomment-36826227 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13015/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [WIP] SPARK-1192: The document for most of the...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/85#issuecomment-36826226 Merged build finished. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [WIP] SPARK-1192: The document for most of the...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/85#issuecomment-36826295 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [WIP] SPARK-1192: The document for most of the...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/85#issuecomment-36828597 Merged build finished. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [WIP] SPARK-1192: The document for most of the...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/85#issuecomment-36828600 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13019/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
