Re: PSA: Java 8 unidoc build

2017-02-07 Thread Shixiong(Ryan) Zhu 
@Sean, I'm using Java 8 but don't see these errors until I manually build
the API docs. Hence I think dropping Java 7 support may not help.

Right now we don't build docs in most of builds as building docs takes a
long time (e.g.,
https://amplab.cs.berkeley.edu/jenkins/job/spark-master-docs/2889/ says
it's 1.5 hours).

On Tue, Feb 7, 2017 at 4:06 AM, Sean Owen  wrote:

> I believe that if we ran the Jenkins builds with Java 8 we would catch
> these? this doesn't require dropping Java 7 support or anything.
>
> @joshrosen I know we are just now talking about modifying the Jenkins jobs
> to remove old Hadoop configs. Is it possible to change the master jobs to
> use Java 8? can't hurt really in any event.
>
> Or maybe I'm mistaken and they already run Java 8 and it doesn't catch
> this until Java 8 is the target.
>
> Yeah this is going to keep breaking as javadoc 8 is pretty strict. Thanks
> Hyukjin. It has forced us to clean up a lot of sloppy bits of doc though.
>
>
> On Tue, Feb 7, 2017 at 12:13 AM Joseph Bradley 
> wrote:
>
>> Public service announcement: Our doc build has worked with Java 8 for
>> brief time periods, but new changes keep breaking the Java 8 unidoc build.
>> Please be aware of this, and try to test doc changes with Java 8!  In
>> general, it is stricter than Java 7 for docs.
>>
>> A shout out to @HyukjinKwon and others who have made many fixes for
>> this!  See these sample PRs for some issues causing failures (especially
>> around links):
>> https://github.com/apache/spark/pull/16741
>> https://github.com/apache/spark/pull/16604
>>
>> Thanks,
>> Joseph
>>
>> --
>>
>> Joseph Bradley
>>
>> Software Engineer - Machine Learning
>>
>> Databricks, Inc.
>>
>> [image: http://databricks.com] 
>>
>

Re: PSA: Java 8 unidoc build

2017-02-07 Thread Felix Cheung 
+1 for all the great work going in for this, HyukjinKwon, and +1 on what Sean 
says about "Jenkins builds with Java 8" and we should catch these nasty 
javadoc8 issue quickly.

I think that would be the great first step to move away from java 7


_
From: Reynold Xin mailto:r...@databricks.com>>
Sent: Tuesday, February 7, 2017 4:48 AM
Subject: Re: PSA: Java 8 unidoc build
To: Sean Owen mailto:so...@cloudera.com>>
Cc: Josh Rosen mailto:joshro...@databricks.com>>, 
Joseph Bradley mailto:jos...@databricks.com>>, 
mailto:dev@spark.apache.org>>


I don't know if this would help but I think we can also officially stop 
supporting Java 7 ...


On Tue, Feb 7, 2017 at 1:06 PM, Sean Owen 
mailto:so...@cloudera.com>> wrote:
I believe that if we ran the Jenkins builds with Java 8 we would catch these? 
this doesn't require dropping Java 7 support or anything.

@joshrosen I know we are just now talking about modifying the Jenkins jobs to 
remove old Hadoop configs. Is it possible to change the master jobs to use Java 
8? can't hurt really in any event.

Or maybe I'm mistaken and they already run Java 8 and it doesn't catch this 
until Java 8 is the target.

Yeah this is going to keep breaking as javadoc 8 is pretty strict. Thanks 
Hyukjin. It has forced us to clean up a lot of sloppy bits of doc though.


On Tue, Feb 7, 2017 at 12:13 AM Joseph Bradley 
mailto:jos...@databricks.com>> wrote:
Public service announcement: Our doc build has worked with Java 8 for brief 
time periods, but new changes keep breaking the Java 8 unidoc build.  Please be 
aware of this, and try to test doc changes with Java 8!  In general, it is 
stricter than Java 7 for docs.

A shout out to @HyukjinKwon and others who have made many fixes for this!  See 
these sample PRs for some issues causing failures (especially around links):
https://github.com/apache/spark/pull/16741
https://github.com/apache/spark/pull/16604

Thanks,
Joseph

--

Joseph Bradley

Software Engineer - Machine Learning

Databricks, Inc.

[http://databricks.com]<http://databricks.com/>

Re: PSA: Java 8 unidoc build

2017-02-07 Thread Reynold Xin 
I don't know if this would help but I think we can also officially stop
supporting Java 7 ...


On Tue, Feb 7, 2017 at 1:06 PM, Sean Owen  wrote:

> I believe that if we ran the Jenkins builds with Java 8 we would catch
> these? this doesn't require dropping Java 7 support or anything.
>
> @joshrosen I know we are just now talking about modifying the Jenkins jobs
> to remove old Hadoop configs. Is it possible to change the master jobs to
> use Java 8? can't hurt really in any event.
>
> Or maybe I'm mistaken and they already run Java 8 and it doesn't catch
> this until Java 8 is the target.
>
> Yeah this is going to keep breaking as javadoc 8 is pretty strict. Thanks
> Hyukjin. It has forced us to clean up a lot of sloppy bits of doc though.
>
>
> On Tue, Feb 7, 2017 at 12:13 AM Joseph Bradley 
> wrote:
>
>> Public service announcement: Our doc build has worked with Java 8 for
>> brief time periods, but new changes keep breaking the Java 8 unidoc build.
>> Please be aware of this, and try to test doc changes with Java 8!  In
>> general, it is stricter than Java 7 for docs.
>>
>> A shout out to @HyukjinKwon and others who have made many fixes for
>> this!  See these sample PRs for some issues causing failures (especially
>> around links):
>> https://github.com/apache/spark/pull/16741
>> https://github.com/apache/spark/pull/16604
>>
>> Thanks,
>> Joseph
>>
>> --
>>
>> Joseph Bradley
>>
>> Software Engineer - Machine Learning
>>
>> Databricks, Inc.
>>
>> [image: http://databricks.com] 
>>
>

Re: PSA: Java 8 unidoc build

2017-02-07 Thread Sean Owen 
I believe that if we ran the Jenkins builds with Java 8 we would catch
these? this doesn't require dropping Java 7 support or anything.

@joshrosen I know we are just now talking about modifying the Jenkins jobs
to remove old Hadoop configs. Is it possible to change the master jobs to
use Java 8? can't hurt really in any event.

Or maybe I'm mistaken and they already run Java 8 and it doesn't catch this
until Java 8 is the target.

Yeah this is going to keep breaking as javadoc 8 is pretty strict. Thanks
Hyukjin. It has forced us to clean up a lot of sloppy bits of doc though.

On Tue, Feb 7, 2017 at 12:13 AM Joseph Bradley 
wrote:

> Public service announcement: Our doc build has worked with Java 8 for
> brief time periods, but new changes keep breaking the Java 8 unidoc build.
> Please be aware of this, and try to test doc changes with Java 8!  In
> general, it is stricter than Java 7 for docs.
>
> A shout out to @HyukjinKwon and others who have made many fixes for this!
> See these sample PRs for some issues causing failures (especially around
> links):
> https://github.com/apache/spark/pull/16741
> https://github.com/apache/spark/pull/16604
>
> Thanks,
> Joseph
>
> --
>
> Joseph Bradley
>
> Software Engineer - Machine Learning
>
> Databricks, Inc.
>
> [image: http://databricks.com] 
>

Re: PSA: Java 8 unidoc build

2017-02-06 Thread Hyukjin Kwon 
(One more.. https://github.com/apache/spark/pull/15999 this describes some
more cases that might easily be mistaken)

On 7 Feb 2017 9:21 a.m., "Hyukjin Kwon"  wrote:

> Oh, Joseph, thanks. It is nice to inform this in dev mailing list.
>
> Let me please leave another PR to refer,
>
> https://github.com/apache/spark/pull/16013
>
> and the JIRA you kindly opened,
>
> https://issues.apache.org/jira/browse/SPARK-18692
>
>
> On 7 Feb 2017 9:13 a.m., "Joseph Bradley"  wrote:
>
> Public service announcement: Our doc build has worked with Java 8 for
> brief time periods, but new changes keep breaking the Java 8 unidoc build.
> Please be aware of this, and try to test doc changes with Java 8!  In
> general, it is stricter than Java 7 for docs.
>
> A shout out to @HyukjinKwon and others who have made many fixes for this!
> See these sample PRs for some issues causing failures (especially around
> links):
> https://github.com/apache/spark/pull/16741
> https://github.com/apache/spark/pull/16604
>
> Thanks,
> Joseph
>
> --
>
> Joseph Bradley
>
> Software Engineer - Machine Learning
>
> Databricks, Inc.
>
> [image: http://databricks.com] 
>
>
>

Re: PSA: Java 8 unidoc build

2017-02-06 Thread Hyukjin Kwon 
Oh, Joseph, thanks. It is nice to inform this in dev mailing list.

Let me please leave another PR to refer,

https://github.com/apache/spark/pull/16013

and the JIRA you kindly opened,

https://issues.apache.org/jira/browse/SPARK-18692


On 7 Feb 2017 9:13 a.m., "Joseph Bradley"  wrote:

Public service announcement: Our doc build has worked with Java 8 for brief
time periods, but new changes keep breaking the Java 8 unidoc build.
Please be aware of this, and try to test doc changes with Java 8!  In
general, it is stricter than Java 7 for docs.

A shout out to @HyukjinKwon and others who have made many fixes for this!
See these sample PRs for some issues causing failures (especially around
links):
https://github.com/apache/spark/pull/16741
https://github.com/apache/spark/pull/16604

Thanks,
Joseph

-- 

Joseph Bradley

Software Engineer - Machine Learning

Databricks, Inc.

[image: http://databricks.com]