[jira] [Commented] (SQOOP-3081) use OracleEscapeUtils.escapeIdentifier OracleUpsertOutputFormat + add compatibility with SQOOP-3066

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/SQOOP-3081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15754327#comment-15754327
 ] 

Hudson commented on SQOOP-3081:
---

SUCCESS: Integrated in Jenkins build Sqoop-hadoop20 #1082 (See 
[https://builds.apache.org/job/Sqoop-hadoop20/1082/])
SQOOP-3081: use OracleEscapeUtils.escapeIdentifier in (maugli: 
[https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=d1e6c5f52f8913a619cfe77c87970d7938c84844])
* (edit) src/test/com/cloudera/sqoop/manager/OracleExportTest.java
* (edit) src/java/org/apache/sqoop/mapreduce/OracleUpsertOutputFormat.java


> use OracleEscapeUtils.escapeIdentifier OracleUpsertOutputFormat + add 
> compatibility with SQOOP-3066
> ---
>
> Key: SQOOP-3081
> URL: https://issues.apache.org/jira/browse/SQOOP-3081
> Project: Sqoop
>  Issue Type: Bug
>Reporter: Anna Szonyi
>Assignee: Anna Szonyi
> Attachments: SQOOP-3081-2.patch, SQOOP-3081-3.patch, SQOOP-3081.patch
>
>
> Introduce OracleEscapeUtils.escapeIdentifiers In OracleUpsertOutputFormat to 
> make it consistent with the rest of the code and compatible with SQOOP-3066.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SQOOP-3081) use OracleEscapeUtils.escapeIdentifier OracleUpsertOutputFormat + add compatibility with SQOOP-3066

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/SQOOP-3081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15754288#comment-15754288
 ] 

Hudson commented on SQOOP-3081:
---

SUCCESS: Integrated in Jenkins build Sqoop-hadoop200 #1088 (See 
[https://builds.apache.org/job/Sqoop-hadoop200/1088/])
SQOOP-3081: use OracleEscapeUtils.escapeIdentifier in (maugli: 
[https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=d1e6c5f52f8913a619cfe77c87970d7938c84844])
* (edit) src/java/org/apache/sqoop/mapreduce/OracleUpsertOutputFormat.java
* (edit) src/test/com/cloudera/sqoop/manager/OracleExportTest.java


> use OracleEscapeUtils.escapeIdentifier OracleUpsertOutputFormat + add 
> compatibility with SQOOP-3066
> ---
>
> Key: SQOOP-3081
> URL: https://issues.apache.org/jira/browse/SQOOP-3081
> Project: Sqoop
>  Issue Type: Bug
>Reporter: Anna Szonyi
>Assignee: Anna Szonyi
> Attachments: SQOOP-3081-2.patch, SQOOP-3081-3.patch, SQOOP-3081.patch
>
>
> Introduce OracleEscapeUtils.escapeIdentifiers In OracleUpsertOutputFormat to 
> make it consistent with the rest of the code and compatible with SQOOP-3066.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SQOOP-3084) org/aspectj/tools/ant/taskdefs/aspectjTaskdefs.properties path needs to be changed after SQOOP-3051

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/SQOOP-3084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15754274#comment-15754274
 ] 

Hudson commented on SQOOP-3084:
---

SUCCESS: Integrated in Jenkins build Sqoop-hadoop100 #1047 (See 
[https://builds.apache.org/job/Sqoop-hadoop100/1047/])
SQOOP-3084: Fix fault injection classpath elements in aop.xml (required 
(maugli: 
[https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=bde0ed1e74ed9645aa0b001464b6a594ee4e362c])
* (edit) src/test/aop/build/aop.xml


> org/aspectj/tools/ant/taskdefs/aspectjTaskdefs.properties path needs to be 
> changed after SQOOP-3051
> ---
>
> Key: SQOOP-3084
> URL: https://issues.apache.org/jira/browse/SQOOP-3084
> Project: Sqoop
>  Issue Type: Bug
>Reporter: Anna Szonyi
>Assignee: Anna Szonyi
> Attachments: SQOOP-3084.patch
>
>
> Due to ivy changes in 3051 the path of 
> org/aspectj/tools/ant/taskdefs/aspectjTaskdefs.properties path needs to be 
> changed, as there is no longer a hadoop$\{hadoopversion\}test, just test



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SQOOP-3081) use OracleEscapeUtils.escapeIdentifier OracleUpsertOutputFormat + add compatibility with SQOOP-3066

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/SQOOP-3081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15754275#comment-15754275
 ] 

Hudson commented on SQOOP-3081:
---

SUCCESS: Integrated in Jenkins build Sqoop-hadoop100 #1047 (See 
[https://builds.apache.org/job/Sqoop-hadoop100/1047/])
SQOOP-3081: use OracleEscapeUtils.escapeIdentifier in (maugli: 
[https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=d1e6c5f52f8913a619cfe77c87970d7938c84844])
* (edit) src/java/org/apache/sqoop/mapreduce/OracleUpsertOutputFormat.java
* (edit) src/test/com/cloudera/sqoop/manager/OracleExportTest.java


> use OracleEscapeUtils.escapeIdentifier OracleUpsertOutputFormat + add 
> compatibility with SQOOP-3066
> ---
>
> Key: SQOOP-3081
> URL: https://issues.apache.org/jira/browse/SQOOP-3081
> Project: Sqoop
>  Issue Type: Bug
>Reporter: Anna Szonyi
>Assignee: Anna Szonyi
> Attachments: SQOOP-3081-2.patch, SQOOP-3081-3.patch, SQOOP-3081.patch
>
>
> Introduce OracleEscapeUtils.escapeIdentifiers In OracleUpsertOutputFormat to 
> make it consistent with the rest of the code and compatible with SQOOP-3066.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SQOOP-3075) Simplify Unicode character support in source files (introduced by SQOOP-3074) by defining explicit locales instead of using EscapeUtils

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/SQOOP-3075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15754224#comment-15754224
 ] 

Hudson commented on SQOOP-3075:
---

SUCCESS: Integrated in Jenkins build Sqoop-hadoop23 #1283 (See 
[https://builds.apache.org/job/Sqoop-hadoop23/1283/])
SQOOP-3075: Simplify Unicode character support in source files (maugli: 
[https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=be30a344ee28ae60fcce9e9e45a0ec73c93209a7])
* (edit) src/java/org/apache/sqoop/avro/AvroUtil.java
* (edit) src/java/org/apache/sqoop/orm/AvroSchemaGenerator.java
* (edit) src/java/org/apache/sqoop/orm/CompilationManager.java
* (edit) src/java/org/apache/sqoop/orm/ClassWriter.java


> Simplify Unicode character support in source files (introduced by SQOOP-3074) 
> by defining explicit locales instead of using EscapeUtils
> ---
>
> Key: SQOOP-3075
> URL: https://issues.apache.org/jira/browse/SQOOP-3075
> Project: Sqoop
>  Issue Type: Improvement
>Reporter: Attila Szabo
>Assignee: Attila Szabo
> Attachments: SQOOP-3075.patch
>
>
> Although [SQOOP-3074] achieved that Sqoop won't fail anymore with special 
> characters even if the locale on the caller system is not UTF-8, there's a 
> simpler solution to do the same thing, by tuning the compiler + classwriter 
> itself (by adding explicit encodings) instead of using the 
> StringEscapeUtils#escapeJava mechanism.
> This solution seems simpler, and won't introduce any confusion around 
> generation of Java identifiers.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SQOOP-3083) Fault injection targets no longer work after SQOOP-2983

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/SQOOP-3083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15754226#comment-15754226
 ] 

Hudson commented on SQOOP-3083:
---

SUCCESS: Integrated in Jenkins build Sqoop-hadoop23 #1283 (See 
[https://builds.apache.org/job/Sqoop-hadoop23/1283/])
SQOOP-3083: Fixing fault injection targets to work together with try (maugli: 
[https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=7783f85f805d54f8377a438aebffb06593aec858])
* (edit) ivy/libraries.properties
* (edit) src/test/aop/build/aop.xml


> Fault injection targets no longer work after SQOOP-2983
> ---
>
> Key: SQOOP-3083
> URL: https://issues.apache.org/jira/browse/SQOOP-3083
> Project: Sqoop
>  Issue Type: Bug
>Reporter: Anna Szonyi
>Assignee: Anna Szonyi
> Attachments: SQOOP-3083-2.patch, SQOOP-3083.patch
>
>
> Fault injection target fails due to:
> compile-fault-inject:
>  [echo] Start weaving aspects in place
>  [iajc] OraOopTestCase.java:157 [error] Syntax error on token "(", { 
> expected
>  [iajc] try (Statement stmt = conn.createStatement()) {
>  [iajc] 
>  [iajc] OraOopTestCase.java:157 [error] Syntax error on token ")", ; 
> expected
>  [iajc] try (Statement stmt = conn.createStatement()) {
>  [iajc] 
>  [iajc] OraOopTestCase.java:161 [error] Syntax error, insert "}" to 
> complete Block
>  [iajc] }
>  [iajc] 
>  [iajc] OraOopTestCase.java:161 [error] Syntax error, insert "Finally" to 
> complete TryStatement
>  [iajc] }
>  [iajc] 
>  [iajc] OraOopTypesTest.java:56 [error] Syntax error on token "(", { 
> expected
>  [iajc] try (Statement stmt = conn.createStatement()) {
>  [iajc] 
>  [iajc] OraOopTypesTest.java:56 [error] Syntax error on token ")", ; 
> expected
>  [iajc] try (Statement stmt = conn.createStatement()) {
>  [iajc] 
>  [iajc] OraOopTypesTest.java:78 [error] Syntax error on token "(", { 
> expected
>  [iajc] try (Statement stmt = conn.createStatement()) {
>  [iajc] 
>  [iajc] OraOopTypesTest.java:78 [error] Duplicate local variable stmt
>  [iajc] try (Statement stmt = conn.createStatement()) {
>  [iajc]
>  [iajc] OraOopTypesTest.java:78 [error] Syntax error on token ")", ; 
> expected
>  [iajc] try (Statement stmt = conn.createStatement()) {
>  [iajc] 
>  [iajc] OraOopTypesTest.java:157 [error] Syntax error, insert "}" to 
> complete Block
>  [iajc] }
>  [iajc] 
>  [iajc] OraOopTypesTest.java:157 [error] Syntax error, insert "Finally" 
> to complete TryStatement
>  [iajc] }
>  [iajc] 
>  [iajc] OraOopTypesTest.java:157 [error] Syntax error, insert "}" to 
> complete Block
>  [iajc] }
>  [iajc] 
>  [iajc] OraOopTypesTest.java:157 [error] Syntax error, insert "Finally" 
> to complete BlockStatements
>  [iajc] }
>  [iajc] 
>  [iajc] OracleData.java:240 [error] Syntax error on token "(", { expected
>  [iajc] try (Statement stmt = conn.createStatement()) {
>  [iajc] 
>  [iajc] OracleData.java:240 [error] Syntax error on token ")", ; expected
>  [iajc] try (Statement stmt = conn.createStatement()) {
>  [iajc] 
>  [iajc] OracleData.java:243 [error] Syntax error, insert "}" to complete 
> Block
>  [iajc] }
>  [iajc] 
>  [iajc] OracleData.java:243 [error] Syntax error, insert "Finally" to 
> complete BlockStatements
>  [iajc] }
>  [iajc] 
>  [iajc] 
>  [iajc] 17 errors



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SQOOP-3081) use OracleEscapeUtils.escapeIdentifier OracleUpsertOutputFormat + add compatibility with SQOOP-3066

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/SQOOP-3081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15754225#comment-15754225
 ] 

Hudson commented on SQOOP-3081:
---

SUCCESS: Integrated in Jenkins build Sqoop-hadoop23 #1283 (See 
[https://builds.apache.org/job/Sqoop-hadoop23/1283/])
SQOOP-3081: use OracleEscapeUtils.escapeIdentifier in (maugli: 
[https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=d1e6c5f52f8913a619cfe77c87970d7938c84844])
* (edit) src/test/com/cloudera/sqoop/manager/OracleExportTest.java
* (edit) src/java/org/apache/sqoop/mapreduce/OracleUpsertOutputFormat.java


> use OracleEscapeUtils.escapeIdentifier OracleUpsertOutputFormat + add 
> compatibility with SQOOP-3066
> ---
>
> Key: SQOOP-3081
> URL: https://issues.apache.org/jira/browse/SQOOP-3081
> Project: Sqoop
>  Issue Type: Bug
>Reporter: Anna Szonyi
>Assignee: Anna Szonyi
> Attachments: SQOOP-3081-2.patch, SQOOP-3081-3.patch, SQOOP-3081.patch
>
>
> Introduce OracleEscapeUtils.escapeIdentifiers In OracleUpsertOutputFormat to 
> make it consistent with the rest of the code and compatible with SQOOP-3066.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SQOOP-3084) org/aspectj/tools/ant/taskdefs/aspectjTaskdefs.properties path needs to be changed after SQOOP-3051

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/SQOOP-3084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15754223#comment-15754223
 ] 

Hudson commented on SQOOP-3084:
---

SUCCESS: Integrated in Jenkins build Sqoop-hadoop23 #1283 (See 
[https://builds.apache.org/job/Sqoop-hadoop23/1283/])
SQOOP-3084: Fix fault injection classpath elements in aop.xml (required 
(maugli: 
[https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=bde0ed1e74ed9645aa0b001464b6a594ee4e362c])
* (edit) src/test/aop/build/aop.xml


> org/aspectj/tools/ant/taskdefs/aspectjTaskdefs.properties path needs to be 
> changed after SQOOP-3051
> ---
>
> Key: SQOOP-3084
> URL: https://issues.apache.org/jira/browse/SQOOP-3084
> Project: Sqoop
>  Issue Type: Bug
>Reporter: Anna Szonyi
>Assignee: Anna Szonyi
> Attachments: SQOOP-3084.patch
>
>
> Due to ivy changes in 3051 the path of 
> org/aspectj/tools/ant/taskdefs/aspectjTaskdefs.properties path needs to be 
> changed, as there is no longer a hadoop$\{hadoopversion\}test, just test



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SQOOP-3084) org/aspectj/tools/ant/taskdefs/aspectjTaskdefs.properties path needs to be changed after SQOOP-3051

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/SQOOP-3084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15754208#comment-15754208
 ] 

Hudson commented on SQOOP-3084:
---

SUCCESS: Integrated in Jenkins build Sqoop-hadoop20 #1081 (See 
[https://builds.apache.org/job/Sqoop-hadoop20/1081/])
SQOOP-3084: Fix fault injection classpath elements in aop.xml (required 
(maugli: 
[https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=bde0ed1e74ed9645aa0b001464b6a594ee4e362c])
* (edit) src/test/aop/build/aop.xml


> org/aspectj/tools/ant/taskdefs/aspectjTaskdefs.properties path needs to be 
> changed after SQOOP-3051
> ---
>
> Key: SQOOP-3084
> URL: https://issues.apache.org/jira/browse/SQOOP-3084
> Project: Sqoop
>  Issue Type: Bug
>Reporter: Anna Szonyi
>Assignee: Anna Szonyi
> Attachments: SQOOP-3084.patch
>
>
> Due to ivy changes in 3051 the path of 
> org/aspectj/tools/ant/taskdefs/aspectjTaskdefs.properties path needs to be 
> changed, as there is no longer a hadoop$\{hadoopversion\}test, just test



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SQOOP-3083) Fault injection targets no longer work after SQOOP-2983

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/SQOOP-3083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15754210#comment-15754210
 ] 

Hudson commented on SQOOP-3083:
---

SUCCESS: Integrated in Jenkins build Sqoop-hadoop20 #1081 (See 
[https://builds.apache.org/job/Sqoop-hadoop20/1081/])
SQOOP-3083: Fixing fault injection targets to work together with try (maugli: 
[https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=7783f85f805d54f8377a438aebffb06593aec858])
* (edit) ivy/libraries.properties
* (edit) src/test/aop/build/aop.xml


> Fault injection targets no longer work after SQOOP-2983
> ---
>
> Key: SQOOP-3083
> URL: https://issues.apache.org/jira/browse/SQOOP-3083
> Project: Sqoop
>  Issue Type: Bug
>Reporter: Anna Szonyi
>Assignee: Anna Szonyi
> Attachments: SQOOP-3083-2.patch, SQOOP-3083.patch
>
>
> Fault injection target fails due to:
> compile-fault-inject:
>  [echo] Start weaving aspects in place
>  [iajc] OraOopTestCase.java:157 [error] Syntax error on token "(", { 
> expected
>  [iajc] try (Statement stmt = conn.createStatement()) {
>  [iajc] 
>  [iajc] OraOopTestCase.java:157 [error] Syntax error on token ")", ; 
> expected
>  [iajc] try (Statement stmt = conn.createStatement()) {
>  [iajc] 
>  [iajc] OraOopTestCase.java:161 [error] Syntax error, insert "}" to 
> complete Block
>  [iajc] }
>  [iajc] 
>  [iajc] OraOopTestCase.java:161 [error] Syntax error, insert "Finally" to 
> complete TryStatement
>  [iajc] }
>  [iajc] 
>  [iajc] OraOopTypesTest.java:56 [error] Syntax error on token "(", { 
> expected
>  [iajc] try (Statement stmt = conn.createStatement()) {
>  [iajc] 
>  [iajc] OraOopTypesTest.java:56 [error] Syntax error on token ")", ; 
> expected
>  [iajc] try (Statement stmt = conn.createStatement()) {
>  [iajc] 
>  [iajc] OraOopTypesTest.java:78 [error] Syntax error on token "(", { 
> expected
>  [iajc] try (Statement stmt = conn.createStatement()) {
>  [iajc] 
>  [iajc] OraOopTypesTest.java:78 [error] Duplicate local variable stmt
>  [iajc] try (Statement stmt = conn.createStatement()) {
>  [iajc]
>  [iajc] OraOopTypesTest.java:78 [error] Syntax error on token ")", ; 
> expected
>  [iajc] try (Statement stmt = conn.createStatement()) {
>  [iajc] 
>  [iajc] OraOopTypesTest.java:157 [error] Syntax error, insert "}" to 
> complete Block
>  [iajc] }
>  [iajc] 
>  [iajc] OraOopTypesTest.java:157 [error] Syntax error, insert "Finally" 
> to complete TryStatement
>  [iajc] }
>  [iajc] 
>  [iajc] OraOopTypesTest.java:157 [error] Syntax error, insert "}" to 
> complete Block
>  [iajc] }
>  [iajc] 
>  [iajc] OraOopTypesTest.java:157 [error] Syntax error, insert "Finally" 
> to complete BlockStatements
>  [iajc] }
>  [iajc] 
>  [iajc] OracleData.java:240 [error] Syntax error on token "(", { expected
>  [iajc] try (Statement stmt = conn.createStatement()) {
>  [iajc] 
>  [iajc] OracleData.java:240 [error] Syntax error on token ")", ; expected
>  [iajc] try (Statement stmt = conn.createStatement()) {
>  [iajc] 
>  [iajc] OracleData.java:243 [error] Syntax error, insert "}" to complete 
> Block
>  [iajc] }
>  [iajc] 
>  [iajc] OracleData.java:243 [error] Syntax error, insert "Finally" to 
> complete BlockStatements
>  [iajc] }
>  [iajc] 
>  [iajc] 
>  [iajc] 17 errors



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SQOOP-3075) Simplify Unicode character support in source files (introduced by SQOOP-3074) by defining explicit locales instead of using EscapeUtils

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/SQOOP-3075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15754209#comment-15754209
 ] 

Hudson commented on SQOOP-3075:
---

SUCCESS: Integrated in Jenkins build Sqoop-hadoop20 #1081 (See 
[https://builds.apache.org/job/Sqoop-hadoop20/1081/])
SQOOP-3075: Simplify Unicode character support in source files (maugli: 
[https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=be30a344ee28ae60fcce9e9e45a0ec73c93209a7])
* (edit) src/java/org/apache/sqoop/orm/AvroSchemaGenerator.java
* (edit) src/java/org/apache/sqoop/orm/ClassWriter.java
* (edit) src/java/org/apache/sqoop/avro/AvroUtil.java
* (edit) src/java/org/apache/sqoop/orm/CompilationManager.java


> Simplify Unicode character support in source files (introduced by SQOOP-3074) 
> by defining explicit locales instead of using EscapeUtils
> ---
>
> Key: SQOOP-3075
> URL: https://issues.apache.org/jira/browse/SQOOP-3075
> Project: Sqoop
>  Issue Type: Improvement
>Reporter: Attila Szabo
>Assignee: Attila Szabo
> Attachments: SQOOP-3075.patch
>
>
> Although [SQOOP-3074] achieved that Sqoop won't fail anymore with special 
> characters even if the locale on the caller system is not UTF-8, there's a 
> simpler solution to do the same thing, by tuning the compiler + classwriter 
> itself (by adding explicit encodings) instead of using the 
> StringEscapeUtils#escapeJava mechanism.
> This solution seems simpler, and won't introduce any confusion around 
> generation of Java identifiers.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SQOOP-3081) use OracleEscapeUtils.escapeIdentifier OracleUpsertOutputFormat + add compatibility with SQOOP-3066

[Attila Szabo (JIRA)]

[ 
https://issues.apache.org/jira/browse/SQOOP-3081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15754189#comment-15754189
 ] 

Attila Szabo commented on SQOOP-3081:
-

Hey [~szonyi],

Thanks for spotting this! Made a code easier to maintain!

Thanks,
[~maugli]

> use OracleEscapeUtils.escapeIdentifier OracleUpsertOutputFormat + add 
> compatibility with SQOOP-3066
> ---
>
> Key: SQOOP-3081
> URL: https://issues.apache.org/jira/browse/SQOOP-3081
> Project: Sqoop
>  Issue Type: Bug
>Reporter: Anna Szonyi
>Assignee: Anna Szonyi
> Attachments: SQOOP-3081-2.patch, SQOOP-3081-3.patch, SQOOP-3081.patch
>
>
> Introduce OracleEscapeUtils.escapeIdentifiers In OracleUpsertOutputFormat to 
> make it consistent with the rest of the code and compatible with SQOOP-3066.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SQOOP-3081) use OracleEscapeUtils.escapeIdentifier OracleUpsertOutputFormat + add compatibility with SQOOP-3066

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/SQOOP-3081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15754186#comment-15754186
 ] 

ASF subversion and git services commented on SQOOP-3081:


Commit d1e6c5f52f8913a619cfe77c87970d7938c84844 in sqoop's branch 
refs/heads/trunk from [~maugli]
[ https://git-wip-us.apache.org/repos/asf?p=sqoop.git;h=d1e6c5f ]

SQOOP-3081: use OracleEscapeUtils.escapeIdentifier
in OracleUpsertOutputFormat instead of inline
appending quotes

(Anna Szonyi via Attila Szabo)


> use OracleEscapeUtils.escapeIdentifier OracleUpsertOutputFormat + add 
> compatibility with SQOOP-3066
> ---
>
> Key: SQOOP-3081
> URL: https://issues.apache.org/jira/browse/SQOOP-3081
> Project: Sqoop
>  Issue Type: Bug
>Reporter: Anna Szonyi
>Assignee: Anna Szonyi
> Attachments: SQOOP-3081-2.patch, SQOOP-3081-3.patch, SQOOP-3081.patch
>
>
> Introduce OracleEscapeUtils.escapeIdentifiers In OracleUpsertOutputFormat to 
> make it consistent with the rest of the code and compatible with SQOOP-3066.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SQOOP-3075) Simplify Unicode character support in source files (introduced by SQOOP-3074) by defining explicit locales instead of using EscapeUtils

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/SQOOP-3075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15754173#comment-15754173
 ] 

Hudson commented on SQOOP-3075:
---

SUCCESS: Integrated in Jenkins build Sqoop-hadoop200 #1087 (See 
[https://builds.apache.org/job/Sqoop-hadoop200/1087/])
SQOOP-3075: Simplify Unicode character support in source files (maugli: 
[https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=be30a344ee28ae60fcce9e9e45a0ec73c93209a7])
* (edit) src/java/org/apache/sqoop/orm/ClassWriter.java
* (edit) src/java/org/apache/sqoop/orm/CompilationManager.java
* (edit) src/java/org/apache/sqoop/avro/AvroUtil.java
* (edit) src/java/org/apache/sqoop/orm/AvroSchemaGenerator.java


> Simplify Unicode character support in source files (introduced by SQOOP-3074) 
> by defining explicit locales instead of using EscapeUtils
> ---
>
> Key: SQOOP-3075
> URL: https://issues.apache.org/jira/browse/SQOOP-3075
> Project: Sqoop
>  Issue Type: Improvement
>Reporter: Attila Szabo
>Assignee: Attila Szabo
> Attachments: SQOOP-3075.patch
>
>
> Although [SQOOP-3074] achieved that Sqoop won't fail anymore with special 
> characters even if the locale on the caller system is not UTF-8, there's a 
> simpler solution to do the same thing, by tuning the compiler + classwriter 
> itself (by adding explicit encodings) instead of using the 
> StringEscapeUtils#escapeJava mechanism.
> This solution seems simpler, and won't introduce any confusion around 
> generation of Java identifiers.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SQOOP-3083) Fault injection targets no longer work after SQOOP-2983

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/SQOOP-3083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15754174#comment-15754174
 ] 

Hudson commented on SQOOP-3083:
---

SUCCESS: Integrated in Jenkins build Sqoop-hadoop200 #1087 (See 
[https://builds.apache.org/job/Sqoop-hadoop200/1087/])
SQOOP-3083: Fixing fault injection targets to work together with try (maugli: 
[https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=7783f85f805d54f8377a438aebffb06593aec858])
* (edit) src/test/aop/build/aop.xml
* (edit) ivy/libraries.properties


> Fault injection targets no longer work after SQOOP-2983
> ---
>
> Key: SQOOP-3083
> URL: https://issues.apache.org/jira/browse/SQOOP-3083
> Project: Sqoop
>  Issue Type: Bug
>Reporter: Anna Szonyi
>Assignee: Anna Szonyi
> Attachments: SQOOP-3083-2.patch, SQOOP-3083.patch
>
>
> Fault injection target fails due to:
> compile-fault-inject:
>  [echo] Start weaving aspects in place
>  [iajc] OraOopTestCase.java:157 [error] Syntax error on token "(", { 
> expected
>  [iajc] try (Statement stmt = conn.createStatement()) {
>  [iajc] 
>  [iajc] OraOopTestCase.java:157 [error] Syntax error on token ")", ; 
> expected
>  [iajc] try (Statement stmt = conn.createStatement()) {
>  [iajc] 
>  [iajc] OraOopTestCase.java:161 [error] Syntax error, insert "}" to 
> complete Block
>  [iajc] }
>  [iajc] 
>  [iajc] OraOopTestCase.java:161 [error] Syntax error, insert "Finally" to 
> complete TryStatement
>  [iajc] }
>  [iajc] 
>  [iajc] OraOopTypesTest.java:56 [error] Syntax error on token "(", { 
> expected
>  [iajc] try (Statement stmt = conn.createStatement()) {
>  [iajc] 
>  [iajc] OraOopTypesTest.java:56 [error] Syntax error on token ")", ; 
> expected
>  [iajc] try (Statement stmt = conn.createStatement()) {
>  [iajc] 
>  [iajc] OraOopTypesTest.java:78 [error] Syntax error on token "(", { 
> expected
>  [iajc] try (Statement stmt = conn.createStatement()) {
>  [iajc] 
>  [iajc] OraOopTypesTest.java:78 [error] Duplicate local variable stmt
>  [iajc] try (Statement stmt = conn.createStatement()) {
>  [iajc]
>  [iajc] OraOopTypesTest.java:78 [error] Syntax error on token ")", ; 
> expected
>  [iajc] try (Statement stmt = conn.createStatement()) {
>  [iajc] 
>  [iajc] OraOopTypesTest.java:157 [error] Syntax error, insert "}" to 
> complete Block
>  [iajc] }
>  [iajc] 
>  [iajc] OraOopTypesTest.java:157 [error] Syntax error, insert "Finally" 
> to complete TryStatement
>  [iajc] }
>  [iajc] 
>  [iajc] OraOopTypesTest.java:157 [error] Syntax error, insert "}" to 
> complete Block
>  [iajc] }
>  [iajc] 
>  [iajc] OraOopTypesTest.java:157 [error] Syntax error, insert "Finally" 
> to complete BlockStatements
>  [iajc] }
>  [iajc] 
>  [iajc] OracleData.java:240 [error] Syntax error on token "(", { expected
>  [iajc] try (Statement stmt = conn.createStatement()) {
>  [iajc] 
>  [iajc] OracleData.java:240 [error] Syntax error on token ")", ; expected
>  [iajc] try (Statement stmt = conn.createStatement()) {
>  [iajc] 
>  [iajc] OracleData.java:243 [error] Syntax error, insert "}" to complete 
> Block
>  [iajc] }
>  [iajc] 
>  [iajc] OracleData.java:243 [error] Syntax error, insert "Finally" to 
> complete BlockStatements
>  [iajc] }
>  [iajc] 
>  [iajc] 
>  [iajc] 17 errors



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SQOOP-3084) org/aspectj/tools/ant/taskdefs/aspectjTaskdefs.properties path needs to be changed after SQOOP-3051

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/SQOOP-3084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15754172#comment-15754172
 ] 

Hudson commented on SQOOP-3084:
---

SUCCESS: Integrated in Jenkins build Sqoop-hadoop200 #1087 (See 
[https://builds.apache.org/job/Sqoop-hadoop200/1087/])
SQOOP-3084: Fix fault injection classpath elements in aop.xml (required 
(maugli: 
[https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=bde0ed1e74ed9645aa0b001464b6a594ee4e362c])
* (edit) src/test/aop/build/aop.xml


> org/aspectj/tools/ant/taskdefs/aspectjTaskdefs.properties path needs to be 
> changed after SQOOP-3051
> ---
>
> Key: SQOOP-3084
> URL: https://issues.apache.org/jira/browse/SQOOP-3084
> Project: Sqoop
>  Issue Type: Bug
>Reporter: Anna Szonyi
>Assignee: Anna Szonyi
> Attachments: SQOOP-3084.patch
>
>
> Due to ivy changes in 3051 the path of 
> org/aspectj/tools/ant/taskdefs/aspectjTaskdefs.properties path needs to be 
> changed, as there is no longer a hadoop$\{hadoopversion\}test, just test



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 54699: SQOOP-3081 use OracleEscapeUtils.escapeIdentifier in OracleUpsertOutputFormat

[Anna Szonyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54699/
---

(Updated Dec. 16, 2016, 11:24 a.m.)


Review request for Sqoop, Attila Szabo and Szabolcs Vasas.


Changes
---

changed append based on review


Bugs: SQOOP-3081
https://issues.apache.org/jira/browse/SQOOP-3081


Repository: sqoop-trunk


Description
---

SQOOP-3081 Introduce OracleEscapeUtils.escapeIdentifiers In 
OracleUpsertOutputFormat to make it consistent with the rest of the code and 
add escaping to the rest of the column variables.


Diffs (updated)
-

  src/java/org/apache/sqoop/mapreduce/OracleUpsertOutputFormat.java 88754e7 
  src/test/com/cloudera/sqoop/manager/OracleExportTest.java 382eb92 

Diff: https://reviews.apache.org/r/54699/diff/


Testing
---

ran ant clean test, ant clean test -Dsqoop.thirdparty.lib.dir=$3rdpartylib 
-Dthirdparty=true 
-Dsqoop.test.oracle.connectstring=$connstr-Dmapred.child.java.opts="-Djava.security.egd=file:/dev/../dev/urandom"
 -Dtest.timeout=100 -Dtestcase=*racle*Test with special attention to 
OracleExportTest#testUpsertTextExport


Thanks,

Anna Szonyi

[jira] [Commented] (SQOOP-3075) Simplify Unicode character support in source files (introduced by SQOOP-3074) by defining explicit locales instead of using EscapeUtils

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/SQOOP-3075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15754146#comment-15754146
 ] 

Hudson commented on SQOOP-3075:
---

SUCCESS: Integrated in Jenkins build Sqoop-hadoop100 #1046 (See 
[https://builds.apache.org/job/Sqoop-hadoop100/1046/])
SQOOP-3075: Simplify Unicode character support in source files (maugli: 
[https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=be30a344ee28ae60fcce9e9e45a0ec73c93209a7])
* (edit) src/java/org/apache/sqoop/avro/AvroUtil.java
* (edit) src/java/org/apache/sqoop/orm/ClassWriter.java
* (edit) src/java/org/apache/sqoop/orm/CompilationManager.java
* (edit) src/java/org/apache/sqoop/orm/AvroSchemaGenerator.java


> Simplify Unicode character support in source files (introduced by SQOOP-3074) 
> by defining explicit locales instead of using EscapeUtils
> ---
>
> Key: SQOOP-3075
> URL: https://issues.apache.org/jira/browse/SQOOP-3075
> Project: Sqoop
>  Issue Type: Improvement
>Reporter: Attila Szabo
>Assignee: Attila Szabo
> Attachments: SQOOP-3075.patch
>
>
> Although [SQOOP-3074] achieved that Sqoop won't fail anymore with special 
> characters even if the locale on the caller system is not UTF-8, there's a 
> simpler solution to do the same thing, by tuning the compiler + classwriter 
> itself (by adding explicit encodings) instead of using the 
> StringEscapeUtils#escapeJava mechanism.
> This solution seems simpler, and won't introduce any confusion around 
> generation of Java identifiers.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SQOOP-3083) Fault injection targets no longer work after SQOOP-2983

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/SQOOP-3083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15754147#comment-15754147
 ] 

Hudson commented on SQOOP-3083:
---

SUCCESS: Integrated in Jenkins build Sqoop-hadoop100 #1046 (See 
[https://builds.apache.org/job/Sqoop-hadoop100/1046/])
SQOOP-3083: Fixing fault injection targets to work together with try (maugli: 
[https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=7783f85f805d54f8377a438aebffb06593aec858])
* (edit) ivy/libraries.properties
* (edit) src/test/aop/build/aop.xml


> Fault injection targets no longer work after SQOOP-2983
> ---
>
> Key: SQOOP-3083
> URL: https://issues.apache.org/jira/browse/SQOOP-3083
> Project: Sqoop
>  Issue Type: Bug
>Reporter: Anna Szonyi
>Assignee: Anna Szonyi
> Attachments: SQOOP-3083-2.patch, SQOOP-3083.patch
>
>
> Fault injection target fails due to:
> compile-fault-inject:
>  [echo] Start weaving aspects in place
>  [iajc] OraOopTestCase.java:157 [error] Syntax error on token "(", { 
> expected
>  [iajc] try (Statement stmt = conn.createStatement()) {
>  [iajc] 
>  [iajc] OraOopTestCase.java:157 [error] Syntax error on token ")", ; 
> expected
>  [iajc] try (Statement stmt = conn.createStatement()) {
>  [iajc] 
>  [iajc] OraOopTestCase.java:161 [error] Syntax error, insert "}" to 
> complete Block
>  [iajc] }
>  [iajc] 
>  [iajc] OraOopTestCase.java:161 [error] Syntax error, insert "Finally" to 
> complete TryStatement
>  [iajc] }
>  [iajc] 
>  [iajc] OraOopTypesTest.java:56 [error] Syntax error on token "(", { 
> expected
>  [iajc] try (Statement stmt = conn.createStatement()) {
>  [iajc] 
>  [iajc] OraOopTypesTest.java:56 [error] Syntax error on token ")", ; 
> expected
>  [iajc] try (Statement stmt = conn.createStatement()) {
>  [iajc] 
>  [iajc] OraOopTypesTest.java:78 [error] Syntax error on token "(", { 
> expected
>  [iajc] try (Statement stmt = conn.createStatement()) {
>  [iajc] 
>  [iajc] OraOopTypesTest.java:78 [error] Duplicate local variable stmt
>  [iajc] try (Statement stmt = conn.createStatement()) {
>  [iajc]
>  [iajc] OraOopTypesTest.java:78 [error] Syntax error on token ")", ; 
> expected
>  [iajc] try (Statement stmt = conn.createStatement()) {
>  [iajc] 
>  [iajc] OraOopTypesTest.java:157 [error] Syntax error, insert "}" to 
> complete Block
>  [iajc] }
>  [iajc] 
>  [iajc] OraOopTypesTest.java:157 [error] Syntax error, insert "Finally" 
> to complete TryStatement
>  [iajc] }
>  [iajc] 
>  [iajc] OraOopTypesTest.java:157 [error] Syntax error, insert "}" to 
> complete Block
>  [iajc] }
>  [iajc] 
>  [iajc] OraOopTypesTest.java:157 [error] Syntax error, insert "Finally" 
> to complete BlockStatements
>  [iajc] }
>  [iajc] 
>  [iajc] OracleData.java:240 [error] Syntax error on token "(", { expected
>  [iajc] try (Statement stmt = conn.createStatement()) {
>  [iajc] 
>  [iajc] OracleData.java:240 [error] Syntax error on token ")", ; expected
>  [iajc] try (Statement stmt = conn.createStatement()) {
>  [iajc] 
>  [iajc] OracleData.java:243 [error] Syntax error, insert "}" to complete 
> Block
>  [iajc] }
>  [iajc] 
>  [iajc] OracleData.java:243 [error] Syntax error, insert "Finally" to 
> complete BlockStatements
>  [iajc] }
>  [iajc] 
>  [iajc] 
>  [iajc] 17 errors



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SQOOP-3084) org/aspectj/tools/ant/taskdefs/aspectjTaskdefs.properties path needs to be changed after SQOOP-3051

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/SQOOP-3084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15754136#comment-15754136
 ] 

ASF subversion and git services commented on SQOOP-3084:


Commit bde0ed1e74ed9645aa0b001464b6a594ee4e362c in sqoop's branch 
refs/heads/trunk from [~maugli]
[ https://git-wip-us.apache.org/repos/asf?p=sqoop.git;h=bde0ed1 ]

SQOOP-3084: Fix fault injection classpath elements
in aop.xml (required by the changes of SQOOP-3051)

(Anna Szonyi via Attila Szabo)


> org/aspectj/tools/ant/taskdefs/aspectjTaskdefs.properties path needs to be 
> changed after SQOOP-3051
> ---
>
> Key: SQOOP-3084
> URL: https://issues.apache.org/jira/browse/SQOOP-3084
> Project: Sqoop
>  Issue Type: Bug
>Reporter: Anna Szonyi
>Assignee: Anna Szonyi
> Attachments: SQOOP-3084.patch
>
>
> Due to ivy changes in 3051 the path of 
> org/aspectj/tools/ant/taskdefs/aspectjTaskdefs.properties path needs to be 
> changed, as there is no longer a hadoop$\{hadoopversion\}test, just test



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SQOOP-3051) Remove/delete obsolete profiles from build.xml

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/SQOOP-3051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15754137#comment-15754137
 ] 

ASF subversion and git services commented on SQOOP-3051:


Commit bde0ed1e74ed9645aa0b001464b6a594ee4e362c in sqoop's branch 
refs/heads/trunk from [~maugli]
[ https://git-wip-us.apache.org/repos/asf?p=sqoop.git;h=bde0ed1 ]

SQOOP-3084: Fix fault injection classpath elements
in aop.xml (required by the changes of SQOOP-3051)

(Anna Szonyi via Attila Szabo)


> Remove/delete obsolete profiles from build.xml
> --
>
> Key: SQOOP-3051
> URL: https://issues.apache.org/jira/browse/SQOOP-3051
> Project: Sqoop
>  Issue Type: Improvement
>Reporter: Attila Szabo
>Assignee: Anna Szonyi
>Priority: Critical
> Fix For: 1.4.7
>
> Attachments: SQOOP-3051-1.patch, SQOOP-3051.patch
>
>
> As [SQOOP-3050] is implemented all the obsolete profiles/settings should be 
> eliminated to make the dependency tree and the whole build environment around 
> Sqoop trunk version simpler.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 54745: SQOOP-3084 bug fix in aop.xml, org/aspectj/tools/ant/taskdefs/aspectjTaskdefs.properties path needs to be changed after SQOOP-3051

[Attila Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54745/#review159430
---


Ship it!




Hi Anna,

Thanks for cleaning this up too!

Attila

- Attila Szabo


On Dec. 14, 2016, 2 p.m., Anna Szonyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54745/
> ---
> 
> (Updated Dec. 14, 2016, 2 p.m.)
> 
> 
> Review request for Sqoop, Boglarka Egyed, Attila Szabo, Szabolcs Vasas, and 
> Erzsebet Szilagyi.
> 
> 
> Bugs: SQOOP-3084
> https://issues.apache.org/jira/browse/SQOOP-3084
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> SQOOP-3084 Due to ivy changes in 3051 the path of 
> org/aspectj/tools/ant/taskdefs/aspectjTaskdefs.properties path needs to be 
> changed, as there is no longer a hadoop${hadoopversion}test, just test
> There is another jira to fix the issue with the fault injection targets no 
> longer working after SQOOP-2983
> 
> 
> Diffs
> -
> 
>   src/test/aop/build/aop.xml 77320aa 
> 
> Diff: https://reviews.apache.org/r/54745/diff/
> 
> 
> Testing
> ---
> 
> ant compile, ant test, ant jar-fault-inject
> 
> 
> Thanks,
> 
> Anna Szonyi
> 
>

[jira] [Commented] (SQOOP-3083) Fault injection targets no longer work after SQOOP-2983

[Attila Szabo (JIRA)]

[ 
https://issues.apache.org/jira/browse/SQOOP-3083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15754123#comment-15754123
 ] 

Attila Szabo commented on SQOOP-3083:
-

Hi [~szonyi],

Thanks for spotting this, and for your contribution!

[~maugli]

> Fault injection targets no longer work after SQOOP-2983
> ---
>
> Key: SQOOP-3083
> URL: https://issues.apache.org/jira/browse/SQOOP-3083
> Project: Sqoop
>  Issue Type: Bug
>Reporter: Anna Szonyi
>Assignee: Anna Szonyi
> Attachments: SQOOP-3083-2.patch, SQOOP-3083.patch
>
>
> Fault injection target fails due to:
> compile-fault-inject:
>  [echo] Start weaving aspects in place
>  [iajc] OraOopTestCase.java:157 [error] Syntax error on token "(", { 
> expected
>  [iajc] try (Statement stmt = conn.createStatement()) {
>  [iajc] 
>  [iajc] OraOopTestCase.java:157 [error] Syntax error on token ")", ; 
> expected
>  [iajc] try (Statement stmt = conn.createStatement()) {
>  [iajc] 
>  [iajc] OraOopTestCase.java:161 [error] Syntax error, insert "}" to 
> complete Block
>  [iajc] }
>  [iajc] 
>  [iajc] OraOopTestCase.java:161 [error] Syntax error, insert "Finally" to 
> complete TryStatement
>  [iajc] }
>  [iajc] 
>  [iajc] OraOopTypesTest.java:56 [error] Syntax error on token "(", { 
> expected
>  [iajc] try (Statement stmt = conn.createStatement()) {
>  [iajc] 
>  [iajc] OraOopTypesTest.java:56 [error] Syntax error on token ")", ; 
> expected
>  [iajc] try (Statement stmt = conn.createStatement()) {
>  [iajc] 
>  [iajc] OraOopTypesTest.java:78 [error] Syntax error on token "(", { 
> expected
>  [iajc] try (Statement stmt = conn.createStatement()) {
>  [iajc] 
>  [iajc] OraOopTypesTest.java:78 [error] Duplicate local variable stmt
>  [iajc] try (Statement stmt = conn.createStatement()) {
>  [iajc]
>  [iajc] OraOopTypesTest.java:78 [error] Syntax error on token ")", ; 
> expected
>  [iajc] try (Statement stmt = conn.createStatement()) {
>  [iajc] 
>  [iajc] OraOopTypesTest.java:157 [error] Syntax error, insert "}" to 
> complete Block
>  [iajc] }
>  [iajc] 
>  [iajc] OraOopTypesTest.java:157 [error] Syntax error, insert "Finally" 
> to complete TryStatement
>  [iajc] }
>  [iajc] 
>  [iajc] OraOopTypesTest.java:157 [error] Syntax error, insert "}" to 
> complete Block
>  [iajc] }
>  [iajc] 
>  [iajc] OraOopTypesTest.java:157 [error] Syntax error, insert "Finally" 
> to complete BlockStatements
>  [iajc] }
>  [iajc] 
>  [iajc] OracleData.java:240 [error] Syntax error on token "(", { expected
>  [iajc] try (Statement stmt = conn.createStatement()) {
>  [iajc] 
>  [iajc] OracleData.java:240 [error] Syntax error on token ")", ; expected
>  [iajc] try (Statement stmt = conn.createStatement()) {
>  [iajc] 
>  [iajc] OracleData.java:243 [error] Syntax error, insert "}" to complete 
> Block
>  [iajc] }
>  [iajc] 
>  [iajc] OracleData.java:243 [error] Syntax error, insert "Finally" to 
> complete BlockStatements
>  [iajc] }
>  [iajc] 
>  [iajc] 
>  [iajc] 17 errors



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SQOOP-3083) Fault injection targets no longer work after SQOOP-2983

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/SQOOP-3083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15754121#comment-15754121
 ] 

ASF subversion and git services commented on SQOOP-3083:


Commit 7783f85f805d54f8377a438aebffb06593aec858 in sqoop's branch 
refs/heads/trunk from [~maugli]
[ https://git-wip-us.apache.org/repos/asf?p=sqoop.git;h=7783f85 ]

SQOOP-3083: Fixing fault injection targets to work
together with try with resources statements
(introduced in SQOOP-2983)

(Anna Szonyi via Attila Szabo)


> Fault injection targets no longer work after SQOOP-2983
> ---
>
> Key: SQOOP-3083
> URL: https://issues.apache.org/jira/browse/SQOOP-3083
> Project: Sqoop
>  Issue Type: Bug
>Reporter: Anna Szonyi
>Assignee: Anna Szonyi
> Attachments: SQOOP-3083-2.patch, SQOOP-3083.patch
>
>
> Fault injection target fails due to:
> compile-fault-inject:
>  [echo] Start weaving aspects in place
>  [iajc] OraOopTestCase.java:157 [error] Syntax error on token "(", { 
> expected
>  [iajc] try (Statement stmt = conn.createStatement()) {
>  [iajc] 
>  [iajc] OraOopTestCase.java:157 [error] Syntax error on token ")", ; 
> expected
>  [iajc] try (Statement stmt = conn.createStatement()) {
>  [iajc] 
>  [iajc] OraOopTestCase.java:161 [error] Syntax error, insert "}" to 
> complete Block
>  [iajc] }
>  [iajc] 
>  [iajc] OraOopTestCase.java:161 [error] Syntax error, insert "Finally" to 
> complete TryStatement
>  [iajc] }
>  [iajc] 
>  [iajc] OraOopTypesTest.java:56 [error] Syntax error on token "(", { 
> expected
>  [iajc] try (Statement stmt = conn.createStatement()) {
>  [iajc] 
>  [iajc] OraOopTypesTest.java:56 [error] Syntax error on token ")", ; 
> expected
>  [iajc] try (Statement stmt = conn.createStatement()) {
>  [iajc] 
>  [iajc] OraOopTypesTest.java:78 [error] Syntax error on token "(", { 
> expected
>  [iajc] try (Statement stmt = conn.createStatement()) {
>  [iajc] 
>  [iajc] OraOopTypesTest.java:78 [error] Duplicate local variable stmt
>  [iajc] try (Statement stmt = conn.createStatement()) {
>  [iajc]
>  [iajc] OraOopTypesTest.java:78 [error] Syntax error on token ")", ; 
> expected
>  [iajc] try (Statement stmt = conn.createStatement()) {
>  [iajc] 
>  [iajc] OraOopTypesTest.java:157 [error] Syntax error, insert "}" to 
> complete Block
>  [iajc] }
>  [iajc] 
>  [iajc] OraOopTypesTest.java:157 [error] Syntax error, insert "Finally" 
> to complete TryStatement
>  [iajc] }
>  [iajc] 
>  [iajc] OraOopTypesTest.java:157 [error] Syntax error, insert "}" to 
> complete Block
>  [iajc] }
>  [iajc] 
>  [iajc] OraOopTypesTest.java:157 [error] Syntax error, insert "Finally" 
> to complete BlockStatements
>  [iajc] }
>  [iajc] 
>  [iajc] OracleData.java:240 [error] Syntax error on token "(", { expected
>  [iajc] try (Statement stmt = conn.createStatement()) {
>  [iajc] 
>  [iajc] OracleData.java:240 [error] Syntax error on token ")", ; expected
>  [iajc] try (Statement stmt = conn.createStatement()) {
>  [iajc] 
>  [iajc] OracleData.java:243 [error] Syntax error, insert "}" to complete 
> Block
>  [iajc] }
>  [iajc] 
>  [iajc] OracleData.java:243 [error] Syntax error, insert "Finally" to 
> complete BlockStatements
>  [iajc] }
>  [iajc] 
>  [iajc] 
>  [iajc] 17 errors



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SQOOP-2983) OraOop export has degraded performance with wide tables

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/SQOOP-2983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15754122#comment-15754122
 ] 

ASF subversion and git services commented on SQOOP-2983:


Commit 7783f85f805d54f8377a438aebffb06593aec858 in sqoop's branch 
refs/heads/trunk from [~maugli]
[ https://git-wip-us.apache.org/repos/asf?p=sqoop.git;h=7783f85 ]

SQOOP-3083: Fixing fault injection targets to work
together with try with resources statements
(introduced in SQOOP-2983)

(Anna Szonyi via Attila Szabo)


> OraOop export has degraded performance with wide tables
> ---
>
> Key: SQOOP-2983
> URL: https://issues.apache.org/jira/browse/SQOOP-2983
> Project: Sqoop
>  Issue Type: Bug
>Reporter: Attila Szabo
>Assignee: Attila Szabo
>Priority: Critical
> Fix For: 1.4.7
>
> Attachments: SQOOP-2983-5.patch, SQOOP-2983-6.patch, 
> SQOOP-2983-7.patch
>
>
> The current version of OraOOP seems to perform very low from performance POV 
> when --direct mode turned on (regardless if the partitioned feature is turned 
> of).
> Just as a baseline from the current trunk version:
> Inserting 100.000 rows into a 800 column wide Oracle table has 400-600 kb/sec 
> with direct mode on my cluster, while the standard oracle driver can produce 
> up to 1.2-1.8 mb/sec. (depending on the number of mappers, batch size).
> Inserting 1.000.000 rows into the same table goes up to 800k-1mb/sec with 
> OraOOP, however with the standard Oracle connector it's around 3.5mb/sec.
> It seems OraOOP export needs a thorough review and some fixing.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 54746: SQOOP-3083 Fault injection targets no longer work after SQOOP-2983 due to introducing try with resource

[Attila Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54746/#review159428
---


Ship it!




Hey Anna,

Thanks for spotting+patching this!

Cheers,
Attila

- Attila Szabo


On Dec. 15, 2016, 7:37 p.m., Anna Szonyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54746/
> ---
> 
> (Updated Dec. 15, 2016, 7:37 p.m.)
> 
> 
> Review request for Sqoop, Boglarka Egyed, Attila Szabo, Szabolcs Vasas, and 
> Erzsebet Szilagyi.
> 
> 
> Bugs: SQOOP-3083
> https://issues.apache.org/jira/browse/SQOOP-3083
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> SQOOP-3083 Fault injection targets no longer work after SQOOP-2983 due to 
> introducing try with resource
> 
> 
> Diffs
> -
> 
>   ivy/libraries.properties e2c2516 
>   src/test/aop/build/aop.xml 77320aa 
> 
> Diff: https://reviews.apache.org/r/54746/diff/
> 
> 
> Testing
> ---
> 
> ant compile, ant test, ant jar-fault-inject
> 
> 
> Thanks,
> 
> Anna Szonyi
> 
>

Re: Review Request 54699: SQOOP-3081 use OracleEscapeUtils.escapeIdentifier in OracleUpsertOutputFormat

[Attila Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54699/#review159427
---


Fix it, then Ship it!




Hi Anna,

Thanks for spotting this problem!
The changes looks good except a slight change in OracleUpsertRecordWriter (I've 
highlighted it in the source).

Otherwise +1.

Thanks,
Attila


src/java/org/apache/sqoop/mapreduce/OracleUpsertOutputFormat.java (line 90)


Hi Anna,

Could please move the two append command into two different lines?

Thanks,
Attila


- Attila Szabo


On Dec. 14, 2016, 11:50 a.m., Anna Szonyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54699/
> ---
> 
> (Updated Dec. 14, 2016, 11:50 a.m.)
> 
> 
> Review request for Sqoop, Attila Szabo and Szabolcs Vasas.
> 
> 
> Bugs: SQOOP-3081
> https://issues.apache.org/jira/browse/SQOOP-3081
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> SQOOP-3081 Introduce OracleEscapeUtils.escapeIdentifiers In 
> OracleUpsertOutputFormat to make it consistent with the rest of the code and 
> add escaping to the rest of the column variables.
> 
> 
> Diffs
> -
> 
>   src/java/org/apache/sqoop/mapreduce/OracleUpsertOutputFormat.java 88754e7 
>   src/test/com/cloudera/sqoop/manager/OracleExportTest.java 382eb92 
> 
> Diff: https://reviews.apache.org/r/54699/diff/
> 
> 
> Testing
> ---
> 
> ran ant clean test, ant clean test -Dsqoop.thirdparty.lib.dir=$3rdpartylib 
> -Dthirdparty=true 
> -Dsqoop.test.oracle.connectstring=$connstr-Dmapred.child.java.opts="-Djava.security.egd=file:/dev/../dev/urandom"
>  -Dtest.timeout=100 -Dtestcase=*racle*Test with special attention to 
> OracleExportTest#testUpsertTextExport
> 
> 
> Thanks,
> 
> Anna Szonyi
> 
>

[jira] [Commented] (SQOOP-3075) Simplify Unicode character support in source files (introduced by SQOOP-3074) by defining explicit locales instead of using EscapeUtils

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/SQOOP-3075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15754095#comment-15754095
 ] 

ASF subversion and git services commented on SQOOP-3075:


Commit be30a344ee28ae60fcce9e9e45a0ec73c93209a7 in sqoop's branch 
refs/heads/trunk from [~maugli]
[ https://git-wip-us.apache.org/repos/asf?p=sqoop.git;h=be30a34 ]

SQOOP-3075: Simplify Unicode character support in
source files (introduced by SQOOP-3074) by
defining explicit locales instead of using
EscapeUtils

(Attila Szabo)


> Simplify Unicode character support in source files (introduced by SQOOP-3074) 
> by defining explicit locales instead of using EscapeUtils
> ---
>
> Key: SQOOP-3075
> URL: https://issues.apache.org/jira/browse/SQOOP-3075
> Project: Sqoop
>  Issue Type: Improvement
>Reporter: Attila Szabo
>Assignee: Attila Szabo
> Attachments: SQOOP-3075.patch
>
>
> Although [SQOOP-3074] achieved that Sqoop won't fail anymore with special 
> characters even if the locale on the caller system is not UTF-8, there's a 
> simpler solution to do the same thing, by tuning the compiler + classwriter 
> itself (by adding explicit encodings) instead of using the 
> StringEscapeUtils#escapeJava mechanism.
> This solution seems simpler, and won't introduce any confusion around 
> generation of Java identifiers.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SQOOP-3074) Fix Avro import not to fail with Javac errors in case of non UTF-8 locale

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/SQOOP-3074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15754096#comment-15754096
 ] 

ASF subversion and git services commented on SQOOP-3074:


Commit be30a344ee28ae60fcce9e9e45a0ec73c93209a7 in sqoop's branch 
refs/heads/trunk from [~maugli]
[ https://git-wip-us.apache.org/repos/asf?p=sqoop.git;h=be30a34 ]

SQOOP-3075: Simplify Unicode character support in
source files (introduced by SQOOP-3074) by
defining explicit locales instead of using
EscapeUtils

(Attila Szabo)


> Fix Avro import not to fail with Javac errors in case of non UTF-8 locale
> -
>
> Key: SQOOP-3074
> URL: https://issues.apache.org/jira/browse/SQOOP-3074
> Project: Sqoop
>  Issue Type: Bug
>Reporter: Attila Szabo
>Assignee: Attila Szabo
> Attachments: SQOOP-3074.patch
>
>
> The current implementation of Sqoop will fail to compile the ClassWriter 
> generated Java class in case of UTF-8 characters are available in the 
> database  but the running host don't have UTF-8 or not supporting that. 
> Meanwhile we'd like to keep up the support of UTF-8 characters for example in 
> Avro schemas.
> A good example for that TestAvroImport#testNonstandardCharactersInColumnName 
> fails if executed form a shell/env with non UTF-8 locale.
> We have to provide an implementation reflects this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 54575: SQOOP-3075: Simplify Unicode character support in source files (introduced by SQOOP-3074) by defining explicit locales instead of using EscapeUtils

[Anna Szonyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54575/#review159426
---


Ship it!




Ship It!

- Anna Szonyi


On Dec. 16, 2016, 10:46 a.m., Attila Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54575/
> ---
> 
> (Updated Dec. 16, 2016, 10:46 a.m.)
> 
> 
> Review request for Sqoop and Anna Szonyi.
> 
> 
> Bugs: SQOOP-3075
> https://issues.apache.org/jira/browse/SQOOP-3075
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> Although SQOOP-3074 achieved that Sqoop won't fail anymore with special 
> characters even if the locale on the caller system is not UTF-8, there's a 
> simpler solution to do the same thing, by tuning the compiler + classwriter 
> itself (by adding explicit encodings) instead of using the 
> StringEscapeUtils#escapeJava mechanism.
> This solution seems simpler, and won't introduce any confusion around 
> generation of Java identifiers.
> 
> 
> Diffs
> -
> 
>   src/java/org/apache/sqoop/avro/AvroUtil.java 8d901302 
>   src/java/org/apache/sqoop/orm/AvroSchemaGenerator.java 5b1c7457 
>   src/java/org/apache/sqoop/orm/ClassWriter.java 0c8d86d0 
>   src/java/org/apache/sqoop/orm/CompilationManager.java 0a2a87f2 
> 
> Diff: https://reviews.apache.org/r/54575/diff/
> 
> 
> Testing
> ---
> 
> ant clean test
> 
> ant clean test -Dthirdparty=true -Dsqoop.thirdparty.lib.dir=/root 
> -Dsqoop.test.mysql.connectstring.host_url=jdbc:mysql://mysqlhostname/ 
> -Dsqoop.test.mysql.databasename=sqoop_repo -Dsqoop.test.mysql.password=sqoop 
> -Dsqoop.test.mysql.username=sqoop 
> -Dsqoop.test.oracle.connectstring=jdbc:oracle:thin:@//oraclehostname/orcl 
> -Dsqoop.test.postgresql.connectstring.host_url=jdbc:postgresql://postgreshostname/
>  -Dsqoop.test.cubrid.connectstring.host_url=jdbc:cubrid:cubridhotname:33000 
> -Dsqoop.test.cubrid.connectstring.username=sqoop 
> -Dsqoop.test.cubrid.connectstring.database=sqoop 
> -Dsqoop.test.cubrid.connectstring.password=sqoop 
> -Dmapred.child.java.opts="-Djava.security.egd=file:/dev/../dev/urandom" 
> -Dtest.timeout=100
> 
> 
> Thanks,
> 
> Attila Szabo
> 
>

Re: Review Request 54575: SQOOP-3075: Simplify Unicode character support in source files (introduced by SQOOP-3074) by defining explicit locales instead of using EscapeUtils

[Attila Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54575/
---

(Updated Dec. 16, 2016, 10:46 a.m.)


Review request for Sqoop and Anna Szonyi.


Changes
---

"Magic strings" has been changed to appropriate constants


Bugs: SQOOP-3075
https://issues.apache.org/jira/browse/SQOOP-3075


Repository: sqoop-trunk


Description
---

Although SQOOP-3074 achieved that Sqoop won't fail anymore with special 
characters even if the locale on the caller system is not UTF-8, there's a 
simpler solution to do the same thing, by tuning the compiler + classwriter 
itself (by adding explicit encodings) instead of using the 
StringEscapeUtils#escapeJava mechanism.
This solution seems simpler, and won't introduce any confusion around 
generation of Java identifiers.


Diffs (updated)
-

  src/java/org/apache/sqoop/avro/AvroUtil.java 8d901302 
  src/java/org/apache/sqoop/orm/AvroSchemaGenerator.java 5b1c7457 
  src/java/org/apache/sqoop/orm/ClassWriter.java 0c8d86d0 
  src/java/org/apache/sqoop/orm/CompilationManager.java 0a2a87f2 

Diff: https://reviews.apache.org/r/54575/diff/


Testing
---

ant clean test

ant clean test -Dthirdparty=true -Dsqoop.thirdparty.lib.dir=/root 
-Dsqoop.test.mysql.connectstring.host_url=jdbc:mysql://mysqlhostname/ 
-Dsqoop.test.mysql.databasename=sqoop_repo -Dsqoop.test.mysql.password=sqoop 
-Dsqoop.test.mysql.username=sqoop 
-Dsqoop.test.oracle.connectstring=jdbc:oracle:thin:@//oraclehostname/orcl 
-Dsqoop.test.postgresql.connectstring.host_url=jdbc:postgresql://postgreshostname/
 -Dsqoop.test.cubrid.connectstring.host_url=jdbc:cubrid:cubridhotname:33000 
-Dsqoop.test.cubrid.connectstring.username=sqoop 
-Dsqoop.test.cubrid.connectstring.database=sqoop 
-Dsqoop.test.cubrid.connectstring.password=sqoop 
-Dmapred.child.java.opts="-Djava.security.egd=file:/dev/../dev/urandom" 
-Dtest.timeout=100


Thanks,

Attila Szabo

Re: Review Request 54699: SQOOP-3081 use OracleEscapeUtils.escapeIdentifier in OracleUpsertOutputFormat

[Boglarka Egyed]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54699/#review159422
---


Ship it!




Ship It!

- Boglarka Egyed


On Dec. 14, 2016, 11:50 a.m., Anna Szonyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54699/
> ---
> 
> (Updated Dec. 14, 2016, 11:50 a.m.)
> 
> 
> Review request for Sqoop, Attila Szabo and Szabolcs Vasas.
> 
> 
> Bugs: SQOOP-3081
> https://issues.apache.org/jira/browse/SQOOP-3081
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> SQOOP-3081 Introduce OracleEscapeUtils.escapeIdentifiers In 
> OracleUpsertOutputFormat to make it consistent with the rest of the code and 
> add escaping to the rest of the column variables.
> 
> 
> Diffs
> -
> 
>   src/java/org/apache/sqoop/mapreduce/OracleUpsertOutputFormat.java 88754e7 
>   src/test/com/cloudera/sqoop/manager/OracleExportTest.java 382eb92 
> 
> Diff: https://reviews.apache.org/r/54699/diff/
> 
> 
> Testing
> ---
> 
> ran ant clean test, ant clean test -Dsqoop.thirdparty.lib.dir=$3rdpartylib 
> -Dthirdparty=true 
> -Dsqoop.test.oracle.connectstring=$connstr-Dmapred.child.java.opts="-Djava.security.egd=file:/dev/../dev/urandom"
>  -Dtest.timeout=100 -Dtestcase=*racle*Test with special attention to 
> OracleExportTest#testUpsertTextExport
> 
> 
> Thanks,
> 
> Anna Szonyi
> 
>

Re: Review Request 54699: SQOOP-3081 use OracleEscapeUtils.escapeIdentifier in OracleUpsertOutputFormat

[Erzsebet Szilagyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54699/#review159420
---


Ship it!




Thanks for adding testing too!

- Erzsebet Szilagyi


On Dec. 14, 2016, 12:50 p.m., Anna Szonyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54699/
> ---
> 
> (Updated Dec. 14, 2016, 12:50 p.m.)
> 
> 
> Review request for Sqoop, Attila Szabo and Szabolcs Vasas.
> 
> 
> Bugs: SQOOP-3081
> https://issues.apache.org/jira/browse/SQOOP-3081
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> SQOOP-3081 Introduce OracleEscapeUtils.escapeIdentifiers In 
> OracleUpsertOutputFormat to make it consistent with the rest of the code and 
> add escaping to the rest of the column variables.
> 
> 
> Diffs
> -
> 
>   src/java/org/apache/sqoop/mapreduce/OracleUpsertOutputFormat.java 88754e7 
>   src/test/com/cloudera/sqoop/manager/OracleExportTest.java 382eb92 
> 
> Diff: https://reviews.apache.org/r/54699/diff/
> 
> 
> Testing
> ---
> 
> ran ant clean test, ant clean test -Dsqoop.thirdparty.lib.dir=$3rdpartylib 
> -Dthirdparty=true 
> -Dsqoop.test.oracle.connectstring=$connstr-Dmapred.child.java.opts="-Djava.security.egd=file:/dev/../dev/urandom"
>  -Dtest.timeout=100 -Dtestcase=*racle*Test with special attention to 
> OracleExportTest#testUpsertTextExport
> 
> 
> Thanks,
> 
> Anna Szonyi
> 
>