Re: Review Request 55132: support for DB2 XML data type when importing to hdfs

2017-02-08 Thread Ying Cao 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55132/
---

(Updated 二月 9, 2017, 3:39 a.m.)


Review request for Sqoop, Abraham Elmahrek and Jarek Cecho.


Changes
---

Update patch SQOOP-1904.6.patch wtih  Abraham's comments


Bugs: SQOOP-1904
https://issues.apache.org/jira/browse/SQOOP-1904


Repository: sqoop-trunk


Description
---

SQOOP-1904: support for DB2 XML data type when importing to hdfs


Diffs (updated)
-

  src/java/org/apache/sqoop/manager/Db2Manager.java e39aa4c 
  src/test/org/apache/sqoop/manager/db2/DB2XmlTypeImportManualTest.java 
PRE-CREATION 

Diff: https://reviews.apache.org/r/55132/diff/


Testing
---

UT passed by manually


Thanks,

Ying Cao

Re: Review Request 55132: support for DB2 XML data type when importing to hdfs

2017-02-08 Thread Ying Cao 


> On 二月 8, 2017, 10:25 p.m., Abraham Elmahrek wrote:
> > src/java/org/apache/sqoop/manager/Db2Manager.java, line 176
> > 
> >
> > Is this a Hive specific type? Or a Java specific type?

Hi Abraham Elmahrek,
Thanks for your comments.
This is Java specific type


> On 二月 8, 2017, 10:25 p.m., Abraham Elmahrek wrote:
> > src/test/org/apache/sqoop/manager/db2/DB2XmlTypeImportManualTest.java, 
> > lines 218-220
> > 
> >
> > Is this necessary?

Thanks for your comments.


> On 二月 8, 2017, 10:25 p.m., Abraham Elmahrek wrote:
> > src/test/org/apache/sqoop/manager/db2/DB2XmlTypeImportManualTest.java, line 
> > 215
> > 
> >
> > You could just move the contents of this method into the test case 
> > method above

Thanks for comments!

This method will help for resued if other more testing scenario is need.


- Ying


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55132/#review164793
---


On 二月 6, 2017, 3:19 a.m., Ying Cao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55132/
> ---
> 
> (Updated 二月 6, 2017, 3:19 a.m.)
> 
> 
> Review request for Sqoop, Abraham Elmahrek and Jarek Cecho.
> 
> 
> Bugs: SQOOP-1904
> https://issues.apache.org/jira/browse/SQOOP-1904
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> SQOOP-1904: support for DB2 XML data type when importing to hdfs
> 
> 
> Diffs
> -
> 
>   src/java/org/apache/sqoop/manager/Db2Manager.java e39aa4c 
>   src/test/org/apache/sqoop/manager/db2/DB2XmlTypeImportManualTest.java 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/55132/diff/
> 
> 
> Testing
> ---
> 
> UT passed by manually
> 
> 
> Thanks,
> 
> Ying Cao
> 
>

Re: Review Request 55132: support for DB2 XML data type when importing to hdfs

2017-02-08 Thread Abraham Elmahrek 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55132/#review164793
---




src/java/org/apache/sqoop/manager/Db2Manager.java (line 176)


Is this a Hive specific type? Or a Java specific type?



src/test/org/apache/sqoop/manager/db2/DB2XmlTypeImportManualTest.java (line 190)


Why not just use a static string or static array of strings?



src/test/org/apache/sqoop/manager/db2/DB2XmlTypeImportManualTest.java (line 215)


You could just move the contents of this method into the test case method 
above



src/test/org/apache/sqoop/manager/db2/DB2XmlTypeImportManualTest.java (lines 
218 - 220)


Is this necessary?


- Abraham Elmahrek


On Feb. 6, 2017, 3:19 a.m., Ying Cao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55132/
> ---
> 
> (Updated Feb. 6, 2017, 3:19 a.m.)
> 
> 
> Review request for Sqoop, Abraham Elmahrek and Jarek Cecho.
> 
> 
> Bugs: SQOOP-1904
> https://issues.apache.org/jira/browse/SQOOP-1904
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> SQOOP-1904: support for DB2 XML data type when importing to hdfs
> 
> 
> Diffs
> -
> 
>   src/java/org/apache/sqoop/manager/Db2Manager.java e39aa4c 
>   src/test/org/apache/sqoop/manager/db2/DB2XmlTypeImportManualTest.java 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/55132/diff/
> 
> 
> Testing
> ---
> 
> UT passed by manually
> 
> 
> Thanks,
> 
> Ying Cao
> 
>

FINAL REMINDER: CFP for ApacheCon closes February 11th

2017-02-08 Thread Rich Bowen 
Dear Apache Enthusiast,

This is your FINAL reminder that the Call for Papers (CFP) for ApacheCon
Miami is closing this weekend - February 11th. This is your final
opportunity to submit a talk for consideration at this event.

This year, we are running several mini conferences in conjunction with
the main event, so if you're submitting for one of those events, please
pay attention to the instructions below.

Apache: Big Data
* Event information:
http://events.linuxfoundation.org/events/apache-big-data-north-america
* CFP:
http://events.linuxfoundation.org/events/apache-big-data-north-america/program/cfp

Apache: IoT (Internet of Things)
* Event Information: http://us.apacheiot.org/
* CFP -
http://events.linuxfoundation.org/events/apachecon-north-america/program/cfp
(Indicate 'IoT' in the Target Audience field)

CloudStack Collaboration Conference
* Event information: http://us.cloudstackcollab.org/
* CFP -
http://events.linuxfoundation.org/events/apachecon-north-america/program/cfp
(Indicate 'CloudStack' in the Target Audience field)

FlexJS Summit
* Event information - http://us.apacheflexjs.org/
* CFP -
http://events.linuxfoundation.org/events/apachecon-north-america/program/cfp
(Indicate 'Flex' in the Target Audience field)

TomcatCon
* Event information - https://tomcat.apache.org/conference.html
* CFP -
http://events.linuxfoundation.org/events/apachecon-north-america/program/cfp
(Indicate 'Tomcat' in the Target Audience field)

All other topics and projects
* Event information -
http://events.linuxfoundation.org/events/apachecon-north-america/program/about
* CFP -
http://events.linuxfoundation.org/events/apachecon-north-america/program/cfp

Admission to any of these events also grants you access to all of the
others.

Thanks, and we look forward to seeing you in Miami!

-- 
Rich Bowen
VP Conferences, Apache Software Foundation
rbo...@apache.org
Twitter: @apachecon



(You are receiving this email because you are subscribed to a dev@ or
users@ list of some Apache Software Foundation project. If you do not
wish to receive email from these lists any more, you must follow that
list's unsubscription procedure. View the headers of this message for
unsubscription instructions.)