> On 二月 8, 2017, 10:25 p.m., Abraham Elmahrek wrote: > > src/java/org/apache/sqoop/manager/Db2Manager.java, line 176 > > <https://reviews.apache.org/r/55132/diff/4/?file=1624607#file1624607line176> > > > > Is this a Hive specific type? Or a Java specific type?
Hi Abraham Elmahrek, Thanks for your comments. This is Java specific type > On 二月 8, 2017, 10:25 p.m., Abraham Elmahrek wrote: > > src/test/org/apache/sqoop/manager/db2/DB2XmlTypeImportManualTest.java, > > lines 218-220 > > <https://reviews.apache.org/r/55132/diff/4/?file=1624608#file1624608line218> > > > > Is this necessary? Thanks for your comments. > On 二月 8, 2017, 10:25 p.m., Abraham Elmahrek wrote: > > src/test/org/apache/sqoop/manager/db2/DB2XmlTypeImportManualTest.java, line > > 215 > > <https://reviews.apache.org/r/55132/diff/4/?file=1624608#file1624608line215> > > > > You could just move the contents of this method into the test case > > method above Thanks for comments! This method will help for resued if other more testing scenario is need. - Ying ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55132/#review164793 ----------------------------------------------------------- On 二月 6, 2017, 3:19 a.m., Ying Cao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55132/ > ----------------------------------------------------------- > > (Updated 二月 6, 2017, 3:19 a.m.) > > > Review request for Sqoop, Abraham Elmahrek and Jarek Cecho. > > > Bugs: SQOOP-1904 > https://issues.apache.org/jira/browse/SQOOP-1904 > > > Repository: sqoop-trunk > > > Description > ------- > > SQOOP-1904: support for DB2 XML data type when importing to hdfs > > > Diffs > ----- > > src/java/org/apache/sqoop/manager/Db2Manager.java e39aa4c > src/test/org/apache/sqoop/manager/db2/DB2XmlTypeImportManualTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/55132/diff/ > > > Testing > ------- > > UT passed by manually > > > Thanks, > > Ying Cao > >
