Re: Review Request 66761: SQOOP-3318: Remove Kite dependency from test cases

[Szabolcs Vasas]

> On April 23, 2018, 2:54 p.m., daniel voros wrote:
> > Great stuff! Do you think we'll need ParquetReader in production code when 
> > removing Kite from the rest of the codebase? If we will, than it probably 
> > makes sense to move it under src/java now.

Yes, I was thinking about it but at this point I am not sure we will need it 
since we might be able to use parquet.hadoop.ParquetInputFormat which creates a 
proper Parquet reader out of the box so at this point I would keep it under 
test folder.


- Szabolcs


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66761/#review201737
---


On April 23, 2018, 12:21 p.m., Szabolcs Vasas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66761/
> ---
> 
> (Updated April 23, 2018, 12:21 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-3318
> https://issues.apache.org/jira/browse/SQOOP-3318
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> Some Sqoop tests use Kite to create test data and verify test results.
> 
> Since we want to remove the Kite dependency from Sqoop we should rewrite 
> these test cases not to use Kite anymore.
> 
> 
> Diffs
> -
> 
>   src/java/org/apache/sqoop/util/FileSystemUtil.java 1493e0954 
>   src/test/org/apache/sqoop/TestAllTables.java 56d1f5772 
>   src/test/org/apache/sqoop/TestMerge.java 8eef8d4ac 
>   src/test/org/apache/sqoop/TestParquetExport.java c8bb663e0 
>   src/test/org/apache/sqoop/TestParquetImport.java 379529a8d 
>   src/test/org/apache/sqoop/hive/TestHiveImport.java 4e1f249a8 
>   src/test/org/apache/sqoop/util/ParquetReader.java PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/66761/diff/1/
> 
> 
> Testing
> ---
> 
> Executed unit and third party tests.
> 
> 
> Thanks,
> 
> Szabolcs Vasas
> 
>

Re: Review Request 66067: SQOOP-3052: Introduce gradle-based build for Sqoop to make it more developer friendly / open

[Szabolcs Vasas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66067/#review201738
---



Hi Anna,

Thank you for fixing the HiveImportTest problem, it works fine now.
I have added a few more comments, there are a few test cases failing now 
because of SQOOP-3309 but it is easy to fix it.

However relnotes and release tasks fail on my side are they supposed to work 
with some extra parameters?


.gitignore
Lines 42 (patched)


When I execute a test case in IntelliJ a directory called out is created, 
can we add it to .gitignore?



build.gradle
Lines 110 (patched)


Since SQOOP-3309 we need another dependency here:

common group: 'org.apache.hive', name: 'hive-jdbc', version: hcatalogVersion



build.gradle
Lines 168 (patched)


Does not really matter but there is a typo here: hadooop



build.gradle
Lines 176 (patched)


HiveServer2 test cases added in SQOOP-3309 need an extra JVM arg here:
"-da:org.apache.hadoop.hive.thrift.HadoopThriftAuthBridge"


- Szabolcs Vasas


On April 23, 2018, 10:40 a.m., Anna Szonyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66067/
> ---
> 
> (Updated April 23, 2018, 10:40 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: Sqoop-3052
> https://issues.apache.org/jira/browse/Sqoop-3052
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> SQOOP-3052: Introduce gradle based build for Sqoop to make it more developer 
> friendly / open
> 
> 
> Diffs
> -
> 
>   .gitignore 68cbe28731e613607c208824443d1edf256d9c8a 
>   COMPILING.txt 3b82250488256871352056e9061ad08fabbd7fc5 
>   build.gradle PRE-CREATION 
>   config/checkstyle/checkstyle-java-header.txt PRE-CREATION 
>   config/checkstyle/checkstyle-noframes.xsl PRE-CREATION 
>   config/checkstyle/checkstyle.xml PRE-CREATION 
>   gradle.properties PRE-CREATION 
>   gradle/customUnixStartScript.txt PRE-CREATION 
>   gradle/customWindowsStartScript.txt PRE-CREATION 
>   gradle/sqoop-package.gradle PRE-CREATION 
>   gradle/sqoop-version-gen.gradle PRE-CREATION 
>   gradle/wrapper/gradle-wrapper.jar PRE-CREATION 
>   gradle/wrapper/gradle-wrapper.properties PRE-CREATION 
>   gradlew PRE-CREATION 
>   gradlew.bat PRE-CREATION 
>   settings.gradle PRE-CREATION 
>   src/scripts/rat-violations.sh 1cfbc1502b24dd1b8b7e7ce21f0b5d1880c06556 
>   testdata/hcatalog/conf/hive-site.xml 
> edac7aa9087a84b7a0c660907794adae684ae313 
> 
> 
> Diff: https://reviews.apache.org/r/66067/diff/9/
> 
> 
> Testing
> ---
> 
> ran all new tasks, except for internal maven publishing
> 
> Notes:
> - To try it out you can call ./gradlew tasks --all to see all the tasks and 
> compare them to current tasks/artifacts.
> - Replaced cobertura with jacoco, as it's easier/cleaner to configure, easier 
> to combine all test results into a single report.
> - Generated pom.xml now has correct dependencies/versions
> - Script generation is currently hardcoded and not based on sqoop help, as 
> previously - though added the possiblity of hooking it in later
> 
> 
> Thanks,
> 
> Anna Szonyi
> 
>

Re: Review Request 66761: SQOOP-3318: Remove Kite dependency from test cases

[daniel voros]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66761/#review201737
---


Ship it!




Great stuff! Do you think we'll need ParquetReader in production code when 
removing Kite from the rest of the codebase? If we will, than it probably makes 
sense to move it under src/java now.

- daniel voros


On April 23, 2018, 12:21 p.m., Szabolcs Vasas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66761/
> ---
> 
> (Updated April 23, 2018, 12:21 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-3318
> https://issues.apache.org/jira/browse/SQOOP-3318
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> Some Sqoop tests use Kite to create test data and verify test results.
> 
> Since we want to remove the Kite dependency from Sqoop we should rewrite 
> these test cases not to use Kite anymore.
> 
> 
> Diffs
> -
> 
>   src/java/org/apache/sqoop/util/FileSystemUtil.java 1493e0954 
>   src/test/org/apache/sqoop/TestAllTables.java 56d1f5772 
>   src/test/org/apache/sqoop/TestMerge.java 8eef8d4ac 
>   src/test/org/apache/sqoop/TestParquetExport.java c8bb663e0 
>   src/test/org/apache/sqoop/TestParquetImport.java 379529a8d 
>   src/test/org/apache/sqoop/hive/TestHiveImport.java 4e1f249a8 
>   src/test/org/apache/sqoop/util/ParquetReader.java PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/66761/diff/1/
> 
> 
> Testing
> ---
> 
> Executed unit and third party tests.
> 
> 
> Thanks,
> 
> Szabolcs Vasas
> 
>

[jira] [Commented] (SQOOP-3313) Remove Kite dependency

[Szabolcs Vasas (JIRA)]

[ 
https://issues.apache.org/jira/browse/SQOOP-3313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16448080#comment-16448080
 ] 

Szabolcs Vasas commented on SQOOP-3313:
---

Hi [~dvoros],

I have created 2 subtasks for now, I think I will have some reviewable results 
soon for the second JIRA too.

I think once the second one is done we can start implementing the Parquet 
reading/writing functionality which does not depend on Kite but implements the 
interface we introduce in the second step. We should thoroughly test it and 
once it is done we could remove the classes using Kite.

I will create the JIRAs for these tasks later as the steps can change depending 
on our further investigation on this topic.

> Remove Kite dependency
> --
>
> Key: SQOOP-3313
> URL: https://issues.apache.org/jira/browse/SQOOP-3313
> Project: Sqoop
>  Issue Type: Improvement
>Reporter: Daniel Voros
>Assignee: Daniel Voros
>Priority: Major
>
> Having Kite as a dependency makes it hard to release a version of Sqoop 
> compatible with Hadoop 3.
> For details see discussion on dev list in [this thread|http://example.com] 
> and also SQOOP-3305.
> Let's use this ticket to gather features that need to be 
> changed/reimplemented.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SQOOP-3319) Extract code using Kite into separate classes

[Szabolcs Vasas (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SQOOP-3319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Szabolcs Vasas updated SQOOP-3319:
--
Description: 
Kite Dataset API is used in many places in the code to read/write Parquet files 
and configure MR jobs.

The goal of this JIRA is to introduce an implementation agnostic interface for 
Parquet reading/writing and extract the code using Kite Dataset API into 
separate classes implementing this interface. The benefit of this refactoring 
is that it enables us introducing a new Parquet reading/writing implementation 
which does not use Kite but plugs in easily.

> Extract code using Kite into separate classes
> -
>
> Key: SQOOP-3319
> URL: https://issues.apache.org/jira/browse/SQOOP-3319
> Project: Sqoop
>  Issue Type: Sub-task
>Reporter: Szabolcs Vasas
>Assignee: Szabolcs Vasas
>Priority: Major
>
> Kite Dataset API is used in many places in the code to read/write Parquet 
> files and configure MR jobs.
> The goal of this JIRA is to introduce an implementation agnostic interface 
> for Parquet reading/writing and extract the code using Kite Dataset API into 
> separate classes implementing this interface. The benefit of this refactoring 
> is that it enables us introducing a new Parquet reading/writing 
> implementation which does not use Kite but plugs in easily.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (SQOOP-3319) Extract code using Kite into separate classes

[Szabolcs Vasas (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SQOOP-3319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Szabolcs Vasas reassigned SQOOP-3319:
-

Assignee: Szabolcs Vasas

> Extract code using Kite into separate classes
> -
>
> Key: SQOOP-3319
> URL: https://issues.apache.org/jira/browse/SQOOP-3319
> Project: Sqoop
>  Issue Type: Sub-task
>Reporter: Szabolcs Vasas
>Assignee: Szabolcs Vasas
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (SQOOP-3319) Extract code using Kite into separate classes

[Szabolcs Vasas (JIRA)]

Szabolcs Vasas created SQOOP-3319:
-

 Summary: Extract code using Kite into separate classes
 Key: SQOOP-3319
 URL: https://issues.apache.org/jira/browse/SQOOP-3319
 Project: Sqoop
  Issue Type: Sub-task
Reporter: Szabolcs Vasas






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SQOOP-3318) Remove Kite dependency from test cases

[Szabolcs Vasas (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SQOOP-3318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Szabolcs Vasas updated SQOOP-3318:
--
Attachment: SQOOP-3318.patch

> Remove Kite dependency from test cases
> --
>
> Key: SQOOP-3318
> URL: https://issues.apache.org/jira/browse/SQOOP-3318
> Project: Sqoop
>  Issue Type: Sub-task
>Reporter: Szabolcs Vasas
>Assignee: Szabolcs Vasas
>Priority: Major
> Attachments: SQOOP-3318.patch
>
>
> Some Sqoop tests use Kite to create test data and verify test results.
> Since we want to remove the Kite dependency from Sqoop we should rewrite 
> these test cases not to use Kite anymore.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Review Request 66761: SQOOP-3318: Remove Kite dependency from test cases

[Szabolcs Vasas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66761/
---

Review request for Sqoop.


Bugs: SQOOP-3318
https://issues.apache.org/jira/browse/SQOOP-3318


Repository: sqoop-trunk


Description
---

Some Sqoop tests use Kite to create test data and verify test results.

Since we want to remove the Kite dependency from Sqoop we should rewrite these 
test cases not to use Kite anymore.


Diffs
-

  src/java/org/apache/sqoop/util/FileSystemUtil.java 1493e0954 
  src/test/org/apache/sqoop/TestAllTables.java 56d1f5772 
  src/test/org/apache/sqoop/TestMerge.java 8eef8d4ac 
  src/test/org/apache/sqoop/TestParquetExport.java c8bb663e0 
  src/test/org/apache/sqoop/TestParquetImport.java 379529a8d 
  src/test/org/apache/sqoop/hive/TestHiveImport.java 4e1f249a8 
  src/test/org/apache/sqoop/util/ParquetReader.java PRE-CREATION 


Diff: https://reviews.apache.org/r/66761/diff/1/


Testing
---

Executed unit and third party tests.


Thanks,

Szabolcs Vasas

[jira] [Updated] (SQOOP-3318) Remove Kite dependency from test cases

[Szabolcs Vasas (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SQOOP-3318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Szabolcs Vasas updated SQOOP-3318:
--
Description: 
Some Sqoop tests use Kite to create test data and verify test results.

Since we want to remove the Kite dependency from Sqoop we should rewrite these 
test cases not to use Kite anymore.

> Remove Kite dependency from test cases
> --
>
> Key: SQOOP-3318
> URL: https://issues.apache.org/jira/browse/SQOOP-3318
> Project: Sqoop
>  Issue Type: Sub-task
>Reporter: Szabolcs Vasas
>Assignee: Szabolcs Vasas
>Priority: Major
>
> Some Sqoop tests use Kite to create test data and verify test results.
> Since we want to remove the Kite dependency from Sqoop we should rewrite 
> these test cases not to use Kite anymore.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (SQOOP-3318) Remote Kite dependency from test cases

[Szabolcs Vasas (JIRA)]

Szabolcs Vasas created SQOOP-3318:
-

 Summary: Remote Kite dependency from test cases
 Key: SQOOP-3318
 URL: https://issues.apache.org/jira/browse/SQOOP-3318
 Project: Sqoop
  Issue Type: Sub-task
Reporter: Szabolcs Vasas






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SQOOP-3318) Remove Kite dependency from test cases

[Szabolcs Vasas (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SQOOP-3318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Szabolcs Vasas updated SQOOP-3318:
--
Summary: Remove Kite dependency from test cases  (was: Remote Kite 
dependency from test cases)

> Remove Kite dependency from test cases
> --
>
> Key: SQOOP-3318
> URL: https://issues.apache.org/jira/browse/SQOOP-3318
> Project: Sqoop
>  Issue Type: Sub-task
>Reporter: Szabolcs Vasas
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (SQOOP-3318) Remove Kite dependency from test cases

[Szabolcs Vasas (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SQOOP-3318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Szabolcs Vasas reassigned SQOOP-3318:
-

Assignee: Szabolcs Vasas

> Remove Kite dependency from test cases
> --
>
> Key: SQOOP-3318
> URL: https://issues.apache.org/jira/browse/SQOOP-3318
> Project: Sqoop
>  Issue Type: Sub-task
>Reporter: Szabolcs Vasas
>Assignee: Szabolcs Vasas
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Review Request 66067: SQOOP-3052: Introduce gradle-based build for Sqoop to make it more developer friendly / open

[Anna Szonyi via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66067/
---

(Updated April 23, 2018, 10:40 a.m.)


Review request for Sqoop.


Bugs: Sqoop-3052
https://issues.apache.org/jira/browse/Sqoop-3052


Repository: sqoop-trunk


Description
---

SQOOP-3052: Introduce gradle based build for Sqoop to make it more developer 
friendly / open


Diffs (updated)
-

  .gitignore 68cbe28731e613607c208824443d1edf256d9c8a 
  COMPILING.txt 3b82250488256871352056e9061ad08fabbd7fc5 
  build.gradle PRE-CREATION 
  config/checkstyle/checkstyle-java-header.txt PRE-CREATION 
  config/checkstyle/checkstyle-noframes.xsl PRE-CREATION 
  config/checkstyle/checkstyle.xml PRE-CREATION 
  gradle.properties PRE-CREATION 
  gradle/customUnixStartScript.txt PRE-CREATION 
  gradle/customWindowsStartScript.txt PRE-CREATION 
  gradle/sqoop-package.gradle PRE-CREATION 
  gradle/sqoop-version-gen.gradle PRE-CREATION 
  gradle/wrapper/gradle-wrapper.jar PRE-CREATION 
  gradle/wrapper/gradle-wrapper.properties PRE-CREATION 
  gradlew PRE-CREATION 
  gradlew.bat PRE-CREATION 
  settings.gradle PRE-CREATION 
  src/scripts/rat-violations.sh 1cfbc1502b24dd1b8b7e7ce21f0b5d1880c06556 
  testdata/hcatalog/conf/hive-site.xml edac7aa9087a84b7a0c660907794adae684ae313 


Diff: https://reviews.apache.org/r/66067/diff/9/

Changes: https://reviews.apache.org/r/66067/diff/8-9/


Testing
---

ran all new tasks, except for internal maven publishing

Notes:
- To try it out you can call ./gradlew tasks --all to see all the tasks and 
compare them to current tasks/artifacts.
- Replaced cobertura with jacoco, as it's easier/cleaner to configure, easier 
to combine all test results into a single report.
- Generated pom.xml now has correct dependencies/versions
- Script generation is currently hardcoded and not based on sqoop help, as 
previously - though added the possiblity of hooking it in later


Thanks,

Anna Szonyi

Re: Review Request 66067: SQOOP-3052: Introduce gradle-based build for Sqoop to make it more developer friendly / open

[Anna Szonyi via Review Board]

> On April 23, 2018, 10:33 a.m., Fero Szabo wrote:
> > Hi Anna,
> > 
> > I couldn't apply the patch cleanly, I ran into the following error message:
> > 
> > fero-MBP:sqoop ferencszabo$ git apply ~/Downloads/SQOOP-3052-5.patch 
> > error: missing binary patch data for 'gradle/wrapper/gradle-wrapper.jar'
> > error: binary patch does not apply to 'gradle/wrapper/gradle-wrapper.jar'
> > error: gradle/wrapper/gradle-wrapper.jar: patch does not apply
> > 
> > Managed to apply it with the following command:
> > patch -p1 -i  ~/Downloads/SQOOP-3052-5.patch
> > 
> > Also, gradle was missing from my system, so I had to install it and then 
> > gradle/wrapper/gradle-wrapper.jar was probably downloaded after I executed 
> > 'gradle wrapper' or './gradlew wrapper'
> > 
> > I'm not sure how to fix these though. Did I go through the "correct" way to 
> > install gradle? Maybe I should have invoked './gradlew wrapper' right after 
> > applying the patch. Would that work without gradle installed on the system?
> > 
> > Anyway thanks for the patch, it would be really cool to use gradle in Sqoop!

Hi Fero,

Thanks for testing, I haven't rebased to the latest version of trunk, which 
might be the reason it doesn't apply cleanly? I tested it when I created the 
patch on the current (at that time) trunk, but I will definitely double-check 
this.

The reason we are adding the gradle wrapper jar and the gradlew and gradlew.bat 
files is that you shouldn't have been required to separately install gradle - 
just execute ./gradlew wrapper.

Thanks,
Anna


- Anna


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66067/#review201727
---


On April 18, 2018, 3:10 p.m., Anna Szonyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66067/
> ---
> 
> (Updated April 18, 2018, 3:10 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: Sqoop-3052
> https://issues.apache.org/jira/browse/Sqoop-3052
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> SQOOP-3052: Introduce gradle based build for Sqoop to make it more developer 
> friendly / open
> 
> 
> Diffs
> -
> 
>   .gitignore 68cbe28731e613607c208824443d1edf256d9c8a 
>   COMPILING.txt 3b82250488256871352056e9061ad08fabbd7fc5 
>   build.gradle PRE-CREATION 
>   config/checkstyle/checkstyle-java-header.txt PRE-CREATION 
>   config/checkstyle/checkstyle-noframes.xsl PRE-CREATION 
>   config/checkstyle/checkstyle.xml PRE-CREATION 
>   gradle.properties PRE-CREATION 
>   gradle/customUnixStartScript.txt PRE-CREATION 
>   gradle/customWindowsStartScript.txt PRE-CREATION 
>   gradle/sqoop-package.gradle PRE-CREATION 
>   gradle/sqoop-version-gen.gradle PRE-CREATION 
>   gradle/wrapper/gradle-wrapper.jar PRE-CREATION 
>   gradle/wrapper/gradle-wrapper.properties PRE-CREATION 
>   gradlew PRE-CREATION 
>   gradlew.bat PRE-CREATION 
>   settings.gradle PRE-CREATION 
>   src/scripts/rat-violations.sh 1cfbc1502b24dd1b8b7e7ce21f0b5d1880c06556 
>   testdata/hcatalog/conf/hive-site.xml 
> edac7aa9087a84b7a0c660907794adae684ae313 
> 
> 
> Diff: https://reviews.apache.org/r/66067/diff/9/
> 
> 
> Testing
> ---
> 
> ran all new tasks, except for internal maven publishing
> 
> Notes:
> - To try it out you can call ./gradlew tasks --all to see all the tasks and 
> compare them to current tasks/artifacts.
> - Replaced cobertura with jacoco, as it's easier/cleaner to configure, easier 
> to combine all test results into a single report.
> - Generated pom.xml now has correct dependencies/versions
> - Script generation is currently hardcoded and not based on sqoop help, as 
> previously - though added the possiblity of hooking it in later
> 
> 
> Thanks,
> 
> Anna Szonyi
> 
>

Re: Review Request 66067: SQOOP-3052: Introduce gradle-based build for Sqoop to make it more developer friendly / open

[Fero Szabo via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66067/#review201727
---



Hi Anna,

I couldn't apply the patch cleanly, I ran into the following error message:

fero-MBP:sqoop ferencszabo$ git apply ~/Downloads/SQOOP-3052-5.patch 
error: missing binary patch data for 'gradle/wrapper/gradle-wrapper.jar'
error: binary patch does not apply to 'gradle/wrapper/gradle-wrapper.jar'
error: gradle/wrapper/gradle-wrapper.jar: patch does not apply

Managed to apply it with the following command:
patch -p1 -i  ~/Downloads/SQOOP-3052-5.patch

Also, gradle was missing from my system, so I had to install it and then 
gradle/wrapper/gradle-wrapper.jar was probably downloaded after I executed 
'gradle wrapper' or './gradlew wrapper'

I'm not sure how to fix these though. Did I go through the "correct" way to 
install gradle? Maybe I should have invoked './gradlew wrapper' right after 
applying the patch. Would that work without gradle installed on the system?

Anyway thanks for the patch, it would be really cool to use gradle in Sqoop!

- Fero Szabo


On April 18, 2018, 3:10 p.m., Anna Szonyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66067/
> ---
> 
> (Updated April 18, 2018, 3:10 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: Sqoop-3052
> https://issues.apache.org/jira/browse/Sqoop-3052
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> SQOOP-3052: Introduce gradle based build for Sqoop to make it more developer 
> friendly / open
> 
> 
> Diffs
> -
> 
>   .gitignore 68cbe28731e613607c208824443d1edf256d9c8a 
>   COMPILING.txt 3b82250488256871352056e9061ad08fabbd7fc5 
>   build.gradle PRE-CREATION 
>   config/checkstyle/checkstyle-java-header.txt PRE-CREATION 
>   config/checkstyle/checkstyle-noframes.xsl PRE-CREATION 
>   config/checkstyle/checkstyle.xml PRE-CREATION 
>   gradle.properties PRE-CREATION 
>   gradle/customUnixStartScript.txt PRE-CREATION 
>   gradle/customWindowsStartScript.txt PRE-CREATION 
>   gradle/sqoop-package.gradle PRE-CREATION 
>   gradle/sqoop-version-gen.gradle PRE-CREATION 
>   gradle/wrapper/gradle-wrapper.jar PRE-CREATION 
>   gradle/wrapper/gradle-wrapper.properties PRE-CREATION 
>   gradlew PRE-CREATION 
>   gradlew.bat PRE-CREATION 
>   settings.gradle PRE-CREATION 
>   src/scripts/rat-violations.sh 1cfbc1502b24dd1b8b7e7ce21f0b5d1880c06556 
>   testdata/hcatalog/conf/hive-site.xml 
> edac7aa9087a84b7a0c660907794adae684ae313 
> 
> 
> Diff: https://reviews.apache.org/r/66067/diff/8/
> 
> 
> Testing
> ---
> 
> ran all new tasks, except for internal maven publishing
> 
> Notes:
> - To try it out you can call ./gradlew tasks --all to see all the tasks and 
> compare them to current tasks/artifacts.
> - Replaced cobertura with jacoco, as it's easier/cleaner to configure, easier 
> to combine all test results into a single report.
> - Generated pom.xml now has correct dependencies/versions
> - Script generation is currently hardcoded and not based on sqoop help, as 
> previously - though added the possiblity of hooking it in later
> 
> 
> Thanks,
> 
> Anna Szonyi
> 
>

[jira] [Updated] (SQOOP-3309) Implement HiveServer2 client

[Szabolcs Vasas (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SQOOP-3309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Szabolcs Vasas updated SQOOP-3309:
--
Attachment: (was: SQOOP-3309.patch)

> Implement HiveServer2 client
> 
>
> Key: SQOOP-3309
> URL: https://issues.apache.org/jira/browse/SQOOP-3309
> Project: Sqoop
>  Issue Type: Sub-task
>Affects Versions: 1.5.0
>Reporter: Szabolcs Vasas
>Assignee: Szabolcs Vasas
>Priority: Major
> Fix For: 1.5.0
>
> Attachments: SQOOP-3309.patch
>
>
> This JIRA covers the implementation of the client for HiveServer2 and its 
> integration into the classes which use HiveImport.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SQOOP-3309) Implement HiveServer2 client

[Szabolcs Vasas (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SQOOP-3309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Szabolcs Vasas updated SQOOP-3309:
--
Attachment: SQOOP-3309.patch

> Implement HiveServer2 client
> 
>
> Key: SQOOP-3309
> URL: https://issues.apache.org/jira/browse/SQOOP-3309
> Project: Sqoop
>  Issue Type: Sub-task
>Affects Versions: 1.5.0
>Reporter: Szabolcs Vasas
>Assignee: Szabolcs Vasas
>Priority: Major
> Fix For: 1.5.0
>
> Attachments: SQOOP-3309.patch
>
>
> This JIRA covers the implementation of the client for HiveServer2 and its 
> integration into the classes which use HiveImport.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)