[jira] [Commented] (SQOOP-3289) Add .travis.yml
[ https://issues.apache.org/jira/browse/SQOOP-3289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697237#comment-16697237 ] Hudson commented on SQOOP-3289: --- FAILURE: Integrated in Jenkins build Sqoop-hadoop200 #1235 (See [https://builds.apache.org/job/Sqoop-hadoop200/1235/]) Revert "SQOOP-3289: Add .travis.yml" (fero: [https://git-wip-us.apache.org/repos/asf?p=sqoop.git=commit=cbc39c3bfa04001a411fda456429e686220ecbba]) * (edit) src/test/org/apache/sqoop/manager/sqlserver/SQLServerManagerImportTest.java * (edit) gradle.properties * (edit) src/test/org/apache/sqoop/manager/db2/DB2XmlTypeImportManualTest.java * (delete) src/test/org/apache/sqoop/testcategories/thirdpartytest/OracleEeTest.java * (edit) build.gradle * (edit) src/test/org/apache/sqoop/metastore/db2/DB2SavedJobsTest.java * (edit) src/test/org/apache/sqoop/manager/mysql/MySQLTestUtils.java * (delete) src/scripts/thirdpartytest/docker-compose/oraclescripts/ee-healthcheck.sh * (edit) src/test/org/apache/sqoop/metastore/postgres/PostgresJobToolTest.java * (edit) src/test/org/apache/sqoop/metastore/postgres/PostgresMetaConnectIncrementalImportTest.java * (edit) src/test/org/apache/sqoop/manager/postgresql/PGBulkloadManagerManualTest.java * (edit) src/test/org/apache/sqoop/manager/postgresql/PostgresqlTestUtil.java * (edit) src/test/org/apache/sqoop/manager/sqlserver/MSSQLTestUtils.java * (edit) src/test/org/apache/sqoop/manager/db2/DB2ManagerImportManualTest.java * (edit) src/test/org/apache/sqoop/manager/oracle/ImportTest.java * (edit) src/test/org/apache/sqoop/manager/oracle/TimestampDataTest.java * (edit) src/test/org/apache/sqoop/manager/sqlserver/SQLServerManagerExportTest.java * (edit) COMPILING.txt * (delete) src/test/org/apache/sqoop/manager/db2/DB2TestUtils.java * (edit) src/scripts/thirdpartytest/docker-compose/oraclescripts/healthcheck.sh * (edit) src/test/org/apache/sqoop/metastore/postgres/PostgresSavedJobsTest.java * (edit) build.xml * (edit) src/test/org/apache/sqoop/manager/db2/DB2ImportAllTableWithSchemaManualTest.java * (edit) src/test/org/apache/sqoop/manager/oracle/ExportTest.java * (edit) src/test/org/apache/sqoop/manager/postgresql/DirectPostgreSQLExportManualTest.java * (edit) src/test/org/apache/sqoop/metastore/db2/DB2MetaConnectIncrementalImportTest.java * (delete) src/scripts/thirdpartytest/docker-compose/oraclescripts/startup/.cache * (edit) src/test/org/apache/sqoop/manager/cubrid/CubridTestUtils.java * (edit) src/test/org/apache/sqoop/manager/oracle/util/OracleUtils.java * (edit) src/test/org/apache/sqoop/manager/oracle/OraOopTypesTest.java * (edit) src/scripts/thirdpartytest/docker-compose/sqoop-thirdpartytest-db-services.yml * (edit) src/test/org/apache/sqoop/metastore/db2/DB2JobToolTest.java * (edit) src/test/org/apache/sqoop/manager/postgresql/PostgresqlExportTest.java * (edit) src/test/org/apache/sqoop/manager/oracle/OracleConnectionFactoryTest.java * (edit) src/test/org/apache/sqoop/manager/postgresql/PostgresqlExternalTableImportTest.java * (delete) .travis.yml * (edit) src/test/org/apache/sqoop/manager/oracle/OraOopTestCase.java SQOOP-3289: Add .travis.yml (fero: [https://git-wip-us.apache.org/repos/asf?p=sqoop.git=commit=2bf6f3ccd0b59c9ff29d56a32b25f3a659dcfe19]) * (edit) build.xml * (add) src/scripts/thirdpartytest/docker-compose/oraclescripts/ee-healthcheck.sh * (edit) src/test/org/apache/sqoop/manager/cubrid/CubridTestUtils.java * (edit) src/test/org/apache/sqoop/manager/mysql/MySQLTestUtils.java * (edit) src/test/org/apache/sqoop/metastore/db2/DB2JobToolTest.java * (edit) src/test/org/apache/sqoop/manager/oracle/ExportTest.java * (add) src/test/org/apache/sqoop/testcategories/thirdpartytest/OracleEeTest.java * (edit) src/test/org/apache/sqoop/manager/db2/DB2ManagerImportManualTest.java * (add) .travis.yml * (edit) src/test/org/apache/sqoop/manager/postgresql/PGBulkloadManagerManualTest.java * (edit) build.gradle * (edit) src/test/org/apache/sqoop/metastore/db2/DB2MetaConnectIncrementalImportTest.java * (edit) src/test/org/apache/sqoop/manager/oracle/OraOopTypesTest.java * (edit) src/test/org/apache/sqoop/manager/sqlserver/SQLServerManagerImportTest.java * (edit) src/test/org/apache/sqoop/metastore/db2/DB2SavedJobsTest.java * (edit) gradle.properties * (edit) COMPILING.txt * (edit) src/test/org/apache/sqoop/manager/db2/DB2ImportAllTableWithSchemaManualTest.java * (edit) src/test/org/apache/sqoop/manager/db2/DB2XmlTypeImportManualTest.java * (edit) src/test/org/apache/sqoop/manager/postgresql/DirectPostgreSQLExportManualTest.java * (edit) src/test/org/apache/sqoop/manager/oracle/ImportTest.java * (edit) src/test/org/apache/sqoop/manager/oracle/TimestampDataTest.java * (edit) src/test/org/apache/sqoop/manager/oracle/OraOopTestCase.java * (edit) src/test/org/apache/sqoop/manager/postgresql/PostgresqlExportTest.java * (edit) src/test/org/apache/sqoop/manager/sqlserver/SQLServerManagerExportTest.java * (edit)
[jira] [Commented] (SQOOP-3289) Add .travis.yml
[
https://issues.apache.org/jira/browse/SQOOP-3289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697180#comment-16697180
]
ASF subversion and git services commented on SQOOP-3289:
Commit 2bf6f3ccd0b59c9ff29d56a32b25f3a659dcfe19 in sqoop's branch
refs/heads/trunk from [~fero]
[ https://git-wip-us.apache.org/repos/asf?p=sqoop.git;h=2bf6f3c ]
SQOOP-3289: Add .travis.yml
(Szabolcs Vasas via Fero Szabo)
> Add .travis.yml
> ---
>
> Key: SQOOP-3289
> URL: https://issues.apache.org/jira/browse/SQOOP-3289
> Project: Sqoop
> Issue Type: Sub-task
> Components: build
>Affects Versions: 1.4.7
>Reporter: Daniel Voros
>Assignee: Szabolcs Vasas
>Priority: Minor
> Fix For: 1.5.0, 3.0.0
>
> Attachments: SQOOP-3289.patch
>
>
> Adding a .travis.yml would enable running builds/tests on travis-ci.org.
> Currently if you wish to use Travis for testing your changes, you have to
> manually add a .travis.yml to your branch. Having it committed to trunk would
> save us this extra step.
> I currently have an example
> [{{.travis.yml}}|https://github.com/dvoros/sqoop/blob/93a4c06c1a3da1fd5305c99e379484507797b3eb/.travis.yml]
> on my travis branch running unit tests for every commit and every pull
> request: https://travis-ci.org/dvoros/sqoop/builds
> Later we could add the build status to the project readme as well, see:
> https://github.com/dvoros/sqoop/tree/travis
> Also, an example of a pull request: https://github.com/dvoros/sqoop/pull/1
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SQOOP-3289) Add .travis.yml
[
https://issues.apache.org/jira/browse/SQOOP-3289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697179#comment-16697179
]
ASF subversion and git services commented on SQOOP-3289:
Commit cbc39c3bfa04001a411fda456429e686220ecbba in sqoop's branch
refs/heads/trunk from [~fero]
[ https://git-wip-us.apache.org/repos/asf?p=sqoop.git;h=cbc39c3 ]
Revert "SQOOP-3289: Add .travis.yml"
This reverts commit 83a18e195111adb9f906401b0c030666378bae69.
Reverting because of accidental inclusion of .cache file.
> Add .travis.yml
> ---
>
> Key: SQOOP-3289
> URL: https://issues.apache.org/jira/browse/SQOOP-3289
> Project: Sqoop
> Issue Type: Sub-task
> Components: build
>Affects Versions: 1.4.7
>Reporter: Daniel Voros
>Assignee: Szabolcs Vasas
>Priority: Minor
> Fix For: 1.5.0, 3.0.0
>
> Attachments: SQOOP-3289.patch
>
>
> Adding a .travis.yml would enable running builds/tests on travis-ci.org.
> Currently if you wish to use Travis for testing your changes, you have to
> manually add a .travis.yml to your branch. Having it committed to trunk would
> save us this extra step.
> I currently have an example
> [{{.travis.yml}}|https://github.com/dvoros/sqoop/blob/93a4c06c1a3da1fd5305c99e379484507797b3eb/.travis.yml]
> on my travis branch running unit tests for every commit and every pull
> request: https://travis-ci.org/dvoros/sqoop/builds
> Later we could add the build status to the project readme as well, see:
> https://github.com/dvoros/sqoop/tree/travis
> Also, an example of a pull request: https://github.com/dvoros/sqoop/pull/1
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SQOOP-3289) Add .travis.yml
[
https://issues.apache.org/jira/browse/SQOOP-3289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697093#comment-16697093
]
Hudson commented on SQOOP-3289:
---
FAILURE: Integrated in Jenkins build Sqoop-hadoop200 #1234 (See
[https://builds.apache.org/job/Sqoop-hadoop200/1234/])
SQOOP-3289: Add .travis.yml (fero:
[https://git-wip-us.apache.org/repos/asf?p=sqoop.git=commit=83a18e195111adb9f906401b0c030666378bae69])
* (edit)
src/test/org/apache/sqoop/manager/postgresql/DirectPostgreSQLExportManualTest.java
* (edit) COMPILING.txt
* (edit) build.gradle
* (edit) src/test/org/apache/sqoop/manager/oracle/OraOopTestCase.java
* (edit)
src/test/org/apache/sqoop/manager/postgresql/PostgresqlExternalTableImportTest.java
* (add) .travis.yml
* (add)
src/scripts/thirdpartytest/docker-compose/oraclescripts/ee-healthcheck.sh
* (add) src/scripts/thirdpartytest/docker-compose/oraclescripts/startup/.cache
* (add) src/test/org/apache/sqoop/manager/db2/DB2TestUtils.java
* (edit) src/test/org/apache/sqoop/manager/oracle/ExportTest.java
* (edit) src/test/org/apache/sqoop/manager/oracle/ImportTest.java
* (edit) src/test/org/apache/sqoop/manager/postgresql/PostgresqlExportTest.java
* (edit)
src/test/org/apache/sqoop/metastore/db2/DB2MetaConnectIncrementalImportTest.java
* (add)
src/test/org/apache/sqoop/testcategories/thirdpartytest/OracleEeTest.java
* (edit) src/test/org/apache/sqoop/manager/db2/DB2XmlTypeImportManualTest.java
* (edit) src/test/org/apache/sqoop/manager/mysql/MySQLTestUtils.java
* (edit) src/test/org/apache/sqoop/manager/postgresql/PostgresqlTestUtil.java
* (edit)
src/test/org/apache/sqoop/manager/db2/DB2ImportAllTableWithSchemaManualTest.java
* (edit) src/test/org/apache/sqoop/manager/db2/DB2ManagerImportManualTest.java
* (edit) src/scripts/thirdpartytest/docker-compose/oraclescripts/healthcheck.sh
* (edit)
src/test/org/apache/sqoop/manager/sqlserver/SQLServerManagerExportTest.java
* (edit) src/test/org/apache/sqoop/manager/sqlserver/MSSQLTestUtils.java
* (edit)
src/test/org/apache/sqoop/metastore/postgres/PostgresMetaConnectIncrementalImportTest.java
* (edit)
src/test/org/apache/sqoop/manager/sqlserver/SQLServerManagerImportTest.java
* (edit) src/test/org/apache/sqoop/metastore/postgres/PostgresSavedJobsTest.java
* (edit) src/test/org/apache/sqoop/manager/oracle/TimestampDataTest.java
* (edit) gradle.properties
* (edit) build.xml
* (edit) src/test/org/apache/sqoop/manager/oracle/util/OracleUtils.java
* (edit)
src/test/org/apache/sqoop/manager/oracle/OracleConnectionFactoryTest.java
* (edit) src/test/org/apache/sqoop/manager/oracle/OraOopTypesTest.java
* (edit)
src/test/org/apache/sqoop/manager/postgresql/PGBulkloadManagerManualTest.java
* (edit) src/test/org/apache/sqoop/metastore/db2/DB2SavedJobsTest.java
* (edit)
src/scripts/thirdpartytest/docker-compose/sqoop-thirdpartytest-db-services.yml
* (edit) src/test/org/apache/sqoop/manager/cubrid/CubridTestUtils.java
* (edit) src/test/org/apache/sqoop/metastore/db2/DB2JobToolTest.java
* (edit) src/test/org/apache/sqoop/metastore/postgres/PostgresJobToolTest.java
> Add .travis.yml
> ---
>
> Key: SQOOP-3289
> URL: https://issues.apache.org/jira/browse/SQOOP-3289
> Project: Sqoop
> Issue Type: Sub-task
> Components: build
>Affects Versions: 1.4.7
>Reporter: Daniel Voros
>Assignee: Szabolcs Vasas
>Priority: Minor
> Fix For: 1.5.0, 3.0.0
>
> Attachments: SQOOP-3289.patch
>
>
> Adding a .travis.yml would enable running builds/tests on travis-ci.org.
> Currently if you wish to use Travis for testing your changes, you have to
> manually add a .travis.yml to your branch. Having it committed to trunk would
> save us this extra step.
> I currently have an example
> [{{.travis.yml}}|https://github.com/dvoros/sqoop/blob/93a4c06c1a3da1fd5305c99e379484507797b3eb/.travis.yml]
> on my travis branch running unit tests for every commit and every pull
> request: https://travis-ci.org/dvoros/sqoop/builds
> Later we could add the build status to the project readme as well, see:
> https://github.com/dvoros/sqoop/tree/travis
> Also, an example of a pull request: https://github.com/dvoros/sqoop/pull/1
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SQOOP-3289) Add .travis.yml
[
https://issues.apache.org/jira/browse/SQOOP-3289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697056#comment-16697056
]
ASF subversion and git services commented on SQOOP-3289:
Commit 83a18e195111adb9f906401b0c030666378bae69 in sqoop's branch
refs/heads/trunk from [~fero]
[ https://git-wip-us.apache.org/repos/asf?p=sqoop.git;h=83a18e1 ]
SQOOP-3289: Add .travis.yml
(Szabolcs Vasas via Fero Szabo)
> Add .travis.yml
> ---
>
> Key: SQOOP-3289
> URL: https://issues.apache.org/jira/browse/SQOOP-3289
> Project: Sqoop
> Issue Type: Sub-task
> Components: build
>Affects Versions: 1.4.7
>Reporter: Daniel Voros
>Assignee: Szabolcs Vasas
>Priority: Minor
> Fix For: 1.5.0, 3.0.0
>
> Attachments: SQOOP-3289.patch
>
>
> Adding a .travis.yml would enable running builds/tests on travis-ci.org.
> Currently if you wish to use Travis for testing your changes, you have to
> manually add a .travis.yml to your branch. Having it committed to trunk would
> save us this extra step.
> I currently have an example
> [{{.travis.yml}}|https://github.com/dvoros/sqoop/blob/93a4c06c1a3da1fd5305c99e379484507797b3eb/.travis.yml]
> on my travis branch running unit tests for every commit and every pull
> request: https://travis-ci.org/dvoros/sqoop/builds
> Later we could add the build status to the project readme as well, see:
> https://github.com/dvoros/sqoop/tree/travis
> Also, an example of a pull request: https://github.com/dvoros/sqoop/pull/1
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SQOOP-3289) Add .travis.yml
[
https://issues.apache.org/jira/browse/SQOOP-3289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16696056#comment-16696056
]
Szabolcs Vasas commented on SQOOP-3289:
---
Hi All,
This initiative was abandoned for a while, after the Gradle upgrade I have
managed to create a Travis job which can execute almost all of the third party
tests with Travis.
Please see my RB request attached: https://reviews.apache.org/r/69433/
> Add .travis.yml
> ---
>
> Key: SQOOP-3289
> URL: https://issues.apache.org/jira/browse/SQOOP-3289
> Project: Sqoop
> Issue Type: Task
> Components: build
>Affects Versions: 1.4.7
>Reporter: Daniel Voros
>Assignee: Daniel Voros
>Priority: Minor
> Fix For: 1.5.0
>
>
> Adding a .travis.yml would enable running builds/tests on travis-ci.org.
> Currently if you wish to use Travis for testing your changes, you have to
> manually add a .travis.yml to your branch. Having it committed to trunk would
> save us this extra step.
> I currently have an example
> [{{.travis.yml}}|https://github.com/dvoros/sqoop/blob/93a4c06c1a3da1fd5305c99e379484507797b3eb/.travis.yml]
> on my travis branch running unit tests for every commit and every pull
> request: https://travis-ci.org/dvoros/sqoop/builds
> Later we could add the build status to the project readme as well, see:
> https://github.com/dvoros/sqoop/tree/travis
> Also, an example of a pull request: https://github.com/dvoros/sqoop/pull/1
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SQOOP-3289) Add .travis.yml
[
https://issues.apache.org/jira/browse/SQOOP-3289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16393199#comment-16393199
]
Daniel Voros commented on SQOOP-3289:
-
Hi [~BoglarkaEgyed],
Thanks for you review! In the meantime I've started fooling around with
thirdparty tests in Travis. Thought I'll share the current status so you can
comment on that early on. For the latest results, please check this build:
https://travis-ci.org/dvoros/sqoop/builds/351353673
cc [~vasas] [~maugli]
> Add .travis.yml
> ---
>
> Key: SQOOP-3289
> URL: https://issues.apache.org/jira/browse/SQOOP-3289
> Project: Sqoop
> Issue Type: Task
> Components: build
>Affects Versions: 1.4.7
>Reporter: Daniel Voros
>Assignee: Daniel Voros
>Priority: Minor
> Fix For: 1.5.0
>
>
> Adding a .travis.yml would enable running builds/tests on travis-ci.org.
> Currently if you wish to use Travis for testing your changes, you have to
> manually add a .travis.yml to your branch. Having it committed to trunk would
> save us this extra step.
> I currently have an example
> [{{.travis.yml}}|https://github.com/dvoros/sqoop/blob/93a4c06c1a3da1fd5305c99e379484507797b3eb/.travis.yml]
> on my travis branch running unit tests for every commit and every pull
> request: https://travis-ci.org/dvoros/sqoop/builds
> Later we could add the build status to the project readme as well, see:
> https://github.com/dvoros/sqoop/tree/travis
> Also, an example of a pull request: https://github.com/dvoros/sqoop/pull/1
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SQOOP-3289) Add .travis.yml
[
https://issues.apache.org/jira/browse/SQOOP-3289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16392893#comment-16392893
]
Boglarka Egyed commented on SQOOP-3289:
---
Hi [~dvoros],
I think this is a great first step to ease the development and the test process
for the contributors, so a +1 from my side too.
I agree with Attila and Szabolcs, we should aim to have a stable CI system
which will run all the unit and third party tests on every commit automatically
or what is more on every patch submission. I haven't investigate this topic on
my own so far but the sources Szabolcs shared seem to be a good point to start.
However I also see legal issues with the third party test suite and for that
either the [Apache Legal Affairs Committee|https://www.apache.org/legal/] or
the [Apache Infrastructure Team|https://www.apache.org/dev/infrastructure.html]
could be contacted perhaps.
> Add .travis.yml
> ---
>
> Key: SQOOP-3289
> URL: https://issues.apache.org/jira/browse/SQOOP-3289
> Project: Sqoop
> Issue Type: Task
> Components: build
>Affects Versions: 1.4.7
>Reporter: Daniel Voros
>Assignee: Daniel Voros
>Priority: Minor
> Fix For: 1.5.0
>
>
> Adding a .travis.yml would enable running builds/tests on travis-ci.org.
> Currently if you wish to use Travis for testing your changes, you have to
> manually add a .travis.yml to your branch. Having it committed to trunk would
> save us this extra step.
> I currently have an example
> [{{.travis.yml}}|https://github.com/dvoros/sqoop/blob/93a4c06c1a3da1fd5305c99e379484507797b3eb/.travis.yml]
> on my travis branch running unit tests for every commit and every pull
> request: https://travis-ci.org/dvoros/sqoop/builds
> Later we could add the build status to the project readme as well, see:
> https://github.com/dvoros/sqoop/tree/travis
> Also, an example of a pull request: https://github.com/dvoros/sqoop/pull/1
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SQOOP-3289) Add .travis.yml
[
https://issues.apache.org/jira/browse/SQOOP-3289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16390860#comment-16390860
]
Daniel Voros commented on SQOOP-3289:
-
Thank you both for your comments! I'm convinced, let's give Travis a shot with
the CI as well!
[~vasas] I'll start experimenting with thirdparty tests. First thing that came
to my mind was to run the DB containers on a third-party server and use that
from Travis. Not sure if that's better or worse from the legal perspective tho.
(:
> Add .travis.yml
> ---
>
> Key: SQOOP-3289
> URL: https://issues.apache.org/jira/browse/SQOOP-3289
> Project: Sqoop
> Issue Type: Task
> Components: build
>Affects Versions: 1.4.7
>Reporter: Daniel Voros
>Assignee: Daniel Voros
>Priority: Minor
> Fix For: 1.5.0
>
>
> Adding a .travis.yml would enable running builds/tests on travis-ci.org.
> Currently if you wish to use Travis for testing your changes, you have to
> manually add a .travis.yml to your branch. Having it committed to trunk would
> save us this extra step.
> I currently have an example
> [{{.travis.yml}}|https://github.com/dvoros/sqoop/blob/93a4c06c1a3da1fd5305c99e379484507797b3eb/.travis.yml]
> on my travis branch running unit tests for every commit and every pull
> request: https://travis-ci.org/dvoros/sqoop/builds
> Later we could add the build status to the project readme as well, see:
> https://github.com/dvoros/sqoop/tree/travis
> Also, an example of a pull request: https://github.com/dvoros/sqoop/pull/1
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SQOOP-3289) Add .travis.yml
[
https://issues.apache.org/jira/browse/SQOOP-3289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379181#comment-16379181
]
Szabolcs Vasas commented on SQOOP-3289:
---
Hi [~dvoros],
Thank you for raising this JIRA and bringing up this topic!
I have also experimented with Travis recently it's a great chance to share our
thoughts on it.
TL;DR: +1 for the patch, I think it can make the life of the contributors
easier and it is a good start for further improvements.
I think the benefit of Travis over Jenkins is that the contributors can run it
on their own forks and can get very quick feedback (the dependency caching
minimizes the time spent with the ivy resolve).
I understand your patch addresses this use case only but we can talk about how
we want/could extend it in the future.
I like that Travis integrates well with Github and pull requests so if we want
to use pull requests instead of review board enabling Travis on Sqoop trunk
could simplify the review process. I also find it great that .travis.yml is
part of the project so it is much easier to change it and it is more
transparent what is happening in the CI job. We might be able to do the same
with Jenkins but I am not really familiar with it and the permission
restrictions make it much harder to configure it.
One potential issue I can see is that Travis has a 50 minute timeout for the
jobs (https://docs.travis-ci.com/user/customizing-the-build/#Build-Timeouts).
However the good thing is that we could parallelize our build and have separate
jobs for our unit tests, integration tests, MySQL tests, etc. under the same
build
(https://docs.travis-ci.com/user/speeding-up-the-build/#Parallelizing-your-builds-across-virtual-machines).
This requires having a much better test category definition
(https://issues.apache.org/jira/browse/SQOOP-3104) but it seems to be feasible
to cover most of our test cases.
Another benefit is that Travis supports starting Docker containers in the build
(https://docs.travis-ci.com/user/docker) this could help us setup our
Docker-based third party test infrastructure much easier.
I would like to continue experimenting with Travis, please let me know what you
think about the above and as always all the contributions are welcome.
Szabolcs
> Add .travis.yml
> ---
>
> Key: SQOOP-3289
> URL: https://issues.apache.org/jira/browse/SQOOP-3289
> Project: Sqoop
> Issue Type: Task
> Components: build
>Affects Versions: 1.4.7
>Reporter: Daniel Voros
>Assignee: Daniel Voros
>Priority: Minor
> Fix For: 1.5.0
>
>
> Adding a .travis.yml would enable running builds/tests on travis-ci.org.
> Currently if you wish to use Travis for testing your changes, you have to
> manually add a .travis.yml to your branch. Having it committed to trunk would
> save us this extra step.
> I currently have an example
> [{{.travis.yml}}|https://github.com/dvoros/sqoop/blob/93a4c06c1a3da1fd5305c99e379484507797b3eb/.travis.yml]
> on my travis branch running unit tests for every commit and every pull
> request: https://travis-ci.org/dvoros/sqoop/builds
> Later we could add the build status to the project readme as well, see:
> https://github.com/dvoros/sqoop/tree/travis
> Also, an example of a pull request: https://github.com/dvoros/sqoop/pull/1
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SQOOP-3289) Add .travis.yml
[
https://issues.apache.org/jira/browse/SQOOP-3289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16377212#comment-16377212
]
Attila Szabo commented on SQOOP-3289:
-
Hi Daniel,
Though in general the ASF community is great, IMHO it does not make too much
sense to compare one project to the other. Especially a very busy active like
Spark with something quite mature as Sqoop.
Though I think my message was clear enough, it's up to you if you willing to
wait until the current builds.apache.org build pipeline will do the real job.
Just one comment on my side :
If we won't be able to make the life of the contributors ( and the committers)
easier, any efforts on this front could be in vain.
My 2 cents,
Attila
> Add .travis.yml
> ---
>
> Key: SQOOP-3289
> URL: https://issues.apache.org/jira/browse/SQOOP-3289
> Project: Sqoop
> Issue Type: Task
> Components: build
>Affects Versions: 1.4.7
>Reporter: Daniel Voros
>Assignee: Daniel Voros
>Priority: Minor
> Fix For: 1.5.0
>
>
> Adding a .travis.yml would enable running builds/tests on travis-ci.org.
> Currently if you wish to use Travis for testing your changes, you have to
> manually add a .travis.yml to your branch. Having it committed to trunk would
> save us this extra step.
> I currently have an example
> [{{.travis.yml}}|https://github.com/dvoros/sqoop/blob/93a4c06c1a3da1fd5305c99e379484507797b3eb/.travis.yml]
> on my travis branch running unit tests for every commit and every pull
> request: https://travis-ci.org/dvoros/sqoop/builds
> Later we could add the build status to the project readme as well, see:
> https://github.com/dvoros/sqoop/tree/travis
> Also, an example of a pull request: https://github.com/dvoros/sqoop/pull/1
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SQOOP-3289) Add .travis.yml
[
https://issues.apache.org/jira/browse/SQOOP-3289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16377022#comment-16377022
]
Daniel Voros commented on SQOOP-3289:
-
Thanks for your response [~maugli]. I definitely agree with you, we should
automate all tests (including thirdparty+manual integration tests) and static
analysis checks as part of a CI gate.
AFAIK ASF is pretty flexible in this matter. For example, Spark's running
checks on a 3rd party Jenkins on PR hooks, while Hive and Hadoop trigger jobs
in builds.apache.org Jenkins via Jira attached patches.
None of them do the CI via Travis tho.
[Hive|https://github.com/apache/hive/blob/master/.travis.yml#L45] and
[Spark|https://github.com/apache/spark/blob/master/.travis.yml#L46] have
.travis.ymls but they're not even running tests. I guess that's because of the
50 min limitation on travis-ci.org runs.
I think we should deal with Travis and CI gatekeeping as separate tasks, and
open a new Jira for the CI part. What do you think?
BTW, I've just found out that we're already running this job on Jira
attachments, but it seems to fail recently. (:
https://builds.apache.org/job/PreCommit-SQOOP-Build/
> Add .travis.yml
> ---
>
> Key: SQOOP-3289
> URL: https://issues.apache.org/jira/browse/SQOOP-3289
> Project: Sqoop
> Issue Type: Task
> Components: build
>Affects Versions: 1.4.7
>Reporter: Daniel Voros
>Assignee: Daniel Voros
>Priority: Minor
> Fix For: 1.5.0
>
>
> Adding a .travis.yml would enable running builds/tests on travis-ci.org.
> Currently if you wish to use Travis for testing your changes, you have to
> manually add a .travis.yml to your branch. Having it committed to trunk would
> save us this extra step.
> I currently have an example
> [{{.travis.yml}}|https://github.com/dvoros/sqoop/blob/93a4c06c1a3da1fd5305c99e379484507797b3eb/.travis.yml]
> on my travis branch running unit tests for every commit and every pull
> request: https://travis-ci.org/dvoros/sqoop/builds
> Later we could add the build status to the project readme as well, see:
> https://github.com/dvoros/sqoop/tree/travis
> Also, an example of a pull request: https://github.com/dvoros/sqoop/pull/1
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SQOOP-3289) Add .travis.yml
[
https://issues.apache.org/jira/browse/SQOOP-3289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375050#comment-16375050
]
Attila Szabo commented on SQOOP-3289:
-
Hey [~dvoros],
I would love the idea to have to finally have a working and (apache toolchain)
independent CI/CD system.
Though if don't mind I'd like to aim for something more ambitious.
What do you think::
Would it be possible to setup travis in a way to execute automatically unit and
integration and 3rd test for trunk after every commit?
The reason why I'm asking is the following:
I do understand that for developers who prefer the Github fork way it would be
much easier to execute the unit tests with Travis compared to local one,
although this solution would barely differ from the currently existing
[https://builds.apache.org/job/Sqoop-hadoop200/] solution, and IMHO we
definitely NEED a CI system where ALL of the tests are evaluated after every
commit. I've been trying to get in contact with the responsible ppl to make
changes in [https://builds.apache.org/job/Sqoop-hadoop200/] though I did not
make too big achievements sadly.
Thats why I'm asking:
What about to aim for running every tests in travis?
Thanks,
Attila
> Add .travis.yml
> ---
>
> Key: SQOOP-3289
> URL: https://issues.apache.org/jira/browse/SQOOP-3289
> Project: Sqoop
> Issue Type: Task
> Components: build
>Affects Versions: 1.4.7
>Reporter: Daniel Voros
>Assignee: Daniel Voros
>Priority: Minor
> Fix For: 1.5.0
>
>
> Adding a .travis.yml would enable running builds/tests on travis-ci.org.
> Currently if you wish to use Travis for testing your changes, you have to
> manually add a .travis.yml to your branch. Having it committed to trunk would
> save us this extra step.
> I currently have an example
> [{{.travis.yml}}|https://github.com/dvoros/sqoop/blob/93a4c06c1a3da1fd5305c99e379484507797b3eb/.travis.yml]
> on my travis branch running unit tests for every commit and every pull
> request: https://travis-ci.org/dvoros/sqoop/builds
> Later we could add the build status to the project readme as well, see:
> https://github.com/dvoros/sqoop/tree/travis
> Also, an example of a pull request: https://github.com/dvoros/sqoop/pull/1
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SQOOP-3289) Add .travis.yml
[
https://issues.apache.org/jira/browse/SQOOP-3289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374368#comment-16374368
]
Daniel Voros commented on SQOOP-3289:
-
Anyone reading this, please drop a note and let me know what you think! I've
also attached the review board link, if you wish to comment on a specific part
or the file.
> Add .travis.yml
> ---
>
> Key: SQOOP-3289
> URL: https://issues.apache.org/jira/browse/SQOOP-3289
> Project: Sqoop
> Issue Type: Task
> Components: build
>Affects Versions: 1.4.7
>Reporter: Daniel Voros
>Assignee: Daniel Voros
>Priority: Minor
> Fix For: 1.4.7
>
>
> Adding a .travis.yml would enable running builds/tests on travis-ci.org.
> Currently if you wish to use Travis for testing your changes, you have to
> manually add a .travis.yml to your branch. Having it committed to trunk would
> save us this extra step.
> I currently have an example
> [{{.travis.yml}}|https://github.com/dvoros/sqoop/blob/93a4c06c1a3da1fd5305c99e379484507797b3eb/.travis.yml]
> on my travis branch running unit tests for every commit and every pull
> request: https://travis-ci.org/dvoros/sqoop/builds
> Later we could add the build status to the project readme as well, see:
> https://github.com/dvoros/sqoop/tree/travis
> Also, an example of a pull request: https://github.com/dvoros/sqoop/pull/1
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
