Re: Review Request 44489: SQOOP-2876: Sqoop2: Document TLS support

2016-03-08 Thread Jarek Cecho 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44489/#review122529
---



I've reviewed only the doc changes, the rest is being reviewed as part of 
SQOOP-2844 :)


docs/src/site/sphinx/security/Encryption.rst (lines 17 - 19)


There will be multiple Encryption points that we will have to eventually 
cover. Would it make sense to rename this section to be clear that it's only 
for the REST interface?



docs/src/site/sphinx/security/Encryption.rst (lines 28 - 29)


Can you please make this a real link and hide the URL from the generated 
text?

Here is an example of whow is link made in index.rst page:

Sqoop is licensed under `Apache Software License v2 
`_.



docs/src/site/sphinx/security/Encryption.rst (line 35)


Please enclose the filename in ``.



docs/src/site/sphinx/security/Encryption.rst (line 43)


Please make this proper link.



docs/src/site/sphinx/security/Encryption.rst (lines 80 - 82)


Please enclose all file names in ``.


ve

- Jarek Cecho


On March 8, 2016, 1:05 a.m., Abraham Fine wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44489/
> ---
> 
> (Updated March 8, 2016, 1:05 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-2876
> https://issues.apache.org/jira/browse/SQOOP-2876
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> ---
> 
> SQOOP-2876: Sqoop2: Document TLS support
> 
> 
> Diffs
> -
> 
>   common/src/main/java/org/apache/sqoop/utils/ProcessUtils.java PRE-CREATION 
>   docs/src/site/sphinx/security/Encryption.rst PRE-CREATION 
>   docs/src/site/sphinx/security/SecurityGuideOnSqoop2.rst 
> 7194d3bb72f58a952cc9250a372b823412afe0cd 
>   server/src/main/java/org/apache/sqoop/server/SqoopJettyServer.java 
> 4696a8764420075bb6f7659b41f9fe81e59f7d8a 
>   shell/src/main/java/org/apache/sqoop/shell/SetCommand.java 
> 3feaac3061a8e6008ef021dff8022ea79a2c2ba7 
>   shell/src/main/java/org/apache/sqoop/shell/SetServerFunction.java 
> e430f9d13c8d6f7b637c923c3609e072582290b8 
>   shell/src/main/java/org/apache/sqoop/shell/SetTruststoreFunction.java 
> PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/ShellEnvironment.java 
> 80ac935e3992c1c5e977a6d06abb6f049ba7d423 
>   shell/src/main/java/org/apache/sqoop/shell/core/Constants.java 
> 8af53f21cb3a8a3555ca25fc65e2b6c5dfca3a2c 
>   shell/src/main/resources/shell-resource.properties 
> 630c31d77a0a96525ef0f3a8ad20b64b5bb24c72 
> 
> Diff: https://reviews.apache.org/r/44489/diff/
> 
> 
> Testing
> ---
> 
> n/a
> 
> 
> Thanks,
> 
> Abraham Fine
> 
>

Re: Review Request 44489: SQOOP-2876: Sqoop2: Document TLS support

2016-03-08 Thread Abraham Fine 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44489/
---

(Updated March 8, 2016, 6:40 p.m.)


Review request for Sqoop.


Bugs: SQOOP-2876
https://issues.apache.org/jira/browse/SQOOP-2876


Repository: sqoop-sqoop2


Description
---

SQOOP-2876: Sqoop2: Document TLS support


Diffs (updated)
-

  common/src/main/java/org/apache/sqoop/utils/ProcessUtils.java PRE-CREATION 
  docs/src/site/sphinx/security/Encryption.rst PRE-CREATION 
  docs/src/site/sphinx/security/SecurityGuideOnSqoop2.rst 
7194d3bb72f58a952cc9250a372b823412afe0cd 
  server/src/main/java/org/apache/sqoop/server/SqoopJettyServer.java 
4696a8764420075bb6f7659b41f9fe81e59f7d8a 
  shell/src/main/java/org/apache/sqoop/shell/SetCommand.java 
3feaac3061a8e6008ef021dff8022ea79a2c2ba7 
  shell/src/main/java/org/apache/sqoop/shell/SetServerFunction.java 
e430f9d13c8d6f7b637c923c3609e072582290b8 
  shell/src/main/java/org/apache/sqoop/shell/SetTruststoreFunction.java 
PRE-CREATION 
  shell/src/main/java/org/apache/sqoop/shell/ShellEnvironment.java 
80ac935e3992c1c5e977a6d06abb6f049ba7d423 
  shell/src/main/java/org/apache/sqoop/shell/core/Constants.java 
8af53f21cb3a8a3555ca25fc65e2b6c5dfca3a2c 
  shell/src/main/resources/shell-resource.properties 
630c31d77a0a96525ef0f3a8ad20b64b5bb24c72 

Diff: https://reviews.apache.org/r/44489/diff/


Testing
---

n/a


Thanks,

Abraham Fine

Re: Review Request 44489: SQOOP-2876: Sqoop2: Document TLS support

2016-03-08 Thread Abraham Fine 


> On March 8, 2016, 3:58 p.m., Jarek Cecho wrote:
> > docs/src/site/sphinx/security/Encryption.rst, lines 17-19
> > 
> >
> > There will be multiple Encryption points that we will have to 
> > eventually cover. Would it make sense to rename this section to be clear 
> > that it's only for the REST interface?

i think we can do that when we add them


- Abraham


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44489/#review122529
---


On March 8, 2016, 1:05 a.m., Abraham Fine wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44489/
> ---
> 
> (Updated March 8, 2016, 1:05 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-2876
> https://issues.apache.org/jira/browse/SQOOP-2876
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> ---
> 
> SQOOP-2876: Sqoop2: Document TLS support
> 
> 
> Diffs
> -
> 
>   common/src/main/java/org/apache/sqoop/utils/ProcessUtils.java PRE-CREATION 
>   docs/src/site/sphinx/security/Encryption.rst PRE-CREATION 
>   docs/src/site/sphinx/security/SecurityGuideOnSqoop2.rst 
> 7194d3bb72f58a952cc9250a372b823412afe0cd 
>   server/src/main/java/org/apache/sqoop/server/SqoopJettyServer.java 
> 4696a8764420075bb6f7659b41f9fe81e59f7d8a 
>   shell/src/main/java/org/apache/sqoop/shell/SetCommand.java 
> 3feaac3061a8e6008ef021dff8022ea79a2c2ba7 
>   shell/src/main/java/org/apache/sqoop/shell/SetServerFunction.java 
> e430f9d13c8d6f7b637c923c3609e072582290b8 
>   shell/src/main/java/org/apache/sqoop/shell/SetTruststoreFunction.java 
> PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/ShellEnvironment.java 
> 80ac935e3992c1c5e977a6d06abb6f049ba7d423 
>   shell/src/main/java/org/apache/sqoop/shell/core/Constants.java 
> 8af53f21cb3a8a3555ca25fc65e2b6c5dfca3a2c 
>   shell/src/main/resources/shell-resource.properties 
> 630c31d77a0a96525ef0f3a8ad20b64b5bb24c72 
> 
> Diff: https://reviews.apache.org/r/44489/diff/
> 
> 
> Testing
> ---
> 
> n/a
> 
> 
> Thanks,
> 
> Abraham Fine
> 
>

Re: Review Request 44489: SQOOP-2876: Sqoop2: Document TLS support

2016-03-08 Thread Abraham Fine 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44489/
---

(Updated March 8, 2016, 8:44 p.m.)


Review request for Sqoop.


Bugs: SQOOP-2876
https://issues.apache.org/jira/browse/SQOOP-2876


Repository: sqoop-sqoop2


Description
---

SQOOP-2876: Sqoop2: Document TLS support


Diffs (updated)
-

  docs/src/site/sphinx/security/Encryption.rst PRE-CREATION 
  docs/src/site/sphinx/security/SecurityGuideOnSqoop2.rst 
7194d3bb72f58a952cc9250a372b823412afe0cd 

Diff: https://reviews.apache.org/r/44489/diff/


Testing
---

n/a


Thanks,

Abraham Fine

Re: Review Request 44489: SQOOP-2876: Sqoop2: Document TLS support

2016-03-08 Thread Jarek Cecho 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44489/#review122604
---


Ship it!




Ship It!

- Jarek Cecho


On March 8, 2016, 8:44 p.m., Abraham Fine wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44489/
> ---
> 
> (Updated March 8, 2016, 8:44 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-2876
> https://issues.apache.org/jira/browse/SQOOP-2876
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> ---
> 
> SQOOP-2876: Sqoop2: Document TLS support
> 
> 
> Diffs
> -
> 
>   docs/src/site/sphinx/security/Encryption.rst PRE-CREATION 
>   docs/src/site/sphinx/security/SecurityGuideOnSqoop2.rst 
> 7194d3bb72f58a952cc9250a372b823412afe0cd 
> 
> Diff: https://reviews.apache.org/r/44489/diff/
> 
> 
> Testing
> ---
> 
> n/a
> 
> 
> Thanks,
> 
> Abraham Fine
> 
>

Re: Review Request 44489: SQOOP-2876: Sqoop2: Document TLS support

2016-03-08 Thread Jarek Cecho 


> On March 8, 2016, 3:58 p.m., Jarek Cecho wrote:
> > docs/src/site/sphinx/security/Encryption.rst, lines 17-19
> > 
> >
> > There will be multiple Encryption points that we will have to 
> > eventually cover. Would it make sense to rename this section to be clear 
> > that it's only for the REST interface?
> 
> Abraham Fine wrote:
> i think we can do that when we add them

Fine with me.


- Jarek


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44489/#review122529
---


On March 8, 2016, 8:44 p.m., Abraham Fine wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44489/
> ---
> 
> (Updated March 8, 2016, 8:44 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-2876
> https://issues.apache.org/jira/browse/SQOOP-2876
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> ---
> 
> SQOOP-2876: Sqoop2: Document TLS support
> 
> 
> Diffs
> -
> 
>   docs/src/site/sphinx/security/Encryption.rst PRE-CREATION 
>   docs/src/site/sphinx/security/SecurityGuideOnSqoop2.rst 
> 7194d3bb72f58a952cc9250a372b823412afe0cd 
> 
> Diff: https://reviews.apache.org/r/44489/diff/
> 
> 
> Testing
> ---
> 
> n/a
> 
> 
> Thanks,
> 
> Abraham Fine
> 
>