[GitHub] storm pull request: [STORM-537] A worker reconnects infinitely to ...

2014-11-06 Thread Sergeant007
Github user Sergeant007 commented on the pull request:

https://github.com/apache/storm/pull/304#issuecomment-61949580
  
@harshach 
 Is there anything changed in 
storm-core/test/clj/backtype/storm/messaging/netty_unit_test.clj

Since I've removed overcomplicated tests, as @clockfly asked me, there are 
no changes at all except of automatically removed by IDE extra whitespaces at 
the end of a few lines. I do believe this change is also helpful, but if you 
ask me, I'll completely revert the whole file.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Fw: Who is the contact point for the Storm Topology Visualization ?

2014-11-06 Thread Itai Frenkel
Resending anyone ?


From: Itai Frenkel i...@forter.com
Sent: Tuesday, November 4, 2014 2:15 PM
To: dev@storm.apache.org
Subject: Who is the contact point for the Storm Topology Visualization ?

Hi,


We are dedicating resources (half time intern) to write our own storm topology 
visualization (graph) needed for internal use.

I would like to reach out to the code owner of the existing ui interactive 
graph, to see if we can align our efforts with other Storm community efforts 
(or at least align JS technologies).

Who is the contact person I'm looking for?


Thanks,

Itai


[jira] [Commented] (STORM-512) KafkaBolt doesn't handle ticks properly

2014-11-06 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/STORM-512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14200135#comment-14200135
 ] 

ASF GitHub Bot commented on STORM-512:
--

Github user nielsbasjes commented on the pull request:

https://github.com/apache/storm/pull/275#issuecomment-61971101
  
What else can/should I do to get this fix validated and committed?


 KafkaBolt doesn't handle ticks properly
 ---

 Key: STORM-512
 URL: https://issues.apache.org/jira/browse/STORM-512
 Project: Apache Storm
  Issue Type: Bug
Reporter: Niels Basjes

 I found that when using the KafkaBolt the tick tuples are not handled 
 properly. They should be ignored and the reality is that they are not.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] storm pull request: STORM-487 Let bin/storm compatible with Window...

2014-11-06 Thread revans2
Github user revans2 commented on the pull request:

https://github.com/apache/storm/pull/280#issuecomment-61983313
  
Sorry it took me so long to respond.  The changes look good to me, but I 
don't have a windows box so I cannot test the windows support, I am +1 on the 
changes so far, but would like to see someone test this on windows too.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (STORM-487) Remove storm.cmd, no need to duplicate work python runs on windows too.

2014-11-06 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/STORM-487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14200187#comment-14200187
 ] 

ASF GitHub Bot commented on STORM-487:
--

Github user revans2 commented on the pull request:

https://github.com/apache/storm/pull/280#issuecomment-61983313
  
Sorry it took me so long to respond.  The changes look good to me, but I 
don't have a windows box so I cannot test the windows support, I am +1 on the 
changes so far, but would like to see someone test this on windows too.


 Remove storm.cmd, no need to duplicate work python runs on windows too.
 ---

 Key: STORM-487
 URL: https://issues.apache.org/jira/browse/STORM-487
 Project: Apache Storm
  Issue Type: Improvement
Reporter: Robert Joseph Evans
  Labels: newbie





--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] storm pull request: [STORM-533] Added in client and server IConnec...

2014-11-06 Thread revans2
Github user revans2 commented on the pull request:

https://github.com/apache/storm/pull/302#issuecomment-61989690
  
The metrics system is very generic, and not that complex.  Essentially it 
sets up a timer that will periodically call getValueAndReset on an instance of 
IMetric.  These values can be anything and are sent to an instance of 
IMetricsConsumer that is residing in a bolt.  It is up to the IMetricsConsumer 
to decide what to do with Object the the IMetric created.

I agree that having an API closer to codahale would be good, but that is a 
much bigger change.  I would like to see that in a separate JIRA/pull request.  
The big difference between the two approaches is that the storm metrics 
associate the value with an individual bolt or spout instance.  codahale and 
most other metrics systems I have seen, associate the metrics with an arbitrary 
name.  We would need a way to bridge that gap in a clean/efficient way.  I 
would also like to see a lot of metrics added into the daemon processes.  
Nimbus, Supervisor, and DRPC all need good monitoring.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (STORM-533) Add metrics collection for IConnection

2014-11-06 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/STORM-533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14200252#comment-14200252
 ] 

ASF GitHub Bot commented on STORM-533:
--

Github user revans2 commented on the pull request:

https://github.com/apache/storm/pull/302#issuecomment-61989690
  
The metrics system is very generic, and not that complex.  Essentially it 
sets up a timer that will periodically call getValueAndReset on an instance of 
IMetric.  These values can be anything and are sent to an instance of 
IMetricsConsumer that is residing in a bolt.  It is up to the IMetricsConsumer 
to decide what to do with Object the the IMetric created.

I agree that having an API closer to codahale would be good, but that is a 
much bigger change.  I would like to see that in a separate JIRA/pull request.  
The big difference between the two approaches is that the storm metrics 
associate the value with an individual bolt or spout instance.  codahale and 
most other metrics systems I have seen, associate the metrics with an arbitrary 
name.  We would need a way to bridge that gap in a clean/efficient way.  I 
would also like to see a lot of metrics added into the daemon processes.  
Nimbus, Supervisor, and DRPC all need good monitoring.


 Add metrics collection for IConnection
 --

 Key: STORM-533
 URL: https://issues.apache.org/jira/browse/STORM-533
 Project: Apache Storm
  Issue Type: Improvement
Reporter: Robert Joseph Evans
Assignee: Robert Joseph Evans

 It would really be great to get some metrics from an IConnection that are 
 then sent to the metrics consumer. 
 We have seen issues in the past where a fire wall rule is mis-configured and 
 one host is unable to talk to another host.  If we had some metrics about how 
 many reconnection attempts are being made by the client to a given host we 
 could easily diagnose this.
 There are other metrics that would be nice to know too, like how many 
 bytes/tuples are being sent between different hosts. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (STORM-533) Add metrics collection for IConnection

2014-11-06 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/STORM-533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14200254#comment-14200254
 ] 

ASF GitHub Bot commented on STORM-533:
--

Github user revans2 commented on the pull request:

https://github.com/apache/storm/pull/302#issuecomment-61990146
  
@clockfly what specifically about the status of the connection do you want?


 Add metrics collection for IConnection
 --

 Key: STORM-533
 URL: https://issues.apache.org/jira/browse/STORM-533
 Project: Apache Storm
  Issue Type: Improvement
Reporter: Robert Joseph Evans
Assignee: Robert Joseph Evans

 It would really be great to get some metrics from an IConnection that are 
 then sent to the metrics consumer. 
 We have seen issues in the past where a fire wall rule is mis-configured and 
 one host is unable to talk to another host.  If we had some metrics about how 
 many reconnection attempts are being made by the client to a given host we 
 could easily diagnose this.
 There are other metrics that would be nice to know too, like how many 
 bytes/tuples are being sent between different hosts. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


topology.enable.message.timeouts does nothing

2014-11-06 Thread Sean Allen
Hi all,

It would appear that topology.enable.message.timeouts settings isn't
being used anymore.
I discovered this when I used this following in my topology but has
timeouts after 30 seconds:

config.put(topology.enable.message.timeouts, Boolean.FALSE)

A search of the source revels it isn't being used. I assume this was in
error? If yes, I can open a ticket in jira.

➜  apache-storm-0.9.2-incubating ag topology.enable.message.timeouts
conf/defaults.yaml
122:topology.enable.message.timeouts: true

storm-core/src/jvm/backtype/storm/Config.java
512:public static final String TOPOLOGY_ENABLE_MESSAGE_TIMEOUTS =
topology.enable.message.timeouts;

-Sean-


Re: topology.enable.message.timeouts does nothing

2014-11-06 Thread Sean Allen
Sorry forgot to include another relevant bit of source:

➜  apache-storm-0.9.2-incubating ag topology.enable.message.timeouts
conf/defaults.yaml
122:topology.enable.message.timeouts: true

storm-core/src/jvm/backtype/storm/Config.java
512:public static final String TOPOLOGY_ENABLE_MESSAGE_TIMEOUTS =
topology.enable.message.timeouts;

➜  apache-storm-0.9.2-incubating ag TOPOLOGY_ENABLE_MESSAGE_TIMEOUTS
storm-core/src/jvm/backtype/storm/Config.java
512:public static final String TOPOLOGY_ENABLE_MESSAGE_TIMEOUTS =
topology.enable.message.timeouts;
513:public static final Object TOPOLOGY_ENABLE_MESSAGE_TIMEOUTS_SCHEMA
= Boolean.class;

On Thu, Nov 6, 2014 at 12:02 PM, Sean Allen s...@monkeysnatchbanana.com
wrote:

 Hi all,

 It would appear that topology.enable.message.timeouts settings isn't
 being used anymore.
 I discovered this when I used this following in my topology but has
 timeouts after 30 seconds:

 config.put(topology.enable.message.timeouts, Boolean.FALSE)

 A search of the source revels it isn't being used. I assume this was in
 error? If yes, I can open a ticket in jira.

 ➜  apache-storm-0.9.2-incubating ag topology.enable.message.timeouts
 conf/defaults.yaml
 122:topology.enable.message.timeouts: true

 storm-core/src/jvm/backtype/storm/Config.java
 512:public static final String TOPOLOGY_ENABLE_MESSAGE_TIMEOUTS =
 topology.enable.message.timeouts;

 -Sean-




-- 

Ce n'est pas une signature


[GitHub] storm pull request: STORM-492 with reverting previous merge

2014-11-06 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/storm/pull/308


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (STORM-492) Test timeout should be configurable

2014-11-06 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/STORM-492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14200505#comment-14200505
 ] 

ASF GitHub Bot commented on STORM-492:
--

Github user asfgit closed the pull request at:

https://github.com/apache/storm/pull/308


 Test timeout should be configurable
 ---

 Key: STORM-492
 URL: https://issues.apache.org/jira/browse/STORM-492
 Project: Apache Storm
  Issue Type: Bug
Reporter: Devika Nair
Assignee: Jungtaek Lim
  Labels: newbie
 Fix For: 0.9.3-rc2


 Test timeout is hard coded to 5000ms in 
 https://github.com/apache/incubator-storm/blob/master/storm-core/src/clj/backtype/storm/testing.clj.
  Provide a way to override this value in order to handle longer running tests.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: topology.enable.message.timeouts does nothing

2014-11-06 Thread Derek Dagit
Hm, I see the same thing.  Yes, please open a JIRA.
Thanks for reaching out about it,
 -- 
Derek
 

 On Thursday, November 6, 2014 11:11 AM, Sean Allen 
s...@monkeysnatchbanana.com wrote:
   

 Sorry forgot to include another relevant bit of source:

➜  apache-storm-0.9.2-incubating ag topology.enable.message.timeouts
conf/defaults.yaml
122:topology.enable.message.timeouts: true

storm-core/src/jvm/backtype/storm/Config.java
512:    public static final String TOPOLOGY_ENABLE_MESSAGE_TIMEOUTS =
topology.enable.message.timeouts;

➜  apache-storm-0.9.2-incubating ag TOPOLOGY_ENABLE_MESSAGE_TIMEOUTS
storm-core/src/jvm/backtype/storm/Config.java
512:    public static final String TOPOLOGY_ENABLE_MESSAGE_TIMEOUTS =
topology.enable.message.timeouts;
513:    public static final Object TOPOLOGY_ENABLE_MESSAGE_TIMEOUTS_SCHEMA
= Boolean.class;

On Thu, Nov 6, 2014 at 12:02 PM, Sean Allen s...@monkeysnatchbanana.com
wrote:

 Hi all,

 It would appear that topology.enable.message.timeouts settings isn't
 being used anymore.
 I discovered this when I used this following in my topology but has
 timeouts after 30 seconds:

    config.put(topology.enable.message.timeouts, Boolean.FALSE)

 A search of the source revels it isn't being used. I assume this was in
 error? If yes, I can open a ticket in jira.

 ➜  apache-storm-0.9.2-incubating ag topology.enable.message.timeouts
 conf/defaults.yaml
 122:topology.enable.message.timeouts: true

 storm-core/src/jvm/backtype/storm/Config.java
 512:    public static final String TOPOLOGY_ENABLE_MESSAGE_TIMEOUTS =
 topology.enable.message.timeouts;

 -Sean-




-- 

Ce n'est pas une signature

   

[jira] [Created] (STORM-549) topology.enable.message.timeouts does nothing

2014-11-06 Thread Sean T Allen (JIRA)
Sean T Allen created STORM-549:
--

 Summary: topology.enable.message.timeouts does nothing
 Key: STORM-549
 URL: https://issues.apache.org/jira/browse/STORM-549
 Project: Apache Storm
  Issue Type: Bug
Affects Versions: 0.9.2-incubating, 0.9.1-incubating
Reporter: Sean T Allen


The configuration option, added on 0.8.0 was never implemented:

➜  apache-storm-0.9.2-incubating ag topology.enable.message.timeouts
conf/defaults.yaml
122:topology.enable.message.timeouts: true

storm-core/src/jvm/backtype/storm/Config.java
512:public static final String TOPOLOGY_ENABLE_MESSAGE_TIMEOUTS = 
topology.enable.message.timeouts;

➜  apache-storm-0.9.2-incubating ag TOPOLOGY_ENABLE_MESSAGE_TIMEOUTS
storm-core/src/jvm/backtype/storm/Config.java
512:public static final String TOPOLOGY_ENABLE_MESSAGE_TIMEOUTS = 
topology.enable.message.timeouts;
513:public static final Object TOPOLOGY_ENABLE_MESSAGE_TIMEOUTS_SCHEMA = 
Boolean.class;



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: topology.enable.message.timeouts does nothing

2014-11-06 Thread Sean Allen
Done.

On Thu, Nov 6, 2014 at 1:01 PM, Derek Dagit der...@yahoo-inc.com.invalid
wrote:

 Hm, I see the same thing.  Yes, please open a JIRA.
 Thanks for reaching out about it,
  --
 Derek


  On Thursday, November 6, 2014 11:11 AM, Sean Allen 
 s...@monkeysnatchbanana.com wrote:


  Sorry forgot to include another relevant bit of source:

 ➜  apache-storm-0.9.2-incubating ag topology.enable.message.timeouts
 conf/defaults.yaml
 122:topology.enable.message.timeouts: true

 storm-core/src/jvm/backtype/storm/Config.java
 512:public static final String TOPOLOGY_ENABLE_MESSAGE_TIMEOUTS =
 topology.enable.message.timeouts;

 ➜  apache-storm-0.9.2-incubating ag TOPOLOGY_ENABLE_MESSAGE_TIMEOUTS
 storm-core/src/jvm/backtype/storm/Config.java
 512:public static final String TOPOLOGY_ENABLE_MESSAGE_TIMEOUTS =
 topology.enable.message.timeouts;
 513:public static final Object TOPOLOGY_ENABLE_MESSAGE_TIMEOUTS_SCHEMA
 = Boolean.class;

 On Thu, Nov 6, 2014 at 12:02 PM, Sean Allen s...@monkeysnatchbanana.com
 wrote:

  Hi all,
 
  It would appear that topology.enable.message.timeouts settings isn't
  being used anymore.
  I discovered this when I used this following in my topology but has
  timeouts after 30 seconds:
 
 config.put(topology.enable.message.timeouts, Boolean.FALSE)
 
  A search of the source revels it isn't being used. I assume this was in
  error? If yes, I can open a ticket in jira.
 
  ➜  apache-storm-0.9.2-incubating ag topology.enable.message.timeouts
  conf/defaults.yaml
  122:topology.enable.message.timeouts: true
 
  storm-core/src/jvm/backtype/storm/Config.java
  512:public static final String TOPOLOGY_ENABLE_MESSAGE_TIMEOUTS =
  topology.enable.message.timeouts;
 
  -Sean-
 



 --

 Ce n'est pas une signature






-- 

Ce n'est pas une signature


[jira] [Commented] (STORM-549) topology.enable.message.timeouts does nothing

2014-11-06 Thread Jungtaek Lim (JIRA)

[ 
https://issues.apache.org/jira/browse/STORM-549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14201340#comment-14201340
 ] 

Jungtaek Lim commented on STORM-549:


(Warning: Need citation)

I'm newbie to Storm Project, but I can find usage from setup-ticks! in 
executor.clj.

{code}
(defn setup-ticks! [worker executor-data]
  (let [storm-conf (:storm-conf executor-data)
tick-time-secs (storm-conf TOPOLOGY-TICK-TUPLE-FREQ-SECS)
receive-queue (:receive-queue executor-data)
context (:worker-context executor-data)]
(when tick-time-secs
  (if (or (system-id? (:component-id executor-data))
  (and (not (storm-conf TOPOLOGY-ENABLE-MESSAGE-TIMEOUTS))
   (= :spout (:type executor-data
(log-message Timeouts disabled for executor  (:component-id 
executor-data) : (:executor-id executor-data))
(schedule-recurring
  (:user-timer worker)
  tick-time-secs
  tick-time-secs
  (fn []
(disruptor/publish
  receive-queue
  [[nil (TupleImpl. context [tick-time-secs] 
Constants/SYSTEM_TASK_ID Constants/SYSTEM_TICK_STREAM_ID)]]
  )))
{code}

If worker is Spout and TOPOLOGY-ENABLE-MESSAGE-TIMEOUTS is disabled, it doesn't 
send tick tuple which means it's time to check tuples timeout.

tl;dr. It seems that it's working properly, though I've not tested yet.

 topology.enable.message.timeouts does nothing
 ---

 Key: STORM-549
 URL: https://issues.apache.org/jira/browse/STORM-549
 Project: Apache Storm
  Issue Type: Bug
Affects Versions: 0.9.2-incubating, 0.9.1-incubating
Reporter: Sean T Allen

 The configuration option, added on 0.8.0 was never implemented:
 ➜  apache-storm-0.9.2-incubating ag topology.enable.message.timeouts
 conf/defaults.yaml
 122:topology.enable.message.timeouts: true
 storm-core/src/jvm/backtype/storm/Config.java
 512:public static final String TOPOLOGY_ENABLE_MESSAGE_TIMEOUTS = 
 topology.enable.message.timeouts;
 ➜  apache-storm-0.9.2-incubating ag TOPOLOGY_ENABLE_MESSAGE_TIMEOUTS
 storm-core/src/jvm/backtype/storm/Config.java
 512:public static final String TOPOLOGY_ENABLE_MESSAGE_TIMEOUTS = 
 topology.enable.message.timeouts;
 513:public static final Object TOPOLOGY_ENABLE_MESSAGE_TIMEOUTS_SCHEMA = 
 Boolean.class;



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (STORM-549) topology.enable.message.timeouts does nothing

2014-11-06 Thread Sean T Allen (JIRA)

[ 
https://issues.apache.org/jira/browse/STORM-549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14201416#comment-14201416
 ] 

Sean T Allen commented on STORM-549:


What branch is this on. I'm looking at latest as well as last couple incubating 
releases and not finding this.


 topology.enable.message.timeouts does nothing
 ---

 Key: STORM-549
 URL: https://issues.apache.org/jira/browse/STORM-549
 Project: Apache Storm
  Issue Type: Bug
Affects Versions: 0.9.2-incubating, 0.9.1-incubating
Reporter: Sean T Allen

 The configuration option, added on 0.8.0 was never implemented:
 ➜  apache-storm-0.9.2-incubating ag topology.enable.message.timeouts
 conf/defaults.yaml
 122:topology.enable.message.timeouts: true
 storm-core/src/jvm/backtype/storm/Config.java
 512:public static final String TOPOLOGY_ENABLE_MESSAGE_TIMEOUTS = 
 topology.enable.message.timeouts;
 ➜  apache-storm-0.9.2-incubating ag TOPOLOGY_ENABLE_MESSAGE_TIMEOUTS
 storm-core/src/jvm/backtype/storm/Config.java
 512:public static final String TOPOLOGY_ENABLE_MESSAGE_TIMEOUTS = 
 topology.enable.message.timeouts;
 513:public static final Object TOPOLOGY_ENABLE_MESSAGE_TIMEOUTS_SCHEMA = 
 Boolean.class;



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (STORM-549) topology.enable.message.timeouts does nothing

2014-11-06 Thread Sean T Allen (JIRA)

[ 
https://issues.apache.org/jira/browse/STORM-549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14201427#comment-14201427
 ] 

Sean T Allen commented on STORM-549:


I see the problem here.

In the clojure code the variable is

TOPOLOGY-ENABLE-MESSAGE-TIMEOUTS

and the java constant is

TOPOLOGY_ENABLE_MESSAGE_TIMEOUTS

should that be

(get storm-conf Config/TOPOLOGY_ENABLE_MESSAGE_TIMEOUTS)

?


 topology.enable.message.timeouts does nothing
 ---

 Key: STORM-549
 URL: https://issues.apache.org/jira/browse/STORM-549
 Project: Apache Storm
  Issue Type: Bug
Affects Versions: 0.9.2-incubating, 0.9.1-incubating
Reporter: Sean T Allen

 The configuration option, added on 0.8.0 was never implemented:
 ➜  apache-storm-0.9.2-incubating ag topology.enable.message.timeouts
 conf/defaults.yaml
 122:topology.enable.message.timeouts: true
 storm-core/src/jvm/backtype/storm/Config.java
 512:public static final String TOPOLOGY_ENABLE_MESSAGE_TIMEOUTS = 
 topology.enable.message.timeouts;
 ➜  apache-storm-0.9.2-incubating ag TOPOLOGY_ENABLE_MESSAGE_TIMEOUTS
 storm-core/src/jvm/backtype/storm/Config.java
 512:public static final String TOPOLOGY_ENABLE_MESSAGE_TIMEOUTS = 
 topology.enable.message.timeouts;
 513:public static final Object TOPOLOGY_ENABLE_MESSAGE_TIMEOUTS_SCHEMA = 
 Boolean.class;



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (STORM-549) topology.enable.message.timeouts does nothing

2014-11-06 Thread Jungtaek Lim (JIRA)

[ 
https://issues.apache.org/jira/browse/STORM-549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14201605#comment-14201605
 ] 

Jungtaek Lim commented on STORM-549:


I don't know Clojure (I'm studying it.) but you can find that more options 
already used with hyphen, not underscore.
setup-ticks! already uses storm-conf TOPOLOGY-TICK-TUPLE-FREQ-SECS, which is 
defined to TOPOLOGY_TICK_TUPLE_FREQ_SECS. 
It may be a Clojure interop rule with Java, or magic inside of Storm.

 topology.enable.message.timeouts does nothing
 ---

 Key: STORM-549
 URL: https://issues.apache.org/jira/browse/STORM-549
 Project: Apache Storm
  Issue Type: Bug
Affects Versions: 0.9.2-incubating, 0.9.1-incubating
Reporter: Sean T Allen

 The configuration option, added on 0.8.0 was never implemented:
 ➜  apache-storm-0.9.2-incubating ag topology.enable.message.timeouts
 conf/defaults.yaml
 122:topology.enable.message.timeouts: true
 storm-core/src/jvm/backtype/storm/Config.java
 512:public static final String TOPOLOGY_ENABLE_MESSAGE_TIMEOUTS = 
 topology.enable.message.timeouts;
 ➜  apache-storm-0.9.2-incubating ag TOPOLOGY_ENABLE_MESSAGE_TIMEOUTS
 storm-core/src/jvm/backtype/storm/Config.java
 512:public static final String TOPOLOGY_ENABLE_MESSAGE_TIMEOUTS = 
 topology.enable.message.timeouts;
 513:public static final Object TOPOLOGY_ENABLE_MESSAGE_TIMEOUTS_SCHEMA = 
 Boolean.class;



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (STORM-549) topology.enable.message.timeouts does nothing

2014-11-06 Thread Sean T Allen (JIRA)

[ 
https://issues.apache.org/jira/browse/STORM-549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14201729#comment-14201729
 ] 

Sean T Allen commented on STORM-549:


If it is actually getting correctly read and set, it isn't actually disabling 
timeouts.

Thats what got me looking into this.

 topology.enable.message.timeouts does nothing
 ---

 Key: STORM-549
 URL: https://issues.apache.org/jira/browse/STORM-549
 Project: Apache Storm
  Issue Type: Bug
Affects Versions: 0.9.2-incubating, 0.9.1-incubating
Reporter: Sean T Allen

 The configuration option, added on 0.8.0 was never implemented:
 ➜  apache-storm-0.9.2-incubating ag topology.enable.message.timeouts
 conf/defaults.yaml
 122:topology.enable.message.timeouts: true
 storm-core/src/jvm/backtype/storm/Config.java
 512:public static final String TOPOLOGY_ENABLE_MESSAGE_TIMEOUTS = 
 topology.enable.message.timeouts;
 ➜  apache-storm-0.9.2-incubating ag TOPOLOGY_ENABLE_MESSAGE_TIMEOUTS
 storm-core/src/jvm/backtype/storm/Config.java
 512:public static final String TOPOLOGY_ENABLE_MESSAGE_TIMEOUTS = 
 topology.enable.message.timeouts;
 513:public static final Object TOPOLOGY_ENABLE_MESSAGE_TIMEOUTS_SCHEMA = 
 Boolean.class;



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)