[GitHub] storm issue #2915: [STORM-3291]Worker can't run as the user who submitted th...
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2915 Could you help me to retrigger CI? ---
[GitHub] storm issue #2915: [STORM-3291]Worker can't run as the user who submitted th...
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2915 @revans2 Hi,is my revision consistent with your thoughts? And I also have a question,whether we can't use ResourceAwareScheduler if supervisor.run.worker.as.user is false? ---
[GitHub] storm issue #2915: [STORM-3291]Worker can't run as the user who submitted th...
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2915 @revans2 Thanks for your reply.I really want to launch worker as who submit it.I think TOPOLOGY_SUBMITTER_USER is for this,but this config doesn't work.I know your concernsï¼but is there any other way to launch worker as users? ---
[GitHub] storm issue #2915: [STORM-3291]Worker can't run as the user who submitted th...
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2915 @revans2 could you help me to review this PR? thanks ---
[GitHub] storm pull request #2915: [STORM-3291]Worker can't run as the user who submi...
GitHub user liu-zhaokun opened a pull request: https://github.com/apache/storm/pull/2915 [STORM-3291]Worker can't run as the user who submitted the topology [https://issues.apache.org/jira/browse/STORM-3291](https://issues.apache.org/jira/browse/STORM-3291) Without principal, worker can't be launched as the user who submitted the topology even we set "supervisor.run.worker.as.user" to true.Because the submitterUser will be overwrited by the user who launched nimbus.Even in ui,we can see the owner is the user who launch nimbus. You can merge this pull request into a Git repository by running: $ git pull https://github.com/liu-zhaokun/storm master1123 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/storm/pull/2915.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2915 commit 8f3b1e8f12c80ef6908696817671e3a4fe9757a3 Author: liuzhaokun Date: 2018-11-23T07:10:21Z [STORM-3291]Worker can't run as the user who submitted the topology ---
[GitHub] storm issue #2765: [STORM-3152]Storm has supported ipv6 but Troubleshooting....
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2765 @revans2 Thanks for your reply.I will try to modify the way to separate out a host from a port. ---
[GitHub] storm issue #2765: [STORM-3152]Storm has supported ipv6 but Troubleshooting....
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2765 @revans2 Thanks for your reply.I will try to modify the way to separate out a host from a port. ---
[GitHub] storm pull request #2765: [STORM-3152]Storm has supported ipv6 but Troublesh...
GitHub user liu-zhaokun opened a pull request: https://github.com/apache/storm/pull/2765 [STORM-3152]Storm has supported ipv6 but Troubleshooting.md didn't update [https://issues.apache.org/jira/browse/STORM-3152](https://issues.apache.org/jira/browse/STORM-3152) As storm's socket get inetaddress by java's InetAddress class,I think there is no difficulty to run Topology on ipv6.And I have test it on ipv6,all socket can be established on ipv6's ip. You can merge this pull request into a Git repository by running: $ git pull https://github.com/liu-zhaokun/storm master0714 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/storm/pull/2765.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2765 commit 6eef92bdbc918f45423b2d9bf402879e78ac4cc8 Author: liuzhaokun Date: 2018-07-14T06:49:20Z [STORM-3152]Storm has supported ipv6 but Troubleshooting.md didn't update ---
[GitHub] storm issue #2066: [STORM-2472] kafkaspout should work normally in kerberos ...
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2066 @aniketalhat You can look through my PRï¼and my intention was to export java.security.auth.login.config=the path to your keytab,and it works.You can try it. ---
[GitHub] storm issue #2365: [STORM-2773]If a drpcserver node in cluster is down,drpc ...
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2365 @revans2 Hi,revans! I guess you forgot this PR after a long time.I just want to know if this PR is available because I used to work hard to make it. Even if you think it is not good enough, I hope you can reply to me rather than ignore it. ---
[GitHub] storm issue #2600: [STORM-2997] Add logviewer ssl module in SECURITY.md
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2600 @HeartSaVioR Could you help me review this PR? ---
[GitHub] storm issue #2599: [STORM-2996] Inaccurate description about offset and kafk...
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2599 @HeartSaVioR Could you help me review this PR? ---
[GitHub] storm pull request #2601: [STORM-2998]Wrong className in LoggerFactory.getLo...
GitHub user liu-zhaokun opened a pull request: https://github.com/apache/storm/pull/2601 [STORM-2998]Wrong className in LoggerFactory.getLogger method [https://issues.apache.org/jira/browse/STORM-2998](https://issues.apache.org/jira/browse/STORM-2998) If we use LoggerFactory.getLogger method in a class,the most accurate approach is use this class as a parameter. You can merge this pull request into a Git repository by running: $ git pull https://github.com/liu-zhaokun/storm master031902 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/storm/pull/2601.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2601 commit e4c1b6117e77365741231825f806c419dc45d3a4 Author: liuzhaokun Date: 2018-03-19T08:46:56Z [STORM-2998]Wrong className in LoggerFactory.getLogger method ---
[GitHub] storm pull request #2600: [STORM-2997] Add logviewer ssl module in SECURITY....
GitHub user liu-zhaokun opened a pull request: https://github.com/apache/storm/pull/2600 [STORM-2997] Add logviewer ssl module in SECURITY.md [https://issues.apache.org/jira/browse/STORM-2997](https://issues.apache.org/jira/browse/STORM-2997) Add logviewer ssl module in SECURITY.md like UI and DRPC You can merge this pull request into a Git repository by running: $ git pull https://github.com/liu-zhaokun/storm master031901 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/storm/pull/2600.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2600 ---
[GitHub] storm pull request #2599: [STORM-2996] Inaccurate description about offset a...
GitHub user liu-zhaokun opened a pull request: https://github.com/apache/storm/pull/2599 [STORM-2996] Inaccurate description about offset and kafkaspout will make users confused [https://issues.apache.org/jira/browse/STORM-2996](https://issues.apache.org/jira/browse/STORM-2996) As you can see in the picture,we don't know which partition the offset belongs in first line,so I think we can log the partition information.And consumer.host is the same as host in Partition in second line,so I think we can remove it. You can merge this pull request into a Git repository by running: $ git pull https://github.com/liu-zhaokun/storm master0319 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/storm/pull/2599.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2599 commit 9cab44a420b3d98c2b337900e703247748c7c7cf Author: liuzhaokun Date: 2018-03-19T07:55:16Z [STORM-2996] Inaccurate description about offset and kafkaspout will make users confused ---
[GitHub] storm issue #2365: [STORM-2773]If a drpcserver node in cluster is down,drpc ...
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2365 Hi,@revans2,I'm not sure whether the ci's failure related to me.And I have add a retry to DRPCInvaction,could you help me to review it? ---
[GitHub] storm issue #2365: [STORM-2773]If a drpcserver node in cluster is down,drpc ...
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2365 @HeartSaVioR @revans2 Hi,are you available to help me review this PR? ---
[GitHub] storm issue #2365: [STORM-2773]If a drpcserver node in cluster is down,drpc ...
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2365 @HeartSaVioR Hi,are you available to help me review this PR? ---
[GitHub] storm issue #2365: [STORM-2773]If a drpcserver node in cluster is down,drpc ...
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2365 Hi,@revans2,I'm not sure whether the ci's failure related to me.And I have add a retry to DRPCInvaction,could you help me to review it? ---
[GitHub] storm issue #2365: [STORM-2773]If a drpcserver node in cluster is down,drpc ...
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2365 @revans2 Do you mean there no need to reconnect when I create a DRPCInvocationClient instance? ---
[GitHub] storm issue #2365: [STORM-2773]If a drpcserver node in cluster is down,drpc ...
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2365 @revans2 I try to fix this bug follow your advice,but I found the original bug occurred in line 41 [https://github.com/liu-zhaokun/storm/blob/d92f1a9c8d7442d4959fec57813fc5de42b179a9/storm-client/src/jvm/org/apache/storm/drpc/DRPCInvocationsClient.java#L41](https://github.com/liu-zhaokun/storm/blob/d92f1a9c8d7442d4959fec57813fc5de42b179a9/storm-client/src/jvm/org/apache/storm/drpc/DRPCInvocationsClient.java#L41) drpcinvocationclient wan't to establish connection with the thrift server.And I am not sure we should fix this bug in line 41.Could you give me some suggestion?Thanks. ---
[GitHub] storm issue #2365: [STORM-2773]If a drpcserver node in cluster is down,drpc ...
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2365 In the long term, it's difficult for us to improve drpc. But would you like to help merge this PR? ---
[GitHub] storm issue #2365: [STORM-2773]If a drpcserver node in cluster is down,drpc ...
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2365 @revans2 I have fix the checkstyle errors and log the exception.Could you help me review this PR again? ---
[GitHub] storm pull request #2365: [STORM-2773]If a drpcserver node in cluster is dow...
GitHub user liu-zhaokun opened a pull request: https://github.com/apache/storm/pull/2365 [STORM-2773]If a drpcserver node in cluster is down,drpc cluster won't work if we don't modify the drpc.server configuration and restart the cluster [https://issues.apache.org/jira/browse/STORM-2773](https://issues.apache.org/jira/browse/STORM-2773) There is a cluster which includes three nodes named storm1,storm2,storm3.And there is a drpcserver in every node,a worker which has been started on strom1.When strom1 was down with hardware failure,my drpc topology won't work,when I send request from drpcclient. As storm1 was down,so the worker will be restarted on another node,but it can't Initialize successfully because the call method of Adder will throw a RuntimeException,when drpcspout try to connect to storm1,so the worker will restart again. In conclusion,If a drpcserver node in cluster is down,drpc cluster won't work until we modify the drpc.server configuration and restart the cluster,but in production,it's difficult to restart whole cluster. So I think we should catch the RuntimeException and log it,and the drpc topology will work normally. You can merge this pull request into a Git repository by running: $ git pull https://github.com/liu-zhaokun/storm master1010 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/storm/pull/2365.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2365 commit d3dec0d3ca80db518511bf26810d20035ce0ae81 Author: liuzhaokun Date: 2017-10-10T03:05:23Z [STORM-2773] If a drpcserver node in cluster is down,drpc cluster won't work if we don't modify the drpc.server configuration and restart the cluster ---
[GitHub] storm issue #2297: [STORM-2713] when the connection to the first zkserver is...
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2297 @srdo Thanks for your reply.I mean if curator has retried several times and failed,the code where I modify will throw a exception,and it will never attempt to connect another zkserver. Could you help me solve doubts? I will check the CI later. ---
[GitHub] storm issue #2297: [STORM-2713] when the connection to the first zkserver is...
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2297 @srdo I guess you support my PR,right? ---
[GitHub] storm issue #2297: [STORM-2713] when the connection to the first zkserver is...
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2297 @srdo I don't think it's related to retry, the key is how storm will do when the first zkserver is down. ---
[GitHub] storm pull request #2297: [STORM-2713] when the connection to the first zkse...
Github user liu-zhaokun commented on a diff in the pull request:
https://github.com/apache/storm/pull/2297#discussion_r136286746
--- Diff:
external/storm-kafka/src/jvm/org/apache/storm/kafka/DynamicBrokersReader.java
---
@@ -110,7 +110,7 @@ private int getNumPartitions(String topic) {
List children =
_curator.getChildren().forPath(topicBrokersPath);
return children.size();
} catch (Exception e) {
-throw new RuntimeException(e);
+LOG.error(e.getMessage(), e);
--- End diff --
@HeartSaVioR
I mean topology should work even we can't connect one of the
zkservers,because the data is shared among zkservers. But if we throw a
exception,storm will not attempt to connect other zkserver,and exit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #2297: [STORM-2713] when the connection to the first zkse...
Github user liu-zhaokun commented on a diff in the pull request:
https://github.com/apache/storm/pull/2297#discussion_r136284170
--- Diff:
external/storm-kafka/src/jvm/org/apache/storm/kafka/DynamicBrokersReader.java
---
@@ -110,7 +110,7 @@ private int getNumPartitions(String topic) {
List children =
_curator.getChildren().forPath(topicBrokersPath);
return children.size();
} catch (Exception e) {
-throw new RuntimeException(e);
+LOG.error(e.getMessage(), e);
--- End diff --
I think it doesn't affect 'fail-fast',I just want to guarantee users'
Topology can work normally.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #2297: [STORM-2713] when the connection to the first zkse...
Github user liu-zhaokun commented on a diff in the pull request:
https://github.com/apache/storm/pull/2297#discussion_r136279982
--- Diff:
external/storm-kafka/src/jvm/org/apache/storm/kafka/DynamicBrokersReader.java
---
@@ -110,7 +110,7 @@ private int getNumPartitions(String topic) {
List children =
_curator.getChildren().forPath(topicBrokersPath);
return children.size();
} catch (Exception e) {
-throw new RuntimeException(e);
+LOG.error(e.getMessage(), e);
--- End diff --
@HeartSaVioR
For example,one role of zk is down in users cluster,storm-kafka will throw
a exception,even storm also can connect another zk role and works.I will check
the result of Travis build.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #2297: [STORM-2713] when the connection to the first zkse...
Github user liu-zhaokun commented on a diff in the pull request:
https://github.com/apache/storm/pull/2297#discussion_r136278638
--- Diff:
external/storm-kafka/src/jvm/org/apache/storm/kafka/DynamicBrokersReader.java
---
@@ -110,7 +110,7 @@ private int getNumPartitions(String topic) {
List children =
_curator.getChildren().forPath(topicBrokersPath);
return children.size();
} catch (Exception e) {
-throw new RuntimeException(e);
+LOG.error(e.getMessage(), e);
--- End diff --
@HeartSaVioR
When exception is caught,we should only print the error messages,so that
users can be aware of there are some problems in their cluster such as one role
of zk was down.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #2297: [STORM-2713] when the connection to the first zkse...
GitHub user liu-zhaokun opened a pull request: https://github.com/apache/storm/pull/2297 [STORM-2713] when the connection to the first zkserver is timeout,storm-kafka's kafkaspout will throw a exception [https://issues.apache.org/jira/browse/STORM-2713](https://issues.apache.org/jira/browse/STORM-2713) when the connection to the first zkserver is timeout,storm-kafka's kafkaspout will throw a exception without attempting to connect other zkserver,even zk can also work with one node down. You can merge this pull request into a Git repository by running: $ git pull https://github.com/liu-zhaokun/storm master08300852 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/storm/pull/2297.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2297 commit aa46372a6907eee3f18adafec5112998b08687b1 Author: liuzhaokun Date: 2017-08-30T01:10:03Z [STORM-2713] when the connection to the first zkserver is timeout,storm-kafka's kafkaspout will throw a exception --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #2259: [STORM-2676] Error class name for log in JsonRecordHiveMa...
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2259 @revans2 OK,thanks for your reply. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #2259: [STORM-2676] Error class name for log in JsonRecordHiveMa...
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2259 @HeartSaVioR Thanks for your support.Could you help me merge it if you have some time? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #2259: [STORM-2676] Error class name for log in JsonRecordHiveMa...
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2259 @HeartSaVioR Could you have a look if you have some time? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request #2259: [STORM-2676] Error class name for log in JsonRecor...
GitHub user liu-zhaokun opened a pull request: https://github.com/apache/storm/pull/2259 [STORM-2676] Error class name for log in JsonRecordHiveMapper.java. [https://issues.apache.org/jira/browse/STORM-2676](https://issues.apache.org/jira/browse/STORM-2676) The class in "LoggerFactory.getLogger()" should be JsonRecordHiveMapper.class. You can merge this pull request into a Git repository by running: $ git pull https://github.com/liu-zhaokun/storm master08030857 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/storm/pull/2259.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2259 commit 7340590ceb9549eb3fe8bc443ba9576260d337cc Author: liuzhaokun Date: 2017-08-03T01:16:02Z [STORM-2676] Error class name for log in JsonRecordHiveMapper.java. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #2240: [STORM-2657] Update SECURITY.MD
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2240 @revans2 Hello,I have modified this PR followed your suggestion.Thanks again for your hard work.Review it,Please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #2240: [STORM-2657] Update SECURITY.MD
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2240 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #2240: [STORM-2657] Update SECURITY.MD
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2240 @revans2 Hello,I have updated SECURITY.MD,review it,please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request #2240: [STORM-2657] Update SECURITY.MD
GitHub user liu-zhaokun opened a pull request: https://github.com/apache/storm/pull/2240 [STORM-2657] Update SECURITY.MD [https://issues.apache.org/jira/browse/STORM-2657](https://issues.apache.org/jira/browse/STORM-2657) There are several PRs about storm acl merged into master,so I update SECURITY.md. You can merge this pull request into a Git repository by running: $ git pull https://github.com/liu-zhaokun/storm master07250849 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/storm/pull/2240.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2240 commit b604ea0abcef950105d4bec9315b6eb211b98c95 Author: liuzhaokun Date: 2017-07-25T02:38:56Z [STORM-2657] Update SECURITY.MD --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #2207: [STORM-2626] Provided a template for drpc-auth-acl.yaml
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2207 @revans2 You are right.I created several PRs which has been mergerd that is related to ACL. I will update SECURITY.md in a new PR with these changes later.Could you help me merge this PR firstly? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #2207: [STORM-2626] Provided a template for drpc-auth-acl.yaml
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2207 @revans2 Could you help me review this PRï¼there are no committer to review it all the time. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #2208: [STORM-2627] The annotation of storm.zookeeper.topology.a...
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2208 @Ethanlm Hi,Ethan. @HeartSaVioR and @revans2 both approved this PR,could you help me merge it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #2207: [STORM-2626] Provided a template for drpc-auth-acl.yaml
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2207 @Ethanlm Ok,thank you. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #2207: [STORM-2626] Provided a template for drpc-auth-acl.yaml
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2207 @Ethanlm Hi,could you help me review the new change? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #2207: [STORM-2626] Provided a template for drpc-auth-acl.yaml
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2207 @Ethanlm Thanks for your reply.I will modify it follow your suggestion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #2208: [STORM-2627] The annotation of storm.zookeeper.topology.a...
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2208 @HeartSaVioR I have modify this PR follow @revans2 suggestion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #2208: [STORM-2627] The annotation of storm.zookeeper.topology.a...
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2208 @HeartSaVioR OK, I will do it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #2207: [STORM-2626] Provided a template for drpc-auth-acl.yaml
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2207 @HeartSaVioR Do you have time to help me review this PR,it's about drpc acl? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #2208: [STORM-2627] The annotation of storm.zookeeper.topology.a...
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2208 @harshach It has always been the case.In other words,the value of this configuration is digest all the time.You can see StormSubmitter.java,line 92.It doesn't matter even that is in case of non-secure cluster. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #2208: [STORM-2627] The annotation of storm.zookeeper.topology.a...
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2208 @HeartSaVioR I have modified this PR according to your opinion,and it has passed all the test.Could you help me merge it?Thank you very much. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #2208: [STORM-2627] The annotation of storm.zookeeper.topology.a...
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2208 @HeartSaVioR Thanks for your reply.I will remove it from Config.java. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #2208: [STORM-2627] The annotation of storm.zookeeper.topology.a...
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2208 @harshach Thanks for your reply.You can see StormSubmitter.java,line 91.STORM_ZOOKEEPER_TOPOLOGY_AUTH_SCHEME is should always be set to digest.It can't be and won't be other value.So,I think we should declare â"storm.zookeeper.topology.auth.schemeâ should always be set to digest.We shouldn't mislead others. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #2208: [STORM-2627] The annotation of storm.zookeeper.topology.a...
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2208 @haitaoyao I am so sorry to bother you.Do you have time to help me review it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #2207: [STORM-2626] Provided a template for drpc-auth-acl.yaml
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2207 @harshach I am so sorry to bother you.Do you have time to help me review it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #2207: [STORM-2626] Provided a template for drpc-auth-acl.yaml
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2207 @vesense I am so sorry to bother you.Do you have time to help me review it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #2207: [STORM-2626] Provided a template for drpc-auth-acl.yaml
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2207 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #2208: [STORM-2627] The annotation of storm.zookeeper.topology.a...
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2208 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #2207: [STORM-2626] Provided a template for drpc-auth-acl.yaml
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2207 @HeartSaVioR I am so sorry to bother you.Do you have time to help me review it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #2208: [STORM-2627] The annotation of storm.zookeeper.topology.a...
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2208 @HeartSaVioR I am so sorry to bother you.Do you have time to help me review it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request #2208: [STORM-2627] The annotation of storm.zookeeper.top...
GitHub user liu-zhaokun opened a pull request: https://github.com/apache/storm/pull/2208 [STORM-2627] The annotation of storm.zookeeper.topology.auth.scheme in Config.java is wrong [https://issues.apache.org/jira/browse/STORM-2627](https://issues.apache.org/jira/browse/STORM-2627) The annotation of "storm.zookeeper.topology.auth.scheme" in Config.java is wrong.As StormSubmitter.java,line 91, says "STORM_ZOOKEEPER_TOPOLOGY_AUTH_SCHEME is should always be set to digest.", the annotation of "storm.zookeeper.topology.auth.scheme" in Config.java should be consistent with it. You can merge this pull request into a Git repository by running: $ git pull https://github.com/liu-zhaokun/storm master07131533 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/storm/pull/2208.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2208 commit 64b9913e108922a5b85249bf1647e235b0d6dcb0 Author: liuzhaokun Date: 2017-07-13T07:55:23Z [STORM-2627] The annotation of storm.zookeeper.topology.auth.scheme in Config.java is wrong --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request #2207: [STORM-2626] Provided a template for drpc-auth-acl...
GitHub user liu-zhaokun opened a pull request: https://github.com/apache/storm/pull/2207 [STORM-2626] Provided a template for drpc-auth-acl.yaml [https://issues.apache.org/jira/browse/STORM-2626](https://issues.apache.org/jira/browse/STORM-2626) The default value of drpc.authorizer.acl.filename in defaults.yaml is "drpc-auth-acl.yaml",so I think we should provided a template for drpc-auth-acl.yaml. You can merge this pull request into a Git repository by running: $ git pull https://github.com/liu-zhaokun/storm master07131509 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/storm/pull/2207.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2207 commit 2dde576804477fdbc16a3de791245d047b32643d Author: liuzhaokun Date: 2017-07-13T07:31:50Z [STORM-2626] Provided a template for drpc-auth-acl.yaml --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #2180: [STORM-2602] storm.zookeeper.topology.auth.payload doesn'...
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2180 @HeartSaVioR Thanks very much for your hard work.I know your difficulties now,and I will support your work. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #2180: [STORM-2602] storm.zookeeper.topology.auth.payload doesn'...
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2180 Could anyone help me merge this PR?It has been create long long ago.I only want to handle it properly.Could anyone reply to me? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #2180: [STORM-2602] storm.zookeeper.topology.auth.payload doesn'...
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2180 @HeartSaVioR Since this PR has been "+1"ï¼could you help me merge IT now? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #2180: [STORM-2602] storm.zookeeper.topology.auth.payload doesn'...
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2180 @harshach Could you help me merge it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #2180: [STORM-2602] storm.zookeeper.topology.auth.payload doesn'...
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2180 @srdo Could you help me merge it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #2180: [STORM-2602] storm.zookeeper.topology.auth.payload doesn'...
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2180 @revans2 Could you help me merge it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #2180: [STORM-2602] storm.zookeeper.topology.auth.payload doesn'...
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2180 @vesense Could you help me merge it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #2180: [STORM-2602] storm.zookeeper.topology.auth.payload doesn'...
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2180 @HeartSaVioR Did you miss this PR?Could you help me merge this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #2180: [STORM-2602] storm.zookeeper.topology.auth.payload doesn'...
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2180 @HeartSaVioR Did you miss this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #2180: [STORM-2602] storm.zookeeper.topology.auth.payload doesn'...
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2180 @HeartSaVioR Could you help me merge this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request #2058: [STORM-2466] The example of jaas.conf in jaas_kerb...
Github user liu-zhaokun closed the pull request at: https://github.com/apache/storm/pull/2058 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request #1890: [STORM-2311]A browser which is outside the cluster...
Github user liu-zhaokun closed the pull request at: https://github.com/apache/storm/pull/1890 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #2180: [STORM-2602] storm.zookeeper.topology.auth.payload doesn'...
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2180 @hmcl Could you help me merge this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request #2066: [STORM-2472] kafkaspout should work normally in ke...
Github user liu-zhaokun closed the pull request at: https://github.com/apache/storm/pull/2066 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #2180: [STORM-2602] storm.zookeeper.topology.auth.payload doesn'...
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2180 @HeartSaVioR The new commit has passed all the tests. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #2180: [STORM-2602] storm.zookeeper.topology.auth.payload doesn'...
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2180 @HeartSaVioR Hello,I have update the test,and adjust my code according to @revans2 's opinion.Could you help me merge it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #2180: [STORM-2602] storm.zookeeper.topology.auth.payload doesn'...
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2180 @revans2 Yes,I pass this configuration by storm.config.I will take a look at that test,and adjust my code according to your opinion.Thanks for your reply. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #2170: [STORM-2564] We should provide a template for storm-clust...
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2170 @HeartSaVioR Thanks for your reply,if possible, please help me merge it as soon as possible,because this PR has been created for a long time. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #2170: [STORM-2564] We should provide a template for storm-clust...
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2170 @HeartSaVioR Users needn't copy the configuration,storm.zookeeper.auth.payload, from storm-cluster-auth.yaml.template and paste to their storm.yaml.They only should add this configuration to storm-cluster-auth.yaml if they need. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #2170: [STORM-2564] We should provide a template for storm-clust...
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2170 @HeartSaVioR It says "Note that if this is set to something with a secret (as when using digest authentication) then it should only be set in the storm-cluster-auth.yaml file." in Config.java,line 1082. So I think we should provide a template. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #2180: [STORM-2602] storm.zookeeper.topology.auth.payload doesn'...
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2180 @HeartSaVioR I want to use my payload by setting the configuration which named "STORM_ZOOKEEPER_TOPOLOGY_AUTH_PAYLOAD",but it doesn't work.The payload of any topology always be a uuid generated by the method which named generateZookeeperDigestSecretPayload().It isn't difficult to judge the logic of "prepareZookeeperAuthentication" was defective. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #2166: [STORM-2559] There are three configurations in defaults.y...
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2166 @HeartSaVioR Please help me merge it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #2180: [STORM-2602] storm.zookeeper.topology.auth.payload doesn'...
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2180 @HeartSaVioR Could you help me review this PR?I think it's a major bug. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #2166: [STORM-2559] There are three configurations in defaults.y...
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2166 Are there any body help me merge it?It was created for a long time. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request #2180: [STORM-2602] storm.zookeeper.topology.auth.payload...
GitHub user liu-zhaokun opened a pull request: https://github.com/apache/storm/pull/2180 [STORM-2602] storm.zookeeper.topology.auth.payload doesn't work even you set it [https://issues.apache.org/jira/browse/STORM-2602](https://issues.apache.org/jira/browse/STORM-2602) "storm.zookeeper.topology.auth.payload" doesn't work even you have set it,because there doesn't use it when the value of STORM_ZOOKEEPER_TOPOLOGY_AUTH_PAYLOAD isn't null or other abnormal condition. You can merge this pull request into a Git repository by running: $ git pull https://github.com/liu-zhaokun/storm new5 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/storm/pull/2180.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2180 commit 319c878f0f5e154ce2d8ecddcde0111e8c285642 Author: liuzhaokun Date: 2017-06-26T11:53:03Z [STORM-2602] storm.zookeeper.topology.auth.payload doesn't work even you set it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #2166: [STORM-2559] There are three configurations in defaults.y...
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2166 @HeartSaVioR Hello,are you available to help me review this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #2170: [STORM-2564] We should provide a template for storm-clust...
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2170 @HeartSaVioR Hello,are you available to help me review this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #2170: [STORM-2564] We should provide a template for storm-clust...
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2170 @vesense Could you help me review this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request #2170: [STORM-2564] We should provide a template for stor...
GitHub user liu-zhaokun opened a pull request: https://github.com/apache/storm/pull/2170 [STORM-2564] We should provide a template for storm-cluster-auth.yaml [https://issues.apache.org/jira/browse/STORM-2564](https://issues.apache.org/jira/browse/STORM-2564) As the configuration which named storm.zookeeper.auth.payload should be filled in "storm-cluster-auth.yaml",and there isn't such a file.So, I think we should provide a template for storm-cluster-auth.yaml. You can merge this pull request into a Git repository by running: $ git pull https://github.com/liu-zhaokun/storm new3 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/storm/pull/2170.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2170 commit bd62e4cc25b3bb8bca17c372c8b5deb43f2456c1 Author: liuzhaokun Date: 2017-06-21T05:24:32Z [STORM-2564] We should provide a template for storm-cluster-auth.yaml --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #2166: [STORM-2559] There are three configurations in defaults.y...
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2166 @HeartSaVioR Hello,are you available to help me review this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #2166: [STORM-2559] There are three configurations in defaults.y...
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2166 @vesense Hello,are you available to help me review this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request #2166: [STORM-2559] There are three configurations in def...
GitHub user liu-zhaokun opened a pull request: https://github.com/apache/storm/pull/2166 [STORM-2559] There are three configurations in defaults.yaml haven't been used in storm. [https://issues.apache.org/jira/browse/STORM-2559](https://issues.apache.org/jira/browse/STORM-2559) There are three configurations,storm.auth.simple-acl.users: [],storm.auth.simple-acl.users.commands: [] and storm.auth.simple-acl.admins: [], in defaults.conf haven't been used in storm.So I think it should be removed from defaults.yaml. You can merge this pull request into a Git repository by running: $ git pull https://github.com/liu-zhaokun/storm new1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/storm/pull/2166.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2166 commit bfcf398c96c277801699da5a32cf03bb04070e10 Author: liuzhaokun Date: 2017-06-19T02:42:47Z [STORM-2559] There are three configurations in defaults.yaml haven't been used in storm. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #2110: [STORM-2466] The example of jaas.conf in jaas_kerberos.co...
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2110 @HeartSaVioR Do you agree with me?Could you help me merge it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #2110: [STORM-2466] The example of jaas.conf in jaas_kerberos.co...
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2110 @HeartSaVioR The explanation has existed in docs\SECURITY.md,so I didn't add it in these files. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #2110: [STORM-2466] The example of jaas.conf in jaas_kerberos.co...
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2110 @HeartSaVioR kishorvpatil approved these changes 28 days ago,could you help me merge this PR as soon as possible? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #2110: [STORM-2466] The example of jaas.conf in jaas_kerberos.co...
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2110 @HeartSaVioR Hello,long time no see!Anyway,thanks for your reply. The $ here should be replace with their keytab and principal by users manually. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #2110: [STORM-2466] The example of jaas.conf in jaas_kerberos.co...
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2110 @kishorvpatil @vesense @HeartSaVioR @harshach ,can you take a look at this PR? It's too long to almost forget The issue is still âIN PROGRESSâ I just want to finish it properly thx --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #2110: [STORM-2466] The example of jaas.conf in jaas_kerberos.co...
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2110 @harshach Could you review this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
