[GitHub] storm issue #2752: Storm 1311 Migration of UI from clj to Java

2018-08-05 Thread HeartSaVioR 
Github user HeartSaVioR commented on the issue:

https://github.com/apache/storm/pull/2752
  
Sorry to revisit this in proper time. Thanks @govind-menon for doing this 
great work, and thanks @revans2 for the detailed review. I'll try to spend time 
to play with UI and report issues if any.


---

[GitHub] storm issue #2752: Storm 1311 Migration of UI from clj to Java

2018-08-03 Thread revans2 
Github user revans2 commented on the issue:

https://github.com/apache/storm/pull/2752
  
Please squash the commits.


---

[GitHub] storm issue #2752: Storm 1311 Migration of UI from clj to Java

2018-08-03 Thread revans2 
Github user revans2 commented on the issue:

https://github.com/apache/storm/pull/2752
  
I may have found out more.  In the logs I see 

```
Caused by: java.io.IOException: Unable to fetch topo conf for topo id 
wc-1-1533264135
at 
org.apache.storm.daemon.ui.filters.AuthorizedUserFilter.filter(AuthorizedUserFilter.java:85)
 ~[storm-webapp-2.0.0-SNAPSHOT.jar:2.0.0-SNAPSHOT]
at 
org.glassfish.jersey.server.ContainerFilteringStage.apply(ContainerFilteringStage.java:132)
 ~[jersey-server-2.27.jar:?]
```

So it looks like the authorizer is throwing an IOException which is causing 
the 500 error


---

[GitHub] storm issue #2752: Storm 1311 Migration of UI from clj to Java

2018-08-03 Thread revans2 
Github user revans2 commented on the issue:

https://github.com/apache/storm/pull/2752
  
I am seeing these when I run DRPC and the logviewer.  They appear to still 
work so this is minor, but it would be nice to fix them in a follow on JIRA if 
you cannot do it quickly now.

```
WARNING: A provider 
org.apache.storm.daemon.logviewer.webapp.LogviewerResource registered in SERVER 
runtime does not implement any provider interfaces applicable in the SERVER 
runtime. Due to constraint configuration problems the provider 
org.apache.storm.daemon.logviewer.webapp.LogviewerResource will be ignored.
```

```
WARNING: A provider org.apache.storm.daemon.drpc.webapp.DRPCResource 
registered in SERVER runtime does not implement any provider interfaces 
applicable in the SERVER runtime. Due to constraint configuration problems the 
provider org.apache.storm.daemon.drpc.webapp.DRPCResource will be ignored.
```

Also I found that the exception mapping does not appear to be working.  If 
you go to the topology page for a topology that is not up (i.e. 
http://localhost:8080/topology.html?id=wc-1-1533264135 ) I see a stack trace 
for the NotAliveException being printed out to stdout or stderr (not sure which)

```
NotAliveException(msg:wc-1-1533264135)
at 
org.apache.storm.generated.Nimbus$getTopologyConf_result$getTopologyConf_resultStandardScheme.read(Nimbus.java:45081)
at 
org.apache.storm.generated.Nimbus$getTopologyConf_result$getTopologyConf_resultStandardScheme.read(Nimbus.java:45059)
at 
org.apache.storm.generated.Nimbus$getTopologyConf_result.read(Nimbus.java:44993)
...
```

But the request is returning an HTML response

```



Error 500 Request failed.

HTTP ERROR 500
Problem accessing /api/v1/topology/wc-1-1533264135. Reason:
Request failed.http://eclipse.org/jetty;>Powered by Jetty:// 9.4.7.v20170914



```


---

[GitHub] storm issue #2752: Storm 1311 Migration of UI from clj to Java

2018-08-01 Thread govind-menon 
Github user govind-menon commented on the issue:

https://github.com/apache/storm/pull/2752
  
@HeartSaVioR @revans2 I've done the changes you requested. Please let me 
know of any other changes.


---

[GitHub] storm issue #2752: Storm 1311 Migration of UI from clj to Java

2018-07-30 Thread revans2 
Github user revans2 commented on the issue:

https://github.com/apache/storm/pull/2752
  
localhost nimbus still does not show up on the UI if it is the only nimbus.

I am also getting an error in the visualization.

When hitting 
http://localhost:4443/api/v1/topology/wc-1-1532972479/visualization?sys=true it 
is causing an error on the nimbus side looking for the wrong blob (looks like 
it somehow think the topology is called `:all-time`).

```
2018-07-30 12:43:17.361 o.a.s.t.ProcessFunction pool-21-thread-17 [ERROR] 
Internal error processing getTopologyInfoWithOpts
java.lang.RuntimeException: java.lang.IllegalArgumentException: 
:all-time-stormconf.ser does not appear to be a valid blob key
at 
org.apache.storm.daemon.nimbus.Nimbus.getTopologyInfoWithOpts(Nimbus.java:3912) 
~[storm-server-2.0.0-SNAPSHOT.jar:2.0.0-SNAPSHOT]
at 
org.apache.storm.generated.Nimbus$Processor$getTopologyInfoWithOpts.getResult(Nimbus.java:4576)
 ~[storm-client-2.0.0-SNAPSHOT.jar:2.0.0-SNAPSHOT]
at 
org.apache.storm.generated.Nimbus$Processor$getTopologyInfoWithOpts.getResult(Nimbus.java:4555)
 ~[storm-client-2.0.0-SNAPSHOT.jar:2.0.0-SNAPSHOT]
at 
org.apache.storm.thrift.ProcessFunction.process(ProcessFunction.java:38) 
[shaded-deps-2.0.0-SNAPSHOT.jar:2.0.0-SNAPSHOT]
at 
org.apache.storm.thrift.TBaseProcessor.process(TBaseProcessor.java:39) 
[shaded-deps-2.0.0-SNAPSHOT.jar:2.0.0-SNAPSHOT]
at 
org.apache.storm.security.auth.SimpleTransportPlugin$SimpleWrapProcessor.process(SimpleTransportPlugin.java:169)
 [storm-client-2.0.0-SNAPSHOT.jar:2.0.0-SNAPSHOT]
at 
org.apache.storm.thrift.server.AbstractNonblockingServer$FrameBuffer.invoke(AbstractNonblockingServer.java:518)
 [shaded-deps-2.0.0-SNAPSHOT.jar:2.0.0-SNAPSHOT]
at 
org.apache.storm.thrift.server.Invocation.run(Invocation.java:18) 
[shaded-deps-2.0.0-SNAPSHOT.jar:2.0.0-SNAPSHOT]
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) 
[?:1.8.0_171]
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) 
[?:1.8.0_171]
at java.lang.Thread.run(Thread.java:748) [?:1.8.0_171]
Caused by: java.lang.IllegalArgumentException: :all-time-stormconf.ser does 
not appear to be a valid blob key
at 
org.apache.storm.blobstore.BlobStore.validateKey(BlobStore.java:63) 
~[storm-client-2.0.0-SNAPSHOT.jar:2.0.0-SNAPSHOT]
at 
org.apache.storm.blobstore.LocalFsBlobStore.getBlob(LocalFsBlobStore.java:387) 
~[storm-server-2.0.0-SNAPSHOT.jar:2.0.0-SNAPSHOT]
at 
org.apache.storm.blobstore.BlobStore.readBlobTo(BlobStore.java:307) 
~[storm-client-2.0.0-SNAPSHOT.jar:2.0.0-SNAPSHOT]
at 
org.apache.storm.blobstore.BlobStore.readBlob(BlobStore.java:336) 
~[storm-client-2.0.0-SNAPSHOT.jar:2.0.0-SNAPSHOT]
at 
org.apache.storm.daemon.nimbus.TopoCache.readTopoConf(TopoCache.java:150) 
~[storm-server-2.0.0-SNAPSHOT.jar:2.0.0-SNAPSHOT]
at 
org.apache.storm.daemon.nimbus.Nimbus.readTopoConfAsNimbus(Nimbus.java:679) 
~[storm-server-2.0.0-SNAPSHOT.jar:2.0.0-SNAPSHOT]
at 
org.apache.storm.daemon.nimbus.Nimbus.tryReadTopoConf(Nimbus.java:840) 
~[storm-server-2.0.0-SNAPSHOT.jar:2.0.0-SNAPSHOT]
at 
org.apache.storm.daemon.nimbus.Nimbus.getCommonTopoInfo(Nimbus.java:2716) 
~[storm-server-2.0.0-SNAPSHOT.jar:2.0.0-SNAPSHOT]
at 
org.apache.storm.daemon.nimbus.Nimbus.getTopologyInfoWithOpts(Nimbus.java:3826) 
~[storm-server-2.0.0-SNAPSHOT.jar:2.0.0-SNAPSHOT]
... 10 more
```


---

[GitHub] storm issue #2752: Storm 1311 Migration of UI from clj to Java

2018-07-27 Thread govind-menon 
Github user govind-menon commented on the issue:

https://github.com/apache/storm/pull/2752
  
@HeartSaVioR I addressed your review comments. Currently fixing checkstyle.


---

[GitHub] storm issue #2752: Storm 1311 Migration of UI from clj to Java

2018-07-11 Thread revans2 
Github user revans2 commented on the issue:

https://github.com/apache/storm/pull/2752
  
The errors being returned by the mappers are becoming html and not json.  
We need them to be json, and I think we want them to support the callback as 
well if possible.

Also is there a way to log the exception.


---

[GitHub] storm issue #2752: Storm 1311 Migration of UI from clj to Java

2018-07-11 Thread revans2 
Github user revans2 commented on the issue:

https://github.com/apache/storm/pull/2752
  
And I am getting a 404 response on the supervisor page from 
`/api/v1/supervisor`  Specifically the full url it was going for is.


`http://localhost:8080/api/v1/supervisor?id=3223d08c-e1e6-4693-80c8-268097580ac7-172.130.98.13=true`

Not sure if this is something we ported over properly or not.


---

[GitHub] storm issue #2752: Storm 1311 Migration of UI from clj to Java

2018-07-11 Thread revans2 
Github user revans2 commented on the issue:

https://github.com/apache/storm/pull/2752
  
I am also getting no nimbus instances on the UI when running locally.


---

[GitHub] storm issue #2752: Storm 1311 Migration of UI from clj to Java

2018-07-11 Thread revans2 
Github user revans2 commented on the issue:

https://github.com/apache/storm/pull/2752
  
Please try running the DPRC server as well as the logviewer.  I am getting 
some exceptions with DRPC.


---

[GitHub] storm issue #2752: Storm 1311 Migration of UI from clj to Java

2018-07-11 Thread govind-menon 
Github user govind-menon commented on the issue:

https://github.com/apache/storm/pull/2752
  
I've addressed the feedback in the new commit - currently checkstyle is 
failing (which is mostly Javadocs) - should have that up soon


---

[GitHub] storm issue #2752: Storm 1311 Migration of UI from clj to Java

2018-07-05 Thread revans2 
Github user revans2 commented on the issue:

https://github.com/apache/storm/pull/2752
  
I'll start looking at the code, but please fix the checkstyle issues so 
that travis can finish the integration test.


---