[GitHub] storm pull request: STORM-675. Allow users to have storm-env.sh un...
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/434#issuecomment-77397949
+1. The diffs of `storm` vs. `storm.py` are minimal and related to windows
compatibility.
For easy reference, here they are:
```
$ diff -w storm storm.py
37a38,40
def is_windows():
return sys.platform.startswith('win')
174c177
JAVA_CMD, jvmtype, get_config_opts(),
---
java, jvmtype, get_config_opts(),
184c187
else:
---
elif is_windows():
186a190,191
else:
os.execvp(JAVA_CMD, all_args)
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-675. Allow users to have storm-env.sh un...
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/434#issuecomment-77397764 @ptgoetz Thanks for the review. Removed the year from LICENSE. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-675. Allow users to have storm-env.sh un...
Github user ptgoetz commented on a diff in the pull request: https://github.com/apache/storm/pull/434#discussion_r25876670 --- Diff: bin/storm --- @@ -1,5 +1,7 @@ -#!/usr/bin/python - +#!/bin/bash +# +# Copyright 2014 The Apache Software Foundation --- End diff -- We shouldn't need the copyright year in the license header. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-675. Allow users to have storm-env.sh un...
Github user ptgoetz commented on a diff in the pull request: https://github.com/apache/storm/pull/434#discussion_r25876751 --- Diff: conf/storm-env.sh --- @@ -0,0 +1,26 @@ +#!/bin/bash +# +# Copyright 2014 The Apache Software Foundation --- End diff -- Same as previous comment. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-675. Allow users to have storm-env.sh un...
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/434#issuecomment-77167715 @ptgoetz can you please take a look at this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: [GitHub] storm pull request: STORM-675. Allow users to have storm-env.sh un...
Dear Storm development team I am new to STORM and writing an application to analyse the tweets in realtime. Can any one help me with some inputs. If anybody could share some sample code that would be really great. Thanks in advance. On Thu, Feb 26, 2015 at 3:21 AM, Parth-Brahmbhatt g...@git.apache.org wrote: Github user Parth-Brahmbhatt commented on the pull request: https://github.com/apache/storm/pull/434#issuecomment-76068327 +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- -- Thanks and Regards Pruthvi
[GitHub] storm pull request: STORM-675. Allow users to have storm-env.sh un...
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/434#issuecomment-75558480 @HeartSaVioR bin/storm which used to be a python script now moved to bin/storm.py and in place of bin/storm we added storm shell script to give users a way to configure storm env variables. Because of this renaming files you see the diff like that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-675. Allow users to have storm-env.sh un...
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/434#issuecomment-75570460 @harshach I know, I just want to point out that bin/storm is not only renamed but also modified a bit. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-675. Allow users to have storm-env.sh un...
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/434#issuecomment-75493979 Great! Looks good to me. Btw, it's better to point out storm.py's actual changed lines since it's hard to find difference. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-675. Allow users to have storm-env.sh un...
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/434#issuecomment-75487910 @HeartSaVioR yes but wanted to keep the .cmd files for at least a release or two as there might be users who are depend on these. Since storm.py is now windows compatabile we can phase out the current storm.cmd --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
