[GitHub] storm pull request: STORM-691 Add basic lookup / persist bolts
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/451#issuecomment-85512521 @revans2 Could you take a look again? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-691 Add basic lookup / persist bolts
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/451 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-691 Add basic lookup / persist bolts
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/451#issuecomment-85539101 +1, again sorry about this taking so long, I'll merge it in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-691 Add basic lookup / persist bolts
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/451#issuecomment-83732719 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-691 Add basic lookup / persist bolts
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/451#issuecomment-78393165 The code looks fine to me. My only comment is that it would be nice to have a default in most of the case statements, mostly as defensive programming so if something gets off we wold get an error instead of falling through and ignoring the tuples. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-691 Add basic lookup / persist bolts
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/451#issuecomment-78396550 @revans2 Thanks for reviewing! It's updated. Could you please check again? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-691 Add basic lookup / persist bolts
GitHub user HeartSaVioR opened a pull request: https://github.com/apache/storm/pull/451 STORM-691 Add basic lookup / persist bolts * Add Basic lookup / persist Bolts * support data types : string, list, hash, set, sorted set, hyperloglog * rename util package to common Type | Read | Write | --- | -- STRING | GET (key) | SET (key, value) HASH | HGET (key, field) | HSET (key, field, value) LIST | LPOP (key) | RPUSH (key, value) SET | SCARD (key) | SADD (key, member) SORTED SET | ZSCORE (key, member) | ZADD (key, score, member) HLL (HyperLogLog) | PFCOUNT (key) | PFADD (key, element) You can merge this pull request into a Git repository by running: $ git pull https://github.com/HeartSaVioR/storm STORM-691 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/storm/pull/451.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #451 commit f7c0bf8a7c843c6e555ee982a85e3952d1c28b33 Author: Jungtaek Lim kabh...@gmail.com Date: 2015-02-28T13:29:32Z STORM-691 Add basic lookup / persist bolts * Add Basic lookup / persist Bolts ** support data types : string, list, hash, set, sorted set, hyperloglog * rename util package to common --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-691 Add basic lookup / persist bolts
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/451#issuecomment-76526842 When this PR will be merged to master, we can apply RedisDataTypeDescription to Trident in order to support more data types. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
