[jira] [Commented] (STORM-534) Store Nimbus Server Information in zookeeper path {storm.zookeeper.root}/nimbus

2015-02-10 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/STORM-534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14315400#comment-14315400
 ] 

ASF GitHub Bot commented on STORM-534:
--

Github user caofangkun closed the pull request at:

https://github.com/apache/storm/pull/394


 Store Nimbus Server Information in zookeeper path 
 {storm.zookeeper.root}/nimbus
 ---

 Key: STORM-534
 URL: https://issues.apache.org/jira/browse/STORM-534
 Project: Apache Storm
  Issue Type: Improvement
Affects Versions: 0.10.0
Reporter: caofangkun
Assignee: caofangkun
Priority: Minor

 1) {nimbus.host} {nimbus.thrift.port} {storm.version} will be stored in  
 {storm.zookeeper.root}/nimbus like  localhost:8826:0.9.3-r1234
 2) Storm Clients only need to configure {storm.zookeeper.root} to get Nimbus 
 Server Information, Configuration like {nimbus.host} {nimbus.thrift.port} 
 {storm.version} will be ignored



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (STORM-534) Store Nimbus Server Information in zookeeper path {storm.zookeeper.root}/nimbus

2015-02-10 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/STORM-534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14314774#comment-14314774
 ] 

ASF GitHub Bot commented on STORM-534:
--

Github user Parth-Brahmbhatt commented on the pull request:

https://github.com/apache/storm/pull/394#issuecomment-73770259
  
I am already planning on storing all the required information and modify 
the UI as part of nimbus HA, Please see 
https://issues.apache.org/jira/browse/STORM-654 and comment on it if you think 
more information should be stores as part of NimbusInfo instance.


 Store Nimbus Server Information in zookeeper path 
 {storm.zookeeper.root}/nimbus
 ---

 Key: STORM-534
 URL: https://issues.apache.org/jira/browse/STORM-534
 Project: Apache Storm
  Issue Type: Improvement
Affects Versions: 0.10.0
Reporter: caofangkun
Assignee: caofangkun
Priority: Minor

 1) {nimbus.host} {nimbus.thrift.port} {storm.version} will be stored in  
 {storm.zookeeper.root}/nimbus like  localhost:8826:0.9.3-r1234
 2) Storm Clients only need to configure {storm.zookeeper.root} to get Nimbus 
 Server Information, Configuration like {nimbus.host} {nimbus.thrift.port} 
 {storm.version} will be ignored



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (STORM-534) Store Nimbus Server Information in zookeeper path {storm.zookeeper.root}/nimbus

2015-02-10 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/STORM-534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14314768#comment-14314768
 ] 

ASF GitHub Bot commented on STORM-534:
--

Github user revans2 commented on the pull request:

https://github.com/apache/storm/pull/394#issuecomment-73769844
  
I have a few questions.  First why are we storing the nimbus version as 
JSON in zookeeper?  The way the code is written to store the data in ZK we 
start off with the raw values.  We put them in a thrift object, and then 
convert them to JSON to store them.  To pull it back with the UI it asks nimbus 
to get the cluster info which results in a zookeeper call to get the JSON 
version string which is converted to thrift, sent back to the UI which converts 
it back to JSON again.  It feels like there are a lot of unnecessary steps. Can 
we just store it as thrift in ZK and only convert to JSON for the final UI call?

I would also prefer to have clients pick the nimbus server to use as part 
of nimbus HA https://github.com/apache/storm/pull/354 it fits better there.  
Perhaps we really should just wait for the HA code to go in before putting in 
the version number info.  With this change we get half of HA but not all of it.


 Store Nimbus Server Information in zookeeper path 
 {storm.zookeeper.root}/nimbus
 ---

 Key: STORM-534
 URL: https://issues.apache.org/jira/browse/STORM-534
 Project: Apache Storm
  Issue Type: Improvement
Affects Versions: 0.10.0
Reporter: caofangkun
Assignee: caofangkun
Priority: Minor

 1) {nimbus.host} {nimbus.thrift.port} {storm.version} will be stored in  
 {storm.zookeeper.root}/nimbus like  localhost:8826:0.9.3-r1234
 2) Storm Clients only need to configure {storm.zookeeper.root} to get Nimbus 
 Server Information, Configuration like {nimbus.host} {nimbus.thrift.port} 
 {storm.version} will be ignored



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (STORM-534) Store Nimbus Server Information in zookeeper path {storm.zookeeper.root}/nimbus

2015-02-09 Thread Derek Dagit (JIRA)

[ 
https://issues.apache.org/jira/browse/STORM-534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14312448#comment-14312448
 ] 

Derek Dagit commented on STORM-534:
---

I noticed this issue has been resolved as a duplicate, but there is a pull 
request that is being reviewed.

https://github.com/apache/storm/pull/394

Should we reopen this issue?

 Store Nimbus Server Information in zookeeper path 
 {storm.zookeeper.root}/nimbus
 ---

 Key: STORM-534
 URL: https://issues.apache.org/jira/browse/STORM-534
 Project: Apache Storm
  Issue Type: Improvement
Affects Versions: 0.10.0
Reporter: caofangkun
Assignee: caofangkun
Priority: Minor

 1) {nimbus.host} {nimbus.thrift.port} {storm.version} will be stored in  
 {storm.zookeeper.root}/nimbus like  localhost:8826:0.9.3-r1234
 2) Storm Clients only need to configure {storm.zookeeper.root} to get Nimbus 
 Server Information, Configuration like {nimbus.host} {nimbus.thrift.port} 
 {storm.version} will be ignored



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (STORM-534) Store Nimbus Server Information in zookeeper path {storm.zookeeper.root}/nimbus

2015-02-03 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/STORM-534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14304493#comment-14304493
 ] 

ASF GitHub Bot commented on STORM-534:
--

Github user caofangkun commented on the pull request:

https://github.com/apache/storm/pull/394#issuecomment-72776924
  
@revans2 
it might be good to:
1:  the configuration  should be paginated 
2:   we'd better supply three types of configuration and they  may 
different from each other
  2.1 nimbus server configuration --- show up all config information and  
in numbus.html 
  2.2 supervisor server configuration( different type of machine may have 
different configuration ) -- show only supervisor local config information and  
in supervisor.html 
  2.3 topology configuration -- show only the topology customized  
configuration and   in topology.html  


 Store Nimbus Server Information in zookeeper path 
 {storm.zookeeper.root}/nimbus
 ---

 Key: STORM-534
 URL: https://issues.apache.org/jira/browse/STORM-534
 Project: Apache Storm
  Issue Type: Improvement
Affects Versions: 0.10.0
Reporter: caofangkun
Assignee: caofangkun
Priority: Minor

 1) {nimbus.host} {nimbus.thrift.port} {storm.version} will be stored in  
 {storm.zookeeper.root}/nimbus like  localhost:8826:0.9.3-r1234
 2) Storm Clients only need to configure {storm.zookeeper.root} to get Nimbus 
 Server Information, Configuration like {nimbus.host} {nimbus.thrift.port} 
 {storm.version} will be ignored



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (STORM-534) Store Nimbus Server Information in zookeeper path {storm.zookeeper.root}/nimbus

2015-02-03 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/STORM-534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14304568#comment-14304568
 ] 

ASF GitHub Bot commented on STORM-534:
--

Github user harshach commented on the pull request:

https://github.com/apache/storm/pull/394#issuecomment-72782784
  
@caofangkun Thanks . I think it helps categorizing the configuration into 
different section. But in a storm deployment same storm.yaml used on all hosts. 
So I don't think its a good idea make this distinction on the code side as it 
makes easier to have same config on all hosts for deployment reasons.


 Store Nimbus Server Information in zookeeper path 
 {storm.zookeeper.root}/nimbus
 ---

 Key: STORM-534
 URL: https://issues.apache.org/jira/browse/STORM-534
 Project: Apache Storm
  Issue Type: Improvement
Affects Versions: 0.10.0
Reporter: caofangkun
Assignee: caofangkun
Priority: Minor

 1) {nimbus.host} {nimbus.thrift.port} {storm.version} will be stored in  
 {storm.zookeeper.root}/nimbus like  localhost:8826:0.9.3-r1234
 2) Storm Clients only need to configure {storm.zookeeper.root} to get Nimbus 
 Server Information, Configuration like {nimbus.host} {nimbus.thrift.port} 
 {storm.version} will be ignored



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (STORM-534) Store Nimbus Server Information in zookeeper path {storm.zookeeper.root}/nimbus

2015-02-03 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/STORM-534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14304585#comment-14304585
 ] 

ASF GitHub Bot commented on STORM-534:
--

Github user caofangkun commented on a diff in the pull request:

https://github.com/apache/storm/pull/394#discussion_r24060605
  
--- Diff: storm-core/src/clj/backtype/storm/daemon/nimbus.clj ---
@@ -18,12 +18,17 @@
[java.util Collections])
   (:import [java.io FileNotFoundException])
   (:import [java.nio.channels Channels WritableByteChannel])
+  (:import [backtype.storm.utils VersionInfo])
   (:import [backtype.storm.security.auth ThriftServer ThriftConnectionType 
ReqContext AuthUtils])
   (:use [backtype.storm.scheduler.DefaultScheduler])
   (:import [backtype.storm.scheduler INimbus SupervisorDetails WorkerSlot 
TopologyDetails
 Cluster Topologies SchedulerAssignment SchedulerAssignmentImpl 
DefaultScheduler ExecutorDetails])
+ HEAD
--- End diff --

Sorry.
I have fixed the merge conflicts . Please do try again.


 Store Nimbus Server Information in zookeeper path 
 {storm.zookeeper.root}/nimbus
 ---

 Key: STORM-534
 URL: https://issues.apache.org/jira/browse/STORM-534
 Project: Apache Storm
  Issue Type: Improvement
Affects Versions: 0.10.0
Reporter: caofangkun
Assignee: caofangkun
Priority: Minor

 1) {nimbus.host} {nimbus.thrift.port} {storm.version} will be stored in  
 {storm.zookeeper.root}/nimbus like  localhost:8826:0.9.3-r1234
 2) Storm Clients only need to configure {storm.zookeeper.root} to get Nimbus 
 Server Information, Configuration like {nimbus.host} {nimbus.thrift.port} 
 {storm.version} will be ignored



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (STORM-534) Store Nimbus Server Information in zookeeper path {storm.zookeeper.root}/nimbus

2015-02-03 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/STORM-534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14304566#comment-14304566
 ] 

ASF GitHub Bot commented on STORM-534:
--

Github user harshach commented on a diff in the pull request:

https://github.com/apache/storm/pull/394#discussion_r24060103
  
--- Diff: storm-core/src/clj/backtype/storm/daemon/nimbus.clj ---
@@ -18,12 +18,17 @@
[java.util Collections])
   (:import [java.io FileNotFoundException])
   (:import [java.nio.channels Channels WritableByteChannel])
+  (:import [backtype.storm.utils VersionInfo])
   (:import [backtype.storm.security.auth ThriftServer ThriftConnectionType 
ReqContext AuthUtils])
   (:use [backtype.storm.scheduler.DefaultScheduler])
   (:import [backtype.storm.scheduler INimbus SupervisorDetails WorkerSlot 
TopologyDetails
 Cluster Topologies SchedulerAssignment SchedulerAssignmentImpl 
DefaultScheduler ExecutorDetails])
+ HEAD
--- End diff --

some merge conflicts made into PR. This won't be able to compile.


 Store Nimbus Server Information in zookeeper path 
 {storm.zookeeper.root}/nimbus
 ---

 Key: STORM-534
 URL: https://issues.apache.org/jira/browse/STORM-534
 Project: Apache Storm
  Issue Type: Improvement
Affects Versions: 0.10.0
Reporter: caofangkun
Assignee: caofangkun
Priority: Minor

 1) {nimbus.host} {nimbus.thrift.port} {storm.version} will be stored in  
 {storm.zookeeper.root}/nimbus like  localhost:8826:0.9.3-r1234
 2) Storm Clients only need to configure {storm.zookeeper.root} to get Nimbus 
 Server Information, Configuration like {nimbus.host} {nimbus.thrift.port} 
 {storm.version} will be ignored



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (STORM-534) Store Nimbus Server Information in zookeeper path {storm.zookeeper.root}/nimbus

2015-02-03 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/STORM-534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14303617#comment-14303617
 ] 

ASF GitHub Bot commented on STORM-534:
--

Github user revans2 commented on the pull request:

https://github.com/apache/storm/pull/394#issuecomment-72693203
  
Sorry this took me so long to respond to.  I am kind of swamped :).  I do 
like the idea of being able to access the version numbers for nimbus, but also 
for the supervisors.  This becomes especially important for HA and rolling 
upgrades of large clusters. It is good to be able to verify that all of the 
nodes are on the versions you expect them to be on.  I am OK with it being 
stored in ZK, so long as it is not written/read very frequently.

Also if you think the configuration takes up too much room please take a 
look at https://github.com/apache/storm/pull/328 which makes the config 
paginated.


 Store Nimbus Server Information in zookeeper path 
 {storm.zookeeper.root}/nimbus
 ---

 Key: STORM-534
 URL: https://issues.apache.org/jira/browse/STORM-534
 Project: Apache Storm
  Issue Type: Improvement
Affects Versions: 0.10.0
Reporter: caofangkun
Assignee: caofangkun
Priority: Minor

 1) {nimbus.host} {nimbus.thrift.port} {storm.version} will be stored in  
 {storm.zookeeper.root}/nimbus like  localhost:8826:0.9.3-r1234
 2) Storm Clients only need to configure {storm.zookeeper.root} to get Nimbus 
 Server Information, Configuration like {nimbus.host} {nimbus.thrift.port} 
 {storm.version} will be ignored



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (STORM-534) Store Nimbus Server Information in zookeeper path {storm.zookeeper.root}/nimbus

2015-02-03 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/STORM-534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14303620#comment-14303620
 ] 

ASF GitHub Bot commented on STORM-534:
--

Github user revans2 commented on the pull request:

https://github.com/apache/storm/pull/394#issuecomment-72693402
  
@caofangkun If you want to reopen this and just add in the nimbus version 
information I would support that.


 Store Nimbus Server Information in zookeeper path 
 {storm.zookeeper.root}/nimbus
 ---

 Key: STORM-534
 URL: https://issues.apache.org/jira/browse/STORM-534
 Project: Apache Storm
  Issue Type: Improvement
Affects Versions: 0.10.0
Reporter: caofangkun
Assignee: caofangkun
Priority: Minor

 1) {nimbus.host} {nimbus.thrift.port} {storm.version} will be stored in  
 {storm.zookeeper.root}/nimbus like  localhost:8826:0.9.3-r1234
 2) Storm Clients only need to configure {storm.zookeeper.root} to get Nimbus 
 Server Information, Configuration like {nimbus.host} {nimbus.thrift.port} 
 {storm.version} will be ignored



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (STORM-534) Store Nimbus Server Information in zookeeper path {storm.zookeeper.root}/nimbus

2015-02-03 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/STORM-534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14304426#comment-14304426
 ] 

ASF GitHub Bot commented on STORM-534:
--

Github user caofangkun commented on the pull request:

https://github.com/apache/storm/pull/394#issuecomment-72770805
  
@revans2 
Yes, not only nimbus server version numbers , but also supervisors and ui 
should show up version numbers on UI .
In face , it may be better add supervsior version numbers in issue:
https://issues.apache.org/jira/browse/STORM-619
“add supervisor page to show workers running detail informations ”


 Store Nimbus Server Information in zookeeper path 
 {storm.zookeeper.root}/nimbus
 ---

 Key: STORM-534
 URL: https://issues.apache.org/jira/browse/STORM-534
 Project: Apache Storm
  Issue Type: Improvement
Affects Versions: 0.10.0
Reporter: caofangkun
Assignee: caofangkun
Priority: Minor

 1) {nimbus.host} {nimbus.thrift.port} {storm.version} will be stored in  
 {storm.zookeeper.root}/nimbus like  localhost:8826:0.9.3-r1234
 2) Storm Clients only need to configure {storm.zookeeper.root} to get Nimbus 
 Server Information, Configuration like {nimbus.host} {nimbus.thrift.port} 
 {storm.version} will be ignored



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (STORM-534) Store Nimbus Server Information in zookeeper path {storm.zookeeper.root}/nimbus

2015-01-25 Thread caofangkun (JIRA)

[ 
https://issues.apache.org/jira/browse/STORM-534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14291373#comment-14291373
 ] 

caofangkun commented on STORM-534:
--

[~rams]

1: supervisor nodes do not need to config nimbus.host/nimbus.thrift.port, add 
will be much easier for Nimbus Server HA 
2: Storm Client do not need to config nimbus.host/nimbus.thirft.port too , add 
will be helpful for storm runinng on Yarn or Docker.  Thanks [~naggarwal]
3: do not need to restarted  UI Service if nimbus.host changed 
4: more easier to share nimbus server information (host ,port, version and so 
on) to outer softwares like monior system.


 Store Nimbus Server Information in zookeeper path 
 {storm.zookeeper.root}/nimbus
 ---

 Key: STORM-534
 URL: https://issues.apache.org/jira/browse/STORM-534
 Project: Apache Storm
  Issue Type: Improvement
Affects Versions: 0.10.0
Reporter: caofangkun
Assignee: caofangkun
Priority: Minor

 1) {nimbus.host} {nimbus.thrift.port} {storm.version} will be stored in  
 {storm.zookeeper.root}/nimbus like  localhost:8826:0.9.3-r1234
 2) Storm Clients only need to configure {storm.zookeeper.root} to get Nimbus 
 Server Information, Configuration like {nimbus.host} {nimbus.thrift.port} 
 {storm.version} will be ignored



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (STORM-534) Store Nimbus Server Information in zookeeper path {storm.zookeeper.root}/nimbus

2015-01-25 Thread Sriharsha Chintalapani (JIRA)

[ 
https://issues.apache.org/jira/browse/STORM-534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14291385#comment-14291385
 ] 

Sriharsha Chintalapani commented on STORM-534:
--

[~caofangkun] one of the easiest way to deploy configurations for storm is to 
deploy same storm.yaml on all the nodes. 
I'll let others speak if they think it adds value but IMO I don't think these 
config changes and pushing into zookeeper is necessity and causes unnecessary 
confusion to the user/admin as they now have different configs on different 
hosts to deal with.  
cc [~ptgoetz] [~revans2]

 Store Nimbus Server Information in zookeeper path 
 {storm.zookeeper.root}/nimbus
 ---

 Key: STORM-534
 URL: https://issues.apache.org/jira/browse/STORM-534
 Project: Apache Storm
  Issue Type: Improvement
Affects Versions: 0.10.0
Reporter: caofangkun
Assignee: caofangkun
Priority: Minor

 1) {nimbus.host} {nimbus.thrift.port} {storm.version} will be stored in  
 {storm.zookeeper.root}/nimbus like  localhost:8826:0.9.3-r1234
 2) Storm Clients only need to configure {storm.zookeeper.root} to get Nimbus 
 Server Information, Configuration like {nimbus.host} {nimbus.thrift.port} 
 {storm.version} will be ignored



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (STORM-534) Store Nimbus Server Information in zookeeper path {storm.zookeeper.root}/nimbus

2015-01-24 Thread Nitin Aggarwal (JIRA)

[ 
https://issues.apache.org/jira/browse/STORM-534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14290968#comment-14290968
 ] 

Nitin Aggarwal commented on STORM-534:
--

We have a use case, where we are running storm using slider on YARN. As we have 
dynamic nimbus node and thrift port, it would be helpful, to get this 
information from zookeeper, for submitting topologies remotely to the cluster.

 Store Nimbus Server Information in zookeeper path 
 {storm.zookeeper.root}/nimbus
 ---

 Key: STORM-534
 URL: https://issues.apache.org/jira/browse/STORM-534
 Project: Apache Storm
  Issue Type: Improvement
Affects Versions: 0.10.0
Reporter: caofangkun
Assignee: caofangkun
Priority: Minor

 1) {nimbus.host} {nimbus.thrift.port} {storm.version} will be stored in  
 {storm.zookeeper.root}/nimbus like  localhost:8826:0.9.3-r1234
 2) Storm Clients only need to configure {storm.zookeeper.root} to get Nimbus 
 Server Information, Configuration like {nimbus.host} {nimbus.thrift.port} 
 {storm.version} will be ignored



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (STORM-534) Store Nimbus Server Information in zookeeper path {storm.zookeeper.root}/nimbus

2015-01-23 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/STORM-534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14288992#comment-14288992
 ] 

ASF GitHub Bot commented on STORM-534:
--

GitHub user caofangkun opened a pull request:

https://github.com/apache/storm/pull/394

STORM-534:Store Nimbus Server Information in zookeeper path 
{storm.zookeeper.root}/nimbus

Store Nimbus Server Information in zookeeper path 
{storm.zookeeper.root}/nimbus
like {nimbus_host_name}:{nimbus_thrift_port}
May add more information like nimbus server version Information ?


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/caofangkun/apache-storm storm-534

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/storm/pull/394.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #394


commit 6c04e1bea802d28ae92a234ddbaad2c1ed0a6835
Author: caofangkun caofang...@gmail.com
Date:   2015-01-23T01:28:46Z

Merge pull request #4 from apache/master

Merger from apache/storm to caofangkun/apache-storm

commit 52cbe5f6459f0923c7eda573df1ad5b792c5ba98
Author: caofangkun caofang...@gmail.com
Date:   2015-01-23T08:55:42Z

STORM-534:Store Nimbus Server Information in zookeeper path 
{storm.zookeeper.root}/nimbus

commit 55f95b52f5f49c5572d81d6b653babafa67750c4
Author: caofangkun caofang...@gmail.com
Date:   2015-01-23T09:02:21Z

STORM-534:Store Nimbus Server Information in zookeeper path 
{storm.zookeeper.root}/nimbus




 Store Nimbus Server Information in zookeeper path 
 {storm.zookeeper.root}/nimbus
 ---

 Key: STORM-534
 URL: https://issues.apache.org/jira/browse/STORM-534
 Project: Apache Storm
  Issue Type: Improvement
Affects Versions: 0.10.0
Reporter: caofangkun
Assignee: caofangkun
Priority: Minor

 1) {nimbus.host} {nimbus.thrift.port} {storm.version} will be stored in  
 {storm.zookeeper.root}/nimbus like  localhost:8826:0.9.3-r1234
 2) Storm Clients only need to configure {storm.zookeeper.root} to get Nimbus 
 Server Information, Configuration like {nimbus.host} {nimbus.thrift.port} 
 {storm.version} will be ignored



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (STORM-534) Store Nimbus Server Information in zookeeper path {storm.zookeeper.root}/nimbus

2015-01-23 Thread Sriharsha Chintalapani (JIRA)

[ 
https://issues.apache.org/jira/browse/STORM-534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14289417#comment-14289417
 ] 

Sriharsha Chintalapani commented on STORM-534:
--

[~caofangkun] can you explain benefit of storing this info on zookeeper , 
instead of in config files like today. 

 Store Nimbus Server Information in zookeeper path 
 {storm.zookeeper.root}/nimbus
 ---

 Key: STORM-534
 URL: https://issues.apache.org/jira/browse/STORM-534
 Project: Apache Storm
  Issue Type: Improvement
Affects Versions: 0.10.0
Reporter: caofangkun
Assignee: caofangkun
Priority: Minor

 1) {nimbus.host} {nimbus.thrift.port} {storm.version} will be stored in  
 {storm.zookeeper.root}/nimbus like  localhost:8826:0.9.3-r1234
 2) Storm Clients only need to configure {storm.zookeeper.root} to get Nimbus 
 Server Information, Configuration like {nimbus.host} {nimbus.thrift.port} 
 {storm.version} will be ignored



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)