DO NOT REPLY [Bug 38628] New: - MockResponseWriter.getWriter()

2006-02-13 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=38628.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38628

   Summary: MockResponseWriter.getWriter()
   Product: Struts
   Version: Nightly Build
  Platform: Other
OS/Version: other
Status: NEW
  Severity: normal
  Priority: P4
 Component: Shale
AssignedTo: dev@struts.apache.org
ReportedBy: [EMAIL PROTECTED]
CC: [EMAIL PROTECTED]


A getter for the writer would help remove 
http://svn.apache.org/viewcvs.cgi/myfaces/commons/trunk/src/test/java/org/apache
/myfaces/test/MockResponseWriter.java?rev=360528view=markup

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 38628] - MockResponseWriter.getWriter()

2006-02-13 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=38628.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38628





--- Additional Comments From [EMAIL PROTECTED]  2006-02-13 09:08 ---
Created an attachment (id=17676)
 -- (http://issues.apache.org/bugzilla/attachment.cgi?id=17676action=view)
exposes writer


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[EMAIL PROTECTED]: Project struts-taglib (in module struts) failed

2006-02-13 Thread Stefan Bodewig
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at [EMAIL PROTECTED]

Project struts-taglib has an issue affecting its community integration.
This issue affects 9 projects,
 and has been outstanding for 16 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- jakarta-tomcat-5 :  Servlet 2.4 and JSP 2.0 Reference Implementation
- jakarta-velocity-tools :  Velocity-Tools project
- portals-bridges-frameworks :  Support for JSR168 compliant Portlet 
development
- portals-bridges-struts :  Support for JSR168 compliant Portlet development
- portals-bridges-velocity :  Support for JSR168 compliant Portlet 
development
- smartfrog-tomcat :  Smartfrog: Application Deployment from HP Laboratories
- struts-el :  Model 2 Model-View-Controller framework for Servlets and JSP
- struts-sslext :  The Struts SSL Extension for HTTP/HTTPS switching
- struts-taglib :  Model 2 Model-View-Controller framework for Servlets and 
JSP


Full details are available at:
http://vmgump.apache.org/gump/public/struts/struts-taglib/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Sole output [struts-taglib-13022006.jar] identifier set to project name
 -DEBUG- Dependency on xdoclet exists, no need to add for property 
maven.jar.xdoclet.
 -DEBUG- Dependency on xdoclet exists, no need to add for property 
maven.jar.xdoclet-web-module.
 -DEBUG- Dependency on xdoclet exists, no need to add for property 
maven.jar.xdoclet-ejb-module.
 -DEBUG- Dependency on xdoclet exists, no need to add for property 
maven.jar.xdoclet-apache-module.
 -DEBUG- Dependency on xdoclet exists, no need to add for property 
maven.jar.xdoclet-xdoclet-module.
 -DEBUG- Dependency on jakarta-servletapi-4 exists, no need to add for property 
maven.jar.servlet-api.
 -DEBUG- Dependency on xdoclet exists, no need to add for property 
maven.jar.xdoclet-hibernate-module.
 -DEBUG- Dependency on xdoclet exists, no need to add for property 
maven.jar.xdoclet-jdo-module.
 -DEBUG- Dependency on xdoclet exists, no need to add for property 
maven.jar.xdoclet-jmx-module.
 -DEBUG- Dependency on xdoclet exists, no need to add for property 
maven.jar.xdoclet-portlet-module.
 -DEBUG- (Gump generated) Maven Properties in: 
/usr/local/gump/public/workspace/struts/taglib/build.properties
 -INFO- Failed with reason build failed
 -DEBUG- Maven POM in: 
/usr/local/gump/public/workspace/struts/taglib/project.xml
 -DEBUG- Maven project properties in: 
/usr/local/gump/public/workspace/struts/taglib/project.properties
 -INFO- Failed to extract fallback artifacts from Gump Repository



The following work was performed:
http://vmgump.apache.org/gump/public/struts/struts-taglib/gump_work/build_struts_struts-taglib.html
Work Name: build_struts_struts-taglib (Type: Build)
Work ended in a state of : Failed
Elapsed: 7 secs
Command Line: maven --offline jar 
[Working Directory: /usr/local/gump/public/workspace/struts/taglib]
CLASSPATH: 

[Struts Wiki] Trivial Update of StrutsNewFaqs by FrankZammetti

2006-02-13 Thread Apache Wiki
Dear Wiki user,

You have subscribed to a wiki page or wiki category on Struts Wiki for change 
notification.

The following page has been changed by FrankZammetti:
http://wiki.apache.org/struts/StrutsNewFaqs

--
   *  PreInitializeActionForm
   *  StrutsPlugins
   *  ServingPdfDocuments
+  *  OpenWindowFromAction
  
  
  * 

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[Struts Wiki] Update of OpenWindowFromAction by FrankZammetti

2006-02-13 Thread Apache Wiki
Dear Wiki user,

You have subscribed to a wiki page or wiki category on Struts Wiki for change 
notification.

The following page has been changed by FrankZammetti:
http://wiki.apache.org/struts/OpenWindowFromAction

New page:
= How to open a new window from an Action =

Another frequent question on the mailing lists is how to open a new browser 
window from an Action.  This one won't take too long:

YOU CAN'T!

:)

Strictly-speaking, this is true... code running on the server has no way to 
tell the browser to open the response in a new window.  That being said, there 
'''ARE''' a couple of ways to get the desired effect.

 * Perhaps the easiest way is to set the target of the form you submit to 
_new.  This will open a new window in which the results returned by the 
server will be shown.  Note that this will ALWAYS happen, there is no standard 
way to only use this target some of the time.  You can however use Javascript 
to variably set and clear the target attribute if you need to sometimes open a 
window and sometimes not, perhaps depending on whether a given checkbox is 
checked or not.

 * You can manually open a window using Javascript, and from there submit the 
form.  This will usually involve copying the values from the form in the parent 
document to a copy of it in the child window, and then programmatically 
submitting it.  This can be a good option if you are essentially spawning a 
navigational subbranch in your application and not simply showing results 
(i.e., a parallel task the user can perform vs. just showing a generated PDF).

 * A third option is to use AJAX.  You may not know it, but you can return 
Javascript from the server via an AJAX call and execute it.  What you can do is 
return something along these lines (this would literally be the HTTP response 
text):

{{{
   s = ;
   s += htmlheadtitleResults/title/headbody;
   s += These are my results;
   s += /body/html;
   w = window.open(, Results, resizable,height=200,width=200);
   w.document.open();
   w.document.write(s);
   w.documenmt.close();
}}}

Imagine generating this in an Action, where the string These are my results 
is replaced by a full HTML page (properly escaped of course).  Yes, you could 
generated the response with a JSP, which is what I would recommend.  That might 
be confusing, so let me explain... a JSP does '''NOTE''' have to render a 
complete HTML document.  It can instead render just a snippet of HTML, or just 
some Javascript, or just some comma-separated data, there is no limitation.  If 
you are doing AJAX, whatever is most appropriate can be done via JSPs (like XML 
too!).  This saved you from writing a lot of println's in your Actions to 
generate a response.

Now, if you make an AJAX call to this Action, and return this content and 
execute it, you will get your response opened in a new window.  Neat, huh?!?  
If you decide to go this route, I suggest checking out !AjaxTags in the Java 
Web Parts project (http://javawebparts.sourceforge.net).  It will allow you to 
put a single custom tag on your page and save you from having to write the AJAX 
code or the code to execute the returned results (although you will still have 
to write the code in the Action).

= Takeaway point =

The important point to take away from all this is that aside from the target 
attribute on the form tag, Javascript is involved.  There is currently no good 
way to avoid that (and someone can correct me if I missed something).  If you 
are working in an environment where scripting is a problem, you may want to 
revisit your design and see if you really need a new window at all.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [VOTE] Confirm the Struts Action Library 1.3.0 release plan

2006-02-13 Thread Gary VanMatre
From: Ted Husted [EMAIL PROTECTED] 

 OK, we're back down to two patches that could be applied this weekend. 
 
 * http://wiki.apache.org/struts/StrutsClassicRelease130 
 
 After resolving these items, I'd like to tag and roll the 1.3.0 
 release on Monday Feburary 13. 
 
 There would be a 1.3.0 release for each of the seven dwarfs, and a 
 Library ZIP file with just the JARS utilized by all seven. (Except 
 the Servlet and JSTL JARs, unless we can redistribute these too.) 
 
 Again, this is not a vote on the quality of the release, only whether 
 to tag the trunk with the marker STRUTS_1_3_0. 
 

+1  for consistency 

 -Ted. 
 
 
 On 11/21/05, Ted Husted wrote: 
  There are two significant items left on the Struts Action Library 
  1.3.0 (aka Struts Classic) release plan before we would tag and roll 
  it. One is renaming struts-action to struts-core, and the other are 
  minor changes to the documentation. 
  
  * http://wiki.apache.org/struts/StrutsClassicRelease130 
  
  At this time, I would ask the PMC, committers, and other interested 
  parties to review the plan and the state of the repository. Please 
  indicate your opinion on the plan in the usual style: +1, +0, or -1, 
  along with any appropriate comments. 
  
  Note this this is not a vote on the quality of the intended release, 
  but on the release plan. 
  
  Given a positive result, it would be our intention to roll the release 
  on Thursday or Friday, assuming we rename the struts-core folder on 
  Wednesday. 
  
  As stated in the plan, this release is intended as a test of the new 
  infrastructure, and other releases in the 1.3.x series are expected. 
  
  -Ted. 
 
 - 
 To unsubscribe, e-mail: [EMAIL PROTECTED] 
 For additional commands, e-mail: [EMAIL PROTECTED] 
 

svn commit: r377457 - /struts/shale/trunk/test-framework/src/java/org/apache/shale/test/mock/MockResponseWriter.java

2006-02-13 Thread craigmcc
Author: craigmcc
Date: Mon Feb 13 10:58:46 2006
New Revision: 377457

URL: http://svn.apache.org/viewcvs?rev=377457view=rev
Log:
Add a getter to access the underlying writer.

PR:  Bugzlla #38628
Submitted by:  Dennis C. Byrne dennis AT dbyrne.net

Modified:

struts/shale/trunk/test-framework/src/java/org/apache/shale/test/mock/MockResponseWriter.java

Modified: 
struts/shale/trunk/test-framework/src/java/org/apache/shale/test/mock/MockResponseWriter.java
URL: 
http://svn.apache.org/viewcvs/struts/shale/trunk/test-framework/src/java/org/apache/shale/test/mock/MockResponseWriter.java?rev=377457r1=377456r2=377457view=diff
==
--- 
struts/shale/trunk/test-framework/src/java/org/apache/shale/test/mock/MockResponseWriter.java
 (original)
+++ 
struts/shale/trunk/test-framework/src/java/org/apache/shale/test/mock/MockResponseWriter.java
 Mon Feb 13 10:58:46 2006
@@ -49,6 +49,10 @@
 // - Mock Object 
Methods
 
 
+public Writer getWriter() {
+return this.writer;
+}
+
 
 // -- ResponseWriter 
Methods
 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r377460 - in /struts/action/trunk/src/java/org/apache/struts/validator: DynaValidatorActionForm.java ValidatorActionForm.java

2006-02-13 Thread husted
Author: husted
Date: Mon Feb 13 11:02:28 2006
New Revision: 377460

URL: http://svn.apache.org/viewcvs?rev=377460view=rev
Log:
Extras
* Move ValidatorActionForm.java and DynaValidatorActionForm.java into Extras, 
which key on the mapping's path attribute rather than the name attribute.

Removed:

struts/action/trunk/src/java/org/apache/struts/validator/DynaValidatorActionForm.java

struts/action/trunk/src/java/org/apache/struts/validator/ValidatorActionForm.java


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r377464 - /struts/action/trunk/xdocs/faqs/kickstart.fml

2006-02-13 Thread husted
Author: husted
Date: Mon Feb 13 11:05:41 2006
New Revision: 377464

URL: http://svn.apache.org/viewcvs?rev=377464view=rev
Log:
Action Kickstart 
* Add new FAQS regarding whether Struts entered a greenfield. 

Modified:
struts/action/trunk/xdocs/faqs/kickstart.fml

Modified: struts/action/trunk/xdocs/faqs/kickstart.fml
URL: 
http://svn.apache.org/viewcvs/struts/action/trunk/xdocs/faqs/kickstart.fml?rev=377464r1=377463r2=377464view=diff
==
--- struts/action/trunk/xdocs/faqs/kickstart.fml (original)
+++ struts/action/trunk/xdocs/faqs/kickstart.fml Mon Feb 13 11:05:41 2006
@@ -82,17 +82,81 @@
 implementation for a servlet 2.3 and JSP 1.2 container.
 /p
 pAfter serving as the co-lead of the JSR 127 specification
-(JavaServerFaces), Craig created another rendition of 
Struts
+(JavaServerFaces), Craig created another rendition of
+Struts
 based on JavaServerFaces, called Shale. Both Struts Action
 Framework and Struts Shale are first-class citizens of the
 Apache Struts project./p
 /answer
 /faq
 
+faq id=first
+questionWas Struts Action the first web application framework
+for Java?/question
+answer
+pNo, not by a long shot. When Struts 1.0 shipped in June
+2001, there were already several other web application
+frameworks available, including Barracuda, Expresso,
+Maverick, Tapestry, and Turbine, to name a few. Struts did
+not enter a greenfield. Back in the day, there were
+lively comparisons between the available frameworks,
+just as there is today.
+/p
+/answer
+/faq
+
+faq id=popular
+questionIs Struts Action the most popular web application
+framework for Java?/question
+answer
+pYes. By any objective measure, Struts Action continues to
+be the most popular web application framework for
+Java./p
+pAs of 2006, the vast majority of job offerings for Java
+developers cite Struts as prerequisite. According to
+OnJava magazine between their reader surveys for 2005 and
+2004 the popularity of Struts remained steady. Likewise,
+the number of Struts articles published in all online
+journals also remained constant between 2004 and 2005. New
+and updated books about Struts continue to be published
+regularly./p
+pWhile some people characterize the space of Java web
+application framework as being fragmented, the truth is
+that
+bmore web developers use Struts Action than all other
+alternatives combined./b
+This observation is as true in 2006 as it was in 2005,
+as it was in 2004. It's probably been true since Struts
+released its 1.0 version in 2001.
+/p
+pOf course, some developers are finding that JavaServer
+Faces can be a faster way to write new applications,
+especially clean-cut intranet applications. And
+that's great! More than anything else, every Struts
+committer wants every developer to get more out of every
+work day. (We're developers too!) As these new JSF
+applications
+grow in complexity, Struts Shale is ready to do for
+emJSF/em
+developers what Struts Action has
+been doing for
+emJSP/em
+developers, year after year
+after year.
+/p
+pMeanwhile, enterprise web developers who have standardized
+on Struts Action can be assured that new releases of
+Action 1 will continue, even as we break new ground with
+the upcoming release of Struts Action 2 (formerly known as
+WebWork)./p
+/answer
+/faq
+
 faq id=where
-answer
-name=Where can I get a copy of Struts Action Framework?
-pThe best place to download Apahce Struts products is at
+questionWhere can I get a copy of Struts Action
+Framework?/question
+answer
+pThe best place to download Apache Struts products is at
 

Re: [VOTE] Confirm the Struts Action Library 1.3.0 release plan

2006-02-13 Thread Joe Germuska

At 10:24 AM -0800 2/13/06, Don Brown wrote:

+1  Lets just get something out the door already :)


+1 and amen

--
Joe Germuska
[EMAIL PROTECTED] * http://blog.germuska.com


You really can't burn anything out by trying something new, and
even if you can burn it out, it can be fixed.  Try something new.
-- Robert Moog

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: 1.3 action pre-release, does jsp:include page=/do/myAct / work?

2006-02-13 Thread Wendy Smoak
On 2/13/06, Wolfgang Gehner [EMAIL PROTECTED] wrote:

 Hi guys,

 I just plopped the nightlies of Feb 12 into a project (struts_action) and

 jsp:include page=/do/myAct /

 doesn't work for me (:
 Always did with 1.1, 1.2 I think I had previously raised a bug on this,
 but I honestly don't remember.
 It affects the use of actions within c:import and Tiles definitions, too.

Looks like you did:
   http://issues.apache.org/bugzilla/show_bug.cgi?id=36579

Can you please confirm that it's the same issue, and attach your new
patch there?

Thanks,
Wendy

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 36579] - Tiles that use actions appear broken

2006-02-13 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=36579.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=36579


[EMAIL PROTECTED] changed:

   What|Removed |Added

  Attachment #16352|0   |1
is obsolete||




--- Additional Comments From [EMAIL PROTECTED]  2006-02-13 20:20 ---
Created an attachment (id=17680)
 -- (http://issues.apache.org/bugzilla/attachment.cgi?id=17680action=view)
A fix validated for jsp:include and c:import, covering same issue

Here's a fixed version, which works for me, based on a very recent version of
PerformForward. (change of package name of the class in my attachment
required).

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: 1.3 action pre-release, does jsp:include page=/do/myAct / work?

2006-02-13 Thread Wolfgang Gehner

Wendy Smoak wrote:


On 2/13/06, Wolfgang Gehner [EMAIL PROTECTED] wrote:

 


Hi guys,

I just plopped the nightlies of Feb 12 into a project (struts_action) and

jsp:include page=/do/myAct /

doesn't work for me (:
Always did with 1.1, 1.2 I think I had previously raised a bug on this,
but I honestly don't remember.
It affects the use of actions within c:import and Tiles definitions, too.
   



Looks like you did:
  http://issues.apache.org/bugzilla/show_bug.cgi?id=36579

Can you please confirm that it's the same issue, and attach your new
patch there?
 


Yes, same issue, and I just attached my working versiion.

Wolfgang


Thanks,
Wendy

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


 





Re: svn commit: r377460 - in /struts/action/trunk/src/java/org/apache/struts/validator: DynaValidatorActionForm.java ValidatorActionForm.java

2006-02-13 Thread Paul Benedict
Ted,

 By default, when an Action is cancelled, validation is bypassed  
and the Action should not execute the business operation.

I think you wording is confusing. When I read should not execute the business 
operation I strongly inferred should not execute the execute method. This 
would obivously be untrue. I don't know if that's what you meant, but I 
recommend a different choice of words or omit the ending clause.

Paul


-
 
 What are the most popular cars? Find out at Yahoo! Autos 

DO NOT REPLY [Bug 38374] - Validation always skipped with Globals.CANCEL_KEY

2006-02-13 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=38374.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38374





--- Additional Comments From [EMAIL PROTECTED]  2006-02-13 21:28 ---
Paul, I just noticed that the patch for 1.2.9 includes an @author tag. The
Apache Struts Project no longer uses @author tags. Please acknowledge that the
author tag can be removed. Otherwise, we will not be able to accept the patch. 




-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [Struts Wiki] Update of StrutsClassicRelease130 by TedHusted

2006-02-13 Thread Ted Husted
On 2/13/06, Martin Cooper [EMAIL PROTECTED] wrote:
== Special Issues ==
 
  - Struts Classic 1.3.0 is


 Shouldn't we be changing this to Struts Action 1.3.0 is?

Well, right now, I'm thinking that we are using Struts Classic as a
nickname for the set of seven subprojects that we extracted from
Struts 1.2.8.

But, we probably do  want to drop the draft release plan for
StrutsClassic131, since 1.3.0 would probably be the only release of
Struts Classic as such. After this, each of the subprojects can be
released independantly under their own release plans. (Action 1.3.1,
Taglib 1.3.1, and so forth.)

-Ted.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: DO NOT REPLY [Bug 38374] - Validation always skipped with Globals.CANCEL_KEY

2006-02-13 Thread Paul Benedict
Ted, you can remove it. Thanks for the heads-up! I didn't know any rule like 
that existed -- I was just trying to do proper javadoc I blame Sun :)



-
Brings words and photos together (easily) with
 PhotoMail  - it's free and works with Yahoo! Mail.

svn commit: r377562 - in /struts/action/trunk/src/java/org/apache/struts: action/InvalidCancelException.java chain/commands/AbstractValidateActionForm.java chain/commands/servlet/PerformForward.java c

2006-02-13 Thread husted
Author: husted
Date: Mon Feb 13 17:28:41 2006
New Revision: 377562

URL: http://svn.apache.org/viewcvs?rev=377562view=rev
Log:
Resolve #38374 Validation always skipped with Globals.CANCEL_KEY reported by 
Paul Benedict 
* ActionConfig: Add cancellable property
* AbstractValidationActionForm: Throw InvalidCancelException if Cancel token 
present but cancellable not set 
* Add InvalidCancelException class

Added:

struts/action/trunk/src/java/org/apache/struts/action/InvalidCancelException.java
   (with props)
Modified:

struts/action/trunk/src/java/org/apache/struts/chain/commands/AbstractValidateActionForm.java

struts/action/trunk/src/java/org/apache/struts/chain/commands/servlet/PerformForward.java
struts/action/trunk/src/java/org/apache/struts/config/ActionConfig.java

Added: 
struts/action/trunk/src/java/org/apache/struts/action/InvalidCancelException.java
URL: 
http://svn.apache.org/viewcvs/struts/action/trunk/src/java/org/apache/struts/action/InvalidCancelException.java?rev=377562view=auto
==
--- 
struts/action/trunk/src/java/org/apache/struts/action/InvalidCancelException.java
 (added)
+++ 
struts/action/trunk/src/java/org/apache/struts/action/InvalidCancelException.java
 Mon Feb 13 17:28:41 2006
@@ -0,0 +1,25 @@
+package org.apache.struts.action;
+
+
+/**
+ * p Thrown when a token generated by the Cancel tag is found in the
+ * request, but the cancellable property for the Action Mapping is not set.
+ * /p
+ */
+public class InvalidCancelException extends Exception {
+/**
+ * pDefault constructor./p
+ */
+public InvalidCancelException() {
+super();
+}
+
+/**
+ * pConstruct the exception with the specified message./p
+ *
+ * @param message the message
+ */
+public InvalidCancelException(String message) {
+super(message);
+}
+}

Propchange: 
struts/action/trunk/src/java/org/apache/struts/action/InvalidCancelException.java
--
svn:eol-style = native

Modified: 
struts/action/trunk/src/java/org/apache/struts/chain/commands/AbstractValidateActionForm.java
URL: 
http://svn.apache.org/viewcvs/struts/action/trunk/src/java/org/apache/struts/chain/commands/AbstractValidateActionForm.java?rev=377562r1=377561r2=377562view=diff
==
--- 
struts/action/trunk/src/java/org/apache/struts/chain/commands/AbstractValidateActionForm.java
 (original)
+++ 
struts/action/trunk/src/java/org/apache/struts/chain/commands/AbstractValidateActionForm.java
 Mon Feb 13 17:28:41 2006
@@ -1,24 +1,10 @@
-/*
- * $Id$
- *
- * Copyright 2003-2005 The Apache Software Foundation.
- *
- * Licensed under the Apache License, Version 2.0 (the License);
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *  http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an AS IS BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
 package org.apache.struts.chain.commands;
 
+import org.apache.commons.logging.Log;
+import org.apache.commons.logging.LogFactory;
 import org.apache.struts.action.ActionErrors;
 import org.apache.struts.action.ActionForm;
+import org.apache.struts.action.InvalidCancelException;
 import org.apache.struts.chain.contexts.ActionContext;
 import org.apache.struts.config.ActionConfig;
 
@@ -32,6 +18,44 @@
  */
 public abstract class AbstractValidateActionForm extends ActionCommandBase {
 // -- Instance 
Variables
+
+/**
+ * p Provide Commons Logging instance for this class. /p
+ */
+private static final Log LOG =
+LogFactory.getLog(AbstractSelectForward.class);
+
+// -- Protected Methods
+
+/**
+ * pHelper method to verify the Cancel state./p
+ *
+ * pIf the state is invalid, Cancel is unset and an
+ * InvalidCancelException is thrown./p
+ *
+ * @param actionCtxOur ActionContext
+ * @param actionConfig Our ActionConfig
+ * @return true if cancel is set, false otherwise.
+ * @throws InvalidCancelException
+ */
+private boolean isCancelled(ActionContext actionCtx,
+ActionConfig actionConfig)
+throws InvalidCancelException {
+Boolean cancel = actionCtx.getCancelled();
+boolean cancelled = ((cancel != null)  cancel.booleanValue());
+boolean cancellable = actionConfig.getCancellable();
+
+boolean invalidState = (cancelled  !cancellable);
+
+if (invalidState) {
+  

svn commit: r377564 - in /struts/apps/trunk/examples/src: java/org/apache/struts/webapp/exercise/MessageResources.properties webapp/WEB-INF/exercise/struts-config.xml

2006-02-13 Thread husted
Author: husted
Date: Mon Feb 13 17:32:25 2006
New Revision: 377564

URL: http://svn.apache.org/viewcvs?rev=377564view=rev
Log:
Cancellable 
* Refine test page for cancellable property 

Modified:

struts/apps/trunk/examples/src/java/org/apache/struts/webapp/exercise/MessageResources.properties
struts/apps/trunk/examples/src/webapp/WEB-INF/exercise/struts-config.xml

Modified: 
struts/apps/trunk/examples/src/java/org/apache/struts/webapp/exercise/MessageResources.properties
URL: 
http://svn.apache.org/viewcvs/struts/apps/trunk/examples/src/java/org/apache/struts/webapp/exercise/MessageResources.properties?rev=377564r1=377563r2=377564view=diff
==
--- 
struts/apps/trunk/examples/src/java/org/apache/struts/webapp/exercise/MessageResources.properties
 (original)
+++ 
struts/apps/trunk/examples/src/java/org/apache/struts/webapp/exercise/MessageResources.properties
 Mon Feb 13 17:32:25 2006
@@ -6,7 +6,7 @@
 errors.footer=/table
 errors.prefix=trtd
 errors.suffix=/td/tr
-errors.cancel=Cancellable not set for this action: {0}
+errors.invalidCancel=Cancel is a not an valid operation for this Action.
 
 property1error1=Property 1, Error 1
 property2error1=Property 2, Error 1

Modified: 
struts/apps/trunk/examples/src/webapp/WEB-INF/exercise/struts-config.xml
URL: 
http://svn.apache.org/viewcvs/struts/apps/trunk/examples/src/webapp/WEB-INF/exercise/struts-config.xml?rev=377564r1=377563r2=377564view=diff
==
--- struts/apps/trunk/examples/src/webapp/WEB-INF/exercise/struts-config.xml 
(original)
+++ struts/apps/trunk/examples/src/webapp/WEB-INF/exercise/struts-config.xml 
Mon Feb 13 17:32:25 2006
@@ -25,13 +25,14 @@
 action path=/welcome forward=/index.html /
 action path=/bean-write-2 forward=/bean-write-2.jsp /
 action path=/html-cancel forward=/html-cancel.jsp/
-!-- --
-action path=/html-cancel-submit name=testbean 
input=/html-cancel.jsp cancellable=false validate=true 
forward=/welcome.do
-exception
-key=errors.cancel
-type=org.apache.struts.action.InvalidCancelException
-path=/html-cancel.jsp/
-/action
+action path=/html-cancel-true name=testbean input=/html-cancel.jsp 
cancellable=true validate=true forward=/welcome.do/
+ action path=/html-cancel-false name=testbean 
input=/html-cancel.jsp cancellable=false validate=true 
forward=/welcome.do
+  exception
+  key=errors.invalidCancel
+  type=org.apache.struts.action.InvalidCancelException
+  path=/html-cancel.jsp/
+  /action
+
 
 action path=/html-img forward=/html-img.jsp /
  !-- :FIXME: ImageAction should compute module prefix --



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r377572 - in /struts/shale/trunk: build/test-framework/project.xml xdocs/features-reusable-views.xml xdocs/features-tiger-extensions.xml

2006-02-13 Thread wsmoak
Author: wsmoak
Date: Mon Feb 13 17:59:49 2006
New Revision: 377572

URL: http://svn.apache.org/viewcvs?rev=377572view=rev
Log:
Added dependency URLs and fixed a couple of typos.

Modified:
struts/shale/trunk/build/test-framework/project.xml
struts/shale/trunk/xdocs/features-reusable-views.xml
struts/shale/trunk/xdocs/features-tiger-extensions.xml

Modified: struts/shale/trunk/build/test-framework/project.xml
URL: 
http://svn.apache.org/viewcvs/struts/shale/trunk/build/test-framework/project.xml?rev=377572r1=377571r2=377572view=diff
==
--- struts/shale/trunk/build/test-framework/project.xml (original)
+++ struts/shale/trunk/build/test-framework/project.xml Mon Feb 13 17:59:49 2006
@@ -69,6 +69,7 @@
   groupIdstruts/groupId
   artifactIdshale-core/artifactId
   version1.0.1-SNAPSHOT/version
+  urlhttp://struts.apache.org/struts-shale/url
 /dependency
 dependency
   groupIdhtmlunit/groupId
@@ -77,6 +78,7 @@
   properties
 optionaltrue/optional
   /properties
+  urlhttp://htmlunit.sourceforge.net//url
 /dependency
 dependency
   groupIdcommons-httpclient/groupId
@@ -85,6 +87,7 @@
   properties
 optionaltrue/optional
   /properties
+  urlhttp://jakarta.apache.org/commons/httpclient//url
 /dependency
   /dependencies
 

Modified: struts/shale/trunk/xdocs/features-reusable-views.xml
URL: 
http://svn.apache.org/viewcvs/struts/shale/trunk/xdocs/features-reusable-views.xml?rev=377572r1=377571r2=377572view=diff
==
--- struts/shale/trunk/xdocs/features-reusable-views.xml (original)
+++ struts/shale/trunk/xdocs/features-reusable-views.xml Mon Feb 13 17:59:49 
2006
@@ -38,7 +38,7 @@
 liiMeta-data Inheritance and Tiles-like 
Composition/i/li
 p
 You can define a component as an extension of an 
existing component and 
-then override or add attributes. This mechamism is 
similar to the inheritance
+then override or add attributes. This mechanism is 
similar to the inheritance
 mechanism built into the popular a 
href=http://struts.apache.org/struts-tiles;Tiles/a framework for composing
 web pages from discrete JSP fragments, known as tiles. 
In fact, Clay's features
 are sophisticated enough that Clay can give you much 
of the same benefits that

Modified: struts/shale/trunk/xdocs/features-tiger-extensions.xml
URL: 
http://svn.apache.org/viewcvs/struts/shale/trunk/xdocs/features-tiger-extensions.xml?rev=377572r1=377571r2=377572view=diff
==
--- struts/shale/trunk/xdocs/features-tiger-extensions.xml (original)
+++ struts/shale/trunk/xdocs/features-tiger-extensions.xml Mon Feb 13 17:59:49 
2006
@@ -224,7 +224,7 @@
 h4Using Annotated Component Registration/h4
 
 pTo use the emAnnotated Component Registration/em feature,
-you mus use annotations from the 
codeorg.apache.shale.tiger.register/code
+you must use annotations from the 
codeorg.apache.shale.tiger.register/code
 package, as illustrated below:/p
 
 pAn annotated component registration should look like this:/p



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r377578 - /struts/action/trunk/src/java/org/apache/struts/chain/commands/servlet/PerformForward.java

2006-02-13 Thread husted
Author: husted
Date: Mon Feb 13 18:15:25 2006
New Revision: 377578

URL: http://svn.apache.org/viewcvs?rev=377578view=rev
Log:
Resolve #36579 Tiles that use actions appear broken reported by Wolfgang 
Gehner.

Modified:

struts/action/trunk/src/java/org/apache/struts/chain/commands/servlet/PerformForward.java

Modified: 
struts/action/trunk/src/java/org/apache/struts/chain/commands/servlet/PerformForward.java
URL: 
http://svn.apache.org/viewcvs/struts/action/trunk/src/java/org/apache/struts/chain/commands/servlet/PerformForward.java?rev=377578r1=377577r2=377578view=diff
==
--- 
struts/action/trunk/src/java/org/apache/struts/chain/commands/servlet/PerformForward.java
 (original)
+++ 
struts/action/trunk/src/java/org/apache/struts/chain/commands/servlet/PerformForward.java
 Mon Feb 13 18:15:25 2006
@@ -28,6 +28,7 @@
 
 import javax.servlet.RequestDispatcher;
 import javax.servlet.http.HttpServletRequest;
+import javax.servlet.http.HttpServletResponse;
 
 /**
  * pPerform forwarding or redirection based on the specified
@@ -51,12 +52,11 @@
 throws Exception {
 ServletActionContext sacontext = (ServletActionContext) context;
 String forwardPath = forwardConfig.getPath();
-String uri = null;
+String uri;
 
 if (forwardPath == null) {
 // Retrieve internal message resources
-ActionServlet servlet =
-(ActionServlet) sacontext.getActionServlet();
+ActionServlet servlet = sacontext.getActionServlet();
 MessageResources resources = servlet.getInternal();
 
 throw new IllegalArgumentException(resources.getMessage(
@@ -74,6 +74,31 @@
 }
 
 HttpServletRequest request = sacontext.getRequest();
+
+// Use of actions within tiles, jsp:include or c:import requires to
+// convert forward (w/o redirect) to an include
+// if response has been committed
+HttpServletResponse response = sacontext.getResponse();
+
+if (response.isCommitted()  !forwardConfig.getRedirect()) {
+RequestDispatcher rd =
+sacontext.getContext().getRequestDispatcher(uri);
+
+if (rd == null) {
+
response.sendError(HttpServletResponse.SC_INTERNAL_SERVER_ERROR,
+Error getting RequestDispatcher for  + uri);
+
+return;
+}
+
+if (LOG.isDebugEnabled()) {
+LOG.debug(Including  + uri);
+}
+
+rd.include(request, response);
+
+return;
+}
 
 // Perform redirect or forward
 if (forwardConfig.getRedirect()) {



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 36579] - Tiles that use actions appear broken

2006-02-13 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=36579.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=36579


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2006-02-14 03:16 ---
Resolved in r377578.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r377579 - /struts/action/trunk/src/java/org/apache/struts/upload/CommonsMultipartRequestHandler.java

2006-02-13 Thread niallp
Author: niallp
Date: Mon Feb 13 18:21:28 2006
New Revision: 377579

URL: http://svn.apache.org/viewcvs?rev=377579view=rev
Log:
Fix for Bug 34445 - use charsets given by browser for form field encodings - 
reported by Ralf Hauser.

Modified:

struts/action/trunk/src/java/org/apache/struts/upload/CommonsMultipartRequestHandler.java

Modified: 
struts/action/trunk/src/java/org/apache/struts/upload/CommonsMultipartRequestHandler.java
URL: 
http://svn.apache.org/viewcvs/struts/action/trunk/src/java/org/apache/struts/upload/CommonsMultipartRequestHandler.java?rev=377579r1=377578r2=377579view=diff
==
--- 
struts/action/trunk/src/java/org/apache/struts/upload/CommonsMultipartRequestHandler.java
 (original)
+++ 
struts/action/trunk/src/java/org/apache/struts/upload/CommonsMultipartRequestHandler.java
 Mon Feb 13 18:21:28 2006
@@ -1,7 +1,7 @@
 /*
  * $Id$
  *
- * Copyright 1999-2004 The Apache Software Foundation.
+ * Copyright 1999-2006 The Apache Software Foundation.
  *
  * Licensed under the Apache License, Version 2.0 (the License);
  * you may not use this file except in compliance with the License.
@@ -18,6 +18,7 @@
 package org.apache.struts.upload;
 
 import org.apache.commons.fileupload.DiskFileUpload;
+import org.apache.commons.fileupload.disk.DiskFileItem;
 import org.apache.commons.fileupload.FileItem;
 import org.apache.commons.fileupload.FileUploadException;
 import org.apache.commons.logging.Log;
@@ -46,8 +47,7 @@
  * interface by providing a wrapper around the Jakarta Commons FileUpload
  * library. /p
  *
- * @version $Rev$ $Date: 2005-05-07 12:11:38 -0400 (Sat, 07 May 2005)
- *  $
+ * @version $Rev$ $Date$
  * @since Struts 1.1
  */
 public class CommonsMultipartRequestHandler implements MultipartRequestHandler 
{
@@ -380,7 +380,21 @@
 String name = item.getFieldName();
 String value = null;
 boolean haveValue = false;
-String encoding = request.getCharacterEncoding();
+String encoding = null;
+
+if (item instanceof DiskFileItem) {
+encoding = ((DiskFileItem)item).getCharSet();
+if (log.isDebugEnabled()) {
+log.debug(DiskFileItem.getCharSet=[ + encoding + ]);
+}
+}
+
+if (encoding == null) {
+encoding = request.getCharacterEncoding();
+if (log.isDebugEnabled()) {
+log.debug(request.getCharacterEncoding=[ + encoding + ]);
+}
+} 
 
 if (encoding != null) {
 try {



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r377580 - /struts/action/trunk/conf/java/chain-config.xml

2006-02-13 Thread niallp
Author: niallp
Date: Mon Feb 13 18:24:01 2006
New Revision: 377580

URL: http://svn.apache.org/viewcvs?rev=377580view=rev
Log:
Correct Tiles command package name

Modified:
struts/action/trunk/conf/java/chain-config.xml

Modified: struts/action/trunk/conf/java/chain-config.xml
URL: 
http://svn.apache.org/viewcvs/struts/action/trunk/conf/java/chain-config.xml?rev=377580r1=377579r2=377580view=diff
==
--- struts/action/trunk/conf/java/chain-config.xml (original)
+++ struts/action/trunk/conf/java/chain-config.xml Mon Feb 13 18:24:01 2006
@@ -246,7 +246,7 @@
 be used from global exception handlers.
 
 command
-className=org.apache.struts.chain.servlet.TilesPreProcessor/
+className=org.apache.struts.tiles.commands.TilesPreProcessor/
 --
 
 !-- Follow the returned ForwardConfig (if any) --



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r377582 - in /struts/apps/trunk/examples/src/webapp/WEB-INF/validator: struts-config-bundles.xml struts-config-i18nVariables.xml struts-config-type.xml struts-config-validwhen.xml struts-c

2006-02-13 Thread husted
Author: husted
Date: Mon Feb 13 18:30:00 2006
New Revision: 377582

URL: http://svn.apache.org/viewcvs?rev=377582view=rev
Log:
Validator Example Application 
* Update for new cancellable property. 

Modified:

struts/apps/trunk/examples/src/webapp/WEB-INF/validator/struts-config-bundles.xml

struts/apps/trunk/examples/src/webapp/WEB-INF/validator/struts-config-i18nVariables.xml

struts/apps/trunk/examples/src/webapp/WEB-INF/validator/struts-config-type.xml

struts/apps/trunk/examples/src/webapp/WEB-INF/validator/struts-config-validwhen.xml
struts/apps/trunk/examples/src/webapp/WEB-INF/validator/struts-config.xml

Modified: 
struts/apps/trunk/examples/src/webapp/WEB-INF/validator/struts-config-bundles.xml
URL: 
http://svn.apache.org/viewcvs/struts/apps/trunk/examples/src/webapp/WEB-INF/validator/struts-config-bundles.xml?rev=377582r1=377581r2=377582view=diff
==
--- 
struts/apps/trunk/examples/src/webapp/WEB-INF/validator/struts-config-bundles.xml
 (original)
+++ 
struts/apps/trunk/examples/src/webapp/WEB-INF/validator/struts-config-bundles.xml
 Mon Feb 13 18:30:00 2006
@@ -28,7 +28,8 @@
 name=bundlesForm 
 scope=request 
 parameter=/welcome.do 
-validate=true 
+validate=true
+cancellable=true
 input=input 
 forward name=input path=/viewBundleExamples.do /
 /action
@@ -41,7 +42,8 @@
 name=bundlesForm 
 scope=request 
 parameter=/welcome.do 
-validate=true 
+validate=true
+cancellable=true
 input=input 
 forward name=input path=/viewJsBundleExamples.do /
 /action

Modified: 
struts/apps/trunk/examples/src/webapp/WEB-INF/validator/struts-config-i18nVariables.xml
URL: 
http://svn.apache.org/viewcvs/struts/apps/trunk/examples/src/webapp/WEB-INF/validator/struts-config-i18nVariables.xml?rev=377582r1=377581r2=377582view=diff
==
--- 
struts/apps/trunk/examples/src/webapp/WEB-INF/validator/struts-config-i18nVariables.xml
 (original)
+++ 
struts/apps/trunk/examples/src/webapp/WEB-INF/validator/struts-config-i18nVariables.xml
 Mon Feb 13 18:30:00 2006
@@ -37,7 +37,8 @@
 name=i18nForm 
 scope=request 
 parameter=/welcome.do 
-validate=true 
+validate=true
+cancellable=true
 input=input 
 forward name=input path=/viewI18nExample.do /
 /action
@@ -49,7 +50,8 @@
 name=i18nForm 
 scope=request 
 parameter=/welcome.do 
-validate=true 
+validate=true
+cancellable=true
 input=input 
 forward name=input path=/viewJsI18nExample.do /
 /action

Modified: 
struts/apps/trunk/examples/src/webapp/WEB-INF/validator/struts-config-type.xml
URL: 
http://svn.apache.org/viewcvs/struts/apps/trunk/examples/src/webapp/WEB-INF/validator/struts-config-type.xml?rev=377582r1=377581r2=377582view=diff
==
--- 
struts/apps/trunk/examples/src/webapp/WEB-INF/validator/struts-config-type.xml 
(original)
+++ 
struts/apps/trunk/examples/src/webapp/WEB-INF/validator/struts-config-type.xml 
Mon Feb 13 18:30:00 2006
@@ -32,7 +32,8 @@
 type=org.apache.struts.webapp.validator.TypeAction 
 name=typeForm 
 scope=request 
-validate=true 
+validate=true
+cancellable=true
 input=input
 forward name=input path=/type.do /
 forward name=success path=/welcome.do /
@@ -52,7 +53,8 @@
 type=org.apache.struts.webapp.validator.TypeAction 
 name=jsTypeForm 
 scope=request 
-validate=true 
+validate=true
+cancellable=true
 input=/jsType.jsp
 forward name=success path=/welcome.do /
 /action

Modified: 
struts/apps/trunk/examples/src/webapp/WEB-INF/validator/struts-config-validwhen.xml
URL: 
http://svn.apache.org/viewcvs/struts/apps/trunk/examples/src/webapp/WEB-INF/validator/struts-config-validwhen.xml?rev=377582r1=377581r2=377582view=diff
==
--- 
struts/apps/trunk/examples/src/webapp/WEB-INF/validator/struts-config-validwhen.xml
 (original)
+++ 
struts/apps/trunk/examples/src/webapp/WEB-INF/validator/struts-config-validwhen.xml
 Mon Feb 13 18:30:00 2006
@@ -34,7 +34,8 @@
 name=validWhenForm 
 scope=request 
 parameter=/welcome.do 
-validate=true 
+validate=true
+cancellable=true
 input=input 
 forward name=input path=/viewValidWhenExamples.do /
 /action

Modified: 

[Struts Wiki] Update of StrutsClassicRelease130 by TedHusted

2006-02-13 Thread Apache Wiki
Dear Wiki user,

You have subscribed to a wiki page or wiki category on Struts Wiki for change 
notification.

The following page has been changed by TedHusted:
http://wiki.apache.org/struts/StrutsClassicRelease130

--
  || [http://issues.apache.org/bugzilla/show_bug.cgi?id=36794 36794] || 
Document enhancement (Enhanced !DynaActionForm) || All || (./) ||
  || [http://issues.apache.org/bugzilla/show_bug.cgi?id=37301 37301] || 
Document enhancement (Allow dynamic interface implementation) || All || (./) 
(n/a) ||
  || [http://issues.apache.org/bugzilla/show_bug.cgi?id=37730 37730] || 
Enhanced !DynaActionForms cannot be correctly deserialized || All || (./) 
(removed) ||
- || [http://issues.apache.org/bugzilla/show_bug.cgi?id=38374 38374] || 
Validation always skipped with Globals.CANCEL_KEY || Action|| (Adapt for 1.3.0 
and amend DTD) ||
+ || [http://issues.apache.org/bugzilla/show_bug.cgi?id=38374 38374] || 
Validation always skipped with Globals.CANCEL_KEY || Action|| (./) ||
  
  OTHER TODO
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r377584 - /struts/action/trunk/src/java/org/apache/struts/chain/commands/ActionCommandBase.java

2006-02-13 Thread niallp
Author: niallp
Date: Mon Feb 13 18:36:06 2006
New Revision: 377584

URL: http://svn.apache.org/viewcvs?rev=377584view=rev
Log:
Log each command's execution, for debug purposes.

Modified:

struts/action/trunk/src/java/org/apache/struts/chain/commands/ActionCommandBase.java

Modified: 
struts/action/trunk/src/java/org/apache/struts/chain/commands/ActionCommandBase.java
URL: 
http://svn.apache.org/viewcvs/struts/action/trunk/src/java/org/apache/struts/chain/commands/ActionCommandBase.java?rev=377584r1=377583r2=377584view=diff
==
--- 
struts/action/trunk/src/java/org/apache/struts/chain/commands/ActionCommandBase.java
 (original)
+++ 
struts/action/trunk/src/java/org/apache/struts/chain/commands/ActionCommandBase.java
 Mon Feb 13 18:36:06 2006
@@ -1,7 +1,7 @@
 /*
  * $Id$
  *
- * Copyright 2005 The Apache Software Foundation.
+ * Copyright 2005-2006 The Apache Software Foundation.
  *
  * Licensed under the Apache License, Version 2.0 (the License);
  * you may not use this file except in compliance with the License.
@@ -17,6 +17,8 @@
  */
 package org.apache.struts.chain.commands;
 
+import org.apache.commons.logging.Log;
+import org.apache.commons.logging.LogFactory;
 import org.apache.commons.chain.Context;
 import org.apache.struts.chain.contexts.ActionContext;
 
@@ -26,6 +28,13 @@
  * that class./p
  */
 public abstract class ActionCommandBase implements ActionCommand {
+
+/**
+ * p Provide Commons Logging instance for this class. /p
+ */
+private static final Log LOG =
+LogFactory.getLog(ActionCommandBase.class);
+
 // See interface for Javadoc
 public abstract boolean execute(ActionContext actionContext)
 throws Exception;
@@ -33,6 +42,9 @@
 // See interface for Javadoc
 public boolean execute(Context context)
 throws Exception {
+if (LOG.isDebugEnabled()) {
+LOG.debug(Executing  + getClass().getName());
+}
 return execute((ActionContext) context);
 }
 }



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [VOTE] Confirm the Struts Action Library 1.3.0 release plan

2006-02-13 Thread Ted Husted
OK, we're making some progress. The Cancellable code is in, and I'm
testing the example applications again, updating the configurations as
needed for the cancellable property. After that, it's a final pass on
the Relesae Notes (since November)., and we should be able to roll
each of the seven subprojects.

Hopefully, I can make some time  in the evenings to finish this up,
but we're starting a new phase at work tomorrow, and I don't know how
much time I'll have.

-Ted.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r377586 - /struts/current/nightly.sh

2006-02-13 Thread jmitchell
Author: jmitchell
Date: Mon Feb 13 18:45:48 2006
New Revision: 377586

URL: http://svn.apache.org/viewcvs?rev=377586view=rev
Log:
Update build script (used to build the nightlies on our zone via cron)


Modified:
struts/current/nightly.sh

Modified: struts/current/nightly.sh
URL: 
http://svn.apache.org/viewcvs/struts/current/nightly.sh?rev=377586r1=377585r2=377586view=diff
==
--- struts/current/nightly.sh (original)
+++ struts/current/nightly.sh Mon Feb 13 18:45:48 2006
@@ -3,46 +3,68 @@
 # This is the exact cron job to that builds
 # the nightly Apache Struts distributions
 #
-# 30 1 * * * /home/jmitchell/svn/nightly.sh
+# 30 1 * * * /export/home/jmitchell/svn/nightly.sh
 # 
 #
 
+export USER_HOME=/export/home/jmitchell
+source $USER_HOME/.bashrc
 
-source ~/.bashrc
-
-export SVN_DIR=/home/jmitchell/svn
-
-cd $SVN_DIR/STRUTS_1_2_BRANCH
+env
 
+echo --- setup environment for this build ---
+export SVN_DIR=/export/home/jmitchell/svn
 export TODAY=`date +%Y%m%d`
-export LOGFILE=$SVN_DIR/../logs/nightly-$TODAY.log
-export UPLOAD_DIR=$SVN_DIR/STRUTS_1_2_BRANCH/release/upload
-export 
TARGET_HOST=cvs.apache.org:/www/cvs.apache.org/builds/jakarta-struts/maven/
+export SOURCE_1_2_DIR=$SVN_DIR/STRUTS_1_2_BRANCH/release/upload
+export 
TARGET_HOST=svn.apache.org:/www/cvs.apache.org/builds/jakarta-struts/maven/
 export TARGET_1_2_URL=$TARGET_HOST/STRUTS_1_2_BRANCH/nightly
 export TARGET_1_3_URL=$TARGET_HOST/trunk/
 export NIGHTLIES=$SVN_DIR/struts/build/nightly
+env
 
-ant clean-lib  $LOGFILE
-svn status  $LOGFILE
-ant download-dependencies nightly  $LOGFILE
-#ant site  $LOGFILE
-
-
-scp $UPLOAD_DIR/*bin* $TARGET_1_2_URL/binary  $LOGFILE
-scp $UPLOAD_DIR/*lib* $TARGET_1_2_URL/lib  $LOGFILE
-scp $UPLOAD_DIR/*src* $TARGET_1_2_URL/src  $LOGFILE
-scp $LOGFILE $TARGET_1_2_URL/logs
-
-
-# TODO - build and deploy 1.2 web site
-
-# build and deploy 1.3.x
-cd $SVN_DIR/struts/build/  $LOGFILE
-maven nightly  $LOGFILE
-cp $LOGFILE $NIGHTLIES/logs
+echo  Struts 1.2.x -
+echo --- move old 1.2 branch to bak/ ---
+cd $SVN_DIR
+mv STRUTS_1_2_BRANCH STRUTS_1_2_BRANCH-$TODAY
+
+echo --- get a fresh checkout from svn ---
+svn co 
https://svn.apache.org/repos/asf/struts/action/branches/STRUTS_1_2_BRANCH/ 
STRUTS_1_2_BRANCH
+cd STRUTS_1_2_BRANCH
+
+echo --- #ant download-dependencies releasee ---
+ant download-dependencies nightly
+
+echo --- push the artifacts to the nightly drop ---
+scp $SOURCE_1_2_DIR/*bin* $TARGET_1_2_URL/binary 
+scp $SOURCE_1_2_DIR/*lib* $TARGET_1_2_URL/lib 
+scp $SOURCE_1_2_DIR/*src* $TARGET_1_2_URL/src 
+
+
+cd $SVN_DIR
+cp build.log bak/build.log-$TODAY
+scp bak/build-$TODAY.log $TARGET_1_2_URL/logs
+echo   build.log
+
+echo  Struts 1.3.x -
+echo --- move old 1.3 branch to bak/ ---
+cd $SVN_DIR
+mv struts bak/struts-$TODAY
+
+echo --- get a fresh checkout from svn ---
+svn co http://svn.apache.org/repos/asf/struts/current/ struts
+
+echo --- build and deploy 1.3.x ---
+cd $SVN_DIR/struts/build/
+maven nightly
 scp -r $NIGHTLIES $TARGET_1_3_URL
 
 
+echo --- copy build.log ---
+cd $SVN_DIR
+cp build.log bak/build.log-$TODAY
+scp bak/build-$TODAY.log $TARGET_1_3_URL/nightly/logs
 
+echo --- clean up folder history ---
+find /home/jmitchell/svn/bak -type f -mtime +7 -exec rm -fr \{\} \;
 
 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [VOTE] Confirm the Struts Action Library 1.3.0 release plan

2006-02-13 Thread Niall Pemberton
On 2/14/06, Ted Husted [EMAIL PROTECTED] wrote:
 OK, we're making some progress. The Cancellable code is in, and I'm
 testing the example applications again, updating the configurations as
 needed for the cancellable property. After that, it's a final pass on
 the Relesae Notes (since November)., and we should be able to roll
 each of the seven subprojects.

I'd like to fix DOS attack, application hack by patching
RequestUtils to ignore any parameter starting with
multipartRequestHandler..

  http://issues.apache.org/bugzilla/show_bug.cgi?id=38534

I don't understand your comment about there being no agreement and
moving it to 1.3.1 - no one seemed to object to this proposal. I think
Paul just wanted a more complete solution in general. Its not elegant
but it plugs the gap and I think this is the main bug left thats going
to screw up 1.3.0's quality vote.

If no one shouts in the next hour, I'm going to fix this.

Niall

 Hopefully, I can make some time  in the evenings to finish this up,
 but we're starting a new phase at work tomorrow, and I don't know how
 much time I'll have.

 -Ted.

 -
 To unsubscribe, e-mail: [EMAIL PROTECTED]
 For additional commands, e-mail: [EMAIL PROTECTED]



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 38374] - Validation always skipped with Globals.CANCEL_KEY

2006-02-13 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=38374.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38374





--- Additional Comments From [EMAIL PROTECTED]  2006-02-14 03:59 ---
Ted, should I modify the 1.2 patch to match the java class names and
documentation that you have chosen?

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [VOTE] Confirm the Struts Action Library 1.3.0 release plan

2006-02-13 Thread Paul Benedict
Here's my take on it:
  
  I think fixing RequestUtils to bypass the multipart property is a  patch. I 
say that because it's a pointed solution to a specific  problem. If we look at 
this as a temporary fix, I am okay with that  because it does provide a 
solution and then it can be replaced with a  broader solution.
  
  That of course assumes a broader solution :-) 
  
  I really do want to investigate allowing the form to dictate which  
properties are valid/invalid for population by the RP. Does anyone want  to 
investigate this with me? I still find a blacklist or whitelist map  to be the 
way to go. I am sensitive to what properties people can  populate in my form 
with a good guess; and you'd be surprised what can  be inferred from a logical 
group of property names.
  
  Paul


-
Brings words and photos together (easily) with
 PhotoMail  - it's free and works with Yahoo! Mail.

DO NOT REPLY [Bug 38374] - Validation always skipped with Globals.CANCEL_KEY

2006-02-13 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=38374.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38374





--- Additional Comments From [EMAIL PROTECTED]  2006-02-14 04:25 ---
Virtually everything has changed because of the jalopy reformatting, so its 
unlikely we would be able to use the svn merge. Other than that I suspect the 
actual logic is the same - so its probably just a cut and paste job to create 
another patch.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [VOTE] Confirm the Struts Action Library 1.3.0 release plan

2006-02-13 Thread Niall Pemberton
On 2/14/06, Paul Benedict [EMAIL PROTECTED] wrote:
 Here's my take on it:

  I think fixing RequestUtils to bypass the multipart property is a  patch. I 
 say that because it's a pointed solution to a specific  problem. If we look 
 at this as a temporary fix, I am okay with that  because it does provide a 
 solution and then it can be replaced with a  broader solution.

It is just a patch - the long term solution to this specific bug is to
remove the getter method from ActionForm.

  That of course assumes a broader solution :-)

  I really do want to investigate allowing the form to dictate which  
 properties are valid/invalid for population by the RP. Does anyone want  to 
 investigate this with me? I still find a blacklist or whitelist map  to be 
 the way to go. I am sensitive to what properties people can  populate in my 
 form with a good guess; and you'd be surprised what can  be inferred from a 
 logical group of property names.

This is a different issue from this bug and I don't' think I agree
that its even a problem. If you expose something in your ActionForm
that you don't want populated then that is where the problem lies and
you need to get them out of the ActionForm.

Niall

  Paul


 -
 Brings words and photos together (easily) with
  PhotoMail  - it's free and works with Yahoo! Mail.


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [VOTE] Confirm the Struts Action Library 1.3.0 release plan

2006-02-13 Thread Ted Husted
On 2/13/06, Niall Pemberton [EMAIL PROTECTED] wrote:
 If no one shouts in the next hour, I'm going to fix this.

I'm in the middle of the final testing of the build as it stands now,
and I would prefer that there be no more changes.

-Ted.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 38374] - Validation always skipped with Globals.CANCEL_KEY

2006-02-13 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=38374.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38374


[EMAIL PROTECTED] changed:

   What|Removed |Added

  Attachment #17523|0   |1
is obsolete||




--- Additional Comments From [EMAIL PROTECTED]  2006-02-14 05:01 ---
Created an attachment (id=17683)
 -- (http://issues.apache.org/bugzilla/attachment.cgi?id=17683action=view)
Patch for Struts 1.2.x branch

Updated JavaDoc to match Ted's comments. The docs will generally read the same
between 1.2 and 1.3.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 38374] - Validation always skipped with Globals.CANCEL_KEY

2006-02-13 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=38374.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38374


[EMAIL PROTECTED] changed:

   What|Removed |Added

  Attachment #17524|0   |1
is obsolete||




--- Additional Comments From [EMAIL PROTECTED]  2006-02-14 05:03 ---
Created an attachment (id=17684)
 -- (http://issues.apache.org/bugzilla/attachment.cgi?id=17684action=view)
InvalidCancelException.java

Updated JavaDoc to match Ted's comments. The docs will generally read the same
between 1.2 and 1.3.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: DO NOT REPLY [Bug 38374] - Validation always skipped with Globals.CANCEL_KEY

2006-02-13 Thread Paul Benedict
All, these are the updated patches for 1.2.x. I've tested them and, as  far I 
see, they are good to go. I'll update the 1.3 original  RequestProcessor 
Tuesday' night -- unless someone can do it during the  work day (I can't).


-
Brings words and photos together (easily) with
 PhotoMail  - it's free and works with Yahoo! Mail.

svn commit: r377616 - /struts/shale/trunk/use-cases/src/web/symbols/home.jsp

2006-02-13 Thread gvanmatre
Author: gvanmatre
Date: Mon Feb 13 20:36:49 2006
New Revision: 377616

URL: http://svn.apache.org/viewcvs?rev=377616view=rev
Log: (empty)

Modified:
struts/shale/trunk/use-cases/src/web/symbols/home.jsp

Modified: struts/shale/trunk/use-cases/src/web/symbols/home.jsp
URL: 
http://svn.apache.org/viewcvs/struts/shale/trunk/use-cases/src/web/symbols/home.jsp?rev=377616r1=377615r2=377616view=diff
==
--- struts/shale/trunk/use-cases/src/web/symbols/home.jsp (original)
+++ struts/shale/trunk/use-cases/src/web/symbols/home.jsp Mon Feb 13 20:36:49 
2006
@@ -50,922 +50,7 @@
  f:param name=url value=/symbols/layout.html//h:outputLink 
that defines 
   sections of a typical page having a header, 
   footer, left navbar and body sections.  The layout is defined as an HTML 
template, 
-  but the entry point can be a full XML or full HTML teIndex: 
src/java/org/apache/shale/faces/ValidatorRenderKit.java
-===
 src/java/org/apache/shale/faces/ValidatorRenderKit.java(revision 0)
-+++ src/java/org/apache/shale/faces/ValidatorRenderKit.java(revision 0)
-@@ -0,0 +1,68 @@
-+/*
-+ * Copyright 2006 The Apache Software Foundation.
-+ *
-+ * Licensed under the Apache License, Version 2.0 (the License);
-+ * you may not use this file except in compliance with the License.
-+ * You may obtain a copy of the License at
-+ *
-+ *  http://www.apache.org/licenses/LICENSE-2.0
-+ *
-+ * Unless required by applicable law or agreed to in writing, software
-+ * distributed under the License is distributed on an AS IS BASIS,
-+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-+ * See the License for the specific language governing permissions and
-+ * limitations under the License.
-+ *
-+ */
-+
-+package org.apache.shale.faces;
-+
-+import java.io.OutputStream;
-+import java.io.Writer;
-+
-+import javax.faces.context.ResponseStream;
-+import javax.faces.context.ResponseWriter;
-+import javax.faces.render.RenderKit;
-+import javax.faces.render.Renderer;
-+import javax.faces.render.ResponseStateManager;
-+
-+import org.apache.shale.renderer.ValidatorCommandRenderer;
-+
-+public class ValidatorRenderKit extends RenderKit {
-+
-+private RenderKit defaultRenderKit = null;
-+public ValidatorRenderKit(RenderKit defaultRenderKit) {
-+   this.defaultRenderKit = defaultRenderKit;
-+}
-+
-+public void addRenderer(String componentFamily, String rendererType, 
Renderer renderer) {
-+   this.defaultRenderKit.addRenderer(componentFamily, rendererType, 
renderer);
-+}
-+
-+public Renderer getRenderer(String componentFamily, String rendererType) {
-+Renderer target = defaultRenderKit.getRenderer(componentFamily, 
rendererType);
-+if (componentFamily.equals(javax.faces.Command)) {
-+   if (!(target instanceof ValidatorCommandRenderer)) {
-+   target = new ValidatorCommandRenderer(target);
-+   addRenderer(componentFamily, rendererType, target);
-+   }
-+}
-+
-+return target;
-+}
-+
-+public ResponseStateManager getResponseStateManager() {
-+return defaultRenderKit.getResponseStateManager();
-+}
-+
-+public ResponseWriter createResponseWriter(Writer writer,
-+String contentTypeList,
-+String characterEncoding){
-+return defaultRenderKit.createResponseWriter(writer, contentTypeList, 
characterEncoding);
-+}
-+
-+public ResponseStream createResponseStream(OutputStream outputStream) {
-+return defaultRenderKit.createResponseStream(outputStream);
-+}
-+
-+}
-Index: src/java/org/apache/shale/validator/Globals.java
-===
 src/java/org/apache/shale/validator/Globals.java   (revision 367478)
-+++ src/java/org/apache/shale/validator/Globals.java   (working copy)
-@@ -19,7 +19,7 @@
- /**
-  * pManifest constants that are global to the validator implementation./p
-  *
-- * $Id:$
-+ * $Id$
-  */
-
- public class Globals {
-Index: src/java/org/apache/shale/renderer/ValidatorCommandRenderer.java
-===
 src/java/org/apache/shale/renderer/ValidatorCommandRenderer.java   
(revision 0)
-+++ src/java/org/apache/shale/renderer/ValidatorCommandRenderer.java   
(revision 0)
-@@ -0,0 +1,168 @@
-+/*
-+ * Copyright 2006 The Apache Software Foundation.
-+ *
-+ * Licensed under the Apache License, Version 2.0 (the License);
-+ * you may not use this file except in compliance with the License.
-+ * You may obtain a copy of the License at
-+ *
-+ *  http://www.apache.org/licenses/LICENSE-2.0
-+ *
-+ * Unless required by applicable law or agreed to in writing, software
-+ * distributed under the License is distributed on an AS IS BASIS,
-+ * WITHOUT WARRANTIES OR CONDITIONS 

svn commit: r377621 - in /struts/shale/trunk/clay-plugin/src/java/org/apache/shale/clay: component/Clay.java component/chain/CreateComponentCommand.java config/beans/AttributeBean.java config/beans/At

2006-02-13 Thread gvanmatre
Author: gvanmatre
Date: Mon Feb 13 20:57:44 2006
New Revision: 377621

URL: http://svn.apache.org/viewcvs?rev=377621view=rev
Log:
Second pass at Bug# 38542.  

Added:

struts/shale/trunk/clay-plugin/src/java/org/apache/shale/clay/config/beans/Attributes.java
   (with props)
Modified:

struts/shale/trunk/clay-plugin/src/java/org/apache/shale/clay/component/Clay.java

struts/shale/trunk/clay-plugin/src/java/org/apache/shale/clay/component/chain/CreateComponentCommand.java

struts/shale/trunk/clay-plugin/src/java/org/apache/shale/clay/config/beans/AttributeBean.java

struts/shale/trunk/clay-plugin/src/java/org/apache/shale/clay/config/beans/ComponentBean.java

Modified: 
struts/shale/trunk/clay-plugin/src/java/org/apache/shale/clay/component/Clay.java
URL: 
http://svn.apache.org/viewcvs/struts/shale/trunk/clay-plugin/src/java/org/apache/shale/clay/component/Clay.java?rev=377621r1=377620r2=377621view=diff
==
--- 
struts/shale/trunk/clay-plugin/src/java/org/apache/shale/clay/component/Clay.java
 (original)
+++ 
struts/shale/trunk/clay-plugin/src/java/org/apache/shale/clay/component/Clay.java
 Mon Feb 13 20:57:44 2006
@@ -396,7 +396,7 @@
 
 /**
  * p
- * Called by JSF, this method delegates to [EMAIL PROTECTED] 
recursiveRenderChildren}.
+ * Called by JSF, this method delegates to 
coderecursiveRenderChildren/code.
  * /p
  */
 public void encodeChildren(FacesContext context) throws IOException {

Modified: 
struts/shale/trunk/clay-plugin/src/java/org/apache/shale/clay/component/chain/CreateComponentCommand.java
URL: 
http://svn.apache.org/viewcvs/struts/shale/trunk/clay-plugin/src/java/org/apache/shale/clay/component/chain/CreateComponentCommand.java?rev=377621r1=377620r2=377621view=diff
==
--- 
struts/shale/trunk/clay-plugin/src/java/org/apache/shale/clay/component/chain/CreateComponentCommand.java
 (original)
+++ 
struts/shale/trunk/clay-plugin/src/java/org/apache/shale/clay/component/chain/CreateComponentCommand.java
 Mon Feb 13 20:57:44 2006
@@ -19,7 +19,6 @@
 package org.apache.shale.clay.component.chain;
 
 import java.util.Map;
-import java.util.TreeMap;
 
 import javax.faces.component.UIComponent;
 import javax.faces.context.FacesContext;
@@ -31,9 +30,8 @@
 import org.apache.shale.clay.component.Clay;
 import org.apache.shale.clay.config.Globals;
 import org.apache.shale.clay.config.beans.AttributeBean;
+import org.apache.shale.clay.config.beans.Attributes;
 import org.apache.shale.clay.config.beans.ComponentBean;
-import org.apache.shale.faces.ShaleConstants;
-import org.apache.shale.util.Tags;
 
 /**
  * p
@@ -84,7 +82,7 @@
 .getMessage(clay.null.facesContext));
 
 // create a new scoped symbol table
-Map symbolTable = new TreeMap();
+Map symbolTable = new Attributes();
 // inherit the parents symbols
 symbolTable.putAll(clayContext.getSymbols());
 // override config (XML, HTML) symbols
@@ -166,8 +164,8 @@
 child.getAttributes().put(Globals.CLAY_RESERVED_ATTRIBUTE, 
displayElement);
 }
 
-// continue with the addComponent chain if not a bound component
-isFinal = (child.getValueBinding(binding) != null);
+// continue with the addComponent chain
+isFinal = false;
 } else {
 if (log.isDebugEnabled())
 log.debug(messages.getMessage(create.component.exists,

Modified: 
struts/shale/trunk/clay-plugin/src/java/org/apache/shale/clay/config/beans/AttributeBean.java
URL: 
http://svn.apache.org/viewcvs/struts/shale/trunk/clay-plugin/src/java/org/apache/shale/clay/config/beans/AttributeBean.java?rev=377621r1=377620r2=377621view=diff
==
--- 
struts/shale/trunk/clay-plugin/src/java/org/apache/shale/clay/config/beans/AttributeBean.java
 (original)
+++ 
struts/shale/trunk/clay-plugin/src/java/org/apache/shale/clay/config/beans/AttributeBean.java
 Mon Feb 13 20:57:44 2006
@@ -1,5 +1,4 @@
 /*
-/*
  * Copyright 2005 The Apache Software Foundation.
  *
  * Licensed under the Apache License, Version 2.0 (the License);

Added: 
struts/shale/trunk/clay-plugin/src/java/org/apache/shale/clay/config/beans/Attributes.java
URL: 
http://svn.apache.org/viewcvs/struts/shale/trunk/clay-plugin/src/java/org/apache/shale/clay/config/beans/Attributes.java?rev=377621view=auto
==
--- 
struts/shale/trunk/clay-plugin/src/java/org/apache/shale/clay/config/beans/Attributes.java
 (added)
+++ 
struts/shale/trunk/clay-plugin/src/java/org/apache/shale/clay/config/beans/Attributes.java
 Mon Feb 13 20:57:44 2006
@@ -0,0 +1,71 @@
+/*
+ * Copyright 2006 The Apache Software Foundation.
+ *
+ * Licensed 

DO NOT REPLY [Bug 38542] - [shale] clay not handling binding attribute correctly

2006-02-13 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=38542.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38542





--- Additional Comments From [EMAIL PROTECTED]  2006-02-14 06:04 ---
Another pass at component binding will be in the 20060214 shale nightly 
build.  Component metadata values will not be ignored for bound components and 
will take precedence over values initialized programmatically.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Passing Parameters to ActionForward from Action

2006-02-13 Thread shiiva
Hi,

Can anyone please describe me how to pass parameters from an Action to 
corresponding ActionForward.

Basically, I am having only the jsp name in forward in struts-config.xml. But, 
when action is processed, I want to send some parameters to the corresponding 
actionforward.

Can some be help me in explaining how it can be achieved.

Thanks,
Shiiva
-
Posted via Jive Forums
http://forums.opensymphony.com/thread.jspa?threadID=18280messageID=35715#35715


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]