Re: [PATCH] don't do autoprops on symbolic links
On Wed, Sep 29, 2010 at 10:56:17AM +1000, Gavin Beau Baumanis wrote: > As a result of no comments for this patch , I have logged it into the issue > tracker so that it doesn't get lost. > > http://subversion.tigris.org/issue-tracker.html > Issue Number : #3722 I've committed the patch. Thanks very much! Stefan
Re: [PATCH] don't do autoprops on symbolic links
As a result of no comments for this patch , I have logged it into the issue tracker so that it doesn't get lost. http://subversion.tigris.org/issue-tracker.html Issue Number : #3722 Gavin "Beau" Baumanis On 04/09/2010, at 10:25 PM, Wei-Yin Chen wrote: > Dear Gavin, > > Thanks. The attachment was in my sent box, but it's absent in the mailing > archive. Don't know why. > > Per Branko's suggestion, I'm using join this time. In case the attachment > gets missing again, it is also embedded in the mail body. > > Regards, > Wei-Yin > > --- svn_apply_autoprops.py.old 2010-09-04 20:16:28.0 +0800 > +++ svn_apply_autoprops.py.nolink 2010-09-04 20:17:20.0 +0800 > @@ -122,10 +122,12 @@ >for autoprops_line in autoprop_lines: > fnmatch_str = autoprops_line[0] > prop_list = autoprops_line[1] > > matching_filenames = fnmatch.filter(filenames, fnmatch_str) > +matching_filenames = [f for f in matching_filenames \ > + if not os.path.islink(os.path.join(dirname, f))] > if not matching_filenames: >continue > > for prop in prop_list: >command = ['svn', 'propset', prop[0], prop[1]] > > > On Sat, Sep 4, 2010 at 4:08 PM, Gavin Beau Baumanis > wrote: > Hi Wei-Yin, > > Just thought I would mention that you did not attach your updated patch. > > > Gavin "Beau" Baumanis > E: ga...@thespidernet.com >
Re: [PATCH] don't do autoprops on symbolic links
Hi Everyone. This renewed patch has received no comments. Gavin "Beau" Baumanis On 04/09/2010, at 10:25 PM, Wei-Yin Chen wrote: > Dear Gavin, > > Thanks. The attachment was in my sent box, but it's absent in the mailing > archive. Don't know why. > > Per Branko's suggestion, I'm using join this time. In case the attachment > gets missing again, it is also embedded in the mail body. > > Regards, > Wei-Yin > > --- svn_apply_autoprops.py.old 2010-09-04 20:16:28.0 +0800 > +++ svn_apply_autoprops.py.nolink 2010-09-04 20:17:20.0 +0800 > @@ -122,10 +122,12 @@ >for autoprops_line in autoprop_lines: > fnmatch_str = autoprops_line[0] > prop_list = autoprops_line[1] > > matching_filenames = fnmatch.filter(filenames, fnmatch_str) > +matching_filenames = [f for f in matching_filenames \ > + if not os.path.islink(os.path.join(dirname, f))] > if not matching_filenames: >continue > > for prop in prop_list: >command = ['svn', 'propset', prop[0], prop[1]] > > > On Sat, Sep 4, 2010 at 4:08 PM, Gavin Beau Baumanis > wrote: > Hi Wei-Yin, > > Just thought I would mention that you did not attach your updated patch. > > > Gavin "Beau" Baumanis > E: ga...@thespidernet.com > >
Re: [PATCH] don't do autoprops on symbolic links
Dear Gavin, Thanks. The attachment was in my sent box, but it's absent in the mailing archive. Don't know why. Per Branko's suggestion, I'm using join this time. In case the attachment gets missing again, it is also embedded in the mail body. Regards, Wei-Yin --- svn_apply_autoprops.py.old 2010-09-04 20:16:28.0 +0800 +++ svn_apply_autoprops.py.nolink 2010-09-04 20:17:20.0 +0800 @@ -122,10 +122,12 @@ for autoprops_line in autoprop_lines: fnmatch_str = autoprops_line[0] prop_list = autoprops_line[1] matching_filenames = fnmatch.filter(filenames, fnmatch_str) +matching_filenames = [f for f in matching_filenames \ + if not os.path.islink(os.path.join(dirname, f))] if not matching_filenames: continue for prop in prop_list: command = ['svn', 'propset', prop[0], prop[1]] On Sat, Sep 4, 2010 at 4:08 PM, Gavin Beau Baumanis wrote: > Hi Wei-Yin, > > Just thought I would mention that you did not attach your updated patch. > > > Gavin "Beau" Baumanis > E: ga...@thespidernet.com >
Re: [PATCH] don't do autoprops on symbolic links
Hi Wei-Yin, Just thought I would mention that you did not attach your updated patch. Gavin "Beau" Baumanis E: ga...@thespidernet.com On 04/09/2010, at 2:19 PM, Wei-Yin Chen wrote: > Hi Stefan, > > Thanks for your comment. I've updated the patch accordingly. > > Regards, > Wei-Yin > > On Fri, Sep 3, 2010 at 9:08 PM, Stefan Sperling wrote: > > Hi, > > thanks for your patch! > > I think we should use os.sep instead of '/', because os.sep is more portable. > > Also, please put spaces around operators (a + b, instead of a+b), > to keep the style of the script consistent. > > Thanks, > Stefan >
Re: [PATCH] don't do autoprops on symbolic links
On 03.09.2010 15:08, Stefan Sperling wrote: > On Fri, Sep 03, 2010 at 08:58:09PM +0800, Wei-Yin Chen wrote: >> Sorry, that line should have been >> matching_filenames = [f for f in matching_filenames if not >> os.path.islink(dirname+'/'+f)] > Hi, > > thanks for your patch! > > I think we should use os.sep instead of '/', because os.sep is more portable. os.path.join maybe? -- Brane
Re: [PATCH] don't do autoprops on symbolic links
Hi Stefan, Thanks for your comment. I've updated the patch accordingly. Regards, Wei-Yin On Fri, Sep 3, 2010 at 9:08 PM, Stefan Sperling wrote: > > Hi, > > thanks for your patch! > > I think we should use os.sep instead of '/', because os.sep is more > portable. > > Also, please put spaces around operators (a + b, instead of a+b), > to keep the style of the script consistent. > > Thanks, > Stefan >
Re: [PATCH] don't do autoprops on symbolic links
On Fri, Sep 03, 2010 at 08:58:09PM +0800, Wei-Yin Chen wrote: > Sorry, that line should have been > matching_filenames = [f for f in matching_filenames if not > os.path.islink(dirname+'/'+f)] Hi, thanks for your patch! I think we should use os.sep instead of '/', because os.sep is more portable. Also, please put spaces around operators (a + b, instead of a+b), to keep the style of the script consistent. Thanks, Stefan > On Fri, Sep 3, 2010 at 8:15 PM, Wei-Yin Chen > wrote: > > > This patch is for the following file. > > > > https://svn.apache.org/repos/asf/subversion/trunk/contrib/client-side/svn_apply_autoprops.py > > > > Log message: > > Do not apply autoprops on symbolic links in svn_apply_autoprops.py. > > > > > Index: svn_apply_autoprops.py > === > --- svn_apply_autoprops.py > +++ svn_apply_autoprops.py > @@ -124,6 +124,7 @@ > prop_list = autoprops_line[1] > > matching_filenames = fnmatch.filter(filenames, fnmatch_str) > +matching_filenames = [f for f in matching_filenames if not > os.path.islink(dirname+'/'+f)] > if not matching_filenames: >continue >
Re: [PATCH] don't do autoprops on symbolic links
Sorry, that line should have been matching_filenames = [f for f in matching_filenames if not os.path.islink(dirname+'/'+f)] On Fri, Sep 3, 2010 at 8:15 PM, Wei-Yin Chen wrote: > This patch is for the following file. > > https://svn.apache.org/repos/asf/subversion/trunk/contrib/client-side/svn_apply_autoprops.py > > Log message: > Do not apply autoprops on symbolic links in svn_apply_autoprops.py. > > Index: svn_apply_autoprops.py === --- svn_apply_autoprops.py +++ svn_apply_autoprops.py @@ -124,6 +124,7 @@ prop_list = autoprops_line[1] matching_filenames = fnmatch.filter(filenames, fnmatch_str) +matching_filenames = [f for f in matching_filenames if not os.path.islink(dirname+'/'+f)] if not matching_filenames: continue
[PATCH] don't do autoprops on symbolic links
This patch is for the following file. https://svn.apache.org/repos/asf/subversion/trunk/contrib/client-side/svn_apply_autoprops.py Log message: Do not apply autoprops on symbolic links in svn_apply_autoprops.py. Index: svn_apply_autoprops.py === --- svn_apply_autoprops.py (revision HEAD) +++ svn_apply_autoprops.py (working copy) @@ -124,6 +124,7 @@ prop_list = autoprops_line[1] matching_filenames = fnmatch.filter(filenames, fnmatch_str) +matching_filenames = [f for f in matching_filenames if not os.path.islink(f)] if not matching_filenames: continue
