Re: [dev] [st] Blinking clock in ncmpcpp
On Mon, Jul 08, 2019 at 04:13:13PM +0200, Antenore Gatta wrote: > > > On 7/8/19 3:24 PM, Antenore Gatta wrote: > > Hi Rasmus, > > > > On 7/8/19 1:33 PM, Rasmus Dahlberg wrote: > > > Hi, > > > > > > I can confirm the flashing behavior for ranger's image preview as of > > > commit e85b6b64660214121164ea97fb098eaa4935f7db. It appears that the > > > added KeyReleaseMask causes this issue (or something depending on it). > > > > I've the problem on a previous commit > > > > 4f4bccd1627c845330235721f593d2e93418723d > > > > but I have some patches applied, so it may be one of the following: > > > > - Patches > > - A bug that has been fixed and reintroduced. > > > > I'll try to do a bisect > > I went back till 0.4 (vanilla, no patches) and the problem, for me, was > always there. > > For me it's the redraw that cause this issue but I've no clue (and time) how > to debug it further at the moment. > -- > Antenore > pub rsa2048 2019-06-18 [SC] [expires: 2020-06-17] > 4926E189760446785917BC9AD4FF3F99578F0F53 > uid Antenore Gatta > sub rsa2048 2019-06-18 [E] [expires: 2020-06-17] *spoiler* It's not a st bug. The application is using a hack and are depending on a certain way to display/render text. w3m is another "offender". Even if it may have worked in the past by chance using some specific config does not neccesarily mean it is now a bug. -- Kind regards, Hiltjo
Re: [dev] [st] Blinking clock in ncmpcpp
Hi Rasmus, On 7/8/19 1:33 PM, Rasmus Dahlberg wrote: Hi, I can confirm the flashing behavior for ranger's image preview as of commit e85b6b64660214121164ea97fb098eaa4935f7db. It appears that the added KeyReleaseMask causes this issue (or something depending on it). I've the problem on a previous commit 4f4bccd1627c845330235721f593d2e93418723d but I have some patches applied, so it may be one of the following: - Patches - A bug that has been fixed and reintroduced. I'll try to do a bisect pEpkey.asc Description: application/pgp-keys
Re: [dev] [st] Blinking clock in ncmpcpp
On 7/8/19 3:24 PM, Antenore Gatta wrote: Hi Rasmus, On 7/8/19 1:33 PM, Rasmus Dahlberg wrote: Hi, I can confirm the flashing behavior for ranger's image preview as of commit e85b6b64660214121164ea97fb098eaa4935f7db. It appears that the added KeyReleaseMask causes this issue (or something depending on it). I've the problem on a previous commit 4f4bccd1627c845330235721f593d2e93418723d but I have some patches applied, so it may be one of the following: - Patches - A bug that has been fixed and reintroduced. I'll try to do a bisect I went back till 0.4 (vanilla, no patches) and the problem, for me, was always there. For me it's the redraw that cause this issue but I've no clue (and time) how to debug it further at the moment. -- Antenore pEpkey.asc Description: application/pgp-keys
Re: [dev] [st] Blinking clock in ncmpcpp
Hi, I can confirm the flashing behavior for ranger's image preview as of commit e85b6b64660214121164ea97fb098eaa4935f7db. It appears that the added KeyReleaseMask causes this issue (or something depending on it). -Rasmus On Fri, Jul 05, 2019 at 03:35:11PM +0200, Antenore Gatta wrote: > > On 7/5/19 1:13 PM, Miekiv wrote: > > ‐‐‐ Original Message ‐‐‐ > > On Thursday, July 4, 2019 10:44 PM, Antenore Gatta > > wrote: > > > > > >> Well, it's probably because of a text property like "very visible", > >> this one in particular is for the cursor, but I'm sure it's something > >> related/similar to that, "very visible" it's often translated to > >> blinking, underline or bold, that's why I think it's related. > >> > >> Now, to find what is the exact ansi escape sequence that is sent, it's > >> not very easy, maybe you can check the ncmpcpp source code and see how > >> the clock is "rendered". > > > > I looked into the source code responsible for the clock screen but didn't > > find anything responsible for font properties. Here are the links: > > https://github.com/arybczak/ncmpcpp/blob/master/src/screens/clock.cpp > > https://github.com/arybczak/ncmpcpp/blob/master/src/screens/clock.h > > Could you take a look at them? > > I've tried to reproduce the problem and for me it's more a refresh issue > in st, it happens to me also when, with ranger, I try to preview images. > > > In fact, for me, it's not a blinking but a flashing behavior (sorry I > know they are synonyms). > > > Can you confirm? > > If it's the case I don't know how to help either. > pub RSA 2048/578F0F53 2019-06-18 Antenore Gatta > sub RSA 2048/665CB1F8 2019-06-18 >
Re: [dev] [st] Blinking clock in ncmpcpp
On 7/5/19 1:13 PM, Miekiv wrote: ‐‐‐ Original Message ‐‐‐ On Thursday, July 4, 2019 10:44 PM, Antenore Gatta wrote: > Well, it's probably because of a text property like "very visible", > this one in particular is for the cursor, but I'm sure it's something > related/similar to that, "very visible" it's often translated to > blinking, underline or bold, that's why I think it's related. > > Now, to find what is the exact ansi escape sequence that is sent, it's > not very easy, maybe you can check the ncmpcpp source code and see how > the clock is "rendered". I looked into the source code responsible for the clock screen but didn't find anything responsible for font properties. Here are the links: https://github.com/arybczak/ncmpcpp/blob/master/src/screens/clock.cpp https://github.com/arybczak/ncmpcpp/blob/master/src/screens/clock.h Could you take a look at them? I've tried to reproduce the problem and for me it's more a refresh issue in st, it happens to me also when, with ranger, I try to preview images. In fact, for me, it's not a blinking but a flashing behavior (sorry I know they are synonyms). Can you confirm? If it's the case I don't know how to help either. pEpkey.asc Description: application/pgp-keys
Re: [dev] [st] Blinking clock in ncmpcpp
Hi Miekiv, On 04.07.19 22:56, Miekiv wrote: > Hi, recently I started using ncmpcpp on my arch linux machine as my > music player and noticed that the clock is blinking. I checked on > both vanilla st 0.8.2 and on the fork I use ( > https://gitlab.com/Matii/st ) and the blinking happens on both. Well, it's probably because of a text property like "very visible", this one in particular is for the cursor, but I'm sure it's something related/similar to that, "very visible" it's often translated to blinking, underline or bold, that's why I think it's related. Now, to find what is the exact ansi escape sequence that is sent, it's not very easy, maybe you can check the ncmpcpp source code and see how the clock is "rendered", or the hard way with an strace. > However, this issue doesn't occur on other terminals (urxvt, xfce > terminal, xterm), which leads me to believe that it's an issue with > st. I asked about this issue on suckless' IRC server and a guy using > void linux said that he has the same issue on his fork of st. I > decided to set up a virtual machine and check there, but this time > the problem didn't occur. On my main machine, I tried downgrading > ncmpcpp and ncurses, changing xfps and actionfps in config.h to > different values. VM with which OS? What is your TERM environment variable on both? Cheers, Antenore
