Re: [VOTE][SIP-111] Proposal for improved database, schema, and table selection UI in SQL Lab sidebar

[Sam Firke]

+1 binding

On Fri, Sep 27, 2024, at 2:17 PM, robe...@dealmeida.net.invalid wrote:
> +1, binding
> 
> On 2024-09-24 09:31, Justin Park wrote:
> > Hi,
> > 
> > Following up from the corresponding DISCUSS email I sent on January 
> > 2nd, I
> > was hoping to call a vote on [SIP-111] Proposal for improved database,
> > schema, and table selection UI in SQL Lab sidebar as detailed below:
> > https://github.com/apache/superset/issues/26395
> > 
> > The vote will be open for at least 72 hours or until the necessary 
> > number
> > of votes are reached. Please vote accordingly:
> > 
> > [ ] +1 approve
> > [ ] +0 no opinion
> > [ ] -1 disapprove with the reason
> > 
> > 
> > Thanks,
> > Justin Park
> 

Re: [VOTE] Release Apache Superset 4.1.0 based on Superset 4.1.0rc2

[Sam Firke]

Also -1 binding for the same issues.

On Tue, Sep 24, 2024, at 8:24 AM, Michael S. Molina wrote:
> -1 (binding) due to blocking issues reported on 
> https://github.com/apache/superset/discussions/2
> 
> Best regards,
> Michael S. Molina
> 
> > On 22 Aug 2024, at 19:44, Joe Li  wrote:
> > 
> >  Hello Superset Community,
> > 
> > This is a call for the vote to release Apache Superset version 4.1.0.
> > 
> > The release candidate:
> > https://dist.apache.org/repos/dist/dev/superset/4.1.0rc2/
> > 
> > The Git tag for the release:
> > https://github.com/apache/superset/tree/4.1.0rc2
> > 
> > The CHANGELOG for the release:
> > https://github.com/apache/superset/blob/4.1.0rc2/CHANGELOG/4.1.0.md
> > 
> > The instructions for updating to the release:
> > https://github.com/apache/superset/blob/4.1.0rc2/UPDATING.md
> > 
> > Public keys are available at:
> > https://www.apache.org/dist/superset/KEYS
> > 
> > 
> > The vote will be left open until at least 72 hours have passed
> > and the necessary number of votes (3) have been reached.
> > 
> > Please vote accordingly:
> > 
> > [ ] +1 approve
> > [ ] +0 no opinion
> > [ ] -1 disapprove with the reason
> > 
> > Thanks,
> > The Apache Superset Team
> 

Re: [VOTE] [SIP-143] Global Async Task Framework

[Sam Firke]

+1 binding

On Mon, Aug 26, 2024, at 1:13 PM, Ville Brofeldt wrote:
> Hi all,
> 
> I am calling for a vote for SIP-143 [1], following the prior discussion 
> thread [2]. The SIP intends to introduce a new framework for more efficient 
> and user friendly execution of asynchronous tasks.
> 
> The vote will be open for at least 72 hours or until the necessary number of 
> votes are reached. Please vote accordingly:
> 
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
> 
> Thanks,
> 
> Ville
> 
> [1] https://github.com/apache/superset/issues/29839
> [2] https://lists.apache.org/thread/ytv9vx7wrk07xxjg4m4kx5rx0zl5whx1
> 
> 

Re: [VOTE][SIP-130] Migrating from Mapbox to MapLibre

[Sam Firke]

+1 binding - the rationale in the GitHub discussion is sound and it seems like 
there's adequate support pledged.

On Thu, Jul 25, 2024, at 5:49 PM, Evan Rusackas wrote:
> Hi everyone,
> 
> I am calling for a vote for SIP-130 [1], which moves to replace MapBox with 
> MapLibre. This was previously put up for discussion here [2]. As discussed on 
> the GitHub thread, there may be additional SIPs for any significant 
> changes/additions to plugins, but this SIP should pave the way to making the 
> shift away from the now-closed-source library, and enable our volunteer 
> contributor to begin working on further improvements.
> 
> The vote will be open for at least 72 hours or until the necessary number
> of votes are reached. Please vote accordingly:
> 
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
> 
> Thanks,
> 
> -e-
> 
> Evan Rusackas
> Preset | preset.io
> Apache Superset PMC
> 
> [1] https://github.com/apache/superset/issues/28356#issuecomment-2204050427
> [2] https://lists.apache.org/thread/m5941c5dk0wk76xds61hlq48x4vgsh7k
> 

Re: [VOTE] Release Apache Superset 4.1.0 based on Superset 4.1.0rc1

[Sam Firke]

-1 binding for the same reason as Michael 

On Thu, Aug 1, 2024, at 8:32 AM, Michael S. Molina wrote:
> -1 (binding) due to the issues raised in the RC discussion 
> https://github.com/apache/superset/discussions/29705
> 
> > On Jul 29, 2024, at 9:18 AM, Phil Dumbreck  
> > wrote:
> > 
> > 0
> > 
> > Celery imports config was out of date. Docs are correct, but I was using a 
> > config created a few years ago.
> > 
> > https://github.com/apache/superset/issues/29708#issuecomment-2255772493
> > 
> > Thanks,
> > Phil
> > 
> > From: Phil Dumbreck 
> > Date: Saturday, 27 July 2024 at 07:24
> > To: dev@superset.apache.org 
> > Subject: Re: [VOTE] Release Apache Superset 4.1.0 based on Superset 4.1.0rc1
> > [You don't often get email from ph...@graphcore.ai.invalid. Learn why this 
> > is important at https://aka.ms/LearnAboutSenderIdentification ]
> > 
> > -1
> > 
> > I currently have this bug preventing reports from running. 
> > https://github.com/apache/superset/issues/29708
> > 
> > Not had time to debug it further, but I haven’t changed any config from 
> > 4.0.2.
> > 
> > Can anyone reproduce?
> > 
> > Thanks,
> > Phil
> > 
> > From: Joe Li 
> > Date: Friday, 26 July 2024 at 01:09
> > To: dev@superset.apache.org 
> > Subject: [VOTE] Release Apache Superset 4.1.0 based on Superset 4.1.0rc1
> > [This message was sent from somebody outside of your organisation]
> > 
> > 
> > 
> > [You don't often get email from j...@preset.io.invalid. Learn why this is 
> > important at https://aka.ms/LearnAboutSenderIdentification ]
> > 
> > Hello Superset Community,
> > 
> > This is a call for the vote to release Apache Superset version 4.1.0.
> > 
> > The release candidate:
> > https://dist.apache.org/repos/dist/dev/superset/4.1.0rc1/
> > 
> > The Git tag for the release:
> > https://github.com/apache/superset/tree/4.1.0rc1
> > 
> > The CHANGELOG for the release:
> > https://github.com/apache/superset/blob/4.1.0rc1/CHANGELOG/4.1.0.md
> > 
> > The instructions for updating to the release:
> > https://github.com/apache/superset/blob/4.1.0rc1/UPDATING.md
> > 
> > Public keys are available at:
> > https://www.apache.org/dist/superset/KEYS
> > 
> > The vote will be left open until at least 72 hours have passed
> > and the necessary number of votes (3) have been reached.
> > 
> > Please vote accordingly:
> > [ ] +1 approve
> > [ ] +0 no opinion
> > [ ] -1 disapprove with the reason
> > 
> > Thanks,
> > The Apache Superset Team
> > 
> > 
> > ** We have updated our privacy policy, which contains important information 
> > about how we collect and process your personal data. To read the policy, 
> > please click here **
> > 
> > This email and its attachments are intended solely for the addressed 
> > recipients and may contain confidential or legally privileged information.
> > If you are not the intended recipient you must not copy, distribute or 
> > disseminate this email in any way; to do so may be unlawful.
> > 
> > Any personal data/special category personal data herein are processed in 
> > accordance with UK data protection legislation.
> > All associated feasible security measures are in place. Further details are 
> > available from the Privacy Notice on the website and/or from the Company.
> > 
> > Graphcore Limited (registered in England and Wales with registration number 
> > 10185006) is registered at 107 Cheapside, London, UK, EC2V 6DN.
> > This message was scanned for viruses upon transmission. However Graphcore 
> > accepts no liability for any such transmission.
> > 
> > 
> > ** We have updated our privacy policy, which contains important information 
> > about how we collect and process your personal data. To read the policy, 
> > please click here **
> > 
> > This email and its attachments are intended solely for the addressed 
> > recipients and may contain confidential or legally privileged information.
> > If you are not the intended recipient you must not copy, distribute or 
> > disseminate this email in any way; to do so may be unlawful.
> > 
> > Any personal data/special category personal data herein are processed in 
> > accordance with UK data protection legislation.
> > All associated feasible security measures are in place. Further details are 
> > available from the Privacy Notice on the website and/or from the Company.
> > 
> > Graphcore Limited (registered in England and Wales with registration number 
> > 10185006) is registered at 107 Cheapside, London, UK, EC2V 6DN.
> > This message was scanned for viruses upon transmission. However Graphcore 
> > accepts no liability for any such transmission.
> 
> 

Re: [VOTE] Release Apache Superset 4.0.2 based on Superset 4.0.2rc2

[Sam Firke]

+1 binding

The regressions I observed in RC1 have been addressed, thank you Michael and 
Justin and anyone else who worked on those!

Note that the sort order will reverse for horizontal bar charts as a result of 
the fix in #29345. I agree that this is an overall improvement, and it's a 
single click to reverse the order back on each affected chart if desired. But 
admins should be aware of this change. 

Sam


On Wed, Jun 26, 2024, at 12:37 PM, Michael S. Molina wrote:
> Hello Superset Community,
> 
> This is a call for the vote to release Apache Superset version 4.0.2.
> 
> The release candidate:
> https://dist.apache.org/repos/dist/dev/superset/4.0.2rc2/
> 
> The Git tag for the release:
> https://github.com/apache/superset/tree/4.0.2rc2
> 
> The change log for the release:
> https://github.com/apache/superset/blob/4.0.2rc2/CHANGELOG/4.0.2.md
> 
> The instructions for updating to the release:
> https://github.com/apache/superset/blob/4.0.2rc2/UPDATING.md
> 
> Public keys are available at:
> https://www.apache.org/dist/superset/KEYS
> 
> The vote will be open for at least 72 hours or until the necessary number
> of votes are reached.
> 
> Please vote accordingly:
> 
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
> 
> Thanks,
> The Apache Superset Team

Re: [VOTE] Release Apache Superset 4.0.2 based on Superset 4.0.2rc1

[Sam Firke]

Thanks Michael. I have completed my testing of RC1 and found no other issues.

Sam

On Wed, Jun 26, 2024, at 8:00 AM, Michael S. Molina wrote:
> -1 (binding)
> 
> I am downvoting the release given the issues mentioned by Sam and a couple 
> more reported by other community members. The fixes are all ready so I will 
> generate RC2 right away.
> 
> Michael
> 
> > On Jun 24, 2024, at 9:34 AM, Sam Firke  wrote:
> > 
> > I am part way through testing and have found a couple of regressions from 
> > 4.0.0:
> > https://github.com/apache/superset/issues/29342 - folks have been posting 
> > this one in Slack
> > https://github.com/apache/superset/issues/29331 - this is trivial on its 
> > surface but as I've only just found it, don't know if it has other 
> > implications for broader functionality problems
> > 
> > I believe these are regressions from 4.0.0, so not problems introduced in 
> > *this *release.  That said if they could be fixed, 4.0.2 would be a more 
> > stable release.
> > 
> > Sam
> > 
> > 
> > On Tue, Jun 18, 2024, at 9:42 AM, Michael S. Molina wrote:
> >> Hello Superset Community,
> >> 
> >> This is a call for the vote to release Apache Superset version 4.0.2.
> >> 
> >> The release candidate:
> >> https://dist.apache.org/repos/dist/dev/superset/4.0.2rc1/
> >> 
> >> The Git tag for the release:
> >> https://github.com/apache/superset/tree/4.0.2rc1
> >> 
> >> The change log for the release:
> >> https://github.com/apache/superset/blob/4.0.2rc1/CHANGELOG/4.0.2.md
> >> 
> >> The instructions for updating to the release:
> >> https://github.com/apache/superset/blob/4.0.2rc1/UPDATING.md
> >> 
> >> Public keys are available at:
> >> https://www.apache.org/dist/superset/KEYS
> >> 
> >> The vote will be open for at least 72 hours or until the necessary number
> >> of votes are reached.
> >> 
> >> Please vote accordingly:
> >> 
> >> [ ] +1 approve
> >> [ ] +0 no opinion
> >> [ ] -1 disapprove with the reason
> >> 
> >> Thanks,
> >> The Apache Superset Team
> >> 
> 
> 

Re: [VOTE] Release Apache Superset 4.0.2 based on Superset 4.0.2rc1

[Sam Firke]

I am part way through testing and have found a couple of regressions from 4.0.0:
https://github.com/apache/superset/issues/29342 - folks have been posting this 
one in Slack
https://github.com/apache/superset/issues/29331 - this is trivial on its 
surface but as I've only just found it, don't know if it has other implications 
for broader functionality problems

I believe these are regressions from 4.0.0, so not problems introduced in *this 
*release.  That said if they could be fixed, 4.0.2 would be a more stable 
release.

Sam


On Tue, Jun 18, 2024, at 9:42 AM, Michael S. Molina wrote:
> Hello Superset Community,
> 
> This is a call for the vote to release Apache Superset version 4.0.2.
> 
> The release candidate:
> https://dist.apache.org/repos/dist/dev/superset/4.0.2rc1/
> 
> The Git tag for the release:
> https://github.com/apache/superset/tree/4.0.2rc1
> 
> The change log for the release:
> https://github.com/apache/superset/blob/4.0.2rc1/CHANGELOG/4.0.2.md
> 
> The instructions for updating to the release:
> https://github.com/apache/superset/blob/4.0.2rc1/UPDATING.md
> 
> Public keys are available at:
> https://www.apache.org/dist/superset/KEYS
> 
> The vote will be open for at least 72 hours or until the necessary number
> of votes are reached.
> 
> Please vote accordingly:
> 
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
> 
> Thanks,
> The Apache Superset Team
> 

Re: Deployment

[Sam Firke]

Correct. You can set up WSL2 on the Windows PC, at which point you're running 
Linux. Then deploy with Linux. Does that count as running Superset on Windows? 
It's a philosophical question at that point 😁

My org runs almost entirely Windows and looked into the above approach. We 
decided it was simpler from a maintenance perspective to just stand up an 
Ubuntu Linux VM and run in native Linux. 

Sam

On Tue, May 21, 2024, at 3:35 AM, Morne Ayres wrote:
> Hi,
>  
> I just want to confirm the following
>  • Superset cannot be deployed on a winders server PC and needs Linux or 
> other OS
>  
> Thanking you in advance
>  
> Regards
> Morne Ayres
> B.Pharm
> B.Sc hons (Pharmacology)
> C: 082 957 1592
>  
> IT’S NOT ABOUT IDEAS, IT’S ABOUT MAKING IDEAS HAPPEN….
> 
>  

Re: [VOTE] Release Apache Superset 4.0.1 based on Superset 4.0.1rc1

[Sam Firke]

+1 binding

I deployed rc1 to my test environment. Authentication, alerts and reports, 
chart creation, existing dashboards all look good. I tried out some of the bug 
fixes and they look good too, e.g., enabling drill-by on a time series chart 
where there is no dimension (#27941). 

On Thu, May 2, 2024, at 11:04 AM, Michael S. Molina wrote:
> Hello Superset Community,
> 
> This is a call for the vote to release Apache Superset version 4.0.1.
> 
> The release candidate:
> https://dist.apache.org/repos/dist/dev/superset/4.0.1rc1/
> 
> The Git tag for the release:
> https://github.com/apache/superset/tree/4.0.1rc1
> 
> The change log for the release:
> https://github.com/apache/superset/blob/4.0.1rc1/CHANGELOG/4.0.1.md
> 
> The instructions for updating to the release:
> https://github.com/apache/superset/blob/4.0.1rc1/UPDATING.md
> 
> Public keys are available at:
> https://www.apache.org/dist/superset/KEYS
> 
> The vote will be open for at least 72 hours or until the necessary number
> of votes are reached.
> 
> Please vote accordingly:
> 
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
> 
> Thanks,
> The Apache Superset Team
> 

Re: [VOTE][SIP-123] Proposal replacement of data table components with ag-grid

[Sam Firke]

This sounded dull because I was unfamiliar with the terms. Then I opened the 
SIP and it looks awesome! That's a nicely done SIP, thanks for the write-up.

+1 binding

On Tue, Apr 16, 2024, at 8:51 PM, Michael S. Molina wrote:
> +1 (binding)
> 
> Best regards,
> Michael S. Molina
> 
> > On 16 Apr 2024, at 21:39, Ville Brofeldt  wrote:
> > 
> > Hi,
> > 
> > this SIP had gone unnoticed by me. But after reading through it I'm super 
> > excited to see this moving forward, and I think this will have a huge 
> > impact on the Superset UX. So big +1 from me.
> > 
> > Ville
> > 
> >> On Apr 16, 2024, at 11:41 AM, Justin Park  wrote:
> >> 
> >> Hi,
> >> 
> >> Following up from the corresponding DISCUSS email I sent on April 9th, I
> >> was hoping to call a vote on [SIP-123] Proposal replacement of data table
> >> components with ag-grid as detailed below:
> >> https://github.com/apache/superset/issues/27645
> >> 
> >> The vote will be open for at least 72 hours or until the necessary number
> >> of votes are reached. Please vote accordingly:
> >> 
> >> [ ] +1 approve
> >> [ ] +0 no opinion
> >> [ ] -1 disapprove with the reason
> >> 
> >> 
> >> Thanks
> >> - Justin
> > 
> 

Re: [VOTE] Release Apache Superset 4.0.0 based on Superset 4.0.0rc1

[Sam Firke]

This RC was very nice. I tested thoroughly and found things looking good 
overall. Drill-to-detail seemed broken for a second, but then I haven't been 
able to replicate it so it was probably only user error. I opened and then 
closed an issue on it: https://github.com/apache/superset/issues/27424

Otherwise no problems to report. I tested alerts and reports using the -dev 
image bundled Firefox, looked at many dashboards, drilled, created a few charts.

I'd vote +1 except that others have noted blocking problems with embedded. 
Officially I will vote -1 (not binding) on this rc1. But I plan to vote +1 on 
rc2 assuming no new regressions.

Kudos to the release manager and everyone who contributed clean code to produce 
such a nice release!

Sam

On Tue, Feb 20, 2024, at 12:29 PM, Michael S. Molina wrote:
> Hello Superset Community,
> 
> This is a call for the vote to release Apache Superset version 4.0.0.
> 
> The release candidate:
> https://dist.apache.org/repos/dist/dev/superset/4.0.0rc1/
> 
> The Git tag for the release:
> https://github.com/apache/superset/tree/4.0.0rc1
> 
> The change log for the release:
> https://github.com/apache/superset/blob/4.0.0rc1/CHANGELOG/4.0.0.md
> 
> The instructions for updating to the release:
> https://github.com/apache/superset/blob/4.0.0rc1/UPDATING.md
> 
> Public keys are available at:
> https://www.apache.org/dist/superset/KEYS
> 
> The vote will be open for at least 72 hours or until the necessary number
> of votes are reached.
> 
> Please vote accordingly:
> 
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
> 
> Thanks,
> The Apache Superset Team
> 

Re: [VOTE] Release Apache Superset 3.0.3 based on Superset 3.0.3rc3

[Sam Firke]

+1

I tested this with many of my production dashboards and verified that alerts & 
reports works with docker compose deployment and the -dev container image.

The fix of #26034 introduced a new bug #26254.  Both cannot currently be fixed 
simultaneously due to a limitation of ECharts.  See the discussion in #26254 
for more details.  But a nice workaround for the new bug was included in 
#26404, now users can fix a chart by checking the "force categorical" box 
instead of having to cast new column types in their database.

I verified that the "force categorical" option works for charts with numerical 
x-axes and I find it to be as good a fix for now as possible.  Thanks to all 
who worked on this set of related problems, especially Michael and Ville!

Sam

On Tue, Jan 9, 2024, at 9:12 AM, Michael S. Molina wrote:
> Hello Superset Community,
> 
> This is a call for the vote to release Apache Superset version 3.0.3.
> 
> The release candidate:
> https://dist.apache.org/repos/dist/dev/superset/3.0.3rc3/
> 
> Git tag for the release:
> https://github.com/apache/superset/tree/3.0.3rc3
> 
> The Change Log for the release:
> https://github.com/apache/superset/blob/3.0.3rc3/CHANGELOG.md
> 
> The Updating instructions for the release:
> https://github.com/apache/superset/blob/3.0.3rc3/UPDATING.md
> 
> Public keys are available at:
> https://www.apache.org/dist/superset/KEYS
> 
> The vote will be open for at least 72 hours or until the necessary number
> of votes are reached.
> 
> Please vote accordingly:
> 
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
> 
> Thanks,
> The Apache Superset Team

Re: [VOTE] Release Apache Superset 3.0.3 based on Superset 3.0.3rc1

[Sam Firke]

-1 as this has cherries that break bar charts with a numeric x-axis. See 
discussion on the RC thread for 3.1.0rc2 for details as my understanding is 
that those cherries affect 3.0.3rc1: 
https://github.com/apache/superset/discussions/26240

On Mon, Dec 11, 2023, at 11:23 AM, Michael S. Molina wrote:
> Hello Superset Community,
> 
> This is a call for the vote to release Apache Superset version 3.0.3.
> 
> The release candidate:
> https://dist.apache.org/repos/dist/dev/superset/3.0.3rc1/
> 
> Git tag for the release:
> https://github.com/apache/superset/tree/3.0.3rc1
> 
> The Change Log for the release:
> https://github.com/apache/superset/blob/3.0.3rc1/CHANGELOG.md
> 
> The Updating instructions for the release:
> https://github.com/apache/superset/blob/3.0.3rc1/UPDATING.md
> 
> Public keys are available at:
> https://www.apache.org/dist/superset/KEYS
> 
> The vote will be open for at least 72 hours or until the necessary number
> of votes are reached.
> 
> Please vote accordingly:
> 
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
> 
> Thanks,
> The Apache Superset Team

Re: [VOTE] Release Apache Superset 3.1.0 based on Superset 3.1.0rc2

[Sam Firke]

-1 due to the regressions associated with bar charts having a numeric x-axis. 
See discussion on the RC thread for details: 
https://github.com/apache/superset/discussions/26240

On Mon, Dec 11, 2023, at 2:57 PM, Michael S. Molina wrote:
> Hello Superset Community,
> 
> This is a call for the vote to release Apache Superset version 3.1.0.
> 
> The release candidate:
> https://dist.apache.org/repos/dist/dev/superset/3.1.0rc2/
> 
> Git tag for the release:
> https://github.com/apache/superset/tree/3.1.0rc2
> 
> The Change Log for the release:
> https://github.com/apache/superset/blob/3.1.0rc2/CHANGELOG.md
> 
> The Updating instructions for the release:
> https://github.com/apache/superset/blob/3.1.0rc2/UPDATING.md
> 
> Public keys are available at:
> https://www.apache.org/dist/superset/KEYS
> 
> The vote will be open for at least 72 hours or until the necessary number
> of votes are reached.
> 
> Please vote accordingly:
> 
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
> 
> Thanks,
> The Apache Superset Team

Re: [VOTE][SIP-108] Superset Release Process

[Sam Firke]

+1 vote and ditto what Evan said.

On Mon, Dec 4, 2023, at 5:12 PM, Evan Rusackas wrote:
> +1 (binding)
> 
> This discussion and document have been shaping up nicely for quite some time, 
> and I’m glad that we’re at the point where so many of us are in alignment. As 
> always, we can continue to adjust and dial things in via further proposals, 
> if such refinements are deemed necessary. I’m excited to see our process 
> taking shape, which I expect will translate to more frequent, less painful, 
> and more stable releases in the future.
> 
> Thanks Michael, for all the hard work in this effort!
> 
> -e-
> 
> Evan Rusackas
> Preset | preset.io
> Apache Superset PMC
> On Dec 4, 2023 at 10:43 AM -0700, Michael S. Molina 
> , wrote:
> > Hi,
> >
> > Having launched a formal discussion thread for [SIP-108] Superset Release 
> > Process (https://github.com/apache/superset/issues/26015) a few weeks ago, 
> > I thought it would be prudent to
> > now put the SIP to a vote.
> >
> > The vote will be open for at least 72 hours or until the necessary number
> > of votes are reached. Please vote accordingly:
> >
> > [ ] +1 approve
> > [ ] +0 no opinion
> > [ ] -1 disapprove with the reason
> >
> > Best regards,
> > Michael S. Molina
> 

Re: [VOTE] Release Apache Superset 3.1.0 based on Superset 3.1.0rc1

[Sam Firke]

-1 due to the issues documented in the thread John linked. I encourage folks to 
test rc1 as long as the vote is open so that as many issues as possible are 
identified and we keep the number of release candidates to a minimum.

Thanks to Michael for leading this release process!

On Fri, Dec 1, 2023, at 9:34 PM, John Bodley wrote:
> -1 (binding)
> 
> Per the discussion thread
>  there's already a
> handful of issues detected including an Alembic migration ordering
> issue—due to a picked cherry which went astray —which renders the
> application unusable when upgrading from 3.0 to 3.1.
> 
> On Tue, Nov 28, 2023 at 10:22 AM Michael S. Molina <
> michael.s.mol...@gmail.com> wrote:
> 
> > Hello Superset Community,
> >
> > This is a call for the vote to release Apache Superset version 3.1.0.
> >
> > The release notes:
> >
> > https://github.com/apache/superset/blob/master/RELEASING/release-notes-3-1/README.md
> >
> > The release candidate:
> > https://dist.apache.org/repos/dist/dev/superset/3.1.0rc1/
> >
> > Git tag for the release:
> > https://github.com/apache/superset/tree/3.1.0rc1
> >
> > The Change Log for the release:
> > https://github.com/apache/superset/blob/3.1.0rc1/CHANGELOG.md
> >
> > The Updating instructions for the release:
> > https://github.com/apache/superset/blob/3.1.0rc1/UPDATING.md
> >
> > Public keys are available at:
> > https://www.apache.org/dist/superset/KEYS
> >
> > The vote will be open for at least 72 hours or until the necessary number
> > of votes are reached.
> >
> > Please vote accordingly:
> >
> > [ ] +1 approve
> > [ ] +0 no opinion
> > [ ] -1 disapprove with the reason
> >
> > Thanks,
> > The Apache Superset Team
> 

Re: [VOTE] Release Apache Superset 3.0.2 based on Superset 3.0.2rc2

[Sam Firke]

+1 

The Azure SSO problem from rc1 is fixed (thanks Michael and Daniel!). I clicked 
around, did some light testing, everything looked good.

Sam

On Mon, Nov 20, 2023, at 3:41 PM, Michael S. Molina wrote:
> Hello Superset Community,
> 
> This is a call for the vote to release Apache Superset version 3.0.2.
> 
> The release candidate:
> https://dist.apache.org/repos/dist/dev/superset/3.0.2rc2/
> 
> Git tag for the release:
> https://github.com/apache/superset/tree/3.0.2rc2
> 
> The Change Log for the release:
> https://github.com/apache/superset/blob/3.0.2rc2/CHANGELOG.md
> 
> The Updating instructions for the release:
> https://github.com/apache/superset/blob/3.0.2rc2/UPDATING.md
> 
> Public keys are available at:
> https://www.apache.org/dist/superset/KEYS
> 
> The vote will be open for at least 72 hours or until the necessary number
> of votes are reached.
> 
> Please vote accordingly:
> 
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
> 
> Thanks,
> The Apache Superset Team
> 

Re: [VOTE] Release Apache Superset 3.0.2 based on Superset 3.0.2rc1

[Sam Firke]

-1 

My existing Azure SSO broke when I tried out 3.0.2rc1.  I'm unable to log in.

When I revert the image to 3.0.1 it works again. Perhaps related to a bump in 
the Flask App builder version? I've created a GitHub issue for this, #26007.

On Thu, Nov 16, 2023, at 12:57 PM, Ville Brofeldt wrote:
> +1 (binding)
> 
> > On Nov 14, 2023, at 6:43 AM, Michael S. Molina  
> > wrote:
> > 
> > Hello Superset Community,
> > 
> > This is a call for the vote to release Apache Superset version 3.0.2.
> > 
> > The release candidate:
> > https://dist.apache.org/repos/dist/dev/superset/3.0.2rc1/
> > 
> > Git tag for the release:
> > https://github.com/apache/superset/tree/3.0.2rc1
> > 
> > The Change Log for the release:
> > https://github.com/apache/superset/blob/3.0.2rc1/CHANGELOG.md
> > 
> > The Updating instructions for the release:
> > https://github.com/apache/superset/blob/3.0.2rc1/UPDATING.md
> > 
> > Public keys are available at:
> > https://www.apache.org/dist/superset/KEYS
> > 
> > The vote will be open for at least 72 hours or until the necessary number
> > of votes are reached.
> > 
> > Please vote accordingly:
> > 
> > [ ] +1 approve
> > [ ] +0 no opinion
> > [ ] -1 disapprove with the reason
> > 
> > Thanks,
> > The Apache Superset Team
> 
> 

Re: [VOTE] Release Apache Superset 3.0.0 based on Superset 3.0.0rc3

[Sam Firke]

I tested reports and my existing dashboards, all of that looked good. I 
commented in the #apache-releases channel re: some aesthetic changes that I 
think should be noted in the release notes.

I'll vote -1 though because of bugs noted in the link John supplied below.

On Tue, Aug 29, 2023, at 2:52 PM, John Bodley wrote:
> -1 (binding)
> 
> Downvoting due to a number of critical issues mentioned here
> .
> 
> On Mon, Aug 28, 2023 at 12:06 PM Evan Rusackas 
> wrote:
> 
> > Still testing this one too, but the signatures and checksums were also
> > verified here, just to get that technicality out of the way...
> >
> > Thanks again,
> >
> > -e-
> >
> > Evan Rusackas
> > Preset | preset.io
> > On Aug 24, 2023 at 1:48 PM -0600, Michael S. Molina <
> > michael.s.mol...@gmail.com>, wrote:
> > > Hello Superset Community,
> > >
> > > This is a call for the vote to release Apache Superset version 3.0.0.
> > >
> > > The release candidate:
> > > https://dist.apache.org/repos/dist/dev/superset/3.0.0rc3
> > >
> > > Git tag for the release:
> > > https://github.com/apache/superset/tree/3.0.0rc3
> > >
> > > The Change Log for the release:
> > > https://github.com/apache/superset/blob/3.0.0rc3/CHANGELOG.md <
> > https://github.com/apache/superset/blob/3.0.0rc/CHANGELOG.md>
> > >
> > > The Updating instructions for the release:
> > > https://github.com/apache/superset/blob/3.0.0rc3/UPDATING.md <
> > https://github.com/apache/superset/blob/3.0.0rc/UPDATING.md>
> > >
> > > Public keys are available at:
> > > https://www.apache.org/dist/superset/KEYS
> > >
> > > The vote will be open for at least 72 hours or until the necessary number
> > > of votes are reached.
> > >
> > > Please vote accordingly:
> > >
> > > [ ] +1 approve
> > > [ ] +0 no opinion
> > > [ ] -1 disapprove with the reason
> > >
> > > Thanks,
> > > The Apache Superset Team
> >
> 

Re: [VOTE] Release Apache Superset 2.1.1 based on Superset 2.1.1rc3

[Sam Firke]

+1

On Tue, Aug 22, 2023, at 10:43 AM, Michael S. Molina wrote:
> +1 (binding)
> 
> Best regards,
> Michael S. Molina
> 
> > On 22 Aug 2023, at 11:38, Daniel Gaspar  wrote:
> > 
> > +1 (binding)
> > 
> > Cheers,
> > Daniel Gaspar / Superset PMC
> > 
> > 
> >> On Fri, 18 Aug 2023 at 01:49, Elizabeth Thompson
> >>  wrote:
> >> 
> >> Hello Superset Community,
> >> 
> >> This is a call for the vote to release Apache Superset version 2.1.1.
> >> 
> >> The release candidate:
> >> https://dist.apache.org/repos/dist/dev/superset/2.1.1rc3/
> >> 
> >> Git tag for the release:
> >> https://github.com/apache/superset/tree/2.1.1rc3
> >> 
> >> The Change Log for the release:
> >> https://github.com/apache/superset/blob/2.1.1rc3/CHANGELOG.md
> >> 
> >> The Updating instructions for the release:
> >> https://github.com/apache/superset/blob/2.1.1rc3/UPDATING.md
> >> 
> >> Public keys are available at:
> >> https://www.apache.org/dist/superset/KEYS
> >> 
> >> The vote will be open for at least 72 hours or until the necessary number
> >> of votes are reached.
> >> 
> >> Please vote accordingly:
> >> 
> >> [ ] +1 approve
> >> [ ] +0 no opinion
> >> [ ] -1 disapprove with the reason
> >> 
> >> Thanks,
> >> The Apache Superset Team
> >> 
> >> 
> 

Re: [ANNOUNCE] New Committer: Sam Firke

[Sam Firke]

Thanks Evan! I appreciate the opportunity and I'm excited to collaborate more 
in-depth with the great folks in the Superset community.

Sam

On Mon, Jul 31, 2023, at 5:30 PM, Evan Rusackas wrote:
> Let me try that first sentence again...
> 
> The Project Management Committee (PMC) for Apache Superset has invited Sam 
> Firke to become a committer and we are pleased to announce that he has 
> accepted.
> 
> While I botched the templated part, the personalized part of the message is 
> still 100% sincere :) Again, welcome aboard, Sam! We’re lucky to have you on 
> the roster.
> 
> -e-
> 
> Evan Rusackas
> Preset | preset.io
> Apache Superset PMC
> On Jul 31, 2023 at 3:25 PM -0600, Evan Rusackas , 
> wrote:
> > The Project Management Committee (PMC) for Apache Superset has invited Sam 
> > Fire to become a committer and we are pleased to announce that she has 
> > accepted.
> > Sam has been contributing to the Superset community in a number of ways - 
> > from helping with GitHub Issues (troubleshooting, triaging, and helping to 
> > close them), to helping drive efforts (and PRs!) around Superset’s 
> > documentation He’s also been helping with testing/voting releases, and 
> > helping drive community conversation around release strategy and more. We 
> > hope this new level of access will not only empower Sam in his continuing 
> > contributions, but help him to help others follow in his footsteps.
> >
> > Being a committer enables easier contribution to the project since there is 
> > no need to go via the patch submission process. This should enable better 
> > productivity. A PMC member helps manage and guide the direction of the 
> > project.
> >
> > Welcome aboard, Sam!
> >
> > Evan Rusackas
> > Preset | preset.io
> > Apache Superset PMC
> 

Proposal: Tag docker images of official Apache releases as "official"

[Sam Firke]

There's been a little discussion about this on Github 
(https://github.com/apache/superset/discussions/22244) and in the 
#operational-model-release-strategy channel on Slack.

I propose that the release process for an official Apache release include 
tagging the associated docker images with a new tag, "official."  That's in 
line with what's on Docker Hub (https://hub.docker.com/r/apache/superset), 
which says '"Official" Releases coming soon.'  Then the project's 
docker-compose-non-dev.yml file could point new users to the official image, 
rather than the latest (possibly-unstable) build.

This would be in line with release guidance from the Apache Foundation and make 
it easier for new Superset admins to experience success with the product.  The 
Foundation says, in bold, "*Projects MUST direct outsiders towards official 
releases rather than raw source repositories, nightly builds, snapshots, 
release candidates, or any other similar packages."*

Are there any concerns or alternatives that people would prefer?  One thing I'm 
unsure about is how to handle cases like 1.5.3 being released after 2.0.1.  
Would it be undesirable for 1.5.3 to take over the "official" tag from 2.0.1 in 
that case?  I'd think the highest numerical version should be the "official" 
release, not the latest chronologically.  Which I'm not sure how to implement 
in the automated release process, but I hope would be possible.

The upcoming release of 3.0.0 offers an opportunity to implement this, thus I'm 
raising it now.

Re: [VOTE] Release Apache Superset 2.1.1 based on Superset 2.1.1rc1

[Sam Firke]

That sounds great to me, thanks for working on this.  In that case I vote -1 
(non-binding) on this rc1 and would vote +1 on a subsequent rc where this PR 
was reverted.

On Tue, Jun 27, 2023, at 7:54 AM, Daniel Gaspar wrote:
> Sam,
> 
> Thank you for testing and reporting this issue.
> 
> I think that a path forward would be to revert that PR on 2.1.1 and fixing
> Alert & Reports auth issue on master and inclusion on 3.0.0
> 
> 
> On Mon, 26 Jun 2023 at 15:26, Sam Firke  wrote:
> 
> > The addition of strong session protection by default <
> > https://github.com/apache/superset/pull/24256> meant that I could not log
> > into Superset when I switched the image to 2.1.1rc1 – I was stuck in a
> > redirect loop from the welcome screen to the login screen.  I changed my
> > config to SESSION_PROTECTION = “basic” and everything worked okay after
> > that.  Including alerts & reports, which some users report is broken by the
> > default value of “strong”, see the prior link.
> >
> > Is that enough of a breaking change that the default setting of “strong”
> > should happen in 3.0.0?  If it’s going into 2.1.1, I think it should be
> > highlighted prominently on UPDATING.md <
> > https://github.com/apache/superset/blob/master/UPDATING.md>.  Right now
> > that page does not have a section for 2.1.1, just “Next” which is mostly
> > 3.0.0 changes.
> >
> > Otherwise the release looks good.  The bug fixes that pertain to my issues
> > work great (like the PivotTable v2 width correction)!
> >
> > Sam
> >
> >
> >
> > On Thu, Jun 22, 2023, at 5:35 AM, Daniel Gaspar wrote:
> > > +1 (binding)
> > >
> > > Daniel Gaspar / Superset PMC
> > >
> > >
> > > On Fri, 16 Jun 2023 at 20:53, Elizabeth Thompson
> > >  wrote:
> > >
> > > > Hello Superset Community,
> > > >
> > > > This is a call for the vote to release Apache Superset version 2.1.1.
> > > >
> > > > The release candidate:
> > > > https://dist.apache.org/repos/dist/dev/superset/2.1.1rc1/
> > > >
> > > > Git tag for the release:
> > > > https://github.com/apache/superset/tree/2.1.1rc1
> > > >
> > > > The Change Log for the release:
> > > > https://github.com/apache/superset/blob/2.1.1rc1/CHANGELOG.md
> > > >
> > > > The Updating instructions for the release:
> > > > https://github.com/apache/superset/blob/2.1.1rc1/UPDATING.md
> > > >
> > > > Public keys are available at:
> > > > https://www.apache.org/dist/superset/KEYS
> > > >
> > > > The vote will be open for at least 72 hours or until the necessary
> > number
> > > > of votes are reached.
> > > >
> > > > Please vote accordingly:
> > > >
> > > > [ ] +1 approve
> > > > [ ] +0 no opinion
> > > > [ ] -1 disapprove with the reason
> > > >
> > > > Thanks,
> > > > The Apache Superset Team
> > > >
> > > >
> > >
> >
> 

Re: [VOTE] Release Apache Superset 2.1.1 based on Superset 2.1.1rc1

[Sam Firke]

The addition of strong session protection by default 
 meant that I could not log into 
Superset when I switched the image to 2.1.1rc1 – I was stuck in a redirect loop 
from the welcome screen to the login screen.  I changed my config to 
SESSION_PROTECTION = “basic” and everything worked okay after that.  Including 
alerts & reports, which some users report is broken by the default value of 
“strong”, see the prior link.
 
Is that enough of a breaking change that the default setting of “strong” should 
happen in 3.0.0?  If it’s going into 2.1.1, I think it should be highlighted 
prominently on UPDATING.md 
.  Right now that 
page does not have a section for 2.1.1, just “Next” which is mostly 3.0.0 
changes.
 
Otherwise the release looks good.  The bug fixes that pertain to my issues work 
great (like the PivotTable v2 width correction)!
 
Sam



On Thu, Jun 22, 2023, at 5:35 AM, Daniel Gaspar wrote:
> +1 (binding)
> 
> Daniel Gaspar / Superset PMC
> 
> 
> On Fri, 16 Jun 2023 at 20:53, Elizabeth Thompson
>  wrote:
> 
> > Hello Superset Community,
> >
> > This is a call for the vote to release Apache Superset version 2.1.1.
> >
> > The release candidate:
> > https://dist.apache.org/repos/dist/dev/superset/2.1.1rc1/
> >
> > Git tag for the release:
> > https://github.com/apache/superset/tree/2.1.1rc1
> >
> > The Change Log for the release:
> > https://github.com/apache/superset/blob/2.1.1rc1/CHANGELOG.md
> >
> > The Updating instructions for the release:
> > https://github.com/apache/superset/blob/2.1.1rc1/UPDATING.md
> >
> > Public keys are available at:
> > https://www.apache.org/dist/superset/KEYS
> >
> > The vote will be open for at least 72 hours or until the necessary number
> > of votes are reached.
> >
> > Please vote accordingly:
> >
> > [ ] +1 approve
> > [ ] +0 no opinion
> > [ ] -1 disapprove with the reason
> >
> > Thanks,
> > The Apache Superset Team
> >
> >
> 

Re: [VOTE] Release Apache Superset 2.1.0 based on Superset 2.1.0rc2

[Sam Firke]

Yes, both work with 2.1.0-dev.  The difference between those images is that the 
-dev image is bundled with additional software, including Firefox.  You can see 
that from looking at the Dockerfile: 
https://github.com/apache/superset/blob/master/Dockerfile#L105  The browser is 
needed to take screenshots.

My approach has been to modify my docker-compose file so that I'm using 2.1.0 
for the main application container and 2.1.0-dev for the worker containers.  I 
posted about this on Github Discussions 
<https://github.com/apache/superset/discussions/22245>.

I expect you and I are not the only ones to be confused by this.  This comes up 
in Slack regularly.  I updated the Alerts & Reports docs  
<https://superset.apache.org/docs/installation/alerts-reports/>to explain why 
one has to run a "dev" image in production in this case - see the paragraphs 
beginning with the text "Note: All the components required" ...

I think there's an opportunity to make this easier on new users by bundling the 
software needed for Alerts & Reports into the main image (my preference) or 
into a separate new image that isn't called "dev" so that reporting works out 
of the box.  If there's support for that, I'd be happy to help however I can.

Sam

P.S. If you made it this far and are interested in clarifying labels of docker 
images, check out this thread re: issues with the current state of pointing new 
users to the latest tag <https://github.com/apache/superset/discussions/22244>.

On Sun, May 7, 2023, at 9:52 AM, Soni, Pankaj wrote:
> Thanks,
> Emails for text report/alert works for me, but not with screenshot. Emails 
> with screenshot is working for you?
> 
> I am using 2.1.0 and it doesn't work.
> How about 2.1.0-dev I believe 2.1.0 and 2.1.0-dev are same. Ideally
> shouldn’t the fix present in 2.1.0 itself.
> 
> Get Outlook for Android<https://aka.ms/AAb9ysg>
> 
> From: Sam Firke 
> Sent: Friday, May 5, 2023 9:41:05 PM
> To: dev@superset.apache.org 
> Subject: Re: [VOTE] Release Apache Superset 2.1.0 based on Superset 2.1.0rc2
> 
> 
> [EXTERNAL EMAIL]
> 
> This is fixed in 2.1.0, I'm running the 2.1.0-dev image as my docker-compose 
> worker container and emails work correctly.
> 
> You might consider posting your situation in Slack to see if someone can help 
> troubleshoot the config?
> 
> On Fri, May 5, 2023, at 7:34 AM, Soni, Pankaj wrote:
> > I tested this image (apache/superset:pr-23388-dev) earlier, It was working 
> > fine with emails having screenshot.
> > And the fix was added in 2.1.0 but I am still facing the same issue (Error: 
> > Failed taking a screenshot Message: 'geckodriver' executable needs to be in 
> > PATH.)
> >
> > Can anyone please have a look, Mails are very important feature for 
> > Superset.
> >
> >
> > Thanks,
> > Pankaj
> >
> > Internal Use - Confidential
> >
> > -Original Message-
> > From: Tai Dupree 
> > Sent: Friday, March 17, 2023 11:37 PM
> > To: dev@superset.apache.org
> > Subject: Re: [VOTE] Release Apache Superset 2.1.0 based on Superset 2.1.0rc2
> >
> >
> > [EXTERNAL EMAIL]
> >
> > Yes, I was able to receive an email report. You need to use an image tagged 
> > with dev, you can try apache/superset:pr-23388-dev.
> >
> > On Fri, Mar 17, 2023 at 2:47 AM Soni, Pankaj 
> > wrote:
> >
> > > Hi,
> > > Are you also able to get screenshots in the mail?
> > > As per your suggestion I tried your fix from recently pushed image:
> > > "apache/superset:e3a7d2014df179088e14a5fc953dc66f69ba0f04-py39"
> > > This incorporates the fix for webdriver. I am able to get reports but
> > > still screenshot gives same error "Failed taking a screenshot Message:
> > > 'geckodriver' executable needs to be in PATH"
> > >
> > > Thanks,
> > > Pankaj
> > >
> > >
> > > Internal Use - Confidential
> > >
> > > -Original Message-
> > > From: Tai Dupree 
> > > Sent: Friday, March 17, 2023 11:50 AM
> > > To: dev@superset.apache.org
> > > Subject: Re: [VOTE] Release Apache Superset 2.1.0 based on Superset
> > > 2.1.0rc2
> > >
> > >
> > > [EXTERNAL EMAIL]
> > >
> > > I was just able to receive an email report just fine, so I don't think
> > > the issue is with this release (aside from what's addressed in my PR).
> > > That connection timeout error is usually networking/config related.
> > > Are you sure you can reach the

Re: [VOTE] Release Apache Superset 2.1.0 based on Superset 2.1.0rc2

[Sam Firke]

This is fixed in 2.1.0, I'm running the 2.1.0-dev image as my docker-compose 
worker container and emails work correctly.

You might consider posting your situation in Slack to see if someone can help 
troubleshoot the config?

On Fri, May 5, 2023, at 7:34 AM, Soni, Pankaj wrote:
> I tested this image (apache/superset:pr-23388-dev) earlier, It was working 
> fine with emails having screenshot.
> And the fix was added in 2.1.0 but I am still facing the same issue (Error: 
> Failed taking a screenshot Message: 'geckodriver' executable needs to be in 
> PATH.)
> 
> Can anyone please have a look, Mails are very important feature for Superset.
> 
> 
> Thanks,
> Pankaj
> 
> Internal Use - Confidential
> 
> -Original Message-
> From: Tai Dupree  
> Sent: Friday, March 17, 2023 11:37 PM
> To: dev@superset.apache.org
> Subject: Re: [VOTE] Release Apache Superset 2.1.0 based on Superset 2.1.0rc2
> 
> 
> [EXTERNAL EMAIL] 
> 
> Yes, I was able to receive an email report. You need to use an image tagged 
> with dev, you can try apache/superset:pr-23388-dev.
> 
> On Fri, Mar 17, 2023 at 2:47 AM Soni, Pankaj 
> wrote:
> 
> > Hi,
> > Are you also able to get screenshots in the mail?
> > As per your suggestion I tried your fix from recently pushed image:
> > "apache/superset:e3a7d2014df179088e14a5fc953dc66f69ba0f04-py39"
> > This incorporates the fix for webdriver. I am able to get reports but 
> > still screenshot gives same error "Failed taking a screenshot Message:
> > 'geckodriver' executable needs to be in PATH"
> >
> > Thanks,
> > Pankaj
> >
> >
> > Internal Use - Confidential
> >
> > -Original Message-
> > From: Tai Dupree 
> > Sent: Friday, March 17, 2023 11:50 AM
> > To: dev@superset.apache.org
> > Subject: Re: [VOTE] Release Apache Superset 2.1.0 based on Superset
> > 2.1.0rc2
> >
> >
> > [EXTERNAL EMAIL]
> >
> > I was just able to receive an email report just fine, so I don't think 
> > the issue is with this release (aside from what's addressed in my PR). 
> > That connection timeout error is usually networking/config related. 
> > Are you sure you can reach the superset web server from the worker, 
> > and that smtp is configured correctly?
> >
> > On Thu, Mar 16, 2023 at 10:58 PM multazim deshmukh 
> > 
> > wrote:
> >
> > > Hi Pankaj,
> > >
> > > Can you give more information to understand the root cause.
> > > 1. Did you upgrade to 2.1.0rc2 from a previous version? If so, which 
> > > version?
> > > 2. Did you try Tai’s fix ?
> > > 3. Any details in the log?
> > >
> > > On Friday, March 17, 2023, Pankaj soni 
> > wrote:
> > >
> > > > Sorry to say, but nothing works to fix alert and report.
> > > > Not only screenshot but also simple reports are getting timeout error.
> > > >
> > > > Overall alert and report is completely broken and not working in 
> > > > any
> > way.
> > > >
> > > > Thanks,
> > > > Pankaj
> > > >
> > > > On Thu, 16 Mar, 2023, 06:31 Tai Dupree,  wrote:
> > > >
> > > >> FWIW, here's a fix PR
> > > >> https://urldefense.com/v3/__https://github.com/apache/superset/pu
> > > >> ll 
> > > >> /23388__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p9xz0Kpz_9RjgQsmyMq_
> > > >> Tm Vaf5Y0ZM0tZx08OF9YD4rmT63sjVdu1A$ [github[.]com]
> > > >>
> > > >> On Wed, Mar 15, 2023 at 11:22 AM Tai Dupree 
> > > >> 
> > > wrote:
> > > >>
> > > >> > Hi,
> > > >> >
> > > >> > So for the alerts/reports issue this config needs to be overridden:
> > > >> >
> > > https://urldefense.com/v3/__https://github.com/apache/superset/blob/
> > > da 
> > > 3791ad3daa209631a588394600d1__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p
> > > 9x z0Kpz_9RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63XwZHw3E$ 
> > > [github[.]com]
> > > >> a8b635e814/superset/config.py#L1307
> > > >> >
> > > >> > I suppose these defaults no longer work with the new 
> > > >> > Firefox/webdriver version. They also seem chrome specific too, 
> > > >> > so probably don't make
> > > >> sense
> > > >> > as a default. I don't think this should block the release 
> > > >> > though since
&

Re: [VOTE] Release Apache Superset 2.1.0 based on Superset 2.1.0rc3

[Sam Firke]

+1 non binding

Report emails are working for me with the dev image. Looks good all around. 
Thank you everyone who worked on this release!

On Mon, Mar 20, 2023, at 6:38 PM, Elizabeth Thompson wrote:
> Hello Superset Community,
> 
> This is a call for the vote to release Apache Superset version 2.1.0.
> 
> The release candidate:
> https://dist.apache.org/repos/dist/dev/superset/2.1.0rc3/
> 
> Git tag for the release:
> https://github.com/apache/superset/tree/2.1.0rc3
> 
> The Change Log for the release:
> https://github.com/apache/superset/blob/2.1.0rc3/CHANGELOG.md
> 
> The Updating instructions for the release:
> https://github.com/apache/superset/blob/2.1.0rc3/UPDATING.md
> 
> Public keys are available at:
> https://www.apache.org/dist/superset/KEYS
> 
> The vote will be open for at least 72 hours or until the necessary number
> of votes are reached.
> 
> Please vote accordingly:
> 
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
> 
> Thanks,
> The Apache Superset Team
> 
> 

Re: [VOTE] Release Apache Superset 2.1.0 based on Superset 2.1.0rc2

[Sam Firke]

I can confirm both that:

- my reports broke with 2.1.0rc2, and
- they are now working, including attaching screenshots, using the docker
image with Tai's fixes: apache/superset:pr-23388-dev

I vote -1 on 2.1.0rc2 as it breaks out-of-the-box reporting.  But I think
Tai's PR provides a suitable fix for a next RC.  And I see no other major
problems with rc2 that should hold up release.

Sam

On Fri, Mar 17, 2023 at 2:07 PM Tai Dupree  wrote:

> Yes, I was able to receive an email report. You need to use an image tagged
> with dev, you can try apache/superset:pr-23388-dev.
>
> On Fri, Mar 17, 2023 at 2:47 AM Soni, Pankaj  >
> wrote:
>
> > Hi,
> > Are you also able to get screenshots in the mail?
> > As per your suggestion I tried your fix from recently pushed image:
> > "apache/superset:e3a7d2014df179088e14a5fc953dc66f69ba0f04-py39"
> > This incorporates the fix for webdriver. I am able to get reports but
> > still screenshot gives same error "Failed taking a screenshot Message:
> > 'geckodriver' executable needs to be in PATH"
> >
> > Thanks,
> > Pankaj
> >
> >
> > Internal Use - Confidential
> >
> > -Original Message-
> > From: Tai Dupree 
> > Sent: Friday, March 17, 2023 11:50 AM
> > To: dev@superset.apache.org
> > Subject: Re: [VOTE] Release Apache Superset 2.1.0 based on Superset
> > 2.1.0rc2
> >
> >
> > [EXTERNAL EMAIL]
> >
> > I was just able to receive an email report just fine, so I don't think
> the
> > issue is with this release (aside from what's addressed in my PR). That
> > connection timeout error is usually networking/config related. Are you
> sure
> > you can reach the superset web server from the worker, and that smtp is
> > configured correctly?
> >
> > On Thu, Mar 16, 2023 at 10:58 PM multazim deshmukh 
> > wrote:
> >
> > > Hi Pankaj,
> > >
> > > Can you give more information to understand the root cause.
> > > 1. Did you upgrade to 2.1.0rc2 from a previous version? If so, which
> > > version?
> > > 2. Did you try Tai’s fix ?
> > > 3. Any details in the log?
> > >
> > > On Friday, March 17, 2023, Pankaj soni 
> > wrote:
> > >
> > > > Sorry to say, but nothing works to fix alert and report.
> > > > Not only screenshot but also simple reports are getting timeout
> error.
> > > >
> > > > Overall alert and report is completely broken and not working in any
> > way.
> > > >
> > > > Thanks,
> > > > Pankaj
> > > >
> > > > On Thu, 16 Mar, 2023, 06:31 Tai Dupree, 
> wrote:
> > > >
> > > >> FWIW, here's a fix PR
> > > >> https://urldefense.com/v3/__https://github.com/apache/superset/pull
> > > >> /23388__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p9xz0Kpz_9RjgQsmyMq_Tm
> > > >> Vaf5Y0ZM0tZx08OF9YD4rmT63sjVdu1A$ [github[.]com]
> > > >>
> > > >> On Wed, Mar 15, 2023 at 11:22 AM Tai Dupree 
> > > wrote:
> > > >>
> > > >> > Hi,
> > > >> >
> > > >> > So for the alerts/reports issue this config needs to be
> overridden:
> > > >> >
> > > https://urldefense.com/v3/__https://github.com/apache/superset/blob/da
> > > 3791ad3daa209631a588394600d1__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p9x
> > > z0Kpz_9RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63XwZHw3E$ [github[.]com]
> > > >> a8b635e814/superset/config.py#L1307
> > > >> >
> > > >> > I suppose these defaults no longer work with the new
> > > >> > Firefox/webdriver version. They also seem chrome specific too, so
> > > >> > probably don't make
> > > >> sense
> > > >> > as a default. I don't think this should block the release though
> > > >> > since
> > > >> the
> > > >> > firefox/webdriver is only part of the dev image and not part of
> > > >> > any official release. Maybe we can just add a note in upgrading
> for
> > this.
> > > >> >
> > > >> >
> > > >> >
> > > >> > On Wed, Mar 15, 2023 at 9:00 AM Sam Firke
> > > >> > 
> > > >> wrote:
> > > >> >
> > > >> >> I'm also seeing errors with Alerts and Reports in rc2. Looking
> > > >> >> at the
> > > >> log

Re: [VOTE] Release Apache Superset 2.1.0 based on Superset 2.1.0rc2

[Sam Firke]

 I can confirm both that:

- my reports broke with 2.1.0rc2, and
- they are now working, including attaching screenshots, using the docker
image with Tai's fixes: apache/superset:pr-23388-dev

I vote -1 on 2.1.0rc2 as it breaks out-of-the-box reporting.  But I think
Tai's PR provides a suitable fix for a next RC.  And I see no other major
problems with rc2 that should hold up release.

Sam

On Fri, Mar 17, 2023 at 2:07 PM Tai Dupree  wrote:

> Yes, I was able to receive an email report. You need to use an image tagged
> with dev, you can try apache/superset:pr-23388-dev.
>
> On Fri, Mar 17, 2023 at 2:47 AM Soni, Pankaj  >
> wrote:
>
> > Hi,
> > Are you also able to get screenshots in the mail?
> > As per your suggestion I tried your fix from recently pushed image:
> > "apache/superset:e3a7d2014df179088e14a5fc953dc66f69ba0f04-py39"
> > This incorporates the fix for webdriver. I am able to get reports but
> > still screenshot gives same error "Failed taking a screenshot Message:
> > 'geckodriver' executable needs to be in PATH"
> >
> > Thanks,
> > Pankaj
> >
> >
> > Internal Use - Confidential
> >
> > -Original Message-
> > From: Tai Dupree 
> > Sent: Friday, March 17, 2023 11:50 AM
> > To: dev@superset.apache.org
> > Subject: Re: [VOTE] Release Apache Superset 2.1.0 based on Superset
> > 2.1.0rc2
> >
> >
> > [EXTERNAL EMAIL]
> >
> > I was just able to receive an email report just fine, so I don't think
> the
> > issue is with this release (aside from what's addressed in my PR). That
> > connection timeout error is usually networking/config related. Are you
> sure
> > you can reach the superset web server from the worker, and that smtp is
> > configured correctly?
> >
> > On Thu, Mar 16, 2023 at 10:58 PM multazim deshmukh 
> > wrote:
> >
> > > Hi Pankaj,
> > >
> > > Can you give more information to understand the root cause.
> > > 1. Did you upgrade to 2.1.0rc2 from a previous version? If so, which
> > > version?
> > > 2. Did you try Tai’s fix ?
> > > 3. Any details in the log?
> > >
> > > On Friday, March 17, 2023, Pankaj soni 
> > wrote:
> > >
> > > > Sorry to say, but nothing works to fix alert and report.
> > > > Not only screenshot but also simple reports are getting timeout
> error.
> > > >
> > > > Overall alert and report is completely broken and not working in any
> > way.
> > > >
> > > > Thanks,
> > > > Pankaj
> > > >
> > > > On Thu, 16 Mar, 2023, 06:31 Tai Dupree, 
> wrote:
> > > >
> > > >> FWIW, here's a fix PR
> > > >> https://urldefense.com/v3/__https://github.com/apache/superset/pull
> > > >> /23388__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p9xz0Kpz_9RjgQsmyMq_Tm
> > > >> Vaf5Y0ZM0tZx08OF9YD4rmT63sjVdu1A$ [github[.]com]
> > > >>
> > > >> On Wed, Mar 15, 2023 at 11:22 AM Tai Dupree 
> > > wrote:
> > > >>
> > > >> > Hi,
> > > >> >
> > > >> > So for the alerts/reports issue this config needs to be
> overridden:
> > > >> >
> > > https://urldefense.com/v3/__https://github.com/apache/superset/blob/da
> > > 3791ad3daa209631a588394600d1__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p9x
> > > z0Kpz_9RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63XwZHw3E$ [github[.]com]
> > > >> a8b635e814/superset/config.py#L1307
> > > >> >
> > > >> > I suppose these defaults no longer work with the new
> > > >> > Firefox/webdriver version. They also seem chrome specific too, so
> > > >> > probably don't make
> > > >> sense
> > > >> > as a default. I don't think this should block the release though
> > > >> > since
> > > >> the
> > > >> > firefox/webdriver is only part of the dev image and not part of
> > > >> > any official release. Maybe we can just add a note in upgrading
> for
> > this.
> > > >> >
> > > >> >
> > > >> >
> > > >> > On Wed, Mar 15, 2023 at 9:00 AM Sam Firke
> > > >> > 
> > > >> wrote:
> > > >> >
> > > >> >> I'm also seeing errors with Alerts and Reports in rc2. Looking
> > > >> >> at the
> > > >> log

Re: [VOTE] Release Apache Superset 2.1.0 based on Superset 2.1.0rc2

[Sam Firke]

I'm also seeing errors with Alerts and Reports in rc2. Looking at the logs
it appears to be this issue: https://github.com/apache/superset/issues/22326

On Wed, Mar 15, 2023, 5:27 AM Pankaj soni  wrote:

> Not able to send alerts, screenshot as alerts and reports as well.
>
> On Wed, 15 Mar, 2023, 14:42 Pankaj soni, 
> wrote:
>
> > -1: Alert & Report section is completely broken as no mails, screenshots
> > are triggered due to error mentioned in image
> >
> > On Tue, 14 Mar, 2023, 07:05 Elizabeth Thompson,
> >  wrote:
> >
> >> Hello Superset Community,
> >>
> >> This is a call for the vote to release Apache Superset version 2.1.0.
> >>
> >> The release candidate:
> >> https://dist.apache.org/repos/dist/dev/superset/2.1.0rc2/
> >>
> >> Git tag for the release:
> >> https://github.com/apache/superset/tree/2.1.0rc2
> >>
> >> The Change Log for the release:
> >> https://github.com/apache/superset/blob/2.1.0rc2/CHANGELOG.md
> >>
> >> The Updating instructions for the release:
> >> https://github.com/apache/superset/blob/2.1.0rc2/UPDATING.md
> >>
> >> Public keys are available at:
> >> https://www.apache.org/dist/superset/KEYS
> >>
> >> The vote will be open for at least 72 hours or until the necessary
> number
> >> of votes are reached.
> >>
> >> Please vote accordingly:
> >>
> >> [ ] +1 approve
> >> [ ] +0 no opinion
> >> [ ] -1 disapprove with the reason
> >>
> >> Thanks,
> >> The Apache Superset Team
> >>
> >>
>

Re: [VOTE] Release Apache Superset 2.1.0 based on Superset 2.1.0rc2

[Sam Firke]

I've put my testing notes here:
https://github.com/apache/superset/discussions/23357#discussioncomment-5314068

Would love to hear from others who are testing. Looking good, my thanks to
those who worked on rc2 and patched bugs since rc1 !

On Mon, Mar 13, 2023, 9:36 PM Elizabeth Thompson
 wrote:

> Hello Superset Community,
>
> This is a call for the vote to release Apache Superset version 2.1.0.
>
> The release candidate:
> https://dist.apache.org/repos/dist/dev/superset/2.1.0rc2/
>
> Git tag for the release:
> https://github.com/apache/superset/tree/2.1.0rc2
>
> The Change Log for the release:
> https://github.com/apache/superset/blob/2.1.0rc2/CHANGELOG.md
>
> The Updating instructions for the release:
> https://github.com/apache/superset/blob/2.1.0rc2/UPDATING.md
>
> Public keys are available at:
> https://www.apache.org/dist/superset/KEYS
>
> The vote will be open for at least 72 hours or until the necessary number
> of votes are reached.
>
> Please vote accordingly:
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> Thanks,
> The Apache Superset Team
>
>

Re: [VOTE] Release Apache Superset 2.1.0 based on Superset 2.1.0rc1

[Sam Firke]

Same here, dashboards with filters out of scope fail to load.  I've noted
that on the discussion thread
https://github.com/apache/superset/discussions/23164.

I'll keep testing the release and will post my findings in that thread but
IMO this is the biggest bug in Superset 2.0.1 and I would vote -1.

I'll say though I'm enjoying a lot of the new features as I test!

It would be helpful to hear from more voters what they've tested.

Sam

On Fri, Feb 24, 2023, 8:06 AM Dan  wrote:

> I vote +1 approve
>
> I've installed and tested locally. All our dashboards work as before.
>
> I do still have an outstanding issue with dashboards not loading on first
> attempt which i thought was:
>
> https://github.com/apache/superset/pull/21576
>
> But I guess that doesn't fix my issue.
>
> On Thu, 23 Feb 2023 at 00:43, Elizabeth Thompson
>  wrote:
>
> > Hello Superset Community,
> >
> > This is a call for the vote to release Apache Superset version 2.1.0.
> >
> > The release candidate:
> > https://dist.apache.org/repos/dist/dev/superset/2.1.0rc1/
> >
> > Git tag for the release:
> > https://github.com/apache/superset/tree/2.1.0rc1
> >
> > The Change Log for the release:
> > https://github.com/apache/superset/blob/2.1.0rc1/CHANGELOG.md
> >
> > The Updating instructions for the release:
> > https://github.com/apache/superset/blob/2.1.0rc1/UPDATING.md
> >
> > Public keys are available at:
> > https://www.apache.org/dist/superset/KEYS
> >
> > The vote will be open for at least 72 hours or until the necessary number
> > of votes are reached.
> >
> > Please vote accordingly:
> >
> > [ ] +1 approve
> > [ ] +0 no opinion
> > [ ] -1 disapprove with the reason
> >
> > Thanks,
> > The Apache Superset Team
> >
> >
>

Re: [VOTE] Release Apache Superset 2.0.1 based on Superset 2.0.1rc6

[Sam Firke]

+1

I looked at some of the new features/bug fixes and they looked good. I
tried out some of my major existing dashboards and found no problems.

On Tue, Dec 20, 2022, 11:18 AM Daniel Gaspar  wrote:

> +1 (binding)
>
> Daniel Gaspar / Superset PMC
>
> On 2022/12/16 01:48:07 Elizabeth Thompson wrote:
> > Hello Superset Community,
> >
> > This is a call for the vote to release Apache Superset version 2.0.1.
> >
> > The release candidate:
> > https://dist.apache.org/repos/dist/dev/superset/2.0.1rc6/
> >
> > Git tag for the release:
> > https://github.com/apache/superset/tree/2.0.1rc6
> >
> > The Change Log for the release:
> > https://github.com/apache/superset/blob/2.0.1rc6/CHANGELOG.md
> >
> > The Updating instructions for the release:
> > https://github.com/apache/superset/blob/2.0.1rc6/UPDATING.md
> >
> > Public keys are available at:
> > https://www.apache.org/dist/superset/KEYS
> >
> > The vote will be open for at least 72 hours or until the necessary number
> > of votes are reached.
> >
> > Please vote accordingly:
> >
> > [ ] +1 approve
> > [ ] +0 no opinion
> > [ ] -1 disapprove with the reason
> >
> > Thanks,
> > The Apache Superset Team
> >
> >
>

Re: [VOTE] Release Apache Superset 2.0.1 based on Superset 2.0.1rc5

[Sam Firke]

Would it be possible to push docker images for 2.01rc5 and 2.01rc5-dev to
Docker Hub, as was done with 2.0.1rc4?  That would make it easier for me to
test out this release candidate next week.

Thanks,

Sam

On Fri, Dec 9, 2022 at 5:11 PM Arash Afghahi 
wrote:

> Hello Superset Community,
>
> This is a call for the vote to release Apache Superset version 2.0.1.
>
> The release candidate:
> https://dist.apache.org/repos/dist/dev/superset/2.0.1rc5/
>
> Git tag for the release:
> https://github.com/apache/superset/tree/2.0.1rc5
>
> The Change Log for the release:
> https://github.com/apache/superset/blob/2.0.1rc5/CHANGELOG.md
>
> The Updating instructions for the release:
> https://github.com/apache/superset/blob/2.0.1rc5/UPDATING.md
>
> Public keys are available at:
> https://www.apache.org/dist/superset/KEYS
>
> The vote will be open for at least 72 hours or until the necessary number
> of votes are reached.
>
> Please vote accordingly:
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> Thanks,
> The Apache Superset Team
>